SocialConnect\OAuth2\Provider\Vk

Complexity

Total Complexity

12

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

96%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getBaseUri()	0	4	1
A	getAuthorizeUri()	0	4	1
A	getRequestTokenUri()	0	4	1
A	getName()	0	4	1
A	parseToken()	0	13	3
B	getIdentity()	0	50	5

<?php
/**
 * SocialConnect project
 * @author: Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace SocialConnect\OAuth2\Provider;

use SocialConnect\Provider\AccessTokenInterface;
use SocialConnect\Provider\Exception\InvalidAccessToken;
use SocialConnect\Provider\Exception\InvalidResponse;
use SocialConnect\OAuth2\AccessToken;
use SocialConnect\Common\Entity\User;
use SocialConnect\Common\Http\Client\Client;
use SocialConnect\Common\Hydrator\ObjectMap;

class Vk extends \SocialConnect\OAuth2\AbstractProvider
{
    /**
     * {@inheritdoc}
     */
    protected $requestHttpMethod = Client::GET;

    /**
     * Vk returns email inside AccessToken
     *
     * @var string|null
     */
    protected $email;

    public function getBaseUri()
    {
        return 'https://api.vk.com/';
    }

    public function getAuthorizeUri()
    {
        return 'https://oauth.vk.com/authorize';
    }

    public function getRequestTokenUri()
    {
        return 'https://oauth.vk.com/access_token';
    }

    public function getName()
    {
        return 'vk';
    }

    /**
     * {@inheritdoc}
     */
    public function parseToken($body)
    {
        $result = json_decode($body, true);
        if (!$result) {
            throw new InvalidAccessToken;
        }

        if (isset($result['email'])) {
            $this->email = $result['email'];
        }

        return new AccessToken($result);
    }

    /**
     * {@inheritdoc}
     */
    public function getIdentity(AccessTokenInterface $accessToken)
    {
        $response = $this->httpClient->request(
            $this->getBaseUri() . 'method/users.get',
            [
                'v' => '5.24',
                'access_token' => $accessToken->getToken(),
                'fields' => $this->getFieldsInline()
            ]
        );

        if (!$response->isSuccess()) {
            throw new InvalidResponse(
                'API response with error code',
                $response
            );
        }

        $result = $response->json();
        if (!$result) {
            throw new InvalidResponse(
                'API response is not a valid JSON object',
                $response->getBody()
            );
        }

        $hydrator = new ObjectMap(
            [
                'id' => 'id',
                'first_name' => 'firstname',
                'last_name' => 'lastname',
                'email' => 'email',
                'bdate' => 'birthday',
                'nickname' => 'username',
                'sex' => 'sex',
            ]
        );

        /** @var User $user */
        $user = $hydrator->hydrate(new User(), $result->response[0]);

        if ($user->sex) {

The expression $user->sex of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $user->sex = $user->sex === 1 ? 'female' : 'male';

The strict comparison === seems to always evaluate to false as the types of $user->sex (string) and 1 (integer) can never be identical. Maybe you want to use a loose comparison == instead?

        }

        $user->email = $this->email;
        $user->emailVerified = true;

        return $user;
    }
}