Vk::getBaseUri() - Code Metrics - Inspection of "[OAuth2] Facebook\Google\Vk - setup emailVerified..." - SocialConnect/auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d2cebe...dfbba4 )

by Дмитрий

created 2017-02-21 07:57 UTC

Vk::getBaseUri() A

↳ Parent: Vk

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php
/**
 * SocialConnect project
 * @author: Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace SocialConnect\OAuth2\Provider;

use SocialConnect\Provider\AccessTokenInterface;
use SocialConnect\Provider\Exception\InvalidAccessToken;
use SocialConnect\Provider\Exception\InvalidResponse;
use SocialConnect\OAuth2\AccessToken;
use SocialConnect\Common\Entity\User;
use SocialConnect\Common\Http\Client\Client;
use SocialConnect\Common\Hydrator\ObjectMap;

class Vk extends \SocialConnect\OAuth2\AbstractProvider
{
    /**
     * {@inheritdoc}
     */
    protected $requestHttpMethod = Client::GET;

    /**
     * Vk returns email inside AccessToken
     *
     * @var string|null
     */
    protected $email;

    public function getBaseUri()
    {
        return 'https://api.vk.com/';
    }

    public function getAuthorizeUri()
    {
        return 'https://oauth.vk.com/authorize';
    }

    public function getRequestTokenUri()
    {
        return 'https://oauth.vk.com/access_token';
    }

    public function getName()
    {
        return 'vk';
    }

    /**
     * {@inheritdoc}
     */
    public function parseToken($body)
    {
        $result = json_decode($body, true);
        if (!$result) {
            throw new InvalidAccessToken;
        }

        if (isset($result['email'])) {
            $this->email = $result['email'];
        }

        return new AccessToken($result);
    }

    /**
     * {@inheritdoc}
     */
    public function getIdentity(AccessTokenInterface $accessToken)
    {
        $response = $this->httpClient->request(
            $this->getBaseUri() . 'method/users.get',
            [
                'v' => '5.24',
                'access_token' => $accessToken->getToken(),
                'fields' => $this->getFieldsInline()
            ]
        );

        if (!$response->isSuccess()) {
            throw new InvalidResponse(
                'API response with error code',
                $response
            );
        }

        $result = $response->json();
        if (!$result) {
            throw new InvalidResponse(
                'API response is not a valid JSON object',
                $response->getBody()
            );
        }

        $hydrator = new ObjectMap(
            [
                'id' => 'id',
                'first_name' => 'firstname',
                'last_name' => 'lastname',
                'email' => 'email',
                'bdate' => 'birthday',
                'nickname' => 'username',
                'sex' => 'sex',
            ]
        );

        /** @var User $user */
        $user = $hydrator->hydrate(new User(), $result->response[0]);

        if ($user->sex) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $user->sex = $user->sex === 1 ? 'female' : 'male';

        }

        $user->email = $this->email;
        $user->emailVerified = true;

        return $user;
    }
}


1		<?php
2		/**
3		* SocialConnect project
4		* @author: Patsura Dmitry https://github.com/ovr <[email protected]>
5		*/
6
7		namespace SocialConnect\OAuth2\Provider;
8
9		use SocialConnect\Provider\AccessTokenInterface;
10		use SocialConnect\Provider\Exception\InvalidAccessToken;
11		use SocialConnect\Provider\Exception\InvalidResponse;
12		use SocialConnect\OAuth2\AccessToken;
13		use SocialConnect\Common\Entity\User;
14		use SocialConnect\Common\Http\Client\Client;
15		use SocialConnect\Common\Hydrator\ObjectMap;
16
17		class Vk extends \SocialConnect\OAuth2\AbstractProvider
18		{
19		/**
20		* {@inheritdoc}
21		*/
22		protected $requestHttpMethod = Client::GET;
23
24		/**
25		* Vk returns email inside AccessToken
26		*
27		* @var string\|null
28		*/
29		protected $email;
30
31	5	public function getBaseUri()
32		{
33	5	return 'https://api.vk.com/';
34		}
35
36	2	public function getAuthorizeUri()
37		{
38	2	return 'https://oauth.vk.com/authorize';
39		}
40
41	3	public function getRequestTokenUri()
42		{
43	3	return 'https://oauth.vk.com/access_token';
44		}
45
46	4	public function getName()
47		{
48	4	return 'vk';
49		}
50
51		/**
52		* {@inheritdoc}
53		*/
54	3	public function parseToken($body)
55		{
56	3	$result = json_decode($body, true);
57	3	if (!$result) {
58	2	throw new InvalidAccessToken;
59		}
60
61	1	if (isset($result['email'])) {
62		$this->email = $result['email'];
63		}
64
65	1	return new AccessToken($result);
66		}
67
68		/**
69		* {@inheritdoc}
70		*/
71	4	public function getIdentity(AccessTokenInterface $accessToken)
72		{
73	4	$response = $this->httpClient->request(
74	4	$this->getBaseUri() . 'method/users.get',
75		[
76	4	'v' => '5.24',
77	4	'access_token' => $accessToken->getToken(),
78	4	'fields' => $this->getFieldsInline()
79	4	]
80	4	);
81
82	4	if (!$response->isSuccess()) {
83	1	throw new InvalidResponse(
84	1	'API response with error code',
85		$response
86	1	);
87		}
88
89	3	$result = $response->json();
90	3	if (!$result) {
91	2	throw new InvalidResponse(
92	2	'API response is not a valid JSON object',
93	2	$response->getBody()
94	2	);
95		}
96
97	1	$hydrator = new ObjectMap(
98		[
99	1	'id' => 'id',
100	1	'first_name' => 'firstname',
101	1	'last_name' => 'lastname',
102	1	'email' => 'email',
103	1	'bdate' => 'birthday',
104	1	'nickname' => 'username',
105	1	'sex' => 'sex',
106		]
107	1	);
108
109		/** @var User $user */
110	1	$user = $hydrator->hydrate(new User(), $result->response[0]);
111
112	1	if ($user->sex) {
		1 ignored issue – show Bug Best Practice introduced 2017-02-21 08:09 UTC by Report Bug Copy Issue Report The expression `$user->sex` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
113	1	$user->sex = $user->sex === 1 ? 'female' : 'male';
		1 ignored issue – show Unused Code Bug introduced 2017-02-21 08:09 UTC by Report Bug Copy Issue Report The strict comparison `===` seems to always evaluate to `false` as the types of `$user->sex` (`string`) and `1` (`integer`) can never be identical. Maybe you want to use a loose comparison `==` instead? Loading history...
114	1	}
115
116	1	$user->email = $this->email;
117	1	$user->emailVerified = true;
118
119	1	return $user;
120		}
121		}
122

SocialConnect / auth

Push — master ( d2cebe...dfbba4 )

Vk::getBaseUri() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like