SmartGecko / GovernorFramework

src/Governor/Framework/CommandHandling/Distributed/CommandReceiver.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 namespace Governor\Framework\CommandHandling\Distributed;
 
 use Governor\Framework\CommandHandling\Callbacks\ClosureCommandCallback;
-use Governor\Framework\CommandHandling\Callbacks\ResultCallback;
 use Governor\Framework\Common\ReceiverInterface;
 use Governor\Framework\CommandHandling\CommandBusInterface;
 use Governor\Framework\Serializer\SerializerInterface;

Spacing +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
         $dispatchMessage = DispatchMessage::fromBytes($this->serializer, $data[1]);
         $self = $this;
 
-        $successCallback = function ($result) use ($dispatchMessage, $self) {
+        $successCallback = function($result) use ($dispatchMessage, $self) {
             $message = new ReplyMessage(
                 $dispatchMessage->getCommandIdentifier(),
                 $self->serializer,
@@ -114,7 +114,7 @@ 
             $self->template->writeCommandReply($dispatchMessage->getCommandIdentifier(), $message->toBytes());
         };
 
-        $failureCallback = function (\Exception $cause) use ($dispatchMessage, $self) {
+        $failureCallback = function(\Exception $cause) use ($dispatchMessage, $self) {
             $message = new ReplyMessage(
                 $dispatchMessage->getCommandIdentifier(),
                 $self->serializer,

src/Governor/Framework/CommandHandling/Distributed/DistributedCommandBus.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 namespace Governor\Framework\CommandHandling\Distributed;
 
-use Governor\Framework\CommandHandling\Callbacks\NoOpCallback;
 use Governor\Framework\CommandHandling\CommandBusInterface;
 use Governor\Framework\CommandHandling\CommandCallbackInterface;
 use Governor\Framework\CommandHandling\CommandHandlerInterface;

Spacing +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
             $this->connector->send($routingKey, $command, $callback);
         } catch (\Exception $ex) {
             $this->logger->error(
-                self::DISPATCH_ERROR_MESSAGE.' {err}',
+                self::DISPATCH_ERROR_MESSAGE . ' {err}',
                 [
                     'err' => $ex->getMessage()
                 ]

src/Governor/Framework/CommandHandling/Distributed/RedisTemplate.php

Doc Comments +8 added lines, -1 removed lines

@@ -143,7 +143,7 @@ 
 
     /**
      * @param string $commandIdentifier
-     * @param mixed $reply
+     * @param string $reply
      */
     public function writeCommandReply($commandIdentifier, $reply)
     {
@@ -200,11 +200,18 @@ 
         );
     }
 
+    /**
+     * @param string $commandName
+     */
     public static function hashCommandName($commandName)
     {
         return hash('md5', $commandName);
     }
 
+    /**
+     * @param string $commandName
+     * @param string $routingKey
+     */
     public static function hashCommandRouting($commandName, $routingKey)
     {
         return hash('md5', sprintf('%s-%s', $commandName, $routingKey));

src/Governor/Framework/CommandHandling/Handlers/AnnotatedAggregateCommandHandler.php

Unused Use Statements +9 added lines, -9 removed lines

@@ -24,15 +24,15 @@
 

 namespace Governor\Framework\CommandHandling\Handlers;

 

-use Governor\Framework\Common\Annotation\AnnotationReaderFactoryInterface;

-use Governor\Framework\Annotations\CommandHandler;

-use Governor\Framework\Common\ParameterResolverFactoryInterface;

-use Governor\Framework\Common\Annotation\MethodMessageHandlerInspector;

-use Governor\Framework\CommandHandling\CommandBusInterface;

-use Governor\Framework\CommandHandling\CommandMessageInterface;

-use Governor\Framework\CommandHandling\CommandTargetResolverInterface;

-use Governor\Framework\CommandHandling\AnnotationCommandTargetResolver;

-use Governor\Framework\UnitOfWork\UnitOfWorkInterface;

+use Governor\Framework\Common\Annotation\AnnotationReaderFactoryInterface;
+use Governor\Framework\Annotations\CommandHandler;
+use Governor\Framework\Common\ParameterResolverFactoryInterface;
+use Governor\Framework\Common\Annotation\MethodMessageHandlerInspector;
+use Governor\Framework\CommandHandling\CommandBusInterface;
+use Governor\Framework\CommandHandling\CommandMessageInterface;
+use Governor\Framework\CommandHandling\CommandTargetResolverInterface;
+use Governor\Framework\CommandHandling\AnnotationCommandTargetResolver;
+use Governor\Framework\UnitOfWork\UnitOfWorkInterface;
 use Governor\Framework\Repository\RepositoryInterface;

 

 /**

src/Governor/Framework/Common/AnnotatedMetaDataParameterResolver.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         return $message->getMetaData()->get($this->getKey());

     }

 

+    /**
+     * @return string
+     */
     private function getKey()

     {

         // !!! TODO check types on primitives ?

Unused Use Statements +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 

 namespace Governor\Framework\Common;

 

-use Governor\Framework\Domain\MessageInterface;

+use Governor\Framework\Domain\MessageInterface;
 use Governor\Framework\Annotations\MetaData;

 /**

  * Description of AnnotatedMetaDataParameterResolver

Indentation +3 added lines, -3 removed lines

@@ -39,9 +39,9 @@
      */

     private $annotation;

     

-     /**

-     * @var \ReflectionParameter 

-     */

+        /**

+         * @var \ReflectionParameter 

+         */

     private $parameter;

     

     public function __construct(MetaData $annotation, \ReflectionParameter $parameter) 

src/Governor/Framework/Common/Annotation/MethodMessageHandlerInspector.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 

 namespace Governor\Framework\Common\Annotation;

 

-use Doctrine\Common\Annotations\Reader;

+use Doctrine\Common\Annotations\Reader;
 use Governor\Framework\Common\ReflectionUtils;

 

 /**

src/Governor/Framework/EventHandling/InMemoryEventListenerRegistry.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     /**
      * Returns an array of registered EventListenerInterface-s.
      *
-     * @return \SplObjectStorage|EventListenerInterface[]
+     * @return \SplObjectStorage
      */
     public function getListeners()
     {

Indentation +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@
 <?php
 /**
- * This file is part of the SmartGecko(c) business platform.
- *
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+     * This file is part of the SmartGecko(c) business platform.
+     *
+     * For the full copyright and license information, please view the LICENSE
+     * file that was distributed with this source code.
+     */
 
 namespace Governor\Framework\EventStore\Mongo;
 

src/Governor/Framework/EventHandling/Listeners/AnnotatedEventListener.php

Doc Comments +3 added lines

@@ -41,6 +41,9 @@
     private $methodName;
     private $eventTarget;
 
+    /**
+     * @param string $eventName
+     */
     function __construct($eventName, $methodName, $eventTarget)
     {
         $this->eventName = $eventName;

src/Governor/Framework/EventSourcing/EventSourcingRepository.php

Doc Comments +3 added lines

@@ -129,6 +129,9 @@
         $this->eventStore->appendEvents($this->getTypeIdentifier(), $eventStream);
     }
 
+    /**
+     * @param string $className
+     */
     private function validateEventSourcedAggregate($className)
     {
         $reflClass = new \ReflectionClass($className);