SmartGecko / GovernorFramework

src/Governor/Framework/Saga/Repository/Orm/OrmSagaRepository.php

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 
 use Psr\Log\LoggerInterface;
 use Psr\Log\LoggerAwareInterface;
-use Doctrine\ORM\Query;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\NoResultException;
 use Governor\Framework\Saga\Repository\AbstractSagaRepository;

Spacing +11 added lines, -11 removed lines

@@ -132,11 +132,11 @@ 
         $sagaIdentifier
     ) {
         $updateCount = $this->entityManager->createQuery(
-            "DELETE FROM ".
-            " Governor\Framework\Saga\Repository\Orm\AssociationValueEntry ae ".
-            "WHERE ae.associationKey = :associationKey ".
-            "AND ae.associationValue = :associationValue ".
-            "AND ae.sagaType = :sagaType ".
+            "DELETE FROM " .
+            " Governor\Framework\Saga\Repository\Orm\AssociationValueEntry ae " .
+            "WHERE ae.associationKey = :associationKey " .
+            "AND ae.associationValue = :associationValue " .
+            "AND ae.sagaType = :sagaType " .
             "AND ae.sagaId = :sagaId"
         )
             ->setParameters(
@@ -190,10 +190,10 @@ 
         AssociationValue $associationValue
     ) {
         $entries = $this->entityManager->createQuery(
-            "SELECT ae.sagaId FROM ".
-            "Governor\Framework\Saga\Repository\Orm\AssociationValueEntry ae ".
-            "WHERE ae.associationKey = :associationKey ".
-            "AND ae.associationValue = :associationValue ".
+            "SELECT ae.sagaId FROM " .
+            "Governor\Framework\Saga\Repository\Orm\AssociationValueEntry ae " .
+            "WHERE ae.associationKey = :associationKey " .
+            "AND ae.associationValue = :associationValue " .
             "AND ae.sagaType = :sagaType"
         )
             ->setParameters(
@@ -238,8 +238,8 @@ 
         );
 
         $updateCount = $this->entityManager->createQuery(
-            "UPDATE Governor\Framework\Saga\Repository\Orm\SagaEntry s ".
-            "SET s.serializedSaga = :serializedSaga, s.revision = :revision ".
+            "UPDATE Governor\Framework\Saga\Repository\Orm\SagaEntry s " .
+            "SET s.serializedSaga = :serializedSaga, s.revision = :revision " .
             "WHERE s.sagaId = :sagaId AND s.sagaType = :sagaType"
         )
             ->setParameters(

src/Governor/Framework/Serializer/MessageSerializer.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 namespace Governor\Framework\Serializer;
 
 use Governor\Framework\Domain\MessageInterface;
-use Governor\Framework\Domain\MetaData;
 
 /**
  * Description of MessageSerializer

src/Governor/Framework/Serializer/SimpleSerializedType.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     }
 
     /**
-     * @return null|string
+     * @return string
      */
     public function getRevision()
     {

src/Governor/Framework/Test/GivenWhenThenTestFixture.php

Doc Comments +6 added lines

@@ -592,6 +592,9 @@ 
     private $givenEvents;
     private $aggregateIdentifier;
 
+    /**
+     * @param string $aggregateIdentifier
+     */
     public function __construct(
         array &$storedEvents,
         array &$givenEvents,
@@ -703,6 +706,9 @@ 
 {
     private $workingAggregate;
 
+    /**
+     * @param AggregateRootInterface $workingAggregate
+     */
     function __construct(&$workingAggregate)
     {
         $this->workingAggregate = &$workingAggregate;

Spacing +14 added lines, -14 removed lines

@@ -241,9 +241,9 @@ 
     {
         if ($this->explicitCommandHandlersSet) {
             throw new FixtureExecutionException(
-                "Cannot inject resources after command handler has been created. ".
-                "Configure all resource before calling ".
-                "registerCommandHandler() or ".
+                "Cannot inject resources after command handler has been created. " .
+                "Configure all resource before calling " .
+                "registerCommandHandler() or " .
                 "registerAnnotatedCommandHandler()"
             );
         }
@@ -383,9 +383,9 @@ 
                 $aggregate2 = $this->repository->load($this->aggregateIdentifier);
                 if ($this->workingAggregate->isDeleted()) {
                     throw new GovernorAssertionError(
-                        "The working aggregate was considered deleted, ".
-                        "but the Repository still contains a non-deleted copy of ".
-                        "the aggregate. Make sure the aggregate explicitly marks ".
+                        "The working aggregate was considered deleted, " .
+                        "but the Repository still contains a non-deleted copy of " .
+                        "the aggregate. Make sure the aggregate explicitly marks " .
                         "itself as deleted in an EventHandler."
                     );
                 }
@@ -393,8 +393,8 @@ 
             } catch (AggregateNotFoundException $notFound) {
                 if (!$this->workingAggregate->isDeleted()) {
                     throw new GovernorAssertionError(
-                        "The working aggregate was not considered deleted, ".
-                        "but the Repository cannot recover the state of the ".
+                        "The working aggregate was not considered deleted, " .
+                        "but the Repository cannot recover the state of the " .
                         "aggregate, as it is considered deleted there."
                     );
                 }
@@ -537,8 +537,8 @@ 
         if (null !== $aggregateIdentifier && !$aggregateIdentifier === $aggregate->getIdentifier()) {
             throw new \RuntimeException(
                 sprintf(
-                    "The aggregate used in this fixture was initialized with an identifier different than ".
-                    "the one used to load it. Loaded [%s], but actual identifier is [%s].\n".
+                    "The aggregate used in this fixture was initialized with an identifier different than " .
+                    "the one used to load it. Loaded [%s], but actual identifier is [%s].\n" .
                     "Make sure the identifier passed in the Command matches that of the given Events.",
                     $aggregateIdentifier,
                     $aggregate->getIdentifier()
@@ -613,14 +613,14 @@ 
 
                 if ($lastEvent->getAggregateIdentifier() !== $next->getAggregateIdentifier()) {
                     throw new EventStoreException(
-                        "Writing events for an unexpected aggregate. This could ".
+                        "Writing events for an unexpected aggregate. This could " .
                         "indicate that a wrong aggregate is being triggered."
                     );
                 } else {
                     if ($lastEvent->getScn() !== $next->getScn() - 1) {
                         throw new EventStoreException(
                             sprintf(
-                                "Unexpected sequence number on stored event. ".
+                                "Unexpected sequence number on stored event. " .
                                 "Expected %s, but got %s.",
                                 $lastEvent->getScn() + 1,
                                 $next->getScn()
@@ -647,7 +647,7 @@ 
 
         if (null !== $this->aggregateIdentifier && $this->aggregateIdentifier !== $identifier) {
             throw new EventStoreException(
-                "You probably want to use aggregateIdentifier() on your fixture ".
+                "You probably want to use aggregateIdentifier() on your fixture " .
                 "to get the aggregate identifier to use"
             );
         } else {
@@ -663,7 +663,7 @@ 
         if (empty($allEvents)) {
             throw new AggregateNotFoundException(
                 $identifier,
-                "No 'given' events were configured for this aggregate, ".
+                "No 'given' events were configured for this aggregate, " .
                 "nor have any events been stored."
             );
         }

src/Governor/Framework/Test/Utils/RecordingEventBus.php

Doc Comments +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
     private $eventListenerRegistry;
 
     /**
-     * @param array $publishedEvents
+     * @param EventMessageInterface[] $publishedEvents
      */
     public function __construct(array &$publishedEvents)
     {
@@ -74,7 +74,7 @@ 
     /**
      * Returns the EventListenerRegistryInterface of this EventBus.
      *
-     * @return EventListenerRegistryInterface
+     * @return EventListenerRegistryInterface[]
      */
     public function getEventListenerRegistry()
     {

src/Governor/Framework/UnitOfWork/DefaultUnitOfWork.php

Doc Comments +3 added lines

@@ -182,6 +182,9 @@
         $this->listeners->add($listener);
     }
 
+    /**
+     * @param string $aggregateType
+     */
     private function findSimilarAggregate($aggregateType, $identifier)
     {
         foreach ($this->registeredAggregates as $hash => $aggregateEntry) {

Spacing +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
         if (null !== $similarAggregate) {
 
             $this->logger->info(
-                "Ignoring aggregate registration. An aggregate of same type and identifier was already".
+                "Ignoring aggregate registration. An aggregate of same type and identifier was already" .
                 "registered in this Unit Of Work: type [{aggregate}], identifier [{identifier}]",
                 array('aggregate' => get_class($aggregateRoot), 'identifier' => $aggregateRoot->getIdentifier())
             );
@@ -153,7 +153,7 @@ 
 
         $uow = $this;
         $eventRegistrationCallback = new UoWEventRegistrationCallback(
-            function (DomainEventMessageInterface $event) use ($uow, $eventBus) {
+            function(DomainEventMessageInterface $event) use ($uow, $eventBus) {
                 $event = $uow->invokeEventRegistrationListeners($event);
                 $uow->eventsToPublishOn($event, $eventBus);
 
@@ -234,7 +234,7 @@ 
         if ($this->dispatcherStatus == self::STATUS_DISPATCHING) {
             // this prevents events from overtaking each other
             $this->logger->debug(
-                "UnitOfWork is already in the dispatch process. ".
+                "UnitOfWork is already in the dispatch process. " .
                 "That process will publish events instead. Aborting..."
             );
 

src/Governor/Framework/UnitOfWork/NestableUnitOfWork.php

Doc Comments +3 added lines, -3 removed lines

@@ -291,9 +291,9 @@
     private $rollbackClosure;
 
     /**
-     * @param callable $commitClosure
-     * @param callable $cleanupClosure
-     * @param callable $rollbackClosure
+     * @param \Closure $commitClosure
+     * @param \Closure $cleanupClosure
+     * @param \Closure $rollbackClosure
      */
     function __construct(
         \Closure $commitClosure,

Spacing +3 added lines, -3 removed lines

@@ -116,13 +116,13 @@
                 $this->outerUnitOfWork->registerInnerUnitOfWork($this);
             } else {
                 $listener = new CommitOnOuterCommitTask(
-                    function (UnitOfWorkInterface $uow) {
+                    function(UnitOfWorkInterface $uow) {
                         $this->performInnerCommit();
                     },
-                    function (UnitOfWorkInterface $uow) {
+                    function(UnitOfWorkInterface $uow) {
                         $this->performCleanup();
                     },
-                    function (UnitOfWorkInterface $uow, \Exception $ex = null) {
+                    function(UnitOfWorkInterface $uow, \Exception $ex = null) {
                         CurrentUnitOfWork::set($this);
                         $this->rollback($ex);
                     }

src/Governor/Framework/CommandHandling/AnnotationCommandTargetResolver.php

Spacing +2 added lines, -2 removed lines

@@ -67,8 +67,8 @@
         if (null === $id) {
             throw new \InvalidArgumentException(
                 sprintf(
-                    "Invalid command. It does not identify the target aggregate. ".
-                    "Make sure at least one of the fields or methods in the [%s] class contains the ".
+                    "Invalid command. It does not identify the target aggregate. " .
+                    "Make sure at least one of the fields or methods in the [%s] class contains the " .
                     "@TargetAggregateIdentifier annotation and that it returns a non-null value.",
                     $command->getPayloadType()
                 )

src/Governor/Framework/CommandHandling/CommandDispatchInterceptorInterface.php

Indentation +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
  */
 interface CommandDispatchInterceptorInterface
 {
-   /**
+    /**
      * Invoked each time a command is about to be dispatched on a Command Bus. The given <code>commandMessage</code>
      * represents the command being dispatched.
      *