SiroDiaz / Routify

Routify/Order.php

Doc Comments +3 added lines, -3 removed lines

@@ -43,7 +43,7 @@ 
     /**
      * Returns the uri(the pattern path).
      *
-     * @return mixed
+     * @return string
      */
 
     public function getUri() {
@@ -53,7 +53,7 @@ 
     /**
      * Returns the request method registered.
      *
-     * @return mixed
+     * @return string
      */
 
     public function getMethod() {
@@ -63,7 +63,7 @@ 
     /**
      * Returns the callback associated to the pattern.
      *
-     * @return mixed
+     * @return callable
      */
 
     public function getResponse() {

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Routify;
 
-use Routify\Exceptions;
-
 
 class Order {
 

Spacing +3 added lines, -3 removed lines

@@ -106,11 +106,11 @@
      */
 
     private function isValidMiddleware() {
-        foreach($this->middlewares as $key => $value) {
-            if(!in_array($key, $this->middlewareTypes)) {
+        foreach ($this->middlewares as $key => $value) {
+            if (!in_array($key, $this->middlewareTypes)) {
                 throw new InvalidMiddleware("Only before and after middleware types are valid");
             }
-            if(!is_callable($value)) {
+            if (!is_callable($value)) {
                 throw new InvalidMiddleware("The middleware must be callable");
             }
         }

Routify/RouterParser.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
      */
     const PARAMETER_IDENTIFIER = ':';
 
+    /**
+     * @param string $path
+     */
     public function __construct($path) {
         $this->path = $path;
     }

Spacing +11 added lines, -11 removed lines

@@ -65,14 +65,14 @@ 
      */
 
     public function countParams($pattern) {
-        if($this->hasParams($pattern) === false) {
+        if ($this->hasParams($pattern) === false) {
             return 0;
         }
 
         $pattern = str_split($pattern); // split string in characters
         $totalParams = 0;
-        for($i = 0; $i < count($pattern); $i++) {
-            if($pattern[$i] === self::PARAMETER_IDENTIFIER) {
+        for ($i = 0; $i < count($pattern); $i++) {
+            if ($pattern[$i] === self::PARAMETER_IDENTIFIER) {
                 $totalParams++;
             }
         }
@@ -90,15 +90,15 @@ 
      */
 
     public function getParams($pattern) {
-        if(!$this->hasParams($pattern)) {
+        if (!$this->hasParams($pattern)) {
             return [];
         }
 
         $pattern = explode('/', $pattern);
         $path = explode('/', $this->path);
         $params = [];
-        for($i = 0; $i < count($pattern); $i++) {
-            if(strpos($pattern[$i], self::PARAMETER_IDENTIFIER) !== false) {
+        for ($i = 0; $i < count($pattern); $i++) {
+            if (strpos($pattern[$i], self::PARAMETER_IDENTIFIER) !== false) {
                 $params[substr($pattern[$i], 1)] = $path[$i];
             }
         }
@@ -117,20 +117,20 @@ 
         $pattern = explode('/', $pattern);
         $path = explode('/', $this->path);
 
-        if(count($pattern) !== count($path)) {
+        if (count($pattern) !== count($path)) {
             return false;
         }
 
         $found = true;
         $index = 0;
-        while($found && $index < count($pattern)) {
+        while ($found && $index < count($pattern)) {
             $check = true;
-            if(strpos($pattern[$index], self::PARAMETER_IDENTIFIER) !== false) {
+            if (strpos($pattern[$index], self::PARAMETER_IDENTIFIER) !== false) {
                 $check = false;
             }
 
-            if($check) {
-                if (!preg_match('/^'. $pattern[$index] .'$/', $path[$index])) {
+            if ($check) {
+                if (!preg_match('/^'.$pattern[$index].'$/', $path[$index])) {
                     $found = false;
                 }
             }

Routify/Router.php

Spacing +7 added lines, -7 removed lines

@@ -104,11 +104,11 @@ 
         $found = false;
         $counter = 0;
 
-        if(count($this->routes) === 0) {
+        if (count($this->routes) === 0) {
             return $found;
         }
 
-        while($found === false && $counter < count($this->routes)) {
+        while ($found === false && $counter < count($this->routes)) {
             if ($this->routes[$counter]->getUri() === $uri && $this->routes[$counter]->getMethod() === $method) {
                 $found = true;
             }
@@ -129,7 +129,7 @@ 
      */
 
     private function addOrder($uri, $method, $response, array $middleware = []) {
-        if($this->find($uri, $method)) {    // search if exists an apparition
+        if ($this->find($uri, $method)) {    // search if exists an apparition
             return false;
         }
 
@@ -207,7 +207,7 @@ 
      */
 
     public function notFound($func) {
-        if(is_callable($func)) {
+        if (is_callable($func)) {
             $this->notFound = $func;
         }
     }
@@ -225,15 +225,15 @@ 
     public function run() {
         $found = false;
         $counter = 0;
-        while($found === false && $counter < count($this->routes)) {
-            if($this->routerParser->match($this->routes[$counter]->getUri()) && $this->routes[$counter]->getMethod() === $this->requestMethod) {
+        while ($found === false && $counter < count($this->routes)) {
+            if ($this->routerParser->match($this->routes[$counter]->getUri()) && $this->routes[$counter]->getMethod() === $this->requestMethod) {
                 $found = true;
             } else {
                 $counter++;
             }
         }
 
-        if($found) {
+        if ($found) {
             // todo if exists before middleware, execute it.
             $params = $this->routerParser->getParams($this->routes[$counter]->getUri());
             $response = call_user_func_array($this->routes[$counter]->getResponse(), $params);