Passed
Pull Request — release-2.1 (#6721)
by
unknown
05:25
created
Sources/Subs.php 1 patch
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 			{
379 379
 				$val = 'CASE ';
380 380
 				foreach ($members as $k => $v)
381
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. alert_count($v, true) . ' ';
381
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . alert_count($v, true) . ' ';
382 382
 
383 383
 				$val = $val . ' END';
384 384
 				$type = 'raw';
@@ -1040,11 +1040,11 @@  discard block
 block discarded – undo
1040 1040
 			// Anything that isn't a specification, punctuation mark, or whitespace.
1041 1041
 			'~(?<!%)\p{L}|[^\p{L}\p{P}\s]~u',
1042 1042
 			// A series of punctuation marks (except %), possibly separated by whitespace.
1043
-			'~([^%\P{P}])(\s*)(?'.'>(\1|[^%\P{Po}])\s*(?!$))*~u',
1043
+			'~([^%\P{P}])(\s*)(?' . '>(\1|[^%\P{Po}])\s*(?!$))*~u',
1044 1044
 			// Unwanted trailing punctuation and whitespace.
1045
-			'~(?'.'>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
1045
+			'~(?' . '>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
1046 1046
 			// Unwanted opening punctuation and whitespace.
1047
-			'~^\s*(?'.'>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
1047
+			'~^\s*(?' . '>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
1048 1048
 		),
1049 1049
 		array(
1050 1050
 			'',
@@ -1442,7 +1442,7 @@  discard block
 block discarded – undo
1442 1442
 								$returnContext .= '<img src="' . $currentAttachment['href'] . '"' . $alt . $title . ' class="bbc_img"></a>';
1443 1443
 							else
1444 1444
 							{
1445
-								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"': '';
1445
+								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
1446 1446
 								$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . ' class="bbc_img resized"/>';
1447 1447
 							}
1448 1448
 						}
@@ -1451,7 +1451,7 @@  discard block
 block discarded – undo
1451 1451
 						{
1452 1452
 							$width = !empty($width) ? ' width="' . $width . '"' : '';
1453 1453
 
1454
-							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="'. $currentAttachment['href'] . '" playsinline' . $width . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1454
+							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="' . $currentAttachment['href'] . '" playsinline' . $width . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1455 1455
 						}
1456 1456
 						// Audio.
1457 1457
 						elseif (strpos($currentAttachment['mime_type'], 'audio/') === 0)
@@ -1459,7 +1459,7 @@  discard block
 block discarded – undo
1459 1459
 							$width = 'max-width:100%; width: ' . (!empty($width) ? $width : '400') . 'px;';
1460 1460
 
1461 1461
 
1462
-							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="'. $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1462
+							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="' . $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1463 1463
 						}
1464 1464
 						// Anything else.
1465 1465
 						else
@@ -1627,7 +1627,7 @@  discard block
 block discarded – undo
1627 1627
 				'type' => 'unparsed_commas_content',
1628 1628
 				'test' => '\d+,\d+\]',
1629 1629
 				'content' => '<a href="$1" target="_blank" rel="noopener">$1</a>',
1630
-				'validate' => function (&$tag, &$data, $disabled)
1630
+				'validate' => function(&$tag, &$data, $disabled)
1631 1631
 				{
1632 1632
 					$scheme = parse_url($data[0], PHP_URL_SCHEME);
1633 1633
 					if (empty($scheme))
@@ -2169,12 +2169,12 @@  discard block
 block discarded – undo
2169 2169
 		$codes[] = array(
2170 2170
 			'tag' => 'cowsay',
2171 2171
 			'parameters' => array(
2172
-				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function ($eyes) use ($smcFunc)
2172
+				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function($eyes) use ($smcFunc)
2173 2173
 					{
2174 2174
 						return $smcFunc['substr']($eyes . 'oo', 0, 2);
2175 2175
 					},
2176 2176
 				),
2177
-				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function ($tongue) use ($smcFunc)
2177
+				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function($tongue) use ($smcFunc)
2178 2178
 					{
2179 2179
 						return $smcFunc['substr']($tongue . '  ', 0, 2);
2180 2180
 					},
@@ -3555,7 +3555,7 @@  discard block
 block discarded – undo
3555 3555
 		if ($fp != false)
3556 3556
 		{
3557 3557
 			// Send the HEAD request (since we don't have to worry about chunked, HTTP/1.1 is fine here.)
3558
-			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: '. SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
3558
+			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: ' . SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
3559 3559
 
3560 3560
 			// Read in the HTTP/1.1 or whatever.
3561 3561
 			$test = substr(fgets($fp, 11), -1);
@@ -4172,7 +4172,7 @@  discard block
 block discarded – undo
4172 4172
 	$toMinify = array();
4173 4173
 	$normal = array();
4174 4174
 
4175
-	uasort($context['css_files'], function ($a, $b)
4175
+	uasort($context['css_files'], function($a, $b)
4176 4176
 	{
4177 4177
 		return $a['options']['order_pos'] < $b['options']['order_pos'] ? -1 : ($a['options']['order_pos'] > $b['options']['order_pos'] ? 1 : 0);
4178 4178
 	});
@@ -5469,7 +5469,7 @@  discard block
 block discarded – undo
5469 5469
 			{
5470 5470
 				fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n");
5471 5471
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
5472
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
5472
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
5473 5473
 				if ($keep_alive)
5474 5474
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n");
5475 5475
 				else
@@ -5479,7 +5479,7 @@  discard block
 block discarded – undo
5479 5479
 			{
5480 5480
 				fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n");
5481 5481
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
5482
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
5482
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
5483 5483
 				if ($keep_alive)
5484 5484
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n");
5485 5485
 				else
@@ -5728,13 +5728,13 @@  discard block
 block discarded – undo
5728 5728
 
5729 5729
 	// UTF-8 occurences of MS special characters
5730 5730
 	$findchars_utf8 = array(
5731
-		"\xe2\x80\x9a",	// single low-9 quotation mark
5732
-		"\xe2\x80\x9e",	// double low-9 quotation mark
5733
-		"\xe2\x80\xa6",	// horizontal ellipsis
5734
-		"\xe2\x80\x98",	// left single curly quote
5735
-		"\xe2\x80\x99",	// right single curly quote
5736
-		"\xe2\x80\x9c",	// left double curly quote
5737
-		"\xe2\x80\x9d",	// right double curly quote
5731
+		"\xe2\x80\x9a", // single low-9 quotation mark
5732
+		"\xe2\x80\x9e", // double low-9 quotation mark
5733
+		"\xe2\x80\xa6", // horizontal ellipsis
5734
+		"\xe2\x80\x98", // left single curly quote
5735
+		"\xe2\x80\x99", // right single curly quote
5736
+		"\xe2\x80\x9c", // left double curly quote
5737
+		"\xe2\x80\x9d", // right double curly quote
5738 5738
 	);
5739 5739
 
5740 5740
 	// windows 1252 / iso equivalents
@@ -5750,13 +5750,13 @@  discard block
 block discarded – undo
5750 5750
 
5751 5751
 	// safe replacements
5752 5752
 	$replacechars = array(
5753
-		',',	// &sbquo;
5754
-		',,',	// &bdquo;
5755
-		'...',	// &hellip;
5756
-		"'",	// &lsquo;
5757
-		"'",	// &rsquo;
5758
-		'"',	// &ldquo;
5759
-		'"',	// &rdquo;
5753
+		',', // &sbquo;
5754
+		',,', // &bdquo;
5755
+		'...', // &hellip;
5756
+		"'", // &lsquo;
5757
+		"'", // &rsquo;
5758
+		'"', // &ldquo;
5759
+		'"', // &rdquo;
5760 5760
 	);
5761 5761
 
5762 5762
 	if ($context['utf8'])
@@ -6101,7 +6101,7 @@  discard block
 block discarded – undo
6101 6101
 			$desc = implode(', ', array_slice(array_unique($tzvalue['locations']), 0, 5)) . (count($tzvalue['locations']) > 5 ? ', ' . $txt['etc'] : '');
6102 6102
 
6103 6103
 		// We don't want abbreviations like '+03' or '-11'.
6104
-		$abbrs = array_filter($tzvalue['abbrs'], function ($abbr) {
6104
+		$abbrs = array_filter($tzvalue['abbrs'], function($abbr) {
6105 6105
 			return !strspn($abbr, '+-');
6106 6106
 		});
6107 6107
 		$abbrs = count($abbrs) == count($tzvalue['abbrs']) ? array_unique($abbrs) : array();
@@ -7065,7 +7065,7 @@  discard block
 block discarded – undo
7065 7065
 			EXISTS (
7066 7066
 				SELECT bpv.id_board
7067 7067
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7068
-				WHERE bpv.id_group IN ('. implode(',', $groups) .')
7068
+				WHERE bpv.id_group IN ('. implode(',', $groups) . ')
7069 7069
 					AND bpv.deny = 0
7070 7070
 					AND bpv.id_board = b.id_board
7071 7071
 			)';
@@ -7075,7 +7075,7 @@  discard block
 block discarded – undo
7075 7075
 			AND NOT EXISTS (
7076 7076
 				SELECT bpv.id_board
7077 7077
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7078
-				WHERE bpv.id_group IN ( '. implode(',', $groups) .')
7078
+				WHERE bpv.id_group IN ( '. implode(',', $groups) . ')
7079 7079
 					AND bpv.deny = 1
7080 7080
 					AND bpv.id_board = b.id_board
7081 7081
 			)';
@@ -7346,8 +7346,8 @@  discard block
 block discarded – undo
7346 7346
 	$i = 0;
7347 7347
 	while (empty($done))
7348 7348
 	{
7349
-		if (strpos($format, '{'. --$i . '}') !== false)
7350
-			$replacements['{'. $i . '}'] = array_pop($list);
7349
+		if (strpos($format, '{' . --$i . '}') !== false)
7350
+			$replacements['{' . $i . '}'] = array_pop($list);
7351 7351
 		else
7352 7352
 			$done = true;
7353 7353
 	}
@@ -7357,8 +7357,8 @@  discard block
 block discarded – undo
7357 7357
 	$i = 0;
7358 7358
 	while (empty($done))
7359 7359
 	{
7360
-		if (strpos($format, '{'. ++$i . '}') !== false)
7361
-			$replacements['{'. $i . '}'] = array_shift($list);
7360
+		if (strpos($format, '{' . ++$i . '}') !== false)
7361
+			$replacements['{' . $i . '}'] = array_shift($list);
7362 7362
 		else
7363 7363
 			$done = true;
7364 7364
 	}
Please login to merge, or discard this patch.