@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Load the $modSettings array. |
@@ -25,13 +26,14 @@ discard block |
||
25 | 26 | global $cache_enable, $sourcedir, $context; |
26 | 27 | |
27 | 28 | // Most database systems have not set UTF-8 as their default input charset. |
28 | - if (!empty($db_character_set)) |
|
29 | - $smcFunc['db_query']('', ' |
|
29 | + if (!empty($db_character_set)) { |
|
30 | + $smcFunc['db_query']('', ' |
|
30 | 31 | SET NAMES {string:db_character_set}', |
31 | 32 | array( |
32 | 33 | 'db_character_set' => $db_character_set, |
33 | 34 | ) |
34 | 35 | ); |
36 | + } |
|
35 | 37 | |
36 | 38 | // We need some caching support, maybe. |
37 | 39 | loadCacheAccelerator(); |
@@ -46,27 +48,35 @@ discard block |
||
46 | 48 | ) |
47 | 49 | ); |
48 | 50 | $modSettings = array(); |
49 | - if (!$request) |
|
50 | - display_db_error(); |
|
51 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
52 | - $modSettings[$row[0]] = $row[1]; |
|
51 | + if (!$request) { |
|
52 | + display_db_error(); |
|
53 | + } |
|
54 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
55 | + $modSettings[$row[0]] = $row[1]; |
|
56 | + } |
|
53 | 57 | $smcFunc['db_free_result']($request); |
54 | 58 | |
55 | 59 | // Do a few things to protect against missing settings or settings with invalid values... |
56 | - if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) |
|
57 | - $modSettings['defaultMaxTopics'] = 20; |
|
58 | - if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) |
|
59 | - $modSettings['defaultMaxMessages'] = 15; |
|
60 | - if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) |
|
61 | - $modSettings['defaultMaxMembers'] = 30; |
|
62 | - if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) |
|
63 | - $modSettings['defaultMaxListItems'] = 15; |
|
60 | + if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) { |
|
61 | + $modSettings['defaultMaxTopics'] = 20; |
|
62 | + } |
|
63 | + if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) { |
|
64 | + $modSettings['defaultMaxMessages'] = 15; |
|
65 | + } |
|
66 | + if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) { |
|
67 | + $modSettings['defaultMaxMembers'] = 30; |
|
68 | + } |
|
69 | + if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) { |
|
70 | + $modSettings['defaultMaxListItems'] = 15; |
|
71 | + } |
|
64 | 72 | |
65 | - if (!is_array($modSettings['attachmentUploadDir'])) |
|
66 | - $modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true); |
|
73 | + if (!is_array($modSettings['attachmentUploadDir'])) { |
|
74 | + $modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true); |
|
75 | + } |
|
67 | 76 | |
68 | - if (!empty($cache_enable)) |
|
69 | - cache_put_data('modSettings', $modSettings, 90); |
|
77 | + if (!empty($cache_enable)) { |
|
78 | + cache_put_data('modSettings', $modSettings, 90); |
|
79 | + } |
|
70 | 80 | } |
71 | 81 | |
72 | 82 | $modSettings['cache_enable'] = $cache_enable; |
@@ -86,8 +96,9 @@ discard block |
||
86 | 96 | }; |
87 | 97 | $fix_utf8mb4 = function($string) use ($utf8, $smcFunc) |
88 | 98 | { |
89 | - if (!$utf8 || $smcFunc['db_mb4']) |
|
90 | - return $string; |
|
99 | + if (!$utf8 || $smcFunc['db_mb4']) { |
|
100 | + return $string; |
|
101 | + } |
|
91 | 102 | |
92 | 103 | $i = 0; |
93 | 104 | $len = strlen($string); |
@@ -99,18 +110,15 @@ discard block |
||
99 | 110 | { |
100 | 111 | $new_string .= $string[$i]; |
101 | 112 | $i++; |
102 | - } |
|
103 | - elseif ($ord < 224) |
|
113 | + } elseif ($ord < 224) |
|
104 | 114 | { |
105 | 115 | $new_string .= $string[$i] . $string[$i + 1]; |
106 | 116 | $i += 2; |
107 | - } |
|
108 | - elseif ($ord < 240) |
|
117 | + } elseif ($ord < 240) |
|
109 | 118 | { |
110 | 119 | $new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2]; |
111 | 120 | $i += 3; |
112 | - } |
|
113 | - elseif ($ord < 248) |
|
121 | + } elseif ($ord < 248) |
|
114 | 122 | { |
115 | 123 | // Magic happens. |
116 | 124 | $val = (ord($string[$i]) & 0x07) << 18; |
@@ -154,8 +162,7 @@ discard block |
||
154 | 162 | { |
155 | 163 | $result = array_search($needle, array_slice($haystack_arr, $offset)); |
156 | 164 | return is_int($result) ? $result + $offset : false; |
157 | - } |
|
158 | - else |
|
165 | + } else |
|
159 | 166 | { |
160 | 167 | $needle_arr = preg_split('~(&#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . ';|"|&|<|>| |.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY); |
161 | 168 | $needle_size = count($needle_arr); |
@@ -164,8 +171,9 @@ discard block |
||
164 | 171 | while ((int) $result === $result) |
165 | 172 | { |
166 | 173 | $offset += $result; |
167 | - if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) |
|
168 | - return $offset; |
|
174 | + if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) { |
|
175 | + return $offset; |
|
176 | + } |
|
169 | 177 | $result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset)); |
170 | 178 | } |
171 | 179 | return false; |
@@ -203,8 +211,9 @@ discard block |
||
203 | 211 | $string = $ent_check($string); |
204 | 212 | preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches); |
205 | 213 | $string = $matches[0]; |
206 | - while (strlen($string) > $length) |
|
207 | - $string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string); |
|
214 | + while (strlen($string) > $length) { |
|
215 | + $string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string); |
|
216 | + } |
|
208 | 217 | return $string; |
209 | 218 | }, |
210 | 219 | 'ucfirst' => $utf8 ? function($string) use (&$smcFunc) |
@@ -214,23 +223,25 @@ discard block |
||
214 | 223 | 'ucwords' => $utf8 ? function($string) use (&$smcFunc) |
215 | 224 | { |
216 | 225 | $words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE); |
217 | - for ($i = 0, $n = count($words); $i < $n; $i += 2) |
|
218 | - $words[$i] = $smcFunc['ucfirst']($words[$i]); |
|
226 | + for ($i = 0, $n = count($words); $i < $n; $i += 2) { |
|
227 | + $words[$i] = $smcFunc['ucfirst']($words[$i]); |
|
228 | + } |
|
219 | 229 | return implode('', $words); |
220 | 230 | } : 'ucwords', |
221 | 231 | ); |
222 | 232 | |
223 | 233 | // Setting the timezone is a requirement for some functions. |
224 | - if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) |
|
225 | - date_default_timezone_set($modSettings['default_timezone']); |
|
226 | - else |
|
234 | + if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) { |
|
235 | + date_default_timezone_set($modSettings['default_timezone']); |
|
236 | + } else |
|
227 | 237 | { |
228 | 238 | // Get PHP's default timezone, if set |
229 | 239 | $ini_tz = ini_get('date.timezone'); |
230 | - if (!empty($ini_tz)) |
|
231 | - $modSettings['default_timezone'] = $ini_tz; |
|
232 | - else |
|
233 | - $modSettings['default_timezone'] = ''; |
|
240 | + if (!empty($ini_tz)) { |
|
241 | + $modSettings['default_timezone'] = $ini_tz; |
|
242 | + } else { |
|
243 | + $modSettings['default_timezone'] = ''; |
|
244 | + } |
|
234 | 245 | |
235 | 246 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
236 | 247 | if (!in_array($modSettings['default_timezone'], timezone_identifiers_list())) |
@@ -248,22 +259,26 @@ discard block |
||
248 | 259 | if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null) |
249 | 260 | { |
250 | 261 | $modSettings['load_average'] = @file_get_contents('/proc/loadavg'); |
251 | - if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) |
|
252 | - $modSettings['load_average'] = (float) $matches[1]; |
|
253 | - elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) |
|
254 | - $modSettings['load_average'] = (float) $matches[1]; |
|
255 | - else |
|
256 | - unset($modSettings['load_average']); |
|
262 | + if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) { |
|
263 | + $modSettings['load_average'] = (float) $matches[1]; |
|
264 | + } elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) { |
|
265 | + $modSettings['load_average'] = (float) $matches[1]; |
|
266 | + } else { |
|
267 | + unset($modSettings['load_average']); |
|
268 | + } |
|
257 | 269 | |
258 | - if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) |
|
259 | - cache_put_data('loadavg', $modSettings['load_average'], 90); |
|
270 | + if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) { |
|
271 | + cache_put_data('loadavg', $modSettings['load_average'], 90); |
|
272 | + } |
|
260 | 273 | } |
261 | 274 | |
262 | - if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) |
|
263 | - call_integration_hook('integrate_load_average', array($modSettings['load_average'])); |
|
275 | + if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) { |
|
276 | + call_integration_hook('integrate_load_average', array($modSettings['load_average'])); |
|
277 | + } |
|
264 | 278 | |
265 | - if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) |
|
266 | - display_loadavg_error(); |
|
279 | + if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) { |
|
280 | + display_loadavg_error(); |
|
281 | + } |
|
267 | 282 | } |
268 | 283 | |
269 | 284 | // Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is. |
@@ -284,8 +299,9 @@ discard block |
||
284 | 299 | if (defined('SMF_INTEGRATION_SETTINGS')) |
285 | 300 | { |
286 | 301 | $integration_settings = smf_json_decode(SMF_INTEGRATION_SETTINGS, true); |
287 | - foreach ($integration_settings as $hook => $function) |
|
288 | - add_integration_function($hook, $function, '', false); |
|
302 | + foreach ($integration_settings as $hook => $function) { |
|
303 | + add_integration_function($hook, $function, '', false); |
|
304 | + } |
|
289 | 305 | } |
290 | 306 | |
291 | 307 | // Any files to pre include? |
@@ -295,8 +311,9 @@ discard block |
||
295 | 311 | foreach ($pre_includes as $include) |
296 | 312 | { |
297 | 313 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
298 | - if (file_exists($include)) |
|
299 | - require_once($include); |
|
314 | + if (file_exists($include)) { |
|
315 | + require_once($include); |
|
316 | + } |
|
300 | 317 | } |
301 | 318 | } |
302 | 319 | |
@@ -400,27 +417,28 @@ discard block |
||
400 | 417 | break; |
401 | 418 | } |
402 | 419 | } |
420 | + } else { |
|
421 | + $id_member = 0; |
|
403 | 422 | } |
404 | - else |
|
405 | - $id_member = 0; |
|
406 | 423 | |
407 | 424 | if (empty($id_member) && isset($_COOKIE[$cookiename])) |
408 | 425 | { |
409 | 426 | $cookie_data = smf_json_decode($_COOKIE[$cookiename], true, false); |
410 | 427 | |
411 | - if (empty($cookie_data)) |
|
412 | - $cookie_data = safe_unserialize($_COOKIE[$cookiename]); |
|
428 | + if (empty($cookie_data)) { |
|
429 | + $cookie_data = safe_unserialize($_COOKIE[$cookiename]); |
|
430 | + } |
|
413 | 431 | |
414 | 432 | list ($id_member, $password) = $cookie_data; |
415 | 433 | $id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0; |
416 | - } |
|
417 | - elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA']))) |
|
434 | + } elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA']))) |
|
418 | 435 | { |
419 | 436 | // @todo Perhaps we can do some more checking on this, such as on the first octet of the IP? |
420 | 437 | $cookie_data = smf_json_decode($_SESSION['login_' . $cookiename]); |
421 | 438 | |
422 | - if (empty($cookie_data)) |
|
423 | - $cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
439 | + if (empty($cookie_data)) { |
|
440 | + $cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
441 | + } |
|
424 | 442 | |
425 | 443 | list ($id_member, $password, $login_span) = $cookie_data; |
426 | 444 | $id_member = !empty($id_member) && strlen($password) == 128 && $login_span > time() ? (int) $id_member : 0; |
@@ -445,30 +463,34 @@ discard block |
||
445 | 463 | $user_settings = $smcFunc['db_fetch_assoc']($request); |
446 | 464 | $smcFunc['db_free_result']($request); |
447 | 465 | |
448 | - if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) |
|
449 | - $user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret); |
|
466 | + if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) { |
|
467 | + $user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret); |
|
468 | + } |
|
450 | 469 | |
451 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
452 | - cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
470 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
471 | + cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
472 | + } |
|
453 | 473 | } |
454 | 474 | |
455 | 475 | // Did we find 'im? If not, junk it. |
456 | 476 | if (!empty($user_settings)) |
457 | 477 | { |
458 | 478 | // As much as the password should be right, we can assume the integration set things up. |
459 | - if (!empty($already_verified) && $already_verified === true) |
|
460 | - $check = true; |
|
479 | + if (!empty($already_verified) && $already_verified === true) { |
|
480 | + $check = true; |
|
481 | + } |
|
461 | 482 | // SHA-512 hash should be 128 characters long. |
462 | - elseif (strlen($password) == 128) |
|
463 | - $check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password; |
|
464 | - else |
|
465 | - $check = false; |
|
483 | + elseif (strlen($password) == 128) { |
|
484 | + $check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password; |
|
485 | + } else { |
|
486 | + $check = false; |
|
487 | + } |
|
466 | 488 | |
467 | 489 | // Wrong password or not activated - either way, you're going nowhere. |
468 | 490 | $id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0; |
491 | + } else { |
|
492 | + $id_member = 0; |
|
469 | 493 | } |
470 | - else |
|
471 | - $id_member = 0; |
|
472 | 494 | |
473 | 495 | // If we no longer have the member maybe they're being all hackey, stop brute force! |
474 | 496 | if (!$id_member) |
@@ -490,13 +512,15 @@ discard block |
||
490 | 512 | { |
491 | 513 | $tfa_data = smf_json_decode($_COOKIE[$tfacookie]); |
492 | 514 | |
493 | - if (is_null($tfa_data)) |
|
494 | - $tfa_data = safe_unserialize($_COOKIE[$tfacookie]); |
|
515 | + if (is_null($tfa_data)) { |
|
516 | + $tfa_data = safe_unserialize($_COOKIE[$tfacookie]); |
|
517 | + } |
|
495 | 518 | |
496 | 519 | list ($tfamember, $tfasecret) = $tfa_data; |
497 | 520 | |
498 | - if ((int) $tfamember != $id_member) |
|
499 | - $tfasecret = null; |
|
521 | + if ((int) $tfamember != $id_member) { |
|
522 | + $tfasecret = null; |
|
523 | + } |
|
500 | 524 | } |
501 | 525 | |
502 | 526 | if (empty($tfasecret) || hash_salt($user_settings['tfa_backup'], $user_settings['password_salt']) != $tfasecret) |
@@ -516,10 +540,12 @@ discard block |
||
516 | 540 | // Are we forcing 2FA? Need to check if the user groups actually require 2FA |
517 | 541 | elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret'])) |
518 | 542 | { |
519 | - if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups |
|
543 | + if ($modSettings['tfa_mode'] == 2) { |
|
544 | + //only do this if we are just forcing SOME membergroups |
|
520 | 545 | { |
521 | 546 | //Build an array of ALL user membergroups. |
522 | 547 | $full_groups = array($user_settings['id_group']); |
548 | + } |
|
523 | 549 | if (!empty($user_settings['additional_groups'])) |
524 | 550 | { |
525 | 551 | $full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups'])); |
@@ -539,15 +565,17 @@ discard block |
||
539 | 565 | ); |
540 | 566 | $row = $smcFunc['db_fetch_assoc']($request); |
541 | 567 | $smcFunc['db_free_result']($request); |
568 | + } else { |
|
569 | + $row['total'] = 1; |
|
542 | 570 | } |
543 | - else |
|
544 | - $row['total'] = 1; //simplifies logics in the next "if" |
|
571 | + //simplifies logics in the next "if" |
|
545 | 572 | |
546 | 573 | $area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : ''; |
547 | 574 | $action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : ''; |
548 | 575 | |
549 | - if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) |
|
550 | - redirectexit('action=profile;area=tfasetup;forced'); |
|
576 | + if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) { |
|
577 | + redirectexit('action=profile;area=tfasetup;forced'); |
|
578 | + } |
|
551 | 579 | } |
552 | 580 | } |
553 | 581 | |
@@ -584,33 +612,37 @@ discard block |
||
584 | 612 | updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP'])); |
585 | 613 | $user_settings['last_login'] = time(); |
586 | 614 | |
587 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
588 | - cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
615 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
616 | + cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
617 | + } |
|
589 | 618 | |
590 | - if (!empty($modSettings['cache_enable'])) |
|
591 | - cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600); |
|
619 | + if (!empty($modSettings['cache_enable'])) { |
|
620 | + cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600); |
|
621 | + } |
|
592 | 622 | } |
623 | + } elseif (empty($_SESSION['id_msg_last_visit'])) { |
|
624 | + $_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit']; |
|
593 | 625 | } |
594 | - elseif (empty($_SESSION['id_msg_last_visit'])) |
|
595 | - $_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit']; |
|
596 | 626 | |
597 | 627 | $username = $user_settings['member_name']; |
598 | 628 | |
599 | - if (empty($user_settings['additional_groups'])) |
|
600 | - $user_info = array( |
|
629 | + if (empty($user_settings['additional_groups'])) { |
|
630 | + $user_info = array( |
|
601 | 631 | 'groups' => array($user_settings['id_group'], $user_settings['id_post_group']) |
602 | 632 | ); |
603 | - else |
|
604 | - $user_info = array( |
|
633 | + } else { |
|
634 | + $user_info = array( |
|
605 | 635 | 'groups' => array_merge( |
606 | 636 | array($user_settings['id_group'], $user_settings['id_post_group']), |
607 | 637 | explode(',', $user_settings['additional_groups']) |
608 | 638 | ) |
609 | 639 | ); |
640 | + } |
|
610 | 641 | |
611 | 642 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
612 | - foreach ($user_info['groups'] as $k => $v) |
|
613 | - $user_info['groups'][$k] = (int) $v; |
|
643 | + foreach ($user_info['groups'] as $k => $v) { |
|
644 | + $user_info['groups'][$k] = (int) $v; |
|
645 | + } |
|
614 | 646 | |
615 | 647 | // This is a logged in user, so definitely not a spider. |
616 | 648 | $user_info['possibly_robot'] = false; |
@@ -624,8 +656,7 @@ discard block |
||
624 | 656 | $time_system = new DateTime('now', $tz_system); |
625 | 657 | $time_user = new DateTime('now', $tz_user); |
626 | 658 | $user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600; |
627 | - } |
|
628 | - else |
|
659 | + } else |
|
629 | 660 | { |
630 | 661 | // !!! Compatibility. |
631 | 662 | $user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset']; |
@@ -639,16 +670,18 @@ discard block |
||
639 | 670 | $user_info = array('groups' => array(-1)); |
640 | 671 | $user_settings = array(); |
641 | 672 | |
642 | - if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) |
|
643 | - $_COOKIE[$cookiename] = ''; |
|
673 | + if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) { |
|
674 | + $_COOKIE[$cookiename] = ''; |
|
675 | + } |
|
644 | 676 | |
645 | 677 | // Expire the 2FA cookie |
646 | 678 | if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member'])) |
647 | 679 | { |
648 | 680 | $tfa_data = smf_json_decode($_COOKIE[$cookiename . '_tfa'], true); |
649 | 681 | |
650 | - if (is_null($tfa_data)) |
|
651 | - $tfa_data = safe_unserialize($_COOKIE[$cookiename . '_tfa']); |
|
682 | + if (is_null($tfa_data)) { |
|
683 | + $tfa_data = safe_unserialize($_COOKIE[$cookiename . '_tfa']); |
|
684 | + } |
|
652 | 685 | |
653 | 686 | list ($id, $user, $exp, $state, $preserve) = $tfa_data; |
654 | 687 | |
@@ -660,19 +693,20 @@ discard block |
||
660 | 693 | } |
661 | 694 | |
662 | 695 | // Create a login token if it doesn't exist yet. |
663 | - if (!isset($_SESSION['token']['post-login'])) |
|
664 | - createToken('login'); |
|
665 | - else |
|
666 | - list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login']; |
|
696 | + if (!isset($_SESSION['token']['post-login'])) { |
|
697 | + createToken('login'); |
|
698 | + } else { |
|
699 | + list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login']; |
|
700 | + } |
|
667 | 701 | |
668 | 702 | // Do we perhaps think this is a search robot? Check every five minutes just in case... |
669 | 703 | if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300)) |
670 | 704 | { |
671 | 705 | require_once($sourcedir . '/ManageSearchEngines.php'); |
672 | 706 | $user_info['possibly_robot'] = SpiderCheck(); |
707 | + } elseif (!empty($modSettings['spider_mode'])) { |
|
708 | + $user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0; |
|
673 | 709 | } |
674 | - elseif (!empty($modSettings['spider_mode'])) |
|
675 | - $user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0; |
|
676 | 710 | // If we haven't turned on proper spider hunts then have a guess! |
677 | 711 | else |
678 | 712 | { |
@@ -720,8 +754,9 @@ discard block |
||
720 | 754 | $user_info['groups'] = array_unique($user_info['groups']); |
721 | 755 | |
722 | 756 | // Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems. |
723 | - if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) |
|
724 | - unset($user_info['ignoreboards'][$tmp]); |
|
757 | + if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) { |
|
758 | + unset($user_info['ignoreboards'][$tmp]); |
|
759 | + } |
|
725 | 760 | |
726 | 761 | // Allow the user to change their language. |
727 | 762 | if (!empty($modSettings['userLanguage'])) |
@@ -734,31 +769,36 @@ discard block |
||
734 | 769 | $user_info['language'] = strtr($_GET['language'], './\\:', '____'); |
735 | 770 | |
736 | 771 | // Make it permanent for members. |
737 | - if (!empty($user_info['id'])) |
|
738 | - updateMemberData($user_info['id'], array('lngfile' => $user_info['language'])); |
|
739 | - else |
|
740 | - $_SESSION['language'] = $user_info['language']; |
|
772 | + if (!empty($user_info['id'])) { |
|
773 | + updateMemberData($user_info['id'], array('lngfile' => $user_info['language'])); |
|
774 | + } else { |
|
775 | + $_SESSION['language'] = $user_info['language']; |
|
776 | + } |
|
777 | + } elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) { |
|
778 | + $user_info['language'] = strtr($_SESSION['language'], './\\:', '____'); |
|
741 | 779 | } |
742 | - elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) |
|
743 | - $user_info['language'] = strtr($_SESSION['language'], './\\:', '____'); |
|
744 | 780 | } |
745 | 781 | |
746 | 782 | // Just build this here, it makes it easier to change/use - administrators can see all boards. |
747 | - if ($user_info['is_admin']) |
|
748 | - $user_info['query_see_board'] = '1=1'; |
|
783 | + if ($user_info['is_admin']) { |
|
784 | + $user_info['query_see_board'] = '1=1'; |
|
785 | + } |
|
749 | 786 | // Otherwise just the groups in $user_info['groups']. |
750 | - else |
|
751 | - $user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')'; |
|
787 | + else { |
|
788 | + $user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')'; |
|
789 | + } |
|
752 | 790 | |
753 | 791 | // Build the list of boards they WANT to see. |
754 | 792 | // This will take the place of query_see_boards in certain spots, so it better include the boards they can see also |
755 | 793 | |
756 | 794 | // If they aren't ignoring any boards then they want to see all the boards they can see |
757 | - if (empty($user_info['ignoreboards'])) |
|
758 | - $user_info['query_wanna_see_board'] = $user_info['query_see_board']; |
|
795 | + if (empty($user_info['ignoreboards'])) { |
|
796 | + $user_info['query_wanna_see_board'] = $user_info['query_see_board']; |
|
797 | + } |
|
759 | 798 | // Ok I guess they don't want to see all the boards |
760 | - else |
|
761 | - $user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))'; |
|
799 | + else { |
|
800 | + $user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))'; |
|
801 | + } |
|
762 | 802 | |
763 | 803 | call_integration_hook('integrate_user_info'); |
764 | 804 | } |
@@ -816,9 +856,9 @@ discard block |
||
816 | 856 | } |
817 | 857 | |
818 | 858 | // Remember redirection is the key to avoiding fallout from your bosses. |
819 | - if (!empty($topic)) |
|
820 | - redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']); |
|
821 | - else |
|
859 | + if (!empty($topic)) { |
|
860 | + redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']); |
|
861 | + } else |
|
822 | 862 | { |
823 | 863 | loadPermissions(); |
824 | 864 | loadTheme(); |
@@ -836,10 +876,11 @@ discard block |
||
836 | 876 | if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3)) |
837 | 877 | { |
838 | 878 | // @todo SLOW? |
839 | - if (!empty($topic)) |
|
840 | - $temp = cache_get_data('topic_board-' . $topic, 120); |
|
841 | - else |
|
842 | - $temp = cache_get_data('board-' . $board, 120); |
|
879 | + if (!empty($topic)) { |
|
880 | + $temp = cache_get_data('topic_board-' . $topic, 120); |
|
881 | + } else { |
|
882 | + $temp = cache_get_data('board-' . $board, 120); |
|
883 | + } |
|
843 | 884 | |
844 | 885 | if (!empty($temp)) |
845 | 886 | { |
@@ -877,8 +918,9 @@ discard block |
||
877 | 918 | $row = $smcFunc['db_fetch_assoc']($request); |
878 | 919 | |
879 | 920 | // Set the current board. |
880 | - if (!empty($row['id_board'])) |
|
881 | - $board = $row['id_board']; |
|
921 | + if (!empty($row['id_board'])) { |
|
922 | + $board = $row['id_board']; |
|
923 | + } |
|
882 | 924 | |
883 | 925 | // Basic operating information. (globals... :/) |
884 | 926 | $board_info = array( |
@@ -914,21 +956,23 @@ discard block |
||
914 | 956 | |
915 | 957 | do |
916 | 958 | { |
917 | - if (!empty($row['id_moderator'])) |
|
918 | - $board_info['moderators'][$row['id_moderator']] = array( |
|
959 | + if (!empty($row['id_moderator'])) { |
|
960 | + $board_info['moderators'][$row['id_moderator']] = array( |
|
919 | 961 | 'id' => $row['id_moderator'], |
920 | 962 | 'name' => $row['real_name'], |
921 | 963 | 'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'], |
922 | 964 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>' |
923 | 965 | ); |
966 | + } |
|
924 | 967 | |
925 | - if (!empty($row['id_moderator_group'])) |
|
926 | - $board_info['moderator_groups'][$row['id_moderator_group']] = array( |
|
968 | + if (!empty($row['id_moderator_group'])) { |
|
969 | + $board_info['moderator_groups'][$row['id_moderator_group']] = array( |
|
927 | 970 | 'id' => $row['id_moderator_group'], |
928 | 971 | 'name' => $row['group_name'], |
929 | 972 | 'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'], |
930 | 973 | 'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>' |
931 | 974 | ); |
975 | + } |
|
932 | 976 | } |
933 | 977 | while ($row = $smcFunc['db_fetch_assoc']($request)); |
934 | 978 | |
@@ -960,12 +1004,12 @@ discard block |
||
960 | 1004 | if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3)) |
961 | 1005 | { |
962 | 1006 | // @todo SLOW? |
963 | - if (!empty($topic)) |
|
964 | - cache_put_data('topic_board-' . $topic, $board_info, 120); |
|
1007 | + if (!empty($topic)) { |
|
1008 | + cache_put_data('topic_board-' . $topic, $board_info, 120); |
|
1009 | + } |
|
965 | 1010 | cache_put_data('board-' . $board, $board_info, 120); |
966 | 1011 | } |
967 | - } |
|
968 | - else |
|
1012 | + } else |
|
969 | 1013 | { |
970 | 1014 | // Otherwise the topic is invalid, there are no moderators, etc. |
971 | 1015 | $board_info = array( |
@@ -979,8 +1023,9 @@ discard block |
||
979 | 1023 | $smcFunc['db_free_result']($request); |
980 | 1024 | } |
981 | 1025 | |
982 | - if (!empty($topic)) |
|
983 | - $_GET['board'] = (int) $board; |
|
1026 | + if (!empty($topic)) { |
|
1027 | + $_GET['board'] = (int) $board; |
|
1028 | + } |
|
984 | 1029 | |
985 | 1030 | if (!empty($board)) |
986 | 1031 | { |
@@ -990,10 +1035,12 @@ discard block |
||
990 | 1035 | // Now check if the user is a moderator. |
991 | 1036 | $user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0; |
992 | 1037 | |
993 | - if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) |
|
994 | - $board_info['error'] = 'access'; |
|
995 | - if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) |
|
996 | - $board_info['error'] = 'access'; |
|
1038 | + if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) { |
|
1039 | + $board_info['error'] = 'access'; |
|
1040 | + } |
|
1041 | + if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) { |
|
1042 | + $board_info['error'] = 'access'; |
|
1043 | + } |
|
997 | 1044 | |
998 | 1045 | // Build up the linktree. |
999 | 1046 | $context['linktree'] = array_merge( |
@@ -1016,8 +1063,9 @@ discard block |
||
1016 | 1063 | $context['current_board'] = $board; |
1017 | 1064 | |
1018 | 1065 | // No posting in redirection boards! |
1019 | - if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) |
|
1020 | - $board_info['error'] == 'post_in_redirect'; |
|
1066 | + if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) { |
|
1067 | + $board_info['error'] == 'post_in_redirect'; |
|
1068 | + } |
|
1021 | 1069 | |
1022 | 1070 | // Hacker... you can't see this topic, I'll tell you that. (but moderators can!) |
1023 | 1071 | if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod'])) |
@@ -1043,24 +1091,23 @@ discard block |
||
1043 | 1091 | ob_end_clean(); |
1044 | 1092 | header('HTTP/1.1 403 Forbidden'); |
1045 | 1093 | die; |
1046 | - } |
|
1047 | - elseif ($board_info['error'] == 'post_in_redirect') |
|
1094 | + } elseif ($board_info['error'] == 'post_in_redirect') |
|
1048 | 1095 | { |
1049 | 1096 | // Slightly different error message here... |
1050 | 1097 | fatal_lang_error('cannot_post_redirect', false); |
1051 | - } |
|
1052 | - elseif ($user_info['is_guest']) |
|
1098 | + } elseif ($user_info['is_guest']) |
|
1053 | 1099 | { |
1054 | 1100 | loadLanguage('Errors'); |
1055 | 1101 | is_not_guest($txt['topic_gone']); |
1102 | + } else { |
|
1103 | + fatal_lang_error('topic_gone', false); |
|
1056 | 1104 | } |
1057 | - else |
|
1058 | - fatal_lang_error('topic_gone', false); |
|
1059 | 1105 | } |
1060 | 1106 | |
1061 | - if ($user_info['is_mod']) |
|
1062 | - $user_info['groups'][] = 3; |
|
1063 | -} |
|
1107 | + if ($user_info['is_mod']) { |
|
1108 | + $user_info['groups'][] = 3; |
|
1109 | + } |
|
1110 | + } |
|
1064 | 1111 | |
1065 | 1112 | /** |
1066 | 1113 | * Load this user's permissions. |
@@ -1081,8 +1128,9 @@ discard block |
||
1081 | 1128 | asort($cache_groups); |
1082 | 1129 | $cache_groups = implode(',', $cache_groups); |
1083 | 1130 | // If it's a spider then cache it different. |
1084 | - if ($user_info['possibly_robot']) |
|
1085 | - $cache_groups .= '-spider'; |
|
1131 | + if ($user_info['possibly_robot']) { |
|
1132 | + $cache_groups .= '-spider'; |
|
1133 | + } |
|
1086 | 1134 | |
1087 | 1135 | if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated']) |
1088 | 1136 | { |
@@ -1090,9 +1138,9 @@ discard block |
||
1090 | 1138 | banPermissions(); |
1091 | 1139 | |
1092 | 1140 | return; |
1141 | + } elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) { |
|
1142 | + list ($user_info['permissions'], $removals) = $temp; |
|
1093 | 1143 | } |
1094 | - elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) |
|
1095 | - list ($user_info['permissions'], $removals) = $temp; |
|
1096 | 1144 | } |
1097 | 1145 | |
1098 | 1146 | // If it is detected as a robot, and we are restricting permissions as a special group - then implement this. |
@@ -1114,23 +1162,26 @@ discard block |
||
1114 | 1162 | $removals = array(); |
1115 | 1163 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1116 | 1164 | { |
1117 | - if (empty($row['add_deny'])) |
|
1118 | - $removals[] = $row['permission']; |
|
1119 | - else |
|
1120 | - $user_info['permissions'][] = $row['permission']; |
|
1165 | + if (empty($row['add_deny'])) { |
|
1166 | + $removals[] = $row['permission']; |
|
1167 | + } else { |
|
1168 | + $user_info['permissions'][] = $row['permission']; |
|
1169 | + } |
|
1121 | 1170 | } |
1122 | 1171 | $smcFunc['db_free_result']($request); |
1123 | 1172 | |
1124 | - if (isset($cache_groups)) |
|
1125 | - cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240); |
|
1173 | + if (isset($cache_groups)) { |
|
1174 | + cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240); |
|
1175 | + } |
|
1126 | 1176 | } |
1127 | 1177 | |
1128 | 1178 | // Get the board permissions. |
1129 | 1179 | if (!empty($board)) |
1130 | 1180 | { |
1131 | 1181 | // Make sure the board (if any) has been loaded by loadBoard(). |
1132 | - if (!isset($board_info['profile'])) |
|
1133 | - fatal_lang_error('no_board'); |
|
1182 | + if (!isset($board_info['profile'])) { |
|
1183 | + fatal_lang_error('no_board'); |
|
1184 | + } |
|
1134 | 1185 | |
1135 | 1186 | $request = $smcFunc['db_query']('', ' |
1136 | 1187 | SELECT permission, add_deny |
@@ -1146,20 +1197,23 @@ discard block |
||
1146 | 1197 | ); |
1147 | 1198 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1148 | 1199 | { |
1149 | - if (empty($row['add_deny'])) |
|
1150 | - $removals[] = $row['permission']; |
|
1151 | - else |
|
1152 | - $user_info['permissions'][] = $row['permission']; |
|
1200 | + if (empty($row['add_deny'])) { |
|
1201 | + $removals[] = $row['permission']; |
|
1202 | + } else { |
|
1203 | + $user_info['permissions'][] = $row['permission']; |
|
1204 | + } |
|
1153 | 1205 | } |
1154 | 1206 | $smcFunc['db_free_result']($request); |
1155 | 1207 | } |
1156 | 1208 | |
1157 | 1209 | // Remove all the permissions they shouldn't have ;). |
1158 | - if (!empty($modSettings['permission_enable_deny'])) |
|
1159 | - $user_info['permissions'] = array_diff($user_info['permissions'], $removals); |
|
1210 | + if (!empty($modSettings['permission_enable_deny'])) { |
|
1211 | + $user_info['permissions'] = array_diff($user_info['permissions'], $removals); |
|
1212 | + } |
|
1160 | 1213 | |
1161 | - if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) |
|
1162 | - cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240); |
|
1214 | + if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) { |
|
1215 | + cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240); |
|
1216 | + } |
|
1163 | 1217 | |
1164 | 1218 | // Banned? Watch, don't touch.. |
1165 | 1219 | banPermissions(); |
@@ -1171,17 +1225,18 @@ discard block |
||
1171 | 1225 | { |
1172 | 1226 | require_once($sourcedir . '/Subs-Auth.php'); |
1173 | 1227 | rebuildModCache(); |
1228 | + } else { |
|
1229 | + $user_info['mod_cache'] = $_SESSION['mc']; |
|
1174 | 1230 | } |
1175 | - else |
|
1176 | - $user_info['mod_cache'] = $_SESSION['mc']; |
|
1177 | 1231 | |
1178 | 1232 | // This is a useful phantom permission added to the current user, and only the current user while they are logged in. |
1179 | 1233 | // For example this drastically simplifies certain changes to the profile area. |
1180 | 1234 | $user_info['permissions'][] = 'is_not_guest'; |
1181 | 1235 | // And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions. |
1182 | 1236 | $user_info['permissions'][] = 'profile_view_own'; |
1183 | - if (in_array('profile_view', $user_info['permissions'])) |
|
1184 | - $user_info['permissions'][] = 'profile_view_any'; |
|
1237 | + if (in_array('profile_view', $user_info['permissions'])) { |
|
1238 | + $user_info['permissions'][] = 'profile_view_any'; |
|
1239 | + } |
|
1185 | 1240 | } |
1186 | 1241 | } |
1187 | 1242 | |
@@ -1199,8 +1254,9 @@ discard block |
||
1199 | 1254 | global $image_proxy_enabled, $image_proxy_secret, $boardurl; |
1200 | 1255 | |
1201 | 1256 | // Can't just look for no users :P. |
1202 | - if (empty($users)) |
|
1203 | - return array(); |
|
1257 | + if (empty($users)) { |
|
1258 | + return array(); |
|
1259 | + } |
|
1204 | 1260 | |
1205 | 1261 | // Pass the set value |
1206 | 1262 | $context['loadMemberContext_set'] = $set; |
@@ -1215,8 +1271,9 @@ discard block |
||
1215 | 1271 | for ($i = 0, $n = count($users); $i < $n; $i++) |
1216 | 1272 | { |
1217 | 1273 | $data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240); |
1218 | - if ($data == null) |
|
1219 | - continue; |
|
1274 | + if ($data == null) { |
|
1275 | + continue; |
|
1276 | + } |
|
1220 | 1277 | |
1221 | 1278 | $loaded_ids[] = $data['id_member']; |
1222 | 1279 | $user_profile[$data['id_member']] = $data; |
@@ -1283,13 +1340,16 @@ discard block |
||
1283 | 1340 | $row['avatar_original'] = !empty($row['avatar']) ? $row['avatar'] : ''; |
1284 | 1341 | |
1285 | 1342 | // Take care of proxying avatar if required, do this here for maximum reach |
1286 | - if ((!empty($row['avatar'])) && $image_proxy_enabled && stripos($row['avatar'], 'http://') !== false) |
|
1287 | - $row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret); |
|
1343 | + if ((!empty($row['avatar'])) && $image_proxy_enabled && stripos($row['avatar'], 'http://') !== false) { |
|
1344 | + $row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret); |
|
1345 | + } |
|
1288 | 1346 | |
1289 | - if (isset($row['member_ip'])) |
|
1290 | - $row['member_ip'] = inet_dtop($row['member_ip']); |
|
1291 | - if (isset($row['member_ip2'])) |
|
1292 | - $row['member_ip2'] = inet_dtop($row['member_ip2']); |
|
1347 | + if (isset($row['member_ip'])) { |
|
1348 | + $row['member_ip'] = inet_dtop($row['member_ip']); |
|
1349 | + } |
|
1350 | + if (isset($row['member_ip2'])) { |
|
1351 | + $row['member_ip2'] = inet_dtop($row['member_ip2']); |
|
1352 | + } |
|
1293 | 1353 | $new_loaded_ids[] = $row['id_member']; |
1294 | 1354 | $loaded_ids[] = $row['id_member']; |
1295 | 1355 | $row['options'] = array(); |
@@ -1308,8 +1368,9 @@ discard block |
||
1308 | 1368 | 'loaded_ids' => $new_loaded_ids, |
1309 | 1369 | ) |
1310 | 1370 | ); |
1311 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1312 | - $user_profile[$row['id_member']]['options'][$row['variable']] = $row['value']; |
|
1371 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1372 | + $user_profile[$row['id_member']]['options'][$row['variable']] = $row['value']; |
|
1373 | + } |
|
1313 | 1374 | $smcFunc['db_free_result']($request); |
1314 | 1375 | } |
1315 | 1376 | |
@@ -1320,10 +1381,11 @@ discard block |
||
1320 | 1381 | { |
1321 | 1382 | foreach ($loaded_ids as $a_member) |
1322 | 1383 | { |
1323 | - if (!empty($user_profile[$a_member]['additional_groups'])) |
|
1324 | - $groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups'])); |
|
1325 | - else |
|
1326 | - $groups = array($user_profile[$a_member]['id_group']); |
|
1384 | + if (!empty($user_profile[$a_member]['additional_groups'])) { |
|
1385 | + $groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups'])); |
|
1386 | + } else { |
|
1387 | + $groups = array($user_profile[$a_member]['id_group']); |
|
1388 | + } |
|
1327 | 1389 | |
1328 | 1390 | $temp = array_intersect($groups, array_keys($board_info['moderator_groups'])); |
1329 | 1391 | |
@@ -1336,8 +1398,9 @@ discard block |
||
1336 | 1398 | |
1337 | 1399 | if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3) |
1338 | 1400 | { |
1339 | - for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) |
|
1340 | - cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240); |
|
1401 | + for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) { |
|
1402 | + cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240); |
|
1403 | + } |
|
1341 | 1404 | } |
1342 | 1405 | |
1343 | 1406 | // Are we loading any moderators? If so, fix their group data... |
@@ -1363,14 +1426,17 @@ discard block |
||
1363 | 1426 | foreach ($temp_mods as $id) |
1364 | 1427 | { |
1365 | 1428 | // By popular demand, don't show admins or global moderators as moderators. |
1366 | - if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) |
|
1367 | - $user_profile[$id]['member_group'] = $row['member_group']; |
|
1429 | + if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) { |
|
1430 | + $user_profile[$id]['member_group'] = $row['member_group']; |
|
1431 | + } |
|
1368 | 1432 | |
1369 | 1433 | // If the Moderator group has no color or icons, but their group does... don't overwrite. |
1370 | - if (!empty($row['icons'])) |
|
1371 | - $user_profile[$id]['icons'] = $row['icons']; |
|
1372 | - if (!empty($row['member_group_color'])) |
|
1373 | - $user_profile[$id]['member_group_color'] = $row['member_group_color']; |
|
1434 | + if (!empty($row['icons'])) { |
|
1435 | + $user_profile[$id]['icons'] = $row['icons']; |
|
1436 | + } |
|
1437 | + if (!empty($row['member_group_color'])) { |
|
1438 | + $user_profile[$id]['member_group_color'] = $row['member_group_color']; |
|
1439 | + } |
|
1374 | 1440 | } |
1375 | 1441 | } |
1376 | 1442 | |
@@ -1392,12 +1458,14 @@ discard block |
||
1392 | 1458 | static $loadedLanguages = array(); |
1393 | 1459 | |
1394 | 1460 | // If this person's data is already loaded, skip it. |
1395 | - if (isset($dataLoaded[$user])) |
|
1396 | - return true; |
|
1461 | + if (isset($dataLoaded[$user])) { |
|
1462 | + return true; |
|
1463 | + } |
|
1397 | 1464 | |
1398 | 1465 | // We can't load guests or members not loaded by loadMemberData()! |
1399 | - if ($user == 0) |
|
1400 | - return false; |
|
1466 | + if ($user == 0) { |
|
1467 | + return false; |
|
1468 | + } |
|
1401 | 1469 | if (!isset($user_profile[$user])) |
1402 | 1470 | { |
1403 | 1471 | trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING); |
@@ -1423,12 +1491,16 @@ discard block |
||
1423 | 1491 | $buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array(); |
1424 | 1492 | |
1425 | 1493 | //We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme |
1426 | - if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists |
|
1494 | + if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) { |
|
1495 | + //icon is set and exists |
|
1427 | 1496 | $group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1]; |
1428 | - elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default |
|
1497 | + } elseif (isset($profile['icons'][1])) { |
|
1498 | + //icon is set and doesn't exist, fallback to default |
|
1429 | 1499 | $group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1]; |
1430 | - else //not set, bye bye |
|
1500 | + } else { |
|
1501 | + //not set, bye bye |
|
1431 | 1502 | $group_icon_url = ''; |
1503 | + } |
|
1432 | 1504 | |
1433 | 1505 | // These minimal values are always loaded |
1434 | 1506 | $memberContext[$user] = array( |
@@ -1447,8 +1519,9 @@ discard block |
||
1447 | 1519 | if ($context['loadMemberContext_set'] != 'minimal') |
1448 | 1520 | { |
1449 | 1521 | // Go the extra mile and load the user's native language name. |
1450 | - if (empty($loadedLanguages)) |
|
1451 | - $loadedLanguages = getLanguages(); |
|
1522 | + if (empty($loadedLanguages)) { |
|
1523 | + $loadedLanguages = getLanguages(); |
|
1524 | + } |
|
1452 | 1525 | |
1453 | 1526 | $memberContext[$user] += array( |
1454 | 1527 | 'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>', |
@@ -1502,31 +1575,33 @@ discard block |
||
1502 | 1575 | { |
1503 | 1576 | if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://'))) |
1504 | 1577 | { |
1505 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) |
|
1506 | - $image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11)); |
|
1507 | - else |
|
1508 | - $image = get_gravatar_url($profile['email_address']); |
|
1509 | - } |
|
1510 | - else |
|
1578 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) { |
|
1579 | + $image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11)); |
|
1580 | + } else { |
|
1581 | + $image = get_gravatar_url($profile['email_address']); |
|
1582 | + } |
|
1583 | + } else |
|
1511 | 1584 | { |
1512 | 1585 | // So it's stored in the member table? |
1513 | 1586 | if (!empty($profile['avatar'])) |
1514 | 1587 | { |
1515 | 1588 | $image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar']; |
1589 | + } elseif (!empty($profile['filename'])) { |
|
1590 | + $image = $modSettings['custom_avatar_url'] . '/' . $profile['filename']; |
|
1516 | 1591 | } |
1517 | - elseif (!empty($profile['filename'])) |
|
1518 | - $image = $modSettings['custom_avatar_url'] . '/' . $profile['filename']; |
|
1519 | 1592 | // Right... no avatar...use the default one |
1520 | - else |
|
1521 | - $image = $modSettings['avatar_url'] . '/default.png'; |
|
1593 | + else { |
|
1594 | + $image = $modSettings['avatar_url'] . '/default.png'; |
|
1595 | + } |
|
1522 | 1596 | } |
1523 | - if (!empty($image)) |
|
1524 | - $memberContext[$user]['avatar'] = array( |
|
1597 | + if (!empty($image)) { |
|
1598 | + $memberContext[$user]['avatar'] = array( |
|
1525 | 1599 | 'name' => $profile['avatar'], |
1526 | 1600 | 'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">', |
1527 | 1601 | 'href' => $image, |
1528 | 1602 | 'url' => $image, |
1529 | 1603 | ); |
1604 | + } |
|
1530 | 1605 | } |
1531 | 1606 | |
1532 | 1607 | // Are we also loading the members custom fields into context? |
@@ -1534,35 +1609,41 @@ discard block |
||
1534 | 1609 | { |
1535 | 1610 | $memberContext[$user]['custom_fields'] = array(); |
1536 | 1611 | |
1537 | - if (!isset($context['display_fields'])) |
|
1538 | - $context['display_fields'] = smf_json_decode($modSettings['displayFields'], true); |
|
1612 | + if (!isset($context['display_fields'])) { |
|
1613 | + $context['display_fields'] = smf_json_decode($modSettings['displayFields'], true); |
|
1614 | + } |
|
1539 | 1615 | |
1540 | 1616 | foreach ($context['display_fields'] as $custom) |
1541 | 1617 | { |
1542 | - if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) |
|
1543 | - continue; |
|
1618 | + if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) { |
|
1619 | + continue; |
|
1620 | + } |
|
1544 | 1621 | |
1545 | 1622 | $value = $profile['options'][$custom['col_name']]; |
1546 | 1623 | |
1547 | 1624 | // Don't show the "disabled" option for the "gender" field. |
1548 | - if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') |
|
1549 | - continue; |
|
1625 | + if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') { |
|
1626 | + continue; |
|
1627 | + } |
|
1550 | 1628 | |
1551 | 1629 | // BBC? |
1552 | - if ($custom['bbc']) |
|
1553 | - $value = parse_bbc($value); |
|
1630 | + if ($custom['bbc']) { |
|
1631 | + $value = parse_bbc($value); |
|
1632 | + } |
|
1554 | 1633 | // ... or checkbox? |
1555 | - elseif (isset($custom['type']) && $custom['type'] == 'check') |
|
1556 | - $value = $value ? $txt['yes'] : $txt['no']; |
|
1634 | + elseif (isset($custom['type']) && $custom['type'] == 'check') { |
|
1635 | + $value = $value ? $txt['yes'] : $txt['no']; |
|
1636 | + } |
|
1557 | 1637 | |
1558 | 1638 | // Enclosing the user input within some other text? |
1559 | - if (!empty($custom['enclose'])) |
|
1560 | - $value = strtr($custom['enclose'], array( |
|
1639 | + if (!empty($custom['enclose'])) { |
|
1640 | + $value = strtr($custom['enclose'], array( |
|
1561 | 1641 | '{SCRIPTURL}' => $scripturl, |
1562 | 1642 | '{IMAGES_URL}' => $settings['images_url'], |
1563 | 1643 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
1564 | 1644 | '{INPUT}' => $value, |
1565 | 1645 | )); |
1646 | + } |
|
1566 | 1647 | |
1567 | 1648 | $memberContext[$user]['custom_fields'][] = array( |
1568 | 1649 | 'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'], |
@@ -1589,8 +1670,9 @@ discard block |
||
1589 | 1670 | global $smcFunc, $txt, $scripturl, $settings; |
1590 | 1671 | |
1591 | 1672 | // Do not waste my time... |
1592 | - if (empty($users) || empty($params)) |
|
1593 | - return false; |
|
1673 | + if (empty($users) || empty($params)) { |
|
1674 | + return false; |
|
1675 | + } |
|
1594 | 1676 | |
1595 | 1677 | // Make sure it's an array. |
1596 | 1678 | $users = !is_array($users) ? array($users) : array_unique($users); |
@@ -1614,31 +1696,36 @@ discard block |
||
1614 | 1696 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1615 | 1697 | { |
1616 | 1698 | // BBC? |
1617 | - if (!empty($row['bbc'])) |
|
1618 | - $row['value'] = parse_bbc($row['value']); |
|
1699 | + if (!empty($row['bbc'])) { |
|
1700 | + $row['value'] = parse_bbc($row['value']); |
|
1701 | + } |
|
1619 | 1702 | |
1620 | 1703 | // ... or checkbox? |
1621 | - elseif (isset($row['type']) && $row['type'] == 'check') |
|
1622 | - $row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no']; |
|
1704 | + elseif (isset($row['type']) && $row['type'] == 'check') { |
|
1705 | + $row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no']; |
|
1706 | + } |
|
1623 | 1707 | |
1624 | 1708 | // Enclosing the user input within some other text? |
1625 | - if (!empty($row['enclose'])) |
|
1626 | - $row['value'] = strtr($row['enclose'], array( |
|
1709 | + if (!empty($row['enclose'])) { |
|
1710 | + $row['value'] = strtr($row['enclose'], array( |
|
1627 | 1711 | '{SCRIPTURL}' => $scripturl, |
1628 | 1712 | '{IMAGES_URL}' => $settings['images_url'], |
1629 | 1713 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
1630 | 1714 | '{INPUT}' => un_htmlspecialchars($row['value']), |
1631 | 1715 | )); |
1716 | + } |
|
1632 | 1717 | |
1633 | 1718 | // Send a simple array if there is just 1 param |
1634 | - if (count($params) == 1) |
|
1635 | - $return[$row['id_member']] = $row; |
|
1719 | + if (count($params) == 1) { |
|
1720 | + $return[$row['id_member']] = $row; |
|
1721 | + } |
|
1636 | 1722 | |
1637 | 1723 | // More than 1? knock yourself out... |
1638 | 1724 | else |
1639 | 1725 | { |
1640 | - if (!isset($return[$row['id_member']])) |
|
1641 | - $return[$row['id_member']] = array(); |
|
1726 | + if (!isset($return[$row['id_member']])) { |
|
1727 | + $return[$row['id_member']] = array(); |
|
1728 | + } |
|
1642 | 1729 | |
1643 | 1730 | $return[$row['id_member']][$row['variable']] = $row; |
1644 | 1731 | } |
@@ -1672,8 +1759,9 @@ discard block |
||
1672 | 1759 | global $context; |
1673 | 1760 | |
1674 | 1761 | // Don't know any browser! |
1675 | - if (empty($context['browser'])) |
|
1676 | - detectBrowser(); |
|
1762 | + if (empty($context['browser'])) { |
|
1763 | + detectBrowser(); |
|
1764 | + } |
|
1677 | 1765 | |
1678 | 1766 | return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false; |
1679 | 1767 | } |
@@ -1691,8 +1779,9 @@ discard block |
||
1691 | 1779 | global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled; |
1692 | 1780 | |
1693 | 1781 | // The theme was specified by parameter. |
1694 | - if (!empty($id_theme)) |
|
1695 | - $id_theme = (int) $id_theme; |
|
1782 | + if (!empty($id_theme)) { |
|
1783 | + $id_theme = (int) $id_theme; |
|
1784 | + } |
|
1696 | 1785 | // The theme was specified by REQUEST. |
1697 | 1786 | elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) |
1698 | 1787 | { |
@@ -1700,51 +1789,58 @@ discard block |
||
1700 | 1789 | $_SESSION['id_theme'] = $id_theme; |
1701 | 1790 | } |
1702 | 1791 | // The theme was specified by REQUEST... previously. |
1703 | - elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) |
|
1704 | - $id_theme = (int) $_SESSION['id_theme']; |
|
1792 | + elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) { |
|
1793 | + $id_theme = (int) $_SESSION['id_theme']; |
|
1794 | + } |
|
1705 | 1795 | // The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.) |
1706 | - elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) |
|
1707 | - $id_theme = $user_info['theme']; |
|
1796 | + elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) { |
|
1797 | + $id_theme = $user_info['theme']; |
|
1798 | + } |
|
1708 | 1799 | // The theme was specified by the board. |
1709 | - elseif (!empty($board_info['theme'])) |
|
1710 | - $id_theme = $board_info['theme']; |
|
1800 | + elseif (!empty($board_info['theme'])) { |
|
1801 | + $id_theme = $board_info['theme']; |
|
1802 | + } |
|
1711 | 1803 | // The theme is the forum's default. |
1712 | - else |
|
1713 | - $id_theme = $modSettings['theme_guests']; |
|
1804 | + else { |
|
1805 | + $id_theme = $modSettings['theme_guests']; |
|
1806 | + } |
|
1714 | 1807 | |
1715 | 1808 | // Verify the id_theme... no foul play. |
1716 | 1809 | // Always allow the board specific theme, if they are overriding. |
1717 | - if (!empty($board_info['theme']) && $board_info['override_theme']) |
|
1718 | - $id_theme = $board_info['theme']; |
|
1810 | + if (!empty($board_info['theme']) && $board_info['override_theme']) { |
|
1811 | + $id_theme = $board_info['theme']; |
|
1812 | + } |
|
1719 | 1813 | // If they have specified a particular theme to use with SSI allow it to be used. |
1720 | - elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) |
|
1721 | - $id_theme = (int) $id_theme; |
|
1722 | - elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum')) |
|
1814 | + elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) { |
|
1815 | + $id_theme = (int) $id_theme; |
|
1816 | + } elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum')) |
|
1723 | 1817 | { |
1724 | 1818 | $themes = explode(',', $modSettings['enableThemes']); |
1725 | - if (!in_array($id_theme, $themes)) |
|
1726 | - $id_theme = $modSettings['theme_guests']; |
|
1727 | - else |
|
1819 | + if (!in_array($id_theme, $themes)) { |
|
1820 | + $id_theme = $modSettings['theme_guests']; |
|
1821 | + } else { |
|
1822 | + $id_theme = (int) $id_theme; |
|
1823 | + } |
|
1824 | + } else { |
|
1728 | 1825 | $id_theme = (int) $id_theme; |
1729 | 1826 | } |
1730 | - else |
|
1731 | - $id_theme = (int) $id_theme; |
|
1732 | 1827 | |
1733 | 1828 | $member = empty($user_info['id']) ? -1 : $user_info['id']; |
1734 | 1829 | |
1735 | 1830 | // Disable image proxy if we don't have SSL enabled |
1736 | - if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) |
|
1737 | - $image_proxy_enabled = false; |
|
1831 | + if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) { |
|
1832 | + $image_proxy_enabled = false; |
|
1833 | + } |
|
1738 | 1834 | |
1739 | 1835 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated']) |
1740 | 1836 | { |
1741 | 1837 | $themeData = $temp; |
1742 | 1838 | $flag = true; |
1839 | + } elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) { |
|
1840 | + $themeData = $temp + array($member => array()); |
|
1841 | + } else { |
|
1842 | + $themeData = array(-1 => array(), 0 => array(), $member => array()); |
|
1743 | 1843 | } |
1744 | - elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) |
|
1745 | - $themeData = $temp + array($member => array()); |
|
1746 | - else |
|
1747 | - $themeData = array(-1 => array(), 0 => array(), $member => array()); |
|
1748 | 1844 | |
1749 | 1845 | if (empty($flag)) |
1750 | 1846 | { |
@@ -1763,31 +1859,37 @@ discard block |
||
1763 | 1859 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
1764 | 1860 | { |
1765 | 1861 | // There are just things we shouldn't be able to change as members. |
1766 | - if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) |
|
1767 | - continue; |
|
1862 | + if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) { |
|
1863 | + continue; |
|
1864 | + } |
|
1768 | 1865 | |
1769 | 1866 | // If this is the theme_dir of the default theme, store it. |
1770 | - if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) |
|
1771 | - $themeData[0]['default_' . $row['variable']] = $row['value']; |
|
1867 | + if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) { |
|
1868 | + $themeData[0]['default_' . $row['variable']] = $row['value']; |
|
1869 | + } |
|
1772 | 1870 | |
1773 | 1871 | // If this isn't set yet, is a theme option, or is not the default theme.. |
1774 | - if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') |
|
1775 | - $themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value']; |
|
1872 | + if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') { |
|
1873 | + $themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value']; |
|
1874 | + } |
|
1776 | 1875 | } |
1777 | 1876 | $smcFunc['db_free_result']($result); |
1778 | 1877 | |
1779 | - if (!empty($themeData[-1])) |
|
1780 | - foreach ($themeData[-1] as $k => $v) |
|
1878 | + if (!empty($themeData[-1])) { |
|
1879 | + foreach ($themeData[-1] as $k => $v) |
|
1781 | 1880 | { |
1782 | 1881 | if (!isset($themeData[$member][$k])) |
1783 | 1882 | $themeData[$member][$k] = $v; |
1883 | + } |
|
1784 | 1884 | } |
1785 | 1885 | |
1786 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
1787 | - cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60); |
|
1886 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
1887 | + cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60); |
|
1888 | + } |
|
1788 | 1889 | // Only if we didn't already load that part of the cache... |
1789 | - elseif (!isset($temp)) |
|
1790 | - cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90); |
|
1890 | + elseif (!isset($temp)) { |
|
1891 | + cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90); |
|
1892 | + } |
|
1791 | 1893 | } |
1792 | 1894 | |
1793 | 1895 | $settings = $themeData[0]; |
@@ -1804,20 +1906,24 @@ discard block |
||
1804 | 1906 | $settings['template_dirs'][] = $settings['theme_dir']; |
1805 | 1907 | |
1806 | 1908 | // Based on theme (if there is one). |
1807 | - if (!empty($settings['base_theme_dir'])) |
|
1808 | - $settings['template_dirs'][] = $settings['base_theme_dir']; |
|
1909 | + if (!empty($settings['base_theme_dir'])) { |
|
1910 | + $settings['template_dirs'][] = $settings['base_theme_dir']; |
|
1911 | + } |
|
1809 | 1912 | |
1810 | 1913 | // Lastly the default theme. |
1811 | - if ($settings['theme_dir'] != $settings['default_theme_dir']) |
|
1812 | - $settings['template_dirs'][] = $settings['default_theme_dir']; |
|
1914 | + if ($settings['theme_dir'] != $settings['default_theme_dir']) { |
|
1915 | + $settings['template_dirs'][] = $settings['default_theme_dir']; |
|
1916 | + } |
|
1813 | 1917 | |
1814 | - if (!$initialize) |
|
1815 | - return; |
|
1918 | + if (!$initialize) { |
|
1919 | + return; |
|
1920 | + } |
|
1816 | 1921 | |
1817 | 1922 | // Check to see if we're forcing SSL |
1818 | 1923 | if (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 && empty($maintenance) && |
1819 | - (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') |
|
1820 | - redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://'))); |
|
1924 | + (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') { |
|
1925 | + redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://'))); |
|
1926 | + } |
|
1821 | 1927 | |
1822 | 1928 | // Check to see if they're accessing it from the wrong place. |
1823 | 1929 | if (isset($_SERVER['HTTP_HOST']) || isset($_SERVER['SERVER_NAME'])) |
@@ -1825,8 +1931,9 @@ discard block |
||
1825 | 1931 | $detected_url = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on' ? 'https://' : 'http://'; |
1826 | 1932 | $detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST']; |
1827 | 1933 | $temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/')); |
1828 | - if ($temp != '/') |
|
1829 | - $detected_url .= $temp; |
|
1934 | + if ($temp != '/') { |
|
1935 | + $detected_url .= $temp; |
|
1936 | + } |
|
1830 | 1937 | } |
1831 | 1938 | if (isset($detected_url) && $detected_url != $boardurl) |
1832 | 1939 | { |
@@ -1838,8 +1945,9 @@ discard block |
||
1838 | 1945 | foreach ($aliases as $alias) |
1839 | 1946 | { |
1840 | 1947 | // Rip off all the boring parts, spaces, etc. |
1841 | - if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) |
|
1842 | - $do_fix = true; |
|
1948 | + if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) { |
|
1949 | + $do_fix = true; |
|
1950 | + } |
|
1843 | 1951 | } |
1844 | 1952 | } |
1845 | 1953 | |
@@ -1847,20 +1955,22 @@ discard block |
||
1847 | 1955 | if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI') |
1848 | 1956 | { |
1849 | 1957 | // Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;). |
1850 | - if (empty($_GET)) |
|
1851 | - redirectexit('wwwRedirect'); |
|
1852 | - else |
|
1958 | + if (empty($_GET)) { |
|
1959 | + redirectexit('wwwRedirect'); |
|
1960 | + } else |
|
1853 | 1961 | { |
1854 | 1962 | list ($k, $v) = each($_GET); |
1855 | 1963 | |
1856 | - if ($k != 'wwwRedirect') |
|
1857 | - redirectexit('wwwRedirect;' . $k . '=' . $v); |
|
1964 | + if ($k != 'wwwRedirect') { |
|
1965 | + redirectexit('wwwRedirect;' . $k . '=' . $v); |
|
1966 | + } |
|
1858 | 1967 | } |
1859 | 1968 | } |
1860 | 1969 | |
1861 | 1970 | // #3 is just a check for SSL... |
1862 | - if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) |
|
1863 | - $do_fix = true; |
|
1971 | + if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) { |
|
1972 | + $do_fix = true; |
|
1973 | + } |
|
1864 | 1974 | |
1865 | 1975 | // Okay, #4 - perhaps it's an IP address? We're gonna want to use that one, then. (assuming it's the IP or something...) |
1866 | 1976 | if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1) |
@@ -1894,8 +2004,9 @@ discard block |
||
1894 | 2004 | $board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl)); |
1895 | 2005 | } |
1896 | 2006 | } |
1897 | - foreach ($context['linktree'] as $k => $dummy) |
|
1898 | - $context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl)); |
|
2007 | + foreach ($context['linktree'] as $k => $dummy) { |
|
2008 | + $context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl)); |
|
2009 | + } |
|
1899 | 2010 | } |
1900 | 2011 | } |
1901 | 2012 | // Set up the contextual user array. |
@@ -1914,16 +2025,16 @@ discard block |
||
1914 | 2025 | 'email' => $user_info['email'], |
1915 | 2026 | 'ignoreusers' => $user_info['ignoreusers'], |
1916 | 2027 | ); |
1917 | - if (!$context['user']['is_guest']) |
|
1918 | - $context['user']['name'] = $user_info['name']; |
|
1919 | - elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) |
|
1920 | - $context['user']['name'] = $txt['guest_title']; |
|
2028 | + if (!$context['user']['is_guest']) { |
|
2029 | + $context['user']['name'] = $user_info['name']; |
|
2030 | + } elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) { |
|
2031 | + $context['user']['name'] = $txt['guest_title']; |
|
2032 | + } |
|
1921 | 2033 | |
1922 | 2034 | // Determine the current smiley set. |
1923 | 2035 | $user_info['smiley_set'] = (!in_array($user_info['smiley_set'], explode(',', $modSettings['smiley_sets_known'])) && $user_info['smiley_set'] != 'none') || empty($modSettings['smiley_sets_enable']) ? (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default']) : $user_info['smiley_set']; |
1924 | 2036 | $context['user']['smiley_set'] = $user_info['smiley_set']; |
1925 | - } |
|
1926 | - else |
|
2037 | + } else |
|
1927 | 2038 | { |
1928 | 2039 | $context['user'] = array( |
1929 | 2040 | 'id' => -1, |
@@ -1939,18 +2050,24 @@ discard block |
||
1939 | 2050 | } |
1940 | 2051 | |
1941 | 2052 | // Some basic information... |
1942 | - if (!isset($context['html_headers'])) |
|
1943 | - $context['html_headers'] = ''; |
|
1944 | - if (!isset($context['javascript_files'])) |
|
1945 | - $context['javascript_files'] = array(); |
|
1946 | - if (!isset($context['css_files'])) |
|
1947 | - $context['css_files'] = array(); |
|
1948 | - if (!isset($context['css_header'])) |
|
1949 | - $context['css_header'] = array(); |
|
1950 | - if (!isset($context['javascript_inline'])) |
|
1951 | - $context['javascript_inline'] = array('standard' => array(), 'defer' => array()); |
|
1952 | - if (!isset($context['javascript_vars'])) |
|
1953 | - $context['javascript_vars'] = array(); |
|
2053 | + if (!isset($context['html_headers'])) { |
|
2054 | + $context['html_headers'] = ''; |
|
2055 | + } |
|
2056 | + if (!isset($context['javascript_files'])) { |
|
2057 | + $context['javascript_files'] = array(); |
|
2058 | + } |
|
2059 | + if (!isset($context['css_files'])) { |
|
2060 | + $context['css_files'] = array(); |
|
2061 | + } |
|
2062 | + if (!isset($context['css_header'])) { |
|
2063 | + $context['css_header'] = array(); |
|
2064 | + } |
|
2065 | + if (!isset($context['javascript_inline'])) { |
|
2066 | + $context['javascript_inline'] = array('standard' => array(), 'defer' => array()); |
|
2067 | + } |
|
2068 | + if (!isset($context['javascript_vars'])) { |
|
2069 | + $context['javascript_vars'] = array(); |
|
2070 | + } |
|
1954 | 2071 | |
1955 | 2072 | $context['login_url'] = (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl) . '?action=login2'; |
1956 | 2073 | $context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | '; |
@@ -1962,8 +2079,9 @@ discard block |
||
1962 | 2079 | $context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null; |
1963 | 2080 | $context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null; |
1964 | 2081 | $context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3; |
1965 | - if (isset($modSettings['load_average'])) |
|
1966 | - $context['load_average'] = $modSettings['load_average']; |
|
2082 | + if (isset($modSettings['load_average'])) { |
|
2083 | + $context['load_average'] = $modSettings['load_average']; |
|
2084 | + } |
|
1967 | 2085 | |
1968 | 2086 | // Detect the browser. This is separated out because it's also used in attachment downloads |
1969 | 2087 | detectBrowser(); |
@@ -1977,8 +2095,9 @@ discard block |
||
1977 | 2095 | // This allows sticking some HTML on the page output - useful for controls. |
1978 | 2096 | $context['insert_after_template'] = ''; |
1979 | 2097 | |
1980 | - if (!isset($txt)) |
|
1981 | - $txt = array(); |
|
2098 | + if (!isset($txt)) { |
|
2099 | + $txt = array(); |
|
2100 | + } |
|
1982 | 2101 | |
1983 | 2102 | $simpleActions = array( |
1984 | 2103 | 'findmember', |
@@ -2024,9 +2143,10 @@ discard block |
||
2024 | 2143 | |
2025 | 2144 | // See if theres any extra param to check. |
2026 | 2145 | $requiresXML = false; |
2027 | - foreach ($extraParams as $key => $extra) |
|
2028 | - if (isset($_REQUEST[$extra])) |
|
2146 | + foreach ($extraParams as $key => $extra) { |
|
2147 | + if (isset($_REQUEST[$extra])) |
|
2029 | 2148 | $requiresXML = true; |
2149 | + } |
|
2030 | 2150 | |
2031 | 2151 | // Output is fully XML, so no need for the index template. |
2032 | 2152 | if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML)) |
@@ -2041,37 +2161,39 @@ discard block |
||
2041 | 2161 | { |
2042 | 2162 | loadLanguage('index+Modifications'); |
2043 | 2163 | $context['template_layers'] = array(); |
2044 | - } |
|
2045 | - |
|
2046 | - else |
|
2164 | + } else |
|
2047 | 2165 | { |
2048 | 2166 | // Custom templates to load, or just default? |
2049 | - if (isset($settings['theme_templates'])) |
|
2050 | - $templates = explode(',', $settings['theme_templates']); |
|
2051 | - else |
|
2052 | - $templates = array('index'); |
|
2167 | + if (isset($settings['theme_templates'])) { |
|
2168 | + $templates = explode(',', $settings['theme_templates']); |
|
2169 | + } else { |
|
2170 | + $templates = array('index'); |
|
2171 | + } |
|
2053 | 2172 | |
2054 | 2173 | // Load each template... |
2055 | - foreach ($templates as $template) |
|
2056 | - loadTemplate($template); |
|
2174 | + foreach ($templates as $template) { |
|
2175 | + loadTemplate($template); |
|
2176 | + } |
|
2057 | 2177 | |
2058 | 2178 | // ...and attempt to load their associated language files. |
2059 | 2179 | $required_files = implode('+', array_merge($templates, array('Modifications'))); |
2060 | 2180 | loadLanguage($required_files, '', false); |
2061 | 2181 | |
2062 | 2182 | // Custom template layers? |
2063 | - if (isset($settings['theme_layers'])) |
|
2064 | - $context['template_layers'] = explode(',', $settings['theme_layers']); |
|
2065 | - else |
|
2066 | - $context['template_layers'] = array('html', 'body'); |
|
2183 | + if (isset($settings['theme_layers'])) { |
|
2184 | + $context['template_layers'] = explode(',', $settings['theme_layers']); |
|
2185 | + } else { |
|
2186 | + $context['template_layers'] = array('html', 'body'); |
|
2187 | + } |
|
2067 | 2188 | } |
2068 | 2189 | |
2069 | 2190 | // Initialize the theme. |
2070 | 2191 | loadSubTemplate('init', 'ignore'); |
2071 | 2192 | |
2072 | 2193 | // Allow overriding the board wide time/number formats. |
2073 | - if (empty($user_settings['time_format']) && !empty($txt['time_format'])) |
|
2074 | - $user_info['time_format'] = $txt['time_format']; |
|
2194 | + if (empty($user_settings['time_format']) && !empty($txt['time_format'])) { |
|
2195 | + $user_info['time_format'] = $txt['time_format']; |
|
2196 | + } |
|
2075 | 2197 | |
2076 | 2198 | // Set the character set from the template. |
2077 | 2199 | $context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']; |
@@ -2079,12 +2201,14 @@ discard block |
||
2079 | 2201 | $context['right_to_left'] = !empty($txt['lang_rtl']); |
2080 | 2202 | |
2081 | 2203 | // Guests may still need a name. |
2082 | - if ($context['user']['is_guest'] && empty($context['user']['name'])) |
|
2083 | - $context['user']['name'] = $txt['guest_title']; |
|
2204 | + if ($context['user']['is_guest'] && empty($context['user']['name'])) { |
|
2205 | + $context['user']['name'] = $txt['guest_title']; |
|
2206 | + } |
|
2084 | 2207 | |
2085 | 2208 | // Any theme-related strings that need to be loaded? |
2086 | - if (!empty($settings['require_theme_strings'])) |
|
2087 | - loadLanguage('ThemeStrings', '', false); |
|
2209 | + if (!empty($settings['require_theme_strings'])) { |
|
2210 | + loadLanguage('ThemeStrings', '', false); |
|
2211 | + } |
|
2088 | 2212 | |
2089 | 2213 | // Make a special URL for the language. |
2090 | 2214 | $settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']); |
@@ -2095,8 +2219,9 @@ discard block |
||
2095 | 2219 | // Here is my luvly Responsive CSS |
2096 | 2220 | loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true), 'smf_responsive'); |
2097 | 2221 | |
2098 | - if ($context['right_to_left']) |
|
2099 | - loadCSSFile('rtl.css', array(), 'smf_rtl'); |
|
2222 | + if ($context['right_to_left']) { |
|
2223 | + loadCSSFile('rtl.css', array(), 'smf_rtl'); |
|
2224 | + } |
|
2100 | 2225 | |
2101 | 2226 | // We allow theme variants, because we're cool. |
2102 | 2227 | $context['theme_variant'] = ''; |
@@ -2104,14 +2229,17 @@ discard block |
||
2104 | 2229 | if (!empty($settings['theme_variants'])) |
2105 | 2230 | { |
2106 | 2231 | // Overriding - for previews and that ilk. |
2107 | - if (!empty($_REQUEST['variant'])) |
|
2108 | - $_SESSION['id_variant'] = $_REQUEST['variant']; |
|
2232 | + if (!empty($_REQUEST['variant'])) { |
|
2233 | + $_SESSION['id_variant'] = $_REQUEST['variant']; |
|
2234 | + } |
|
2109 | 2235 | // User selection? |
2110 | - if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) |
|
2111 | - $context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : ''); |
|
2236 | + if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) { |
|
2237 | + $context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : ''); |
|
2238 | + } |
|
2112 | 2239 | // If not a user variant, select the default. |
2113 | - if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) |
|
2114 | - $context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0]; |
|
2240 | + if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) { |
|
2241 | + $context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0]; |
|
2242 | + } |
|
2115 | 2243 | |
2116 | 2244 | // Do this to keep things easier in the templates. |
2117 | 2245 | $context['theme_variant'] = '_' . $context['theme_variant']; |
@@ -2120,20 +2248,23 @@ discard block |
||
2120 | 2248 | if (!empty($context['theme_variant'])) |
2121 | 2249 | { |
2122 | 2250 | loadCSSFile('index' . $context['theme_variant'] . '.css', array(), 'smf_index' . $context['theme_variant']); |
2123 | - if ($context['right_to_left']) |
|
2124 | - loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']); |
|
2251 | + if ($context['right_to_left']) { |
|
2252 | + loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']); |
|
2253 | + } |
|
2125 | 2254 | } |
2126 | 2255 | } |
2127 | 2256 | |
2128 | 2257 | // Let's be compatible with old themes! |
2129 | - if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) |
|
2130 | - $context['template_layers'] = array('main'); |
|
2258 | + if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) { |
|
2259 | + $context['template_layers'] = array('main'); |
|
2260 | + } |
|
2131 | 2261 | |
2132 | 2262 | $context['tabindex'] = 1; |
2133 | 2263 | |
2134 | 2264 | // Compatibility. |
2135 | - if (!isset($settings['theme_version'])) |
|
2136 | - $modSettings['memberCount'] = $modSettings['totalMembers']; |
|
2265 | + if (!isset($settings['theme_version'])) { |
|
2266 | + $modSettings['memberCount'] = $modSettings['totalMembers']; |
|
2267 | + } |
|
2137 | 2268 | |
2138 | 2269 | // Default JS variables for use in every theme |
2139 | 2270 | $context['javascript_vars'] = array( |
@@ -2152,18 +2283,18 @@ discard block |
||
2152 | 2283 | ); |
2153 | 2284 | |
2154 | 2285 | // Add the JQuery library to the list of files to load. |
2155 | - if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') |
|
2156 | - loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2157 | - |
|
2158 | - elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') |
|
2159 | - loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery'); |
|
2160 | - |
|
2161 | - elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') |
|
2162 | - loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery'); |
|
2286 | + if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') { |
|
2287 | + loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2288 | + } elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') { |
|
2289 | + loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery'); |
|
2290 | + } elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') { |
|
2291 | + loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery'); |
|
2292 | + } |
|
2163 | 2293 | |
2164 | 2294 | // Auto loading? template_javascript() will take care of the local half of this. |
2165 | - else |
|
2166 | - loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2295 | + else { |
|
2296 | + loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2297 | + } |
|
2167 | 2298 | |
2168 | 2299 | // Queue our JQuery plugins! |
2169 | 2300 | loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins'); |
@@ -2186,12 +2317,12 @@ discard block |
||
2186 | 2317 | require_once($sourcedir . '/ScheduledTasks.php'); |
2187 | 2318 | |
2188 | 2319 | // What to do, what to do?! |
2189 | - if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) |
|
2190 | - AutoTask(); |
|
2191 | - else |
|
2192 | - ReduceMailQueue(); |
|
2193 | - } |
|
2194 | - else |
|
2320 | + if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) { |
|
2321 | + AutoTask(); |
|
2322 | + } else { |
|
2323 | + ReduceMailQueue(); |
|
2324 | + } |
|
2325 | + } else |
|
2195 | 2326 | { |
2196 | 2327 | $type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq'; |
2197 | 2328 | $ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time']; |
@@ -2242,8 +2373,9 @@ discard block |
||
2242 | 2373 | foreach ($theme_includes as $include) |
2243 | 2374 | { |
2244 | 2375 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
2245 | - if (file_exists($include)) |
|
2246 | - require_once($include); |
|
2376 | + if (file_exists($include)) { |
|
2377 | + require_once($include); |
|
2378 | + } |
|
2247 | 2379 | } |
2248 | 2380 | } |
2249 | 2381 | |
@@ -2273,16 +2405,19 @@ discard block |
||
2273 | 2405 | // Do any style sheets first, cause we're easy with those. |
2274 | 2406 | if (!empty($style_sheets)) |
2275 | 2407 | { |
2276 | - if (!is_array($style_sheets)) |
|
2277 | - $style_sheets = array($style_sheets); |
|
2408 | + if (!is_array($style_sheets)) { |
|
2409 | + $style_sheets = array($style_sheets); |
|
2410 | + } |
|
2278 | 2411 | |
2279 | - foreach ($style_sheets as $sheet) |
|
2280 | - loadCSSFile($sheet . '.css', array(), $sheet); |
|
2412 | + foreach ($style_sheets as $sheet) { |
|
2413 | + loadCSSFile($sheet . '.css', array(), $sheet); |
|
2414 | + } |
|
2281 | 2415 | } |
2282 | 2416 | |
2283 | 2417 | // No template to load? |
2284 | - if ($template_name === false) |
|
2285 | - return true; |
|
2418 | + if ($template_name === false) { |
|
2419 | + return true; |
|
2420 | + } |
|
2286 | 2421 | |
2287 | 2422 | $loaded = false; |
2288 | 2423 | foreach ($settings['template_dirs'] as $template_dir) |
@@ -2297,12 +2432,14 @@ discard block |
||
2297 | 2432 | |
2298 | 2433 | if ($loaded) |
2299 | 2434 | { |
2300 | - if ($db_show_debug === true) |
|
2301 | - $context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')'; |
|
2435 | + if ($db_show_debug === true) { |
|
2436 | + $context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')'; |
|
2437 | + } |
|
2302 | 2438 | |
2303 | 2439 | // If they have specified an initialization function for this template, go ahead and call it now. |
2304 | - if (function_exists('template_' . $template_name . '_init')) |
|
2305 | - call_user_func('template_' . $template_name . '_init'); |
|
2440 | + if (function_exists('template_' . $template_name . '_init')) { |
|
2441 | + call_user_func('template_' . $template_name . '_init'); |
|
2442 | + } |
|
2306 | 2443 | } |
2307 | 2444 | // Hmmm... doesn't exist?! I don't suppose the directory is wrong, is it? |
2308 | 2445 | elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default')) |
@@ -2322,13 +2459,14 @@ discard block |
||
2322 | 2459 | loadTemplate($template_name); |
2323 | 2460 | } |
2324 | 2461 | // Cause an error otherwise. |
2325 | - elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) |
|
2326 | - fatal_lang_error('theme_template_error', 'template', array((string) $template_name)); |
|
2327 | - elseif ($fatal) |
|
2328 | - die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template')); |
|
2329 | - else |
|
2330 | - return false; |
|
2331 | -} |
|
2462 | + elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) { |
|
2463 | + fatal_lang_error('theme_template_error', 'template', array((string) $template_name)); |
|
2464 | + } elseif ($fatal) { |
|
2465 | + die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template')); |
|
2466 | + } else { |
|
2467 | + return false; |
|
2468 | + } |
|
2469 | + } |
|
2332 | 2470 | |
2333 | 2471 | /** |
2334 | 2472 | * Load a sub-template. |
@@ -2346,17 +2484,19 @@ discard block |
||
2346 | 2484 | { |
2347 | 2485 | global $context, $txt, $db_show_debug; |
2348 | 2486 | |
2349 | - if ($db_show_debug === true) |
|
2350 | - $context['debug']['sub_templates'][] = $sub_template_name; |
|
2487 | + if ($db_show_debug === true) { |
|
2488 | + $context['debug']['sub_templates'][] = $sub_template_name; |
|
2489 | + } |
|
2351 | 2490 | |
2352 | 2491 | // Figure out what the template function is named. |
2353 | 2492 | $theme_function = 'template_' . $sub_template_name; |
2354 | - if (function_exists($theme_function)) |
|
2355 | - $theme_function(); |
|
2356 | - elseif ($fatal === false) |
|
2357 | - fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name)); |
|
2358 | - elseif ($fatal !== 'ignore') |
|
2359 | - die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template')); |
|
2493 | + if (function_exists($theme_function)) { |
|
2494 | + $theme_function(); |
|
2495 | + } elseif ($fatal === false) { |
|
2496 | + fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name)); |
|
2497 | + } elseif ($fatal !== 'ignore') { |
|
2498 | + die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template')); |
|
2499 | + } |
|
2360 | 2500 | |
2361 | 2501 | // Are we showing debugging for templates? Just make sure not to do it before the doctype... |
2362 | 2502 | if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml'])) |
@@ -2393,8 +2533,9 @@ discard block |
||
2393 | 2533 | $params['validate'] = isset($params['validate']) ? $params['validate'] : true; |
2394 | 2534 | |
2395 | 2535 | // If this is an external file, automatically set this to false. |
2396 | - if (!empty($params['external'])) |
|
2397 | - $params['minimize'] = false; |
|
2536 | + if (!empty($params['external'])) { |
|
2537 | + $params['minimize'] = false; |
|
2538 | + } |
|
2398 | 2539 | |
2399 | 2540 | // Account for shorthand like admin.css?alp21 filenames |
2400 | 2541 | $has_seed = strpos($fileName, '.css?'); |
@@ -2411,13 +2552,10 @@ discard block |
||
2411 | 2552 | { |
2412 | 2553 | $fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
2413 | 2554 | $filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
2555 | + } else { |
|
2556 | + $fileUrl = false; |
|
2414 | 2557 | } |
2415 | - |
|
2416 | - else |
|
2417 | - $fileUrl = false; |
|
2418 | - } |
|
2419 | - |
|
2420 | - else |
|
2558 | + } else |
|
2421 | 2559 | { |
2422 | 2560 | $fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
2423 | 2561 | $filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
@@ -2432,12 +2570,14 @@ discard block |
||
2432 | 2570 | } |
2433 | 2571 | |
2434 | 2572 | // Add it to the array for use in the template |
2435 | - if (!empty($fileName)) |
|
2436 | - $context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2573 | + if (!empty($fileName)) { |
|
2574 | + $context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2575 | + } |
|
2437 | 2576 | |
2438 | - if (!empty($context['right_to_left']) && !empty($params['rtl'])) |
|
2439 | - loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0))); |
|
2440 | -} |
|
2577 | + if (!empty($context['right_to_left']) && !empty($params['rtl'])) { |
|
2578 | + loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0))); |
|
2579 | + } |
|
2580 | + } |
|
2441 | 2581 | |
2442 | 2582 | /** |
2443 | 2583 | * Add a block of inline css code to be executed later |
@@ -2454,8 +2594,9 @@ discard block |
||
2454 | 2594 | global $context; |
2455 | 2595 | |
2456 | 2596 | // Gotta add something... |
2457 | - if (empty($css)) |
|
2458 | - return false; |
|
2597 | + if (empty($css)) { |
|
2598 | + return false; |
|
2599 | + } |
|
2459 | 2600 | |
2460 | 2601 | $context['css_header'][] = $css; |
2461 | 2602 | } |
@@ -2490,8 +2631,9 @@ discard block |
||
2490 | 2631 | $params['validate'] = isset($params['validate']) ? $params['validate'] : true; |
2491 | 2632 | |
2492 | 2633 | // If this is an external file, automatically set this to false. |
2493 | - if (!empty($params['external'])) |
|
2494 | - $params['minimize'] = false; |
|
2634 | + if (!empty($params['external'])) { |
|
2635 | + $params['minimize'] = false; |
|
2636 | + } |
|
2495 | 2637 | |
2496 | 2638 | // Account for shorthand like admin.js?alp21 filenames |
2497 | 2639 | $has_seed = strpos($fileName, '.js?'); |
@@ -2508,16 +2650,12 @@ discard block |
||
2508 | 2650 | { |
2509 | 2651 | $fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
2510 | 2652 | $filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
2511 | - } |
|
2512 | - |
|
2513 | - else |
|
2653 | + } else |
|
2514 | 2654 | { |
2515 | 2655 | $fileUrl = false; |
2516 | 2656 | $filePath = false; |
2517 | 2657 | } |
2518 | - } |
|
2519 | - |
|
2520 | - else |
|
2658 | + } else |
|
2521 | 2659 | { |
2522 | 2660 | $fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
2523 | 2661 | $filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
@@ -2532,9 +2670,10 @@ discard block |
||
2532 | 2670 | } |
2533 | 2671 | |
2534 | 2672 | // Add it to the array for use in the template |
2535 | - if (!empty($fileName)) |
|
2536 | - $context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2537 | -} |
|
2673 | + if (!empty($fileName)) { |
|
2674 | + $context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2675 | + } |
|
2676 | + } |
|
2538 | 2677 | |
2539 | 2678 | /** |
2540 | 2679 | * Add a Javascript variable for output later (for feeding text strings and similar to JS) |
@@ -2548,9 +2687,10 @@ discard block |
||
2548 | 2687 | { |
2549 | 2688 | global $context; |
2550 | 2689 | |
2551 | - if (!empty($key) && (!empty($value) || $value === '0')) |
|
2552 | - $context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value; |
|
2553 | -} |
|
2690 | + if (!empty($key) && (!empty($value) || $value === '0')) { |
|
2691 | + $context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value; |
|
2692 | + } |
|
2693 | + } |
|
2554 | 2694 | |
2555 | 2695 | /** |
2556 | 2696 | * Add a block of inline Javascript code to be executed later |
@@ -2567,8 +2707,9 @@ discard block |
||
2567 | 2707 | { |
2568 | 2708 | global $context; |
2569 | 2709 | |
2570 | - if (empty($javascript)) |
|
2571 | - return false; |
|
2710 | + if (empty($javascript)) { |
|
2711 | + return false; |
|
2712 | + } |
|
2572 | 2713 | |
2573 | 2714 | $context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript; |
2574 | 2715 | } |
@@ -2589,15 +2730,18 @@ discard block |
||
2589 | 2730 | static $already_loaded = array(); |
2590 | 2731 | |
2591 | 2732 | // Default to the user's language. |
2592 | - if ($lang == '') |
|
2593 | - $lang = isset($user_info['language']) ? $user_info['language'] : $language; |
|
2733 | + if ($lang == '') { |
|
2734 | + $lang = isset($user_info['language']) ? $user_info['language'] : $language; |
|
2735 | + } |
|
2594 | 2736 | |
2595 | 2737 | // Do we want the English version of language file as fallback? |
2596 | - if (empty($modSettings['disable_language_fallback']) && $lang != 'english') |
|
2597 | - loadLanguage($template_name, 'english', false); |
|
2738 | + if (empty($modSettings['disable_language_fallback']) && $lang != 'english') { |
|
2739 | + loadLanguage($template_name, 'english', false); |
|
2740 | + } |
|
2598 | 2741 | |
2599 | - if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) |
|
2600 | - return $lang; |
|
2742 | + if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) { |
|
2743 | + return $lang; |
|
2744 | + } |
|
2601 | 2745 | |
2602 | 2746 | // Make sure we have $settings - if not we're in trouble and need to find it! |
2603 | 2747 | if (empty($settings['default_theme_dir'])) |
@@ -2608,8 +2752,9 @@ discard block |
||
2608 | 2752 | |
2609 | 2753 | // What theme are we in? |
2610 | 2754 | $theme_name = basename($settings['theme_url']); |
2611 | - if (empty($theme_name)) |
|
2612 | - $theme_name = 'unknown'; |
|
2755 | + if (empty($theme_name)) { |
|
2756 | + $theme_name = 'unknown'; |
|
2757 | + } |
|
2613 | 2758 | |
2614 | 2759 | // For each file open it up and write it out! |
2615 | 2760 | foreach (explode('+', $template_name) as $template) |
@@ -2651,8 +2796,9 @@ discard block |
||
2651 | 2796 | $found = true; |
2652 | 2797 | |
2653 | 2798 | // setlocale is required for basename() & pathinfo() to work properly on the selected language |
2654 | - if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) |
|
2655 | - setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']); |
|
2799 | + if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) { |
|
2800 | + setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']); |
|
2801 | + } |
|
2656 | 2802 | |
2657 | 2803 | break; |
2658 | 2804 | } |
@@ -2692,8 +2838,9 @@ discard block |
||
2692 | 2838 | } |
2693 | 2839 | |
2694 | 2840 | // Keep track of what we're up to soldier. |
2695 | - if ($db_show_debug === true) |
|
2696 | - $context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')'; |
|
2841 | + if ($db_show_debug === true) { |
|
2842 | + $context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')'; |
|
2843 | + } |
|
2697 | 2844 | |
2698 | 2845 | // Remember what we have loaded, and in which language. |
2699 | 2846 | $already_loaded[$template_name] = $lang; |
@@ -2739,8 +2886,9 @@ discard block |
||
2739 | 2886 | ) |
2740 | 2887 | ); |
2741 | 2888 | // In the EXTREMELY unlikely event this happens, give an error message. |
2742 | - if ($smcFunc['db_num_rows']($result) == 0) |
|
2743 | - fatal_lang_error('parent_not_found', 'critical'); |
|
2889 | + if ($smcFunc['db_num_rows']($result) == 0) { |
|
2890 | + fatal_lang_error('parent_not_found', 'critical'); |
|
2891 | + } |
|
2744 | 2892 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
2745 | 2893 | { |
2746 | 2894 | if (!isset($boards[$row['id_board']])) |
@@ -2757,8 +2905,8 @@ discard block |
||
2757 | 2905 | ); |
2758 | 2906 | } |
2759 | 2907 | // If a moderator exists for this board, add that moderator for all children too. |
2760 | - if (!empty($row['id_moderator'])) |
|
2761 | - foreach ($boards as $id => $dummy) |
|
2908 | + if (!empty($row['id_moderator'])) { |
|
2909 | + foreach ($boards as $id => $dummy) |
|
2762 | 2910 | { |
2763 | 2911 | $boards[$id]['moderators'][$row['id_moderator']] = array( |
2764 | 2912 | 'id' => $row['id_moderator'], |
@@ -2766,11 +2914,12 @@ discard block |
||
2766 | 2914 | 'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'], |
2767 | 2915 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>' |
2768 | 2916 | ); |
2917 | + } |
|
2769 | 2918 | } |
2770 | 2919 | |
2771 | 2920 | // If a moderator group exists for this board, add that moderator group for all children too |
2772 | - if (!empty($row['id_moderator_group'])) |
|
2773 | - foreach ($boards as $id => $dummy) |
|
2921 | + if (!empty($row['id_moderator_group'])) { |
|
2922 | + foreach ($boards as $id => $dummy) |
|
2774 | 2923 | { |
2775 | 2924 | $boards[$id]['moderator_groups'][$row['id_moderator_group']] = array( |
2776 | 2925 | 'id' => $row['id_moderator_group'], |
@@ -2778,6 +2927,7 @@ discard block |
||
2778 | 2927 | 'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'], |
2779 | 2928 | 'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>' |
2780 | 2929 | ); |
2930 | + } |
|
2781 | 2931 | } |
2782 | 2932 | } |
2783 | 2933 | $smcFunc['db_free_result']($result); |
@@ -2804,23 +2954,27 @@ discard block |
||
2804 | 2954 | if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null) |
2805 | 2955 | { |
2806 | 2956 | // If we don't have our ucwords function defined yet, let's load the settings data. |
2807 | - if (empty($smcFunc['ucwords'])) |
|
2808 | - reloadSettings(); |
|
2957 | + if (empty($smcFunc['ucwords'])) { |
|
2958 | + reloadSettings(); |
|
2959 | + } |
|
2809 | 2960 | |
2810 | 2961 | // If we don't have our theme information yet, let's get it. |
2811 | - if (empty($settings['default_theme_dir'])) |
|
2812 | - loadTheme(0, false); |
|
2962 | + if (empty($settings['default_theme_dir'])) { |
|
2963 | + loadTheme(0, false); |
|
2964 | + } |
|
2813 | 2965 | |
2814 | 2966 | // Default language directories to try. |
2815 | 2967 | $language_directories = array( |
2816 | 2968 | $settings['default_theme_dir'] . '/languages', |
2817 | 2969 | ); |
2818 | - if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) |
|
2819 | - $language_directories[] = $settings['actual_theme_dir'] . '/languages'; |
|
2970 | + if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) { |
|
2971 | + $language_directories[] = $settings['actual_theme_dir'] . '/languages'; |
|
2972 | + } |
|
2820 | 2973 | |
2821 | 2974 | // We possibly have a base theme directory. |
2822 | - if (!empty($settings['base_theme_dir'])) |
|
2823 | - $language_directories[] = $settings['base_theme_dir'] . '/languages'; |
|
2975 | + if (!empty($settings['base_theme_dir'])) { |
|
2976 | + $language_directories[] = $settings['base_theme_dir'] . '/languages'; |
|
2977 | + } |
|
2824 | 2978 | |
2825 | 2979 | // Remove any duplicates. |
2826 | 2980 | $language_directories = array_unique($language_directories); |
@@ -2834,20 +2988,21 @@ discard block |
||
2834 | 2988 | foreach ($language_directories as $language_dir) |
2835 | 2989 | { |
2836 | 2990 | // Can't look in here... doesn't exist! |
2837 | - if (!file_exists($language_dir)) |
|
2838 | - continue; |
|
2991 | + if (!file_exists($language_dir)) { |
|
2992 | + continue; |
|
2993 | + } |
|
2839 | 2994 | |
2840 | 2995 | $dir = dir($language_dir); |
2841 | 2996 | while ($entry = $dir->read()) |
2842 | 2997 | { |
2843 | 2998 | // Look for the index language file... For good measure skip any "index.language-utf8.php" files |
2844 | - if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) |
|
2845 | - continue; |
|
2846 | - |
|
2847 | - if (!empty($langList) && !empty($langList[$matches[1]])) |
|
2848 | - $langName = $langList[$matches[1]]; |
|
2999 | + if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) { |
|
3000 | + continue; |
|
3001 | + } |
|
2849 | 3002 | |
2850 | - else |
|
3003 | + if (!empty($langList) && !empty($langList[$matches[1]])) { |
|
3004 | + $langName = $langList[$matches[1]]; |
|
3005 | + } else |
|
2851 | 3006 | { |
2852 | 3007 | $langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' '))); |
2853 | 3008 | |
@@ -2888,12 +3043,14 @@ discard block |
||
2888 | 3043 | } |
2889 | 3044 | |
2890 | 3045 | // Do we need to store the lang list? |
2891 | - if (empty($langList)) |
|
2892 | - updateSettings(array('langList' => json_encode($catchLang))); |
|
3046 | + if (empty($langList)) { |
|
3047 | + updateSettings(array('langList' => json_encode($catchLang))); |
|
3048 | + } |
|
2893 | 3049 | |
2894 | 3050 | // Let's cash in on this deal. |
2895 | - if (!empty($modSettings['cache_enable'])) |
|
2896 | - cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600); |
|
3051 | + if (!empty($modSettings['cache_enable'])) { |
|
3052 | + cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600); |
|
3053 | + } |
|
2897 | 3054 | } |
2898 | 3055 | |
2899 | 3056 | return $context['languages']; |
@@ -2916,8 +3073,9 @@ discard block |
||
2916 | 3073 | global $modSettings, $options, $txt; |
2917 | 3074 | static $censor_vulgar = null, $censor_proper; |
2918 | 3075 | |
2919 | - if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') |
|
2920 | - return $text; |
|
3076 | + if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') { |
|
3077 | + return $text; |
|
3078 | + } |
|
2921 | 3079 | |
2922 | 3080 | // If they haven't yet been loaded, load them. |
2923 | 3081 | if ($censor_vulgar == null) |
@@ -2945,9 +3103,9 @@ discard block |
||
2945 | 3103 | { |
2946 | 3104 | $func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace'; |
2947 | 3105 | $text = $func($censor_vulgar, $censor_proper, $text); |
3106 | + } else { |
|
3107 | + $text = preg_replace($censor_vulgar, $censor_proper, $text); |
|
2948 | 3108 | } |
2949 | - else |
|
2950 | - $text = preg_replace($censor_vulgar, $censor_proper, $text); |
|
2951 | 3109 | |
2952 | 3110 | return $text; |
2953 | 3111 | } |
@@ -2973,38 +3131,42 @@ discard block |
||
2973 | 3131 | @ini_set('track_errors', '1'); |
2974 | 3132 | |
2975 | 3133 | // Don't include the file more than once, if $once is true. |
2976 | - if ($once && in_array($filename, $templates)) |
|
2977 | - return; |
|
3134 | + if ($once && in_array($filename, $templates)) { |
|
3135 | + return; |
|
3136 | + } |
|
2978 | 3137 | // Add this file to the include list, whether $once is true or not. |
2979 | - else |
|
2980 | - $templates[] = $filename; |
|
3138 | + else { |
|
3139 | + $templates[] = $filename; |
|
3140 | + } |
|
2981 | 3141 | |
2982 | 3142 | // Are we going to use eval? |
2983 | 3143 | if (empty($modSettings['disableTemplateEval'])) |
2984 | 3144 | { |
2985 | 3145 | $file_found = file_exists($filename) && eval('?' . '>' . rtrim(file_get_contents($filename))) !== false; |
2986 | 3146 | $settings['current_include_filename'] = $filename; |
2987 | - } |
|
2988 | - else |
|
3147 | + } else |
|
2989 | 3148 | { |
2990 | 3149 | $file_found = file_exists($filename); |
2991 | 3150 | |
2992 | - if ($once && $file_found) |
|
2993 | - require_once($filename); |
|
2994 | - elseif ($file_found) |
|
2995 | - require($filename); |
|
3151 | + if ($once && $file_found) { |
|
3152 | + require_once($filename); |
|
3153 | + } elseif ($file_found) { |
|
3154 | + require($filename); |
|
3155 | + } |
|
2996 | 3156 | } |
2997 | 3157 | |
2998 | 3158 | if ($file_found !== true) |
2999 | 3159 | { |
3000 | 3160 | ob_end_clean(); |
3001 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
3002 | - @ob_start('ob_gzhandler'); |
|
3003 | - else |
|
3004 | - ob_start(); |
|
3161 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
3162 | + @ob_start('ob_gzhandler'); |
|
3163 | + } else { |
|
3164 | + ob_start(); |
|
3165 | + } |
|
3005 | 3166 | |
3006 | - if (isset($_GET['debug'])) |
|
3007 | - header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3167 | + if (isset($_GET['debug'])) { |
|
3168 | + header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3169 | + } |
|
3008 | 3170 | |
3009 | 3171 | // Don't cache error pages!! |
3010 | 3172 | header('Expires: Mon, 26 Jul 1997 05:00:00 GMT'); |
@@ -3023,12 +3185,13 @@ discard block |
||
3023 | 3185 | echo '<!DOCTYPE html> |
3024 | 3186 | <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '> |
3025 | 3187 | <head>'; |
3026 | - if (isset($context['character_set'])) |
|
3027 | - echo ' |
|
3188 | + if (isset($context['character_set'])) { |
|
3189 | + echo ' |
|
3028 | 3190 | <meta charset="', $context['character_set'], '">'; |
3191 | + } |
|
3029 | 3192 | |
3030 | - if (!empty($maintenance) && !allowedTo('admin_forum')) |
|
3031 | - echo ' |
|
3193 | + if (!empty($maintenance) && !allowedTo('admin_forum')) { |
|
3194 | + echo ' |
|
3032 | 3195 | <title>', $mtitle, '</title> |
3033 | 3196 | </head> |
3034 | 3197 | <body> |
@@ -3036,8 +3199,8 @@ discard block |
||
3036 | 3199 | ', $mmessage, ' |
3037 | 3200 | </body> |
3038 | 3201 | </html>'; |
3039 | - elseif (!allowedTo('admin_forum')) |
|
3040 | - echo ' |
|
3202 | + } elseif (!allowedTo('admin_forum')) { |
|
3203 | + echo ' |
|
3041 | 3204 | <title>', $txt['template_parse_error'], '</title> |
3042 | 3205 | </head> |
3043 | 3206 | <body> |
@@ -3045,16 +3208,18 @@ discard block |
||
3045 | 3208 | ', $txt['template_parse_error_message'], ' |
3046 | 3209 | </body> |
3047 | 3210 | </html>'; |
3048 | - else |
|
3211 | + } else |
|
3049 | 3212 | { |
3050 | 3213 | require_once($sourcedir . '/Subs-Package.php'); |
3051 | 3214 | |
3052 | 3215 | $error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => ''))); |
3053 | 3216 | $error_array = error_get_last(); |
3054 | - if (empty($error) && ini_get('track_errors') && !empty($error_array)) |
|
3055 | - $error = $error_array['message']; |
|
3056 | - if (empty($error)) |
|
3057 | - $error = $txt['template_parse_errmsg']; |
|
3217 | + if (empty($error) && ini_get('track_errors') && !empty($error_array)) { |
|
3218 | + $error = $error_array['message']; |
|
3219 | + } |
|
3220 | + if (empty($error)) { |
|
3221 | + $error = $txt['template_parse_errmsg']; |
|
3222 | + } |
|
3058 | 3223 | |
3059 | 3224 | $error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>')); |
3060 | 3225 | |
@@ -3065,11 +3230,12 @@ discard block |
||
3065 | 3230 | <h3>', $txt['template_parse_error'], '</h3> |
3066 | 3231 | ', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => ''))); |
3067 | 3232 | |
3068 | - if (!empty($error)) |
|
3069 | - echo ' |
|
3233 | + if (!empty($error)) { |
|
3234 | + echo ' |
|
3070 | 3235 | <hr> |
3071 | 3236 | |
3072 | 3237 | <div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>'; |
3238 | + } |
|
3073 | 3239 | |
3074 | 3240 | // I know, I know... this is VERY COMPLICATED. Still, it's good. |
3075 | 3241 | if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0) |
@@ -3079,10 +3245,11 @@ discard block |
||
3079 | 3245 | $data2 = preg_split('~\<br( /)?\>~', $data2); |
3080 | 3246 | |
3081 | 3247 | // Fix the PHP code stuff... |
3082 | - if (!isBrowser('gecko')) |
|
3083 | - $data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2); |
|
3084 | - else |
|
3085 | - $data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2); |
|
3248 | + if (!isBrowser('gecko')) { |
|
3249 | + $data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2); |
|
3250 | + } else { |
|
3251 | + $data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2); |
|
3252 | + } |
|
3086 | 3253 | |
3087 | 3254 | // Now we get to work around a bug in PHP where it doesn't escape <br>s! |
3088 | 3255 | $j = -1; |
@@ -3090,8 +3257,9 @@ discard block |
||
3090 | 3257 | { |
3091 | 3258 | $j++; |
3092 | 3259 | |
3093 | - if (substr_count($line, '<br>') == 0) |
|
3094 | - continue; |
|
3260 | + if (substr_count($line, '<br>') == 0) { |
|
3261 | + continue; |
|
3262 | + } |
|
3095 | 3263 | |
3096 | 3264 | $n = substr_count($line, '<br>'); |
3097 | 3265 | for ($i = 0; $i < $n; $i++) |
@@ -3110,38 +3278,42 @@ discard block |
||
3110 | 3278 | // Figure out what the color coding was before... |
3111 | 3279 | $line = max($match[1] - 9, 1); |
3112 | 3280 | $last_line = ''; |
3113 | - for ($line2 = $line - 1; $line2 > 1; $line2--) |
|
3114 | - if (strpos($data2[$line2], '<') !== false) |
|
3281 | + for ($line2 = $line - 1; $line2 > 1; $line2--) { |
|
3282 | + if (strpos($data2[$line2], '<') !== false) |
|
3115 | 3283 | { |
3116 | 3284 | if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0) |
3117 | 3285 | $last_line = $color_match[1]; |
3286 | + } |
|
3118 | 3287 | break; |
3119 | 3288 | } |
3120 | 3289 | |
3121 | 3290 | // Show the relevant lines... |
3122 | 3291 | for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++) |
3123 | 3292 | { |
3124 | - if ($line == $match[1]) |
|
3125 | - echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">'; |
|
3293 | + if ($line == $match[1]) { |
|
3294 | + echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">'; |
|
3295 | + } |
|
3126 | 3296 | |
3127 | 3297 | echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> '; |
3128 | - if (isset($data2[$line]) && $data2[$line] != '') |
|
3129 | - echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line]; |
|
3298 | + if (isset($data2[$line]) && $data2[$line] != '') { |
|
3299 | + echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line]; |
|
3300 | + } |
|
3130 | 3301 | |
3131 | 3302 | if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0) |
3132 | 3303 | { |
3133 | 3304 | $last_line = $color_match[1]; |
3134 | 3305 | echo '</', substr($last_line, 1, 4), '>'; |
3306 | + } elseif ($last_line != '' && strpos($data2[$line], '<') !== false) { |
|
3307 | + $last_line = ''; |
|
3308 | + } elseif ($last_line != '' && $data2[$line] != '') { |
|
3309 | + echo '</', substr($last_line, 1, 4), '>'; |
|
3135 | 3310 | } |
3136 | - elseif ($last_line != '' && strpos($data2[$line], '<') !== false) |
|
3137 | - $last_line = ''; |
|
3138 | - elseif ($last_line != '' && $data2[$line] != '') |
|
3139 | - echo '</', substr($last_line, 1, 4), '>'; |
|
3140 | 3311 | |
3141 | - if ($line == $match[1]) |
|
3142 | - echo '</pre></div><pre style="margin: 0;">'; |
|
3143 | - else |
|
3144 | - echo "\n"; |
|
3312 | + if ($line == $match[1]) { |
|
3313 | + echo '</pre></div><pre style="margin: 0;">'; |
|
3314 | + } else { |
|
3315 | + echo "\n"; |
|
3316 | + } |
|
3145 | 3317 | } |
3146 | 3318 | |
3147 | 3319 | echo '</pre></div>'; |
@@ -3165,8 +3337,9 @@ discard block |
||
3165 | 3337 | global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port; |
3166 | 3338 | |
3167 | 3339 | // Figure out what type of database we are using. |
3168 | - if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) |
|
3169 | - $db_type = 'mysql'; |
|
3340 | + if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) { |
|
3341 | + $db_type = 'mysql'; |
|
3342 | + } |
|
3170 | 3343 | |
3171 | 3344 | // Load the file for the database. |
3172 | 3345 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
@@ -3174,8 +3347,9 @@ discard block |
||
3174 | 3347 | $db_options = array(); |
3175 | 3348 | |
3176 | 3349 | // Add in the port if needed |
3177 | - if (!empty($db_port)) |
|
3178 | - $db_options['port'] = $db_port; |
|
3350 | + if (!empty($db_port)) { |
|
3351 | + $db_options['port'] = $db_port; |
|
3352 | + } |
|
3179 | 3353 | |
3180 | 3354 | // If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use. |
3181 | 3355 | if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd)) |
@@ -3194,13 +3368,15 @@ discard block |
||
3194 | 3368 | } |
3195 | 3369 | |
3196 | 3370 | // Safe guard here, if there isn't a valid connection lets put a stop to it. |
3197 | - if (!$db_connection) |
|
3198 | - display_db_error(); |
|
3371 | + if (!$db_connection) { |
|
3372 | + display_db_error(); |
|
3373 | + } |
|
3199 | 3374 | |
3200 | 3375 | // If in SSI mode fix up the prefix. |
3201 | - if (SMF == 'SSI') |
|
3202 | - db_fix_prefix($db_prefix, $db_name); |
|
3203 | -} |
|
3376 | + if (SMF == 'SSI') { |
|
3377 | + db_fix_prefix($db_prefix, $db_name); |
|
3378 | + } |
|
3379 | + } |
|
3204 | 3380 | |
3205 | 3381 | /** |
3206 | 3382 | * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it. |
@@ -3214,10 +3390,11 @@ discard block |
||
3214 | 3390 | global $sourcedir, $cacheAPI, $cache_accelerator; |
3215 | 3391 | |
3216 | 3392 | // Not overriding this and we have a cacheAPI, send it back. |
3217 | - if (empty($overrideCache) && is_object($cacheAPI)) |
|
3218 | - return $cacheAPI; |
|
3219 | - elseif (is_null($cacheAPI)) |
|
3220 | - $cacheAPI = false; |
|
3393 | + if (empty($overrideCache) && is_object($cacheAPI)) { |
|
3394 | + return $cacheAPI; |
|
3395 | + } elseif (is_null($cacheAPI)) { |
|
3396 | + $cacheAPI = false; |
|
3397 | + } |
|
3221 | 3398 | |
3222 | 3399 | // Make sure our class is in session. |
3223 | 3400 | require_once($sourcedir . '/Class-CacheAPI.php'); |
@@ -3238,8 +3415,9 @@ discard block |
||
3238 | 3415 | if (!$testAPI->isSupported()) |
3239 | 3416 | { |
3240 | 3417 | // Can we save ourselves? |
3241 | - if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') |
|
3242 | - return loadCacheAccelerator(null, false); |
|
3418 | + if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') { |
|
3419 | + return loadCacheAccelerator(null, false); |
|
3420 | + } |
|
3243 | 3421 | return false; |
3244 | 3422 | } |
3245 | 3423 | |
@@ -3251,9 +3429,9 @@ discard block |
||
3251 | 3429 | { |
3252 | 3430 | $cacheAPI = $testAPI; |
3253 | 3431 | return $cacheAPI; |
3432 | + } else { |
|
3433 | + return $testAPI; |
|
3254 | 3434 | } |
3255 | - else |
|
3256 | - return $testAPI; |
|
3257 | 3435 | } |
3258 | 3436 | } |
3259 | 3437 | |
@@ -3273,8 +3451,9 @@ discard block |
||
3273 | 3451 | |
3274 | 3452 | // @todo Why are we doing this if caching is disabled? |
3275 | 3453 | |
3276 | - if (function_exists('call_integration_hook')) |
|
3277 | - call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level)); |
|
3454 | + if (function_exists('call_integration_hook')) { |
|
3455 | + call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level)); |
|
3456 | + } |
|
3278 | 3457 | |
3279 | 3458 | /* Refresh the cache if either: |
3280 | 3459 | 1. Caching is disabled. |
@@ -3288,16 +3467,19 @@ discard block |
||
3288 | 3467 | require_once($sourcedir . '/' . $file); |
3289 | 3468 | $cache_block = call_user_func_array($function, $params); |
3290 | 3469 | |
3291 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) |
|
3292 | - cache_put_data($key, $cache_block, $cache_block['expires'] - time()); |
|
3470 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) { |
|
3471 | + cache_put_data($key, $cache_block, $cache_block['expires'] - time()); |
|
3472 | + } |
|
3293 | 3473 | } |
3294 | 3474 | |
3295 | 3475 | // Some cached data may need a freshening up after retrieval. |
3296 | - if (!empty($cache_block['post_retri_eval'])) |
|
3297 | - eval($cache_block['post_retri_eval']); |
|
3476 | + if (!empty($cache_block['post_retri_eval'])) { |
|
3477 | + eval($cache_block['post_retri_eval']); |
|
3478 | + } |
|
3298 | 3479 | |
3299 | - if (function_exists('call_integration_hook')) |
|
3300 | - call_integration_hook('post_cache_quick_get', array(&$cache_block)); |
|
3480 | + if (function_exists('call_integration_hook')) { |
|
3481 | + call_integration_hook('post_cache_quick_get', array(&$cache_block)); |
|
3482 | + } |
|
3301 | 3483 | |
3302 | 3484 | return $cache_block['data']; |
3303 | 3485 | } |
@@ -3324,8 +3506,9 @@ discard block |
||
3324 | 3506 | global $cache_enable, $cacheAPI; |
3325 | 3507 | global $cache_hits, $cache_count, $db_show_debug; |
3326 | 3508 | |
3327 | - if (empty($cache_enable) || empty($cacheAPI)) |
|
3328 | - return; |
|
3509 | + if (empty($cache_enable) || empty($cacheAPI)) { |
|
3510 | + return; |
|
3511 | + } |
|
3329 | 3512 | |
3330 | 3513 | $cache_count = isset($cache_count) ? $cache_count + 1 : 1; |
3331 | 3514 | if (isset($db_show_debug) && $db_show_debug === true) |
@@ -3338,12 +3521,14 @@ discard block |
||
3338 | 3521 | $value = $value === null ? null : json_encode($value); |
3339 | 3522 | $cacheAPI->putData($key, $value, $ttl); |
3340 | 3523 | |
3341 | - if (function_exists('call_integration_hook')) |
|
3342 | - call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl)); |
|
3524 | + if (function_exists('call_integration_hook')) { |
|
3525 | + call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl)); |
|
3526 | + } |
|
3343 | 3527 | |
3344 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
3345 | - $cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st)); |
|
3346 | -} |
|
3528 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3529 | + $cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st)); |
|
3530 | + } |
|
3531 | + } |
|
3347 | 3532 | |
3348 | 3533 | /** |
3349 | 3534 | * Gets the value from the cache specified by key, so long as it is not older than ttl seconds. |
@@ -3359,8 +3544,9 @@ discard block |
||
3359 | 3544 | global $cache_enable, $cacheAPI; |
3360 | 3545 | global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug; |
3361 | 3546 | |
3362 | - if (empty($cache_enable) || empty($cacheAPI)) |
|
3363 | - return; |
|
3547 | + if (empty($cache_enable) || empty($cacheAPI)) { |
|
3548 | + return; |
|
3549 | + } |
|
3364 | 3550 | |
3365 | 3551 | $cache_count = isset($cache_count) ? $cache_count + 1 : 1; |
3366 | 3552 | if (isset($db_show_debug) && $db_show_debug === true) |
@@ -3380,16 +3566,18 @@ discard block |
||
3380 | 3566 | |
3381 | 3567 | if (empty($value)) |
3382 | 3568 | { |
3383 | - if (!is_array($cache_misses)) |
|
3384 | - $cache_misses = array(); |
|
3569 | + if (!is_array($cache_misses)) { |
|
3570 | + $cache_misses = array(); |
|
3571 | + } |
|
3385 | 3572 | |
3386 | 3573 | $cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1; |
3387 | 3574 | $cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get'); |
3388 | 3575 | } |
3389 | 3576 | } |
3390 | 3577 | |
3391 | - if (function_exists('call_integration_hook') && isset($value)) |
|
3392 | - call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value)); |
|
3578 | + if (function_exists('call_integration_hook') && isset($value)) { |
|
3579 | + call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value)); |
|
3580 | + } |
|
3393 | 3581 | |
3394 | 3582 | return empty($value) ? null : smf_json_decode($value, true); |
3395 | 3583 | } |
@@ -3411,8 +3599,9 @@ discard block |
||
3411 | 3599 | global $cacheAPI; |
3412 | 3600 | |
3413 | 3601 | // If we can't get to the API, can't do this. |
3414 | - if (empty($cacheAPI)) |
|
3415 | - return; |
|
3602 | + if (empty($cacheAPI)) { |
|
3603 | + return; |
|
3604 | + } |
|
3416 | 3605 | |
3417 | 3606 | // Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure. |
3418 | 3607 | $cacheAPI->cleanCache($type); |
@@ -3437,8 +3626,9 @@ discard block |
||
3437 | 3626 | global $modSettings, $boardurl, $smcFunc, $image_proxy_enabled, $image_proxy_secret; |
3438 | 3627 | |
3439 | 3628 | // Come on! |
3440 | - if (empty($data)) |
|
3441 | - return array(); |
|
3629 | + if (empty($data)) { |
|
3630 | + return array(); |
|
3631 | + } |
|
3442 | 3632 | |
3443 | 3633 | // Set a nice default var. |
3444 | 3634 | $image = ''; |
@@ -3446,11 +3636,11 @@ discard block |
||
3446 | 3636 | // Gravatar has been set as mandatory! |
3447 | 3637 | if (!empty($modSettings['gravatarOverride'])) |
3448 | 3638 | { |
3449 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) |
|
3450 | - $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3451 | - |
|
3452 | - else if (!empty($data['email'])) |
|
3453 | - $image = get_gravatar_url($data['email']); |
|
3639 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) { |
|
3640 | + $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3641 | + } else if (!empty($data['email'])) { |
|
3642 | + $image = get_gravatar_url($data['email']); |
|
3643 | + } |
|
3454 | 3644 | } |
3455 | 3645 | |
3456 | 3646 | // Look if the user has a gravatar field or has set an external url as avatar. |
@@ -3462,54 +3652,60 @@ discard block |
||
3462 | 3652 | // Gravatar. |
3463 | 3653 | if (stristr($data['avatar'], 'gravatar://')) |
3464 | 3654 | { |
3465 | - if ($data['avatar'] == 'gravatar://') |
|
3466 | - $image = get_gravatar_url($data['email']); |
|
3467 | - |
|
3468 | - elseif (!empty($modSettings['gravatarAllowExtraEmail'])) |
|
3469 | - $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3655 | + if ($data['avatar'] == 'gravatar://') { |
|
3656 | + $image = get_gravatar_url($data['email']); |
|
3657 | + } elseif (!empty($modSettings['gravatarAllowExtraEmail'])) { |
|
3658 | + $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3659 | + } |
|
3470 | 3660 | } |
3471 | 3661 | |
3472 | 3662 | // External url. |
3473 | 3663 | else |
3474 | 3664 | { |
3475 | 3665 | // Using ssl? |
3476 | - if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) |
|
3477 | - $image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret); |
|
3666 | + if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) { |
|
3667 | + $image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret); |
|
3668 | + } |
|
3478 | 3669 | |
3479 | 3670 | // Just a plain external url. |
3480 | - else |
|
3481 | - $image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar']; |
|
3671 | + else { |
|
3672 | + $image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar']; |
|
3673 | + } |
|
3482 | 3674 | } |
3483 | 3675 | } |
3484 | 3676 | |
3485 | 3677 | // Perhaps this user has an attachment as avatar... |
3486 | - else if (!empty($data['filename'])) |
|
3487 | - $image = $modSettings['custom_avatar_url'] . '/' . $data['filename']; |
|
3678 | + else if (!empty($data['filename'])) { |
|
3679 | + $image = $modSettings['custom_avatar_url'] . '/' . $data['filename']; |
|
3680 | + } |
|
3488 | 3681 | |
3489 | 3682 | // Right... no avatar... use our default image. |
3490 | - else |
|
3491 | - $image = $modSettings['avatar_url'] . '/default.png'; |
|
3683 | + else { |
|
3684 | + $image = $modSettings['avatar_url'] . '/default.png'; |
|
3685 | + } |
|
3492 | 3686 | } |
3493 | 3687 | |
3494 | 3688 | call_integration_hook('integrate_set_avatar_data', array(&$image, &$data)); |
3495 | 3689 | |
3496 | 3690 | // At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed. |
3497 | - if (!empty($image)) |
|
3498 | - return array( |
|
3691 | + if (!empty($image)) { |
|
3692 | + return array( |
|
3499 | 3693 | 'name' => !empty($data['avatar']) ? $data['avatar'] : '', |
3500 | 3694 | 'image' => '<img class="avatar" src="' . $image . '" />', |
3501 | 3695 | 'href' => $image, |
3502 | 3696 | 'url' => $image, |
3503 | 3697 | ); |
3698 | + } |
|
3504 | 3699 | |
3505 | 3700 | // Fallback to make life easier for everyone... |
3506 | - else |
|
3507 | - return array( |
|
3701 | + else { |
|
3702 | + return array( |
|
3508 | 3703 | 'name' => '', |
3509 | 3704 | 'image' => '', |
3510 | 3705 | 'href' => '', |
3511 | 3706 | 'url' => '', |
3512 | 3707 | ); |
3513 | -} |
|
3708 | + } |
|
3709 | + } |
|
3514 | 3710 | |
3515 | 3711 | ?> |
3516 | 3712 | \ No newline at end of file |