SimpleMachines / SMF2.1

other/buildtools/check-signed-off.php

Braces +3 added lines, -2 removed lines

@@ -13,5 +13,6 @@
 
 $message = shell_exec('git show -s --format=%B ' . $hash . ' | tail -n 1');
 $result = stripos($message, 'Signed-off by:');
-if ($result === false)
-	die('Error: Signed-off by not found in commit message');
\ No newline at end of file
+if ($result === false) {
+	die('Error: Signed-off by not found in commit message');
+}

other/buildtools/check-smf-languages.php

Braces +15 added lines, -8 removed lines

@@ -17,25 +17,29 @@ 
 );
 
 // No file? Thats bad.
-if (!isset($_SERVER['argv'], $_SERVER['argv'][1]))
+if (!isset($_SERVER['argv'], $_SERVER['argv'][1])) {
 	die('Error: No File specified' . "\n");
+}
 
 // The file has to exist.
 $currentFile = $_SERVER['argv'][1];
-if (!file_exists($currentFile))
+if (!file_exists($currentFile)) {
 	die('Error: File does not exist' . "\n");
+}
 
 // Is this ignored?
-foreach ($ignoreFiles as $if)
+foreach ($ignoreFiles as $if) {
 	if (preg_match('~' . $if . '~i', $currentFile))
 		die;
+}
 
 // Lets get the main index.php for $forum_version and $software_year.
 $upgradeFile = fopen('./other/upgrade.php', 'r');
 $upgradeContents = fread($upgradeFile, 500);
 
-if (!preg_match('~define\(\'SMF_LANG_VERSION\', \'([^\']+)\'\);~i', $upgradeContents, $versionResults))
+if (!preg_match('~define\(\'SMF_LANG_VERSION\', \'([^\']+)\'\);~i', $upgradeContents, $versionResults)) {
 	die('Error: Could not locate SMF_LANG_VERSION' . "\n");
+}
 $currentVersion = $versionResults[1];
 
 $file = fopen($currentFile, 'r');
@@ -44,15 +48,18 @@ 
 
 // Just see if the basic match is there.
 $match = '// Version: ' . $currentVersion;
-if (!preg_match('~' . $match . '~i', $contents))
+if (!preg_match('~' . $match . '~i', $contents)) {
 	die('Error: The version is missing or incorrect in ' . $currentFile . "\n");
+}
 
 // Get the file prefix.
 preg_match('~([A-Za-z]+)\.english\.php~i', $currentFile, $fileMatch);
-if (empty($fileMatch))
+if (empty($fileMatch)) {
 	die('Error: Could not locate locate the file name in ' . $currentFile . "\n");
+}
 
 // Now match that prefix in a more strict mode.
 $match = '// Version: ' . $currentVersion . '; ' . $fileMatch[1];
-if (!preg_match('~' . $match . '~i', $contents))
-	die('Error: The version with file name is missing or incorrect in ' . $currentFile . "\n");
\ No newline at end of file
+if (!preg_match('~' . $match . '~i', $contents)) {
+	die('Error: The version with file name is missing or incorrect in ' . $currentFile . "\n");
+}

other/buildtools/check-smf-license.php

Braces +17 added lines, -9 removed lines

@@ -47,29 +47,34 @@ 
 );
 
 // No file? Thats bad.
-if (!isset($_SERVER['argv'], $_SERVER['argv'][1]))
+if (!isset($_SERVER['argv'], $_SERVER['argv'][1])) {
 	die('Error: No File specified' . "\n");
+}
 
 // The file has to exist.
 $currentFile = $_SERVER['argv'][1];
-if (!file_exists($currentFile))
+if (!file_exists($currentFile)) {
 	die('Error: File does not exist' . "\n");
+}
 
 // Is this ignored?
-foreach ($ignoreFiles as $if)
+foreach ($ignoreFiles as $if) {
 	if (preg_match('~' . $if . '~i', $currentFile))
 		die;
+}
 
 // Lets get the main index.php for $forum_version and $software_year.
 $indexFile = fopen('./index.php', 'r');
 $indexContents = fread($indexFile, 850);
 
-if (!preg_match('~\$forum_version = \'SMF ([^\']+)\';~i', $indexContents, $versionResults))
+if (!preg_match('~\$forum_version = \'SMF ([^\']+)\';~i', $indexContents, $versionResults)) {
 	die('Error: Could not locate $forum_version' . "\n");
+}
 $currentVersion = $versionResults[1];
 
-if (!preg_match('~\$software_year = \'(\d{4})\';~i', $indexContents, $yearResults))
+if (!preg_match('~\$software_year = \'(\d{4})\';~i', $indexContents, $yearResults)) {
 	die('Error: Could not locate $software_year' . "\n");
+}
 $currentSoftwareYear = (int) $yearResults[1];
 
 $file = fopen($currentFile, 'r');
@@ -90,17 +95,20 @@ 
 );
 
 // Just see if the license is there.
-if (!preg_match('~' . implode('', $match) . '~i', $contents))
+if (!preg_match('~' . implode('', $match) . '~i', $contents)) {
 	die('Error: License File is invalid or not found in ' . $currentFile . "\n");
+}
 
 // Check the year is correct.
 $yearMatch = $match;
 $yearMatch[4] = ' \* @copyright ' . $currentSoftwareYear . ' Simple Machines and individual contributors' . '[\r]?\n';
-if (!preg_match('~' . implode('', $yearMatch) . '~i', $contents))
+if (!preg_match('~' . implode('', $yearMatch) . '~i', $contents)) {
 	die('Error: The software year is incorrect in ' . $currentFile . "\n");
+}
 
 // Check the version is correct.
 $versionMatch = $match;
 $versionMatch[7] = ' \* @version ' . $currentVersion . '[\r]?\n';
-if (!preg_match('~' . implode('', $versionMatch) . '~i', $contents))
-	die('Error: The version is incorrect in ' . $currentFile . "\n");
\ No newline at end of file
+if (!preg_match('~' . implode('', $versionMatch) . '~i', $contents)) {
+	die('Error: The version is incorrect in ' . $currentFile . "\n");
+}