Completed
Push — release-2.1 ( e39a06...9cd069 )
by Colin
08:16
created
Sources/Load.php 1 patch
Braces   +784 added lines, -593 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Load the $modSettings array.
@@ -25,13 +26,14 @@  discard block
 block discarded – undo
25 26
 	global $cache_enable, $sourcedir, $context;
26 27
 
27 28
 	// Most database systems have not set UTF-8 as their default input charset.
28
-	if (!empty($db_character_set))
29
-		$smcFunc['db_query']('', '
29
+	if (!empty($db_character_set)) {
30
+			$smcFunc['db_query']('', '
30 31
 			SET NAMES {string:db_character_set}',
31 32
 			array(
32 33
 				'db_character_set' => $db_character_set,
33 34
 			)
34 35
 		);
36
+	}
35 37
 
36 38
 	// We need some caching support, maybe.
37 39
 	loadCacheAccelerator();
@@ -46,28 +48,36 @@  discard block
 block discarded – undo
46 48
 			)
47 49
 		);
48 50
 		$modSettings = array();
49
-		if (!$request)
50
-			display_db_error();
51
-		while ($row = $smcFunc['db_fetch_row']($request))
52
-			$modSettings[$row[0]] = $row[1];
51
+		if (!$request) {
52
+					display_db_error();
53
+		}
54
+		while ($row = $smcFunc['db_fetch_row']($request)) {
55
+					$modSettings[$row[0]] = $row[1];
56
+		}
53 57
 		$smcFunc['db_free_result']($request);
54 58
 
55 59
 		// Do a few things to protect against missing settings or settings with invalid values...
56
-		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999)
57
-			$modSettings['defaultMaxTopics'] = 20;
58
-		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999)
59
-			$modSettings['defaultMaxMessages'] = 15;
60
-		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999)
61
-			$modSettings['defaultMaxMembers'] = 30;
62
-		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999)
63
-			$modSettings['defaultMaxListItems'] = 15;
60
+		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) {
61
+					$modSettings['defaultMaxTopics'] = 20;
62
+		}
63
+		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) {
64
+					$modSettings['defaultMaxMessages'] = 15;
65
+		}
66
+		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) {
67
+					$modSettings['defaultMaxMembers'] = 30;
68
+		}
69
+		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) {
70
+					$modSettings['defaultMaxListItems'] = 15;
71
+		}
64 72
 
65 73
 		// We excpiclity do not use $smcFunc['json_decode'] here yet, as $smcFunc is not fully loaded.
66
-		if (!is_array($modSettings['attachmentUploadDir']))
67
-			$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
74
+		if (!is_array($modSettings['attachmentUploadDir'])) {
75
+					$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
76
+		}
68 77
 
69
-		if (!empty($cache_enable))
70
-			cache_put_data('modSettings', $modSettings, 90);
78
+		if (!empty($cache_enable)) {
79
+					cache_put_data('modSettings', $modSettings, 90);
80
+		}
71 81
 	}
72 82
 
73 83
 	$modSettings['cache_enable'] = $cache_enable;
@@ -87,8 +97,9 @@  discard block
 block discarded – undo
87 97
 		};
88 98
 	$fix_utf8mb4 = function($string) use ($utf8, $smcFunc)
89 99
 	{
90
-		if (!$utf8 || $smcFunc['db_mb4'])
91
-			return $string;
100
+		if (!$utf8 || $smcFunc['db_mb4']) {
101
+					return $string;
102
+		}
92 103
 
93 104
 		$i = 0;
94 105
 		$len = strlen($string);
@@ -100,18 +111,15 @@  discard block
 block discarded – undo
100 111
 			{
101 112
 				$new_string .= $string[$i];
102 113
 				$i++;
103
-			}
104
-			elseif ($ord < 224)
114
+			} elseif ($ord < 224)
105 115
 			{
106 116
 				$new_string .= $string[$i] . $string[$i + 1];
107 117
 				$i += 2;
108
-			}
109
-			elseif ($ord < 240)
118
+			} elseif ($ord < 240)
110 119
 			{
111 120
 				$new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2];
112 121
 				$i += 3;
113
-			}
114
-			elseif ($ord < 248)
122
+			} elseif ($ord < 248)
115 123
 			{
116 124
 				// Magic happens.
117 125
 				$val = (ord($string[$i]) & 0x07) << 18;
@@ -155,8 +163,7 @@  discard block
 block discarded – undo
155 163
 			{
156 164
 				$result = array_search($needle, array_slice($haystack_arr, $offset));
157 165
 				return is_int($result) ? $result + $offset : false;
158
-			}
159
-			else
166
+			} else
160 167
 			{
161 168
 				$needle_arr = preg_split('~(&#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . ';|&quot;|&amp;|&lt;|&gt;|&nbsp;|.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
162 169
 				$needle_size = count($needle_arr);
@@ -165,8 +172,9 @@  discard block
 block discarded – undo
165 172
 				while ((int) $result === $result)
166 173
 				{
167 174
 					$offset += $result;
168
-					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr)
169
-						return $offset;
175
+					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) {
176
+											return $offset;
177
+					}
170 178
 					$result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset));
171 179
 				}
172 180
 				return false;
@@ -204,8 +212,9 @@  discard block
 block discarded – undo
204 212
 			$string = $ent_check($string);
205 213
 			preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches);
206 214
 			$string = $matches[0];
207
-			while (strlen($string) > $length)
208
-				$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
215
+			while (strlen($string) > $length) {
216
+							$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
217
+			}
209 218
 			return $string;
210 219
 		},
211 220
 		'ucfirst' => $utf8 ? function($string) use (&$smcFunc)
@@ -215,8 +224,9 @@  discard block
 block discarded – undo
215 224
 		'ucwords' => $utf8 ? function($string) use (&$smcFunc)
216 225
 		{
217 226
 			$words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE);
218
-			for ($i = 0, $n = count($words); $i < $n; $i += 2)
219
-				$words[$i] = $smcFunc['ucfirst']($words[$i]);
227
+			for ($i = 0, $n = count($words); $i < $n; $i += 2) {
228
+							$words[$i] = $smcFunc['ucfirst']($words[$i]);
229
+			}
220 230
 			return implode('', $words);
221 231
 		} : 'ucwords',
222 232
 		'json_decode' => 'smf_json_decode',
@@ -224,16 +234,17 @@  discard block
 block discarded – undo
224 234
 	);
225 235
 
226 236
 	// Setting the timezone is a requirement for some functions.
227
-	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list()))
228
-		date_default_timezone_set($modSettings['default_timezone']);
229
-	else
237
+	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) {
238
+			date_default_timezone_set($modSettings['default_timezone']);
239
+	} else
230 240
 	{
231 241
 		// Get PHP's default timezone, if set
232 242
 		$ini_tz = ini_get('date.timezone');
233
-		if (!empty($ini_tz))
234
-			$modSettings['default_timezone'] = $ini_tz;
235
-		else
236
-			$modSettings['default_timezone'] = '';
243
+		if (!empty($ini_tz)) {
244
+					$modSettings['default_timezone'] = $ini_tz;
245
+		} else {
246
+					$modSettings['default_timezone'] = '';
247
+		}
237 248
 
238 249
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
239 250
 		if (!in_array($modSettings['default_timezone'], timezone_identifiers_list()))
@@ -251,22 +262,26 @@  discard block
 block discarded – undo
251 262
 		if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null)
252 263
 		{
253 264
 			$modSettings['load_average'] = @file_get_contents('/proc/loadavg');
254
-			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0)
255
-				$modSettings['load_average'] = (float) $matches[1];
256
-			elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0)
257
-				$modSettings['load_average'] = (float) $matches[1];
258
-			else
259
-				unset($modSettings['load_average']);
265
+			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) {
266
+							$modSettings['load_average'] = (float) $matches[1];
267
+			} elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) {
268
+							$modSettings['load_average'] = (float) $matches[1];
269
+			} else {
270
+							unset($modSettings['load_average']);
271
+			}
260 272
 
261
-			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
262
-				cache_put_data('loadavg', $modSettings['load_average'], 90);
273
+			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
274
+							cache_put_data('loadavg', $modSettings['load_average'], 90);
275
+			}
263 276
 		}
264 277
 
265
-		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
266
-			call_integration_hook('integrate_load_average', array($modSettings['load_average']));
278
+		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
279
+					call_integration_hook('integrate_load_average', array($modSettings['load_average']));
280
+		}
267 281
 
268
-		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum'])
269
-			display_loadavg_error();
282
+		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) {
283
+					display_loadavg_error();
284
+		}
270 285
 	}
271 286
 
272 287
 	// Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is.
@@ -287,8 +302,9 @@  discard block
 block discarded – undo
287 302
 	if (defined('SMF_INTEGRATION_SETTINGS'))
288 303
 	{
289 304
 		$integration_settings = $smcFunc['json_decode'](SMF_INTEGRATION_SETTINGS, true);
290
-		foreach ($integration_settings as $hook => $function)
291
-			add_integration_function($hook, $function, '', false);
305
+		foreach ($integration_settings as $hook => $function) {
306
+					add_integration_function($hook, $function, '', false);
307
+		}
292 308
 	}
293 309
 
294 310
 	// Any files to pre include?
@@ -298,8 +314,9 @@  discard block
 block discarded – undo
298 314
 		foreach ($pre_includes as $include)
299 315
 		{
300 316
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
301
-			if (file_exists($include))
302
-				require_once($include);
317
+			if (file_exists($include)) {
318
+							require_once($include);
319
+			}
303 320
 		}
304 321
 	}
305 322
 
@@ -405,27 +422,28 @@  discard block
 block discarded – undo
405 422
 				break;
406 423
 			}
407 424
 		}
425
+	} else {
426
+			$id_member = 0;
408 427
 	}
409
-	else
410
-		$id_member = 0;
411 428
 
412 429
 	if (empty($id_member) && isset($_COOKIE[$cookiename]))
413 430
 	{
414 431
 		$cookie_data = $smcFunc['json_decode']($_COOKIE[$cookiename], true, false);
415 432
 
416
-		if (empty($cookie_data))
417
-			$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
433
+		if (empty($cookie_data)) {
434
+					$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
435
+		}
418 436
 
419 437
 		list ($id_member, $password) = $cookie_data;
420 438
 		$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;
421
-	}
422
-	elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
439
+	} elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
423 440
 	{
424 441
 		// @todo Perhaps we can do some more checking on this, such as on the first octet of the IP?
425 442
 		$cookie_data = $smcFunc['json_decode']($_SESSION['login_' . $cookiename]);
426 443
 
427
-		if (empty($cookie_data))
428
-			$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
444
+		if (empty($cookie_data)) {
445
+					$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
446
+		}
429 447
 
430 448
 		list ($id_member, $password, $login_span) = $cookie_data;
431 449
 		$id_member = !empty($id_member) && strlen($password) == 128 && $login_span > time() ? (int) $id_member : 0;
@@ -450,30 +468,34 @@  discard block
 block discarded – undo
450 468
 			$user_settings = $smcFunc['db_fetch_assoc']($request);
451 469
 			$smcFunc['db_free_result']($request);
452 470
 
453
-			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false)
454
-				$user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret);
471
+			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) {
472
+							$user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret);
473
+			}
455 474
 
456
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
457
-				cache_put_data('user_settings-' . $id_member, $user_settings, 60);
475
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
476
+							cache_put_data('user_settings-' . $id_member, $user_settings, 60);
477
+			}
458 478
 		}
459 479
 
460 480
 		// Did we find 'im?  If not, junk it.
461 481
 		if (!empty($user_settings))
462 482
 		{
463 483
 			// As much as the password should be right, we can assume the integration set things up.
464
-			if (!empty($already_verified) && $already_verified === true)
465
-				$check = true;
484
+			if (!empty($already_verified) && $already_verified === true) {
485
+							$check = true;
486
+			}
466 487
 			// SHA-512 hash should be 128 characters long.
467
-			elseif (strlen($password) == 128)
468
-				$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
469
-			else
470
-				$check = false;
488
+			elseif (strlen($password) == 128) {
489
+							$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
490
+			} else {
491
+							$check = false;
492
+			}
471 493
 
472 494
 			// Wrong password or not activated - either way, you're going nowhere.
473 495
 			$id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0;
496
+		} else {
497
+					$id_member = 0;
474 498
 		}
475
-		else
476
-			$id_member = 0;
477 499
 
478 500
 		// If we no longer have the member maybe they're being all hackey, stop brute force!
479 501
 		if (!$id_member)
@@ -502,8 +524,9 @@  discard block
 block discarded – undo
502 524
 
503 525
 					list ($tfamember, $tfasecret) = $tfa_data;
504 526
 
505
-					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member)
506
-						$tfasecret = null;
527
+					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member) {
528
+											$tfasecret = null;
529
+					}
507 530
 				}
508 531
 
509 532
 				if (empty($tfasecret) || hash_salt($user_settings['tfa_backup'], $user_settings['password_salt']) != $tfasecret)
@@ -523,10 +546,12 @@  discard block
 block discarded – undo
523 546
 		// Are we forcing 2FA? Need to check if the user groups actually require 2FA
524 547
 		elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret']))
525 548
 		{
526
-			if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups
549
+			if ($modSettings['tfa_mode'] == 2) {
550
+				//only do this if we are just forcing SOME membergroups
527 551
 			{
528 552
 				//Build an array of ALL user membergroups.
529 553
 				$full_groups = array($user_settings['id_group']);
554
+			}
530 555
 				if (!empty($user_settings['additional_groups']))
531 556
 				{
532 557
 					$full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups']));
@@ -546,15 +571,17 @@  discard block
 block discarded – undo
546 571
 				);
547 572
 				$row = $smcFunc['db_fetch_assoc']($request);
548 573
 				$smcFunc['db_free_result']($request);
574
+			} else {
575
+							$row['total'] = 1;
549 576
 			}
550
-			else
551
-				$row['total'] = 1; //simplifies logics in the next "if"
577
+			//simplifies logics in the next "if"
552 578
 
553 579
 			$area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : '';
554 580
 			$action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : '';
555 581
 
556
-			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup'))
557
-				redirectexit('action=profile;area=tfasetup;forced');
582
+			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) {
583
+							redirectexit('action=profile;area=tfasetup;forced');
584
+			}
558 585
 		}
559 586
 	}
560 587
 
@@ -591,33 +618,37 @@  discard block
 block discarded – undo
591 618
 				updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP']));
592 619
 				$user_settings['last_login'] = time();
593 620
 
594
-				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
595
-					cache_put_data('user_settings-' . $id_member, $user_settings, 60);
621
+				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
622
+									cache_put_data('user_settings-' . $id_member, $user_settings, 60);
623
+				}
596 624
 
597
-				if (!empty($modSettings['cache_enable']))
598
-					cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
625
+				if (!empty($modSettings['cache_enable'])) {
626
+									cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
627
+				}
599 628
 			}
629
+		} elseif (empty($_SESSION['id_msg_last_visit'])) {
630
+					$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
600 631
 		}
601
-		elseif (empty($_SESSION['id_msg_last_visit']))
602
-			$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
603 632
 
604 633
 		$username = $user_settings['member_name'];
605 634
 
606
-		if (empty($user_settings['additional_groups']))
607
-			$user_info = array(
635
+		if (empty($user_settings['additional_groups'])) {
636
+					$user_info = array(
608 637
 				'groups' => array($user_settings['id_group'], $user_settings['id_post_group'])
609 638
 			);
610
-		else
611
-			$user_info = array(
639
+		} else {
640
+					$user_info = array(
612 641
 				'groups' => array_merge(
613 642
 					array($user_settings['id_group'], $user_settings['id_post_group']),
614 643
 					explode(',', $user_settings['additional_groups'])
615 644
 				)
616 645
 			);
646
+		}
617 647
 
618 648
 		// Because history has proven that it is possible for groups to go bad - clean up in case.
619
-		foreach ($user_info['groups'] as $k => $v)
620
-			$user_info['groups'][$k] = (int) $v;
649
+		foreach ($user_info['groups'] as $k => $v) {
650
+					$user_info['groups'][$k] = (int) $v;
651
+		}
621 652
 
622 653
 		// This is a logged in user, so definitely not a spider.
623 654
 		$user_info['possibly_robot'] = false;
@@ -631,8 +662,7 @@  discard block
 block discarded – undo
631 662
 			$time_system = new DateTime('now', $tz_system);
632 663
 			$time_user = new DateTime('now', $tz_user);
633 664
 			$user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600;
634
-		}
635
-		else
665
+		} else
636 666
 		{
637 667
 			// !!! Compatibility.
638 668
 			$user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset'];
@@ -646,8 +676,9 @@  discard block
 block discarded – undo
646 676
 		$user_info = array('groups' => array(-1));
647 677
 		$user_settings = array();
648 678
 
649
-		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member']))
650
-			$_COOKIE[$cookiename] = '';
679
+		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) {
680
+					$_COOKIE[$cookiename] = '';
681
+		}
651 682
 
652 683
 		// Expire the 2FA cookie
653 684
 		if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member']))
@@ -664,19 +695,20 @@  discard block
 block discarded – undo
664 695
 		}
665 696
 
666 697
 		// Create a login token if it doesn't exist yet.
667
-		if (!isset($_SESSION['token']['post-login']))
668
-			createToken('login');
669
-		else
670
-			list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
698
+		if (!isset($_SESSION['token']['post-login'])) {
699
+					createToken('login');
700
+		} else {
701
+					list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
702
+		}
671 703
 
672 704
 		// Do we perhaps think this is a search robot? Check every five minutes just in case...
673 705
 		if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300))
674 706
 		{
675 707
 			require_once($sourcedir . '/ManageSearchEngines.php');
676 708
 			$user_info['possibly_robot'] = SpiderCheck();
709
+		} elseif (!empty($modSettings['spider_mode'])) {
710
+					$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
677 711
 		}
678
-		elseif (!empty($modSettings['spider_mode']))
679
-			$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
680 712
 		// If we haven't turned on proper spider hunts then have a guess!
681 713
 		else
682 714
 		{
@@ -724,8 +756,9 @@  discard block
 block discarded – undo
724 756
 	$user_info['groups'] = array_unique($user_info['groups']);
725 757
 
726 758
 	// Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems.
727
-	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1]))
728
-		unset($user_info['ignoreboards'][$tmp]);
759
+	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) {
760
+			unset($user_info['ignoreboards'][$tmp]);
761
+	}
729 762
 
730 763
 	// Allow the user to change their language.
731 764
 	if (!empty($modSettings['userLanguage']))
@@ -738,13 +771,14 @@  discard block
 block discarded – undo
738 771
 			$user_info['language'] = strtr($_GET['language'], './\\:', '____');
739 772
 
740 773
 			// Make it permanent for members.
741
-			if (!empty($user_info['id']))
742
-				updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
743
-			else
744
-				$_SESSION['language'] = $user_info['language'];
774
+			if (!empty($user_info['id'])) {
775
+							updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
776
+			} else {
777
+							$_SESSION['language'] = $user_info['language'];
778
+			}
779
+		} elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) {
780
+					$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
745 781
 		}
746
-		elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')]))
747
-			$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
748 782
 	}
749 783
 
750 784
 	$temp = build_query_board($user_info['id']);
@@ -807,9 +841,9 @@  discard block
 block discarded – undo
807 841
 		}
808 842
 
809 843
 		// Remember redirection is the key to avoiding fallout from your bosses.
810
-		if (!empty($topic))
811
-			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
812
-		else
844
+		if (!empty($topic)) {
845
+					redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
846
+		} else
813 847
 		{
814 848
 			loadPermissions();
815 849
 			loadTheme();
@@ -827,10 +861,11 @@  discard block
 block discarded – undo
827 861
 	if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
828 862
 	{
829 863
 		// @todo SLOW?
830
-		if (!empty($topic))
831
-			$temp = cache_get_data('topic_board-' . $topic, 120);
832
-		else
833
-			$temp = cache_get_data('board-' . $board, 120);
864
+		if (!empty($topic)) {
865
+					$temp = cache_get_data('topic_board-' . $topic, 120);
866
+		} else {
867
+					$temp = cache_get_data('board-' . $board, 120);
868
+		}
834 869
 
835 870
 		if (!empty($temp))
836 871
 		{
@@ -868,8 +903,9 @@  discard block
 block discarded – undo
868 903
 			$row = $smcFunc['db_fetch_assoc']($request);
869 904
 
870 905
 			// Set the current board.
871
-			if (!empty($row['id_board']))
872
-				$board = $row['id_board'];
906
+			if (!empty($row['id_board'])) {
907
+							$board = $row['id_board'];
908
+			}
873 909
 
874 910
 			// Basic operating information. (globals... :/)
875 911
 			$board_info = array(
@@ -905,21 +941,23 @@  discard block
 block discarded – undo
905 941
 
906 942
 			do
907 943
 			{
908
-				if (!empty($row['id_moderator']))
909
-					$board_info['moderators'][$row['id_moderator']] = array(
944
+				if (!empty($row['id_moderator'])) {
945
+									$board_info['moderators'][$row['id_moderator']] = array(
910 946
 						'id' => $row['id_moderator'],
911 947
 						'name' => $row['real_name'],
912 948
 						'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
913 949
 						'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
914 950
 					);
951
+				}
915 952
 
916
-				if (!empty($row['id_moderator_group']))
917
-					$board_info['moderator_groups'][$row['id_moderator_group']] = array(
953
+				if (!empty($row['id_moderator_group'])) {
954
+									$board_info['moderator_groups'][$row['id_moderator_group']] = array(
918 955
 						'id' => $row['id_moderator_group'],
919 956
 						'name' => $row['group_name'],
920 957
 						'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
921 958
 						'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
922 959
 					);
960
+				}
923 961
 			}
924 962
 			while ($row = $smcFunc['db_fetch_assoc']($request));
925 963
 
@@ -951,12 +989,12 @@  discard block
 block discarded – undo
951 989
 			if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
952 990
 			{
953 991
 				// @todo SLOW?
954
-				if (!empty($topic))
955
-					cache_put_data('topic_board-' . $topic, $board_info, 120);
992
+				if (!empty($topic)) {
993
+									cache_put_data('topic_board-' . $topic, $board_info, 120);
994
+				}
956 995
 				cache_put_data('board-' . $board, $board_info, 120);
957 996
 			}
958
-		}
959
-		else
997
+		} else
960 998
 		{
961 999
 			// Otherwise the topic is invalid, there are no moderators, etc.
962 1000
 			$board_info = array(
@@ -970,8 +1008,9 @@  discard block
 block discarded – undo
970 1008
 		$smcFunc['db_free_result']($request);
971 1009
 	}
972 1010
 
973
-	if (!empty($topic))
974
-		$_GET['board'] = (int) $board;
1011
+	if (!empty($topic)) {
1012
+			$_GET['board'] = (int) $board;
1013
+	}
975 1014
 
976 1015
 	if (!empty($board))
977 1016
 	{
@@ -981,10 +1020,12 @@  discard block
 block discarded – undo
981 1020
 		// Now check if the user is a moderator.
982 1021
 		$user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0;
983 1022
 
984
-		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin'])
985
-			$board_info['error'] = 'access';
986
-		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin'])
987
-			$board_info['error'] = 'access';
1023
+		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) {
1024
+					$board_info['error'] = 'access';
1025
+		}
1026
+		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) {
1027
+					$board_info['error'] = 'access';
1028
+		}
988 1029
 
989 1030
 		// Build up the linktree.
990 1031
 		$context['linktree'] = array_merge(
@@ -1007,8 +1048,9 @@  discard block
 block discarded – undo
1007 1048
 	$context['current_board'] = $board;
1008 1049
 
1009 1050
 	// No posting in redirection boards!
1010
-	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect']))
1011
-		$board_info['error'] == 'post_in_redirect';
1051
+	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) {
1052
+			$board_info['error'] == 'post_in_redirect';
1053
+	}
1012 1054
 
1013 1055
 	// Hacker... you can't see this topic, I'll tell you that. (but moderators can!)
1014 1056
 	if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod']))
@@ -1034,24 +1076,23 @@  discard block
 block discarded – undo
1034 1076
 			ob_end_clean();
1035 1077
 			header('HTTP/1.1 403 Forbidden');
1036 1078
 			die;
1037
-		}
1038
-		elseif ($board_info['error'] == 'post_in_redirect')
1079
+		} elseif ($board_info['error'] == 'post_in_redirect')
1039 1080
 		{
1040 1081
 			// Slightly different error message here...
1041 1082
 			fatal_lang_error('cannot_post_redirect', false);
1042
-		}
1043
-		elseif ($user_info['is_guest'])
1083
+		} elseif ($user_info['is_guest'])
1044 1084
 		{
1045 1085
 			loadLanguage('Errors');
1046 1086
 			is_not_guest($txt['topic_gone']);
1087
+		} else {
1088
+					fatal_lang_error('topic_gone', false);
1047 1089
 		}
1048
-		else
1049
-			fatal_lang_error('topic_gone', false);
1050 1090
 	}
1051 1091
 
1052
-	if ($user_info['is_mod'])
1053
-		$user_info['groups'][] = 3;
1054
-}
1092
+	if ($user_info['is_mod']) {
1093
+			$user_info['groups'][] = 3;
1094
+	}
1095
+	}
1055 1096
 
1056 1097
 /**
1057 1098
  * Load this user's permissions.
@@ -1072,8 +1113,9 @@  discard block
 block discarded – undo
1072 1113
 		asort($cache_groups);
1073 1114
 		$cache_groups = implode(',', $cache_groups);
1074 1115
 		// If it's a spider then cache it different.
1075
-		if ($user_info['possibly_robot'])
1076
-			$cache_groups .= '-spider';
1116
+		if ($user_info['possibly_robot']) {
1117
+					$cache_groups .= '-spider';
1118
+		}
1077 1119
 
1078 1120
 		if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1079 1121
 		{
@@ -1081,9 +1123,9 @@  discard block
 block discarded – undo
1081 1123
 			banPermissions();
1082 1124
 
1083 1125
 			return;
1126
+		} elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) {
1127
+					list ($user_info['permissions'], $removals) = $temp;
1084 1128
 		}
1085
-		elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1086
-			list ($user_info['permissions'], $removals) = $temp;
1087 1129
 	}
1088 1130
 
1089 1131
 	// If it is detected as a robot, and we are restricting permissions as a special group - then implement this.
@@ -1105,23 +1147,26 @@  discard block
 block discarded – undo
1105 1147
 		$removals = array();
1106 1148
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1107 1149
 		{
1108
-			if (empty($row['add_deny']))
1109
-				$removals[] = $row['permission'];
1110
-			else
1111
-				$user_info['permissions'][] = $row['permission'];
1150
+			if (empty($row['add_deny'])) {
1151
+							$removals[] = $row['permission'];
1152
+			} else {
1153
+							$user_info['permissions'][] = $row['permission'];
1154
+			}
1112 1155
 		}
1113 1156
 		$smcFunc['db_free_result']($request);
1114 1157
 
1115
-		if (isset($cache_groups))
1116
-			cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1158
+		if (isset($cache_groups)) {
1159
+					cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1160
+		}
1117 1161
 	}
1118 1162
 
1119 1163
 	// Get the board permissions.
1120 1164
 	if (!empty($board))
1121 1165
 	{
1122 1166
 		// Make sure the board (if any) has been loaded by loadBoard().
1123
-		if (!isset($board_info['profile']))
1124
-			fatal_lang_error('no_board');
1167
+		if (!isset($board_info['profile'])) {
1168
+					fatal_lang_error('no_board');
1169
+		}
1125 1170
 
1126 1171
 		$request = $smcFunc['db_query']('', '
1127 1172
 			SELECT permission, add_deny
@@ -1137,20 +1182,23 @@  discard block
 block discarded – undo
1137 1182
 		);
1138 1183
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1139 1184
 		{
1140
-			if (empty($row['add_deny']))
1141
-				$removals[] = $row['permission'];
1142
-			else
1143
-				$user_info['permissions'][] = $row['permission'];
1185
+			if (empty($row['add_deny'])) {
1186
+							$removals[] = $row['permission'];
1187
+			} else {
1188
+							$user_info['permissions'][] = $row['permission'];
1189
+			}
1144 1190
 		}
1145 1191
 		$smcFunc['db_free_result']($request);
1146 1192
 	}
1147 1193
 
1148 1194
 	// Remove all the permissions they shouldn't have ;).
1149
-	if (!empty($modSettings['permission_enable_deny']))
1150
-		$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1195
+	if (!empty($modSettings['permission_enable_deny'])) {
1196
+			$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1197
+	}
1151 1198
 
1152
-	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2)
1153
-		cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1199
+	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) {
1200
+			cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1201
+	}
1154 1202
 
1155 1203
 	// Banned?  Watch, don't touch..
1156 1204
 	banPermissions();
@@ -1162,17 +1210,18 @@  discard block
 block discarded – undo
1162 1210
 		{
1163 1211
 			require_once($sourcedir . '/Subs-Auth.php');
1164 1212
 			rebuildModCache();
1213
+		} else {
1214
+					$user_info['mod_cache'] = $_SESSION['mc'];
1165 1215
 		}
1166
-		else
1167
-			$user_info['mod_cache'] = $_SESSION['mc'];
1168 1216
 
1169 1217
 		// This is a useful phantom permission added to the current user, and only the current user while they are logged in.
1170 1218
 		// For example this drastically simplifies certain changes to the profile area.
1171 1219
 		$user_info['permissions'][] = 'is_not_guest';
1172 1220
 		// And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions.
1173 1221
 		$user_info['permissions'][] = 'profile_view_own';
1174
-		if (in_array('profile_view', $user_info['permissions']))
1175
-			$user_info['permissions'][] = 'profile_view_any';
1222
+		if (in_array('profile_view', $user_info['permissions'])) {
1223
+					$user_info['permissions'][] = 'profile_view_any';
1224
+		}
1176 1225
 	}
1177 1226
 }
1178 1227
 
@@ -1190,8 +1239,9 @@  discard block
 block discarded – undo
1190 1239
 	global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1191 1240
 
1192 1241
 	// Can't just look for no users :P.
1193
-	if (empty($users))
1194
-		return array();
1242
+	if (empty($users)) {
1243
+			return array();
1244
+	}
1195 1245
 
1196 1246
 	// Pass the set value
1197 1247
 	$context['loadMemberContext_set'] = $set;
@@ -1206,8 +1256,9 @@  discard block
 block discarded – undo
1206 1256
 		for ($i = 0, $n = count($users); $i < $n; $i++)
1207 1257
 		{
1208 1258
 			$data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240);
1209
-			if ($data == null)
1210
-				continue;
1259
+			if ($data == null) {
1260
+							continue;
1261
+			}
1211 1262
 
1212 1263
 			$loaded_ids[] = $data['id_member'];
1213 1264
 			$user_profile[$data['id_member']] = $data;
@@ -1274,16 +1325,19 @@  discard block
 block discarded – undo
1274 1325
 			$row['avatar_original'] = !empty($row['avatar']) ? $row['avatar'] : '';
1275 1326
 
1276 1327
 			// Take care of proxying avatar if required, do this here for maximum reach
1277
-			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false)
1278
-				$row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret);
1328
+			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false) {
1329
+							$row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret);
1330
+			}
1279 1331
 
1280 1332
 			// Keep track of the member's normal member group
1281 1333
 			$row['primary_group'] = $row['member_group'];
1282 1334
 
1283
-			if (isset($row['member_ip']))
1284
-				$row['member_ip'] = inet_dtop($row['member_ip']);
1285
-			if (isset($row['member_ip2']))
1286
-				$row['member_ip2'] = inet_dtop($row['member_ip2']);
1335
+			if (isset($row['member_ip'])) {
1336
+							$row['member_ip'] = inet_dtop($row['member_ip']);
1337
+			}
1338
+			if (isset($row['member_ip2'])) {
1339
+							$row['member_ip2'] = inet_dtop($row['member_ip2']);
1340
+			}
1287 1341
 			$new_loaded_ids[] = $row['id_member'];
1288 1342
 			$loaded_ids[] = $row['id_member'];
1289 1343
 			$row['options'] = array();
@@ -1302,8 +1356,9 @@  discard block
 block discarded – undo
1302 1356
 				'loaded_ids' => $new_loaded_ids,
1303 1357
 			)
1304 1358
 		);
1305
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1306
-			$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1359
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1360
+					$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1361
+		}
1307 1362
 		$smcFunc['db_free_result']($request);
1308 1363
 	}
1309 1364
 
@@ -1314,10 +1369,11 @@  discard block
 block discarded – undo
1314 1369
 	{
1315 1370
 		foreach ($loaded_ids as $a_member)
1316 1371
 		{
1317
-			if (!empty($user_profile[$a_member]['additional_groups']))
1318
-				$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1319
-			else
1320
-				$groups = array($user_profile[$a_member]['id_group']);
1372
+			if (!empty($user_profile[$a_member]['additional_groups'])) {
1373
+							$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1374
+			} else {
1375
+							$groups = array($user_profile[$a_member]['id_group']);
1376
+			}
1321 1377
 
1322 1378
 			$temp = array_intersect($groups, array_keys($board_info['moderator_groups']));
1323 1379
 
@@ -1330,8 +1386,9 @@  discard block
 block discarded – undo
1330 1386
 
1331 1387
 	if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3)
1332 1388
 	{
1333
-		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++)
1334
-			cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1389
+		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) {
1390
+					cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1391
+		}
1335 1392
 	}
1336 1393
 
1337 1394
 	// Are we loading any moderators?  If so, fix their group data...
@@ -1357,14 +1414,17 @@  discard block
 block discarded – undo
1357 1414
 		foreach ($temp_mods as $id)
1358 1415
 		{
1359 1416
 			// By popular demand, don't show admins or global moderators as moderators.
1360
-			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2)
1361
-				$user_profile[$id]['member_group'] = $row['member_group'];
1417
+			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) {
1418
+							$user_profile[$id]['member_group'] = $row['member_group'];
1419
+			}
1362 1420
 
1363 1421
 			// If the Moderator group has no color or icons, but their group does... don't overwrite.
1364
-			if (!empty($row['icons']))
1365
-				$user_profile[$id]['icons'] = $row['icons'];
1366
-			if (!empty($row['member_group_color']))
1367
-				$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1422
+			if (!empty($row['icons'])) {
1423
+							$user_profile[$id]['icons'] = $row['icons'];
1424
+			}
1425
+			if (!empty($row['member_group_color'])) {
1426
+							$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1427
+			}
1368 1428
 		}
1369 1429
 	}
1370 1430
 
@@ -1386,12 +1446,14 @@  discard block
 block discarded – undo
1386 1446
 	static $loadedLanguages = array();
1387 1447
 
1388 1448
 	// If this person's data is already loaded, skip it.
1389
-	if (isset($dataLoaded[$user]))
1390
-		return true;
1449
+	if (isset($dataLoaded[$user])) {
1450
+			return true;
1451
+	}
1391 1452
 
1392 1453
 	// We can't load guests or members not loaded by loadMemberData()!
1393
-	if ($user == 0)
1394
-		return false;
1454
+	if ($user == 0) {
1455
+			return false;
1456
+	}
1395 1457
 	if (!isset($user_profile[$user]))
1396 1458
 	{
1397 1459
 		trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING);
@@ -1417,12 +1479,16 @@  discard block
 block discarded – undo
1417 1479
 	$buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array();
1418 1480
 
1419 1481
 	//We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme
1420
-	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists
1482
+	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) {
1483
+		//icon is set and exists
1421 1484
 		$group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1];
1422
-	elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default
1485
+	} elseif (isset($profile['icons'][1])) {
1486
+		//icon is set and doesn't exist, fallback to default
1423 1487
 		$group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1];
1424
-	else //not set, bye bye
1488
+	} else {
1489
+		//not set, bye bye
1425 1490
 		$group_icon_url = '';
1491
+	}
1426 1492
 
1427 1493
 	// These minimal values are always loaded
1428 1494
 	$memberContext[$user] = array(
@@ -1441,8 +1507,9 @@  discard block
 block discarded – undo
1441 1507
 	if ($context['loadMemberContext_set'] != 'minimal')
1442 1508
 	{
1443 1509
 		// Go the extra mile and load the user's native language name.
1444
-		if (empty($loadedLanguages))
1445
-			$loadedLanguages = getLanguages();
1510
+		if (empty($loadedLanguages)) {
1511
+					$loadedLanguages = getLanguages();
1512
+		}
1446 1513
 
1447 1514
 		$memberContext[$user] += array(
1448 1515
 			'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>',
@@ -1497,31 +1564,33 @@  discard block
 block discarded – undo
1497 1564
 	{
1498 1565
 		if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://')))
1499 1566
 		{
1500
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11)
1501
-				$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1502
-			else
1503
-				$image = get_gravatar_url($profile['email_address']);
1504
-		}
1505
-		else
1567
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) {
1568
+							$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1569
+			} else {
1570
+							$image = get_gravatar_url($profile['email_address']);
1571
+			}
1572
+		} else
1506 1573
 		{
1507 1574
 			// So it's stored in the member table?
1508 1575
 			if (!empty($profile['avatar']))
1509 1576
 			{
1510 1577
 				$image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar'];
1578
+			} elseif (!empty($profile['filename'])) {
1579
+							$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1511 1580
 			}
1512
-			elseif (!empty($profile['filename']))
1513
-				$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1514 1581
 			// Right... no avatar...use the default one
1515
-			else
1516
-				$image = $modSettings['avatar_url'] . '/default.png';
1582
+			else {
1583
+							$image = $modSettings['avatar_url'] . '/default.png';
1584
+			}
1517 1585
 		}
1518
-		if (!empty($image))
1519
-			$memberContext[$user]['avatar'] = array(
1586
+		if (!empty($image)) {
1587
+					$memberContext[$user]['avatar'] = array(
1520 1588
 				'name' => $profile['avatar'],
1521 1589
 				'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">',
1522 1590
 				'href' => $image,
1523 1591
 				'url' => $image,
1524 1592
 			);
1593
+		}
1525 1594
 	}
1526 1595
 
1527 1596
 	// Are we also loading the members custom fields into context?
@@ -1529,35 +1598,41 @@  discard block
 block discarded – undo
1529 1598
 	{
1530 1599
 		$memberContext[$user]['custom_fields'] = array();
1531 1600
 
1532
-		if (!isset($context['display_fields']))
1533
-			$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1601
+		if (!isset($context['display_fields'])) {
1602
+					$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1603
+		}
1534 1604
 
1535 1605
 		foreach ($context['display_fields'] as $custom)
1536 1606
 		{
1537
-			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']]))
1538
-				continue;
1607
+			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) {
1608
+							continue;
1609
+			}
1539 1610
 
1540 1611
 			$value = $profile['options'][$custom['col_name']];
1541 1612
 
1542 1613
 			// Don't show the "disabled" option for the "gender" field.
1543
-			if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled')
1544
-				continue;
1614
+			if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') {
1615
+							continue;
1616
+			}
1545 1617
 
1546 1618
 			// BBC?
1547
-			if ($custom['bbc'])
1548
-				$value = parse_bbc($value);
1619
+			if ($custom['bbc']) {
1620
+							$value = parse_bbc($value);
1621
+			}
1549 1622
 			// ... or checkbox?
1550
-			elseif (isset($custom['type']) && $custom['type'] == 'check')
1551
-				$value = $value ? $txt['yes'] : $txt['no'];
1623
+			elseif (isset($custom['type']) && $custom['type'] == 'check') {
1624
+							$value = $value ? $txt['yes'] : $txt['no'];
1625
+			}
1552 1626
 
1553 1627
 			// Enclosing the user input within some other text?
1554
-			if (!empty($custom['enclose']))
1555
-				$value = strtr($custom['enclose'], array(
1628
+			if (!empty($custom['enclose'])) {
1629
+							$value = strtr($custom['enclose'], array(
1556 1630
 					'{SCRIPTURL}' => $scripturl,
1557 1631
 					'{IMAGES_URL}' => $settings['images_url'],
1558 1632
 					'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1559 1633
 					'{INPUT}' => $value,
1560 1634
 				));
1635
+			}
1561 1636
 
1562 1637
 			$memberContext[$user]['custom_fields'][] = array(
1563 1638
 				'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'],
@@ -1584,8 +1659,9 @@  discard block
 block discarded – undo
1584 1659
 	global $smcFunc, $txt, $scripturl, $settings;
1585 1660
 
1586 1661
 	// Do not waste my time...
1587
-	if (empty($users) || empty($params))
1588
-		return false;
1662
+	if (empty($users) || empty($params)) {
1663
+			return false;
1664
+	}
1589 1665
 
1590 1666
 	// Make sure it's an array.
1591 1667
 	$users = !is_array($users) ? array($users) : array_unique($users);
@@ -1609,31 +1685,36 @@  discard block
 block discarded – undo
1609 1685
 	while ($row = $smcFunc['db_fetch_assoc']($request))
1610 1686
 	{
1611 1687
 		// BBC?
1612
-		if (!empty($row['bbc']))
1613
-			$row['value'] = parse_bbc($row['value']);
1688
+		if (!empty($row['bbc'])) {
1689
+					$row['value'] = parse_bbc($row['value']);
1690
+		}
1614 1691
 
1615 1692
 		// ... or checkbox?
1616
-		elseif (isset($row['type']) && $row['type'] == 'check')
1617
-			$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1693
+		elseif (isset($row['type']) && $row['type'] == 'check') {
1694
+					$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1695
+		}
1618 1696
 
1619 1697
 		// Enclosing the user input within some other text?
1620
-		if (!empty($row['enclose']))
1621
-			$row['value'] = strtr($row['enclose'], array(
1698
+		if (!empty($row['enclose'])) {
1699
+					$row['value'] = strtr($row['enclose'], array(
1622 1700
 				'{SCRIPTURL}' => $scripturl,
1623 1701
 				'{IMAGES_URL}' => $settings['images_url'],
1624 1702
 				'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1625 1703
 				'{INPUT}' => un_htmlspecialchars($row['value']),
1626 1704
 			));
1705
+		}
1627 1706
 
1628 1707
 		// Send a simple array if there is just 1 param
1629
-		if (count($params) == 1)
1630
-			$return[$row['id_member']] = $row;
1708
+		if (count($params) == 1) {
1709
+					$return[$row['id_member']] = $row;
1710
+		}
1631 1711
 
1632 1712
 		// More than 1? knock yourself out...
1633 1713
 		else
1634 1714
 		{
1635
-			if (!isset($return[$row['id_member']]))
1636
-				$return[$row['id_member']] = array();
1715
+			if (!isset($return[$row['id_member']])) {
1716
+							$return[$row['id_member']] = array();
1717
+			}
1637 1718
 
1638 1719
 			$return[$row['id_member']][$row['variable']] = $row;
1639 1720
 		}
@@ -1667,8 +1748,9 @@  discard block
 block discarded – undo
1667 1748
 	global $context;
1668 1749
 
1669 1750
 	// Don't know any browser!
1670
-	if (empty($context['browser']))
1671
-		detectBrowser();
1751
+	if (empty($context['browser'])) {
1752
+			detectBrowser();
1753
+	}
1672 1754
 
1673 1755
 	return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false;
1674 1756
 }
@@ -1686,8 +1768,9 @@  discard block
 block discarded – undo
1686 1768
 	global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled;
1687 1769
 
1688 1770
 	// The theme was specified by parameter.
1689
-	if (!empty($id_theme))
1690
-		$id_theme = (int) $id_theme;
1771
+	if (!empty($id_theme)) {
1772
+			$id_theme = (int) $id_theme;
1773
+	}
1691 1774
 	// The theme was specified by REQUEST.
1692 1775
 	elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1693 1776
 	{
@@ -1695,54 +1778,61 @@  discard block
 block discarded – undo
1695 1778
 		$_SESSION['id_theme'] = $id_theme;
1696 1779
 	}
1697 1780
 	// The theme was specified by REQUEST... previously.
1698
-	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1699
-		$id_theme = (int) $_SESSION['id_theme'];
1781
+	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) {
1782
+			$id_theme = (int) $_SESSION['id_theme'];
1783
+	}
1700 1784
 	// The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.)
1701
-	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme']))
1702
-		$id_theme = $user_info['theme'];
1785
+	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) {
1786
+			$id_theme = $user_info['theme'];
1787
+	}
1703 1788
 	// The theme was specified by the board.
1704
-	elseif (!empty($board_info['theme']))
1705
-		$id_theme = $board_info['theme'];
1789
+	elseif (!empty($board_info['theme'])) {
1790
+			$id_theme = $board_info['theme'];
1791
+	}
1706 1792
 	// The theme is the forum's default.
1707
-	else
1708
-		$id_theme = $modSettings['theme_guests'];
1793
+	else {
1794
+			$id_theme = $modSettings['theme_guests'];
1795
+	}
1709 1796
 
1710 1797
 	// We already load the basic stuff?
1711 1798
 	if (empty($settings['theme_id']) || $settings['theme_id'] != $id_theme )
1712 1799
 	{
1713 1800
 		// Verify the id_theme... no foul play.
1714 1801
 		// Always allow the board specific theme, if they are overriding.
1715
-		if (!empty($board_info['theme']) && $board_info['override_theme'])
1716
-			$id_theme = $board_info['theme'];
1802
+		if (!empty($board_info['theme']) && $board_info['override_theme']) {
1803
+					$id_theme = $board_info['theme'];
1804
+		}
1717 1805
 		// If they have specified a particular theme to use with SSI allow it to be used.
1718
-		elseif (!empty($ssi_theme) && $id_theme == $ssi_theme)
1719
-			$id_theme = (int) $id_theme;
1720
-		elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1806
+		elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) {
1807
+					$id_theme = (int) $id_theme;
1808
+		} elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1721 1809
 		{
1722 1810
 			$themes = explode(',', $modSettings['enableThemes']);
1723
-			if (!in_array($id_theme, $themes))
1724
-				$id_theme = $modSettings['theme_guests'];
1725
-			else
1726
-				$id_theme = (int) $id_theme;
1811
+			if (!in_array($id_theme, $themes)) {
1812
+							$id_theme = $modSettings['theme_guests'];
1813
+			} else {
1814
+							$id_theme = (int) $id_theme;
1815
+			}
1816
+		} else {
1817
+					$id_theme = (int) $id_theme;
1727 1818
 		}
1728
-		else
1729
-			$id_theme = (int) $id_theme;
1730 1819
 
1731 1820
 		$member = empty($user_info['id']) ? -1 : $user_info['id'];
1732 1821
 
1733 1822
 		// Disable image proxy if we don't have SSL enabled
1734
-		if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2)
1735
-			$image_proxy_enabled = false;
1823
+		if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) {
1824
+					$image_proxy_enabled = false;
1825
+		}
1736 1826
 
1737 1827
 		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated'])
1738 1828
 		{
1739 1829
 			$themeData = $temp;
1740 1830
 			$flag = true;
1831
+		} elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) {
1832
+					$themeData = $temp + array($member => array());
1833
+		} else {
1834
+					$themeData = array(-1 => array(), 0 => array(), $member => array());
1741 1835
 		}
1742
-		elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated'])
1743
-			$themeData = $temp + array($member => array());
1744
-		else
1745
-			$themeData = array(-1 => array(), 0 => array(), $member => array());
1746 1836
 
1747 1837
 		if (empty($flag))
1748 1838
 		{
@@ -1761,31 +1851,37 @@  discard block
 block discarded – undo
1761 1851
 			while ($row = $smcFunc['db_fetch_assoc']($result))
1762 1852
 			{
1763 1853
 				// There are just things we shouldn't be able to change as members.
1764
-				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url')))
1765
-					continue;
1854
+				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) {
1855
+									continue;
1856
+				}
1766 1857
 
1767 1858
 				// If this is the theme_dir of the default theme, store it.
1768
-				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member']))
1769
-					$themeData[0]['default_' . $row['variable']] = $row['value'];
1859
+				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) {
1860
+									$themeData[0]['default_' . $row['variable']] = $row['value'];
1861
+				}
1770 1862
 
1771 1863
 				// If this isn't set yet, is a theme option, or is not the default theme..
1772
-				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1')
1773
-					$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1864
+				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') {
1865
+									$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1866
+				}
1774 1867
 			}
1775 1868
 			$smcFunc['db_free_result']($result);
1776 1869
 
1777
-			if (!empty($themeData[-1]))
1778
-				foreach ($themeData[-1] as $k => $v)
1870
+			if (!empty($themeData[-1])) {
1871
+							foreach ($themeData[-1] as $k => $v)
1779 1872
 				{
1780 1873
 					if (!isset($themeData[$member][$k]))
1781 1874
 						$themeData[$member][$k] = $v;
1875
+			}
1782 1876
 				}
1783 1877
 
1784
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
1785
-				cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1878
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
1879
+							cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1880
+			}
1786 1881
 			// Only if we didn't already load that part of the cache...
1787
-			elseif (!isset($temp))
1788
-				cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1882
+			elseif (!isset($temp)) {
1883
+							cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1884
+			}
1789 1885
 		}
1790 1886
 
1791 1887
 		$settings = $themeData[0];
@@ -1802,22 +1898,26 @@  discard block
 block discarded – undo
1802 1898
 		$settings['template_dirs'][] = $settings['theme_dir'];
1803 1899
 
1804 1900
 		// Based on theme (if there is one).
1805
-		if (!empty($settings['base_theme_dir']))
1806
-			$settings['template_dirs'][] = $settings['base_theme_dir'];
1901
+		if (!empty($settings['base_theme_dir'])) {
1902
+					$settings['template_dirs'][] = $settings['base_theme_dir'];
1903
+		}
1807 1904
 
1808 1905
 		// Lastly the default theme.
1809
-		if ($settings['theme_dir'] != $settings['default_theme_dir'])
1810
-			$settings['template_dirs'][] = $settings['default_theme_dir'];
1906
+		if ($settings['theme_dir'] != $settings['default_theme_dir']) {
1907
+					$settings['template_dirs'][] = $settings['default_theme_dir'];
1908
+		}
1811 1909
 	}
1812 1910
 
1813 1911
 
1814
-	if (!$initialize)
1815
-		return;
1912
+	if (!$initialize) {
1913
+			return;
1914
+	}
1816 1915
 
1817 1916
 	// Check to see if we're forcing SSL
1818 1917
 	if (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 && empty($maintenance) &&
1819
-		(!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI')
1820
-		redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://')));
1918
+		(!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') {
1919
+			redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://')));
1920
+	}
1821 1921
 
1822 1922
 	// Check to see if they're accessing it from the wrong place.
1823 1923
 	if (isset($_SERVER['HTTP_HOST']) || isset($_SERVER['SERVER_NAME']))
@@ -1825,8 +1925,9 @@  discard block
 block discarded – undo
1825 1925
 		$detected_url = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on' ? 'https://' : 'http://';
1826 1926
 		$detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST'];
1827 1927
 		$temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/'));
1828
-		if ($temp != '/')
1829
-			$detected_url .= $temp;
1928
+		if ($temp != '/') {
1929
+					$detected_url .= $temp;
1930
+		}
1830 1931
 	}
1831 1932
 	if (isset($detected_url) && $detected_url != $boardurl)
1832 1933
 	{
@@ -1838,8 +1939,9 @@  discard block
 block discarded – undo
1838 1939
 			foreach ($aliases as $alias)
1839 1940
 			{
1840 1941
 				// Rip off all the boring parts, spaces, etc.
1841
-				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias))
1842
-					$do_fix = true;
1942
+				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) {
1943
+									$do_fix = true;
1944
+				}
1843 1945
 			}
1844 1946
 		}
1845 1947
 
@@ -1847,21 +1949,23 @@  discard block
 block discarded – undo
1847 1949
 		if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI')
1848 1950
 		{
1849 1951
 			// Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;).
1850
-			if (empty($_GET))
1851
-				redirectexit('wwwRedirect');
1852
-			else
1952
+			if (empty($_GET)) {
1953
+							redirectexit('wwwRedirect');
1954
+			} else
1853 1955
 			{
1854 1956
 				$k = key($_GET);
1855 1957
 				$v = current($_GET);
1856 1958
 
1857
-				if ($k != 'wwwRedirect')
1858
-					redirectexit('wwwRedirect;' . $k . '=' . $v);
1959
+				if ($k != 'wwwRedirect') {
1960
+									redirectexit('wwwRedirect;' . $k . '=' . $v);
1961
+				}
1859 1962
 			}
1860 1963
 		}
1861 1964
 
1862 1965
 		// #3 is just a check for SSL...
1863
-		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl)
1864
-			$do_fix = true;
1966
+		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) {
1967
+					$do_fix = true;
1968
+		}
1865 1969
 
1866 1970
 		// Okay, #4 - perhaps it's an IP address?  We're gonna want to use that one, then. (assuming it's the IP or something...)
1867 1971
 		if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1)
@@ -1896,8 +2000,9 @@  discard block
 block discarded – undo
1896 2000
 					$board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl));
1897 2001
 				}
1898 2002
 			}
1899
-			foreach ($context['linktree'] as $k => $dummy)
1900
-				$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2003
+			foreach ($context['linktree'] as $k => $dummy) {
2004
+							$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2005
+			}
1901 2006
 		}
1902 2007
 	}
1903 2008
 	// Set up the contextual user array.
@@ -1916,16 +2021,16 @@  discard block
 block discarded – undo
1916 2021
 			'email' => $user_info['email'],
1917 2022
 			'ignoreusers' => $user_info['ignoreusers'],
1918 2023
 		);
1919
-		if (!$context['user']['is_guest'])
1920
-			$context['user']['name'] = $user_info['name'];
1921
-		elseif ($context['user']['is_guest'] && !empty($txt['guest_title']))
1922
-			$context['user']['name'] = $txt['guest_title'];
2024
+		if (!$context['user']['is_guest']) {
2025
+					$context['user']['name'] = $user_info['name'];
2026
+		} elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) {
2027
+					$context['user']['name'] = $txt['guest_title'];
2028
+		}
1923 2029
 
1924 2030
 		// Determine the current smiley set.
1925 2031
 		$user_info['smiley_set'] = (!in_array($user_info['smiley_set'], explode(',', $modSettings['smiley_sets_known'])) && $user_info['smiley_set'] != 'none') || empty($modSettings['smiley_sets_enable']) ? (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default']) : $user_info['smiley_set'];
1926 2032
 		$context['user']['smiley_set'] = $user_info['smiley_set'];
1927
-	}
1928
-	else
2033
+	} else
1929 2034
 	{
1930 2035
 		// What to do when there is no $user_info (e.g., an error very early in the login process)
1931 2036
 		$context['user'] = array(
@@ -1959,18 +2064,24 @@  discard block
 block discarded – undo
1959 2064
 	}
1960 2065
 
1961 2066
 	// Some basic information...
1962
-	if (!isset($context['html_headers']))
1963
-		$context['html_headers'] = '';
1964
-	if (!isset($context['javascript_files']))
1965
-		$context['javascript_files'] = array();
1966
-	if (!isset($context['css_files']))
1967
-		$context['css_files'] = array();
1968
-	if (!isset($context['css_header']))
1969
-		$context['css_header'] = array();
1970
-	if (!isset($context['javascript_inline']))
1971
-		$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
1972
-	if (!isset($context['javascript_vars']))
1973
-		$context['javascript_vars'] = array();
2067
+	if (!isset($context['html_headers'])) {
2068
+			$context['html_headers'] = '';
2069
+	}
2070
+	if (!isset($context['javascript_files'])) {
2071
+			$context['javascript_files'] = array();
2072
+	}
2073
+	if (!isset($context['css_files'])) {
2074
+			$context['css_files'] = array();
2075
+	}
2076
+	if (!isset($context['css_header'])) {
2077
+			$context['css_header'] = array();
2078
+	}
2079
+	if (!isset($context['javascript_inline'])) {
2080
+			$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
2081
+	}
2082
+	if (!isset($context['javascript_vars'])) {
2083
+			$context['javascript_vars'] = array();
2084
+	}
1974 2085
 
1975 2086
 	$context['login_url'] = (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl) . '?action=login2';
1976 2087
 	$context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | ';
@@ -1982,16 +2093,18 @@  discard block
 block discarded – undo
1982 2093
 	$context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null;
1983 2094
 	$context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null;
1984 2095
 	$context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3;
1985
-	if (isset($modSettings['load_average']))
1986
-		$context['load_average'] = $modSettings['load_average'];
2096
+	if (isset($modSettings['load_average'])) {
2097
+			$context['load_average'] = $modSettings['load_average'];
2098
+	}
1987 2099
 
1988 2100
 	// Detect the browser. This is separated out because it's also used in attachment downloads
1989 2101
 	detectBrowser();
1990 2102
 
1991 2103
 	// Set the top level linktree up.
1992 2104
 	// Note that if we're dealing with certain very early errors (e.g., login) the linktree might not be set yet...
1993
-	if (empty($context['linktree']))
1994
-		$context['linktree'] = array();
2105
+	if (empty($context['linktree'])) {
2106
+			$context['linktree'] = array();
2107
+	}
1995 2108
 	array_unshift($context['linktree'], array(
1996 2109
 		'url' => $scripturl,
1997 2110
 		'name' => $context['forum_name_html_safe']
@@ -2000,8 +2113,9 @@  discard block
 block discarded – undo
2000 2113
 	// This allows sticking some HTML on the page output - useful for controls.
2001 2114
 	$context['insert_after_template'] = '';
2002 2115
 
2003
-	if (!isset($txt))
2004
-		$txt = array();
2116
+	if (!isset($txt)) {
2117
+			$txt = array();
2118
+	}
2005 2119
 
2006 2120
 	$simpleActions = array(
2007 2121
 		'findmember',
@@ -2047,9 +2161,10 @@  discard block
 block discarded – undo
2047 2161
 
2048 2162
 	// See if theres any extra param to check.
2049 2163
 	$requiresXML = false;
2050
-	foreach ($extraParams as $key => $extra)
2051
-		if (isset($_REQUEST[$extra]))
2164
+	foreach ($extraParams as $key => $extra) {
2165
+			if (isset($_REQUEST[$extra]))
2052 2166
 			$requiresXML = true;
2167
+	}
2053 2168
 
2054 2169
 	// Output is fully XML, so no need for the index template.
2055 2170
 	if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML))
@@ -2064,37 +2179,39 @@  discard block
 block discarded – undo
2064 2179
 	{
2065 2180
 		loadLanguage('index+Modifications');
2066 2181
 		$context['template_layers'] = array();
2067
-	}
2068
-
2069
-	else
2182
+	} else
2070 2183
 	{
2071 2184
 		// Custom templates to load, or just default?
2072
-		if (isset($settings['theme_templates']))
2073
-			$templates = explode(',', $settings['theme_templates']);
2074
-		else
2075
-			$templates = array('index');
2185
+		if (isset($settings['theme_templates'])) {
2186
+					$templates = explode(',', $settings['theme_templates']);
2187
+		} else {
2188
+					$templates = array('index');
2189
+		}
2076 2190
 
2077 2191
 		// Load each template...
2078
-		foreach ($templates as $template)
2079
-			loadTemplate($template);
2192
+		foreach ($templates as $template) {
2193
+					loadTemplate($template);
2194
+		}
2080 2195
 
2081 2196
 		// ...and attempt to load their associated language files.
2082 2197
 		$required_files = implode('+', array_merge($templates, array('Modifications')));
2083 2198
 		loadLanguage($required_files, '', false);
2084 2199
 
2085 2200
 		// Custom template layers?
2086
-		if (isset($settings['theme_layers']))
2087
-			$context['template_layers'] = explode(',', $settings['theme_layers']);
2088
-		else
2089
-			$context['template_layers'] = array('html', 'body');
2201
+		if (isset($settings['theme_layers'])) {
2202
+					$context['template_layers'] = explode(',', $settings['theme_layers']);
2203
+		} else {
2204
+					$context['template_layers'] = array('html', 'body');
2205
+		}
2090 2206
 	}
2091 2207
 
2092 2208
 	// Initialize the theme.
2093 2209
 	loadSubTemplate('init', 'ignore');
2094 2210
 
2095 2211
 	// Allow overriding the board wide time/number formats.
2096
-	if (empty($user_settings['time_format']) && !empty($txt['time_format']))
2097
-		$user_info['time_format'] = $txt['time_format'];
2212
+	if (empty($user_settings['time_format']) && !empty($txt['time_format'])) {
2213
+			$user_info['time_format'] = $txt['time_format'];
2214
+	}
2098 2215
 
2099 2216
 	// Set the character set from the template.
2100 2217
 	$context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set'];
@@ -2102,12 +2219,14 @@  discard block
 block discarded – undo
2102 2219
 	$context['right_to_left'] = !empty($txt['lang_rtl']);
2103 2220
 
2104 2221
 	// Guests may still need a name.
2105
-	if ($context['user']['is_guest'] && empty($context['user']['name']))
2106
-		$context['user']['name'] = $txt['guest_title'];
2222
+	if ($context['user']['is_guest'] && empty($context['user']['name'])) {
2223
+			$context['user']['name'] = $txt['guest_title'];
2224
+	}
2107 2225
 
2108 2226
 	// Any theme-related strings that need to be loaded?
2109
-	if (!empty($settings['require_theme_strings']))
2110
-		loadLanguage('ThemeStrings', '', false);
2227
+	if (!empty($settings['require_theme_strings'])) {
2228
+			loadLanguage('ThemeStrings', '', false);
2229
+	}
2111 2230
 
2112 2231
 	// Make a special URL for the language.
2113 2232
 	$settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']);
@@ -2118,8 +2237,9 @@  discard block
 block discarded – undo
2118 2237
 	// Here is my luvly Responsive CSS
2119 2238
 	loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true), 'smf_responsive');
2120 2239
 
2121
-	if ($context['right_to_left'])
2122
-		loadCSSFile('rtl.css', array(), 'smf_rtl');
2240
+	if ($context['right_to_left']) {
2241
+			loadCSSFile('rtl.css', array(), 'smf_rtl');
2242
+	}
2123 2243
 
2124 2244
 	// We allow theme variants, because we're cool.
2125 2245
 	$context['theme_variant'] = '';
@@ -2127,14 +2247,17 @@  discard block
 block discarded – undo
2127 2247
 	if (!empty($settings['theme_variants']))
2128 2248
 	{
2129 2249
 		// Overriding - for previews and that ilk.
2130
-		if (!empty($_REQUEST['variant']))
2131
-			$_SESSION['id_variant'] = $_REQUEST['variant'];
2250
+		if (!empty($_REQUEST['variant'])) {
2251
+					$_SESSION['id_variant'] = $_REQUEST['variant'];
2252
+		}
2132 2253
 		// User selection?
2133
-		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum'))
2134
-			$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2254
+		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) {
2255
+					$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2256
+		}
2135 2257
 		// If not a user variant, select the default.
2136
-		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants']))
2137
-			$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2258
+		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) {
2259
+					$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2260
+		}
2138 2261
 
2139 2262
 		// Do this to keep things easier in the templates.
2140 2263
 		$context['theme_variant'] = '_' . $context['theme_variant'];
@@ -2143,20 +2266,23 @@  discard block
 block discarded – undo
2143 2266
 		if (!empty($context['theme_variant']))
2144 2267
 		{
2145 2268
 			loadCSSFile('index' . $context['theme_variant'] . '.css', array(), 'smf_index' . $context['theme_variant']);
2146
-			if ($context['right_to_left'])
2147
-				loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']);
2269
+			if ($context['right_to_left']) {
2270
+							loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']);
2271
+			}
2148 2272
 		}
2149 2273
 	}
2150 2274
 
2151 2275
 	// Let's be compatible with old themes!
2152
-	if (!function_exists('template_html_above') && in_array('html', $context['template_layers']))
2153
-		$context['template_layers'] = array('main');
2276
+	if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) {
2277
+			$context['template_layers'] = array('main');
2278
+	}
2154 2279
 
2155 2280
 	$context['tabindex'] = 1;
2156 2281
 
2157 2282
 	// Compatibility.
2158
-	if (!isset($settings['theme_version']))
2159
-		$modSettings['memberCount'] = $modSettings['totalMembers'];
2283
+	if (!isset($settings['theme_version'])) {
2284
+			$modSettings['memberCount'] = $modSettings['totalMembers'];
2285
+	}
2160 2286
 
2161 2287
 	// Default JS variables for use in every theme
2162 2288
 	$context['javascript_vars'] = array(
@@ -2175,18 +2301,18 @@  discard block
 block discarded – undo
2175 2301
 	);
2176 2302
 
2177 2303
 	// Add the JQuery library to the list of files to load.
2178
-	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn')
2179
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2180
-
2181
-	elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local')
2182
-		loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery');
2183
-
2184
-	elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom')
2185
-		loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2304
+	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') {
2305
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2306
+	} elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') {
2307
+			loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery');
2308
+	} elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') {
2309
+			loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2310
+	}
2186 2311
 
2187 2312
 	// Auto loading? template_javascript() will take care of the local half of this.
2188
-	else
2189
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2313
+	else {
2314
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2315
+	}
2190 2316
 
2191 2317
 	// Queue our JQuery plugins!
2192 2318
 	loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins');
@@ -2209,12 +2335,12 @@  discard block
 block discarded – undo
2209 2335
 			require_once($sourcedir . '/ScheduledTasks.php');
2210 2336
 
2211 2337
 			// What to do, what to do?!
2212
-			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time())
2213
-				AutoTask();
2214
-			else
2215
-				ReduceMailQueue();
2216
-		}
2217
-		else
2338
+			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) {
2339
+							AutoTask();
2340
+			} else {
2341
+							ReduceMailQueue();
2342
+			}
2343
+		} else
2218 2344
 		{
2219 2345
 			$type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq';
2220 2346
 			$ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time'];
@@ -2265,8 +2391,9 @@  discard block
 block discarded – undo
2265 2391
 		foreach ($theme_includes as $include)
2266 2392
 		{
2267 2393
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
2268
-			if (file_exists($include))
2269
-				require_once($include);
2394
+			if (file_exists($include)) {
2395
+							require_once($include);
2396
+			}
2270 2397
 		}
2271 2398
 	}
2272 2399
 
@@ -2296,16 +2423,19 @@  discard block
 block discarded – undo
2296 2423
 	// Do any style sheets first, cause we're easy with those.
2297 2424
 	if (!empty($style_sheets))
2298 2425
 	{
2299
-		if (!is_array($style_sheets))
2300
-			$style_sheets = array($style_sheets);
2426
+		if (!is_array($style_sheets)) {
2427
+					$style_sheets = array($style_sheets);
2428
+		}
2301 2429
 
2302
-		foreach ($style_sheets as $sheet)
2303
-			loadCSSFile($sheet . '.css', array(), $sheet);
2430
+		foreach ($style_sheets as $sheet) {
2431
+					loadCSSFile($sheet . '.css', array(), $sheet);
2432
+		}
2304 2433
 	}
2305 2434
 
2306 2435
 	// No template to load?
2307
-	if ($template_name === false)
2308
-		return true;
2436
+	if ($template_name === false) {
2437
+			return true;
2438
+	}
2309 2439
 
2310 2440
 	$loaded = false;
2311 2441
 	foreach ($settings['template_dirs'] as $template_dir)
@@ -2320,12 +2450,14 @@  discard block
 block discarded – undo
2320 2450
 
2321 2451
 	if ($loaded)
2322 2452
 	{
2323
-		if ($db_show_debug === true)
2324
-			$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2453
+		if ($db_show_debug === true) {
2454
+					$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2455
+		}
2325 2456
 
2326 2457
 		// If they have specified an initialization function for this template, go ahead and call it now.
2327
-		if (function_exists('template_' . $template_name . '_init'))
2328
-			call_user_func('template_' . $template_name . '_init');
2458
+		if (function_exists('template_' . $template_name . '_init')) {
2459
+					call_user_func('template_' . $template_name . '_init');
2460
+		}
2329 2461
 	}
2330 2462
 	// Hmmm... doesn't exist?!  I don't suppose the directory is wrong, is it?
2331 2463
 	elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default'))
@@ -2345,13 +2477,14 @@  discard block
 block discarded – undo
2345 2477
 		loadTemplate($template_name);
2346 2478
 	}
2347 2479
 	// Cause an error otherwise.
2348
-	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal)
2349
-		fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2350
-	elseif ($fatal)
2351
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2352
-	else
2353
-		return false;
2354
-}
2480
+	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) {
2481
+			fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2482
+	} elseif ($fatal) {
2483
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2484
+	} else {
2485
+			return false;
2486
+	}
2487
+	}
2355 2488
 
2356 2489
 /**
2357 2490
  * Load a sub-template.
@@ -2369,17 +2502,19 @@  discard block
 block discarded – undo
2369 2502
 {
2370 2503
 	global $context, $txt, $db_show_debug;
2371 2504
 
2372
-	if ($db_show_debug === true)
2373
-		$context['debug']['sub_templates'][] = $sub_template_name;
2505
+	if ($db_show_debug === true) {
2506
+			$context['debug']['sub_templates'][] = $sub_template_name;
2507
+	}
2374 2508
 
2375 2509
 	// Figure out what the template function is named.
2376 2510
 	$theme_function = 'template_' . $sub_template_name;
2377
-	if (function_exists($theme_function))
2378
-		$theme_function();
2379
-	elseif ($fatal === false)
2380
-		fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2381
-	elseif ($fatal !== 'ignore')
2382
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2511
+	if (function_exists($theme_function)) {
2512
+			$theme_function();
2513
+	} elseif ($fatal === false) {
2514
+			fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2515
+	} elseif ($fatal !== 'ignore') {
2516
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2517
+	}
2383 2518
 
2384 2519
 	// Are we showing debugging for templates?  Just make sure not to do it before the doctype...
2385 2520
 	if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml']))
@@ -2416,8 +2551,9 @@  discard block
 block discarded – undo
2416 2551
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2417 2552
 
2418 2553
 	// If this is an external file, automatically set this to false.
2419
-	if (!empty($params['external']))
2420
-		$params['minimize'] = false;
2554
+	if (!empty($params['external'])) {
2555
+			$params['minimize'] = false;
2556
+	}
2421 2557
 
2422 2558
 	// Account for shorthand like admin.css?alp21 filenames
2423 2559
 	$has_seed = strpos($fileName, '.css?');
@@ -2434,13 +2570,10 @@  discard block
 block discarded – undo
2434 2570
 			{
2435 2571
 				$fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2436 2572
 				$filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2573
+			} else {
2574
+							$fileUrl = false;
2437 2575
 			}
2438
-
2439
-			else
2440
-				$fileUrl = false;
2441
-		}
2442
-
2443
-		else
2576
+		} else
2444 2577
 		{
2445 2578
 			$fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2446 2579
 			$filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2455,12 +2588,14 @@  discard block
 block discarded – undo
2455 2588
 	}
2456 2589
 
2457 2590
 	// Add it to the array for use in the template
2458
-	if (!empty($fileName))
2459
-		$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2591
+	if (!empty($fileName)) {
2592
+			$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2593
+	}
2460 2594
 
2461
-	if (!empty($context['right_to_left']) && !empty($params['rtl']))
2462
-		loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2463
-}
2595
+	if (!empty($context['right_to_left']) && !empty($params['rtl'])) {
2596
+			loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2597
+	}
2598
+	}
2464 2599
 
2465 2600
 /**
2466 2601
  * Add a block of inline css code to be executed later
@@ -2477,8 +2612,9 @@  discard block
 block discarded – undo
2477 2612
 	global $context;
2478 2613
 
2479 2614
 	// Gotta add something...
2480
-	if (empty($css))
2481
-		return false;
2615
+	if (empty($css)) {
2616
+			return false;
2617
+	}
2482 2618
 
2483 2619
 	$context['css_header'][] = $css;
2484 2620
 }
@@ -2513,8 +2649,9 @@  discard block
 block discarded – undo
2513 2649
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2514 2650
 
2515 2651
 	// If this is an external file, automatically set this to false.
2516
-	if (!empty($params['external']))
2517
-		$params['minimize'] = false;
2652
+	if (!empty($params['external'])) {
2653
+			$params['minimize'] = false;
2654
+	}
2518 2655
 
2519 2656
 	// Account for shorthand like admin.js?alp21 filenames
2520 2657
 	$has_seed = strpos($fileName, '.js?');
@@ -2531,16 +2668,12 @@  discard block
 block discarded – undo
2531 2668
 			{
2532 2669
 				$fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2533 2670
 				$filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2534
-			}
2535
-
2536
-			else
2671
+			} else
2537 2672
 			{
2538 2673
 				$fileUrl = false;
2539 2674
 				$filePath = false;
2540 2675
 			}
2541
-		}
2542
-
2543
-		else
2676
+		} else
2544 2677
 		{
2545 2678
 			$fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2546 2679
 			$filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2555,9 +2688,10 @@  discard block
 block discarded – undo
2555 2688
 	}
2556 2689
 
2557 2690
 	// Add it to the array for use in the template
2558
-	if (!empty($fileName))
2559
-		$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2560
-}
2691
+	if (!empty($fileName)) {
2692
+			$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2693
+	}
2694
+	}
2561 2695
 
2562 2696
 /**
2563 2697
  * Add a Javascript variable for output later (for feeding text strings and similar to JS)
@@ -2571,9 +2705,10 @@  discard block
 block discarded – undo
2571 2705
 {
2572 2706
 	global $context;
2573 2707
 
2574
-	if (!empty($key) && (!empty($value) || $value === '0'))
2575
-		$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2576
-}
2708
+	if (!empty($key) && (!empty($value) || $value === '0')) {
2709
+			$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2710
+	}
2711
+	}
2577 2712
 
2578 2713
 /**
2579 2714
  * Add a block of inline Javascript code to be executed later
@@ -2590,8 +2725,9 @@  discard block
 block discarded – undo
2590 2725
 {
2591 2726
 	global $context;
2592 2727
 
2593
-	if (empty($javascript))
2594
-		return false;
2728
+	if (empty($javascript)) {
2729
+			return false;
2730
+	}
2595 2731
 
2596 2732
 	$context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript;
2597 2733
 }
@@ -2612,15 +2748,18 @@  discard block
 block discarded – undo
2612 2748
 	static $already_loaded = array();
2613 2749
 
2614 2750
 	// Default to the user's language.
2615
-	if ($lang == '')
2616
-		$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2751
+	if ($lang == '') {
2752
+			$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2753
+	}
2617 2754
 
2618 2755
 	// Do we want the English version of language file as fallback?
2619
-	if (empty($modSettings['disable_language_fallback']) && $lang != 'english')
2620
-		loadLanguage($template_name, 'english', false);
2756
+	if (empty($modSettings['disable_language_fallback']) && $lang != 'english') {
2757
+			loadLanguage($template_name, 'english', false);
2758
+	}
2621 2759
 
2622
-	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang)
2623
-		return $lang;
2760
+	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) {
2761
+			return $lang;
2762
+	}
2624 2763
 
2625 2764
 	// Make sure we have $settings - if not we're in trouble and need to find it!
2626 2765
 	if (empty($settings['default_theme_dir']))
@@ -2631,8 +2770,9 @@  discard block
 block discarded – undo
2631 2770
 
2632 2771
 	// What theme are we in?
2633 2772
 	$theme_name = basename($settings['theme_url']);
2634
-	if (empty($theme_name))
2635
-		$theme_name = 'unknown';
2773
+	if (empty($theme_name)) {
2774
+			$theme_name = 'unknown';
2775
+	}
2636 2776
 
2637 2777
 	// For each file open it up and write it out!
2638 2778
 	foreach (explode('+', $template_name) as $template)
@@ -2674,8 +2814,9 @@  discard block
 block discarded – undo
2674 2814
 				$found = true;
2675 2815
 
2676 2816
 				// setlocale is required for basename() & pathinfo() to work properly on the selected language
2677
-				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set']))
2678
-					setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2817
+				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) {
2818
+									setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2819
+				}
2679 2820
 
2680 2821
 				break;
2681 2822
 			}
@@ -2715,8 +2856,9 @@  discard block
 block discarded – undo
2715 2856
 	}
2716 2857
 
2717 2858
 	// Keep track of what we're up to soldier.
2718
-	if ($db_show_debug === true)
2719
-		$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2859
+	if ($db_show_debug === true) {
2860
+			$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2861
+	}
2720 2862
 
2721 2863
 	// Remember what we have loaded, and in which language.
2722 2864
 	$already_loaded[$template_name] = $lang;
@@ -2762,8 +2904,9 @@  discard block
 block discarded – undo
2762 2904
 				)
2763 2905
 			);
2764 2906
 			// In the EXTREMELY unlikely event this happens, give an error message.
2765
-			if ($smcFunc['db_num_rows']($result) == 0)
2766
-				fatal_lang_error('parent_not_found', 'critical');
2907
+			if ($smcFunc['db_num_rows']($result) == 0) {
2908
+							fatal_lang_error('parent_not_found', 'critical');
2909
+			}
2767 2910
 			while ($row = $smcFunc['db_fetch_assoc']($result))
2768 2911
 			{
2769 2912
 				if (!isset($boards[$row['id_board']]))
@@ -2780,8 +2923,8 @@  discard block
 block discarded – undo
2780 2923
 					);
2781 2924
 				}
2782 2925
 				// If a moderator exists for this board, add that moderator for all children too.
2783
-				if (!empty($row['id_moderator']))
2784
-					foreach ($boards as $id => $dummy)
2926
+				if (!empty($row['id_moderator'])) {
2927
+									foreach ($boards as $id => $dummy)
2785 2928
 					{
2786 2929
 						$boards[$id]['moderators'][$row['id_moderator']] = array(
2787 2930
 							'id' => $row['id_moderator'],
@@ -2789,11 +2932,12 @@  discard block
 block discarded – undo
2789 2932
 							'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
2790 2933
 							'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
2791 2934
 						);
2935
+				}
2792 2936
 					}
2793 2937
 
2794 2938
 				// If a moderator group exists for this board, add that moderator group for all children too
2795
-				if (!empty($row['id_moderator_group']))
2796
-					foreach ($boards as $id => $dummy)
2939
+				if (!empty($row['id_moderator_group'])) {
2940
+									foreach ($boards as $id => $dummy)
2797 2941
 					{
2798 2942
 						$boards[$id]['moderator_groups'][$row['id_moderator_group']] = array(
2799 2943
 							'id' => $row['id_moderator_group'],
@@ -2801,6 +2945,7 @@  discard block
 block discarded – undo
2801 2945
 							'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
2802 2946
 							'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
2803 2947
 						);
2948
+				}
2804 2949
 					}
2805 2950
 			}
2806 2951
 			$smcFunc['db_free_result']($result);
@@ -2827,23 +2972,27 @@  discard block
 block discarded – undo
2827 2972
 	if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null)
2828 2973
 	{
2829 2974
 		// If we don't have our ucwords function defined yet, let's load the settings data.
2830
-		if (empty($smcFunc['ucwords']))
2831
-			reloadSettings();
2975
+		if (empty($smcFunc['ucwords'])) {
2976
+					reloadSettings();
2977
+		}
2832 2978
 
2833 2979
 		// If we don't have our theme information yet, let's get it.
2834
-		if (empty($settings['default_theme_dir']))
2835
-			loadTheme(0, false);
2980
+		if (empty($settings['default_theme_dir'])) {
2981
+					loadTheme(0, false);
2982
+		}
2836 2983
 
2837 2984
 		// Default language directories to try.
2838 2985
 		$language_directories = array(
2839 2986
 			$settings['default_theme_dir'] . '/languages',
2840 2987
 		);
2841
-		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir'])
2842
-			$language_directories[] = $settings['actual_theme_dir'] . '/languages';
2988
+		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) {
2989
+					$language_directories[] = $settings['actual_theme_dir'] . '/languages';
2990
+		}
2843 2991
 
2844 2992
 		// We possibly have a base theme directory.
2845
-		if (!empty($settings['base_theme_dir']))
2846
-			$language_directories[] = $settings['base_theme_dir'] . '/languages';
2993
+		if (!empty($settings['base_theme_dir'])) {
2994
+					$language_directories[] = $settings['base_theme_dir'] . '/languages';
2995
+		}
2847 2996
 
2848 2997
 		// Remove any duplicates.
2849 2998
 		$language_directories = array_unique($language_directories);
@@ -2857,20 +3006,21 @@  discard block
 block discarded – undo
2857 3006
 		foreach ($language_directories as $language_dir)
2858 3007
 		{
2859 3008
 			// Can't look in here... doesn't exist!
2860
-			if (!file_exists($language_dir))
2861
-				continue;
3009
+			if (!file_exists($language_dir)) {
3010
+							continue;
3011
+			}
2862 3012
 
2863 3013
 			$dir = dir($language_dir);
2864 3014
 			while ($entry = $dir->read())
2865 3015
 			{
2866 3016
 				// Look for the index language file... For good measure skip any "index.language-utf8.php" files
2867
-				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches))
2868
-					continue;
2869
-
2870
-				if (!empty($langList) && !empty($langList[$matches[1]]))
2871
-					$langName = $langList[$matches[1]];
3017
+				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) {
3018
+									continue;
3019
+				}
2872 3020
 
2873
-				else
3021
+				if (!empty($langList) && !empty($langList[$matches[1]])) {
3022
+									$langName = $langList[$matches[1]];
3023
+				} else
2874 3024
 				{
2875 3025
 					$langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' ')));
2876 3026
 
@@ -2911,12 +3061,14 @@  discard block
 block discarded – undo
2911 3061
 		}
2912 3062
 
2913 3063
 		// Do we need to store the lang list?
2914
-		if (empty($langList))
2915
-			updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3064
+		if (empty($langList)) {
3065
+					updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3066
+		}
2916 3067
 
2917 3068
 		// Let's cash in on this deal.
2918
-		if (!empty($modSettings['cache_enable']))
2919
-			cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3069
+		if (!empty($modSettings['cache_enable'])) {
3070
+					cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3071
+		}
2920 3072
 	}
2921 3073
 
2922 3074
 	return $context['languages'];
@@ -2939,8 +3091,9 @@  discard block
 block discarded – undo
2939 3091
 	global $modSettings, $options, $txt;
2940 3092
 	static $censor_vulgar = null, $censor_proper;
2941 3093
 
2942
-	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '')
2943
-		return $text;
3094
+	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') {
3095
+			return $text;
3096
+	}
2944 3097
 
2945 3098
 	// If they haven't yet been loaded, load them.
2946 3099
 	if ($censor_vulgar == null)
@@ -2968,9 +3121,9 @@  discard block
 block discarded – undo
2968 3121
 	{
2969 3122
 		$func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace';
2970 3123
 		$text = $func($censor_vulgar, $censor_proper, $text);
3124
+	} else {
3125
+			$text = preg_replace($censor_vulgar, $censor_proper, $text);
2971 3126
 	}
2972
-	else
2973
-		$text = preg_replace($censor_vulgar, $censor_proper, $text);
2974 3127
 
2975 3128
 	return $text;
2976 3129
 }
@@ -2996,38 +3149,42 @@  discard block
 block discarded – undo
2996 3149
 	@ini_set('track_errors', '1');
2997 3150
 
2998 3151
 	// Don't include the file more than once, if $once is true.
2999
-	if ($once && in_array($filename, $templates))
3000
-		return;
3152
+	if ($once && in_array($filename, $templates)) {
3153
+			return;
3154
+	}
3001 3155
 	// Add this file to the include list, whether $once is true or not.
3002
-	else
3003
-		$templates[] = $filename;
3156
+	else {
3157
+			$templates[] = $filename;
3158
+	}
3004 3159
 
3005 3160
 	// Are we going to use eval?
3006 3161
 	if (empty($modSettings['disableTemplateEval']))
3007 3162
 	{
3008 3163
 		$file_found = file_exists($filename) && eval('?' . '>' . rtrim(file_get_contents($filename))) !== false;
3009 3164
 		$settings['current_include_filename'] = $filename;
3010
-	}
3011
-	else
3165
+	} else
3012 3166
 	{
3013 3167
 		$file_found = file_exists($filename);
3014 3168
 
3015
-		if ($once && $file_found)
3016
-			require_once($filename);
3017
-		elseif ($file_found)
3018
-			require($filename);
3169
+		if ($once && $file_found) {
3170
+					require_once($filename);
3171
+		} elseif ($file_found) {
3172
+					require($filename);
3173
+		}
3019 3174
 	}
3020 3175
 
3021 3176
 	if ($file_found !== true)
3022 3177
 	{
3023 3178
 		ob_end_clean();
3024
-		if (!empty($modSettings['enableCompressedOutput']))
3025
-			@ob_start('ob_gzhandler');
3026
-		else
3027
-			ob_start();
3179
+		if (!empty($modSettings['enableCompressedOutput'])) {
3180
+					@ob_start('ob_gzhandler');
3181
+		} else {
3182
+					ob_start();
3183
+		}
3028 3184
 
3029
-		if (isset($_GET['debug']))
3030
-			header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3185
+		if (isset($_GET['debug'])) {
3186
+					header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3187
+		}
3031 3188
 
3032 3189
 		// Don't cache error pages!!
3033 3190
 		header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
@@ -3046,12 +3203,13 @@  discard block
 block discarded – undo
3046 3203
 		echo '<!DOCTYPE html>
3047 3204
 <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '>
3048 3205
 	<head>';
3049
-		if (isset($context['character_set']))
3050
-			echo '
3206
+		if (isset($context['character_set'])) {
3207
+					echo '
3051 3208
 		<meta charset="', $context['character_set'], '">';
3209
+		}
3052 3210
 
3053
-		if (!empty($maintenance) && !allowedTo('admin_forum'))
3054
-			echo '
3211
+		if (!empty($maintenance) && !allowedTo('admin_forum')) {
3212
+					echo '
3055 3213
 		<title>', $mtitle, '</title>
3056 3214
 	</head>
3057 3215
 	<body>
@@ -3059,8 +3217,8 @@  discard block
 block discarded – undo
3059 3217
 		', $mmessage, '
3060 3218
 	</body>
3061 3219
 </html>';
3062
-		elseif (!allowedTo('admin_forum'))
3063
-			echo '
3220
+		} elseif (!allowedTo('admin_forum')) {
3221
+					echo '
3064 3222
 		<title>', $txt['template_parse_error'], '</title>
3065 3223
 	</head>
3066 3224
 	<body>
@@ -3068,16 +3226,18 @@  discard block
 block discarded – undo
3068 3226
 		', $txt['template_parse_error_message'], '
3069 3227
 	</body>
3070 3228
 </html>';
3071
-		else
3229
+		} else
3072 3230
 		{
3073 3231
 			require_once($sourcedir . '/Subs-Package.php');
3074 3232
 
3075 3233
 			$error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3076 3234
 			$error_array = error_get_last();
3077
-			if (empty($error) && ini_get('track_errors') && !empty($error_array))
3078
-				$error = $error_array['message'];
3079
-			if (empty($error))
3080
-				$error = $txt['template_parse_errmsg'];
3235
+			if (empty($error) && ini_get('track_errors') && !empty($error_array)) {
3236
+							$error = $error_array['message'];
3237
+			}
3238
+			if (empty($error)) {
3239
+							$error = $txt['template_parse_errmsg'];
3240
+			}
3081 3241
 
3082 3242
 			$error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>'));
3083 3243
 
@@ -3088,11 +3248,12 @@  discard block
 block discarded – undo
3088 3248
 		<h3>', $txt['template_parse_error'], '</h3>
3089 3249
 		', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3090 3250
 
3091
-			if (!empty($error))
3092
-				echo '
3251
+			if (!empty($error)) {
3252
+							echo '
3093 3253
 		<hr>
3094 3254
 
3095 3255
 		<div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>';
3256
+			}
3096 3257
 
3097 3258
 			// I know, I know... this is VERY COMPLICATED.  Still, it's good.
3098 3259
 			if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0)
@@ -3102,10 +3263,11 @@  discard block
 block discarded – undo
3102 3263
 				$data2 = preg_split('~\<br( /)?\>~', $data2);
3103 3264
 
3104 3265
 				// Fix the PHP code stuff...
3105
-				if (!isBrowser('gecko'))
3106
-					$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3107
-				else
3108
-					$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3266
+				if (!isBrowser('gecko')) {
3267
+									$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3268
+				} else {
3269
+									$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3270
+				}
3109 3271
 
3110 3272
 				// Now we get to work around a bug in PHP where it doesn't escape <br>s!
3111 3273
 				$j = -1;
@@ -3113,8 +3275,9 @@  discard block
 block discarded – undo
3113 3275
 				{
3114 3276
 					$j++;
3115 3277
 
3116
-					if (substr_count($line, '<br>') == 0)
3117
-						continue;
3278
+					if (substr_count($line, '<br>') == 0) {
3279
+											continue;
3280
+					}
3118 3281
 
3119 3282
 					$n = substr_count($line, '<br>');
3120 3283
 					for ($i = 0; $i < $n; $i++)
@@ -3133,38 +3296,42 @@  discard block
 block discarded – undo
3133 3296
 				// Figure out what the color coding was before...
3134 3297
 				$line = max($match[1] - 9, 1);
3135 3298
 				$last_line = '';
3136
-				for ($line2 = $line - 1; $line2 > 1; $line2--)
3137
-					if (strpos($data2[$line2], '<') !== false)
3299
+				for ($line2 = $line - 1; $line2 > 1; $line2--) {
3300
+									if (strpos($data2[$line2], '<') !== false)
3138 3301
 					{
3139 3302
 						if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0)
3140 3303
 							$last_line = $color_match[1];
3304
+				}
3141 3305
 						break;
3142 3306
 					}
3143 3307
 
3144 3308
 				// Show the relevant lines...
3145 3309
 				for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++)
3146 3310
 				{
3147
-					if ($line == $match[1])
3148
-						echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3311
+					if ($line == $match[1]) {
3312
+											echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3313
+					}
3149 3314
 
3150 3315
 					echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> ';
3151
-					if (isset($data2[$line]) && $data2[$line] != '')
3152
-						echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3316
+					if (isset($data2[$line]) && $data2[$line] != '') {
3317
+											echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3318
+					}
3153 3319
 
3154 3320
 					if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0)
3155 3321
 					{
3156 3322
 						$last_line = $color_match[1];
3157 3323
 						echo '</', substr($last_line, 1, 4), '>';
3324
+					} elseif ($last_line != '' && strpos($data2[$line], '<') !== false) {
3325
+											$last_line = '';
3326
+					} elseif ($last_line != '' && $data2[$line] != '') {
3327
+											echo '</', substr($last_line, 1, 4), '>';
3158 3328
 					}
3159
-					elseif ($last_line != '' && strpos($data2[$line], '<') !== false)
3160
-						$last_line = '';
3161
-					elseif ($last_line != '' && $data2[$line] != '')
3162
-						echo '</', substr($last_line, 1, 4), '>';
3163 3329
 
3164
-					if ($line == $match[1])
3165
-						echo '</pre></div><pre style="margin: 0;">';
3166
-					else
3167
-						echo "\n";
3330
+					if ($line == $match[1]) {
3331
+											echo '</pre></div><pre style="margin: 0;">';
3332
+					} else {
3333
+											echo "\n";
3334
+					}
3168 3335
 				}
3169 3336
 
3170 3337
 				echo '</pre></div>';
@@ -3188,8 +3355,9 @@  discard block
 block discarded – undo
3188 3355
 	global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port;
3189 3356
 
3190 3357
 	// Figure out what type of database we are using.
3191
-	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
3192
-		$db_type = 'mysql';
3358
+	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) {
3359
+			$db_type = 'mysql';
3360
+	}
3193 3361
 
3194 3362
 	// Load the file for the database.
3195 3363
 	require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
@@ -3197,8 +3365,9 @@  discard block
 block discarded – undo
3197 3365
 	$db_options = array();
3198 3366
 
3199 3367
 	// Add in the port if needed
3200
-	if (!empty($db_port))
3201
-		$db_options['port'] = $db_port;
3368
+	if (!empty($db_port)) {
3369
+			$db_options['port'] = $db_port;
3370
+	}
3202 3371
 
3203 3372
 	// If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use.
3204 3373
 	if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd))
@@ -3217,13 +3386,15 @@  discard block
 block discarded – undo
3217 3386
 	}
3218 3387
 
3219 3388
 	// Safe guard here, if there isn't a valid connection lets put a stop to it.
3220
-	if (!$db_connection)
3221
-		display_db_error();
3389
+	if (!$db_connection) {
3390
+			display_db_error();
3391
+	}
3222 3392
 
3223 3393
 	// If in SSI mode fix up the prefix.
3224
-	if (SMF == 'SSI')
3225
-		db_fix_prefix($db_prefix, $db_name);
3226
-}
3394
+	if (SMF == 'SSI') {
3395
+			db_fix_prefix($db_prefix, $db_name);
3396
+	}
3397
+	}
3227 3398
 
3228 3399
 /**
3229 3400
  * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it.
@@ -3237,10 +3408,11 @@  discard block
 block discarded – undo
3237 3408
 	global $sourcedir, $cacheAPI, $cache_accelerator;
3238 3409
 
3239 3410
 	// Not overriding this and we have a cacheAPI, send it back.
3240
-	if (empty($overrideCache) && is_object($cacheAPI))
3241
-		return $cacheAPI;
3242
-	elseif (is_null($cacheAPI))
3243
-		$cacheAPI = false;
3411
+	if (empty($overrideCache) && is_object($cacheAPI)) {
3412
+			return $cacheAPI;
3413
+	} elseif (is_null($cacheAPI)) {
3414
+			$cacheAPI = false;
3415
+	}
3244 3416
 
3245 3417
 	// Make sure our class is in session.
3246 3418
 	require_once($sourcedir . '/Class-CacheAPI.php');
@@ -3261,8 +3433,9 @@  discard block
 block discarded – undo
3261 3433
 		if (!$testAPI->isSupported())
3262 3434
 		{
3263 3435
 			// Can we save ourselves?
3264
-			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf')
3265
-				return loadCacheAccelerator(null, false);
3436
+			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') {
3437
+							return loadCacheAccelerator(null, false);
3438
+			}
3266 3439
 			return false;
3267 3440
 		}
3268 3441
 
@@ -3274,9 +3447,9 @@  discard block
 block discarded – undo
3274 3447
 		{
3275 3448
 			$cacheAPI = $testAPI;
3276 3449
 			return $cacheAPI;
3450
+		} else {
3451
+					return $testAPI;
3277 3452
 		}
3278
-		else
3279
-			return $testAPI;
3280 3453
 	}
3281 3454
 }
3282 3455
 
@@ -3296,8 +3469,9 @@  discard block
 block discarded – undo
3296 3469
 
3297 3470
 	// @todo Why are we doing this if caching is disabled?
3298 3471
 
3299
-	if (function_exists('call_integration_hook'))
3300
-		call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3472
+	if (function_exists('call_integration_hook')) {
3473
+			call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3474
+	}
3301 3475
 
3302 3476
 	/* Refresh the cache if either:
3303 3477
 		1. Caching is disabled.
@@ -3311,16 +3485,19 @@  discard block
 block discarded – undo
3311 3485
 		require_once($sourcedir . '/' . $file);
3312 3486
 		$cache_block = call_user_func_array($function, $params);
3313 3487
 
3314
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level)
3315
-			cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3488
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) {
3489
+					cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3490
+		}
3316 3491
 	}
3317 3492
 
3318 3493
 	// Some cached data may need a freshening up after retrieval.
3319
-	if (!empty($cache_block['post_retri_eval']))
3320
-		eval($cache_block['post_retri_eval']);
3494
+	if (!empty($cache_block['post_retri_eval'])) {
3495
+			eval($cache_block['post_retri_eval']);
3496
+	}
3321 3497
 
3322
-	if (function_exists('call_integration_hook'))
3323
-		call_integration_hook('post_cache_quick_get', array(&$cache_block));
3498
+	if (function_exists('call_integration_hook')) {
3499
+			call_integration_hook('post_cache_quick_get', array(&$cache_block));
3500
+	}
3324 3501
 
3325 3502
 	return $cache_block['data'];
3326 3503
 }
@@ -3347,8 +3524,9 @@  discard block
 block discarded – undo
3347 3524
 	global $smcFunc, $cache_enable, $cacheAPI;
3348 3525
 	global $cache_hits, $cache_count, $db_show_debug;
3349 3526
 
3350
-	if (empty($cache_enable) || empty($cacheAPI))
3351
-		return;
3527
+	if (empty($cache_enable) || empty($cacheAPI)) {
3528
+			return;
3529
+	}
3352 3530
 
3353 3531
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3354 3532
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3361,12 +3539,14 @@  discard block
 block discarded – undo
3361 3539
 	$value = $value === null ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_encode']($value) : json_encode($value));
3362 3540
 	$cacheAPI->putData($key, $value, $ttl);
3363 3541
 
3364
-	if (function_exists('call_integration_hook'))
3365
-		call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3542
+	if (function_exists('call_integration_hook')) {
3543
+			call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3544
+	}
3366 3545
 
3367
-	if (isset($db_show_debug) && $db_show_debug === true)
3368
-		$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3369
-}
3546
+	if (isset($db_show_debug) && $db_show_debug === true) {
3547
+			$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3548
+	}
3549
+	}
3370 3550
 
3371 3551
 /**
3372 3552
  * Gets the value from the cache specified by key, so long as it is not older than ttl seconds.
@@ -3382,8 +3562,9 @@  discard block
 block discarded – undo
3382 3562
 	global $smcFunc, $cache_enable, $cacheAPI;
3383 3563
 	global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug;
3384 3564
 
3385
-	if (empty($cache_enable) || empty($cacheAPI))
3386
-		return;
3565
+	if (empty($cache_enable) || empty($cacheAPI)) {
3566
+			return;
3567
+	}
3387 3568
 
3388 3569
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3389 3570
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3403,16 +3584,18 @@  discard block
 block discarded – undo
3403 3584
 
3404 3585
 		if (empty($value))
3405 3586
 		{
3406
-			if (!is_array($cache_misses))
3407
-				$cache_misses = array();
3587
+			if (!is_array($cache_misses)) {
3588
+							$cache_misses = array();
3589
+			}
3408 3590
 
3409 3591
 			$cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1;
3410 3592
 			$cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get');
3411 3593
 		}
3412 3594
 	}
3413 3595
 
3414
-	if (function_exists('call_integration_hook') && isset($value))
3415
-		call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3596
+	if (function_exists('call_integration_hook') && isset($value)) {
3597
+			call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3598
+	}
3416 3599
 
3417 3600
 	return empty($value) ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_decode']($value, true) : smf_json_decode($value, true));
3418 3601
 }
@@ -3434,8 +3617,9 @@  discard block
 block discarded – undo
3434 3617
 	global $cacheAPI;
3435 3618
 
3436 3619
 	// If we can't get to the API, can't do this.
3437
-	if (empty($cacheAPI))
3438
-		return;
3620
+	if (empty($cacheAPI)) {
3621
+			return;
3622
+	}
3439 3623
 
3440 3624
 	// Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure.
3441 3625
 	$cacheAPI->cleanCache($type);
@@ -3460,8 +3644,9 @@  discard block
 block discarded – undo
3460 3644
 	global $modSettings, $boardurl, $smcFunc, $image_proxy_enabled, $image_proxy_secret;
3461 3645
 
3462 3646
 	// Come on!
3463
-	if (empty($data))
3464
-		return array();
3647
+	if (empty($data)) {
3648
+			return array();
3649
+	}
3465 3650
 
3466 3651
 	// Set a nice default var.
3467 3652
 	$image = '';
@@ -3469,11 +3654,11 @@  discard block
 block discarded – undo
3469 3654
 	// Gravatar has been set as mandatory!
3470 3655
 	if (!empty($modSettings['gravatarOverride']))
3471 3656
 	{
3472
-		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://'))
3473
-			$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3474
-
3475
-		else if (!empty($data['email']))
3476
-			$image = get_gravatar_url($data['email']);
3657
+		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) {
3658
+					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3659
+		} else if (!empty($data['email'])) {
3660
+					$image = get_gravatar_url($data['email']);
3661
+		}
3477 3662
 	}
3478 3663
 
3479 3664
 	// Look if the user has a gravatar field or has set an external url as avatar.
@@ -3485,54 +3670,60 @@  discard block
 block discarded – undo
3485 3670
 			// Gravatar.
3486 3671
 			if (stristr($data['avatar'], 'gravatar://'))
3487 3672
 			{
3488
-				if ($data['avatar'] == 'gravatar://')
3489
-					$image = get_gravatar_url($data['email']);
3490
-
3491
-				elseif (!empty($modSettings['gravatarAllowExtraEmail']))
3492
-					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3673
+				if ($data['avatar'] == 'gravatar://') {
3674
+									$image = get_gravatar_url($data['email']);
3675
+				} elseif (!empty($modSettings['gravatarAllowExtraEmail'])) {
3676
+									$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3677
+				}
3493 3678
 			}
3494 3679
 
3495 3680
 			// External url.
3496 3681
 			else
3497 3682
 			{
3498 3683
 				// Using ssl?
3499
-				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false)
3500
-					$image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret);
3684
+				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) {
3685
+									$image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret);
3686
+				}
3501 3687
 
3502 3688
 				// Just a plain external url.
3503
-				else
3504
-					$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3689
+				else {
3690
+									$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3691
+				}
3505 3692
 			}
3506 3693
 		}
3507 3694
 
3508 3695
 		// Perhaps this user has an attachment as avatar...
3509
-		else if (!empty($data['filename']))
3510
-			$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3696
+		else if (!empty($data['filename'])) {
3697
+					$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3698
+		}
3511 3699
 
3512 3700
 		// Right... no avatar... use our default image.
3513
-		else
3514
-			$image = $modSettings['avatar_url'] . '/default.png';
3701
+		else {
3702
+					$image = $modSettings['avatar_url'] . '/default.png';
3703
+		}
3515 3704
 	}
3516 3705
 
3517 3706
 	call_integration_hook('integrate_set_avatar_data', array(&$image, &$data));
3518 3707
 
3519 3708
 	// At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed.
3520
-	if (!empty($image))
3521
-		return array(
3709
+	if (!empty($image)) {
3710
+			return array(
3522 3711
 			'name' => !empty($data['avatar']) ? $data['avatar'] : '',
3523 3712
 			'image' => '<img class="avatar" src="' . $image . '" />',
3524 3713
 			'href' => $image,
3525 3714
 			'url' => $image,
3526 3715
 		);
3716
+	}
3527 3717
 
3528 3718
 	// Fallback to make life easier for everyone...
3529
-	else
3530
-		return array(
3719
+	else {
3720
+			return array(
3531 3721
 			'name' => '',
3532 3722
 			'image' => '',
3533 3723
 			'href' => '',
3534 3724
 			'url' => '',
3535 3725
 		);
3536
-}
3726
+	}
3727
+	}
3537 3728
 
3538 3729
 ?>
3539 3730
\ No newline at end of file
Please login to merge, or discard this patch.