@@ -12,8 +12,9 @@ discard block |
||
12 | 12 | */ |
13 | 13 | |
14 | 14 | // Don't do anything if SMF is already loaded. |
15 | -if (defined('SMF')) |
|
15 | +if (defined('SMF')) { |
|
16 | 16 | return true; |
17 | +} |
|
17 | 18 | |
18 | 19 | define('SMF', 'SSI'); |
19 | 20 | |
@@ -28,16 +29,18 @@ discard block |
||
28 | 29 | $time_start = microtime(true); |
29 | 30 | |
30 | 31 | // Just being safe... |
31 | -foreach (array('db_character_set', 'cachedir') as $variable) |
|
32 | +foreach (array('db_character_set', 'cachedir') as $variable) { |
|
32 | 33 | if (isset($GLOBALS[$variable])) |
33 | 34 | unset($GLOBALS[$variable]); |
35 | +} |
|
34 | 36 | |
35 | 37 | // Get the forum's settings for database and file paths. |
36 | 38 | require_once(dirname(__FILE__) . '/Settings.php'); |
37 | 39 | |
38 | 40 | // Make absolutely sure the cache directory is defined. |
39 | -if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) |
|
41 | +if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) { |
|
40 | 42 | $cachedir = $boarddir . '/cache'; |
43 | +} |
|
41 | 44 | |
42 | 45 | $ssi_error_reporting = error_reporting(defined('E_STRICT') ? E_ALL | E_STRICT : E_ALL); |
43 | 46 | /* Set this to one of three values depending on what you want to happen in the case of a fatal error. |
@@ -48,12 +51,14 @@ discard block |
||
48 | 51 | $ssi_on_error_method = false; |
49 | 52 | |
50 | 53 | // Don't do john didley if the forum's been shut down completely. |
51 | -if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true)) |
|
54 | +if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true)) { |
|
52 | 55 | die($mmessage); |
56 | +} |
|
53 | 57 | |
54 | 58 | // Fix for using the current directory as a path. |
55 | -if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.') |
|
59 | +if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.') { |
|
56 | 60 | $sourcedir = dirname(__FILE__) . substr($sourcedir, 1); |
61 | +} |
|
57 | 62 | |
58 | 63 | // Load the important includes. |
59 | 64 | require_once($sourcedir . '/QueryString.php'); |
@@ -78,34 +83,38 @@ discard block |
||
78 | 83 | cleanRequest(); |
79 | 84 | |
80 | 85 | // Seed the random generator? |
81 | -if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) |
|
86 | +if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) { |
|
82 | 87 | smf_seed_generator(); |
88 | +} |
|
83 | 89 | |
84 | 90 | // Check on any hacking attempts. |
85 | -if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) |
|
91 | +if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) { |
|
86 | 92 | die('No direct access...'); |
87 | -elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme) |
|
93 | +} elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme) { |
|
88 | 94 | die('No direct access...'); |
89 | -elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme) |
|
95 | +} elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme) { |
|
90 | 96 | die('No direct access...'); |
91 | -elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers) |
|
97 | +} elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers) { |
|
92 | 98 | die('No direct access...'); |
93 | -if (isset($_REQUEST['context'])) |
|
99 | +} |
|
100 | +if (isset($_REQUEST['context'])) { |
|
94 | 101 | die('No direct access...'); |
102 | +} |
|
95 | 103 | |
96 | 104 | // Gzip output? (because it must be boolean and true, this can't be hacked.) |
97 | -if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>=')) |
|
105 | +if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>=')) { |
|
98 | 106 | ob_start('ob_gzhandler'); |
99 | -else |
|
107 | +} else { |
|
100 | 108 | $modSettings['enableCompressedOutput'] = '0'; |
109 | +} |
|
101 | 110 | |
102 | 111 | // Primarily, this is to fix the URLs... |
103 | 112 | ob_start('ob_sessrewrite'); |
104 | 113 | |
105 | 114 | // Start the session... known to scramble SSI includes in cases... |
106 | -if (!headers_sent()) |
|
115 | +if (!headers_sent()) { |
|
107 | 116 | loadSession(); |
108 | -else |
|
117 | +} else |
|
109 | 118 | { |
110 | 119 | if (isset($_COOKIE[session_name()]) || isset($_REQUEST[session_name()])) |
111 | 120 | { |
@@ -139,12 +148,14 @@ discard block |
||
139 | 148 | loadTheme(isset($ssi_theme) ? (int) $ssi_theme : 0); |
140 | 149 | |
141 | 150 | // @todo: probably not the best place, but somewhere it should be set... |
142 | -if (!headers_sent()) |
|
151 | +if (!headers_sent()) { |
|
143 | 152 | header('Content-Type: text/html; charset=' . (empty($modSettings['global_character_set']) ? (empty($txt['lang_character_set']) ? 'ISO-8859-1' : $txt['lang_character_set']) : $modSettings['global_character_set'])); |
153 | +} |
|
144 | 154 | |
145 | 155 | // Take care of any banning that needs to be done. |
146 | -if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true)) |
|
156 | +if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true)) { |
|
147 | 157 | is_not_banned(); |
158 | +} |
|
148 | 159 | |
149 | 160 | // Do we allow guests in here? |
150 | 161 | if (empty($ssi_guest_access) && empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && basename($_SERVER['PHP_SELF']) != 'SSI.php') |
@@ -159,17 +170,19 @@ discard block |
||
159 | 170 | { |
160 | 171 | $context['template_layers'] = $ssi_layers; |
161 | 172 | template_header(); |
162 | -} |
|
163 | -else |
|
173 | +} else { |
|
164 | 174 | setupThemeContext(); |
175 | +} |
|
165 | 176 | |
166 | 177 | // Make sure they didn't muss around with the settings... but only if it's not cli. |
167 | -if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '') |
|
178 | +if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '') { |
|
168 | 179 | trigger_error($txt['ssi_session_broken'], E_USER_NOTICE); |
180 | +} |
|
169 | 181 | |
170 | 182 | // Without visiting the forum this session variable might not be set on submit. |
171 | -if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote')) |
|
183 | +if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote')) { |
|
172 | 184 | $_SESSION['USER_AGENT'] = $_SERVER['HTTP_USER_AGENT']; |
185 | +} |
|
173 | 186 | |
174 | 187 | // Have the ability to easily add functions to SSI. |
175 | 188 | call_integration_hook('integrate_SSI'); |
@@ -178,11 +191,13 @@ discard block |
||
178 | 191 | if (basename($_SERVER['PHP_SELF']) == 'SSI.php') |
179 | 192 | { |
180 | 193 | // You shouldn't just access SSI.php directly by URL!! |
181 | - if (!isset($_GET['ssi_function'])) |
|
182 | - die(sprintf($txt['ssi_not_direct'], $user_info['is_admin'] ? '\'' . addslashes(__FILE__) . '\'' : '\'SSI.php\'')); |
|
194 | + if (!isset($_GET['ssi_function'])) { |
|
195 | + die(sprintf($txt['ssi_not_direct'], $user_info['is_admin'] ? '\'' . addslashes(__FILE__) . '\'' : '\'SSI.php\'')); |
|
196 | + } |
|
183 | 197 | // Call a function passed by GET. |
184 | - if (function_exists('ssi_' . $_GET['ssi_function']) && (!empty($modSettings['allow_guestAccess']) || !$user_info['is_guest'])) |
|
185 | - call_user_func('ssi_' . $_GET['ssi_function']); |
|
198 | + if (function_exists('ssi_' . $_GET['ssi_function']) && (!empty($modSettings['allow_guestAccess']) || !$user_info['is_guest'])) { |
|
199 | + call_user_func('ssi_' . $_GET['ssi_function']); |
|
200 | + } |
|
186 | 201 | exit; |
187 | 202 | } |
188 | 203 | |
@@ -199,9 +214,10 @@ discard block |
||
199 | 214 | */ |
200 | 215 | function ssi_shutdown() |
201 | 216 | { |
202 | - if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown') |
|
203 | - template_footer(); |
|
204 | -} |
|
217 | + if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown') { |
|
218 | + template_footer(); |
|
219 | + } |
|
220 | + } |
|
205 | 221 | |
206 | 222 | /** |
207 | 223 | * Display a welcome message, like: Hey, User, you have 0 messages, 0 are new. |
@@ -214,15 +230,17 @@ discard block |
||
214 | 230 | |
215 | 231 | if ($output_method == 'echo') |
216 | 232 | { |
217 | - if ($context['user']['is_guest']) |
|
218 | - echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'); |
|
219 | - else |
|
220 | - echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : ''; |
|
233 | + if ($context['user']['is_guest']) { |
|
234 | + echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'); |
|
235 | + } else { |
|
236 | + echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : ''; |
|
237 | + } |
|
221 | 238 | } |
222 | 239 | // Don't echo... then do what?! |
223 | - else |
|
224 | - return $context['user']; |
|
225 | -} |
|
240 | + else { |
|
241 | + return $context['user']; |
|
242 | + } |
|
243 | + } |
|
226 | 244 | |
227 | 245 | /** |
228 | 246 | * Display a menu bar, like is displayed at the top of the forum. |
@@ -233,12 +251,14 @@ discard block |
||
233 | 251 | { |
234 | 252 | global $context; |
235 | 253 | |
236 | - if ($output_method == 'echo') |
|
237 | - template_menu(); |
|
254 | + if ($output_method == 'echo') { |
|
255 | + template_menu(); |
|
256 | + } |
|
238 | 257 | // What else could this do? |
239 | - else |
|
240 | - return $context['menu_buttons']; |
|
241 | -} |
|
258 | + else { |
|
259 | + return $context['menu_buttons']; |
|
260 | + } |
|
261 | + } |
|
242 | 262 | |
243 | 263 | /** |
244 | 264 | * Show a logout link. |
@@ -250,20 +270,23 @@ discard block |
||
250 | 270 | { |
251 | 271 | global $context, $txt, $scripturl; |
252 | 272 | |
253 | - if ($redirect_to != '') |
|
254 | - $_SESSION['logout_url'] = $redirect_to; |
|
273 | + if ($redirect_to != '') { |
|
274 | + $_SESSION['logout_url'] = $redirect_to; |
|
275 | + } |
|
255 | 276 | |
256 | 277 | // Guests can't log out. |
257 | - if ($context['user']['is_guest']) |
|
258 | - return false; |
|
278 | + if ($context['user']['is_guest']) { |
|
279 | + return false; |
|
280 | + } |
|
259 | 281 | |
260 | 282 | $link = '<a href="' . $scripturl . '?action=logout;' . $context['session_var'] . '=' . $context['session_id'] . '">' . $txt['logout'] . '</a>'; |
261 | 283 | |
262 | - if ($output_method == 'echo') |
|
263 | - echo $link; |
|
264 | - else |
|
265 | - return $link; |
|
266 | -} |
|
284 | + if ($output_method == 'echo') { |
|
285 | + echo $link; |
|
286 | + } else { |
|
287 | + return $link; |
|
288 | + } |
|
289 | + } |
|
267 | 290 | |
268 | 291 | /** |
269 | 292 | * Recent post list: [board] Subject by Poster Date |
@@ -279,17 +302,17 @@ discard block |
||
279 | 302 | global $modSettings, $context; |
280 | 303 | |
281 | 304 | // Excluding certain boards... |
282 | - if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) |
|
283 | - $exclude_boards = array($modSettings['recycle_board']); |
|
284 | - else |
|
285 | - $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
305 | + if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) { |
|
306 | + $exclude_boards = array($modSettings['recycle_board']); |
|
307 | + } else { |
|
308 | + $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
309 | + } |
|
286 | 310 | |
287 | 311 | // What about including certain boards - note we do some protection here as pre-2.0 didn't have this parameter. |
288 | 312 | if (is_array($include_boards) || (int) $include_boards === $include_boards) |
289 | 313 | { |
290 | 314 | $include_boards = is_array($include_boards) ? $include_boards : array($include_boards); |
291 | - } |
|
292 | - elseif ($include_boards != null) |
|
315 | + } elseif ($include_boards != null) |
|
293 | 316 | { |
294 | 317 | $include_boards = array(); |
295 | 318 | } |
@@ -326,8 +349,9 @@ discard block |
||
326 | 349 | { |
327 | 350 | global $modSettings; |
328 | 351 | |
329 | - if (empty($post_ids)) |
|
330 | - return; |
|
352 | + if (empty($post_ids)) { |
|
353 | + return; |
|
354 | + } |
|
331 | 355 | |
332 | 356 | // Allow the user to request more than one - why not? |
333 | 357 | $post_ids = is_array($post_ids) ? $post_ids : array($post_ids); |
@@ -362,8 +386,9 @@ discard block |
||
362 | 386 | global $scripturl, $txt, $user_info; |
363 | 387 | global $modSettings, $smcFunc, $context; |
364 | 388 | |
365 | - if (!empty($modSettings['enable_likes'])) |
|
366 | - $context['can_like'] = allowedTo('likes_like'); |
|
389 | + if (!empty($modSettings['enable_likes'])) { |
|
390 | + $context['can_like'] = allowedTo('likes_like'); |
|
391 | + } |
|
367 | 392 | |
368 | 393 | // Find all the posts. Newer ones will have higher IDs. |
369 | 394 | $request = $smcFunc['db_query']('substring', ' |
@@ -429,12 +454,13 @@ discard block |
||
429 | 454 | ); |
430 | 455 | |
431 | 456 | // Get the likes for each message. |
432 | - if (!empty($modSettings['enable_likes'])) |
|
433 | - $posts[$row['id_msg']]['likes'] = array( |
|
457 | + if (!empty($modSettings['enable_likes'])) { |
|
458 | + $posts[$row['id_msg']]['likes'] = array( |
|
434 | 459 | 'count' => $row['likes'], |
435 | 460 | 'you' => in_array($row['id_msg'], prepareLikesContext($row['id_topic'])), |
436 | 461 | 'can_like' => !$context['user']['is_guest'] && $row['id_member'] != $context['user']['id'] && !empty($context['can_like']), |
437 | 462 | ); |
463 | + } |
|
438 | 464 | } |
439 | 465 | $smcFunc['db_free_result']($request); |
440 | 466 | |
@@ -442,13 +468,14 @@ discard block |
||
442 | 468 | call_integration_hook('integrate_ssi_queryPosts', array(&$posts)); |
443 | 469 | |
444 | 470 | // Just return it. |
445 | - if ($output_method != 'echo' || empty($posts)) |
|
446 | - return $posts; |
|
471 | + if ($output_method != 'echo' || empty($posts)) { |
|
472 | + return $posts; |
|
473 | + } |
|
447 | 474 | |
448 | 475 | echo ' |
449 | 476 | <table style="border: none" class="ssi_table">'; |
450 | - foreach ($posts as $post) |
|
451 | - echo ' |
|
477 | + foreach ($posts as $post) { |
|
478 | + echo ' |
|
452 | 479 | <tr> |
453 | 480 | <td style="text-align: right; vertical-align: top; white-space: nowrap"> |
454 | 481 | [', $post['board']['link'], '] |
@@ -462,6 +489,7 @@ discard block |
||
462 | 489 | ', $post['time'], ' |
463 | 490 | </td> |
464 | 491 | </tr>'; |
492 | + } |
|
465 | 493 | echo ' |
466 | 494 | </table>'; |
467 | 495 | } |
@@ -479,25 +507,26 @@ discard block |
||
479 | 507 | global $settings, $scripturl, $txt, $user_info; |
480 | 508 | global $modSettings, $smcFunc, $context; |
481 | 509 | |
482 | - if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) |
|
483 | - $exclude_boards = array($modSettings['recycle_board']); |
|
484 | - else |
|
485 | - $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
510 | + if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) { |
|
511 | + $exclude_boards = array($modSettings['recycle_board']); |
|
512 | + } else { |
|
513 | + $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
514 | + } |
|
486 | 515 | |
487 | 516 | // Only some boards?. |
488 | 517 | if (is_array($include_boards) || (int) $include_boards === $include_boards) |
489 | 518 | { |
490 | 519 | $include_boards = is_array($include_boards) ? $include_boards : array($include_boards); |
491 | - } |
|
492 | - elseif ($include_boards != null) |
|
520 | + } elseif ($include_boards != null) |
|
493 | 521 | { |
494 | 522 | $output_method = $include_boards; |
495 | 523 | $include_boards = array(); |
496 | 524 | } |
497 | 525 | |
498 | 526 | $icon_sources = array(); |
499 | - foreach ($context['stable_icons'] as $icon) |
|
500 | - $icon_sources[$icon] = 'images_url'; |
|
527 | + foreach ($context['stable_icons'] as $icon) { |
|
528 | + $icon_sources[$icon] = 'images_url'; |
|
529 | + } |
|
501 | 530 | |
502 | 531 | // Find all the posts in distinct topics. Newer ones will have higher IDs. |
503 | 532 | $request = $smcFunc['db_query']('substring', ' |
@@ -522,13 +551,15 @@ discard block |
||
522 | 551 | ) |
523 | 552 | ); |
524 | 553 | $topics = array(); |
525 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
526 | - $topics[$row['id_topic']] = $row; |
|
554 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
555 | + $topics[$row['id_topic']] = $row; |
|
556 | + } |
|
527 | 557 | $smcFunc['db_free_result']($request); |
528 | 558 | |
529 | 559 | // Did we find anything? If not, bail. |
530 | - if (empty($topics)) |
|
531 | - return array(); |
|
560 | + if (empty($topics)) { |
|
561 | + return array(); |
|
562 | + } |
|
532 | 563 | |
533 | 564 | $recycle_board = !empty($modSettings['recycle_enable']) && !empty($modSettings['recycle_board']) ? (int) $modSettings['recycle_board'] : 0; |
534 | 565 | |
@@ -556,19 +587,22 @@ discard block |
||
556 | 587 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
557 | 588 | { |
558 | 589 | $row['body'] = strip_tags(strtr(parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']), array('<br>' => ' '))); |
559 | - if ($smcFunc['strlen']($row['body']) > 128) |
|
560 | - $row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...'; |
|
590 | + if ($smcFunc['strlen']($row['body']) > 128) { |
|
591 | + $row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...'; |
|
592 | + } |
|
561 | 593 | |
562 | 594 | // Censor the subject. |
563 | 595 | censorText($row['subject']); |
564 | 596 | censorText($row['body']); |
565 | 597 | |
566 | 598 | // Recycled icon |
567 | - if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board']) |
|
568 | - $row['icon'] = 'recycled'; |
|
599 | + if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board']) { |
|
600 | + $row['icon'] = 'recycled'; |
|
601 | + } |
|
569 | 602 | |
570 | - if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) |
|
571 | - $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
603 | + if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) { |
|
604 | + $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
605 | + } |
|
572 | 606 | |
573 | 607 | // Build the array. |
574 | 608 | $posts[] = array( |
@@ -607,13 +641,14 @@ discard block |
||
607 | 641 | call_integration_hook('integrate_ssi_recentTopics', array(&$posts)); |
608 | 642 | |
609 | 643 | // Just return it. |
610 | - if ($output_method != 'echo' || empty($posts)) |
|
611 | - return $posts; |
|
644 | + if ($output_method != 'echo' || empty($posts)) { |
|
645 | + return $posts; |
|
646 | + } |
|
612 | 647 | |
613 | 648 | echo ' |
614 | 649 | <table style="border: none" class="ssi_table">'; |
615 | - foreach ($posts as $post) |
|
616 | - echo ' |
|
650 | + foreach ($posts as $post) { |
|
651 | + echo ' |
|
617 | 652 | <tr> |
618 | 653 | <td style="text-align: right; vertical-align: top; white-space: nowrap"> |
619 | 654 | [', $post['board']['link'], '] |
@@ -627,6 +662,7 @@ discard block |
||
627 | 662 | ', $post['time'], ' |
628 | 663 | </td> |
629 | 664 | </tr>'; |
665 | + } |
|
630 | 666 | echo ' |
631 | 667 | </table>'; |
632 | 668 | } |
@@ -651,27 +687,30 @@ discard block |
||
651 | 687 | ) |
652 | 688 | ); |
653 | 689 | $return = array(); |
654 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
655 | - $return[] = array( |
|
690 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
691 | + $return[] = array( |
|
656 | 692 | 'id' => $row['id_member'], |
657 | 693 | 'name' => $row['real_name'], |
658 | 694 | 'href' => $scripturl . '?action=profile;u=' . $row['id_member'], |
659 | 695 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>', |
660 | 696 | 'posts' => $row['posts'] |
661 | 697 | ); |
698 | + } |
|
662 | 699 | $smcFunc['db_free_result']($request); |
663 | 700 | |
664 | 701 | // If mods want to do somthing with this list of members, let them do that now. |
665 | 702 | call_integration_hook('integrate_ssi_topPoster', array(&$return)); |
666 | 703 | |
667 | 704 | // Just return all the top posters. |
668 | - if ($output_method != 'echo') |
|
669 | - return $return; |
|
705 | + if ($output_method != 'echo') { |
|
706 | + return $return; |
|
707 | + } |
|
670 | 708 | |
671 | 709 | // Make a quick array to list the links in. |
672 | 710 | $temp_array = array(); |
673 | - foreach ($return as $member) |
|
674 | - $temp_array[] = $member['link']; |
|
711 | + foreach ($return as $member) { |
|
712 | + $temp_array[] = $member['link']; |
|
713 | + } |
|
675 | 714 | |
676 | 715 | echo implode(', ', $temp_array); |
677 | 716 | } |
@@ -703,8 +742,8 @@ discard block |
||
703 | 742 | ) |
704 | 743 | ); |
705 | 744 | $boards = array(); |
706 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
707 | - $boards[] = array( |
|
745 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
746 | + $boards[] = array( |
|
708 | 747 | 'id' => $row['id_board'], |
709 | 748 | 'num_posts' => $row['num_posts'], |
710 | 749 | 'num_topics' => $row['num_topics'], |
@@ -713,14 +752,16 @@ discard block |
||
713 | 752 | 'href' => $scripturl . '?board=' . $row['id_board'] . '.0', |
714 | 753 | 'link' => '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>' |
715 | 754 | ); |
755 | + } |
|
716 | 756 | $smcFunc['db_free_result']($request); |
717 | 757 | |
718 | 758 | // If mods want to do somthing with this list of boards, let them do that now. |
719 | 759 | call_integration_hook('integrate_ssi_topBoards', array(&$boards)); |
720 | 760 | |
721 | 761 | // If we shouldn't output or have nothing to output, just jump out. |
722 | - if ($output_method != 'echo' || empty($boards)) |
|
723 | - return $boards; |
|
762 | + if ($output_method != 'echo' || empty($boards)) { |
|
763 | + return $boards; |
|
764 | + } |
|
724 | 765 | |
725 | 766 | echo ' |
726 | 767 | <table class="ssi_table"> |
@@ -729,13 +770,14 @@ discard block |
||
729 | 770 | <th style="text-align: left">', $txt['board_topics'], '</th> |
730 | 771 | <th style="text-align: left">', $txt['posts'], '</th> |
731 | 772 | </tr>'; |
732 | - foreach ($boards as $sBoard) |
|
733 | - echo ' |
|
773 | + foreach ($boards as $sBoard) { |
|
774 | + echo ' |
|
734 | 775 | <tr> |
735 | 776 | <td>', $sBoard['link'], $sBoard['new'] ? ' <a href="' . $sBoard['href'] . '"><span class="new_posts">' . $txt['new'] . '</span></a>' : '', '</td> |
736 | 777 | <td style="text-align: right">', comma_format($sBoard['num_topics']), '</td> |
737 | 778 | <td style="text-align: right">', comma_format($sBoard['num_posts']), '</td> |
738 | 779 | </tr>'; |
780 | + } |
|
739 | 781 | echo ' |
740 | 782 | </table>'; |
741 | 783 | } |
@@ -768,12 +810,13 @@ discard block |
||
768 | 810 | ) |
769 | 811 | ); |
770 | 812 | $topic_ids = array(); |
771 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
772 | - $topic_ids[] = $row['id_topic']; |
|
813 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
814 | + $topic_ids[] = $row['id_topic']; |
|
815 | + } |
|
773 | 816 | $smcFunc['db_free_result']($request); |
817 | + } else { |
|
818 | + $topic_ids = array(); |
|
774 | 819 | } |
775 | - else |
|
776 | - $topic_ids = array(); |
|
777 | 820 | |
778 | 821 | $request = $smcFunc['db_query']('', ' |
779 | 822 | SELECT m.subject, m.id_topic, t.num_views, t.num_replies |
@@ -812,8 +855,9 @@ discard block |
||
812 | 855 | // If mods want to do somthing with this list of topics, let them do that now. |
813 | 856 | call_integration_hook('integrate_ssi_topTopics', array(&$topics, $type)); |
814 | 857 | |
815 | - if ($output_method != 'echo' || empty($topics)) |
|
816 | - return $topics; |
|
858 | + if ($output_method != 'echo' || empty($topics)) { |
|
859 | + return $topics; |
|
860 | + } |
|
817 | 861 | |
818 | 862 | echo ' |
819 | 863 | <table class="ssi_table"> |
@@ -822,8 +866,8 @@ discard block |
||
822 | 866 | <th style="text-align: left">', $txt['views'], '</th> |
823 | 867 | <th style="text-align: left">', $txt['replies'], '</th> |
824 | 868 | </tr>'; |
825 | - foreach ($topics as $sTopic) |
|
826 | - echo ' |
|
869 | + foreach ($topics as $sTopic) { |
|
870 | + echo ' |
|
827 | 871 | <tr> |
828 | 872 | <td style="text-align: left"> |
829 | 873 | ', $sTopic['link'], ' |
@@ -831,6 +875,7 @@ discard block |
||
831 | 875 | <td style="text-align: right">', comma_format($sTopic['num_views']), '</td> |
832 | 876 | <td style="text-align: right">', comma_format($sTopic['num_replies']), '</td> |
833 | 877 | </tr>'; |
878 | + } |
|
834 | 879 | echo ' |
835 | 880 | </table>'; |
836 | 881 | } |
@@ -866,12 +911,13 @@ discard block |
||
866 | 911 | { |
867 | 912 | global $txt, $context; |
868 | 913 | |
869 | - if ($output_method == 'echo') |
|
870 | - echo ' |
|
914 | + if ($output_method == 'echo') { |
|
915 | + echo ' |
|
871 | 916 | ', sprintf($txt['welcome_newest_member'], $context['common_stats']['latest_member']['link']), '<br>'; |
872 | - else |
|
873 | - return $context['common_stats']['latest_member']; |
|
874 | -} |
|
917 | + } else { |
|
918 | + return $context['common_stats']['latest_member']; |
|
919 | + } |
|
920 | + } |
|
875 | 921 | |
876 | 922 | /** |
877 | 923 | * Fetches a random member. |
@@ -920,8 +966,9 @@ discard block |
||
920 | 966 | } |
921 | 967 | |
922 | 968 | // Just to be sure put the random generator back to something... random. |
923 | - if ($random_type != '') |
|
924 | - mt_srand(time()); |
|
969 | + if ($random_type != '') { |
|
970 | + mt_srand(time()); |
|
971 | + } |
|
925 | 972 | |
926 | 973 | return $result; |
927 | 974 | } |
@@ -934,8 +981,9 @@ discard block |
||
934 | 981 | */ |
935 | 982 | function ssi_fetchMember($member_ids = array(), $output_method = 'echo') |
936 | 983 | { |
937 | - if (empty($member_ids)) |
|
938 | - return; |
|
984 | + if (empty($member_ids)) { |
|
985 | + return; |
|
986 | + } |
|
939 | 987 | |
940 | 988 | // Can have more than one member if you really want... |
941 | 989 | $member_ids = is_array($member_ids) ? $member_ids : array($member_ids); |
@@ -960,8 +1008,9 @@ discard block |
||
960 | 1008 | */ |
961 | 1009 | function ssi_fetchGroupMembers($group_id = null, $output_method = 'echo') |
962 | 1010 | { |
963 | - if ($group_id === null) |
|
964 | - return; |
|
1011 | + if ($group_id === null) { |
|
1012 | + return; |
|
1013 | + } |
|
965 | 1014 | |
966 | 1015 | $query_where = ' |
967 | 1016 | id_group = {int:id_group} |
@@ -988,8 +1037,9 @@ discard block |
||
988 | 1037 | { |
989 | 1038 | global $smcFunc, $memberContext; |
990 | 1039 | |
991 | - if ($query_where === null) |
|
992 | - return; |
|
1040 | + if ($query_where === null) { |
|
1041 | + return; |
|
1042 | + } |
|
993 | 1043 | |
994 | 1044 | // Fetch the members in question. |
995 | 1045 | $request = $smcFunc['db_query']('', ' |
@@ -1002,12 +1052,14 @@ discard block |
||
1002 | 1052 | )) |
1003 | 1053 | ); |
1004 | 1054 | $members = array(); |
1005 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1006 | - $members[] = $row['id_member']; |
|
1055 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1056 | + $members[] = $row['id_member']; |
|
1057 | + } |
|
1007 | 1058 | $smcFunc['db_free_result']($request); |
1008 | 1059 | |
1009 | - if (empty($members)) |
|
1010 | - return array(); |
|
1060 | + if (empty($members)) { |
|
1061 | + return array(); |
|
1062 | + } |
|
1011 | 1063 | |
1012 | 1064 | // If mods want to do somthing with this list of members, let them do that now. |
1013 | 1065 | call_integration_hook('integrate_ssi_queryMembers', array(&$members)); |
@@ -1016,23 +1068,25 @@ discard block |
||
1016 | 1068 | loadMemberData($members); |
1017 | 1069 | |
1018 | 1070 | // Draw the table! |
1019 | - if ($output_method == 'echo') |
|
1020 | - echo ' |
|
1071 | + if ($output_method == 'echo') { |
|
1072 | + echo ' |
|
1021 | 1073 | <table style="border: none" class="ssi_table">'; |
1074 | + } |
|
1022 | 1075 | |
1023 | 1076 | $query_members = array(); |
1024 | 1077 | foreach ($members as $member) |
1025 | 1078 | { |
1026 | 1079 | // Load their context data. |
1027 | - if (!loadMemberContext($member)) |
|
1028 | - continue; |
|
1080 | + if (!loadMemberContext($member)) { |
|
1081 | + continue; |
|
1082 | + } |
|
1029 | 1083 | |
1030 | 1084 | // Store this member's information. |
1031 | 1085 | $query_members[$member] = $memberContext[$member]; |
1032 | 1086 | |
1033 | 1087 | // Only do something if we're echo'ing. |
1034 | - if ($output_method == 'echo') |
|
1035 | - echo ' |
|
1088 | + if ($output_method == 'echo') { |
|
1089 | + echo ' |
|
1036 | 1090 | <tr> |
1037 | 1091 | <td style="text-align: right; vertical-align: top; white-space: nowrap"> |
1038 | 1092 | ', $query_members[$member]['link'], ' |
@@ -1040,12 +1094,14 @@ discard block |
||
1040 | 1094 | <br>', $query_members[$member]['avatar']['image'], ' |
1041 | 1095 | </td> |
1042 | 1096 | </tr>'; |
1097 | + } |
|
1043 | 1098 | } |
1044 | 1099 | |
1045 | 1100 | // End the table if appropriate. |
1046 | - if ($output_method == 'echo') |
|
1047 | - echo ' |
|
1101 | + if ($output_method == 'echo') { |
|
1102 | + echo ' |
|
1048 | 1103 | </table>'; |
1104 | + } |
|
1049 | 1105 | |
1050 | 1106 | // Send back the data. |
1051 | 1107 | return $query_members; |
@@ -1060,8 +1116,9 @@ discard block |
||
1060 | 1116 | { |
1061 | 1117 | global $txt, $scripturl, $modSettings, $smcFunc; |
1062 | 1118 | |
1063 | - if (!allowedTo('view_stats')) |
|
1064 | - return; |
|
1119 | + if (!allowedTo('view_stats')) { |
|
1120 | + return; |
|
1121 | + } |
|
1065 | 1122 | |
1066 | 1123 | $totals = array( |
1067 | 1124 | 'members' => $modSettings['totalMembers'], |
@@ -1090,8 +1147,9 @@ discard block |
||
1090 | 1147 | // If mods want to do somthing with the board stats, let them do that now. |
1091 | 1148 | call_integration_hook('integrate_ssi_boardStats', array(&$totals)); |
1092 | 1149 | |
1093 | - if ($output_method != 'echo') |
|
1094 | - return $totals; |
|
1150 | + if ($output_method != 'echo') { |
|
1151 | + return $totals; |
|
1152 | + } |
|
1095 | 1153 | |
1096 | 1154 | echo ' |
1097 | 1155 | ', $txt['total_members'], ': <a href="', $scripturl . '?action=mlist">', comma_format($totals['members']), '</a><br> |
@@ -1120,8 +1178,8 @@ discard block |
||
1120 | 1178 | call_integration_hook('integrate_ssi_whosOnline', array(&$return)); |
1121 | 1179 | |
1122 | 1180 | // Add some redundancy for backwards compatibility reasons. |
1123 | - if ($output_method != 'echo') |
|
1124 | - return $return + array( |
|
1181 | + if ($output_method != 'echo') { |
|
1182 | + return $return + array( |
|
1125 | 1183 | 'users' => $return['users_online'], |
1126 | 1184 | 'guests' => $return['num_guests'], |
1127 | 1185 | 'hidden' => $return['num_users_hidden'], |
@@ -1129,29 +1187,35 @@ discard block |
||
1129 | 1187 | 'num_users' => $return['num_users_online'], |
1130 | 1188 | 'total_users' => $return['num_users_online'] + $return['num_guests'], |
1131 | 1189 | ); |
1190 | + } |
|
1132 | 1191 | |
1133 | 1192 | echo ' |
1134 | 1193 | ', comma_format($return['num_guests']), ' ', $return['num_guests'] == 1 ? $txt['guest'] : $txt['guests'], ', ', comma_format($return['num_users_online']), ' ', $return['num_users_online'] == 1 ? $txt['user'] : $txt['users']; |
1135 | 1194 | |
1136 | 1195 | $bracketList = array(); |
1137 | - if (!empty($user_info['buddies'])) |
|
1138 | - $bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
1139 | - if (!empty($return['num_spiders'])) |
|
1140 | - $bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
1141 | - if (!empty($return['num_users_hidden'])) |
|
1142 | - $bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden']; |
|
1196 | + if (!empty($user_info['buddies'])) { |
|
1197 | + $bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
1198 | + } |
|
1199 | + if (!empty($return['num_spiders'])) { |
|
1200 | + $bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
1201 | + } |
|
1202 | + if (!empty($return['num_users_hidden'])) { |
|
1203 | + $bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden']; |
|
1204 | + } |
|
1143 | 1205 | |
1144 | - if (!empty($bracketList)) |
|
1145 | - echo ' (' . implode(', ', $bracketList) . ')'; |
|
1206 | + if (!empty($bracketList)) { |
|
1207 | + echo ' (' . implode(', ', $bracketList) . ')'; |
|
1208 | + } |
|
1146 | 1209 | |
1147 | 1210 | echo '<br> |
1148 | 1211 | ', implode(', ', $return['list_users_online']); |
1149 | 1212 | |
1150 | 1213 | // Showing membergroups? |
1151 | - if (!empty($settings['show_group_key']) && !empty($return['membergroups'])) |
|
1152 | - echo '<br> |
|
1214 | + if (!empty($settings['show_group_key']) && !empty($return['membergroups'])) { |
|
1215 | + echo '<br> |
|
1153 | 1216 | [' . implode('] [', $return['membergroups']) . ']'; |
1154 | -} |
|
1217 | + } |
|
1218 | + } |
|
1155 | 1219 | |
1156 | 1220 | /** |
1157 | 1221 | * Just like whosOnline except it also logs the online presence. |
@@ -1162,11 +1226,12 @@ discard block |
||
1162 | 1226 | { |
1163 | 1227 | writeLog(); |
1164 | 1228 | |
1165 | - if ($output_method != 'echo') |
|
1166 | - return ssi_whosOnline($output_method); |
|
1167 | - else |
|
1168 | - ssi_whosOnline($output_method); |
|
1169 | -} |
|
1229 | + if ($output_method != 'echo') { |
|
1230 | + return ssi_whosOnline($output_method); |
|
1231 | + } else { |
|
1232 | + ssi_whosOnline($output_method); |
|
1233 | + } |
|
1234 | + } |
|
1170 | 1235 | |
1171 | 1236 | // Shows a login box. |
1172 | 1237 | /** |
@@ -1179,11 +1244,13 @@ discard block |
||
1179 | 1244 | { |
1180 | 1245 | global $scripturl, $txt, $user_info, $context; |
1181 | 1246 | |
1182 | - if ($redirect_to != '') |
|
1183 | - $_SESSION['login_url'] = $redirect_to; |
|
1247 | + if ($redirect_to != '') { |
|
1248 | + $_SESSION['login_url'] = $redirect_to; |
|
1249 | + } |
|
1184 | 1250 | |
1185 | - if ($output_method != 'echo' || !$user_info['is_guest']) |
|
1186 | - return $user_info['is_guest']; |
|
1251 | + if ($output_method != 'echo' || !$user_info['is_guest']) { |
|
1252 | + return $user_info['is_guest']; |
|
1253 | + } |
|
1187 | 1254 | |
1188 | 1255 | // Create a login token |
1189 | 1256 | createToken('login'); |
@@ -1235,8 +1302,9 @@ discard block |
||
1235 | 1302 | |
1236 | 1303 | $boardsAllowed = array_intersect(boardsAllowedTo('poll_view'), boardsAllowedTo('poll_vote')); |
1237 | 1304 | |
1238 | - if (empty($boardsAllowed)) |
|
1239 | - return array(); |
|
1305 | + if (empty($boardsAllowed)) { |
|
1306 | + return array(); |
|
1307 | + } |
|
1240 | 1308 | |
1241 | 1309 | $request = $smcFunc['db_query']('', ' |
1242 | 1310 | SELECT p.id_poll, p.question, t.id_topic, p.max_votes, p.guest_vote, p.hide_results, p.expire_time |
@@ -1269,12 +1337,14 @@ discard block |
||
1269 | 1337 | $smcFunc['db_free_result']($request); |
1270 | 1338 | |
1271 | 1339 | // This user has voted on all the polls. |
1272 | - if (empty($row) || !is_array($row)) |
|
1273 | - return array(); |
|
1340 | + if (empty($row) || !is_array($row)) { |
|
1341 | + return array(); |
|
1342 | + } |
|
1274 | 1343 | |
1275 | 1344 | // If this is a guest who's voted we'll through ourselves to show poll to show the results. |
1276 | - if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))))) |
|
1277 | - return ssi_showPoll($row['id_topic'], $output_method); |
|
1345 | + if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))))) { |
|
1346 | + return ssi_showPoll($row['id_topic'], $output_method); |
|
1347 | + } |
|
1278 | 1348 | |
1279 | 1349 | $request = $smcFunc['db_query']('', ' |
1280 | 1350 | SELECT COUNT(DISTINCT id_member) |
@@ -1338,8 +1408,9 @@ discard block |
||
1338 | 1408 | // If mods want to do somthing with this list of polls, let them do that now. |
1339 | 1409 | call_integration_hook('integrate_ssi_recentPoll', array(&$return, $topPollInstead)); |
1340 | 1410 | |
1341 | - if ($output_method != 'echo') |
|
1342 | - return $return; |
|
1411 | + if ($output_method != 'echo') { |
|
1412 | + return $return; |
|
1413 | + } |
|
1343 | 1414 | |
1344 | 1415 | if ($allow_view_results) |
1345 | 1416 | { |
@@ -1348,19 +1419,20 @@ discard block |
||
1348 | 1419 | <strong>', $return['question'], '</strong><br> |
1349 | 1420 | ', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : ''; |
1350 | 1421 | |
1351 | - foreach ($return['options'] as $option) |
|
1352 | - echo ' |
|
1422 | + foreach ($return['options'] as $option) { |
|
1423 | + echo ' |
|
1353 | 1424 | <label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>'; |
1425 | + } |
|
1354 | 1426 | |
1355 | 1427 | echo ' |
1356 | 1428 | <input type="submit" value="', $txt['poll_vote'], '" class="button"> |
1357 | 1429 | <input type="hidden" name="poll" value="', $return['id'], '"> |
1358 | 1430 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
1359 | 1431 | </form>'; |
1432 | + } else { |
|
1433 | + echo $txt['poll_cannot_see']; |
|
1434 | + } |
|
1360 | 1435 | } |
1361 | - else |
|
1362 | - echo $txt['poll_cannot_see']; |
|
1363 | -} |
|
1364 | 1436 | |
1365 | 1437 | /** |
1366 | 1438 | * Shows the poll from the specified topic |
@@ -1374,13 +1446,15 @@ discard block |
||
1374 | 1446 | |
1375 | 1447 | $boardsAllowed = boardsAllowedTo('poll_view'); |
1376 | 1448 | |
1377 | - if (empty($boardsAllowed)) |
|
1378 | - return array(); |
|
1449 | + if (empty($boardsAllowed)) { |
|
1450 | + return array(); |
|
1451 | + } |
|
1379 | 1452 | |
1380 | - if ($topic === null && isset($_REQUEST['ssi_topic'])) |
|
1381 | - $topic = (int) $_REQUEST['ssi_topic']; |
|
1382 | - else |
|
1383 | - $topic = (int) $topic; |
|
1453 | + if ($topic === null && isset($_REQUEST['ssi_topic'])) { |
|
1454 | + $topic = (int) $_REQUEST['ssi_topic']; |
|
1455 | + } else { |
|
1456 | + $topic = (int) $topic; |
|
1457 | + } |
|
1384 | 1458 | |
1385 | 1459 | $request = $smcFunc['db_query']('', ' |
1386 | 1460 | SELECT |
@@ -1401,17 +1475,18 @@ discard block |
||
1401 | 1475 | ); |
1402 | 1476 | |
1403 | 1477 | // Either this topic has no poll, or the user cannot view it. |
1404 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1405 | - return array(); |
|
1478 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1479 | + return array(); |
|
1480 | + } |
|
1406 | 1481 | |
1407 | 1482 | $row = $smcFunc['db_fetch_assoc']($request); |
1408 | 1483 | $smcFunc['db_free_result']($request); |
1409 | 1484 | |
1410 | 1485 | // Check if they can vote. |
1411 | 1486 | $already_voted = false; |
1412 | - if (!empty($row['expire_time']) && $row['expire_time'] < time()) |
|
1413 | - $allow_vote = false; |
|
1414 | - elseif ($user_info['is_guest']) |
|
1487 | + if (!empty($row['expire_time']) && $row['expire_time'] < time()) { |
|
1488 | + $allow_vote = false; |
|
1489 | + } elseif ($user_info['is_guest']) |
|
1415 | 1490 | { |
1416 | 1491 | // There's a difference between "allowed to vote" and "already voted"... |
1417 | 1492 | $allow_vote = $row['guest_vote']; |
@@ -1421,10 +1496,9 @@ discard block |
||
1421 | 1496 | { |
1422 | 1497 | $already_voted = true; |
1423 | 1498 | } |
1424 | - } |
|
1425 | - elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board'])) |
|
1426 | - $allow_vote = false; |
|
1427 | - else |
|
1499 | + } elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board'])) { |
|
1500 | + $allow_vote = false; |
|
1501 | + } else |
|
1428 | 1502 | { |
1429 | 1503 | $request = $smcFunc['db_query']('', ' |
1430 | 1504 | SELECT id_member |
@@ -1506,8 +1580,9 @@ discard block |
||
1506 | 1580 | // If mods want to do somthing with this poll, let them do that now. |
1507 | 1581 | call_integration_hook('integrate_ssi_showPoll', array(&$return)); |
1508 | 1582 | |
1509 | - if ($output_method != 'echo') |
|
1510 | - return $return; |
|
1583 | + if ($output_method != 'echo') { |
|
1584 | + return $return; |
|
1585 | + } |
|
1511 | 1586 | |
1512 | 1587 | if ($return['allow_vote']) |
1513 | 1588 | { |
@@ -1516,17 +1591,17 @@ discard block |
||
1516 | 1591 | <strong>', $return['question'], '</strong><br> |
1517 | 1592 | ', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : ''; |
1518 | 1593 | |
1519 | - foreach ($return['options'] as $option) |
|
1520 | - echo ' |
|
1594 | + foreach ($return['options'] as $option) { |
|
1595 | + echo ' |
|
1521 | 1596 | <label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>'; |
1597 | + } |
|
1522 | 1598 | |
1523 | 1599 | echo ' |
1524 | 1600 | <input type="submit" value="', $txt['poll_vote'], '" class="button"> |
1525 | 1601 | <input type="hidden" name="poll" value="', $return['id'], '"> |
1526 | 1602 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
1527 | 1603 | </form>'; |
1528 | - } |
|
1529 | - else |
|
1604 | + } else |
|
1530 | 1605 | { |
1531 | 1606 | echo ' |
1532 | 1607 | <div class="ssi_poll"> |
@@ -1606,27 +1681,32 @@ discard block |
||
1606 | 1681 | 'is_approved' => 1, |
1607 | 1682 | ) |
1608 | 1683 | ); |
1609 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1610 | - die; |
|
1684 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1685 | + die; |
|
1686 | + } |
|
1611 | 1687 | $row = $smcFunc['db_fetch_assoc']($request); |
1612 | 1688 | $smcFunc['db_free_result']($request); |
1613 | 1689 | |
1614 | - if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time'])) |
|
1615 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1690 | + if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time'])) { |
|
1691 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1692 | + } |
|
1616 | 1693 | |
1617 | 1694 | // Too many options checked? |
1618 | - if (count($_REQUEST['options']) > $row['max_votes']) |
|
1619 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1695 | + if (count($_REQUEST['options']) > $row['max_votes']) { |
|
1696 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1697 | + } |
|
1620 | 1698 | |
1621 | 1699 | // It's a guest who has already voted? |
1622 | 1700 | if ($user_info['is_guest']) |
1623 | 1701 | { |
1624 | 1702 | // Guest voting disabled? |
1625 | - if (!$row['guest_vote']) |
|
1626 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1703 | + if (!$row['guest_vote']) { |
|
1704 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1705 | + } |
|
1627 | 1706 | // Already voted? |
1628 | - elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))) |
|
1629 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1707 | + elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))) { |
|
1708 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1709 | + } |
|
1630 | 1710 | } |
1631 | 1711 | |
1632 | 1712 | $sOptions = array(); |
@@ -1680,11 +1760,13 @@ discard block |
||
1680 | 1760 | { |
1681 | 1761 | global $scripturl, $txt, $context; |
1682 | 1762 | |
1683 | - if (!allowedTo('search_posts')) |
|
1684 | - return; |
|
1763 | + if (!allowedTo('search_posts')) { |
|
1764 | + return; |
|
1765 | + } |
|
1685 | 1766 | |
1686 | - if ($output_method != 'echo') |
|
1687 | - return $scripturl . '?action=search'; |
|
1767 | + if ($output_method != 'echo') { |
|
1768 | + return $scripturl . '?action=search'; |
|
1769 | + } |
|
1688 | 1770 | |
1689 | 1771 | echo ' |
1690 | 1772 | <form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '"> |
@@ -1706,8 +1788,9 @@ discard block |
||
1706 | 1788 | // If mods want to do somthing with the news, let them do that now. Don't need to pass the news line itself, since it is already in $context. |
1707 | 1789 | call_integration_hook('integrate_ssi_news'); |
1708 | 1790 | |
1709 | - if ($output_method != 'echo') |
|
1710 | - return $context['random_news_line']; |
|
1791 | + if ($output_method != 'echo') { |
|
1792 | + return $context['random_news_line']; |
|
1793 | + } |
|
1711 | 1794 | |
1712 | 1795 | echo $context['random_news_line']; |
1713 | 1796 | } |
@@ -1721,8 +1804,9 @@ discard block |
||
1721 | 1804 | { |
1722 | 1805 | global $scripturl, $modSettings, $user_info; |
1723 | 1806 | |
1724 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view')) |
|
1725 | - return; |
|
1807 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view')) { |
|
1808 | + return; |
|
1809 | + } |
|
1726 | 1810 | |
1727 | 1811 | $eventOptions = array( |
1728 | 1812 | 'include_birthdays' => true, |
@@ -1733,13 +1817,15 @@ discard block |
||
1733 | 1817 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1734 | 1818 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1735 | 1819 | |
1736 | - if ($output_method != 'echo') |
|
1737 | - return $return['calendar_birthdays']; |
|
1820 | + if ($output_method != 'echo') { |
|
1821 | + return $return['calendar_birthdays']; |
|
1822 | + } |
|
1738 | 1823 | |
1739 | - foreach ($return['calendar_birthdays'] as $member) |
|
1740 | - echo ' |
|
1824 | + foreach ($return['calendar_birthdays'] as $member) { |
|
1825 | + echo ' |
|
1741 | 1826 | <a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">' . $member['name'] . '</span>' . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>' . (!$member['is_last'] ? ', ' : ''); |
1742 | -} |
|
1827 | + } |
|
1828 | + } |
|
1743 | 1829 | |
1744 | 1830 | /** |
1745 | 1831 | * Shows today's holidays. |
@@ -1750,8 +1836,9 @@ discard block |
||
1750 | 1836 | { |
1751 | 1837 | global $modSettings, $user_info; |
1752 | 1838 | |
1753 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
1754 | - return; |
|
1839 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
1840 | + return; |
|
1841 | + } |
|
1755 | 1842 | |
1756 | 1843 | $eventOptions = array( |
1757 | 1844 | 'include_holidays' => true, |
@@ -1762,8 +1849,9 @@ discard block |
||
1762 | 1849 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1763 | 1850 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1764 | 1851 | |
1765 | - if ($output_method != 'echo') |
|
1766 | - return $return['calendar_holidays']; |
|
1852 | + if ($output_method != 'echo') { |
|
1853 | + return $return['calendar_holidays']; |
|
1854 | + } |
|
1767 | 1855 | |
1768 | 1856 | echo ' |
1769 | 1857 | ', implode(', ', $return['calendar_holidays']); |
@@ -1777,8 +1865,9 @@ discard block |
||
1777 | 1865 | { |
1778 | 1866 | global $modSettings, $user_info; |
1779 | 1867 | |
1780 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
1781 | - return; |
|
1868 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
1869 | + return; |
|
1870 | + } |
|
1782 | 1871 | |
1783 | 1872 | $eventOptions = array( |
1784 | 1873 | 'include_events' => true, |
@@ -1789,14 +1878,16 @@ discard block |
||
1789 | 1878 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1790 | 1879 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1791 | 1880 | |
1792 | - if ($output_method != 'echo') |
|
1793 | - return $return['calendar_events']; |
|
1881 | + if ($output_method != 'echo') { |
|
1882 | + return $return['calendar_events']; |
|
1883 | + } |
|
1794 | 1884 | |
1795 | 1885 | foreach ($return['calendar_events'] as $event) |
1796 | 1886 | { |
1797 | - if ($event['can_edit']) |
|
1798 | - echo ' |
|
1887 | + if ($event['can_edit']) { |
|
1888 | + echo ' |
|
1799 | 1889 | <a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> '; |
1890 | + } |
|
1800 | 1891 | echo ' |
1801 | 1892 | ' . $event['link'] . (!$event['is_last'] ? ', ' : ''); |
1802 | 1893 | } |
@@ -1811,8 +1902,9 @@ discard block |
||
1811 | 1902 | { |
1812 | 1903 | global $modSettings, $txt, $scripturl, $user_info; |
1813 | 1904 | |
1814 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
1815 | - return; |
|
1905 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
1906 | + return; |
|
1907 | + } |
|
1816 | 1908 | |
1817 | 1909 | $eventOptions = array( |
1818 | 1910 | 'include_birthdays' => allowedTo('profile_view'), |
@@ -1825,19 +1917,22 @@ discard block |
||
1825 | 1917 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1826 | 1918 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1827 | 1919 | |
1828 | - if ($output_method != 'echo') |
|
1829 | - return $return; |
|
1920 | + if ($output_method != 'echo') { |
|
1921 | + return $return; |
|
1922 | + } |
|
1830 | 1923 | |
1831 | - if (!empty($return['calendar_holidays'])) |
|
1832 | - echo ' |
|
1924 | + if (!empty($return['calendar_holidays'])) { |
|
1925 | + echo ' |
|
1833 | 1926 | <span class="holiday">' . $txt['calendar_prompt'] . ' ' . implode(', ', $return['calendar_holidays']) . '<br></span>'; |
1927 | + } |
|
1834 | 1928 | if (!empty($return['calendar_birthdays'])) |
1835 | 1929 | { |
1836 | 1930 | echo ' |
1837 | 1931 | <span class="birthday">' . $txt['birthdays_upcoming'] . '</span> '; |
1838 | - foreach ($return['calendar_birthdays'] as $member) |
|
1839 | - echo ' |
|
1932 | + foreach ($return['calendar_birthdays'] as $member) { |
|
1933 | + echo ' |
|
1840 | 1934 | <a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">', $member['name'], '</span>', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', !$member['is_last'] ? ', ' : ''; |
1935 | + } |
|
1841 | 1936 | echo ' |
1842 | 1937 | <br>'; |
1843 | 1938 | } |
@@ -1847,9 +1942,10 @@ discard block |
||
1847 | 1942 | <span class="event">' . $txt['events_upcoming'] . '</span> '; |
1848 | 1943 | foreach ($return['calendar_events'] as $event) |
1849 | 1944 | { |
1850 | - if ($event['can_edit']) |
|
1851 | - echo ' |
|
1945 | + if ($event['can_edit']) { |
|
1946 | + echo ' |
|
1852 | 1947 | <a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> '; |
1948 | + } |
|
1853 | 1949 | echo ' |
1854 | 1950 | ' . $event['link'] . (!$event['is_last'] ? ', ' : ''); |
1855 | 1951 | } |
@@ -1873,25 +1969,29 @@ discard block |
||
1873 | 1969 | loadLanguage('Stats'); |
1874 | 1970 | |
1875 | 1971 | // Must be integers.... |
1876 | - if ($limit === null) |
|
1877 | - $limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5; |
|
1878 | - else |
|
1879 | - $limit = (int) $limit; |
|
1880 | - |
|
1881 | - if ($start === null) |
|
1882 | - $start = isset($_GET['start']) ? (int) $_GET['start'] : 0; |
|
1883 | - else |
|
1884 | - $start = (int) $start; |
|
1885 | - |
|
1886 | - if ($board !== null) |
|
1887 | - $board = (int) $board; |
|
1888 | - elseif (isset($_GET['board'])) |
|
1889 | - $board = (int) $_GET['board']; |
|
1890 | - |
|
1891 | - if ($length === null) |
|
1892 | - $length = isset($_GET['length']) ? (int) $_GET['length'] : 0; |
|
1893 | - else |
|
1894 | - $length = (int) $length; |
|
1972 | + if ($limit === null) { |
|
1973 | + $limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5; |
|
1974 | + } else { |
|
1975 | + $limit = (int) $limit; |
|
1976 | + } |
|
1977 | + |
|
1978 | + if ($start === null) { |
|
1979 | + $start = isset($_GET['start']) ? (int) $_GET['start'] : 0; |
|
1980 | + } else { |
|
1981 | + $start = (int) $start; |
|
1982 | + } |
|
1983 | + |
|
1984 | + if ($board !== null) { |
|
1985 | + $board = (int) $board; |
|
1986 | + } elseif (isset($_GET['board'])) { |
|
1987 | + $board = (int) $_GET['board']; |
|
1988 | + } |
|
1989 | + |
|
1990 | + if ($length === null) { |
|
1991 | + $length = isset($_GET['length']) ? (int) $_GET['length'] : 0; |
|
1992 | + } else { |
|
1993 | + $length = (int) $length; |
|
1994 | + } |
|
1895 | 1995 | |
1896 | 1996 | $limit = max(0, $limit); |
1897 | 1997 | $start = max(0, $start); |
@@ -1909,17 +2009,19 @@ discard block |
||
1909 | 2009 | ); |
1910 | 2010 | if ($smcFunc['db_num_rows']($request) == 0) |
1911 | 2011 | { |
1912 | - if ($output_method == 'echo') |
|
1913 | - die($txt['ssi_no_guests']); |
|
1914 | - else |
|
1915 | - return array(); |
|
2012 | + if ($output_method == 'echo') { |
|
2013 | + die($txt['ssi_no_guests']); |
|
2014 | + } else { |
|
2015 | + return array(); |
|
2016 | + } |
|
1916 | 2017 | } |
1917 | 2018 | list ($board) = $smcFunc['db_fetch_row']($request); |
1918 | 2019 | $smcFunc['db_free_result']($request); |
1919 | 2020 | |
1920 | 2021 | $icon_sources = array(); |
1921 | - foreach ($context['stable_icons'] as $icon) |
|
1922 | - $icon_sources[$icon] = 'images_url'; |
|
2022 | + foreach ($context['stable_icons'] as $icon) { |
|
2023 | + $icon_sources[$icon] = 'images_url'; |
|
2024 | + } |
|
1923 | 2025 | |
1924 | 2026 | if (!empty($modSettings['enable_likes'])) |
1925 | 2027 | { |
@@ -1942,12 +2044,14 @@ discard block |
||
1942 | 2044 | ) |
1943 | 2045 | ); |
1944 | 2046 | $posts = array(); |
1945 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1946 | - $posts[] = $row['id_first_msg']; |
|
2047 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2048 | + $posts[] = $row['id_first_msg']; |
|
2049 | + } |
|
1947 | 2050 | $smcFunc['db_free_result']($request); |
1948 | 2051 | |
1949 | - if (empty($posts)) |
|
1950 | - return array(); |
|
2052 | + if (empty($posts)) { |
|
2053 | + return array(); |
|
2054 | + } |
|
1951 | 2055 | |
1952 | 2056 | // Find the posts. |
1953 | 2057 | $request = $smcFunc['db_query']('', ' |
@@ -1977,24 +2081,28 @@ discard block |
||
1977 | 2081 | $last_space = strrpos($row['body'], ' '); |
1978 | 2082 | $last_open = strrpos($row['body'], '<'); |
1979 | 2083 | $last_close = strrpos($row['body'], '>'); |
1980 | - if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6) |
|
1981 | - $cutoff = $last_open; |
|
1982 | - elseif (empty($last_close) || $last_close < $last_open) |
|
1983 | - $cutoff = $last_space; |
|
2084 | + if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6) { |
|
2085 | + $cutoff = $last_open; |
|
2086 | + } elseif (empty($last_close) || $last_close < $last_open) { |
|
2087 | + $cutoff = $last_space; |
|
2088 | + } |
|
1984 | 2089 | |
1985 | - if ($cutoff !== false) |
|
1986 | - $row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff); |
|
2090 | + if ($cutoff !== false) { |
|
2091 | + $row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff); |
|
2092 | + } |
|
1987 | 2093 | $row['body'] .= '...'; |
1988 | 2094 | } |
1989 | 2095 | |
1990 | 2096 | $row['body'] = parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']); |
1991 | 2097 | |
1992 | - if (!empty($recycle_board) && $row['id_board'] == $recycle_board) |
|
1993 | - $row['icon'] = 'recycled'; |
|
2098 | + if (!empty($recycle_board) && $row['id_board'] == $recycle_board) { |
|
2099 | + $row['icon'] = 'recycled'; |
|
2100 | + } |
|
1994 | 2101 | |
1995 | 2102 | // Check that this message icon is there... |
1996 | - if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) |
|
1997 | - $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
2103 | + if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) { |
|
2104 | + $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
2105 | + } |
|
1998 | 2106 | |
1999 | 2107 | censorText($row['subject']); |
2000 | 2108 | censorText($row['body']); |
@@ -2031,16 +2139,18 @@ discard block |
||
2031 | 2139 | } |
2032 | 2140 | $smcFunc['db_free_result']($request); |
2033 | 2141 | |
2034 | - if (empty($return)) |
|
2035 | - return $return; |
|
2142 | + if (empty($return)) { |
|
2143 | + return $return; |
|
2144 | + } |
|
2036 | 2145 | |
2037 | 2146 | $return[count($return) - 1]['is_last'] = true; |
2038 | 2147 | |
2039 | 2148 | // If mods want to do somthing with this list of posts, let them do that now. |
2040 | 2149 | call_integration_hook('integrate_ssi_boardNews', array(&$return)); |
2041 | 2150 | |
2042 | - if ($output_method != 'echo') |
|
2043 | - return $return; |
|
2151 | + if ($output_method != 'echo') { |
|
2152 | + return $return; |
|
2153 | + } |
|
2044 | 2154 | |
2045 | 2155 | foreach ($return as $news) |
2046 | 2156 | { |
@@ -2092,9 +2202,10 @@ discard block |
||
2092 | 2202 | echo ' |
2093 | 2203 | </div>'; |
2094 | 2204 | |
2095 | - if (!$news['is_last']) |
|
2096 | - echo ' |
|
2205 | + if (!$news['is_last']) { |
|
2206 | + echo ' |
|
2097 | 2207 | <hr>'; |
2208 | + } |
|
2098 | 2209 | } |
2099 | 2210 | } |
2100 | 2211 | |
@@ -2108,8 +2219,9 @@ discard block |
||
2108 | 2219 | { |
2109 | 2220 | global $user_info, $scripturl, $modSettings, $txt, $context, $smcFunc; |
2110 | 2221 | |
2111 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
2112 | - return; |
|
2222 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
2223 | + return; |
|
2224 | + } |
|
2113 | 2225 | |
2114 | 2226 | // Find all events which are happening in the near future that the member can see. |
2115 | 2227 | $request = $smcFunc['db_query']('', ' |
@@ -2135,20 +2247,23 @@ discard block |
||
2135 | 2247 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2136 | 2248 | { |
2137 | 2249 | // Check if we've already come by an event linked to this same topic with the same title... and don't display it if we have. |
2138 | - if (!empty($duplicates[$row['title'] . $row['id_topic']])) |
|
2139 | - continue; |
|
2250 | + if (!empty($duplicates[$row['title'] . $row['id_topic']])) { |
|
2251 | + continue; |
|
2252 | + } |
|
2140 | 2253 | |
2141 | 2254 | // Censor the title. |
2142 | 2255 | censorText($row['title']); |
2143 | 2256 | |
2144 | - if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false))) |
|
2145 | - $date = strftime('%Y-%m-%d', forum_time(false)); |
|
2146 | - else |
|
2147 | - $date = $row['start_date']; |
|
2257 | + if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false))) { |
|
2258 | + $date = strftime('%Y-%m-%d', forum_time(false)); |
|
2259 | + } else { |
|
2260 | + $date = $row['start_date']; |
|
2261 | + } |
|
2148 | 2262 | |
2149 | 2263 | // If the topic it is attached to is not approved then don't link it. |
2150 | - if (!empty($row['id_first_msg']) && !$row['approved']) |
|
2151 | - $row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0; |
|
2264 | + if (!empty($row['id_first_msg']) && !$row['approved']) { |
|
2265 | + $row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0; |
|
2266 | + } |
|
2152 | 2267 | |
2153 | 2268 | $allday = (empty($row['start_time']) || empty($row['end_time']) || empty($row['timezone']) || !in_array($row['timezone'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) ? true : false; |
2154 | 2269 | |
@@ -2174,24 +2289,27 @@ discard block |
||
2174 | 2289 | } |
2175 | 2290 | $smcFunc['db_free_result']($request); |
2176 | 2291 | |
2177 | - foreach ($return as $mday => $array) |
|
2178 | - $return[$mday][count($array) - 1]['is_last'] = true; |
|
2292 | + foreach ($return as $mday => $array) { |
|
2293 | + $return[$mday][count($array) - 1]['is_last'] = true; |
|
2294 | + } |
|
2179 | 2295 | |
2180 | 2296 | // If mods want to do somthing with this list of events, let them do that now. |
2181 | 2297 | call_integration_hook('integrate_ssi_recentEvents', array(&$return)); |
2182 | 2298 | |
2183 | - if ($output_method != 'echo' || empty($return)) |
|
2184 | - return $return; |
|
2299 | + if ($output_method != 'echo' || empty($return)) { |
|
2300 | + return $return; |
|
2301 | + } |
|
2185 | 2302 | |
2186 | 2303 | // Well the output method is echo. |
2187 | 2304 | echo ' |
2188 | 2305 | <span class="event">' . $txt['events'] . '</span> '; |
2189 | - foreach ($return as $mday => $array) |
|
2190 | - foreach ($array as $event) |
|
2306 | + foreach ($return as $mday => $array) { |
|
2307 | + foreach ($array as $event) |
|
2191 | 2308 | { |
2192 | 2309 | if ($event['can_edit']) |
2193 | 2310 | echo ' |
2194 | 2311 | <a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> '; |
2312 | + } |
|
2195 | 2313 | |
2196 | 2314 | echo ' |
2197 | 2315 | ' . $event['link'] . (!$event['is_last'] ? ', ' : ''); |
@@ -2210,8 +2328,9 @@ discard block |
||
2210 | 2328 | global $smcFunc; |
2211 | 2329 | |
2212 | 2330 | // If $id is null, this was most likely called from a query string and should do nothing. |
2213 | - if ($id === null) |
|
2214 | - return; |
|
2331 | + if ($id === null) { |
|
2332 | + return; |
|
2333 | + } |
|
2215 | 2334 | |
2216 | 2335 | $request = $smcFunc['db_query']('', ' |
2217 | 2336 | SELECT passwd, member_name, is_activated |
@@ -2243,8 +2362,9 @@ discard block |
||
2243 | 2362 | $attachments_boards = boardsAllowedTo('view_attachments'); |
2244 | 2363 | |
2245 | 2364 | // No boards? Adios amigo. |
2246 | - if (empty($attachments_boards)) |
|
2247 | - return array(); |
|
2365 | + if (empty($attachments_boards)) { |
|
2366 | + return array(); |
|
2367 | + } |
|
2248 | 2368 | |
2249 | 2369 | // Is it an array? |
2250 | 2370 | $attachment_ext = (array) $attachment_ext; |
@@ -2328,8 +2448,9 @@ discard block |
||
2328 | 2448 | call_integration_hook('integrate_ssi_recentAttachments', array(&$attachments)); |
2329 | 2449 | |
2330 | 2450 | // So you just want an array? Here you can have it. |
2331 | - if ($output_method == 'array' || empty($attachments)) |
|
2332 | - return $attachments; |
|
2451 | + if ($output_method == 'array' || empty($attachments)) { |
|
2452 | + return $attachments; |
|
2453 | + } |
|
2333 | 2454 | |
2334 | 2455 | // Give them the default. |
2335 | 2456 | echo ' |
@@ -2340,14 +2461,15 @@ discard block |
||
2340 | 2461 | <th style="text-align: left; padding: 2">', $txt['downloads'], '</th> |
2341 | 2462 | <th style="text-align: left; padding: 2">', $txt['filesize'], '</th> |
2342 | 2463 | </tr>'; |
2343 | - foreach ($attachments as $attach) |
|
2344 | - echo ' |
|
2464 | + foreach ($attachments as $attach) { |
|
2465 | + echo ' |
|
2345 | 2466 | <tr> |
2346 | 2467 | <td>', $attach['file']['link'], '</td> |
2347 | 2468 | <td>', $attach['member']['link'], '</td> |
2348 | 2469 | <td style="text-align: center">', $attach['file']['downloads'], '</td> |
2349 | 2470 | <td>', $attach['file']['filesize'], '</td> |
2350 | 2471 | </tr>'; |
2472 | + } |
|
2351 | 2473 | echo ' |
2352 | 2474 | </table>'; |
2353 | 2475 | } |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Add the file functions to the $smcFunc array. |
@@ -53,8 +54,9 @@ discard block |
||
53 | 54 | 'messages', 'moderator_groups', 'moderators', 'package_servers', 'permission_profiles', 'permissions', 'personal_messages', |
54 | 55 | 'pm_labeled_messages', 'pm_labels', 'pm_recipients', 'pm_rules', 'poll_choices', 'polls', 'scheduled_tasks', 'sessions', 'settings', 'smileys', |
55 | 56 | 'spiders', 'subscriptions', 'themes', 'topics', 'user_alerts', 'user_alerts_prefs', 'user_drafts', 'user_likes'); |
56 | - foreach ($reservedTables as $k => $table_name) |
|
57 | - $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
57 | + foreach ($reservedTables as $k => $table_name) { |
|
58 | + $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
59 | + } |
|
58 | 60 | |
59 | 61 | // We in turn may need the extra stuff. |
60 | 62 | db_extend('extra'); |
@@ -109,8 +111,9 @@ discard block |
||
109 | 111 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
110 | 112 | |
111 | 113 | // First - no way do we touch SMF tables. |
112 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
113 | - return false; |
|
114 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
115 | + return false; |
|
116 | + } |
|
114 | 117 | |
115 | 118 | // Log that we'll want to remove this on uninstall. |
116 | 119 | $db_package_log[] = array('remove_table', $table_name); |
@@ -120,9 +123,9 @@ discard block |
||
120 | 123 | if (in_array($full_table_name, $tables)) |
121 | 124 | { |
122 | 125 | // This is a sad day... drop the table? If not, return false (error) by default. |
123 | - if ($if_exists == 'overwrite') |
|
124 | - $smcFunc['db_drop_table']($table_name); |
|
125 | - else if ($if_exists == 'update') |
|
126 | + if ($if_exists == 'overwrite') { |
|
127 | + $smcFunc['db_drop_table']($table_name); |
|
128 | + } else if ($if_exists == 'update') |
|
126 | 129 | { |
127 | 130 | $smcFunc['db_transaction']('begin'); |
128 | 131 | $db_trans = true; |
@@ -134,15 +137,16 @@ discard block |
||
134 | 137 | ) |
135 | 138 | ); |
136 | 139 | $old_table_exists = true; |
140 | + } else { |
|
141 | + return $if_exists == 'ignore'; |
|
137 | 142 | } |
138 | - else |
|
139 | - return $if_exists == 'ignore'; |
|
140 | 143 | } |
141 | 144 | |
142 | 145 | // Righty - let's do the damn thing! |
143 | 146 | $table_query = 'CREATE TABLE ' . $table_name . "\n" . '('; |
144 | - foreach ($columns as $column) |
|
145 | - $table_query .= "\n\t" . smf_db_create_query_column($column) . ','; |
|
147 | + foreach ($columns as $column) { |
|
148 | + $table_query .= "\n\t" . smf_db_create_query_column($column) . ','; |
|
149 | + } |
|
146 | 150 | |
147 | 151 | // Loop through the indexes next... |
148 | 152 | foreach ($indexes as $index) |
@@ -150,19 +154,21 @@ discard block |
||
150 | 154 | $columns = implode(',', $index['columns']); |
151 | 155 | |
152 | 156 | // Is it the primary? |
153 | - if (isset($index['type']) && $index['type'] == 'primary') |
|
154 | - $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
155 | - else |
|
157 | + if (isset($index['type']) && $index['type'] == 'primary') { |
|
158 | + $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
159 | + } else |
|
156 | 160 | { |
157 | - if (empty($index['name'])) |
|
158 | - $index['name'] = implode('_', $index['columns']); |
|
161 | + if (empty($index['name'])) { |
|
162 | + $index['name'] = implode('_', $index['columns']); |
|
163 | + } |
|
159 | 164 | $table_query .= "\n\t" . (isset($index['type']) && $index['type'] == 'unique' ? 'UNIQUE' : 'KEY') . ' ' . $index['name'] . ' (' . $columns . '),'; |
160 | 165 | } |
161 | 166 | } |
162 | 167 | |
163 | 168 | // No trailing commas! |
164 | - if (substr($table_query, -1) == ',') |
|
165 | - $table_query = substr($table_query, 0, -1); |
|
169 | + if (substr($table_query, -1) == ',') { |
|
170 | + $table_query = substr($table_query, 0, -1); |
|
171 | + } |
|
166 | 172 | |
167 | 173 | // Which engine do we want here? |
168 | 174 | if (empty($engines)) |
@@ -172,8 +178,9 @@ discard block |
||
172 | 178 | |
173 | 179 | while ($row = $smcFunc['db_fetch_assoc']($get_engines)) |
174 | 180 | { |
175 | - if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') |
|
176 | - $engines[] = $row['Engine']; |
|
181 | + if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') { |
|
182 | + $engines[] = $row['Engine']; |
|
183 | + } |
|
177 | 184 | } |
178 | 185 | |
179 | 186 | $smcFunc['db_free_result']($get_engines); |
@@ -187,8 +194,9 @@ discard block |
||
187 | 194 | } |
188 | 195 | |
189 | 196 | $table_query .= ') ENGINE=' . $parameters['engine']; |
190 | - if (!empty($db_character_set) && $db_character_set == 'utf8') |
|
191 | - $table_query .= ' DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci'; |
|
197 | + if (!empty($db_character_set) && $db_character_set == 'utf8') { |
|
198 | + $table_query .= ' DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci'; |
|
199 | + } |
|
192 | 200 | |
193 | 201 | // Create the table! |
194 | 202 | $smcFunc['db_query']('', $table_query, |
@@ -255,8 +263,9 @@ discard block |
||
255 | 263 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
256 | 264 | |
257 | 265 | // God no - dropping one of these = bad. |
258 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
259 | - return false; |
|
266 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
267 | + return false; |
|
268 | + } |
|
260 | 269 | |
261 | 270 | // Does it exist? |
262 | 271 | if (in_array($full_table_name, $smcFunc['db_list_tables']())) |
@@ -297,14 +306,16 @@ discard block |
||
297 | 306 | |
298 | 307 | // Does it exist - if so don't add it again! |
299 | 308 | $columns = $smcFunc['db_list_columns']($table_name, false); |
300 | - foreach ($columns as $column) |
|
301 | - if ($column == $column_info['name']) |
|
309 | + foreach ($columns as $column) { |
|
310 | + if ($column == $column_info['name']) |
|
302 | 311 | { |
303 | 312 | // If we're going to overwrite then use change column. |
304 | 313 | if ($if_exists == 'update') |
305 | 314 | return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
306 | - else |
|
307 | - return false; |
|
315 | + } |
|
316 | + else { |
|
317 | + return false; |
|
318 | + } |
|
308 | 319 | } |
309 | 320 | |
310 | 321 | // Get the specifics... |
@@ -340,8 +351,8 @@ discard block |
||
340 | 351 | |
341 | 352 | // Does it exist? |
342 | 353 | $columns = $smcFunc['db_list_columns']($table_name, true); |
343 | - foreach ($columns as $column) |
|
344 | - if ($column['name'] == $column_name) |
|
354 | + foreach ($columns as $column) { |
|
355 | + if ($column['name'] == $column_name) |
|
345 | 356 | { |
346 | 357 | $smcFunc['db_query']('', ' |
347 | 358 | ALTER TABLE ' . $table_name . ' |
@@ -350,6 +361,7 @@ discard block |
||
350 | 361 | 'security_override' => true, |
351 | 362 | ) |
352 | 363 | ); |
364 | + } |
|
353 | 365 | |
354 | 366 | return true; |
355 | 367 | } |
@@ -375,37 +387,47 @@ discard block |
||
375 | 387 | // Check it does exist! |
376 | 388 | $columns = $smcFunc['db_list_columns']($table_name, true); |
377 | 389 | $old_info = null; |
378 | - foreach ($columns as $column) |
|
379 | - if ($column['name'] == $old_column) |
|
390 | + foreach ($columns as $column) { |
|
391 | + if ($column['name'] == $old_column) |
|
380 | 392 | $old_info = $column; |
393 | + } |
|
381 | 394 | |
382 | 395 | // Nothing? |
383 | - if ($old_info == null) |
|
384 | - return false; |
|
396 | + if ($old_info == null) { |
|
397 | + return false; |
|
398 | + } |
|
385 | 399 | |
386 | 400 | // Get the right bits. |
387 | - if (!isset($column_info['name'])) |
|
388 | - $column_info['name'] = $old_column; |
|
389 | - if (!isset($column_info['default'])) |
|
390 | - $column_info['default'] = $old_info['default']; |
|
391 | - if (!isset($column_info['null'])) |
|
392 | - $column_info['null'] = $old_info['null']; |
|
393 | - if (!isset($column_info['auto'])) |
|
394 | - $column_info['auto'] = $old_info['auto']; |
|
395 | - if (!isset($column_info['type'])) |
|
396 | - $column_info['type'] = $old_info['type']; |
|
397 | - if (!isset($column_info['size']) || !is_numeric($column_info['size'])) |
|
398 | - $column_info['size'] = $old_info['size']; |
|
399 | - if (!isset($column_info['unsigned']) || !in_array($column_info['type'], array('int', 'tinyint', 'smallint', 'mediumint', 'bigint'))) |
|
400 | - $column_info['unsigned'] = ''; |
|
401 | + if (!isset($column_info['name'])) { |
|
402 | + $column_info['name'] = $old_column; |
|
403 | + } |
|
404 | + if (!isset($column_info['default'])) { |
|
405 | + $column_info['default'] = $old_info['default']; |
|
406 | + } |
|
407 | + if (!isset($column_info['null'])) { |
|
408 | + $column_info['null'] = $old_info['null']; |
|
409 | + } |
|
410 | + if (!isset($column_info['auto'])) { |
|
411 | + $column_info['auto'] = $old_info['auto']; |
|
412 | + } |
|
413 | + if (!isset($column_info['type'])) { |
|
414 | + $column_info['type'] = $old_info['type']; |
|
415 | + } |
|
416 | + if (!isset($column_info['size']) || !is_numeric($column_info['size'])) { |
|
417 | + $column_info['size'] = $old_info['size']; |
|
418 | + } |
|
419 | + if (!isset($column_info['unsigned']) || !in_array($column_info['type'], array('int', 'tinyint', 'smallint', 'mediumint', 'bigint'))) { |
|
420 | + $column_info['unsigned'] = ''; |
|
421 | + } |
|
401 | 422 | |
402 | 423 | list ($type, $size) = $smcFunc['db_calculate_type']($column_info['type'], $column_info['size']); |
403 | 424 | |
404 | 425 | // Allow for unsigned integers (mysql only) |
405 | 426 | $unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint')) && !empty($column_info['unsigned']) ? 'unsigned ' : ''; |
406 | 427 | |
407 | - if ($size !== null) |
|
408 | - $type = $type . '(' . $size . ')'; |
|
428 | + if ($size !== null) { |
|
429 | + $type = $type . '(' . $size . ')'; |
|
430 | + } |
|
409 | 431 | |
410 | 432 | $smcFunc['db_query']('', ' |
411 | 433 | ALTER TABLE ' . $table_name . ' |
@@ -435,18 +457,20 @@ discard block |
||
435 | 457 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
436 | 458 | |
437 | 459 | // No columns = no index. |
438 | - if (empty($index_info['columns'])) |
|
439 | - return false; |
|
460 | + if (empty($index_info['columns'])) { |
|
461 | + return false; |
|
462 | + } |
|
440 | 463 | $columns = implode(',', $index_info['columns']); |
441 | 464 | |
442 | 465 | // No name - make it up! |
443 | 466 | if (empty($index_info['name'])) |
444 | 467 | { |
445 | 468 | // No need for primary. |
446 | - if (isset($index_info['type']) && $index_info['type'] == 'primary') |
|
447 | - $index_info['name'] = ''; |
|
448 | - else |
|
449 | - $index_info['name'] = implode('_', $index_info['columns']); |
|
469 | + if (isset($index_info['type']) && $index_info['type'] == 'primary') { |
|
470 | + $index_info['name'] = ''; |
|
471 | + } else { |
|
472 | + $index_info['name'] = implode('_', $index_info['columns']); |
|
473 | + } |
|
450 | 474 | } |
451 | 475 | |
452 | 476 | // Log that we are going to want to remove this! |
@@ -460,10 +484,11 @@ discard block |
||
460 | 484 | if ($index['name'] == $index_info['name'] || ($index['type'] == 'primary' && isset($index_info['type']) && $index_info['type'] == 'primary')) |
461 | 485 | { |
462 | 486 | // If we want to overwrite simply remove the current one then continue. |
463 | - if ($if_exists != 'update' || $index['type'] == 'primary') |
|
464 | - return false; |
|
465 | - else |
|
466 | - $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
487 | + if ($if_exists != 'update' || $index['type'] == 'primary') { |
|
488 | + return false; |
|
489 | + } else { |
|
490 | + $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
491 | + } |
|
467 | 492 | } |
468 | 493 | } |
469 | 494 | |
@@ -477,8 +502,7 @@ discard block |
||
477 | 502 | 'security_override' => true, |
478 | 503 | ) |
479 | 504 | ); |
480 | - } |
|
481 | - else |
|
505 | + } else |
|
482 | 506 | { |
483 | 507 | $smcFunc['db_query']('', ' |
484 | 508 | ALTER TABLE ' . $table_name . ' |
@@ -562,8 +586,7 @@ discard block |
||
562 | 586 | $types = array( |
563 | 587 | 'inet' => 'varbinary', |
564 | 588 | ); |
565 | - } |
|
566 | - else |
|
589 | + } else |
|
567 | 590 | { |
568 | 591 | $types = array( |
569 | 592 | 'varbinary' => 'inet', |
@@ -577,16 +600,15 @@ discard block |
||
577 | 600 | { |
578 | 601 | $type_size = 16; |
579 | 602 | $type_name = 'varbinary'; |
580 | - } |
|
581 | - elseif ($type_name == 'varbinary' && $reverse && $type_size == 16) |
|
603 | + } elseif ($type_name == 'varbinary' && $reverse && $type_size == 16) |
|
582 | 604 | { |
583 | 605 | $type_name = 'inet'; |
584 | 606 | $type_size = null; |
607 | + } elseif ($type_name == 'varbinary') { |
|
608 | + $type_name = 'varbinary'; |
|
609 | + } else { |
|
610 | + $type_name = $types[$type_name]; |
|
585 | 611 | } |
586 | - elseif ($type_name == 'varbinary') |
|
587 | - $type_name = 'varbinary'; |
|
588 | - else |
|
589 | - $type_name = $types[$type_name]; |
|
590 | 612 | } |
591 | 613 | |
592 | 614 | return array($type_name, $type_size); |
@@ -653,8 +675,7 @@ discard block |
||
653 | 675 | if (!$detail) |
654 | 676 | { |
655 | 677 | $columns[] = $row['Field']; |
656 | - } |
|
657 | - else |
|
678 | + } else |
|
658 | 679 | { |
659 | 680 | // Is there an auto_increment? |
660 | 681 | $auto = strpos($row['Extra'], 'auto_increment') !== false ? true : false; |
@@ -664,10 +685,10 @@ discard block |
||
664 | 685 | { |
665 | 686 | $type = $matches[1]; |
666 | 687 | $size = $matches[2]; |
667 | - if (!empty($matches[3]) && $matches[3] == 'unsigned') |
|
668 | - $unsigned = true; |
|
669 | - } |
|
670 | - else |
|
688 | + if (!empty($matches[3]) && $matches[3] == 'unsigned') { |
|
689 | + $unsigned = true; |
|
690 | + } |
|
691 | + } else |
|
671 | 692 | { |
672 | 693 | $type = $row['Type']; |
673 | 694 | $size = null; |
@@ -718,19 +739,20 @@ discard block |
||
718 | 739 | $indexes = array(); |
719 | 740 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
720 | 741 | { |
721 | - if (!$detail) |
|
722 | - $indexes[] = $row['Key_name']; |
|
723 | - else |
|
742 | + if (!$detail) { |
|
743 | + $indexes[] = $row['Key_name']; |
|
744 | + } else |
|
724 | 745 | { |
725 | 746 | // What is the type? |
726 | - if ($row['Key_name'] == 'PRIMARY') |
|
727 | - $type = 'primary'; |
|
728 | - elseif (empty($row['Non_unique'])) |
|
729 | - $type = 'unique'; |
|
730 | - elseif (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT') |
|
731 | - $type = 'fulltext'; |
|
732 | - else |
|
733 | - $type = 'index'; |
|
747 | + if ($row['Key_name'] == 'PRIMARY') { |
|
748 | + $type = 'primary'; |
|
749 | + } elseif (empty($row['Non_unique'])) { |
|
750 | + $type = 'unique'; |
|
751 | + } elseif (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT') { |
|
752 | + $type = 'fulltext'; |
|
753 | + } else { |
|
754 | + $type = 'index'; |
|
755 | + } |
|
734 | 756 | |
735 | 757 | // This is the first column we've seen? |
736 | 758 | if (empty($indexes[$row['Key_name']])) |
@@ -743,10 +765,11 @@ discard block |
||
743 | 765 | } |
744 | 766 | |
745 | 767 | // Is it a partial index? |
746 | - if (!empty($row['Sub_part'])) |
|
747 | - $indexes[$row['Key_name']]['columns'][] = $row['Column_name'] . '(' . $row['Sub_part'] . ')'; |
|
748 | - else |
|
749 | - $indexes[$row['Key_name']]['columns'][] = $row['Column_name']; |
|
768 | + if (!empty($row['Sub_part'])) { |
|
769 | + $indexes[$row['Key_name']]['columns'][] = $row['Column_name'] . '(' . $row['Sub_part'] . ')'; |
|
770 | + } else { |
|
771 | + $indexes[$row['Key_name']]['columns'][] = $row['Column_name']; |
|
772 | + } |
|
750 | 773 | } |
751 | 774 | } |
752 | 775 | $smcFunc['db_free_result']($result); |
@@ -768,11 +791,11 @@ discard block |
||
768 | 791 | if (!empty($column['auto'])) |
769 | 792 | { |
770 | 793 | $default = 'auto_increment'; |
794 | + } elseif (isset($column['default']) && $column['default'] !== null) { |
|
795 | + $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
796 | + } else { |
|
797 | + $default = ''; |
|
771 | 798 | } |
772 | - elseif (isset($column['default']) && $column['default'] !== null) |
|
773 | - $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
774 | - else |
|
775 | - $default = ''; |
|
776 | 799 | |
777 | 800 | // Sort out the size... and stuff... |
778 | 801 | $column['size'] = isset($column['size']) && is_numeric($column['size']) ? $column['size'] : null; |
@@ -781,8 +804,9 @@ discard block |
||
781 | 804 | // Allow unsigned integers (mysql only) |
782 | 805 | $unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint')) && !empty($column['unsigned']) ? 'unsigned ' : ''; |
783 | 806 | |
784 | - if ($size !== null) |
|
785 | - $type = $type . '(' . $size . ')'; |
|
807 | + if ($size !== null) { |
|
808 | + $type = $type . '(' . $size . ')'; |
|
809 | + } |
|
786 | 810 | |
787 | 811 | // Now just put it together! |
788 | 812 | return '`' . $column['name'] . '` ' . $type . ' ' . (!empty($unsigned) ? $unsigned : '') . (!empty($column['null']) ? '' : 'NOT NULL') . ' ' . $default; |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Add the file functions to the $smcFunc array. |
@@ -53,8 +54,9 @@ discard block |
||
53 | 54 | 'messages', 'moderator_groups', 'moderators', 'package_servers', 'permission_profiles', 'permissions', 'personal_messages', |
54 | 55 | 'pm_labeled_messages', 'pm_labels', 'pm_recipients', 'pm_rules', 'poll_choices', 'polls', 'scheduled_tasks', 'sessions', 'settings', 'smileys', |
55 | 56 | 'spiders', 'subscriptions', 'themes', 'topics', 'user_alerts', 'user_alerts_prefs', 'user_drafts', 'user_likes'); |
56 | - foreach ($reservedTables as $k => $table_name) |
|
57 | - $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
57 | + foreach ($reservedTables as $k => $table_name) { |
|
58 | + $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
59 | + } |
|
58 | 60 | |
59 | 61 | // We in turn may need the extra stuff. |
60 | 62 | db_extend('extra'); |
@@ -107,8 +109,9 @@ discard block |
||
107 | 109 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
108 | 110 | |
109 | 111 | // First - no way do we touch SMF tables. |
110 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
111 | - return false; |
|
112 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
113 | + return false; |
|
114 | + } |
|
112 | 115 | |
113 | 116 | // Log that we'll want to remove this on uninstall. |
114 | 117 | $db_package_log[] = array('remove_table', $table_name); |
@@ -118,9 +121,9 @@ discard block |
||
118 | 121 | if (in_array($full_table_name, $tables)) |
119 | 122 | { |
120 | 123 | // This is a sad day... drop the table? If not, return false (error) by default. |
121 | - if ($if_exists == 'overwrite') |
|
122 | - $smcFunc['db_drop_table']($table_name); |
|
123 | - else if ($if_exists == 'update') |
|
124 | + if ($if_exists == 'overwrite') { |
|
125 | + $smcFunc['db_drop_table']($table_name); |
|
126 | + } else if ($if_exists == 'update') |
|
124 | 127 | { |
125 | 128 | $smcFunc['db_drop_table']($table_name.'_old'); |
126 | 129 | $smcFunc['db_transaction']('begin'); |
@@ -132,47 +135,51 @@ discard block |
||
132 | 135 | ) |
133 | 136 | ); |
134 | 137 | $old_table_exists = true; |
138 | + } else { |
|
139 | + return $if_exists == 'ignore'; |
|
135 | 140 | } |
136 | - else |
|
137 | - return $if_exists == 'ignore'; |
|
138 | 141 | } |
139 | 142 | |
140 | 143 | // If we've got this far - good news - no table exists. We can build our own! |
141 | - if (!$db_trans) |
|
142 | - $smcFunc['db_transaction']('begin'); |
|
144 | + if (!$db_trans) { |
|
145 | + $smcFunc['db_transaction']('begin'); |
|
146 | + } |
|
143 | 147 | $table_query = 'CREATE TABLE ' . $table_name . "\n" . '('; |
144 | 148 | foreach ($columns as $column) |
145 | 149 | { |
146 | 150 | // If we have an auto increment do it! |
147 | 151 | if (!empty($column['auto'])) |
148 | 152 | { |
149 | - if (!$old_table_exists) |
|
150 | - $smcFunc['db_query']('', ' |
|
153 | + if (!$old_table_exists) { |
|
154 | + $smcFunc['db_query']('', ' |
|
151 | 155 | DROP SEQUENCE IF EXISTS ' . $table_name . '_seq', |
152 | 156 | array( |
153 | 157 | 'security_override' => true, |
154 | 158 | ) |
155 | 159 | ); |
160 | + } |
|
156 | 161 | |
157 | - if (!$old_table_exists) |
|
158 | - $smcFunc['db_query']('', ' |
|
162 | + if (!$old_table_exists) { |
|
163 | + $smcFunc['db_query']('', ' |
|
159 | 164 | CREATE SEQUENCE ' . $table_name . '_seq', |
160 | 165 | array( |
161 | 166 | 'security_override' => true, |
162 | 167 | ) |
163 | 168 | ); |
169 | + } |
|
164 | 170 | $default = 'default nextval(\'' . $table_name . '_seq\')'; |
171 | + } elseif (isset($column['default']) && $column['default'] !== null) { |
|
172 | + $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
173 | + } else { |
|
174 | + $default = ''; |
|
165 | 175 | } |
166 | - elseif (isset($column['default']) && $column['default'] !== null) |
|
167 | - $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
168 | - else |
|
169 | - $default = ''; |
|
170 | 176 | |
171 | 177 | // Sort out the size... |
172 | 178 | $column['size'] = isset($column['size']) && is_numeric($column['size']) ? $column['size'] : null; |
173 | 179 | list ($type, $size) = $smcFunc['db_calculate_type']($column['type'], $column['size']); |
174 | - if ($size !== null) |
|
175 | - $type = $type . '(' . $size . ')'; |
|
180 | + if ($size !== null) { |
|
181 | + $type = $type . '(' . $size . ')'; |
|
182 | + } |
|
176 | 183 | |
177 | 184 | // Now just put it together! |
178 | 185 | $table_query .= "\n\t\"" . $column['name'] . '" ' . $type . ' ' . (!empty($column['null']) ? '' : 'NOT NULL') . ' ' . $default . ','; |
@@ -185,19 +192,21 @@ discard block |
||
185 | 192 | $columns = implode(',', $index['columns']); |
186 | 193 | |
187 | 194 | // Primary goes in the table... |
188 | - if (isset($index['type']) && $index['type'] == 'primary') |
|
189 | - $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
190 | - else |
|
195 | + if (isset($index['type']) && $index['type'] == 'primary') { |
|
196 | + $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
197 | + } else |
|
191 | 198 | { |
192 | - if (empty($index['name'])) |
|
193 | - $index['name'] = implode('_', $index['columns']); |
|
199 | + if (empty($index['name'])) { |
|
200 | + $index['name'] = implode('_', $index['columns']); |
|
201 | + } |
|
194 | 202 | $index_queries[] = 'CREATE ' . (isset($index['type']) && $index['type'] == 'unique' ? 'UNIQUE' : '') . ' INDEX ' . $table_name . '_' . $index['name'] . ' ON ' . $table_name . ' (' . $columns . ')'; |
195 | 203 | } |
196 | 204 | } |
197 | 205 | |
198 | 206 | // No trailing commas! |
199 | - if (substr($table_query, -1) == ',') |
|
200 | - $table_query = substr($table_query, 0, -1); |
|
207 | + if (substr($table_query, -1) == ',') { |
|
208 | + $table_query = substr($table_query, 0, -1); |
|
209 | + } |
|
201 | 210 | |
202 | 211 | $table_query .= ')'; |
203 | 212 | |
@@ -242,18 +251,20 @@ discard block |
||
242 | 251 | } |
243 | 252 | |
244 | 253 | // And the indexes... |
245 | - foreach ($index_queries as $query) |
|
246 | - $smcFunc['db_query']('', $query, |
|
254 | + foreach ($index_queries as $query) { |
|
255 | + $smcFunc['db_query']('', $query, |
|
247 | 256 | array( |
248 | 257 | 'security_override' => true, |
249 | 258 | ) |
250 | 259 | ); |
260 | + } |
|
251 | 261 | |
252 | 262 | // Go, go power rangers! |
253 | 263 | $smcFunc['db_transaction']('commit'); |
254 | 264 | |
255 | - if ($old_table_exists) |
|
256 | - $smcFunc['db_drop_table']($table_name . '_old'); |
|
265 | + if ($old_table_exists) { |
|
266 | + $smcFunc['db_drop_table']($table_name . '_old'); |
|
267 | + } |
|
257 | 268 | |
258 | 269 | return true; |
259 | 270 | } |
@@ -278,8 +289,9 @@ discard block |
||
278 | 289 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
279 | 290 | |
280 | 291 | // God no - dropping one of these = bad. |
281 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
282 | - return false; |
|
292 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
293 | + return false; |
|
294 | + } |
|
283 | 295 | |
284 | 296 | // Does it exist? |
285 | 297 | if (in_array($full_table_name, $smcFunc['db_list_tables']())) |
@@ -337,21 +349,24 @@ discard block |
||
337 | 349 | |
338 | 350 | // Does it exist - if so don't add it again! |
339 | 351 | $columns = $smcFunc['db_list_columns']($table_name, false); |
340 | - foreach ($columns as $column) |
|
341 | - if ($column == $column_info['name']) |
|
352 | + foreach ($columns as $column) { |
|
353 | + if ($column == $column_info['name']) |
|
342 | 354 | { |
343 | 355 | // If we're going to overwrite then use change column. |
344 | 356 | if ($if_exists == 'update') |
345 | 357 | return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
346 | - else |
|
347 | - return false; |
|
358 | + } |
|
359 | + else { |
|
360 | + return false; |
|
361 | + } |
|
348 | 362 | } |
349 | 363 | |
350 | 364 | // Get the specifics... |
351 | 365 | $column_info['size'] = isset($column_info['size']) && is_numeric($column_info['size']) ? $column_info['size'] : null; |
352 | 366 | list ($type, $size) = $smcFunc['db_calculate_type']($column_info['type'], $column_info['size']); |
353 | - if ($size !== null) |
|
354 | - $type = $type . '(' . $size . ')'; |
|
367 | + if ($size !== null) { |
|
368 | + $type = $type . '(' . $size . ')'; |
|
369 | + } |
|
355 | 370 | |
356 | 371 | // Now add the thing! |
357 | 372 | $query = ' |
@@ -366,11 +381,12 @@ discard block |
||
366 | 381 | // If there's more attributes they need to be done via a change on PostgreSQL. |
367 | 382 | unset($column_info['type'], $column_info['size']); |
368 | 383 | |
369 | - if (count($column_info) != 1) |
|
370 | - return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
|
371 | - else |
|
372 | - return true; |
|
373 | -} |
|
384 | + if (count($column_info) != 1) { |
|
385 | + return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
|
386 | + } else { |
|
387 | + return true; |
|
388 | + } |
|
389 | + } |
|
374 | 390 | |
375 | 391 | /** |
376 | 392 | * Removes a column. |
@@ -389,8 +405,8 @@ discard block |
||
389 | 405 | |
390 | 406 | // Does it exist? |
391 | 407 | $columns = $smcFunc['db_list_columns']($table_name, true); |
392 | - foreach ($columns as $column) |
|
393 | - if ($column['name'] == $column_name) |
|
408 | + foreach ($columns as $column) { |
|
409 | + if ($column['name'] == $column_name) |
|
394 | 410 | { |
395 | 411 | // If there is an auto we need remove it! |
396 | 412 | if ($column['auto']) |
@@ -400,6 +416,7 @@ discard block |
||
400 | 416 | 'security_override' => true, |
401 | 417 | ) |
402 | 418 | ); |
419 | + } |
|
403 | 420 | |
404 | 421 | $smcFunc['db_query']('', ' |
405 | 422 | ALTER TABLE ' . $table_name . ' |
@@ -433,13 +450,15 @@ discard block |
||
433 | 450 | // Check it does exist! |
434 | 451 | $columns = $smcFunc['db_list_columns']($table_name, true); |
435 | 452 | $old_info = null; |
436 | - foreach ($columns as $column) |
|
437 | - if ($column['name'] == $old_column) |
|
453 | + foreach ($columns as $column) { |
|
454 | + if ($column['name'] == $old_column) |
|
438 | 455 | $old_info = $column; |
456 | + } |
|
439 | 457 | |
440 | 458 | // Nothing? |
441 | - if ($old_info == null) |
|
442 | - return false; |
|
459 | + if ($old_info == null) { |
|
460 | + return false; |
|
461 | + } |
|
443 | 462 | |
444 | 463 | // Now we check each bit individually and ALTER as required. |
445 | 464 | if (isset($column_info['name']) && $column_info['name'] != $old_column) |
@@ -496,8 +515,9 @@ discard block |
||
496 | 515 | { |
497 | 516 | $column_info['size'] = isset($column_info['size']) && is_numeric($column_info['size']) ? $column_info['size'] : null; |
498 | 517 | list ($type, $size) = $smcFunc['db_calculate_type']($column_info['type'], $column_info['size']); |
499 | - if ($size !== null) |
|
500 | - $type = $type . '(' . $size . ')'; |
|
518 | + if ($size !== null) { |
|
519 | + $type = $type . '(' . $size . ')'; |
|
520 | + } |
|
501 | 521 | |
502 | 522 | // The alter is a pain. |
503 | 523 | $smcFunc['db_transaction']('begin'); |
@@ -598,21 +618,23 @@ discard block |
||
598 | 618 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
599 | 619 | |
600 | 620 | // No columns = no index. |
601 | - if (empty($index_info['columns'])) |
|
602 | - return false; |
|
621 | + if (empty($index_info['columns'])) { |
|
622 | + return false; |
|
623 | + } |
|
603 | 624 | $columns = implode(',', $index_info['columns']); |
604 | 625 | |
605 | 626 | // No name - make it up! |
606 | 627 | if (empty($index_info['name'])) |
607 | 628 | { |
608 | 629 | // No need for primary. |
609 | - if (isset($index_info['type']) && $index_info['type'] == 'primary') |
|
610 | - $index_info['name'] = ''; |
|
611 | - else |
|
612 | - $index_info['name'] = $table_name . implode('_', $index_info['columns']); |
|
630 | + if (isset($index_info['type']) && $index_info['type'] == 'primary') { |
|
631 | + $index_info['name'] = ''; |
|
632 | + } else { |
|
633 | + $index_info['name'] = $table_name . implode('_', $index_info['columns']); |
|
634 | + } |
|
635 | + } else { |
|
636 | + $index_info['name'] = $table_name . $index_info['name']; |
|
613 | 637 | } |
614 | - else |
|
615 | - $index_info['name'] = $table_name . $index_info['name']; |
|
616 | 638 | |
617 | 639 | // Log that we are going to want to remove this! |
618 | 640 | $db_package_log[] = array('remove_index', $table_name, $index_info['name']); |
@@ -625,10 +647,11 @@ discard block |
||
625 | 647 | if ($index['name'] == $index_info['name'] || ($index['type'] == 'primary' && isset($index_info['type']) && $index_info['type'] == 'primary')) |
626 | 648 | { |
627 | 649 | // If we want to overwrite simply remove the current one then continue. |
628 | - if ($if_exists != 'update' || $index['type'] == 'primary') |
|
629 | - return false; |
|
630 | - else |
|
631 | - $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
650 | + if ($if_exists != 'update' || $index['type'] == 'primary') { |
|
651 | + return false; |
|
652 | + } else { |
|
653 | + $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
654 | + } |
|
632 | 655 | } |
633 | 656 | } |
634 | 657 | |
@@ -642,8 +665,7 @@ discard block |
||
642 | 665 | 'security_override' => true, |
643 | 666 | ) |
644 | 667 | ); |
645 | - } |
|
646 | - else |
|
668 | + } else |
|
647 | 669 | { |
648 | 670 | $smcFunc['db_query']('', ' |
649 | 671 | CREATE ' . (isset($index_info['type']) && $index_info['type'] == 'unique' ? 'UNIQUE' : '') . ' INDEX ' . $index_info['name'] . ' ON ' . $table_name . ' (' . $columns . ')', |
@@ -671,8 +693,9 @@ discard block |
||
671 | 693 | |
672 | 694 | // Better exist! |
673 | 695 | $indexes = $smcFunc['db_list_indexes']($table_name, true); |
674 | - if ($index_name != 'primary') |
|
675 | - $index_name = $table_name . '_' . $index_name; |
|
696 | + if ($index_name != 'primary') { |
|
697 | + $index_name = $table_name . '_' . $index_name; |
|
698 | + } |
|
676 | 699 | |
677 | 700 | foreach ($indexes as $index) |
678 | 701 | { |
@@ -736,8 +759,7 @@ discard block |
||
736 | 759 | 'datetime' => 'timestamp without time zone', |
737 | 760 | 'timestamp' => 'timestamp without time zone', |
738 | 761 | ); |
739 | - } |
|
740 | - else |
|
762 | + } else |
|
741 | 763 | { |
742 | 764 | $types = array( |
743 | 765 | 'character varying' => 'varchar', |
@@ -753,14 +775,16 @@ discard block |
||
753 | 775 | // Got it? Change it! |
754 | 776 | if (isset($types[$type_name])) |
755 | 777 | { |
756 | - if ($type_name == 'tinytext') |
|
757 | - $type_size = 255; |
|
778 | + if ($type_name == 'tinytext') { |
|
779 | + $type_size = 255; |
|
780 | + } |
|
758 | 781 | $type_name = $types[$type_name]; |
759 | 782 | } |
760 | 783 | |
761 | 784 | // Only char fields got size |
762 | - if (strpos($type_name, 'char') === false) |
|
763 | - $type_size = null; |
|
785 | + if (strpos($type_name, 'char') === false) { |
|
786 | + $type_size = null; |
|
787 | + } |
|
764 | 788 | |
765 | 789 | |
766 | 790 | return array($type_name, $type_size); |
@@ -816,8 +840,7 @@ discard block |
||
816 | 840 | if (!$detail) |
817 | 841 | { |
818 | 842 | $columns[] = $row['column_name']; |
819 | - } |
|
820 | - else |
|
843 | + } else |
|
821 | 844 | { |
822 | 845 | $auto = false; |
823 | 846 | // What is the default? |
@@ -825,11 +848,11 @@ discard block |
||
825 | 848 | { |
826 | 849 | $default = null; |
827 | 850 | $auto = true; |
851 | + } elseif (trim($row['column_default']) != '') { |
|
852 | + $default = strpos($row['column_default'], '::') === false ? $row['column_default'] : substr($row['column_default'], 0, strpos($row['column_default'], '::')); |
|
853 | + } else { |
|
854 | + $default = null; |
|
828 | 855 | } |
829 | - elseif (trim($row['column_default']) != '') |
|
830 | - $default = strpos($row['column_default'], '::') === false ? $row['column_default'] : substr($row['column_default'], 0, strpos($row['column_default'], '::')); |
|
831 | - else |
|
832 | - $default = null; |
|
833 | 856 | |
834 | 857 | // Make the type generic. |
835 | 858 | list ($type, $size) = $smcFunc['db_calculate_type']($row['data_type'], $row['character_maximum_length'], true); |
@@ -880,26 +903,30 @@ discard block |
||
880 | 903 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
881 | 904 | { |
882 | 905 | // Try get the columns that make it up. |
883 | - if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0) |
|
884 | - continue; |
|
906 | + if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0) { |
|
907 | + continue; |
|
908 | + } |
|
885 | 909 | |
886 | 910 | $columns = explode(',', $matches[1]); |
887 | 911 | |
888 | - if (empty($columns)) |
|
889 | - continue; |
|
912 | + if (empty($columns)) { |
|
913 | + continue; |
|
914 | + } |
|
890 | 915 | |
891 | - foreach ($columns as $k => $v) |
|
892 | - $columns[$k] = trim($v); |
|
916 | + foreach ($columns as $k => $v) { |
|
917 | + $columns[$k] = trim($v); |
|
918 | + } |
|
893 | 919 | |
894 | 920 | // Fix up the name to be consistent cross databases |
895 | - if (substr($row['name'], -5) == '_pkey' && $row['is_primary'] == 1) |
|
896 | - $row['name'] = 'PRIMARY'; |
|
897 | - else |
|
898 | - $row['name'] = str_replace($table_name . '_', '', $row['name']); |
|
921 | + if (substr($row['name'], -5) == '_pkey' && $row['is_primary'] == 1) { |
|
922 | + $row['name'] = 'PRIMARY'; |
|
923 | + } else { |
|
924 | + $row['name'] = str_replace($table_name . '_', '', $row['name']); |
|
925 | + } |
|
899 | 926 | |
900 | - if (!$detail) |
|
901 | - $indexes[] = $row['name']; |
|
902 | - else |
|
927 | + if (!$detail) { |
|
928 | + $indexes[] = $row['name']; |
|
929 | + } else |
|
903 | 930 | { |
904 | 931 | $indexes[$row['name']] = array( |
905 | 932 | 'name' => $row['name'], |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
122 | 123 | $smcFunc['db_free_result']($result); |
123 | 124 | |
124 | 125 | // Add this to the number of unapproved members |
125 | - if (!empty($changes['unapprovedMembers'])) |
|
126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
127 | - else |
|
128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
126 | + if (!empty($changes['unapprovedMembers'])) { |
|
127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
128 | + } else { |
|
129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
130 | + } |
|
129 | 131 | } |
130 | 132 | } |
131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
133 | 135 | break; |
134 | 136 | |
135 | 137 | case 'message': |
136 | - if ($parameter1 === true && $parameter2 !== null) |
|
137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
138 | - else |
|
138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
140 | + } else |
|
139 | 141 | { |
140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
175 | 177 | $parameter2 = text2words($parameter2); |
176 | 178 | |
177 | 179 | $inserts = array(); |
178 | - foreach ($parameter2 as $word) |
|
179 | - $inserts[] = array($word, $parameter1); |
|
180 | + foreach ($parameter2 as $word) { |
|
181 | + $inserts[] = array($word, $parameter1); |
|
182 | + } |
|
180 | 183 | |
181 | - if (!empty($inserts)) |
|
182 | - $smcFunc['db_insert']('ignore', |
|
184 | + if (!empty($inserts)) { |
|
185 | + $smcFunc['db_insert']('ignore', |
|
183 | 186 | '{db_prefix}log_search_subjects', |
184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
185 | 188 | $inserts, |
186 | 189 | array('word', 'id_topic') |
187 | 190 | ); |
191 | + } |
|
188 | 192 | } |
189 | 193 | break; |
190 | 194 | |
191 | 195 | case 'topic': |
192 | - if ($parameter1 === true) |
|
193 | - updateSettings(array('totalTopics' => true), true); |
|
194 | - else |
|
196 | + if ($parameter1 === true) { |
|
197 | + updateSettings(array('totalTopics' => true), true); |
|
198 | + } else |
|
195 | 199 | { |
196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
212 | 216 | |
213 | 217 | case 'postgroups': |
214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
216 | - return; |
|
219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
220 | + return; |
|
221 | + } |
|
217 | 222 | |
218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
228 | 233 | ) |
229 | 234 | ); |
230 | 235 | $postgroups = array(); |
231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
238 | + } |
|
233 | 239 | $smcFunc['db_free_result']($request); |
234 | 240 | |
235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
239 | 245 | } |
240 | 246 | |
241 | 247 | // Oh great, they've screwed their post groups. |
242 | - if (empty($postgroups)) |
|
243 | - return; |
|
248 | + if (empty($postgroups)) { |
|
249 | + return; |
|
250 | + } |
|
244 | 251 | |
245 | 252 | // Set all membergroups from most posts to least posts. |
246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
298 | 305 | { |
299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
300 | 307 | $parameters['members'] = $members; |
301 | - } |
|
302 | - elseif ($members === null) |
|
303 | - $condition = '1=1'; |
|
304 | - else |
|
308 | + } elseif ($members === null) { |
|
309 | + $condition = '1=1'; |
|
310 | + } else |
|
305 | 311 | { |
306 | 312 | $condition = 'id_member = {int:member}'; |
307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
341 | 347 | if (count($vars_to_integrate) != 0) |
342 | 348 | { |
343 | 349 | // Fetch a list of member_names if necessary |
344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
345 | - $member_names = array($user_info['username']); |
|
346 | - else |
|
350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
351 | + $member_names = array($user_info['username']); |
|
352 | + } else |
|
347 | 353 | { |
348 | 354 | $member_names = array(); |
349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
352 | 358 | WHERE ' . $condition, |
353 | 359 | $parameters |
354 | 360 | ); |
355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
356 | - $member_names[] = $row['member_name']; |
|
361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
362 | + $member_names[] = $row['member_name']; |
|
363 | + } |
|
357 | 364 | $smcFunc['db_free_result']($request); |
358 | 365 | } |
359 | 366 | |
360 | - if (!empty($member_names)) |
|
361 | - foreach ($vars_to_integrate as $var) |
|
367 | + if (!empty($member_names)) { |
|
368 | + foreach ($vars_to_integrate as $var) |
|
362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
370 | + } |
|
363 | 371 | } |
364 | 372 | } |
365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
367 | 375 | foreach ($data as $var => $val) |
368 | 376 | { |
369 | 377 | $type = 'string'; |
370 | - if (in_array($var, $knownInts)) |
|
371 | - $type = 'int'; |
|
372 | - elseif (in_array($var, $knownFloats)) |
|
373 | - $type = 'float'; |
|
374 | - elseif ($var == 'birthdate') |
|
375 | - $type = 'date'; |
|
376 | - elseif ($var == 'member_ip') |
|
377 | - $type = 'inet'; |
|
378 | - elseif ($var == 'member_ip2') |
|
379 | - $type = 'inet'; |
|
378 | + if (in_array($var, $knownInts)) { |
|
379 | + $type = 'int'; |
|
380 | + } elseif (in_array($var, $knownFloats)) { |
|
381 | + $type = 'float'; |
|
382 | + } elseif ($var == 'birthdate') { |
|
383 | + $type = 'date'; |
|
384 | + } elseif ($var == 'member_ip') { |
|
385 | + $type = 'inet'; |
|
386 | + } elseif ($var == 'member_ip2') { |
|
387 | + $type = 'inet'; |
|
388 | + } |
|
380 | 389 | |
381 | 390 | // Doing an increment? |
382 | 391 | if ($var == 'alerts' && ($val === '+' || $val === '-')) |
@@ -385,18 +394,17 @@ discard block |
||
385 | 394 | if (is_array($members)) |
386 | 395 | { |
387 | 396 | $val = 'CASE '; |
388 | - foreach ($members as $k => $v) |
|
389 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
397 | + foreach ($members as $k => $v) { |
|
398 | + $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
399 | + } |
|
390 | 400 | $val = $val . ' END'; |
391 | 401 | $type = 'raw'; |
392 | - } |
|
393 | - else |
|
402 | + } else |
|
394 | 403 | { |
395 | 404 | $blub = fetch_alerts($members, false, 0, array(), false); |
396 | 405 | $val = count($blub); |
397 | 406 | } |
398 | - } |
|
399 | - else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
407 | + } else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
400 | 408 | { |
401 | 409 | $val = $var . ' ' . $val . ' 1'; |
402 | 410 | $type = 'raw'; |
@@ -407,8 +415,9 @@ discard block |
||
407 | 415 | { |
408 | 416 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
409 | 417 | { |
410 | - if ($match[1] != '+ ') |
|
411 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
418 | + if ($match[1] != '+ ') { |
|
419 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
420 | + } |
|
412 | 421 | $type = 'raw'; |
413 | 422 | } |
414 | 423 | } |
@@ -429,8 +438,9 @@ discard block |
||
429 | 438 | // Clear any caching? |
430 | 439 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
431 | 440 | { |
432 | - if (!is_array($members)) |
|
433 | - $members = array($members); |
|
441 | + if (!is_array($members)) { |
|
442 | + $members = array($members); |
|
443 | + } |
|
434 | 444 | |
435 | 445 | foreach ($members as $member) |
436 | 446 | { |
@@ -463,29 +473,32 @@ discard block |
||
463 | 473 | { |
464 | 474 | global $modSettings, $smcFunc; |
465 | 475 | |
466 | - if (empty($changeArray) || !is_array($changeArray)) |
|
467 | - return; |
|
476 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
477 | + return; |
|
478 | + } |
|
468 | 479 | |
469 | 480 | $toRemove = array(); |
470 | 481 | |
471 | 482 | // Go check if there is any setting to be removed. |
472 | - foreach ($changeArray as $k => $v) |
|
473 | - if ($v === null) |
|
483 | + foreach ($changeArray as $k => $v) { |
|
484 | + if ($v === null) |
|
474 | 485 | { |
475 | 486 | // Found some, remove them from the original array and add them to ours. |
476 | 487 | unset($changeArray[$k]); |
488 | + } |
|
477 | 489 | $toRemove[] = $k; |
478 | 490 | } |
479 | 491 | |
480 | 492 | // Proceed with the deletion. |
481 | - if (!empty($toRemove)) |
|
482 | - $smcFunc['db_query']('', ' |
|
493 | + if (!empty($toRemove)) { |
|
494 | + $smcFunc['db_query']('', ' |
|
483 | 495 | DELETE FROM {db_prefix}settings |
484 | 496 | WHERE variable IN ({array_string:remove})', |
485 | 497 | array( |
486 | 498 | 'remove' => $toRemove, |
487 | 499 | ) |
488 | 500 | ); |
501 | + } |
|
489 | 502 | |
490 | 503 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
491 | 504 | if ($update) |
@@ -514,19 +527,22 @@ discard block |
||
514 | 527 | foreach ($changeArray as $variable => $value) |
515 | 528 | { |
516 | 529 | // Don't bother if it's already like that ;). |
517 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
518 | - continue; |
|
530 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
531 | + continue; |
|
532 | + } |
|
519 | 533 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
520 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
521 | - continue; |
|
534 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
535 | + continue; |
|
536 | + } |
|
522 | 537 | |
523 | 538 | $replaceArray[] = array($variable, $value); |
524 | 539 | |
525 | 540 | $modSettings[$variable] = $value; |
526 | 541 | } |
527 | 542 | |
528 | - if (empty($replaceArray)) |
|
529 | - return; |
|
543 | + if (empty($replaceArray)) { |
|
544 | + return; |
|
545 | + } |
|
530 | 546 | |
531 | 547 | $smcFunc['db_insert']('replace', |
532 | 548 | '{db_prefix}settings', |
@@ -572,14 +588,17 @@ discard block |
||
572 | 588 | $start_invalid = $start < 0; |
573 | 589 | |
574 | 590 | // Make sure $start is a proper variable - not less than 0. |
575 | - if ($start_invalid) |
|
576 | - $start = 0; |
|
591 | + if ($start_invalid) { |
|
592 | + $start = 0; |
|
593 | + } |
|
577 | 594 | // Not greater than the upper bound. |
578 | - elseif ($start >= $max_value) |
|
579 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
595 | + elseif ($start >= $max_value) { |
|
596 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
597 | + } |
|
580 | 598 | // And it has to be a multiple of $num_per_page! |
581 | - else |
|
582 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
599 | + else { |
|
600 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
601 | + } |
|
583 | 602 | |
584 | 603 | $context['current_page'] = $start / $num_per_page; |
585 | 604 | |
@@ -609,77 +628,87 @@ discard block |
||
609 | 628 | |
610 | 629 | // Show all the pages. |
611 | 630 | $display_page = 1; |
612 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
613 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
631 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
632 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
633 | + } |
|
614 | 634 | |
615 | 635 | // Show the right arrow. |
616 | 636 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
617 | - if ($start != $counter - $max_value && !$start_invalid) |
|
618 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
619 | - } |
|
620 | - else |
|
637 | + if ($start != $counter - $max_value && !$start_invalid) { |
|
638 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
639 | + } |
|
640 | + } else |
|
621 | 641 | { |
622 | 642 | // If they didn't enter an odd value, pretend they did. |
623 | 643 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
624 | 644 | |
625 | 645 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
626 | - if (!empty($start) && $show_prevnext) |
|
627 | - $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
628 | - else |
|
629 | - $pageindex .= ''; |
|
646 | + if (!empty($start) && $show_prevnext) { |
|
647 | + $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
648 | + } else { |
|
649 | + $pageindex .= ''; |
|
650 | + } |
|
630 | 651 | |
631 | 652 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
632 | - if ($start > $num_per_page * $PageContiguous) |
|
633 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
653 | + if ($start > $num_per_page * $PageContiguous) { |
|
654 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
655 | + } |
|
634 | 656 | |
635 | 657 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
636 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
637 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
658 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
659 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
638 | 660 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
639 | 661 | '{FIRST_PAGE}' => $num_per_page, |
640 | 662 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
641 | 663 | '{PER_PAGE}' => $num_per_page, |
642 | 664 | )); |
665 | + } |
|
643 | 666 | |
644 | 667 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
645 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
646 | - if ($start >= $num_per_page * $nCont) |
|
668 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
669 | + if ($start >= $num_per_page * $nCont) |
|
647 | 670 | { |
648 | 671 | $tmpStart = $start - $num_per_page * $nCont; |
672 | + } |
|
649 | 673 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
650 | 674 | } |
651 | 675 | |
652 | 676 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
653 | - if (!$start_invalid) |
|
654 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
655 | - else |
|
656 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
677 | + if (!$start_invalid) { |
|
678 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
679 | + } else { |
|
680 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
681 | + } |
|
657 | 682 | |
658 | 683 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
659 | 684 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
660 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
661 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
685 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
686 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
662 | 687 | { |
663 | 688 | $tmpStart = $start + $num_per_page * $nCont; |
689 | + } |
|
664 | 690 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
665 | 691 | } |
666 | 692 | |
667 | 693 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
668 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
669 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
694 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
695 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
670 | 696 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
671 | 697 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
672 | 698 | '{LAST_PAGE}' => $tmpMaxPages, |
673 | 699 | '{PER_PAGE}' => $num_per_page, |
674 | 700 | )); |
701 | + } |
|
675 | 702 | |
676 | 703 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
677 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
678 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
704 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
705 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
706 | + } |
|
679 | 707 | |
680 | 708 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
681 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
682 | - $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
709 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
710 | + $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
711 | + } |
|
683 | 712 | } |
684 | 713 | $pageindex .= $settings['page_index']['extra_after']; |
685 | 714 | |
@@ -705,8 +734,9 @@ discard block |
||
705 | 734 | if ($decimal_separator === null) |
706 | 735 | { |
707 | 736 | // Not set for whatever reason? |
708 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
709 | - return $number; |
|
737 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
738 | + return $number; |
|
739 | + } |
|
710 | 740 | |
711 | 741 | // Cache these each load... |
712 | 742 | $thousands_separator = $matches[1]; |
@@ -740,17 +770,20 @@ discard block |
||
740 | 770 | static $unsupportedFormats, $finalizedFormats; |
741 | 771 | |
742 | 772 | // Offset the time. |
743 | - if (!$offset_type) |
|
744 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
773 | + if (!$offset_type) { |
|
774 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
775 | + } |
|
745 | 776 | // Just the forum offset? |
746 | - elseif ($offset_type == 'forum') |
|
747 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
748 | - else |
|
749 | - $time = $log_time; |
|
777 | + elseif ($offset_type == 'forum') { |
|
778 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
779 | + } else { |
|
780 | + $time = $log_time; |
|
781 | + } |
|
750 | 782 | |
751 | 783 | // We can't have a negative date (on Windows, at least.) |
752 | - if ($log_time < 0) |
|
753 | - $log_time = 0; |
|
784 | + if ($log_time < 0) { |
|
785 | + $log_time = 0; |
|
786 | + } |
|
754 | 787 | |
755 | 788 | // Today and Yesterday? |
756 | 789 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -767,24 +800,27 @@ discard block |
||
767 | 800 | { |
768 | 801 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
769 | 802 | $today_fmt = $h . ':%M' . $s . ' %p'; |
803 | + } else { |
|
804 | + $today_fmt = '%H:%M' . $s; |
|
770 | 805 | } |
771 | - else |
|
772 | - $today_fmt = '%H:%M' . $s; |
|
773 | 806 | |
774 | 807 | // Same day of the year, same year.... Today! |
775 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
776 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
808 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
809 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
810 | + } |
|
777 | 811 | |
778 | 812 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
779 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
780 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
813 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
814 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
815 | + } |
|
781 | 816 | } |
782 | 817 | |
783 | 818 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
784 | 819 | |
785 | 820 | // Use the cached formats if available |
786 | - if (is_null($finalizedFormats)) |
|
787 | - $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
821 | + if (is_null($finalizedFormats)) { |
|
822 | + $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
823 | + } |
|
788 | 824 | |
789 | 825 | // Make a supported version for this format if we don't already have one |
790 | 826 | if (empty($finalizedFormats[$str])) |
@@ -813,8 +849,9 @@ discard block |
||
813 | 849 | ); |
814 | 850 | |
815 | 851 | // No need to do this part again if we already did it once |
816 | - if (is_null($unsupportedFormats)) |
|
817 | - $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
852 | + if (is_null($unsupportedFormats)) { |
|
853 | + $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
854 | + } |
|
818 | 855 | if (empty($unsupportedFormats)) |
819 | 856 | { |
820 | 857 | foreach($strftimeFormatSubstitutions as $format => $substitution) |
@@ -823,20 +860,23 @@ discard block |
||
823 | 860 | |
824 | 861 | // Windows will return false for unsupported formats |
825 | 862 | // Other operating systems return the format string as a literal |
826 | - if ($value === false || $value === $format) |
|
827 | - $unsupportedFormats[] = $format; |
|
863 | + if ($value === false || $value === $format) { |
|
864 | + $unsupportedFormats[] = $format; |
|
865 | + } |
|
828 | 866 | } |
829 | 867 | cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400); |
830 | 868 | } |
831 | 869 | |
832 | 870 | // Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q' |
833 | - if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') |
|
834 | - $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
871 | + if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') { |
|
872 | + $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
873 | + } |
|
835 | 874 | |
836 | 875 | // Substitute unsupported formats with supported ones |
837 | - if (!empty($unsupportedFormats)) |
|
838 | - while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
876 | + if (!empty($unsupportedFormats)) { |
|
877 | + while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
839 | 878 | $timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat); |
879 | + } |
|
840 | 880 | |
841 | 881 | // Remember this so we don't need to do it again |
842 | 882 | $finalizedFormats[$str] = $timeformat; |
@@ -845,33 +885,39 @@ discard block |
||
845 | 885 | |
846 | 886 | $str = $finalizedFormats[$str]; |
847 | 887 | |
848 | - if (!isset($locale_cache)) |
|
849 | - $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
888 | + if (!isset($locale_cache)) { |
|
889 | + $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
890 | + } |
|
850 | 891 | |
851 | 892 | if ($locale_cache !== false) |
852 | 893 | { |
853 | 894 | // Check if another process changed the locale |
854 | - if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) |
|
855 | - setlocale(LC_TIME, $txt['lang_locale']); |
|
895 | + if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) { |
|
896 | + setlocale(LC_TIME, $txt['lang_locale']); |
|
897 | + } |
|
856 | 898 | |
857 | - if (!isset($non_twelve_hour)) |
|
858 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
859 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
860 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
899 | + if (!isset($non_twelve_hour)) { |
|
900 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
901 | + } |
|
902 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
903 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
904 | + } |
|
861 | 905 | |
862 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
863 | - if (strpos($str, $token) !== false) |
|
906 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
907 | + if (strpos($str, $token) !== false) |
|
864 | 908 | $str = str_replace($token, strftime($token, $time), $str); |
865 | - } |
|
866 | - else |
|
909 | + } |
|
910 | + } else |
|
867 | 911 | { |
868 | 912 | // Do-it-yourself time localization. Fun. |
869 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
870 | - if (strpos($str, $token) !== false) |
|
913 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
914 | + if (strpos($str, $token) !== false) |
|
871 | 915 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
916 | + } |
|
872 | 917 | |
873 | - if (strpos($str, '%p') !== false) |
|
874 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
918 | + if (strpos($str, '%p') !== false) { |
|
919 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
920 | + } |
|
875 | 921 | } |
876 | 922 | |
877 | 923 | // Format the time and then restore any literal percent characters |
@@ -894,16 +940,19 @@ discard block |
||
894 | 940 | static $translation = array(); |
895 | 941 | |
896 | 942 | // Determine the character set... Default to UTF-8 |
897 | - if (empty($context['character_set'])) |
|
898 | - $charset = 'UTF-8'; |
|
943 | + if (empty($context['character_set'])) { |
|
944 | + $charset = 'UTF-8'; |
|
945 | + } |
|
899 | 946 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
900 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
901 | - $charset = 'ISO-8859-1'; |
|
902 | - else |
|
903 | - $charset = $context['character_set']; |
|
947 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
948 | + $charset = 'ISO-8859-1'; |
|
949 | + } else { |
|
950 | + $charset = $context['character_set']; |
|
951 | + } |
|
904 | 952 | |
905 | - if (empty($translation)) |
|
906 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
953 | + if (empty($translation)) { |
|
954 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
955 | + } |
|
907 | 956 | |
908 | 957 | return strtr($string, $translation); |
909 | 958 | } |
@@ -925,8 +974,9 @@ discard block |
||
925 | 974 | global $smcFunc; |
926 | 975 | |
927 | 976 | // It was already short enough! |
928 | - if ($smcFunc['strlen']($subject) <= $len) |
|
929 | - return $subject; |
|
977 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
978 | + return $subject; |
|
979 | + } |
|
930 | 980 | |
931 | 981 | // Shorten it by the length it was too long, and strip off junk from the end. |
932 | 982 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -945,10 +995,11 @@ discard block |
||
945 | 995 | { |
946 | 996 | global $user_info, $modSettings; |
947 | 997 | |
948 | - if ($timestamp === null) |
|
949 | - $timestamp = time(); |
|
950 | - elseif ($timestamp == 0) |
|
951 | - return 0; |
|
998 | + if ($timestamp === null) { |
|
999 | + $timestamp = time(); |
|
1000 | + } elseif ($timestamp == 0) { |
|
1001 | + return 0; |
|
1002 | + } |
|
952 | 1003 | |
953 | 1004 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
954 | 1005 | } |
@@ -977,8 +1028,9 @@ discard block |
||
977 | 1028 | $array[$i] = $array[$j]; |
978 | 1029 | $array[$j] = $temp; |
979 | 1030 | |
980 | - for ($i = 1; $p[$i] == 0; $i++) |
|
981 | - $p[$i] = 1; |
|
1031 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
1032 | + $p[$i] = 1; |
|
1033 | + } |
|
982 | 1034 | |
983 | 1035 | $orders[] = $array; |
984 | 1036 | } |
@@ -1010,12 +1062,14 @@ discard block |
||
1010 | 1062 | static $disabled; |
1011 | 1063 | |
1012 | 1064 | // Don't waste cycles |
1013 | - if ($message === '') |
|
1014 | - return ''; |
|
1065 | + if ($message === '') { |
|
1066 | + return ''; |
|
1067 | + } |
|
1015 | 1068 | |
1016 | 1069 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
1017 | - if (!isset($context['utf8'])) |
|
1018 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1070 | + if (!isset($context['utf8'])) { |
|
1071 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1072 | + } |
|
1019 | 1073 | |
1020 | 1074 | // Clean up any cut/paste issues we may have |
1021 | 1075 | $message = sanitizeMSCutPaste($message); |
@@ -1027,13 +1081,15 @@ discard block |
||
1027 | 1081 | return $message; |
1028 | 1082 | } |
1029 | 1083 | |
1030 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
1031 | - $smileys = (bool) $smileys; |
|
1084 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
1085 | + $smileys = (bool) $smileys; |
|
1086 | + } |
|
1032 | 1087 | |
1033 | 1088 | if (empty($modSettings['enableBBC']) && $message !== false) |
1034 | 1089 | { |
1035 | - if ($smileys === true) |
|
1036 | - parsesmileys($message); |
|
1090 | + if ($smileys === true) { |
|
1091 | + parsesmileys($message); |
|
1092 | + } |
|
1037 | 1093 | |
1038 | 1094 | return $message; |
1039 | 1095 | } |
@@ -1046,8 +1102,9 @@ discard block |
||
1046 | 1102 | } |
1047 | 1103 | |
1048 | 1104 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
1049 | - if (!empty($modSettings['autoLinkUrls'])) |
|
1050 | - set_tld_regex(); |
|
1105 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
1106 | + set_tld_regex(); |
|
1107 | + } |
|
1051 | 1108 | |
1052 | 1109 | // Allow mods access before entering the main parse_bbc loop |
1053 | 1110 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1061,12 +1118,14 @@ discard block |
||
1061 | 1118 | |
1062 | 1119 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
1063 | 1120 | |
1064 | - foreach ($temp as $tag) |
|
1065 | - $disabled[trim($tag)] = true; |
|
1121 | + foreach ($temp as $tag) { |
|
1122 | + $disabled[trim($tag)] = true; |
|
1123 | + } |
|
1066 | 1124 | } |
1067 | 1125 | |
1068 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1069 | - $disabled['flash'] = true; |
|
1126 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1127 | + $disabled['flash'] = true; |
|
1128 | + } |
|
1070 | 1129 | |
1071 | 1130 | /* The following bbc are formatted as an array, with keys as follows: |
1072 | 1131 | |
@@ -1187,8 +1246,9 @@ discard block |
||
1187 | 1246 | $returnContext = ''; |
1188 | 1247 | |
1189 | 1248 | // BBC or the entire attachments feature is disabled |
1190 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
1191 | - return $data; |
|
1249 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
1250 | + return $data; |
|
1251 | + } |
|
1192 | 1252 | |
1193 | 1253 | // Save the attach ID. |
1194 | 1254 | $attachID = $data; |
@@ -1199,8 +1259,9 @@ discard block |
||
1199 | 1259 | $currentAttachment = parseAttachBBC($attachID); |
1200 | 1260 | |
1201 | 1261 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
1202 | - if (is_string($currentAttachment)) |
|
1203 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1262 | + if (is_string($currentAttachment)) { |
|
1263 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1264 | + } |
|
1204 | 1265 | |
1205 | 1266 | if (!empty($currentAttachment['is_image'])) |
1206 | 1267 | { |
@@ -1216,15 +1277,17 @@ discard block |
||
1216 | 1277 | $height = ' height="' . $currentAttachment['height'] . '"'; |
1217 | 1278 | } |
1218 | 1279 | |
1219 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
1220 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1221 | - else |
|
1222 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1280 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
1281 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1282 | + } else { |
|
1283 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1284 | + } |
|
1223 | 1285 | } |
1224 | 1286 | |
1225 | 1287 | // No image. Show a link. |
1226 | - else |
|
1227 | - $returnContext .= $currentAttachment['link']; |
|
1288 | + else { |
|
1289 | + $returnContext .= $currentAttachment['link']; |
|
1290 | + } |
|
1228 | 1291 | |
1229 | 1292 | // Gotta append what we just did. |
1230 | 1293 | $data = $returnContext; |
@@ -1255,8 +1318,9 @@ discard block |
||
1255 | 1318 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1256 | 1319 | { |
1257 | 1320 | // Do PHP code coloring? |
1258 | - if ($php_parts[$php_i] != '<?php') |
|
1259 | - continue; |
|
1321 | + if ($php_parts[$php_i] != '<?php') { |
|
1322 | + continue; |
|
1323 | + } |
|
1260 | 1324 | |
1261 | 1325 | $php_string = ''; |
1262 | 1326 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1272,8 +1336,9 @@ discard block |
||
1272 | 1336 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
1273 | 1337 | |
1274 | 1338 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1275 | - if ($context['browser']['is_opera']) |
|
1276 | - $data .= ' '; |
|
1339 | + if ($context['browser']['is_opera']) { |
|
1340 | + $data .= ' '; |
|
1341 | + } |
|
1277 | 1342 | } |
1278 | 1343 | }, |
1279 | 1344 | 'block_level' => true, |
@@ -1292,8 +1357,9 @@ discard block |
||
1292 | 1357 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1293 | 1358 | { |
1294 | 1359 | // Do PHP code coloring? |
1295 | - if ($php_parts[$php_i] != '<?php') |
|
1296 | - continue; |
|
1360 | + if ($php_parts[$php_i] != '<?php') { |
|
1361 | + continue; |
|
1362 | + } |
|
1297 | 1363 | |
1298 | 1364 | $php_string = ''; |
1299 | 1365 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1309,8 +1375,9 @@ discard block |
||
1309 | 1375 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
1310 | 1376 | |
1311 | 1377 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1312 | - if ($context['browser']['is_opera']) |
|
1313 | - $data[0] .= ' '; |
|
1378 | + if ($context['browser']['is_opera']) { |
|
1379 | + $data[0] .= ' '; |
|
1380 | + } |
|
1314 | 1381 | } |
1315 | 1382 | }, |
1316 | 1383 | 'block_level' => true, |
@@ -1348,11 +1415,13 @@ discard block |
||
1348 | 1415 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1349 | 1416 | 'validate' => function (&$tag, &$data, $disabled) |
1350 | 1417 | { |
1351 | - if (isset($disabled['url'])) |
|
1352 | - $tag['content'] = '$1'; |
|
1418 | + if (isset($disabled['url'])) { |
|
1419 | + $tag['content'] = '$1'; |
|
1420 | + } |
|
1353 | 1421 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
1354 | - if (empty($scheme)) |
|
1355 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
1422 | + if (empty($scheme)) { |
|
1423 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
1424 | + } |
|
1356 | 1425 | }, |
1357 | 1426 | 'disabled_content' => '<a href="$1" target="_blank">$1</a>', |
1358 | 1427 | ), |
@@ -1366,10 +1435,11 @@ discard block |
||
1366 | 1435 | { |
1367 | 1436 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1368 | 1437 | |
1369 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
1370 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1371 | - else |
|
1372 | - $css = ''; |
|
1438 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
1439 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1440 | + } else { |
|
1441 | + $css = ''; |
|
1442 | + } |
|
1373 | 1443 | |
1374 | 1444 | $data = $class . $css; |
1375 | 1445 | }, |
@@ -1419,14 +1489,16 @@ discard block |
||
1419 | 1489 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1420 | 1490 | if ($image_proxy_enabled) |
1421 | 1491 | { |
1422 | - if (empty($scheme)) |
|
1423 | - $data = 'http://' . ltrim($data, ':/'); |
|
1492 | + if (empty($scheme)) { |
|
1493 | + $data = 'http://' . ltrim($data, ':/'); |
|
1494 | + } |
|
1424 | 1495 | |
1425 | - if ($scheme != 'https') |
|
1426 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1496 | + if ($scheme != 'https') { |
|
1497 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1498 | + } |
|
1499 | + } elseif (empty($scheme)) { |
|
1500 | + $data = '//' . ltrim($data, ':/'); |
|
1427 | 1501 | } |
1428 | - elseif (empty($scheme)) |
|
1429 | - $data = '//' . ltrim($data, ':/'); |
|
1430 | 1502 | }, |
1431 | 1503 | 'disabled_content' => '($1)', |
1432 | 1504 | ), |
@@ -1442,14 +1514,16 @@ discard block |
||
1442 | 1514 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1443 | 1515 | if ($image_proxy_enabled) |
1444 | 1516 | { |
1445 | - if (empty($scheme)) |
|
1446 | - $data = 'http://' . ltrim($data, ':/'); |
|
1517 | + if (empty($scheme)) { |
|
1518 | + $data = 'http://' . ltrim($data, ':/'); |
|
1519 | + } |
|
1447 | 1520 | |
1448 | - if ($scheme != 'https') |
|
1449 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1521 | + if ($scheme != 'https') { |
|
1522 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1523 | + } |
|
1524 | + } elseif (empty($scheme)) { |
|
1525 | + $data = '//' . ltrim($data, ':/'); |
|
1450 | 1526 | } |
1451 | - elseif (empty($scheme)) |
|
1452 | - $data = '//' . ltrim($data, ':/'); |
|
1453 | 1527 | }, |
1454 | 1528 | 'disabled_content' => '($1)', |
1455 | 1529 | ), |
@@ -1461,8 +1535,9 @@ discard block |
||
1461 | 1535 | { |
1462 | 1536 | $data = strtr($data, array('<br>' => '')); |
1463 | 1537 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1464 | - if (empty($scheme)) |
|
1465 | - $data = '//' . ltrim($data, ':/'); |
|
1538 | + if (empty($scheme)) { |
|
1539 | + $data = '//' . ltrim($data, ':/'); |
|
1540 | + } |
|
1466 | 1541 | }, |
1467 | 1542 | ), |
1468 | 1543 | array( |
@@ -1473,13 +1548,14 @@ discard block |
||
1473 | 1548 | 'after' => '</a>', |
1474 | 1549 | 'validate' => function (&$tag, &$data, $disabled) |
1475 | 1550 | { |
1476 | - if (substr($data, 0, 1) == '#') |
|
1477 | - $data = '#post_' . substr($data, 1); |
|
1478 | - else |
|
1551 | + if (substr($data, 0, 1) == '#') { |
|
1552 | + $data = '#post_' . substr($data, 1); |
|
1553 | + } else |
|
1479 | 1554 | { |
1480 | 1555 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1481 | - if (empty($scheme)) |
|
1482 | - $data = '//' . ltrim($data, ':/'); |
|
1556 | + if (empty($scheme)) { |
|
1557 | + $data = '//' . ltrim($data, ':/'); |
|
1558 | + } |
|
1483 | 1559 | } |
1484 | 1560 | }, |
1485 | 1561 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1557,8 +1633,9 @@ discard block |
||
1557 | 1633 | { |
1558 | 1634 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
1559 | 1635 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
1560 | - if ($add_begin) |
|
1561 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1636 | + if ($add_begin) { |
|
1637 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1638 | + } |
|
1562 | 1639 | } |
1563 | 1640 | }, |
1564 | 1641 | 'block_level' => false, |
@@ -1689,10 +1766,11 @@ discard block |
||
1689 | 1766 | 'content' => '$1', |
1690 | 1767 | 'validate' => function (&$tag, &$data, $disabled) |
1691 | 1768 | { |
1692 | - if (is_numeric($data)) |
|
1693 | - $data = timeformat($data); |
|
1694 | - else |
|
1695 | - $tag['content'] = '[time]$1[/time]'; |
|
1769 | + if (is_numeric($data)) { |
|
1770 | + $data = timeformat($data); |
|
1771 | + } else { |
|
1772 | + $tag['content'] = '[time]$1[/time]'; |
|
1773 | + } |
|
1696 | 1774 | }, |
1697 | 1775 | ), |
1698 | 1776 | array( |
@@ -1719,8 +1797,9 @@ discard block |
||
1719 | 1797 | { |
1720 | 1798 | $data = strtr($data, array('<br>' => '')); |
1721 | 1799 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1722 | - if (empty($scheme)) |
|
1723 | - $data = '//' . ltrim($data, ':/'); |
|
1800 | + if (empty($scheme)) { |
|
1801 | + $data = '//' . ltrim($data, ':/'); |
|
1802 | + } |
|
1724 | 1803 | }, |
1725 | 1804 | ), |
1726 | 1805 | array( |
@@ -1732,8 +1811,9 @@ discard block |
||
1732 | 1811 | 'validate' => function (&$tag, &$data, $disabled) |
1733 | 1812 | { |
1734 | 1813 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1735 | - if (empty($scheme)) |
|
1736 | - $data = '//' . ltrim($data, ':/'); |
|
1814 | + if (empty($scheme)) { |
|
1815 | + $data = '//' . ltrim($data, ':/'); |
|
1816 | + } |
|
1737 | 1817 | }, |
1738 | 1818 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
1739 | 1819 | 'disabled_after' => ' ($1)', |
@@ -1753,8 +1833,9 @@ discard block |
||
1753 | 1833 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
1754 | 1834 | if ($message === false) |
1755 | 1835 | { |
1756 | - if (isset($temp_bbc)) |
|
1757 | - $bbc_codes = $temp_bbc; |
|
1836 | + if (isset($temp_bbc)) { |
|
1837 | + $bbc_codes = $temp_bbc; |
|
1838 | + } |
|
1758 | 1839 | usort($codes, function ($a, $b) { |
1759 | 1840 | return strcmp($a['tag'], $b['tag']); |
1760 | 1841 | }); |
@@ -1774,8 +1855,9 @@ discard block |
||
1774 | 1855 | ); |
1775 | 1856 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
1776 | 1857 | { |
1777 | - foreach ($itemcodes as $c => $dummy) |
|
1778 | - $bbc_codes[$c] = array(); |
|
1858 | + foreach ($itemcodes as $c => $dummy) { |
|
1859 | + $bbc_codes[$c] = array(); |
|
1860 | + } |
|
1779 | 1861 | } |
1780 | 1862 | |
1781 | 1863 | // Shhhh! |
@@ -1796,12 +1878,14 @@ discard block |
||
1796 | 1878 | foreach ($codes as $code) |
1797 | 1879 | { |
1798 | 1880 | // Make it easier to process parameters later |
1799 | - if (!empty($code['parameters'])) |
|
1800 | - ksort($code['parameters'], SORT_STRING); |
|
1881 | + if (!empty($code['parameters'])) { |
|
1882 | + ksort($code['parameters'], SORT_STRING); |
|
1883 | + } |
|
1801 | 1884 | |
1802 | 1885 | // If we are not doing every tag only do ones we are interested in. |
1803 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
1804 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1886 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
1887 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1888 | + } |
|
1805 | 1889 | } |
1806 | 1890 | $codes = null; |
1807 | 1891 | } |
@@ -1812,8 +1896,9 @@ discard block |
||
1812 | 1896 | // It's likely this will change if the message is modified. |
1813 | 1897 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
1814 | 1898 | |
1815 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
1816 | - return $temp; |
|
1899 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
1900 | + return $temp; |
|
1901 | + } |
|
1817 | 1902 | |
1818 | 1903 | $cache_t = microtime(); |
1819 | 1904 | } |
@@ -1845,8 +1930,9 @@ discard block |
||
1845 | 1930 | $disabled['flash'] = true; |
1846 | 1931 | |
1847 | 1932 | // @todo Change maybe? |
1848 | - if (!isset($_GET['images'])) |
|
1849 | - $disabled['img'] = true; |
|
1933 | + if (!isset($_GET['images'])) { |
|
1934 | + $disabled['img'] = true; |
|
1935 | + } |
|
1850 | 1936 | |
1851 | 1937 | // @todo Interface/setting to add more? |
1852 | 1938 | } |
@@ -1870,8 +1956,9 @@ discard block |
||
1870 | 1956 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
1871 | 1957 | |
1872 | 1958 | // Failsafe. |
1873 | - if ($pos === false || $last_pos > $pos) |
|
1874 | - $pos = strlen($message) + 1; |
|
1959 | + if ($pos === false || $last_pos > $pos) { |
|
1960 | + $pos = strlen($message) + 1; |
|
1961 | + } |
|
1875 | 1962 | |
1876 | 1963 | // Can't have a one letter smiley, URL, or email! (sorry.) |
1877 | 1964 | if ($last_pos < $pos - 1) |
@@ -1889,8 +1976,9 @@ discard block |
||
1889 | 1976 | |
1890 | 1977 | // <br> should be empty. |
1891 | 1978 | $empty_tags = array('br', 'hr'); |
1892 | - foreach ($empty_tags as $tag) |
|
1893 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1979 | + foreach ($empty_tags as $tag) { |
|
1980 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1981 | + } |
|
1894 | 1982 | |
1895 | 1983 | // b, u, i, s, pre... basic tags. |
1896 | 1984 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong'); |
@@ -1899,8 +1987,9 @@ discard block |
||
1899 | 1987 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
1900 | 1988 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
1901 | 1989 | |
1902 | - if ($diff > 0) |
|
1903 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1990 | + if ($diff > 0) { |
|
1991 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1992 | + } |
|
1904 | 1993 | } |
1905 | 1994 | |
1906 | 1995 | // Do <img ...> - with security... action= -> action-. |
@@ -1913,8 +2002,9 @@ discard block |
||
1913 | 2002 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
1914 | 2003 | |
1915 | 2004 | // Remove action= from the URL - no funny business, now. |
1916 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
1917 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2005 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
2006 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2007 | + } |
|
1918 | 2008 | |
1919 | 2009 | // Check if the image is larger than allowed. |
1920 | 2010 | if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height'])) |
@@ -1935,9 +2025,9 @@ discard block |
||
1935 | 2025 | |
1936 | 2026 | // Set the new image tag. |
1937 | 2027 | $replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]'; |
2028 | + } else { |
|
2029 | + $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1938 | 2030 | } |
1939 | - else |
|
1940 | - $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1941 | 2031 | } |
1942 | 2032 | |
1943 | 2033 | $data = strtr($data, $replaces); |
@@ -1950,16 +2040,18 @@ discard block |
||
1950 | 2040 | $no_autolink_area = false; |
1951 | 2041 | if (!empty($open_tags)) |
1952 | 2042 | { |
1953 | - foreach ($open_tags as $open_tag) |
|
1954 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
2043 | + foreach ($open_tags as $open_tag) { |
|
2044 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
1955 | 2045 | $no_autolink_area = true; |
2046 | + } |
|
1956 | 2047 | } |
1957 | 2048 | |
1958 | 2049 | // Don't go backwards. |
1959 | 2050 | // @todo Don't think is the real solution.... |
1960 | 2051 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
1961 | - if ($pos < $lastAutoPos) |
|
1962 | - $no_autolink_area = true; |
|
2052 | + if ($pos < $lastAutoPos) { |
|
2053 | + $no_autolink_area = true; |
|
2054 | + } |
|
1963 | 2055 | $lastAutoPos = $pos; |
1964 | 2056 | |
1965 | 2057 | if (!$no_autolink_area) |
@@ -2068,17 +2160,19 @@ discard block |
||
2068 | 2160 | if ($scheme == 'mailto') |
2069 | 2161 | { |
2070 | 2162 | $email_address = str_replace('mailto:', '', $url); |
2071 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
2072 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2073 | - else |
|
2074 | - return $url; |
|
2163 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
2164 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2165 | + } else { |
|
2166 | + return $url; |
|
2167 | + } |
|
2075 | 2168 | } |
2076 | 2169 | |
2077 | 2170 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
2078 | - if (empty($scheme)) |
|
2079 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
2080 | - else |
|
2081 | - $fullUrl = $url; |
|
2171 | + if (empty($scheme)) { |
|
2172 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
2173 | + } else { |
|
2174 | + $fullUrl = $url; |
|
2175 | + } |
|
2082 | 2176 | |
2083 | 2177 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
2084 | 2178 | }, $data); |
@@ -2127,16 +2221,18 @@ discard block |
||
2127 | 2221 | } |
2128 | 2222 | |
2129 | 2223 | // Are we there yet? Are we there yet? |
2130 | - if ($pos >= strlen($message) - 1) |
|
2131 | - break; |
|
2224 | + if ($pos >= strlen($message) - 1) { |
|
2225 | + break; |
|
2226 | + } |
|
2132 | 2227 | |
2133 | 2228 | $tags = strtolower($message[$pos + 1]); |
2134 | 2229 | |
2135 | 2230 | if ($tags == '/' && !empty($open_tags)) |
2136 | 2231 | { |
2137 | 2232 | $pos2 = strpos($message, ']', $pos + 1); |
2138 | - if ($pos2 == $pos + 2) |
|
2139 | - continue; |
|
2233 | + if ($pos2 == $pos + 2) { |
|
2234 | + continue; |
|
2235 | + } |
|
2140 | 2236 | |
2141 | 2237 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
2142 | 2238 | |
@@ -2146,8 +2242,9 @@ discard block |
||
2146 | 2242 | do |
2147 | 2243 | { |
2148 | 2244 | $tag = array_pop($open_tags); |
2149 | - if (!$tag) |
|
2150 | - break; |
|
2245 | + if (!$tag) { |
|
2246 | + break; |
|
2247 | + } |
|
2151 | 2248 | |
2152 | 2249 | if (!empty($tag['block_level'])) |
2153 | 2250 | { |
@@ -2161,10 +2258,11 @@ discard block |
||
2161 | 2258 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
2162 | 2259 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
2163 | 2260 | { |
2164 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2165 | - if ($temp['tag'] == $look_for) |
|
2261 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2262 | + if ($temp['tag'] == $look_for) |
|
2166 | 2263 | { |
2167 | 2264 | $block_level = !empty($temp['block_level']); |
2265 | + } |
|
2168 | 2266 | break; |
2169 | 2267 | } |
2170 | 2268 | } |
@@ -2186,15 +2284,15 @@ discard block |
||
2186 | 2284 | { |
2187 | 2285 | $open_tags = $to_close; |
2188 | 2286 | continue; |
2189 | - } |
|
2190 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2287 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2191 | 2288 | { |
2192 | 2289 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
2193 | 2290 | { |
2194 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2195 | - if ($temp['tag'] == $look_for) |
|
2291 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2292 | + if ($temp['tag'] == $look_for) |
|
2196 | 2293 | { |
2197 | 2294 | $block_level = !empty($temp['block_level']); |
2295 | + } |
|
2198 | 2296 | break; |
2199 | 2297 | } |
2200 | 2298 | } |
@@ -2202,8 +2300,9 @@ discard block |
||
2202 | 2300 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
2203 | 2301 | if (!$block_level) |
2204 | 2302 | { |
2205 | - foreach ($to_close as $tag) |
|
2206 | - array_push($open_tags, $tag); |
|
2303 | + foreach ($to_close as $tag) { |
|
2304 | + array_push($open_tags, $tag); |
|
2305 | + } |
|
2207 | 2306 | continue; |
2208 | 2307 | } |
2209 | 2308 | } |
@@ -2216,14 +2315,17 @@ discard block |
||
2216 | 2315 | |
2217 | 2316 | // See the comment at the end of the big loop - just eating whitespace ;). |
2218 | 2317 | $whitespace_regex = ''; |
2219 | - if (!empty($tag['block_level'])) |
|
2220 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2318 | + if (!empty($tag['block_level'])) { |
|
2319 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2320 | + } |
|
2221 | 2321 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
2222 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2223 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2322 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2323 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2324 | + } |
|
2224 | 2325 | |
2225 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2226 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2326 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2327 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2328 | + } |
|
2227 | 2329 | } |
2228 | 2330 | |
2229 | 2331 | if (!empty($to_close)) |
@@ -2236,8 +2338,9 @@ discard block |
||
2236 | 2338 | } |
2237 | 2339 | |
2238 | 2340 | // No tags for this character, so just keep going (fastest possible course.) |
2239 | - if (!isset($bbc_codes[$tags])) |
|
2240 | - continue; |
|
2341 | + if (!isset($bbc_codes[$tags])) { |
|
2342 | + continue; |
|
2343 | + } |
|
2241 | 2344 | |
2242 | 2345 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
2243 | 2346 | $tag = null; |
@@ -2246,44 +2349,52 @@ discard block |
||
2246 | 2349 | $pt_strlen = strlen($possible['tag']); |
2247 | 2350 | |
2248 | 2351 | // Not a match? |
2249 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
2250 | - continue; |
|
2352 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
2353 | + continue; |
|
2354 | + } |
|
2251 | 2355 | |
2252 | 2356 | $next_c = $message[$pos + 1 + $pt_strlen]; |
2253 | 2357 | |
2254 | 2358 | // A test validation? |
2255 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
2256 | - continue; |
|
2359 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
2360 | + continue; |
|
2361 | + } |
|
2257 | 2362 | // Do we want parameters? |
2258 | 2363 | elseif (!empty($possible['parameters'])) |
2259 | 2364 | { |
2260 | - if ($next_c != ' ') |
|
2261 | - continue; |
|
2262 | - } |
|
2263 | - elseif (isset($possible['type'])) |
|
2365 | + if ($next_c != ' ') { |
|
2366 | + continue; |
|
2367 | + } |
|
2368 | + } elseif (isset($possible['type'])) |
|
2264 | 2369 | { |
2265 | 2370 | // Do we need an equal sign? |
2266 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
2267 | - continue; |
|
2371 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
2372 | + continue; |
|
2373 | + } |
|
2268 | 2374 | // Maybe we just want a /... |
2269 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
2270 | - continue; |
|
2375 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
2376 | + continue; |
|
2377 | + } |
|
2271 | 2378 | // An immediate ]? |
2272 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
2273 | - continue; |
|
2379 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
2380 | + continue; |
|
2381 | + } |
|
2274 | 2382 | } |
2275 | 2383 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
2276 | - elseif ($next_c != ']') |
|
2277 | - continue; |
|
2384 | + elseif ($next_c != ']') { |
|
2385 | + continue; |
|
2386 | + } |
|
2278 | 2387 | |
2279 | 2388 | // Check allowed tree? |
2280 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
2281 | - continue; |
|
2282 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
2283 | - continue; |
|
2389 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
2390 | + continue; |
|
2391 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
2392 | + continue; |
|
2393 | + } |
|
2284 | 2394 | // If this is in the list of disallowed child tags, don't parse it. |
2285 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
2286 | - continue; |
|
2395 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
2396 | + continue; |
|
2397 | + } |
|
2287 | 2398 | |
2288 | 2399 | $pos1 = $pos + 1 + $pt_strlen + 1; |
2289 | 2400 | |
@@ -2295,8 +2406,9 @@ discard block |
||
2295 | 2406 | foreach ($open_tags as $open_quote) |
2296 | 2407 | { |
2297 | 2408 | // Every parent quote this quote has flips the styling |
2298 | - if ($open_quote['tag'] == 'quote') |
|
2299 | - $quote_alt = !$quote_alt; |
|
2409 | + if ($open_quote['tag'] == 'quote') { |
|
2410 | + $quote_alt = !$quote_alt; |
|
2411 | + } |
|
2300 | 2412 | } |
2301 | 2413 | // Add a class to the quote to style alternating blockquotes |
2302 | 2414 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2307,8 +2419,9 @@ discard block |
||
2307 | 2419 | { |
2308 | 2420 | // Build a regular expression for each parameter for the current tag. |
2309 | 2421 | $preg = array(); |
2310 | - foreach ($possible['parameters'] as $p => $info) |
|
2311 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2422 | + foreach ($possible['parameters'] as $p => $info) { |
|
2423 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2424 | + } |
|
2312 | 2425 | |
2313 | 2426 | // Extract the string that potentially holds our parameters. |
2314 | 2427 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2328,24 +2441,27 @@ discard block |
||
2328 | 2441 | |
2329 | 2442 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
2330 | 2443 | |
2331 | - if ($match) |
|
2332 | - $blob_counter = count($blobs) + 1; |
|
2444 | + if ($match) { |
|
2445 | + $blob_counter = count($blobs) + 1; |
|
2446 | + } |
|
2333 | 2447 | } |
2334 | 2448 | |
2335 | 2449 | // Didn't match our parameter list, try the next possible. |
2336 | - if (!$match) |
|
2337 | - continue; |
|
2450 | + if (!$match) { |
|
2451 | + continue; |
|
2452 | + } |
|
2338 | 2453 | |
2339 | 2454 | $params = array(); |
2340 | 2455 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
2341 | 2456 | { |
2342 | 2457 | $key = strtok(ltrim($matches[$i]), '='); |
2343 | - if (isset($possible['parameters'][$key]['value'])) |
|
2344 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2345 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
2346 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2347 | - else |
|
2348 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2458 | + if (isset($possible['parameters'][$key]['value'])) { |
|
2459 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2460 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
2461 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2462 | + } else { |
|
2463 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2464 | + } |
|
2349 | 2465 | |
2350 | 2466 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
2351 | 2467 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2353,23 +2469,26 @@ discard block |
||
2353 | 2469 | |
2354 | 2470 | foreach ($possible['parameters'] as $p => $info) |
2355 | 2471 | { |
2356 | - if (!isset($params['{' . $p . '}'])) |
|
2357 | - $params['{' . $p . '}'] = ''; |
|
2472 | + if (!isset($params['{' . $p . '}'])) { |
|
2473 | + $params['{' . $p . '}'] = ''; |
|
2474 | + } |
|
2358 | 2475 | } |
2359 | 2476 | |
2360 | 2477 | $tag = $possible; |
2361 | 2478 | |
2362 | 2479 | // Put the parameters into the string. |
2363 | - if (isset($tag['before'])) |
|
2364 | - $tag['before'] = strtr($tag['before'], $params); |
|
2365 | - if (isset($tag['after'])) |
|
2366 | - $tag['after'] = strtr($tag['after'], $params); |
|
2367 | - if (isset($tag['content'])) |
|
2368 | - $tag['content'] = strtr($tag['content'], $params); |
|
2480 | + if (isset($tag['before'])) { |
|
2481 | + $tag['before'] = strtr($tag['before'], $params); |
|
2482 | + } |
|
2483 | + if (isset($tag['after'])) { |
|
2484 | + $tag['after'] = strtr($tag['after'], $params); |
|
2485 | + } |
|
2486 | + if (isset($tag['content'])) { |
|
2487 | + $tag['content'] = strtr($tag['content'], $params); |
|
2488 | + } |
|
2369 | 2489 | |
2370 | 2490 | $pos1 += strlen($given_param_string); |
2371 | - } |
|
2372 | - else |
|
2491 | + } else |
|
2373 | 2492 | { |
2374 | 2493 | $tag = $possible; |
2375 | 2494 | $params = array(); |
@@ -2380,8 +2499,9 @@ discard block |
||
2380 | 2499 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
2381 | 2500 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
2382 | 2501 | { |
2383 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
2384 | - continue; |
|
2502 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
2503 | + continue; |
|
2504 | + } |
|
2385 | 2505 | |
2386 | 2506 | $tag = $itemcodes[$message[$pos + 1]]; |
2387 | 2507 | |
@@ -2402,9 +2522,9 @@ discard block |
||
2402 | 2522 | { |
2403 | 2523 | array_pop($open_tags); |
2404 | 2524 | $code = '</li>'; |
2525 | + } else { |
|
2526 | + $code = ''; |
|
2405 | 2527 | } |
2406 | - else |
|
2407 | - $code = ''; |
|
2408 | 2528 | |
2409 | 2529 | // Now we open a new tag. |
2410 | 2530 | $open_tags[] = array( |
@@ -2451,12 +2571,14 @@ discard block |
||
2451 | 2571 | } |
2452 | 2572 | |
2453 | 2573 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
2454 | - if ($tag === null) |
|
2455 | - continue; |
|
2574 | + if ($tag === null) { |
|
2575 | + continue; |
|
2576 | + } |
|
2456 | 2577 | |
2457 | 2578 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
2458 | - if (isset($inside['disallow_children'])) |
|
2459 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2579 | + if (isset($inside['disallow_children'])) { |
|
2580 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2581 | + } |
|
2460 | 2582 | |
2461 | 2583 | // Is this tag disabled? |
2462 | 2584 | if (isset($disabled[$tag['tag']])) |
@@ -2466,14 +2588,13 @@ discard block |
||
2466 | 2588 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
2467 | 2589 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
2468 | 2590 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
2469 | - } |
|
2470 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2591 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2471 | 2592 | { |
2472 | 2593 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
2473 | 2594 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
2595 | + } else { |
|
2596 | + $tag['content'] = $tag['disabled_content']; |
|
2474 | 2597 | } |
2475 | - else |
|
2476 | - $tag['content'] = $tag['disabled_content']; |
|
2477 | 2598 | } |
2478 | 2599 | |
2479 | 2600 | // we use this a lot |
@@ -2483,8 +2604,9 @@ discard block |
||
2483 | 2604 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
2484 | 2605 | { |
2485 | 2606 | $n = count($open_tags) - 1; |
2486 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
2487 | - $n--; |
|
2607 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
2608 | + $n--; |
|
2609 | + } |
|
2488 | 2610 | |
2489 | 2611 | // Close all the non block level tags so this tag isn't surrounded by them. |
2490 | 2612 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2496,12 +2618,15 @@ discard block |
||
2496 | 2618 | |
2497 | 2619 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
2498 | 2620 | $whitespace_regex = ''; |
2499 | - if (!empty($tag['block_level'])) |
|
2500 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2501 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2502 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2503 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2504 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2621 | + if (!empty($tag['block_level'])) { |
|
2622 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2623 | + } |
|
2624 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2625 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2626 | + } |
|
2627 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2628 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2629 | + } |
|
2505 | 2630 | |
2506 | 2631 | array_pop($open_tags); |
2507 | 2632 | } |
@@ -2522,16 +2647,19 @@ discard block |
||
2522 | 2647 | elseif ($tag['type'] == 'unparsed_content') |
2523 | 2648 | { |
2524 | 2649 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
2525 | - if ($pos2 === false) |
|
2526 | - continue; |
|
2650 | + if ($pos2 === false) { |
|
2651 | + continue; |
|
2652 | + } |
|
2527 | 2653 | |
2528 | 2654 | $data = substr($message, $pos1, $pos2 - $pos1); |
2529 | 2655 | |
2530 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
2531 | - $data = substr($data, 4); |
|
2656 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
2657 | + $data = substr($data, 4); |
|
2658 | + } |
|
2532 | 2659 | |
2533 | - if (isset($tag['validate'])) |
|
2534 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2660 | + if (isset($tag['validate'])) { |
|
2661 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2662 | + } |
|
2535 | 2663 | |
2536 | 2664 | $code = strtr($tag['content'], array('$1' => $data)); |
2537 | 2665 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2547,34 +2675,40 @@ discard block |
||
2547 | 2675 | if (isset($tag['quoted'])) |
2548 | 2676 | { |
2549 | 2677 | $quoted = substr($message, $pos1, 6) == '"'; |
2550 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2551 | - continue; |
|
2678 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2679 | + continue; |
|
2680 | + } |
|
2552 | 2681 | |
2553 | - if ($quoted) |
|
2554 | - $pos1 += 6; |
|
2682 | + if ($quoted) { |
|
2683 | + $pos1 += 6; |
|
2684 | + } |
|
2685 | + } else { |
|
2686 | + $quoted = false; |
|
2555 | 2687 | } |
2556 | - else |
|
2557 | - $quoted = false; |
|
2558 | 2688 | |
2559 | 2689 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2560 | - if ($pos2 === false) |
|
2561 | - continue; |
|
2690 | + if ($pos2 === false) { |
|
2691 | + continue; |
|
2692 | + } |
|
2562 | 2693 | |
2563 | 2694 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2564 | - if ($pos3 === false) |
|
2565 | - continue; |
|
2695 | + if ($pos3 === false) { |
|
2696 | + continue; |
|
2697 | + } |
|
2566 | 2698 | |
2567 | 2699 | $data = array( |
2568 | 2700 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
2569 | 2701 | substr($message, $pos1, $pos2 - $pos1) |
2570 | 2702 | ); |
2571 | 2703 | |
2572 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
2573 | - $data[0] = substr($data[0], 4); |
|
2704 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
2705 | + $data[0] = substr($data[0], 4); |
|
2706 | + } |
|
2574 | 2707 | |
2575 | 2708 | // Validation for my parking, please! |
2576 | - if (isset($tag['validate'])) |
|
2577 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2709 | + if (isset($tag['validate'])) { |
|
2710 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2711 | + } |
|
2578 | 2712 | |
2579 | 2713 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
2580 | 2714 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2591,23 +2725,27 @@ discard block |
||
2591 | 2725 | elseif ($tag['type'] == 'unparsed_commas_content') |
2592 | 2726 | { |
2593 | 2727 | $pos2 = strpos($message, ']', $pos1); |
2594 | - if ($pos2 === false) |
|
2595 | - continue; |
|
2728 | + if ($pos2 === false) { |
|
2729 | + continue; |
|
2730 | + } |
|
2596 | 2731 | |
2597 | 2732 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2598 | - if ($pos3 === false) |
|
2599 | - continue; |
|
2733 | + if ($pos3 === false) { |
|
2734 | + continue; |
|
2735 | + } |
|
2600 | 2736 | |
2601 | 2737 | // We want $1 to be the content, and the rest to be csv. |
2602 | 2738 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
2603 | 2739 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
2604 | 2740 | |
2605 | - if (isset($tag['validate'])) |
|
2606 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2741 | + if (isset($tag['validate'])) { |
|
2742 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2743 | + } |
|
2607 | 2744 | |
2608 | 2745 | $code = $tag['content']; |
2609 | - foreach ($data as $k => $d) |
|
2610 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2746 | + foreach ($data as $k => $d) { |
|
2747 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2748 | + } |
|
2611 | 2749 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
2612 | 2750 | $pos += strlen($code) - 1 + 2; |
2613 | 2751 | } |
@@ -2615,24 +2753,28 @@ discard block |
||
2615 | 2753 | elseif ($tag['type'] == 'unparsed_commas') |
2616 | 2754 | { |
2617 | 2755 | $pos2 = strpos($message, ']', $pos1); |
2618 | - if ($pos2 === false) |
|
2619 | - continue; |
|
2756 | + if ($pos2 === false) { |
|
2757 | + continue; |
|
2758 | + } |
|
2620 | 2759 | |
2621 | 2760 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
2622 | 2761 | |
2623 | - if (isset($tag['validate'])) |
|
2624 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2762 | + if (isset($tag['validate'])) { |
|
2763 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2764 | + } |
|
2625 | 2765 | |
2626 | 2766 | // Fix after, for disabled code mainly. |
2627 | - foreach ($data as $k => $d) |
|
2628 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2767 | + foreach ($data as $k => $d) { |
|
2768 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2769 | + } |
|
2629 | 2770 | |
2630 | 2771 | $open_tags[] = $tag; |
2631 | 2772 | |
2632 | 2773 | // Replace them out, $1, $2, $3, $4, etc. |
2633 | 2774 | $code = $tag['before']; |
2634 | - foreach ($data as $k => $d) |
|
2635 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2775 | + foreach ($data as $k => $d) { |
|
2776 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2777 | + } |
|
2636 | 2778 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
2637 | 2779 | $pos += strlen($code) - 1 + 2; |
2638 | 2780 | } |
@@ -2643,28 +2785,33 @@ discard block |
||
2643 | 2785 | if (isset($tag['quoted'])) |
2644 | 2786 | { |
2645 | 2787 | $quoted = substr($message, $pos1, 6) == '"'; |
2646 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2647 | - continue; |
|
2788 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2789 | + continue; |
|
2790 | + } |
|
2648 | 2791 | |
2649 | - if ($quoted) |
|
2650 | - $pos1 += 6; |
|
2792 | + if ($quoted) { |
|
2793 | + $pos1 += 6; |
|
2794 | + } |
|
2795 | + } else { |
|
2796 | + $quoted = false; |
|
2651 | 2797 | } |
2652 | - else |
|
2653 | - $quoted = false; |
|
2654 | 2798 | |
2655 | 2799 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2656 | - if ($pos2 === false) |
|
2657 | - continue; |
|
2800 | + if ($pos2 === false) { |
|
2801 | + continue; |
|
2802 | + } |
|
2658 | 2803 | |
2659 | 2804 | $data = substr($message, $pos1, $pos2 - $pos1); |
2660 | 2805 | |
2661 | 2806 | // Validation for my parking, please! |
2662 | - if (isset($tag['validate'])) |
|
2663 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2807 | + if (isset($tag['validate'])) { |
|
2808 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2809 | + } |
|
2664 | 2810 | |
2665 | 2811 | // For parsed content, we must recurse to avoid security problems. |
2666 | - if ($tag['type'] != 'unparsed_equals') |
|
2667 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2812 | + if ($tag['type'] != 'unparsed_equals') { |
|
2813 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2814 | + } |
|
2668 | 2815 | |
2669 | 2816 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
2670 | 2817 | |
@@ -2676,34 +2823,40 @@ discard block |
||
2676 | 2823 | } |
2677 | 2824 | |
2678 | 2825 | // If this is block level, eat any breaks after it. |
2679 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
2680 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2826 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
2827 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2828 | + } |
|
2681 | 2829 | |
2682 | 2830 | // Are we trimming outside this tag? |
2683 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
2684 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2831 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
2832 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2833 | + } |
|
2685 | 2834 | } |
2686 | 2835 | |
2687 | 2836 | // Close any remaining tags. |
2688 | - while ($tag = array_pop($open_tags)) |
|
2689 | - $message .= "\n" . $tag['after'] . "\n"; |
|
2837 | + while ($tag = array_pop($open_tags)) { |
|
2838 | + $message .= "\n" . $tag['after'] . "\n"; |
|
2839 | + } |
|
2690 | 2840 | |
2691 | 2841 | // Parse the smileys within the parts where it can be done safely. |
2692 | 2842 | if ($smileys === true) |
2693 | 2843 | { |
2694 | 2844 | $message_parts = explode("\n", $message); |
2695 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
2696 | - parsesmileys($message_parts[$i]); |
|
2845 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
2846 | + parsesmileys($message_parts[$i]); |
|
2847 | + } |
|
2697 | 2848 | |
2698 | 2849 | $message = implode('', $message_parts); |
2699 | 2850 | } |
2700 | 2851 | |
2701 | 2852 | // No smileys, just get rid of the markers. |
2702 | - else |
|
2703 | - $message = strtr($message, array("\n" => '')); |
|
2853 | + else { |
|
2854 | + $message = strtr($message, array("\n" => '')); |
|
2855 | + } |
|
2704 | 2856 | |
2705 | - if ($message !== '' && $message[0] === ' ') |
|
2706 | - $message = ' ' . substr($message, 1); |
|
2857 | + if ($message !== '' && $message[0] === ' ') { |
|
2858 | + $message = ' ' . substr($message, 1); |
|
2859 | + } |
|
2707 | 2860 | |
2708 | 2861 | // Cleanup whitespace. |
2709 | 2862 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2712,15 +2865,16 @@ discard block |
||
2712 | 2865 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
2713 | 2866 | |
2714 | 2867 | // Cache the output if it took some time... |
2715 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
2716 | - cache_put_data($cache_key, $message, 240); |
|
2868 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
2869 | + cache_put_data($cache_key, $message, 240); |
|
2870 | + } |
|
2717 | 2871 | |
2718 | 2872 | // If this was a force parse revert if needed. |
2719 | 2873 | if (!empty($parse_tags)) |
2720 | 2874 | { |
2721 | - if (empty($temp_bbc)) |
|
2722 | - $bbc_codes = array(); |
|
2723 | - else |
|
2875 | + if (empty($temp_bbc)) { |
|
2876 | + $bbc_codes = array(); |
|
2877 | + } else |
|
2724 | 2878 | { |
2725 | 2879 | $bbc_codes = $temp_bbc; |
2726 | 2880 | unset($temp_bbc); |
@@ -2747,8 +2901,9 @@ discard block |
||
2747 | 2901 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
2748 | 2902 | |
2749 | 2903 | // No smiley set at all?! |
2750 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
2751 | - return; |
|
2904 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
2905 | + return; |
|
2906 | + } |
|
2752 | 2907 | |
2753 | 2908 | // If smileyPregSearch hasn't been set, do it now. |
2754 | 2909 | if (empty($smileyPregSearch)) |
@@ -2759,8 +2914,7 @@ discard block |
||
2759 | 2914 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
2760 | 2915 | $smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif'); |
2761 | 2916 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
2762 | - } |
|
2763 | - else |
|
2917 | + } else |
|
2764 | 2918 | { |
2765 | 2919 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
2766 | 2920 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2784,9 +2938,9 @@ discard block |
||
2784 | 2938 | $smcFunc['db_free_result']($result); |
2785 | 2939 | |
2786 | 2940 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
2941 | + } else { |
|
2942 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2787 | 2943 | } |
2788 | - else |
|
2789 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2790 | 2944 | } |
2791 | 2945 | |
2792 | 2946 | // The non-breaking-space is a complex thing... |
@@ -2863,35 +3017,41 @@ discard block |
||
2863 | 3017 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
2864 | 3018 | |
2865 | 3019 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
2866 | - if (!empty($context['flush_mail'])) |
|
2867 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3020 | + if (!empty($context['flush_mail'])) { |
|
3021 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2868 | 3022 | AddMailQueue(true); |
3023 | + } |
|
2869 | 3024 | |
2870 | 3025 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
2871 | 3026 | |
2872 | - if ($add) |
|
2873 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3027 | + if ($add) { |
|
3028 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3029 | + } |
|
2874 | 3030 | |
2875 | 3031 | // Put the session ID in. |
2876 | - if (defined('SID') && SID != '') |
|
2877 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3032 | + if (defined('SID') && SID != '') { |
|
3033 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3034 | + } |
|
2878 | 3035 | // Keep that debug in their for template debugging! |
2879 | - elseif (isset($_GET['debug'])) |
|
2880 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3036 | + elseif (isset($_GET['debug'])) { |
|
3037 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3038 | + } |
|
2881 | 3039 | |
2882 | 3040 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
2883 | 3041 | { |
2884 | - if (defined('SID') && SID != '') |
|
2885 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
3042 | + if (defined('SID') && SID != '') { |
|
3043 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
2886 | 3044 | function ($m) use ($scripturl) |
2887 | 3045 | { |
2888 | 3046 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
3047 | + } |
|
2889 | 3048 | }, $setLocation); |
2890 | - else |
|
2891 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
3049 | + else { |
|
3050 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
2892 | 3051 | function ($m) use ($scripturl) |
2893 | 3052 | { |
2894 | 3053 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
3054 | + } |
|
2895 | 3055 | }, $setLocation); |
2896 | 3056 | } |
2897 | 3057 | |
@@ -2902,8 +3062,9 @@ discard block |
||
2902 | 3062 | header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
2903 | 3063 | |
2904 | 3064 | // Debugging. |
2905 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
2906 | - $_SESSION['debug_redirect'] = $db_cache; |
|
3065 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3066 | + $_SESSION['debug_redirect'] = $db_cache; |
|
3067 | + } |
|
2907 | 3068 | |
2908 | 3069 | obExit(false); |
2909 | 3070 | } |
@@ -2922,51 +3083,60 @@ discard block |
||
2922 | 3083 | |
2923 | 3084 | // Attempt to prevent a recursive loop. |
2924 | 3085 | ++$level; |
2925 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
2926 | - exit; |
|
2927 | - if ($from_fatal_error) |
|
2928 | - $has_fatal_error = true; |
|
3086 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
3087 | + exit; |
|
3088 | + } |
|
3089 | + if ($from_fatal_error) { |
|
3090 | + $has_fatal_error = true; |
|
3091 | + } |
|
2929 | 3092 | |
2930 | 3093 | // Clear out the stat cache. |
2931 | 3094 | trackStats(); |
2932 | 3095 | |
2933 | 3096 | // If we have mail to send, send it. |
2934 | - if (!empty($context['flush_mail'])) |
|
2935 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3097 | + if (!empty($context['flush_mail'])) { |
|
3098 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2936 | 3099 | AddMailQueue(true); |
3100 | + } |
|
2937 | 3101 | |
2938 | 3102 | $do_header = $header === null ? !$header_done : $header; |
2939 | - if ($do_footer === null) |
|
2940 | - $do_footer = $do_header; |
|
3103 | + if ($do_footer === null) { |
|
3104 | + $do_footer = $do_header; |
|
3105 | + } |
|
2941 | 3106 | |
2942 | 3107 | // Has the template/header been done yet? |
2943 | 3108 | if ($do_header) |
2944 | 3109 | { |
2945 | 3110 | // Was the page title set last minute? Also update the HTML safe one. |
2946 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
2947 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3111 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
3112 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3113 | + } |
|
2948 | 3114 | |
2949 | 3115 | // Start up the session URL fixer. |
2950 | 3116 | ob_start('ob_sessrewrite'); |
2951 | 3117 | |
2952 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
2953 | - $buffers = explode(',', $settings['output_buffers']); |
|
2954 | - elseif (!empty($settings['output_buffers'])) |
|
2955 | - $buffers = $settings['output_buffers']; |
|
2956 | - else |
|
2957 | - $buffers = array(); |
|
3118 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
3119 | + $buffers = explode(',', $settings['output_buffers']); |
|
3120 | + } elseif (!empty($settings['output_buffers'])) { |
|
3121 | + $buffers = $settings['output_buffers']; |
|
3122 | + } else { |
|
3123 | + $buffers = array(); |
|
3124 | + } |
|
2958 | 3125 | |
2959 | - if (isset($modSettings['integrate_buffer'])) |
|
2960 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3126 | + if (isset($modSettings['integrate_buffer'])) { |
|
3127 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3128 | + } |
|
2961 | 3129 | |
2962 | - if (!empty($buffers)) |
|
2963 | - foreach ($buffers as $function) |
|
3130 | + if (!empty($buffers)) { |
|
3131 | + foreach ($buffers as $function) |
|
2964 | 3132 | { |
2965 | 3133 | $call = call_helper($function, true); |
3134 | + } |
|
2966 | 3135 | |
2967 | 3136 | // Is it valid? |
2968 | - if (!empty($call)) |
|
2969 | - ob_start($call); |
|
3137 | + if (!empty($call)) { |
|
3138 | + ob_start($call); |
|
3139 | + } |
|
2970 | 3140 | } |
2971 | 3141 | |
2972 | 3142 | // Display the screen in the logical order. |
@@ -2978,8 +3148,9 @@ discard block |
||
2978 | 3148 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
2979 | 3149 | |
2980 | 3150 | // Anything special to put out? |
2981 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
2982 | - echo $context['insert_after_template']; |
|
3151 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
3152 | + echo $context['insert_after_template']; |
|
3153 | + } |
|
2983 | 3154 | |
2984 | 3155 | // Just so we don't get caught in an endless loop of errors from the footer... |
2985 | 3156 | if (!$footer_done) |
@@ -2988,14 +3159,16 @@ discard block |
||
2988 | 3159 | template_footer(); |
2989 | 3160 | |
2990 | 3161 | // (since this is just debugging... it's okay that it's after </html>.) |
2991 | - if (!isset($_REQUEST['xml'])) |
|
2992 | - displayDebug(); |
|
3162 | + if (!isset($_REQUEST['xml'])) { |
|
3163 | + displayDebug(); |
|
3164 | + } |
|
2993 | 3165 | } |
2994 | 3166 | } |
2995 | 3167 | |
2996 | 3168 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
2997 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
2998 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3169 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
3170 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3171 | + } |
|
2999 | 3172 | |
3000 | 3173 | // For session check verification.... don't switch browsers... |
3001 | 3174 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -3004,9 +3177,10 @@ discard block |
||
3004 | 3177 | call_integration_hook('integrate_exit', array($do_footer)); |
3005 | 3178 | |
3006 | 3179 | // Don't exit if we're coming from index.php; that will pass through normally. |
3007 | - if (!$from_index) |
|
3008 | - exit; |
|
3009 | -} |
|
3180 | + if (!$from_index) { |
|
3181 | + exit; |
|
3182 | + } |
|
3183 | + } |
|
3010 | 3184 | |
3011 | 3185 | /** |
3012 | 3186 | * Get the size of a specified image with better error handling. |
@@ -3025,8 +3199,9 @@ discard block |
||
3025 | 3199 | $url = str_replace(' ', '%20', $url); |
3026 | 3200 | |
3027 | 3201 | // Can we pull this from the cache... please please? |
3028 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
3029 | - return $temp; |
|
3202 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
3203 | + return $temp; |
|
3204 | + } |
|
3030 | 3205 | $t = microtime(); |
3031 | 3206 | |
3032 | 3207 | // Get the host to pester... |
@@ -3036,12 +3211,10 @@ discard block |
||
3036 | 3211 | if ($url == '' || $url == 'http://' || $url == 'https://') |
3037 | 3212 | { |
3038 | 3213 | return false; |
3039 | - } |
|
3040 | - elseif (!isset($match[1])) |
|
3214 | + } elseif (!isset($match[1])) |
|
3041 | 3215 | { |
3042 | 3216 | $size = @getimagesize($url); |
3043 | - } |
|
3044 | - else |
|
3217 | + } else |
|
3045 | 3218 | { |
3046 | 3219 | // Try to connect to the server... give it half a second. |
3047 | 3220 | $temp = 0; |
@@ -3080,12 +3253,14 @@ discard block |
||
3080 | 3253 | } |
3081 | 3254 | |
3082 | 3255 | // If we didn't get it, we failed. |
3083 | - if (!isset($size)) |
|
3084 | - $size = false; |
|
3256 | + if (!isset($size)) { |
|
3257 | + $size = false; |
|
3258 | + } |
|
3085 | 3259 | |
3086 | 3260 | // If this took a long time, we may never have to do it again, but then again we might... |
3087 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
3088 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3261 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
3262 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3263 | + } |
|
3089 | 3264 | |
3090 | 3265 | // Didn't work. |
3091 | 3266 | return $size; |
@@ -3103,8 +3278,9 @@ discard block |
||
3103 | 3278 | |
3104 | 3279 | // Under SSI this function can be called more then once. That can cause some problems. |
3105 | 3280 | // So only run the function once unless we are forced to run it again. |
3106 | - if ($loaded && !$forceload) |
|
3107 | - return; |
|
3281 | + if ($loaded && !$forceload) { |
|
3282 | + return; |
|
3283 | + } |
|
3108 | 3284 | |
3109 | 3285 | $loaded = true; |
3110 | 3286 | |
@@ -3116,14 +3292,16 @@ discard block |
||
3116 | 3292 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
3117 | 3293 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
3118 | 3294 | { |
3119 | - if (trim($context['news_lines'][$i]) == '') |
|
3120 | - continue; |
|
3295 | + if (trim($context['news_lines'][$i]) == '') { |
|
3296 | + continue; |
|
3297 | + } |
|
3121 | 3298 | |
3122 | 3299 | // Clean it up for presentation ;). |
3123 | 3300 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
3124 | 3301 | } |
3125 | - if (!empty($context['news_lines'])) |
|
3126 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3302 | + if (!empty($context['news_lines'])) { |
|
3303 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3304 | + } |
|
3127 | 3305 | |
3128 | 3306 | if (!$user_info['is_guest']) |
3129 | 3307 | { |
@@ -3132,40 +3310,48 @@ discard block |
||
3132 | 3310 | $context['user']['alerts'] = &$user_info['alerts']; |
3133 | 3311 | |
3134 | 3312 | // Personal message popup... |
3135 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
3136 | - $context['user']['popup_messages'] = true; |
|
3137 | - else |
|
3138 | - $context['user']['popup_messages'] = false; |
|
3313 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
3314 | + $context['user']['popup_messages'] = true; |
|
3315 | + } else { |
|
3316 | + $context['user']['popup_messages'] = false; |
|
3317 | + } |
|
3139 | 3318 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
3140 | 3319 | |
3141 | - if (allowedTo('moderate_forum')) |
|
3142 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3320 | + if (allowedTo('moderate_forum')) { |
|
3321 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3322 | + } |
|
3143 | 3323 | |
3144 | 3324 | $context['user']['avatar'] = array(); |
3145 | 3325 | |
3146 | 3326 | // Check for gravatar first since we might be forcing them... |
3147 | 3327 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
3148 | 3328 | { |
3149 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
3150 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3151 | - else |
|
3152 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3329 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
3330 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3331 | + } else { |
|
3332 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3333 | + } |
|
3153 | 3334 | } |
3154 | 3335 | // Uploaded? |
3155 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
3156 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3336 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
3337 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3338 | + } |
|
3157 | 3339 | // Full URL? |
3158 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
3159 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3340 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
3341 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3342 | + } |
|
3160 | 3343 | // Otherwise we assume it's server stored. |
3161 | - elseif ($user_info['avatar']['url'] != '') |
|
3162 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3344 | + elseif ($user_info['avatar']['url'] != '') { |
|
3345 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3346 | + } |
|
3163 | 3347 | // No avatar at all? Fine, we have a big fat default avatar ;) |
3164 | - else |
|
3165 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3348 | + else { |
|
3349 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3350 | + } |
|
3166 | 3351 | |
3167 | - if (!empty($context['user']['avatar'])) |
|
3168 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3352 | + if (!empty($context['user']['avatar'])) { |
|
3353 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3354 | + } |
|
3169 | 3355 | |
3170 | 3356 | // Figure out how long they've been logged in. |
3171 | 3357 | $context['user']['total_time_logged_in'] = array( |
@@ -3173,8 +3359,7 @@ discard block |
||
3173 | 3359 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
3174 | 3360 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
3175 | 3361 | ); |
3176 | - } |
|
3177 | - else |
|
3362 | + } else |
|
3178 | 3363 | { |
3179 | 3364 | $context['user']['messages'] = 0; |
3180 | 3365 | $context['user']['unread_messages'] = 0; |
@@ -3182,12 +3367,14 @@ discard block |
||
3182 | 3367 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
3183 | 3368 | $context['user']['popup_messages'] = false; |
3184 | 3369 | |
3185 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
3186 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3370 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
3371 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3372 | + } |
|
3187 | 3373 | |
3188 | 3374 | // If we've upgraded recently, go easy on the passwords. |
3189 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
3190 | - $context['disable_login_hashing'] = true; |
|
3375 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
3376 | + $context['disable_login_hashing'] = true; |
|
3377 | + } |
|
3191 | 3378 | } |
3192 | 3379 | |
3193 | 3380 | // Setup the main menu items. |
@@ -3200,8 +3387,8 @@ discard block |
||
3200 | 3387 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
3201 | 3388 | |
3202 | 3389 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
3203 | - if ($context['show_pm_popup']) |
|
3204 | - addInlineJavaScript(' |
|
3390 | + if ($context['show_pm_popup']) { |
|
3391 | + addInlineJavaScript(' |
|
3205 | 3392 | jQuery(document).ready(function($) { |
3206 | 3393 | new smc_Popup({ |
3207 | 3394 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3209,15 +3396,17 @@ discard block |
||
3209 | 3396 | icon_class: \'generic_icons mail_new\' |
3210 | 3397 | }); |
3211 | 3398 | });'); |
3399 | + } |
|
3212 | 3400 | |
3213 | 3401 | // Add a generic "Are you sure?" confirmation message. |
3214 | 3402 | addInlineJavaScript(' |
3215 | 3403 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
3216 | 3404 | |
3217 | 3405 | // Now add the capping code for avatars. |
3218 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
3219 | - addInlineCss(' |
|
3406 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
3407 | + addInlineCss(' |
|
3220 | 3408 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
3409 | + } |
|
3221 | 3410 | |
3222 | 3411 | // This looks weird, but it's because BoardIndex.php references the variable. |
3223 | 3412 | $context['common_stats']['latest_member'] = array( |
@@ -3234,11 +3423,13 @@ discard block |
||
3234 | 3423 | ); |
3235 | 3424 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
3236 | 3425 | |
3237 | - if (empty($settings['theme_version'])) |
|
3238 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
3426 | + if (empty($settings['theme_version'])) { |
|
3427 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
3428 | + } |
|
3239 | 3429 | |
3240 | - if (!isset($context['page_title'])) |
|
3241 | - $context['page_title'] = ''; |
|
3430 | + if (!isset($context['page_title'])) { |
|
3431 | + $context['page_title'] = ''; |
|
3432 | + } |
|
3242 | 3433 | |
3243 | 3434 | // Set some specific vars. |
3244 | 3435 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3248,21 +3439,23 @@ discard block |
||
3248 | 3439 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
3249 | 3440 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
3250 | 3441 | |
3251 | - if (!empty($context['meta_keywords'])) |
|
3252 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3442 | + if (!empty($context['meta_keywords'])) { |
|
3443 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3444 | + } |
|
3253 | 3445 | |
3254 | - if (!empty($context['canonical_url'])) |
|
3255 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3446 | + if (!empty($context['canonical_url'])) { |
|
3447 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3448 | + } |
|
3256 | 3449 | |
3257 | - if (!empty($settings['og_image'])) |
|
3258 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3450 | + if (!empty($settings['og_image'])) { |
|
3451 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3452 | + } |
|
3259 | 3453 | |
3260 | 3454 | if (!empty($context['meta_description'])) |
3261 | 3455 | { |
3262 | 3456 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
3263 | 3457 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
3264 | - } |
|
3265 | - else |
|
3458 | + } else |
|
3266 | 3459 | { |
3267 | 3460 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
3268 | 3461 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3287,8 +3480,9 @@ discard block |
||
3287 | 3480 | $memory_needed = memoryReturnBytes($needed); |
3288 | 3481 | |
3289 | 3482 | // should we account for how much is currently being used? |
3290 | - if ($in_use) |
|
3291 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3483 | + if ($in_use) { |
|
3484 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3485 | + } |
|
3292 | 3486 | |
3293 | 3487 | // if more is needed, request it |
3294 | 3488 | if ($memory_current < $memory_needed) |
@@ -3311,8 +3505,9 @@ discard block |
||
3311 | 3505 | */ |
3312 | 3506 | function memoryReturnBytes($val) |
3313 | 3507 | { |
3314 | - if (is_integer($val)) |
|
3315 | - return $val; |
|
3508 | + if (is_integer($val)) { |
|
3509 | + return $val; |
|
3510 | + } |
|
3316 | 3511 | |
3317 | 3512 | // Separate the number from the designator |
3318 | 3513 | $val = trim($val); |
@@ -3348,10 +3543,11 @@ discard block |
||
3348 | 3543 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
3349 | 3544 | |
3350 | 3545 | // Are we debugging the template/html content? |
3351 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
3352 | - header('Content-Type: application/xhtml+xml'); |
|
3353 | - elseif (!isset($_REQUEST['xml'])) |
|
3354 | - header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3546 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
3547 | + header('Content-Type: application/xhtml+xml'); |
|
3548 | + } elseif (!isset($_REQUEST['xml'])) { |
|
3549 | + header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3550 | + } |
|
3355 | 3551 | } |
3356 | 3552 | |
3357 | 3553 | header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3360,8 +3556,9 @@ discard block |
||
3360 | 3556 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
3361 | 3557 | { |
3362 | 3558 | $position = array_search('body', $context['template_layers']); |
3363 | - if ($position === false) |
|
3364 | - $position = array_search('main', $context['template_layers']); |
|
3559 | + if ($position === false) { |
|
3560 | + $position = array_search('main', $context['template_layers']); |
|
3561 | + } |
|
3365 | 3562 | |
3366 | 3563 | if ($position !== false) |
3367 | 3564 | { |
@@ -3389,23 +3586,25 @@ discard block |
||
3389 | 3586 | |
3390 | 3587 | foreach ($securityFiles as $i => $securityFile) |
3391 | 3588 | { |
3392 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
3393 | - unset($securityFiles[$i]); |
|
3589 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
3590 | + unset($securityFiles[$i]); |
|
3591 | + } |
|
3394 | 3592 | } |
3395 | 3593 | |
3396 | 3594 | // We are already checking so many files...just few more doesn't make any difference! :P |
3397 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
3398 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3399 | - |
|
3400 | - else |
|
3401 | - $path = $modSettings['attachmentUploadDir']; |
|
3595 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
3596 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3597 | + } else { |
|
3598 | + $path = $modSettings['attachmentUploadDir']; |
|
3599 | + } |
|
3402 | 3600 | |
3403 | 3601 | secureDirectory($path, true); |
3404 | 3602 | secureDirectory($cachedir); |
3405 | 3603 | |
3406 | 3604 | // If agreement is enabled, at least the english version shall exists |
3407 | - if ($modSettings['requireAgreement']) |
|
3408 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3605 | + if ($modSettings['requireAgreement']) { |
|
3606 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3607 | + } |
|
3409 | 3608 | |
3410 | 3609 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
3411 | 3610 | { |
@@ -3420,18 +3619,21 @@ discard block |
||
3420 | 3619 | echo ' |
3421 | 3620 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
3422 | 3621 | |
3423 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
3424 | - echo ' |
|
3622 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
3623 | + echo ' |
|
3425 | 3624 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
3625 | + } |
|
3426 | 3626 | } |
3427 | 3627 | |
3428 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
3429 | - echo ' |
|
3628 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
3629 | + echo ' |
|
3430 | 3630 | <strong>', $txt['cache_writable'], '</strong><br>'; |
3631 | + } |
|
3431 | 3632 | |
3432 | - if (!empty($agreement)) |
|
3433 | - echo ' |
|
3633 | + if (!empty($agreement)) { |
|
3634 | + echo ' |
|
3434 | 3635 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
3636 | + } |
|
3435 | 3637 | |
3436 | 3638 | echo ' |
3437 | 3639 | </p> |
@@ -3446,16 +3648,18 @@ discard block |
||
3446 | 3648 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
3447 | 3649 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
3448 | 3650 | |
3449 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
3450 | - echo ' |
|
3651 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
3652 | + echo ' |
|
3451 | 3653 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
3654 | + } |
|
3452 | 3655 | |
3453 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
3454 | - echo ' |
|
3656 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
3657 | + echo ' |
|
3455 | 3658 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
3456 | - else |
|
3457 | - echo ' |
|
3659 | + } else { |
|
3660 | + echo ' |
|
3458 | 3661 | <div>', $txt['your_ban_expires_never'], '</div>'; |
3662 | + } |
|
3459 | 3663 | |
3460 | 3664 | echo ' |
3461 | 3665 | </div>'; |
@@ -3471,8 +3675,9 @@ discard block |
||
3471 | 3675 | global $forum_copyright, $software_year, $forum_version; |
3472 | 3676 | |
3473 | 3677 | // Don't display copyright for things like SSI. |
3474 | - if (!isset($forum_version) || !isset($software_year)) |
|
3475 | - return; |
|
3678 | + if (!isset($forum_version) || !isset($software_year)) { |
|
3679 | + return; |
|
3680 | + } |
|
3476 | 3681 | |
3477 | 3682 | // Put in the version... |
3478 | 3683 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3490,9 +3695,10 @@ discard block |
||
3490 | 3695 | $context['load_time'] = round(microtime(true) - $time_start, 3); |
3491 | 3696 | $context['load_queries'] = $db_count; |
3492 | 3697 | |
3493 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
3494 | - loadSubTemplate($layer . '_below', true); |
|
3495 | -} |
|
3698 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
3699 | + loadSubTemplate($layer . '_below', true); |
|
3700 | + } |
|
3701 | + } |
|
3496 | 3702 | |
3497 | 3703 | /** |
3498 | 3704 | * Output the Javascript files |
@@ -3523,8 +3729,7 @@ discard block |
||
3523 | 3729 | { |
3524 | 3730 | echo ' |
3525 | 3731 | var ', $key, ';'; |
3526 | - } |
|
3527 | - else |
|
3732 | + } else |
|
3528 | 3733 | { |
3529 | 3734 | echo ' |
3530 | 3735 | var ', $key, ' = ', $value, ';'; |
@@ -3539,26 +3744,27 @@ discard block |
||
3539 | 3744 | foreach ($context['javascript_files'] as $id => $js_file) |
3540 | 3745 | { |
3541 | 3746 | // Last minute call! allow theme authors to disable single files. |
3542 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3543 | - continue; |
|
3747 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3748 | + continue; |
|
3749 | + } |
|
3544 | 3750 | |
3545 | 3751 | // By default all files don't get minimized unless the file explicitly says so! |
3546 | 3752 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
3547 | 3753 | { |
3548 | - if ($do_deferred && !empty($js_file['options']['defer'])) |
|
3549 | - $toMinifyDefer[] = $js_file; |
|
3550 | - |
|
3551 | - elseif (!$do_deferred && empty($js_file['options']['defer'])) |
|
3552 | - $toMinify[] = $js_file; |
|
3754 | + if ($do_deferred && !empty($js_file['options']['defer'])) { |
|
3755 | + $toMinifyDefer[] = $js_file; |
|
3756 | + } elseif (!$do_deferred && empty($js_file['options']['defer'])) { |
|
3757 | + $toMinify[] = $js_file; |
|
3758 | + } |
|
3553 | 3759 | |
3554 | 3760 | // Grab a random seed. |
3555 | - if (!isset($minSeed)) |
|
3556 | - $minSeed = $js_file['options']['seed']; |
|
3557 | - } |
|
3558 | - |
|
3559 | - elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) |
|
3560 | - echo ' |
|
3761 | + if (!isset($minSeed)) { |
|
3762 | + $minSeed = $js_file['options']['seed']; |
|
3763 | + } |
|
3764 | + } elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) { |
|
3765 | + echo ' |
|
3561 | 3766 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>'; |
3767 | + } |
|
3562 | 3768 | } |
3563 | 3769 | |
3564 | 3770 | if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer))) |
@@ -3566,14 +3772,14 @@ discard block |
||
3566 | 3772 | $result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred); |
3567 | 3773 | |
3568 | 3774 | // Minify process couldn't work, print each individual files. |
3569 | - if (!empty($result) && is_array($result)) |
|
3570 | - foreach ($result as $minFailedFile) |
|
3775 | + if (!empty($result) && is_array($result)) { |
|
3776 | + foreach ($result as $minFailedFile) |
|
3571 | 3777 | echo ' |
3572 | 3778 | <script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>'; |
3573 | - |
|
3574 | - else |
|
3575 | - echo ' |
|
3779 | + } else { |
|
3780 | + echo ' |
|
3576 | 3781 | <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
3782 | + } |
|
3577 | 3783 | } |
3578 | 3784 | |
3579 | 3785 | // Inline JavaScript - Actually useful some times! |
@@ -3584,8 +3790,9 @@ discard block |
||
3584 | 3790 | echo ' |
3585 | 3791 | <script>'; |
3586 | 3792 | |
3587 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
3588 | - echo $js_code; |
|
3793 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
3794 | + echo $js_code; |
|
3795 | + } |
|
3589 | 3796 | |
3590 | 3797 | echo ' |
3591 | 3798 | </script>'; |
@@ -3596,8 +3803,9 @@ discard block |
||
3596 | 3803 | echo ' |
3597 | 3804 | <script>'; |
3598 | 3805 | |
3599 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
3600 | - echo $js_code; |
|
3806 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
3807 | + echo $js_code; |
|
3808 | + } |
|
3601 | 3809 | |
3602 | 3810 | echo ' |
3603 | 3811 | </script>'; |
@@ -3622,8 +3830,9 @@ discard block |
||
3622 | 3830 | foreach ($context['css_files'] as $id => $file) |
3623 | 3831 | { |
3624 | 3832 | // Last minute call! allow theme authors to disable single files. |
3625 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3626 | - continue; |
|
3833 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3834 | + continue; |
|
3835 | + } |
|
3627 | 3836 | |
3628 | 3837 | // By default all files don't get minimized unless the file explicitly says so! |
3629 | 3838 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
@@ -3631,12 +3840,12 @@ discard block |
||
3631 | 3840 | $toMinify[] = $file; |
3632 | 3841 | |
3633 | 3842 | // Grab a random seed. |
3634 | - if (!isset($minSeed)) |
|
3635 | - $minSeed = $file['options']['seed']; |
|
3843 | + if (!isset($minSeed)) { |
|
3844 | + $minSeed = $file['options']['seed']; |
|
3845 | + } |
|
3846 | + } else { |
|
3847 | + $normal[] = $file['fileUrl']; |
|
3636 | 3848 | } |
3637 | - |
|
3638 | - else |
|
3639 | - $normal[] = $file['fileUrl']; |
|
3640 | 3849 | } |
3641 | 3850 | |
3642 | 3851 | if (!empty($toMinify)) |
@@ -3644,28 +3853,30 @@ discard block |
||
3644 | 3853 | $result = custMinify($toMinify, 'css'); |
3645 | 3854 | |
3646 | 3855 | // Minify process couldn't work, print each individual files. |
3647 | - if (!empty($result) && is_array($result)) |
|
3648 | - foreach ($result as $minFailedFile) |
|
3856 | + if (!empty($result) && is_array($result)) { |
|
3857 | + foreach ($result as $minFailedFile) |
|
3649 | 3858 | echo ' |
3650 | 3859 | <link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">'; |
3651 | - |
|
3652 | - else |
|
3653 | - echo ' |
|
3860 | + } else { |
|
3861 | + echo ' |
|
3654 | 3862 | <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
3863 | + } |
|
3655 | 3864 | } |
3656 | 3865 | |
3657 | 3866 | // Print the rest after the minified files. |
3658 | - if (!empty($normal)) |
|
3659 | - foreach ($normal as $nf) |
|
3867 | + if (!empty($normal)) { |
|
3868 | + foreach ($normal as $nf) |
|
3660 | 3869 | echo ' |
3661 | 3870 | <link rel="stylesheet" href="', $nf ,'">'; |
3871 | + } |
|
3662 | 3872 | |
3663 | 3873 | if ($db_show_debug === true) |
3664 | 3874 | { |
3665 | 3875 | // Try to keep only what's useful. |
3666 | 3876 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
3667 | - foreach ($context['css_files'] as $file) |
|
3668 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3877 | + foreach ($context['css_files'] as $file) { |
|
3878 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3879 | + } |
|
3669 | 3880 | } |
3670 | 3881 | |
3671 | 3882 | if (!empty($context['css_header'])) |
@@ -3673,9 +3884,10 @@ discard block |
||
3673 | 3884 | echo ' |
3674 | 3885 | <style>'; |
3675 | 3886 | |
3676 | - foreach ($context['css_header'] as $css) |
|
3677 | - echo $css .' |
|
3887 | + foreach ($context['css_header'] as $css) { |
|
3888 | + echo $css .' |
|
3678 | 3889 | '; |
3890 | + } |
|
3679 | 3891 | |
3680 | 3892 | echo' |
3681 | 3893 | </style>'; |
@@ -3699,15 +3911,17 @@ discard block |
||
3699 | 3911 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
3700 | 3912 | $data = !empty($data) ? $data : false; |
3701 | 3913 | |
3702 | - if (empty($type) || empty($data)) |
|
3703 | - return false; |
|
3914 | + if (empty($type) || empty($data)) { |
|
3915 | + return false; |
|
3916 | + } |
|
3704 | 3917 | |
3705 | 3918 | // Did we already did this? |
3706 | 3919 | $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
3707 | 3920 | |
3708 | 3921 | // Already done? |
3709 | - if (!empty($toCache)) |
|
3710 | - return true; |
|
3922 | + if (!empty($toCache)) { |
|
3923 | + return true; |
|
3924 | + } |
|
3711 | 3925 | |
3712 | 3926 | // No namespaces, sorry! |
3713 | 3927 | $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
@@ -3789,8 +4003,9 @@ discard block |
||
3789 | 4003 | global $modSettings, $smcFunc; |
3790 | 4004 | |
3791 | 4005 | // Just make up a nice hash... |
3792 | - if ($new) |
|
3793 | - return sha1(md5($filename . time()) . mt_rand()); |
|
4006 | + if ($new) { |
|
4007 | + return sha1(md5($filename . time()) . mt_rand()); |
|
4008 | + } |
|
3794 | 4009 | |
3795 | 4010 | // Just make sure that attachment id is only a int |
3796 | 4011 | $attachment_id = (int) $attachment_id; |
@@ -3807,23 +4022,25 @@ discard block |
||
3807 | 4022 | 'id_attach' => $attachment_id, |
3808 | 4023 | )); |
3809 | 4024 | |
3810 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
3811 | - return false; |
|
4025 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
4026 | + return false; |
|
4027 | + } |
|
3812 | 4028 | |
3813 | 4029 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
3814 | 4030 | $smcFunc['db_free_result']($request); |
3815 | 4031 | } |
3816 | 4032 | |
3817 | 4033 | // Still no hash? mmm... |
3818 | - if (empty($file_hash)) |
|
3819 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4034 | + if (empty($file_hash)) { |
|
4035 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4036 | + } |
|
3820 | 4037 | |
3821 | 4038 | // Are we using multiple directories? |
3822 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
3823 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
3824 | - |
|
3825 | - else |
|
3826 | - $path = $modSettings['attachmentUploadDir']; |
|
4039 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
4040 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
4041 | + } else { |
|
4042 | + $path = $modSettings['attachmentUploadDir']; |
|
4043 | + } |
|
3827 | 4044 | |
3828 | 4045 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
3829 | 4046 | } |
@@ -3838,8 +4055,9 @@ discard block |
||
3838 | 4055 | function ip2range($fullip) |
3839 | 4056 | { |
3840 | 4057 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
3841 | - if ($fullip == 'unknown') |
|
3842 | - $fullip = '255.255.255.255'; |
|
4058 | + if ($fullip == 'unknown') { |
|
4059 | + $fullip = '255.255.255.255'; |
|
4060 | + } |
|
3843 | 4061 | |
3844 | 4062 | $ip_parts = explode('-', $fullip); |
3845 | 4063 | $ip_array = array(); |
@@ -3863,10 +4081,11 @@ discard block |
||
3863 | 4081 | $ip_array['low'] = $ip_parts[0]; |
3864 | 4082 | $ip_array['high'] = $ip_parts[1]; |
3865 | 4083 | return $ip_array; |
3866 | - } |
|
3867 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
4084 | + } elseif (count($ip_parts) == 2) { |
|
4085 | + // if ip 22.22.*-22.22.* |
|
3868 | 4086 | { |
3869 | 4087 | $valid_low = isValidIP($ip_parts[0]); |
4088 | + } |
|
3870 | 4089 | $valid_high = isValidIP($ip_parts[1]); |
3871 | 4090 | $count = 0; |
3872 | 4091 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -3881,7 +4100,9 @@ discard block |
||
3881 | 4100 | $ip_parts[0] .= $mode . $min; |
3882 | 4101 | $valid_low = isValidIP($ip_parts[0]); |
3883 | 4102 | $count++; |
3884 | - if ($count > 9) break; |
|
4103 | + if ($count > 9) { |
|
4104 | + break; |
|
4105 | + } |
|
3885 | 4106 | } |
3886 | 4107 | } |
3887 | 4108 | |
@@ -3895,7 +4116,9 @@ discard block |
||
3895 | 4116 | $ip_parts[1] .= $mode . $max; |
3896 | 4117 | $valid_high = isValidIP($ip_parts[1]); |
3897 | 4118 | $count++; |
3898 | - if ($count > 9) break; |
|
4119 | + if ($count > 9) { |
|
4120 | + break; |
|
4121 | + } |
|
3899 | 4122 | } |
3900 | 4123 | } |
3901 | 4124 | |
@@ -3920,46 +4143,54 @@ discard block |
||
3920 | 4143 | { |
3921 | 4144 | global $modSettings; |
3922 | 4145 | |
3923 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
3924 | - return $host; |
|
4146 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
4147 | + return $host; |
|
4148 | + } |
|
3925 | 4149 | $t = microtime(); |
3926 | 4150 | |
3927 | 4151 | // Try the Linux host command, perhaps? |
3928 | 4152 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
3929 | 4153 | { |
3930 | - if (!isset($modSettings['host_to_dis'])) |
|
3931 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
3932 | - else |
|
3933 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4154 | + if (!isset($modSettings['host_to_dis'])) { |
|
4155 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
4156 | + } else { |
|
4157 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4158 | + } |
|
3934 | 4159 | |
3935 | 4160 | // Did host say it didn't find anything? |
3936 | - if (strpos($test, 'not found') !== false) |
|
3937 | - $host = ''; |
|
4161 | + if (strpos($test, 'not found') !== false) { |
|
4162 | + $host = ''; |
|
4163 | + } |
|
3938 | 4164 | // Invalid server option? |
3939 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
3940 | - updateSettings(array('host_to_dis' => 1)); |
|
4165 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
4166 | + updateSettings(array('host_to_dis' => 1)); |
|
4167 | + } |
|
3941 | 4168 | // Maybe it found something, after all? |
3942 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
3943 | - $host = $match[1]; |
|
4169 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
4170 | + $host = $match[1]; |
|
4171 | + } |
|
3944 | 4172 | } |
3945 | 4173 | |
3946 | 4174 | // This is nslookup; usually only Windows, but possibly some Unix? |
3947 | 4175 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
3948 | 4176 | { |
3949 | 4177 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
3950 | - if (strpos($test, 'Non-existent domain') !== false) |
|
3951 | - $host = ''; |
|
3952 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
3953 | - $host = $match[1]; |
|
4178 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
4179 | + $host = ''; |
|
4180 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
4181 | + $host = $match[1]; |
|
4182 | + } |
|
3954 | 4183 | } |
3955 | 4184 | |
3956 | 4185 | // This is the last try :/. |
3957 | - if (!isset($host) || $host === false) |
|
3958 | - $host = @gethostbyaddr($ip); |
|
4186 | + if (!isset($host) || $host === false) { |
|
4187 | + $host = @gethostbyaddr($ip); |
|
4188 | + } |
|
3959 | 4189 | |
3960 | 4190 | // It took a long time, so let's cache it! |
3961 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
3962 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4191 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
4192 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4193 | + } |
|
3963 | 4194 | |
3964 | 4195 | return $host; |
3965 | 4196 | } |
@@ -3995,20 +4226,21 @@ discard block |
||
3995 | 4226 | { |
3996 | 4227 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
3997 | 4228 | $total = 0; |
3998 | - for ($i = 0; $i < $max_chars; $i++) |
|
3999 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4229 | + for ($i = 0; $i < $max_chars; $i++) { |
|
4230 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4231 | + } |
|
4000 | 4232 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
4001 | 4233 | } |
4002 | 4234 | } |
4003 | 4235 | return array_unique($returned_ints); |
4004 | - } |
|
4005 | - else |
|
4236 | + } else |
|
4006 | 4237 | { |
4007 | 4238 | // Trim characters before and after and add slashes for database insertion. |
4008 | 4239 | $returned_words = array(); |
4009 | - foreach ($words as $word) |
|
4010 | - if (($word = trim($word, '-_\'')) !== '') |
|
4240 | + foreach ($words as $word) { |
|
4241 | + if (($word = trim($word, '-_\'')) !== '') |
|
4011 | 4242 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
4243 | + } |
|
4012 | 4244 | |
4013 | 4245 | // Filter out all words that occur more than once. |
4014 | 4246 | return array_unique($returned_words); |
@@ -4030,16 +4262,18 @@ discard block |
||
4030 | 4262 | global $settings, $txt; |
4031 | 4263 | |
4032 | 4264 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
4033 | - if (function_exists('template_create_button') && !$force_use) |
|
4034 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4265 | + if (function_exists('template_create_button') && !$force_use) { |
|
4266 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4267 | + } |
|
4035 | 4268 | |
4036 | - if (!$settings['use_image_buttons']) |
|
4037 | - return $txt[$alt]; |
|
4038 | - elseif (!empty($settings['use_buttons'])) |
|
4039 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4040 | - else |
|
4041 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4042 | -} |
|
4269 | + if (!$settings['use_image_buttons']) { |
|
4270 | + return $txt[$alt]; |
|
4271 | + } elseif (!empty($settings['use_buttons'])) { |
|
4272 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4273 | + } else { |
|
4274 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4275 | + } |
|
4276 | + } |
|
4043 | 4277 | |
4044 | 4278 | /** |
4045 | 4279 | * Sets up all of the top menu buttons |
@@ -4082,9 +4316,10 @@ discard block |
||
4082 | 4316 | var user_menus = new smc_PopupMenu(); |
4083 | 4317 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4084 | 4318 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
4085 | - if ($context['allow_pm']) |
|
4086 | - addInlineJavaScript(' |
|
4319 | + if ($context['allow_pm']) { |
|
4320 | + addInlineJavaScript(' |
|
4087 | 4321 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
4322 | + } |
|
4088 | 4323 | |
4089 | 4324 | if (!empty($modSettings['enable_ajax_alerts'])) |
4090 | 4325 | { |
@@ -4244,88 +4479,96 @@ discard block |
||
4244 | 4479 | |
4245 | 4480 | // Now we put the buttons in the context so the theme can use them. |
4246 | 4481 | $menu_buttons = array(); |
4247 | - foreach ($buttons as $act => $button) |
|
4248 | - if (!empty($button['show'])) |
|
4482 | + foreach ($buttons as $act => $button) { |
|
4483 | + if (!empty($button['show'])) |
|
4249 | 4484 | { |
4250 | 4485 | $button['active_button'] = false; |
4486 | + } |
|
4251 | 4487 | |
4252 | 4488 | // This button needs some action. |
4253 | - if (isset($button['action_hook'])) |
|
4254 | - $needs_action_hook = true; |
|
4489 | + if (isset($button['action_hook'])) { |
|
4490 | + $needs_action_hook = true; |
|
4491 | + } |
|
4255 | 4492 | |
4256 | 4493 | // Make sure the last button truly is the last button. |
4257 | 4494 | if (!empty($button['is_last'])) |
4258 | 4495 | { |
4259 | - if (isset($last_button)) |
|
4260 | - unset($menu_buttons[$last_button]['is_last']); |
|
4496 | + if (isset($last_button)) { |
|
4497 | + unset($menu_buttons[$last_button]['is_last']); |
|
4498 | + } |
|
4261 | 4499 | $last_button = $act; |
4262 | 4500 | } |
4263 | 4501 | |
4264 | 4502 | // Go through the sub buttons if there are any. |
4265 | - if (!empty($button['sub_buttons'])) |
|
4266 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4503 | + if (!empty($button['sub_buttons'])) { |
|
4504 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4267 | 4505 | { |
4268 | 4506 | if (empty($subbutton['show'])) |
4269 | 4507 | unset($button['sub_buttons'][$key]); |
4508 | + } |
|
4270 | 4509 | |
4271 | 4510 | // 2nd level sub buttons next... |
4272 | 4511 | if (!empty($subbutton['sub_buttons'])) |
4273 | 4512 | { |
4274 | 4513 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
4275 | 4514 | { |
4276 | - if (empty($sub_button2['show'])) |
|
4277 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4515 | + if (empty($sub_button2['show'])) { |
|
4516 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4517 | + } |
|
4278 | 4518 | } |
4279 | 4519 | } |
4280 | 4520 | } |
4281 | 4521 | |
4282 | 4522 | // Does this button have its own icon? |
4283 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
4284 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4285 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
4286 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4287 | - elseif (isset($button['icon'])) |
|
4288 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4289 | - else |
|
4290 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4523 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
4524 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4525 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
4526 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4527 | + } elseif (isset($button['icon'])) { |
|
4528 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4529 | + } else { |
|
4530 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4531 | + } |
|
4291 | 4532 | |
4292 | 4533 | $menu_buttons[$act] = $button; |
4293 | 4534 | } |
4294 | 4535 | |
4295 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
4296 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4536 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
4537 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4538 | + } |
|
4297 | 4539 | } |
4298 | 4540 | |
4299 | 4541 | $context['menu_buttons'] = $menu_buttons; |
4300 | 4542 | |
4301 | 4543 | // Logging out requires the session id in the url. |
4302 | - if (isset($context['menu_buttons']['logout'])) |
|
4303 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4544 | + if (isset($context['menu_buttons']['logout'])) { |
|
4545 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4546 | + } |
|
4304 | 4547 | |
4305 | 4548 | // Figure out which action we are doing so we can set the active tab. |
4306 | 4549 | // Default to home. |
4307 | 4550 | $current_action = 'home'; |
4308 | 4551 | |
4309 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
4310 | - $current_action = $context['current_action']; |
|
4311 | - elseif ($context['current_action'] == 'search2') |
|
4312 | - $current_action = 'search'; |
|
4313 | - elseif ($context['current_action'] == 'theme') |
|
4314 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4315 | - elseif ($context['current_action'] == 'register2') |
|
4316 | - $current_action = 'register'; |
|
4317 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
4318 | - $current_action = 'login'; |
|
4319 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
4320 | - $current_action = 'moderate'; |
|
4552 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
4553 | + $current_action = $context['current_action']; |
|
4554 | + } elseif ($context['current_action'] == 'search2') { |
|
4555 | + $current_action = 'search'; |
|
4556 | + } elseif ($context['current_action'] == 'theme') { |
|
4557 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4558 | + } elseif ($context['current_action'] == 'register2') { |
|
4559 | + $current_action = 'register'; |
|
4560 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
4561 | + $current_action = 'login'; |
|
4562 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
4563 | + $current_action = 'moderate'; |
|
4564 | + } |
|
4321 | 4565 | |
4322 | 4566 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
4323 | 4567 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
4324 | 4568 | { |
4325 | 4569 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
4326 | 4570 | $context[$current_action] = true; |
4327 | - } |
|
4328 | - elseif ($context['current_action'] == 'pm') |
|
4571 | + } elseif ($context['current_action'] == 'pm') |
|
4329 | 4572 | { |
4330 | 4573 | $current_action = 'self_pm'; |
4331 | 4574 | $context['self_pm'] = true; |
@@ -4366,12 +4609,14 @@ discard block |
||
4366 | 4609 | } |
4367 | 4610 | |
4368 | 4611 | // Not all actions are simple. |
4369 | - if (!empty($needs_action_hook)) |
|
4370 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4612 | + if (!empty($needs_action_hook)) { |
|
4613 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4614 | + } |
|
4371 | 4615 | |
4372 | - if (isset($context['menu_buttons'][$current_action])) |
|
4373 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4374 | -} |
|
4616 | + if (isset($context['menu_buttons'][$current_action])) { |
|
4617 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4618 | + } |
|
4619 | + } |
|
4375 | 4620 | |
4376 | 4621 | /** |
4377 | 4622 | * Generate a random seed and ensure it's stored in settings. |
@@ -4395,30 +4640,35 @@ discard block |
||
4395 | 4640 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
4396 | 4641 | global $context, $txt; |
4397 | 4642 | |
4398 | - if ($db_show_debug === true) |
|
4399 | - $context['debug']['hooks'][] = $hook; |
|
4643 | + if ($db_show_debug === true) { |
|
4644 | + $context['debug']['hooks'][] = $hook; |
|
4645 | + } |
|
4400 | 4646 | |
4401 | 4647 | // Need to have some control. |
4402 | - if (!isset($context['instances'])) |
|
4403 | - $context['instances'] = array(); |
|
4648 | + if (!isset($context['instances'])) { |
|
4649 | + $context['instances'] = array(); |
|
4650 | + } |
|
4404 | 4651 | |
4405 | 4652 | $results = array(); |
4406 | - if (empty($modSettings[$hook])) |
|
4407 | - return $results; |
|
4653 | + if (empty($modSettings[$hook])) { |
|
4654 | + return $results; |
|
4655 | + } |
|
4408 | 4656 | |
4409 | 4657 | $functions = explode(',', $modSettings[$hook]); |
4410 | 4658 | // Loop through each function. |
4411 | 4659 | foreach ($functions as $function) |
4412 | 4660 | { |
4413 | 4661 | // Hook has been marked as "disabled". Skip it! |
4414 | - if (strpos($function, '!') !== false) |
|
4415 | - continue; |
|
4662 | + if (strpos($function, '!') !== false) { |
|
4663 | + continue; |
|
4664 | + } |
|
4416 | 4665 | |
4417 | 4666 | $call = call_helper($function, true); |
4418 | 4667 | |
4419 | 4668 | // Is it valid? |
4420 | - if (!empty($call)) |
|
4421 | - $results[$function] = call_user_func_array($call, $parameters); |
|
4669 | + if (!empty($call)) { |
|
4670 | + $results[$function] = call_user_func_array($call, $parameters); |
|
4671 | + } |
|
4422 | 4672 | |
4423 | 4673 | // Whatever it was suppose to call, it failed :( |
4424 | 4674 | elseif (!empty($function)) |
@@ -4434,8 +4684,9 @@ discard block |
||
4434 | 4684 | } |
4435 | 4685 | |
4436 | 4686 | // "Assume" the file resides on $boarddir somewhere... |
4437 | - else |
|
4438 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4687 | + else { |
|
4688 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4689 | + } |
|
4439 | 4690 | } |
4440 | 4691 | } |
4441 | 4692 | |
@@ -4457,12 +4708,14 @@ discard block |
||
4457 | 4708 | global $smcFunc, $modSettings; |
4458 | 4709 | |
4459 | 4710 | // Any objects? |
4460 | - if ($object) |
|
4461 | - $function = $function . '#'; |
|
4711 | + if ($object) { |
|
4712 | + $function = $function . '#'; |
|
4713 | + } |
|
4462 | 4714 | |
4463 | 4715 | // Any files to load? |
4464 | - if (!empty($file) && is_string($file)) |
|
4465 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4716 | + if (!empty($file) && is_string($file)) { |
|
4717 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4718 | + } |
|
4466 | 4719 | |
4467 | 4720 | // Get the correct string. |
4468 | 4721 | $integration_call = $function; |
@@ -4484,13 +4737,14 @@ discard block |
||
4484 | 4737 | if (!empty($current_functions)) |
4485 | 4738 | { |
4486 | 4739 | $current_functions = explode(',', $current_functions); |
4487 | - if (in_array($integration_call, $current_functions)) |
|
4488 | - return; |
|
4740 | + if (in_array($integration_call, $current_functions)) { |
|
4741 | + return; |
|
4742 | + } |
|
4489 | 4743 | |
4490 | 4744 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
4745 | + } else { |
|
4746 | + $permanent_functions = array($integration_call); |
|
4491 | 4747 | } |
4492 | - else |
|
4493 | - $permanent_functions = array($integration_call); |
|
4494 | 4748 | |
4495 | 4749 | updateSettings(array($hook => implode(',', $permanent_functions))); |
4496 | 4750 | } |
@@ -4499,8 +4753,9 @@ discard block |
||
4499 | 4753 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4500 | 4754 | |
4501 | 4755 | // Do nothing, if it's already there. |
4502 | - if (in_array($integration_call, $functions)) |
|
4503 | - return; |
|
4756 | + if (in_array($integration_call, $functions)) { |
|
4757 | + return; |
|
4758 | + } |
|
4504 | 4759 | |
4505 | 4760 | $functions[] = $integration_call; |
4506 | 4761 | $modSettings[$hook] = implode(',', $functions); |
@@ -4523,12 +4778,14 @@ discard block |
||
4523 | 4778 | global $smcFunc, $modSettings; |
4524 | 4779 | |
4525 | 4780 | // Any objects? |
4526 | - if ($object) |
|
4527 | - $function = $function . '#'; |
|
4781 | + if ($object) { |
|
4782 | + $function = $function . '#'; |
|
4783 | + } |
|
4528 | 4784 | |
4529 | 4785 | // Any files to load? |
4530 | - if (!empty($file) && is_string($file)) |
|
4531 | - $function = $file . '|' . $function; |
|
4786 | + if (!empty($file) && is_string($file)) { |
|
4787 | + $function = $file . '|' . $function; |
|
4788 | + } |
|
4532 | 4789 | |
4533 | 4790 | // Get the correct string. |
4534 | 4791 | $integration_call = $function; |
@@ -4549,16 +4806,18 @@ discard block |
||
4549 | 4806 | { |
4550 | 4807 | $current_functions = explode(',', $current_functions); |
4551 | 4808 | |
4552 | - if (in_array($integration_call, $current_functions)) |
|
4553 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4809 | + if (in_array($integration_call, $current_functions)) { |
|
4810 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4811 | + } |
|
4554 | 4812 | } |
4555 | 4813 | |
4556 | 4814 | // Turn the function list into something usable. |
4557 | 4815 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4558 | 4816 | |
4559 | 4817 | // You can only remove it if it's available. |
4560 | - if (!in_array($integration_call, $functions)) |
|
4561 | - return; |
|
4818 | + if (!in_array($integration_call, $functions)) { |
|
4819 | + return; |
|
4820 | + } |
|
4562 | 4821 | |
4563 | 4822 | $functions = array_diff($functions, array($integration_call)); |
4564 | 4823 | $modSettings[$hook] = implode(',', $functions); |
@@ -4579,17 +4838,20 @@ discard block |
||
4579 | 4838 | global $context, $smcFunc, $txt, $db_show_debug; |
4580 | 4839 | |
4581 | 4840 | // Really? |
4582 | - if (empty($string)) |
|
4583 | - return false; |
|
4841 | + if (empty($string)) { |
|
4842 | + return false; |
|
4843 | + } |
|
4584 | 4844 | |
4585 | 4845 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
4586 | 4846 | // A closure? should be a callable one. |
4587 | - if (is_array($string) || $string instanceof Closure) |
|
4588 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4847 | + if (is_array($string) || $string instanceof Closure) { |
|
4848 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4849 | + } |
|
4589 | 4850 | |
4590 | 4851 | // No full objects, sorry! pass a method or a property instead! |
4591 | - if (is_object($string)) |
|
4592 | - return false; |
|
4852 | + if (is_object($string)) { |
|
4853 | + return false; |
|
4854 | + } |
|
4593 | 4855 | |
4594 | 4856 | // Stay vitaminized my friends... |
4595 | 4857 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4598,8 +4860,9 @@ discard block |
||
4598 | 4860 | $string = load_file($string); |
4599 | 4861 | |
4600 | 4862 | // Loaded file failed |
4601 | - if (empty($string)) |
|
4602 | - return false; |
|
4863 | + if (empty($string)) { |
|
4864 | + return false; |
|
4865 | + } |
|
4603 | 4866 | |
4604 | 4867 | // Found a method. |
4605 | 4868 | if (strpos($string, '::') !== false) |
@@ -4620,8 +4883,9 @@ discard block |
||
4620 | 4883 | // Add another one to the list. |
4621 | 4884 | if ($db_show_debug === true) |
4622 | 4885 | { |
4623 | - if (!isset($context['debug']['instances'])) |
|
4624 | - $context['debug']['instances'] = array(); |
|
4886 | + if (!isset($context['debug']['instances'])) { |
|
4887 | + $context['debug']['instances'] = array(); |
|
4888 | + } |
|
4625 | 4889 | |
4626 | 4890 | $context['debug']['instances'][$class] = $class; |
4627 | 4891 | } |
@@ -4631,13 +4895,15 @@ discard block |
||
4631 | 4895 | } |
4632 | 4896 | |
4633 | 4897 | // Right then. This is a call to a static method. |
4634 | - else |
|
4635 | - $func = array($class, $method); |
|
4898 | + else { |
|
4899 | + $func = array($class, $method); |
|
4900 | + } |
|
4636 | 4901 | } |
4637 | 4902 | |
4638 | 4903 | // Nope! just a plain regular function. |
4639 | - else |
|
4640 | - $func = $string; |
|
4904 | + else { |
|
4905 | + $func = $string; |
|
4906 | + } |
|
4641 | 4907 | |
4642 | 4908 | // Right, we got what we need, time to do some checks. |
4643 | 4909 | if (!is_callable($func, false, $callable_name)) |
@@ -4653,17 +4919,18 @@ discard block |
||
4653 | 4919 | else |
4654 | 4920 | { |
4655 | 4921 | // What are we gonna do about it? |
4656 | - if ($return) |
|
4657 | - return $func; |
|
4922 | + if ($return) { |
|
4923 | + return $func; |
|
4924 | + } |
|
4658 | 4925 | |
4659 | 4926 | // If this is a plain function, avoid the heat of calling call_user_func(). |
4660 | 4927 | else |
4661 | 4928 | { |
4662 | - if (is_array($func)) |
|
4663 | - call_user_func($func); |
|
4664 | - |
|
4665 | - else |
|
4666 | - $func(); |
|
4929 | + if (is_array($func)) { |
|
4930 | + call_user_func($func); |
|
4931 | + } else { |
|
4932 | + $func(); |
|
4933 | + } |
|
4667 | 4934 | } |
4668 | 4935 | } |
4669 | 4936 | } |
@@ -4680,31 +4947,34 @@ discard block |
||
4680 | 4947 | { |
4681 | 4948 | global $sourcedir, $txt, $boarddir, $settings; |
4682 | 4949 | |
4683 | - if (empty($string)) |
|
4684 | - return false; |
|
4950 | + if (empty($string)) { |
|
4951 | + return false; |
|
4952 | + } |
|
4685 | 4953 | |
4686 | 4954 | if (strpos($string, '|') !== false) |
4687 | 4955 | { |
4688 | 4956 | list ($file, $string) = explode('|', $string); |
4689 | 4957 | |
4690 | 4958 | // Match the wildcards to their regular vars. |
4691 | - if (empty($settings['theme_dir'])) |
|
4692 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4693 | - |
|
4694 | - else |
|
4695 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4959 | + if (empty($settings['theme_dir'])) { |
|
4960 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4961 | + } else { |
|
4962 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4963 | + } |
|
4696 | 4964 | |
4697 | 4965 | // Load the file if it can be loaded. |
4698 | - if (file_exists($absPath)) |
|
4699 | - require_once($absPath); |
|
4966 | + if (file_exists($absPath)) { |
|
4967 | + require_once($absPath); |
|
4968 | + } |
|
4700 | 4969 | |
4701 | 4970 | // No? try a fallback to $sourcedir |
4702 | 4971 | else |
4703 | 4972 | { |
4704 | 4973 | $absPath = $sourcedir .'/'. $file; |
4705 | 4974 | |
4706 | - if (file_exists($absPath)) |
|
4707 | - require_once($absPath); |
|
4975 | + if (file_exists($absPath)) { |
|
4976 | + require_once($absPath); |
|
4977 | + } |
|
4708 | 4978 | |
4709 | 4979 | // Sorry, can't do much for you at this point. |
4710 | 4980 | else |
@@ -4731,8 +5001,9 @@ discard block |
||
4731 | 5001 | global $user_info, $smcFunc; |
4732 | 5002 | |
4733 | 5003 | // Make sure we have something to work with. |
4734 | - if (empty($topic)) |
|
4735 | - return array(); |
|
5004 | + if (empty($topic)) { |
|
5005 | + return array(); |
|
5006 | + } |
|
4736 | 5007 | |
4737 | 5008 | |
4738 | 5009 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -4755,8 +5026,9 @@ discard block |
||
4755 | 5026 | 'topic' => $topic, |
4756 | 5027 | ) |
4757 | 5028 | ); |
4758 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
4759 | - $temp[] = (int) $row['content_id']; |
|
5029 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
5030 | + $temp[] = (int) $row['content_id']; |
|
5031 | + } |
|
4760 | 5032 | |
4761 | 5033 | cache_put_data($cache_key, $temp, $ttl); |
4762 | 5034 | } |
@@ -4777,8 +5049,9 @@ discard block |
||
4777 | 5049 | { |
4778 | 5050 | global $context; |
4779 | 5051 | |
4780 | - if (empty($string)) |
|
4781 | - return $string; |
|
5052 | + if (empty($string)) { |
|
5053 | + return $string; |
|
5054 | + } |
|
4782 | 5055 | |
4783 | 5056 | // UTF-8 occurences of MS special characters |
4784 | 5057 | $findchars_utf8 = array( |
@@ -4819,10 +5092,11 @@ discard block |
||
4819 | 5092 | '--', // — |
4820 | 5093 | ); |
4821 | 5094 | |
4822 | - if ($context['utf8']) |
|
4823 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
4824 | - else |
|
4825 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
5095 | + if ($context['utf8']) { |
|
5096 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
5097 | + } else { |
|
5098 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
5099 | + } |
|
4826 | 5100 | |
4827 | 5101 | return $string; |
4828 | 5102 | } |
@@ -4841,49 +5115,59 @@ discard block |
||
4841 | 5115 | { |
4842 | 5116 | global $context; |
4843 | 5117 | |
4844 | - if (!isset($matches[2])) |
|
4845 | - return ''; |
|
5118 | + if (!isset($matches[2])) { |
|
5119 | + return ''; |
|
5120 | + } |
|
4846 | 5121 | |
4847 | 5122 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4848 | 5123 | |
4849 | 5124 | // remove left to right / right to left overrides |
4850 | - if ($num === 0x202D || $num === 0x202E) |
|
4851 | - return ''; |
|
5125 | + if ($num === 0x202D || $num === 0x202E) { |
|
5126 | + return ''; |
|
5127 | + } |
|
4852 | 5128 | |
4853 | 5129 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
4854 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
4855 | - return '&#' . $num . ';'; |
|
5130 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
5131 | + return '&#' . $num . ';'; |
|
5132 | + } |
|
4856 | 5133 | |
4857 | 5134 | if (empty($context['utf8'])) |
4858 | 5135 | { |
4859 | 5136 | // no control characters |
4860 | - if ($num < 0x20) |
|
4861 | - return ''; |
|
5137 | + if ($num < 0x20) { |
|
5138 | + return ''; |
|
5139 | + } |
|
4862 | 5140 | // text is text |
4863 | - elseif ($num < 0x80) |
|
4864 | - return chr($num); |
|
5141 | + elseif ($num < 0x80) { |
|
5142 | + return chr($num); |
|
5143 | + } |
|
4865 | 5144 | // all others get html-ised |
4866 | - else |
|
4867 | - return '&#' . $matches[2] . ';'; |
|
4868 | - } |
|
4869 | - else |
|
5145 | + else { |
|
5146 | + return '&#' . $matches[2] . ';'; |
|
5147 | + } |
|
5148 | + } else |
|
4870 | 5149 | { |
4871 | 5150 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
4872 | 5151 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
4873 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
4874 | - return ''; |
|
5152 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
5153 | + return ''; |
|
5154 | + } |
|
4875 | 5155 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4876 | - elseif ($num < 0x80) |
|
4877 | - return chr($num); |
|
5156 | + elseif ($num < 0x80) { |
|
5157 | + return chr($num); |
|
5158 | + } |
|
4878 | 5159 | // <0x800 (2048) |
4879 | - elseif ($num < 0x800) |
|
4880 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5160 | + elseif ($num < 0x800) { |
|
5161 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5162 | + } |
|
4881 | 5163 | // < 0x10000 (65536) |
4882 | - elseif ($num < 0x10000) |
|
4883 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5164 | + elseif ($num < 0x10000) { |
|
5165 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5166 | + } |
|
4884 | 5167 | // <= 0x10FFFF (1114111) |
4885 | - else |
|
4886 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5168 | + else { |
|
5169 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5170 | + } |
|
4887 | 5171 | } |
4888 | 5172 | } |
4889 | 5173 | |
@@ -4899,28 +5183,34 @@ discard block |
||
4899 | 5183 | */ |
4900 | 5184 | function fixchar__callback($matches) |
4901 | 5185 | { |
4902 | - if (!isset($matches[1])) |
|
4903 | - return ''; |
|
5186 | + if (!isset($matches[1])) { |
|
5187 | + return ''; |
|
5188 | + } |
|
4904 | 5189 | |
4905 | 5190 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
4906 | 5191 | |
4907 | 5192 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
4908 | 5193 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
4909 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
4910 | - return ''; |
|
5194 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
5195 | + return ''; |
|
5196 | + } |
|
4911 | 5197 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4912 | - elseif ($num < 0x80) |
|
4913 | - return chr($num); |
|
5198 | + elseif ($num < 0x80) { |
|
5199 | + return chr($num); |
|
5200 | + } |
|
4914 | 5201 | // <0x800 (2048) |
4915 | - elseif ($num < 0x800) |
|
4916 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5202 | + elseif ($num < 0x800) { |
|
5203 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5204 | + } |
|
4917 | 5205 | // < 0x10000 (65536) |
4918 | - elseif ($num < 0x10000) |
|
4919 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5206 | + elseif ($num < 0x10000) { |
|
5207 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5208 | + } |
|
4920 | 5209 | // <= 0x10FFFF (1114111) |
4921 | - else |
|
4922 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
4923 | -} |
|
5210 | + else { |
|
5211 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5212 | + } |
|
5213 | + } |
|
4924 | 5214 | |
4925 | 5215 | /** |
4926 | 5216 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -4933,17 +5223,19 @@ discard block |
||
4933 | 5223 | */ |
4934 | 5224 | function entity_fix__callback($matches) |
4935 | 5225 | { |
4936 | - if (!isset($matches[2])) |
|
4937 | - return ''; |
|
5226 | + if (!isset($matches[2])) { |
|
5227 | + return ''; |
|
5228 | + } |
|
4938 | 5229 | |
4939 | 5230 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4940 | 5231 | |
4941 | 5232 | // we don't allow control characters, characters out of range, byte markers, etc |
4942 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
4943 | - return ''; |
|
4944 | - else |
|
4945 | - return '&#' . $num . ';'; |
|
4946 | -} |
|
5233 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
5234 | + return ''; |
|
5235 | + } else { |
|
5236 | + return '&#' . $num . ';'; |
|
5237 | + } |
|
5238 | + } |
|
4947 | 5239 | |
4948 | 5240 | /** |
4949 | 5241 | * Return a Gravatar URL based on |
@@ -4967,18 +5259,23 @@ discard block |
||
4967 | 5259 | $ratings = array('G', 'PG', 'R', 'X'); |
4968 | 5260 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
4969 | 5261 | $url_params = array(); |
4970 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
4971 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
4972 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
4973 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
4974 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
4975 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
4976 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
4977 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
5262 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
5263 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
5264 | + } |
|
5265 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
5266 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
5267 | + } |
|
5268 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
5269 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
5270 | + } |
|
5271 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
5272 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
4978 | 5273 | $size_string = $modSettings['avatar_max_height_external']; |
5274 | + } |
|
4979 | 5275 | |
4980 | - if (!empty($size_string)) |
|
4981 | - $url_params[] = 's=' . $size_string; |
|
5276 | + if (!empty($size_string)) { |
|
5277 | + $url_params[] = 's=' . $size_string; |
|
5278 | + } |
|
4982 | 5279 | } |
4983 | 5280 | $http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www'; |
4984 | 5281 | |
@@ -4997,22 +5294,26 @@ discard block |
||
4997 | 5294 | static $timezones = null, $lastwhen = null; |
4998 | 5295 | |
4999 | 5296 | // No point doing this over if we already did it once |
5000 | - if (!empty($timezones) && $when == $lastwhen) |
|
5001 | - return $timezones; |
|
5002 | - else |
|
5003 | - $lastwhen = $when; |
|
5297 | + if (!empty($timezones) && $when == $lastwhen) { |
|
5298 | + return $timezones; |
|
5299 | + } else { |
|
5300 | + $lastwhen = $when; |
|
5301 | + } |
|
5004 | 5302 | |
5005 | 5303 | // Parseable datetime string? |
5006 | - if (is_int($timestamp = strtotime($when))) |
|
5007 | - $when = $timestamp; |
|
5304 | + if (is_int($timestamp = strtotime($when))) { |
|
5305 | + $when = $timestamp; |
|
5306 | + } |
|
5008 | 5307 | |
5009 | 5308 | // A Unix timestamp? |
5010 | - elseif (is_numeric($when)) |
|
5011 | - $when = intval($when); |
|
5309 | + elseif (is_numeric($when)) { |
|
5310 | + $when = intval($when); |
|
5311 | + } |
|
5012 | 5312 | |
5013 | 5313 | // Invalid value? Just get current Unix timestamp. |
5014 | - else |
|
5015 | - $when = time(); |
|
5314 | + else { |
|
5315 | + $when = time(); |
|
5316 | + } |
|
5016 | 5317 | |
5017 | 5318 | // We'll need these too |
5018 | 5319 | $date_when = date_create('@' . $when); |
@@ -5076,8 +5377,9 @@ discard block |
||
5076 | 5377 | foreach ($priority_countries as $country) |
5077 | 5378 | { |
5078 | 5379 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
5079 | - if (!empty($country_tzids)) |
|
5080 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5380 | + if (!empty($country_tzids)) { |
|
5381 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5382 | + } |
|
5081 | 5383 | } |
5082 | 5384 | |
5083 | 5385 | // Process the preferred timezones first, then the rest. |
@@ -5087,8 +5389,9 @@ discard block |
||
5087 | 5389 | foreach ($tzids as $tzid) |
5088 | 5390 | { |
5089 | 5391 | // We don't want UTC right now |
5090 | - if ($tzid == 'UTC') |
|
5091 | - continue; |
|
5392 | + if ($tzid == 'UTC') { |
|
5393 | + continue; |
|
5394 | + } |
|
5092 | 5395 | |
5093 | 5396 | $tz = timezone_open($tzid); |
5094 | 5397 | |
@@ -5109,8 +5412,9 @@ discard block |
||
5109 | 5412 | } |
5110 | 5413 | |
5111 | 5414 | // A time zone from a prioritized country? |
5112 | - if (in_array($tzid, $priority_tzids)) |
|
5113 | - $priority_zones[$tzkey] = true; |
|
5415 | + if (in_array($tzid, $priority_tzids)) { |
|
5416 | + $priority_zones[$tzkey] = true; |
|
5417 | + } |
|
5114 | 5418 | |
5115 | 5419 | // Keep track of the location and offset for this tzid |
5116 | 5420 | $tzid_parts = explode('/', $tzid); |
@@ -5129,15 +5433,17 @@ discard block |
||
5129 | 5433 | { |
5130 | 5434 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
5131 | 5435 | |
5132 | - if (!empty($timezone_descriptions[$tzvalue['tzid']])) |
|
5133 | - $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5134 | - else |
|
5135 | - $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5436 | + if (!empty($timezone_descriptions[$tzvalue['tzid']])) { |
|
5437 | + $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5438 | + } else { |
|
5439 | + $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5440 | + } |
|
5136 | 5441 | |
5137 | - if (isset($priority_zones[$tzkey])) |
|
5138 | - $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5139 | - else |
|
5140 | - $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5442 | + if (isset($priority_zones[$tzkey])) { |
|
5443 | + $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5444 | + } else { |
|
5445 | + $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5446 | + } |
|
5141 | 5447 | } |
5142 | 5448 | |
5143 | 5449 | $timezones = array_merge( |
@@ -5191,9 +5497,9 @@ discard block |
||
5191 | 5497 | 'Indian/Kerguelen' => 'TFT', |
5192 | 5498 | ); |
5193 | 5499 | |
5194 | - if (!empty($missing_tz_abbrs[$tzid])) |
|
5195 | - $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5196 | - else |
|
5500 | + if (!empty($missing_tz_abbrs[$tzid])) { |
|
5501 | + $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5502 | + } else |
|
5197 | 5503 | { |
5198 | 5504 | // Russia likes to experiment with time zones often, and names them as offsets from Moscow |
5199 | 5505 | $tz_location = timezone_location_get(timezone_open($tzid)); |
@@ -5221,8 +5527,9 @@ discard block |
||
5221 | 5527 | */ |
5222 | 5528 | function inet_ptod($ip_address) |
5223 | 5529 | { |
5224 | - if (!isValidIP($ip_address)) |
|
5225 | - return $ip_address; |
|
5530 | + if (!isValidIP($ip_address)) { |
|
5531 | + return $ip_address; |
|
5532 | + } |
|
5226 | 5533 | |
5227 | 5534 | $bin = inet_pton($ip_address); |
5228 | 5535 | return $bin; |
@@ -5234,13 +5541,15 @@ discard block |
||
5234 | 5541 | */ |
5235 | 5542 | function inet_dtop($bin) |
5236 | 5543 | { |
5237 | - if(empty($bin)) |
|
5238 | - return ''; |
|
5544 | + if(empty($bin)) { |
|
5545 | + return ''; |
|
5546 | + } |
|
5239 | 5547 | |
5240 | 5548 | global $db_type; |
5241 | 5549 | |
5242 | - if ($db_type == 'postgresql') |
|
5243 | - return $bin; |
|
5550 | + if ($db_type == 'postgresql') { |
|
5551 | + return $bin; |
|
5552 | + } |
|
5244 | 5553 | |
5245 | 5554 | $ip_address = inet_ntop($bin); |
5246 | 5555 | |
@@ -5265,26 +5574,32 @@ discard block |
||
5265 | 5574 | */ |
5266 | 5575 | function _safe_serialize($value) |
5267 | 5576 | { |
5268 | - if(is_null($value)) |
|
5269 | - return 'N;'; |
|
5577 | + if(is_null($value)) { |
|
5578 | + return 'N;'; |
|
5579 | + } |
|
5270 | 5580 | |
5271 | - if(is_bool($value)) |
|
5272 | - return 'b:'. (int) $value .';'; |
|
5581 | + if(is_bool($value)) { |
|
5582 | + return 'b:'. (int) $value .';'; |
|
5583 | + } |
|
5273 | 5584 | |
5274 | - if(is_int($value)) |
|
5275 | - return 'i:'. $value .';'; |
|
5585 | + if(is_int($value)) { |
|
5586 | + return 'i:'. $value .';'; |
|
5587 | + } |
|
5276 | 5588 | |
5277 | - if(is_float($value)) |
|
5278 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5589 | + if(is_float($value)) { |
|
5590 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
5591 | + } |
|
5279 | 5592 | |
5280 | - if(is_string($value)) |
|
5281 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5593 | + if(is_string($value)) { |
|
5594 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
5595 | + } |
|
5282 | 5596 | |
5283 | 5597 | if(is_array($value)) |
5284 | 5598 | { |
5285 | 5599 | $out = ''; |
5286 | - foreach($value as $k => $v) |
|
5287 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5600 | + foreach($value as $k => $v) { |
|
5601 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5602 | + } |
|
5288 | 5603 | |
5289 | 5604 | return 'a:'. count($value) .':{'. $out .'}'; |
5290 | 5605 | } |
@@ -5310,8 +5625,9 @@ discard block |
||
5310 | 5625 | |
5311 | 5626 | $out = _safe_serialize($value); |
5312 | 5627 | |
5313 | - if (isset($mbIntEnc)) |
|
5314 | - mb_internal_encoding($mbIntEnc); |
|
5628 | + if (isset($mbIntEnc)) { |
|
5629 | + mb_internal_encoding($mbIntEnc); |
|
5630 | + } |
|
5315 | 5631 | |
5316 | 5632 | return $out; |
5317 | 5633 | } |
@@ -5328,8 +5644,9 @@ discard block |
||
5328 | 5644 | function _safe_unserialize($str) |
5329 | 5645 | { |
5330 | 5646 | // Input is not a string. |
5331 | - if(empty($str) || !is_string($str)) |
|
5332 | - return false; |
|
5647 | + if(empty($str) || !is_string($str)) { |
|
5648 | + return false; |
|
5649 | + } |
|
5333 | 5650 | |
5334 | 5651 | $stack = array(); |
5335 | 5652 | $expected = array(); |
@@ -5345,43 +5662,38 @@ discard block |
||
5345 | 5662 | while($state != 1) |
5346 | 5663 | { |
5347 | 5664 | $type = isset($str[0]) ? $str[0] : ''; |
5348 | - if($type == '}') |
|
5349 | - $str = substr($str, 1); |
|
5350 | - |
|
5351 | - else if($type == 'N' && $str[1] == ';') |
|
5665 | + if($type == '}') { |
|
5666 | + $str = substr($str, 1); |
|
5667 | + } else if($type == 'N' && $str[1] == ';') |
|
5352 | 5668 | { |
5353 | 5669 | $value = null; |
5354 | 5670 | $str = substr($str, 2); |
5355 | - } |
|
5356 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5671 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5357 | 5672 | { |
5358 | 5673 | $value = $matches[1] == '1' ? true : false; |
5359 | 5674 | $str = substr($str, 4); |
5360 | - } |
|
5361 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5675 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5362 | 5676 | { |
5363 | 5677 | $value = (int)$matches[1]; |
5364 | 5678 | $str = $matches[2]; |
5365 | - } |
|
5366 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5679 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5367 | 5680 | { |
5368 | 5681 | $value = (float)$matches[1]; |
5369 | 5682 | $str = $matches[3]; |
5370 | - } |
|
5371 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5683 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5372 | 5684 | { |
5373 | 5685 | $value = substr($matches[2], 0, (int)$matches[1]); |
5374 | 5686 | $str = substr($matches[2], (int)$matches[1] + 2); |
5375 | - } |
|
5376 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5687 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5377 | 5688 | { |
5378 | 5689 | $expectedLength = (int)$matches[1]; |
5379 | 5690 | $str = $matches[2]; |
5380 | 5691 | } |
5381 | 5692 | |
5382 | 5693 | // Object or unknown/malformed type. |
5383 | - else |
|
5384 | - return false; |
|
5694 | + else { |
|
5695 | + return false; |
|
5696 | + } |
|
5385 | 5697 | |
5386 | 5698 | switch($state) |
5387 | 5699 | { |
@@ -5409,8 +5721,9 @@ discard block |
||
5409 | 5721 | if($type == '}') |
5410 | 5722 | { |
5411 | 5723 | // Array size is less than expected. |
5412 | - if(count($list) < end($expected)) |
|
5413 | - return false; |
|
5724 | + if(count($list) < end($expected)) { |
|
5725 | + return false; |
|
5726 | + } |
|
5414 | 5727 | |
5415 | 5728 | unset($list); |
5416 | 5729 | $list = &$stack[count($stack)-1]; |
@@ -5419,8 +5732,9 @@ discard block |
||
5419 | 5732 | // Go to terminal state if we're at the end of the root array. |
5420 | 5733 | array_pop($expected); |
5421 | 5734 | |
5422 | - if(count($expected) == 0) |
|
5423 | - $state = 1; |
|
5735 | + if(count($expected) == 0) { |
|
5736 | + $state = 1; |
|
5737 | + } |
|
5424 | 5738 | |
5425 | 5739 | break; |
5426 | 5740 | } |
@@ -5428,8 +5742,9 @@ discard block |
||
5428 | 5742 | if($type == 'i' || $type == 's') |
5429 | 5743 | { |
5430 | 5744 | // Array size exceeds expected length. |
5431 | - if(count($list) >= end($expected)) |
|
5432 | - return false; |
|
5745 | + if(count($list) >= end($expected)) { |
|
5746 | + return false; |
|
5747 | + } |
|
5433 | 5748 | |
5434 | 5749 | $key = $value; |
5435 | 5750 | $state = 3; |
@@ -5463,8 +5778,9 @@ discard block |
||
5463 | 5778 | } |
5464 | 5779 | |
5465 | 5780 | // Trailing data in input. |
5466 | - if(!empty($str)) |
|
5467 | - return false; |
|
5781 | + if(!empty($str)) { |
|
5782 | + return false; |
|
5783 | + } |
|
5468 | 5784 | |
5469 | 5785 | return $data; |
5470 | 5786 | } |
@@ -5487,8 +5803,9 @@ discard block |
||
5487 | 5803 | |
5488 | 5804 | $out = _safe_unserialize($str); |
5489 | 5805 | |
5490 | - if (isset($mbIntEnc)) |
|
5491 | - mb_internal_encoding($mbIntEnc); |
|
5806 | + if (isset($mbIntEnc)) { |
|
5807 | + mb_internal_encoding($mbIntEnc); |
|
5808 | + } |
|
5492 | 5809 | |
5493 | 5810 | return $out; |
5494 | 5811 | } |
@@ -5503,12 +5820,14 @@ discard block |
||
5503 | 5820 | function smf_chmod($file, $value = 0) |
5504 | 5821 | { |
5505 | 5822 | // No file? no checks! |
5506 | - if (empty($file)) |
|
5507 | - return false; |
|
5823 | + if (empty($file)) { |
|
5824 | + return false; |
|
5825 | + } |
|
5508 | 5826 | |
5509 | 5827 | // Already writable? |
5510 | - if (is_writable($file)) |
|
5511 | - return true; |
|
5828 | + if (is_writable($file)) { |
|
5829 | + return true; |
|
5830 | + } |
|
5512 | 5831 | |
5513 | 5832 | // Do we have a file or a dir? |
5514 | 5833 | $isDir = is_dir($file); |
@@ -5524,10 +5843,9 @@ discard block |
||
5524 | 5843 | { |
5525 | 5844 | $isWritable = true; |
5526 | 5845 | break; |
5846 | + } else { |
|
5847 | + @chmod($file, $val); |
|
5527 | 5848 | } |
5528 | - |
|
5529 | - else |
|
5530 | - @chmod($file, $val); |
|
5531 | 5849 | } |
5532 | 5850 | |
5533 | 5851 | return $isWritable; |
@@ -5546,8 +5864,9 @@ discard block |
||
5546 | 5864 | global $txt; |
5547 | 5865 | |
5548 | 5866 | // Come on... |
5549 | - if (empty($json) || !is_string($json)) |
|
5550 | - return array(); |
|
5867 | + if (empty($json) || !is_string($json)) { |
|
5868 | + return array(); |
|
5869 | + } |
|
5551 | 5870 | |
5552 | 5871 | $returnArray = @json_decode($json, $returnAsArray); |
5553 | 5872 | |
@@ -5585,11 +5904,11 @@ discard block |
||
5585 | 5904 | $jsonDebug = $jsonDebug[0]; |
5586 | 5905 | loadLanguage('Errors'); |
5587 | 5906 | |
5588 | - if (!empty($jsonDebug)) |
|
5589 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5590 | - |
|
5591 | - else |
|
5592 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5907 | + if (!empty($jsonDebug)) { |
|
5908 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5909 | + } else { |
|
5910 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
5911 | + } |
|
5593 | 5912 | |
5594 | 5913 | // Everyone expects an array. |
5595 | 5914 | return array(); |
@@ -5623,8 +5942,9 @@ discard block |
||
5623 | 5942 | global $db_show_debug, $modSettings; |
5624 | 5943 | |
5625 | 5944 | // Defensive programming anyone? |
5626 | - if (empty($data)) |
|
5627 | - return false; |
|
5945 | + if (empty($data)) { |
|
5946 | + return false; |
|
5947 | + } |
|
5628 | 5948 | |
5629 | 5949 | // Don't need extra stuff... |
5630 | 5950 | $db_show_debug = false; |
@@ -5632,11 +5952,11 @@ discard block |
||
5632 | 5952 | // Kill anything else. |
5633 | 5953 | ob_end_clean(); |
5634 | 5954 | |
5635 | - if (!empty($modSettings['CompressedOutput'])) |
|
5636 | - @ob_start('ob_gzhandler'); |
|
5637 | - |
|
5638 | - else |
|
5639 | - ob_start(); |
|
5955 | + if (!empty($modSettings['CompressedOutput'])) { |
|
5956 | + @ob_start('ob_gzhandler'); |
|
5957 | + } else { |
|
5958 | + ob_start(); |
|
5959 | + } |
|
5640 | 5960 | |
5641 | 5961 | // Set the header. |
5642 | 5962 | header($type); |
@@ -5668,8 +5988,9 @@ discard block |
||
5668 | 5988 | static $done = false; |
5669 | 5989 | |
5670 | 5990 | // If we don't need to do anything, don't |
5671 | - if (!$update && $done) |
|
5672 | - return; |
|
5991 | + if (!$update && $done) { |
|
5992 | + return; |
|
5993 | + } |
|
5673 | 5994 | |
5674 | 5995 | // Should we get a new copy of the official list of TLDs? |
5675 | 5996 | if ($update) |
@@ -5678,8 +5999,9 @@ discard block |
||
5678 | 5999 | $tlds = fetch_web_data('https://data.iana.org/TLD/tlds-alpha-by-domain.txt'); |
5679 | 6000 | |
5680 | 6001 | // If the Internet Assigned Numbers Authority can't be reached, the Internet is gone. We're probably running on a server hidden in a bunker deep underground to protect it from marauding bandits roaming on the surface. We don't want to waste precious electricity on pointlessly repeating background tasks, so we'll wait until the next regularly scheduled update to see if civilization has been restored. |
5681 | - if ($tlds === false) |
|
5682 | - $postapocalypticNightmare = true; |
|
6002 | + if ($tlds === false) { |
|
6003 | + $postapocalypticNightmare = true; |
|
6004 | + } |
|
5683 | 6005 | } |
5684 | 6006 | // If we aren't updating and the regex is valid, we're done |
5685 | 6007 | elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false) |
@@ -5694,10 +6016,11 @@ discard block |
||
5694 | 6016 | // Clean $tlds and convert it to an array |
5695 | 6017 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
5696 | 6018 | $line = trim($line); |
5697 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
5698 | - return false; |
|
5699 | - else |
|
5700 | - return true; |
|
6019 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
6020 | + return false; |
|
6021 | + } else { |
|
6022 | + return true; |
|
6023 | + } |
|
5701 | 6024 | }); |
5702 | 6025 | |
5703 | 6026 | // Convert Punycode to Unicode |
@@ -5751,8 +6074,9 @@ discard block |
||
5751 | 6074 | $idx += $digit * $w; |
5752 | 6075 | $t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias)); |
5753 | 6076 | |
5754 | - if ($digit < $t) |
|
5755 | - break; |
|
6077 | + if ($digit < $t) { |
|
6078 | + break; |
|
6079 | + } |
|
5756 | 6080 | |
5757 | 6081 | $w = (int) ($w * ($base - $t)); |
5758 | 6082 | } |
@@ -5761,8 +6085,9 @@ discard block |
||
5761 | 6085 | $delta = intval($is_first ? ($delta / $damp) : ($delta / 2)); |
5762 | 6086 | $delta += intval($delta / ($deco_len + 1)); |
5763 | 6087 | |
5764 | - for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) |
|
5765 | - $delta = intval($delta / ($base - $tmin)); |
|
6088 | + for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) { |
|
6089 | + $delta = intval($delta / ($base - $tmin)); |
|
6090 | + } |
|
5766 | 6091 | |
5767 | 6092 | $bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew)); |
5768 | 6093 | $is_first = false; |
@@ -5771,8 +6096,9 @@ discard block |
||
5771 | 6096 | |
5772 | 6097 | if ($deco_len > 0) |
5773 | 6098 | { |
5774 | - for ($i = $deco_len; $i > $idx; $i--) |
|
5775 | - $decoded[$i] = $decoded[($i - 1)]; |
|
6099 | + for ($i = $deco_len; $i > $idx; $i--) { |
|
6100 | + $decoded[$i] = $decoded[($i - 1)]; |
|
6101 | + } |
|
5776 | 6102 | } |
5777 | 6103 | $decoded[$idx++] = $char; |
5778 | 6104 | } |
@@ -5780,24 +6106,29 @@ discard block |
||
5780 | 6106 | foreach ($decoded as $k => $v) |
5781 | 6107 | { |
5782 | 6108 | // 7bit are transferred literally |
5783 | - if ($v < 128) |
|
5784 | - $output .= chr($v); |
|
6109 | + if ($v < 128) { |
|
6110 | + $output .= chr($v); |
|
6111 | + } |
|
5785 | 6112 | |
5786 | 6113 | // 2 bytes |
5787 | - elseif ($v < (1 << 11)) |
|
5788 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6114 | + elseif ($v < (1 << 11)) { |
|
6115 | + $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6116 | + } |
|
5789 | 6117 | |
5790 | 6118 | // 3 bytes |
5791 | - elseif ($v < (1 << 16)) |
|
5792 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6119 | + elseif ($v < (1 << 16)) { |
|
6120 | + $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6121 | + } |
|
5793 | 6122 | |
5794 | 6123 | // 4 bytes |
5795 | - elseif ($v < (1 << 21)) |
|
5796 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6124 | + elseif ($v < (1 << 21)) { |
|
6125 | + $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6126 | + } |
|
5797 | 6127 | |
5798 | 6128 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5799 | - else |
|
5800 | - $output .= $safe_char; |
|
6129 | + else { |
|
6130 | + $output .= $safe_char; |
|
6131 | + } |
|
5801 | 6132 | } |
5802 | 6133 | |
5803 | 6134 | $output_parts[] = $output; |
@@ -5890,8 +6221,7 @@ discard block |
||
5890 | 6221 | |
5891 | 6222 | $strlen = 'mb_strlen'; |
5892 | 6223 | $substr = 'mb_substr'; |
5893 | - } |
|
5894 | - else |
|
6224 | + } else |
|
5895 | 6225 | { |
5896 | 6226 | $strlen = $smcFunc['strlen']; |
5897 | 6227 | $substr = $smcFunc['substr']; |
@@ -5905,20 +6235,21 @@ discard block |
||
5905 | 6235 | |
5906 | 6236 | $first = $substr($string, 0, 1); |
5907 | 6237 | |
5908 | - if (empty($index[$first])) |
|
5909 | - $index[$first] = array(); |
|
6238 | + if (empty($index[$first])) { |
|
6239 | + $index[$first] = array(); |
|
6240 | + } |
|
5910 | 6241 | |
5911 | 6242 | if ($strlen($string) > 1) |
5912 | 6243 | { |
5913 | 6244 | // Sanity check on recursion |
5914 | - if ($depth > 99) |
|
5915 | - $index[$first][$substr($string, 1)] = ''; |
|
5916 | - |
|
5917 | - else |
|
5918 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6245 | + if ($depth > 99) { |
|
6246 | + $index[$first][$substr($string, 1)] = ''; |
|
6247 | + } else { |
|
6248 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6249 | + } |
|
6250 | + } else { |
|
6251 | + $index[$first][''] = ''; |
|
5919 | 6252 | } |
5920 | - else |
|
5921 | - $index[$first][''] = ''; |
|
5922 | 6253 | |
5923 | 6254 | $depth--; |
5924 | 6255 | return $index; |
@@ -5941,9 +6272,9 @@ discard block |
||
5941 | 6272 | $key_regex = preg_quote($key, $delim); |
5942 | 6273 | $new_key = $key; |
5943 | 6274 | |
5944 | - if (empty($value)) |
|
5945 | - $sub_regex = ''; |
|
5946 | - else |
|
6275 | + if (empty($value)) { |
|
6276 | + $sub_regex = ''; |
|
6277 | + } else |
|
5947 | 6278 | { |
5948 | 6279 | $sub_regex = $index_to_regex($value, $delim); |
5949 | 6280 | |
@@ -5951,22 +6282,22 @@ discard block |
||
5951 | 6282 | { |
5952 | 6283 | $new_key_array = explode('(?'.'>', $sub_regex); |
5953 | 6284 | $new_key .= $new_key_array[0]; |
6285 | + } else { |
|
6286 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5954 | 6287 | } |
5955 | - else |
|
5956 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5957 | 6288 | } |
5958 | 6289 | |
5959 | - if ($depth > 1) |
|
5960 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
5961 | - else |
|
6290 | + if ($depth > 1) { |
|
6291 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
6292 | + } else |
|
5962 | 6293 | { |
5963 | 6294 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
5964 | 6295 | { |
5965 | 6296 | $regex[$new_key] = $key_regex . $sub_regex; |
5966 | 6297 | unset($index[$key]); |
6298 | + } else { |
|
6299 | + break; |
|
5967 | 6300 | } |
5968 | - else |
|
5969 | - break; |
|
5970 | 6301 | } |
5971 | 6302 | } |
5972 | 6303 | |
@@ -5975,10 +6306,11 @@ discard block |
||
5975 | 6306 | $l1 = $strlen($k1); |
5976 | 6307 | $l2 = $strlen($k2); |
5977 | 6308 | |
5978 | - if ($l1 == $l2) |
|
5979 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
5980 | - else |
|
5981 | - return $l1 > $l2 ? -1 : 1; |
|
6309 | + if ($l1 == $l2) { |
|
6310 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
6311 | + } else { |
|
6312 | + return $l1 > $l2 ? -1 : 1; |
|
6313 | + } |
|
5982 | 6314 | }); |
5983 | 6315 | |
5984 | 6316 | $depth--; |
@@ -5989,21 +6321,24 @@ discard block |
||
5989 | 6321 | $index = array(); |
5990 | 6322 | $regex = ''; |
5991 | 6323 | |
5992 | - foreach ($strings as $string) |
|
5993 | - $index = $add_string_to_index($string, $index); |
|
6324 | + foreach ($strings as $string) { |
|
6325 | + $index = $add_string_to_index($string, $index); |
|
6326 | + } |
|
5994 | 6327 | |
5995 | 6328 | if ($returnArray === true) |
5996 | 6329 | { |
5997 | 6330 | $regex = array(); |
5998 | - while (!empty($index)) |
|
5999 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6331 | + while (!empty($index)) { |
|
6332 | + $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6333 | + } |
|
6334 | + } else { |
|
6335 | + $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6000 | 6336 | } |
6001 | - else |
|
6002 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6003 | 6337 | |
6004 | 6338 | // Restore PHP's internal character encoding to whatever it was originally |
6005 | - if (!empty($current_encoding)) |
|
6006 | - mb_internal_encoding($current_encoding); |
|
6339 | + if (!empty($current_encoding)) { |
|
6340 | + mb_internal_encoding($current_encoding); |
|
6341 | + } |
|
6007 | 6342 | |
6008 | 6343 | return $regex; |
6009 | 6344 | } |
@@ -6043,13 +6378,15 @@ discard block |
||
6043 | 6378 | // Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't... |
6044 | 6379 | $url = str_ireplace('https://', 'http://', $url) . '/'; |
6045 | 6380 | $headers = @get_headers($url); |
6046 | - if ($headers === false) |
|
6047 | - return false; |
|
6381 | + if ($headers === false) { |
|
6382 | + return false; |
|
6383 | + } |
|
6048 | 6384 | |
6049 | 6385 | // Now to see if it came back https... |
6050 | 6386 | // First check for a redirect status code in first row (301, 302, 307) |
6051 | - if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) |
|
6052 | - return false; |
|
6387 | + if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) { |
|
6388 | + return false; |
|
6389 | + } |
|
6053 | 6390 | |
6054 | 6391 | // Search for the location entry to confirm https |
6055 | 6392 | $result = false; |
@@ -6085,8 +6422,7 @@ discard block |
||
6085 | 6422 | $is_admin = $user_info['is_admin']; |
6086 | 6423 | $mod_cache = !empty($user_info['mod_cache']) ? $user_info['mod_cache'] : null; |
6087 | 6424 | $ignoreboards = !empty($user_info['ignoreboards']) ? $user_info['ignoreboards'] : null; |
6088 | - } |
|
6089 | - else |
|
6425 | + } else |
|
6090 | 6426 | { |
6091 | 6427 | $request = $smcFunc['db_query']('', ' |
6092 | 6428 | SELECT mem.ignore_boards, mem.id_group, mem.additional_groups, mem.id_post_group |
@@ -6100,17 +6436,19 @@ discard block |
||
6100 | 6436 | |
6101 | 6437 | $row = $smcFunc['db_fetch_assoc']($request); |
6102 | 6438 | |
6103 | - if (empty($row['additional_groups'])) |
|
6104 | - $groups = array($row['id_group'], $user_settings['id_post_group']); |
|
6105 | - else |
|
6106 | - $groups = array_merge( |
|
6439 | + if (empty($row['additional_groups'])) { |
|
6440 | + $groups = array($row['id_group'], $user_settings['id_post_group']); |
|
6441 | + } else { |
|
6442 | + $groups = array_merge( |
|
6107 | 6443 | array($row['id_group'], $user_settings['id_post_group']), |
6108 | 6444 | explode(',', $row['additional_groups']) |
6109 | 6445 | ); |
6446 | + } |
|
6110 | 6447 | |
6111 | 6448 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
6112 | - foreach ($groups as $k => $v) |
|
6113 | - $groups[$k] = (int) $v; |
|
6449 | + foreach ($groups as $k => $v) { |
|
6450 | + $groups[$k] = (int) $v; |
|
6451 | + } |
|
6114 | 6452 | |
6115 | 6453 | $is_admin = in_array(1, $groups); |
6116 | 6454 | |
@@ -6127,8 +6465,9 @@ discard block |
||
6127 | 6465 | 'current_member' => $userid, |
6128 | 6466 | ) |
6129 | 6467 | ); |
6130 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6131 | - $boards_mod[] = $row['id_board']; |
|
6468 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6469 | + $boards_mod[] = $row['id_board']; |
|
6470 | + } |
|
6132 | 6471 | $smcFunc['db_free_result']($request); |
6133 | 6472 | |
6134 | 6473 | // Can any of the groups they're in moderate any of the boards? |
@@ -6140,8 +6479,9 @@ discard block |
||
6140 | 6479 | 'groups' => $groups, |
6141 | 6480 | ) |
6142 | 6481 | ); |
6143 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6144 | - $boards_mod[] = $row['id_board']; |
|
6482 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6483 | + $boards_mod[] = $row['id_board']; |
|
6484 | + } |
|
6145 | 6485 | $smcFunc['db_free_result']($request); |
6146 | 6486 | |
6147 | 6487 | // Just in case we've got duplicates here... |
@@ -6151,21 +6491,25 @@ discard block |
||
6151 | 6491 | } |
6152 | 6492 | |
6153 | 6493 | // Just build this here, it makes it easier to change/use - administrators can see all boards. |
6154 | - if ($is_admin) |
|
6155 | - $query_part['query_see_board'] = '1=1'; |
|
6494 | + if ($is_admin) { |
|
6495 | + $query_part['query_see_board'] = '1=1'; |
|
6496 | + } |
|
6156 | 6497 | // Otherwise just the groups in $user_info['groups']. |
6157 | - else |
|
6158 | - $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6498 | + else { |
|
6499 | + $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6500 | + } |
|
6159 | 6501 | |
6160 | 6502 | // Build the list of boards they WANT to see. |
6161 | 6503 | // This will take the place of query_see_boards in certain spots, so it better include the boards they can see also |
6162 | 6504 | |
6163 | 6505 | // If they aren't ignoring any boards then they want to see all the boards they can see |
6164 | - if (empty($ignoreboards)) |
|
6165 | - $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6506 | + if (empty($ignoreboards)) { |
|
6507 | + $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6508 | + } |
|
6166 | 6509 | // Ok I guess they don't want to see all the boards |
6167 | - else |
|
6168 | - $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6510 | + else { |
|
6511 | + $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6512 | + } |
|
6169 | 6513 | |
6170 | 6514 | return $query_part; |
6171 | 6515 | } |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Finds or repairs errors in the database to fix possible problems. |
@@ -50,8 +51,9 @@ discard block |
||
50 | 51 | ); |
51 | 52 | |
52 | 53 | // Start displaying errors without fixing them. |
53 | - if (isset($_GET['fixErrors'])) |
|
54 | - checkSession('get'); |
|
54 | + if (isset($_GET['fixErrors'])) { |
|
55 | + checkSession('get'); |
|
56 | + } |
|
55 | 57 | |
56 | 58 | // Will want this. |
57 | 59 | loadForumTests(); |
@@ -69,11 +71,11 @@ discard block |
||
69 | 71 | $_SESSION['repairboards_to_fix'] = $context['to_fix']; |
70 | 72 | $_SESSION['repairboards_to_fix2'] = null; |
71 | 73 | |
72 | - if (empty($context['repair_errors'])) |
|
73 | - $context['repair_errors'][] = '???'; |
|
74 | + if (empty($context['repair_errors'])) { |
|
75 | + $context['repair_errors'][] = '???'; |
|
76 | + } |
|
74 | 77 | } |
75 | - } |
|
76 | - else |
|
78 | + } else |
|
77 | 79 | { |
78 | 80 | $context['error_search'] = false; |
79 | 81 | $context['to_fix'] = isset($_SESSION['repairboards_to_fix']) ? $_SESSION['repairboards_to_fix'] : array(); |
@@ -120,16 +122,19 @@ discard block |
||
120 | 122 | |
121 | 123 | // More time, I need more time! |
122 | 124 | @set_time_limit(600); |
123 | - if (function_exists('apache_reset_timeout')) |
|
124 | - @apache_reset_timeout(); |
|
125 | + if (function_exists('apache_reset_timeout')) { |
|
126 | + @apache_reset_timeout(); |
|
127 | + } |
|
125 | 128 | |
126 | 129 | // Errr, wait. How much time has this taken already? |
127 | - if (!$force && (time() - $time_start) < 3) |
|
128 | - return; |
|
130 | + if (!$force && (time() - $time_start) < 3) { |
|
131 | + return; |
|
132 | + } |
|
129 | 133 | |
130 | 134 | // Restore the query cache if interested. |
131 | - if (!empty($db_temp_cache)) |
|
132 | - $db_cache = $db_temp_cache; |
|
135 | + if (!empty($db_temp_cache)) { |
|
136 | + $db_cache = $db_temp_cache; |
|
137 | + } |
|
133 | 138 | |
134 | 139 | $context['continue_get_data'] = '?action=admin;area=repairboards' . (isset($_GET['fixErrors']) ? ';fixErrors' : '') . ';step=' . $_GET['step'] . ';substep=' . $_GET['substep'] . ';' . $context['session_var'] . '=' . $context['session_id']; |
135 | 140 | $context['page_title'] = $txt['not_done_title']; |
@@ -138,10 +143,11 @@ discard block |
||
138 | 143 | $context['sub_template'] = 'not_done'; |
139 | 144 | |
140 | 145 | // Change these two if more steps are added! |
141 | - if (empty($max_substep)) |
|
142 | - $context['continue_percent'] = round(($_GET['step'] * 100) / $context['total_steps']); |
|
143 | - else |
|
144 | - $context['continue_percent'] = round((($_GET['step'] + ($_GET['substep'] / $max_substep)) * 100) / $context['total_steps']); |
|
146 | + if (empty($max_substep)) { |
|
147 | + $context['continue_percent'] = round(($_GET['step'] * 100) / $context['total_steps']); |
|
148 | + } else { |
|
149 | + $context['continue_percent'] = round((($_GET['step'] + ($_GET['substep'] / $max_substep)) * 100) / $context['total_steps']); |
|
150 | + } |
|
145 | 151 | |
146 | 152 | // Never more than 100%! |
147 | 153 | $context['continue_percent'] = min($context['continue_percent'], 100); |
@@ -612,8 +618,9 @@ discard block |
||
612 | 618 | $row['myid_last_msg'] = (int) $row['myid_last_msg']; |
613 | 619 | |
614 | 620 | // Not really a problem? |
615 | - if ($row['id_first_msg'] == $row['myid_first_msg'] && $row['id_last_msg'] == $row['myid_last_msg'] && $row['approved'] == $row['firstmsg_approved']) |
|
616 | - return false; |
|
621 | + if ($row['id_first_msg'] == $row['myid_first_msg'] && $row['id_last_msg'] == $row['myid_last_msg'] && $row['approved'] == $row['firstmsg_approved']) { |
|
622 | + return false; |
|
623 | + } |
|
617 | 624 | |
618 | 625 | $memberStartedID = (int) getMsgMemberID($row['myid_first_msg']); |
619 | 626 | $memberUpdatedID = (int) getMsgMemberID($row['myid_last_msg']); |
@@ -637,15 +644,19 @@ discard block |
||
637 | 644 | 'message_function' => function ($row) use ($txt, &$context) |
638 | 645 | { |
639 | 646 | // A pretend error? |
640 | - if ($row['id_first_msg'] == $row['myid_first_msg'] && $row['id_last_msg'] == $row['myid_last_msg'] && $row['approved'] == $row['firstmsg_approved']) |
|
641 | - return false; |
|
647 | + if ($row['id_first_msg'] == $row['myid_first_msg'] && $row['id_last_msg'] == $row['myid_last_msg'] && $row['approved'] == $row['firstmsg_approved']) { |
|
648 | + return false; |
|
649 | + } |
|
642 | 650 | |
643 | - if ($row['id_first_msg'] != $row['myid_first_msg']) |
|
644 | - $context['repair_errors'][] = sprintf($txt['repair_stats_topics_1'], $row['id_topic'], $row['id_first_msg']); |
|
645 | - if ($row['id_last_msg'] != $row['myid_last_msg']) |
|
646 | - $context['repair_errors'][] = sprintf($txt['repair_stats_topics_2'], $row['id_topic'], $row['id_last_msg']); |
|
647 | - if ($row['approved'] != $row['firstmsg_approved']) |
|
648 | - $context['repair_errors'][] = sprintf($txt['repair_stats_topics_5'], $row['id_topic']); |
|
651 | + if ($row['id_first_msg'] != $row['myid_first_msg']) { |
|
652 | + $context['repair_errors'][] = sprintf($txt['repair_stats_topics_1'], $row['id_topic'], $row['id_first_msg']); |
|
653 | + } |
|
654 | + if ($row['id_last_msg'] != $row['myid_last_msg']) { |
|
655 | + $context['repair_errors'][] = sprintf($txt['repair_stats_topics_2'], $row['id_topic'], $row['id_last_msg']); |
|
656 | + } |
|
657 | + if ($row['approved'] != $row['firstmsg_approved']) { |
|
658 | + $context['repair_errors'][] = sprintf($txt['repair_stats_topics_5'], $row['id_topic']); |
|
659 | + } |
|
649 | 660 | |
650 | 661 | return true; |
651 | 662 | }, |
@@ -675,8 +686,9 @@ discard block |
||
675 | 686 | $row['my_num_replies'] = (int) $row['my_num_replies']; |
676 | 687 | |
677 | 688 | // Not really a problem? |
678 | - if ($row['my_num_replies'] == $row['num_replies']) |
|
679 | - return false; |
|
689 | + if ($row['my_num_replies'] == $row['num_replies']) { |
|
690 | + return false; |
|
691 | + } |
|
680 | 692 | |
681 | 693 | $smcFunc['db_query']('', ' |
682 | 694 | UPDATE {db_prefix}topics |
@@ -695,11 +707,13 @@ discard block |
||
695 | 707 | global $txt, $context; |
696 | 708 | |
697 | 709 | // Just joking? |
698 | - if ($row['my_num_replies'] == $row['num_replies']) |
|
699 | - return false; |
|
710 | + if ($row['my_num_replies'] == $row['num_replies']) { |
|
711 | + return false; |
|
712 | + } |
|
700 | 713 | |
701 | - if ($row['num_replies'] != $row['my_num_replies']) |
|
702 | - $context['repair_errors'][] = sprintf($txt['repair_stats_topics_3'], $row['id_topic'], $row['num_replies']); |
|
714 | + if ($row['num_replies'] != $row['my_num_replies']) { |
|
715 | + $context['repair_errors'][] = sprintf($txt['repair_stats_topics_3'], $row['id_topic'], $row['num_replies']); |
|
716 | + } |
|
703 | 717 | |
704 | 718 | return true; |
705 | 719 | |
@@ -1290,8 +1304,9 @@ discard block |
||
1290 | 1304 | $inserts = array(); |
1291 | 1305 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
1292 | 1306 | { |
1293 | - foreach (text2words($row['subject']) as $word) |
|
1294 | - $inserts[] = array($word, $row['id_topic']); |
|
1307 | + foreach (text2words($row['subject']) as $word) { |
|
1308 | + $inserts[] = array($word, $row['id_topic']); |
|
1309 | + } |
|
1295 | 1310 | if (count($inserts) > 500) |
1296 | 1311 | { |
1297 | 1312 | $smcFunc['db_insert']('ignore', |
@@ -1305,13 +1320,14 @@ discard block |
||
1305 | 1320 | |
1306 | 1321 | } |
1307 | 1322 | |
1308 | - if (!empty($inserts)) |
|
1309 | - $smcFunc['db_insert']('ignore', |
|
1323 | + if (!empty($inserts)) { |
|
1324 | + $smcFunc['db_insert']('ignore', |
|
1310 | 1325 | '{db_prefix}log_search_subjects', |
1311 | 1326 | array('word' => 'string', 'id_topic' => 'int'), |
1312 | 1327 | $inserts, |
1313 | 1328 | array('word', 'id_topic') |
1314 | 1329 | ); |
1330 | + } |
|
1315 | 1331 | |
1316 | 1332 | }, |
1317 | 1333 | 'message_function' => function ($row) |
@@ -1581,8 +1597,9 @@ discard block |
||
1581 | 1597 | $current_step++; |
1582 | 1598 | |
1583 | 1599 | // Already done this? |
1584 | - if ($_GET['step'] > $current_step) |
|
1585 | - continue; |
|
1600 | + if ($_GET['step'] > $current_step) { |
|
1601 | + continue; |
|
1602 | + } |
|
1586 | 1603 | |
1587 | 1604 | // If we're fixing it but it ain't broke why try? |
1588 | 1605 | if ($do_fix && !in_array($error_type, $to_fix)) |
@@ -1611,14 +1628,16 @@ discard block |
||
1611 | 1628 | while (!$done) |
1612 | 1629 | { |
1613 | 1630 | // Make sure there's at least one ID to test. |
1614 | - if (isset($test['substeps']) && empty($step_max)) |
|
1615 | - break; |
|
1631 | + if (isset($test['substeps']) && empty($step_max)) { |
|
1632 | + break; |
|
1633 | + } |
|
1616 | 1634 | |
1617 | 1635 | // What is the testing query (Changes if we are testing or fixing) |
1618 | - if (!$do_fix) |
|
1619 | - $test_query = 'check_query'; |
|
1620 | - else |
|
1621 | - $test_query = isset($test['fix_query']) ? 'fix_query' : 'check_query'; |
|
1636 | + if (!$do_fix) { |
|
1637 | + $test_query = 'check_query'; |
|
1638 | + } else { |
|
1639 | + $test_query = isset($test['fix_query']) ? 'fix_query' : 'check_query'; |
|
1640 | + } |
|
1622 | 1641 | |
1623 | 1642 | // Do the test... |
1624 | 1643 | $request = $smcFunc['db_query']('', |
@@ -1628,10 +1647,11 @@ discard block |
||
1628 | 1647 | ); |
1629 | 1648 | |
1630 | 1649 | // Does it need a fix? |
1631 | - if (!empty($test['check_type']) && $test['check_type'] == 'count') |
|
1632 | - list ($needs_fix) = $smcFunc['db_fetch_row']($request); |
|
1633 | - else |
|
1634 | - $needs_fix = $smcFunc['db_num_rows']($request); |
|
1650 | + if (!empty($test['check_type']) && $test['check_type'] == 'count') { |
|
1651 | + list ($needs_fix) = $smcFunc['db_fetch_row']($request); |
|
1652 | + } else { |
|
1653 | + $needs_fix = $smcFunc['db_num_rows']($request); |
|
1654 | + } |
|
1635 | 1655 | |
1636 | 1656 | $total_queries++; |
1637 | 1657 | |
@@ -1643,8 +1663,9 @@ discard block |
||
1643 | 1663 | // Assume need to fix. |
1644 | 1664 | $found_errors = true; |
1645 | 1665 | |
1646 | - if (isset($test['message'])) |
|
1647 | - $context['repair_errors'][] = $txt[$test['message']]; |
|
1666 | + if (isset($test['message'])) { |
|
1667 | + $context['repair_errors'][] = $txt[$test['message']]; |
|
1668 | + } |
|
1648 | 1669 | |
1649 | 1670 | // One per row! |
1650 | 1671 | elseif (isset($test['messages'])) |
@@ -1654,10 +1675,11 @@ discard block |
||
1654 | 1675 | $variables = $test['messages']; |
1655 | 1676 | foreach ($variables as $k => $v) |
1656 | 1677 | { |
1657 | - if ($k == 0 && isset($txt[$v])) |
|
1658 | - $variables[$k] = $txt[$v]; |
|
1659 | - elseif ($k > 0 && isset($row[$v])) |
|
1660 | - $variables[$k] = $row[$v]; |
|
1678 | + if ($k == 0 && isset($txt[$v])) { |
|
1679 | + $variables[$k] = $txt[$v]; |
|
1680 | + } elseif ($k > 0 && isset($row[$v])) { |
|
1681 | + $variables[$k] = $row[$v]; |
|
1682 | + } |
|
1661 | 1683 | } |
1662 | 1684 | $context['repair_errors'][] = call_user_func_array('sprintf', $variables); |
1663 | 1685 | } |
@@ -1668,13 +1690,15 @@ discard block |
||
1668 | 1690 | { |
1669 | 1691 | // Find out if there are actually errors. |
1670 | 1692 | $found_errors = false; |
1671 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1672 | - $found_errors |= $test['message_function']($row); |
|
1693 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1694 | + $found_errors |= $test['message_function']($row); |
|
1695 | + } |
|
1673 | 1696 | } |
1674 | 1697 | |
1675 | 1698 | // Actually have something to fix? |
1676 | - if ($found_errors) |
|
1677 | - $to_fix[] = $error_type; |
|
1699 | + if ($found_errors) { |
|
1700 | + $to_fix[] = $error_type; |
|
1701 | + } |
|
1678 | 1702 | } |
1679 | 1703 | |
1680 | 1704 | // We want to fix, we need to fix - so work out what exactly to do! |
@@ -1684,8 +1708,9 @@ discard block |
||
1684 | 1708 | if (isset($test['fix_collect'])) |
1685 | 1709 | { |
1686 | 1710 | $ids = array(); |
1687 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1688 | - $ids[] = $row[$test['fix_collect']['index']]; |
|
1711 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1712 | + $ids[] = $row[$test['fix_collect']['index']]; |
|
1713 | + } |
|
1689 | 1714 | if (!empty($ids)) |
1690 | 1715 | { |
1691 | 1716 | // Fix it! |
@@ -1694,30 +1719,34 @@ discard block |
||
1694 | 1719 | } |
1695 | 1720 | |
1696 | 1721 | // Simply executing a fix it query? |
1697 | - elseif (isset($test['fix_it_query'])) |
|
1698 | - $smcFunc['db_query']('', |
|
1722 | + elseif (isset($test['fix_it_query'])) { |
|
1723 | + $smcFunc['db_query']('', |
|
1699 | 1724 | $test['fix_it_query'], |
1700 | 1725 | array( |
1701 | 1726 | ) |
1702 | 1727 | ); |
1728 | + } |
|
1703 | 1729 | |
1704 | 1730 | // Do we have some processing to do? |
1705 | 1731 | elseif (isset($test['fix_processing'])) |
1706 | 1732 | { |
1707 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1708 | - $test['fix_processing']($row); |
|
1733 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1734 | + $test['fix_processing']($row); |
|
1735 | + } |
|
1709 | 1736 | } |
1710 | 1737 | |
1711 | 1738 | // What about the full set of processing? |
1712 | - elseif (isset($test['fix_full_processing'])) |
|
1713 | - $test['fix_full_processing']($request); |
|
1739 | + elseif (isset($test['fix_full_processing'])) { |
|
1740 | + $test['fix_full_processing']($request); |
|
1741 | + } |
|
1714 | 1742 | |
1715 | 1743 | // Do we have other things we need to fix as a result? |
1716 | 1744 | if (!empty($test['force_fix'])) |
1717 | 1745 | { |
1718 | - foreach ($test['force_fix'] as $item) |
|
1719 | - if (!in_array($item, $to_fix)) |
|
1746 | + foreach ($test['force_fix'] as $item) { |
|
1747 | + if (!in_array($item, $to_fix)) |
|
1720 | 1748 | $to_fix[] = $item; |
1749 | + } |
|
1721 | 1750 | } |
1722 | 1751 | } |
1723 | 1752 | } |
@@ -1735,16 +1764,17 @@ discard block |
||
1735 | 1764 | if ($_GET['substep'] <= $step_max) |
1736 | 1765 | { |
1737 | 1766 | pauseRepairProcess($to_fix, $error_type, $step_max); |
1767 | + } else { |
|
1768 | + $done = true; |
|
1738 | 1769 | } |
1739 | - else |
|
1740 | - $done = true; |
|
1770 | + } else { |
|
1771 | + $done = true; |
|
1741 | 1772 | } |
1742 | - else |
|
1743 | - $done = true; |
|
1744 | 1773 | |
1745 | 1774 | // Don't allow more than 1000 queries at a time. |
1746 | - if ($total_queries >= 1000) |
|
1747 | - pauseRepairProcess($to_fix, $error_type, $step_max, true); |
|
1775 | + if ($total_queries >= 1000) { |
|
1776 | + pauseRepairProcess($to_fix, $error_type, $step_max, true); |
|
1777 | + } |
|
1748 | 1778 | } |
1749 | 1779 | |
1750 | 1780 | // Keep going. |
@@ -1757,8 +1787,9 @@ discard block |
||
1757 | 1787 | if ($do_fix) |
1758 | 1788 | { |
1759 | 1789 | $key = array_search($error_type, $to_fix); |
1760 | - if ($key !== false && isset($to_fix[$key])) |
|
1761 | - unset($to_fix[$key]); |
|
1790 | + if ($key !== false && isset($to_fix[$key])) { |
|
1791 | + unset($to_fix[$key]); |
|
1792 | + } |
|
1762 | 1793 | } |
1763 | 1794 | |
1764 | 1795 | // Are we done? |
@@ -1781,10 +1812,11 @@ discard block |
||
1781 | 1812 | static $createOnce = false; |
1782 | 1813 | |
1783 | 1814 | // Have we already created it? |
1784 | - if ($createOnce) |
|
1785 | - return; |
|
1786 | - else |
|
1787 | - $createOnce = true; |
|
1815 | + if ($createOnce) { |
|
1816 | + return; |
|
1817 | + } else { |
|
1818 | + $createOnce = true; |
|
1819 | + } |
|
1788 | 1820 | |
1789 | 1821 | // Back to the forum's default language. |
1790 | 1822 | loadLanguage('Admin', $language); |
@@ -1799,8 +1831,9 @@ discard block |
||
1799 | 1831 | 'cat_name' => $txt['salvaged_category_name'], |
1800 | 1832 | ) |
1801 | 1833 | ); |
1802 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
1803 | - list ($salvageCatID) = $smcFunc['db_fetch_row']($result); |
|
1834 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
1835 | + list ($salvageCatID) = $smcFunc['db_fetch_row']($result); |
|
1836 | + } |
|
1804 | 1837 | $smcFunc['db_free_result']($result); |
1805 | 1838 | |
1806 | 1839 | if (empty($salvageCatID)) |
@@ -1832,8 +1865,9 @@ discard block |
||
1832 | 1865 | 'board_name' => $txt['salvaged_board_name'], |
1833 | 1866 | ) |
1834 | 1867 | ); |
1835 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
1836 | - list ($salvageBoardID) = $smcFunc['db_fetch_row']($result); |
|
1868 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
1869 | + list ($salvageBoardID) = $smcFunc['db_fetch_row']($result); |
|
1870 | + } |
|
1837 | 1871 | $smcFunc['db_free_result']($result); |
1838 | 1872 | |
1839 | 1873 | if (empty($salvageBoardID)) |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * The main admin handling function.<br> |
@@ -444,8 +445,9 @@ discard block |
||
444 | 445 | foreach ($admin_includes as $include) |
445 | 446 | { |
446 | 447 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
447 | - if (file_exists($include)) |
|
448 | - require_once($include); |
|
448 | + if (file_exists($include)) { |
|
449 | + require_once($include); |
|
450 | + } |
|
449 | 451 | } |
450 | 452 | } |
451 | 453 | |
@@ -457,24 +459,27 @@ discard block |
||
457 | 459 | unset($admin_areas); |
458 | 460 | |
459 | 461 | // Nothing valid? |
460 | - if ($admin_include_data == false) |
|
461 | - fatal_lang_error('no_access', false); |
|
462 | + if ($admin_include_data == false) { |
|
463 | + fatal_lang_error('no_access', false); |
|
464 | + } |
|
462 | 465 | |
463 | 466 | // Build the link tree. |
464 | 467 | $context['linktree'][] = array( |
465 | 468 | 'url' => $scripturl . '?action=admin', |
466 | 469 | 'name' => $txt['admin_center'], |
467 | 470 | ); |
468 | - if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index') |
|
469 | - $context['linktree'][] = array( |
|
471 | + if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index') { |
|
472 | + $context['linktree'][] = array( |
|
470 | 473 | 'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';' . $context['session_var'] . '=' . $context['session_id'], |
471 | 474 | 'name' => $admin_include_data['label'], |
472 | 475 | ); |
473 | - if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label']) |
|
474 | - $context['linktree'][] = array( |
|
476 | + } |
|
477 | + if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label']) { |
|
478 | + $context['linktree'][] = array( |
|
475 | 479 | 'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';sa=' . $admin_include_data['current_subsection'] . ';' . $context['session_var'] . '=' . $context['session_id'], |
476 | 480 | 'name' => $admin_include_data['subsections'][$admin_include_data['current_subsection']][0], |
477 | 481 | ); |
482 | + } |
|
478 | 483 | |
479 | 484 | // Make a note of the Unique ID for this menu. |
480 | 485 | $context['admin_menu_id'] = $context['max_menu_id']; |
@@ -484,16 +489,18 @@ discard block |
||
484 | 489 | $context['admin_area'] = $admin_include_data['current_area']; |
485 | 490 | |
486 | 491 | // Now - finally - call the right place! |
487 | - if (isset($admin_include_data['file'])) |
|
488 | - require_once($sourcedir . '/' . $admin_include_data['file']); |
|
492 | + if (isset($admin_include_data['file'])) { |
|
493 | + require_once($sourcedir . '/' . $admin_include_data['file']); |
|
494 | + } |
|
489 | 495 | |
490 | 496 | // Get the right callable. |
491 | 497 | $call = call_helper($admin_include_data['function'], true); |
492 | 498 | |
493 | 499 | // Is it valid? |
494 | - if (!empty($call)) |
|
495 | - call_user_func($call); |
|
496 | -} |
|
500 | + if (!empty($call)) { |
|
501 | + call_user_func($call); |
|
502 | + } |
|
503 | + } |
|
497 | 504 | |
498 | 505 | /** |
499 | 506 | * The main administration section. |
@@ -547,13 +554,14 @@ discard block |
||
547 | 554 | |
548 | 555 | $context['sub_template'] = $context['admin_area'] == 'credits' ? 'credits' : 'admin'; |
549 | 556 | $context['page_title'] = $context['admin_area'] == 'credits' ? $txt['support_credits_title'] : $txt['admin_center']; |
550 | - if ($context['admin_area'] != 'credits') |
|
551 | - $context[$context['admin_menu_name']]['tab_data'] = array( |
|
557 | + if ($context['admin_area'] != 'credits') { |
|
558 | + $context[$context['admin_menu_name']]['tab_data'] = array( |
|
552 | 559 | 'title' => $txt['admin_center'], |
553 | 560 | 'help' => '', |
554 | 561 | 'description' => '<strong>' . $txt['hello_guest'] . ' ' . $context['user']['name'] . '!</strong> |
555 | 562 | ' . sprintf($txt['admin_main_welcome'], $txt['admin_center'], $txt['help'], $txt['help']), |
556 | 563 | ); |
564 | + } |
|
557 | 565 | |
558 | 566 | // Lastly, fill in the blanks in the support resources paragraphs. |
559 | 567 | $txt['support_resources_p1'] = sprintf($txt['support_resources_p1'], |
@@ -571,9 +579,10 @@ discard block |
||
571 | 579 | 'https://www.simplemachines.org/redirect/customize_support' |
572 | 580 | ); |
573 | 581 | |
574 | - if ($context['admin_area'] == 'admin') |
|
575 | - loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin'); |
|
576 | -} |
|
582 | + if ($context['admin_area'] == 'admin') { |
|
583 | + loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin'); |
|
584 | + } |
|
585 | + } |
|
577 | 586 | |
578 | 587 | /** |
579 | 588 | * Get one of the admin information files from Simple Machines. |
@@ -584,8 +593,9 @@ discard block |
||
584 | 593 | |
585 | 594 | setMemoryLimit('32M'); |
586 | 595 | |
587 | - if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename'])) |
|
588 | - fatal_lang_error('no_access', false); |
|
596 | + if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename'])) { |
|
597 | + fatal_lang_error('no_access', false); |
|
598 | + } |
|
589 | 599 | |
590 | 600 | // Strip off the forum cache part or we won't find it... |
591 | 601 | $_REQUEST['filename'] = str_replace($modSettings['browser_cache'], '', $_REQUEST['filename']); |
@@ -600,27 +610,30 @@ discard block |
||
600 | 610 | ) |
601 | 611 | ); |
602 | 612 | |
603 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
604 | - fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404); |
|
613 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
614 | + fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404); |
|
615 | + } |
|
605 | 616 | |
606 | 617 | list ($file_data, $filetype) = $smcFunc['db_fetch_row']($request); |
607 | 618 | $smcFunc['db_free_result']($request); |
608 | 619 | |
609 | 620 | // @todo Temp |
610 | 621 | // Figure out if sesc is still being used. |
611 | - if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript') |
|
612 | - $file_data = ' |
|
622 | + if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript') { |
|
623 | + $file_data = ' |
|
613 | 624 | if (!(\'smfForum_sessionvar\' in window)) |
614 | 625 | window.smfForum_sessionvar = \'sesc\'; |
615 | 626 | ' . strtr($file_data, array(';sesc=' => ';\' + window.smfForum_sessionvar + \'=')); |
627 | + } |
|
616 | 628 | |
617 | 629 | $context['template_layers'] = array(); |
618 | 630 | // Lets make sure we aren't going to output anything nasty. |
619 | 631 | @ob_end_clean(); |
620 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
621 | - @ob_start('ob_gzhandler'); |
|
622 | - else |
|
623 | - @ob_start(); |
|
632 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
633 | + @ob_start('ob_gzhandler'); |
|
634 | + } else { |
|
635 | + @ob_start(); |
|
636 | + } |
|
624 | 637 | |
625 | 638 | // Make sure they know what type of file we are. |
626 | 639 | header('Content-Type: ' . $filetype); |
@@ -660,11 +673,12 @@ discard block |
||
660 | 673 | updateAdminPreferences(); |
661 | 674 | } |
662 | 675 | |
663 | - if (trim($context['search_term']) == '') |
|
664 | - $context['search_results'] = array(); |
|
665 | - else |
|
666 | - call_helper($subActions[$context['search_type']]); |
|
667 | -} |
|
676 | + if (trim($context['search_term']) == '') { |
|
677 | + $context['search_results'] = array(); |
|
678 | + } else { |
|
679 | + call_helper($subActions[$context['search_type']]); |
|
680 | + } |
|
681 | + } |
|
668 | 682 | |
669 | 683 | /** |
670 | 684 | * A complicated but relatively quick internal search. |
@@ -728,8 +742,9 @@ discard block |
||
728 | 742 | |
729 | 743 | loadLanguage(implode('+', $language_files)); |
730 | 744 | |
731 | - foreach ($include_files as $file) |
|
732 | - require_once($sourcedir . '/' . $file . '.php'); |
|
745 | + foreach ($include_files as $file) { |
|
746 | + require_once($sourcedir . '/' . $file . '.php'); |
|
747 | + } |
|
733 | 748 | |
734 | 749 | /* This is the huge array that defines everything... it's a huge array of items formatted as follows: |
735 | 750 | 0 = Language index (Can be array of indexes) to search through for this setting. |
@@ -753,11 +768,12 @@ discard block |
||
753 | 768 | foreach ($section['areas'] as $menu_key => $menu_item) |
754 | 769 | { |
755 | 770 | $search_data['sections'][] = array($menu_item['label'], 'area=' . $menu_key); |
756 | - if (!empty($menu_item['subsections'])) |
|
757 | - foreach ($menu_item['subsections'] as $key => $sublabel) |
|
771 | + if (!empty($menu_item['subsections'])) { |
|
772 | + foreach ($menu_item['subsections'] as $key => $sublabel) |
|
758 | 773 | { |
759 | 774 | if (isset($sublabel['label'])) |
760 | 775 | $search_data['sections'][] = array($sublabel['label'], 'area=' . $menu_key . ';sa=' . $key); |
776 | + } |
|
761 | 777 | } |
762 | 778 | } |
763 | 779 | } |
@@ -767,9 +783,10 @@ discard block |
||
767 | 783 | // Get a list of their variables. |
768 | 784 | $config_vars = $setting_area[0](true); |
769 | 785 | |
770 | - foreach ($config_vars as $var) |
|
771 | - if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc'))) |
|
786 | + foreach ($config_vars as $var) { |
|
787 | + if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc'))) |
|
772 | 788 | $search_data['settings'][] = array($var[(isset($var[2]) && in_array($var[2], array('file', 'db'))) ? 0 : 1], $setting_area[1], 'alttxt' => (isset($var[2]) && in_array($var[2], array('file', 'db'))) || isset($var[3]) ? (in_array($var[2], array('file', 'db')) ? $var[1] : $var[3]) : ''); |
789 | + } |
|
773 | 790 | } |
774 | 791 | |
775 | 792 | $context['page_title'] = $txt['admin_search_results']; |
@@ -782,8 +799,9 @@ discard block |
||
782 | 799 | foreach ($data as $item) |
783 | 800 | { |
784 | 801 | $found = false; |
785 | - if (!is_array($item[0])) |
|
786 | - $item[0] = array($item[0]); |
|
802 | + if (!is_array($item[0])) { |
|
803 | + $item[0] = array($item[0]); |
|
804 | + } |
|
787 | 805 | foreach ($item[0] as $term) |
788 | 806 | { |
789 | 807 | if (stripos($term, $search_term) !== false || (isset($txt[$term]) && stripos($txt[$term], $search_term) !== false) || (isset($txt['setting_' . $term]) && stripos($txt['setting_' . $term], $search_term) !== false)) |
@@ -841,8 +859,9 @@ discard block |
||
841 | 859 | $postVars = explode(' ', $context['search_term']); |
842 | 860 | |
843 | 861 | // Encode the search data. |
844 | - foreach ($postVars as $k => $v) |
|
845 | - $postVars[$k] = urlencode($v); |
|
862 | + foreach ($postVars as $k => $v) { |
|
863 | + $postVars[$k] = urlencode($v); |
|
864 | + } |
|
846 | 865 | |
847 | 866 | // This is what we will send. |
848 | 867 | $postVars = implode('+', $postVars); |
@@ -854,8 +873,9 @@ discard block |
||
854 | 873 | $search_results = fetch_web_data($context['doc_apiurl'] . '?action=query&list=search&srprop=timestamp|snippet&format=xml&srwhat=text&srsearch=' . $postVars); |
855 | 874 | |
856 | 875 | // If we didn't get any xml back we are in trouble - perhaps the doc site is overloaded? |
857 | - if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true) |
|
858 | - fatal_lang_error('cannot_connect_doc_site'); |
|
876 | + if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true) { |
|
877 | + fatal_lang_error('cannot_connect_doc_site'); |
|
878 | + } |
|
859 | 879 | |
860 | 880 | $search_results = $matches[1]; |
861 | 881 | |
@@ -867,8 +887,9 @@ discard block |
||
867 | 887 | $results = new xmlArray($search_results, false); |
868 | 888 | |
869 | 889 | // Move through the api layer. |
870 | - if (!$results->exists('api')) |
|
871 | - fatal_lang_error('cannot_connect_doc_site'); |
|
890 | + if (!$results->exists('api')) { |
|
891 | + fatal_lang_error('cannot_connect_doc_site'); |
|
892 | + } |
|
872 | 893 | |
873 | 894 | // Are there actually some results? |
874 | 895 | if ($results->exists('api/query/search/p')) |
@@ -904,8 +925,9 @@ discard block |
||
904 | 925 | ); |
905 | 926 | |
906 | 927 | // If it's not got a sa set it must have come here for first time, pretend error log should be reversed. |
907 | - if (!isset($_REQUEST['sa'])) |
|
908 | - $_REQUEST['desc'] = true; |
|
928 | + if (!isset($_REQUEST['sa'])) { |
|
929 | + $_REQUEST['desc'] = true; |
|
930 | + } |
|
909 | 931 | |
910 | 932 | // Setup some tab stuff. |
911 | 933 | $context[$context['admin_menu_name']]['tab_data'] = array( |
@@ -955,9 +977,10 @@ discard block |
||
955 | 977 | unset($_SESSION['admin_time']); |
956 | 978 | |
957 | 979 | // Clean any admin tokens as well. |
958 | - foreach ($_SESSION['token'] as $key => $token) |
|
959 | - if (strpos($key, '-admin') !== false) |
|
980 | + foreach ($_SESSION['token'] as $key => $token) { |
|
981 | + if (strpos($key, '-admin') !== false) |
|
960 | 982 | unset($_SESSION['token'][$key]); |
983 | + } |
|
961 | 984 | |
962 | 985 | redirectexit(); |
963 | 986 | } |
@@ -20,8 +20,9 @@ discard block |
||
20 | 20 | // ><html dir="ltr"><head><title>Error!</title></head><body>Sorry, this installer requires PHP!<div style="display: none;"> |
21 | 21 | |
22 | 22 | // Let's pull in useful classes |
23 | -if (!defined('SMF')) |
|
23 | +if (!defined('SMF')) { |
|
24 | 24 | define('SMF', 1); |
25 | +} |
|
25 | 26 | |
26 | 27 | require_once('Sources/Class-Package.php'); |
27 | 28 | |
@@ -63,10 +64,11 @@ discard block |
||
63 | 64 | |
64 | 65 | list ($charcode) = pg_fetch_row($request); |
65 | 66 | |
66 | - if ($charcode == 'UTF8') |
|
67 | - return true; |
|
68 | - else |
|
69 | - return false; |
|
67 | + if ($charcode == 'UTF8') { |
|
68 | + return true; |
|
69 | + } else { |
|
70 | + return false; |
|
71 | + } |
|
70 | 72 | }, |
71 | 73 | 'utf8_version' => '8.0', |
72 | 74 | 'utf8_version_check' => '$request = pg_query(\'SELECT version()\'); list ($version) = pg_fetch_row($request); list($pgl, $version) = explode(" ", $version); return $version;', |
@@ -76,12 +78,14 @@ discard block |
||
76 | 78 | $value = preg_replace('~[^A-Za-z0-9_\$]~', '', $value); |
77 | 79 | |
78 | 80 | // Is it reserved? |
79 | - if ($value == 'pg_') |
|
80 | - return $txt['error_db_prefix_reserved']; |
|
81 | + if ($value == 'pg_') { |
|
82 | + return $txt['error_db_prefix_reserved']; |
|
83 | + } |
|
81 | 84 | |
82 | 85 | // Is the prefix numeric? |
83 | - if (preg_match('~^\d~', $value)) |
|
84 | - return $txt['error_db_prefix_numeric']; |
|
86 | + if (preg_match('~^\d~', $value)) { |
|
87 | + return $txt['error_db_prefix_numeric']; |
|
88 | + } |
|
85 | 89 | |
86 | 90 | return true; |
87 | 91 | }, |
@@ -128,10 +132,11 @@ discard block |
||
128 | 132 | $incontext['skip'] = false; |
129 | 133 | |
130 | 134 | // Call the step and if it returns false that means pause! |
131 | - if (function_exists($step[2]) && $step[2]() === false) |
|
132 | - break; |
|
133 | - elseif (function_exists($step[2])) |
|
134 | - $incontext['current_step']++; |
|
135 | + if (function_exists($step[2]) && $step[2]() === false) { |
|
136 | + break; |
|
137 | + } elseif (function_exists($step[2])) { |
|
138 | + $incontext['current_step']++; |
|
139 | + } |
|
135 | 140 | |
136 | 141 | // No warnings pass on. |
137 | 142 | $incontext['warning'] = ''; |
@@ -147,8 +152,9 @@ discard block |
||
147 | 152 | global $databases; |
148 | 153 | |
149 | 154 | // Just so people using older versions of PHP aren't left in the cold. |
150 | - if (!isset($_SERVER['PHP_SELF'])) |
|
151 | - $_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php'; |
|
155 | + if (!isset($_SERVER['PHP_SELF'])) { |
|
156 | + $_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php'; |
|
157 | + } |
|
152 | 158 | |
153 | 159 | // Enable error reporting for fatal errors. |
154 | 160 | error_reporting(E_ERROR | E_PARSE); |
@@ -164,21 +170,23 @@ discard block |
||
164 | 170 | { |
165 | 171 | ob_start(); |
166 | 172 | |
167 | - if (ini_get('session.save_handler') == 'user') |
|
168 | - @ini_set('session.save_handler', 'files'); |
|
169 | - if (function_exists('session_start')) |
|
170 | - @session_start(); |
|
171 | - } |
|
172 | - else |
|
173 | + if (ini_get('session.save_handler') == 'user') { |
|
174 | + @ini_set('session.save_handler', 'files'); |
|
175 | + } |
|
176 | + if (function_exists('session_start')) { |
|
177 | + @session_start(); |
|
178 | + } |
|
179 | + } else |
|
173 | 180 | { |
174 | 181 | ob_start('ob_gzhandler'); |
175 | 182 | |
176 | - if (ini_get('session.save_handler') == 'user') |
|
177 | - @ini_set('session.save_handler', 'files'); |
|
183 | + if (ini_get('session.save_handler') == 'user') { |
|
184 | + @ini_set('session.save_handler', 'files'); |
|
185 | + } |
|
178 | 186 | session_start(); |
179 | 187 | |
180 | - if (!headers_sent()) |
|
181 | - echo '<!DOCTYPE html> |
|
188 | + if (!headers_sent()) { |
|
189 | + echo '<!DOCTYPE html> |
|
182 | 190 | <html> |
183 | 191 | <head> |
184 | 192 | <title>', htmlspecialchars($_GET['pass_string']), '</title> |
@@ -187,14 +195,16 @@ discard block |
||
187 | 195 | <strong>', htmlspecialchars($_GET['pass_string']), '</strong> |
188 | 196 | </body> |
189 | 197 | </html>'; |
198 | + } |
|
190 | 199 | exit; |
191 | 200 | } |
192 | 201 | |
193 | 202 | // Add slashes, as long as they aren't already being added. |
194 | - if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) |
|
195 | - foreach ($_POST as $k => $v) |
|
203 | + if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) { |
|
204 | + foreach ($_POST as $k => $v) |
|
196 | 205 | if (strpos($k, 'password') === false && strpos($k, 'db_passwd') === false) |
197 | 206 | $_POST[$k] = addslashes($v); |
207 | + } |
|
198 | 208 | |
199 | 209 | // This is really quite simple; if ?delete is on the URL, delete the installer... |
200 | 210 | if (isset($_GET['delete'])) |
@@ -215,8 +225,7 @@ discard block |
||
215 | 225 | $ftp->close(); |
216 | 226 | |
217 | 227 | unset($_SESSION['installer_temp_ftp']); |
218 | - } |
|
219 | - else |
|
228 | + } else |
|
220 | 229 | { |
221 | 230 | @unlink(__FILE__); |
222 | 231 | |
@@ -237,10 +246,11 @@ discard block |
||
237 | 246 | { |
238 | 247 | // Get PHP's default timezone, if set |
239 | 248 | $ini_tz = ini_get('date.timezone'); |
240 | - if (!empty($ini_tz)) |
|
241 | - $timezone_id = $ini_tz; |
|
242 | - else |
|
243 | - $timezone_id = ''; |
|
249 | + if (!empty($ini_tz)) { |
|
250 | + $timezone_id = $ini_tz; |
|
251 | + } else { |
|
252 | + $timezone_id = ''; |
|
253 | + } |
|
244 | 254 | |
245 | 255 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
246 | 256 | if (!in_array($timezone_id, timezone_identifiers_list())) |
@@ -270,8 +280,9 @@ discard block |
||
270 | 280 | $dir = dir(dirname(__FILE__) . '/Themes/default/languages'); |
271 | 281 | while ($entry = $dir->read()) |
272 | 282 | { |
273 | - if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') |
|
274 | - $incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12)); |
|
283 | + if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') { |
|
284 | + $incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12)); |
|
285 | + } |
|
275 | 286 | } |
276 | 287 | $dir->close(); |
277 | 288 | } |
@@ -306,10 +317,11 @@ discard block |
||
306 | 317 | } |
307 | 318 | |
308 | 319 | // Override the language file? |
309 | - if (isset($_GET['lang_file'])) |
|
310 | - $_SESSION['installer_temp_lang'] = $_GET['lang_file']; |
|
311 | - elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) |
|
312 | - $_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file']; |
|
320 | + if (isset($_GET['lang_file'])) { |
|
321 | + $_SESSION['installer_temp_lang'] = $_GET['lang_file']; |
|
322 | + } elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) { |
|
323 | + $_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file']; |
|
324 | + } |
|
313 | 325 | |
314 | 326 | // Make sure it exists, if it doesn't reset it. |
315 | 327 | if (!isset($_SESSION['installer_temp_lang']) || preg_match('~[^\\w_\\-.]~', $_SESSION['installer_temp_lang']) === 1 || !file_exists(dirname(__FILE__) . '/Themes/default/languages/' . $_SESSION['installer_temp_lang'])) |
@@ -318,8 +330,9 @@ discard block |
||
318 | 330 | list ($_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
319 | 331 | |
320 | 332 | // If we have english and some other language, use the other language. We Americans hate english :P. |
321 | - if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) |
|
322 | - list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
|
333 | + if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) { |
|
334 | + list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
|
335 | + } |
|
323 | 336 | } |
324 | 337 | |
325 | 338 | // And now include the actual language file itself. |
@@ -332,15 +345,18 @@ discard block |
||
332 | 345 | global $db_prefix, $db_connection, $sourcedir, $smcFunc, $modSettings; |
333 | 346 | global $db_server, $db_passwd, $db_type, $db_name, $db_user, $db_persist; |
334 | 347 | |
335 | - if (empty($sourcedir)) |
|
336 | - $sourcedir = dirname(__FILE__) . '/Sources'; |
|
348 | + if (empty($sourcedir)) { |
|
349 | + $sourcedir = dirname(__FILE__) . '/Sources'; |
|
350 | + } |
|
337 | 351 | |
338 | 352 | // Need this to check whether we need the database password. |
339 | 353 | require(dirname(__FILE__) . '/Settings.php'); |
340 | - if (!defined('SMF')) |
|
341 | - define('SMF', 1); |
|
342 | - if (empty($smcFunc)) |
|
343 | - $smcFunc = array(); |
|
354 | + if (!defined('SMF')) { |
|
355 | + define('SMF', 1); |
|
356 | + } |
|
357 | + if (empty($smcFunc)) { |
|
358 | + $smcFunc = array(); |
|
359 | + } |
|
344 | 360 | |
345 | 361 | $modSettings['disableQueryCheck'] = true; |
346 | 362 | |
@@ -348,8 +364,9 @@ discard block |
||
348 | 364 | if (!$db_connection) |
349 | 365 | { |
350 | 366 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
351 | - if (version_compare(PHP_VERSION, '5', '<')) |
|
352 | - require_once($sourcedir . '/Subs-Compat.php'); |
|
367 | + if (version_compare(PHP_VERSION, '5', '<')) { |
|
368 | + require_once($sourcedir . '/Subs-Compat.php'); |
|
369 | + } |
|
353 | 370 | |
354 | 371 | $db_options = array('persist' => $db_persist); |
355 | 372 | $port = ''; |
@@ -360,19 +377,20 @@ discard block |
||
360 | 377 | if ($db_type == 'mysql') |
361 | 378 | { |
362 | 379 | $port = ((int) $_POST['db_port'] == ini_get($db_type . 'default_port')) ? '' : (int) $_POST['db_port']; |
363 | - } |
|
364 | - elseif ($db_type == 'postgresql') |
|
380 | + } elseif ($db_type == 'postgresql') |
|
365 | 381 | { |
366 | 382 | // PostgreSQL doesn't have a default port setting in php.ini, so just check against the default |
367 | 383 | $port = ((int) $_POST['db_port'] == 5432) ? '' : (int) $_POST['db_port']; |
368 | 384 | } |
369 | 385 | } |
370 | 386 | |
371 | - if (!empty($port)) |
|
372 | - $db_options['port'] = $port; |
|
387 | + if (!empty($port)) { |
|
388 | + $db_options['port'] = $port; |
|
389 | + } |
|
373 | 390 | |
374 | - if (!$db_connection) |
|
375 | - $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options); |
|
391 | + if (!$db_connection) { |
|
392 | + $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options); |
|
393 | + } |
|
376 | 394 | } |
377 | 395 | } |
378 | 396 | |
@@ -400,8 +418,9 @@ discard block |
||
400 | 418 | // @todo REMOVE THIS!! |
401 | 419 | else |
402 | 420 | { |
403 | - if (function_exists('doStep' . $_GET['step'])) |
|
404 | - call_user_func('doStep' . $_GET['step']); |
|
421 | + if (function_exists('doStep' . $_GET['step'])) { |
|
422 | + call_user_func('doStep' . $_GET['step']); |
|
423 | + } |
|
405 | 424 | } |
406 | 425 | // Show the footer. |
407 | 426 | template_install_below(); |
@@ -419,8 +438,9 @@ discard block |
||
419 | 438 | $incontext['sub_template'] = 'welcome_message'; |
420 | 439 | |
421 | 440 | // Done the submission? |
422 | - if (isset($_POST['contbutt'])) |
|
423 | - return true; |
|
441 | + if (isset($_POST['contbutt'])) { |
|
442 | + return true; |
|
443 | + } |
|
424 | 444 | |
425 | 445 | // See if we think they have already installed it? |
426 | 446 | if (is_readable(dirname(__FILE__) . '/Settings.php')) |
@@ -428,14 +448,17 @@ discard block |
||
428 | 448 | $probably_installed = 0; |
429 | 449 | foreach (file(dirname(__FILE__) . '/Settings.php') as $line) |
430 | 450 | { |
431 | - if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) |
|
432 | - $probably_installed++; |
|
433 | - if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) |
|
434 | - $probably_installed++; |
|
451 | + if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) { |
|
452 | + $probably_installed++; |
|
453 | + } |
|
454 | + if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) { |
|
455 | + $probably_installed++; |
|
456 | + } |
|
435 | 457 | } |
436 | 458 | |
437 | - if ($probably_installed == 2) |
|
438 | - $incontext['warning'] = $txt['error_already_installed']; |
|
459 | + if ($probably_installed == 2) { |
|
460 | + $incontext['warning'] = $txt['error_already_installed']; |
|
461 | + } |
|
439 | 462 | } |
440 | 463 | |
441 | 464 | // Is some database support even compiled in? |
@@ -450,45 +473,54 @@ discard block |
||
450 | 473 | $databases[$key]['supported'] = false; |
451 | 474 | $notFoundSQLFile = true; |
452 | 475 | $txt['error_db_script_missing'] = sprintf($txt['error_db_script_missing'], 'install_' . $GLOBALS['db_script_version'] . '_' . $type . '.sql'); |
476 | + } else { |
|
477 | + $incontext['supported_databases'][] = $db; |
|
453 | 478 | } |
454 | - else |
|
455 | - $incontext['supported_databases'][] = $db; |
|
456 | 479 | } |
457 | 480 | } |
458 | 481 | |
459 | 482 | // Check the PHP version. |
460 | - if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>='))) |
|
461 | - $error = 'error_php_too_low'; |
|
483 | + if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>='))) { |
|
484 | + $error = 'error_php_too_low'; |
|
485 | + } |
|
462 | 486 | // Make sure we have a supported database |
463 | - elseif (empty($incontext['supported_databases'])) |
|
464 | - $error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing'; |
|
487 | + elseif (empty($incontext['supported_databases'])) { |
|
488 | + $error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing'; |
|
489 | + } |
|
465 | 490 | // How about session support? Some crazy sysadmin remove it? |
466 | - elseif (!function_exists('session_start')) |
|
467 | - $error = 'error_session_missing'; |
|
491 | + elseif (!function_exists('session_start')) { |
|
492 | + $error = 'error_session_missing'; |
|
493 | + } |
|
468 | 494 | // Make sure they uploaded all the files. |
469 | - elseif (!file_exists(dirname(__FILE__) . '/index.php')) |
|
470 | - $error = 'error_missing_files'; |
|
495 | + elseif (!file_exists(dirname(__FILE__) . '/index.php')) { |
|
496 | + $error = 'error_missing_files'; |
|
497 | + } |
|
471 | 498 | // Very simple check on the session.save_path for Windows. |
472 | 499 | // @todo Move this down later if they don't use database-driven sessions? |
473 | - elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') |
|
474 | - $error = 'error_session_save_path'; |
|
500 | + elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') { |
|
501 | + $error = 'error_session_save_path'; |
|
502 | + } |
|
475 | 503 | |
476 | 504 | // Since each of the three messages would look the same, anyway... |
477 | - if (isset($error)) |
|
478 | - $incontext['error'] = $txt[$error]; |
|
505 | + if (isset($error)) { |
|
506 | + $incontext['error'] = $txt[$error]; |
|
507 | + } |
|
479 | 508 | |
480 | 509 | // Mod_security blocks everything that smells funny. Let SMF handle security. |
481 | - if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) |
|
482 | - $incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again']; |
|
510 | + if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) { |
|
511 | + $incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again']; |
|
512 | + } |
|
483 | 513 | |
484 | 514 | // Confirm mbstring is loaded... |
485 | - if (!extension_loaded('mbstring')) |
|
486 | - $incontext['error'] = $txt['install_no_mbstring']; |
|
515 | + if (!extension_loaded('mbstring')) { |
|
516 | + $incontext['error'] = $txt['install_no_mbstring']; |
|
517 | + } |
|
487 | 518 | |
488 | 519 | // Check for https stream support. |
489 | 520 | $supported_streams = stream_get_wrappers(); |
490 | - if (!in_array('https', $supported_streams)) |
|
491 | - $incontext['warning'] = $txt['install_no_https']; |
|
521 | + if (!in_array('https', $supported_streams)) { |
|
522 | + $incontext['warning'] = $txt['install_no_https']; |
|
523 | + } |
|
492 | 524 | |
493 | 525 | return false; |
494 | 526 | } |
@@ -514,12 +546,14 @@ discard block |
||
514 | 546 | 'db_last_error.php', |
515 | 547 | ); |
516 | 548 | |
517 | - foreach ($incontext['detected_languages'] as $lang => $temp) |
|
518 | - $extra_files[] = 'Themes/default/languages/' . $lang; |
|
549 | + foreach ($incontext['detected_languages'] as $lang => $temp) { |
|
550 | + $extra_files[] = 'Themes/default/languages/' . $lang; |
|
551 | + } |
|
519 | 552 | |
520 | 553 | // With mod_security installed, we could attempt to fix it with .htaccess. |
521 | - if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) |
|
522 | - $writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.'; |
|
554 | + if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) { |
|
555 | + $writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.'; |
|
556 | + } |
|
523 | 557 | |
524 | 558 | $failed_files = array(); |
525 | 559 | |
@@ -531,20 +565,23 @@ discard block |
||
531 | 565 | foreach ($writable_files as $file) |
532 | 566 | { |
533 | 567 | // Some files won't exist, try to address up front |
534 | - if (!file_exists(dirname(__FILE__) . '/' . $file)) |
|
535 | - @touch(dirname(__FILE__) . '/' . $file); |
|
568 | + if (!file_exists(dirname(__FILE__) . '/' . $file)) { |
|
569 | + @touch(dirname(__FILE__) . '/' . $file); |
|
570 | + } |
|
536 | 571 | // NOW do the writable check... |
537 | 572 | if (!is_writable(dirname(__FILE__) . '/' . $file)) |
538 | 573 | { |
539 | 574 | @chmod(dirname(__FILE__) . '/' . $file, 0755); |
540 | 575 | |
541 | 576 | // Well, 755 hopefully worked... if not, try 777. |
542 | - if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) |
|
543 | - $failed_files[] = $file; |
|
577 | + if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) { |
|
578 | + $failed_files[] = $file; |
|
579 | + } |
|
544 | 580 | } |
545 | 581 | } |
546 | - foreach ($extra_files as $file) |
|
547 | - @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
582 | + foreach ($extra_files as $file) { |
|
583 | + @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
584 | + } |
|
548 | 585 | } |
549 | 586 | // Windows is trickier. Let's try opening for r+... |
550 | 587 | else |
@@ -554,30 +591,35 @@ discard block |
||
554 | 591 | foreach ($writable_files as $file) |
555 | 592 | { |
556 | 593 | // Folders can't be opened for write... but the index.php in them can ;) |
557 | - if (is_dir(dirname(__FILE__) . '/' . $file)) |
|
558 | - $file .= '/index.php'; |
|
594 | + if (is_dir(dirname(__FILE__) . '/' . $file)) { |
|
595 | + $file .= '/index.php'; |
|
596 | + } |
|
559 | 597 | |
560 | 598 | // Funny enough, chmod actually does do something on windows - it removes the read only attribute. |
561 | 599 | @chmod(dirname(__FILE__) . '/' . $file, 0777); |
562 | 600 | $fp = @fopen(dirname(__FILE__) . '/' . $file, 'r+'); |
563 | 601 | |
564 | 602 | // Hmm, okay, try just for write in that case... |
565 | - if (!is_resource($fp)) |
|
566 | - $fp = @fopen(dirname(__FILE__) . '/' . $file, 'w'); |
|
603 | + if (!is_resource($fp)) { |
|
604 | + $fp = @fopen(dirname(__FILE__) . '/' . $file, 'w'); |
|
605 | + } |
|
567 | 606 | |
568 | - if (!is_resource($fp)) |
|
569 | - $failed_files[] = $file; |
|
607 | + if (!is_resource($fp)) { |
|
608 | + $failed_files[] = $file; |
|
609 | + } |
|
570 | 610 | |
571 | 611 | @fclose($fp); |
572 | 612 | } |
573 | - foreach ($extra_files as $file) |
|
574 | - @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
613 | + foreach ($extra_files as $file) { |
|
614 | + @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
615 | + } |
|
575 | 616 | } |
576 | 617 | |
577 | 618 | $failure = count($failed_files) >= 1; |
578 | 619 | |
579 | - if (!isset($_SERVER)) |
|
580 | - return !$failure; |
|
620 | + if (!isset($_SERVER)) { |
|
621 | + return !$failure; |
|
622 | + } |
|
581 | 623 | |
582 | 624 | // Put the list into context. |
583 | 625 | $incontext['failed_files'] = $failed_files; |
@@ -625,19 +667,23 @@ discard block |
||
625 | 667 | |
626 | 668 | if (!isset($ftp) || $ftp->error !== false) |
627 | 669 | { |
628 | - if (!isset($ftp)) |
|
629 | - $ftp = new ftp_connection(null); |
|
670 | + if (!isset($ftp)) { |
|
671 | + $ftp = new ftp_connection(null); |
|
672 | + } |
|
630 | 673 | // Save the error so we can mess with listing... |
631 | - elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) |
|
632 | - $incontext['ftp_errors'][] = $ftp->last_message; |
|
674 | + elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) { |
|
675 | + $incontext['ftp_errors'][] = $ftp->last_message; |
|
676 | + } |
|
633 | 677 | |
634 | 678 | list ($username, $detect_path, $found_path) = $ftp->detect_path(dirname(__FILE__)); |
635 | 679 | |
636 | - if (empty($_POST['ftp_path']) && $found_path) |
|
637 | - $_POST['ftp_path'] = $detect_path; |
|
680 | + if (empty($_POST['ftp_path']) && $found_path) { |
|
681 | + $_POST['ftp_path'] = $detect_path; |
|
682 | + } |
|
638 | 683 | |
639 | - if (!isset($_POST['ftp_username'])) |
|
640 | - $_POST['ftp_username'] = $username; |
|
684 | + if (!isset($_POST['ftp_username'])) { |
|
685 | + $_POST['ftp_username'] = $username; |
|
686 | + } |
|
641 | 687 | |
642 | 688 | // Set the username etc, into context. |
643 | 689 | $incontext['ftp'] = array( |
@@ -649,8 +695,7 @@ discard block |
||
649 | 695 | ); |
650 | 696 | |
651 | 697 | return false; |
652 | - } |
|
653 | - else |
|
698 | + } else |
|
654 | 699 | { |
655 | 700 | $_SESSION['installer_temp_ftp'] = array( |
656 | 701 | 'server' => $_POST['ftp_server'], |
@@ -664,10 +709,12 @@ discard block |
||
664 | 709 | |
665 | 710 | foreach ($failed_files as $file) |
666 | 711 | { |
667 | - if (!is_writable(dirname(__FILE__) . '/' . $file)) |
|
668 | - $ftp->chmod($file, 0755); |
|
669 | - if (!is_writable(dirname(__FILE__) . '/' . $file)) |
|
670 | - $ftp->chmod($file, 0777); |
|
712 | + if (!is_writable(dirname(__FILE__) . '/' . $file)) { |
|
713 | + $ftp->chmod($file, 0755); |
|
714 | + } |
|
715 | + if (!is_writable(dirname(__FILE__) . '/' . $file)) { |
|
716 | + $ftp->chmod($file, 0777); |
|
717 | + } |
|
671 | 718 | if (!is_writable(dirname(__FILE__) . '/' . $file)) |
672 | 719 | { |
673 | 720 | $failed_files_updated[] = $file; |
@@ -723,15 +770,17 @@ discard block |
||
723 | 770 | |
724 | 771 | if (!$foundOne) |
725 | 772 | { |
726 | - if (isset($db['default_host'])) |
|
727 | - $incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost'; |
|
773 | + if (isset($db['default_host'])) { |
|
774 | + $incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost'; |
|
775 | + } |
|
728 | 776 | if (isset($db['default_user'])) |
729 | 777 | { |
730 | 778 | $incontext['db']['user'] = ini_get($db['default_user']); |
731 | 779 | $incontext['db']['name'] = ini_get($db['default_user']); |
732 | 780 | } |
733 | - if (isset($db['default_password'])) |
|
734 | - $incontext['db']['pass'] = ini_get($db['default_password']); |
|
781 | + if (isset($db['default_password'])) { |
|
782 | + $incontext['db']['pass'] = ini_get($db['default_password']); |
|
783 | + } |
|
735 | 784 | |
736 | 785 | // For simplicity and less confusion, leave the port blank by default |
737 | 786 | $incontext['db']['port'] = ''; |
@@ -750,10 +799,10 @@ discard block |
||
750 | 799 | $incontext['db']['server'] = $_POST['db_server']; |
751 | 800 | $incontext['db']['prefix'] = $_POST['db_prefix']; |
752 | 801 | |
753 | - if (!empty($_POST['db_port'])) |
|
754 | - $incontext['db']['port'] = $_POST['db_port']; |
|
755 | - } |
|
756 | - else |
|
802 | + if (!empty($_POST['db_port'])) { |
|
803 | + $incontext['db']['port'] = $_POST['db_port']; |
|
804 | + } |
|
805 | + } else |
|
757 | 806 | { |
758 | 807 | $incontext['db']['prefix'] = 'smf_'; |
759 | 808 | } |
@@ -789,10 +838,11 @@ discard block |
||
789 | 838 | if (!empty($_POST['db_port'])) |
790 | 839 | { |
791 | 840 | // For MySQL, we can get the "default port" from PHP. PostgreSQL has no such option though. |
792 | - if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) |
|
793 | - $vars['db_port'] = (int) $_POST['db_port']; |
|
794 | - elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) |
|
795 | - $vars['db_port'] = (int) $_POST['db_port']; |
|
841 | + if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) { |
|
842 | + $vars['db_port'] = (int) $_POST['db_port']; |
|
843 | + } elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) { |
|
844 | + $vars['db_port'] = (int) $_POST['db_port']; |
|
845 | + } |
|
796 | 846 | } |
797 | 847 | |
798 | 848 | // God I hope it saved! |
@@ -805,8 +855,9 @@ discard block |
||
805 | 855 | // Make sure it works. |
806 | 856 | require(dirname(__FILE__) . '/Settings.php'); |
807 | 857 | |
808 | - if (empty($sourcedir)) |
|
809 | - $sourcedir = dirname(__FILE__) . '/Sources'; |
|
858 | + if (empty($sourcedir)) { |
|
859 | + $sourcedir = dirname(__FILE__) . '/Sources'; |
|
860 | + } |
|
810 | 861 | |
811 | 862 | // Better find the database file! |
812 | 863 | if (!file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) |
@@ -816,18 +867,21 @@ discard block |
||
816 | 867 | } |
817 | 868 | |
818 | 869 | // Now include it for database functions! |
819 | - if (!defined('SMF')) |
|
820 | - define('SMF', 1); |
|
870 | + if (!defined('SMF')) { |
|
871 | + define('SMF', 1); |
|
872 | + } |
|
821 | 873 | |
822 | 874 | $modSettings['disableQueryCheck'] = true; |
823 | - if (empty($smcFunc)) |
|
824 | - $smcFunc = array(); |
|
875 | + if (empty($smcFunc)) { |
|
876 | + $smcFunc = array(); |
|
877 | + } |
|
825 | 878 | |
826 | 879 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
827 | 880 | |
828 | 881 | // What - running PHP4? The shame! |
829 | - if (version_compare(PHP_VERSION, '5', '<')) |
|
830 | - require_once($sourcedir . '/Subs-Compat.php'); |
|
882 | + if (version_compare(PHP_VERSION, '5', '<')) { |
|
883 | + require_once($sourcedir . '/Subs-Compat.php'); |
|
884 | + } |
|
831 | 885 | |
832 | 886 | // Attempt a connection. |
833 | 887 | $needsDB = !empty($databases[$db_type]['always_has_db']); |
@@ -915,12 +969,14 @@ discard block |
||
915 | 969 | $incontext['page_title'] = $txt['install_settings']; |
916 | 970 | |
917 | 971 | // Let's see if we got the database type correct. |
918 | - if (isset($_POST['db_type'], $databases[$_POST['db_type']])) |
|
919 | - $db_type = $_POST['db_type']; |
|
972 | + if (isset($_POST['db_type'], $databases[$_POST['db_type']])) { |
|
973 | + $db_type = $_POST['db_type']; |
|
974 | + } |
|
920 | 975 | |
921 | 976 | // Else we'd better be able to get the connection. |
922 | - else |
|
923 | - load_database(); |
|
977 | + else { |
|
978 | + load_database(); |
|
979 | + } |
|
924 | 980 | |
925 | 981 | $db_type = isset($_POST['db_type']) ? $_POST['db_type'] : $db_type; |
926 | 982 | |
@@ -957,18 +1013,21 @@ discard block |
||
957 | 1013 | // Submitting? |
958 | 1014 | if (isset($_POST['boardurl'])) |
959 | 1015 | { |
960 | - if (substr($_POST['boardurl'], -10) == '/index.php') |
|
961 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
962 | - elseif (substr($_POST['boardurl'], -1) == '/') |
|
963 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
964 | - if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') |
|
965 | - $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
1016 | + if (substr($_POST['boardurl'], -10) == '/index.php') { |
|
1017 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
1018 | + } elseif (substr($_POST['boardurl'], -1) == '/') { |
|
1019 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
1020 | + } |
|
1021 | + if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') { |
|
1022 | + $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
1023 | + } |
|
966 | 1024 | |
967 | 1025 | //Make sure boardurl is aligned with ssl setting |
968 | - if (empty($_POST['force_ssl'])) |
|
969 | - $_POST['boardurl'] = strtr($_POST['boardurl'], array('https://' => 'http://')); |
|
970 | - else |
|
971 | - $_POST['boardurl'] = strtr($_POST['boardurl'], array('http://' => 'https://')); |
|
1026 | + if (empty($_POST['force_ssl'])) { |
|
1027 | + $_POST['boardurl'] = strtr($_POST['boardurl'], array('https://' => 'http://')); |
|
1028 | + } else { |
|
1029 | + $_POST['boardurl'] = strtr($_POST['boardurl'], array('http://' => 'https://')); |
|
1030 | + } |
|
972 | 1031 | |
973 | 1032 | // Save these variables. |
974 | 1033 | $vars = array( |
@@ -1007,10 +1066,10 @@ discard block |
||
1007 | 1066 | { |
1008 | 1067 | $incontext['error'] = sprintf($txt['error_utf8_version'], $databases[$db_type]['utf8_version']); |
1009 | 1068 | return false; |
1010 | - } |
|
1011 | - else |
|
1012 | - // Set the character set here. |
|
1069 | + } else { |
|
1070 | + // Set the character set here. |
|
1013 | 1071 | updateSettingsFile(array('db_character_set' => 'utf8')); |
1072 | + } |
|
1014 | 1073 | } |
1015 | 1074 | |
1016 | 1075 | // Good, skip on. |
@@ -1030,8 +1089,9 @@ discard block |
||
1030 | 1089 | $incontext['continue'] = 1; |
1031 | 1090 | |
1032 | 1091 | // Already done? |
1033 | - if (isset($_POST['pop_done'])) |
|
1034 | - return true; |
|
1092 | + if (isset($_POST['pop_done'])) { |
|
1093 | + return true; |
|
1094 | + } |
|
1035 | 1095 | |
1036 | 1096 | // Reload settings. |
1037 | 1097 | require(dirname(__FILE__) . '/Settings.php'); |
@@ -1049,8 +1109,9 @@ discard block |
||
1049 | 1109 | $modSettings = array(); |
1050 | 1110 | if ($result !== false) |
1051 | 1111 | { |
1052 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
1053 | - $modSettings[$row['variable']] = $row['value']; |
|
1112 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
1113 | + $modSettings[$row['variable']] = $row['value']; |
|
1114 | + } |
|
1054 | 1115 | $smcFunc['db_free_result']($result); |
1055 | 1116 | |
1056 | 1117 | // Do they match? If so, this is just a refresh so charge on! |
@@ -1063,20 +1124,22 @@ discard block |
||
1063 | 1124 | $modSettings['disableQueryCheck'] = true; |
1064 | 1125 | |
1065 | 1126 | // If doing UTF8, select it. PostgreSQL requires passing it as a string... |
1066 | - if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) |
|
1067 | - $smcFunc['db_query']('', ' |
|
1127 | + if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) { |
|
1128 | + $smcFunc['db_query']('', ' |
|
1068 | 1129 | SET NAMES {string:utf8}', |
1069 | 1130 | array( |
1070 | 1131 | 'db_error_skip' => true, |
1071 | 1132 | 'utf8' => 'utf8', |
1072 | 1133 | ) |
1073 | 1134 | ); |
1135 | + } |
|
1074 | 1136 | |
1075 | 1137 | // Windows likes to leave the trailing slash, which yields to C:\path\to\SMF\/attachments... |
1076 | - if (substr(__DIR__, -1) == '\\') |
|
1077 | - $attachdir = __DIR__ . 'attachments'; |
|
1078 | - else |
|
1079 | - $attachdir = __DIR__ . '/attachments'; |
|
1138 | + if (substr(__DIR__, -1) == '\\') { |
|
1139 | + $attachdir = __DIR__ . 'attachments'; |
|
1140 | + } else { |
|
1141 | + $attachdir = __DIR__ . '/attachments'; |
|
1142 | + } |
|
1080 | 1143 | |
1081 | 1144 | $replaces = array( |
1082 | 1145 | '{$db_prefix}' => $db_prefix, |
@@ -1093,8 +1156,9 @@ discard block |
||
1093 | 1156 | |
1094 | 1157 | foreach ($txt as $key => $value) |
1095 | 1158 | { |
1096 | - if (substr($key, 0, 8) == 'default_') |
|
1097 | - $replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value); |
|
1159 | + if (substr($key, 0, 8) == 'default_') { |
|
1160 | + $replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value); |
|
1161 | + } |
|
1098 | 1162 | } |
1099 | 1163 | $replaces['{$default_reserved_names}'] = strtr($replaces['{$default_reserved_names}'], array('\\\\n' => '\\n')); |
1100 | 1164 | |
@@ -1109,8 +1173,9 @@ discard block |
||
1109 | 1173 | |
1110 | 1174 | while ($row = $smcFunc['db_fetch_assoc']($get_engines)) |
1111 | 1175 | { |
1112 | - if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') |
|
1113 | - $engines[] = $row['Engine']; |
|
1176 | + if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') { |
|
1177 | + $engines[] = $row['Engine']; |
|
1178 | + } |
|
1114 | 1179 | } |
1115 | 1180 | |
1116 | 1181 | // Done with this now |
@@ -1134,8 +1199,7 @@ discard block |
||
1134 | 1199 | $replaces['START TRANSACTION;'] = ''; |
1135 | 1200 | $replaces['COMMIT;'] = ''; |
1136 | 1201 | } |
1137 | - } |
|
1138 | - else |
|
1202 | + } else |
|
1139 | 1203 | { |
1140 | 1204 | $has_innodb = false; |
1141 | 1205 | } |
@@ -1157,21 +1221,24 @@ discard block |
||
1157 | 1221 | foreach ($sql_lines as $count => $line) |
1158 | 1222 | { |
1159 | 1223 | // No comments allowed! |
1160 | - if (substr(trim($line), 0, 1) != '#') |
|
1161 | - $current_statement .= "\n" . rtrim($line); |
|
1224 | + if (substr(trim($line), 0, 1) != '#') { |
|
1225 | + $current_statement .= "\n" . rtrim($line); |
|
1226 | + } |
|
1162 | 1227 | |
1163 | 1228 | // Is this the end of the query string? |
1164 | - if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) |
|
1165 | - continue; |
|
1229 | + if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) { |
|
1230 | + continue; |
|
1231 | + } |
|
1166 | 1232 | |
1167 | 1233 | // Does this table already exist? If so, don't insert more data into it! |
1168 | 1234 | if (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) != 0 && in_array($match[1], $exists)) |
1169 | 1235 | { |
1170 | 1236 | preg_match_all('~\)[,;]~', $current_statement, $matches); |
1171 | - if (!empty($matches[0])) |
|
1172 | - $incontext['sql_results']['insert_dups'] += count($matches[0]); |
|
1173 | - else |
|
1174 | - $incontext['sql_results']['insert_dups']++; |
|
1237 | + if (!empty($matches[0])) { |
|
1238 | + $incontext['sql_results']['insert_dups'] += count($matches[0]); |
|
1239 | + } else { |
|
1240 | + $incontext['sql_results']['insert_dups']++; |
|
1241 | + } |
|
1175 | 1242 | |
1176 | 1243 | $current_statement = ''; |
1177 | 1244 | continue; |
@@ -1180,8 +1247,9 @@ discard block |
||
1180 | 1247 | if ($smcFunc['db_query']('', $current_statement, array('security_override' => true, 'db_error_skip' => true), $db_connection) === false) |
1181 | 1248 | { |
1182 | 1249 | // Use the appropriate function based on the DB type |
1183 | - if ($db_type == 'mysql' || $db_type == 'mysqli') |
|
1184 | - $db_errorno = $db_type . '_errno'; |
|
1250 | + if ($db_type == 'mysql' || $db_type == 'mysqli') { |
|
1251 | + $db_errorno = $db_type . '_errno'; |
|
1252 | + } |
|
1185 | 1253 | |
1186 | 1254 | // Error 1050: Table already exists! |
1187 | 1255 | // @todo Needs to be made better! |
@@ -1196,18 +1264,18 @@ discard block |
||
1196 | 1264 | // MySQLi requires a connection object. It's optional with MySQL and Postgres |
1197 | 1265 | $incontext['failures'][$count] = $smcFunc['db_error']($db_connection); |
1198 | 1266 | } |
1199 | - } |
|
1200 | - else |
|
1267 | + } else |
|
1201 | 1268 | { |
1202 | - if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
1203 | - $incontext['sql_results']['tables']++; |
|
1204 | - elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
1269 | + if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) { |
|
1270 | + $incontext['sql_results']['tables']++; |
|
1271 | + } elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
1205 | 1272 | { |
1206 | 1273 | preg_match_all('~\)[,;]~', $current_statement, $matches); |
1207 | - if (!empty($matches[0])) |
|
1208 | - $incontext['sql_results']['inserts'] += count($matches[0]); |
|
1209 | - else |
|
1210 | - $incontext['sql_results']['inserts']++; |
|
1274 | + if (!empty($matches[0])) { |
|
1275 | + $incontext['sql_results']['inserts'] += count($matches[0]); |
|
1276 | + } else { |
|
1277 | + $incontext['sql_results']['inserts']++; |
|
1278 | + } |
|
1211 | 1279 | } |
1212 | 1280 | } |
1213 | 1281 | |
@@ -1220,15 +1288,17 @@ discard block |
||
1220 | 1288 | // Sort out the context for the SQL. |
1221 | 1289 | foreach ($incontext['sql_results'] as $key => $number) |
1222 | 1290 | { |
1223 | - if ($number == 0) |
|
1224 | - unset($incontext['sql_results'][$key]); |
|
1225 | - else |
|
1226 | - $incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number); |
|
1291 | + if ($number == 0) { |
|
1292 | + unset($incontext['sql_results'][$key]); |
|
1293 | + } else { |
|
1294 | + $incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number); |
|
1295 | + } |
|
1227 | 1296 | } |
1228 | 1297 | |
1229 | 1298 | // Make sure UTF will be used globally. |
1230 | - if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) |
|
1231 | - $newSettings[] = array('global_character_set', 'UTF-8'); |
|
1299 | + if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) { |
|
1300 | + $newSettings[] = array('global_character_set', 'UTF-8'); |
|
1301 | + } |
|
1232 | 1302 | |
1233 | 1303 | // Auto-detect local & global cookie settings |
1234 | 1304 | $url_parts = parse_url($boardurl); |
@@ -1254,15 +1324,19 @@ discard block |
||
1254 | 1324 | |
1255 | 1325 | // Look for subfolder, if found, set localCookie |
1256 | 1326 | // Checking for len > 1 ensures you don't have just a slash... |
1257 | - if (!empty($url_parts['path']) && strlen($url_parts['path']) > 1) |
|
1258 | - $localCookies = '1'; |
|
1327 | + if (!empty($url_parts['path']) && strlen($url_parts['path']) > 1) { |
|
1328 | + $localCookies = '1'; |
|
1329 | + } |
|
1259 | 1330 | |
1260 | - if (isset($globalCookies)) |
|
1261 | - $newSettings[] = array('globalCookies', $globalCookies); |
|
1262 | - if (isset($globalCookiesDomain)) |
|
1263 | - $newSettings[] = array('globalCookiesDomain', $globalCookiesDomain); |
|
1264 | - if (isset($localCookies)) |
|
1265 | - $newSettings[] = array('localCookies', $localCookies); |
|
1331 | + if (isset($globalCookies)) { |
|
1332 | + $newSettings[] = array('globalCookies', $globalCookies); |
|
1333 | + } |
|
1334 | + if (isset($globalCookiesDomain)) { |
|
1335 | + $newSettings[] = array('globalCookiesDomain', $globalCookiesDomain); |
|
1336 | + } |
|
1337 | + if (isset($localCookies)) { |
|
1338 | + $newSettings[] = array('localCookies', $localCookies); |
|
1339 | + } |
|
1266 | 1340 | } |
1267 | 1341 | |
1268 | 1342 | // Are we allowing stat collection? |
@@ -1280,16 +1354,17 @@ discard block |
||
1280 | 1354 | fwrite($fp, $out); |
1281 | 1355 | |
1282 | 1356 | $return_data = ''; |
1283 | - while (!feof($fp)) |
|
1284 | - $return_data .= fgets($fp, 128); |
|
1357 | + while (!feof($fp)) { |
|
1358 | + $return_data .= fgets($fp, 128); |
|
1359 | + } |
|
1285 | 1360 | |
1286 | 1361 | fclose($fp); |
1287 | 1362 | |
1288 | 1363 | // Get the unique site ID. |
1289 | 1364 | preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID); |
1290 | 1365 | |
1291 | - if (!empty($ID[1])) |
|
1292 | - $smcFunc['db_insert']('replace', |
|
1366 | + if (!empty($ID[1])) { |
|
1367 | + $smcFunc['db_insert']('replace', |
|
1293 | 1368 | $db_prefix . 'settings', |
1294 | 1369 | array('variable' => 'string', 'value' => 'string'), |
1295 | 1370 | array( |
@@ -1298,11 +1373,12 @@ discard block |
||
1298 | 1373 | ), |
1299 | 1374 | array('variable') |
1300 | 1375 | ); |
1376 | + } |
|
1301 | 1377 | } |
1302 | 1378 | } |
1303 | 1379 | // Don't remove stat collection unless we unchecked the box for real, not from the loop. |
1304 | - elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) |
|
1305 | - $smcFunc['db_query']('', ' |
|
1380 | + elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) { |
|
1381 | + $smcFunc['db_query']('', ' |
|
1306 | 1382 | DELETE FROM {db_prefix}settings |
1307 | 1383 | WHERE variable = {string:enable_sm_stats}', |
1308 | 1384 | array( |
@@ -1310,20 +1386,23 @@ discard block |
||
1310 | 1386 | 'db_error_skip' => true, |
1311 | 1387 | ) |
1312 | 1388 | ); |
1389 | + } |
|
1313 | 1390 | |
1314 | 1391 | // Are we enabling SSL? |
1315 | - if (!empty($_POST['force_ssl'])) |
|
1316 | - $newSettings[] = array('force_ssl', 2); |
|
1392 | + if (!empty($_POST['force_ssl'])) { |
|
1393 | + $newSettings[] = array('force_ssl', 2); |
|
1394 | + } |
|
1317 | 1395 | |
1318 | 1396 | // Setting a timezone is required. |
1319 | 1397 | if (!isset($modSettings['default_timezone']) && function_exists('date_default_timezone_set')) |
1320 | 1398 | { |
1321 | 1399 | // Get PHP's default timezone, if set |
1322 | 1400 | $ini_tz = ini_get('date.timezone'); |
1323 | - if (!empty($ini_tz)) |
|
1324 | - $timezone_id = $ini_tz; |
|
1325 | - else |
|
1326 | - $timezone_id = ''; |
|
1401 | + if (!empty($ini_tz)) { |
|
1402 | + $timezone_id = $ini_tz; |
|
1403 | + } else { |
|
1404 | + $timezone_id = ''; |
|
1405 | + } |
|
1327 | 1406 | |
1328 | 1407 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
1329 | 1408 | if (!in_array($timezone_id, timezone_identifiers_list())) |
@@ -1332,8 +1411,9 @@ discard block |
||
1332 | 1411 | $timezone_id = timezone_name_from_abbr('', $server_offset, 0); |
1333 | 1412 | } |
1334 | 1413 | |
1335 | - if (date_default_timezone_set($timezone_id)) |
|
1336 | - $newSettings[] = array('default_timezone', $timezone_id); |
|
1414 | + if (date_default_timezone_set($timezone_id)) { |
|
1415 | + $newSettings[] = array('default_timezone', $timezone_id); |
|
1416 | + } |
|
1337 | 1417 | } |
1338 | 1418 | |
1339 | 1419 | if (!empty($newSettings)) |
@@ -1364,16 +1444,18 @@ discard block |
||
1364 | 1444 | } |
1365 | 1445 | |
1366 | 1446 | // MySQL specific stuff |
1367 | - if (substr($db_type, 0, 5) != 'mysql') |
|
1368 | - return false; |
|
1447 | + if (substr($db_type, 0, 5) != 'mysql') { |
|
1448 | + return false; |
|
1449 | + } |
|
1369 | 1450 | |
1370 | 1451 | // Find database user privileges. |
1371 | 1452 | $privs = array(); |
1372 | 1453 | $get_privs = $smcFunc['db_query']('', 'SHOW PRIVILEGES', array()); |
1373 | 1454 | while ($row = $smcFunc['db_fetch_assoc']($get_privs)) |
1374 | 1455 | { |
1375 | - if ($row['Privilege'] == 'Alter') |
|
1376 | - $privs[] = $row['Privilege']; |
|
1456 | + if ($row['Privilege'] == 'Alter') { |
|
1457 | + $privs[] = $row['Privilege']; |
|
1458 | + } |
|
1377 | 1459 | } |
1378 | 1460 | $smcFunc['db_free_result']($get_privs); |
1379 | 1461 | |
@@ -1403,8 +1485,9 @@ discard block |
||
1403 | 1485 | $incontext['continue'] = 1; |
1404 | 1486 | |
1405 | 1487 | // Skipping? |
1406 | - if (!empty($_POST['skip'])) |
|
1407 | - return true; |
|
1488 | + if (!empty($_POST['skip'])) { |
|
1489 | + return true; |
|
1490 | + } |
|
1408 | 1491 | |
1409 | 1492 | // Need this to check whether we need the database password. |
1410 | 1493 | require(dirname(__FILE__) . '/Settings.php'); |
@@ -1421,18 +1504,22 @@ discard block |
||
1421 | 1504 | // We need this to properly hash the password for Admin |
1422 | 1505 | $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) { |
1423 | 1506 | global $sourcedir; |
1424 | - if (function_exists('mb_strtolower')) |
|
1425 | - return mb_strtolower($string, 'UTF-8'); |
|
1507 | + if (function_exists('mb_strtolower')) { |
|
1508 | + return mb_strtolower($string, 'UTF-8'); |
|
1509 | + } |
|
1426 | 1510 | require_once($sourcedir . '/Subs-Charset.php'); |
1427 | 1511 | return utf8_strtolower($string); |
1428 | 1512 | }; |
1429 | 1513 | |
1430 | - if (!isset($_POST['username'])) |
|
1431 | - $_POST['username'] = ''; |
|
1432 | - if (!isset($_POST['email'])) |
|
1433 | - $_POST['email'] = ''; |
|
1434 | - if (!isset($_POST['server_email'])) |
|
1435 | - $_POST['server_email'] = ''; |
|
1514 | + if (!isset($_POST['username'])) { |
|
1515 | + $_POST['username'] = ''; |
|
1516 | + } |
|
1517 | + if (!isset($_POST['email'])) { |
|
1518 | + $_POST['email'] = ''; |
|
1519 | + } |
|
1520 | + if (!isset($_POST['server_email'])) { |
|
1521 | + $_POST['server_email'] = ''; |
|
1522 | + } |
|
1436 | 1523 | |
1437 | 1524 | $incontext['username'] = htmlspecialchars(stripslashes($_POST['username'])); |
1438 | 1525 | $incontext['email'] = htmlspecialchars(stripslashes($_POST['email'])); |
@@ -1451,8 +1538,9 @@ discard block |
||
1451 | 1538 | 'admin_group' => 1, |
1452 | 1539 | ) |
1453 | 1540 | ); |
1454 | - if ($smcFunc['db_num_rows']($request) != 0) |
|
1455 | - $incontext['skip'] = 1; |
|
1541 | + if ($smcFunc['db_num_rows']($request) != 0) { |
|
1542 | + $incontext['skip'] = 1; |
|
1543 | + } |
|
1456 | 1544 | $smcFunc['db_free_result']($request); |
1457 | 1545 | |
1458 | 1546 | // Trying to create an account? |
@@ -1483,8 +1571,9 @@ discard block |
||
1483 | 1571 | } |
1484 | 1572 | |
1485 | 1573 | // Update the webmaster's email? |
1486 | - if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) |
|
1487 | - updateSettingsFile(array('webmaster_email' => $_POST['server_email'])); |
|
1574 | + if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) { |
|
1575 | + updateSettingsFile(array('webmaster_email' => $_POST['server_email'])); |
|
1576 | + } |
|
1488 | 1577 | |
1489 | 1578 | // Work out whether we're going to have dodgy characters and remove them. |
1490 | 1579 | $invalid_characters = preg_match('~[<>&"\'=\\\]~', $_POST['username']) != 0; |
@@ -1507,32 +1596,27 @@ discard block |
||
1507 | 1596 | $smcFunc['db_free_result']($result); |
1508 | 1597 | |
1509 | 1598 | $incontext['account_existed'] = $txt['error_user_settings_taken']; |
1510 | - } |
|
1511 | - elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25) |
|
1599 | + } elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25) |
|
1512 | 1600 | { |
1513 | 1601 | // Try the previous step again. |
1514 | 1602 | $incontext['error'] = $_POST['username'] == '' ? $txt['error_username_left_empty'] : $txt['error_username_too_long']; |
1515 | 1603 | return false; |
1516 | - } |
|
1517 | - elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false) |
|
1604 | + } elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false) |
|
1518 | 1605 | { |
1519 | 1606 | // Try the previous step again. |
1520 | 1607 | $incontext['error'] = $txt['error_invalid_characters_username']; |
1521 | 1608 | return false; |
1522 | - } |
|
1523 | - elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255) |
|
1609 | + } elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255) |
|
1524 | 1610 | { |
1525 | 1611 | // One step back, this time fill out a proper admin email address. |
1526 | 1612 | $incontext['error'] = sprintf($txt['error_valid_admin_email_needed'], $_POST['username']); |
1527 | 1613 | return false; |
1528 | - } |
|
1529 | - elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255) |
|
1614 | + } elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255) |
|
1530 | 1615 | { |
1531 | 1616 | // One step back, this time fill out a proper admin email address. |
1532 | 1617 | $incontext['error'] = $txt['error_valid_server_email_needed']; |
1533 | 1618 | return false; |
1534 | - } |
|
1535 | - elseif ($_POST['username'] != '') |
|
1619 | + } elseif ($_POST['username'] != '') |
|
1536 | 1620 | { |
1537 | 1621 | $incontext['member_salt'] = substr(md5(mt_rand()), 0, 4); |
1538 | 1622 | |
@@ -1600,17 +1684,19 @@ discard block |
||
1600 | 1684 | reloadSettings(); |
1601 | 1685 | |
1602 | 1686 | // Bring a warning over. |
1603 | - if (!empty($incontext['account_existed'])) |
|
1604 | - $incontext['warning'] = $incontext['account_existed']; |
|
1687 | + if (!empty($incontext['account_existed'])) { |
|
1688 | + $incontext['warning'] = $incontext['account_existed']; |
|
1689 | + } |
|
1605 | 1690 | |
1606 | - if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) |
|
1607 | - $smcFunc['db_query']('', ' |
|
1691 | + if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) { |
|
1692 | + $smcFunc['db_query']('', ' |
|
1608 | 1693 | SET NAMES {string:db_character_set}', |
1609 | 1694 | array( |
1610 | 1695 | 'db_character_set' => $db_character_set, |
1611 | 1696 | 'db_error_skip' => true, |
1612 | 1697 | ) |
1613 | 1698 | ); |
1699 | + } |
|
1614 | 1700 | |
1615 | 1701 | // As track stats is by default enabled let's add some activity. |
1616 | 1702 | $smcFunc['db_insert']('ignore', |
@@ -1631,14 +1717,16 @@ discard block |
||
1631 | 1717 | // Only proceed if we can load the data. |
1632 | 1718 | if ($request) |
1633 | 1719 | { |
1634 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
1635 | - $modSettings[$row[0]] = $row[1]; |
|
1720 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
1721 | + $modSettings[$row[0]] = $row[1]; |
|
1722 | + } |
|
1636 | 1723 | $smcFunc['db_free_result']($request); |
1637 | 1724 | } |
1638 | 1725 | |
1639 | 1726 | // Automatically log them in ;) |
1640 | - if (isset($incontext['member_id']) && isset($incontext['member_salt'])) |
|
1641 | - setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt'])); |
|
1727 | + if (isset($incontext['member_id']) && isset($incontext['member_salt'])) { |
|
1728 | + setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt'])); |
|
1729 | + } |
|
1642 | 1730 | |
1643 | 1731 | $result = $smcFunc['db_query']('', ' |
1644 | 1732 | SELECT value |
@@ -1649,13 +1737,14 @@ discard block |
||
1649 | 1737 | 'db_error_skip' => true, |
1650 | 1738 | ) |
1651 | 1739 | ); |
1652 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
1653 | - list ($db_sessions) = $smcFunc['db_fetch_row']($result); |
|
1740 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
1741 | + list ($db_sessions) = $smcFunc['db_fetch_row']($result); |
|
1742 | + } |
|
1654 | 1743 | $smcFunc['db_free_result']($result); |
1655 | 1744 | |
1656 | - if (empty($db_sessions)) |
|
1657 | - $_SESSION['admin_time'] = time(); |
|
1658 | - else |
|
1745 | + if (empty($db_sessions)) { |
|
1746 | + $_SESSION['admin_time'] = time(); |
|
1747 | + } else |
|
1659 | 1748 | { |
1660 | 1749 | $_SERVER['HTTP_USER_AGENT'] = substr($_SERVER['HTTP_USER_AGENT'], 0, 211); |
1661 | 1750 | |
@@ -1679,8 +1768,9 @@ discard block |
||
1679 | 1768 | $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : |
1680 | 1769 | function($string){ |
1681 | 1770 | global $sourcedir; |
1682 | - if (function_exists('mb_strtolower')) |
|
1683 | - return mb_strtolower($string, 'UTF-8'); |
|
1771 | + if (function_exists('mb_strtolower')) { |
|
1772 | + return mb_strtolower($string, 'UTF-8'); |
|
1773 | + } |
|
1684 | 1774 | require_once($sourcedir . '/Subs-Charset.php'); |
1685 | 1775 | return utf8_strtolower($string); |
1686 | 1776 | }; |
@@ -1696,8 +1786,9 @@ discard block |
||
1696 | 1786 | ) |
1697 | 1787 | ); |
1698 | 1788 | $context['utf8'] = $db_character_set === 'utf8' || $txt['lang_character_set'] === 'UTF-8'; |
1699 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
1700 | - updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject'])); |
|
1789 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
1790 | + updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject'])); |
|
1791 | + } |
|
1701 | 1792 | $smcFunc['db_free_result']($request); |
1702 | 1793 | |
1703 | 1794 | // Now is the perfect time to fetch the SM files. |
@@ -1716,8 +1807,9 @@ discard block |
||
1716 | 1807 | |
1717 | 1808 | // Check if we need some stupid MySQL fix. |
1718 | 1809 | $server_version = $smcFunc['db_server_info'](); |
1719 | - if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) |
|
1720 | - updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
1810 | + if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) { |
|
1811 | + updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
1812 | + } |
|
1721 | 1813 | |
1722 | 1814 | // Some final context for the template. |
1723 | 1815 | $incontext['dir_still_writable'] = is_writable(dirname(__FILE__)) && substr(__FILE__, 1, 2) != ':\\'; |
@@ -1737,8 +1829,9 @@ discard block |
||
1737 | 1829 | $settingsArray = file(dirname(__FILE__) . '/Settings.php'); |
1738 | 1830 | |
1739 | 1831 | // @todo Do we just want to read the file in clean, and split it this way always? |
1740 | - if (count($settingsArray) == 1) |
|
1741 | - $settingsArray = preg_split('~[\r\n]~', $settingsArray[0]); |
|
1832 | + if (count($settingsArray) == 1) { |
|
1833 | + $settingsArray = preg_split('~[\r\n]~', $settingsArray[0]); |
|
1834 | + } |
|
1742 | 1835 | |
1743 | 1836 | for ($i = 0, $n = count($settingsArray); $i < $n; $i++) |
1744 | 1837 | { |
@@ -1753,19 +1846,22 @@ discard block |
||
1753 | 1846 | continue; |
1754 | 1847 | } |
1755 | 1848 | |
1756 | - if (trim($settingsArray[$i]) == '?' . '>') |
|
1757 | - $settingsArray[$i] = ''; |
|
1849 | + if (trim($settingsArray[$i]) == '?' . '>') { |
|
1850 | + $settingsArray[$i] = ''; |
|
1851 | + } |
|
1758 | 1852 | |
1759 | 1853 | // Don't trim or bother with it if it's not a variable. |
1760 | - if (substr($settingsArray[$i], 0, 1) != '$') |
|
1761 | - continue; |
|
1854 | + if (substr($settingsArray[$i], 0, 1) != '$') { |
|
1855 | + continue; |
|
1856 | + } |
|
1762 | 1857 | |
1763 | 1858 | $settingsArray[$i] = rtrim($settingsArray[$i]) . "\n"; |
1764 | 1859 | |
1765 | - foreach ($vars as $var => $val) |
|
1766 | - if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0) |
|
1860 | + foreach ($vars as $var => $val) { |
|
1861 | + if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0) |
|
1767 | 1862 | { |
1768 | 1863 | $comment = strstr($settingsArray[$i], '#'); |
1864 | + } |
|
1769 | 1865 | $settingsArray[$i] = '$' . $var . ' = \'' . $val . '\';' . ($comment != '' ? "\t\t" . $comment : "\n"); |
1770 | 1866 | unset($vars[$var]); |
1771 | 1867 | } |
@@ -1775,36 +1871,41 @@ discard block |
||
1775 | 1871 | if (!empty($vars)) |
1776 | 1872 | { |
1777 | 1873 | $settingsArray[$i++] = ''; |
1778 | - foreach ($vars as $var => $val) |
|
1779 | - $settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n"; |
|
1874 | + foreach ($vars as $var => $val) { |
|
1875 | + $settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n"; |
|
1876 | + } |
|
1780 | 1877 | } |
1781 | 1878 | |
1782 | 1879 | // Blank out the file - done to fix a oddity with some servers. |
1783 | 1880 | $fp = @fopen(dirname(__FILE__) . '/Settings.php', 'w'); |
1784 | - if (!$fp) |
|
1785 | - return false; |
|
1881 | + if (!$fp) { |
|
1882 | + return false; |
|
1883 | + } |
|
1786 | 1884 | fclose($fp); |
1787 | 1885 | |
1788 | 1886 | $fp = fopen(dirname(__FILE__) . '/Settings.php', 'r+'); |
1789 | 1887 | |
1790 | 1888 | // Gotta have one of these ;) |
1791 | - if (trim($settingsArray[0]) != '<?php') |
|
1792 | - fwrite($fp, "<?php\n"); |
|
1889 | + if (trim($settingsArray[0]) != '<?php') { |
|
1890 | + fwrite($fp, "<?php\n"); |
|
1891 | + } |
|
1793 | 1892 | |
1794 | 1893 | $lines = count($settingsArray); |
1795 | 1894 | for ($i = 0; $i < $lines - 1; $i++) |
1796 | 1895 | { |
1797 | 1896 | // Don't just write a bunch of blank lines. |
1798 | - if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') |
|
1799 | - fwrite($fp, strtr($settingsArray[$i], "\r", '')); |
|
1897 | + if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') { |
|
1898 | + fwrite($fp, strtr($settingsArray[$i], "\r", '')); |
|
1899 | + } |
|
1800 | 1900 | } |
1801 | 1901 | fwrite($fp, $settingsArray[$i] . '?' . '>'); |
1802 | 1902 | fclose($fp); |
1803 | 1903 | |
1804 | 1904 | // Even though on normal installations the filemtime should prevent this being used by the installer incorrectly |
1805 | 1905 | // it seems that there are times it might not. So let's MAKE it dump the cache. |
1806 | - if (function_exists('opcache_invalidate')) |
|
1807 | - opcache_invalidate(dirname(__FILE__) . '/Settings.php', true); |
|
1906 | + if (function_exists('opcache_invalidate')) { |
|
1907 | + opcache_invalidate(dirname(__FILE__) . '/Settings.php', true); |
|
1908 | + } |
|
1808 | 1909 | |
1809 | 1910 | return true; |
1810 | 1911 | } |
@@ -1829,9 +1930,9 @@ discard block |
||
1829 | 1930 | SecFilterScanPOST Off |
1830 | 1931 | </IfModule>'; |
1831 | 1932 | |
1832 | - if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) |
|
1833 | - return true; |
|
1834 | - elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess')) |
|
1933 | + if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) { |
|
1934 | + return true; |
|
1935 | + } elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess')) |
|
1835 | 1936 | { |
1836 | 1937 | $current_htaccess = implode('', file(dirname(__FILE__) . '/.htaccess')); |
1837 | 1938 | |
@@ -1843,29 +1944,28 @@ discard block |
||
1843 | 1944 | fwrite($ht_handle, $htaccess_addition); |
1844 | 1945 | fclose($ht_handle); |
1845 | 1946 | return true; |
1947 | + } else { |
|
1948 | + return false; |
|
1846 | 1949 | } |
1847 | - else |
|
1848 | - return false; |
|
1950 | + } else { |
|
1951 | + return true; |
|
1849 | 1952 | } |
1850 | - else |
|
1851 | - return true; |
|
1852 | - } |
|
1853 | - elseif (file_exists(dirname(__FILE__) . '/.htaccess')) |
|
1854 | - return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false; |
|
1855 | - elseif (is_writable(dirname(__FILE__))) |
|
1953 | + } elseif (file_exists(dirname(__FILE__) . '/.htaccess')) { |
|
1954 | + return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false; |
|
1955 | + } elseif (is_writable(dirname(__FILE__))) |
|
1856 | 1956 | { |
1857 | 1957 | if ($ht_handle = fopen(dirname(__FILE__) . '/.htaccess', 'w')) |
1858 | 1958 | { |
1859 | 1959 | fwrite($ht_handle, $htaccess_addition); |
1860 | 1960 | fclose($ht_handle); |
1861 | 1961 | return true; |
1962 | + } else { |
|
1963 | + return false; |
|
1862 | 1964 | } |
1863 | - else |
|
1965 | + } else { |
|
1864 | 1966 | return false; |
1865 | 1967 | } |
1866 | - else |
|
1867 | - return false; |
|
1868 | -} |
|
1968 | + } |
|
1869 | 1969 | |
1870 | 1970 | function template_install_above() |
1871 | 1971 | { |
@@ -1903,9 +2003,10 @@ discard block |
||
1903 | 2003 | <label for="installer_language">', $txt['installer_language'], ':</label> |
1904 | 2004 | <select id="installer_language" name="lang_file" onchange="location.href = \'', $installurl, '?lang_file=\' + this.options[this.selectedIndex].value;">'; |
1905 | 2005 | |
1906 | - foreach ($incontext['detected_languages'] as $lang => $name) |
|
1907 | - echo ' |
|
2006 | + foreach ($incontext['detected_languages'] as $lang => $name) { |
|
2007 | + echo ' |
|
1908 | 2008 | <option', isset($_SESSION['installer_temp_lang']) && $_SESSION['installer_temp_lang'] == $lang ? ' selected' : '', ' value="', $lang, '">', $name, '</option>'; |
2009 | + } |
|
1909 | 2010 | |
1910 | 2011 | echo ' |
1911 | 2012 | </select> |
@@ -1925,9 +2026,10 @@ discard block |
||
1925 | 2026 | <h2>', $txt['upgrade_progress'], '</h2> |
1926 | 2027 | <ul>'; |
1927 | 2028 | |
1928 | - foreach ($incontext['steps'] as $num => $step) |
|
1929 | - echo ' |
|
2029 | + foreach ($incontext['steps'] as $num => $step) { |
|
2030 | + echo ' |
|
1930 | 2031 | <li class="', $num < $incontext['current_step'] ? 'stepdone' : ($num == $incontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>'; |
2032 | + } |
|
1931 | 2033 | |
1932 | 2034 | echo ' |
1933 | 2035 | </ul> |
@@ -1952,20 +2054,23 @@ discard block |
||
1952 | 2054 | echo ' |
1953 | 2055 | <div class="floatright">'; |
1954 | 2056 | |
1955 | - if (!empty($incontext['continue'])) |
|
1956 | - echo ' |
|
2057 | + if (!empty($incontext['continue'])) { |
|
2058 | + echo ' |
|
1957 | 2059 | <input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '" onclick="return submitThisOnce(this);" class="button" />'; |
1958 | - if (!empty($incontext['skip'])) |
|
1959 | - echo ' |
|
2060 | + } |
|
2061 | + if (!empty($incontext['skip'])) { |
|
2062 | + echo ' |
|
1960 | 2063 | <input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="return submitThisOnce(this);" class="button" />'; |
2064 | + } |
|
1961 | 2065 | echo ' |
1962 | 2066 | </div>'; |
1963 | 2067 | } |
1964 | 2068 | |
1965 | 2069 | // Show the closing form tag and other data only if not in the last step |
1966 | - if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) |
|
1967 | - echo ' |
|
2070 | + if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) { |
|
2071 | + echo ' |
|
1968 | 2072 | </form>'; |
2073 | + } |
|
1969 | 2074 | |
1970 | 2075 | echo ' |
1971 | 2076 | </div> |
@@ -2000,13 +2105,15 @@ discard block |
||
2000 | 2105 | </div>'; |
2001 | 2106 | |
2002 | 2107 | // Show the warnings, or not. |
2003 | - if (template_warning_divs()) |
|
2004 | - echo ' |
|
2108 | + if (template_warning_divs()) { |
|
2109 | + echo ' |
|
2005 | 2110 | <h3>', $txt['install_all_lovely'], '</h3>'; |
2111 | + } |
|
2006 | 2112 | |
2007 | 2113 | // Say we want the continue button! |
2008 | - if (empty($incontext['error'])) |
|
2009 | - $incontext['continue'] = 1; |
|
2114 | + if (empty($incontext['error'])) { |
|
2115 | + $incontext['continue'] = 1; |
|
2116 | + } |
|
2010 | 2117 | |
2011 | 2118 | // For the latest version stuff. |
2012 | 2119 | echo ' |
@@ -2040,8 +2147,8 @@ discard block |
||
2040 | 2147 | global $txt, $incontext; |
2041 | 2148 | |
2042 | 2149 | // Errors are very serious.. |
2043 | - if (!empty($incontext['error'])) |
|
2044 | - echo ' |
|
2150 | + if (!empty($incontext['error'])) { |
|
2151 | + echo ' |
|
2045 | 2152 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
2046 | 2153 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
2047 | 2154 | <strong style="text-decoration: underline;">', $txt['upgrade_critical_error'], '</strong><br> |
@@ -2049,9 +2156,10 @@ discard block |
||
2049 | 2156 | ', $incontext['error'], ' |
2050 | 2157 | </div> |
2051 | 2158 | </div>'; |
2159 | + } |
|
2052 | 2160 | // A warning message? |
2053 | - elseif (!empty($incontext['warning'])) |
|
2054 | - echo ' |
|
2161 | + elseif (!empty($incontext['warning'])) { |
|
2162 | + echo ' |
|
2055 | 2163 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
2056 | 2164 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
2057 | 2165 | <strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br> |
@@ -2059,6 +2167,7 @@ discard block |
||
2059 | 2167 | ', $incontext['warning'], ' |
2060 | 2168 | </div> |
2061 | 2169 | </div>'; |
2170 | + } |
|
2062 | 2171 | |
2063 | 2172 | return empty($incontext['error']) && empty($incontext['warning']); |
2064 | 2173 | } |
@@ -2074,27 +2183,30 @@ discard block |
||
2074 | 2183 | <li>', $incontext['failed_files']), '</li> |
2075 | 2184 | </ul>'; |
2076 | 2185 | |
2077 | - if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') |
|
2078 | - echo ' |
|
2186 | + if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') { |
|
2187 | + echo ' |
|
2079 | 2188 | <hr> |
2080 | 2189 | <p>', $txt['chmod_linux_info'], '</p> |
2081 | 2190 | <tt># chmod a+w ', implode(' ' . $incontext['detected_path'] . '/', $incontext['failed_files']), '</tt>'; |
2191 | + } |
|
2082 | 2192 | |
2083 | 2193 | // This is serious! |
2084 | - if (!template_warning_divs()) |
|
2085 | - return; |
|
2194 | + if (!template_warning_divs()) { |
|
2195 | + return; |
|
2196 | + } |
|
2086 | 2197 | |
2087 | 2198 | echo ' |
2088 | 2199 | <hr> |
2089 | 2200 | <p>', $txt['ftp_setup_info'], '</p>'; |
2090 | 2201 | |
2091 | - if (!empty($incontext['ftp_errors'])) |
|
2092 | - echo ' |
|
2202 | + if (!empty($incontext['ftp_errors'])) { |
|
2203 | + echo ' |
|
2093 | 2204 | <div class="error_message"> |
2094 | 2205 | ', $txt['error_ftp_no_connect'], '<br><br> |
2095 | 2206 | <code>', implode('<br>', $incontext['ftp_errors']), '</code> |
2096 | 2207 | </div> |
2097 | 2208 | <br>'; |
2209 | + } |
|
2098 | 2210 | |
2099 | 2211 | echo ' |
2100 | 2212 | <form action="', $incontext['form_url'], '" method="post"> |
@@ -2154,17 +2266,17 @@ discard block |
||
2154 | 2266 | <td> |
2155 | 2267 | <select name="db_type" id="db_type_input" onchange="toggleDBInput();">'; |
2156 | 2268 | |
2157 | - foreach ($incontext['supported_databases'] as $key => $db) |
|
2158 | - echo ' |
|
2269 | + foreach ($incontext['supported_databases'] as $key => $db) { |
|
2270 | + echo ' |
|
2159 | 2271 | <option value="', $key, '"', isset($_POST['db_type']) && $_POST['db_type'] == $key ? ' selected' : '', '>', $db['name'], '</option>'; |
2272 | + } |
|
2160 | 2273 | |
2161 | 2274 | echo ' |
2162 | 2275 | </select> |
2163 | 2276 | <div class="smalltext block">', $txt['db_settings_type_info'], '</div> |
2164 | 2277 | </td> |
2165 | 2278 | </tr>'; |
2166 | - } |
|
2167 | - else |
|
2279 | + } else |
|
2168 | 2280 | { |
2169 | 2281 | echo ' |
2170 | 2282 | <tr style="display: none;"> |
@@ -2357,9 +2469,10 @@ discard block |
||
2357 | 2469 | <div style="color: red;">', $txt['error_db_queries'], '</div> |
2358 | 2470 | <ul>'; |
2359 | 2471 | |
2360 | - foreach ($incontext['failures'] as $line => $fail) |
|
2361 | - echo ' |
|
2472 | + foreach ($incontext['failures'] as $line => $fail) { |
|
2473 | + echo ' |
|
2362 | 2474 | <li><strong>', $txt['error_db_queries_line'], $line + 1, ':</strong> ', nl2br(htmlspecialchars($fail)), '</li>'; |
2475 | + } |
|
2363 | 2476 | |
2364 | 2477 | echo ' |
2365 | 2478 | </ul>'; |
@@ -2420,15 +2533,16 @@ discard block |
||
2420 | 2533 | </tr> |
2421 | 2534 | </table>'; |
2422 | 2535 | |
2423 | - if ($incontext['require_db_confirm']) |
|
2424 | - echo ' |
|
2536 | + if ($incontext['require_db_confirm']) { |
|
2537 | + echo ' |
|
2425 | 2538 | <h2>', $txt['user_settings_database'], '</h2> |
2426 | 2539 | <p>', $txt['user_settings_database_info'], '</p> |
2427 | 2540 | |
2428 | 2541 | <div style="margin-bottom: 2ex; padding-', $txt['lang_rtl'] == false ? 'left' : 'right', ': 50px;"> |
2429 | 2542 | <input type="password" name="password3" size="30" /> |
2430 | 2543 | </div>'; |
2431 | -} |
|
2544 | + } |
|
2545 | + } |
|
2432 | 2546 | |
2433 | 2547 | // Tell them it's done, and to delete. |
2434 | 2548 | function template_delete_install() |
@@ -2441,14 +2555,15 @@ discard block |
||
2441 | 2555 | template_warning_divs(); |
2442 | 2556 | |
2443 | 2557 | // Install directory still writable? |
2444 | - if ($incontext['dir_still_writable']) |
|
2445 | - echo ' |
|
2558 | + if ($incontext['dir_still_writable']) { |
|
2559 | + echo ' |
|
2446 | 2560 | <em>', $txt['still_writable'], '</em><br> |
2447 | 2561 | <br>'; |
2562 | + } |
|
2448 | 2563 | |
2449 | 2564 | // Don't show the box if it's like 99% sure it won't work :P. |
2450 | - if ($incontext['probably_delete_install']) |
|
2451 | - echo ' |
|
2565 | + if ($incontext['probably_delete_install']) { |
|
2566 | + echo ' |
|
2452 | 2567 | <div style="margin: 1ex; font-weight: bold;"> |
2453 | 2568 | <label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete();" /> ', $txt['delete_installer'], !isset($_SESSION['installer_temp_ftp']) ? ' ' . $txt['delete_installer_maybe'] : '', '</label> |
2454 | 2569 | </div> |
@@ -2464,6 +2579,7 @@ discard block |
||
2464 | 2579 | } |
2465 | 2580 | </script> |
2466 | 2581 | <br>'; |
2582 | + } |
|
2467 | 2583 | |
2468 | 2584 | echo ' |
2469 | 2585 | ', sprintf($txt['go_to_your_forum'], $boardurl . '/index.php'), '<br> |
@@ -122,9 +122,10 @@ discard block |
||
122 | 122 | <h3 class="catbg">', $txt['attachment_transfer'], '</h3> |
123 | 123 | </div>'; |
124 | 124 | |
125 | - if (!empty($context['results'])) |
|
126 | - echo ' |
|
125 | + if (!empty($context['results'])) { |
|
126 | + echo ' |
|
127 | 127 | <div class="noticebox">', $context['results'], '</div>'; |
128 | + } |
|
128 | 129 | |
129 | 130 | echo ' |
130 | 131 | <div class="windowbg2 noup"> |
@@ -136,9 +137,10 @@ discard block |
||
136 | 137 | <select name="from"> |
137 | 138 | <option value="0">', $txt['attachment_transfer_select'], '</option>'; |
138 | 139 | |
139 | - foreach ($context['attach_dirs'] as $id => $dir) |
|
140 | - echo ' |
|
140 | + foreach ($context['attach_dirs'] as $id => $dir) { |
|
141 | + echo ' |
|
141 | 142 | <option value="', $id, '">', $dir, '</option>'; |
143 | + } |
|
142 | 144 | |
143 | 145 | echo ' |
144 | 146 | </select> |
@@ -149,13 +151,14 @@ discard block |
||
149 | 151 | <option value="0">', $txt['attachment_transfer_auto_select'], '</option> |
150 | 152 | <option value="-1">', $txt['attachment_transfer_forum_root'], '</option>'; |
151 | 153 | |
152 | - if (!empty($context['base_dirs'])) |
|
153 | - foreach ($context['base_dirs'] as $id => $dir) |
|
154 | + if (!empty($context['base_dirs'])) { |
|
155 | + foreach ($context['base_dirs'] as $id => $dir) |
|
154 | 156 | echo ' |
155 | 157 | <option value="', $id, '">', $dir, '</option>'; |
156 | - else |
|
157 | - echo ' |
|
158 | + } else { |
|
159 | + echo ' |
|
158 | 160 | <option value="0" disabled>', $txt['attachment_transfer_no_base'], '</option>'; |
161 | + } |
|
159 | 162 | |
160 | 163 | echo ' |
161 | 164 | </select> |
@@ -165,18 +168,20 @@ discard block |
||
165 | 168 | <select name="to"> |
166 | 169 | <option value="0">', $txt['attachment_transfer_select'], '</option>'; |
167 | 170 | |
168 | - foreach ($context['attach_dirs'] as $id => $dir) |
|
169 | - echo ' |
|
171 | + foreach ($context['attach_dirs'] as $id => $dir) { |
|
172 | + echo ' |
|
170 | 173 | <option value="', $id, '">', $dir, '</option>'; |
174 | + } |
|
171 | 175 | |
172 | 176 | echo ' |
173 | 177 | </select> |
174 | 178 | </dd>'; |
175 | 179 | |
176 | - if (!empty($modSettings['attachmentDirFileLimit'])) |
|
177 | - echo ' |
|
180 | + if (!empty($modSettings['attachmentDirFileLimit'])) { |
|
181 | + echo ' |
|
178 | 182 | <dt>', $txt['attachment_transfer_empty'], '</dt> |
179 | 183 | <dd><input type="checkbox" name="empty_it"', $context['checked'] ? ' checked' : '', '></dd>'; |
184 | + } |
|
180 | 185 | |
181 | 186 | echo ' |
182 | 187 | </dl> |
@@ -253,10 +258,11 @@ discard block |
||
253 | 258 | // Loop through each error reporting the status |
254 | 259 | foreach ($context['repair_errors'] as $error => $number) |
255 | 260 | { |
256 | - if (!empty($number)) |
|
257 | - echo ' |
|
261 | + if (!empty($number)) { |
|
262 | + echo ' |
|
258 | 263 | <input type="checkbox" name="to_fix[]" id="', $error, '" value="', $error, '"> |
259 | 264 | <label for="', $error, '">', sprintf($txt['attach_repair_' . $error], $number), '</label><br>'; |
265 | + } |
|
260 | 266 | } |
261 | 267 | |
262 | 268 | echo ' |
@@ -24,11 +24,12 @@ discard block |
||
24 | 24 | <h3 class="catbg">', $txt['paid_' . $context['action_type'] . '_subscription'], '</h3> |
25 | 25 | </div>'; |
26 | 26 | |
27 | - if (!empty($context['disable_groups'])) |
|
28 | - echo ' |
|
27 | + if (!empty($context['disable_groups'])) { |
|
28 | + echo ' |
|
29 | 29 | <div class="information"> |
30 | 30 | <span class="alert">', $txt['paid_mod_edit_note'], '</span> |
31 | 31 | </div>'; |
32 | + } |
|
32 | 33 | |
33 | 34 | echo ' |
34 | 35 | <div class="windowbg2"> |
@@ -69,9 +70,10 @@ discard block |
||
69 | 70 | <option value="0"', $context['sub']['prim_group'] == 0 ? ' selected' : '', '>', $txt['paid_mod_no_group'], '</option>'; |
70 | 71 | |
71 | 72 | // Put each group into the box. |
72 | - foreach ($context['groups'] as $id => $name) |
|
73 | - echo ' |
|
73 | + foreach ($context['groups'] as $id => $name) { |
|
74 | + echo ' |
|
74 | 75 | <option value="', $id, '"', $context['sub']['prim_group'] == $id ? ' selected' : '', '>', $name, '</option>'; |
76 | + } |
|
75 | 77 | |
76 | 78 | echo ' |
77 | 79 | </select> |
@@ -83,11 +85,12 @@ discard block |
||
83 | 85 | <dd>'; |
84 | 86 | |
85 | 87 | // Put a checkbox in for each group |
86 | - foreach ($context['groups'] as $id => $name) |
|
87 | - echo ' |
|
88 | + foreach ($context['groups'] as $id => $name) { |
|
89 | + echo ' |
|
88 | 90 | <label for="addgroup_', $id, '"> |
89 | 91 | <input type="checkbox" id="addgroup_', $id, '" name="addgroup[', $id, ']"', in_array($id, $context['sub']['add_groups']) ? ' checked' : '', !empty($context['disable_groups']) ? ' disabled' : '', '> <span class="smalltext">', $name, '</span> |
90 | 92 | </label><br>'; |
93 | + } |
|
91 | 94 | |
92 | 95 | echo ' |
93 | 96 | </dd> |
@@ -141,8 +144,8 @@ discard block |
||
141 | 144 | <fieldset>'; |
142 | 145 | |
143 | 146 | //!! Removed until implemented |
144 | - if (!empty($sdflsdhglsdjgs)) |
|
145 | - echo ' |
|
147 | + if (!empty($sdflsdhglsdjgs)) { |
|
148 | + echo ' |
|
146 | 149 | <dl class="settings"> |
147 | 150 | <dt> |
148 | 151 | <label for="allow_partial_check">', $txt['paid_mod_allow_partial'], '</label>:<br><span class="smalltext">', $txt['paid_mod_allow_partial_desc'], '</span> |
@@ -151,6 +154,7 @@ discard block |
||
151 | 154 | <input type="checkbox" name="allow_partial" id="allow_partial_check"', empty($context['sub']['allow_partial']) ? '' : ' checked', '> |
152 | 155 | </dd> |
153 | 156 | </dl>'; |
157 | + } |
|
154 | 158 | |
155 | 159 | echo ' |
156 | 160 | <div class="information"> |
@@ -251,8 +255,8 @@ discard block |
||
251 | 255 | <dl class="settings">'; |
252 | 256 | |
253 | 257 | // Do we need a username? |
254 | - if ($context['action_type'] == 'add') |
|
255 | - echo ' |
|
258 | + if ($context['action_type'] == 'add') { |
|
259 | + echo ' |
|
256 | 260 | <dt> |
257 | 261 | <strong>', $txt['paid_username'], ':</strong><br> |
258 | 262 | <span class="smalltext">', $txt['one_username'], '</span> |
@@ -260,6 +264,7 @@ discard block |
||
260 | 264 | <dd> |
261 | 265 | <input type="text" name="name" id="name_control" value="', $context['sub']['username'], '" size="30"> |
262 | 266 | </dd>'; |
267 | + } |
|
263 | 268 | |
264 | 269 | echo ' |
265 | 270 | <dt> |
@@ -277,9 +282,10 @@ discard block |
||
277 | 282 | <select name="year" id="year" onchange="generateDays();">'; |
278 | 283 | |
279 | 284 | // Show a list of all the years we allow... |
280 | - for ($year = 2005; $year <= 2030; $year++) |
|
281 | - echo ' |
|
285 | + for ($year = 2005; $year <= 2030; $year++) { |
|
286 | + echo ' |
|
282 | 287 | <option value="', $year, '"', $year == $context['sub']['start']['year'] ? ' selected' : '', '>', $year, '</option>'; |
288 | + } |
|
283 | 289 | |
284 | 290 | echo ' |
285 | 291 | </select> |
@@ -287,9 +293,10 @@ discard block |
||
287 | 293 | <select name="month" id="month" onchange="generateDays();">'; |
288 | 294 | |
289 | 295 | // There are 12 months per year - ensure that they all get listed. |
290 | - for ($month = 1; $month <= 12; $month++) |
|
291 | - echo ' |
|
296 | + for ($month = 1; $month <= 12; $month++) { |
|
297 | + echo ' |
|
292 | 298 | <option value="', $month, '"', $month == $context['sub']['start']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>'; |
299 | + } |
|
293 | 300 | |
294 | 301 | echo ' |
295 | 302 | </select> |
@@ -297,9 +304,10 @@ discard block |
||
297 | 304 | <select name="day" id="day">'; |
298 | 305 | |
299 | 306 | // This prints out all the days in the current month - this changes dynamically as we switch months. |
300 | - for ($day = 1; $day <= $context['sub']['start']['last_day']; $day++) |
|
301 | - echo ' |
|
307 | + for ($day = 1; $day <= $context['sub']['start']['last_day']; $day++) { |
|
308 | + echo ' |
|
302 | 309 | <option value="', $day, '"', $day == $context['sub']['start']['day'] ? ' selected' : '', '>', $day, '</option>'; |
310 | + } |
|
303 | 311 | |
304 | 312 | echo ' |
305 | 313 | </select> |
@@ -311,9 +319,10 @@ discard block |
||
311 | 319 | <select name="yearend" id="yearend" onchange="generateDays(\'end\');">'; |
312 | 320 | |
313 | 321 | // Show a list of all the years we allow... |
314 | - for ($year = 2005; $year <= 2030; $year++) |
|
315 | - echo ' |
|
322 | + for ($year = 2005; $year <= 2030; $year++) { |
|
323 | + echo ' |
|
316 | 324 | <option value="', $year, '"', $year == $context['sub']['end']['year'] ? ' selected' : '', '>', $year, '</option>'; |
325 | + } |
|
317 | 326 | |
318 | 327 | echo ' |
319 | 328 | </select> |
@@ -321,9 +330,10 @@ discard block |
||
321 | 330 | <select name="monthend" id="monthend" onchange="generateDays(\'end\');">'; |
322 | 331 | |
323 | 332 | // There are 12 months per year - ensure that they all get listed. |
324 | - for ($month = 1; $month <= 12; $month++) |
|
325 | - echo ' |
|
333 | + for ($month = 1; $month <= 12; $month++) { |
|
334 | + echo ' |
|
326 | 335 | <option value="', $month, '"', $month == $context['sub']['end']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>'; |
336 | + } |
|
327 | 337 | |
328 | 338 | echo ' |
329 | 339 | </select> |
@@ -331,9 +341,10 @@ discard block |
||
331 | 341 | <select name="dayend" id="dayend">'; |
332 | 342 | |
333 | 343 | // This prints out all the days in the current month - this changes dynamically as we switch months. |
334 | - for ($day = 1; $day <= $context['sub']['end']['last_day']; $day++) |
|
335 | - echo ' |
|
344 | + for ($day = 1; $day <= $context['sub']['end']['last_day']; $day++) { |
|
345 | + echo ' |
|
336 | 346 | <option value="', $day, '"', $day == $context['sub']['end']['day'] ? ' selected' : '', '>', $day, '</option>'; |
347 | + } |
|
337 | 348 | |
338 | 349 | echo ' |
339 | 350 | </select> |
@@ -415,8 +426,7 @@ discard block |
||
415 | 426 | <div class="information"> |
416 | 427 | ', $txt['paid_subs_none'], ' |
417 | 428 | </div>'; |
418 | - } |
|
419 | - else |
|
429 | + } else |
|
420 | 430 | { |
421 | 431 | echo ' |
422 | 432 | <div class="information"> |
@@ -428,8 +438,9 @@ discard block |
||
428 | 438 | { |
429 | 439 | |
430 | 440 | // Ignore the inactive ones... |
431 | - if (empty($subscription['active'])) |
|
432 | - continue; |
|
441 | + if (empty($subscription['active'])) { |
|
442 | + continue; |
|
443 | + } |
|
433 | 444 | |
434 | 445 | echo ' |
435 | 446 | <div class="cat_bar"> |
@@ -439,9 +450,10 @@ discard block |
||
439 | 450 | <p><strong>', $subscription['name'], '</strong></p> |
440 | 451 | <p class="smalltext">', $subscription['desc'], '</p>'; |
441 | 452 | |
442 | - if (!$subscription['flexible']) |
|
443 | - echo ' |
|
453 | + if (!$subscription['flexible']) { |
|
454 | + echo ' |
|
444 | 455 | <div><strong>', $txt['paid_duration'], ':</strong> ', $subscription['length'], '</div>'; |
456 | + } |
|
445 | 457 | |
446 | 458 | if ($context['user']['is_owner']) |
447 | 459 | { |
@@ -454,24 +466,25 @@ discard block |
||
454 | 466 | <select name="cur[', $subscription['id'], ']">'; |
455 | 467 | |
456 | 468 | // Print out the costs for this one. |
457 | - foreach ($subscription['costs'] as $duration => $value) |
|
458 | - echo ' |
|
469 | + foreach ($subscription['costs'] as $duration => $value) { |
|
470 | + echo ' |
|
459 | 471 | <option value="', $duration, '">', sprintf($modSettings['paid_currency_symbol'], $value), '/', $txt[$duration], '</option>'; |
472 | + } |
|
460 | 473 | |
461 | 474 | echo ' |
462 | 475 | </select>'; |
463 | - } |
|
464 | - else |
|
465 | - echo ' |
|
476 | + } else { |
|
477 | + echo ' |
|
466 | 478 | ', sprintf($modSettings['paid_currency_symbol'], $subscription['costs']['fixed']); |
479 | + } |
|
467 | 480 | |
468 | 481 | echo ' |
469 | 482 | <hr> |
470 | 483 | <input type="submit" name="sub_id[', $subscription['id'], ']" value="', $txt['paid_order'], '" class="button">'; |
471 | - } |
|
472 | - else |
|
473 | - echo ' |
|
484 | + } else { |
|
485 | + echo ' |
|
474 | 486 | <a href="', $scripturl, '?action=admin;area=paidsubscribe;sa=modifyuser;sid=', $subscription['id'], ';uid=', $context['member']['id'], (empty($context['current'][$subscription['id']]) ? '' : ';lid=' . $context['current'][$subscription['id']]['id']), '">', empty($context['current'][$subscription['id']]) ? $txt['paid_admin_add'] : $txt['paid_edit_subscription'], '</a>'; |
487 | + } |
|
475 | 488 | |
476 | 489 | echo ' |
477 | 490 | </div><!-- .windowbg -->'; |
@@ -498,19 +511,20 @@ discard block |
||
498 | 511 | </thead> |
499 | 512 | <tbody>'; |
500 | 513 | |
501 | - if (empty($context['current'])) |
|
502 | - echo ' |
|
514 | + if (empty($context['current'])) { |
|
515 | + echo ' |
|
503 | 516 | <tr class="windowbg"> |
504 | 517 | <td colspan="4"> |
505 | 518 | ', $txt['paid_none_yet'], ' |
506 | 519 | </td> |
507 | 520 | </tr>'; |
521 | + } |
|
508 | 522 | |
509 | 523 | foreach ($context['current'] as $sub) |
510 | 524 | { |
511 | 525 | |
512 | - if (!$sub['hide']) |
|
513 | - echo ' |
|
526 | + if (!$sub['hide']) { |
|
527 | + echo ' |
|
514 | 528 | <tr class="windowbg"> |
515 | 529 | <td> |
516 | 530 | ', (allowedTo('admin_forum') ? '<a href="' . $scripturl . '?action=admin;area=paidsubscribe;sa=modifyuser;lid=' . $sub['id'] . '">' . $sub['name'] . '</a>' : $sub['name']), ' |
@@ -521,6 +535,7 @@ discard block |
||
521 | 535 | <td>', $sub['start'], '</td> |
522 | 536 | <td>', $sub['end'], '</td> |
523 | 537 | </tr>'; |
538 | + } |
|
524 | 539 | } |
525 | 540 | echo ' |
526 | 541 | </tbody> |
@@ -571,15 +586,17 @@ discard block |
||
571 | 586 | ', $gateway['desc'], '<br> |
572 | 587 | <form action="', $gateway['form'], '" method="post">'; |
573 | 588 | |
574 | - if (!empty($gateway['javascript'])) |
|
575 | - echo ' |
|
589 | + if (!empty($gateway['javascript'])) { |
|
590 | + echo ' |
|
576 | 591 | <script> |
577 | 592 | ', $gateway['javascript'], ' |
578 | 593 | </script>'; |
594 | + } |
|
579 | 595 | |
580 | - foreach ($gateway['hidden'] as $name => $value) |
|
581 | - echo ' |
|
596 | + foreach ($gateway['hidden'] as $name => $value) { |
|
597 | + echo ' |
|
582 | 598 | <input type="hidden" id="', $gateway['id'], '_', $name, '" name="', $name, '" value="', $value, '">'; |
599 | + } |
|
583 | 600 | |
584 | 601 | echo ' |
585 | 602 | <br> |