@@ -18,23 +18,25 @@ discard block |
||
18 | 18 | global $context; |
19 | 19 | |
20 | 20 | // Prevent Chrome from auto completing fields when viewing/editing other members profiles |
21 | - if (isBrowser('is_chrome') && !$context['user']['is_owner']) |
|
22 | - echo ' |
|
21 | + if (isBrowser('is_chrome') && !$context['user']['is_owner']) { |
|
22 | + echo ' |
|
23 | 23 | <script> |
24 | 24 | disableAutoComplete(); |
25 | 25 | </script>'; |
26 | + } |
|
26 | 27 | |
27 | 28 | // If an error occurred while trying to save previously, give the user a clue! |
28 | 29 | echo ' |
29 | 30 | ', template_error_message(); |
30 | 31 | |
31 | 32 | // If the profile was update successfully, let the user know this. |
32 | - if (!empty($context['profile_updated'])) |
|
33 | - echo ' |
|
33 | + if (!empty($context['profile_updated'])) { |
|
34 | + echo ' |
|
34 | 35 | <div class="infobox"> |
35 | 36 | ', $context['profile_updated'], ' |
36 | 37 | </div>'; |
37 | -} |
|
38 | + } |
|
39 | + } |
|
38 | 40 | |
39 | 41 | /** |
40 | 42 | * Template for any HTML needed below the profile (closing off divs/tables, etc.) |
@@ -102,8 +104,7 @@ discard block |
||
102 | 104 | if (empty($context['unread_alerts'])) |
103 | 105 | { |
104 | 106 | template_alerts_all_read(); |
105 | - } |
|
106 | - else |
|
107 | + } else |
|
107 | 108 | { |
108 | 109 | foreach ($context['unread_alerts'] as $id_alert => $details) |
109 | 110 | { |
@@ -164,10 +165,11 @@ discard block |
||
164 | 165 | <div class="custom_fields_above_name"> |
165 | 166 | <ul >'; |
166 | 167 | |
167 | - foreach ($context['print_custom_fields']['above_member'] as $field) |
|
168 | - if (!empty($field['output_html'])) |
|
168 | + foreach ($context['print_custom_fields']['above_member'] as $field) { |
|
169 | + if (!empty($field['output_html'])) |
|
169 | 170 | echo ' |
170 | 171 | <li>', $field['output_html'], '</li>'; |
172 | + } |
|
171 | 173 | |
172 | 174 | echo ' |
173 | 175 | </ul> |
@@ -188,10 +190,11 @@ discard block |
||
188 | 190 | <div class="custom_fields_below_avatar"> |
189 | 191 | <ul >'; |
190 | 192 | |
191 | - foreach ($context['print_custom_fields']['below_avatar'] as $field) |
|
192 | - if (!empty($field['output_html'])) |
|
193 | + foreach ($context['print_custom_fields']['below_avatar'] as $field) { |
|
194 | + if (!empty($field['output_html'])) |
|
193 | 195 | echo ' |
194 | 196 | <li>', $field['output_html'], '</li>'; |
197 | + } |
|
195 | 198 | |
196 | 199 | echo ' |
197 | 200 | </ul> |
@@ -202,22 +205,25 @@ discard block |
||
202 | 205 | echo ' |
203 | 206 | <ul class="clear">'; |
204 | 207 | // Email is only visible if it's your profile or you have the moderate_forum permission |
205 | - if ($context['member']['show_email']) |
|
206 | - echo ' |
|
208 | + if ($context['member']['show_email']) { |
|
209 | + echo ' |
|
207 | 210 | <li><a href="mailto:', $context['member']['email'], '" title="', $context['member']['email'], '" rel="nofollow"><span class="generic_icons mail" title="' . $txt['email'] . '"></span></a></li>'; |
211 | + } |
|
208 | 212 | |
209 | 213 | // Don't show an icon if they haven't specified a website. |
210 | - if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) |
|
211 | - echo ' |
|
214 | + if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) { |
|
215 | + echo ' |
|
212 | 216 | <li><a href="', $context['member']['website']['url'], '" title="' . $context['member']['website']['title'] . '" target="_blank">', ($settings['use_image_buttons'] ? '<span class="generic_icons www" title="' . $context['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
217 | + } |
|
213 | 218 | |
214 | 219 | // Are there any custom profile fields as icons? |
215 | 220 | if (!empty($context['print_custom_fields']['icons'])) |
216 | 221 | { |
217 | - foreach ($context['print_custom_fields']['icons'] as $field) |
|
218 | - if (!empty($field['output_html'])) |
|
222 | + foreach ($context['print_custom_fields']['icons'] as $field) { |
|
223 | + if (!empty($field['output_html'])) |
|
219 | 224 | echo ' |
220 | 225 | <li class="custom_field">', $field['output_html'], '</li>'; |
226 | + } |
|
221 | 227 | } |
222 | 228 | |
223 | 229 | echo ' |
@@ -225,23 +231,26 @@ discard block |
||
225 | 231 | <span id="userstatus">', $context['can_send_pm'] ? '<a href="' . $context['member']['online']['href'] . '" title="' . $context['member']['online']['text'] . '" rel="nofollow">' : '', $settings['use_image_buttons'] ? '<span class="' . ($context['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $context['member']['online']['text'] . '"></span>' : $context['member']['online']['label'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['member']['online']['label'] . '</span>' : ''; |
226 | 232 | |
227 | 233 | // Can they add this member as a buddy? |
228 | - if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) |
|
229 | - echo ' |
|
234 | + if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) { |
|
235 | + echo ' |
|
230 | 236 | <br><a href="', $scripturl, '?action=buddy;u=', $context['id_member'], ';', $context['session_var'], '=', $context['session_id'], '">[', $txt['buddy_' . ($context['member']['is_buddy'] ? 'remove' : 'add')], ']</a>'; |
237 | + } |
|
231 | 238 | |
232 | 239 | echo ' |
233 | 240 | </span>'; |
234 | 241 | |
235 | - if (!$context['user']['is_owner'] && $context['can_send_pm']) |
|
236 | - echo ' |
|
242 | + if (!$context['user']['is_owner'] && $context['can_send_pm']) { |
|
243 | + echo ' |
|
237 | 244 | <a href="', $scripturl, '?action=pm;sa=send;u=', $context['id_member'], '" class="infolinks">', $txt['profile_sendpm_short'], '</a>'; |
245 | + } |
|
238 | 246 | |
239 | 247 | echo ' |
240 | 248 | <a href="', $scripturl, '?action=profile;area=showposts;u=', $context['id_member'], '" class="infolinks">', $txt['showPosts'], '</a>'; |
241 | 249 | |
242 | - if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) |
|
243 | - echo ' |
|
250 | + if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) { |
|
251 | + echo ' |
|
244 | 252 | <a href="', $scripturl, '?action=profile;area=showdrafts;u=', $context['id_member'], '" class="infolinks">', $txt['drafts_show'], '</a>'; |
253 | + } |
|
245 | 254 | |
246 | 255 | echo ' |
247 | 256 | <a href="', $scripturl, '?action=profile;area=statistics;u=', $context['id_member'], '" class="infolinks">', $txt['statPanel'], '</a>'; |
@@ -253,10 +262,11 @@ discard block |
||
253 | 262 | <div class="custom_fields_bottom"> |
254 | 263 | <ul class="nolist">'; |
255 | 264 | |
256 | - foreach ($context['print_custom_fields']['bottom_poster'] as $field) |
|
257 | - if (!empty($field['output_html'])) |
|
265 | + foreach ($context['print_custom_fields']['bottom_poster'] as $field) { |
|
266 | + if (!empty($field['output_html'])) |
|
258 | 267 | echo ' |
259 | 268 | <li>', $field['output_html'], '</li>'; |
269 | + } |
|
260 | 270 | |
261 | 271 | echo ' |
262 | 272 | </ul> |
@@ -270,15 +280,17 @@ discard block |
||
270 | 280 | <div id="detailedinfo"> |
271 | 281 | <dl class="settings">'; |
272 | 282 | |
273 | - if ($context['user']['is_owner'] || $context['user']['is_admin']) |
|
274 | - echo ' |
|
283 | + if ($context['user']['is_owner'] || $context['user']['is_admin']) { |
|
284 | + echo ' |
|
275 | 285 | <dt>', $txt['username'], ': </dt> |
276 | 286 | <dd>', $context['member']['username'], '</dd>'; |
287 | + } |
|
277 | 288 | |
278 | - if (!isset($context['disabled_fields']['posts'])) |
|
279 | - echo ' |
|
289 | + if (!isset($context['disabled_fields']['posts'])) { |
|
290 | + echo ' |
|
280 | 291 | <dt>', $txt['profile_posts'], ': </dt> |
281 | 292 | <dd>', $context['member']['posts'], ' (', $context['member']['posts_per_day'], ' ', $txt['posts_per_day'], ')</dd>'; |
293 | + } |
|
282 | 294 | |
283 | 295 | if ($context['member']['show_email']) |
284 | 296 | { |
@@ -287,15 +299,17 @@ discard block |
||
287 | 299 | <dd><a href="mailto:', $context['member']['email'], '">', $context['member']['email'], '</a></dd>'; |
288 | 300 | } |
289 | 301 | |
290 | - if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) |
|
291 | - echo ' |
|
302 | + if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) { |
|
303 | + echo ' |
|
292 | 304 | <dt>', $txt['custom_title'], ': </dt> |
293 | 305 | <dd>', $context['member']['title'], '</dd>'; |
306 | + } |
|
294 | 307 | |
295 | - if (!empty($context['member']['blurb'])) |
|
296 | - echo ' |
|
308 | + if (!empty($context['member']['blurb'])) { |
|
309 | + echo ' |
|
297 | 310 | <dt>', $txt['personal_text'], ': </dt> |
298 | 311 | <dd>', $context['member']['blurb'], '</dd>'; |
312 | + } |
|
299 | 313 | |
300 | 314 | echo ' |
301 | 315 | <dt>', $txt['age'], ':</dt> |
@@ -310,11 +324,12 @@ discard block |
||
310 | 324 | echo ' |
311 | 325 | <dl class="settings">'; |
312 | 326 | |
313 | - foreach ($context['print_custom_fields']['standard'] as $field) |
|
314 | - if (!empty($field['output_html'])) |
|
327 | + foreach ($context['print_custom_fields']['standard'] as $field) { |
|
328 | + if (!empty($field['output_html'])) |
|
315 | 329 | echo ' |
316 | 330 | <dt>', $field['name'], ':</dt> |
317 | 331 | <dd>', $field['output_html'], '</dd>'; |
332 | + } |
|
318 | 333 | |
319 | 334 | echo ' |
320 | 335 | </dl>'; |
@@ -332,9 +347,10 @@ discard block |
||
332 | 347 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=', ($context['can_issue_warning'] && !$context['user']['is_owner'] ? 'issuewarning' : 'viewwarning'), '">', $context['member']['warning'], '%</a>'; |
333 | 348 | |
334 | 349 | // Can we provide information on what this means? |
335 | - if (!empty($context['warning_status'])) |
|
336 | - echo ' |
|
350 | + if (!empty($context['warning_status'])) { |
|
351 | + echo ' |
|
337 | 352 | <span class="smalltext">(', $context['warning_status'], ')</span>'; |
353 | + } |
|
338 | 354 | |
339 | 355 | echo ' |
340 | 356 | </dd>'; |
@@ -345,9 +361,10 @@ discard block |
||
345 | 361 | { |
346 | 362 | |
347 | 363 | // If the person looking at the summary has permission, and the account isn't activated, give the viewer the ability to do it themselves. |
348 | - if (!empty($context['activate_message'])) |
|
349 | - echo ' |
|
364 | + if (!empty($context['activate_message'])) { |
|
365 | + echo ' |
|
350 | 366 | <dt class="clear"><span class="alert">', $context['activate_message'], '</span> (<a href="', $context['activate_link'], '"', ($context['activate_type'] == 4 ? ' class="you_sure" data-confirm="' . $txt['profileConfirm'] . '"' : ''), '>', $context['activate_link_text'], '</a>)</dt>'; |
367 | + } |
|
351 | 368 | |
352 | 369 | // If the current member is banned, show a message and possibly a link to the ban. |
353 | 370 | if (!empty($context['member']['bans'])) |
@@ -357,9 +374,10 @@ discard block |
||
357 | 374 | <dt class="clear" id="ban_info" style="display: none;"> |
358 | 375 | <strong>', $txt['user_banned_by_following'], ':</strong>'; |
359 | 376 | |
360 | - foreach ($context['member']['bans'] as $ban) |
|
361 | - echo ' |
|
377 | + foreach ($context['member']['bans'] as $ban) { |
|
378 | + echo ' |
|
362 | 379 | <br><span class="smalltext">', $ban['explanation'], '</span>'; |
380 | + } |
|
363 | 381 | |
364 | 382 | echo ' |
365 | 383 | </dt>'; |
@@ -373,30 +391,34 @@ discard block |
||
373 | 391 | // If the person looking is allowed, they can check the members IP address and hostname. |
374 | 392 | if ($context['can_see_ip']) |
375 | 393 | { |
376 | - if (!empty($context['member']['ip'])) |
|
377 | - echo ' |
|
394 | + if (!empty($context['member']['ip'])) { |
|
395 | + echo ' |
|
378 | 396 | <dt>', $txt['ip'], ': </dt> |
379 | 397 | <dd><a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['member']['ip'], ';u=', $context['member']['id'], '">', $context['member']['ip'], '</a></dd>'; |
398 | + } |
|
380 | 399 | |
381 | - if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) |
|
382 | - echo ' |
|
400 | + if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) { |
|
401 | + echo ' |
|
383 | 402 | <dt>', $txt['hostname'], ': </dt> |
384 | 403 | <dd>', $context['member']['hostname'], '</dd>'; |
404 | + } |
|
385 | 405 | } |
386 | 406 | |
387 | 407 | echo ' |
388 | 408 | <dt>', $txt['local_time'], ':</dt> |
389 | 409 | <dd>', $context['member']['local_time'], '</dd>'; |
390 | 410 | |
391 | - if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) |
|
392 | - echo ' |
|
411 | + if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) { |
|
412 | + echo ' |
|
393 | 413 | <dt>', $txt['language'], ':</dt> |
394 | 414 | <dd>', $context['member']['language'], '</dd>'; |
415 | + } |
|
395 | 416 | |
396 | - if ($context['member']['show_last_login']) |
|
397 | - echo ' |
|
417 | + if ($context['member']['show_last_login']) { |
|
418 | + echo ' |
|
398 | 419 | <dt>', $txt['lastLoggedIn'], ': </dt> |
399 | 420 | <dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>'; |
421 | + } |
|
400 | 422 | |
401 | 423 | echo ' |
402 | 424 | </dl>'; |
@@ -408,10 +430,11 @@ discard block |
||
408 | 430 | <div class="custom_fields_above_signature"> |
409 | 431 | <ul class="nolist">'; |
410 | 432 | |
411 | - foreach ($context['print_custom_fields']['above_signature'] as $field) |
|
412 | - if (!empty($field['output_html'])) |
|
433 | + foreach ($context['print_custom_fields']['above_signature'] as $field) { |
|
434 | + if (!empty($field['output_html'])) |
|
413 | 435 | echo ' |
414 | 436 | <li>', $field['output_html'], '</li>'; |
437 | + } |
|
415 | 438 | |
416 | 439 | echo ' |
417 | 440 | </ul> |
@@ -419,12 +442,13 @@ discard block |
||
419 | 442 | } |
420 | 443 | |
421 | 444 | // Show the users signature. |
422 | - if ($context['signature_enabled'] && !empty($context['member']['signature'])) |
|
423 | - echo ' |
|
445 | + if ($context['signature_enabled'] && !empty($context['member']['signature'])) { |
|
446 | + echo ' |
|
424 | 447 | <div class="signature"> |
425 | 448 | <h5>', $txt['signature'], ':</h5> |
426 | 449 | ', $context['member']['signature'], ' |
427 | 450 | </div>'; |
451 | + } |
|
428 | 452 | |
429 | 453 | // Are there any custom profile fields for below the signature? |
430 | 454 | if (!empty($context['print_custom_fields']['below_signature'])) |
@@ -433,10 +457,11 @@ discard block |
||
433 | 457 | <div class="custom_fields_below_signature"> |
434 | 458 | <ul class="nolist">'; |
435 | 459 | |
436 | - foreach ($context['print_custom_fields']['below_signature'] as $field) |
|
437 | - if (!empty($field['output_html'])) |
|
460 | + foreach ($context['print_custom_fields']['below_signature'] as $field) { |
|
461 | + if (!empty($field['output_html'])) |
|
438 | 462 | echo ' |
439 | 463 | <li>', $field['output_html'], '</li>'; |
464 | + } |
|
440 | 465 | |
441 | 466 | echo ' |
442 | 467 | </ul> |
@@ -481,62 +506,70 @@ discard block |
||
481 | 506 | </div> |
482 | 507 | <div class="list_posts">'; |
483 | 508 | |
484 | - if (!$post['approved']) |
|
485 | - echo ' |
|
509 | + if (!$post['approved']) { |
|
510 | + echo ' |
|
486 | 511 | <div class="approve_post"> |
487 | 512 | <em>', $txt['post_awaiting_approval'], '</em> |
488 | 513 | </div>'; |
514 | + } |
|
489 | 515 | |
490 | 516 | echo ' |
491 | 517 | ', $post['body'], ' |
492 | 518 | </div>'; |
493 | 519 | |
494 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
495 | - echo ' |
|
520 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
521 | + echo ' |
|
496 | 522 | <div class="floatright"> |
497 | 523 | <ul class="quickbuttons">'; |
524 | + } |
|
498 | 525 | |
499 | 526 | // If they *can* reply? |
500 | - if ($post['can_reply']) |
|
501 | - echo ' |
|
527 | + if ($post['can_reply']) { |
|
528 | + echo ' |
|
502 | 529 | <li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>'; |
530 | + } |
|
503 | 531 | |
504 | 532 | // If they *can* quote? |
505 | - if ($post['can_quote']) |
|
506 | - echo ' |
|
533 | + if ($post['can_quote']) { |
|
534 | + echo ' |
|
507 | 535 | <li><a href="', $scripturl . '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>'; |
536 | + } |
|
508 | 537 | |
509 | 538 | // How about... even... remove it entirely?! |
510 | - if ($post['can_delete']) |
|
511 | - echo ' |
|
539 | + if ($post['can_delete']) { |
|
540 | + echo ' |
|
512 | 541 | <li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';profile;u=', $context['member']['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
542 | + } |
|
513 | 543 | |
514 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
515 | - echo ' |
|
544 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
545 | + echo ' |
|
516 | 546 | </ul> |
517 | 547 | </div>'; |
548 | + } |
|
518 | 549 | |
519 | 550 | echo ' |
520 | 551 | </div>'; |
521 | 552 | } |
553 | + } else { |
|
554 | + template_show_list('attachments'); |
|
522 | 555 | } |
523 | - else |
|
524 | - template_show_list('attachments'); |
|
525 | 556 | |
526 | 557 | // No posts? Just end with a informative message. |
527 | - if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) |
|
528 | - echo ' |
|
558 | + if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) { |
|
559 | + echo ' |
|
529 | 560 | <div class="windowbg2"> |
530 | 561 | ', isset($context['attachments']) ? $txt['show_attachments_none'] : ($context['is_topics'] ? $txt['show_topics_none'] : $txt['show_posts_none']), ' |
531 | 562 | </div>'; |
563 | + } |
|
532 | 564 | |
533 | 565 | // Show more page numbers. |
534 | - if (!empty($context['page_index'])) |
|
535 | - echo ' |
|
566 | + if (!empty($context['page_index'])) { |
|
567 | + echo ' |
|
536 | 568 | <div class="pagesection"> |
537 | 569 | <div class="pagelinks">', $context['page_index'], '</div> |
538 | 570 | </div>'; |
539 | -} |
|
571 | + } |
|
572 | + } |
|
540 | 573 | |
541 | 574 | /** |
542 | 575 | * Template for showing alerts within the alerts popup |
@@ -546,11 +579,12 @@ discard block |
||
546 | 579 | global $context, $txt, $scripturl; |
547 | 580 | |
548 | 581 | // Do we have an update message? |
549 | - if (!empty($context['update_message'])) |
|
550 | - echo ' |
|
582 | + if (!empty($context['update_message'])) { |
|
583 | + echo ' |
|
551 | 584 | <div class="infobox"> |
552 | 585 | ', $context['update_message'], '. |
553 | 586 | </div>'; |
587 | + } |
|
554 | 588 | |
555 | 589 | echo ' |
556 | 590 | <div class="cat_bar"> |
@@ -559,13 +593,12 @@ discard block |
||
559 | 593 | </h3> |
560 | 594 | </div>'; |
561 | 595 | |
562 | - if (empty($context['alerts'])) |
|
563 | - echo ' |
|
596 | + if (empty($context['alerts'])) { |
|
597 | + echo ' |
|
564 | 598 | <div class="information"> |
565 | 599 | ', $txt['alerts_none'], ' |
566 | 600 | </div>'; |
567 | - |
|
568 | - else |
|
601 | + } else |
|
569 | 602 | { |
570 | 603 | // Start the form. |
571 | 604 | echo ' |
@@ -627,12 +660,12 @@ discard block |
||
627 | 660 | </div>' : ''; |
628 | 661 | |
629 | 662 | // No drafts? Just show an informative message. |
630 | - if (empty($context['drafts'])) |
|
631 | - echo ' |
|
663 | + if (empty($context['drafts'])) { |
|
664 | + echo ' |
|
632 | 665 | <div class="windowbg2 centertext"> |
633 | 666 | ', $txt['draft_none'], ' |
634 | 667 | </div>'; |
635 | - else |
|
668 | + } else |
|
636 | 669 | { |
637 | 670 | // For every draft to be displayed, give it its own div, and show the important details of the draft. |
638 | 671 | foreach ($context['drafts'] as $draft) |
@@ -643,11 +676,13 @@ discard block |
||
643 | 676 | <div class="topic_details"> |
644 | 677 | <h5><strong><a href="', $scripturl, '?board=', $draft['board']['id'], '.0">', $draft['board']['name'], '</a> / ', $draft['topic']['link'], '</strong> '; |
645 | 678 | |
646 | - if (!empty($draft['sticky'])) |
|
647 | - echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>'; |
|
679 | + if (!empty($draft['sticky'])) { |
|
680 | + echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>'; |
|
681 | + } |
|
648 | 682 | |
649 | - if (!empty($draft['locked'])) |
|
650 | - echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>'; |
|
683 | + if (!empty($draft['locked'])) { |
|
684 | + echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>'; |
|
685 | + } |
|
651 | 686 | |
652 | 687 | echo ' |
653 | 688 | </h5> |
@@ -680,12 +715,13 @@ discard block |
||
680 | 715 | { |
681 | 716 | global $context, $scripturl, $txt; |
682 | 717 | |
683 | - if (!empty($context['saved_successful'])) |
|
684 | - echo ' |
|
718 | + if (!empty($context['saved_successful'])) { |
|
719 | + echo ' |
|
685 | 720 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
686 | - elseif (!empty($context['saved_failed'])) |
|
687 | - echo ' |
|
721 | + } elseif (!empty($context['saved_failed'])) { |
|
722 | + echo ' |
|
688 | 723 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
724 | + } |
|
689 | 725 | |
690 | 726 | echo ' |
691 | 727 | <div id="edit_buddies"> |
@@ -699,24 +735,27 @@ discard block |
||
699 | 735 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
700 | 736 | <th scope="col">', $txt['status'], '</th>'; |
701 | 737 | |
702 | - if (allowedTo('moderate_forum')) |
|
703 | - echo ' |
|
738 | + if (allowedTo('moderate_forum')) { |
|
739 | + echo ' |
|
704 | 740 | <th scope="col">', $txt['email'], '</th>'; |
741 | + } |
|
705 | 742 | |
706 | - if (!empty($context['custom_pf'])) |
|
707 | - foreach ($context['custom_pf'] as $column) |
|
743 | + if (!empty($context['custom_pf'])) { |
|
744 | + foreach ($context['custom_pf'] as $column) |
|
708 | 745 | echo '<th scope="col">', $column['label'], '</th>'; |
746 | + } |
|
709 | 747 | |
710 | 748 | echo ' |
711 | 749 | <th scope="col">', $txt['remove'], '</th> |
712 | 750 | </tr>'; |
713 | 751 | |
714 | 752 | // If they don't have any buddies don't list them! |
715 | - if (empty($context['buddies'])) |
|
716 | - echo ' |
|
753 | + if (empty($context['buddies'])) { |
|
754 | + echo ' |
|
717 | 755 | <tr class="windowbg"> |
718 | 756 | <td colspan="', allowedTo('moderate_forum') ? '10' : '9', '"><strong>', $txt['no_buddies'], '</strong></td> |
719 | 757 | </tr>'; |
758 | + } |
|
720 | 759 | |
721 | 760 | // Now loop through each buddy showing info on each. |
722 | 761 | else |
@@ -728,15 +767,17 @@ discard block |
||
728 | 767 | <td>', $buddy['link'], '</td> |
729 | 768 | <td><a href="', $buddy['online']['href'], '"><span class="' . ($buddy['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $buddy['online']['text'] . '"></span></a></td>'; |
730 | 769 | |
731 | - if ($buddy['show_email']) |
|
732 | - echo ' |
|
770 | + if ($buddy['show_email']) { |
|
771 | + echo ' |
|
733 | 772 | <td><a href="mailto:' . $buddy['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $buddy['name'] . '"></span></a></td>'; |
773 | + } |
|
734 | 774 | |
735 | 775 | // Show the custom profile fields for this user. |
736 | - if (!empty($context['custom_pf'])) |
|
737 | - foreach ($context['custom_pf'] as $key => $column) |
|
776 | + if (!empty($context['custom_pf'])) { |
|
777 | + foreach ($context['custom_pf'] as $key => $column) |
|
738 | 778 | echo ' |
739 | 779 | <td class="lefttext">', $buddy['options'][$key], '</td>'; |
780 | + } |
|
740 | 781 | |
741 | 782 | echo ' |
742 | 783 | <td><a href="', $scripturl, '?action=profile;area=lists;sa=buddies;u=', $context['id_member'], ';remove=', $buddy['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['buddy_remove'], '"></span></a></td> |
@@ -766,9 +807,10 @@ discard block |
||
766 | 807 | </dl> |
767 | 808 | </div>'; |
768 | 809 | |
769 | - if (!empty($context['token_check'])) |
|
770 | - echo ' |
|
810 | + if (!empty($context['token_check'])) { |
|
811 | + echo ' |
|
771 | 812 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
813 | + } |
|
772 | 814 | |
773 | 815 | echo ' |
774 | 816 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -794,12 +836,13 @@ discard block |
||
794 | 836 | { |
795 | 837 | global $context, $scripturl, $txt; |
796 | 838 | |
797 | - if (!empty($context['saved_successful'])) |
|
798 | - echo ' |
|
839 | + if (!empty($context['saved_successful'])) { |
|
840 | + echo ' |
|
799 | 841 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
800 | - elseif (!empty($context['saved_failed'])) |
|
801 | - echo ' |
|
842 | + } elseif (!empty($context['saved_failed'])) { |
|
843 | + echo ' |
|
802 | 844 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
845 | + } |
|
803 | 846 | |
804 | 847 | echo ' |
805 | 848 | <div id="edit_buddies"> |
@@ -813,20 +856,22 @@ discard block |
||
813 | 856 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
814 | 857 | <th scope="col">', $txt['status'], '</th>'; |
815 | 858 | |
816 | - if (allowedTo('moderate_forum')) |
|
817 | - echo ' |
|
859 | + if (allowedTo('moderate_forum')) { |
|
860 | + echo ' |
|
818 | 861 | <th scope="col">', $txt['email'], '</th>'; |
862 | + } |
|
819 | 863 | |
820 | 864 | echo ' |
821 | 865 | <th scope="col">', $txt['ignore_remove'], '</th> |
822 | 866 | </tr>'; |
823 | 867 | |
824 | 868 | // If they don't have anyone on their ignore list, don't list it! |
825 | - if (empty($context['ignore_list'])) |
|
826 | - echo ' |
|
869 | + if (empty($context['ignore_list'])) { |
|
870 | + echo ' |
|
827 | 871 | <tr class="windowbg"> |
828 | 872 | <td colspan="', allowedTo('moderate_forum') ? '4' : '3', '"><strong>', $txt['no_ignore'], '</strong></td> |
829 | 873 | </tr>'; |
874 | + } |
|
830 | 875 | |
831 | 876 | // Now loop through each buddy showing info on each. |
832 | 877 | foreach ($context['ignore_list'] as $member) |
@@ -836,9 +881,10 @@ discard block |
||
836 | 881 | <td>', $member['link'], '</td> |
837 | 882 | <td><a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a></td>'; |
838 | 883 | |
839 | - if ($member['show_email']) |
|
840 | - echo ' |
|
884 | + if ($member['show_email']) { |
|
885 | + echo ' |
|
841 | 886 | <td><a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a></td>'; |
887 | + } |
|
842 | 888 | echo ' |
843 | 889 | <td><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=lists;sa=ignore;remove=', $member['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['ignore_remove'], '"></span></a></td> |
844 | 890 | </tr>'; |
@@ -865,9 +911,10 @@ discard block |
||
865 | 911 | </dl> |
866 | 912 | </div>'; |
867 | 913 | |
868 | - if (!empty($context['token_check'])) |
|
869 | - echo ' |
|
914 | + if (!empty($context['token_check'])) { |
|
915 | + echo ' |
|
870 | 916 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
917 | + } |
|
871 | 918 | |
872 | 919 | echo ' |
873 | 920 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -912,9 +959,10 @@ discard block |
||
912 | 959 | <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip'], ';u=', $context['member']['id'], '">', $context['last_ip'], '</a>'; |
913 | 960 | |
914 | 961 | // Second address detected? |
915 | - if (!empty($context['last_ip2'])) |
|
916 | - echo ' |
|
962 | + if (!empty($context['last_ip2'])) { |
|
963 | + echo ' |
|
917 | 964 | , <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip2'], ';u=', $context['member']['id'], '">', $context['last_ip2'], '</a>'; |
965 | + } |
|
918 | 966 | |
919 | 967 | echo ' |
920 | 968 | </dd>'; |
@@ -979,9 +1027,10 @@ discard block |
||
979 | 1027 | <h3 class="catbg">', $txt['whois_title'], ' ', $context['ip'], '</h3> |
980 | 1028 | </div> |
981 | 1029 | <div class="windowbg2 noup">'; |
982 | - foreach ($context['whois_servers'] as $server) |
|
983 | - echo ' |
|
1030 | + foreach ($context['whois_servers'] as $server) { |
|
1031 | + echo ' |
|
984 | 1032 | <a href="', $server['url'], '" target="_blank"', isset($context['auto_whois_server']) && $context['auto_whois_server']['name'] == $server['name'] ? ' style="font-weight: bold;"' : '', '>', $server['name'], '</a><br>'; |
1033 | + } |
|
985 | 1034 | echo ' |
986 | 1035 | </div> |
987 | 1036 | <br>'; |
@@ -992,10 +1041,10 @@ discard block |
||
992 | 1041 | <div class="cat_bar"> |
993 | 1042 | <h3 class="catbg">', $txt['members_from_ip'], ' ', $context['ip'], '</h3> |
994 | 1043 | </div>'; |
995 | - if (empty($context['ips'])) |
|
996 | - echo ' |
|
1044 | + if (empty($context['ips'])) { |
|
1045 | + echo ' |
|
997 | 1046 | <p class="windowbg2 description"><em>', $txt['no_members_from_ip'], '</em></p>'; |
998 | - else |
|
1047 | + } else |
|
999 | 1048 | { |
1000 | 1049 | echo ' |
1001 | 1050 | <table class="table_grid"> |
@@ -1008,12 +1057,13 @@ discard block |
||
1008 | 1057 | <tbody>'; |
1009 | 1058 | |
1010 | 1059 | // Loop through each of the members and display them. |
1011 | - foreach ($context['ips'] as $ip => $memberlist) |
|
1012 | - echo ' |
|
1060 | + foreach ($context['ips'] as $ip => $memberlist) { |
|
1061 | + echo ' |
|
1013 | 1062 | <tr class="windowbg"> |
1014 | 1063 | <td><a href="', $context['base_url'], ';searchip=', $ip, '">', $ip, '</a></td> |
1015 | 1064 | <td>', implode(', ', $memberlist), '</td> |
1016 | 1065 | </tr>'; |
1066 | + } |
|
1017 | 1067 | |
1018 | 1068 | echo ' |
1019 | 1069 | </tbody> |
@@ -1059,8 +1109,7 @@ discard block |
||
1059 | 1109 | { |
1060 | 1110 | echo ' |
1061 | 1111 | <div class="information">', $txt['showPermissions_all'], '</div>'; |
1062 | - } |
|
1063 | - else |
|
1112 | + } else |
|
1064 | 1113 | { |
1065 | 1114 | echo ' |
1066 | 1115 | <div class="information">',$txt['showPermissions_help'], '</div> |
@@ -1074,9 +1123,10 @@ discard block |
||
1074 | 1123 | </div> |
1075 | 1124 | <div class="windowbg smalltext"> |
1076 | 1125 | ', $txt['showPermissions_restricted_boards_desc'], ':<br>'; |
1077 | - foreach ($context['no_access_boards'] as $no_access_board) |
|
1078 | - echo ' |
|
1126 | + foreach ($context['no_access_boards'] as $no_access_board) { |
|
1127 | + echo ' |
|
1079 | 1128 | <a href="', $scripturl, '?board=', $no_access_board['id'], '.0">', $no_access_board['name'], '</a>', $no_access_board['is_last'] ? '' : ', '; |
1129 | + } |
|
1080 | 1130 | echo ' |
1081 | 1131 | </div>'; |
1082 | 1132 | } |
@@ -1108,12 +1158,13 @@ discard block |
||
1108 | 1158 | </td> |
1109 | 1159 | <td class="smalltext">'; |
1110 | 1160 | |
1111 | - if ($permission['is_denied']) |
|
1112 | - echo ' |
|
1161 | + if ($permission['is_denied']) { |
|
1162 | + echo ' |
|
1113 | 1163 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1114 | - else |
|
1115 | - echo ' |
|
1164 | + } else { |
|
1165 | + echo ' |
|
1116 | 1166 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
1167 | + } |
|
1117 | 1168 | |
1118 | 1169 | echo ' |
1119 | 1170 | </td> |
@@ -1123,10 +1174,10 @@ discard block |
||
1123 | 1174 | </tbody> |
1124 | 1175 | </table> |
1125 | 1176 | </div><br>'; |
1126 | - } |
|
1127 | - else |
|
1128 | - echo ' |
|
1177 | + } else { |
|
1178 | + echo ' |
|
1129 | 1179 | <p class="windowbg2">', $txt['showPermissions_none_general'], '</p>'; |
1180 | + } |
|
1130 | 1181 | |
1131 | 1182 | // Board permission section. |
1132 | 1183 | echo ' |
@@ -1136,14 +1187,16 @@ discard block |
||
1136 | 1187 | <a id="board_permissions"></a>', $txt['showPermissions_select'], ': |
1137 | 1188 | <select name="board" onchange="if (this.options[this.selectedIndex].value) this.form.submit();"> |
1138 | 1189 | <option value="0"', $context['board'] == 0 ? ' selected' : '', '>', $txt['showPermissions_global'], ' </option>'; |
1139 | - if (!empty($context['boards'])) |
|
1140 | - echo ' |
|
1190 | + if (!empty($context['boards'])) { |
|
1191 | + echo ' |
|
1141 | 1192 | <option value="" disabled>---------------------------</option>'; |
1193 | + } |
|
1142 | 1194 | |
1143 | 1195 | // Fill the box with any local permission boards. |
1144 | - foreach ($context['boards'] as $board) |
|
1145 | - echo ' |
|
1196 | + foreach ($context['boards'] as $board) { |
|
1197 | + echo ' |
|
1146 | 1198 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['name'], ' (', $board['profile_name'], ')</option>'; |
1199 | + } |
|
1147 | 1200 | |
1148 | 1201 | echo ' |
1149 | 1202 | </select> |
@@ -1174,8 +1227,7 @@ discard block |
||
1174 | 1227 | { |
1175 | 1228 | echo ' |
1176 | 1229 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1177 | - } |
|
1178 | - else |
|
1230 | + } else |
|
1179 | 1231 | { |
1180 | 1232 | echo ' |
1181 | 1233 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
@@ -1187,10 +1239,10 @@ discard block |
||
1187 | 1239 | echo ' |
1188 | 1240 | </tbody> |
1189 | 1241 | </table>'; |
1190 | - } |
|
1191 | - else |
|
1192 | - echo ' |
|
1242 | + } else { |
|
1243 | + echo ' |
|
1193 | 1244 | <p class="windowbg2">', $txt['showPermissions_none_board'], '</p>'; |
1245 | + } |
|
1194 | 1246 | echo ' |
1195 | 1247 | </div> |
1196 | 1248 | </div>'; |
@@ -1232,9 +1284,10 @@ discard block |
||
1232 | 1284 | </div>'; |
1233 | 1285 | |
1234 | 1286 | // If they haven't post at all, don't draw the graph. |
1235 | - if (empty($context['posts_by_time'])) |
|
1236 | - echo ' |
|
1287 | + if (empty($context['posts_by_time'])) { |
|
1288 | + echo ' |
|
1237 | 1289 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1290 | + } |
|
1238 | 1291 | // Otherwise do! |
1239 | 1292 | else |
1240 | 1293 | { |
@@ -1273,11 +1326,10 @@ discard block |
||
1273 | 1326 | </h3> |
1274 | 1327 | </div>'; |
1275 | 1328 | |
1276 | - if (empty($context['popular_boards'])) |
|
1277 | - echo ' |
|
1329 | + if (empty($context['popular_boards'])) { |
|
1330 | + echo ' |
|
1278 | 1331 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1279 | - |
|
1280 | - else |
|
1332 | + } else |
|
1281 | 1333 | { |
1282 | 1334 | echo ' |
1283 | 1335 | <dl class="stats">'; |
@@ -1308,10 +1360,10 @@ discard block |
||
1308 | 1360 | </h3> |
1309 | 1361 | </div>'; |
1310 | 1362 | |
1311 | - if (empty($context['board_activity'])) |
|
1312 | - echo ' |
|
1363 | + if (empty($context['board_activity'])) { |
|
1364 | + echo ' |
|
1313 | 1365 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1314 | - else |
|
1366 | + } else |
|
1315 | 1367 | { |
1316 | 1368 | echo ' |
1317 | 1369 | <dl class="stats">'; |
@@ -1359,41 +1411,46 @@ discard block |
||
1359 | 1411 | <h3 class="catbg profile_hd">'; |
1360 | 1412 | |
1361 | 1413 | // Don't say "Profile" if this isn't the profile... |
1362 | - if (!empty($context['profile_header_text'])) |
|
1363 | - echo ' |
|
1414 | + if (!empty($context['profile_header_text'])) { |
|
1415 | + echo ' |
|
1364 | 1416 | ', $context['profile_header_text']; |
1365 | - else |
|
1366 | - echo ' |
|
1417 | + } else { |
|
1418 | + echo ' |
|
1367 | 1419 | ', $txt['profile']; |
1420 | + } |
|
1368 | 1421 | |
1369 | 1422 | echo ' |
1370 | 1423 | </h3> |
1371 | 1424 | </div>'; |
1372 | 1425 | |
1373 | 1426 | // Have we some description? |
1374 | - if ($context['page_desc']) |
|
1375 | - echo ' |
|
1427 | + if ($context['page_desc']) { |
|
1428 | + echo ' |
|
1376 | 1429 | <p class="information">', $context['page_desc'], '</p>'; |
1430 | + } |
|
1377 | 1431 | |
1378 | 1432 | echo ' |
1379 | 1433 | <div class="roundframe">'; |
1380 | 1434 | |
1381 | 1435 | // Any bits at the start? |
1382 | - if (!empty($context['profile_prehtml'])) |
|
1383 | - echo ' |
|
1436 | + if (!empty($context['profile_prehtml'])) { |
|
1437 | + echo ' |
|
1384 | 1438 | <div>', $context['profile_prehtml'], '</div>'; |
1439 | + } |
|
1385 | 1440 | |
1386 | - if (!empty($context['profile_fields'])) |
|
1387 | - echo ' |
|
1441 | + if (!empty($context['profile_fields'])) { |
|
1442 | + echo ' |
|
1388 | 1443 | <dl class="settings">'; |
1444 | + } |
|
1389 | 1445 | |
1390 | 1446 | // Start the big old loop 'of love. |
1391 | 1447 | $lastItem = 'hr'; |
1392 | 1448 | foreach ($context['profile_fields'] as $key => $field) |
1393 | 1449 | { |
1394 | 1450 | // We add a little hack to be sure we never get more than one hr in a row! |
1395 | - if ($lastItem == 'hr' && $field['type'] == 'hr') |
|
1396 | - continue; |
|
1451 | + if ($lastItem == 'hr' && $field['type'] == 'hr') { |
|
1452 | + continue; |
|
1453 | + } |
|
1397 | 1454 | |
1398 | 1455 | $lastItem = $field['type']; |
1399 | 1456 | if ($field['type'] == 'hr') |
@@ -1402,48 +1459,50 @@ discard block |
||
1402 | 1459 | </dl> |
1403 | 1460 | <hr> |
1404 | 1461 | <dl class="settings">'; |
1405 | - } |
|
1406 | - elseif ($field['type'] == 'callback') |
|
1462 | + } elseif ($field['type'] == 'callback') |
|
1407 | 1463 | { |
1408 | 1464 | if (isset($field['callback_func']) && function_exists('template_profile_' . $field['callback_func'])) |
1409 | 1465 | { |
1410 | 1466 | $callback_func = 'template_profile_' . $field['callback_func']; |
1411 | 1467 | $callback_func(); |
1412 | 1468 | } |
1413 | - } |
|
1414 | - else |
|
1469 | + } else |
|
1415 | 1470 | { |
1416 | 1471 | echo ' |
1417 | 1472 | <dt> |
1418 | 1473 | <strong', !empty($field['is_error']) ? ' class="error"' : '', '>', $field['type'] !== 'label' ? '<label for="' . $key . '">' : '', $field['label'], $field['type'] !== 'label' ? '</label>' : '', '</strong>'; |
1419 | 1474 | |
1420 | 1475 | // Does it have any subtext to show? |
1421 | - if (!empty($field['subtext'])) |
|
1422 | - echo ' |
|
1476 | + if (!empty($field['subtext'])) { |
|
1477 | + echo ' |
|
1423 | 1478 | <br> |
1424 | 1479 | <span class="smalltext">', $field['subtext'], '</span>'; |
1480 | + } |
|
1425 | 1481 | |
1426 | 1482 | echo ' |
1427 | 1483 | </dt> |
1428 | 1484 | <dd>'; |
1429 | 1485 | |
1430 | 1486 | // Want to put something infront of the box? |
1431 | - if (!empty($field['preinput'])) |
|
1432 | - echo ' |
|
1487 | + if (!empty($field['preinput'])) { |
|
1488 | + echo ' |
|
1433 | 1489 | ', $field['preinput']; |
1490 | + } |
|
1434 | 1491 | |
1435 | 1492 | // What type of data are we showing? |
1436 | - if ($field['type'] == 'label') |
|
1437 | - echo ' |
|
1493 | + if ($field['type'] == 'label') { |
|
1494 | + echo ' |
|
1438 | 1495 | ', $field['value']; |
1496 | + } |
|
1439 | 1497 | |
1440 | 1498 | // Maybe it's a text box - very likely! |
1441 | 1499 | elseif (in_array($field['type'], array('int', 'float', 'text', 'password', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number', 'time', 'url'))) |
1442 | 1500 | { |
1443 | - if ($field['type'] == 'int' || $field['type'] == 'float') |
|
1444 | - $type = 'number'; |
|
1445 | - else |
|
1446 | - $type = $field['type']; |
|
1501 | + if ($field['type'] == 'int' || $field['type'] == 'float') { |
|
1502 | + $type = 'number'; |
|
1503 | + } else { |
|
1504 | + $type = $field['type']; |
|
1505 | + } |
|
1447 | 1506 | $step = $field['type'] == 'float' ? ' step="0.1"' : ''; |
1448 | 1507 | |
1449 | 1508 | |
@@ -1451,9 +1510,10 @@ discard block |
||
1451 | 1510 | <input type="', $type, '" name="', $key, '" id="', $key, '" size="', empty($field['size']) ? 30 : $field['size'], '" value="', $field['value'], '" ', $field['input_attr'], ' ', $step, '>'; |
1452 | 1511 | } |
1453 | 1512 | // You "checking" me out? ;) |
1454 | - elseif ($field['type'] == 'check') |
|
1455 | - echo ' |
|
1513 | + elseif ($field['type'] == 'check') { |
|
1514 | + echo ' |
|
1456 | 1515 | <input type="hidden" name="', $key, '" value="0"><input type="checkbox" name="', $key, '" id="', $key, '"', !empty($field['value']) ? ' checked' : '', ' value="1" ', $field['input_attr'], '>'; |
1516 | + } |
|
1457 | 1517 | |
1458 | 1518 | // Always fun - select boxes! |
1459 | 1519 | elseif ($field['type'] == 'select') |
@@ -1464,13 +1524,15 @@ discard block |
||
1464 | 1524 | if (isset($field['options'])) |
1465 | 1525 | { |
1466 | 1526 | // Is this some code to generate the options? |
1467 | - if (!is_array($field['options'])) |
|
1468 | - $field['options'] = $field['options'](); |
|
1527 | + if (!is_array($field['options'])) { |
|
1528 | + $field['options'] = $field['options'](); |
|
1529 | + } |
|
1469 | 1530 | // Assuming we now have some! |
1470 | - if (is_array($field['options'])) |
|
1471 | - foreach ($field['options'] as $value => $name) |
|
1531 | + if (is_array($field['options'])) { |
|
1532 | + foreach ($field['options'] as $value => $name) |
|
1472 | 1533 | echo ' |
1473 | 1534 | <option value="', $value, '"', $value == $field['value'] ? ' selected' : '', '>', $name, '</option>'; |
1535 | + } |
|
1474 | 1536 | } |
1475 | 1537 | |
1476 | 1538 | echo ' |
@@ -1478,25 +1540,28 @@ discard block |
||
1478 | 1540 | } |
1479 | 1541 | |
1480 | 1542 | // Something to end with? |
1481 | - if (!empty($field['postinput'])) |
|
1482 | - echo ' |
|
1543 | + if (!empty($field['postinput'])) { |
|
1544 | + echo ' |
|
1483 | 1545 | ', $field['postinput']; |
1546 | + } |
|
1484 | 1547 | |
1485 | 1548 | echo ' |
1486 | 1549 | </dd>'; |
1487 | 1550 | } |
1488 | 1551 | } |
1489 | 1552 | |
1490 | - if (!empty($context['profile_fields'])) |
|
1491 | - echo ' |
|
1553 | + if (!empty($context['profile_fields'])) { |
|
1554 | + echo ' |
|
1492 | 1555 | </dl>'; |
1556 | + } |
|
1493 | 1557 | |
1494 | 1558 | // Are there any custom profile fields - if so print them! |
1495 | 1559 | if (!empty($context['custom_fields'])) |
1496 | 1560 | { |
1497 | - if ($lastItem != 'hr') |
|
1498 | - echo ' |
|
1561 | + if ($lastItem != 'hr') { |
|
1562 | + echo ' |
|
1499 | 1563 | <hr>'; |
1564 | + } |
|
1500 | 1565 | |
1501 | 1566 | echo ' |
1502 | 1567 | <dl class="settings">'; |
@@ -1519,13 +1584,14 @@ discard block |
||
1519 | 1584 | } |
1520 | 1585 | |
1521 | 1586 | // Any closing HTML? |
1522 | - if (!empty($context['profile_posthtml'])) |
|
1523 | - echo ' |
|
1587 | + if (!empty($context['profile_posthtml'])) { |
|
1588 | + echo ' |
|
1524 | 1589 | <div>', $context['profile_posthtml'], '</div>'; |
1590 | + } |
|
1525 | 1591 | |
1526 | 1592 | // Only show the password box if it's actually needed. |
1527 | - if ($context['require_password']) |
|
1528 | - echo ' |
|
1593 | + if ($context['require_password']) { |
|
1594 | + echo ' |
|
1529 | 1595 | <dl class="settings"> |
1530 | 1596 | <dt> |
1531 | 1597 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br> |
@@ -1535,18 +1601,21 @@ discard block |
||
1535 | 1601 | <input type="password" name="oldpasswrd" id="oldpasswrd" size="20" style="margin-right: 4ex;"> |
1536 | 1602 | </dd> |
1537 | 1603 | </dl>'; |
1604 | + } |
|
1538 | 1605 | |
1539 | 1606 | // The button shouldn't say "Change profile" unless we're changing the profile... |
1540 | - if (!empty($context['submit_button_text'])) |
|
1541 | - echo ' |
|
1607 | + if (!empty($context['submit_button_text'])) { |
|
1608 | + echo ' |
|
1542 | 1609 | <input type="submit" name="save" value="', $context['submit_button_text'], '" class="button_submit">'; |
1543 | - else |
|
1544 | - echo ' |
|
1610 | + } else { |
|
1611 | + echo ' |
|
1545 | 1612 | <input type="submit" name="save" value="', $txt['change_profile'], '" class="button_submit">'; |
1613 | + } |
|
1546 | 1614 | |
1547 | - if (!empty($context['token_check'])) |
|
1548 | - echo ' |
|
1615 | + if (!empty($context['token_check'])) { |
|
1616 | + echo ' |
|
1549 | 1617 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
1618 | + } |
|
1550 | 1619 | |
1551 | 1620 | echo ' |
1552 | 1621 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -1556,10 +1625,11 @@ discard block |
||
1556 | 1625 | </form>'; |
1557 | 1626 | |
1558 | 1627 | // Any final spellchecking stuff? |
1559 | - if (!empty($context['show_spellchecking'])) |
|
1560 | - echo ' |
|
1628 | + if (!empty($context['show_spellchecking'])) { |
|
1629 | + echo ' |
|
1561 | 1630 | <form name="spell_form" id="spell_form" method="post" accept-charset="', $context['character_set'], '" target="spellWindow" action="', $scripturl, '?action=spellcheck"><input type="hidden" name="spellstring" value=""></form>'; |
1562 | -} |
|
1631 | + } |
|
1632 | + } |
|
1563 | 1633 | |
1564 | 1634 | /** |
1565 | 1635 | * Personal Message settings. |
@@ -1596,10 +1666,11 @@ discard block |
||
1596 | 1666 | <select name="pm_receive_from" id="pm_receive_from"> |
1597 | 1667 | <option value="0"', empty($context['receive_from']) || (empty($modSettings['enable_buddylist']) && $context['receive_from'] < 3) ? ' selected' : '', '>', $txt['pm_receive_from_everyone'], '</option>'; |
1598 | 1668 | |
1599 | - if (!empty($modSettings['enable_buddylist'])) |
|
1600 | - echo ' |
|
1669 | + if (!empty($modSettings['enable_buddylist'])) { |
|
1670 | + echo ' |
|
1601 | 1671 | <option value="1"', !empty($context['receive_from']) && $context['receive_from'] == 1 ? ' selected' : '', '>', $txt['pm_receive_from_ignore'], '</option> |
1602 | 1672 | <option value="2"', !empty($context['receive_from']) && $context['receive_from'] == 2 ? ' selected' : '', '>', $txt['pm_receive_from_buddies'], '</option>'; |
1673 | + } |
|
1603 | 1674 | |
1604 | 1675 | echo ' |
1605 | 1676 | <option value="3"', !empty($context['receive_from']) && $context['receive_from'] > 2 ? ' selected' : '', '>', $txt['pm_receive_from_admins'], '</option> |
@@ -1642,11 +1713,12 @@ discard block |
||
1642 | 1713 | if (empty($setting) || !is_array($setting)) |
1643 | 1714 | { |
1644 | 1715 | // Insert a separator (unless this is the first item in the list) |
1645 | - if ($i !== $first_option_key) |
|
1646 | - echo ' |
|
1716 | + if ($i !== $first_option_key) { |
|
1717 | + echo ' |
|
1647 | 1718 | </dl> |
1648 | 1719 | <hr> |
1649 | 1720 | <dl class="settings">'; |
1721 | + } |
|
1650 | 1722 | |
1651 | 1723 | // Should we give a name to this section? |
1652 | 1724 | if (is_string($setting) && !empty($setting)) |
@@ -1654,48 +1726,52 @@ discard block |
||
1654 | 1726 | $titled_section = true; |
1655 | 1727 | echo ' |
1656 | 1728 | <dt><strong>' . $setting . '</strong></dt><dd></dd>'; |
1729 | + } else { |
|
1730 | + $titled_section = false; |
|
1657 | 1731 | } |
1658 | - else |
|
1659 | - $titled_section = false; |
|
1660 | 1732 | |
1661 | 1733 | continue; |
1662 | 1734 | } |
1663 | 1735 | |
1664 | 1736 | // Is this disabled? |
1665 | - if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) |
|
1666 | - continue; |
|
1667 | - elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
1668 | - continue; |
|
1669 | - elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) |
|
1670 | - continue; |
|
1671 | - elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) |
|
1672 | - continue; |
|
1673 | - elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) |
|
1674 | - continue; |
|
1675 | - elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage'])) |
|
1676 | - continue; |
|
1677 | - elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1678 | - continue; |
|
1679 | - elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1680 | - continue; |
|
1737 | + if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) { |
|
1738 | + continue; |
|
1739 | + } elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) { |
|
1740 | + continue; |
|
1741 | + } elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) { |
|
1742 | + continue; |
|
1743 | + } elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) { |
|
1744 | + continue; |
|
1745 | + } elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) { |
|
1746 | + continue; |
|
1747 | + } elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage'])) { |
|
1748 | + continue; |
|
1749 | + } elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1750 | + continue; |
|
1751 | + } elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1752 | + continue; |
|
1753 | + } |
|
1681 | 1754 | |
1682 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
1683 | - $setting['type'] = 'checkbox'; |
|
1684 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
1685 | - $setting['type'] = 'number'; |
|
1686 | - elseif ($setting['type'] == 'string') |
|
1687 | - $setting['type'] = 'text'; |
|
1755 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
1756 | + $setting['type'] = 'checkbox'; |
|
1757 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
1758 | + $setting['type'] = 'number'; |
|
1759 | + } elseif ($setting['type'] == 'string') { |
|
1760 | + $setting['type'] = 'text'; |
|
1761 | + } |
|
1688 | 1762 | |
1689 | - if (isset($setting['options'])) |
|
1690 | - $setting['type'] = 'list'; |
|
1763 | + if (isset($setting['options'])) { |
|
1764 | + $setting['type'] = 'list'; |
|
1765 | + } |
|
1691 | 1766 | |
1692 | 1767 | echo ' |
1693 | 1768 | <dt> |
1694 | 1769 | <label for="', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>'; |
1695 | 1770 | |
1696 | - if (isset($setting['description'])) |
|
1697 | - echo ' |
|
1771 | + if (isset($setting['description'])) { |
|
1772 | + echo ' |
|
1698 | 1773 | <br><span class="smalltext">', $setting['description'], '</span>'; |
1774 | + } |
|
1699 | 1775 | echo ' |
1700 | 1776 | </dt> |
1701 | 1777 | <dd>'; |
@@ -1733,13 +1809,11 @@ discard block |
||
1733 | 1809 | |
1734 | 1810 | echo ' |
1735 | 1811 | <input type="number"', $min . $max . $step; |
1736 | - } |
|
1737 | - else if (isset($setting['type']) && $setting['type'] == 'url') |
|
1812 | + } else if (isset($setting['type']) && $setting['type'] == 'url') |
|
1738 | 1813 | { |
1739 | 1814 | echo' |
1740 | 1815 | <input type="url"'; |
1741 | - } |
|
1742 | - else |
|
1816 | + } else |
|
1743 | 1817 | { |
1744 | 1818 | echo ' |
1745 | 1819 | <input type="text"'; |
@@ -1778,8 +1852,8 @@ discard block |
||
1778 | 1852 | <dl class="settings">'; |
1779 | 1853 | |
1780 | 1854 | // Allow notification on announcements to be disabled? |
1781 | - if (!empty($modSettings['allow_disableAnnounce'])) |
|
1782 | - echo ' |
|
1855 | + if (!empty($modSettings['allow_disableAnnounce'])) { |
|
1856 | + echo ' |
|
1783 | 1857 | <dt> |
1784 | 1858 | <label for="notify_announcements">', $txt['notify_important_email'], '</label> |
1785 | 1859 | </dt> |
@@ -1787,9 +1861,10 @@ discard block |
||
1787 | 1861 | <input type="hidden" name="notify_announcements" value="0"> |
1788 | 1862 | <input type="checkbox" id="notify_announcements" name="notify_announcements" value="1"', !empty($context['member']['notify_announcements']) ? ' checked' : '', '> |
1789 | 1863 | </dd>'; |
1864 | + } |
|
1790 | 1865 | |
1791 | - if (!empty($modSettings['enable_ajax_alerts'])) |
|
1792 | - echo ' |
|
1866 | + if (!empty($modSettings['enable_ajax_alerts'])) { |
|
1867 | + echo ' |
|
1793 | 1868 | <dt> |
1794 | 1869 | <label for="notify_send_body">', $txt['notify_alert_timeout'], '</label> |
1795 | 1870 | </dt> |
@@ -1797,6 +1872,7 @@ discard block |
||
1797 | 1872 | <input type="number" size="4" id="notify_alert_timeout" name="opt_alert_timeout" min="0" value="', $context['member']['alert_timeout'], '"> |
1798 | 1873 | </dd> |
1799 | 1874 | '; |
1875 | + } |
|
1800 | 1876 | |
1801 | 1877 | echo ' |
1802 | 1878 | </dl> |
@@ -1826,9 +1902,10 @@ discard block |
||
1826 | 1902 | <td colspan="3">'; |
1827 | 1903 | $label = $txt['alert_opt_' . $opts[1]]; |
1828 | 1904 | $label_pos = isset($opts['label']) ? $opts['label'] : ''; |
1829 | - if ($label_pos == 'before') |
|
1830 | - echo ' |
|
1905 | + if ($label_pos == 'before') { |
|
1906 | + echo ' |
|
1831 | 1907 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
1908 | + } |
|
1832 | 1909 | |
1833 | 1910 | $this_value = isset($context['alert_prefs'][$opts[1]]) ? $context['alert_prefs'][$opts[1]] : 0; |
1834 | 1911 | switch ($opts[0]) |
@@ -1840,17 +1917,19 @@ discard block |
||
1840 | 1917 | case 'select': |
1841 | 1918 | echo ' |
1842 | 1919 | <select name="opt_', $opts[1], '" id="opt_', $opts[1], '">'; |
1843 | - foreach ($opts['opts'] as $k => $v) |
|
1844 | - echo ' |
|
1920 | + foreach ($opts['opts'] as $k => $v) { |
|
1921 | + echo ' |
|
1845 | 1922 | <option value="', $k, '"', $this_value == $k ? ' selected' : '', '>', $v, '</option>'; |
1923 | + } |
|
1846 | 1924 | echo ' |
1847 | 1925 | </select>'; |
1848 | 1926 | break; |
1849 | 1927 | } |
1850 | 1928 | |
1851 | - if ($label_pos == 'after') |
|
1852 | - echo ' |
|
1929 | + if ($label_pos == 'after') { |
|
1930 | + echo ' |
|
1853 | 1931 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
1932 | + } |
|
1854 | 1933 | |
1855 | 1934 | echo ' |
1856 | 1935 | </td> |
@@ -1964,11 +2043,12 @@ discard block |
||
1964 | 2043 | <p class="information">', $txt['groupMembership_info'], '</p>'; |
1965 | 2044 | |
1966 | 2045 | // Do we have an update message? |
1967 | - if (!empty($context['update_message'])) |
|
1968 | - echo ' |
|
2046 | + if (!empty($context['update_message'])) { |
|
2047 | + echo ' |
|
1969 | 2048 | <div class="infobox"> |
1970 | 2049 | ', $context['update_message'], '. |
1971 | 2050 | </div>'; |
2051 | + } |
|
1972 | 2052 | |
1973 | 2053 | echo ' |
1974 | 2054 | <div id="groups">'; |
@@ -1990,8 +2070,7 @@ discard block |
||
1990 | 2070 | </div> |
1991 | 2071 | </div> |
1992 | 2072 | </div>'; |
1993 | - } |
|
1994 | - else |
|
2073 | + } else |
|
1995 | 2074 | { |
1996 | 2075 | echo ' |
1997 | 2076 | <div class="title_bar"> |
@@ -2003,27 +2082,30 @@ discard block |
||
2003 | 2082 | echo ' |
2004 | 2083 | <div class="windowbg" id="primdiv_', $group['id'], '">'; |
2005 | 2084 | |
2006 | - if ($context['can_edit_primary']) |
|
2007 | - echo ' |
|
2085 | + if ($context['can_edit_primary']) { |
|
2086 | + echo ' |
|
2008 | 2087 | <input type="radio" name="primary" id="primary_', $group['id'], '" value="', $group['id'], '"', $group['is_primary'] ? ' checked' : '', ' onclick="highlightSelected(\'primdiv_' . $group['id'] . '\');"', $group['can_be_primary'] ? '' : ' disabled', '>'; |
2088 | + } |
|
2009 | 2089 | |
2010 | 2090 | echo ' |
2011 | 2091 | <label for="primary_', $group['id'], '"><strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '</label>'; |
2012 | 2092 | |
2013 | 2093 | // Can they leave their group? |
2014 | - if ($group['can_leave']) |
|
2015 | - echo ' |
|
2094 | + if ($group['can_leave']) { |
|
2095 | + echo ' |
|
2016 | 2096 | <a href="' . $scripturl . '?action=profile;save;u=' . $context['id_member'] . ';area=groupmembership;' . $context['session_var'] . '=' . $context['session_id'] . ';gid=' . $group['id'] . ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '">' . $txt['leave_group'] . '</a>'; |
2097 | + } |
|
2017 | 2098 | |
2018 | 2099 | echo ' |
2019 | 2100 | </div>'; |
2020 | 2101 | } |
2021 | 2102 | |
2022 | - if ($context['can_edit_primary']) |
|
2023 | - echo ' |
|
2103 | + if ($context['can_edit_primary']) { |
|
2104 | + echo ' |
|
2024 | 2105 | <div class="padding righttext"> |
2025 | 2106 | <input type="submit" value="', $txt['make_primary'], '" class="button_submit"> |
2026 | 2107 | </div>'; |
2108 | + } |
|
2027 | 2109 | |
2028 | 2110 | // Any groups they can join? |
2029 | 2111 | if (!empty($context['groups']['available'])) |
@@ -2039,15 +2121,16 @@ discard block |
||
2039 | 2121 | <div class="windowbg"> |
2040 | 2122 | <strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), ''; |
2041 | 2123 | |
2042 | - if ($group['type'] == 3) |
|
2043 | - echo ' |
|
2124 | + if ($group['type'] == 3) { |
|
2125 | + echo ' |
|
2044 | 2126 | <a href="', $scripturl, '?action=profile;save;u=', $context['id_member'], ';area=groupmembership;', $context['session_var'], '=', $context['session_id'], ';gid=', $group['id'], ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '" class="button floatright">', $txt['join_group'], '</a>'; |
2045 | - elseif ($group['type'] == 2 && $group['pending']) |
|
2046 | - echo ' |
|
2127 | + } elseif ($group['type'] == 2 && $group['pending']) { |
|
2128 | + echo ' |
|
2047 | 2129 | <span class="floatright">', $txt['approval_pending'], '</span>'; |
2048 | - elseif ($group['type'] == 2) |
|
2049 | - echo ' |
|
2130 | + } elseif ($group['type'] == 2) { |
|
2131 | + echo ' |
|
2050 | 2132 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=groupmembership;request=', $group['id'], '" class="button floatright">', $txt['request_group'], '</a>'; |
2133 | + } |
|
2051 | 2134 | |
2052 | 2135 | echo ' |
2053 | 2136 | </div>'; |
@@ -2070,9 +2153,10 @@ discard block |
||
2070 | 2153 | |
2071 | 2154 | prevDiv.className = "windowbg"; |
2072 | 2155 | }'; |
2073 | - if (isset($context['groups']['member'][$context['primary_group']])) |
|
2074 | - echo ' |
|
2156 | + if (isset($context['groups']['member'][$context['primary_group']])) { |
|
2157 | + echo ' |
|
2075 | 2158 | highlightSelected("primdiv_' . $context['primary_group'] . '");'; |
2159 | + } |
|
2076 | 2160 | echo ' |
2077 | 2161 | </script>'; |
2078 | 2162 | } |
@@ -2080,9 +2164,10 @@ discard block |
||
2080 | 2164 | echo ' |
2081 | 2165 | </div>'; |
2082 | 2166 | |
2083 | - if (!empty($context['token_check'])) |
|
2084 | - echo ' |
|
2167 | + if (!empty($context['token_check'])) { |
|
2168 | + echo ' |
|
2085 | 2169 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2170 | + } |
|
2086 | 2171 | |
2087 | 2172 | echo ' |
2088 | 2173 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2129,14 +2214,15 @@ discard block |
||
2129 | 2214 | |
2130 | 2215 | foreach ($category['boards'] as $board) |
2131 | 2216 | { |
2132 | - if ($i == $limit) |
|
2133 | - echo ' |
|
2217 | + if ($i == $limit) { |
|
2218 | + echo ' |
|
2134 | 2219 | </ul> |
2135 | 2220 | </li> |
2136 | 2221 | </ul> |
2137 | 2222 | <ul class="ignoreboards floatright"> |
2138 | 2223 | <li class="category"> |
2139 | 2224 | <ul>'; |
2225 | + } |
|
2140 | 2226 | |
2141 | 2227 | echo ' |
2142 | 2228 | <li class="board" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;"> |
@@ -2182,10 +2268,11 @@ discard block |
||
2182 | 2268 | |
2183 | 2269 | // Work out the starting color. |
2184 | 2270 | $context['current_color'] = $context['colors'][0]; |
2185 | - foreach ($context['colors'] as $limit => $color) |
|
2186 | - if ($context['member']['warning'] >= $limit) |
|
2271 | + foreach ($context['colors'] as $limit => $color) { |
|
2272 | + if ($context['member']['warning'] >= $limit) |
|
2187 | 2273 | $context['current_color'] = $color; |
2188 | -} |
|
2274 | + } |
|
2275 | + } |
|
2189 | 2276 | |
2190 | 2277 | // Show all warnings of a user? |
2191 | 2278 | function template_viewWarning() |
@@ -2224,14 +2311,15 @@ discard block |
||
2224 | 2311 | </dd>'; |
2225 | 2312 | |
2226 | 2313 | // There's some impact of this? |
2227 | - if (!empty($context['level_effects'][$context['current_level']])) |
|
2228 | - echo ' |
|
2314 | + if (!empty($context['level_effects'][$context['current_level']])) { |
|
2315 | + echo ' |
|
2229 | 2316 | <dt> |
2230 | 2317 | <strong>', $txt['profile_viewwarning_impact'], ':</strong> |
2231 | 2318 | </dt> |
2232 | 2319 | <dd> |
2233 | 2320 | ', $context['level_effects'][$context['current_level']], ' |
2234 | 2321 | </dd>'; |
2322 | + } |
|
2235 | 2323 | |
2236 | 2324 | echo ' |
2237 | 2325 | </dl> |
@@ -2269,10 +2357,11 @@ discard block |
||
2269 | 2357 | |
2270 | 2358 | // Otherwise see what we can do...'; |
2271 | 2359 | |
2272 | - foreach ($context['notification_templates'] as $k => $type) |
|
2273 | - echo ' |
|
2360 | + foreach ($context['notification_templates'] as $k => $type) { |
|
2361 | + echo ' |
|
2274 | 2362 | if (index == ', $k, ') |
2275 | 2363 | document.getElementById(\'warn_body\').value = "', strtr($type['body'], array('"' => "'", "\n" => '\\n', "\r" => '')), '";'; |
2364 | + } |
|
2276 | 2365 | |
2277 | 2366 | echo ' |
2278 | 2367 | } |
@@ -2282,10 +2371,11 @@ discard block |
||
2282 | 2371 | // Also set the right effect. |
2283 | 2372 | effectText = "";'; |
2284 | 2373 | |
2285 | - foreach ($context['level_effects'] as $limit => $text) |
|
2286 | - echo ' |
|
2374 | + foreach ($context['level_effects'] as $limit => $text) { |
|
2375 | + echo ' |
|
2287 | 2376 | if (slideAmount >= ', $limit, ') |
2288 | 2377 | effectText = "', $text, '";'; |
2378 | + } |
|
2289 | 2379 | |
2290 | 2380 | echo ' |
2291 | 2381 | setInnerHTML(document.getElementById(\'cur_level_div\'), slideAmount + \'% (\' + effectText + \')\'); |
@@ -2300,31 +2390,34 @@ discard block |
||
2300 | 2390 | </h3> |
2301 | 2391 | </div>'; |
2302 | 2392 | |
2303 | - if (!$context['user']['is_owner']) |
|
2304 | - echo ' |
|
2393 | + if (!$context['user']['is_owner']) { |
|
2394 | + echo ' |
|
2305 | 2395 | <p class="information">', $txt['profile_warning_desc'], '</p>'; |
2396 | + } |
|
2306 | 2397 | |
2307 | 2398 | echo ' |
2308 | 2399 | <div class="windowbg"> |
2309 | 2400 | <dl class="settings">'; |
2310 | 2401 | |
2311 | - if (!$context['user']['is_owner']) |
|
2312 | - echo ' |
|
2402 | + if (!$context['user']['is_owner']) { |
|
2403 | + echo ' |
|
2313 | 2404 | <dt> |
2314 | 2405 | <strong>', $txt['profile_warning_name'], ':</strong> |
2315 | 2406 | </dt> |
2316 | 2407 | <dd> |
2317 | 2408 | <strong>', $context['member']['name'], '</strong> |
2318 | 2409 | </dd>'; |
2410 | + } |
|
2319 | 2411 | |
2320 | 2412 | echo ' |
2321 | 2413 | <dt> |
2322 | 2414 | <strong>', $txt['profile_warning_level'], ':</strong>'; |
2323 | 2415 | |
2324 | 2416 | // Is there only so much they can apply? |
2325 | - if ($context['warning_limit']) |
|
2326 | - echo ' |
|
2417 | + if ($context['warning_limit']) { |
|
2418 | + echo ' |
|
2327 | 2419 | <br><span class="smalltext">', sprintf($txt['profile_warning_limit_attribute'], $context['warning_limit']), '</span>'; |
2420 | + } |
|
2328 | 2421 | |
2329 | 2422 | echo ' |
2330 | 2423 | </dt> |
@@ -2377,9 +2470,10 @@ discard block |
||
2377 | 2470 | <option value="-1">', $txt['profile_warning_notify_template'], '</option> |
2378 | 2471 | <option value="-1" disabled>------------------------------</option>'; |
2379 | 2472 | |
2380 | - foreach ($context['notification_templates'] as $id_template => $template) |
|
2381 | - echo ' |
|
2473 | + foreach ($context['notification_templates'] as $id_template => $template) { |
|
2474 | + echo ' |
|
2382 | 2475 | <option value="', $id_template, '">', $template['title'], '</option>'; |
2476 | + } |
|
2383 | 2477 | |
2384 | 2478 | echo ' |
2385 | 2479 | </select> |
@@ -2391,9 +2485,10 @@ discard block |
||
2391 | 2485 | </dl> |
2392 | 2486 | <div class="righttext">'; |
2393 | 2487 | |
2394 | - if (!empty($context['token_check'])) |
|
2395 | - echo ' |
|
2488 | + if (!empty($context['token_check'])) { |
|
2489 | + echo ' |
|
2396 | 2490 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2491 | + } |
|
2397 | 2492 | |
2398 | 2493 | echo ' |
2399 | 2494 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2409,8 +2504,8 @@ discard block |
||
2409 | 2504 | echo ' |
2410 | 2505 | <script>'; |
2411 | 2506 | |
2412 | - if (!$context['user']['is_owner']) |
|
2413 | - echo ' |
|
2507 | + if (!$context['user']['is_owner']) { |
|
2508 | + echo ' |
|
2414 | 2509 | modifyWarnNotify(); |
2415 | 2510 | $(document).ready(function() { |
2416 | 2511 | $("#preview_button").click(function() { |
@@ -2449,6 +2544,7 @@ discard block |
||
2449 | 2544 | }); |
2450 | 2545 | return false; |
2451 | 2546 | }'; |
2547 | + } |
|
2452 | 2548 | |
2453 | 2549 | echo ' |
2454 | 2550 | </script>'; |
@@ -2471,16 +2567,18 @@ discard block |
||
2471 | 2567 | </div>'; |
2472 | 2568 | |
2473 | 2569 | // If deleting another account give them a lovely info box. |
2474 | - if (!$context['user']['is_owner']) |
|
2475 | - echo ' |
|
2570 | + if (!$context['user']['is_owner']) { |
|
2571 | + echo ' |
|
2476 | 2572 | <p class="information">', $txt['deleteAccount_desc'], '</p>'; |
2573 | + } |
|
2477 | 2574 | echo ' |
2478 | 2575 | <div class="windowbg2">'; |
2479 | 2576 | |
2480 | 2577 | // If they are deleting their account AND the admin needs to approve it - give them another piece of info ;) |
2481 | - if ($context['needs_approval']) |
|
2482 | - echo ' |
|
2578 | + if ($context['needs_approval']) { |
|
2579 | + echo ' |
|
2483 | 2580 | <div class="errorbox">', $txt['deleteAccount_approval'], '</div>'; |
2581 | + } |
|
2484 | 2582 | |
2485 | 2583 | // If the user is deleting their own account warn them first - and require a password! |
2486 | 2584 | if ($context['user']['is_owner']) |
@@ -2492,9 +2590,10 @@ discard block |
||
2492 | 2590 | <input type="password" name="oldpasswrd" size="20"> |
2493 | 2591 | <input type="submit" value="', $txt['yes'], '" class="button_submit">'; |
2494 | 2592 | |
2495 | - if (!empty($context['token_check'])) |
|
2496 | - echo ' |
|
2593 | + if (!empty($context['token_check'])) { |
|
2594 | + echo ' |
|
2497 | 2595 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2596 | + } |
|
2498 | 2597 | |
2499 | 2598 | echo ' |
2500 | 2599 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2520,9 +2619,10 @@ discard block |
||
2520 | 2619 | <option value="topics">', $txt['deleteAccount_topics'], '</option> |
2521 | 2620 | </select>'; |
2522 | 2621 | |
2523 | - if ($context['show_perma_delete']) |
|
2524 | - echo ' |
|
2622 | + if ($context['show_perma_delete']) { |
|
2623 | + echo ' |
|
2525 | 2624 | <br><label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1">', $txt['deleteAccount_permanent'], ':</label>'; |
2625 | + } |
|
2526 | 2626 | |
2527 | 2627 | echo ' |
2528 | 2628 | </div>'; |
@@ -2535,9 +2635,10 @@ discard block |
||
2535 | 2635 | <div> |
2536 | 2636 | <input type="submit" value="', $txt['delete'], '" class="button_submit">'; |
2537 | 2637 | |
2538 | - if (!empty($context['token_check'])) |
|
2539 | - echo ' |
|
2638 | + if (!empty($context['token_check'])) { |
|
2639 | + echo ' |
|
2540 | 2640 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2641 | + } |
|
2541 | 2642 | |
2542 | 2643 | echo ' |
2543 | 2644 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2563,8 +2664,8 @@ discard block |
||
2563 | 2664 | <hr>'; |
2564 | 2665 | |
2565 | 2666 | // Only show the password box if it's actually needed. |
2566 | - if ($context['require_password']) |
|
2567 | - echo ' |
|
2667 | + if ($context['require_password']) { |
|
2668 | + echo ' |
|
2568 | 2669 | <dl class="settings"> |
2569 | 2670 | <dt> |
2570 | 2671 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '>', $txt['current_password'], ': </strong><br> |
@@ -2574,13 +2675,15 @@ discard block |
||
2574 | 2675 | <input type="password" name="oldpasswrd" size="20" style="margin-right: 4ex;"> |
2575 | 2676 | </dd> |
2576 | 2677 | </dl>'; |
2678 | + } |
|
2577 | 2679 | |
2578 | 2680 | echo ' |
2579 | 2681 | <div class="righttext">'; |
2580 | 2682 | |
2581 | - if (!empty($context['token_check'])) |
|
2582 | - echo ' |
|
2683 | + if (!empty($context['token_check'])) { |
|
2684 | + echo ' |
|
2583 | 2685 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2686 | + } |
|
2584 | 2687 | |
2585 | 2688 | echo ' |
2586 | 2689 | <input type="submit" value="', $txt['change_profile'], '" class="button_submit"> |
@@ -2607,9 +2710,10 @@ discard block |
||
2607 | 2710 | <ul id="list_errors">'; |
2608 | 2711 | |
2609 | 2712 | // Cycle through each error and display an error message. |
2610 | - foreach ($context['post_errors'] as $error) |
|
2611 | - echo ' |
|
2713 | + foreach ($context['post_errors'] as $error) { |
|
2714 | + echo ' |
|
2612 | 2715 | <li>', isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : $error, '</li>'; |
2716 | + } |
|
2613 | 2717 | |
2614 | 2718 | echo ' |
2615 | 2719 | </ul>'; |
@@ -2635,12 +2739,13 @@ discard block |
||
2635 | 2739 | <select name="id_group" ', ($context['user']['is_owner'] && $context['member']['group_id'] == 1 ? 'onchange="if (this.value != 1 && !confirm(\'' . $txt['deadmin_confirm'] . '\')) this.value = 1;"' : ''), '>'; |
2636 | 2740 | |
2637 | 2741 | // Fill the select box with all primary member groups that can be assigned to a member. |
2638 | - foreach ($context['member_groups'] as $member_group) |
|
2639 | - if (!empty($member_group['can_be_primary'])) |
|
2742 | + foreach ($context['member_groups'] as $member_group) { |
|
2743 | + if (!empty($member_group['can_be_primary'])) |
|
2640 | 2744 | echo ' |
2641 | 2745 | <option value="', $member_group['id'], '"', $member_group['is_primary'] ? ' selected' : '', '> |
2642 | 2746 | ', $member_group['name'], ' |
2643 | 2747 | </option>'; |
2748 | + } |
|
2644 | 2749 | echo ' |
2645 | 2750 | </select> |
2646 | 2751 | </dd> |
@@ -2652,10 +2757,11 @@ discard block |
||
2652 | 2757 | <input type="hidden" name="additional_groups[]" value="0">'; |
2653 | 2758 | |
2654 | 2759 | // For each membergroup show a checkbox so members can be assigned to more than one group. |
2655 | - foreach ($context['member_groups'] as $member_group) |
|
2656 | - if ($member_group['can_be_additional']) |
|
2760 | + foreach ($context['member_groups'] as $member_group) { |
|
2761 | + if ($member_group['can_be_additional']) |
|
2657 | 2762 | echo ' |
2658 | 2763 | <label for="additional_groups-', $member_group['id'], '"><input type="checkbox" name="additional_groups[]" value="', $member_group['id'], '" id="additional_groups-', $member_group['id'], '"', $member_group['is_additional'] ? ' checked' : '', '> ', $member_group['name'], '</label><br>'; |
2764 | + } |
|
2659 | 2765 | echo ' |
2660 | 2766 | </span> |
2661 | 2767 | <a href="javascript:void(0);" onclick="document.getElementById(\'additional_groupsList\').style.display = \'block\'; document.getElementById(\'additional_groupsLink\').style.display = \'none\'; return false;" id="additional_groupsLink" style="display: none;" class="toggle_down">', $txt['additional_membergroups_show'], '</a> |
@@ -2715,9 +2821,10 @@ discard block |
||
2715 | 2821 | <span class="smalltext">', $txt['sig_info'], '</span><br> |
2716 | 2822 | <br>'; |
2717 | 2823 | |
2718 | - if ($context['show_spellchecking']) |
|
2719 | - echo ' |
|
2824 | + if ($context['show_spellchecking']) { |
|
2825 | + echo ' |
|
2720 | 2826 | <input type="button" value="', $txt['spell_check'], '" onclick="spellCheck(\'creator\', \'signature\');" class="button_submit">'; |
2827 | + } |
|
2721 | 2828 | |
2722 | 2829 | echo ' |
2723 | 2830 | </dt> |
@@ -2725,17 +2832,20 @@ discard block |
||
2725 | 2832 | <textarea class="editor" onkeyup="calcCharLeft();" id="signature" name="signature" rows="5" cols="50" style="min-width: 50%; max-width: 99%;">', $context['member']['signature'], '</textarea><br>'; |
2726 | 2833 | |
2727 | 2834 | // If there is a limit at all! |
2728 | - if (!empty($context['signature_limits']['max_length'])) |
|
2729 | - echo ' |
|
2835 | + if (!empty($context['signature_limits']['max_length'])) { |
|
2836 | + echo ' |
|
2730 | 2837 | <span class="smalltext">', sprintf($txt['max_sig_characters'], $context['signature_limits']['max_length']), ' <span id="signatureLeft">', $context['signature_limits']['max_length'], '</span></span><br>'; |
2838 | + } |
|
2731 | 2839 | |
2732 | - if (!empty($context['show_preview_button'])) |
|
2733 | - echo ' |
|
2840 | + if (!empty($context['show_preview_button'])) { |
|
2841 | + echo ' |
|
2734 | 2842 | <input type="button" name="preview_signature" id="preview_button" value="', $txt['preview_signature'], '" class="button_submit">'; |
2843 | + } |
|
2735 | 2844 | |
2736 | - if ($context['signature_warning']) |
|
2737 | - echo ' |
|
2845 | + if ($context['signature_warning']) { |
|
2846 | + echo ' |
|
2738 | 2847 | <span class="smalltext">', $context['signature_warning'], '</span>'; |
2848 | + } |
|
2739 | 2849 | |
2740 | 2850 | // Some javascript used to count how many characters have been used so far in the signature. |
2741 | 2851 | echo ' |
@@ -2779,9 +2889,10 @@ discard block |
||
2779 | 2889 | <div> |
2780 | 2890 | <select name="cat" id="cat" size="10" onchange="changeSel(\'\');" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'server_stored\');">'; |
2781 | 2891 | // This lists all the file categories. |
2782 | - foreach ($context['avatars'] as $avatar) |
|
2783 | - echo ' |
|
2892 | + foreach ($context['avatars'] as $avatar) { |
|
2893 | + echo ' |
|
2784 | 2894 | <option value="', $avatar['filename'] . ($avatar['is_dir'] ? '/' : ''), '"', ($avatar['checked'] ? ' selected' : ''), '>', $avatar['name'], '</option>'; |
2895 | + } |
|
2785 | 2896 | echo ' |
2786 | 2897 | </select> |
2787 | 2898 | </div> |
@@ -2836,16 +2947,17 @@ discard block |
||
2836 | 2947 | <div id="avatar_gravatar"> |
2837 | 2948 | <img src="' . $context['member']['avatar']['href'] . '" alt="" />'; |
2838 | 2949 | |
2839 | - if (empty($modSettings['gravatarAllowExtraEmail'])) |
|
2840 | - echo ' |
|
2950 | + if (empty($modSettings['gravatarAllowExtraEmail'])) { |
|
2951 | + echo ' |
|
2841 | 2952 | <div class="smalltext">', $txt['gravatar_noAlternateEmail'], '</div>'; |
2842 | - else |
|
2953 | + } else |
|
2843 | 2954 | { |
2844 | 2955 | // Depending on other stuff, the stored value here might have some odd things in it from other areas. |
2845 | - if ($context['member']['avatar']['external'] == $context['member']['email']) |
|
2846 | - $textbox_value = ''; |
|
2847 | - else |
|
2848 | - $textbox_value = $context['member']['avatar']['external']; |
|
2956 | + if ($context['member']['avatar']['external'] == $context['member']['email']) { |
|
2957 | + $textbox_value = ''; |
|
2958 | + } else { |
|
2959 | + $textbox_value = $context['member']['avatar']['external']; |
|
2960 | + } |
|
2849 | 2961 | |
2850 | 2962 | echo ' |
2851 | 2963 | <div class="smalltext">', $txt['gravatar_alternateEmail'], '</div> |
@@ -2917,8 +3029,9 @@ discard block |
||
2917 | 3029 | $h = !empty($modSettings['avatar_max_height_' . $type]) ? comma_format($modSettings['avatar_max_height_' . $type]) : 0; |
2918 | 3030 | |
2919 | 3031 | $suffix = (!empty($w) ? 'w' : '') . (!empty($h) ? 'h' : ''); |
2920 | - if (empty($suffix)) |
|
2921 | - return; |
|
3032 | + if (empty($suffix)) { |
|
3033 | + return; |
|
3034 | + } |
|
2922 | 3035 | |
2923 | 3036 | echo ' |
2924 | 3037 | <div class="smalltext">', sprintf($txt['avatar_max_size_' . $suffix], $w, $h), '</div>'; |
@@ -2940,9 +3053,10 @@ discard block |
||
2940 | 3053 | <dd> |
2941 | 3054 | <select name="easyformat" id="easyformat" onchange="document.forms.creator.time_format.value = this.options[this.selectedIndex].value;" style="margin-bottom: 4px;">'; |
2942 | 3055 | // Help the user by showing a list of common time formats. |
2943 | - foreach ($context['easy_timeformats'] as $time_format) |
|
2944 | - echo ' |
|
3056 | + foreach ($context['easy_timeformats'] as $time_format) { |
|
3057 | + echo ' |
|
2945 | 3058 | <option value="', $time_format['format'], '"', $time_format['format'] == $context['member']['time_format'] ? ' selected' : '', '>', $time_format['title'], '</option>'; |
3059 | + } |
|
2946 | 3060 | echo ' |
2947 | 3061 | </select><br> |
2948 | 3062 | <input type="text" name="time_format" id="time_format" value="', $context['member']['time_format'], '" size="30"> |
@@ -2978,9 +3092,10 @@ discard block |
||
2978 | 3092 | </dt> |
2979 | 3093 | <dd> |
2980 | 3094 | <select name="smiley_set" id="smiley_set" onchange="document.getElementById(\'smileypr\').src = this.selectedIndex == 0 ? \'', $settings['images_url'], '/blank.png\' : \'', $modSettings['smileys_url'], '/\' + (this.selectedIndex != 1 ? this.options[this.selectedIndex].value : \'', !empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'], '\') + \'/smiley.gif\';">'; |
2981 | - foreach ($context['smiley_sets'] as $set) |
|
2982 | - echo ' |
|
3095 | + foreach ($context['smiley_sets'] as $set) { |
|
3096 | + echo ' |
|
2983 | 3097 | <option value="', $set['id'], '"', $set['selected'] ? ' selected' : '', '>', $set['name'], '</option>'; |
3098 | + } |
|
2984 | 3099 | echo ' |
2985 | 3100 | </select> <img id="smileypr" class="centericon" src="', $context['member']['smiley_set']['id'] != 'none' ? $modSettings['smileys_url'] . '/' . ($context['member']['smiley_set']['id'] != '' ? $context['member']['smiley_set']['id'] : (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'])) . '/smiley.gif' : $settings['images_url'] . '/blank.png', '" alt=":)" style="padding-left: 20px;"> |
2986 | 3101 | </dd>'; |
@@ -3031,10 +3146,11 @@ discard block |
||
3031 | 3146 | </div> |
3032 | 3147 | <div class="clear"></div>'; |
3033 | 3148 | |
3034 | - if (!empty($context['from_ajax'])) |
|
3035 | - echo ' |
|
3149 | + if (!empty($context['from_ajax'])) { |
|
3150 | + echo ' |
|
3036 | 3151 | <br> |
3037 | 3152 | <a href="javascript:self.close();"></a>'; |
3153 | + } |
|
3038 | 3154 | |
3039 | 3155 | echo ' |
3040 | 3156 | </div> |
@@ -3073,15 +3189,16 @@ discard block |
||
3073 | 3189 | <br><div class="smalltext">', $txt['tfa_profile_desc'], '</div> |
3074 | 3190 | </dt> |
3075 | 3191 | <dd>'; |
3076 | - if (!$context['tfa_enabled'] && $context['user']['is_owner']) |
|
3077 | - echo ' |
|
3192 | + if (!$context['tfa_enabled'] && $context['user']['is_owner']) { |
|
3193 | + echo ' |
|
3078 | 3194 | <a href="', !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl, '?action=profile;area=tfasetup" id="enable_tfa">', $txt['tfa_profile_enable'], '</a>'; |
3079 | - elseif (!$context['tfa_enabled']) |
|
3080 | - echo ' |
|
3195 | + } elseif (!$context['tfa_enabled']) { |
|
3196 | + echo ' |
|
3081 | 3197 | ', $txt['tfa_profile_disabled']; |
3082 | - else |
|
3083 | - echo ' |
|
3198 | + } else { |
|
3199 | + echo ' |
|
3084 | 3200 | ', sprintf($txt['tfa_profile_enabled'], $scripturl . '?action=profile;u=' . $context['id_member'] . ';area=tfasetup;disable'); |
3201 | + } |
|
3085 | 3202 | echo ' |
3086 | 3203 | </dd>'; |
3087 | 3204 | } |
@@ -21,8 +21,8 @@ discard block |
||
21 | 21 | <div id="personal_messages">'; |
22 | 22 | |
23 | 23 | // Show the capacity bar, if available. |
24 | - if (!empty($context['limit_bar'])) |
|
25 | - echo ' |
|
24 | + if (!empty($context['limit_bar'])) { |
|
25 | + echo ' |
|
26 | 26 | <div class="cat_bar"> |
27 | 27 | <h3 class="catbg"> |
28 | 28 | <span class="floatleft">', $txt['pm_capacity'], ':</span> |
@@ -32,14 +32,16 @@ discard block |
||
32 | 32 | <span class="floatright', $context['limit_bar']['percent'] > 90 ? ' alert' : '', '">', $context['limit_bar']['text'], '</span> |
33 | 33 | </h3> |
34 | 34 | </div>'; |
35 | + } |
|
35 | 36 | |
36 | 37 | // Message sent? Show a small indication. |
37 | - if (isset($context['pm_sent'])) |
|
38 | - echo ' |
|
38 | + if (isset($context['pm_sent'])) { |
|
39 | + echo ' |
|
39 | 40 | <div class="infobox"> |
40 | 41 | ', $txt['pm_sent'], ' |
41 | 42 | </div>'; |
42 | -} |
|
43 | + } |
|
44 | + } |
|
43 | 45 | |
44 | 46 | /** |
45 | 47 | * Just the end of the index bar, nothing special. |
@@ -72,8 +74,7 @@ discard block |
||
72 | 74 | { |
73 | 75 | echo ' |
74 | 76 | <div class="no_unread">', $txt['pm_no_unread'], '</div>'; |
75 | - } |
|
76 | - else |
|
77 | + } else |
|
77 | 78 | { |
78 | 79 | foreach ($context['unread_pms'] as $id_pm => $pm_details) |
79 | 80 | { |
@@ -193,14 +194,15 @@ discard block |
||
193 | 194 | if ($context['get_pmessage']('message', true)) |
194 | 195 | { |
195 | 196 | // Show the helpful titlebar - generally. |
196 | - if ($context['display_mode'] != 1) |
|
197 | - echo ' |
|
197 | + if ($context['display_mode'] != 1) { |
|
198 | + echo ' |
|
198 | 199 | <div class="cat_bar"> |
199 | 200 | <h3 class="catbg"> |
200 | 201 | <span id="author">', $txt['author'], '</span> |
201 | 202 | <span id="topic_title">', $txt[$context['display_mode'] == 0 ? 'messages' : 'conversation'], '</span> |
202 | 203 | </h3> |
203 | 204 | </div>'; |
205 | + } |
|
204 | 206 | |
205 | 207 | // Show a few buttons if we are in conversation mode and outputting the first message. |
206 | 208 | if ($context['display_mode'] == 2) |
@@ -229,9 +231,10 @@ discard block |
||
229 | 231 | <div class="custom_fields_above_member"> |
230 | 232 | <ul class="nolist">'; |
231 | 233 | |
232 | - foreach ($message['custom_fields']['above_member'] as $custom) |
|
233 | - echo ' |
|
234 | + foreach ($message['custom_fields']['above_member'] as $custom) { |
|
235 | + echo ' |
|
234 | 236 | <li class="custom ', $custom['col_name'] ,'">', $custom['value'], '</li>'; |
237 | + } |
|
235 | 238 | |
236 | 239 | echo ' |
237 | 240 | </ul> |
@@ -243,9 +246,10 @@ discard block |
||
243 | 246 | <a id="msg', $message['id'], '"></a>'; |
244 | 247 | |
245 | 248 | // Show online and offline buttons? |
246 | - if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) |
|
247 | - echo ' |
|
249 | + if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) { |
|
250 | + echo ' |
|
248 | 251 | <span class="' . ($message['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $message['member']['online']['text'] . '"></span>'; |
252 | + } |
|
249 | 253 | |
250 | 254 | // Show a link to the member's profile (but only if the sender isn't a guest). |
251 | 255 | echo ' |
@@ -258,48 +262,56 @@ discard block |
||
258 | 262 | <ul class="user_info">'; |
259 | 263 | |
260 | 264 | // Show the user's avatar. |
261 | - if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) |
|
262 | - echo ' |
|
265 | + if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) { |
|
266 | + echo ' |
|
263 | 267 | <li class="avatar"> |
264 | 268 | <a href="', $scripturl, '?action=profile;u=', $message['member']['id'], '">', $message['member']['avatar']['image'], '</a> |
265 | 269 | </li>'; |
270 | + } |
|
266 | 271 | |
267 | 272 | // Are there any custom fields below the avatar? |
268 | - if (!empty($message['custom_fields']['below_avatar'])) |
|
269 | - foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
273 | + if (!empty($message['custom_fields']['below_avatar'])) { |
|
274 | + foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
270 | 275 | echo ' |
271 | 276 | <li class="custom ', $custom['col_name'] ,'">', $custom['value'], '</li>'; |
277 | + } |
|
272 | 278 | |
273 | - if (!$message['member']['is_guest']) |
|
274 | - echo ' |
|
279 | + if (!$message['member']['is_guest']) { |
|
280 | + echo ' |
|
275 | 281 | <li class="icons">', $message['member']['group_icons'], '</li>'; |
282 | + } |
|
276 | 283 | // Show the member's primary group (like 'Administrator') if they have one. |
277 | - if (isset($message['member']['group']) && $message['member']['group'] != '') |
|
278 | - echo ' |
|
284 | + if (isset($message['member']['group']) && $message['member']['group'] != '') { |
|
285 | + echo ' |
|
279 | 286 | <li class="membergroup">', $message['member']['group'], '</li>'; |
287 | + } |
|
280 | 288 | |
281 | 289 | // Show the member's custom title, if they have one. |
282 | - if (isset($message['member']['title']) && $message['member']['title'] != '') |
|
283 | - echo ' |
|
290 | + if (isset($message['member']['title']) && $message['member']['title'] != '') { |
|
291 | + echo ' |
|
284 | 292 | <li class="title">', $message['member']['title'], '</li>'; |
293 | + } |
|
285 | 294 | |
286 | 295 | // Don't show these things for guests. |
287 | 296 | if (!$message['member']['is_guest']) |
288 | 297 | { |
289 | 298 | // Show the post group if and only if they have no other group or the option is on, and they are in a post group. |
290 | - if ((empty($modSettings['hide_post_group']) || $message['member']['group'] == '') && $message['member']['post_group'] != '') |
|
291 | - echo ' |
|
299 | + if ((empty($modSettings['hide_post_group']) || $message['member']['group'] == '') && $message['member']['post_group'] != '') { |
|
300 | + echo ' |
|
292 | 301 | <li class="postgroup">', $message['member']['post_group'], '</li>'; |
302 | + } |
|
293 | 303 | |
294 | 304 | // Show how many posts they have made. |
295 | - if (!isset($context['disabled_fields']['posts'])) |
|
296 | - echo ' |
|
305 | + if (!isset($context['disabled_fields']['posts'])) { |
|
306 | + echo ' |
|
297 | 307 | <li class="postcount">', $txt['member_postcount'], ': ', $message['member']['posts'], '</li>'; |
308 | + } |
|
298 | 309 | |
299 | 310 | // Show their personal text? |
300 | - if (!empty($modSettings['show_blurb']) && $message['member']['blurb'] != '') |
|
301 | - echo ' |
|
311 | + if (!empty($modSettings['show_blurb']) && $message['member']['blurb'] != '') { |
|
312 | + echo ' |
|
302 | 313 | <li class="blurb">', $message['member']['blurb'], '</li>'; |
314 | + } |
|
303 | 315 | |
304 | 316 | // Any custom fields to show as icons? |
305 | 317 | if (!empty($message['custom_fields']['icons'])) |
@@ -308,9 +320,10 @@ discard block |
||
308 | 320 | <li class="im_icons"> |
309 | 321 | <ol>'; |
310 | 322 | |
311 | - foreach ($message['custom_fields']['icons'] as $custom) |
|
312 | - echo ' |
|
323 | + foreach ($message['custom_fields']['icons'] as $custom) { |
|
324 | + echo ' |
|
313 | 325 | <li class="custom ', $custom['col_name'] ,'">', $custom['value'], '</li>'; |
326 | + } |
|
314 | 327 | |
315 | 328 | echo ' |
316 | 329 | </ol> |
@@ -318,19 +331,22 @@ discard block |
||
318 | 331 | } |
319 | 332 | |
320 | 333 | // Show the IP to this user for this post - because you can moderate? |
321 | - if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) |
|
322 | - echo ' |
|
334 | + if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) { |
|
335 | + echo ' |
|
323 | 336 | <li class="poster_ip"><a href="', $scripturl, '?action=', !empty($message['member']['is_guest']) ? 'trackip' : 'profile;area=tracking;sa=ip;u=' . $message['member']['id'], ';searchip=', $message['member']['ip'], '">', $message['member']['ip'], '</a> <a href="', $scripturl, '?action=helpadmin;help=see_admin_ip" onclick="return reqOverlayDiv(this.href);" class="help">(?)</a></li>'; |
337 | + } |
|
324 | 338 | |
325 | 339 | // Or, should we show it because this is you? |
326 | - elseif ($message['can_see_ip']) |
|
327 | - echo ' |
|
340 | + elseif ($message['can_see_ip']) { |
|
341 | + echo ' |
|
328 | 342 | <li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $message['member']['ip'], '</a></li>'; |
343 | + } |
|
329 | 344 | |
330 | 345 | // Okay, you are logged in, then we can show something about why IPs are logged... |
331 | - else |
|
332 | - echo ' |
|
346 | + else { |
|
347 | + echo ' |
|
333 | 348 | <li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $txt['logged'], '</a></li>'; |
349 | + } |
|
334 | 350 | |
335 | 351 | // Show the profile, website, email address, and personal message buttons. |
336 | 352 | if ($message['member']['show_profile_buttons']) |
@@ -340,24 +356,28 @@ discard block |
||
340 | 356 | <ol class="profile_icons">'; |
341 | 357 | |
342 | 358 | // Show the profile button |
343 | - if ($message['member']['can_view_profile']) |
|
344 | - echo ' |
|
359 | + if ($message['member']['can_view_profile']) { |
|
360 | + echo ' |
|
345 | 361 | <li><a href="', $message['member']['href'], '">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/icons/profile_sm.png" alt="' . $txt['view_profile'] . '" title="' . $txt['view_profile'] . '">' : $txt['view_profile']), '</a></li>'; |
362 | + } |
|
346 | 363 | |
347 | 364 | // Don't show an icon if they haven't specified a website. |
348 | - if ($message['member']['website']['url'] != '' && !isset($context['disabled_fields']['website'])) |
|
349 | - echo ' |
|
365 | + if ($message['member']['website']['url'] != '' && !isset($context['disabled_fields']['website'])) { |
|
366 | + echo ' |
|
350 | 367 | <li><a href="', $message['member']['website']['url'], '" title="' . $message['member']['website']['title'] . '" target="_blank">', ($settings['use_image_buttons'] ? '<span class="generic_icons www centericon" title="' . $message['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
368 | + } |
|
351 | 369 | |
352 | 370 | // Don't show the email address if they want it hidden. |
353 | - if ($message['member']['show_email']) |
|
354 | - echo ' |
|
371 | + if ($message['member']['show_email']) { |
|
372 | + echo ' |
|
355 | 373 | <li><a href="mailto:', $message['member']['email'], '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>'; |
374 | + } |
|
356 | 375 | |
357 | 376 | // Since we know this person isn't a guest, you *can* message them. |
358 | - if ($context['can_send_pm']) |
|
359 | - echo ' |
|
377 | + if ($context['can_send_pm']) { |
|
378 | + echo ' |
|
360 | 379 | <li><a href="', $scripturl, '?action=pm;sa=send;u=', $message['member']['id'], '" title="', $message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline'], '">', $settings['use_image_buttons'] ? '<span class="generic_icons im_' . ($message['member']['online']['is_online'] ? 'on' : 'off') . ' centericon" title="' . ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']) . '"></span> ' : ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']), '</a></li>'; |
380 | + } |
|
361 | 381 | |
362 | 382 | echo ' |
363 | 383 | </ol> |
@@ -365,21 +385,24 @@ discard block |
||
365 | 385 | } |
366 | 386 | |
367 | 387 | // Any custom fields for standard placement? |
368 | - if (!empty($message['custom_fields']['standard'])) |
|
369 | - foreach ($message['custom_fields']['standard'] as $custom) |
|
388 | + if (!empty($message['custom_fields']['standard'])) { |
|
389 | + foreach ($message['custom_fields']['standard'] as $custom) |
|
370 | 390 | echo ' |
371 | 391 | <li class="custom ', $custom['col_name'] ,'">', $custom['title'], ': ', $custom['value'], '</li>'; |
392 | + } |
|
372 | 393 | |
373 | 394 | // Are we showing the warning status? |
374 | - if ($message['member']['can_see_warning']) |
|
375 | - echo ' |
|
395 | + if ($message['member']['can_see_warning']) { |
|
396 | + echo ' |
|
376 | 397 | <li class="warning">', $context['can_issue_warning'] ? '<a href="' . $scripturl . '?action=profile;area=issuewarning;u=' . $message['member']['id'] . '">' : '', '<span class="generic_icons warning_', $message['member']['warning_status'], '"></span>', $context['can_issue_warning'] ? '</a>' : '', '<span class="warn_', $message['member']['warning_status'], '">', $txt['warn_' . $message['member']['warning_status']], '</span></li>'; |
398 | + } |
|
377 | 399 | |
378 | 400 | // Are there any custom fields to show at the bottom of the poster info? |
379 | - if (!empty($message['custom_fields']['bottom_poster'])) |
|
380 | - foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
401 | + if (!empty($message['custom_fields']['bottom_poster'])) { |
|
402 | + foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
381 | 403 | echo ' |
382 | 404 | <li class="custom ', $custom['col_name'] ,'">', $custom['value'], '</li>'; |
405 | + } |
|
383 | 406 | } |
384 | 407 | |
385 | 408 | // Done with the information about the poster... on to the post itself. |
@@ -398,24 +421,28 @@ discard block |
||
398 | 421 | <span class="smalltext">« <strong> ', $txt['sent_to'], ':</strong> '; |
399 | 422 | |
400 | 423 | // People it was sent directly to.... |
401 | - if (!empty($message['recipients']['to'])) |
|
402 | - echo implode(', ', $message['recipients']['to']); |
|
424 | + if (!empty($message['recipients']['to'])) { |
|
425 | + echo implode(', ', $message['recipients']['to']); |
|
426 | + } |
|
403 | 427 | // Otherwise, we're just going to say "some people"... |
404 | - elseif ($context['folder'] != 'sent') |
|
405 | - echo '(', $txt['pm_undisclosed_recipients'], ')'; |
|
428 | + elseif ($context['folder'] != 'sent') { |
|
429 | + echo '(', $txt['pm_undisclosed_recipients'], ')'; |
|
430 | + } |
|
406 | 431 | |
407 | 432 | echo ' |
408 | 433 | <strong> ', $txt['on'], ':</strong> ', $message['time'], ' » |
409 | 434 | </span>'; |
410 | 435 | |
411 | 436 | // If we're in the sent items, show who it was sent to besides the "To:" people. |
412 | - if (!empty($message['recipients']['bcc'])) |
|
413 | - echo ' |
|
437 | + if (!empty($message['recipients']['bcc'])) { |
|
438 | + echo ' |
|
414 | 439 | <br><span class="smalltext">« <strong> ', $txt['pm_bcc'], ':</strong> ', implode(', ', $message['recipients']['bcc']), ' »</span>'; |
440 | + } |
|
415 | 441 | |
416 | - if (!empty($message['is_replied_to'])) |
|
417 | - echo ' |
|
442 | + if (!empty($message['is_replied_to'])) { |
|
443 | + echo ' |
|
418 | 444 | <br><span class="smalltext">« ', $context['folder'] == 'sent' ? $txt['pm_sent_is_replied_to'] : $txt['pm_is_replied_to'], ' »</span>'; |
445 | + } |
|
419 | 446 | |
420 | 447 | echo ' |
421 | 448 | </div> |
@@ -423,13 +450,15 @@ discard block |
||
423 | 450 | <div class="post"> |
424 | 451 | <div class="inner" id="msg_', $message['id'], '"', '>', $message['body'], '</div>'; |
425 | 452 | |
426 | - if ($message['can_report'] || $context['can_send_pm']) |
|
427 | - echo ' |
|
453 | + if ($message['can_report'] || $context['can_send_pm']) { |
|
454 | + echo ' |
|
428 | 455 | <div class="under_message">'; |
456 | + } |
|
429 | 457 | |
430 | - if ($message['can_report']) |
|
431 | - echo ' |
|
458 | + if ($message['can_report']) { |
|
459 | + echo ' |
|
432 | 460 | <a href="' . $scripturl . '?action=pm;sa=report;l=' . $context['current_label_id'] . ';pmsg=' . $message['id'] . '" class="floatright">' . $txt['pm_report_to_admin'] . '</a>'; |
461 | + } |
|
433 | 462 | |
434 | 463 | echo ' |
435 | 464 | <ul class="quickbuttons">'; |
@@ -441,32 +470,36 @@ discard block |
||
441 | 470 | if (!$message['member']['is_guest']) |
442 | 471 | { |
443 | 472 | // Is there than more than one recipient you can reply to? |
444 | - if ($message['number_recipients'] > 1) |
|
445 | - echo ' |
|
473 | + if ($message['number_recipients'] > 1) { |
|
474 | + echo ' |
|
446 | 475 | <li><a href="', $scripturl, '?action=pm;sa=send;f=', $context['folder'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';pmsg=', $message['id'], ';quote;u=all"><span class="generic_icons reply_all_button"></span>', $txt['reply_to_all'], '</a></li>'; |
476 | + } |
|
447 | 477 | |
448 | 478 | echo ' |
449 | 479 | <li><a href="', $scripturl, '?action=pm;sa=send;f=', $context['folder'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';pmsg=', $message['id'], ';u=', $message['member']['id'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li> |
450 | 480 | <li><a href="', $scripturl, '?action=pm;sa=send;f=', $context['folder'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';pmsg=', $message['id'], ';quote', $context['folder'] == 'sent' ? '' : ';u=' . $message['member']['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>'; |
451 | 481 | } |
452 | 482 | // This is for "forwarding" - even if the member is gone. |
453 | - else |
|
454 | - echo ' |
|
483 | + else { |
|
484 | + echo ' |
|
455 | 485 | <li><a href="', $scripturl, '?action=pm;sa=send;f=', $context['folder'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';pmsg=', $message['id'], ';quote"><span class="generic_icons quote"></span>', $txt['reply_quote'], '</a></li>'; |
486 | + } |
|
456 | 487 | } |
457 | 488 | echo ' |
458 | 489 | <li><a href="', $scripturl, '?action=pm;sa=pmactions;pm_actions%5b', $message['id'], '%5D=delete;f=', $context['folder'], ';start=', $context['start'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', addslashes($txt['remove_message_question']), '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['delete'], '</a></li>'; |
459 | 490 | |
460 | - if (empty($context['display_mode'])) |
|
461 | - echo ' |
|
491 | + if (empty($context['display_mode'])) { |
|
492 | + echo ' |
|
462 | 493 | <li><input type="checkbox" name="pms[]" id="deletedisplay', $message['id'], '" value="', $message['id'], '" onclick="document.getElementById(\'deletelisting', $message['id'], '\').checked = this.checked;"></li>'; |
494 | + } |
|
463 | 495 | |
464 | 496 | echo ' |
465 | 497 | </ul>'; |
466 | 498 | |
467 | - if ($message['can_report'] || $context['can_send_pm']) |
|
468 | - echo ' |
|
499 | + if ($message['can_report'] || $context['can_send_pm']) { |
|
500 | + echo ' |
|
469 | 501 | </div>'; |
502 | + } |
|
470 | 503 | |
471 | 504 | // Are there any custom profile fields for above the signature? |
472 | 505 | if (!empty($message['custom_fields']['above_signature'])) |
@@ -475,9 +508,10 @@ discard block |
||
475 | 508 | <div class="custom_fields_above_signature"> |
476 | 509 | <ul class="nolist">'; |
477 | 510 | |
478 | - foreach ($message['custom_fields']['above_signature'] as $custom) |
|
479 | - echo ' |
|
511 | + foreach ($message['custom_fields']['above_signature'] as $custom) { |
|
512 | + echo ' |
|
480 | 513 | <li class="custom ', $custom['col_name'] ,'">', $custom['value'], '</li>'; |
514 | + } |
|
481 | 515 | |
482 | 516 | echo ' |
483 | 517 | </ul> |
@@ -485,9 +519,10 @@ discard block |
||
485 | 519 | } |
486 | 520 | |
487 | 521 | // Show the member's signature? |
488 | - if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) |
|
489 | - echo ' |
|
522 | + if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) { |
|
523 | + echo ' |
|
490 | 524 | <div class="signature">', $message['member']['signature'], '</div>'; |
525 | + } |
|
491 | 526 | |
492 | 527 | // Are there any custom profile fields for below the signature? |
493 | 528 | if (!empty($message['custom_fields']['below_signature'])) |
@@ -496,9 +531,10 @@ discard block |
||
496 | 531 | <div class="custom_fields_below_signature"> |
497 | 532 | <ul class="nolist">'; |
498 | 533 | |
499 | - foreach ($message['custom_fields']['below_signature'] as $custom) |
|
500 | - echo ' |
|
534 | + foreach ($message['custom_fields']['below_signature'] as $custom) { |
|
535 | + echo ' |
|
501 | 536 | <li class="custom ', $custom['col_name'] ,'">', $custom['value'], '</li>'; |
537 | + } |
|
502 | 538 | |
503 | 539 | echo ' |
504 | 540 | </ul> |
@@ -523,19 +559,21 @@ discard block |
||
523 | 559 | { |
524 | 560 | echo ' |
525 | 561 | <option value="" disabled>', $txt['pm_msg_label_apply'], ':</option>'; |
526 | - foreach ($context['labels'] as $label) |
|
527 | - if (!isset($message['labels'][$label['id']])) |
|
562 | + foreach ($context['labels'] as $label) { |
|
563 | + if (!isset($message['labels'][$label['id']])) |
|
528 | 564 | echo ' |
529 | 565 | <option value="', $label['id'], '"> ', $label['name'], '</option>'; |
566 | + } |
|
530 | 567 | } |
531 | 568 | // ... and are there any that can be removed? |
532 | 569 | if (!empty($message['labels']) && (count($message['labels']) > 1 || !isset($message['labels'][-1]))) |
533 | 570 | { |
534 | 571 | echo ' |
535 | 572 | <option value="" disabled>', $txt['pm_msg_label_remove'], ':</option>'; |
536 | - foreach ($message['labels'] as $label) |
|
537 | - echo ' |
|
573 | + foreach ($message['labels'] as $label) { |
|
574 | + echo ' |
|
538 | 575 | <option value="', $label['id'], '"> ', $label['name'], '</option>'; |
576 | + } |
|
539 | 577 | } |
540 | 578 | echo ' |
541 | 579 | </select> |
@@ -555,13 +593,14 @@ discard block |
||
555 | 593 | </div>'; |
556 | 594 | } |
557 | 595 | |
558 | - if (empty($context['display_mode'])) |
|
559 | - echo ' |
|
596 | + if (empty($context['display_mode'])) { |
|
597 | + echo ' |
|
560 | 598 | |
561 | 599 | <div class="pagesection"> |
562 | 600 | <div class="floatleft">', $context['page_index'], '</div> |
563 | 601 | <div class="floatright"><input type="submit" name="del_selected" value="', $txt['quickmod_delete_selected'], '" style="font-weight: normal;" onclick="if (!confirm(\'', $txt['delete_selected_confirm'], '\')) return false;" class="button_submit"></div> |
564 | 602 | </div>'; |
603 | + } |
|
565 | 604 | |
566 | 605 | // Show a few buttons if we are in conversation mode and outputting the first message. |
567 | 606 | elseif ($context['display_mode'] == 2 && isset($context['conversation_buttons'])) |
@@ -621,11 +660,12 @@ discard block |
||
621 | 660 | </tr> |
622 | 661 | </thead> |
623 | 662 | <tbody>'; |
624 | - if (!$context['show_delete']) |
|
625 | - echo ' |
|
663 | + if (!$context['show_delete']) { |
|
664 | + echo ' |
|
626 | 665 | <tr class="windowbg"> |
627 | 666 | <td colspan="5">', $txt['pm_alert_none'], '</td> |
628 | 667 | </tr>'; |
668 | + } |
|
629 | 669 | |
630 | 670 | while ($message = $context['get_pmessage']('subject')) |
631 | 671 | { |
@@ -678,9 +718,10 @@ discard block |
||
678 | 718 | |
679 | 719 | foreach ($context['labels'] as $label) |
680 | 720 | { |
681 | - if ($label['id'] != $context['current_label_id']) |
|
682 | - echo ' |
|
721 | + if ($label['id'] != $context['current_label_id']) { |
|
722 | + echo ' |
|
683 | 723 | <option value="add_', $label['id'], '"> ', $label['name'], '</option>'; |
724 | + } |
|
684 | 725 | } |
685 | 726 | |
686 | 727 | echo ' |
@@ -765,9 +806,10 @@ discard block |
||
765 | 806 | <dt class="between">', $txt['pm_search_post_age'], ':</dt> |
766 | 807 | <dd>', $txt['pm_search_between'], ' <input type="number" name="minage" value="', empty($context['search_params']['minage']) ? '0' : $context['search_params']['minage'], '" size="5" maxlength="5" min="0" max="9999"> ', $txt['pm_search_between_and'], ' <input type="number" name="maxage" value="', empty($context['search_params']['maxage']) ? '9999' : $context['search_params']['maxage'], '" size="5" maxlength="5" min="0" max="9999"> ', $txt['pm_search_between_days'], '</dd> |
767 | 808 | </dl>'; |
768 | - if (!$context['currently_using_labels']) |
|
769 | - echo ' |
|
809 | + if (!$context['currently_using_labels']) { |
|
810 | + echo ' |
|
770 | 811 | <input type="submit" name="pm_search" value="', $txt['pm_search_go'], '" class="button_submit">'; |
812 | + } |
|
771 | 813 | echo ' |
772 | 814 | <br class="clear_right"> |
773 | 815 | </div> |
@@ -787,12 +829,13 @@ discard block |
||
787 | 829 | <div id="advanced_panel_div"> |
788 | 830 | <ul id="searchLabelsExpand">'; |
789 | 831 | |
790 | - foreach ($context['search_labels'] as $label) |
|
791 | - echo ' |
|
832 | + foreach ($context['search_labels'] as $label) { |
|
833 | + echo ' |
|
792 | 834 | <li> |
793 | 835 | <label for="searchlabel_', $label['id'], '"><input type="checkbox" id="searchlabel_', $label['id'], '" name="searchlabel[', $label['id'], ']" value="', $label['id'], '"', $label['checked'] ? ' checked' : '', '> |
794 | 836 | ', $label['name'], '</label> |
795 | 837 | </li>'; |
838 | + } |
|
796 | 839 | |
797 | 840 | echo ' |
798 | 841 | </ul> |
@@ -852,8 +895,8 @@ discard block |
||
852 | 895 | </div>'; |
853 | 896 | |
854 | 897 | // complete results ? |
855 | - if (empty($context['search_params']['show_complete']) && !empty($context['personal_messages'])) |
|
856 | - echo ' |
|
898 | + if (empty($context['search_params']['show_complete']) && !empty($context['personal_messages'])) { |
|
899 | + echo ' |
|
857 | 900 | <table class="table_grid"> |
858 | 901 | <thead> |
859 | 902 | <tr class="title_bar"> |
@@ -863,6 +906,7 @@ discard block |
||
863 | 906 | </tr> |
864 | 907 | </thead> |
865 | 908 | <tbody>'; |
909 | + } |
|
866 | 910 | |
867 | 911 | // Print each message out... |
868 | 912 | foreach ($context['personal_messages'] as $message) |
@@ -882,11 +926,13 @@ discard block |
||
882 | 926 | |
883 | 927 | // Show the recipients. |
884 | 928 | // @todo This doesn't deal with the sent item searching quite right for bcc. |
885 | - if (!empty($message['recipients']['to'])) |
|
886 | - echo implode(', ', $message['recipients']['to']); |
|
929 | + if (!empty($message['recipients']['to'])) { |
|
930 | + echo implode(', ', $message['recipients']['to']); |
|
931 | + } |
|
887 | 932 | // Otherwise, we're just going to say "some people"... |
888 | - elseif ($context['folder'] != 'sent') |
|
889 | - echo '(', $txt['pm_undisclosed_recipients'], ')'; |
|
933 | + elseif ($context['folder'] != 'sent') { |
|
934 | + echo '(', $txt['pm_undisclosed_recipients'], ')'; |
|
935 | + } |
|
890 | 936 | |
891 | 937 | echo ' |
892 | 938 | </h3> |
@@ -900,14 +946,16 @@ discard block |
||
900 | 946 | $quote_button = create_button('quote.png', 'reply_quote', 'reply_quote', 'class="centericon"'); |
901 | 947 | $reply_button = create_button('im_reply.png', 'reply', 'reply', 'class="centericon"'); |
902 | 948 | // You can only reply if they are not a guest... |
903 | - if (!$message['member']['is_guest']) |
|
904 | - echo ' |
|
949 | + if (!$message['member']['is_guest']) { |
|
950 | + echo ' |
|
905 | 951 | <a href="', $scripturl, '?action=pm;sa=send;f=', $context['folder'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';pmsg=', $message['id'], ';quote;u=', $context['folder'] == 'sent' ? '' : $message['member']['id'], '">', $quote_button , '</a>', $context['menu_separator'], ' |
906 | 952 | <a href="', $scripturl, '?action=pm;sa=send;f=', $context['folder'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';pmsg=', $message['id'], ';u=', $message['member']['id'], '">', $reply_button , '</a> ', $context['menu_separator']; |
953 | + } |
|
907 | 954 | // This is for "forwarding" - even if the member is gone. |
908 | - else |
|
909 | - echo ' |
|
955 | + else { |
|
956 | + echo ' |
|
910 | 957 | <a href="', $scripturl, '?action=pm;sa=send;f=', $context['folder'], $context['current_label_id'] != -1 ? ';l=' . $context['current_label_id'] : '', ';pmsg=', $message['id'], ';quote">', $quote_button , '</a>', $context['menu_separator']; |
958 | + } |
|
911 | 959 | } |
912 | 960 | |
913 | 961 | echo ' |
@@ -928,17 +976,19 @@ discard block |
||
928 | 976 | } |
929 | 977 | |
930 | 978 | // Finish off the page... |
931 | - if (empty($context['search_params']['show_complete']) && !empty($context['personal_messages'])) |
|
932 | - echo ' |
|
979 | + if (empty($context['search_params']['show_complete']) && !empty($context['personal_messages'])) { |
|
980 | + echo ' |
|
933 | 981 | </tbody> |
934 | 982 | </table>'; |
983 | + } |
|
935 | 984 | |
936 | 985 | // No results? |
937 | - if (empty($context['personal_messages'])) |
|
938 | - echo ' |
|
986 | + if (empty($context['personal_messages'])) { |
|
987 | + echo ' |
|
939 | 988 | <div class="windowbg"> |
940 | 989 | <p class="centertext">', $txt['pm_search_none_found'], '</p> |
941 | 990 | </div>'; |
991 | + } |
|
942 | 992 | |
943 | 993 | echo ' |
944 | 994 | <div class="pagesection"> |
@@ -962,12 +1012,14 @@ discard block |
||
962 | 1012 | <h3 class="catbg">', $txt['pm_send_report'], '</h3> |
963 | 1013 | </div> |
964 | 1014 | <div class="windowbg">'; |
965 | - if (!empty($context['send_log']['sent'])) |
|
966 | - foreach ($context['send_log']['sent'] as $log_entry) |
|
1015 | + if (!empty($context['send_log']['sent'])) { |
|
1016 | + foreach ($context['send_log']['sent'] as $log_entry) |
|
967 | 1017 | echo '<span class="error">', $log_entry, '</span><br>'; |
968 | - if (!empty($context['send_log']['failed'])) |
|
969 | - foreach ($context['send_log']['failed'] as $log_entry) |
|
1018 | + } |
|
1019 | + if (!empty($context['send_log']['failed'])) { |
|
1020 | + foreach ($context['send_log']['failed'] as $log_entry) |
|
970 | 1021 | echo '<span class="error">', $log_entry, '</span><br>'; |
1022 | + } |
|
971 | 1023 | echo ' |
972 | 1024 | </div> |
973 | 1025 | <br>'; |
@@ -1015,12 +1067,13 @@ discard block |
||
1015 | 1067 | </dl> |
1016 | 1068 | </div>'; |
1017 | 1069 | |
1018 | - if (!empty($modSettings['drafts_pm_enabled'])) |
|
1019 | - echo ' |
|
1070 | + if (!empty($modSettings['drafts_pm_enabled'])) { |
|
1071 | + echo ' |
|
1020 | 1072 | <div id="draft_section" class="infobox"', isset($context['draft_saved']) ? '' : ' style="display: none;"', '>', |
1021 | 1073 | sprintf($txt['draft_pm_saved'], $scripturl . '?action=pm;sa=showpmdrafts'), ' |
1022 | 1074 | ', (!empty($modSettings['drafts_keep_days']) ? ' <strong>' . sprintf($txt['draft_save_warning'], $modSettings['drafts_keep_days']) . '</strong>' : ''), ' |
1023 | 1075 | </div>'; |
1076 | + } |
|
1024 | 1077 | |
1025 | 1078 | echo ' |
1026 | 1079 | <dl id="post_header">'; |
@@ -1075,9 +1128,10 @@ discard block |
||
1075 | 1128 | } |
1076 | 1129 | |
1077 | 1130 | // What about smileys? |
1078 | - if (!empty($context['smileys']['postform']) || !empty($context['smileys']['popup'])) |
|
1079 | - echo ' |
|
1131 | + if (!empty($context['smileys']['postform']) || !empty($context['smileys']['popup'])) { |
|
1132 | + echo ' |
|
1080 | 1133 | <div id="smileyBox_message"></div>'; |
1134 | + } |
|
1081 | 1135 | |
1082 | 1136 | // Show BBC buttons, smileys and textbox. |
1083 | 1137 | echo ' |
@@ -1124,10 +1178,11 @@ discard block |
||
1124 | 1178 | <dt><strong>', $txt['subject'], '</strong></dt> |
1125 | 1179 | <dd><strong>', $txt['draft_saved_on'], '</strong></dd>'; |
1126 | 1180 | |
1127 | - foreach ($context['drafts'] as $draft) |
|
1128 | - echo ' |
|
1181 | + foreach ($context['drafts'] as $draft) { |
|
1182 | + echo ' |
|
1129 | 1183 | <dt>', $draft['link'], '</dt> |
1130 | 1184 | <dd>', $draft['poster_time'], '</dd>'; |
1185 | + } |
|
1131 | 1186 | echo ' |
1132 | 1187 | </dl> |
1133 | 1188 | </div>'; |
@@ -1233,8 +1288,8 @@ discard block |
||
1233 | 1288 | }'; |
1234 | 1289 | |
1235 | 1290 | // Code for showing and hiding drafts |
1236 | - if (!empty($context['drafts'])) |
|
1237 | - echo ' |
|
1291 | + if (!empty($context['drafts'])) { |
|
1292 | + echo ' |
|
1238 | 1293 | var oSwapDraftOptions = new smc_Toggle({ |
1239 | 1294 | bToggleEnabled: true, |
1240 | 1295 | bCurrentlyCollapsed: true, |
@@ -1256,13 +1311,14 @@ discard block |
||
1256 | 1311 | } |
1257 | 1312 | ] |
1258 | 1313 | });'; |
1314 | + } |
|
1259 | 1315 | |
1260 | 1316 | echo ' |
1261 | 1317 | </script>'; |
1262 | 1318 | |
1263 | 1319 | // Show the message you're replying to. |
1264 | - if ($context['reply']) |
|
1265 | - echo ' |
|
1320 | + if ($context['reply']) { |
|
1321 | + echo ' |
|
1266 | 1322 | <br> |
1267 | 1323 | <br> |
1268 | 1324 | <div class="cat_bar"> |
@@ -1276,6 +1332,7 @@ discard block |
||
1276 | 1332 | <hr> |
1277 | 1333 | ', $context['quoted_message']['body'], ' |
1278 | 1334 | </div><br class="clear">'; |
1335 | + } |
|
1279 | 1336 | |
1280 | 1337 | echo ' |
1281 | 1338 | <script> |
@@ -1286,22 +1343,24 @@ discard block |
||
1286 | 1343 | sTextDeleteItem: \'', $txt['autosuggest_delete_item'], '\', |
1287 | 1344 | sToControlId: \'to_control\', |
1288 | 1345 | aToRecipients: ['; |
1289 | - foreach ($context['recipients']['to'] as $i => $member) |
|
1290 | - echo ' |
|
1346 | + foreach ($context['recipients']['to'] as $i => $member) { |
|
1347 | + echo ' |
|
1291 | 1348 | { |
1292 | 1349 | sItemId: ', JavaScriptEscape($member['id']), ', |
1293 | 1350 | sItemName: ', JavaScriptEscape($member['name']), ' |
1294 | 1351 | }', $i == count($context['recipients']['to']) - 1 ? '' : ','; |
1352 | + } |
|
1295 | 1353 | |
1296 | 1354 | echo ' |
1297 | 1355 | ], |
1298 | 1356 | aBccRecipients: ['; |
1299 | - foreach ($context['recipients']['bcc'] as $i => $member) |
|
1300 | - echo ' |
|
1357 | + foreach ($context['recipients']['bcc'] as $i => $member) { |
|
1358 | + echo ' |
|
1301 | 1359 | { |
1302 | 1360 | sItemId: ', JavaScriptEscape($member['id']), ', |
1303 | 1361 | sItemName: ', JavaScriptEscape($member['name']), ' |
1304 | 1362 | }', $i == count($context['recipients']['bcc']) - 1 ? '' : ','; |
1363 | + } |
|
1305 | 1364 | |
1306 | 1365 | echo ' |
1307 | 1366 | ], |
@@ -1388,26 +1447,28 @@ discard block |
||
1388 | 1447 | </th> |
1389 | 1448 | <th class="centertext table_icon">'; |
1390 | 1449 | |
1391 | - if (count($context['labels']) > 2) |
|
1392 | - echo ' |
|
1450 | + if (count($context['labels']) > 2) { |
|
1451 | + echo ' |
|
1393 | 1452 | <input type="checkbox" onclick="invertAll(this, this.form);">'; |
1453 | + } |
|
1394 | 1454 | |
1395 | 1455 | echo ' |
1396 | 1456 | </th> |
1397 | 1457 | </tr> |
1398 | 1458 | </thead> |
1399 | 1459 | <tbody>'; |
1400 | - if (count($context['labels']) < 2) |
|
1401 | - echo ' |
|
1460 | + if (count($context['labels']) < 2) { |
|
1461 | + echo ' |
|
1402 | 1462 | <tr class="windowbg"> |
1403 | 1463 | <td colspan="2">', $txt['pm_labels_no_exist'], '</td> |
1404 | 1464 | </tr>'; |
1405 | - else |
|
1465 | + } else |
|
1406 | 1466 | { |
1407 | 1467 | foreach ($context['labels'] as $label) |
1408 | 1468 | { |
1409 | - if ($label['id'] == -1) |
|
1410 | - continue; |
|
1469 | + if ($label['id'] == -1) { |
|
1470 | + continue; |
|
1471 | + } |
|
1411 | 1472 | |
1412 | 1473 | echo ' |
1413 | 1474 | <tr class="windowbg"> |
@@ -1422,12 +1483,13 @@ discard block |
||
1422 | 1483 | </tbody> |
1423 | 1484 | </table>'; |
1424 | 1485 | |
1425 | - if (!count($context['labels']) < 2) |
|
1426 | - echo ' |
|
1486 | + if (!count($context['labels']) < 2) { |
|
1487 | + echo ' |
|
1427 | 1488 | <div class="padding"> |
1428 | 1489 | <input type="submit" name="save" value="', $txt['save'], '" class="button_submit"> |
1429 | 1490 | <input type="submit" name="delete" value="', $txt['quickmod_delete_selected'], '" data-confirm="', $txt['pm_labels_delete'] ,'" class="button_submit you_sure"> |
1430 | 1491 | </div>'; |
1492 | + } |
|
1431 | 1493 | |
1432 | 1494 | echo ' |
1433 | 1495 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -1482,9 +1544,10 @@ discard block |
||
1482 | 1544 | <dd> |
1483 | 1545 | <select name="id_admin"> |
1484 | 1546 | <option value="0">', $txt['pm_report_all_admins'], '</option>'; |
1485 | - foreach ($context['admins'] as $id => $name) |
|
1486 | - echo ' |
|
1547 | + foreach ($context['admins'] as $id => $name) { |
|
1548 | + echo ' |
|
1487 | 1549 | <option value="', $id, '">', $name, '</option>'; |
1550 | + } |
|
1488 | 1551 | echo ' |
1489 | 1552 | </select> |
1490 | 1553 | </dd>'; |
@@ -1546,9 +1609,10 @@ discard block |
||
1546 | 1609 | </th> |
1547 | 1610 | <th class="centertext table_icon">'; |
1548 | 1611 | |
1549 | - if (!empty($context['rules'])) |
|
1550 | - echo ' |
|
1612 | + if (!empty($context['rules'])) { |
|
1613 | + echo ' |
|
1551 | 1614 | <input type="checkbox" onclick="invertAll(this, this.form);">'; |
1615 | + } |
|
1552 | 1616 | |
1553 | 1617 | echo ' |
1554 | 1618 | </th> |
@@ -1556,13 +1620,14 @@ discard block |
||
1556 | 1620 | </thead> |
1557 | 1621 | <tbody>'; |
1558 | 1622 | |
1559 | - if (empty($context['rules'])) |
|
1560 | - echo ' |
|
1623 | + if (empty($context['rules'])) { |
|
1624 | + echo ' |
|
1561 | 1625 | <tr class="windowbg"> |
1562 | 1626 | <td colspan="2"> |
1563 | 1627 | ', $txt['pm_rules_none'], ' |
1564 | 1628 | </td> |
1565 | 1629 | </tr>'; |
1630 | + } |
|
1566 | 1631 | |
1567 | 1632 | foreach ($context['rules'] as $rule) |
1568 | 1633 | { |
@@ -1583,14 +1648,16 @@ discard block |
||
1583 | 1648 | <div class="righttext"> |
1584 | 1649 | <a class="button_link" href="', $scripturl, '?action=pm;sa=manrules;add;rid=0">', $txt['pm_add_rule'], '</a>'; |
1585 | 1650 | |
1586 | - if (!empty($context['rules'])) |
|
1587 | - echo ' |
|
1651 | + if (!empty($context['rules'])) { |
|
1652 | + echo ' |
|
1588 | 1653 | [<a href="', $scripturl, '?action=pm;sa=manrules;apply;', $context['session_var'], '=', $context['session_id'], '" onclick="return confirm(\'', $txt['pm_js_apply_rules_confirm'], '\');">', $txt['pm_apply_rules'], '</a>]'; |
1654 | + } |
|
1589 | 1655 | |
1590 | - if (!empty($context['rules'])) |
|
1591 | - echo ' |
|
1656 | + if (!empty($context['rules'])) { |
|
1657 | + echo ' |
|
1592 | 1658 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
1593 | 1659 | <input type="submit" name="delselected" value="', $txt['pm_delete_selected_rule'], '" data-confirm="', $txt['pm_js_delete_rule_confirm'] ,'" class="button_submit smalltext you_sure">'; |
1660 | + } |
|
1594 | 1661 | |
1595 | 1662 | echo ' |
1596 | 1663 | </div> |
@@ -1612,14 +1679,16 @@ discard block |
||
1612 | 1679 | var groups = new Array() |
1613 | 1680 | var labels = new Array()'; |
1614 | 1681 | |
1615 | - foreach ($context['groups'] as $id => $title) |
|
1616 | - echo ' |
|
1682 | + foreach ($context['groups'] as $id => $title) { |
|
1683 | + echo ' |
|
1617 | 1684 | groups[', $id, '] = "', addslashes($title), '";'; |
1685 | + } |
|
1618 | 1686 | |
1619 | - foreach ($context['labels'] as $label) |
|
1620 | - if ($label['id'] != -1) |
|
1687 | + foreach ($context['labels'] as $label) { |
|
1688 | + if ($label['id'] != -1) |
|
1621 | 1689 | echo ' |
1622 | 1690 | labels[', ($label['id']), '] = "', addslashes($label['name']), '";'; |
1691 | + } |
|
1623 | 1692 | |
1624 | 1693 | echo ' |
1625 | 1694 | function addCriteriaOption() |
@@ -1634,8 +1703,9 @@ discard block |
||
1634 | 1703 | |
1635 | 1704 | setOuterHTML(document.getElementById("criteriaAddHere"), \'<br><select name="ruletype[\' + criteriaNum + \']" id="ruletype\' + criteriaNum + \'" onchange="updateRuleDef(\' + criteriaNum + \'); rebuildRuleDesc();"><option value="">', addslashes($txt['pm_rule_criteria_pick']), ':<\' + \'/option><option value="mid">', addslashes($txt['pm_rule_mid']), '<\' + \'/option><option value="gid">', addslashes($txt['pm_rule_gid']), '<\' + \'/option><option value="sub">', addslashes($txt['pm_rule_sub']), '<\' + \'/option><option value="msg">', addslashes($txt['pm_rule_msg']), '<\' + \'/option><option value="bud">', addslashes($txt['pm_rule_bud']), '<\' + \'/option><\' + \'/select> <span id="defdiv\' + criteriaNum + \'" style="display: none;"><input type="text" name="ruledef[\' + criteriaNum + \']" id="ruledef\' + criteriaNum + \'" onkeyup="rebuildRuleDesc();" value=""><\' + \'/span><span id="defseldiv\' + criteriaNum + \'" style="display: none;"><select name="ruledefgroup[\' + criteriaNum + \']" id="ruledefgroup\' + criteriaNum + \'" onchange="rebuildRuleDesc();"><option value="">', addslashes($txt['pm_rule_sel_group']), '<\' + \'/option>'; |
1636 | 1705 | |
1637 | - foreach ($context['groups'] as $id => $group) |
|
1638 | - echo '<option value="', $id, '">', strtr($group, array("'" => "\'")), '<\' + \'/option>'; |
|
1706 | + foreach ($context['groups'] as $id => $group) { |
|
1707 | + echo '<option value="', $id, '">', strtr($group, array("'" => "\'")), '<\' + \'/option>'; |
|
1708 | + } |
|
1639 | 1709 | |
1640 | 1710 | echo '<\' + \'/select><\' + \'/span><span id="criteriaAddHere"><\' + \'/span>\'); |
1641 | 1711 | } |
@@ -1652,9 +1722,10 @@ discard block |
||
1652 | 1722 | |
1653 | 1723 | setOuterHTML(document.getElementById("actionAddHere"), \'<br><select name="acttype[\' + actionNum + \']" id="acttype\' + actionNum + \'" onchange="updateActionDef(\' + actionNum + \'); rebuildRuleDesc();"><option value="">', addslashes($txt['pm_rule_sel_action']), ':<\' + \'/option><option value="lab">', addslashes($txt['pm_rule_label']), '<\' + \'/option><option value="del">', addslashes($txt['pm_rule_delete']), '<\' + \'/option><\' + \'/select> <span id="labdiv\' + actionNum + \'" style="display: none;"><select name="labdef[\' + actionNum + \']" id="labdef\' + actionNum + \'" onchange="rebuildRuleDesc();"><option value="">', addslashes($txt['pm_rule_sel_label']), '<\' + \'/option>'; |
1654 | 1724 | |
1655 | - foreach ($context['labels'] as $label) |
|
1656 | - if ($label['id'] != -1) |
|
1725 | + foreach ($context['labels'] as $label) { |
|
1726 | + if ($label['id'] != -1) |
|
1657 | 1727 | echo '<option value="', ($label['id']), '">', addslashes($label['name']), '<\' + \'/option>'; |
1728 | + } |
|
1658 | 1729 | |
1659 | 1730 | echo '<\' + \'/select><\' + \'/span><span id="actionAddHere"><\' + \'/span>\'); |
1660 | 1731 | } |
@@ -1768,18 +1839,20 @@ discard block |
||
1768 | 1839 | $isFirst = true; |
1769 | 1840 | foreach ($context['rule']['criteria'] as $k => $criteria) |
1770 | 1841 | { |
1771 | - if (!$isFirst && $criteria['t'] == '') |
|
1772 | - echo '<div id="removeonjs1">'; |
|
1773 | - elseif (!$isFirst) |
|
1774 | - echo '<br>'; |
|
1842 | + if (!$isFirst && $criteria['t'] == '') { |
|
1843 | + echo '<div id="removeonjs1">'; |
|
1844 | + } elseif (!$isFirst) { |
|
1845 | + echo '<br>'; |
|
1846 | + } |
|
1775 | 1847 | |
1776 | 1848 | echo ' |
1777 | 1849 | <select name="ruletype[', $k, ']" id="ruletype', $k, '" onchange="updateRuleDef(', $k, '); rebuildRuleDesc();"> |
1778 | 1850 | <option value="">', $txt['pm_rule_criteria_pick'], ':</option>'; |
1779 | 1851 | |
1780 | - foreach (array('mid', 'gid', 'sub', 'msg', 'bud') as $cr) |
|
1781 | - echo ' |
|
1852 | + foreach (array('mid', 'gid', 'sub', 'msg', 'bud') as $cr) { |
|
1853 | + echo ' |
|
1782 | 1854 | <option value="', $cr, '"', $criteria['t'] == $cr ? ' selected' : '', '>', $txt['pm_rule_' . $cr], '</option>'; |
1855 | + } |
|
1783 | 1856 | |
1784 | 1857 | echo ' |
1785 | 1858 | </select> |
@@ -1790,18 +1863,20 @@ discard block |
||
1790 | 1863 | <select name="ruledefgroup[', $k, ']" id="ruledefgroup', $k, '" onchange="rebuildRuleDesc();"> |
1791 | 1864 | <option value="">', $txt['pm_rule_sel_group'], '</option>'; |
1792 | 1865 | |
1793 | - foreach ($context['groups'] as $id => $group) |
|
1794 | - echo ' |
|
1866 | + foreach ($context['groups'] as $id => $group) { |
|
1867 | + echo ' |
|
1795 | 1868 | <option value="', $id, '"', $criteria['t'] == 'gid' && $criteria['v'] == $id ? ' selected' : '', '>', $group, '</option>'; |
1869 | + } |
|
1796 | 1870 | echo ' |
1797 | 1871 | </select> |
1798 | 1872 | </span>'; |
1799 | 1873 | |
1800 | 1874 | // If this is the dummy we add a means to hide for non js users. |
1801 | - if ($isFirst) |
|
1802 | - $isFirst = false; |
|
1803 | - elseif ($criteria['t'] == '') |
|
1804 | - echo '</div>'; |
|
1875 | + if ($isFirst) { |
|
1876 | + $isFirst = false; |
|
1877 | + } elseif ($criteria['t'] == '') { |
|
1878 | + echo '</div>'; |
|
1879 | + } |
|
1805 | 1880 | } |
1806 | 1881 | |
1807 | 1882 | echo ' |
@@ -1824,10 +1899,11 @@ discard block |
||
1824 | 1899 | $isFirst = true; |
1825 | 1900 | foreach ($context['rule']['actions'] as $k => $action) |
1826 | 1901 | { |
1827 | - if (!$isFirst && $action['t'] == '') |
|
1828 | - echo '<div id="removeonjs2">'; |
|
1829 | - elseif (!$isFirst) |
|
1830 | - echo '<br>'; |
|
1902 | + if (!$isFirst && $action['t'] == '') { |
|
1903 | + echo '<div id="removeonjs2">'; |
|
1904 | + } elseif (!$isFirst) { |
|
1905 | + echo '<br>'; |
|
1906 | + } |
|
1831 | 1907 | |
1832 | 1908 | echo ' |
1833 | 1909 | <select name="acttype[', $k, ']" id="acttype', $k, '" onchange="updateActionDef(', $k, '); rebuildRuleDesc();"> |
@@ -1838,20 +1914,22 @@ discard block |
||
1838 | 1914 | <span id="labdiv', $k, '"> |
1839 | 1915 | <select name="labdef[', $k, ']" id="labdef', $k, '" onchange="rebuildRuleDesc();"> |
1840 | 1916 | <option value="">', $txt['pm_rule_sel_label'], '</option>'; |
1841 | - foreach ($context['labels'] as $label) |
|
1842 | - if ($label['id'] != -1) |
|
1917 | + foreach ($context['labels'] as $label) { |
|
1918 | + if ($label['id'] != -1) |
|
1843 | 1919 | echo ' |
1844 | 1920 | <option value="', ($label['id']), '"', $action['t'] == 'lab' && $action['v'] == $label['id'] ? ' selected' : '', '>', $label['name'], '</option>'; |
1921 | + } |
|
1845 | 1922 | |
1846 | 1923 | echo ' |
1847 | 1924 | </select> |
1848 | 1925 | </span>'; |
1849 | 1926 | |
1850 | - if ($isFirst) |
|
1851 | - $isFirst = false; |
|
1852 | - elseif ($action['t'] == '') |
|
1853 | - echo ' |
|
1927 | + if ($isFirst) { |
|
1928 | + $isFirst = false; |
|
1929 | + } elseif ($action['t'] == '') { |
|
1930 | + echo ' |
|
1854 | 1931 | </div>'; |
1932 | + } |
|
1855 | 1933 | } |
1856 | 1934 | |
1857 | 1935 | echo ' |
@@ -1875,22 +1953,25 @@ discard block |
||
1875 | 1953 | echo ' |
1876 | 1954 | <script>'; |
1877 | 1955 | |
1878 | - foreach ($context['rule']['criteria'] as $k => $c) |
|
1879 | - echo ' |
|
1956 | + foreach ($context['rule']['criteria'] as $k => $c) { |
|
1957 | + echo ' |
|
1880 | 1958 | updateRuleDef(', $k, ');'; |
1959 | + } |
|
1881 | 1960 | |
1882 | - foreach ($context['rule']['actions'] as $k => $c) |
|
1883 | - echo ' |
|
1961 | + foreach ($context['rule']['actions'] as $k => $c) { |
|
1962 | + echo ' |
|
1884 | 1963 | updateActionDef(', $k, ');'; |
1964 | + } |
|
1885 | 1965 | |
1886 | 1966 | echo ' |
1887 | 1967 | rebuildRuleDesc();'; |
1888 | 1968 | |
1889 | 1969 | // If this isn't a new rule and we have JS enabled remove the JS compatibility stuff. |
1890 | - if ($context['rid']) |
|
1891 | - echo ' |
|
1970 | + if ($context['rid']) { |
|
1971 | + echo ' |
|
1892 | 1972 | document.getElementById("removeonjs1").style.display = "none"; |
1893 | 1973 | document.getElementById("removeonjs2").style.display = "none";'; |
1974 | + } |
|
1894 | 1975 | |
1895 | 1976 | echo ' |
1896 | 1977 | document.getElementById("addonjs1").style.display = ""; |
@@ -1918,12 +1999,12 @@ discard block |
||
1918 | 1999 | </div>'; |
1919 | 2000 | |
1920 | 2001 | // No drafts? Just show an informative message. |
1921 | - if (empty($context['drafts'])) |
|
1922 | - echo ' |
|
2002 | + if (empty($context['drafts'])) { |
|
2003 | + echo ' |
|
1923 | 2004 | <div class="windowbg2 centertext"> |
1924 | 2005 | ', $txt['draft_none'], ' |
1925 | 2006 | </div>'; |
1926 | - else |
|
2007 | + } else |
|
1927 | 2008 | { |
1928 | 2009 | // For every draft to be displayed, give it its own div, and show the important details of the draft. |
1929 | 2010 | foreach ($context['drafts'] as $draft) |
@@ -51,11 +51,13 @@ discard block |
||
51 | 51 | <p>'; |
52 | 52 | |
53 | 53 | // Show just numbers...? |
54 | - if ($settings['display_who_viewing'] == 1) |
|
55 | - echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members']; |
|
54 | + if ($settings['display_who_viewing'] == 1) { |
|
55 | + echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members']; |
|
56 | + } |
|
56 | 57 | // Or show the actual people viewing the topic? |
57 | - else |
|
58 | - echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
58 | + else { |
|
59 | + echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
60 | + } |
|
59 | 61 | |
60 | 62 | // Now show how many guests are here too. |
61 | 63 | echo $txt['who_and'], $context['view_num_guests'], ' ', $context['view_num_guests'] == 1 ? $txt['guest'] : $txt['guests'], $txt['who_viewing_topic'], ' |
@@ -93,10 +95,11 @@ discard block |
||
93 | 95 | <dt class="', $option['voted_this'] ? ' voted' : '', '">', $option['option'], '</dt> |
94 | 96 | <dd class="statsbar', $option['voted_this'] ? ' voted' : '', '">'; |
95 | 97 | |
96 | - if ($context['allow_results_view']) |
|
97 | - echo ' |
|
98 | + if ($context['allow_results_view']) { |
|
99 | + echo ' |
|
98 | 100 | ', $option['bar_ndt'], ' |
99 | 101 | <span class="percentage">', $option['votes'], ' (', $option['percent'], '%)</span>'; |
102 | + } |
|
100 | 103 | |
101 | 104 | echo ' |
102 | 105 | </dd>'; |
@@ -105,9 +108,10 @@ discard block |
||
105 | 108 | echo ' |
106 | 109 | </dl>'; |
107 | 110 | |
108 | - if ($context['allow_results_view']) |
|
109 | - echo ' |
|
111 | + if ($context['allow_results_view']) { |
|
112 | + echo ' |
|
110 | 113 | <p><strong>', $txt['poll_total_voters'], ':</strong> ', $context['poll']['total_votes'], '</p>'; |
114 | + } |
|
111 | 115 | } |
112 | 116 | // They are allowed to vote! Go to it! |
113 | 117 | else |
@@ -116,17 +120,19 @@ discard block |
||
116 | 120 | <form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '">'; |
117 | 121 | |
118 | 122 | // Show a warning if they are allowed more than one option. |
119 | - if ($context['poll']['allowed_warning']) |
|
120 | - echo ' |
|
123 | + if ($context['poll']['allowed_warning']) { |
|
124 | + echo ' |
|
121 | 125 | <p class="smallpadding">', $context['poll']['allowed_warning'], '</p>'; |
126 | + } |
|
122 | 127 | |
123 | 128 | echo ' |
124 | 129 | <ul class="options">'; |
125 | 130 | |
126 | 131 | // Show each option with its button - a radio likely. |
127 | - foreach ($context['poll']['options'] as $option) |
|
128 | - echo ' |
|
132 | + foreach ($context['poll']['options'] as $option) { |
|
133 | + echo ' |
|
129 | 134 | <li>', $option['vote_button'], ' <label for="', $option['id'], '">', $option['option'], '</label></li>'; |
135 | + } |
|
130 | 136 | |
131 | 137 | echo ' |
132 | 138 | </ul> |
@@ -138,9 +144,10 @@ discard block |
||
138 | 144 | } |
139 | 145 | |
140 | 146 | // Is the clock ticking? |
141 | - if (!empty($context['poll']['expire_time'])) |
|
142 | - echo ' |
|
147 | + if (!empty($context['poll']['expire_time'])) { |
|
148 | + echo ' |
|
143 | 149 | <p><strong>', ($context['poll']['is_expired'] ? $txt['poll_expired_on'] : $txt['poll_expires_on']), ':</strong> ', $context['poll']['expire_time'], '</p>'; |
150 | + } |
|
144 | 151 | |
145 | 152 | echo ' |
146 | 153 | </div> |
@@ -170,11 +177,13 @@ discard block |
||
170 | 177 | <li> |
171 | 178 | <b class="event_title"><a href="', $scripturl, '?action=calendar;event=', $event['id'], '">', $event['title'], '</a></b>'; |
172 | 179 | |
173 | - if ($event['can_edit']) |
|
174 | - echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
180 | + if ($event['can_edit']) { |
|
181 | + echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
182 | + } |
|
175 | 183 | |
176 | - if ($event['can_export']) |
|
177 | - echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
184 | + if ($event['can_export']) { |
|
185 | + echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
186 | + } |
|
178 | 187 | |
179 | 188 | echo ' |
180 | 189 | <br>'; |
@@ -182,14 +191,14 @@ discard block |
||
182 | 191 | if (!empty($event['allday'])) |
183 | 192 | { |
184 | 193 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), '</time>', ($event['start_date'] != $event['end_date']) ? ' – <time datetime="' . $event['end_iso_gmdate'] . '">' . trim($event['end_date_local']) . '</time>' : ''; |
185 | - } |
|
186 | - else |
|
194 | + } else |
|
187 | 195 | { |
188 | 196 | // Display event info relative to user's local timezone |
189 | 197 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), ', ', trim($event['start_time_local']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
190 | 198 | |
191 | - if ($event['start_date_local'] != $event['end_date_local']) |
|
192 | - echo trim($event['end_date_local']) . ', '; |
|
199 | + if ($event['start_date_local'] != $event['end_date_local']) { |
|
200 | + echo trim($event['end_date_local']) . ', '; |
|
201 | + } |
|
193 | 202 | |
194 | 203 | echo trim($event['end_time_local']); |
195 | 204 | |
@@ -198,23 +207,27 @@ discard block |
||
198 | 207 | { |
199 | 208 | echo '</time> (<time datetime="' . $event['start_iso_gmdate'] . '">'; |
200 | 209 | |
201 | - if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) |
|
202 | - echo trim($event['start_date_orig']), ', '; |
|
210 | + if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) { |
|
211 | + echo trim($event['start_date_orig']), ', '; |
|
212 | + } |
|
203 | 213 | |
204 | 214 | echo trim($event['start_time_orig']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
205 | 215 | |
206 | - if ($event['start_date_orig'] != $event['end_date_orig']) |
|
207 | - echo trim($event['end_date_orig']) . ', '; |
|
216 | + if ($event['start_date_orig'] != $event['end_date_orig']) { |
|
217 | + echo trim($event['end_date_orig']) . ', '; |
|
218 | + } |
|
208 | 219 | |
209 | 220 | echo trim($event['end_time_orig']), ' ', $event['tz_abbrev'], '</time>)'; |
210 | 221 | } |
211 | 222 | // Event is scheduled in the user's own timezone? Let 'em know, just to avoid confusion |
212 | - else |
|
213 | - echo ' ', $event['tz_abbrev'], '</time>'; |
|
223 | + else { |
|
224 | + echo ' ', $event['tz_abbrev'], '</time>'; |
|
225 | + } |
|
214 | 226 | } |
215 | 227 | |
216 | - if (!empty($event['location'])) |
|
217 | - echo '<br>', $event['location']; |
|
228 | + if (!empty($event['location'])) { |
|
229 | + echo '<br>', $event['location']; |
|
230 | + } |
|
218 | 231 | |
219 | 232 | echo ' |
220 | 233 | </li>'; |
@@ -253,8 +266,9 @@ discard block |
||
253 | 266 | $context['removableMessageIDs'] = array(); |
254 | 267 | |
255 | 268 | // Get all the messages... |
256 | - while ($message = $context['get_message']()) |
|
257 | - template_single_post($message); |
|
269 | + while ($message = $context['get_message']()) { |
|
270 | + template_single_post($message); |
|
271 | + } |
|
258 | 272 | |
259 | 273 | echo ' |
260 | 274 | </form> |
@@ -292,8 +306,9 @@ discard block |
||
292 | 306 | <div id="display_jump_to"> </div>'; |
293 | 307 | |
294 | 308 | // Show quickreply |
295 | - if ($context['can_reply']) |
|
296 | - template_quickreply(); |
|
309 | + if ($context['can_reply']) { |
|
310 | + template_quickreply(); |
|
311 | + } |
|
297 | 312 | |
298 | 313 | // User action pop on mobile screen (or actually small screen), this uses responsive css does not check mobile device. |
299 | 314 | echo ' |
@@ -306,8 +321,8 @@ discard block |
||
306 | 321 | </div>'; |
307 | 322 | |
308 | 323 | // Show the moderation button & pop only if user can moderate |
309 | - if ($context['can_moderate_forum'] || $context['user']['is_mod']) |
|
310 | - echo ' |
|
324 | + if ($context['can_moderate_forum'] || $context['user']['is_mod']) { |
|
325 | + echo ' |
|
311 | 326 | <div id="mobile_moderation" class="popup_container"> |
312 | 327 | <div class="popup_window description"> |
313 | 328 | <div class="popup_heading">', $txt['mobile_moderation'], ' |
@@ -317,6 +332,7 @@ discard block |
||
317 | 332 | </div> |
318 | 333 | </div> |
319 | 334 | </div>'; |
335 | + } |
|
320 | 336 | |
321 | 337 | echo ' |
322 | 338 | <script>'; |
@@ -440,9 +456,10 @@ discard block |
||
440 | 456 | }); |
441 | 457 | }'; |
442 | 458 | |
443 | - if (!empty($context['ignoredMsgs'])) |
|
444 | - echo ' |
|
459 | + if (!empty($context['ignoredMsgs'])) { |
|
460 | + echo ' |
|
445 | 461 | ignore_toggles([', implode(', ', $context['ignoredMsgs']), '], ', JavaScriptEscape($txt['show_ignore_user_post']), ');'; |
462 | + } |
|
446 | 463 | |
447 | 464 | echo ' |
448 | 465 | </script>'; |
@@ -459,8 +476,9 @@ discard block |
||
459 | 476 | |
460 | 477 | $ignoring = false; |
461 | 478 | |
462 | - if ($message['can_remove']) |
|
463 | - $context['removableMessageIDs'][] = $message['id']; |
|
479 | + if ($message['can_remove']) { |
|
480 | + $context['removableMessageIDs'][] = $message['id']; |
|
481 | + } |
|
464 | 482 | |
465 | 483 | // Are we ignoring this message? |
466 | 484 | if (!empty($message['is_ignored'])) |
@@ -486,9 +504,10 @@ discard block |
||
486 | 504 | <div class="custom_fields_above_member"> |
487 | 505 | <ul class="nolist">'; |
488 | 506 | |
489 | - foreach ($message['custom_fields']['above_member'] as $custom) |
|
490 | - echo ' |
|
507 | + foreach ($message['custom_fields']['above_member'] as $custom) { |
|
508 | + echo ' |
|
491 | 509 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
510 | + } |
|
492 | 511 | |
493 | 512 | echo ' |
494 | 513 | </ul> |
@@ -499,9 +518,10 @@ discard block |
||
499 | 518 | <h4>'; |
500 | 519 | |
501 | 520 | // Show online and offline buttons? |
502 | - if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) |
|
503 | - echo ' |
|
521 | + if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) { |
|
522 | + echo ' |
|
504 | 523 | ', $context['can_send_pm'] ? '<a href="' . $message['member']['online']['href'] . '" title="' . $message['member']['online']['label'] . '">' : '', '<span class="' . ($message['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $message['member']['online']['text'] . '"></span>', $context['can_send_pm'] ? '</a>' : ''; |
524 | + } |
|
505 | 525 | |
506 | 526 | |
507 | 527 | // Show a link to the member's profile. |
@@ -514,51 +534,59 @@ discard block |
||
514 | 534 | |
515 | 535 | |
516 | 536 | // Show the user's avatar. |
517 | - if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) |
|
518 | - echo ' |
|
537 | + if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) { |
|
538 | + echo ' |
|
519 | 539 | <li class="avatar"> |
520 | 540 | <a href="', $message['member']['href'], '">', $message['member']['avatar']['image'], '</a> |
521 | 541 | </li>'; |
542 | + } |
|
522 | 543 | |
523 | 544 | // Are there any custom fields below the avatar? |
524 | - if (!empty($message['custom_fields']['below_avatar'])) |
|
525 | - foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
545 | + if (!empty($message['custom_fields']['below_avatar'])) { |
|
546 | + foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
526 | 547 | echo ' |
527 | 548 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
549 | + } |
|
528 | 550 | |
529 | 551 | // Show the post group icons, but not for guests. |
530 | - if (!$message['member']['is_guest']) |
|
531 | - echo ' |
|
552 | + if (!$message['member']['is_guest']) { |
|
553 | + echo ' |
|
532 | 554 | <li class="icons">', $message['member']['group_icons'], '</li>'; |
555 | + } |
|
533 | 556 | |
534 | 557 | // Show the member's primary group (like 'Administrator') if they have one. |
535 | - if (!empty($message['member']['group'])) |
|
536 | - echo ' |
|
558 | + if (!empty($message['member']['group'])) { |
|
559 | + echo ' |
|
537 | 560 | <li class="membergroup">', $message['member']['group'], '</li>'; |
561 | + } |
|
538 | 562 | |
539 | 563 | // Show the member's custom title, if they have one. |
540 | - if (!empty($message['member']['title'])) |
|
541 | - echo ' |
|
564 | + if (!empty($message['member']['title'])) { |
|
565 | + echo ' |
|
542 | 566 | <li class="title">', $message['member']['title'], '</li>'; |
567 | + } |
|
543 | 568 | |
544 | 569 | // Don't show these things for guests. |
545 | 570 | if (!$message['member']['is_guest']) |
546 | 571 | { |
547 | 572 | |
548 | 573 | // Show the post group if and only if they have no other group or the option is on, and they are in a post group. |
549 | - if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group'])) |
|
550 | - echo ' |
|
574 | + if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group'])) { |
|
575 | + echo ' |
|
551 | 576 | <li class="postgroup">', $message['member']['post_group'], '</li>'; |
577 | + } |
|
552 | 578 | |
553 | 579 | // Show how many posts they have made. |
554 | - if (!isset($context['disabled_fields']['posts'])) |
|
555 | - echo ' |
|
580 | + if (!isset($context['disabled_fields']['posts'])) { |
|
581 | + echo ' |
|
556 | 582 | <li class="postcount">', $txt['member_postcount'], ': ', $message['member']['posts'], '</li>'; |
583 | + } |
|
557 | 584 | |
558 | 585 | // Show their personal text? |
559 | - if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb'])) |
|
560 | - echo ' |
|
586 | + if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb'])) { |
|
587 | + echo ' |
|
561 | 588 | <li class="blurb">', $message['member']['blurb'], '</li>'; |
589 | + } |
|
562 | 590 | |
563 | 591 | // Any custom fields to show as icons? |
564 | 592 | if (!empty($message['custom_fields']['icons'])) |
@@ -567,9 +595,10 @@ discard block |
||
567 | 595 | <li class="im_icons"> |
568 | 596 | <ol>'; |
569 | 597 | |
570 | - foreach ($message['custom_fields']['icons'] as $custom) |
|
571 | - echo ' |
|
598 | + foreach ($message['custom_fields']['icons'] as $custom) { |
|
599 | + echo ' |
|
572 | 600 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
601 | + } |
|
573 | 602 | |
574 | 603 | echo ' |
575 | 604 | </ol> |
@@ -584,19 +613,22 @@ discard block |
||
584 | 613 | <ol class="profile_icons">'; |
585 | 614 | |
586 | 615 | // Don't show an icon if they haven't specified a website. |
587 | - if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website'])) |
|
588 | - echo ' |
|
616 | + if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website'])) { |
|
617 | + echo ' |
|
589 | 618 | <li><a href="', $message['member']['website']['url'], '" title="' . $message['member']['website']['title'] . '" target="_blank">', ($settings['use_image_buttons'] ? '<span class="generic_icons www centericon" title="' . $message['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
619 | + } |
|
590 | 620 | |
591 | 621 | // Since we know this person isn't a guest, you *can* message them. |
592 | - if ($context['can_send_pm']) |
|
593 | - echo ' |
|
622 | + if ($context['can_send_pm']) { |
|
623 | + echo ' |
|
594 | 624 | <li><a href="', $scripturl, '?action=pm;sa=send;u=', $message['member']['id'], '" title="', $message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline'], '">', $settings['use_image_buttons'] ? '<span class="generic_icons im_' . ($message['member']['online']['is_online'] ? 'on' : 'off') . ' centericon" title="' . ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']) . '"></span> ' : ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']), '</a></li>'; |
625 | + } |
|
595 | 626 | |
596 | 627 | // Show the email if necessary |
597 | - if (!empty($message['member']['email']) && $message['member']['show_email']) |
|
598 | - echo ' |
|
628 | + if (!empty($message['member']['email']) && $message['member']['show_email']) { |
|
629 | + echo ' |
|
599 | 630 | <li class="email"><a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>'; |
631 | + } |
|
600 | 632 | |
601 | 633 | echo ' |
602 | 634 | </ol> |
@@ -604,48 +636,56 @@ discard block |
||
604 | 636 | } |
605 | 637 | |
606 | 638 | // Any custom fields for standard placement? |
607 | - if (!empty($message['custom_fields']['standard'])) |
|
608 | - foreach ($message['custom_fields']['standard'] as $custom) |
|
639 | + if (!empty($message['custom_fields']['standard'])) { |
|
640 | + foreach ($message['custom_fields']['standard'] as $custom) |
|
609 | 641 | echo ' |
610 | 642 | <li class="custom ', $custom['col_name'], '">', $custom['title'], ': ', $custom['value'], '</li>'; |
643 | + } |
|
611 | 644 | |
612 | 645 | } |
613 | 646 | // Otherwise, show the guest's email. |
614 | - elseif (!empty($message['member']['email']) && $message['member']['show_email']) |
|
615 | - echo ' |
|
647 | + elseif (!empty($message['member']['email']) && $message['member']['show_email']) { |
|
648 | + echo ' |
|
616 | 649 | <li class="email"><a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>'; |
650 | + } |
|
617 | 651 | |
618 | 652 | // Show the IP to this user for this post - because you can moderate? |
619 | - if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) |
|
620 | - echo ' |
|
653 | + if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) { |
|
654 | + echo ' |
|
621 | 655 | <li class="poster_ip"><a href="', $scripturl, '?action=', !empty($message['member']['is_guest']) ? 'trackip' : 'profile;area=tracking;sa=ip;u=' . $message['member']['id'], ';searchip=', $message['member']['ip'], '">', $message['member']['ip'], '</a> <a href="', $scripturl, '?action=helpadmin;help=see_admin_ip" onclick="return reqOverlayDiv(this.href);" class="help">(?)</a></li>'; |
656 | + } |
|
622 | 657 | |
623 | 658 | // Or, should we show it because this is you? |
624 | - elseif ($message['can_see_ip']) |
|
625 | - echo ' |
|
659 | + elseif ($message['can_see_ip']) { |
|
660 | + echo ' |
|
626 | 661 | <li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $message['member']['ip'], '</a></li>'; |
662 | + } |
|
627 | 663 | |
628 | 664 | // Okay, are you at least logged in? Then we can show something about why IPs are logged... |
629 | - elseif (!$context['user']['is_guest']) |
|
630 | - echo ' |
|
665 | + elseif (!$context['user']['is_guest']) { |
|
666 | + echo ' |
|
631 | 667 | <li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $txt['logged'], '</a></li>'; |
668 | + } |
|
632 | 669 | |
633 | 670 | // Otherwise, you see NOTHING! |
634 | - else |
|
635 | - echo ' |
|
671 | + else { |
|
672 | + echo ' |
|
636 | 673 | <li class="poster_ip">', $txt['logged'], '</li>'; |
674 | + } |
|
637 | 675 | |
638 | 676 | // Are we showing the warning status? |
639 | 677 | // Don't show these things for guests. |
640 | - if (!$message['member']['is_guest'] && $message['member']['can_see_warning']) |
|
641 | - echo ' |
|
678 | + if (!$message['member']['is_guest'] && $message['member']['can_see_warning']) { |
|
679 | + echo ' |
|
642 | 680 | <li class="warning">', $context['can_issue_warning'] ? '<a href="' . $scripturl . '?action=profile;area=issuewarning;u=' . $message['member']['id'] . '">' : '', '<span class="generic_icons warning_', $message['member']['warning_status'], '"></span> ', $context['can_issue_warning'] ? '</a>' : '', '<span class="warn_', $message['member']['warning_status'], '">', $txt['warn_' . $message['member']['warning_status']], '</span></li>'; |
681 | + } |
|
643 | 682 | |
644 | 683 | // Are there any custom fields to show at the bottom of the poster info? |
645 | - if (!empty($message['custom_fields']['bottom_poster'])) |
|
646 | - foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
684 | + if (!empty($message['custom_fields']['bottom_poster'])) { |
|
685 | + foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
647 | 686 | echo ' |
648 | 687 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
688 | + } |
|
649 | 689 | |
650 | 690 | // Poster info ends. |
651 | 691 | echo ' |
@@ -674,9 +714,10 @@ discard block |
||
674 | 714 | echo ' |
675 | 715 | <span class="smalltext modified floatright', !empty($modSettings['show_modify']) && !empty($message['modified']['name']) ? ' mvisible' : '','" id="modified_', $message['id'], '">'; |
676 | 716 | |
677 | - if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) |
|
678 | - echo |
|
717 | + if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) { |
|
718 | + echo |
|
679 | 719 | $message['modified']['last_edit_text']; |
720 | + } |
|
680 | 721 | |
681 | 722 | echo ' |
682 | 723 | </span> |
@@ -685,22 +726,24 @@ discard block |
||
685 | 726 | </div>'; |
686 | 727 | |
687 | 728 | // Ignoring this user? Hide the post. |
688 | - if ($ignoring) |
|
689 | - echo ' |
|
729 | + if ($ignoring) { |
|
730 | + echo ' |
|
690 | 731 | <div id="msg_', $message['id'], '_ignored_prompt"> |
691 | 732 | ', $txt['ignoring_user'], ' |
692 | 733 | <a href="#" id="msg_', $message['id'], '_ignored_link" style="display: none;">', $txt['show_ignore_user_post'], '</a> |
693 | 734 | </div>'; |
735 | + } |
|
694 | 736 | |
695 | 737 | // Show the post itself, finally! |
696 | 738 | echo ' |
697 | 739 | <div class="post">'; |
698 | 740 | |
699 | - if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id']) |
|
700 | - echo ' |
|
741 | + if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id']) { |
|
742 | + echo ' |
|
701 | 743 | <div class="approve_post"> |
702 | 744 | ', $txt['post_awaiting_approval'], ' |
703 | 745 | </div>'; |
746 | + } |
|
704 | 747 | echo ' |
705 | 748 | <div class="inner" data-msgid="', $message['id'], '" id="msg_', $message['id'], '"', $ignoring ? ' style="display:none;"' : '', '>', $message['body'], '</div> |
706 | 749 | </div>'; |
@@ -717,9 +760,9 @@ discard block |
||
717 | 760 | foreach ($message['attachment'] as $attachment) |
718 | 761 | { |
719 | 762 | // Do we want this attachment to not be showed here? |
720 | - if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']])) |
|
721 | - continue; |
|
722 | - elseif (!$div_output) |
|
763 | + if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']])) { |
|
764 | + continue; |
|
765 | + } elseif (!$div_output) |
|
723 | 766 | { |
724 | 767 | $div_output = true; |
725 | 768 | |
@@ -735,9 +778,10 @@ discard block |
||
735 | 778 | <fieldset> |
736 | 779 | <legend>', $txt['attach_awaiting_approve']; |
737 | 780 | |
738 | - if ($context['can_approve']) |
|
739 | - echo ' |
|
781 | + if ($context['can_approve']) { |
|
782 | + echo ' |
|
740 | 783 | [<a href="', $scripturl, '?action=attachapprove;sa=all;mid=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve_all'], '</a>]'; |
784 | + } |
|
741 | 785 | |
742 | 786 | echo ' |
743 | 787 | </legend>'; |
@@ -751,12 +795,13 @@ discard block |
||
751 | 795 | echo ' |
752 | 796 | <div class="attachments_top">'; |
753 | 797 | |
754 | - if ($attachment['thumbnail']['has_thumb']) |
|
755 | - echo ' |
|
798 | + if ($attachment['thumbnail']['has_thumb']) { |
|
799 | + echo ' |
|
756 | 800 | <a href="', $attachment['href'], ';image" id="link_', $attachment['id'], '" onclick="', $attachment['thumbnail']['javascript'], '"><img src="', $attachment['thumbnail']['href'], '" alt="" id="thumb_', $attachment['id'], '" class="atc_img"></a>'; |
757 | - else |
|
758 | - echo ' |
|
801 | + } else { |
|
802 | + echo ' |
|
759 | 803 | <img src="' . $attachment['href'] . ';image" alt="" width="' . $attachment['width'] . '" height="' . $attachment['height'] . '" class="atc_img">'; |
804 | + } |
|
760 | 805 | |
761 | 806 | echo ' |
762 | 807 | </div>'; |
@@ -766,9 +811,10 @@ discard block |
||
766 | 811 | <div class="attachments_bot"> |
767 | 812 | <a href="' . $attachment['href'] . '"><img src="' . $settings['images_url'] . '/icons/clip.png" class="centericon" alt="*"> ' . $attachment['name'] . '</a> '; |
768 | 813 | |
769 | - if (!$attachment['is_approved'] && $context['can_approve']) |
|
770 | - echo ' |
|
814 | + if (!$attachment['is_approved'] && $context['can_approve']) { |
|
815 | + echo ' |
|
771 | 816 | [<a href="', $scripturl, '?action=attachapprove;sa=approve;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve'], '</a>] | [<a href="', $scripturl, '?action=attachapprove;sa=reject;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['delete'], '</a>] '; |
817 | + } |
|
772 | 818 | echo ' |
773 | 819 | <br>', $attachment['size'], ($attachment['is_image'] ? ', ' . $attachment['real_width'] . 'x' . $attachment['real_height'] . '<br>' . sprintf($txt['attach_viewed'], $attachment['downloads']) : '<br>' . sprintf($txt['attach_downloaded'], $attachment['downloads'])), ' |
774 | 820 | </div>'; |
@@ -777,33 +823,38 @@ discard block |
||
777 | 823 | </div>'; |
778 | 824 | |
779 | 825 | // Next attachment line ? |
780 | - if (++$i % $attachments_per_line === 0) |
|
781 | - echo ' |
|
826 | + if (++$i % $attachments_per_line === 0) { |
|
827 | + echo ' |
|
782 | 828 | <br>'; |
829 | + } |
|
783 | 830 | } |
784 | 831 | |
785 | 832 | // If we had unapproved attachments clean up. |
786 | - if ($last_approved_state == 0) |
|
787 | - echo ' |
|
833 | + if ($last_approved_state == 0) { |
|
834 | + echo ' |
|
788 | 835 | </fieldset>'; |
836 | + } |
|
789 | 837 | |
790 | 838 | // Only do this if we output a div above - otherwise it'll break things |
791 | - if ($div_output) |
|
792 | - echo ' |
|
839 | + if ($div_output) { |
|
840 | + echo ' |
|
793 | 841 | </div>'; |
842 | + } |
|
794 | 843 | } |
795 | 844 | |
796 | 845 | // And stuff below the attachments. |
797 | - if ($context['can_report_moderator'] || !empty($context['can_see_likes']) || !empty($context['can_like']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) |
|
798 | - echo ' |
|
846 | + if ($context['can_report_moderator'] || !empty($context['can_see_likes']) || !empty($context['can_like']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) { |
|
847 | + echo ' |
|
799 | 848 | <div class="under_message">'; |
849 | + } |
|
800 | 850 | |
801 | 851 | // Maybe they want to report this post to the moderator(s)? |
802 | - if ($context['can_report_moderator']) |
|
803 | - echo ' |
|
852 | + if ($context['can_report_moderator']) { |
|
853 | + echo ' |
|
804 | 854 | <ul class="floatright smalltext"> |
805 | 855 | <li class="report_link"><a href="', $scripturl, '?action=reporttm;topic=', $context['current_topic'], '.', $message['counter'], ';msg=', $message['id'], '">', $txt['report_to_mod'], '</a></li> |
806 | 856 | </ul>'; |
857 | + } |
|
807 | 858 | |
808 | 859 | // What about likes? |
809 | 860 | if (!empty($modSettings['enable_likes'])) |
@@ -844,78 +895,91 @@ discard block |
||
844 | 895 | <ul class="quickbuttons">'; |
845 | 896 | |
846 | 897 | // Can they quote? if so they can select and quote as well! |
847 | - if ($context['can_quote']) |
|
848 | - echo ' |
|
898 | + if ($context['can_quote']) { |
|
899 | + echo ' |
|
849 | 900 | <li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';last_msg=', $context['topic_last_message'], '" onclick="return oQuickReply.quote(', $message['id'], ');"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li> |
850 | 901 | <li style="display:none;" id="quoteSelected_', $message['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a></li>'; |
902 | + } |
|
851 | 903 | |
852 | 904 | // Can the user modify the contents of this post? Show the modify inline image. |
853 | - if ($message['can_modify']) |
|
854 | - echo ' |
|
905 | + if ($message['can_modify']) { |
|
906 | + echo ' |
|
855 | 907 | <li class="quick_edit"><a title="', $txt['modify_msg'], '" class="modifybutton" id="modify_button_', $message['id'], '" onclick="oQuickModify.modifyMsg(\'', $message['id'], '\', \'', !empty($modSettings['toggle_subject']), '\')"><span class="generic_icons quick_edit_button"></span>', $txt['quick_edit'], '</a></li>'; |
908 | + } |
|
856 | 909 | |
857 | - if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) |
|
858 | - echo ' |
|
910 | + if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) { |
|
911 | + echo ' |
|
859 | 912 | <li class="post_options">', $txt['post_options']; |
913 | + } |
|
860 | 914 | |
861 | 915 | echo ' |
862 | 916 | <ul>'; |
863 | 917 | |
864 | 918 | // Can the user modify the contents of this post? |
865 | - if ($message['can_modify']) |
|
866 | - echo ' |
|
919 | + if ($message['can_modify']) { |
|
920 | + echo ' |
|
867 | 921 | <li><a href="', $scripturl, '?action=post;msg=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], '"><span class="generic_icons modify_button"></span>', $txt['modify'], '</a></li>'; |
922 | + } |
|
868 | 923 | |
869 | 924 | // How about... even... remove it entirely?! |
870 | - if ($context['can_delete'] && ($context['topic_first_message'] == $message['id'])) |
|
871 | - echo ' |
|
925 | + if ($context['can_delete'] && ($context['topic_first_message'] == $message['id'])) { |
|
926 | + echo ' |
|
872 | 927 | <li><a href="', $scripturl, '?action=removetopic2;topic=', $context['current_topic'], '.', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['are_sure_remove_topic'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove_topic'], '</a></li>'; |
873 | - elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id'])) |
|
874 | - echo ' |
|
928 | + } elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id'])) { |
|
929 | + echo ' |
|
875 | 930 | <li><a href="', $scripturl, '?action=deletemsg;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message_question'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
931 | + } |
|
876 | 932 | |
877 | 933 | // What about splitting it off the rest of the topic? |
878 | - if ($context['can_split'] && !empty($context['real_num_replies'])) |
|
879 | - echo ' |
|
934 | + if ($context['can_split'] && !empty($context['real_num_replies'])) { |
|
935 | + echo ' |
|
880 | 936 | <li><a href="', $scripturl, '?action=splittopics;topic=', $context['current_topic'], '.0;at=', $message['id'], '"><span class="generic_icons split_button"></span>', $txt['split'], '</a></li>'; |
937 | + } |
|
881 | 938 | |
882 | 939 | // Can we issue a warning because of this post? Remember, we can't give guests warnings. |
883 | - if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest']) |
|
884 | - echo ' |
|
940 | + if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest']) { |
|
941 | + echo ' |
|
885 | 942 | <li><a href="', $scripturl, '?action=profile;area=issuewarning;u=', $message['member']['id'], ';msg=', $message['id'], '"><span class="generic_icons warn_button"></span>', $txt['issue_warning'], '</a></li>'; |
943 | + } |
|
886 | 944 | |
887 | 945 | // Can we restore topics? |
888 | - if ($context['can_restore_msg']) |
|
889 | - echo ' |
|
946 | + if ($context['can_restore_msg']) { |
|
947 | + echo ' |
|
890 | 948 | <li><a href="', $scripturl, '?action=restoretopic;msgs=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons restore_button"></span>', $txt['restore_message'], '</a></li>'; |
949 | + } |
|
891 | 950 | |
892 | 951 | // Maybe we can approve it, maybe we should? |
893 | - if ($message['can_approve']) |
|
894 | - echo ' |
|
952 | + if ($message['can_approve']) { |
|
953 | + echo ' |
|
895 | 954 | <li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons approve_button"></span>', $txt['approve'], '</a></li>'; |
955 | + } |
|
896 | 956 | |
897 | 957 | // Maybe we can unapprove it? |
898 | - if ($message['can_unapprove']) |
|
899 | - echo ' |
|
958 | + if ($message['can_unapprove']) { |
|
959 | + echo ' |
|
900 | 960 | <li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons unapprove_button"></span>', $txt['unapprove'], '</a></li>'; |
961 | + } |
|
901 | 962 | |
902 | 963 | echo ' |
903 | 964 | </ul> |
904 | 965 | </li>'; |
905 | 966 | |
906 | 967 | // Show a checkbox for quick moderation? |
907 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove']) |
|
908 | - echo ' |
|
968 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove']) { |
|
969 | + echo ' |
|
909 | 970 | <li style="display: none;" id="in_topic_mod_check_', $message['id'], '"></li>'; |
971 | + } |
|
910 | 972 | |
911 | - if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) |
|
912 | - echo ' |
|
973 | + if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) { |
|
974 | + echo ' |
|
913 | 975 | </ul>'; |
976 | + } |
|
914 | 977 | } |
915 | 978 | |
916 | - if ($context['can_report_moderator'] || !empty($context['can_see_likes']) || !empty($context['can_like']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) |
|
917 | - echo ' |
|
979 | + if ($context['can_report_moderator'] || !empty($context['can_see_likes']) || !empty($context['can_like']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) { |
|
980 | + echo ' |
|
918 | 981 | </div>'; |
982 | + } |
|
919 | 983 | |
920 | 984 | echo ' |
921 | 985 | </div> |
@@ -928,9 +992,10 @@ discard block |
||
928 | 992 | <div class="custom_fields_above_signature"> |
929 | 993 | <ul class="nolist">'; |
930 | 994 | |
931 | - foreach ($message['custom_fields']['above_signature'] as $custom) |
|
932 | - echo ' |
|
995 | + foreach ($message['custom_fields']['above_signature'] as $custom) { |
|
996 | + echo ' |
|
933 | 997 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
998 | + } |
|
934 | 999 | |
935 | 1000 | echo ' |
936 | 1001 | </ul> |
@@ -938,9 +1003,10 @@ discard block |
||
938 | 1003 | } |
939 | 1004 | |
940 | 1005 | // Show the member's signature? |
941 | - if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) |
|
942 | - echo ' |
|
1006 | + if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) { |
|
1007 | + echo ' |
|
943 | 1008 | <div class="signature" id="msg_', $message['id'], '_signature"', $ignoring ? ' style="display:none;"' : '', '>', $message['member']['signature'], '</div>'; |
1009 | + } |
|
944 | 1010 | |
945 | 1011 | |
946 | 1012 | // Are there any custom profile fields for below the signature? |
@@ -950,9 +1016,10 @@ discard block |
||
950 | 1016 | <div class="custom_fields_below_signature"> |
951 | 1017 | <ul class="nolist">'; |
952 | 1018 | |
953 | - foreach ($message['custom_fields']['below_signature'] as $custom) |
|
954 | - echo ' |
|
1019 | + foreach ($message['custom_fields']['below_signature'] as $custom) { |
|
1020 | + echo ' |
|
955 | 1021 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
1022 | + } |
|
956 | 1023 | |
957 | 1024 | echo ' |
958 | 1025 | </ul> |
@@ -1000,8 +1067,8 @@ discard block |
||
1000 | 1067 | <input type="hidden" name="seqnum" value="', $context['form_sequence_number'], '">'; |
1001 | 1068 | |
1002 | 1069 | // Guests just need more. |
1003 | - if ($context['user']['is_guest']) |
|
1004 | - echo ' |
|
1070 | + if ($context['user']['is_guest']) { |
|
1071 | + echo ' |
|
1005 | 1072 | <dl id="post_header"> |
1006 | 1073 | <dt> |
1007 | 1074 | ', $txt['name'], ': |
@@ -1016,6 +1083,7 @@ discard block |
||
1016 | 1083 | <input type="email" name="email" size="25" value="', $context['email'], '" tabindex="', $context['tabindex']++, '" required> |
1017 | 1084 | </dd> |
1018 | 1085 | </dl>'; |
1086 | + } |
|
1019 | 1087 | |
1020 | 1088 | echo ' |
1021 | 1089 | ', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message'), ' |
@@ -1063,8 +1131,8 @@ discard block |
||
1063 | 1131 | <br class="clear">'; |
1064 | 1132 | |
1065 | 1133 | // draft autosave available and the user has it enabled? |
1066 | - if (!empty($context['drafts_autosave'])) |
|
1067 | - echo ' |
|
1134 | + if (!empty($context['drafts_autosave'])) { |
|
1135 | + echo ' |
|
1068 | 1136 | <script> |
1069 | 1137 | var oDraftAutoSave = new smf_DraftAutoSave({ |
1070 | 1138 | sSelf: \'oDraftAutoSave\', |
@@ -1076,10 +1144,12 @@ discard block |
||
1076 | 1144 | iFreq: ', (empty($modSettings['masterAutoSaveDraftsDelay']) ? 60000 : $modSettings['masterAutoSaveDraftsDelay'] * 1000), ' |
1077 | 1145 | }); |
1078 | 1146 | </script>'; |
1147 | + } |
|
1079 | 1148 | |
1080 | - if ($context['show_spellchecking']) |
|
1081 | - echo ' |
|
1149 | + if ($context['show_spellchecking']) { |
|
1150 | + echo ' |
|
1082 | 1151 | <form action="', $scripturl, '?action=spellcheck" method="post" accept-charset="', $context['character_set'], '" name="spell_form" id="spell_form" target="spellWindow"><input type="hidden" name="spellstring" value=""></form>'; |
1152 | + } |
|
1083 | 1153 | |
1084 | 1154 | echo ' |
1085 | 1155 | <script> |
@@ -26,9 +26,10 @@ discard block |
||
26 | 26 | <div class="cat_bar"> |
27 | 27 | <h3 class="catbg"> |
28 | 28 | <span class="floatleft">', $txt['members_list'], '</span>'; |
29 | - if (!isset($context['old_search'])) |
|
30 | - echo ' |
|
29 | + if (!isset($context['old_search'])) { |
|
30 | + echo ' |
|
31 | 31 | <span class="floatright">', $context['letter_links'], '</span>'; |
32 | + } |
|
32 | 33 | echo ' |
33 | 34 | </h3> |
34 | 35 | </div>'; |
@@ -43,19 +44,22 @@ discard block |
||
43 | 44 | foreach ($context['columns'] as $key => $column) |
44 | 45 | { |
45 | 46 | // @TODO maybe find something nicer? |
46 | - if ($key == 'email_address' && !$context['can_send_email']) |
|
47 | - continue; |
|
47 | + if ($key == 'email_address' && !$context['can_send_email']) { |
|
48 | + continue; |
|
49 | + } |
|
48 | 50 | |
49 | 51 | // This is a selected column, so underline it or some such. |
50 | - if ($column['selected']) |
|
51 | - echo ' |
|
52 | + if ($column['selected']) { |
|
53 | + echo ' |
|
52 | 54 | <th scope="col" class="', $key, isset($column['class']) ? ' ' . $column['class'] : '', ' selected" style="width: auto;"' . (isset($column['colspan']) ? ' colspan="' . $column['colspan'] . '"' : '') . '> |
53 | 55 | <a href="' . $column['href'] . '" rel="nofollow">' . $column['label'] . '</a><span class="generic_icons sort_' . $context['sort_direction'] . '"></span></th>'; |
56 | + } |
|
54 | 57 | // This is just some column... show the link and be done with it. |
55 | - else |
|
56 | - echo ' |
|
58 | + else { |
|
59 | + echo ' |
|
57 | 60 | <th scope="col" class="', $key, isset($column['class']) ? ' ' . $column['class'] : '', '"', isset($column['width']) ? ' style="width: ' . $column['width'] . '"' : '', isset($column['colspan']) ? ' colspan="' . $column['colspan'] . '"' : '', '> |
58 | 61 | ', $column['link'], '</th>'; |
62 | + } |
|
59 | 63 | } |
60 | 64 | echo ' |
61 | 65 | </tr> |
@@ -74,9 +78,10 @@ discard block |
||
74 | 78 | </td> |
75 | 79 | <td class="lefttext">', $member['link'], '</td>'; |
76 | 80 | |
77 | - if (!isset($context['disabled_fields']['website'])) |
|
78 | - echo ' |
|
81 | + if (!isset($context['disabled_fields']['website'])) { |
|
82 | + echo ' |
|
79 | 83 | <td class="centertext website_url">', $member['website']['url'] != '' ? '<a href="' . $member['website']['url'] . '" target="_blank"><span class="generic_icons www" title="' . $member['website']['title'] . '"></span></a>' : '', '</td>'; |
84 | + } |
|
80 | 85 | |
81 | 86 | // Group and date. |
82 | 87 | echo ' |
@@ -89,11 +94,12 @@ discard block |
||
89 | 94 | <td class="centertext" style="white-space: nowrap; width: 15px">', $member['posts'], '</td> |
90 | 95 | <td class="centertext statsbar" style="width: 120px">'; |
91 | 96 | |
92 | - if (!empty($member['post_percent'])) |
|
93 | - echo ' |
|
97 | + if (!empty($member['post_percent'])) { |
|
98 | + echo ' |
|
94 | 99 | <div class="bar" style="width: ', $member['post_percent'] + 4, 'px;"> |
95 | 100 | <div style="width: ', $member['post_percent'], 'px;"></div> |
96 | 101 | </div>'; |
102 | + } |
|
97 | 103 | |
98 | 104 | echo ' |
99 | 105 | </td>'; |
@@ -102,9 +108,10 @@ discard block |
||
102 | 108 | // Show custom fields marked to be shown here |
103 | 109 | if (!empty($context['custom_profile_fields']['columns'])) |
104 | 110 | { |
105 | - foreach ($context['custom_profile_fields']['columns'] as $key => $column) |
|
106 | - echo ' |
|
111 | + foreach ($context['custom_profile_fields']['columns'] as $key => $column) { |
|
112 | + echo ' |
|
107 | 113 | <td class="righttext">', $member['options'][$key], '</td>'; |
114 | + } |
|
108 | 115 | } |
109 | 116 | |
110 | 117 | echo ' |
@@ -112,11 +119,12 @@ discard block |
||
112 | 119 | } |
113 | 120 | } |
114 | 121 | // No members? |
115 | - else |
|
116 | - echo ' |
|
122 | + else { |
|
123 | + echo ' |
|
117 | 124 | <tr> |
118 | 125 | <td colspan="', $context['colspan'], '" class="windowbg">', $txt['search_no_results'], '</td> |
119 | 126 | </tr>'; |
127 | + } |
|
120 | 128 | |
121 | 129 | echo ' |
122 | 130 | </tbody> |
@@ -129,9 +137,10 @@ discard block |
||
129 | 137 | <div class="pagelinks floatleft">', $context['page_index'], '</div>'; |
130 | 138 | |
131 | 139 | // If it is displaying the result of a search show a "search again" link to edit their criteria. |
132 | - if (isset($context['old_search'])) |
|
133 | - echo ' |
|
140 | + if (isset($context['old_search'])) { |
|
141 | + echo ' |
|
134 | 142 | <a class="button_link" href="', $scripturl, '?action=mlist;sa=search;search=', $context['old_search_value'], '">', $txt['mlist_search_again'], '</a>'; |
143 | + } |
|
135 | 144 | echo ' |
136 | 145 | </div> |
137 | 146 | </div>'; |
@@ -37,9 +37,10 @@ discard block |
||
37 | 37 | echo ' |
38 | 38 | <optgroup label="', $category['name'], '">'; |
39 | 39 | |
40 | - foreach ($category['boards'] as $board) |
|
41 | - echo ' |
|
40 | + foreach ($category['boards'] as $board) { |
|
41 | + echo ' |
|
42 | 42 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', $board['id'] == $context['current_board'] ? ' disabled' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level']-1) . '=> ' : '', $board['name'], '</option>'; |
43 | + } |
|
43 | 44 | echo ' |
44 | 45 | </optgroup>'; |
45 | 46 | } |
@@ -68,9 +69,10 @@ discard block |
||
68 | 69 | </div> |
69 | 70 | </div>'; |
70 | 71 | |
71 | - if ($context['back_to_topic']) |
|
72 | - echo ' |
|
72 | + if ($context['back_to_topic']) { |
|
73 | + echo ' |
|
73 | 74 | <input type="hidden" name="goback" value="1">'; |
75 | + } |
|
74 | 76 | |
75 | 77 | echo ' |
76 | 78 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -120,8 +122,7 @@ discard block |
||
120 | 122 | <option value="86400">', $txt['two_months'], '</option> |
121 | 123 | </select> |
122 | 124 | </dd>'; |
123 | - } |
|
124 | - else |
|
125 | + } else |
|
125 | 126 | { |
126 | 127 | echo ' |
127 | 128 | <input type="hidden" name="redirect_expires" value="0">'; |
@@ -217,9 +218,9 @@ discard block |
||
217 | 218 | <input type="submit" value="', $txt['go'], '" class="button_submit"> |
218 | 219 | </form>'; |
219 | 220 | |
221 | + } else { |
|
222 | + echo $txt['target_below']; |
|
220 | 223 | } |
221 | - else |
|
222 | - echo $txt['target_below']; |
|
223 | 224 | |
224 | 225 | echo ' </h4> |
225 | 226 | </div>'; |
@@ -237,12 +238,13 @@ discard block |
||
237 | 238 | |
238 | 239 | $merge_button = create_button('merge', 'merge', ''); |
239 | 240 | |
240 | - foreach ($context['topics'] as $topic) |
|
241 | - echo ' |
|
241 | + foreach ($context['topics'] as $topic) { |
|
242 | + echo ' |
|
242 | 243 | <li> |
243 | 244 | <a href="', $scripturl, '?action=mergetopics;sa=options;board=', $context['current_board'], '.0;from=', $context['origin_topic'], ';to=', $topic['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $merge_button, '</a> |
244 | 245 | <a href="', $scripturl, '?topic=', $topic['id'], '.0" target="_blank">', $topic['subject'], '</a> ', $txt['started_by'], ' ', $topic['poster']['link'], ' |
245 | 246 | </li>'; |
247 | + } |
|
246 | 248 | |
247 | 249 | echo ' |
248 | 250 | </ul> |
@@ -251,8 +253,7 @@ discard block |
||
251 | 253 | <div class="pagesection"> |
252 | 254 | ', $context['page_index'], ' |
253 | 255 | </div>'; |
254 | - } |
|
255 | - else |
|
256 | + } else |
|
256 | 257 | { |
257 | 258 | // Just a nice "There aren't any topics" message |
258 | 259 | echo ' |
@@ -306,8 +307,8 @@ discard block |
||
306 | 307 | </tr> |
307 | 308 | </thead> |
308 | 309 | <tbody>'; |
309 | - foreach ($context['topics'] as $topic) |
|
310 | - echo ' |
|
310 | + foreach ($context['topics'] as $topic) { |
|
311 | + echo ' |
|
311 | 312 | <tr class="windowbg"> |
312 | 313 | <td> |
313 | 314 | <input type="checkbox" name="topics[]" value="' . $topic['id'] . '" checked> |
@@ -327,6 +328,7 @@ discard block |
||
327 | 328 | <input type="checkbox" name="notifications[]" value="' . $topic['id'] . '" checked> |
328 | 329 | </td> |
329 | 330 | </tr>'; |
331 | + } |
|
330 | 332 | echo ' |
331 | 333 | </tbody> |
332 | 334 | </table> |
@@ -337,9 +339,10 @@ discard block |
||
337 | 339 | <fieldset id="merge_subject" class="merge_options"> |
338 | 340 | <legend>', $txt['merge_select_subject'], '</legend> |
339 | 341 | <select name="subject" onchange="this.form.custom_subject.style.display = (this.options[this.selectedIndex].value != 0) ? \'none\': \'\' ;">'; |
340 | - foreach ($context['topics'] as $topic) |
|
341 | - echo ' |
|
342 | + foreach ($context['topics'] as $topic) { |
|
343 | + echo ' |
|
342 | 344 | <option value="', $topic['id'], '"' . ($topic['selected'] ? ' selected' : '') . '>', $topic['subject'], '</option>'; |
345 | + } |
|
343 | 346 | echo ' |
344 | 347 | <option value="0">', $txt['merge_custom_subject'], ':</option> |
345 | 348 | </select> |
@@ -357,11 +360,12 @@ discard block |
||
357 | 360 | <fieldset id="merge_board" class="merge_options"> |
358 | 361 | <legend>', $txt['merge_select_target_board'], '</legend> |
359 | 362 | <ul>'; |
360 | - foreach ($context['boards'] as $board) |
|
361 | - echo ' |
|
363 | + foreach ($context['boards'] as $board) { |
|
364 | + echo ' |
|
362 | 365 | <li> |
363 | 366 | <input type="radio" name="board" value="' . $board['id'] . '"' . ($board['selected'] ? ' checked' : '') . '> ' . $board['name'] . ' |
364 | 367 | </li>'; |
368 | + } |
|
365 | 369 | echo ' |
366 | 370 | </ul> |
367 | 371 | </fieldset>'; |
@@ -372,11 +376,12 @@ discard block |
||
372 | 376 | <fieldset id="merge_poll" class="merge_options"> |
373 | 377 | <legend>' . $txt['merge_select_poll'] . '</legend> |
374 | 378 | <ul>'; |
375 | - foreach ($context['polls'] as $poll) |
|
376 | - echo ' |
|
379 | + foreach ($context['polls'] as $poll) { |
|
380 | + echo ' |
|
377 | 381 | <li> |
378 | 382 | <input type="radio" name="poll" value="' . $poll['id'] . '"' . ($poll['selected'] ? ' checked' : '') . '> ' . $poll['question'] . ' (' . $txt['topic'] . ': <a href="' . $scripturl . '?topic=' . $poll['topic']['id'] . '.0" target="_blank">' . $poll['topic']['subject'] . '</a>) |
379 | 383 | </li>'; |
384 | + } |
|
380 | 385 | echo ' |
381 | 386 | <li> |
382 | 387 | <input type="radio" name="poll" value="-1"> (' . $txt['merge_no_poll'] . ') |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Entry point for the moderation center. |
@@ -26,8 +27,9 @@ discard block |
||
26 | 27 | global $smcFunc, $txt, $context, $scripturl, $modSettings, $user_info, $sourcedir, $options; |
27 | 28 | |
28 | 29 | // Don't run this twice... and don't conflict with the admin bar. |
29 | - if (isset($context['admin_area'])) |
|
30 | - return; |
|
30 | + if (isset($context['admin_area'])) { |
|
31 | + return; |
|
32 | + } |
|
31 | 33 | |
32 | 34 | $context['can_moderate_boards'] = $user_info['mod_cache']['bq'] != '0=1'; |
33 | 35 | $context['can_moderate_groups'] = $user_info['mod_cache']['gq'] != '0=1'; |
@@ -35,8 +37,9 @@ discard block |
||
35 | 37 | $context['can_moderate_users'] = allowedTo('moderate_forum'); |
36 | 38 | |
37 | 39 | // Everyone using this area must be allowed here! |
38 | - if (!$context['can_moderate_boards'] && !$context['can_moderate_groups'] && !$context['can_moderate_approvals'] && !$context['can_moderate_users']) |
|
39 | - isAllowedTo('access_mod_center'); |
|
40 | + if (!$context['can_moderate_boards'] && !$context['can_moderate_groups'] && !$context['can_moderate_approvals'] && !$context['can_moderate_users']) { |
|
41 | + isAllowedTo('access_mod_center'); |
|
42 | + } |
|
40 | 43 | |
41 | 44 | // We're gonna want a menu of some kind. |
42 | 45 | require_once($sourcedir . '/Subs-Menu.php'); |
@@ -195,8 +198,9 @@ discard block |
||
195 | 198 | unset($moderation_areas); |
196 | 199 | |
197 | 200 | // We got something - didn't we? DIDN'T WE! |
198 | - if ($mod_include_data == false) |
|
199 | - fatal_lang_error('no_access', false); |
|
201 | + if ($mod_include_data == false) { |
|
202 | + fatal_lang_error('no_access', false); |
|
203 | + } |
|
200 | 204 | |
201 | 205 | // Retain the ID information in case required by a subaction. |
202 | 206 | $context['moderation_menu_id'] = $context['max_menu_id']; |
@@ -219,22 +223,25 @@ discard block |
||
219 | 223 | 'url' => $scripturl . '?action=moderate', |
220 | 224 | 'name' => $txt['moderation_center'], |
221 | 225 | ); |
222 | - if (isset($mod_include_data['current_area']) && $mod_include_data['current_area'] != 'index') |
|
223 | - $context['linktree'][] = array( |
|
226 | + if (isset($mod_include_data['current_area']) && $mod_include_data['current_area'] != 'index') { |
|
227 | + $context['linktree'][] = array( |
|
224 | 228 | 'url' => $scripturl . '?action=moderate;area=' . $mod_include_data['current_area'], |
225 | 229 | 'name' => $mod_include_data['label'], |
226 | 230 | ); |
227 | - if (!empty($mod_include_data['current_subsection']) && $mod_include_data['subsections'][$mod_include_data['current_subsection']][0] != $mod_include_data['label']) |
|
228 | - $context['linktree'][] = array( |
|
231 | + } |
|
232 | + if (!empty($mod_include_data['current_subsection']) && $mod_include_data['subsections'][$mod_include_data['current_subsection']][0] != $mod_include_data['label']) { |
|
233 | + $context['linktree'][] = array( |
|
229 | 234 | 'url' => $scripturl . '?action=moderate;area=' . $mod_include_data['current_area'] . ';sa=' . $mod_include_data['current_subsection'], |
230 | 235 | 'name' => $mod_include_data['subsections'][$mod_include_data['current_subsection']][0], |
231 | 236 | ); |
237 | + } |
|
232 | 238 | |
233 | 239 | // Now - finally - the bit before the encore - the main performance of course! |
234 | 240 | if (!$dont_call) |
235 | 241 | { |
236 | - if (isset($mod_include_data['file'])) |
|
237 | - require_once($sourcedir . '/' . $mod_include_data['file']); |
|
242 | + if (isset($mod_include_data['file'])) { |
|
243 | + require_once($sourcedir . '/' . $mod_include_data['file']); |
|
244 | + } |
|
238 | 245 | |
239 | 246 | call_helper($mod_include_data['function']); |
240 | 247 | } |
@@ -259,8 +266,9 @@ discard block |
||
259 | 266 | // Load what blocks the user actually can see... |
260 | 267 | $valid_blocks = array(); |
261 | 268 | |
262 | - if ($context['can_moderate_groups']) |
|
263 | - $valid_blocks['g'] = 'GroupRequests'; |
|
269 | + if ($context['can_moderate_groups']) { |
|
270 | + $valid_blocks['g'] = 'GroupRequests'; |
|
271 | + } |
|
264 | 272 | if ($context['can_moderate_boards']) |
265 | 273 | { |
266 | 274 | $valid_blocks['r'] = 'ReportedPosts'; |
@@ -269,8 +277,9 @@ discard block |
||
269 | 277 | if ($context['can_moderate_users']) |
270 | 278 | { |
271 | 279 | // This falls under the category of moderating users as well... |
272 | - if (!$context['can_moderate_boards']) |
|
273 | - $valid_blocks['w'] = 'WatchedUsers'; |
|
280 | + if (!$context['can_moderate_boards']) { |
|
281 | + $valid_blocks['w'] = 'WatchedUsers'; |
|
282 | + } |
|
274 | 283 | |
275 | 284 | $valid_blocks['rm'] = 'ReportedMembers'; |
276 | 285 | } |
@@ -281,8 +290,9 @@ discard block |
||
281 | 290 | foreach ($valid_blocks as $k => $block) |
282 | 291 | { |
283 | 292 | $block = 'ModBlock' . $block; |
284 | - if (function_exists($block)) |
|
285 | - $context['mod_blocks'][] = $block(); |
|
293 | + if (function_exists($block)) { |
|
294 | + $context['mod_blocks'][] = $block(); |
|
295 | + } |
|
286 | 296 | } |
287 | 297 | |
288 | 298 | $context['admin_prefs'] = !empty($options['admin_preferences']) ? $smcFunc['json_decode']($options['admin_preferences'], true) : array(); |
@@ -309,8 +319,9 @@ discard block |
||
309 | 319 | ) |
310 | 320 | ); |
311 | 321 | $watched_users = array(); |
312 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
313 | - $watched_users[] = $row; |
|
322 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
323 | + $watched_users[] = $row; |
|
324 | + } |
|
314 | 325 | $smcFunc['db_free_result']($request); |
315 | 326 | |
316 | 327 | cache_put_data('recent_user_watches', $watched_users, 240); |
@@ -402,8 +413,9 @@ discard block |
||
402 | 413 | $note_owner = $smcFunc['db_num_rows']($get_owner); |
403 | 414 | $smcFunc['db_free_result']($get_owner); |
404 | 415 | |
405 | - if (empty($note_owner)) |
|
406 | - fatal_lang_error('mc_notes_delete_own', false); |
|
416 | + if (empty($note_owner)) { |
|
417 | + fatal_lang_error('mc_notes_delete_own', false); |
|
418 | + } |
|
407 | 419 | } |
408 | 420 | |
409 | 421 | // Lets delete it. |
@@ -460,12 +472,14 @@ discard block |
||
460 | 472 | ) |
461 | 473 | ); |
462 | 474 | $moderator_notes = array(); |
463 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
464 | - $moderator_notes[] = $row; |
|
475 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
476 | + $moderator_notes[] = $row; |
|
477 | + } |
|
465 | 478 | $smcFunc['db_free_result']($request); |
466 | 479 | |
467 | - if ($offset == 0) |
|
468 | - cache_put_data('moderator_notes', $moderator_notes, 240); |
|
480 | + if ($offset == 0) { |
|
481 | + cache_put_data('moderator_notes', $moderator_notes, 240); |
|
482 | + } |
|
469 | 483 | } |
470 | 484 | |
471 | 485 | // Lets construct a page index. |
@@ -504,8 +518,9 @@ discard block |
||
504 | 518 | // Got the info already? |
505 | 519 | $cachekey = md5($smcFunc['json_encode']($user_info['mod_cache']['bq'])); |
506 | 520 | $context['reported_posts'] = array(); |
507 | - if ($user_info['mod_cache']['bq'] == '0=1') |
|
508 | - return 'reported_posts_block'; |
|
521 | + if ($user_info['mod_cache']['bq'] == '0=1') { |
|
522 | + return 'reported_posts_block'; |
|
523 | + } |
|
509 | 524 | |
510 | 525 | if (($reported_posts = cache_get_data('reported_posts_' . $cachekey, 90)) === null) |
511 | 526 | { |
@@ -529,8 +544,9 @@ discard block |
||
529 | 544 | ) |
530 | 545 | ); |
531 | 546 | $reported_posts = array(); |
532 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
533 | - $reported_posts[] = $row; |
|
547 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
548 | + $reported_posts[] = $row; |
|
549 | + } |
|
534 | 550 | $smcFunc['db_free_result']($request); |
535 | 551 | |
536 | 552 | // Cache it. |
@@ -568,8 +584,9 @@ discard block |
||
568 | 584 | |
569 | 585 | $context['group_requests'] = array(); |
570 | 586 | // Make sure they can even moderate someone! |
571 | - if ($user_info['mod_cache']['gq'] == '0=1') |
|
572 | - return 'group_requests_block'; |
|
587 | + if ($user_info['mod_cache']['gq'] == '0=1') { |
|
588 | + return 'group_requests_block'; |
|
589 | + } |
|
573 | 590 | |
574 | 591 | // What requests are outstanding? |
575 | 592 | $request = $smcFunc['db_query']('', ' |
@@ -618,8 +635,9 @@ discard block |
||
618 | 635 | // Got the info already? |
619 | 636 | $cachekey = md5($smcFunc['json_encode']((int) allowedTo('moderate_forum'))); |
620 | 637 | $context['reported_users'] = array(); |
621 | - if (!allowedTo('moderate_forum')) |
|
622 | - return 'reported_users_block'; |
|
638 | + if (!allowedTo('moderate_forum')) { |
|
639 | + return 'reported_users_block'; |
|
640 | + } |
|
623 | 641 | |
624 | 642 | if (($reported_users = cache_get_data('reported_users_' . $cachekey, 90)) === null) |
625 | 643 | { |
@@ -642,8 +660,9 @@ discard block |
||
642 | 660 | ) |
643 | 661 | ); |
644 | 662 | $reported_users = array(); |
645 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
646 | - $reported_users[] = $row; |
|
663 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
664 | + $reported_users[] = $row; |
|
665 | + } |
|
647 | 666 | $smcFunc['db_free_result']($request); |
648 | 667 | |
649 | 668 | // Cache it. |
@@ -742,15 +761,15 @@ discard block |
||
742 | 761 | // Time to update. |
743 | 762 | updateSettings(array('last_mod_report_action' => time())); |
744 | 763 | recountOpenReports('members'); |
745 | - } |
|
746 | - elseif (isset($_POST['close']) && isset($_POST['close_selected'])) |
|
764 | + } elseif (isset($_POST['close']) && isset($_POST['close_selected'])) |
|
747 | 765 | { |
748 | 766 | checkSession(); |
749 | 767 | |
750 | 768 | // All the ones to update... |
751 | 769 | $toClose = array(); |
752 | - foreach ($_POST['close'] as $rid) |
|
753 | - $toClose[] = (int) $rid; |
|
770 | + foreach ($_POST['close'] as $rid) { |
|
771 | + $toClose[] = (int) $rid; |
|
772 | + } |
|
754 | 773 | |
755 | 774 | if (!empty($toClose)) |
756 | 775 | { |
@@ -903,8 +922,9 @@ discard block |
||
903 | 922 | global $context, $user_info; |
904 | 923 | |
905 | 924 | // You need to be allowed to moderate groups... |
906 | - if ($user_info['mod_cache']['gq'] == '0=1') |
|
907 | - isAllowedTo('manage_membergroups'); |
|
925 | + if ($user_info['mod_cache']['gq'] == '0=1') { |
|
926 | + isAllowedTo('manage_membergroups'); |
|
927 | + } |
|
908 | 928 | |
909 | 929 | // Load the group templates. |
910 | 930 | loadTemplate('ModerationCenter'); |
@@ -915,8 +935,9 @@ discard block |
||
915 | 935 | 'view' => 'ViewGroups', |
916 | 936 | ); |
917 | 937 | |
918 | - if (!isset($_GET['sa']) || !isset($subActions[$_GET['sa']])) |
|
919 | - $_GET['sa'] = 'view'; |
|
938 | + if (!isset($_GET['sa']) || !isset($subActions[$_GET['sa']])) { |
|
939 | + $_GET['sa'] = 'view'; |
|
940 | + } |
|
920 | 941 | $context['sub_action'] = $_GET['sa']; |
921 | 942 | |
922 | 943 | // Call the relevant function. |
@@ -946,8 +967,9 @@ discard block |
||
946 | 967 | 'id_notice' => $id_notice, |
947 | 968 | ) |
948 | 969 | ); |
949 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
950 | - fatal_lang_error('no_access', false); |
|
970 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
971 | + fatal_lang_error('no_access', false); |
|
972 | + } |
|
951 | 973 | list ($context['notice_body'], $context['notice_subject']) = $smcFunc['db_fetch_row']($request); |
952 | 974 | $smcFunc['db_free_result']($request); |
953 | 975 | |
@@ -984,18 +1006,20 @@ discard block |
||
984 | 1006 | checkSession(!is_array($_REQUEST['delete']) ? 'get' : 'post'); |
985 | 1007 | |
986 | 1008 | $toDelete = array(); |
987 | - if (!is_array($_REQUEST['delete'])) |
|
988 | - $toDelete[] = (int) $_REQUEST['delete']; |
|
989 | - else |
|
990 | - foreach ($_REQUEST['delete'] as $did) |
|
1009 | + if (!is_array($_REQUEST['delete'])) { |
|
1010 | + $toDelete[] = (int) $_REQUEST['delete']; |
|
1011 | + } else { |
|
1012 | + foreach ($_REQUEST['delete'] as $did) |
|
991 | 1013 | $toDelete[] = (int) $did; |
1014 | + } |
|
992 | 1015 | |
993 | 1016 | if (!empty($toDelete)) |
994 | 1017 | { |
995 | 1018 | require_once($sourcedir . '/RemoveTopic.php'); |
996 | 1019 | // If they don't have permission we'll let it error - either way no chance of a security slip here! |
997 | - foreach ($toDelete as $did) |
|
998 | - removeMessage($did); |
|
1020 | + foreach ($toDelete as $did) { |
|
1021 | + removeMessage($did); |
|
1022 | + } |
|
999 | 1023 | } |
1000 | 1024 | } |
1001 | 1025 | |
@@ -1004,20 +1028,21 @@ discard block |
||
1004 | 1028 | { |
1005 | 1029 | $approve_query = ''; |
1006 | 1030 | $delete_boards = array(); |
1007 | - } |
|
1008 | - else |
|
1031 | + } else |
|
1009 | 1032 | { |
1010 | 1033 | // Still obey permissions! |
1011 | 1034 | $approve_boards = boardsAllowedTo('approve_posts'); |
1012 | 1035 | $delete_boards = boardsAllowedTo('delete_any'); |
1013 | 1036 | |
1014 | - if ($approve_boards == array(0)) |
|
1015 | - $approve_query = ''; |
|
1016 | - elseif (!empty($approve_boards)) |
|
1017 | - $approve_query = ' AND m.id_board IN (' . implode(',', $approve_boards) . ')'; |
|
1037 | + if ($approve_boards == array(0)) { |
|
1038 | + $approve_query = ''; |
|
1039 | + } elseif (!empty($approve_boards)) { |
|
1040 | + $approve_query = ' AND m.id_board IN (' . implode(',', $approve_boards) . ')'; |
|
1041 | + } |
|
1018 | 1042 | // Nada, zip, etc... |
1019 | - else |
|
1020 | - $approve_query = ' AND 1=0'; |
|
1043 | + else { |
|
1044 | + $approve_query = ' AND 1=0'; |
|
1045 | + } |
|
1021 | 1046 | } |
1022 | 1047 | |
1023 | 1048 | require_once($sourcedir . '/Subs-List.php'); |
@@ -1116,10 +1141,11 @@ discard block |
||
1116 | 1141 | 'data' => array( |
1117 | 1142 | 'function' => function($member) use ($scripturl) |
1118 | 1143 | { |
1119 | - if ($member['last_post_id']) |
|
1120 | - return '<a href="' . $scripturl . '?msg=' . $member['last_post_id'] . '">' . $member['last_post'] . '</a>'; |
|
1121 | - else |
|
1122 | - return $member['last_post']; |
|
1144 | + if ($member['last_post_id']) { |
|
1145 | + return '<a href="' . $scripturl . '?msg=' . $member['last_post_id'] . '">' . $member['last_post'] . '</a>'; |
|
1146 | + } else { |
|
1147 | + return $member['last_post']; |
|
1148 | + } |
|
1123 | 1149 | }, |
1124 | 1150 | ), |
1125 | 1151 | ), |
@@ -1247,8 +1273,9 @@ discard block |
||
1247 | 1273 | ) |
1248 | 1274 | ); |
1249 | 1275 | $latest_posts = array(); |
1250 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1251 | - $latest_posts[$row['id_member']] = $row['last_post_id']; |
|
1276 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1277 | + $latest_posts[$row['id_member']] = $row['last_post_id']; |
|
1278 | + } |
|
1252 | 1279 | |
1253 | 1280 | if (!empty($latest_posts)) |
1254 | 1281 | { |
@@ -1439,15 +1466,17 @@ discard block |
||
1439 | 1466 | // Setup the direction stuff... |
1440 | 1467 | $context['order'] = isset($_REQUEST['sort']) && isset($sort_types[$_REQUEST['sort']]) ? $_REQUEST['sort'] : 'member'; |
1441 | 1468 | |
1442 | - if (!isset($search_params['string']) || (!empty($_REQUEST['search']) && $search_params['string'] != $_REQUEST['search'])) |
|
1443 | - $search_params_string = empty($_REQUEST['search']) ? '' : $_REQUEST['search']; |
|
1444 | - else |
|
1445 | - $search_params_string = $search_params['string']; |
|
1469 | + if (!isset($search_params['string']) || (!empty($_REQUEST['search']) && $search_params['string'] != $_REQUEST['search'])) { |
|
1470 | + $search_params_string = empty($_REQUEST['search']) ? '' : $_REQUEST['search']; |
|
1471 | + } else { |
|
1472 | + $search_params_string = $search_params['string']; |
|
1473 | + } |
|
1446 | 1474 | |
1447 | - if (isset($_REQUEST['search_type']) || empty($search_params['type']) || !isset($searchTypes[$search_params['type']])) |
|
1448 | - $search_params_type = isset($_REQUEST['search_type']) && isset($searchTypes[$_REQUEST['search_type']]) ? $_REQUEST['search_type'] : (isset($searchTypes[$context['order']]) ? $context['order'] : 'member'); |
|
1449 | - else |
|
1450 | - $search_params_type = $search_params['type']; |
|
1475 | + if (isset($_REQUEST['search_type']) || empty($search_params['type']) || !isset($searchTypes[$search_params['type']])) { |
|
1476 | + $search_params_type = isset($_REQUEST['search_type']) && isset($searchTypes[$_REQUEST['search_type']]) ? $_REQUEST['search_type'] : (isset($searchTypes[$context['order']]) ? $context['order'] : 'member'); |
|
1477 | + } else { |
|
1478 | + $search_params_type = $search_params['type']; |
|
1479 | + } |
|
1451 | 1480 | |
1452 | 1481 | $search_params = array( |
1453 | 1482 | 'string' => $search_params_string, |
@@ -1530,9 +1559,10 @@ discard block |
||
1530 | 1559 | ' . $rowData['reason'] . ' |
1531 | 1560 | </div>'; |
1532 | 1561 | |
1533 | - if (!empty($rowData['id_notice'])) |
|
1534 | - $output .= ' |
|
1562 | + if (!empty($rowData['id_notice'])) { |
|
1563 | + $output .= ' |
|
1535 | 1564 | <a href="' . $scripturl . '?action=moderate;area=notice;nid=' . $rowData['id_notice'] . '" onclick="window.open(this.href, \'\', \'scrollbars=yes,resizable=yes,width=400,height=250\');return false;" target="_blank" title="' . $txt['profile_warning_previous_notice'] . '"><span class="generic_icons filter centericon"></span></a>'; |
1565 | + } |
|
1536 | 1566 | return $output; |
1537 | 1567 | }, |
1538 | 1568 | ), |
@@ -1650,9 +1680,9 @@ discard block |
||
1650 | 1680 | global $smcFunc, $modSettings, $context, $txt, $scripturl, $sourcedir, $user_info; |
1651 | 1681 | |
1652 | 1682 | // Submitting a new one? |
1653 | - if (isset($_POST['add'])) |
|
1654 | - return ModifyWarningTemplate(); |
|
1655 | - elseif (isset($_POST['delete']) && !empty($_POST['deltpl'])) |
|
1683 | + if (isset($_POST['add'])) { |
|
1684 | + return ModifyWarningTemplate(); |
|
1685 | + } elseif (isset($_POST['delete']) && !empty($_POST['deltpl'])) |
|
1656 | 1686 | { |
1657 | 1687 | checkSession(); |
1658 | 1688 | validateToken('mod-wt'); |
@@ -1671,8 +1701,9 @@ discard block |
||
1671 | 1701 | 'current_member' => $user_info['id'], |
1672 | 1702 | ) |
1673 | 1703 | ); |
1674 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1675 | - logAction('delete_warn_template', array('template' => $row['recipient_name'])); |
|
1704 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1705 | + logAction('delete_warn_template', array('template' => $row['recipient_name'])); |
|
1706 | + } |
|
1676 | 1707 | $smcFunc['db_free_result']($request); |
1677 | 1708 | |
1678 | 1709 | // Do the deletes. |
@@ -1963,16 +1994,18 @@ discard block |
||
1963 | 1994 | ); |
1964 | 1995 | |
1965 | 1996 | // If it wasn't visible and now is they've effectively added it. |
1966 | - if ($context['template_data']['personal'] && !$recipient_id) |
|
1967 | - logAction('add_warn_template', array('template' => $_POST['template_title'])); |
|
1997 | + if ($context['template_data']['personal'] && !$recipient_id) { |
|
1998 | + logAction('add_warn_template', array('template' => $_POST['template_title'])); |
|
1999 | + } |
|
1968 | 2000 | // Conversely if they made it personal it's a delete. |
1969 | - elseif (!$context['template_data']['personal'] && $recipient_id) |
|
1970 | - logAction('delete_warn_template', array('template' => $_POST['template_title'])); |
|
2001 | + elseif (!$context['template_data']['personal'] && $recipient_id) { |
|
2002 | + logAction('delete_warn_template', array('template' => $_POST['template_title'])); |
|
2003 | + } |
|
1971 | 2004 | // Otherwise just an edit. |
1972 | - else |
|
1973 | - logAction('modify_warn_template', array('template' => $_POST['template_title'])); |
|
1974 | - } |
|
1975 | - else |
|
2005 | + else { |
|
2006 | + logAction('modify_warn_template', array('template' => $_POST['template_title'])); |
|
2007 | + } |
|
2008 | + } else |
|
1976 | 2009 | { |
1977 | 2010 | $smcFunc['db_insert']('', |
1978 | 2011 | '{db_prefix}log_comments', |
@@ -1992,17 +2025,18 @@ discard block |
||
1992 | 2025 | |
1993 | 2026 | // Get out of town... |
1994 | 2027 | redirectexit('action=moderate;area=warnings;sa=templates'); |
1995 | - } |
|
1996 | - else |
|
2028 | + } else |
|
1997 | 2029 | { |
1998 | 2030 | $context['warning_errors'] = array(); |
1999 | 2031 | $context['template_data']['title'] = !empty($_POST['template_title']) ? $_POST['template_title'] : ''; |
2000 | 2032 | $context['template_data']['body'] = !empty($_POST['template_body']) ? $_POST['template_body'] : $txt['mc_warning_template_body_default']; |
2001 | 2033 | $context['template_data']['personal'] = !empty($_POST['make_personal']); |
2002 | - if (empty($_POST['template_title'])) |
|
2003 | - $context['warning_errors'][] = $txt['mc_warning_template_error_no_title']; |
|
2004 | - if (empty($_POST['template_body'])) |
|
2005 | - $context['warning_errors'][] = $txt['mc_warning_template_error_no_body']; |
|
2034 | + if (empty($_POST['template_title'])) { |
|
2035 | + $context['warning_errors'][] = $txt['mc_warning_template_error_no_title']; |
|
2036 | + } |
|
2037 | + if (empty($_POST['template_body'])) { |
|
2038 | + $context['warning_errors'][] = $txt['mc_warning_template_error_no_body']; |
|
2039 | + } |
|
2006 | 2040 | } |
2007 | 2041 | } |
2008 | 2042 | |
@@ -2047,8 +2081,9 @@ discard block |
||
2047 | 2081 | // Now check other options! |
2048 | 2082 | $pref_binary = 0; |
2049 | 2083 | |
2050 | - if ($context['can_moderate_approvals'] && !empty($_POST['mod_notify_approval'])) |
|
2051 | - $pref_binary |= 4; |
|
2084 | + if ($context['can_moderate_approvals'] && !empty($_POST['mod_notify_approval'])) { |
|
2085 | + $pref_binary |= 4; |
|
2086 | + } |
|
2052 | 2087 | |
2053 | 2088 | // Put it all together. |
2054 | 2089 | $mod_prefs = '0||' . $pref_binary; |
@@ -2072,9 +2107,10 @@ discard block |
||
2072 | 2107 | unset($_SESSION['moderate_time']); |
2073 | 2108 | |
2074 | 2109 | // Clean any moderator tokens as well. |
2075 | - foreach ($_SESSION['token'] as $key => $token) |
|
2076 | - if (strpos($key, '-mod') !== false) |
|
2110 | + foreach ($_SESSION['token'] as $key => $token) { |
|
2111 | + if (strpos($key, '-mod') !== false) |
|
2077 | 2112 | unset($_SESSION['token'][$key]); |
2113 | + } |
|
2078 | 2114 | |
2079 | 2115 | redirectexit(); |
2080 | 2116 | } |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Activate an account. |
@@ -48,8 +49,9 @@ discard block |
||
48 | 49 | logAction('approve_member', array('member' => $memID), 'admin'); |
49 | 50 | |
50 | 51 | // If we are doing approval, update the stats for the member just in case. |
51 | - if (in_array($user_profile[$memID]['is_activated'], array(3, 4, 5, 13, 14, 15))) |
|
52 | - updateSettings(array('unapprovedMembers' => ($modSettings['unapprovedMembers'] > 1 ? $modSettings['unapprovedMembers'] - 1 : 0))); |
|
52 | + if (in_array($user_profile[$memID]['is_activated'], array(3, 4, 5, 13, 14, 15))) { |
|
53 | + updateSettings(array('unapprovedMembers' => ($modSettings['unapprovedMembers'] > 1 ? $modSettings['unapprovedMembers'] - 1 : 0))); |
|
54 | + } |
|
53 | 55 | |
54 | 56 | // Make sure we update the stats too. |
55 | 57 | updateStats('member', false); |
@@ -76,8 +78,9 @@ discard block |
||
76 | 78 | $issueErrors = array(); |
77 | 79 | |
78 | 80 | // Doesn't hurt to be overly cautious. |
79 | - if (empty($modSettings['warning_enable']) || ($context['user']['is_owner'] && !$cur_profile['warning']) || !allowedTo('issue_warning')) |
|
80 | - fatal_lang_error('no_access', false); |
|
81 | + if (empty($modSettings['warning_enable']) || ($context['user']['is_owner'] && !$cur_profile['warning']) || !allowedTo('issue_warning')) { |
|
82 | + fatal_lang_error('no_access', false); |
|
83 | + } |
|
81 | 84 | |
82 | 85 | // Get the base (errors related) stuff done. |
83 | 86 | loadLanguage('Errors'); |
@@ -135,16 +138,18 @@ discard block |
||
135 | 138 | |
136 | 139 | // This cannot be empty! |
137 | 140 | $_POST['warn_reason'] = isset($_POST['warn_reason']) ? trim($_POST['warn_reason']) : ''; |
138 | - if ($_POST['warn_reason'] == '' && !$context['user']['is_owner']) |
|
139 | - $issueErrors[] = 'warning_no_reason'; |
|
141 | + if ($_POST['warn_reason'] == '' && !$context['user']['is_owner']) { |
|
142 | + $issueErrors[] = 'warning_no_reason'; |
|
143 | + } |
|
140 | 144 | $_POST['warn_reason'] = $smcFunc['htmlspecialchars']($_POST['warn_reason']); |
141 | 145 | |
142 | 146 | $_POST['warning_level'] = (int) $_POST['warning_level']; |
143 | 147 | $_POST['warning_level'] = max(0, min(100, $_POST['warning_level'])); |
144 | - if ($_POST['warning_level'] < $context['min_allowed']) |
|
145 | - $_POST['warning_level'] = $context['min_allowed']; |
|
146 | - elseif ($_POST['warning_level'] > $context['max_allowed']) |
|
147 | - $_POST['warning_level'] = $context['max_allowed']; |
|
148 | + if ($_POST['warning_level'] < $context['min_allowed']) { |
|
149 | + $_POST['warning_level'] = $context['min_allowed']; |
|
150 | + } elseif ($_POST['warning_level'] > $context['max_allowed']) { |
|
151 | + $_POST['warning_level'] = $context['max_allowed']; |
|
152 | + } |
|
148 | 153 | |
149 | 154 | // Do we actually have to issue them with a PM? |
150 | 155 | $id_notice = 0; |
@@ -152,8 +157,9 @@ discard block |
||
152 | 157 | { |
153 | 158 | $_POST['warn_sub'] = trim($_POST['warn_sub']); |
154 | 159 | $_POST['warn_body'] = trim($_POST['warn_body']); |
155 | - if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) |
|
156 | - $issueErrors[] = 'warning_notify_blank'; |
|
160 | + if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) { |
|
161 | + $issueErrors[] = 'warning_notify_blank'; |
|
162 | + } |
|
157 | 163 | // Send the PM? |
158 | 164 | else |
159 | 165 | { |
@@ -190,8 +196,8 @@ discard block |
||
190 | 196 | if (empty($issueErrors)) |
191 | 197 | { |
192 | 198 | // Log what we've done! |
193 | - if (!$context['user']['is_owner']) |
|
194 | - $smcFunc['db_insert']('', |
|
199 | + if (!$context['user']['is_owner']) { |
|
200 | + $smcFunc['db_insert']('', |
|
195 | 201 | '{db_prefix}log_comments', |
196 | 202 | array( |
197 | 203 | 'id_member' => 'int', 'member_name' => 'string', 'comment_type' => 'string', 'id_recipient' => 'int', 'recipient_name' => 'string-255', |
@@ -203,14 +209,14 @@ discard block |
||
203 | 209 | ), |
204 | 210 | array('id_comment') |
205 | 211 | ); |
212 | + } |
|
206 | 213 | |
207 | 214 | // Make the change. |
208 | 215 | updateMemberData($memID, array('warning' => $_POST['warning_level'])); |
209 | 216 | |
210 | 217 | // Leave a lovely message. |
211 | 218 | $context['profile_updated'] = $context['user']['is_owner'] ? $txt['profile_updated_own'] : $txt['profile_warning_success']; |
212 | - } |
|
213 | - else |
|
219 | + } else |
|
214 | 220 | { |
215 | 221 | // Try to remember some bits. |
216 | 222 | $context['warning_data'] = array( |
@@ -229,8 +235,9 @@ discard block |
||
229 | 235 | { |
230 | 236 | $warning_body = !empty($_POST['warn_body']) ? trim(censorText($_POST['warn_body'])) : ''; |
231 | 237 | $context['preview_subject'] = !empty($_POST['warn_sub']) ? trim($smcFunc['htmlspecialchars']($_POST['warn_sub'])) : ''; |
232 | - if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) |
|
233 | - $issueErrors[] = 'warning_notify_blank'; |
|
238 | + if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) { |
|
239 | + $issueErrors[] = 'warning_notify_blank'; |
|
240 | + } |
|
234 | 241 | |
235 | 242 | if (!empty($_POST['warn_body'])) |
236 | 243 | { |
@@ -254,8 +261,9 @@ discard block |
||
254 | 261 | { |
255 | 262 | // Fill in the suite of errors. |
256 | 263 | $context['post_errors'] = array(); |
257 | - foreach ($issueErrors as $error) |
|
258 | - $context['post_errors'][] = $txt[$error]; |
|
264 | + foreach ($issueErrors as $error) { |
|
265 | + $context['post_errors'][] = $txt[$error]; |
|
266 | + } |
|
259 | 267 | } |
260 | 268 | |
261 | 269 | |
@@ -272,9 +280,10 @@ discard block |
||
272 | 280 | $modSettings['warning_mute'] => $txt['profile_warning_effect_mute'], |
273 | 281 | ); |
274 | 282 | $context['current_level'] = 0; |
275 | - foreach ($context['level_effects'] as $limit => $dummy) |
|
276 | - if ($context['member']['warning'] >= $limit) |
|
283 | + foreach ($context['level_effects'] as $limit => $dummy) { |
|
284 | + if ($context['member']['warning'] >= $limit) |
|
277 | 285 | $context['current_level'] = $limit; |
286 | + } |
|
278 | 287 | |
279 | 288 | $listOptions = array( |
280 | 289 | 'id' => 'view_warnings', |
@@ -337,11 +346,12 @@ discard block |
||
337 | 346 | ' . $warning['reason'] . ' |
338 | 347 | </div>'; |
339 | 348 | |
340 | - if (!empty($warning['id_notice'])) |
|
341 | - $ret .= ' |
|
349 | + if (!empty($warning['id_notice'])) { |
|
350 | + $ret .= ' |
|
342 | 351 | <div class="floatright"> |
343 | 352 | <a href="' . $scripturl . '?action=moderate;area=notice;nid=' . $warning['id_notice'] . '" onclick="window.open(this.href, \'\', \'scrollbars=yes,resizable=yes,width=400,height=250\');return false;" target="_blank" title="' . $txt['profile_warning_previous_notice'] . '"><span class="generic_icons filter centericon"></span></a> |
344 | 353 | </div>'; |
354 | + } |
|
345 | 355 | |
346 | 356 | return $ret; |
347 | 357 | }, |
@@ -413,8 +423,9 @@ discard block |
||
413 | 423 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
414 | 424 | { |
415 | 425 | // If we're not warning for a message skip any that are. |
416 | - if (!$context['warning_for_message'] && strpos($row['body'], '{MESSAGE}') !== false) |
|
417 | - continue; |
|
426 | + if (!$context['warning_for_message'] && strpos($row['body'], '{MESSAGE}') !== false) { |
|
427 | + continue; |
|
428 | + } |
|
418 | 429 | |
419 | 430 | $context['notification_templates'][] = array( |
420 | 431 | 'title' => $row['template_title'], |
@@ -424,16 +435,18 @@ discard block |
||
424 | 435 | $smcFunc['db_free_result']($request); |
425 | 436 | |
426 | 437 | // Setup the "default" templates. |
427 | - foreach (array('spamming', 'offence', 'insulting') as $type) |
|
428 | - $context['notification_templates'][] = array( |
|
438 | + foreach (array('spamming', 'offence', 'insulting') as $type) { |
|
439 | + $context['notification_templates'][] = array( |
|
429 | 440 | 'title' => $txt['profile_warning_notify_title_' . $type], |
430 | 441 | 'body' => sprintf($txt['profile_warning_notify_template_outline' . (!empty($context['warning_for_message']) ? '_post' : '')], $txt['profile_warning_notify_for_' . $type]), |
431 | 442 | ); |
443 | + } |
|
432 | 444 | |
433 | 445 | // Replace all the common variables in the templates. |
434 | - foreach ($context['notification_templates'] as $k => $name) |
|
435 | - $context['notification_templates'][$k]['body'] = strtr($name['body'], array('{MEMBER}' => un_htmlspecialchars($context['member']['name']), '{MESSAGE}' => '[url=' . $scripturl . '?msg=' . $context['warning_for_message'] . ']' . un_htmlspecialchars($context['warned_message_subject']) . '[/url]', '{SCRIPTURL}' => $scripturl, '{FORUMNAME}' => $mbname, '{REGARDS}' => $txt['regards_team'])); |
|
436 | -} |
|
446 | + foreach ($context['notification_templates'] as $k => $name) { |
|
447 | + $context['notification_templates'][$k]['body'] = strtr($name['body'], array('{MEMBER}' => un_htmlspecialchars($context['member']['name']), '{MESSAGE}' => '[url=' . $scripturl . '?msg=' . $context['warning_for_message'] . ']' . un_htmlspecialchars($context['warned_message_subject']) . '[/url]', '{SCRIPTURL}' => $scripturl, '{FORUMNAME}' => $mbname, '{REGARDS}' => $txt['regards_team'])); |
|
448 | + } |
|
449 | + } |
|
437 | 450 | |
438 | 451 | /** |
439 | 452 | * Get the number of warnings a user has. Callback for $listOptions['get_count'] in issueWarning() |
@@ -517,10 +530,11 @@ discard block |
||
517 | 530 | { |
518 | 531 | global $txt, $context, $modSettings, $cur_profile; |
519 | 532 | |
520 | - if (!$context['user']['is_owner']) |
|
521 | - isAllowedTo('profile_remove_any'); |
|
522 | - elseif (!allowedTo('profile_remove_any')) |
|
523 | - isAllowedTo('profile_remove_own'); |
|
533 | + if (!$context['user']['is_owner']) { |
|
534 | + isAllowedTo('profile_remove_any'); |
|
535 | + } elseif (!allowedTo('profile_remove_any')) { |
|
536 | + isAllowedTo('profile_remove_own'); |
|
537 | + } |
|
524 | 538 | |
525 | 539 | // Permissions for removing stuff... |
526 | 540 | $context['can_delete_posts'] = !$context['user']['is_owner'] && allowedTo('moderate_forum'); |
@@ -547,10 +561,11 @@ discard block |
||
547 | 561 | |
548 | 562 | // @todo Add a way to delete pms as well? |
549 | 563 | |
550 | - if (!$context['user']['is_owner']) |
|
551 | - isAllowedTo('profile_remove_any'); |
|
552 | - elseif (!allowedTo('profile_remove_any')) |
|
553 | - isAllowedTo('profile_remove_own'); |
|
564 | + if (!$context['user']['is_owner']) { |
|
565 | + isAllowedTo('profile_remove_any'); |
|
566 | + } elseif (!allowedTo('profile_remove_any')) { |
|
567 | + isAllowedTo('profile_remove_own'); |
|
568 | + } |
|
554 | 569 | |
555 | 570 | checkSession(); |
556 | 571 | |
@@ -576,8 +591,9 @@ discard block |
||
576 | 591 | list ($another) = $smcFunc['db_fetch_row']($request); |
577 | 592 | $smcFunc['db_free_result']($request); |
578 | 593 | |
579 | - if (empty($another)) |
|
580 | - fatal_lang_error('at_least_one_admin', 'critical'); |
|
594 | + if (empty($another)) { |
|
595 | + fatal_lang_error('at_least_one_admin', 'critical'); |
|
596 | + } |
|
581 | 597 | } |
582 | 598 | |
583 | 599 | // This file is needed for the deleteMembers function. |
@@ -656,8 +672,9 @@ discard block |
||
656 | 672 | ) |
657 | 673 | ); |
658 | 674 | $topicIDs = array(); |
659 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
660 | - $topicIDs[] = $row['id_topic']; |
|
675 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
676 | + $topicIDs[] = $row['id_topic']; |
|
677 | + } |
|
661 | 678 | $smcFunc['db_free_result']($request); |
662 | 679 | |
663 | 680 | // Actually remove the topics. Ignore recycling if we want to perma-delete things... |
@@ -680,8 +697,9 @@ discard block |
||
680 | 697 | // This could take a while... but ya know it's gonna be worth it in the end. |
681 | 698 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
682 | 699 | { |
683 | - if (function_exists('apache_reset_timeout')) |
|
684 | - @apache_reset_timeout(); |
|
700 | + if (function_exists('apache_reset_timeout')) { |
|
701 | + @apache_reset_timeout(); |
|
702 | + } |
|
685 | 703 | |
686 | 704 | removeMessage($row['id_msg']); |
687 | 705 | } |
@@ -689,8 +707,9 @@ discard block |
||
689 | 707 | } |
690 | 708 | |
691 | 709 | // Only delete this poor members account if they are actually being booted out of camp. |
692 | - if (isset($_POST['deleteAccount'])) |
|
693 | - deleteMembers($memID); |
|
710 | + if (isset($_POST['deleteAccount'])) { |
|
711 | + deleteMembers($memID); |
|
712 | + } |
|
694 | 713 | } |
695 | 714 | // Do they need approval to delete? |
696 | 715 | elseif (!empty($modSettings['approveAccountDeletion']) && !allowedTo('moderate_forum')) |
@@ -741,18 +760,18 @@ discard block |
||
741 | 760 | { |
742 | 761 | foreach ($costs as $duration => $cost) |
743 | 762 | { |
744 | - if ($cost != 0) |
|
745 | - $cost_array[$duration] = $cost; |
|
763 | + if ($cost != 0) { |
|
764 | + $cost_array[$duration] = $cost; |
|
765 | + } |
|
746 | 766 | } |
747 | - } |
|
748 | - else |
|
767 | + } else |
|
749 | 768 | { |
750 | 769 | $cost_array['fixed'] = $costs['fixed']; |
751 | 770 | } |
752 | 771 | |
753 | - if (empty($cost_array)) |
|
754 | - unset($context['subscriptions'][$id]); |
|
755 | - else |
|
772 | + if (empty($cost_array)) { |
|
773 | + unset($context['subscriptions'][$id]); |
|
774 | + } else |
|
756 | 775 | { |
757 | 776 | $context['subscriptions'][$id]['member'] = 0; |
758 | 777 | $context['subscriptions'][$id]['subscribed'] = false; |
@@ -765,13 +784,15 @@ discard block |
||
765 | 784 | foreach ($gateways as $id => $gateway) |
766 | 785 | { |
767 | 786 | $gateways[$id] = new $gateway['display_class'](); |
768 | - if (!$gateways[$id]->gatewayEnabled()) |
|
769 | - unset($gateways[$id]); |
|
787 | + if (!$gateways[$id]->gatewayEnabled()) { |
|
788 | + unset($gateways[$id]); |
|
789 | + } |
|
770 | 790 | } |
771 | 791 | |
772 | 792 | // No gateways yet? |
773 | - if (empty($gateways)) |
|
774 | - fatal_error($txt['paid_admin_not_setup_gateway']); |
|
793 | + if (empty($gateways)) { |
|
794 | + fatal_error($txt['paid_admin_not_setup_gateway']); |
|
795 | + } |
|
775 | 796 | |
776 | 797 | // Get the current subscriptions. |
777 | 798 | $request = $smcFunc['db_query']('', ' |
@@ -786,8 +807,9 @@ discard block |
||
786 | 807 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
787 | 808 | { |
788 | 809 | // The subscription must exist! |
789 | - if (!isset($context['subscriptions'][$row['id_subscribe']])) |
|
790 | - continue; |
|
810 | + if (!isset($context['subscriptions'][$row['id_subscribe']])) { |
|
811 | + continue; |
|
812 | + } |
|
791 | 813 | |
792 | 814 | $context['current'][$row['id_subscribe']] = array( |
793 | 815 | 'id' => $row['id_sublog'], |
@@ -801,8 +823,9 @@ discard block |
||
801 | 823 | 'status_text' => $row['status'] == 0 ? ($row['payments_pending'] ? $txt['paid_pending'] : $txt['paid_finished']) : $txt['paid_active'], |
802 | 824 | ); |
803 | 825 | |
804 | - if ($row['status'] == 1) |
|
805 | - $context['subscriptions'][$row['id_subscribe']]['subscribed'] = true; |
|
826 | + if ($row['status'] == 1) { |
|
827 | + $context['subscriptions'][$row['id_subscribe']]['subscribed'] = true; |
|
828 | + } |
|
806 | 829 | } |
807 | 830 | $smcFunc['db_free_result']($request); |
808 | 831 | |
@@ -853,21 +876,25 @@ discard block |
||
853 | 876 | if (isset($_GET['confirm']) && isset($_POST['sub_id']) && is_array($_POST['sub_id'])) |
854 | 877 | { |
855 | 878 | // Hopefully just one. |
856 | - foreach ($_POST['sub_id'] as $k => $v) |
|
857 | - $ID_SUB = (int) $k; |
|
879 | + foreach ($_POST['sub_id'] as $k => $v) { |
|
880 | + $ID_SUB = (int) $k; |
|
881 | + } |
|
858 | 882 | |
859 | - if (!isset($context['subscriptions'][$ID_SUB]) || $context['subscriptions'][$ID_SUB]['active'] == 0) |
|
860 | - fatal_lang_error('paid_sub_not_active'); |
|
883 | + if (!isset($context['subscriptions'][$ID_SUB]) || $context['subscriptions'][$ID_SUB]['active'] == 0) { |
|
884 | + fatal_lang_error('paid_sub_not_active'); |
|
885 | + } |
|
861 | 886 | |
862 | 887 | // Simplify... |
863 | 888 | $context['sub'] = $context['subscriptions'][$ID_SUB]; |
864 | 889 | $period = 'xx'; |
865 | - if ($context['sub']['flexible']) |
|
866 | - $period = isset($_POST['cur'][$ID_SUB]) && isset($context['sub']['costs'][$_POST['cur'][$ID_SUB]]) ? $_POST['cur'][$ID_SUB] : 'xx'; |
|
890 | + if ($context['sub']['flexible']) { |
|
891 | + $period = isset($_POST['cur'][$ID_SUB]) && isset($context['sub']['costs'][$_POST['cur'][$ID_SUB]]) ? $_POST['cur'][$ID_SUB] : 'xx'; |
|
892 | + } |
|
867 | 893 | |
868 | 894 | // Check we have a valid cost. |
869 | - if ($context['sub']['flexible'] && $period == 'xx') |
|
870 | - fatal_lang_error('paid_sub_not_active'); |
|
895 | + if ($context['sub']['flexible'] && $period == 'xx') { |
|
896 | + fatal_lang_error('paid_sub_not_active'); |
|
897 | + } |
|
871 | 898 | |
872 | 899 | // Sort out the cost/currency. |
873 | 900 | $context['currency'] = $modSettings['paid_currency_code']; |
@@ -880,8 +907,7 @@ discard block |
||
880 | 907 | $context['cost'] = sprintf($modSettings['paid_currency_symbol'], $context['value']) . '/' . $txt[$_POST['cur'][$ID_SUB]]; |
881 | 908 | // The period value for paypal. |
882 | 909 | $context['paypal_period'] = strtoupper(substr($_POST['cur'][$ID_SUB], 0, 1)); |
883 | - } |
|
884 | - else |
|
910 | + } else |
|
885 | 911 | { |
886 | 912 | // Real cost... |
887 | 913 | $context['value'] = $context['sub']['costs']['fixed']; |
@@ -898,13 +924,15 @@ discard block |
||
898 | 924 | foreach ($gateways as $id => $gateway) |
899 | 925 | { |
900 | 926 | $fields = $gateways[$id]->fetchGatewayFields($context['sub']['id'] . '+' . $memID, $context['sub'], $context['value'], $period, $scripturl . '?action=profile;u=' . $memID . ';area=subscriptions;sub_id=' . $context['sub']['id'] . ';done'); |
901 | - if (!empty($fields['form'])) |
|
902 | - $context['gateways'][] = $fields; |
|
927 | + if (!empty($fields['form'])) { |
|
928 | + $context['gateways'][] = $fields; |
|
929 | + } |
|
903 | 930 | } |
904 | 931 | |
905 | 932 | // Bugger?! |
906 | - if (empty($context['gateways'])) |
|
907 | - fatal_error($txt['paid_admin_not_setup_gateway']); |
|
933 | + if (empty($context['gateways'])) { |
|
934 | + fatal_error($txt['paid_admin_not_setup_gateway']); |
|
935 | + } |
|
908 | 936 | |
909 | 937 | // Now we are going to assume they want to take this out ;) |
910 | 938 | $new_data = array($context['sub']['id'], $context['value'], $period, 'prepay'); |
@@ -912,16 +940,19 @@ discard block |
||
912 | 940 | { |
913 | 941 | // What are the details like? |
914 | 942 | $current_pending = array(); |
915 | - if ($context['current'][$context['sub']['id']]['pending_details'] != '') |
|
916 | - $current_pending = $smcFunc['json_decode']($context['current'][$context['sub']['id']]['pending_details'], true); |
|
943 | + if ($context['current'][$context['sub']['id']]['pending_details'] != '') { |
|
944 | + $current_pending = $smcFunc['json_decode']($context['current'][$context['sub']['id']]['pending_details'], true); |
|
945 | + } |
|
917 | 946 | // Don't get silly. |
918 | - if (count($current_pending) > 9) |
|
919 | - $current_pending = array(); |
|
947 | + if (count($current_pending) > 9) { |
|
948 | + $current_pending = array(); |
|
949 | + } |
|
920 | 950 | $pending_count = 0; |
921 | 951 | // Only record real pending payments as will otherwise confuse the admin! |
922 | - foreach ($current_pending as $pending) |
|
923 | - if ($pending[3] == 'payback') |
|
952 | + foreach ($current_pending as $pending) { |
|
953 | + if ($pending[3] == 'payback') |
|
924 | 954 | $pending_count++; |
955 | + } |
|
925 | 956 | |
926 | 957 | if (!in_array($new_data, $current_pending)) |
927 | 958 | { |
@@ -966,9 +997,9 @@ discard block |
||
966 | 997 | |
967 | 998 | // Quit. |
968 | 999 | return; |
1000 | + } else { |
|
1001 | + $context['sub_template'] = 'user_subscription'; |
|
1002 | + } |
|
969 | 1003 | } |
970 | - else |
|
971 | - $context['sub_template'] = 'user_subscription'; |
|
972 | -} |
|
973 | 1004 | |
974 | 1005 | ?> |
975 | 1006 | \ No newline at end of file |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
122 | 123 | $smcFunc['db_free_result']($result); |
123 | 124 | |
124 | 125 | // Add this to the number of unapproved members |
125 | - if (!empty($changes['unapprovedMembers'])) |
|
126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
127 | - else |
|
128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
126 | + if (!empty($changes['unapprovedMembers'])) { |
|
127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
128 | + } else { |
|
129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
130 | + } |
|
129 | 131 | } |
130 | 132 | } |
131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
133 | 135 | break; |
134 | 136 | |
135 | 137 | case 'message': |
136 | - if ($parameter1 === true && $parameter2 !== null) |
|
137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
138 | - else |
|
138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
140 | + } else |
|
139 | 141 | { |
140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
175 | 177 | $parameter2 = text2words($parameter2); |
176 | 178 | |
177 | 179 | $inserts = array(); |
178 | - foreach ($parameter2 as $word) |
|
179 | - $inserts[] = array($word, $parameter1); |
|
180 | + foreach ($parameter2 as $word) { |
|
181 | + $inserts[] = array($word, $parameter1); |
|
182 | + } |
|
180 | 183 | |
181 | - if (!empty($inserts)) |
|
182 | - $smcFunc['db_insert']('ignore', |
|
184 | + if (!empty($inserts)) { |
|
185 | + $smcFunc['db_insert']('ignore', |
|
183 | 186 | '{db_prefix}log_search_subjects', |
184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
185 | 188 | $inserts, |
186 | 189 | array('word', 'id_topic') |
187 | 190 | ); |
191 | + } |
|
188 | 192 | } |
189 | 193 | break; |
190 | 194 | |
191 | 195 | case 'topic': |
192 | - if ($parameter1 === true) |
|
193 | - updateSettings(array('totalTopics' => true), true); |
|
194 | - else |
|
196 | + if ($parameter1 === true) { |
|
197 | + updateSettings(array('totalTopics' => true), true); |
|
198 | + } else |
|
195 | 199 | { |
196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
212 | 216 | |
213 | 217 | case 'postgroups': |
214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
216 | - return; |
|
219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
220 | + return; |
|
221 | + } |
|
217 | 222 | |
218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
228 | 233 | ) |
229 | 234 | ); |
230 | 235 | $postgroups = array(); |
231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
238 | + } |
|
233 | 239 | $smcFunc['db_free_result']($request); |
234 | 240 | |
235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
239 | 245 | } |
240 | 246 | |
241 | 247 | // Oh great, they've screwed their post groups. |
242 | - if (empty($postgroups)) |
|
243 | - return; |
|
248 | + if (empty($postgroups)) { |
|
249 | + return; |
|
250 | + } |
|
244 | 251 | |
245 | 252 | // Set all membergroups from most posts to least posts. |
246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
298 | 305 | { |
299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
300 | 307 | $parameters['members'] = $members; |
301 | - } |
|
302 | - elseif ($members === null) |
|
303 | - $condition = '1=1'; |
|
304 | - else |
|
308 | + } elseif ($members === null) { |
|
309 | + $condition = '1=1'; |
|
310 | + } else |
|
305 | 311 | { |
306 | 312 | $condition = 'id_member = {int:member}'; |
307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
341 | 347 | if (count($vars_to_integrate) != 0) |
342 | 348 | { |
343 | 349 | // Fetch a list of member_names if necessary |
344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
345 | - $member_names = array($user_info['username']); |
|
346 | - else |
|
350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
351 | + $member_names = array($user_info['username']); |
|
352 | + } else |
|
347 | 353 | { |
348 | 354 | $member_names = array(); |
349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
352 | 358 | WHERE ' . $condition, |
353 | 359 | $parameters |
354 | 360 | ); |
355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
356 | - $member_names[] = $row['member_name']; |
|
361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
362 | + $member_names[] = $row['member_name']; |
|
363 | + } |
|
357 | 364 | $smcFunc['db_free_result']($request); |
358 | 365 | } |
359 | 366 | |
360 | - if (!empty($member_names)) |
|
361 | - foreach ($vars_to_integrate as $var) |
|
367 | + if (!empty($member_names)) { |
|
368 | + foreach ($vars_to_integrate as $var) |
|
362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
370 | + } |
|
363 | 371 | } |
364 | 372 | } |
365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
367 | 375 | foreach ($data as $var => $val) |
368 | 376 | { |
369 | 377 | $type = 'string'; |
370 | - if (in_array($var, $knownInts)) |
|
371 | - $type = 'int'; |
|
372 | - elseif (in_array($var, $knownFloats)) |
|
373 | - $type = 'float'; |
|
374 | - elseif ($var == 'birthdate') |
|
375 | - $type = 'date'; |
|
376 | - elseif ($var == 'member_ip') |
|
377 | - $type = 'inet'; |
|
378 | - elseif ($var == 'member_ip2') |
|
379 | - $type = 'inet'; |
|
378 | + if (in_array($var, $knownInts)) { |
|
379 | + $type = 'int'; |
|
380 | + } elseif (in_array($var, $knownFloats)) { |
|
381 | + $type = 'float'; |
|
382 | + } elseif ($var == 'birthdate') { |
|
383 | + $type = 'date'; |
|
384 | + } elseif ($var == 'member_ip') { |
|
385 | + $type = 'inet'; |
|
386 | + } elseif ($var == 'member_ip2') { |
|
387 | + $type = 'inet'; |
|
388 | + } |
|
380 | 389 | |
381 | 390 | // Doing an increment? |
382 | 391 | if ($type == 'int' && ($val === '+' || $val === '-')) |
@@ -390,8 +399,9 @@ discard block |
||
390 | 399 | { |
391 | 400 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
392 | 401 | { |
393 | - if ($match[1] != '+ ') |
|
394 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
402 | + if ($match[1] != '+ ') { |
|
403 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
404 | + } |
|
395 | 405 | $type = 'raw'; |
396 | 406 | } |
397 | 407 | } |
@@ -412,8 +422,9 @@ discard block |
||
412 | 422 | // Clear any caching? |
413 | 423 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
414 | 424 | { |
415 | - if (!is_array($members)) |
|
416 | - $members = array($members); |
|
425 | + if (!is_array($members)) { |
|
426 | + $members = array($members); |
|
427 | + } |
|
417 | 428 | |
418 | 429 | foreach ($members as $member) |
419 | 430 | { |
@@ -446,29 +457,32 @@ discard block |
||
446 | 457 | { |
447 | 458 | global $modSettings, $smcFunc; |
448 | 459 | |
449 | - if (empty($changeArray) || !is_array($changeArray)) |
|
450 | - return; |
|
460 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
461 | + return; |
|
462 | + } |
|
451 | 463 | |
452 | 464 | $toRemove = array(); |
453 | 465 | |
454 | 466 | // Go check if there is any setting to be removed. |
455 | - foreach ($changeArray as $k => $v) |
|
456 | - if ($v === null) |
|
467 | + foreach ($changeArray as $k => $v) { |
|
468 | + if ($v === null) |
|
457 | 469 | { |
458 | 470 | // Found some, remove them from the original array and add them to ours. |
459 | 471 | unset($changeArray[$k]); |
472 | + } |
|
460 | 473 | $toRemove[] = $k; |
461 | 474 | } |
462 | 475 | |
463 | 476 | // Proceed with the deletion. |
464 | - if (!empty($toRemove)) |
|
465 | - $smcFunc['db_query']('', ' |
|
477 | + if (!empty($toRemove)) { |
|
478 | + $smcFunc['db_query']('', ' |
|
466 | 479 | DELETE FROM {db_prefix}settings |
467 | 480 | WHERE variable IN ({array_string:remove})', |
468 | 481 | array( |
469 | 482 | 'remove' => $toRemove, |
470 | 483 | ) |
471 | 484 | ); |
485 | + } |
|
472 | 486 | |
473 | 487 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
474 | 488 | if ($update) |
@@ -497,19 +511,22 @@ discard block |
||
497 | 511 | foreach ($changeArray as $variable => $value) |
498 | 512 | { |
499 | 513 | // Don't bother if it's already like that ;). |
500 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
501 | - continue; |
|
514 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
515 | + continue; |
|
516 | + } |
|
502 | 517 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
503 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
504 | - continue; |
|
518 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
519 | + continue; |
|
520 | + } |
|
505 | 521 | |
506 | 522 | $replaceArray[] = array($variable, $value); |
507 | 523 | |
508 | 524 | $modSettings[$variable] = $value; |
509 | 525 | } |
510 | 526 | |
511 | - if (empty($replaceArray)) |
|
512 | - return; |
|
527 | + if (empty($replaceArray)) { |
|
528 | + return; |
|
529 | + } |
|
513 | 530 | |
514 | 531 | $smcFunc['db_insert']('replace', |
515 | 532 | '{db_prefix}settings', |
@@ -555,14 +572,17 @@ discard block |
||
555 | 572 | $start_invalid = $start < 0; |
556 | 573 | |
557 | 574 | // Make sure $start is a proper variable - not less than 0. |
558 | - if ($start_invalid) |
|
559 | - $start = 0; |
|
575 | + if ($start_invalid) { |
|
576 | + $start = 0; |
|
577 | + } |
|
560 | 578 | // Not greater than the upper bound. |
561 | - elseif ($start >= $max_value) |
|
562 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
579 | + elseif ($start >= $max_value) { |
|
580 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
581 | + } |
|
563 | 582 | // And it has to be a multiple of $num_per_page! |
564 | - else |
|
565 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
583 | + else { |
|
584 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
585 | + } |
|
566 | 586 | |
567 | 587 | $context['current_page'] = $start / $num_per_page; |
568 | 588 | |
@@ -592,77 +612,87 @@ discard block |
||
592 | 612 | |
593 | 613 | // Show all the pages. |
594 | 614 | $display_page = 1; |
595 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
596 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
615 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
616 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
617 | + } |
|
597 | 618 | |
598 | 619 | // Show the right arrow. |
599 | 620 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
600 | - if ($start != $counter - $max_value && !$start_invalid) |
|
601 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
602 | - } |
|
603 | - else |
|
621 | + if ($start != $counter - $max_value && !$start_invalid) { |
|
622 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
623 | + } |
|
624 | + } else |
|
604 | 625 | { |
605 | 626 | // If they didn't enter an odd value, pretend they did. |
606 | 627 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
607 | 628 | |
608 | 629 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
609 | - if (!empty($start) && $show_prevnext) |
|
610 | - $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
611 | - else |
|
612 | - $pageindex .= ''; |
|
630 | + if (!empty($start) && $show_prevnext) { |
|
631 | + $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
632 | + } else { |
|
633 | + $pageindex .= ''; |
|
634 | + } |
|
613 | 635 | |
614 | 636 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
615 | - if ($start > $num_per_page * $PageContiguous) |
|
616 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
637 | + if ($start > $num_per_page * $PageContiguous) { |
|
638 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
639 | + } |
|
617 | 640 | |
618 | 641 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
619 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
620 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
642 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
643 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
621 | 644 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
622 | 645 | '{FIRST_PAGE}' => $num_per_page, |
623 | 646 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
624 | 647 | '{PER_PAGE}' => $num_per_page, |
625 | 648 | )); |
649 | + } |
|
626 | 650 | |
627 | 651 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
628 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
629 | - if ($start >= $num_per_page * $nCont) |
|
652 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
653 | + if ($start >= $num_per_page * $nCont) |
|
630 | 654 | { |
631 | 655 | $tmpStart = $start - $num_per_page * $nCont; |
656 | + } |
|
632 | 657 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
633 | 658 | } |
634 | 659 | |
635 | 660 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
636 | - if (!$start_invalid) |
|
637 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
638 | - else |
|
639 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
661 | + if (!$start_invalid) { |
|
662 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
663 | + } else { |
|
664 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
665 | + } |
|
640 | 666 | |
641 | 667 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
642 | 668 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
643 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
644 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
669 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
670 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
645 | 671 | { |
646 | 672 | $tmpStart = $start + $num_per_page * $nCont; |
673 | + } |
|
647 | 674 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
648 | 675 | } |
649 | 676 | |
650 | 677 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
651 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
652 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
678 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
679 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
653 | 680 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
654 | 681 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
655 | 682 | '{LAST_PAGE}' => $tmpMaxPages, |
656 | 683 | '{PER_PAGE}' => $num_per_page, |
657 | 684 | )); |
685 | + } |
|
658 | 686 | |
659 | 687 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
660 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
661 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
688 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
689 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
690 | + } |
|
662 | 691 | |
663 | 692 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
664 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
665 | - $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
693 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
694 | + $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
695 | + } |
|
666 | 696 | } |
667 | 697 | $pageindex .= $settings['page_index']['extra_after']; |
668 | 698 | |
@@ -688,8 +718,9 @@ discard block |
||
688 | 718 | if ($decimal_separator === null) |
689 | 719 | { |
690 | 720 | // Not set for whatever reason? |
691 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
692 | - return $number; |
|
721 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
722 | + return $number; |
|
723 | + } |
|
693 | 724 | |
694 | 725 | // Cache these each load... |
695 | 726 | $thousands_separator = $matches[1]; |
@@ -723,17 +754,20 @@ discard block |
||
723 | 754 | static $unsupportedFormats, $finalizedFormats; |
724 | 755 | |
725 | 756 | // Offset the time. |
726 | - if (!$offset_type) |
|
727 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
757 | + if (!$offset_type) { |
|
758 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
759 | + } |
|
728 | 760 | // Just the forum offset? |
729 | - elseif ($offset_type == 'forum') |
|
730 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
731 | - else |
|
732 | - $time = $log_time; |
|
761 | + elseif ($offset_type == 'forum') { |
|
762 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
763 | + } else { |
|
764 | + $time = $log_time; |
|
765 | + } |
|
733 | 766 | |
734 | 767 | // We can't have a negative date (on Windows, at least.) |
735 | - if ($log_time < 0) |
|
736 | - $log_time = 0; |
|
768 | + if ($log_time < 0) { |
|
769 | + $log_time = 0; |
|
770 | + } |
|
737 | 771 | |
738 | 772 | // Today and Yesterday? |
739 | 773 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -750,24 +784,27 @@ discard block |
||
750 | 784 | { |
751 | 785 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
752 | 786 | $today_fmt = $h . ':%M' . $s . ' %p'; |
787 | + } else { |
|
788 | + $today_fmt = '%H:%M' . $s; |
|
753 | 789 | } |
754 | - else |
|
755 | - $today_fmt = '%H:%M' . $s; |
|
756 | 790 | |
757 | 791 | // Same day of the year, same year.... Today! |
758 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
759 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
792 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
793 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
794 | + } |
|
760 | 795 | |
761 | 796 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
762 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
763 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
797 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
798 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
799 | + } |
|
764 | 800 | } |
765 | 801 | |
766 | 802 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
767 | 803 | |
768 | 804 | // Use the cached formats if available |
769 | - if (is_null($finalizedFormats)) |
|
770 | - $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
805 | + if (is_null($finalizedFormats)) { |
|
806 | + $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
807 | + } |
|
771 | 808 | |
772 | 809 | // Make a supported version for this format if we don't already have one |
773 | 810 | if (empty($finalizedFormats[$str])) |
@@ -796,8 +833,9 @@ discard block |
||
796 | 833 | ); |
797 | 834 | |
798 | 835 | // No need to do this part again if we already did it once |
799 | - if (is_null($unsupportedFormats)) |
|
800 | - $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
836 | + if (is_null($unsupportedFormats)) { |
|
837 | + $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
838 | + } |
|
801 | 839 | if (empty($unsupportedFormats)) |
802 | 840 | { |
803 | 841 | foreach($strftimeFormatSubstitutions as $format => $substitution) |
@@ -806,20 +844,23 @@ discard block |
||
806 | 844 | |
807 | 845 | // Windows will return false for unsupported formats |
808 | 846 | // Other operating systems return the format string as a literal |
809 | - if ($value === false || $value === $format) |
|
810 | - $unsupportedFormats[] = $format; |
|
847 | + if ($value === false || $value === $format) { |
|
848 | + $unsupportedFormats[] = $format; |
|
849 | + } |
|
811 | 850 | } |
812 | 851 | cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400); |
813 | 852 | } |
814 | 853 | |
815 | 854 | // Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q' |
816 | - if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') |
|
817 | - $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
855 | + if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') { |
|
856 | + $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
857 | + } |
|
818 | 858 | |
819 | 859 | // Substitute unsupported formats with supported ones |
820 | - if (!empty($unsupportedFormats)) |
|
821 | - while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
860 | + if (!empty($unsupportedFormats)) { |
|
861 | + while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
822 | 862 | $timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat); |
863 | + } |
|
823 | 864 | |
824 | 865 | // Remember this so we don't need to do it again |
825 | 866 | $finalizedFormats[$str] = $timeformat; |
@@ -828,33 +869,39 @@ discard block |
||
828 | 869 | |
829 | 870 | $str = $finalizedFormats[$str]; |
830 | 871 | |
831 | - if (!isset($locale_cache)) |
|
832 | - $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
872 | + if (!isset($locale_cache)) { |
|
873 | + $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
874 | + } |
|
833 | 875 | |
834 | 876 | if ($locale_cache !== false) |
835 | 877 | { |
836 | 878 | // Check if another process changed the locale |
837 | - if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) |
|
838 | - setlocale(LC_TIME, $txt['lang_locale']); |
|
879 | + if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) { |
|
880 | + setlocale(LC_TIME, $txt['lang_locale']); |
|
881 | + } |
|
839 | 882 | |
840 | - if (!isset($non_twelve_hour)) |
|
841 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
842 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
843 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
883 | + if (!isset($non_twelve_hour)) { |
|
884 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
885 | + } |
|
886 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
887 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
888 | + } |
|
844 | 889 | |
845 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
846 | - if (strpos($str, $token) !== false) |
|
890 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
891 | + if (strpos($str, $token) !== false) |
|
847 | 892 | $str = str_replace($token, strftime($token, $time), $str); |
848 | - } |
|
849 | - else |
|
893 | + } |
|
894 | + } else |
|
850 | 895 | { |
851 | 896 | // Do-it-yourself time localization. Fun. |
852 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
853 | - if (strpos($str, $token) !== false) |
|
897 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
898 | + if (strpos($str, $token) !== false) |
|
854 | 899 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
900 | + } |
|
855 | 901 | |
856 | - if (strpos($str, '%p') !== false) |
|
857 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
902 | + if (strpos($str, '%p') !== false) { |
|
903 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
904 | + } |
|
858 | 905 | } |
859 | 906 | |
860 | 907 | // Format the time and then restore any literal percent characters |
@@ -877,16 +924,19 @@ discard block |
||
877 | 924 | static $translation = array(); |
878 | 925 | |
879 | 926 | // Determine the character set... Default to UTF-8 |
880 | - if (empty($context['character_set'])) |
|
881 | - $charset = 'UTF-8'; |
|
927 | + if (empty($context['character_set'])) { |
|
928 | + $charset = 'UTF-8'; |
|
929 | + } |
|
882 | 930 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
883 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
884 | - $charset = 'ISO-8859-1'; |
|
885 | - else |
|
886 | - $charset = $context['character_set']; |
|
931 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
932 | + $charset = 'ISO-8859-1'; |
|
933 | + } else { |
|
934 | + $charset = $context['character_set']; |
|
935 | + } |
|
887 | 936 | |
888 | - if (empty($translation)) |
|
889 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
937 | + if (empty($translation)) { |
|
938 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
939 | + } |
|
890 | 940 | |
891 | 941 | return strtr($string, $translation); |
892 | 942 | } |
@@ -908,8 +958,9 @@ discard block |
||
908 | 958 | global $smcFunc; |
909 | 959 | |
910 | 960 | // It was already short enough! |
911 | - if ($smcFunc['strlen']($subject) <= $len) |
|
912 | - return $subject; |
|
961 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
962 | + return $subject; |
|
963 | + } |
|
913 | 964 | |
914 | 965 | // Shorten it by the length it was too long, and strip off junk from the end. |
915 | 966 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -928,10 +979,11 @@ discard block |
||
928 | 979 | { |
929 | 980 | global $user_info, $modSettings; |
930 | 981 | |
931 | - if ($timestamp === null) |
|
932 | - $timestamp = time(); |
|
933 | - elseif ($timestamp == 0) |
|
934 | - return 0; |
|
982 | + if ($timestamp === null) { |
|
983 | + $timestamp = time(); |
|
984 | + } elseif ($timestamp == 0) { |
|
985 | + return 0; |
|
986 | + } |
|
935 | 987 | |
936 | 988 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
937 | 989 | } |
@@ -960,8 +1012,9 @@ discard block |
||
960 | 1012 | $array[$i] = $array[$j]; |
961 | 1013 | $array[$j] = $temp; |
962 | 1014 | |
963 | - for ($i = 1; $p[$i] == 0; $i++) |
|
964 | - $p[$i] = 1; |
|
1015 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
1016 | + $p[$i] = 1; |
|
1017 | + } |
|
965 | 1018 | |
966 | 1019 | $orders[] = $array; |
967 | 1020 | } |
@@ -993,12 +1046,14 @@ discard block |
||
993 | 1046 | static $disabled; |
994 | 1047 | |
995 | 1048 | // Don't waste cycles |
996 | - if ($message === '') |
|
997 | - return ''; |
|
1049 | + if ($message === '') { |
|
1050 | + return ''; |
|
1051 | + } |
|
998 | 1052 | |
999 | 1053 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
1000 | - if (!isset($context['utf8'])) |
|
1001 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1054 | + if (!isset($context['utf8'])) { |
|
1055 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1056 | + } |
|
1002 | 1057 | |
1003 | 1058 | // Clean up any cut/paste issues we may have |
1004 | 1059 | $message = sanitizeMSCutPaste($message); |
@@ -1010,13 +1065,15 @@ discard block |
||
1010 | 1065 | return $message; |
1011 | 1066 | } |
1012 | 1067 | |
1013 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
1014 | - $smileys = (bool) $smileys; |
|
1068 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
1069 | + $smileys = (bool) $smileys; |
|
1070 | + } |
|
1015 | 1071 | |
1016 | 1072 | if (empty($modSettings['enableBBC']) && $message !== false) |
1017 | 1073 | { |
1018 | - if ($smileys === true) |
|
1019 | - parsesmileys($message); |
|
1074 | + if ($smileys === true) { |
|
1075 | + parsesmileys($message); |
|
1076 | + } |
|
1020 | 1077 | |
1021 | 1078 | return $message; |
1022 | 1079 | } |
@@ -1029,8 +1086,9 @@ discard block |
||
1029 | 1086 | } |
1030 | 1087 | |
1031 | 1088 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
1032 | - if (!empty($modSettings['autoLinkUrls'])) |
|
1033 | - set_tld_regex(); |
|
1089 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
1090 | + set_tld_regex(); |
|
1091 | + } |
|
1034 | 1092 | |
1035 | 1093 | // Allow mods access before entering the main parse_bbc loop |
1036 | 1094 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1044,12 +1102,14 @@ discard block |
||
1044 | 1102 | |
1045 | 1103 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
1046 | 1104 | |
1047 | - foreach ($temp as $tag) |
|
1048 | - $disabled[trim($tag)] = true; |
|
1105 | + foreach ($temp as $tag) { |
|
1106 | + $disabled[trim($tag)] = true; |
|
1107 | + } |
|
1049 | 1108 | } |
1050 | 1109 | |
1051 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1052 | - $disabled['flash'] = true; |
|
1110 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1111 | + $disabled['flash'] = true; |
|
1112 | + } |
|
1053 | 1113 | |
1054 | 1114 | /* The following bbc are formatted as an array, with keys as follows: |
1055 | 1115 | |
@@ -1170,8 +1230,9 @@ discard block |
||
1170 | 1230 | $returnContext = ''; |
1171 | 1231 | |
1172 | 1232 | // BBC or the entire attachments feature is disabled |
1173 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
1174 | - return $data; |
|
1233 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
1234 | + return $data; |
|
1235 | + } |
|
1175 | 1236 | |
1176 | 1237 | // Save the attach ID. |
1177 | 1238 | $attachID = $data; |
@@ -1182,8 +1243,9 @@ discard block |
||
1182 | 1243 | $currentAttachment = parseAttachBBC($attachID); |
1183 | 1244 | |
1184 | 1245 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
1185 | - if (is_string($currentAttachment)) |
|
1186 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1246 | + if (is_string($currentAttachment)) { |
|
1247 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1248 | + } |
|
1187 | 1249 | |
1188 | 1250 | if (!empty($currentAttachment['is_image'])) |
1189 | 1251 | { |
@@ -1199,15 +1261,17 @@ discard block |
||
1199 | 1261 | $height = ' height="' . $currentAttachment['height'] . '"'; |
1200 | 1262 | } |
1201 | 1263 | |
1202 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
1203 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1204 | - else |
|
1205 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1264 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
1265 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1266 | + } else { |
|
1267 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1268 | + } |
|
1206 | 1269 | } |
1207 | 1270 | |
1208 | 1271 | // No image. Show a link. |
1209 | - else |
|
1210 | - $returnContext .= $currentAttachment['link']; |
|
1272 | + else { |
|
1273 | + $returnContext .= $currentAttachment['link']; |
|
1274 | + } |
|
1211 | 1275 | |
1212 | 1276 | // Gotta append what we just did. |
1213 | 1277 | $data = $returnContext; |
@@ -1238,8 +1302,9 @@ discard block |
||
1238 | 1302 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1239 | 1303 | { |
1240 | 1304 | // Do PHP code coloring? |
1241 | - if ($php_parts[$php_i] != '<?php') |
|
1242 | - continue; |
|
1305 | + if ($php_parts[$php_i] != '<?php') { |
|
1306 | + continue; |
|
1307 | + } |
|
1243 | 1308 | |
1244 | 1309 | $php_string = ''; |
1245 | 1310 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1255,8 +1320,9 @@ discard block |
||
1255 | 1320 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
1256 | 1321 | |
1257 | 1322 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1258 | - if ($context['browser']['is_opera']) |
|
1259 | - $data .= ' '; |
|
1323 | + if ($context['browser']['is_opera']) { |
|
1324 | + $data .= ' '; |
|
1325 | + } |
|
1260 | 1326 | } |
1261 | 1327 | }, |
1262 | 1328 | 'block_level' => true, |
@@ -1275,8 +1341,9 @@ discard block |
||
1275 | 1341 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1276 | 1342 | { |
1277 | 1343 | // Do PHP code coloring? |
1278 | - if ($php_parts[$php_i] != '<?php') |
|
1279 | - continue; |
|
1344 | + if ($php_parts[$php_i] != '<?php') { |
|
1345 | + continue; |
|
1346 | + } |
|
1280 | 1347 | |
1281 | 1348 | $php_string = ''; |
1282 | 1349 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1292,8 +1359,9 @@ discard block |
||
1292 | 1359 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
1293 | 1360 | |
1294 | 1361 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1295 | - if ($context['browser']['is_opera']) |
|
1296 | - $data[0] .= ' '; |
|
1362 | + if ($context['browser']['is_opera']) { |
|
1363 | + $data[0] .= ' '; |
|
1364 | + } |
|
1297 | 1365 | } |
1298 | 1366 | }, |
1299 | 1367 | 'block_level' => true, |
@@ -1331,11 +1399,13 @@ discard block |
||
1331 | 1399 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1332 | 1400 | 'validate' => function (&$tag, &$data, $disabled) |
1333 | 1401 | { |
1334 | - if (isset($disabled['url'])) |
|
1335 | - $tag['content'] = '$1'; |
|
1402 | + if (isset($disabled['url'])) { |
|
1403 | + $tag['content'] = '$1'; |
|
1404 | + } |
|
1336 | 1405 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
1337 | - if (empty($scheme)) |
|
1338 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
1406 | + if (empty($scheme)) { |
|
1407 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
1408 | + } |
|
1339 | 1409 | }, |
1340 | 1410 | 'disabled_content' => '<a href="$1" target="_blank">$1</a>', |
1341 | 1411 | ), |
@@ -1349,10 +1419,11 @@ discard block |
||
1349 | 1419 | { |
1350 | 1420 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1351 | 1421 | |
1352 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
1353 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1354 | - else |
|
1355 | - $css = ''; |
|
1422 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
1423 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1424 | + } else { |
|
1425 | + $css = ''; |
|
1426 | + } |
|
1356 | 1427 | |
1357 | 1428 | $data = $class . $css; |
1358 | 1429 | }, |
@@ -1402,14 +1473,16 @@ discard block |
||
1402 | 1473 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1403 | 1474 | if ($image_proxy_enabled) |
1404 | 1475 | { |
1405 | - if (empty($scheme)) |
|
1406 | - $data = 'http://' . ltrim($data, ':/'); |
|
1476 | + if (empty($scheme)) { |
|
1477 | + $data = 'http://' . ltrim($data, ':/'); |
|
1478 | + } |
|
1407 | 1479 | |
1408 | - if ($scheme != 'https') |
|
1409 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1480 | + if ($scheme != 'https') { |
|
1481 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1482 | + } |
|
1483 | + } elseif (empty($scheme)) { |
|
1484 | + $data = '//' . ltrim($data, ':/'); |
|
1410 | 1485 | } |
1411 | - elseif (empty($scheme)) |
|
1412 | - $data = '//' . ltrim($data, ':/'); |
|
1413 | 1486 | }, |
1414 | 1487 | 'disabled_content' => '($1)', |
1415 | 1488 | ), |
@@ -1425,14 +1498,16 @@ discard block |
||
1425 | 1498 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1426 | 1499 | if ($image_proxy_enabled) |
1427 | 1500 | { |
1428 | - if (empty($scheme)) |
|
1429 | - $data = 'http://' . ltrim($data, ':/'); |
|
1501 | + if (empty($scheme)) { |
|
1502 | + $data = 'http://' . ltrim($data, ':/'); |
|
1503 | + } |
|
1430 | 1504 | |
1431 | - if ($scheme != 'https') |
|
1432 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1505 | + if ($scheme != 'https') { |
|
1506 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1507 | + } |
|
1508 | + } elseif (empty($scheme)) { |
|
1509 | + $data = '//' . ltrim($data, ':/'); |
|
1433 | 1510 | } |
1434 | - elseif (empty($scheme)) |
|
1435 | - $data = '//' . ltrim($data, ':/'); |
|
1436 | 1511 | }, |
1437 | 1512 | 'disabled_content' => '($1)', |
1438 | 1513 | ), |
@@ -1444,8 +1519,9 @@ discard block |
||
1444 | 1519 | { |
1445 | 1520 | $data = strtr($data, array('<br>' => '')); |
1446 | 1521 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1447 | - if (empty($scheme)) |
|
1448 | - $data = '//' . ltrim($data, ':/'); |
|
1522 | + if (empty($scheme)) { |
|
1523 | + $data = '//' . ltrim($data, ':/'); |
|
1524 | + } |
|
1449 | 1525 | }, |
1450 | 1526 | ), |
1451 | 1527 | array( |
@@ -1456,13 +1532,14 @@ discard block |
||
1456 | 1532 | 'after' => '</a>', |
1457 | 1533 | 'validate' => function (&$tag, &$data, $disabled) |
1458 | 1534 | { |
1459 | - if (substr($data, 0, 1) == '#') |
|
1460 | - $data = '#post_' . substr($data, 1); |
|
1461 | - else |
|
1535 | + if (substr($data, 0, 1) == '#') { |
|
1536 | + $data = '#post_' . substr($data, 1); |
|
1537 | + } else |
|
1462 | 1538 | { |
1463 | 1539 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1464 | - if (empty($scheme)) |
|
1465 | - $data = '//' . ltrim($data, ':/'); |
|
1540 | + if (empty($scheme)) { |
|
1541 | + $data = '//' . ltrim($data, ':/'); |
|
1542 | + } |
|
1466 | 1543 | } |
1467 | 1544 | }, |
1468 | 1545 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1540,8 +1617,9 @@ discard block |
||
1540 | 1617 | { |
1541 | 1618 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
1542 | 1619 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
1543 | - if ($add_begin) |
|
1544 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1620 | + if ($add_begin) { |
|
1621 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1622 | + } |
|
1545 | 1623 | } |
1546 | 1624 | }, |
1547 | 1625 | 'block_level' => false, |
@@ -1672,10 +1750,11 @@ discard block |
||
1672 | 1750 | 'content' => '$1', |
1673 | 1751 | 'validate' => function (&$tag, &$data, $disabled) |
1674 | 1752 | { |
1675 | - if (is_numeric($data)) |
|
1676 | - $data = timeformat($data); |
|
1677 | - else |
|
1678 | - $tag['content'] = '[time]$1[/time]'; |
|
1753 | + if (is_numeric($data)) { |
|
1754 | + $data = timeformat($data); |
|
1755 | + } else { |
|
1756 | + $tag['content'] = '[time]$1[/time]'; |
|
1757 | + } |
|
1679 | 1758 | }, |
1680 | 1759 | ), |
1681 | 1760 | array( |
@@ -1702,8 +1781,9 @@ discard block |
||
1702 | 1781 | { |
1703 | 1782 | $data = strtr($data, array('<br>' => '')); |
1704 | 1783 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1705 | - if (empty($scheme)) |
|
1706 | - $data = '//' . ltrim($data, ':/'); |
|
1784 | + if (empty($scheme)) { |
|
1785 | + $data = '//' . ltrim($data, ':/'); |
|
1786 | + } |
|
1707 | 1787 | }, |
1708 | 1788 | ), |
1709 | 1789 | array( |
@@ -1715,8 +1795,9 @@ discard block |
||
1715 | 1795 | 'validate' => function (&$tag, &$data, $disabled) |
1716 | 1796 | { |
1717 | 1797 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1718 | - if (empty($scheme)) |
|
1719 | - $data = '//' . ltrim($data, ':/'); |
|
1798 | + if (empty($scheme)) { |
|
1799 | + $data = '//' . ltrim($data, ':/'); |
|
1800 | + } |
|
1720 | 1801 | }, |
1721 | 1802 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
1722 | 1803 | 'disabled_after' => ' ($1)', |
@@ -1736,8 +1817,9 @@ discard block |
||
1736 | 1817 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
1737 | 1818 | if ($message === false) |
1738 | 1819 | { |
1739 | - if (isset($temp_bbc)) |
|
1740 | - $bbc_codes = $temp_bbc; |
|
1820 | + if (isset($temp_bbc)) { |
|
1821 | + $bbc_codes = $temp_bbc; |
|
1822 | + } |
|
1741 | 1823 | usort($codes, function ($a, $b) { |
1742 | 1824 | return strcmp($a['tag'], $b['tag']); |
1743 | 1825 | }); |
@@ -1757,8 +1839,9 @@ discard block |
||
1757 | 1839 | ); |
1758 | 1840 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
1759 | 1841 | { |
1760 | - foreach ($itemcodes as $c => $dummy) |
|
1761 | - $bbc_codes[$c] = array(); |
|
1842 | + foreach ($itemcodes as $c => $dummy) { |
|
1843 | + $bbc_codes[$c] = array(); |
|
1844 | + } |
|
1762 | 1845 | } |
1763 | 1846 | |
1764 | 1847 | // Shhhh! |
@@ -1779,12 +1862,14 @@ discard block |
||
1779 | 1862 | foreach ($codes as $code) |
1780 | 1863 | { |
1781 | 1864 | // Make it easier to process parameters later |
1782 | - if (!empty($code['parameters'])) |
|
1783 | - ksort($code['parameters'], SORT_STRING); |
|
1865 | + if (!empty($code['parameters'])) { |
|
1866 | + ksort($code['parameters'], SORT_STRING); |
|
1867 | + } |
|
1784 | 1868 | |
1785 | 1869 | // If we are not doing every tag only do ones we are interested in. |
1786 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
1787 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1870 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
1871 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1872 | + } |
|
1788 | 1873 | } |
1789 | 1874 | $codes = null; |
1790 | 1875 | } |
@@ -1795,8 +1880,9 @@ discard block |
||
1795 | 1880 | // It's likely this will change if the message is modified. |
1796 | 1881 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
1797 | 1882 | |
1798 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
1799 | - return $temp; |
|
1883 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
1884 | + return $temp; |
|
1885 | + } |
|
1800 | 1886 | |
1801 | 1887 | $cache_t = microtime(); |
1802 | 1888 | } |
@@ -1828,8 +1914,9 @@ discard block |
||
1828 | 1914 | $disabled['flash'] = true; |
1829 | 1915 | |
1830 | 1916 | // @todo Change maybe? |
1831 | - if (!isset($_GET['images'])) |
|
1832 | - $disabled['img'] = true; |
|
1917 | + if (!isset($_GET['images'])) { |
|
1918 | + $disabled['img'] = true; |
|
1919 | + } |
|
1833 | 1920 | |
1834 | 1921 | // @todo Interface/setting to add more? |
1835 | 1922 | } |
@@ -1853,8 +1940,9 @@ discard block |
||
1853 | 1940 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
1854 | 1941 | |
1855 | 1942 | // Failsafe. |
1856 | - if ($pos === false || $last_pos > $pos) |
|
1857 | - $pos = strlen($message) + 1; |
|
1943 | + if ($pos === false || $last_pos > $pos) { |
|
1944 | + $pos = strlen($message) + 1; |
|
1945 | + } |
|
1858 | 1946 | |
1859 | 1947 | // Can't have a one letter smiley, URL, or email! (sorry.) |
1860 | 1948 | if ($last_pos < $pos - 1) |
@@ -1872,8 +1960,9 @@ discard block |
||
1872 | 1960 | |
1873 | 1961 | // <br> should be empty. |
1874 | 1962 | $empty_tags = array('br', 'hr'); |
1875 | - foreach ($empty_tags as $tag) |
|
1876 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1963 | + foreach ($empty_tags as $tag) { |
|
1964 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1965 | + } |
|
1877 | 1966 | |
1878 | 1967 | // b, u, i, s, pre... basic tags. |
1879 | 1968 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong'); |
@@ -1882,8 +1971,9 @@ discard block |
||
1882 | 1971 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
1883 | 1972 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
1884 | 1973 | |
1885 | - if ($diff > 0) |
|
1886 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1974 | + if ($diff > 0) { |
|
1975 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1976 | + } |
|
1887 | 1977 | } |
1888 | 1978 | |
1889 | 1979 | // Do <img ...> - with security... action= -> action-. |
@@ -1896,8 +1986,9 @@ discard block |
||
1896 | 1986 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
1897 | 1987 | |
1898 | 1988 | // Remove action= from the URL - no funny business, now. |
1899 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
1900 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
1989 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
1990 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
1991 | + } |
|
1901 | 1992 | |
1902 | 1993 | // Check if the image is larger than allowed. |
1903 | 1994 | if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height'])) |
@@ -1918,9 +2009,9 @@ discard block |
||
1918 | 2009 | |
1919 | 2010 | // Set the new image tag. |
1920 | 2011 | $replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]'; |
2012 | + } else { |
|
2013 | + $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1921 | 2014 | } |
1922 | - else |
|
1923 | - $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1924 | 2015 | } |
1925 | 2016 | |
1926 | 2017 | $data = strtr($data, $replaces); |
@@ -1933,16 +2024,18 @@ discard block |
||
1933 | 2024 | $no_autolink_area = false; |
1934 | 2025 | if (!empty($open_tags)) |
1935 | 2026 | { |
1936 | - foreach ($open_tags as $open_tag) |
|
1937 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
2027 | + foreach ($open_tags as $open_tag) { |
|
2028 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
1938 | 2029 | $no_autolink_area = true; |
2030 | + } |
|
1939 | 2031 | } |
1940 | 2032 | |
1941 | 2033 | // Don't go backwards. |
1942 | 2034 | // @todo Don't think is the real solution.... |
1943 | 2035 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
1944 | - if ($pos < $lastAutoPos) |
|
1945 | - $no_autolink_area = true; |
|
2036 | + if ($pos < $lastAutoPos) { |
|
2037 | + $no_autolink_area = true; |
|
2038 | + } |
|
1946 | 2039 | $lastAutoPos = $pos; |
1947 | 2040 | |
1948 | 2041 | if (!$no_autolink_area) |
@@ -2051,17 +2144,19 @@ discard block |
||
2051 | 2144 | if ($scheme == 'mailto') |
2052 | 2145 | { |
2053 | 2146 | $email_address = str_replace('mailto:', '', $url); |
2054 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
2055 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2056 | - else |
|
2057 | - return $url; |
|
2147 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
2148 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2149 | + } else { |
|
2150 | + return $url; |
|
2151 | + } |
|
2058 | 2152 | } |
2059 | 2153 | |
2060 | 2154 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
2061 | - if (empty($scheme)) |
|
2062 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
2063 | - else |
|
2064 | - $fullUrl = $url; |
|
2155 | + if (empty($scheme)) { |
|
2156 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
2157 | + } else { |
|
2158 | + $fullUrl = $url; |
|
2159 | + } |
|
2065 | 2160 | |
2066 | 2161 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
2067 | 2162 | }, $data); |
@@ -2110,16 +2205,18 @@ discard block |
||
2110 | 2205 | } |
2111 | 2206 | |
2112 | 2207 | // Are we there yet? Are we there yet? |
2113 | - if ($pos >= strlen($message) - 1) |
|
2114 | - break; |
|
2208 | + if ($pos >= strlen($message) - 1) { |
|
2209 | + break; |
|
2210 | + } |
|
2115 | 2211 | |
2116 | 2212 | $tags = strtolower($message[$pos + 1]); |
2117 | 2213 | |
2118 | 2214 | if ($tags == '/' && !empty($open_tags)) |
2119 | 2215 | { |
2120 | 2216 | $pos2 = strpos($message, ']', $pos + 1); |
2121 | - if ($pos2 == $pos + 2) |
|
2122 | - continue; |
|
2217 | + if ($pos2 == $pos + 2) { |
|
2218 | + continue; |
|
2219 | + } |
|
2123 | 2220 | |
2124 | 2221 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
2125 | 2222 | |
@@ -2129,8 +2226,9 @@ discard block |
||
2129 | 2226 | do |
2130 | 2227 | { |
2131 | 2228 | $tag = array_pop($open_tags); |
2132 | - if (!$tag) |
|
2133 | - break; |
|
2229 | + if (!$tag) { |
|
2230 | + break; |
|
2231 | + } |
|
2134 | 2232 | |
2135 | 2233 | if (!empty($tag['block_level'])) |
2136 | 2234 | { |
@@ -2144,10 +2242,11 @@ discard block |
||
2144 | 2242 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
2145 | 2243 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
2146 | 2244 | { |
2147 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2148 | - if ($temp['tag'] == $look_for) |
|
2245 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2246 | + if ($temp['tag'] == $look_for) |
|
2149 | 2247 | { |
2150 | 2248 | $block_level = !empty($temp['block_level']); |
2249 | + } |
|
2151 | 2250 | break; |
2152 | 2251 | } |
2153 | 2252 | } |
@@ -2169,15 +2268,15 @@ discard block |
||
2169 | 2268 | { |
2170 | 2269 | $open_tags = $to_close; |
2171 | 2270 | continue; |
2172 | - } |
|
2173 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2271 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2174 | 2272 | { |
2175 | 2273 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
2176 | 2274 | { |
2177 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2178 | - if ($temp['tag'] == $look_for) |
|
2275 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2276 | + if ($temp['tag'] == $look_for) |
|
2179 | 2277 | { |
2180 | 2278 | $block_level = !empty($temp['block_level']); |
2279 | + } |
|
2181 | 2280 | break; |
2182 | 2281 | } |
2183 | 2282 | } |
@@ -2185,8 +2284,9 @@ discard block |
||
2185 | 2284 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
2186 | 2285 | if (!$block_level) |
2187 | 2286 | { |
2188 | - foreach ($to_close as $tag) |
|
2189 | - array_push($open_tags, $tag); |
|
2287 | + foreach ($to_close as $tag) { |
|
2288 | + array_push($open_tags, $tag); |
|
2289 | + } |
|
2190 | 2290 | continue; |
2191 | 2291 | } |
2192 | 2292 | } |
@@ -2199,14 +2299,17 @@ discard block |
||
2199 | 2299 | |
2200 | 2300 | // See the comment at the end of the big loop - just eating whitespace ;). |
2201 | 2301 | $whitespace_regex = ''; |
2202 | - if (!empty($tag['block_level'])) |
|
2203 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2302 | + if (!empty($tag['block_level'])) { |
|
2303 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2304 | + } |
|
2204 | 2305 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
2205 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2206 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2306 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2307 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2308 | + } |
|
2207 | 2309 | |
2208 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2209 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2310 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2311 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2312 | + } |
|
2210 | 2313 | } |
2211 | 2314 | |
2212 | 2315 | if (!empty($to_close)) |
@@ -2219,8 +2322,9 @@ discard block |
||
2219 | 2322 | } |
2220 | 2323 | |
2221 | 2324 | // No tags for this character, so just keep going (fastest possible course.) |
2222 | - if (!isset($bbc_codes[$tags])) |
|
2223 | - continue; |
|
2325 | + if (!isset($bbc_codes[$tags])) { |
|
2326 | + continue; |
|
2327 | + } |
|
2224 | 2328 | |
2225 | 2329 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
2226 | 2330 | $tag = null; |
@@ -2229,44 +2333,52 @@ discard block |
||
2229 | 2333 | $pt_strlen = strlen($possible['tag']); |
2230 | 2334 | |
2231 | 2335 | // Not a match? |
2232 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
2233 | - continue; |
|
2336 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
2337 | + continue; |
|
2338 | + } |
|
2234 | 2339 | |
2235 | 2340 | $next_c = $message[$pos + 1 + $pt_strlen]; |
2236 | 2341 | |
2237 | 2342 | // A test validation? |
2238 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
2239 | - continue; |
|
2343 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
2344 | + continue; |
|
2345 | + } |
|
2240 | 2346 | // Do we want parameters? |
2241 | 2347 | elseif (!empty($possible['parameters'])) |
2242 | 2348 | { |
2243 | - if ($next_c != ' ') |
|
2244 | - continue; |
|
2245 | - } |
|
2246 | - elseif (isset($possible['type'])) |
|
2349 | + if ($next_c != ' ') { |
|
2350 | + continue; |
|
2351 | + } |
|
2352 | + } elseif (isset($possible['type'])) |
|
2247 | 2353 | { |
2248 | 2354 | // Do we need an equal sign? |
2249 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
2250 | - continue; |
|
2355 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
2356 | + continue; |
|
2357 | + } |
|
2251 | 2358 | // Maybe we just want a /... |
2252 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
2253 | - continue; |
|
2359 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
2360 | + continue; |
|
2361 | + } |
|
2254 | 2362 | // An immediate ]? |
2255 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
2256 | - continue; |
|
2363 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
2364 | + continue; |
|
2365 | + } |
|
2257 | 2366 | } |
2258 | 2367 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
2259 | - elseif ($next_c != ']') |
|
2260 | - continue; |
|
2368 | + elseif ($next_c != ']') { |
|
2369 | + continue; |
|
2370 | + } |
|
2261 | 2371 | |
2262 | 2372 | // Check allowed tree? |
2263 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
2264 | - continue; |
|
2265 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
2266 | - continue; |
|
2373 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
2374 | + continue; |
|
2375 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
2376 | + continue; |
|
2377 | + } |
|
2267 | 2378 | // If this is in the list of disallowed child tags, don't parse it. |
2268 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
2269 | - continue; |
|
2379 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
2380 | + continue; |
|
2381 | + } |
|
2270 | 2382 | |
2271 | 2383 | $pos1 = $pos + 1 + $pt_strlen + 1; |
2272 | 2384 | |
@@ -2278,8 +2390,9 @@ discard block |
||
2278 | 2390 | foreach ($open_tags as $open_quote) |
2279 | 2391 | { |
2280 | 2392 | // Every parent quote this quote has flips the styling |
2281 | - if ($open_quote['tag'] == 'quote') |
|
2282 | - $quote_alt = !$quote_alt; |
|
2393 | + if ($open_quote['tag'] == 'quote') { |
|
2394 | + $quote_alt = !$quote_alt; |
|
2395 | + } |
|
2283 | 2396 | } |
2284 | 2397 | // Add a class to the quote to style alternating blockquotes |
2285 | 2398 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2290,8 +2403,9 @@ discard block |
||
2290 | 2403 | { |
2291 | 2404 | // Build a regular expression for each parameter for the current tag. |
2292 | 2405 | $preg = array(); |
2293 | - foreach ($possible['parameters'] as $p => $info) |
|
2294 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2406 | + foreach ($possible['parameters'] as $p => $info) { |
|
2407 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2408 | + } |
|
2295 | 2409 | |
2296 | 2410 | // Extract the string that potentially holds our parameters. |
2297 | 2411 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2311,24 +2425,27 @@ discard block |
||
2311 | 2425 | |
2312 | 2426 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
2313 | 2427 | |
2314 | - if ($match) |
|
2315 | - $blob_counter = count($blobs) + 1; |
|
2428 | + if ($match) { |
|
2429 | + $blob_counter = count($blobs) + 1; |
|
2430 | + } |
|
2316 | 2431 | } |
2317 | 2432 | |
2318 | 2433 | // Didn't match our parameter list, try the next possible. |
2319 | - if (!$match) |
|
2320 | - continue; |
|
2434 | + if (!$match) { |
|
2435 | + continue; |
|
2436 | + } |
|
2321 | 2437 | |
2322 | 2438 | $params = array(); |
2323 | 2439 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
2324 | 2440 | { |
2325 | 2441 | $key = strtok(ltrim($matches[$i]), '='); |
2326 | - if (isset($possible['parameters'][$key]['value'])) |
|
2327 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2328 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
2329 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2330 | - else |
|
2331 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2442 | + if (isset($possible['parameters'][$key]['value'])) { |
|
2443 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2444 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
2445 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2446 | + } else { |
|
2447 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2448 | + } |
|
2332 | 2449 | |
2333 | 2450 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
2334 | 2451 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2336,23 +2453,26 @@ discard block |
||
2336 | 2453 | |
2337 | 2454 | foreach ($possible['parameters'] as $p => $info) |
2338 | 2455 | { |
2339 | - if (!isset($params['{' . $p . '}'])) |
|
2340 | - $params['{' . $p . '}'] = ''; |
|
2456 | + if (!isset($params['{' . $p . '}'])) { |
|
2457 | + $params['{' . $p . '}'] = ''; |
|
2458 | + } |
|
2341 | 2459 | } |
2342 | 2460 | |
2343 | 2461 | $tag = $possible; |
2344 | 2462 | |
2345 | 2463 | // Put the parameters into the string. |
2346 | - if (isset($tag['before'])) |
|
2347 | - $tag['before'] = strtr($tag['before'], $params); |
|
2348 | - if (isset($tag['after'])) |
|
2349 | - $tag['after'] = strtr($tag['after'], $params); |
|
2350 | - if (isset($tag['content'])) |
|
2351 | - $tag['content'] = strtr($tag['content'], $params); |
|
2464 | + if (isset($tag['before'])) { |
|
2465 | + $tag['before'] = strtr($tag['before'], $params); |
|
2466 | + } |
|
2467 | + if (isset($tag['after'])) { |
|
2468 | + $tag['after'] = strtr($tag['after'], $params); |
|
2469 | + } |
|
2470 | + if (isset($tag['content'])) { |
|
2471 | + $tag['content'] = strtr($tag['content'], $params); |
|
2472 | + } |
|
2352 | 2473 | |
2353 | 2474 | $pos1 += strlen($given_param_string); |
2354 | - } |
|
2355 | - else |
|
2475 | + } else |
|
2356 | 2476 | { |
2357 | 2477 | $tag = $possible; |
2358 | 2478 | $params = array(); |
@@ -2363,8 +2483,9 @@ discard block |
||
2363 | 2483 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
2364 | 2484 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
2365 | 2485 | { |
2366 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
2367 | - continue; |
|
2486 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
2487 | + continue; |
|
2488 | + } |
|
2368 | 2489 | |
2369 | 2490 | $tag = $itemcodes[$message[$pos + 1]]; |
2370 | 2491 | |
@@ -2385,9 +2506,9 @@ discard block |
||
2385 | 2506 | { |
2386 | 2507 | array_pop($open_tags); |
2387 | 2508 | $code = '</li>'; |
2509 | + } else { |
|
2510 | + $code = ''; |
|
2388 | 2511 | } |
2389 | - else |
|
2390 | - $code = ''; |
|
2391 | 2512 | |
2392 | 2513 | // Now we open a new tag. |
2393 | 2514 | $open_tags[] = array( |
@@ -2434,12 +2555,14 @@ discard block |
||
2434 | 2555 | } |
2435 | 2556 | |
2436 | 2557 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
2437 | - if ($tag === null) |
|
2438 | - continue; |
|
2558 | + if ($tag === null) { |
|
2559 | + continue; |
|
2560 | + } |
|
2439 | 2561 | |
2440 | 2562 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
2441 | - if (isset($inside['disallow_children'])) |
|
2442 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2563 | + if (isset($inside['disallow_children'])) { |
|
2564 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2565 | + } |
|
2443 | 2566 | |
2444 | 2567 | // Is this tag disabled? |
2445 | 2568 | if (isset($disabled[$tag['tag']])) |
@@ -2449,14 +2572,13 @@ discard block |
||
2449 | 2572 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
2450 | 2573 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
2451 | 2574 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
2452 | - } |
|
2453 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2575 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2454 | 2576 | { |
2455 | 2577 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
2456 | 2578 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
2579 | + } else { |
|
2580 | + $tag['content'] = $tag['disabled_content']; |
|
2457 | 2581 | } |
2458 | - else |
|
2459 | - $tag['content'] = $tag['disabled_content']; |
|
2460 | 2582 | } |
2461 | 2583 | |
2462 | 2584 | // we use this a lot |
@@ -2466,8 +2588,9 @@ discard block |
||
2466 | 2588 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
2467 | 2589 | { |
2468 | 2590 | $n = count($open_tags) - 1; |
2469 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
2470 | - $n--; |
|
2591 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
2592 | + $n--; |
|
2593 | + } |
|
2471 | 2594 | |
2472 | 2595 | // Close all the non block level tags so this tag isn't surrounded by them. |
2473 | 2596 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2479,12 +2602,15 @@ discard block |
||
2479 | 2602 | |
2480 | 2603 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
2481 | 2604 | $whitespace_regex = ''; |
2482 | - if (!empty($tag['block_level'])) |
|
2483 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2484 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2485 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2486 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2487 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2605 | + if (!empty($tag['block_level'])) { |
|
2606 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2607 | + } |
|
2608 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2609 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2610 | + } |
|
2611 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2612 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2613 | + } |
|
2488 | 2614 | |
2489 | 2615 | array_pop($open_tags); |
2490 | 2616 | } |
@@ -2502,16 +2628,19 @@ discard block |
||
2502 | 2628 | elseif ($tag['type'] == 'unparsed_content') |
2503 | 2629 | { |
2504 | 2630 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
2505 | - if ($pos2 === false) |
|
2506 | - continue; |
|
2631 | + if ($pos2 === false) { |
|
2632 | + continue; |
|
2633 | + } |
|
2507 | 2634 | |
2508 | 2635 | $data = substr($message, $pos1, $pos2 - $pos1); |
2509 | 2636 | |
2510 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
2511 | - $data = substr($data, 4); |
|
2637 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
2638 | + $data = substr($data, 4); |
|
2639 | + } |
|
2512 | 2640 | |
2513 | - if (isset($tag['validate'])) |
|
2514 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2641 | + if (isset($tag['validate'])) { |
|
2642 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2643 | + } |
|
2515 | 2644 | |
2516 | 2645 | $code = strtr($tag['content'], array('$1' => $data)); |
2517 | 2646 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2527,34 +2656,40 @@ discard block |
||
2527 | 2656 | if (isset($tag['quoted'])) |
2528 | 2657 | { |
2529 | 2658 | $quoted = substr($message, $pos1, 6) == '"'; |
2530 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2531 | - continue; |
|
2659 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2660 | + continue; |
|
2661 | + } |
|
2532 | 2662 | |
2533 | - if ($quoted) |
|
2534 | - $pos1 += 6; |
|
2663 | + if ($quoted) { |
|
2664 | + $pos1 += 6; |
|
2665 | + } |
|
2666 | + } else { |
|
2667 | + $quoted = false; |
|
2535 | 2668 | } |
2536 | - else |
|
2537 | - $quoted = false; |
|
2538 | 2669 | |
2539 | 2670 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2540 | - if ($pos2 === false) |
|
2541 | - continue; |
|
2671 | + if ($pos2 === false) { |
|
2672 | + continue; |
|
2673 | + } |
|
2542 | 2674 | |
2543 | 2675 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2544 | - if ($pos3 === false) |
|
2545 | - continue; |
|
2676 | + if ($pos3 === false) { |
|
2677 | + continue; |
|
2678 | + } |
|
2546 | 2679 | |
2547 | 2680 | $data = array( |
2548 | 2681 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
2549 | 2682 | substr($message, $pos1, $pos2 - $pos1) |
2550 | 2683 | ); |
2551 | 2684 | |
2552 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
2553 | - $data[0] = substr($data[0], 4); |
|
2685 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
2686 | + $data[0] = substr($data[0], 4); |
|
2687 | + } |
|
2554 | 2688 | |
2555 | 2689 | // Validation for my parking, please! |
2556 | - if (isset($tag['validate'])) |
|
2557 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2690 | + if (isset($tag['validate'])) { |
|
2691 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2692 | + } |
|
2558 | 2693 | |
2559 | 2694 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
2560 | 2695 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2571,23 +2706,27 @@ discard block |
||
2571 | 2706 | elseif ($tag['type'] == 'unparsed_commas_content') |
2572 | 2707 | { |
2573 | 2708 | $pos2 = strpos($message, ']', $pos1); |
2574 | - if ($pos2 === false) |
|
2575 | - continue; |
|
2709 | + if ($pos2 === false) { |
|
2710 | + continue; |
|
2711 | + } |
|
2576 | 2712 | |
2577 | 2713 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2578 | - if ($pos3 === false) |
|
2579 | - continue; |
|
2714 | + if ($pos3 === false) { |
|
2715 | + continue; |
|
2716 | + } |
|
2580 | 2717 | |
2581 | 2718 | // We want $1 to be the content, and the rest to be csv. |
2582 | 2719 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
2583 | 2720 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
2584 | 2721 | |
2585 | - if (isset($tag['validate'])) |
|
2586 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2722 | + if (isset($tag['validate'])) { |
|
2723 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2724 | + } |
|
2587 | 2725 | |
2588 | 2726 | $code = $tag['content']; |
2589 | - foreach ($data as $k => $d) |
|
2590 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2727 | + foreach ($data as $k => $d) { |
|
2728 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2729 | + } |
|
2591 | 2730 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
2592 | 2731 | $pos += strlen($code) - 1 + 2; |
2593 | 2732 | } |
@@ -2595,24 +2734,28 @@ discard block |
||
2595 | 2734 | elseif ($tag['type'] == 'unparsed_commas') |
2596 | 2735 | { |
2597 | 2736 | $pos2 = strpos($message, ']', $pos1); |
2598 | - if ($pos2 === false) |
|
2599 | - continue; |
|
2737 | + if ($pos2 === false) { |
|
2738 | + continue; |
|
2739 | + } |
|
2600 | 2740 | |
2601 | 2741 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
2602 | 2742 | |
2603 | - if (isset($tag['validate'])) |
|
2604 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2743 | + if (isset($tag['validate'])) { |
|
2744 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2745 | + } |
|
2605 | 2746 | |
2606 | 2747 | // Fix after, for disabled code mainly. |
2607 | - foreach ($data as $k => $d) |
|
2608 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2748 | + foreach ($data as $k => $d) { |
|
2749 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2750 | + } |
|
2609 | 2751 | |
2610 | 2752 | $open_tags[] = $tag; |
2611 | 2753 | |
2612 | 2754 | // Replace them out, $1, $2, $3, $4, etc. |
2613 | 2755 | $code = $tag['before']; |
2614 | - foreach ($data as $k => $d) |
|
2615 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2756 | + foreach ($data as $k => $d) { |
|
2757 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2758 | + } |
|
2616 | 2759 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
2617 | 2760 | $pos += strlen($code) - 1 + 2; |
2618 | 2761 | } |
@@ -2623,28 +2766,33 @@ discard block |
||
2623 | 2766 | if (isset($tag['quoted'])) |
2624 | 2767 | { |
2625 | 2768 | $quoted = substr($message, $pos1, 6) == '"'; |
2626 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2627 | - continue; |
|
2769 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2770 | + continue; |
|
2771 | + } |
|
2628 | 2772 | |
2629 | - if ($quoted) |
|
2630 | - $pos1 += 6; |
|
2773 | + if ($quoted) { |
|
2774 | + $pos1 += 6; |
|
2775 | + } |
|
2776 | + } else { |
|
2777 | + $quoted = false; |
|
2631 | 2778 | } |
2632 | - else |
|
2633 | - $quoted = false; |
|
2634 | 2779 | |
2635 | 2780 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2636 | - if ($pos2 === false) |
|
2637 | - continue; |
|
2781 | + if ($pos2 === false) { |
|
2782 | + continue; |
|
2783 | + } |
|
2638 | 2784 | |
2639 | 2785 | $data = substr($message, $pos1, $pos2 - $pos1); |
2640 | 2786 | |
2641 | 2787 | // Validation for my parking, please! |
2642 | - if (isset($tag['validate'])) |
|
2643 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2788 | + if (isset($tag['validate'])) { |
|
2789 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2790 | + } |
|
2644 | 2791 | |
2645 | 2792 | // For parsed content, we must recurse to avoid security problems. |
2646 | - if ($tag['type'] != 'unparsed_equals') |
|
2647 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2793 | + if ($tag['type'] != 'unparsed_equals') { |
|
2794 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2795 | + } |
|
2648 | 2796 | |
2649 | 2797 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
2650 | 2798 | |
@@ -2656,34 +2804,40 @@ discard block |
||
2656 | 2804 | } |
2657 | 2805 | |
2658 | 2806 | // If this is block level, eat any breaks after it. |
2659 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
2660 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2807 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
2808 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2809 | + } |
|
2661 | 2810 | |
2662 | 2811 | // Are we trimming outside this tag? |
2663 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
2664 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2812 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
2813 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2814 | + } |
|
2665 | 2815 | } |
2666 | 2816 | |
2667 | 2817 | // Close any remaining tags. |
2668 | - while ($tag = array_pop($open_tags)) |
|
2669 | - $message .= "\n" . $tag['after'] . "\n"; |
|
2818 | + while ($tag = array_pop($open_tags)) { |
|
2819 | + $message .= "\n" . $tag['after'] . "\n"; |
|
2820 | + } |
|
2670 | 2821 | |
2671 | 2822 | // Parse the smileys within the parts where it can be done safely. |
2672 | 2823 | if ($smileys === true) |
2673 | 2824 | { |
2674 | 2825 | $message_parts = explode("\n", $message); |
2675 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
2676 | - parsesmileys($message_parts[$i]); |
|
2826 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
2827 | + parsesmileys($message_parts[$i]); |
|
2828 | + } |
|
2677 | 2829 | |
2678 | 2830 | $message = implode('', $message_parts); |
2679 | 2831 | } |
2680 | 2832 | |
2681 | 2833 | // No smileys, just get rid of the markers. |
2682 | - else |
|
2683 | - $message = strtr($message, array("\n" => '')); |
|
2834 | + else { |
|
2835 | + $message = strtr($message, array("\n" => '')); |
|
2836 | + } |
|
2684 | 2837 | |
2685 | - if ($message !== '' && $message[0] === ' ') |
|
2686 | - $message = ' ' . substr($message, 1); |
|
2838 | + if ($message !== '' && $message[0] === ' ') { |
|
2839 | + $message = ' ' . substr($message, 1); |
|
2840 | + } |
|
2687 | 2841 | |
2688 | 2842 | // Cleanup whitespace. |
2689 | 2843 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2692,15 +2846,16 @@ discard block |
||
2692 | 2846 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
2693 | 2847 | |
2694 | 2848 | // Cache the output if it took some time... |
2695 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
2696 | - cache_put_data($cache_key, $message, 240); |
|
2849 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
2850 | + cache_put_data($cache_key, $message, 240); |
|
2851 | + } |
|
2697 | 2852 | |
2698 | 2853 | // If this was a force parse revert if needed. |
2699 | 2854 | if (!empty($parse_tags)) |
2700 | 2855 | { |
2701 | - if (empty($temp_bbc)) |
|
2702 | - $bbc_codes = array(); |
|
2703 | - else |
|
2856 | + if (empty($temp_bbc)) { |
|
2857 | + $bbc_codes = array(); |
|
2858 | + } else |
|
2704 | 2859 | { |
2705 | 2860 | $bbc_codes = $temp_bbc; |
2706 | 2861 | unset($temp_bbc); |
@@ -2727,8 +2882,9 @@ discard block |
||
2727 | 2882 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
2728 | 2883 | |
2729 | 2884 | // No smiley set at all?! |
2730 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
2731 | - return; |
|
2885 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
2886 | + return; |
|
2887 | + } |
|
2732 | 2888 | |
2733 | 2889 | // If smileyPregSearch hasn't been set, do it now. |
2734 | 2890 | if (empty($smileyPregSearch)) |
@@ -2739,8 +2895,7 @@ discard block |
||
2739 | 2895 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
2740 | 2896 | $smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif'); |
2741 | 2897 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
2742 | - } |
|
2743 | - else |
|
2898 | + } else |
|
2744 | 2899 | { |
2745 | 2900 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
2746 | 2901 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2764,9 +2919,9 @@ discard block |
||
2764 | 2919 | $smcFunc['db_free_result']($result); |
2765 | 2920 | |
2766 | 2921 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
2922 | + } else { |
|
2923 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2767 | 2924 | } |
2768 | - else |
|
2769 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2770 | 2925 | } |
2771 | 2926 | |
2772 | 2927 | // The non-breaking-space is a complex thing... |
@@ -2843,35 +2998,41 @@ discard block |
||
2843 | 2998 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
2844 | 2999 | |
2845 | 3000 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
2846 | - if (!empty($context['flush_mail'])) |
|
2847 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3001 | + if (!empty($context['flush_mail'])) { |
|
3002 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2848 | 3003 | AddMailQueue(true); |
3004 | + } |
|
2849 | 3005 | |
2850 | 3006 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
2851 | 3007 | |
2852 | - if ($add) |
|
2853 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3008 | + if ($add) { |
|
3009 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3010 | + } |
|
2854 | 3011 | |
2855 | 3012 | // Put the session ID in. |
2856 | - if (defined('SID') && SID != '') |
|
2857 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3013 | + if (defined('SID') && SID != '') { |
|
3014 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3015 | + } |
|
2858 | 3016 | // Keep that debug in their for template debugging! |
2859 | - elseif (isset($_GET['debug'])) |
|
2860 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3017 | + elseif (isset($_GET['debug'])) { |
|
3018 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3019 | + } |
|
2861 | 3020 | |
2862 | 3021 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
2863 | 3022 | { |
2864 | - if (defined('SID') && SID != '') |
|
2865 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
3023 | + if (defined('SID') && SID != '') { |
|
3024 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
2866 | 3025 | function ($m) use ($scripturl) |
2867 | 3026 | { |
2868 | 3027 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
3028 | + } |
|
2869 | 3029 | }, $setLocation); |
2870 | - else |
|
2871 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
3030 | + else { |
|
3031 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
2872 | 3032 | function ($m) use ($scripturl) |
2873 | 3033 | { |
2874 | 3034 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
3035 | + } |
|
2875 | 3036 | }, $setLocation); |
2876 | 3037 | } |
2877 | 3038 | |
@@ -2882,8 +3043,9 @@ discard block |
||
2882 | 3043 | header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
2883 | 3044 | |
2884 | 3045 | // Debugging. |
2885 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
2886 | - $_SESSION['debug_redirect'] = $db_cache; |
|
3046 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3047 | + $_SESSION['debug_redirect'] = $db_cache; |
|
3048 | + } |
|
2887 | 3049 | |
2888 | 3050 | obExit(false); |
2889 | 3051 | } |
@@ -2902,51 +3064,60 @@ discard block |
||
2902 | 3064 | |
2903 | 3065 | // Attempt to prevent a recursive loop. |
2904 | 3066 | ++$level; |
2905 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
2906 | - exit; |
|
2907 | - if ($from_fatal_error) |
|
2908 | - $has_fatal_error = true; |
|
3067 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
3068 | + exit; |
|
3069 | + } |
|
3070 | + if ($from_fatal_error) { |
|
3071 | + $has_fatal_error = true; |
|
3072 | + } |
|
2909 | 3073 | |
2910 | 3074 | // Clear out the stat cache. |
2911 | 3075 | trackStats(); |
2912 | 3076 | |
2913 | 3077 | // If we have mail to send, send it. |
2914 | - if (!empty($context['flush_mail'])) |
|
2915 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3078 | + if (!empty($context['flush_mail'])) { |
|
3079 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2916 | 3080 | AddMailQueue(true); |
3081 | + } |
|
2917 | 3082 | |
2918 | 3083 | $do_header = $header === null ? !$header_done : $header; |
2919 | - if ($do_footer === null) |
|
2920 | - $do_footer = $do_header; |
|
3084 | + if ($do_footer === null) { |
|
3085 | + $do_footer = $do_header; |
|
3086 | + } |
|
2921 | 3087 | |
2922 | 3088 | // Has the template/header been done yet? |
2923 | 3089 | if ($do_header) |
2924 | 3090 | { |
2925 | 3091 | // Was the page title set last minute? Also update the HTML safe one. |
2926 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
2927 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3092 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
3093 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3094 | + } |
|
2928 | 3095 | |
2929 | 3096 | // Start up the session URL fixer. |
2930 | 3097 | ob_start('ob_sessrewrite'); |
2931 | 3098 | |
2932 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
2933 | - $buffers = explode(',', $settings['output_buffers']); |
|
2934 | - elseif (!empty($settings['output_buffers'])) |
|
2935 | - $buffers = $settings['output_buffers']; |
|
2936 | - else |
|
2937 | - $buffers = array(); |
|
3099 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
3100 | + $buffers = explode(',', $settings['output_buffers']); |
|
3101 | + } elseif (!empty($settings['output_buffers'])) { |
|
3102 | + $buffers = $settings['output_buffers']; |
|
3103 | + } else { |
|
3104 | + $buffers = array(); |
|
3105 | + } |
|
2938 | 3106 | |
2939 | - if (isset($modSettings['integrate_buffer'])) |
|
2940 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3107 | + if (isset($modSettings['integrate_buffer'])) { |
|
3108 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3109 | + } |
|
2941 | 3110 | |
2942 | - if (!empty($buffers)) |
|
2943 | - foreach ($buffers as $function) |
|
3111 | + if (!empty($buffers)) { |
|
3112 | + foreach ($buffers as $function) |
|
2944 | 3113 | { |
2945 | 3114 | $call = call_helper($function, true); |
3115 | + } |
|
2946 | 3116 | |
2947 | 3117 | // Is it valid? |
2948 | - if (!empty($call)) |
|
2949 | - ob_start($call); |
|
3118 | + if (!empty($call)) { |
|
3119 | + ob_start($call); |
|
3120 | + } |
|
2950 | 3121 | } |
2951 | 3122 | |
2952 | 3123 | // Display the screen in the logical order. |
@@ -2958,8 +3129,9 @@ discard block |
||
2958 | 3129 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
2959 | 3130 | |
2960 | 3131 | // Anything special to put out? |
2961 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
2962 | - echo $context['insert_after_template']; |
|
3132 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
3133 | + echo $context['insert_after_template']; |
|
3134 | + } |
|
2963 | 3135 | |
2964 | 3136 | // Just so we don't get caught in an endless loop of errors from the footer... |
2965 | 3137 | if (!$footer_done) |
@@ -2968,14 +3140,16 @@ discard block |
||
2968 | 3140 | template_footer(); |
2969 | 3141 | |
2970 | 3142 | // (since this is just debugging... it's okay that it's after </html>.) |
2971 | - if (!isset($_REQUEST['xml'])) |
|
2972 | - displayDebug(); |
|
3143 | + if (!isset($_REQUEST['xml'])) { |
|
3144 | + displayDebug(); |
|
3145 | + } |
|
2973 | 3146 | } |
2974 | 3147 | } |
2975 | 3148 | |
2976 | 3149 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
2977 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
2978 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3150 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
3151 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3152 | + } |
|
2979 | 3153 | |
2980 | 3154 | // For session check verification.... don't switch browsers... |
2981 | 3155 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -2984,9 +3158,10 @@ discard block |
||
2984 | 3158 | call_integration_hook('integrate_exit', array($do_footer)); |
2985 | 3159 | |
2986 | 3160 | // Don't exit if we're coming from index.php; that will pass through normally. |
2987 | - if (!$from_index) |
|
2988 | - exit; |
|
2989 | -} |
|
3161 | + if (!$from_index) { |
|
3162 | + exit; |
|
3163 | + } |
|
3164 | + } |
|
2990 | 3165 | |
2991 | 3166 | /** |
2992 | 3167 | * Get the size of a specified image with better error handling. |
@@ -3005,8 +3180,9 @@ discard block |
||
3005 | 3180 | $url = str_replace(' ', '%20', $url); |
3006 | 3181 | |
3007 | 3182 | // Can we pull this from the cache... please please? |
3008 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
3009 | - return $temp; |
|
3183 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
3184 | + return $temp; |
|
3185 | + } |
|
3010 | 3186 | $t = microtime(); |
3011 | 3187 | |
3012 | 3188 | // Get the host to pester... |
@@ -3016,12 +3192,10 @@ discard block |
||
3016 | 3192 | if ($url == '' || $url == 'http://' || $url == 'https://') |
3017 | 3193 | { |
3018 | 3194 | return false; |
3019 | - } |
|
3020 | - elseif (!isset($match[1])) |
|
3195 | + } elseif (!isset($match[1])) |
|
3021 | 3196 | { |
3022 | 3197 | $size = @getimagesize($url); |
3023 | - } |
|
3024 | - else |
|
3198 | + } else |
|
3025 | 3199 | { |
3026 | 3200 | // Try to connect to the server... give it half a second. |
3027 | 3201 | $temp = 0; |
@@ -3060,12 +3234,14 @@ discard block |
||
3060 | 3234 | } |
3061 | 3235 | |
3062 | 3236 | // If we didn't get it, we failed. |
3063 | - if (!isset($size)) |
|
3064 | - $size = false; |
|
3237 | + if (!isset($size)) { |
|
3238 | + $size = false; |
|
3239 | + } |
|
3065 | 3240 | |
3066 | 3241 | // If this took a long time, we may never have to do it again, but then again we might... |
3067 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
3068 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3242 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
3243 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3244 | + } |
|
3069 | 3245 | |
3070 | 3246 | // Didn't work. |
3071 | 3247 | return $size; |
@@ -3083,8 +3259,9 @@ discard block |
||
3083 | 3259 | |
3084 | 3260 | // Under SSI this function can be called more then once. That can cause some problems. |
3085 | 3261 | // So only run the function once unless we are forced to run it again. |
3086 | - if ($loaded && !$forceload) |
|
3087 | - return; |
|
3262 | + if ($loaded && !$forceload) { |
|
3263 | + return; |
|
3264 | + } |
|
3088 | 3265 | |
3089 | 3266 | $loaded = true; |
3090 | 3267 | |
@@ -3096,14 +3273,16 @@ discard block |
||
3096 | 3273 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
3097 | 3274 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
3098 | 3275 | { |
3099 | - if (trim($context['news_lines'][$i]) == '') |
|
3100 | - continue; |
|
3276 | + if (trim($context['news_lines'][$i]) == '') { |
|
3277 | + continue; |
|
3278 | + } |
|
3101 | 3279 | |
3102 | 3280 | // Clean it up for presentation ;). |
3103 | 3281 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
3104 | 3282 | } |
3105 | - if (!empty($context['news_lines'])) |
|
3106 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3283 | + if (!empty($context['news_lines'])) { |
|
3284 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3285 | + } |
|
3107 | 3286 | |
3108 | 3287 | if (!$user_info['is_guest']) |
3109 | 3288 | { |
@@ -3112,40 +3291,48 @@ discard block |
||
3112 | 3291 | $context['user']['alerts'] = &$user_info['alerts']; |
3113 | 3292 | |
3114 | 3293 | // Personal message popup... |
3115 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
3116 | - $context['user']['popup_messages'] = true; |
|
3117 | - else |
|
3118 | - $context['user']['popup_messages'] = false; |
|
3294 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
3295 | + $context['user']['popup_messages'] = true; |
|
3296 | + } else { |
|
3297 | + $context['user']['popup_messages'] = false; |
|
3298 | + } |
|
3119 | 3299 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
3120 | 3300 | |
3121 | - if (allowedTo('moderate_forum')) |
|
3122 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3301 | + if (allowedTo('moderate_forum')) { |
|
3302 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3303 | + } |
|
3123 | 3304 | |
3124 | 3305 | $context['user']['avatar'] = array(); |
3125 | 3306 | |
3126 | 3307 | // Check for gravatar first since we might be forcing them... |
3127 | 3308 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
3128 | 3309 | { |
3129 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
3130 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3131 | - else |
|
3132 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3310 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
3311 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3312 | + } else { |
|
3313 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3314 | + } |
|
3133 | 3315 | } |
3134 | 3316 | // Uploaded? |
3135 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
3136 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3317 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
3318 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3319 | + } |
|
3137 | 3320 | // Full URL? |
3138 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
3139 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3321 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
3322 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3323 | + } |
|
3140 | 3324 | // Otherwise we assume it's server stored. |
3141 | - elseif ($user_info['avatar']['url'] != '') |
|
3142 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3325 | + elseif ($user_info['avatar']['url'] != '') { |
|
3326 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3327 | + } |
|
3143 | 3328 | // No avatar at all? Fine, we have a big fat default avatar ;) |
3144 | - else |
|
3145 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3329 | + else { |
|
3330 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3331 | + } |
|
3146 | 3332 | |
3147 | - if (!empty($context['user']['avatar'])) |
|
3148 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3333 | + if (!empty($context['user']['avatar'])) { |
|
3334 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3335 | + } |
|
3149 | 3336 | |
3150 | 3337 | // Figure out how long they've been logged in. |
3151 | 3338 | $context['user']['total_time_logged_in'] = array( |
@@ -3153,8 +3340,7 @@ discard block |
||
3153 | 3340 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
3154 | 3341 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
3155 | 3342 | ); |
3156 | - } |
|
3157 | - else |
|
3343 | + } else |
|
3158 | 3344 | { |
3159 | 3345 | $context['user']['messages'] = 0; |
3160 | 3346 | $context['user']['unread_messages'] = 0; |
@@ -3162,12 +3348,14 @@ discard block |
||
3162 | 3348 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
3163 | 3349 | $context['user']['popup_messages'] = false; |
3164 | 3350 | |
3165 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
3166 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3351 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
3352 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3353 | + } |
|
3167 | 3354 | |
3168 | 3355 | // If we've upgraded recently, go easy on the passwords. |
3169 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
3170 | - $context['disable_login_hashing'] = true; |
|
3356 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
3357 | + $context['disable_login_hashing'] = true; |
|
3358 | + } |
|
3171 | 3359 | } |
3172 | 3360 | |
3173 | 3361 | // Setup the main menu items. |
@@ -3180,8 +3368,8 @@ discard block |
||
3180 | 3368 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
3181 | 3369 | |
3182 | 3370 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
3183 | - if ($context['show_pm_popup']) |
|
3184 | - addInlineJavaScript(' |
|
3371 | + if ($context['show_pm_popup']) { |
|
3372 | + addInlineJavaScript(' |
|
3185 | 3373 | jQuery(document).ready(function($) { |
3186 | 3374 | new smc_Popup({ |
3187 | 3375 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3189,15 +3377,17 @@ discard block |
||
3189 | 3377 | icon_class: \'generic_icons mail_new\' |
3190 | 3378 | }); |
3191 | 3379 | });'); |
3380 | + } |
|
3192 | 3381 | |
3193 | 3382 | // Add a generic "Are you sure?" confirmation message. |
3194 | 3383 | addInlineJavaScript(' |
3195 | 3384 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
3196 | 3385 | |
3197 | 3386 | // Now add the capping code for avatars. |
3198 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
3199 | - addInlineCss(' |
|
3387 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
3388 | + addInlineCss(' |
|
3200 | 3389 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
3390 | + } |
|
3201 | 3391 | |
3202 | 3392 | // This looks weird, but it's because BoardIndex.php references the variable. |
3203 | 3393 | $context['common_stats']['latest_member'] = array( |
@@ -3214,11 +3404,13 @@ discard block |
||
3214 | 3404 | ); |
3215 | 3405 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
3216 | 3406 | |
3217 | - if (empty($settings['theme_version'])) |
|
3218 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
3407 | + if (empty($settings['theme_version'])) { |
|
3408 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
3409 | + } |
|
3219 | 3410 | |
3220 | - if (!isset($context['page_title'])) |
|
3221 | - $context['page_title'] = ''; |
|
3411 | + if (!isset($context['page_title'])) { |
|
3412 | + $context['page_title'] = ''; |
|
3413 | + } |
|
3222 | 3414 | |
3223 | 3415 | // Set some specific vars. |
3224 | 3416 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3228,21 +3420,23 @@ discard block |
||
3228 | 3420 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
3229 | 3421 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
3230 | 3422 | |
3231 | - if (!empty($context['meta_keywords'])) |
|
3232 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3423 | + if (!empty($context['meta_keywords'])) { |
|
3424 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3425 | + } |
|
3233 | 3426 | |
3234 | - if (!empty($context['canonical_url'])) |
|
3235 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3427 | + if (!empty($context['canonical_url'])) { |
|
3428 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3429 | + } |
|
3236 | 3430 | |
3237 | - if (!empty($settings['og_image'])) |
|
3238 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3431 | + if (!empty($settings['og_image'])) { |
|
3432 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3433 | + } |
|
3239 | 3434 | |
3240 | 3435 | if (!empty($context['meta_description'])) |
3241 | 3436 | { |
3242 | 3437 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
3243 | 3438 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
3244 | - } |
|
3245 | - else |
|
3439 | + } else |
|
3246 | 3440 | { |
3247 | 3441 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
3248 | 3442 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3267,8 +3461,9 @@ discard block |
||
3267 | 3461 | $memory_needed = memoryReturnBytes($needed); |
3268 | 3462 | |
3269 | 3463 | // should we account for how much is currently being used? |
3270 | - if ($in_use) |
|
3271 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3464 | + if ($in_use) { |
|
3465 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3466 | + } |
|
3272 | 3467 | |
3273 | 3468 | // if more is needed, request it |
3274 | 3469 | if ($memory_current < $memory_needed) |
@@ -3291,8 +3486,9 @@ discard block |
||
3291 | 3486 | */ |
3292 | 3487 | function memoryReturnBytes($val) |
3293 | 3488 | { |
3294 | - if (is_integer($val)) |
|
3295 | - return $val; |
|
3489 | + if (is_integer($val)) { |
|
3490 | + return $val; |
|
3491 | + } |
|
3296 | 3492 | |
3297 | 3493 | // Separate the number from the designator |
3298 | 3494 | $val = trim($val); |
@@ -3328,10 +3524,11 @@ discard block |
||
3328 | 3524 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
3329 | 3525 | |
3330 | 3526 | // Are we debugging the template/html content? |
3331 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
3332 | - header('Content-Type: application/xhtml+xml'); |
|
3333 | - elseif (!isset($_REQUEST['xml'])) |
|
3334 | - header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3527 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
3528 | + header('Content-Type: application/xhtml+xml'); |
|
3529 | + } elseif (!isset($_REQUEST['xml'])) { |
|
3530 | + header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3531 | + } |
|
3335 | 3532 | } |
3336 | 3533 | |
3337 | 3534 | header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3340,8 +3537,9 @@ discard block |
||
3340 | 3537 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
3341 | 3538 | { |
3342 | 3539 | $position = array_search('body', $context['template_layers']); |
3343 | - if ($position === false) |
|
3344 | - $position = array_search('main', $context['template_layers']); |
|
3540 | + if ($position === false) { |
|
3541 | + $position = array_search('main', $context['template_layers']); |
|
3542 | + } |
|
3345 | 3543 | |
3346 | 3544 | if ($position !== false) |
3347 | 3545 | { |
@@ -3369,23 +3567,25 @@ discard block |
||
3369 | 3567 | |
3370 | 3568 | foreach ($securityFiles as $i => $securityFile) |
3371 | 3569 | { |
3372 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
3373 | - unset($securityFiles[$i]); |
|
3570 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
3571 | + unset($securityFiles[$i]); |
|
3572 | + } |
|
3374 | 3573 | } |
3375 | 3574 | |
3376 | 3575 | // We are already checking so many files...just few more doesn't make any difference! :P |
3377 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
3378 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3379 | - |
|
3380 | - else |
|
3381 | - $path = $modSettings['attachmentUploadDir']; |
|
3576 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
3577 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3578 | + } else { |
|
3579 | + $path = $modSettings['attachmentUploadDir']; |
|
3580 | + } |
|
3382 | 3581 | |
3383 | 3582 | secureDirectory($path, true); |
3384 | 3583 | secureDirectory($cachedir); |
3385 | 3584 | |
3386 | 3585 | // If agreement is enabled, at least the english version shall exists |
3387 | - if ($modSettings['requireAgreement']) |
|
3388 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3586 | + if ($modSettings['requireAgreement']) { |
|
3587 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3588 | + } |
|
3389 | 3589 | |
3390 | 3590 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
3391 | 3591 | { |
@@ -3400,18 +3600,21 @@ discard block |
||
3400 | 3600 | echo ' |
3401 | 3601 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
3402 | 3602 | |
3403 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
3404 | - echo ' |
|
3603 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
3604 | + echo ' |
|
3405 | 3605 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
3606 | + } |
|
3406 | 3607 | } |
3407 | 3608 | |
3408 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
3409 | - echo ' |
|
3609 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
3610 | + echo ' |
|
3410 | 3611 | <strong>', $txt['cache_writable'], '</strong><br>'; |
3612 | + } |
|
3411 | 3613 | |
3412 | - if (!empty($agreement)) |
|
3413 | - echo ' |
|
3614 | + if (!empty($agreement)) { |
|
3615 | + echo ' |
|
3414 | 3616 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
3617 | + } |
|
3415 | 3618 | |
3416 | 3619 | echo ' |
3417 | 3620 | </p> |
@@ -3426,16 +3629,18 @@ discard block |
||
3426 | 3629 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
3427 | 3630 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
3428 | 3631 | |
3429 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
3430 | - echo ' |
|
3632 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
3633 | + echo ' |
|
3431 | 3634 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
3635 | + } |
|
3432 | 3636 | |
3433 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
3434 | - echo ' |
|
3637 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
3638 | + echo ' |
|
3435 | 3639 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
3436 | - else |
|
3437 | - echo ' |
|
3640 | + } else { |
|
3641 | + echo ' |
|
3438 | 3642 | <div>', $txt['your_ban_expires_never'], '</div>'; |
3643 | + } |
|
3439 | 3644 | |
3440 | 3645 | echo ' |
3441 | 3646 | </div>'; |
@@ -3451,8 +3656,9 @@ discard block |
||
3451 | 3656 | global $forum_copyright, $software_year, $forum_version; |
3452 | 3657 | |
3453 | 3658 | // Don't display copyright for things like SSI. |
3454 | - if (!isset($forum_version) || !isset($software_year)) |
|
3455 | - return; |
|
3659 | + if (!isset($forum_version) || !isset($software_year)) { |
|
3660 | + return; |
|
3661 | + } |
|
3456 | 3662 | |
3457 | 3663 | // Put in the version... |
3458 | 3664 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3470,9 +3676,10 @@ discard block |
||
3470 | 3676 | $context['load_time'] = comma_format(round(array_sum(explode(' ', microtime())) - array_sum(explode(' ', $time_start)), 3)); |
3471 | 3677 | $context['load_queries'] = $db_count; |
3472 | 3678 | |
3473 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
3474 | - loadSubTemplate($layer . '_below', true); |
|
3475 | -} |
|
3679 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
3680 | + loadSubTemplate($layer . '_below', true); |
|
3681 | + } |
|
3682 | + } |
|
3476 | 3683 | |
3477 | 3684 | /** |
3478 | 3685 | * Output the Javascript files |
@@ -3503,8 +3710,7 @@ discard block |
||
3503 | 3710 | { |
3504 | 3711 | echo ' |
3505 | 3712 | var ', $key, ';'; |
3506 | - } |
|
3507 | - else |
|
3713 | + } else |
|
3508 | 3714 | { |
3509 | 3715 | echo ' |
3510 | 3716 | var ', $key, ' = ', $value, ';'; |
@@ -3519,26 +3725,27 @@ discard block |
||
3519 | 3725 | foreach ($context['javascript_files'] as $id => $js_file) |
3520 | 3726 | { |
3521 | 3727 | // Last minute call! allow theme authors to disable single files. |
3522 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3523 | - continue; |
|
3728 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3729 | + continue; |
|
3730 | + } |
|
3524 | 3731 | |
3525 | 3732 | // By default all files don't get minimized unless the file explicitly says so! |
3526 | 3733 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
3527 | 3734 | { |
3528 | - if ($do_deferred && !empty($js_file['options']['defer'])) |
|
3529 | - $toMinifyDefer[] = $js_file; |
|
3530 | - |
|
3531 | - elseif (!$do_deferred && empty($js_file['options']['defer'])) |
|
3532 | - $toMinify[] = $js_file; |
|
3735 | + if ($do_deferred && !empty($js_file['options']['defer'])) { |
|
3736 | + $toMinifyDefer[] = $js_file; |
|
3737 | + } elseif (!$do_deferred && empty($js_file['options']['defer'])) { |
|
3738 | + $toMinify[] = $js_file; |
|
3739 | + } |
|
3533 | 3740 | |
3534 | 3741 | // Grab a random seed. |
3535 | - if (!isset($minSeed)) |
|
3536 | - $minSeed = $js_file['options']['seed']; |
|
3537 | - } |
|
3538 | - |
|
3539 | - elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) |
|
3540 | - echo ' |
|
3742 | + if (!isset($minSeed)) { |
|
3743 | + $minSeed = $js_file['options']['seed']; |
|
3744 | + } |
|
3745 | + } elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) { |
|
3746 | + echo ' |
|
3541 | 3747 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>'; |
3748 | + } |
|
3542 | 3749 | } |
3543 | 3750 | |
3544 | 3751 | if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer))) |
@@ -3546,14 +3753,14 @@ discard block |
||
3546 | 3753 | $result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred); |
3547 | 3754 | |
3548 | 3755 | // Minify process couldn't work, print each individual files. |
3549 | - if (!empty($result) && is_array($result)) |
|
3550 | - foreach ($result as $minFailedFile) |
|
3756 | + if (!empty($result) && is_array($result)) { |
|
3757 | + foreach ($result as $minFailedFile) |
|
3551 | 3758 | echo ' |
3552 | 3759 | <script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>'; |
3553 | - |
|
3554 | - else |
|
3555 | - echo ' |
|
3760 | + } else { |
|
3761 | + echo ' |
|
3556 | 3762 | <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
3763 | + } |
|
3557 | 3764 | } |
3558 | 3765 | |
3559 | 3766 | // Inline JavaScript - Actually useful some times! |
@@ -3564,8 +3771,9 @@ discard block |
||
3564 | 3771 | echo ' |
3565 | 3772 | <script>'; |
3566 | 3773 | |
3567 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
3568 | - echo $js_code; |
|
3774 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
3775 | + echo $js_code; |
|
3776 | + } |
|
3569 | 3777 | |
3570 | 3778 | echo ' |
3571 | 3779 | </script>'; |
@@ -3576,8 +3784,9 @@ discard block |
||
3576 | 3784 | echo ' |
3577 | 3785 | <script>'; |
3578 | 3786 | |
3579 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
3580 | - echo $js_code; |
|
3787 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
3788 | + echo $js_code; |
|
3789 | + } |
|
3581 | 3790 | |
3582 | 3791 | echo ' |
3583 | 3792 | </script>'; |
@@ -3602,8 +3811,9 @@ discard block |
||
3602 | 3811 | foreach ($context['css_files'] as $id => $file) |
3603 | 3812 | { |
3604 | 3813 | // Last minute call! allow theme authors to disable single files. |
3605 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3606 | - continue; |
|
3814 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3815 | + continue; |
|
3816 | + } |
|
3607 | 3817 | |
3608 | 3818 | // By default all files don't get minimized unless the file explicitly says so! |
3609 | 3819 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
@@ -3611,12 +3821,12 @@ discard block |
||
3611 | 3821 | $toMinify[] = $file; |
3612 | 3822 | |
3613 | 3823 | // Grab a random seed. |
3614 | - if (!isset($minSeed)) |
|
3615 | - $minSeed = $file['options']['seed']; |
|
3824 | + if (!isset($minSeed)) { |
|
3825 | + $minSeed = $file['options']['seed']; |
|
3826 | + } |
|
3827 | + } else { |
|
3828 | + $normal[] = $file['fileUrl']; |
|
3616 | 3829 | } |
3617 | - |
|
3618 | - else |
|
3619 | - $normal[] = $file['fileUrl']; |
|
3620 | 3830 | } |
3621 | 3831 | |
3622 | 3832 | if (!empty($toMinify)) |
@@ -3624,28 +3834,30 @@ discard block |
||
3624 | 3834 | $result = custMinify($toMinify, 'css'); |
3625 | 3835 | |
3626 | 3836 | // Minify process couldn't work, print each individual files. |
3627 | - if (!empty($result) && is_array($result)) |
|
3628 | - foreach ($result as $minFailedFile) |
|
3837 | + if (!empty($result) && is_array($result)) { |
|
3838 | + foreach ($result as $minFailedFile) |
|
3629 | 3839 | echo ' |
3630 | 3840 | <link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">'; |
3631 | - |
|
3632 | - else |
|
3633 | - echo ' |
|
3841 | + } else { |
|
3842 | + echo ' |
|
3634 | 3843 | <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
3844 | + } |
|
3635 | 3845 | } |
3636 | 3846 | |
3637 | 3847 | // Print the rest after the minified files. |
3638 | - if (!empty($normal)) |
|
3639 | - foreach ($normal as $nf) |
|
3848 | + if (!empty($normal)) { |
|
3849 | + foreach ($normal as $nf) |
|
3640 | 3850 | echo ' |
3641 | 3851 | <link rel="stylesheet" href="', $nf ,'">'; |
3852 | + } |
|
3642 | 3853 | |
3643 | 3854 | if ($db_show_debug === true) |
3644 | 3855 | { |
3645 | 3856 | // Try to keep only what's useful. |
3646 | 3857 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
3647 | - foreach ($context['css_files'] as $file) |
|
3648 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3858 | + foreach ($context['css_files'] as $file) { |
|
3859 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3860 | + } |
|
3649 | 3861 | } |
3650 | 3862 | |
3651 | 3863 | if (!empty($context['css_header'])) |
@@ -3653,9 +3865,10 @@ discard block |
||
3653 | 3865 | echo ' |
3654 | 3866 | <style>'; |
3655 | 3867 | |
3656 | - foreach ($context['css_header'] as $css) |
|
3657 | - echo $css .' |
|
3868 | + foreach ($context['css_header'] as $css) { |
|
3869 | + echo $css .' |
|
3658 | 3870 | '; |
3871 | + } |
|
3659 | 3872 | |
3660 | 3873 | echo' |
3661 | 3874 | </style>'; |
@@ -3679,15 +3892,17 @@ discard block |
||
3679 | 3892 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
3680 | 3893 | $data = !empty($data) ? $data : false; |
3681 | 3894 | |
3682 | - if (empty($type) || empty($data)) |
|
3683 | - return false; |
|
3895 | + if (empty($type) || empty($data)) { |
|
3896 | + return false; |
|
3897 | + } |
|
3684 | 3898 | |
3685 | 3899 | // Did we already did this? |
3686 | 3900 | $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
3687 | 3901 | |
3688 | 3902 | // Already done? |
3689 | - if (!empty($toCache)) |
|
3690 | - return true; |
|
3903 | + if (!empty($toCache)) { |
|
3904 | + return true; |
|
3905 | + } |
|
3691 | 3906 | |
3692 | 3907 | // No namespaces, sorry! |
3693 | 3908 | $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
@@ -3769,8 +3984,9 @@ discard block |
||
3769 | 3984 | global $modSettings, $smcFunc; |
3770 | 3985 | |
3771 | 3986 | // Just make up a nice hash... |
3772 | - if ($new) |
|
3773 | - return sha1(md5($filename . time()) . mt_rand()); |
|
3987 | + if ($new) { |
|
3988 | + return sha1(md5($filename . time()) . mt_rand()); |
|
3989 | + } |
|
3774 | 3990 | |
3775 | 3991 | // Just make sure that attachment id is only a int |
3776 | 3992 | $attachment_id = (int) $attachment_id; |
@@ -3787,23 +4003,25 @@ discard block |
||
3787 | 4003 | 'id_attach' => $attachment_id, |
3788 | 4004 | )); |
3789 | 4005 | |
3790 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
3791 | - return false; |
|
4006 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
4007 | + return false; |
|
4008 | + } |
|
3792 | 4009 | |
3793 | 4010 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
3794 | 4011 | $smcFunc['db_free_result']($request); |
3795 | 4012 | } |
3796 | 4013 | |
3797 | 4014 | // Still no hash? mmm... |
3798 | - if (empty($file_hash)) |
|
3799 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4015 | + if (empty($file_hash)) { |
|
4016 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4017 | + } |
|
3800 | 4018 | |
3801 | 4019 | // Are we using multiple directories? |
3802 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
3803 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
3804 | - |
|
3805 | - else |
|
3806 | - $path = $modSettings['attachmentUploadDir']; |
|
4020 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
4021 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
4022 | + } else { |
|
4023 | + $path = $modSettings['attachmentUploadDir']; |
|
4024 | + } |
|
3807 | 4025 | |
3808 | 4026 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
3809 | 4027 | } |
@@ -3818,8 +4036,9 @@ discard block |
||
3818 | 4036 | function ip2range($fullip) |
3819 | 4037 | { |
3820 | 4038 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
3821 | - if ($fullip == 'unknown') |
|
3822 | - $fullip = '255.255.255.255'; |
|
4039 | + if ($fullip == 'unknown') { |
|
4040 | + $fullip = '255.255.255.255'; |
|
4041 | + } |
|
3823 | 4042 | |
3824 | 4043 | $ip_parts = explode('-', $fullip); |
3825 | 4044 | $ip_array = array(); |
@@ -3843,10 +4062,11 @@ discard block |
||
3843 | 4062 | $ip_array['low'] = $ip_parts[0]; |
3844 | 4063 | $ip_array['high'] = $ip_parts[1]; |
3845 | 4064 | return $ip_array; |
3846 | - } |
|
3847 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
4065 | + } elseif (count($ip_parts) == 2) { |
|
4066 | + // if ip 22.22.*-22.22.* |
|
3848 | 4067 | { |
3849 | 4068 | $valid_low = isValidIP($ip_parts[0]); |
4069 | + } |
|
3850 | 4070 | $valid_high = isValidIP($ip_parts[1]); |
3851 | 4071 | $count = 0; |
3852 | 4072 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -3861,7 +4081,9 @@ discard block |
||
3861 | 4081 | $ip_parts[0] .= $mode . $min; |
3862 | 4082 | $valid_low = isValidIP($ip_parts[0]); |
3863 | 4083 | $count++; |
3864 | - if ($count > 9) break; |
|
4084 | + if ($count > 9) { |
|
4085 | + break; |
|
4086 | + } |
|
3865 | 4087 | } |
3866 | 4088 | } |
3867 | 4089 | |
@@ -3875,7 +4097,9 @@ discard block |
||
3875 | 4097 | $ip_parts[1] .= $mode . $max; |
3876 | 4098 | $valid_high = isValidIP($ip_parts[1]); |
3877 | 4099 | $count++; |
3878 | - if ($count > 9) break; |
|
4100 | + if ($count > 9) { |
|
4101 | + break; |
|
4102 | + } |
|
3879 | 4103 | } |
3880 | 4104 | } |
3881 | 4105 | |
@@ -3900,46 +4124,54 @@ discard block |
||
3900 | 4124 | { |
3901 | 4125 | global $modSettings; |
3902 | 4126 | |
3903 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
3904 | - return $host; |
|
4127 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
4128 | + return $host; |
|
4129 | + } |
|
3905 | 4130 | $t = microtime(); |
3906 | 4131 | |
3907 | 4132 | // Try the Linux host command, perhaps? |
3908 | 4133 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
3909 | 4134 | { |
3910 | - if (!isset($modSettings['host_to_dis'])) |
|
3911 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
3912 | - else |
|
3913 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4135 | + if (!isset($modSettings['host_to_dis'])) { |
|
4136 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
4137 | + } else { |
|
4138 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4139 | + } |
|
3914 | 4140 | |
3915 | 4141 | // Did host say it didn't find anything? |
3916 | - if (strpos($test, 'not found') !== false) |
|
3917 | - $host = ''; |
|
4142 | + if (strpos($test, 'not found') !== false) { |
|
4143 | + $host = ''; |
|
4144 | + } |
|
3918 | 4145 | // Invalid server option? |
3919 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
3920 | - updateSettings(array('host_to_dis' => 1)); |
|
4146 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
4147 | + updateSettings(array('host_to_dis' => 1)); |
|
4148 | + } |
|
3921 | 4149 | // Maybe it found something, after all? |
3922 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
3923 | - $host = $match[1]; |
|
4150 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
4151 | + $host = $match[1]; |
|
4152 | + } |
|
3924 | 4153 | } |
3925 | 4154 | |
3926 | 4155 | // This is nslookup; usually only Windows, but possibly some Unix? |
3927 | 4156 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
3928 | 4157 | { |
3929 | 4158 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
3930 | - if (strpos($test, 'Non-existent domain') !== false) |
|
3931 | - $host = ''; |
|
3932 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
3933 | - $host = $match[1]; |
|
4159 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
4160 | + $host = ''; |
|
4161 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
4162 | + $host = $match[1]; |
|
4163 | + } |
|
3934 | 4164 | } |
3935 | 4165 | |
3936 | 4166 | // This is the last try :/. |
3937 | - if (!isset($host) || $host === false) |
|
3938 | - $host = @gethostbyaddr($ip); |
|
4167 | + if (!isset($host) || $host === false) { |
|
4168 | + $host = @gethostbyaddr($ip); |
|
4169 | + } |
|
3939 | 4170 | |
3940 | 4171 | // It took a long time, so let's cache it! |
3941 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
3942 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4172 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
4173 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4174 | + } |
|
3943 | 4175 | |
3944 | 4176 | return $host; |
3945 | 4177 | } |
@@ -3975,20 +4207,21 @@ discard block |
||
3975 | 4207 | { |
3976 | 4208 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
3977 | 4209 | $total = 0; |
3978 | - for ($i = 0; $i < $max_chars; $i++) |
|
3979 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4210 | + for ($i = 0; $i < $max_chars; $i++) { |
|
4211 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4212 | + } |
|
3980 | 4213 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
3981 | 4214 | } |
3982 | 4215 | } |
3983 | 4216 | return array_unique($returned_ints); |
3984 | - } |
|
3985 | - else |
|
4217 | + } else |
|
3986 | 4218 | { |
3987 | 4219 | // Trim characters before and after and add slashes for database insertion. |
3988 | 4220 | $returned_words = array(); |
3989 | - foreach ($words as $word) |
|
3990 | - if (($word = trim($word, '-_\'')) !== '') |
|
4221 | + foreach ($words as $word) { |
|
4222 | + if (($word = trim($word, '-_\'')) !== '') |
|
3991 | 4223 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
4224 | + } |
|
3992 | 4225 | |
3993 | 4226 | // Filter out all words that occur more than once. |
3994 | 4227 | return array_unique($returned_words); |
@@ -4010,16 +4243,18 @@ discard block |
||
4010 | 4243 | global $settings, $txt; |
4011 | 4244 | |
4012 | 4245 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
4013 | - if (function_exists('template_create_button') && !$force_use) |
|
4014 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4246 | + if (function_exists('template_create_button') && !$force_use) { |
|
4247 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4248 | + } |
|
4015 | 4249 | |
4016 | - if (!$settings['use_image_buttons']) |
|
4017 | - return $txt[$alt]; |
|
4018 | - elseif (!empty($settings['use_buttons'])) |
|
4019 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4020 | - else |
|
4021 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4022 | -} |
|
4250 | + if (!$settings['use_image_buttons']) { |
|
4251 | + return $txt[$alt]; |
|
4252 | + } elseif (!empty($settings['use_buttons'])) { |
|
4253 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4254 | + } else { |
|
4255 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4256 | + } |
|
4257 | + } |
|
4023 | 4258 | |
4024 | 4259 | /** |
4025 | 4260 | * Sets up all of the top menu buttons |
@@ -4062,9 +4297,10 @@ discard block |
||
4062 | 4297 | var user_menus = new smc_PopupMenu(); |
4063 | 4298 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4064 | 4299 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
4065 | - if ($context['allow_pm']) |
|
4066 | - addInlineJavaScript(' |
|
4300 | + if ($context['allow_pm']) { |
|
4301 | + addInlineJavaScript(' |
|
4067 | 4302 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
4303 | + } |
|
4068 | 4304 | |
4069 | 4305 | if (!empty($modSettings['enable_ajax_alerts'])) |
4070 | 4306 | { |
@@ -4224,88 +4460,96 @@ discard block |
||
4224 | 4460 | |
4225 | 4461 | // Now we put the buttons in the context so the theme can use them. |
4226 | 4462 | $menu_buttons = array(); |
4227 | - foreach ($buttons as $act => $button) |
|
4228 | - if (!empty($button['show'])) |
|
4463 | + foreach ($buttons as $act => $button) { |
|
4464 | + if (!empty($button['show'])) |
|
4229 | 4465 | { |
4230 | 4466 | $button['active_button'] = false; |
4467 | + } |
|
4231 | 4468 | |
4232 | 4469 | // This button needs some action. |
4233 | - if (isset($button['action_hook'])) |
|
4234 | - $needs_action_hook = true; |
|
4470 | + if (isset($button['action_hook'])) { |
|
4471 | + $needs_action_hook = true; |
|
4472 | + } |
|
4235 | 4473 | |
4236 | 4474 | // Make sure the last button truly is the last button. |
4237 | 4475 | if (!empty($button['is_last'])) |
4238 | 4476 | { |
4239 | - if (isset($last_button)) |
|
4240 | - unset($menu_buttons[$last_button]['is_last']); |
|
4477 | + if (isset($last_button)) { |
|
4478 | + unset($menu_buttons[$last_button]['is_last']); |
|
4479 | + } |
|
4241 | 4480 | $last_button = $act; |
4242 | 4481 | } |
4243 | 4482 | |
4244 | 4483 | // Go through the sub buttons if there are any. |
4245 | - if (!empty($button['sub_buttons'])) |
|
4246 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4484 | + if (!empty($button['sub_buttons'])) { |
|
4485 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4247 | 4486 | { |
4248 | 4487 | if (empty($subbutton['show'])) |
4249 | 4488 | unset($button['sub_buttons'][$key]); |
4489 | + } |
|
4250 | 4490 | |
4251 | 4491 | // 2nd level sub buttons next... |
4252 | 4492 | if (!empty($subbutton['sub_buttons'])) |
4253 | 4493 | { |
4254 | 4494 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
4255 | 4495 | { |
4256 | - if (empty($sub_button2['show'])) |
|
4257 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4496 | + if (empty($sub_button2['show'])) { |
|
4497 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4498 | + } |
|
4258 | 4499 | } |
4259 | 4500 | } |
4260 | 4501 | } |
4261 | 4502 | |
4262 | 4503 | // Does this button have its own icon? |
4263 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
4264 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4265 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
4266 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4267 | - elseif (isset($button['icon'])) |
|
4268 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4269 | - else |
|
4270 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4504 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
4505 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4506 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
4507 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4508 | + } elseif (isset($button['icon'])) { |
|
4509 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4510 | + } else { |
|
4511 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4512 | + } |
|
4271 | 4513 | |
4272 | 4514 | $menu_buttons[$act] = $button; |
4273 | 4515 | } |
4274 | 4516 | |
4275 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
4276 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4517 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
4518 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4519 | + } |
|
4277 | 4520 | } |
4278 | 4521 | |
4279 | 4522 | $context['menu_buttons'] = $menu_buttons; |
4280 | 4523 | |
4281 | 4524 | // Logging out requires the session id in the url. |
4282 | - if (isset($context['menu_buttons']['logout'])) |
|
4283 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4525 | + if (isset($context['menu_buttons']['logout'])) { |
|
4526 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4527 | + } |
|
4284 | 4528 | |
4285 | 4529 | // Figure out which action we are doing so we can set the active tab. |
4286 | 4530 | // Default to home. |
4287 | 4531 | $current_action = 'home'; |
4288 | 4532 | |
4289 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
4290 | - $current_action = $context['current_action']; |
|
4291 | - elseif ($context['current_action'] == 'search2') |
|
4292 | - $current_action = 'search'; |
|
4293 | - elseif ($context['current_action'] == 'theme') |
|
4294 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4295 | - elseif ($context['current_action'] == 'register2') |
|
4296 | - $current_action = 'register'; |
|
4297 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
4298 | - $current_action = 'login'; |
|
4299 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
4300 | - $current_action = 'moderate'; |
|
4533 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
4534 | + $current_action = $context['current_action']; |
|
4535 | + } elseif ($context['current_action'] == 'search2') { |
|
4536 | + $current_action = 'search'; |
|
4537 | + } elseif ($context['current_action'] == 'theme') { |
|
4538 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4539 | + } elseif ($context['current_action'] == 'register2') { |
|
4540 | + $current_action = 'register'; |
|
4541 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
4542 | + $current_action = 'login'; |
|
4543 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
4544 | + $current_action = 'moderate'; |
|
4545 | + } |
|
4301 | 4546 | |
4302 | 4547 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
4303 | 4548 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
4304 | 4549 | { |
4305 | 4550 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
4306 | 4551 | $context[$current_action] = true; |
4307 | - } |
|
4308 | - elseif ($context['current_action'] == 'pm') |
|
4552 | + } elseif ($context['current_action'] == 'pm') |
|
4309 | 4553 | { |
4310 | 4554 | $current_action = 'self_pm'; |
4311 | 4555 | $context['self_pm'] = true; |
@@ -4346,12 +4590,14 @@ discard block |
||
4346 | 4590 | } |
4347 | 4591 | |
4348 | 4592 | // Not all actions are simple. |
4349 | - if (!empty($needs_action_hook)) |
|
4350 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4593 | + if (!empty($needs_action_hook)) { |
|
4594 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4595 | + } |
|
4351 | 4596 | |
4352 | - if (isset($context['menu_buttons'][$current_action])) |
|
4353 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4354 | -} |
|
4597 | + if (isset($context['menu_buttons'][$current_action])) { |
|
4598 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4599 | + } |
|
4600 | + } |
|
4355 | 4601 | |
4356 | 4602 | /** |
4357 | 4603 | * Generate a random seed and ensure it's stored in settings. |
@@ -4375,30 +4621,35 @@ discard block |
||
4375 | 4621 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
4376 | 4622 | global $context, $txt; |
4377 | 4623 | |
4378 | - if ($db_show_debug === true) |
|
4379 | - $context['debug']['hooks'][] = $hook; |
|
4624 | + if ($db_show_debug === true) { |
|
4625 | + $context['debug']['hooks'][] = $hook; |
|
4626 | + } |
|
4380 | 4627 | |
4381 | 4628 | // Need to have some control. |
4382 | - if (!isset($context['instances'])) |
|
4383 | - $context['instances'] = array(); |
|
4629 | + if (!isset($context['instances'])) { |
|
4630 | + $context['instances'] = array(); |
|
4631 | + } |
|
4384 | 4632 | |
4385 | 4633 | $results = array(); |
4386 | - if (empty($modSettings[$hook])) |
|
4387 | - return $results; |
|
4634 | + if (empty($modSettings[$hook])) { |
|
4635 | + return $results; |
|
4636 | + } |
|
4388 | 4637 | |
4389 | 4638 | $functions = explode(',', $modSettings[$hook]); |
4390 | 4639 | // Loop through each function. |
4391 | 4640 | foreach ($functions as $function) |
4392 | 4641 | { |
4393 | 4642 | // Hook has been marked as "disabled". Skip it! |
4394 | - if (strpos($function, '!') !== false) |
|
4395 | - continue; |
|
4643 | + if (strpos($function, '!') !== false) { |
|
4644 | + continue; |
|
4645 | + } |
|
4396 | 4646 | |
4397 | 4647 | $call = call_helper($function, true); |
4398 | 4648 | |
4399 | 4649 | // Is it valid? |
4400 | - if (!empty($call)) |
|
4401 | - $results[$function] = call_user_func_array($call, $parameters); |
|
4650 | + if (!empty($call)) { |
|
4651 | + $results[$function] = call_user_func_array($call, $parameters); |
|
4652 | + } |
|
4402 | 4653 | |
4403 | 4654 | // Whatever it was suppose to call, it failed :( |
4404 | 4655 | elseif (!empty($function)) |
@@ -4414,8 +4665,9 @@ discard block |
||
4414 | 4665 | } |
4415 | 4666 | |
4416 | 4667 | // "Assume" the file resides on $boarddir somewhere... |
4417 | - else |
|
4418 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4668 | + else { |
|
4669 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4670 | + } |
|
4419 | 4671 | } |
4420 | 4672 | } |
4421 | 4673 | |
@@ -4437,12 +4689,14 @@ discard block |
||
4437 | 4689 | global $smcFunc, $modSettings; |
4438 | 4690 | |
4439 | 4691 | // Any objects? |
4440 | - if ($object) |
|
4441 | - $function = $function . '#'; |
|
4692 | + if ($object) { |
|
4693 | + $function = $function . '#'; |
|
4694 | + } |
|
4442 | 4695 | |
4443 | 4696 | // Any files to load? |
4444 | - if (!empty($file) && is_string($file)) |
|
4445 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4697 | + if (!empty($file) && is_string($file)) { |
|
4698 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4699 | + } |
|
4446 | 4700 | |
4447 | 4701 | // Get the correct string. |
4448 | 4702 | $integration_call = $function; |
@@ -4464,13 +4718,14 @@ discard block |
||
4464 | 4718 | if (!empty($current_functions)) |
4465 | 4719 | { |
4466 | 4720 | $current_functions = explode(',', $current_functions); |
4467 | - if (in_array($integration_call, $current_functions)) |
|
4468 | - return; |
|
4721 | + if (in_array($integration_call, $current_functions)) { |
|
4722 | + return; |
|
4723 | + } |
|
4469 | 4724 | |
4470 | 4725 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
4726 | + } else { |
|
4727 | + $permanent_functions = array($integration_call); |
|
4471 | 4728 | } |
4472 | - else |
|
4473 | - $permanent_functions = array($integration_call); |
|
4474 | 4729 | |
4475 | 4730 | updateSettings(array($hook => implode(',', $permanent_functions))); |
4476 | 4731 | } |
@@ -4479,8 +4734,9 @@ discard block |
||
4479 | 4734 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4480 | 4735 | |
4481 | 4736 | // Do nothing, if it's already there. |
4482 | - if (in_array($integration_call, $functions)) |
|
4483 | - return; |
|
4737 | + if (in_array($integration_call, $functions)) { |
|
4738 | + return; |
|
4739 | + } |
|
4484 | 4740 | |
4485 | 4741 | $functions[] = $integration_call; |
4486 | 4742 | $modSettings[$hook] = implode(',', $functions); |
@@ -4503,12 +4759,14 @@ discard block |
||
4503 | 4759 | global $smcFunc, $modSettings; |
4504 | 4760 | |
4505 | 4761 | // Any objects? |
4506 | - if ($object) |
|
4507 | - $function = $function . '#'; |
|
4762 | + if ($object) { |
|
4763 | + $function = $function . '#'; |
|
4764 | + } |
|
4508 | 4765 | |
4509 | 4766 | // Any files to load? |
4510 | - if (!empty($file) && is_string($file)) |
|
4511 | - $function = $file . '|' . $function; |
|
4767 | + if (!empty($file) && is_string($file)) { |
|
4768 | + $function = $file . '|' . $function; |
|
4769 | + } |
|
4512 | 4770 | |
4513 | 4771 | // Get the correct string. |
4514 | 4772 | $integration_call = $function; |
@@ -4529,16 +4787,18 @@ discard block |
||
4529 | 4787 | { |
4530 | 4788 | $current_functions = explode(',', $current_functions); |
4531 | 4789 | |
4532 | - if (in_array($integration_call, $current_functions)) |
|
4533 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4790 | + if (in_array($integration_call, $current_functions)) { |
|
4791 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4792 | + } |
|
4534 | 4793 | } |
4535 | 4794 | |
4536 | 4795 | // Turn the function list into something usable. |
4537 | 4796 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4538 | 4797 | |
4539 | 4798 | // You can only remove it if it's available. |
4540 | - if (!in_array($integration_call, $functions)) |
|
4541 | - return; |
|
4799 | + if (!in_array($integration_call, $functions)) { |
|
4800 | + return; |
|
4801 | + } |
|
4542 | 4802 | |
4543 | 4803 | $functions = array_diff($functions, array($integration_call)); |
4544 | 4804 | $modSettings[$hook] = implode(',', $functions); |
@@ -4559,17 +4819,20 @@ discard block |
||
4559 | 4819 | global $context, $smcFunc, $txt, $db_show_debug; |
4560 | 4820 | |
4561 | 4821 | // Really? |
4562 | - if (empty($string)) |
|
4563 | - return false; |
|
4822 | + if (empty($string)) { |
|
4823 | + return false; |
|
4824 | + } |
|
4564 | 4825 | |
4565 | 4826 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
4566 | 4827 | // A closure? should be a callable one. |
4567 | - if (is_array($string) || $string instanceof Closure) |
|
4568 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4828 | + if (is_array($string) || $string instanceof Closure) { |
|
4829 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4830 | + } |
|
4569 | 4831 | |
4570 | 4832 | // No full objects, sorry! pass a method or a property instead! |
4571 | - if (is_object($string)) |
|
4572 | - return false; |
|
4833 | + if (is_object($string)) { |
|
4834 | + return false; |
|
4835 | + } |
|
4573 | 4836 | |
4574 | 4837 | // Stay vitaminized my friends... |
4575 | 4838 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4578,8 +4841,9 @@ discard block |
||
4578 | 4841 | $string = load_file($string); |
4579 | 4842 | |
4580 | 4843 | // Loaded file failed |
4581 | - if (empty($string)) |
|
4582 | - return false; |
|
4844 | + if (empty($string)) { |
|
4845 | + return false; |
|
4846 | + } |
|
4583 | 4847 | |
4584 | 4848 | // Found a method. |
4585 | 4849 | if (strpos($string, '::') !== false) |
@@ -4600,8 +4864,9 @@ discard block |
||
4600 | 4864 | // Add another one to the list. |
4601 | 4865 | if ($db_show_debug === true) |
4602 | 4866 | { |
4603 | - if (!isset($context['debug']['instances'])) |
|
4604 | - $context['debug']['instances'] = array(); |
|
4867 | + if (!isset($context['debug']['instances'])) { |
|
4868 | + $context['debug']['instances'] = array(); |
|
4869 | + } |
|
4605 | 4870 | |
4606 | 4871 | $context['debug']['instances'][$class] = $class; |
4607 | 4872 | } |
@@ -4611,13 +4876,15 @@ discard block |
||
4611 | 4876 | } |
4612 | 4877 | |
4613 | 4878 | // Right then. This is a call to a static method. |
4614 | - else |
|
4615 | - $func = array($class, $method); |
|
4879 | + else { |
|
4880 | + $func = array($class, $method); |
|
4881 | + } |
|
4616 | 4882 | } |
4617 | 4883 | |
4618 | 4884 | // Nope! just a plain regular function. |
4619 | - else |
|
4620 | - $func = $string; |
|
4885 | + else { |
|
4886 | + $func = $string; |
|
4887 | + } |
|
4621 | 4888 | |
4622 | 4889 | // Right, we got what we need, time to do some checks. |
4623 | 4890 | if (!is_callable($func, false, $callable_name)) |
@@ -4633,17 +4900,18 @@ discard block |
||
4633 | 4900 | else |
4634 | 4901 | { |
4635 | 4902 | // What are we gonna do about it? |
4636 | - if ($return) |
|
4637 | - return $func; |
|
4903 | + if ($return) { |
|
4904 | + return $func; |
|
4905 | + } |
|
4638 | 4906 | |
4639 | 4907 | // If this is a plain function, avoid the heat of calling call_user_func(). |
4640 | 4908 | else |
4641 | 4909 | { |
4642 | - if (is_array($func)) |
|
4643 | - call_user_func($func); |
|
4644 | - |
|
4645 | - else |
|
4646 | - $func(); |
|
4910 | + if (is_array($func)) { |
|
4911 | + call_user_func($func); |
|
4912 | + } else { |
|
4913 | + $func(); |
|
4914 | + } |
|
4647 | 4915 | } |
4648 | 4916 | } |
4649 | 4917 | } |
@@ -4660,31 +4928,34 @@ discard block |
||
4660 | 4928 | { |
4661 | 4929 | global $sourcedir, $txt, $boarddir, $settings; |
4662 | 4930 | |
4663 | - if (empty($string)) |
|
4664 | - return false; |
|
4931 | + if (empty($string)) { |
|
4932 | + return false; |
|
4933 | + } |
|
4665 | 4934 | |
4666 | 4935 | if (strpos($string, '|') !== false) |
4667 | 4936 | { |
4668 | 4937 | list ($file, $string) = explode('|', $string); |
4669 | 4938 | |
4670 | 4939 | // Match the wildcards to their regular vars. |
4671 | - if (empty($settings['theme_dir'])) |
|
4672 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4673 | - |
|
4674 | - else |
|
4675 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4940 | + if (empty($settings['theme_dir'])) { |
|
4941 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4942 | + } else { |
|
4943 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4944 | + } |
|
4676 | 4945 | |
4677 | 4946 | // Load the file if it can be loaded. |
4678 | - if (file_exists($absPath)) |
|
4679 | - require_once($absPath); |
|
4947 | + if (file_exists($absPath)) { |
|
4948 | + require_once($absPath); |
|
4949 | + } |
|
4680 | 4950 | |
4681 | 4951 | // No? try a fallback to $sourcedir |
4682 | 4952 | else |
4683 | 4953 | { |
4684 | 4954 | $absPath = $sourcedir .'/'. $file; |
4685 | 4955 | |
4686 | - if (file_exists($absPath)) |
|
4687 | - require_once($absPath); |
|
4956 | + if (file_exists($absPath)) { |
|
4957 | + require_once($absPath); |
|
4958 | + } |
|
4688 | 4959 | |
4689 | 4960 | // Sorry, can't do much for you at this point. |
4690 | 4961 | else |
@@ -4711,8 +4982,9 @@ discard block |
||
4711 | 4982 | global $user_info, $smcFunc; |
4712 | 4983 | |
4713 | 4984 | // Make sure we have something to work with. |
4714 | - if (empty($topic)) |
|
4715 | - return array(); |
|
4985 | + if (empty($topic)) { |
|
4986 | + return array(); |
|
4987 | + } |
|
4716 | 4988 | |
4717 | 4989 | |
4718 | 4990 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -4735,8 +5007,9 @@ discard block |
||
4735 | 5007 | 'topic' => $topic, |
4736 | 5008 | ) |
4737 | 5009 | ); |
4738 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
4739 | - $temp[] = (int) $row['content_id']; |
|
5010 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
5011 | + $temp[] = (int) $row['content_id']; |
|
5012 | + } |
|
4740 | 5013 | |
4741 | 5014 | cache_put_data($cache_key, $temp, $ttl); |
4742 | 5015 | } |
@@ -4757,8 +5030,9 @@ discard block |
||
4757 | 5030 | { |
4758 | 5031 | global $context; |
4759 | 5032 | |
4760 | - if (empty($string)) |
|
4761 | - return $string; |
|
5033 | + if (empty($string)) { |
|
5034 | + return $string; |
|
5035 | + } |
|
4762 | 5036 | |
4763 | 5037 | // UTF-8 occurences of MS special characters |
4764 | 5038 | $findchars_utf8 = array( |
@@ -4799,10 +5073,11 @@ discard block |
||
4799 | 5073 | '--', // — |
4800 | 5074 | ); |
4801 | 5075 | |
4802 | - if ($context['utf8']) |
|
4803 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
4804 | - else |
|
4805 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
5076 | + if ($context['utf8']) { |
|
5077 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
5078 | + } else { |
|
5079 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
5080 | + } |
|
4806 | 5081 | |
4807 | 5082 | return $string; |
4808 | 5083 | } |
@@ -4821,49 +5096,59 @@ discard block |
||
4821 | 5096 | { |
4822 | 5097 | global $context; |
4823 | 5098 | |
4824 | - if (!isset($matches[2])) |
|
4825 | - return ''; |
|
5099 | + if (!isset($matches[2])) { |
|
5100 | + return ''; |
|
5101 | + } |
|
4826 | 5102 | |
4827 | 5103 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4828 | 5104 | |
4829 | 5105 | // remove left to right / right to left overrides |
4830 | - if ($num === 0x202D || $num === 0x202E) |
|
4831 | - return ''; |
|
5106 | + if ($num === 0x202D || $num === 0x202E) { |
|
5107 | + return ''; |
|
5108 | + } |
|
4832 | 5109 | |
4833 | 5110 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
4834 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
4835 | - return '&#' . $num . ';'; |
|
5111 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
5112 | + return '&#' . $num . ';'; |
|
5113 | + } |
|
4836 | 5114 | |
4837 | 5115 | if (empty($context['utf8'])) |
4838 | 5116 | { |
4839 | 5117 | // no control characters |
4840 | - if ($num < 0x20) |
|
4841 | - return ''; |
|
5118 | + if ($num < 0x20) { |
|
5119 | + return ''; |
|
5120 | + } |
|
4842 | 5121 | // text is text |
4843 | - elseif ($num < 0x80) |
|
4844 | - return chr($num); |
|
5122 | + elseif ($num < 0x80) { |
|
5123 | + return chr($num); |
|
5124 | + } |
|
4845 | 5125 | // all others get html-ised |
4846 | - else |
|
4847 | - return '&#' . $matches[2] . ';'; |
|
4848 | - } |
|
4849 | - else |
|
5126 | + else { |
|
5127 | + return '&#' . $matches[2] . ';'; |
|
5128 | + } |
|
5129 | + } else |
|
4850 | 5130 | { |
4851 | 5131 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
4852 | 5132 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
4853 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
4854 | - return ''; |
|
5133 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
5134 | + return ''; |
|
5135 | + } |
|
4855 | 5136 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4856 | - elseif ($num < 0x80) |
|
4857 | - return chr($num); |
|
5137 | + elseif ($num < 0x80) { |
|
5138 | + return chr($num); |
|
5139 | + } |
|
4858 | 5140 | // <0x800 (2048) |
4859 | - elseif ($num < 0x800) |
|
4860 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5141 | + elseif ($num < 0x800) { |
|
5142 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5143 | + } |
|
4861 | 5144 | // < 0x10000 (65536) |
4862 | - elseif ($num < 0x10000) |
|
4863 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5145 | + elseif ($num < 0x10000) { |
|
5146 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5147 | + } |
|
4864 | 5148 | // <= 0x10FFFF (1114111) |
4865 | - else |
|
4866 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5149 | + else { |
|
5150 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5151 | + } |
|
4867 | 5152 | } |
4868 | 5153 | } |
4869 | 5154 | |
@@ -4879,28 +5164,34 @@ discard block |
||
4879 | 5164 | */ |
4880 | 5165 | function fixchar__callback($matches) |
4881 | 5166 | { |
4882 | - if (!isset($matches[1])) |
|
4883 | - return ''; |
|
5167 | + if (!isset($matches[1])) { |
|
5168 | + return ''; |
|
5169 | + } |
|
4884 | 5170 | |
4885 | 5171 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
4886 | 5172 | |
4887 | 5173 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
4888 | 5174 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
4889 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
4890 | - return ''; |
|
5175 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
5176 | + return ''; |
|
5177 | + } |
|
4891 | 5178 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4892 | - elseif ($num < 0x80) |
|
4893 | - return chr($num); |
|
5179 | + elseif ($num < 0x80) { |
|
5180 | + return chr($num); |
|
5181 | + } |
|
4894 | 5182 | // <0x800 (2048) |
4895 | - elseif ($num < 0x800) |
|
4896 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5183 | + elseif ($num < 0x800) { |
|
5184 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5185 | + } |
|
4897 | 5186 | // < 0x10000 (65536) |
4898 | - elseif ($num < 0x10000) |
|
4899 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5187 | + elseif ($num < 0x10000) { |
|
5188 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5189 | + } |
|
4900 | 5190 | // <= 0x10FFFF (1114111) |
4901 | - else |
|
4902 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
4903 | -} |
|
5191 | + else { |
|
5192 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5193 | + } |
|
5194 | + } |
|
4904 | 5195 | |
4905 | 5196 | /** |
4906 | 5197 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -4913,17 +5204,19 @@ discard block |
||
4913 | 5204 | */ |
4914 | 5205 | function entity_fix__callback($matches) |
4915 | 5206 | { |
4916 | - if (!isset($matches[2])) |
|
4917 | - return ''; |
|
5207 | + if (!isset($matches[2])) { |
|
5208 | + return ''; |
|
5209 | + } |
|
4918 | 5210 | |
4919 | 5211 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4920 | 5212 | |
4921 | 5213 | // we don't allow control characters, characters out of range, byte markers, etc |
4922 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
4923 | - return ''; |
|
4924 | - else |
|
4925 | - return '&#' . $num . ';'; |
|
4926 | -} |
|
5214 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
5215 | + return ''; |
|
5216 | + } else { |
|
5217 | + return '&#' . $num . ';'; |
|
5218 | + } |
|
5219 | + } |
|
4927 | 5220 | |
4928 | 5221 | /** |
4929 | 5222 | * Return a Gravatar URL based on |
@@ -4947,18 +5240,23 @@ discard block |
||
4947 | 5240 | $ratings = array('G', 'PG', 'R', 'X'); |
4948 | 5241 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
4949 | 5242 | $url_params = array(); |
4950 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
4951 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
4952 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
4953 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
4954 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
4955 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
4956 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
4957 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
5243 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
5244 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
5245 | + } |
|
5246 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
5247 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
5248 | + } |
|
5249 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
5250 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
5251 | + } |
|
5252 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
5253 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
4958 | 5254 | $size_string = $modSettings['avatar_max_height_external']; |
5255 | + } |
|
4959 | 5256 | |
4960 | - if (!empty($size_string)) |
|
4961 | - $url_params[] = 's=' . $size_string; |
|
5257 | + if (!empty($size_string)) { |
|
5258 | + $url_params[] = 's=' . $size_string; |
|
5259 | + } |
|
4962 | 5260 | } |
4963 | 5261 | $http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www'; |
4964 | 5262 | |
@@ -4977,22 +5275,26 @@ discard block |
||
4977 | 5275 | static $timezones = null, $lastwhen = null; |
4978 | 5276 | |
4979 | 5277 | // No point doing this over if we already did it once |
4980 | - if (!empty($timezones) && $when == $lastwhen) |
|
4981 | - return $timezones; |
|
4982 | - else |
|
4983 | - $lastwhen = $when; |
|
5278 | + if (!empty($timezones) && $when == $lastwhen) { |
|
5279 | + return $timezones; |
|
5280 | + } else { |
|
5281 | + $lastwhen = $when; |
|
5282 | + } |
|
4984 | 5283 | |
4985 | 5284 | // Parseable datetime string? |
4986 | - if (is_int($timestamp = strtotime($when))) |
|
4987 | - $when = $timestamp; |
|
5285 | + if (is_int($timestamp = strtotime($when))) { |
|
5286 | + $when = $timestamp; |
|
5287 | + } |
|
4988 | 5288 | |
4989 | 5289 | // A Unix timestamp? |
4990 | - elseif (is_numeric($when)) |
|
4991 | - $when = intval($when); |
|
5290 | + elseif (is_numeric($when)) { |
|
5291 | + $when = intval($when); |
|
5292 | + } |
|
4992 | 5293 | |
4993 | 5294 | // Invalid value? Just get current Unix timestamp. |
4994 | - else |
|
4995 | - $when = time(); |
|
5295 | + else { |
|
5296 | + $when = time(); |
|
5297 | + } |
|
4996 | 5298 | |
4997 | 5299 | // We'll need these too |
4998 | 5300 | $date_when = date_create('@' . $when); |
@@ -5056,8 +5358,9 @@ discard block |
||
5056 | 5358 | foreach ($priority_countries as $country) |
5057 | 5359 | { |
5058 | 5360 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
5059 | - if (!empty($country_tzids)) |
|
5060 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5361 | + if (!empty($country_tzids)) { |
|
5362 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5363 | + } |
|
5061 | 5364 | } |
5062 | 5365 | |
5063 | 5366 | // Process the preferred timezones first, then the rest. |
@@ -5067,8 +5370,9 @@ discard block |
||
5067 | 5370 | foreach ($tzids as $tzid) |
5068 | 5371 | { |
5069 | 5372 | // We don't want UTC right now |
5070 | - if ($tzid == 'UTC') |
|
5071 | - continue; |
|
5373 | + if ($tzid == 'UTC') { |
|
5374 | + continue; |
|
5375 | + } |
|
5072 | 5376 | |
5073 | 5377 | $tz = timezone_open($tzid); |
5074 | 5378 | |
@@ -5089,8 +5393,9 @@ discard block |
||
5089 | 5393 | } |
5090 | 5394 | |
5091 | 5395 | // A time zone from a prioritized country? |
5092 | - if (in_array($tzid, $priority_tzids)) |
|
5093 | - $priority_zones[$tzkey] = true; |
|
5396 | + if (in_array($tzid, $priority_tzids)) { |
|
5397 | + $priority_zones[$tzkey] = true; |
|
5398 | + } |
|
5094 | 5399 | |
5095 | 5400 | // Keep track of the location and offset for this tzid |
5096 | 5401 | $tzid_parts = explode('/', $tzid); |
@@ -5109,15 +5414,17 @@ discard block |
||
5109 | 5414 | { |
5110 | 5415 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
5111 | 5416 | |
5112 | - if (!empty($timezone_descriptions[$tzvalue['tzid']])) |
|
5113 | - $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5114 | - else |
|
5115 | - $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5417 | + if (!empty($timezone_descriptions[$tzvalue['tzid']])) { |
|
5418 | + $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5419 | + } else { |
|
5420 | + $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5421 | + } |
|
5116 | 5422 | |
5117 | - if (isset($priority_zones[$tzkey])) |
|
5118 | - $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5119 | - else |
|
5120 | - $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5423 | + if (isset($priority_zones[$tzkey])) { |
|
5424 | + $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5425 | + } else { |
|
5426 | + $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5427 | + } |
|
5121 | 5428 | } |
5122 | 5429 | |
5123 | 5430 | $timezones = array_merge( |
@@ -5171,9 +5478,9 @@ discard block |
||
5171 | 5478 | 'Indian/Kerguelen' => 'TFT', |
5172 | 5479 | ); |
5173 | 5480 | |
5174 | - if (!empty($missing_tz_abbrs[$tzid])) |
|
5175 | - $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5176 | - else |
|
5481 | + if (!empty($missing_tz_abbrs[$tzid])) { |
|
5482 | + $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5483 | + } else |
|
5177 | 5484 | { |
5178 | 5485 | // Russia likes to experiment with time zones often, and names them as offsets from Moscow |
5179 | 5486 | $tz_location = timezone_location_get(timezone_open($tzid)); |
@@ -5201,8 +5508,9 @@ discard block |
||
5201 | 5508 | */ |
5202 | 5509 | function inet_ptod($ip_address) |
5203 | 5510 | { |
5204 | - if (!isValidIP($ip_address)) |
|
5205 | - return $ip_address; |
|
5511 | + if (!isValidIP($ip_address)) { |
|
5512 | + return $ip_address; |
|
5513 | + } |
|
5206 | 5514 | |
5207 | 5515 | $bin = inet_pton($ip_address); |
5208 | 5516 | return $bin; |
@@ -5214,13 +5522,15 @@ discard block |
||
5214 | 5522 | */ |
5215 | 5523 | function inet_dtop($bin) |
5216 | 5524 | { |
5217 | - if(empty($bin)) |
|
5218 | - return ''; |
|
5525 | + if(empty($bin)) { |
|
5526 | + return ''; |
|
5527 | + } |
|
5219 | 5528 | |
5220 | 5529 | global $db_type; |
5221 | 5530 | |
5222 | - if ($db_type == 'postgresql') |
|
5223 | - return $bin; |
|
5531 | + if ($db_type == 'postgresql') { |
|
5532 | + return $bin; |
|
5533 | + } |
|
5224 | 5534 | |
5225 | 5535 | $ip_address = inet_ntop($bin); |
5226 | 5536 | |
@@ -5245,26 +5555,32 @@ discard block |
||
5245 | 5555 | */ |
5246 | 5556 | function _safe_serialize($value) |
5247 | 5557 | { |
5248 | - if(is_null($value)) |
|
5249 | - return 'N;'; |
|
5558 | + if(is_null($value)) { |
|
5559 | + return 'N;'; |
|
5560 | + } |
|
5250 | 5561 | |
5251 | - if(is_bool($value)) |
|
5252 | - return 'b:'. (int) $value .';'; |
|
5562 | + if(is_bool($value)) { |
|
5563 | + return 'b:'. (int) $value .';'; |
|
5564 | + } |
|
5253 | 5565 | |
5254 | - if(is_int($value)) |
|
5255 | - return 'i:'. $value .';'; |
|
5566 | + if(is_int($value)) { |
|
5567 | + return 'i:'. $value .';'; |
|
5568 | + } |
|
5256 | 5569 | |
5257 | - if(is_float($value)) |
|
5258 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5570 | + if(is_float($value)) { |
|
5571 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
5572 | + } |
|
5259 | 5573 | |
5260 | - if(is_string($value)) |
|
5261 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5574 | + if(is_string($value)) { |
|
5575 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
5576 | + } |
|
5262 | 5577 | |
5263 | 5578 | if(is_array($value)) |
5264 | 5579 | { |
5265 | 5580 | $out = ''; |
5266 | - foreach($value as $k => $v) |
|
5267 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5581 | + foreach($value as $k => $v) { |
|
5582 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5583 | + } |
|
5268 | 5584 | |
5269 | 5585 | return 'a:'. count($value) .':{'. $out .'}'; |
5270 | 5586 | } |
@@ -5290,8 +5606,9 @@ discard block |
||
5290 | 5606 | |
5291 | 5607 | $out = _safe_serialize($value); |
5292 | 5608 | |
5293 | - if (isset($mbIntEnc)) |
|
5294 | - mb_internal_encoding($mbIntEnc); |
|
5609 | + if (isset($mbIntEnc)) { |
|
5610 | + mb_internal_encoding($mbIntEnc); |
|
5611 | + } |
|
5295 | 5612 | |
5296 | 5613 | return $out; |
5297 | 5614 | } |
@@ -5308,8 +5625,9 @@ discard block |
||
5308 | 5625 | function _safe_unserialize($str) |
5309 | 5626 | { |
5310 | 5627 | // Input is not a string. |
5311 | - if(empty($str) || !is_string($str)) |
|
5312 | - return false; |
|
5628 | + if(empty($str) || !is_string($str)) { |
|
5629 | + return false; |
|
5630 | + } |
|
5313 | 5631 | |
5314 | 5632 | $stack = array(); |
5315 | 5633 | $expected = array(); |
@@ -5325,43 +5643,38 @@ discard block |
||
5325 | 5643 | while($state != 1) |
5326 | 5644 | { |
5327 | 5645 | $type = isset($str[0]) ? $str[0] : ''; |
5328 | - if($type == '}') |
|
5329 | - $str = substr($str, 1); |
|
5330 | - |
|
5331 | - else if($type == 'N' && $str[1] == ';') |
|
5646 | + if($type == '}') { |
|
5647 | + $str = substr($str, 1); |
|
5648 | + } else if($type == 'N' && $str[1] == ';') |
|
5332 | 5649 | { |
5333 | 5650 | $value = null; |
5334 | 5651 | $str = substr($str, 2); |
5335 | - } |
|
5336 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5652 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5337 | 5653 | { |
5338 | 5654 | $value = $matches[1] == '1' ? true : false; |
5339 | 5655 | $str = substr($str, 4); |
5340 | - } |
|
5341 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5656 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5342 | 5657 | { |
5343 | 5658 | $value = (int)$matches[1]; |
5344 | 5659 | $str = $matches[2]; |
5345 | - } |
|
5346 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5660 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5347 | 5661 | { |
5348 | 5662 | $value = (float)$matches[1]; |
5349 | 5663 | $str = $matches[3]; |
5350 | - } |
|
5351 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5664 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5352 | 5665 | { |
5353 | 5666 | $value = substr($matches[2], 0, (int)$matches[1]); |
5354 | 5667 | $str = substr($matches[2], (int)$matches[1] + 2); |
5355 | - } |
|
5356 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5668 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5357 | 5669 | { |
5358 | 5670 | $expectedLength = (int)$matches[1]; |
5359 | 5671 | $str = $matches[2]; |
5360 | 5672 | } |
5361 | 5673 | |
5362 | 5674 | // Object or unknown/malformed type. |
5363 | - else |
|
5364 | - return false; |
|
5675 | + else { |
|
5676 | + return false; |
|
5677 | + } |
|
5365 | 5678 | |
5366 | 5679 | switch($state) |
5367 | 5680 | { |
@@ -5389,8 +5702,9 @@ discard block |
||
5389 | 5702 | if($type == '}') |
5390 | 5703 | { |
5391 | 5704 | // Array size is less than expected. |
5392 | - if(count($list) < end($expected)) |
|
5393 | - return false; |
|
5705 | + if(count($list) < end($expected)) { |
|
5706 | + return false; |
|
5707 | + } |
|
5394 | 5708 | |
5395 | 5709 | unset($list); |
5396 | 5710 | $list = &$stack[count($stack)-1]; |
@@ -5399,8 +5713,9 @@ discard block |
||
5399 | 5713 | // Go to terminal state if we're at the end of the root array. |
5400 | 5714 | array_pop($expected); |
5401 | 5715 | |
5402 | - if(count($expected) == 0) |
|
5403 | - $state = 1; |
|
5716 | + if(count($expected) == 0) { |
|
5717 | + $state = 1; |
|
5718 | + } |
|
5404 | 5719 | |
5405 | 5720 | break; |
5406 | 5721 | } |
@@ -5408,8 +5723,9 @@ discard block |
||
5408 | 5723 | if($type == 'i' || $type == 's') |
5409 | 5724 | { |
5410 | 5725 | // Array size exceeds expected length. |
5411 | - if(count($list) >= end($expected)) |
|
5412 | - return false; |
|
5726 | + if(count($list) >= end($expected)) { |
|
5727 | + return false; |
|
5728 | + } |
|
5413 | 5729 | |
5414 | 5730 | $key = $value; |
5415 | 5731 | $state = 3; |
@@ -5443,8 +5759,9 @@ discard block |
||
5443 | 5759 | } |
5444 | 5760 | |
5445 | 5761 | // Trailing data in input. |
5446 | - if(!empty($str)) |
|
5447 | - return false; |
|
5762 | + if(!empty($str)) { |
|
5763 | + return false; |
|
5764 | + } |
|
5448 | 5765 | |
5449 | 5766 | return $data; |
5450 | 5767 | } |
@@ -5467,8 +5784,9 @@ discard block |
||
5467 | 5784 | |
5468 | 5785 | $out = _safe_unserialize($str); |
5469 | 5786 | |
5470 | - if (isset($mbIntEnc)) |
|
5471 | - mb_internal_encoding($mbIntEnc); |
|
5787 | + if (isset($mbIntEnc)) { |
|
5788 | + mb_internal_encoding($mbIntEnc); |
|
5789 | + } |
|
5472 | 5790 | |
5473 | 5791 | return $out; |
5474 | 5792 | } |
@@ -5483,12 +5801,14 @@ discard block |
||
5483 | 5801 | function smf_chmod($file, $value = 0) |
5484 | 5802 | { |
5485 | 5803 | // No file? no checks! |
5486 | - if (empty($file)) |
|
5487 | - return false; |
|
5804 | + if (empty($file)) { |
|
5805 | + return false; |
|
5806 | + } |
|
5488 | 5807 | |
5489 | 5808 | // Already writable? |
5490 | - if (is_writable($file)) |
|
5491 | - return true; |
|
5809 | + if (is_writable($file)) { |
|
5810 | + return true; |
|
5811 | + } |
|
5492 | 5812 | |
5493 | 5813 | // Do we have a file or a dir? |
5494 | 5814 | $isDir = is_dir($file); |
@@ -5504,10 +5824,9 @@ discard block |
||
5504 | 5824 | { |
5505 | 5825 | $isWritable = true; |
5506 | 5826 | break; |
5827 | + } else { |
|
5828 | + @chmod($file, $val); |
|
5507 | 5829 | } |
5508 | - |
|
5509 | - else |
|
5510 | - @chmod($file, $val); |
|
5511 | 5830 | } |
5512 | 5831 | |
5513 | 5832 | return $isWritable; |
@@ -5526,8 +5845,9 @@ discard block |
||
5526 | 5845 | global $txt; |
5527 | 5846 | |
5528 | 5847 | // Come on... |
5529 | - if (empty($json) || !is_string($json)) |
|
5530 | - return array(); |
|
5848 | + if (empty($json) || !is_string($json)) { |
|
5849 | + return array(); |
|
5850 | + } |
|
5531 | 5851 | |
5532 | 5852 | $returnArray = @json_decode($json, $returnAsArray); |
5533 | 5853 | |
@@ -5565,11 +5885,11 @@ discard block |
||
5565 | 5885 | $jsonDebug = $jsonDebug[0]; |
5566 | 5886 | loadLanguage('Errors'); |
5567 | 5887 | |
5568 | - if (!empty($jsonDebug)) |
|
5569 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5570 | - |
|
5571 | - else |
|
5572 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5888 | + if (!empty($jsonDebug)) { |
|
5889 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5890 | + } else { |
|
5891 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
5892 | + } |
|
5573 | 5893 | |
5574 | 5894 | // Everyone expects an array. |
5575 | 5895 | return array(); |
@@ -5603,8 +5923,9 @@ discard block |
||
5603 | 5923 | global $db_show_debug, $modSettings; |
5604 | 5924 | |
5605 | 5925 | // Defensive programming anyone? |
5606 | - if (empty($data)) |
|
5607 | - return false; |
|
5926 | + if (empty($data)) { |
|
5927 | + return false; |
|
5928 | + } |
|
5608 | 5929 | |
5609 | 5930 | // Don't need extra stuff... |
5610 | 5931 | $db_show_debug = false; |
@@ -5612,11 +5933,11 @@ discard block |
||
5612 | 5933 | // Kill anything else. |
5613 | 5934 | ob_end_clean(); |
5614 | 5935 | |
5615 | - if (!empty($modSettings['CompressedOutput'])) |
|
5616 | - @ob_start('ob_gzhandler'); |
|
5617 | - |
|
5618 | - else |
|
5619 | - ob_start(); |
|
5936 | + if (!empty($modSettings['CompressedOutput'])) { |
|
5937 | + @ob_start('ob_gzhandler'); |
|
5938 | + } else { |
|
5939 | + ob_start(); |
|
5940 | + } |
|
5620 | 5941 | |
5621 | 5942 | // Set the header. |
5622 | 5943 | header($type); |
@@ -5648,8 +5969,9 @@ discard block |
||
5648 | 5969 | static $done = false; |
5649 | 5970 | |
5650 | 5971 | // If we don't need to do anything, don't |
5651 | - if (!$update && $done) |
|
5652 | - return; |
|
5972 | + if (!$update && $done) { |
|
5973 | + return; |
|
5974 | + } |
|
5653 | 5975 | |
5654 | 5976 | // Should we get a new copy of the official list of TLDs? |
5655 | 5977 | if ($update) |
@@ -5658,8 +5980,9 @@ discard block |
||
5658 | 5980 | $tlds = fetch_web_data('https://data.iana.org/TLD/tlds-alpha-by-domain.txt'); |
5659 | 5981 | |
5660 | 5982 | // If the Internet Assigned Numbers Authority can't be reached, the Internet is gone. We're probably running on a server hidden in a bunker deep underground to protect it from marauding bandits roaming on the surface. We don't want to waste precious electricity on pointlessly repeating background tasks, so we'll wait until the next regularly scheduled update to see if civilization has been restored. |
5661 | - if ($tlds === false) |
|
5662 | - $postapocalypticNightmare = true; |
|
5983 | + if ($tlds === false) { |
|
5984 | + $postapocalypticNightmare = true; |
|
5985 | + } |
|
5663 | 5986 | } |
5664 | 5987 | // If we aren't updating and the regex is valid, we're done |
5665 | 5988 | elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false) |
@@ -5674,10 +5997,11 @@ discard block |
||
5674 | 5997 | // Clean $tlds and convert it to an array |
5675 | 5998 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
5676 | 5999 | $line = trim($line); |
5677 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
5678 | - return false; |
|
5679 | - else |
|
5680 | - return true; |
|
6000 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
6001 | + return false; |
|
6002 | + } else { |
|
6003 | + return true; |
|
6004 | + } |
|
5681 | 6005 | }); |
5682 | 6006 | |
5683 | 6007 | // Convert Punycode to Unicode |
@@ -5731,8 +6055,9 @@ discard block |
||
5731 | 6055 | $idx += $digit * $w; |
5732 | 6056 | $t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias)); |
5733 | 6057 | |
5734 | - if ($digit < $t) |
|
5735 | - break; |
|
6058 | + if ($digit < $t) { |
|
6059 | + break; |
|
6060 | + } |
|
5736 | 6061 | |
5737 | 6062 | $w = (int) ($w * ($base - $t)); |
5738 | 6063 | } |
@@ -5741,8 +6066,9 @@ discard block |
||
5741 | 6066 | $delta = intval($is_first ? ($delta / $damp) : ($delta / 2)); |
5742 | 6067 | $delta += intval($delta / ($deco_len + 1)); |
5743 | 6068 | |
5744 | - for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) |
|
5745 | - $delta = intval($delta / ($base - $tmin)); |
|
6069 | + for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) { |
|
6070 | + $delta = intval($delta / ($base - $tmin)); |
|
6071 | + } |
|
5746 | 6072 | |
5747 | 6073 | $bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew)); |
5748 | 6074 | $is_first = false; |
@@ -5751,8 +6077,9 @@ discard block |
||
5751 | 6077 | |
5752 | 6078 | if ($deco_len > 0) |
5753 | 6079 | { |
5754 | - for ($i = $deco_len; $i > $idx; $i--) |
|
5755 | - $decoded[$i] = $decoded[($i - 1)]; |
|
6080 | + for ($i = $deco_len; $i > $idx; $i--) { |
|
6081 | + $decoded[$i] = $decoded[($i - 1)]; |
|
6082 | + } |
|
5756 | 6083 | } |
5757 | 6084 | $decoded[$idx++] = $char; |
5758 | 6085 | } |
@@ -5760,24 +6087,29 @@ discard block |
||
5760 | 6087 | foreach ($decoded as $k => $v) |
5761 | 6088 | { |
5762 | 6089 | // 7bit are transferred literally |
5763 | - if ($v < 128) |
|
5764 | - $output .= chr($v); |
|
6090 | + if ($v < 128) { |
|
6091 | + $output .= chr($v); |
|
6092 | + } |
|
5765 | 6093 | |
5766 | 6094 | // 2 bytes |
5767 | - elseif ($v < (1 << 11)) |
|
5768 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6095 | + elseif ($v < (1 << 11)) { |
|
6096 | + $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6097 | + } |
|
5769 | 6098 | |
5770 | 6099 | // 3 bytes |
5771 | - elseif ($v < (1 << 16)) |
|
5772 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6100 | + elseif ($v < (1 << 16)) { |
|
6101 | + $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6102 | + } |
|
5773 | 6103 | |
5774 | 6104 | // 4 bytes |
5775 | - elseif ($v < (1 << 21)) |
|
5776 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6105 | + elseif ($v < (1 << 21)) { |
|
6106 | + $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6107 | + } |
|
5777 | 6108 | |
5778 | 6109 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5779 | - else |
|
5780 | - $output .= $safe_char; |
|
6110 | + else { |
|
6111 | + $output .= $safe_char; |
|
6112 | + } |
|
5781 | 6113 | } |
5782 | 6114 | |
5783 | 6115 | $output_parts[] = $output; |
@@ -5870,8 +6202,7 @@ discard block |
||
5870 | 6202 | |
5871 | 6203 | $strlen = 'mb_strlen'; |
5872 | 6204 | $substr = 'mb_substr'; |
5873 | - } |
|
5874 | - else |
|
6205 | + } else |
|
5875 | 6206 | { |
5876 | 6207 | $strlen = $smcFunc['strlen']; |
5877 | 6208 | $substr = $smcFunc['substr']; |
@@ -5885,20 +6216,21 @@ discard block |
||
5885 | 6216 | |
5886 | 6217 | $first = $substr($string, 0, 1); |
5887 | 6218 | |
5888 | - if (empty($index[$first])) |
|
5889 | - $index[$first] = array(); |
|
6219 | + if (empty($index[$first])) { |
|
6220 | + $index[$first] = array(); |
|
6221 | + } |
|
5890 | 6222 | |
5891 | 6223 | if ($strlen($string) > 1) |
5892 | 6224 | { |
5893 | 6225 | // Sanity check on recursion |
5894 | - if ($depth > 99) |
|
5895 | - $index[$first][$substr($string, 1)] = ''; |
|
5896 | - |
|
5897 | - else |
|
5898 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6226 | + if ($depth > 99) { |
|
6227 | + $index[$first][$substr($string, 1)] = ''; |
|
6228 | + } else { |
|
6229 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6230 | + } |
|
6231 | + } else { |
|
6232 | + $index[$first][''] = ''; |
|
5899 | 6233 | } |
5900 | - else |
|
5901 | - $index[$first][''] = ''; |
|
5902 | 6234 | |
5903 | 6235 | $depth--; |
5904 | 6236 | return $index; |
@@ -5921,9 +6253,9 @@ discard block |
||
5921 | 6253 | $key_regex = preg_quote($key, $delim); |
5922 | 6254 | $new_key = $key; |
5923 | 6255 | |
5924 | - if (empty($value)) |
|
5925 | - $sub_regex = ''; |
|
5926 | - else |
|
6256 | + if (empty($value)) { |
|
6257 | + $sub_regex = ''; |
|
6258 | + } else |
|
5927 | 6259 | { |
5928 | 6260 | $sub_regex = $index_to_regex($value, $delim); |
5929 | 6261 | |
@@ -5931,22 +6263,22 @@ discard block |
||
5931 | 6263 | { |
5932 | 6264 | $new_key_array = explode('(?'.'>', $sub_regex); |
5933 | 6265 | $new_key .= $new_key_array[0]; |
6266 | + } else { |
|
6267 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5934 | 6268 | } |
5935 | - else |
|
5936 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5937 | 6269 | } |
5938 | 6270 | |
5939 | - if ($depth > 1) |
|
5940 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
5941 | - else |
|
6271 | + if ($depth > 1) { |
|
6272 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
6273 | + } else |
|
5942 | 6274 | { |
5943 | 6275 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
5944 | 6276 | { |
5945 | 6277 | $regex[$new_key] = $key_regex . $sub_regex; |
5946 | 6278 | unset($index[$key]); |
6279 | + } else { |
|
6280 | + break; |
|
5947 | 6281 | } |
5948 | - else |
|
5949 | - break; |
|
5950 | 6282 | } |
5951 | 6283 | } |
5952 | 6284 | |
@@ -5955,10 +6287,11 @@ discard block |
||
5955 | 6287 | $l1 = $strlen($k1); |
5956 | 6288 | $l2 = $strlen($k2); |
5957 | 6289 | |
5958 | - if ($l1 == $l2) |
|
5959 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
5960 | - else |
|
5961 | - return $l1 > $l2 ? -1 : 1; |
|
6290 | + if ($l1 == $l2) { |
|
6291 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
6292 | + } else { |
|
6293 | + return $l1 > $l2 ? -1 : 1; |
|
6294 | + } |
|
5962 | 6295 | }); |
5963 | 6296 | |
5964 | 6297 | $depth--; |
@@ -5969,21 +6302,24 @@ discard block |
||
5969 | 6302 | $index = array(); |
5970 | 6303 | $regex = ''; |
5971 | 6304 | |
5972 | - foreach ($strings as $string) |
|
5973 | - $index = $add_string_to_index($string, $index); |
|
6305 | + foreach ($strings as $string) { |
|
6306 | + $index = $add_string_to_index($string, $index); |
|
6307 | + } |
|
5974 | 6308 | |
5975 | 6309 | if ($returnArray === true) |
5976 | 6310 | { |
5977 | 6311 | $regex = array(); |
5978 | - while (!empty($index)) |
|
5979 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6312 | + while (!empty($index)) { |
|
6313 | + $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6314 | + } |
|
6315 | + } else { |
|
6316 | + $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
5980 | 6317 | } |
5981 | - else |
|
5982 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
5983 | 6318 | |
5984 | 6319 | // Restore PHP's internal character encoding to whatever it was originally |
5985 | - if (!empty($current_encoding)) |
|
5986 | - mb_internal_encoding($current_encoding); |
|
6320 | + if (!empty($current_encoding)) { |
|
6321 | + mb_internal_encoding($current_encoding); |
|
6322 | + } |
|
5987 | 6323 | |
5988 | 6324 | return $regex; |
5989 | 6325 | } |
@@ -6021,13 +6357,15 @@ discard block |
||
6021 | 6357 | // Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't... |
6022 | 6358 | $url = str_ireplace('https://', 'http://', $url) . '/'; |
6023 | 6359 | $headers = @get_headers($url); |
6024 | - if ($headers === false) |
|
6025 | - return false; |
|
6360 | + if ($headers === false) { |
|
6361 | + return false; |
|
6362 | + } |
|
6026 | 6363 | |
6027 | 6364 | // Now to see if it came back https... |
6028 | 6365 | // First check for a redirect status code in first row (301, 302, 307) |
6029 | - if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) |
|
6030 | - return false; |
|
6366 | + if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) { |
|
6367 | + return false; |
|
6368 | + } |
|
6031 | 6369 | |
6032 | 6370 | // Search for the location entry to confirm https |
6033 | 6371 | $result = false; |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Truncate the GET array to a specified length |
@@ -26,14 +27,15 @@ discard block |
||
26 | 27 | function truncateArray($arr, $max_length=1900) |
27 | 28 | { |
28 | 29 | $curr_length = array_sum(array_map("strlen", $arr)); |
29 | - if ($curr_length <= $max_length) |
|
30 | - return $arr; |
|
31 | - else |
|
30 | + if ($curr_length <= $max_length) { |
|
31 | + return $arr; |
|
32 | + } else |
|
32 | 33 | { |
33 | 34 | // Truncate each element's value to a reasonable length |
34 | 35 | $param_max = floor($max_length/count($arr)); |
35 | - foreach ($arr as $key => &$value) |
|
36 | - $value = substr($value, 0, $param_max - strlen($key) - 5); |
|
36 | + foreach ($arr as $key => &$value) { |
|
37 | + $value = substr($value, 0, $param_max - strlen($key) - 5); |
|
38 | + } |
|
37 | 39 | return $arr; |
38 | 40 | } |
39 | 41 | } |
@@ -55,8 +57,9 @@ discard block |
||
55 | 57 | // Don't update for every page - this isn't wholly accurate but who cares. |
56 | 58 | if ($topic) |
57 | 59 | { |
58 | - if (isset($_SESSION['last_topic_id']) && $_SESSION['last_topic_id'] == $topic) |
|
59 | - $force = false; |
|
60 | + if (isset($_SESSION['last_topic_id']) && $_SESSION['last_topic_id'] == $topic) { |
|
61 | + $force = false; |
|
62 | + } |
|
60 | 63 | $_SESSION['last_topic_id'] = $topic; |
61 | 64 | } |
62 | 65 | } |
@@ -69,22 +72,24 @@ discard block |
||
69 | 72 | } |
70 | 73 | |
71 | 74 | // Don't mark them as online more than every so often. |
72 | - if (!empty($_SESSION['log_time']) && $_SESSION['log_time'] >= (time() - 8) && !$force) |
|
73 | - return; |
|
75 | + if (!empty($_SESSION['log_time']) && $_SESSION['log_time'] >= (time() - 8) && !$force) { |
|
76 | + return; |
|
77 | + } |
|
74 | 78 | |
75 | 79 | if (!empty($modSettings['who_enabled'])) |
76 | 80 | { |
77 | 81 | $encoded_get = truncateArray($_GET) + array('USER_AGENT' => $_SERVER['HTTP_USER_AGENT']); |
78 | 82 | |
79 | 83 | // In the case of a dlattach action, session_var may not be set. |
80 | - if (!isset($context['session_var'])) |
|
81 | - $context['session_var'] = $_SESSION['session_var']; |
|
84 | + if (!isset($context['session_var'])) { |
|
85 | + $context['session_var'] = $_SESSION['session_var']; |
|
86 | + } |
|
82 | 87 | |
83 | 88 | unset($encoded_get['sesc'], $encoded_get[$context['session_var']]); |
84 | 89 | $encoded_get = $smcFunc['json_encode']($encoded_get); |
90 | + } else { |
|
91 | + $encoded_get = ''; |
|
85 | 92 | } |
86 | - else |
|
87 | - $encoded_get = ''; |
|
88 | 93 | |
89 | 94 | // Guests use 0, members use their session ID. |
90 | 95 | $session_id = $user_info['is_guest'] ? 'ip' . $user_info['ip'] : session_id(); |
@@ -124,17 +129,18 @@ discard block |
||
124 | 129 | ); |
125 | 130 | |
126 | 131 | // Guess it got deleted. |
127 | - if ($smcFunc['db_affected_rows']() == 0) |
|
132 | + if ($smcFunc['db_affected_rows']() == 0) { |
|
133 | + $_SESSION['log_time'] = 0; |
|
134 | + } |
|
135 | + } else { |
|
128 | 136 | $_SESSION['log_time'] = 0; |
129 | 137 | } |
130 | - else |
|
131 | - $_SESSION['log_time'] = 0; |
|
132 | 138 | |
133 | 139 | // Otherwise, we have to delete and insert. |
134 | 140 | if (empty($_SESSION['log_time'])) |
135 | 141 | { |
136 | - if ($do_delete || !empty($user_info['id'])) |
|
137 | - $smcFunc['db_query']('', ' |
|
142 | + if ($do_delete || !empty($user_info['id'])) { |
|
143 | + $smcFunc['db_query']('', ' |
|
138 | 144 | DELETE FROM {db_prefix}log_online |
139 | 145 | WHERE ' . ($do_delete ? 'log_time < {int:log_time}' : '') . ($do_delete && !empty($user_info['id']) ? ' OR ' : '') . (empty($user_info['id']) ? '' : 'id_member = {int:current_member}'), |
140 | 146 | array( |
@@ -142,6 +148,7 @@ discard block |
||
142 | 148 | 'log_time' => time() - $modSettings['lastActive'] * 60, |
143 | 149 | ) |
144 | 150 | ); |
151 | + } |
|
145 | 152 | |
146 | 153 | $smcFunc['db_insert']($do_delete ? 'ignore' : 'replace', |
147 | 154 | '{db_prefix}log_online', |
@@ -155,21 +162,24 @@ discard block |
||
155 | 162 | $_SESSION['log_time'] = time(); |
156 | 163 | |
157 | 164 | // Well, they are online now. |
158 | - if (empty($_SESSION['timeOnlineUpdated'])) |
|
159 | - $_SESSION['timeOnlineUpdated'] = time(); |
|
165 | + if (empty($_SESSION['timeOnlineUpdated'])) { |
|
166 | + $_SESSION['timeOnlineUpdated'] = time(); |
|
167 | + } |
|
160 | 168 | |
161 | 169 | // Set their login time, if not already done within the last minute. |
162 | 170 | if (SMF != 'SSI' && !empty($user_info['last_login']) && $user_info['last_login'] < time() - 60 && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('.xml', 'login2', 'logintfa')))) |
163 | 171 | { |
164 | 172 | // Don't count longer than 15 minutes. |
165 | - if (time() - $_SESSION['timeOnlineUpdated'] > 60 * 15) |
|
166 | - $_SESSION['timeOnlineUpdated'] = time(); |
|
173 | + if (time() - $_SESSION['timeOnlineUpdated'] > 60 * 15) { |
|
174 | + $_SESSION['timeOnlineUpdated'] = time(); |
|
175 | + } |
|
167 | 176 | |
168 | 177 | $user_settings['total_time_logged_in'] += time() - $_SESSION['timeOnlineUpdated']; |
169 | 178 | updateMemberData($user_info['id'], array('last_login' => time(), 'member_ip' => $user_info['ip'], 'member_ip2' => $_SERVER['BAN_CHECK_IP'], 'total_time_logged_in' => $user_settings['total_time_logged_in'])); |
170 | 179 | |
171 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
172 | - cache_put_data('user_settings-' . $user_info['id'], $user_settings, 60); |
|
180 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
181 | + cache_put_data('user_settings-' . $user_info['id'], $user_settings, 60); |
|
182 | + } |
|
173 | 183 | |
174 | 184 | $user_info['total_time_logged_in'] += time() - $_SESSION['timeOnlineUpdated']; |
175 | 185 | $_SESSION['timeOnlineUpdated'] = time(); |
@@ -206,8 +216,7 @@ discard block |
||
206 | 216 | // Oops. maybe we have no more disk space left, or some other troubles, troubles... |
207 | 217 | // Copy the file back and run for your life! |
208 | 218 | @copy($boarddir . '/db_last_error_bak.php', $boarddir . '/db_last_error.php'); |
209 | - } |
|
210 | - else |
|
219 | + } else |
|
211 | 220 | { |
212 | 221 | @touch($boarddir . '/' . 'Settings.php'); |
213 | 222 | return true; |
@@ -227,22 +236,27 @@ discard block |
||
227 | 236 | global $db_cache, $db_count, $cache_misses, $cache_count_misses, $db_show_debug, $cache_count, $cache_hits, $smcFunc, $txt; |
228 | 237 | |
229 | 238 | // Add to Settings.php if you want to show the debugging information. |
230 | - if (!isset($db_show_debug) || $db_show_debug !== true || (isset($_GET['action']) && $_GET['action'] == 'viewquery')) |
|
231 | - return; |
|
239 | + if (!isset($db_show_debug) || $db_show_debug !== true || (isset($_GET['action']) && $_GET['action'] == 'viewquery')) { |
|
240 | + return; |
|
241 | + } |
|
232 | 242 | |
233 | - if (empty($_SESSION['view_queries'])) |
|
234 | - $_SESSION['view_queries'] = 0; |
|
235 | - if (empty($context['debug']['language_files'])) |
|
236 | - $context['debug']['language_files'] = array(); |
|
237 | - if (empty($context['debug']['sheets'])) |
|
238 | - $context['debug']['sheets'] = array(); |
|
243 | + if (empty($_SESSION['view_queries'])) { |
|
244 | + $_SESSION['view_queries'] = 0; |
|
245 | + } |
|
246 | + if (empty($context['debug']['language_files'])) { |
|
247 | + $context['debug']['language_files'] = array(); |
|
248 | + } |
|
249 | + if (empty($context['debug']['sheets'])) { |
|
250 | + $context['debug']['sheets'] = array(); |
|
251 | + } |
|
239 | 252 | |
240 | 253 | $files = get_included_files(); |
241 | 254 | $total_size = 0; |
242 | 255 | for ($i = 0, $n = count($files); $i < $n; $i++) |
243 | 256 | { |
244 | - if (file_exists($files[$i])) |
|
245 | - $total_size += filesize($files[$i]); |
|
257 | + if (file_exists($files[$i])) { |
|
258 | + $total_size += filesize($files[$i]); |
|
259 | + } |
|
246 | 260 | $files[$i] = strtr($files[$i], array($boarddir => '.', $sourcedir => '(Sources)', $cachedir => '(Cache)', $settings['actual_theme_dir'] => '(Current Theme)')); |
247 | 261 | } |
248 | 262 | |
@@ -251,8 +265,9 @@ discard block |
||
251 | 265 | { |
252 | 266 | foreach ($db_cache as $q => $qq) |
253 | 267 | { |
254 | - if (!empty($qq['w'])) |
|
255 | - $warnings += count($qq['w']); |
|
268 | + if (!empty($qq['w'])) { |
|
269 | + $warnings += count($qq['w']); |
|
270 | + } |
|
256 | 271 | } |
257 | 272 | |
258 | 273 | $_SESSION['debug'] = &$db_cache; |
@@ -273,12 +288,14 @@ discard block |
||
273 | 288 | ',(isset($context['debug']['instances']) ? ($txt['debug_instances'] . (empty($context['debug']['instances']) ? 0 : count($context['debug']['instances'])) . ' (<a href="javascript:void(0);" onclick="document.getElementById(\'debug_instances\').style.display = \'inline\'; this.style.display = \'none\'; return false;">'. $txt['debug_show'] .'</a><span id="debug_instances" style="display: none;"><em>'. implode('</em>, <em>', array_keys($context['debug']['instances'])) .'</em></span>)'. '<br>') : ''),' |
274 | 289 | ', $txt['debug_files_included'], count($files), ' - ', round($total_size / 1024), $txt['debug_kb'], ' (<a href="javascript:void(0);" onclick="document.getElementById(\'debug_include_info\').style.display = \'inline\'; this.style.display = \'none\'; return false;">', $txt['debug_show'], '</a><span id="debug_include_info" style="display: none;"><em>', implode('</em>, <em>', $files), '</em></span>)<br>'; |
275 | 290 | |
276 | - if (function_exists('memory_get_peak_usage')) |
|
277 | - echo $txt['debug_memory_use'], ceil(memory_get_peak_usage() / 1024), $txt['debug_kb'], '<br>'; |
|
291 | + if (function_exists('memory_get_peak_usage')) { |
|
292 | + echo $txt['debug_memory_use'], ceil(memory_get_peak_usage() / 1024), $txt['debug_kb'], '<br>'; |
|
293 | + } |
|
278 | 294 | |
279 | 295 | // What tokens are active? |
280 | - if (isset($_SESSION['token'])) |
|
281 | - echo $txt['debug_tokens'] . '<em>' . implode(',</em> <em>', array_keys($_SESSION['token'])), '</em>.<br>'; |
|
296 | + if (isset($_SESSION['token'])) { |
|
297 | + echo $txt['debug_tokens'] . '<em>' . implode(',</em> <em>', array_keys($_SESSION['token'])), '</em>.<br>'; |
|
298 | + } |
|
282 | 299 | |
283 | 300 | if (!empty($modSettings['cache_enable']) && !empty($cache_hits)) |
284 | 301 | { |
@@ -292,10 +309,12 @@ discard block |
||
292 | 309 | $total_t += $cache_hit['t']; |
293 | 310 | $total_s += $cache_hit['s']; |
294 | 311 | } |
295 | - if (!isset($cache_misses)) |
|
296 | - $cache_misses = array(); |
|
297 | - foreach ($cache_misses as $missed) |
|
298 | - $missed_entries[] = $missed['d'] . ' ' . $missed['k']; |
|
312 | + if (!isset($cache_misses)) { |
|
313 | + $cache_misses = array(); |
|
314 | + } |
|
315 | + foreach ($cache_misses as $missed) { |
|
316 | + $missed_entries[] = $missed['d'] . ' ' . $missed['k']; |
|
317 | + } |
|
299 | 318 | |
300 | 319 | echo ' |
301 | 320 | ', $txt['debug_cache_hits'], $cache_count, ': ', sprintf($txt['debug_cache_seconds_bytes_total'], comma_format($total_t, 5), comma_format($total_s)), ' (<a href="javascript:void(0);" onclick="document.getElementById(\'debug_cache_info\').style.display = \'inline\'; this.style.display = \'none\'; return false;">', $txt['debug_show'], '</a><span id="debug_cache_info" style="display: none;"><em>', implode('</em>, <em>', $entries), '</em></span>)<br> |
@@ -306,38 +325,44 @@ discard block |
||
306 | 325 | <a href="', $scripturl, '?action=viewquery" target="_blank">', $warnings == 0 ? sprintf($txt['debug_queries_used'], (int) $db_count) : sprintf($txt['debug_queries_used_and_warnings'], (int) $db_count, $warnings), '</a><br> |
307 | 326 | <br>'; |
308 | 327 | |
309 | - if ($_SESSION['view_queries'] == 1 && !empty($db_cache)) |
|
310 | - foreach ($db_cache as $q => $qq) |
|
328 | + if ($_SESSION['view_queries'] == 1 && !empty($db_cache)) { |
|
329 | + foreach ($db_cache as $q => $qq) |
|
311 | 330 | { |
312 | 331 | $is_select = strpos(trim($qq['q']), 'SELECT') === 0 || preg_match('~^INSERT(?: IGNORE)? INTO \w+(?:\s+\([^)]+\))?\s+SELECT .+$~s', trim($qq['q'])) != 0; |
332 | + } |
|
313 | 333 | // Temporary tables created in earlier queries are not explainable. |
314 | 334 | if ($is_select) |
315 | 335 | { |
316 | - foreach (array('log_topics_unread', 'topics_posted_in', 'tmp_log_search_topics', 'tmp_log_search_messages') as $tmp) |
|
317 | - if (strpos(trim($qq['q']), $tmp) !== false) |
|
336 | + foreach (array('log_topics_unread', 'topics_posted_in', 'tmp_log_search_topics', 'tmp_log_search_messages') as $tmp) { |
|
337 | + if (strpos(trim($qq['q']), $tmp) !== false) |
|
318 | 338 | { |
319 | 339 | $is_select = false; |
340 | + } |
|
320 | 341 | break; |
321 | 342 | } |
322 | 343 | } |
323 | 344 | // But actual creation of the temporary tables are. |
324 | - elseif (preg_match('~^CREATE TEMPORARY TABLE .+?SELECT .+$~s', trim($qq['q'])) != 0) |
|
325 | - $is_select = true; |
|
345 | + elseif (preg_match('~^CREATE TEMPORARY TABLE .+?SELECT .+$~s', trim($qq['q'])) != 0) { |
|
346 | + $is_select = true; |
|
347 | + } |
|
326 | 348 | |
327 | 349 | // Make the filenames look a bit better. |
328 | - if (isset($qq['f'])) |
|
329 | - $qq['f'] = preg_replace('~^' . preg_quote($boarddir, '~') . '~', '...', $qq['f']); |
|
350 | + if (isset($qq['f'])) { |
|
351 | + $qq['f'] = preg_replace('~^' . preg_quote($boarddir, '~') . '~', '...', $qq['f']); |
|
352 | + } |
|
330 | 353 | |
331 | 354 | echo ' |
332 | 355 | <strong>', $is_select ? '<a href="' . $scripturl . '?action=viewquery;qq=' . ($q + 1) . '#qq' . $q . '" target="_blank" style="text-decoration: none;">' : '', nl2br(str_replace("\t", ' ', $smcFunc['htmlspecialchars'](ltrim($qq['q'], "\n\r")))) . ($is_select ? '</a></strong>' : '</strong>') . '<br> |
333 | 356 | '; |
334 | - if (!empty($qq['f']) && !empty($qq['l'])) |
|
335 | - echo sprintf($txt['debug_query_in_line'], $qq['f'], $qq['l']); |
|
357 | + if (!empty($qq['f']) && !empty($qq['l'])) { |
|
358 | + echo sprintf($txt['debug_query_in_line'], $qq['f'], $qq['l']); |
|
359 | + } |
|
336 | 360 | |
337 | - if (isset($qq['s'], $qq['t']) && isset($txt['debug_query_which_took_at'])) |
|
338 | - echo sprintf($txt['debug_query_which_took_at'], round($qq['t'], 8), round($qq['s'], 8)) . '<br>'; |
|
339 | - elseif (isset($qq['t'])) |
|
340 | - echo sprintf($txt['debug_query_which_took'], round($qq['t'], 8)) . '<br>'; |
|
361 | + if (isset($qq['s'], $qq['t']) && isset($txt['debug_query_which_took_at'])) { |
|
362 | + echo sprintf($txt['debug_query_which_took_at'], round($qq['t'], 8), round($qq['s'], 8)) . '<br>'; |
|
363 | + } elseif (isset($qq['t'])) { |
|
364 | + echo sprintf($txt['debug_query_which_took'], round($qq['t'], 8)) . '<br>'; |
|
365 | + } |
|
341 | 366 | echo ' |
342 | 367 | <br>'; |
343 | 368 | } |
@@ -362,12 +387,14 @@ discard block |
||
362 | 387 | global $modSettings, $smcFunc; |
363 | 388 | static $cache_stats = array(); |
364 | 389 | |
365 | - if (empty($modSettings['trackStats'])) |
|
366 | - return false; |
|
367 | - if (!empty($stats)) |
|
368 | - return $cache_stats = array_merge($cache_stats, $stats); |
|
369 | - elseif (empty($cache_stats)) |
|
370 | - return false; |
|
390 | + if (empty($modSettings['trackStats'])) { |
|
391 | + return false; |
|
392 | + } |
|
393 | + if (!empty($stats)) { |
|
394 | + return $cache_stats = array_merge($cache_stats, $stats); |
|
395 | + } elseif (empty($cache_stats)) { |
|
396 | + return false; |
|
397 | + } |
|
371 | 398 | |
372 | 399 | $setStringUpdate = ''; |
373 | 400 | $insert_keys = array(); |
@@ -380,10 +407,11 @@ discard block |
||
380 | 407 | $setStringUpdate .= ' |
381 | 408 | ' . $field . ' = ' . ($change === '+' ? $field . ' + 1' : '{int:' . $field . '}') . ','; |
382 | 409 | |
383 | - if ($change === '+') |
|
384 | - $cache_stats[$field] = 1; |
|
385 | - else |
|
386 | - $update_parameters[$field] = $change; |
|
410 | + if ($change === '+') { |
|
411 | + $cache_stats[$field] = 1; |
|
412 | + } else { |
|
413 | + $update_parameters[$field] = $change; |
|
414 | + } |
|
387 | 415 | $insert_keys[$field] = 'int'; |
388 | 416 | } |
389 | 417 | |
@@ -447,43 +475,50 @@ discard block |
||
447 | 475 | ); |
448 | 476 | |
449 | 477 | // Make sure this particular log is enabled first... |
450 | - if (empty($modSettings['modlog_enabled'])) |
|
451 | - unset ($log_types['moderate']); |
|
452 | - if (empty($modSettings['userlog_enabled'])) |
|
453 | - unset ($log_types['user']); |
|
454 | - if (empty($modSettings['adminlog_enabled'])) |
|
455 | - unset ($log_types['admin']); |
|
478 | + if (empty($modSettings['modlog_enabled'])) { |
|
479 | + unset ($log_types['moderate']); |
|
480 | + } |
|
481 | + if (empty($modSettings['userlog_enabled'])) { |
|
482 | + unset ($log_types['user']); |
|
483 | + } |
|
484 | + if (empty($modSettings['adminlog_enabled'])) { |
|
485 | + unset ($log_types['admin']); |
|
486 | + } |
|
456 | 487 | |
457 | 488 | call_integration_hook('integrate_log_types', array(&$log_types)); |
458 | 489 | |
459 | 490 | foreach ($logs as $log) |
460 | 491 | { |
461 | - if (!isset($log_types[$log['log_type']])) |
|
462 | - return false; |
|
492 | + if (!isset($log_types[$log['log_type']])) { |
|
493 | + return false; |
|
494 | + } |
|
463 | 495 | |
464 | - if (!is_array($log['extra'])) |
|
465 | - trigger_error('logActions(): data is not an array with action \'' . $log['action'] . '\'', E_USER_NOTICE); |
|
496 | + if (!is_array($log['extra'])) { |
|
497 | + trigger_error('logActions(): data is not an array with action \'' . $log['action'] . '\'', E_USER_NOTICE); |
|
498 | + } |
|
466 | 499 | |
467 | 500 | // Pull out the parts we want to store separately, but also make sure that the data is proper |
468 | 501 | if (isset($log['extra']['topic'])) |
469 | 502 | { |
470 | - if (!is_numeric($log['extra']['topic'])) |
|
471 | - trigger_error('logActions(): data\'s topic is not a number', E_USER_NOTICE); |
|
503 | + if (!is_numeric($log['extra']['topic'])) { |
|
504 | + trigger_error('logActions(): data\'s topic is not a number', E_USER_NOTICE); |
|
505 | + } |
|
472 | 506 | $topic_id = empty($log['extra']['topic']) ? 0 : (int) $log['extra']['topic']; |
473 | 507 | unset($log['extra']['topic']); |
508 | + } else { |
|
509 | + $topic_id = 0; |
|
474 | 510 | } |
475 | - else |
|
476 | - $topic_id = 0; |
|
477 | 511 | |
478 | 512 | if (isset($log['extra']['message'])) |
479 | 513 | { |
480 | - if (!is_numeric($log['extra']['message'])) |
|
481 | - trigger_error('logActions(): data\'s message is not a number', E_USER_NOTICE); |
|
514 | + if (!is_numeric($log['extra']['message'])) { |
|
515 | + trigger_error('logActions(): data\'s message is not a number', E_USER_NOTICE); |
|
516 | + } |
|
482 | 517 | $msg_id = empty($log['extra']['message']) ? 0 : (int) $log['extra']['message']; |
483 | 518 | unset($log['extra']['message']); |
519 | + } else { |
|
520 | + $msg_id = 0; |
|
484 | 521 | } |
485 | - else |
|
486 | - $msg_id = 0; |
|
487 | 522 | |
488 | 523 | // @todo cache this? |
489 | 524 | // Is there an associated report on this? |
@@ -510,23 +545,26 @@ discard block |
||
510 | 545 | $smcFunc['db_free_result']($request); |
511 | 546 | } |
512 | 547 | |
513 | - if (isset($log['extra']['member']) && !is_numeric($log['extra']['member'])) |
|
514 | - trigger_error('logActions(): data\'s member is not a number', E_USER_NOTICE); |
|
548 | + if (isset($log['extra']['member']) && !is_numeric($log['extra']['member'])) { |
|
549 | + trigger_error('logActions(): data\'s member is not a number', E_USER_NOTICE); |
|
550 | + } |
|
515 | 551 | |
516 | 552 | if (isset($log['extra']['board'])) |
517 | 553 | { |
518 | - if (!is_numeric($log['extra']['board'])) |
|
519 | - trigger_error('logActions(): data\'s board is not a number', E_USER_NOTICE); |
|
554 | + if (!is_numeric($log['extra']['board'])) { |
|
555 | + trigger_error('logActions(): data\'s board is not a number', E_USER_NOTICE); |
|
556 | + } |
|
520 | 557 | $board_id = empty($log['extra']['board']) ? 0 : (int) $log['extra']['board']; |
521 | 558 | unset($log['extra']['board']); |
559 | + } else { |
|
560 | + $board_id = 0; |
|
522 | 561 | } |
523 | - else |
|
524 | - $board_id = 0; |
|
525 | 562 | |
526 | 563 | if (isset($log['extra']['board_to'])) |
527 | 564 | { |
528 | - if (!is_numeric($log['extra']['board_to'])) |
|
529 | - trigger_error('logActions(): data\'s board_to is not a number', E_USER_NOTICE); |
|
565 | + if (!is_numeric($log['extra']['board_to'])) { |
|
566 | + trigger_error('logActions(): data\'s board_to is not a number', E_USER_NOTICE); |
|
567 | + } |
|
530 | 568 | if (empty($board_id)) |
531 | 569 | { |
532 | 570 | $board_id = empty($log['extra']['board_to']) ? 0 : (int) $log['extra']['board_to']; |
@@ -534,10 +572,11 @@ discard block |
||
534 | 572 | } |
535 | 573 | } |
536 | 574 | |
537 | - if (isset($log['extra']['member_affected'])) |
|
538 | - $memID = $log['extra']['member_affected']; |
|
539 | - else |
|
540 | - $memID = $user_info['id']; |
|
575 | + if (isset($log['extra']['member_affected'])) { |
|
576 | + $memID = $log['extra']['member_affected']; |
|
577 | + } else { |
|
578 | + $memID = $user_info['id']; |
|
579 | + } |
|
541 | 580 | |
542 | 581 | $inserts[] = array( |
543 | 582 | time(), $log_types[$log['log_type']], $memID, $user_info['ip'], $log['action'], |