@@ -14,8 +14,9 @@ discard block |
||
| 14 | 14 | * @version 2.1 Beta 4 |
| 15 | 15 | */ |
| 16 | 16 | |
| 17 | -if (!defined('SMF')) |
|
| 17 | +if (!defined('SMF')) { |
|
| 18 | 18 | die('No direct access...'); |
| 19 | +} |
|
| 19 | 20 | |
| 20 | 21 | /** |
| 21 | 22 | * Mark a board or multiple boards read. |
@@ -28,14 +29,16 @@ discard block |
||
| 28 | 29 | global $user_info, $modSettings, $smcFunc; |
| 29 | 30 | |
| 30 | 31 | // Force $boards to be an array. |
| 31 | - if (!is_array($boards)) |
|
| 32 | - $boards = array($boards); |
|
| 33 | - else |
|
| 34 | - $boards = array_unique($boards); |
|
| 32 | + if (!is_array($boards)) { |
|
| 33 | + $boards = array($boards); |
|
| 34 | + } else { |
|
| 35 | + $boards = array_unique($boards); |
|
| 36 | + } |
|
| 35 | 37 | |
| 36 | 38 | // No boards, nothing to mark as read. |
| 37 | - if (empty($boards)) |
|
| 38 | - return; |
|
| 39 | + if (empty($boards)) { |
|
| 40 | + return; |
|
| 41 | + } |
|
| 39 | 42 | |
| 40 | 43 | // Allow the user to mark a board as unread. |
| 41 | 44 | if ($unread) |
@@ -65,8 +68,9 @@ discard block |
||
| 65 | 68 | else |
| 66 | 69 | { |
| 67 | 70 | $markRead = array(); |
| 68 | - foreach ($boards as $board) |
|
| 69 | - $markRead[] = array($modSettings['maxMsgID'], $user_info['id'], $board); |
|
| 71 | + foreach ($boards as $board) { |
|
| 72 | + $markRead[] = array($modSettings['maxMsgID'], $user_info['id'], $board); |
|
| 73 | + } |
|
| 70 | 74 | |
| 71 | 75 | // Update log_mark_read and log_boards. |
| 72 | 76 | $smcFunc['db_insert']('replace', |
@@ -99,8 +103,9 @@ discard block |
||
| 99 | 103 | list ($lowest_topic) = $smcFunc['db_fetch_row']($result); |
| 100 | 104 | $smcFunc['db_free_result']($result); |
| 101 | 105 | |
| 102 | - if (empty($lowest_topic)) |
|
| 103 | - return; |
|
| 106 | + if (empty($lowest_topic)) { |
|
| 107 | + return; |
|
| 108 | + } |
|
| 104 | 109 | |
| 105 | 110 | // @todo SLOW This query seems to eat it sometimes. |
| 106 | 111 | $result = $smcFunc['db_query']('', ' |
@@ -118,12 +123,13 @@ discard block |
||
| 118 | 123 | ) |
| 119 | 124 | ); |
| 120 | 125 | $topics = array(); |
| 121 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
| 122 | - $topics[] = $row['id_topic']; |
|
| 126 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
| 127 | + $topics[] = $row['id_topic']; |
|
| 128 | + } |
|
| 123 | 129 | $smcFunc['db_free_result']($result); |
| 124 | 130 | |
| 125 | - if (!empty($topics)) |
|
| 126 | - $smcFunc['db_query']('', ' |
|
| 131 | + if (!empty($topics)) { |
|
| 132 | + $smcFunc['db_query']('', ' |
|
| 127 | 133 | DELETE FROM {db_prefix}log_topics |
| 128 | 134 | WHERE id_member = {int:current_member} |
| 129 | 135 | AND id_topic IN ({array_int:topic_list})', |
@@ -132,7 +138,8 @@ discard block |
||
| 132 | 138 | 'topic_list' => $topics, |
| 133 | 139 | ) |
| 134 | 140 | ); |
| 135 | -} |
|
| 141 | + } |
|
| 142 | + } |
|
| 136 | 143 | |
| 137 | 144 | /** |
| 138 | 145 | * Mark one or more boards as read. |
@@ -157,23 +164,26 @@ discard block |
||
| 157 | 164 | ) |
| 158 | 165 | ); |
| 159 | 166 | $boards = array(); |
| 160 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
| 161 | - $boards[] = $row['id_board']; |
|
| 167 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
| 168 | + $boards[] = $row['id_board']; |
|
| 169 | + } |
|
| 162 | 170 | $smcFunc['db_free_result']($result); |
| 163 | 171 | |
| 164 | - if (!empty($boards)) |
|
| 165 | - markBoardsRead($boards, isset($_REQUEST['unread'])); |
|
| 172 | + if (!empty($boards)) { |
|
| 173 | + markBoardsRead($boards, isset($_REQUEST['unread'])); |
|
| 174 | + } |
|
| 166 | 175 | |
| 167 | 176 | $_SESSION['id_msg_last_visit'] = $modSettings['maxMsgID']; |
| 168 | - if (!empty($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'action=unread') !== false) |
|
| 169 | - redirectexit('action=unread'); |
|
| 177 | + if (!empty($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'action=unread') !== false) { |
|
| 178 | + redirectexit('action=unread'); |
|
| 179 | + } |
|
| 170 | 180 | |
| 171 | - if (isset($_SESSION['topicseen_cache'])) |
|
| 172 | - $_SESSION['topicseen_cache'] = array(); |
|
| 181 | + if (isset($_SESSION['topicseen_cache'])) { |
|
| 182 | + $_SESSION['topicseen_cache'] = array(); |
|
| 183 | + } |
|
| 173 | 184 | |
| 174 | 185 | redirectexit(); |
| 175 | - } |
|
| 176 | - elseif (isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'unreadreplies') |
|
| 186 | + } elseif (isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'unreadreplies') |
|
| 177 | 187 | { |
| 178 | 188 | // Make sure all the topics are integers! |
| 179 | 189 | $topics = array_map('intval', explode('-', $_REQUEST['topics'])); |
@@ -189,13 +199,15 @@ discard block |
||
| 189 | 199 | ) |
| 190 | 200 | ); |
| 191 | 201 | $logged_topics = array(); |
| 192 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 193 | - $logged_topics[$row['id_topic']] = $row['unwatched']; |
|
| 202 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 203 | + $logged_topics[$row['id_topic']] = $row['unwatched']; |
|
| 204 | + } |
|
| 194 | 205 | $smcFunc['db_free_result']($request); |
| 195 | 206 | |
| 196 | 207 | $markRead = array(); |
| 197 | - foreach ($topics as $id_topic) |
|
| 198 | - $markRead[] = array($modSettings['maxMsgID'], $user_info['id'], $id_topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0)); |
|
| 208 | + foreach ($topics as $id_topic) { |
|
| 209 | + $markRead[] = array($modSettings['maxMsgID'], $user_info['id'], $id_topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0)); |
|
| 210 | + } |
|
| 199 | 211 | |
| 200 | 212 | $smcFunc['db_insert']('replace', |
| 201 | 213 | '{db_prefix}log_topics', |
@@ -204,8 +216,9 @@ discard block |
||
| 204 | 216 | array('id_member', 'id_topic') |
| 205 | 217 | ); |
| 206 | 218 | |
| 207 | - if (isset($_SESSION['topicseen_cache'])) |
|
| 208 | - $_SESSION['topicseen_cache'] = array(); |
|
| 219 | + if (isset($_SESSION['topicseen_cache'])) { |
|
| 220 | + $_SESSION['topicseen_cache'] = array(); |
|
| 221 | + } |
|
| 209 | 222 | |
| 210 | 223 | redirectexit('action=unreadreplies'); |
| 211 | 224 | } |
@@ -230,11 +243,13 @@ discard block |
||
| 230 | 243 | if (!empty($_GET['t'])) |
| 231 | 244 | { |
| 232 | 245 | // If they read the whole topic, go back to the beginning. |
| 233 | - if ($_GET['t'] >= $topicinfo['id_last_msg']) |
|
| 234 | - $earlyMsg = 0; |
|
| 246 | + if ($_GET['t'] >= $topicinfo['id_last_msg']) { |
|
| 247 | + $earlyMsg = 0; |
|
| 248 | + } |
|
| 235 | 249 | // If they want to mark the whole thing read, same. |
| 236 | - elseif ($_GET['t'] <= $topicinfo['id_first_msg']) |
|
| 237 | - $earlyMsg = 0; |
|
| 250 | + elseif ($_GET['t'] <= $topicinfo['id_first_msg']) { |
|
| 251 | + $earlyMsg = 0; |
|
| 252 | + } |
|
| 238 | 253 | // Otherwise, get the latest message before the named one. |
| 239 | 254 | else |
| 240 | 255 | { |
@@ -255,9 +270,9 @@ discard block |
||
| 255 | 270 | } |
| 256 | 271 | } |
| 257 | 272 | // Marking read from first page? That's the whole topic. |
| 258 | - elseif ($_REQUEST['start'] == 0) |
|
| 259 | - $earlyMsg = 0; |
|
| 260 | - else |
|
| 273 | + elseif ($_REQUEST['start'] == 0) { |
|
| 274 | + $earlyMsg = 0; |
|
| 275 | + } else |
|
| 261 | 276 | { |
| 262 | 277 | $result = $smcFunc['db_query']('', ' |
| 263 | 278 | SELECT id_msg |
@@ -285,8 +300,7 @@ discard block |
||
| 285 | 300 | ); |
| 286 | 301 | |
| 287 | 302 | redirectexit('board=' . $board . '.0'); |
| 288 | - } |
|
| 289 | - else |
|
| 303 | + } else |
|
| 290 | 304 | { |
| 291 | 305 | $categories = array(); |
| 292 | 306 | $boards = array(); |
@@ -294,17 +308,20 @@ discard block |
||
| 294 | 308 | if (isset($_REQUEST['c'])) |
| 295 | 309 | { |
| 296 | 310 | $_REQUEST['c'] = explode(',', $_REQUEST['c']); |
| 297 | - foreach ($_REQUEST['c'] as $c) |
|
| 298 | - $categories[] = (int) $c; |
|
| 311 | + foreach ($_REQUEST['c'] as $c) { |
|
| 312 | + $categories[] = (int) $c; |
|
| 313 | + } |
|
| 299 | 314 | } |
| 300 | 315 | if (isset($_REQUEST['boards'])) |
| 301 | 316 | { |
| 302 | 317 | $_REQUEST['boards'] = explode(',', $_REQUEST['boards']); |
| 303 | - foreach ($_REQUEST['boards'] as $b) |
|
| 304 | - $boards[] = (int) $b; |
|
| 318 | + foreach ($_REQUEST['boards'] as $b) { |
|
| 319 | + $boards[] = (int) $b; |
|
| 320 | + } |
|
| 321 | + } |
|
| 322 | + if (!empty($board)) { |
|
| 323 | + $boards[] = (int) $board; |
|
| 305 | 324 | } |
| 306 | - if (!empty($board)) |
|
| 307 | - $boards[] = (int) $board; |
|
| 308 | 325 | |
| 309 | 326 | if (isset($_REQUEST['children']) && !empty($boards)) |
| 310 | 327 | { |
@@ -324,9 +341,10 @@ discard block |
||
| 324 | 341 | 'board_list' => $boards, |
| 325 | 342 | ) |
| 326 | 343 | ); |
| 327 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 328 | - if (in_array($row['id_parent'], $boards)) |
|
| 344 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 345 | + if (in_array($row['id_parent'], $boards)) |
|
| 329 | 346 | $boards[] = $row['id_board']; |
| 347 | + } |
|
| 330 | 348 | $smcFunc['db_free_result']($request); |
| 331 | 349 | } |
| 332 | 350 | |
@@ -343,8 +361,9 @@ discard block |
||
| 343 | 361 | $clauseParameters['board_list'] = $boards; |
| 344 | 362 | } |
| 345 | 363 | |
| 346 | - if (empty($clauses)) |
|
| 347 | - redirectexit(); |
|
| 364 | + if (empty($clauses)) { |
|
| 365 | + redirectexit(); |
|
| 366 | + } |
|
| 348 | 367 | |
| 349 | 368 | $request = $smcFunc['db_query']('', ' |
| 350 | 369 | SELECT b.id_board |
@@ -355,19 +374,22 @@ discard block |
||
| 355 | 374 | )) |
| 356 | 375 | ); |
| 357 | 376 | $boards = array(); |
| 358 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 359 | - $boards[] = $row['id_board']; |
|
| 377 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 378 | + $boards[] = $row['id_board']; |
|
| 379 | + } |
|
| 360 | 380 | $smcFunc['db_free_result']($request); |
| 361 | 381 | |
| 362 | - if (empty($boards)) |
|
| 363 | - redirectexit(); |
|
| 382 | + if (empty($boards)) { |
|
| 383 | + redirectexit(); |
|
| 384 | + } |
|
| 364 | 385 | |
| 365 | 386 | markBoardsRead($boards, isset($_REQUEST['unread'])); |
| 366 | 387 | |
| 367 | 388 | foreach ($boards as $b) |
| 368 | 389 | { |
| 369 | - if (isset($_SESSION['topicseen_cache'][$b])) |
|
| 370 | - $_SESSION['topicseen_cache'][$b] = array(); |
|
| 390 | + if (isset($_SESSION['topicseen_cache'][$b])) { |
|
| 391 | + $_SESSION['topicseen_cache'][$b] = array(); |
|
| 392 | + } |
|
| 371 | 393 | } |
| 372 | 394 | |
| 373 | 395 | if (!isset($_REQUEST['unread'])) |
@@ -384,8 +406,9 @@ discard block |
||
| 384 | 406 | if ($smcFunc['db_num_rows']($result) > 0) |
| 385 | 407 | { |
| 386 | 408 | $logBoardInserts = array(); |
| 387 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
| 388 | - $logBoardInserts[] = array($modSettings['maxMsgID'], $user_info['id'], $row['id_board']); |
|
| 409 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
| 410 | + $logBoardInserts[] = array($modSettings['maxMsgID'], $user_info['id'], $row['id_board']); |
|
| 411 | + } |
|
| 389 | 412 | |
| 390 | 413 | $smcFunc['db_insert']('replace', |
| 391 | 414 | '{db_prefix}log_boards', |
@@ -396,17 +419,18 @@ discard block |
||
| 396 | 419 | } |
| 397 | 420 | $smcFunc['db_free_result']($result); |
| 398 | 421 | |
| 399 | - if (empty($board)) |
|
| 400 | - redirectexit(); |
|
| 401 | - else |
|
| 402 | - redirectexit('board=' . $board . '.0'); |
|
| 403 | - } |
|
| 404 | - else |
|
| 422 | + if (empty($board)) { |
|
| 423 | + redirectexit(); |
|
| 424 | + } else { |
|
| 425 | + redirectexit('board=' . $board . '.0'); |
|
| 426 | + } |
|
| 427 | + } else |
|
| 405 | 428 | { |
| 406 | - if (empty($board_info['parent'])) |
|
| 407 | - redirectexit(); |
|
| 408 | - else |
|
| 409 | - redirectexit('board=' . $board_info['parent'] . '.0'); |
|
| 429 | + if (empty($board_info['parent'])) { |
|
| 430 | + redirectexit(); |
|
| 431 | + } else { |
|
| 432 | + redirectexit('board=' . $board_info['parent'] . '.0'); |
|
| 433 | + } |
|
| 410 | 434 | } |
| 411 | 435 | } |
| 412 | 436 | } |
@@ -431,11 +455,13 @@ discard block |
||
| 431 | 455 | 'selected_message' => (int) $messageID, |
| 432 | 456 | ) |
| 433 | 457 | ); |
| 434 | - if ($smcFunc['db_num_rows']($result) > 0) |
|
| 435 | - list ($memberID) = $smcFunc['db_fetch_row']($result); |
|
| 458 | + if ($smcFunc['db_num_rows']($result) > 0) { |
|
| 459 | + list ($memberID) = $smcFunc['db_fetch_row']($result); |
|
| 460 | + } |
|
| 436 | 461 | // The message doesn't even exist. |
| 437 | - else |
|
| 438 | - $memberID = 0; |
|
| 462 | + else { |
|
| 463 | + $memberID = 0; |
|
| 464 | + } |
|
| 439 | 465 | $smcFunc['db_free_result']($result); |
| 440 | 466 | |
| 441 | 467 | return (int) $memberID; |
@@ -456,8 +482,9 @@ discard block |
||
| 456 | 482 | getBoardTree(); |
| 457 | 483 | |
| 458 | 484 | // Make sure given boards and categories exist. |
| 459 | - if (!isset($boards[$board_id]) || (isset($boardOptions['target_board']) && !isset($boards[$boardOptions['target_board']])) || (isset($boardOptions['target_category']) && !isset($cat_tree[$boardOptions['target_category']]))) |
|
| 460 | - fatal_lang_error('no_board'); |
|
| 485 | + if (!isset($boards[$board_id]) || (isset($boardOptions['target_board']) && !isset($boards[$boardOptions['target_board']])) || (isset($boardOptions['target_category']) && !isset($cat_tree[$boardOptions['target_category']]))) { |
|
| 486 | + fatal_lang_error('no_board'); |
|
| 487 | + } |
|
| 461 | 488 | |
| 462 | 489 | $id = $board_id; |
| 463 | 490 | call_integration_hook('integrate_pre_modify_board', array($id, &$boardOptions)); |
@@ -485,8 +512,9 @@ discard block |
||
| 485 | 512 | $child_level = 0; |
| 486 | 513 | $id_parent = 0; |
| 487 | 514 | $after = 0; |
| 488 | - foreach ($cat_tree[$id_cat]['children'] as $id_board => $dummy) |
|
| 489 | - $after = max($after, $boards[$id_board]['order']); |
|
| 515 | + foreach ($cat_tree[$id_cat]['children'] as $id_board => $dummy) { |
|
| 516 | + $after = max($after, $boards[$id_board]['order']); |
|
| 517 | + } |
|
| 490 | 518 | } |
| 491 | 519 | |
| 492 | 520 | // Make the board a child of a given board. |
@@ -497,17 +525,19 @@ discard block |
||
| 497 | 525 | $id_parent = $boardOptions['target_board']; |
| 498 | 526 | |
| 499 | 527 | // People can be creative, in many ways... |
| 500 | - if (isChildOf($id_parent, $board_id)) |
|
| 501 | - fatal_lang_error('mboards_parent_own_child_error', false); |
|
| 502 | - elseif ($id_parent == $board_id) |
|
| 503 | - fatal_lang_error('mboards_board_own_child_error', false); |
|
| 528 | + if (isChildOf($id_parent, $board_id)) { |
|
| 529 | + fatal_lang_error('mboards_parent_own_child_error', false); |
|
| 530 | + } elseif ($id_parent == $board_id) { |
|
| 531 | + fatal_lang_error('mboards_board_own_child_error', false); |
|
| 532 | + } |
|
| 504 | 533 | |
| 505 | 534 | $after = $boards[$boardOptions['target_board']]['order']; |
| 506 | 535 | |
| 507 | 536 | // Check if there are already children and (if so) get the max board order. |
| 508 | - if (!empty($boards[$id_parent]['tree']['children']) && empty($boardOptions['move_first_child'])) |
|
| 509 | - foreach ($boards[$id_parent]['tree']['children'] as $childBoard_id => $dummy) |
|
| 537 | + if (!empty($boards[$id_parent]['tree']['children']) && empty($boardOptions['move_first_child'])) { |
|
| 538 | + foreach ($boards[$id_parent]['tree']['children'] as $childBoard_id => $dummy) |
|
| 510 | 539 | $after = max($after, $boards[$childBoard_id]['order']); |
| 540 | + } |
|
| 511 | 541 | } |
| 512 | 542 | |
| 513 | 543 | // Place a board before or after another board, on the same child level. |
@@ -520,8 +550,9 @@ discard block |
||
| 520 | 550 | } |
| 521 | 551 | |
| 522 | 552 | // Oops...? |
| 523 | - else |
|
| 524 | - trigger_error('modifyBoard(): The move_to value \'' . $boardOptions['move_to'] . '\' is incorrect', E_USER_ERROR); |
|
| 553 | + else { |
|
| 554 | + trigger_error('modifyBoard(): The move_to value \'' . $boardOptions['move_to'] . '\' is incorrect', E_USER_ERROR); |
|
| 555 | + } |
|
| 525 | 556 | |
| 526 | 557 | // Get a list of children of this board. |
| 527 | 558 | $childList = array(); |
@@ -530,14 +561,16 @@ discard block |
||
| 530 | 561 | // See if there are changes that affect children. |
| 531 | 562 | $childUpdates = array(); |
| 532 | 563 | $levelDiff = $child_level - $boards[$board_id]['level']; |
| 533 | - if ($levelDiff != 0) |
|
| 534 | - $childUpdates[] = 'child_level = child_level ' . ($levelDiff > 0 ? '+ ' : '') . '{int:level_diff}'; |
|
| 535 | - if ($id_cat != $boards[$board_id]['category']) |
|
| 536 | - $childUpdates[] = 'id_cat = {int:category}'; |
|
| 564 | + if ($levelDiff != 0) { |
|
| 565 | + $childUpdates[] = 'child_level = child_level ' . ($levelDiff > 0 ? '+ ' : '') . '{int:level_diff}'; |
|
| 566 | + } |
|
| 567 | + if ($id_cat != $boards[$board_id]['category']) { |
|
| 568 | + $childUpdates[] = 'id_cat = {int:category}'; |
|
| 569 | + } |
|
| 537 | 570 | |
| 538 | 571 | // Fix the children of this board. |
| 539 | - if (!empty($childList) && !empty($childUpdates)) |
|
| 540 | - $smcFunc['db_query']('', ' |
|
| 572 | + if (!empty($childList) && !empty($childUpdates)) { |
|
| 573 | + $smcFunc['db_query']('', ' |
|
| 541 | 574 | UPDATE {db_prefix}boards |
| 542 | 575 | SET ' . implode(', |
| 543 | 576 | ', $childUpdates) . ' |
@@ -548,6 +581,7 @@ discard block |
||
| 548 | 581 | 'level_diff' => $levelDiff, |
| 549 | 582 | ) |
| 550 | 583 | ); |
| 584 | + } |
|
| 551 | 585 | |
| 552 | 586 | // Make some room for this spot. |
| 553 | 587 | $smcFunc['db_query']('', ' |
@@ -643,8 +677,8 @@ discard block |
||
| 643 | 677 | call_integration_hook('integrate_modify_board', array($id, $boardOptions, &$boardUpdates, &$boardUpdateParameters)); |
| 644 | 678 | |
| 645 | 679 | // Do the updates (if any). |
| 646 | - if (!empty($boardUpdates)) |
|
| 647 | - $smcFunc['db_query']('', ' |
|
| 680 | + if (!empty($boardUpdates)) { |
|
| 681 | + $smcFunc['db_query']('', ' |
|
| 648 | 682 | UPDATE {db_prefix}boards |
| 649 | 683 | SET |
| 650 | 684 | ' . implode(', |
@@ -654,12 +688,15 @@ discard block |
||
| 654 | 688 | 'selected_board' => $board_id, |
| 655 | 689 | )) |
| 656 | 690 | ); |
| 691 | + } |
|
| 657 | 692 | |
| 658 | 693 | // Do permission sync |
| 659 | - if (!empty($boardUpdateParameters['deny_groups'])) |
|
| 660 | - $insert = array(); |
|
| 661 | - foreach($boardOptions['deny_groups'] as $value) |
|
| 662 | - $insert[] = array($value, $board_id, 1); |
|
| 694 | + if (!empty($boardUpdateParameters['deny_groups'])) { |
|
| 695 | + $insert = array(); |
|
| 696 | + } |
|
| 697 | + foreach($boardOptions['deny_groups'] as $value) { |
|
| 698 | + $insert[] = array($value, $board_id, 1); |
|
| 699 | + } |
|
| 663 | 700 | $smcFunc['db_query']('', ' |
| 664 | 701 | DELETE FROM {db_prefix}board_permissions_view |
| 665 | 702 | WHERE id_board = {int:selected_board} AND deny = 1', |
@@ -676,8 +713,9 @@ discard block |
||
| 676 | 713 | if (!empty($boardUpdateParameters['member_groups'])) |
| 677 | 714 | { |
| 678 | 715 | $insert = array(); |
| 679 | - foreach($boardOptions['access_groups'] as $value) |
|
| 680 | - $insert[] = array($value, $board_id, 0); |
|
| 716 | + foreach($boardOptions['access_groups'] as $value) { |
|
| 717 | + $insert[] = array($value, $board_id, 0); |
|
| 718 | + } |
|
| 681 | 719 | $smcFunc['db_query']('', ' |
| 682 | 720 | DELETE FROM {db_prefix}board_permissions_view |
| 683 | 721 | WHERE id_board = {int:selected_board} AND deny = 0', |
@@ -717,13 +755,15 @@ discard block |
||
| 717 | 755 | { |
| 718 | 756 | $moderators[$k] = trim($moderators[$k]); |
| 719 | 757 | |
| 720 | - if (strlen($moderators[$k]) == 0) |
|
| 721 | - unset($moderators[$k]); |
|
| 758 | + if (strlen($moderators[$k]) == 0) { |
|
| 759 | + unset($moderators[$k]); |
|
| 760 | + } |
|
| 722 | 761 | } |
| 723 | 762 | |
| 724 | 763 | // Find all the id_member's for the member_name's in the list. |
| 725 | - if (empty($boardOptions['moderators'])) |
|
| 726 | - $boardOptions['moderators'] = array(); |
|
| 764 | + if (empty($boardOptions['moderators'])) { |
|
| 765 | + $boardOptions['moderators'] = array(); |
|
| 766 | + } |
|
| 727 | 767 | if (!empty($moderators)) |
| 728 | 768 | { |
| 729 | 769 | $request = $smcFunc['db_query']('', ' |
@@ -736,8 +776,9 @@ discard block |
||
| 736 | 776 | 'limit' => count($moderators), |
| 737 | 777 | ) |
| 738 | 778 | ); |
| 739 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 740 | - $boardOptions['moderators'][] = $row['id_member']; |
|
| 779 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 780 | + $boardOptions['moderators'][] = $row['id_member']; |
|
| 781 | + } |
|
| 741 | 782 | $smcFunc['db_free_result']($request); |
| 742 | 783 | } |
| 743 | 784 | } |
@@ -746,8 +787,9 @@ discard block |
||
| 746 | 787 | if (!empty($boardOptions['moderators'])) |
| 747 | 788 | { |
| 748 | 789 | $inserts = array(); |
| 749 | - foreach ($boardOptions['moderators'] as $moderator) |
|
| 750 | - $inserts[] = array($board_id, $moderator); |
|
| 790 | + foreach ($boardOptions['moderators'] as $moderator) { |
|
| 791 | + $inserts[] = array($board_id, $moderator); |
|
| 792 | + } |
|
| 751 | 793 | |
| 752 | 794 | $smcFunc['db_insert']('insert', |
| 753 | 795 | '{db_prefix}moderators', |
@@ -777,14 +819,16 @@ discard block |
||
| 777 | 819 | { |
| 778 | 820 | $moderator_groups[$k] = trim($moderator_groups[$k]); |
| 779 | 821 | |
| 780 | - if (strlen($moderator_groups[$k]) == 0) |
|
| 781 | - unset($moderator_groups[$k]); |
|
| 822 | + if (strlen($moderator_groups[$k]) == 0) { |
|
| 823 | + unset($moderator_groups[$k]); |
|
| 824 | + } |
|
| 782 | 825 | } |
| 783 | 826 | |
| 784 | 827 | /* Find all the id_group's for all the group names in the list |
| 785 | 828 | But skip any invalid ones (invisible/post groups/Administrator/Moderator) */ |
| 786 | - if (empty($boardOptions['moderator_groups'])) |
|
| 787 | - $boardOptions['moderator_groups'] = array(); |
|
| 829 | + if (empty($boardOptions['moderator_groups'])) { |
|
| 830 | + $boardOptions['moderator_groups'] = array(); |
|
| 831 | + } |
|
| 788 | 832 | if (!empty($moderator_groups)) |
| 789 | 833 | { |
| 790 | 834 | $request = $smcFunc['db_query']('', ' |
@@ -815,8 +859,9 @@ discard block |
||
| 815 | 859 | if (!empty($boardOptions['moderator_groups'])) |
| 816 | 860 | { |
| 817 | 861 | $inserts = array(); |
| 818 | - foreach ($boardOptions['moderator_groups'] as $moderator_group) |
|
| 819 | - $inserts[] = array($board_id, $moderator_group); |
|
| 862 | + foreach ($boardOptions['moderator_groups'] as $moderator_group) { |
|
| 863 | + $inserts[] = array($board_id, $moderator_group); |
|
| 864 | + } |
|
| 820 | 865 | |
| 821 | 866 | $smcFunc['db_insert']('insert', |
| 822 | 867 | '{db_prefix}moderator_groups', |
@@ -830,14 +875,16 @@ discard block |
||
| 830 | 875 | updateSettings(array('settings_updated' => time())); |
| 831 | 876 | } |
| 832 | 877 | |
| 833 | - if (isset($boardOptions['move_to'])) |
|
| 834 | - reorderBoards(); |
|
| 878 | + if (isset($boardOptions['move_to'])) { |
|
| 879 | + reorderBoards(); |
|
| 880 | + } |
|
| 835 | 881 | |
| 836 | 882 | clean_cache('data'); |
| 837 | 883 | |
| 838 | - if (empty($boardOptions['dont_log'])) |
|
| 839 | - logAction('edit_board', array('board' => $board_id), 'admin'); |
|
| 840 | -} |
|
| 884 | + if (empty($boardOptions['dont_log'])) { |
|
| 885 | + logAction('edit_board', array('board' => $board_id), 'admin'); |
|
| 886 | + } |
|
| 887 | + } |
|
| 841 | 888 | |
| 842 | 889 | /** |
| 843 | 890 | * Create a new board and set its properties and position. |
@@ -853,11 +900,13 @@ discard block |
||
| 853 | 900 | global $boards, $smcFunc; |
| 854 | 901 | |
| 855 | 902 | // Trigger an error if one of the required values is not set. |
| 856 | - if (!isset($boardOptions['board_name']) || trim($boardOptions['board_name']) == '' || !isset($boardOptions['move_to']) || !isset($boardOptions['target_category'])) |
|
| 857 | - trigger_error('createBoard(): One or more of the required options is not set', E_USER_ERROR); |
|
| 903 | + if (!isset($boardOptions['board_name']) || trim($boardOptions['board_name']) == '' || !isset($boardOptions['move_to']) || !isset($boardOptions['target_category'])) { |
|
| 904 | + trigger_error('createBoard(): One or more of the required options is not set', E_USER_ERROR); |
|
| 905 | + } |
|
| 858 | 906 | |
| 859 | - if (in_array($boardOptions['move_to'], array('child', 'before', 'after')) && !isset($boardOptions['target_board'])) |
|
| 860 | - trigger_error('createBoard(): Target board is not set', E_USER_ERROR); |
|
| 907 | + if (in_array($boardOptions['move_to'], array('child', 'before', 'after')) && !isset($boardOptions['target_board'])) { |
|
| 908 | + trigger_error('createBoard(): Target board is not set', E_USER_ERROR); |
|
| 909 | + } |
|
| 861 | 910 | |
| 862 | 911 | // Set every optional value to its default value. |
| 863 | 912 | $boardOptions += array( |
@@ -896,8 +945,9 @@ discard block |
||
| 896 | 945 | |
| 897 | 946 | $insert = array(); |
| 898 | 947 | |
| 899 | - foreach(explode(',', $default_memgrps) as $value) |
|
| 900 | - $insert[] = array($value, $board_id, 0); |
|
| 948 | + foreach(explode(',', $default_memgrps) as $value) { |
|
| 949 | + $insert[] = array($value, $board_id, 0); |
|
| 950 | + } |
|
| 901 | 951 | |
| 902 | 952 | $smcFunc['db_insert']('', |
| 903 | 953 | '{db_prefix}board_permissions_view', |
@@ -907,8 +957,9 @@ discard block |
||
| 907 | 957 | 1 |
| 908 | 958 | ); |
| 909 | 959 | |
| 910 | - if (empty($board_id)) |
|
| 911 | - return 0; |
|
| 960 | + if (empty($board_id)) { |
|
| 961 | + return 0; |
|
| 962 | + } |
|
| 912 | 963 | |
| 913 | 964 | // Change the board according to the given specifications. |
| 914 | 965 | modifyBoard($board_id, $boardOptions); |
@@ -971,8 +1022,9 @@ discard block |
||
| 971 | 1022 | global $sourcedir, $boards, $smcFunc; |
| 972 | 1023 | |
| 973 | 1024 | // No boards to delete? Return! |
| 974 | - if (empty($boards_to_remove)) |
|
| 975 | - return; |
|
| 1025 | + if (empty($boards_to_remove)) { |
|
| 1026 | + return; |
|
| 1027 | + } |
|
| 976 | 1028 | |
| 977 | 1029 | getBoardTree(); |
| 978 | 1030 | |
@@ -983,12 +1035,14 @@ discard block |
||
| 983 | 1035 | { |
| 984 | 1036 | // Get a list of the child boards that will also be removed. |
| 985 | 1037 | $child_boards_to_remove = array(); |
| 986 | - foreach ($boards_to_remove as $board_to_remove) |
|
| 987 | - recursiveBoards($child_boards_to_remove, $boards[$board_to_remove]['tree']); |
|
| 1038 | + foreach ($boards_to_remove as $board_to_remove) { |
|
| 1039 | + recursiveBoards($child_boards_to_remove, $boards[$board_to_remove]['tree']); |
|
| 1040 | + } |
|
| 988 | 1041 | |
| 989 | 1042 | // Merge the children with their parents. |
| 990 | - if (!empty($child_boards_to_remove)) |
|
| 991 | - $boards_to_remove = array_unique(array_merge($boards_to_remove, $child_boards_to_remove)); |
|
| 1043 | + if (!empty($child_boards_to_remove)) { |
|
| 1044 | + $boards_to_remove = array_unique(array_merge($boards_to_remove, $child_boards_to_remove)); |
|
| 1045 | + } |
|
| 992 | 1046 | } |
| 993 | 1047 | // Move the children to a safe home. |
| 994 | 1048 | else |
@@ -996,10 +1050,11 @@ discard block |
||
| 996 | 1050 | foreach ($boards_to_remove as $id_board) |
| 997 | 1051 | { |
| 998 | 1052 | // @todo Separate category? |
| 999 | - if ($moveChildrenTo === 0) |
|
| 1000 | - fixChildren($id_board, 0, 0); |
|
| 1001 | - else |
|
| 1002 | - fixChildren($id_board, $boards[$moveChildrenTo]['level'] + 1, $moveChildrenTo); |
|
| 1053 | + if ($moveChildrenTo === 0) { |
|
| 1054 | + fixChildren($id_board, 0, 0); |
|
| 1055 | + } else { |
|
| 1056 | + fixChildren($id_board, $boards[$moveChildrenTo]['level'] + 1, $moveChildrenTo); |
|
| 1057 | + } |
|
| 1003 | 1058 | } |
| 1004 | 1059 | } |
| 1005 | 1060 | |
@@ -1013,8 +1068,9 @@ discard block |
||
| 1013 | 1068 | ) |
| 1014 | 1069 | ); |
| 1015 | 1070 | $topics = array(); |
| 1016 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1017 | - $topics[] = $row['id_topic']; |
|
| 1071 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1072 | + $topics[] = $row['id_topic']; |
|
| 1073 | + } |
|
| 1018 | 1074 | $smcFunc['db_free_result']($request); |
| 1019 | 1075 | |
| 1020 | 1076 | require_once($sourcedir . '/RemoveTopic.php'); |
@@ -1111,8 +1167,9 @@ discard block |
||
| 1111 | 1167 | clean_cache('data'); |
| 1112 | 1168 | |
| 1113 | 1169 | // Let's do some serious logging. |
| 1114 | - foreach ($boards_to_remove as $id_board) |
|
| 1115 | - logAction('delete_board', array('boardname' => $boards[$id_board]['name']), 'admin'); |
|
| 1170 | + foreach ($boards_to_remove as $id_board) { |
|
| 1171 | + logAction('delete_board', array('boardname' => $boards[$id_board]['name']), 'admin'); |
|
| 1172 | + } |
|
| 1116 | 1173 | |
| 1117 | 1174 | reorderBoards(); |
| 1118 | 1175 | } |
@@ -1131,8 +1188,8 @@ discard block |
||
| 1131 | 1188 | $board_order = 0; |
| 1132 | 1189 | foreach ($cat_tree as $catID => $dummy) |
| 1133 | 1190 | { |
| 1134 | - foreach ($boardList[$catID] as $boardID) |
|
| 1135 | - if ($boards[$boardID]['order'] != ++$board_order) |
|
| 1191 | + foreach ($boardList[$catID] as $boardID) { |
|
| 1192 | + if ($boards[$boardID]['order'] != ++$board_order) |
|
| 1136 | 1193 | $smcFunc['db_query']('', ' |
| 1137 | 1194 | UPDATE {db_prefix}boards |
| 1138 | 1195 | SET board_order = {int:new_order} |
@@ -1142,6 +1199,7 @@ discard block |
||
| 1142 | 1199 | 'selected_board' => $boardID, |
| 1143 | 1200 | ) |
| 1144 | 1201 | ); |
| 1202 | + } |
|
| 1145 | 1203 | } |
| 1146 | 1204 | |
| 1147 | 1205 | // Empty the board order cache |
@@ -1170,8 +1228,9 @@ discard block |
||
| 1170 | 1228 | ) |
| 1171 | 1229 | ); |
| 1172 | 1230 | $children = array(); |
| 1173 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
| 1174 | - $children[] = $row['id_board']; |
|
| 1231 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
| 1232 | + $children[] = $row['id_board']; |
|
| 1233 | + } |
|
| 1175 | 1234 | $smcFunc['db_free_result']($result); |
| 1176 | 1235 | |
| 1177 | 1236 | // ...and set it to a new parent and child_level. |
@@ -1187,9 +1246,10 @@ discard block |
||
| 1187 | 1246 | ); |
| 1188 | 1247 | |
| 1189 | 1248 | // Recursively fix the children of the children. |
| 1190 | - foreach ($children as $child) |
|
| 1191 | - fixChildren($child, $newLevel + 1, $child); |
|
| 1192 | -} |
|
| 1249 | + foreach ($children as $child) { |
|
| 1250 | + fixChildren($child, $newLevel + 1, $child); |
|
| 1251 | + } |
|
| 1252 | + } |
|
| 1193 | 1253 | |
| 1194 | 1254 | /** |
| 1195 | 1255 | * Tries to load up the entire board order and category very very quickly |
@@ -1206,8 +1266,9 @@ discard block |
||
| 1206 | 1266 | 'boards' => array(), |
| 1207 | 1267 | ); |
| 1208 | 1268 | |
| 1209 | - if (!empty($tree_order['boards'])) |
|
| 1210 | - return $tree_order; |
|
| 1269 | + if (!empty($tree_order['boards'])) { |
|
| 1270 | + return $tree_order; |
|
| 1271 | + } |
|
| 1211 | 1272 | |
| 1212 | 1273 | if (($cached = cache_get_data('board_order', 86400)) !== null) |
| 1213 | 1274 | { |
@@ -1223,8 +1284,9 @@ discard block |
||
| 1223 | 1284 | ); |
| 1224 | 1285 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1225 | 1286 | { |
| 1226 | - if (!in_array($row['id_cat'], $tree_order['cats'])) |
|
| 1227 | - $tree_order['cats'][] = $row['id_cat']; |
|
| 1287 | + if (!in_array($row['id_cat'], $tree_order['cats'])) { |
|
| 1288 | + $tree_order['cats'][] = $row['id_cat']; |
|
| 1289 | + } |
|
| 1228 | 1290 | $tree_order['boards'][] = $row['id_board']; |
| 1229 | 1291 | } |
| 1230 | 1292 | $smcFunc['db_free_result']($request); |
@@ -1244,16 +1306,19 @@ discard block |
||
| 1244 | 1306 | $tree = getTreeOrder(); |
| 1245 | 1307 | |
| 1246 | 1308 | $ordered = array(); |
| 1247 | - foreach ($tree['boards'] as $board) |
|
| 1248 | - if (!empty($boards[$board])) |
|
| 1309 | + foreach ($tree['boards'] as $board) { |
|
| 1310 | + if (!empty($boards[$board])) |
|
| 1249 | 1311 | { |
| 1250 | 1312 | $ordered[$board] = $boards[$board]; |
| 1313 | + } |
|
| 1251 | 1314 | |
| 1252 | - if (is_array($ordered[$board]) && !empty($ordered[$board]['boards'])) |
|
| 1253 | - sortBoards($ordered[$board]['boards']); |
|
| 1315 | + if (is_array($ordered[$board]) && !empty($ordered[$board]['boards'])) { |
|
| 1316 | + sortBoards($ordered[$board]['boards']); |
|
| 1317 | + } |
|
| 1254 | 1318 | |
| 1255 | - if (is_array($ordered[$board]) && !empty($ordered[$board]['children'])) |
|
| 1256 | - sortBoards($ordered[$board]['children']); |
|
| 1319 | + if (is_array($ordered[$board]) && !empty($ordered[$board]['children'])) { |
|
| 1320 | + sortBoards($ordered[$board]['children']); |
|
| 1321 | + } |
|
| 1257 | 1322 | } |
| 1258 | 1323 | |
| 1259 | 1324 | $boards = $ordered; |
@@ -1269,12 +1334,14 @@ discard block |
||
| 1269 | 1334 | $tree = getTreeOrder(); |
| 1270 | 1335 | |
| 1271 | 1336 | $ordered = array(); |
| 1272 | - foreach ($tree['cats'] as $cat) |
|
| 1273 | - if (!empty($categories[$cat])) |
|
| 1337 | + foreach ($tree['cats'] as $cat) { |
|
| 1338 | + if (!empty($categories[$cat])) |
|
| 1274 | 1339 | { |
| 1275 | 1340 | $ordered[$cat] = $categories[$cat]; |
| 1276 | - if (!empty($ordered[$cat]['boards'])) |
|
| 1277 | - sortBoards($ordered[$cat]['boards']); |
|
| 1341 | + } |
|
| 1342 | + if (!empty($ordered[$cat]['boards'])) { |
|
| 1343 | + sortBoards($ordered[$cat]['boards']); |
|
| 1344 | + } |
|
| 1278 | 1345 | } |
| 1279 | 1346 | |
| 1280 | 1347 | $categories = $ordered; |
@@ -1290,8 +1357,9 @@ discard block |
||
| 1290 | 1357 | { |
| 1291 | 1358 | global $smcFunc, $scripturl, $txt; |
| 1292 | 1359 | |
| 1293 | - if (empty($boards)) |
|
| 1294 | - return array(); |
|
| 1360 | + if (empty($boards)) { |
|
| 1361 | + return array(); |
|
| 1362 | + } |
|
| 1295 | 1363 | |
| 1296 | 1364 | $request = $smcFunc['db_query']('', ' |
| 1297 | 1365 | SELECT mem.id_member, mem.real_name, mo.id_board |
@@ -1305,8 +1373,9 @@ discard block |
||
| 1305 | 1373 | $moderators = array(); |
| 1306 | 1374 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1307 | 1375 | { |
| 1308 | - if (empty($moderators[$row['id_board']])) |
|
| 1309 | - $moderators[$row['id_board']] = array(); |
|
| 1376 | + if (empty($moderators[$row['id_board']])) { |
|
| 1377 | + $moderators[$row['id_board']] = array(); |
|
| 1378 | + } |
|
| 1310 | 1379 | |
| 1311 | 1380 | $moderators[$row['id_board']][] = array( |
| 1312 | 1381 | 'id' => $row['id_member'], |
@@ -1330,8 +1399,9 @@ discard block |
||
| 1330 | 1399 | { |
| 1331 | 1400 | global $smcFunc, $scripturl, $txt; |
| 1332 | 1401 | |
| 1333 | - if (empty($boards)) |
|
| 1334 | - return array(); |
|
| 1402 | + if (empty($boards)) { |
|
| 1403 | + return array(); |
|
| 1404 | + } |
|
| 1335 | 1405 | |
| 1336 | 1406 | $request = $smcFunc['db_query']('', ' |
| 1337 | 1407 | SELECT mg.id_group, mg.group_name, bg.id_board |
@@ -1345,8 +1415,9 @@ discard block |
||
| 1345 | 1415 | $groups = array(); |
| 1346 | 1416 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1347 | 1417 | { |
| 1348 | - if (empty($groups[$row['id_board']])) |
|
| 1349 | - $groups[$row['id_board']] = array(); |
|
| 1418 | + if (empty($groups[$row['id_board']])) { |
|
| 1419 | + $groups[$row['id_board']] = array(); |
|
| 1420 | + } |
|
| 1350 | 1421 | |
| 1351 | 1422 | $groups[$row['id_board']][] = array( |
| 1352 | 1423 | 'id' => $row['id_group'], |
@@ -1421,8 +1492,9 @@ discard block |
||
| 1421 | 1492 | |
| 1422 | 1493 | if (!empty($row['id_board'])) |
| 1423 | 1494 | { |
| 1424 | - if ($row['child_level'] != $curLevel) |
|
| 1425 | - $prevBoard = 0; |
|
| 1495 | + if ($row['child_level'] != $curLevel) { |
|
| 1496 | + $prevBoard = 0; |
|
| 1497 | + } |
|
| 1426 | 1498 | |
| 1427 | 1499 | $boards[$row['id_board']] = array( |
| 1428 | 1500 | 'id' => $row['id_board'], |
@@ -1454,16 +1526,16 @@ discard block |
||
| 1454 | 1526 | 'children' => array() |
| 1455 | 1527 | ); |
| 1456 | 1528 | $boards[$row['id_board']]['tree'] = &$cat_tree[$row['id_cat']]['children'][$row['id_board']]; |
| 1457 | - } |
|
| 1458 | - else |
|
| 1529 | + } else |
|
| 1459 | 1530 | { |
| 1460 | 1531 | // Parent doesn't exist! |
| 1461 | - if (!isset($boards[$row['id_parent']]['tree'])) |
|
| 1462 | - fatal_lang_error('no_valid_parent', false, array($row['board_name'])); |
|
| 1532 | + if (!isset($boards[$row['id_parent']]['tree'])) { |
|
| 1533 | + fatal_lang_error('no_valid_parent', false, array($row['board_name'])); |
|
| 1534 | + } |
|
| 1463 | 1535 | |
| 1464 | 1536 | // Wrong childlevel...we can silently fix this... |
| 1465 | - if ($boards[$row['id_parent']]['tree']['node']['level'] != $row['child_level'] - 1) |
|
| 1466 | - $smcFunc['db_query']('', ' |
|
| 1537 | + if ($boards[$row['id_parent']]['tree']['node']['level'] != $row['child_level'] - 1) { |
|
| 1538 | + $smcFunc['db_query']('', ' |
|
| 1467 | 1539 | UPDATE {db_prefix}boards |
| 1468 | 1540 | SET child_level = {int:new_child_level} |
| 1469 | 1541 | WHERE id_board = {int:selected_board}', |
@@ -1472,6 +1544,7 @@ discard block |
||
| 1472 | 1544 | 'selected_board' => $row['id_board'], |
| 1473 | 1545 | ) |
| 1474 | 1546 | ); |
| 1547 | + } |
|
| 1475 | 1548 | |
| 1476 | 1549 | $boards[$row['id_parent']]['tree']['children'][$row['id_board']] = array( |
| 1477 | 1550 | 'node' => &$boards[$row['id_board']], |
@@ -1505,8 +1578,9 @@ discard block |
||
| 1505 | 1578 | */ |
| 1506 | 1579 | function recursiveBoards(&$_boardList, &$_tree) |
| 1507 | 1580 | { |
| 1508 | - if (empty($_tree['children'])) |
|
| 1509 | - return; |
|
| 1581 | + if (empty($_tree['children'])) { |
|
| 1582 | + return; |
|
| 1583 | + } |
|
| 1510 | 1584 | |
| 1511 | 1585 | foreach ($_tree['children'] as $id => $node) |
| 1512 | 1586 | { |
@@ -1525,11 +1599,13 @@ discard block |
||
| 1525 | 1599 | { |
| 1526 | 1600 | global $boards; |
| 1527 | 1601 | |
| 1528 | - if (empty($boards[$child]['parent'])) |
|
| 1529 | - return false; |
|
| 1602 | + if (empty($boards[$child]['parent'])) { |
|
| 1603 | + return false; |
|
| 1604 | + } |
|
| 1530 | 1605 | |
| 1531 | - if ($boards[$child]['parent'] == $parent) |
|
| 1532 | - return true; |
|
| 1606 | + if ($boards[$child]['parent'] == $parent) { |
|
| 1607 | + return true; |
|
| 1608 | + } |
|
| 1533 | 1609 | |
| 1534 | 1610 | return isChildOf($boards[$child]['parent'], $parent); |
| 1535 | 1611 | } |
@@ -658,7 +658,7 @@ discard block |
||
| 658 | 658 | // Do permission sync |
| 659 | 659 | if (!empty($boardUpdateParameters['deny_groups'])) |
| 660 | 660 | $insert = array(); |
| 661 | - foreach($boardOptions['deny_groups'] as $value) |
|
| 661 | + foreach ($boardOptions['deny_groups'] as $value) |
|
| 662 | 662 | $insert[] = array($value, $board_id, 1); |
| 663 | 663 | $smcFunc['db_query']('', ' |
| 664 | 664 | DELETE FROM {db_prefix}board_permissions_view |
@@ -671,12 +671,12 @@ discard block |
||
| 671 | 671 | '{db_prefix}board_permissions_view', |
| 672 | 672 | array('id_group' => 'int', 'id_board' => 'int', 'deny' => 'int'), |
| 673 | 673 | $insert, |
| 674 | - array('id_group','id_board','deny') |
|
| 674 | + array('id_group', 'id_board', 'deny') |
|
| 675 | 675 | ); |
| 676 | 676 | if (!empty($boardUpdateParameters['member_groups'])) |
| 677 | 677 | { |
| 678 | 678 | $insert = array(); |
| 679 | - foreach($boardOptions['access_groups'] as $value) |
|
| 679 | + foreach ($boardOptions['access_groups'] as $value) |
|
| 680 | 680 | $insert[] = array($value, $board_id, 0); |
| 681 | 681 | $smcFunc['db_query']('', ' |
| 682 | 682 | DELETE FROM {db_prefix}board_permissions_view |
@@ -689,7 +689,7 @@ discard block |
||
| 689 | 689 | '{db_prefix}board_permissions_view', |
| 690 | 690 | array('id_group' => 'int', 'id_board' => 'int', 'deny' => 'int'), |
| 691 | 691 | $insert, |
| 692 | - array('id_group','id_board','deny') |
|
| 692 | + array('id_group', 'id_board', 'deny') |
|
| 693 | 693 | ); |
| 694 | 694 | } |
| 695 | 695 | |
@@ -896,14 +896,14 @@ discard block |
||
| 896 | 896 | |
| 897 | 897 | $insert = array(); |
| 898 | 898 | |
| 899 | - foreach(explode(',', $default_memgrps) as $value) |
|
| 899 | + foreach (explode(',', $default_memgrps) as $value) |
|
| 900 | 900 | $insert[] = array($value, $board_id, 0); |
| 901 | 901 | |
| 902 | 902 | $smcFunc['db_insert']('', |
| 903 | 903 | '{db_prefix}board_permissions_view', |
| 904 | 904 | array('id_group' => 'int', 'id_board' => 'int', 'deny' => 'int'), |
| 905 | 905 | $insert, |
| 906 | - array('id_group','id_board','deny'), |
|
| 906 | + array('id_group', 'id_board', 'deny'), |
|
| 907 | 907 | 1 |
| 908 | 908 | ); |
| 909 | 909 | |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 4 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
| 122 | 123 | $smcFunc['db_free_result']($result); |
| 123 | 124 | |
| 124 | 125 | // Add this to the number of unapproved members |
| 125 | - if (!empty($changes['unapprovedMembers'])) |
|
| 126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
| 127 | - else |
|
| 128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
| 126 | + if (!empty($changes['unapprovedMembers'])) { |
|
| 127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
| 128 | + } else { |
|
| 129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
| 130 | + } |
|
| 129 | 131 | } |
| 130 | 132 | } |
| 131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
| 133 | 135 | break; |
| 134 | 136 | |
| 135 | 137 | case 'message': |
| 136 | - if ($parameter1 === true && $parameter2 !== null) |
|
| 137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
| 138 | - else |
|
| 138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
| 139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
| 140 | + } else |
|
| 139 | 141 | { |
| 140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
| 141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
| 175 | 177 | $parameter2 = text2words($parameter2); |
| 176 | 178 | |
| 177 | 179 | $inserts = array(); |
| 178 | - foreach ($parameter2 as $word) |
|
| 179 | - $inserts[] = array($word, $parameter1); |
|
| 180 | + foreach ($parameter2 as $word) { |
|
| 181 | + $inserts[] = array($word, $parameter1); |
|
| 182 | + } |
|
| 180 | 183 | |
| 181 | - if (!empty($inserts)) |
|
| 182 | - $smcFunc['db_insert']('ignore', |
|
| 184 | + if (!empty($inserts)) { |
|
| 185 | + $smcFunc['db_insert']('ignore', |
|
| 183 | 186 | '{db_prefix}log_search_subjects', |
| 184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
| 185 | 188 | $inserts, |
| 186 | 189 | array('word', 'id_topic') |
| 187 | 190 | ); |
| 191 | + } |
|
| 188 | 192 | } |
| 189 | 193 | break; |
| 190 | 194 | |
| 191 | 195 | case 'topic': |
| 192 | - if ($parameter1 === true) |
|
| 193 | - updateSettings(array('totalTopics' => true), true); |
|
| 194 | - else |
|
| 196 | + if ($parameter1 === true) { |
|
| 197 | + updateSettings(array('totalTopics' => true), true); |
|
| 198 | + } else |
|
| 195 | 199 | { |
| 196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
| 197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
| 212 | 216 | |
| 213 | 217 | case 'postgroups': |
| 214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
| 215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
| 216 | - return; |
|
| 219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
| 220 | + return; |
|
| 221 | + } |
|
| 217 | 222 | |
| 218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
| 219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
| 228 | 233 | ) |
| 229 | 234 | ); |
| 230 | 235 | $postgroups = array(); |
| 231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
| 236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
| 238 | + } |
|
| 233 | 239 | $smcFunc['db_free_result']($request); |
| 234 | 240 | |
| 235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
| 239 | 245 | } |
| 240 | 246 | |
| 241 | 247 | // Oh great, they've screwed their post groups. |
| 242 | - if (empty($postgroups)) |
|
| 243 | - return; |
|
| 248 | + if (empty($postgroups)) { |
|
| 249 | + return; |
|
| 250 | + } |
|
| 244 | 251 | |
| 245 | 252 | // Set all membergroups from most posts to least posts. |
| 246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
| 298 | 305 | { |
| 299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
| 300 | 307 | $parameters['members'] = $members; |
| 301 | - } |
|
| 302 | - elseif ($members === null) |
|
| 303 | - $condition = '1=1'; |
|
| 304 | - else |
|
| 308 | + } elseif ($members === null) { |
|
| 309 | + $condition = '1=1'; |
|
| 310 | + } else |
|
| 305 | 311 | { |
| 306 | 312 | $condition = 'id_member = {int:member}'; |
| 307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
| 341 | 347 | if (count($vars_to_integrate) != 0) |
| 342 | 348 | { |
| 343 | 349 | // Fetch a list of member_names if necessary |
| 344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
| 345 | - $member_names = array($user_info['username']); |
|
| 346 | - else |
|
| 350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
| 351 | + $member_names = array($user_info['username']); |
|
| 352 | + } else |
|
| 347 | 353 | { |
| 348 | 354 | $member_names = array(); |
| 349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
| 352 | 358 | WHERE ' . $condition, |
| 353 | 359 | $parameters |
| 354 | 360 | ); |
| 355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 356 | - $member_names[] = $row['member_name']; |
|
| 361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 362 | + $member_names[] = $row['member_name']; |
|
| 363 | + } |
|
| 357 | 364 | $smcFunc['db_free_result']($request); |
| 358 | 365 | } |
| 359 | 366 | |
| 360 | - if (!empty($member_names)) |
|
| 361 | - foreach ($vars_to_integrate as $var) |
|
| 367 | + if (!empty($member_names)) { |
|
| 368 | + foreach ($vars_to_integrate as $var) |
|
| 362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
| 370 | + } |
|
| 363 | 371 | } |
| 364 | 372 | } |
| 365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
| 367 | 375 | foreach ($data as $var => $val) |
| 368 | 376 | { |
| 369 | 377 | $type = 'string'; |
| 370 | - if (in_array($var, $knownInts)) |
|
| 371 | - $type = 'int'; |
|
| 372 | - elseif (in_array($var, $knownFloats)) |
|
| 373 | - $type = 'float'; |
|
| 374 | - elseif ($var == 'birthdate') |
|
| 375 | - $type = 'date'; |
|
| 376 | - elseif ($var == 'member_ip') |
|
| 377 | - $type = 'inet'; |
|
| 378 | - elseif ($var == 'member_ip2') |
|
| 379 | - $type = 'inet'; |
|
| 378 | + if (in_array($var, $knownInts)) { |
|
| 379 | + $type = 'int'; |
|
| 380 | + } elseif (in_array($var, $knownFloats)) { |
|
| 381 | + $type = 'float'; |
|
| 382 | + } elseif ($var == 'birthdate') { |
|
| 383 | + $type = 'date'; |
|
| 384 | + } elseif ($var == 'member_ip') { |
|
| 385 | + $type = 'inet'; |
|
| 386 | + } elseif ($var == 'member_ip2') { |
|
| 387 | + $type = 'inet'; |
|
| 388 | + } |
|
| 380 | 389 | |
| 381 | 390 | // Doing an increment? |
| 382 | 391 | if ($var == 'alerts' && ($val === '+' || $val === '-')) |
@@ -385,18 +394,17 @@ discard block |
||
| 385 | 394 | if (is_array($members)) |
| 386 | 395 | { |
| 387 | 396 | $val = 'CASE '; |
| 388 | - foreach ($members as $k => $v) |
|
| 389 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
| 397 | + foreach ($members as $k => $v) { |
|
| 398 | + $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
| 399 | + } |
|
| 390 | 400 | $val = $val . ' END'; |
| 391 | 401 | $type = 'raw'; |
| 392 | - } |
|
| 393 | - else |
|
| 402 | + } else |
|
| 394 | 403 | { |
| 395 | 404 | $blub = fetch_alerts($members, false, 0, array(), false); |
| 396 | 405 | $val = count($blub); |
| 397 | 406 | } |
| 398 | - } |
|
| 399 | - else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
| 407 | + } else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
| 400 | 408 | { |
| 401 | 409 | $val = $var . ' ' . $val . ' 1'; |
| 402 | 410 | $type = 'raw'; |
@@ -407,8 +415,9 @@ discard block |
||
| 407 | 415 | { |
| 408 | 416 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
| 409 | 417 | { |
| 410 | - if ($match[1] != '+ ') |
|
| 411 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
| 418 | + if ($match[1] != '+ ') { |
|
| 419 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
| 420 | + } |
|
| 412 | 421 | $type = 'raw'; |
| 413 | 422 | } |
| 414 | 423 | } |
@@ -429,8 +438,9 @@ discard block |
||
| 429 | 438 | // Clear any caching? |
| 430 | 439 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
| 431 | 440 | { |
| 432 | - if (!is_array($members)) |
|
| 433 | - $members = array($members); |
|
| 441 | + if (!is_array($members)) { |
|
| 442 | + $members = array($members); |
|
| 443 | + } |
|
| 434 | 444 | |
| 435 | 445 | foreach ($members as $member) |
| 436 | 446 | { |
@@ -463,29 +473,32 @@ discard block |
||
| 463 | 473 | { |
| 464 | 474 | global $modSettings, $smcFunc; |
| 465 | 475 | |
| 466 | - if (empty($changeArray) || !is_array($changeArray)) |
|
| 467 | - return; |
|
| 476 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
| 477 | + return; |
|
| 478 | + } |
|
| 468 | 479 | |
| 469 | 480 | $toRemove = array(); |
| 470 | 481 | |
| 471 | 482 | // Go check if there is any setting to be removed. |
| 472 | - foreach ($changeArray as $k => $v) |
|
| 473 | - if ($v === null) |
|
| 483 | + foreach ($changeArray as $k => $v) { |
|
| 484 | + if ($v === null) |
|
| 474 | 485 | { |
| 475 | 486 | // Found some, remove them from the original array and add them to ours. |
| 476 | 487 | unset($changeArray[$k]); |
| 488 | + } |
|
| 477 | 489 | $toRemove[] = $k; |
| 478 | 490 | } |
| 479 | 491 | |
| 480 | 492 | // Proceed with the deletion. |
| 481 | - if (!empty($toRemove)) |
|
| 482 | - $smcFunc['db_query']('', ' |
|
| 493 | + if (!empty($toRemove)) { |
|
| 494 | + $smcFunc['db_query']('', ' |
|
| 483 | 495 | DELETE FROM {db_prefix}settings |
| 484 | 496 | WHERE variable IN ({array_string:remove})', |
| 485 | 497 | array( |
| 486 | 498 | 'remove' => $toRemove, |
| 487 | 499 | ) |
| 488 | 500 | ); |
| 501 | + } |
|
| 489 | 502 | |
| 490 | 503 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
| 491 | 504 | if ($update) |
@@ -514,19 +527,22 @@ discard block |
||
| 514 | 527 | foreach ($changeArray as $variable => $value) |
| 515 | 528 | { |
| 516 | 529 | // Don't bother if it's already like that ;). |
| 517 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
| 518 | - continue; |
|
| 530 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
| 531 | + continue; |
|
| 532 | + } |
|
| 519 | 533 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
| 520 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
| 521 | - continue; |
|
| 534 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
| 535 | + continue; |
|
| 536 | + } |
|
| 522 | 537 | |
| 523 | 538 | $replaceArray[] = array($variable, $value); |
| 524 | 539 | |
| 525 | 540 | $modSettings[$variable] = $value; |
| 526 | 541 | } |
| 527 | 542 | |
| 528 | - if (empty($replaceArray)) |
|
| 529 | - return; |
|
| 543 | + if (empty($replaceArray)) { |
|
| 544 | + return; |
|
| 545 | + } |
|
| 530 | 546 | |
| 531 | 547 | $smcFunc['db_insert']('replace', |
| 532 | 548 | '{db_prefix}settings', |
@@ -572,14 +588,17 @@ discard block |
||
| 572 | 588 | $start_invalid = $start < 0; |
| 573 | 589 | |
| 574 | 590 | // Make sure $start is a proper variable - not less than 0. |
| 575 | - if ($start_invalid) |
|
| 576 | - $start = 0; |
|
| 591 | + if ($start_invalid) { |
|
| 592 | + $start = 0; |
|
| 593 | + } |
|
| 577 | 594 | // Not greater than the upper bound. |
| 578 | - elseif ($start >= $max_value) |
|
| 579 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
| 595 | + elseif ($start >= $max_value) { |
|
| 596 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
| 597 | + } |
|
| 580 | 598 | // And it has to be a multiple of $num_per_page! |
| 581 | - else |
|
| 582 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
| 599 | + else { |
|
| 600 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
| 601 | + } |
|
| 583 | 602 | |
| 584 | 603 | $context['current_page'] = $start / $num_per_page; |
| 585 | 604 | |
@@ -609,77 +628,87 @@ discard block |
||
| 609 | 628 | |
| 610 | 629 | // Show all the pages. |
| 611 | 630 | $display_page = 1; |
| 612 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
| 613 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
| 631 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
| 632 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
| 633 | + } |
|
| 614 | 634 | |
| 615 | 635 | // Show the right arrow. |
| 616 | 636 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
| 617 | - if ($start != $counter - $max_value && !$start_invalid) |
|
| 618 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
| 619 | - } |
|
| 620 | - else |
|
| 637 | + if ($start != $counter - $max_value && !$start_invalid) { |
|
| 638 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
| 639 | + } |
|
| 640 | + } else |
|
| 621 | 641 | { |
| 622 | 642 | // If they didn't enter an odd value, pretend they did. |
| 623 | 643 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
| 624 | 644 | |
| 625 | 645 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
| 626 | - if (!empty($start) && $show_prevnext) |
|
| 627 | - $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
| 628 | - else |
|
| 629 | - $pageindex .= ''; |
|
| 646 | + if (!empty($start) && $show_prevnext) { |
|
| 647 | + $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
| 648 | + } else { |
|
| 649 | + $pageindex .= ''; |
|
| 650 | + } |
|
| 630 | 651 | |
| 631 | 652 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
| 632 | - if ($start > $num_per_page * $PageContiguous) |
|
| 633 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
| 653 | + if ($start > $num_per_page * $PageContiguous) { |
|
| 654 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
| 655 | + } |
|
| 634 | 656 | |
| 635 | 657 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
| 636 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
| 637 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 658 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
| 659 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 638 | 660 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
| 639 | 661 | '{FIRST_PAGE}' => $num_per_page, |
| 640 | 662 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
| 641 | 663 | '{PER_PAGE}' => $num_per_page, |
| 642 | 664 | )); |
| 665 | + } |
|
| 643 | 666 | |
| 644 | 667 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
| 645 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
| 646 | - if ($start >= $num_per_page * $nCont) |
|
| 668 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
| 669 | + if ($start >= $num_per_page * $nCont) |
|
| 647 | 670 | { |
| 648 | 671 | $tmpStart = $start - $num_per_page * $nCont; |
| 672 | + } |
|
| 649 | 673 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
| 650 | 674 | } |
| 651 | 675 | |
| 652 | 676 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
| 653 | - if (!$start_invalid) |
|
| 654 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
| 655 | - else |
|
| 656 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
| 677 | + if (!$start_invalid) { |
|
| 678 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
| 679 | + } else { |
|
| 680 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
| 681 | + } |
|
| 657 | 682 | |
| 658 | 683 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
| 659 | 684 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
| 660 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
| 661 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
| 685 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
| 686 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
| 662 | 687 | { |
| 663 | 688 | $tmpStart = $start + $num_per_page * $nCont; |
| 689 | + } |
|
| 664 | 690 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
| 665 | 691 | } |
| 666 | 692 | |
| 667 | 693 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
| 668 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
| 669 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 694 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
| 695 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 670 | 696 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
| 671 | 697 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
| 672 | 698 | '{LAST_PAGE}' => $tmpMaxPages, |
| 673 | 699 | '{PER_PAGE}' => $num_per_page, |
| 674 | 700 | )); |
| 701 | + } |
|
| 675 | 702 | |
| 676 | 703 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
| 677 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
| 678 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
| 704 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
| 705 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
| 706 | + } |
|
| 679 | 707 | |
| 680 | 708 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
| 681 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
| 682 | - $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
| 709 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
| 710 | + $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
| 711 | + } |
|
| 683 | 712 | } |
| 684 | 713 | $pageindex .= $settings['page_index']['extra_after']; |
| 685 | 714 | |
@@ -705,8 +734,9 @@ discard block |
||
| 705 | 734 | if ($decimal_separator === null) |
| 706 | 735 | { |
| 707 | 736 | // Not set for whatever reason? |
| 708 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
| 709 | - return $number; |
|
| 737 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
| 738 | + return $number; |
|
| 739 | + } |
|
| 710 | 740 | |
| 711 | 741 | // Cache these each load... |
| 712 | 742 | $thousands_separator = $matches[1]; |
@@ -747,17 +777,20 @@ discard block |
||
| 747 | 777 | $user_info['time_format'] = !empty($user_info['time_format']) ? $user_info['time_format'] : (!empty($modSettings['time_format']) ? $modSettings['time_format'] : '%F %H:%M'); |
| 748 | 778 | |
| 749 | 779 | // Offset the time. |
| 750 | - if (!$offset_type) |
|
| 751 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
| 780 | + if (!$offset_type) { |
|
| 781 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
| 782 | + } |
|
| 752 | 783 | // Just the forum offset? |
| 753 | - elseif ($offset_type == 'forum') |
|
| 754 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
| 755 | - else |
|
| 756 | - $time = $log_time; |
|
| 784 | + elseif ($offset_type == 'forum') { |
|
| 785 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
| 786 | + } else { |
|
| 787 | + $time = $log_time; |
|
| 788 | + } |
|
| 757 | 789 | |
| 758 | 790 | // We can't have a negative date (on Windows, at least.) |
| 759 | - if ($log_time < 0) |
|
| 760 | - $log_time = 0; |
|
| 791 | + if ($log_time < 0) { |
|
| 792 | + $log_time = 0; |
|
| 793 | + } |
|
| 761 | 794 | |
| 762 | 795 | // Today and Yesterday? |
| 763 | 796 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -774,24 +807,27 @@ discard block |
||
| 774 | 807 | { |
| 775 | 808 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
| 776 | 809 | $today_fmt = $h . ':%M' . $s . ' %p'; |
| 810 | + } else { |
|
| 811 | + $today_fmt = '%H:%M' . $s; |
|
| 777 | 812 | } |
| 778 | - else |
|
| 779 | - $today_fmt = '%H:%M' . $s; |
|
| 780 | 813 | |
| 781 | 814 | // Same day of the year, same year.... Today! |
| 782 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
| 783 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 815 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
| 816 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 817 | + } |
|
| 784 | 818 | |
| 785 | 819 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
| 786 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
| 787 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 820 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
| 821 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 822 | + } |
|
| 788 | 823 | } |
| 789 | 824 | |
| 790 | 825 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
| 791 | 826 | |
| 792 | 827 | // Use the cached formats if available |
| 793 | - if (is_null($finalizedFormats)) |
|
| 794 | - $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
| 828 | + if (is_null($finalizedFormats)) { |
|
| 829 | + $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
| 830 | + } |
|
| 795 | 831 | |
| 796 | 832 | // Make a supported version for this format if we don't already have one |
| 797 | 833 | if (empty($finalizedFormats[$str])) |
@@ -820,8 +856,9 @@ discard block |
||
| 820 | 856 | ); |
| 821 | 857 | |
| 822 | 858 | // No need to do this part again if we already did it once |
| 823 | - if (is_null($unsupportedFormats)) |
|
| 824 | - $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
| 859 | + if (is_null($unsupportedFormats)) { |
|
| 860 | + $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
| 861 | + } |
|
| 825 | 862 | if (empty($unsupportedFormats)) |
| 826 | 863 | { |
| 827 | 864 | foreach($strftimeFormatSubstitutions as $format => $substitution) |
@@ -837,20 +874,23 @@ discard block |
||
| 837 | 874 | |
| 838 | 875 | // Windows will return false for unsupported formats |
| 839 | 876 | // Other operating systems return the format string as a literal |
| 840 | - if ($value === false || $value === $format) |
|
| 841 | - $unsupportedFormats[] = $format; |
|
| 877 | + if ($value === false || $value === $format) { |
|
| 878 | + $unsupportedFormats[] = $format; |
|
| 879 | + } |
|
| 842 | 880 | } |
| 843 | 881 | cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400); |
| 844 | 882 | } |
| 845 | 883 | |
| 846 | 884 | // Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q' |
| 847 | - if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') |
|
| 848 | - $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
| 885 | + if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') { |
|
| 886 | + $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
| 887 | + } |
|
| 849 | 888 | |
| 850 | 889 | // Substitute unsupported formats with supported ones |
| 851 | - if (!empty($unsupportedFormats)) |
|
| 852 | - while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
| 890 | + if (!empty($unsupportedFormats)) { |
|
| 891 | + while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
| 853 | 892 | $timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat); |
| 893 | + } |
|
| 854 | 894 | |
| 855 | 895 | // Remember this so we don't need to do it again |
| 856 | 896 | $finalizedFormats[$str] = $timeformat; |
@@ -859,33 +899,39 @@ discard block |
||
| 859 | 899 | |
| 860 | 900 | $str = $finalizedFormats[$str]; |
| 861 | 901 | |
| 862 | - if (!isset($locale_cache)) |
|
| 863 | - $locale_cache = setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : ''); |
|
| 902 | + if (!isset($locale_cache)) { |
|
| 903 | + $locale_cache = setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : ''); |
|
| 904 | + } |
|
| 864 | 905 | |
| 865 | 906 | if ($locale_cache !== false) |
| 866 | 907 | { |
| 867 | 908 | // Check if another process changed the locale |
| 868 | - if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) |
|
| 869 | - setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : ''); |
|
| 909 | + if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) { |
|
| 910 | + setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : ''); |
|
| 911 | + } |
|
| 870 | 912 | |
| 871 | - if (!isset($non_twelve_hour)) |
|
| 872 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
| 873 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
| 874 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 913 | + if (!isset($non_twelve_hour)) { |
|
| 914 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
| 915 | + } |
|
| 916 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
| 917 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 918 | + } |
|
| 875 | 919 | |
| 876 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
| 877 | - if (strpos($str, $token) !== false) |
|
| 920 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
| 921 | + if (strpos($str, $token) !== false) |
|
| 878 | 922 | $str = str_replace($token, strftime($token, $time), $str); |
| 879 | - } |
|
| 880 | - else |
|
| 923 | + } |
|
| 924 | + } else |
|
| 881 | 925 | { |
| 882 | 926 | // Do-it-yourself time localization. Fun. |
| 883 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
| 884 | - if (strpos($str, $token) !== false) |
|
| 927 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
| 928 | + if (strpos($str, $token) !== false) |
|
| 885 | 929 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
| 930 | + } |
|
| 886 | 931 | |
| 887 | - if (strpos($str, '%p') !== false) |
|
| 888 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 932 | + if (strpos($str, '%p') !== false) { |
|
| 933 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 934 | + } |
|
| 889 | 935 | } |
| 890 | 936 | |
| 891 | 937 | // Format the time and then restore any literal percent characters |
@@ -908,16 +954,19 @@ discard block |
||
| 908 | 954 | static $translation = array(); |
| 909 | 955 | |
| 910 | 956 | // Determine the character set... Default to UTF-8 |
| 911 | - if (empty($context['character_set'])) |
|
| 912 | - $charset = 'UTF-8'; |
|
| 957 | + if (empty($context['character_set'])) { |
|
| 958 | + $charset = 'UTF-8'; |
|
| 959 | + } |
|
| 913 | 960 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
| 914 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
| 915 | - $charset = 'ISO-8859-1'; |
|
| 916 | - else |
|
| 917 | - $charset = $context['character_set']; |
|
| 961 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
| 962 | + $charset = 'ISO-8859-1'; |
|
| 963 | + } else { |
|
| 964 | + $charset = $context['character_set']; |
|
| 965 | + } |
|
| 918 | 966 | |
| 919 | - if (empty($translation)) |
|
| 920 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
| 967 | + if (empty($translation)) { |
|
| 968 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
| 969 | + } |
|
| 921 | 970 | |
| 922 | 971 | return strtr($string, $translation); |
| 923 | 972 | } |
@@ -939,8 +988,9 @@ discard block |
||
| 939 | 988 | global $smcFunc; |
| 940 | 989 | |
| 941 | 990 | // It was already short enough! |
| 942 | - if ($smcFunc['strlen']($subject) <= $len) |
|
| 943 | - return $subject; |
|
| 991 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
| 992 | + return $subject; |
|
| 993 | + } |
|
| 944 | 994 | |
| 945 | 995 | // Shorten it by the length it was too long, and strip off junk from the end. |
| 946 | 996 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -959,10 +1009,11 @@ discard block |
||
| 959 | 1009 | { |
| 960 | 1010 | global $user_info, $modSettings; |
| 961 | 1011 | |
| 962 | - if ($timestamp === null) |
|
| 963 | - $timestamp = time(); |
|
| 964 | - elseif ($timestamp == 0) |
|
| 965 | - return 0; |
|
| 1012 | + if ($timestamp === null) { |
|
| 1013 | + $timestamp = time(); |
|
| 1014 | + } elseif ($timestamp == 0) { |
|
| 1015 | + return 0; |
|
| 1016 | + } |
|
| 966 | 1017 | |
| 967 | 1018 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
| 968 | 1019 | } |
@@ -991,8 +1042,9 @@ discard block |
||
| 991 | 1042 | $array[$i] = $array[$j]; |
| 992 | 1043 | $array[$j] = $temp; |
| 993 | 1044 | |
| 994 | - for ($i = 1; $p[$i] == 0; $i++) |
|
| 995 | - $p[$i] = 1; |
|
| 1045 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
| 1046 | + $p[$i] = 1; |
|
| 1047 | + } |
|
| 996 | 1048 | |
| 997 | 1049 | $orders[] = $array; |
| 998 | 1050 | } |
@@ -1024,12 +1076,14 @@ discard block |
||
| 1024 | 1076 | static $disabled; |
| 1025 | 1077 | |
| 1026 | 1078 | // Don't waste cycles |
| 1027 | - if ($message === '') |
|
| 1028 | - return ''; |
|
| 1079 | + if ($message === '') { |
|
| 1080 | + return ''; |
|
| 1081 | + } |
|
| 1029 | 1082 | |
| 1030 | 1083 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
| 1031 | - if (!isset($context['utf8'])) |
|
| 1032 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
| 1084 | + if (!isset($context['utf8'])) { |
|
| 1085 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
| 1086 | + } |
|
| 1033 | 1087 | |
| 1034 | 1088 | // Clean up any cut/paste issues we may have |
| 1035 | 1089 | $message = sanitizeMSCutPaste($message); |
@@ -1041,13 +1095,15 @@ discard block |
||
| 1041 | 1095 | return $message; |
| 1042 | 1096 | } |
| 1043 | 1097 | |
| 1044 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
| 1045 | - $smileys = (bool) $smileys; |
|
| 1098 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
| 1099 | + $smileys = (bool) $smileys; |
|
| 1100 | + } |
|
| 1046 | 1101 | |
| 1047 | 1102 | if (empty($modSettings['enableBBC']) && $message !== false) |
| 1048 | 1103 | { |
| 1049 | - if ($smileys === true) |
|
| 1050 | - parsesmileys($message); |
|
| 1104 | + if ($smileys === true) { |
|
| 1105 | + parsesmileys($message); |
|
| 1106 | + } |
|
| 1051 | 1107 | |
| 1052 | 1108 | return $message; |
| 1053 | 1109 | } |
@@ -1060,8 +1116,9 @@ discard block |
||
| 1060 | 1116 | } |
| 1061 | 1117 | |
| 1062 | 1118 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
| 1063 | - if (!empty($modSettings['autoLinkUrls'])) |
|
| 1064 | - set_tld_regex(); |
|
| 1119 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
| 1120 | + set_tld_regex(); |
|
| 1121 | + } |
|
| 1065 | 1122 | |
| 1066 | 1123 | // Allow mods access before entering the main parse_bbc loop |
| 1067 | 1124 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1075,12 +1132,14 @@ discard block |
||
| 1075 | 1132 | |
| 1076 | 1133 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
| 1077 | 1134 | |
| 1078 | - foreach ($temp as $tag) |
|
| 1079 | - $disabled[trim($tag)] = true; |
|
| 1135 | + foreach ($temp as $tag) { |
|
| 1136 | + $disabled[trim($tag)] = true; |
|
| 1137 | + } |
|
| 1080 | 1138 | } |
| 1081 | 1139 | |
| 1082 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
| 1083 | - $disabled['flash'] = true; |
|
| 1140 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
| 1141 | + $disabled['flash'] = true; |
|
| 1142 | + } |
|
| 1084 | 1143 | |
| 1085 | 1144 | /* The following bbc are formatted as an array, with keys as follows: |
| 1086 | 1145 | |
@@ -1201,8 +1260,9 @@ discard block |
||
| 1201 | 1260 | $returnContext = ''; |
| 1202 | 1261 | |
| 1203 | 1262 | // BBC or the entire attachments feature is disabled |
| 1204 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
| 1205 | - return $data; |
|
| 1263 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
| 1264 | + return $data; |
|
| 1265 | + } |
|
| 1206 | 1266 | |
| 1207 | 1267 | // Save the attach ID. |
| 1208 | 1268 | $attachID = $data; |
@@ -1213,8 +1273,9 @@ discard block |
||
| 1213 | 1273 | $currentAttachment = parseAttachBBC($attachID); |
| 1214 | 1274 | |
| 1215 | 1275 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
| 1216 | - if (is_string($currentAttachment)) |
|
| 1217 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
| 1276 | + if (is_string($currentAttachment)) { |
|
| 1277 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
| 1278 | + } |
|
| 1218 | 1279 | |
| 1219 | 1280 | if (!empty($currentAttachment['is_image'])) |
| 1220 | 1281 | { |
@@ -1230,15 +1291,17 @@ discard block |
||
| 1230 | 1291 | $height = ' height="' . $currentAttachment['height'] . '"'; |
| 1231 | 1292 | } |
| 1232 | 1293 | |
| 1233 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
| 1234 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
| 1235 | - else |
|
| 1236 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
| 1294 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
| 1295 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
| 1296 | + } else { |
|
| 1297 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
| 1298 | + } |
|
| 1237 | 1299 | } |
| 1238 | 1300 | |
| 1239 | 1301 | // No image. Show a link. |
| 1240 | - else |
|
| 1241 | - $returnContext .= $currentAttachment['link']; |
|
| 1302 | + else { |
|
| 1303 | + $returnContext .= $currentAttachment['link']; |
|
| 1304 | + } |
|
| 1242 | 1305 | |
| 1243 | 1306 | // Gotta append what we just did. |
| 1244 | 1307 | $data = $returnContext; |
@@ -1269,8 +1332,9 @@ discard block |
||
| 1269 | 1332 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
| 1270 | 1333 | { |
| 1271 | 1334 | // Do PHP code coloring? |
| 1272 | - if ($php_parts[$php_i] != '<?php') |
|
| 1273 | - continue; |
|
| 1335 | + if ($php_parts[$php_i] != '<?php') { |
|
| 1336 | + continue; |
|
| 1337 | + } |
|
| 1274 | 1338 | |
| 1275 | 1339 | $php_string = ''; |
| 1276 | 1340 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1286,8 +1350,9 @@ discard block |
||
| 1286 | 1350 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
| 1287 | 1351 | |
| 1288 | 1352 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
| 1289 | - if ($context['browser']['is_opera']) |
|
| 1290 | - $data .= ' '; |
|
| 1353 | + if ($context['browser']['is_opera']) { |
|
| 1354 | + $data .= ' '; |
|
| 1355 | + } |
|
| 1291 | 1356 | } |
| 1292 | 1357 | }, |
| 1293 | 1358 | 'block_level' => true, |
@@ -1306,8 +1371,9 @@ discard block |
||
| 1306 | 1371 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
| 1307 | 1372 | { |
| 1308 | 1373 | // Do PHP code coloring? |
| 1309 | - if ($php_parts[$php_i] != '<?php') |
|
| 1310 | - continue; |
|
| 1374 | + if ($php_parts[$php_i] != '<?php') { |
|
| 1375 | + continue; |
|
| 1376 | + } |
|
| 1311 | 1377 | |
| 1312 | 1378 | $php_string = ''; |
| 1313 | 1379 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1323,8 +1389,9 @@ discard block |
||
| 1323 | 1389 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
| 1324 | 1390 | |
| 1325 | 1391 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
| 1326 | - if ($context['browser']['is_opera']) |
|
| 1327 | - $data[0] .= ' '; |
|
| 1392 | + if ($context['browser']['is_opera']) { |
|
| 1393 | + $data[0] .= ' '; |
|
| 1394 | + } |
|
| 1328 | 1395 | } |
| 1329 | 1396 | }, |
| 1330 | 1397 | 'block_level' => true, |
@@ -1362,11 +1429,13 @@ discard block |
||
| 1362 | 1429 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
| 1363 | 1430 | 'validate' => function (&$tag, &$data, $disabled) |
| 1364 | 1431 | { |
| 1365 | - if (isset($disabled['url'])) |
|
| 1366 | - $tag['content'] = '$1'; |
|
| 1432 | + if (isset($disabled['url'])) { |
|
| 1433 | + $tag['content'] = '$1'; |
|
| 1434 | + } |
|
| 1367 | 1435 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
| 1368 | - if (empty($scheme)) |
|
| 1369 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
| 1436 | + if (empty($scheme)) { |
|
| 1437 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
| 1438 | + } |
|
| 1370 | 1439 | }, |
| 1371 | 1440 | 'disabled_content' => '<a href="$1" target="_blank" rel="noopener">$1</a>', |
| 1372 | 1441 | ), |
@@ -1380,10 +1449,11 @@ discard block |
||
| 1380 | 1449 | { |
| 1381 | 1450 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
| 1382 | 1451 | |
| 1383 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
| 1384 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
| 1385 | - else |
|
| 1386 | - $css = ''; |
|
| 1452 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
| 1453 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
| 1454 | + } else { |
|
| 1455 | + $css = ''; |
|
| 1456 | + } |
|
| 1387 | 1457 | |
| 1388 | 1458 | $data = $class . $css; |
| 1389 | 1459 | }, |
@@ -1433,17 +1503,20 @@ discard block |
||
| 1433 | 1503 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1434 | 1504 | if ($image_proxy_enabled) |
| 1435 | 1505 | { |
| 1436 | - if (!empty($user_info['possibly_robot'])) |
|
| 1437 | - return; |
|
| 1506 | + if (!empty($user_info['possibly_robot'])) { |
|
| 1507 | + return; |
|
| 1508 | + } |
|
| 1438 | 1509 | |
| 1439 | - if (empty($scheme)) |
|
| 1440 | - $data = 'http://' . ltrim($data, ':/'); |
|
| 1510 | + if (empty($scheme)) { |
|
| 1511 | + $data = 'http://' . ltrim($data, ':/'); |
|
| 1512 | + } |
|
| 1441 | 1513 | |
| 1442 | - if ($scheme != 'https') |
|
| 1443 | - $data = get_proxied_url($data); |
|
| 1514 | + if ($scheme != 'https') { |
|
| 1515 | + $data = get_proxied_url($data); |
|
| 1516 | + } |
|
| 1517 | + } elseif (empty($scheme)) { |
|
| 1518 | + $data = '//' . ltrim($data, ':/'); |
|
| 1444 | 1519 | } |
| 1445 | - elseif (empty($scheme)) |
|
| 1446 | - $data = '//' . ltrim($data, ':/'); |
|
| 1447 | 1520 | }, |
| 1448 | 1521 | 'disabled_content' => '($1)', |
| 1449 | 1522 | ), |
@@ -1459,17 +1532,20 @@ discard block |
||
| 1459 | 1532 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1460 | 1533 | if ($image_proxy_enabled) |
| 1461 | 1534 | { |
| 1462 | - if (!empty($user_info['possibly_robot'])) |
|
| 1463 | - return; |
|
| 1535 | + if (!empty($user_info['possibly_robot'])) { |
|
| 1536 | + return; |
|
| 1537 | + } |
|
| 1464 | 1538 | |
| 1465 | - if (empty($scheme)) |
|
| 1466 | - $data = 'http://' . ltrim($data, ':/'); |
|
| 1539 | + if (empty($scheme)) { |
|
| 1540 | + $data = 'http://' . ltrim($data, ':/'); |
|
| 1541 | + } |
|
| 1467 | 1542 | |
| 1468 | - if ($scheme != 'https') |
|
| 1469 | - $data = get_proxied_url($data); |
|
| 1543 | + if ($scheme != 'https') { |
|
| 1544 | + $data = get_proxied_url($data); |
|
| 1545 | + } |
|
| 1546 | + } elseif (empty($scheme)) { |
|
| 1547 | + $data = '//' . ltrim($data, ':/'); |
|
| 1470 | 1548 | } |
| 1471 | - elseif (empty($scheme)) |
|
| 1472 | - $data = '//' . ltrim($data, ':/'); |
|
| 1473 | 1549 | }, |
| 1474 | 1550 | 'disabled_content' => '($1)', |
| 1475 | 1551 | ), |
@@ -1481,8 +1557,9 @@ discard block |
||
| 1481 | 1557 | { |
| 1482 | 1558 | $data = strtr($data, array('<br>' => '')); |
| 1483 | 1559 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1484 | - if (empty($scheme)) |
|
| 1485 | - $data = '//' . ltrim($data, ':/'); |
|
| 1560 | + if (empty($scheme)) { |
|
| 1561 | + $data = '//' . ltrim($data, ':/'); |
|
| 1562 | + } |
|
| 1486 | 1563 | }, |
| 1487 | 1564 | ), |
| 1488 | 1565 | array( |
@@ -1493,13 +1570,14 @@ discard block |
||
| 1493 | 1570 | 'after' => '</a>', |
| 1494 | 1571 | 'validate' => function (&$tag, &$data, $disabled) |
| 1495 | 1572 | { |
| 1496 | - if (substr($data, 0, 1) == '#') |
|
| 1497 | - $data = '#post_' . substr($data, 1); |
|
| 1498 | - else |
|
| 1573 | + if (substr($data, 0, 1) == '#') { |
|
| 1574 | + $data = '#post_' . substr($data, 1); |
|
| 1575 | + } else |
|
| 1499 | 1576 | { |
| 1500 | 1577 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1501 | - if (empty($scheme)) |
|
| 1502 | - $data = '//' . ltrim($data, ':/'); |
|
| 1578 | + if (empty($scheme)) { |
|
| 1579 | + $data = '//' . ltrim($data, ':/'); |
|
| 1580 | + } |
|
| 1503 | 1581 | } |
| 1504 | 1582 | }, |
| 1505 | 1583 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1583,8 +1661,9 @@ discard block |
||
| 1583 | 1661 | { |
| 1584 | 1662 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
| 1585 | 1663 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
| 1586 | - if ($add_begin) |
|
| 1587 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
| 1664 | + if ($add_begin) { |
|
| 1665 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
| 1666 | + } |
|
| 1588 | 1667 | } |
| 1589 | 1668 | }, |
| 1590 | 1669 | 'block_level' => false, |
@@ -1715,10 +1794,11 @@ discard block |
||
| 1715 | 1794 | 'content' => '$1', |
| 1716 | 1795 | 'validate' => function (&$tag, &$data, $disabled) |
| 1717 | 1796 | { |
| 1718 | - if (is_numeric($data)) |
|
| 1719 | - $data = timeformat($data); |
|
| 1720 | - else |
|
| 1721 | - $tag['content'] = '[time]$1[/time]'; |
|
| 1797 | + if (is_numeric($data)) { |
|
| 1798 | + $data = timeformat($data); |
|
| 1799 | + } else { |
|
| 1800 | + $tag['content'] = '[time]$1[/time]'; |
|
| 1801 | + } |
|
| 1722 | 1802 | }, |
| 1723 | 1803 | ), |
| 1724 | 1804 | array( |
@@ -1745,8 +1825,9 @@ discard block |
||
| 1745 | 1825 | { |
| 1746 | 1826 | $data = strtr($data, array('<br>' => '')); |
| 1747 | 1827 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1748 | - if (empty($scheme)) |
|
| 1749 | - $data = '//' . ltrim($data, ':/'); |
|
| 1828 | + if (empty($scheme)) { |
|
| 1829 | + $data = '//' . ltrim($data, ':/'); |
|
| 1830 | + } |
|
| 1750 | 1831 | }, |
| 1751 | 1832 | ), |
| 1752 | 1833 | array( |
@@ -1758,8 +1839,9 @@ discard block |
||
| 1758 | 1839 | 'validate' => function (&$tag, &$data, $disabled) |
| 1759 | 1840 | { |
| 1760 | 1841 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1761 | - if (empty($scheme)) |
|
| 1762 | - $data = '//' . ltrim($data, ':/'); |
|
| 1842 | + if (empty($scheme)) { |
|
| 1843 | + $data = '//' . ltrim($data, ':/'); |
|
| 1844 | + } |
|
| 1763 | 1845 | }, |
| 1764 | 1846 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
| 1765 | 1847 | 'disabled_after' => ' ($1)', |
@@ -1785,8 +1867,9 @@ discard block |
||
| 1785 | 1867 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
| 1786 | 1868 | if ($message === false) |
| 1787 | 1869 | { |
| 1788 | - if (isset($temp_bbc)) |
|
| 1789 | - $bbc_codes = $temp_bbc; |
|
| 1870 | + if (isset($temp_bbc)) { |
|
| 1871 | + $bbc_codes = $temp_bbc; |
|
| 1872 | + } |
|
| 1790 | 1873 | usort($codes, function ($a, $b) { |
| 1791 | 1874 | return strcmp($a['tag'], $b['tag']); |
| 1792 | 1875 | }); |
@@ -1806,8 +1889,9 @@ discard block |
||
| 1806 | 1889 | ); |
| 1807 | 1890 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
| 1808 | 1891 | { |
| 1809 | - foreach ($itemcodes as $c => $dummy) |
|
| 1810 | - $bbc_codes[$c] = array(); |
|
| 1892 | + foreach ($itemcodes as $c => $dummy) { |
|
| 1893 | + $bbc_codes[$c] = array(); |
|
| 1894 | + } |
|
| 1811 | 1895 | } |
| 1812 | 1896 | |
| 1813 | 1897 | // Shhhh! |
@@ -1828,12 +1912,14 @@ discard block |
||
| 1828 | 1912 | foreach ($codes as $code) |
| 1829 | 1913 | { |
| 1830 | 1914 | // Make it easier to process parameters later |
| 1831 | - if (!empty($code['parameters'])) |
|
| 1832 | - ksort($code['parameters'], SORT_STRING); |
|
| 1915 | + if (!empty($code['parameters'])) { |
|
| 1916 | + ksort($code['parameters'], SORT_STRING); |
|
| 1917 | + } |
|
| 1833 | 1918 | |
| 1834 | 1919 | // If we are not doing every tag only do ones we are interested in. |
| 1835 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
| 1836 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
| 1920 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
| 1921 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
| 1922 | + } |
|
| 1837 | 1923 | } |
| 1838 | 1924 | $codes = null; |
| 1839 | 1925 | } |
@@ -1844,8 +1930,9 @@ discard block |
||
| 1844 | 1930 | // It's likely this will change if the message is modified. |
| 1845 | 1931 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
| 1846 | 1932 | |
| 1847 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
| 1848 | - return $temp; |
|
| 1933 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
| 1934 | + return $temp; |
|
| 1935 | + } |
|
| 1849 | 1936 | |
| 1850 | 1937 | $cache_t = microtime(); |
| 1851 | 1938 | } |
@@ -1877,8 +1964,9 @@ discard block |
||
| 1877 | 1964 | $disabled['flash'] = true; |
| 1878 | 1965 | |
| 1879 | 1966 | // @todo Change maybe? |
| 1880 | - if (!isset($_GET['images'])) |
|
| 1881 | - $disabled['img'] = true; |
|
| 1967 | + if (!isset($_GET['images'])) { |
|
| 1968 | + $disabled['img'] = true; |
|
| 1969 | + } |
|
| 1882 | 1970 | |
| 1883 | 1971 | // @todo Interface/setting to add more? |
| 1884 | 1972 | } |
@@ -1889,8 +1977,9 @@ discard block |
||
| 1889 | 1977 | $alltags = array(); |
| 1890 | 1978 | foreach ($bbc_codes as $section) |
| 1891 | 1979 | { |
| 1892 | - foreach ($section as $code) |
|
| 1893 | - $alltags[] = $code['tag']; |
|
| 1980 | + foreach ($section as $code) { |
|
| 1981 | + $alltags[] = $code['tag']; |
|
| 1982 | + } |
|
| 1894 | 1983 | } |
| 1895 | 1984 | $alltags_regex = '\b' . implode("\b|\b", array_unique($alltags)) . '\b'; |
| 1896 | 1985 | |
@@ -1902,8 +1991,9 @@ discard block |
||
| 1902 | 1991 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
| 1903 | 1992 | |
| 1904 | 1993 | // Failsafe. |
| 1905 | - if ($pos === false || $last_pos > $pos) |
|
| 1906 | - $pos = strlen($message) + 1; |
|
| 1994 | + if ($pos === false || $last_pos > $pos) { |
|
| 1995 | + $pos = strlen($message) + 1; |
|
| 1996 | + } |
|
| 1907 | 1997 | |
| 1908 | 1998 | // Can't have a one letter smiley, URL, or email! (sorry.) |
| 1909 | 1999 | if ($last_pos < $pos - 1) |
@@ -1921,8 +2011,9 @@ discard block |
||
| 1921 | 2011 | |
| 1922 | 2012 | // <br> should be empty. |
| 1923 | 2013 | $empty_tags = array('br', 'hr'); |
| 1924 | - foreach ($empty_tags as $tag) |
|
| 1925 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
| 2014 | + foreach ($empty_tags as $tag) { |
|
| 2015 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
| 2016 | + } |
|
| 1926 | 2017 | |
| 1927 | 2018 | // b, u, i, s, pre... basic tags. |
| 1928 | 2019 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong'); |
@@ -1931,8 +2022,9 @@ discard block |
||
| 1931 | 2022 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
| 1932 | 2023 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
| 1933 | 2024 | |
| 1934 | - if ($diff > 0) |
|
| 1935 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
| 2025 | + if ($diff > 0) { |
|
| 2026 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
| 2027 | + } |
|
| 1936 | 2028 | } |
| 1937 | 2029 | |
| 1938 | 2030 | // Do <img ...> - with security... action= -> action-. |
@@ -1945,8 +2037,9 @@ discard block |
||
| 1945 | 2037 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
| 1946 | 2038 | |
| 1947 | 2039 | // Remove action= from the URL - no funny business, now. |
| 1948 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
| 1949 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
| 2040 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
| 2041 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
| 2042 | + } |
|
| 1950 | 2043 | |
| 1951 | 2044 | $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
| 1952 | 2045 | } |
@@ -1961,16 +2054,18 @@ discard block |
||
| 1961 | 2054 | $no_autolink_area = false; |
| 1962 | 2055 | if (!empty($open_tags)) |
| 1963 | 2056 | { |
| 1964 | - foreach ($open_tags as $open_tag) |
|
| 1965 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
| 2057 | + foreach ($open_tags as $open_tag) { |
|
| 2058 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
| 1966 | 2059 | $no_autolink_area = true; |
| 2060 | + } |
|
| 1967 | 2061 | } |
| 1968 | 2062 | |
| 1969 | 2063 | // Don't go backwards. |
| 1970 | 2064 | // @todo Don't think is the real solution.... |
| 1971 | 2065 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
| 1972 | - if ($pos < $lastAutoPos) |
|
| 1973 | - $no_autolink_area = true; |
|
| 2066 | + if ($pos < $lastAutoPos) { |
|
| 2067 | + $no_autolink_area = true; |
|
| 2068 | + } |
|
| 1974 | 2069 | $lastAutoPos = $pos; |
| 1975 | 2070 | |
| 1976 | 2071 | if (!$no_autolink_area) |
@@ -2075,29 +2170,33 @@ discard block |
||
| 2075 | 2170 | $url = array_shift($matches); |
| 2076 | 2171 | |
| 2077 | 2172 | // If this isn't a clean URL, bail out |
| 2078 | - if ($url != sanitize_iri($url)) |
|
| 2079 | - return $url; |
|
| 2173 | + if ($url != sanitize_iri($url)) { |
|
| 2174 | + return $url; |
|
| 2175 | + } |
|
| 2080 | 2176 | |
| 2081 | 2177 | $scheme = parse_url($url, PHP_URL_SCHEME); |
| 2082 | 2178 | |
| 2083 | 2179 | if ($scheme == 'mailto') |
| 2084 | 2180 | { |
| 2085 | 2181 | $email_address = str_replace('mailto:', '', $url); |
| 2086 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
| 2087 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
| 2088 | - else |
|
| 2089 | - return $url; |
|
| 2182 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
| 2183 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
| 2184 | + } else { |
|
| 2185 | + return $url; |
|
| 2186 | + } |
|
| 2090 | 2187 | } |
| 2091 | 2188 | |
| 2092 | 2189 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
| 2093 | - if (empty($scheme)) |
|
| 2094 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
| 2095 | - else |
|
| 2096 | - $fullUrl = $url; |
|
| 2190 | + if (empty($scheme)) { |
|
| 2191 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
| 2192 | + } else { |
|
| 2193 | + $fullUrl = $url; |
|
| 2194 | + } |
|
| 2097 | 2195 | |
| 2098 | 2196 | // Make sure that $fullUrl really is valid |
| 2099 | - if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '' ) . $fullUrl) === false) |
|
| 2100 | - return $url; |
|
| 2197 | + if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '' ) . $fullUrl) === false) { |
|
| 2198 | + return $url; |
|
| 2199 | + } |
|
| 2101 | 2200 | |
| 2102 | 2201 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
| 2103 | 2202 | }, $data); |
@@ -2146,22 +2245,25 @@ discard block |
||
| 2146 | 2245 | } |
| 2147 | 2246 | |
| 2148 | 2247 | // Are we there yet? Are we there yet? |
| 2149 | - if ($pos >= strlen($message) - 1) |
|
| 2150 | - break; |
|
| 2248 | + if ($pos >= strlen($message) - 1) { |
|
| 2249 | + break; |
|
| 2250 | + } |
|
| 2151 | 2251 | |
| 2152 | 2252 | $tags = strtolower($message[$pos + 1]); |
| 2153 | 2253 | |
| 2154 | 2254 | if ($tags == '/' && !empty($open_tags)) |
| 2155 | 2255 | { |
| 2156 | 2256 | $pos2 = strpos($message, ']', $pos + 1); |
| 2157 | - if ($pos2 == $pos + 2) |
|
| 2158 | - continue; |
|
| 2257 | + if ($pos2 == $pos + 2) { |
|
| 2258 | + continue; |
|
| 2259 | + } |
|
| 2159 | 2260 | |
| 2160 | 2261 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
| 2161 | 2262 | |
| 2162 | 2263 | // A closing tag that doesn't match any open tags? Skip it. |
| 2163 | - if (!in_array($look_for, array_map(function($code){return $code['tag'];}, $open_tags))) |
|
| 2164 | - continue; |
|
| 2264 | + if (!in_array($look_for, array_map(function($code){return $code['tag'];}, $open_tags))) { |
|
| 2265 | + continue; |
|
| 2266 | + } |
|
| 2165 | 2267 | |
| 2166 | 2268 | $to_close = array(); |
| 2167 | 2269 | $block_level = null; |
@@ -2169,8 +2271,9 @@ discard block |
||
| 2169 | 2271 | do |
| 2170 | 2272 | { |
| 2171 | 2273 | $tag = array_pop($open_tags); |
| 2172 | - if (!$tag) |
|
| 2173 | - break; |
|
| 2274 | + if (!$tag) { |
|
| 2275 | + break; |
|
| 2276 | + } |
|
| 2174 | 2277 | |
| 2175 | 2278 | if (!empty($tag['block_level'])) |
| 2176 | 2279 | { |
@@ -2184,10 +2287,11 @@ discard block |
||
| 2184 | 2287 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
| 2185 | 2288 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
| 2186 | 2289 | { |
| 2187 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
| 2188 | - if ($temp['tag'] == $look_for) |
|
| 2290 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
| 2291 | + if ($temp['tag'] == $look_for) |
|
| 2189 | 2292 | { |
| 2190 | 2293 | $block_level = !empty($temp['block_level']); |
| 2294 | + } |
|
| 2191 | 2295 | break; |
| 2192 | 2296 | } |
| 2193 | 2297 | } |
@@ -2209,15 +2313,15 @@ discard block |
||
| 2209 | 2313 | { |
| 2210 | 2314 | $open_tags = $to_close; |
| 2211 | 2315 | continue; |
| 2212 | - } |
|
| 2213 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
| 2316 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
| 2214 | 2317 | { |
| 2215 | 2318 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
| 2216 | 2319 | { |
| 2217 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
| 2218 | - if ($temp['tag'] == $look_for) |
|
| 2320 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
| 2321 | + if ($temp['tag'] == $look_for) |
|
| 2219 | 2322 | { |
| 2220 | 2323 | $block_level = !empty($temp['block_level']); |
| 2324 | + } |
|
| 2221 | 2325 | break; |
| 2222 | 2326 | } |
| 2223 | 2327 | } |
@@ -2225,8 +2329,9 @@ discard block |
||
| 2225 | 2329 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
| 2226 | 2330 | if (!$block_level) |
| 2227 | 2331 | { |
| 2228 | - foreach ($to_close as $tag) |
|
| 2229 | - array_push($open_tags, $tag); |
|
| 2332 | + foreach ($to_close as $tag) { |
|
| 2333 | + array_push($open_tags, $tag); |
|
| 2334 | + } |
|
| 2230 | 2335 | continue; |
| 2231 | 2336 | } |
| 2232 | 2337 | } |
@@ -2239,14 +2344,17 @@ discard block |
||
| 2239 | 2344 | |
| 2240 | 2345 | // See the comment at the end of the big loop - just eating whitespace ;). |
| 2241 | 2346 | $whitespace_regex = ''; |
| 2242 | - if (!empty($tag['block_level'])) |
|
| 2243 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2347 | + if (!empty($tag['block_level'])) { |
|
| 2348 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2349 | + } |
|
| 2244 | 2350 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
| 2245 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
| 2246 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2351 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
| 2352 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2353 | + } |
|
| 2247 | 2354 | |
| 2248 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
| 2249 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2355 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
| 2356 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2357 | + } |
|
| 2250 | 2358 | } |
| 2251 | 2359 | |
| 2252 | 2360 | if (!empty($to_close)) |
@@ -2259,8 +2367,9 @@ discard block |
||
| 2259 | 2367 | } |
| 2260 | 2368 | |
| 2261 | 2369 | // No tags for this character, so just keep going (fastest possible course.) |
| 2262 | - if (!isset($bbc_codes[$tags])) |
|
| 2263 | - continue; |
|
| 2370 | + if (!isset($bbc_codes[$tags])) { |
|
| 2371 | + continue; |
|
| 2372 | + } |
|
| 2264 | 2373 | |
| 2265 | 2374 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
| 2266 | 2375 | $tag = null; |
@@ -2269,48 +2378,57 @@ discard block |
||
| 2269 | 2378 | $pt_strlen = strlen($possible['tag']); |
| 2270 | 2379 | |
| 2271 | 2380 | // Not a match? |
| 2272 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
| 2273 | - continue; |
|
| 2381 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
| 2382 | + continue; |
|
| 2383 | + } |
|
| 2274 | 2384 | |
| 2275 | 2385 | $next_c = isset($message[$pos + 1 + $pt_strlen]) ? $message[$pos + 1 + $pt_strlen] : ''; |
| 2276 | 2386 | |
| 2277 | 2387 | // A tag is the last char maybe |
| 2278 | - if ($next_c == '') |
|
| 2279 | - break; |
|
| 2388 | + if ($next_c == '') { |
|
| 2389 | + break; |
|
| 2390 | + } |
|
| 2280 | 2391 | |
| 2281 | 2392 | // A test validation? |
| 2282 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
| 2283 | - continue; |
|
| 2393 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
| 2394 | + continue; |
|
| 2395 | + } |
|
| 2284 | 2396 | // Do we want parameters? |
| 2285 | 2397 | elseif (!empty($possible['parameters'])) |
| 2286 | 2398 | { |
| 2287 | - if ($next_c != ' ') |
|
| 2288 | - continue; |
|
| 2289 | - } |
|
| 2290 | - elseif (isset($possible['type'])) |
|
| 2399 | + if ($next_c != ' ') { |
|
| 2400 | + continue; |
|
| 2401 | + } |
|
| 2402 | + } elseif (isset($possible['type'])) |
|
| 2291 | 2403 | { |
| 2292 | 2404 | // Do we need an equal sign? |
| 2293 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
| 2294 | - continue; |
|
| 2405 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
| 2406 | + continue; |
|
| 2407 | + } |
|
| 2295 | 2408 | // Maybe we just want a /... |
| 2296 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
| 2297 | - continue; |
|
| 2409 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
| 2410 | + continue; |
|
| 2411 | + } |
|
| 2298 | 2412 | // An immediate ]? |
| 2299 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
| 2300 | - continue; |
|
| 2413 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
| 2414 | + continue; |
|
| 2415 | + } |
|
| 2301 | 2416 | } |
| 2302 | 2417 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
| 2303 | - elseif ($next_c != ']') |
|
| 2304 | - continue; |
|
| 2418 | + elseif ($next_c != ']') { |
|
| 2419 | + continue; |
|
| 2420 | + } |
|
| 2305 | 2421 | |
| 2306 | 2422 | // Check allowed tree? |
| 2307 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
| 2308 | - continue; |
|
| 2309 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
| 2310 | - continue; |
|
| 2423 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
| 2424 | + continue; |
|
| 2425 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
| 2426 | + continue; |
|
| 2427 | + } |
|
| 2311 | 2428 | // If this is in the list of disallowed child tags, don't parse it. |
| 2312 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
| 2313 | - continue; |
|
| 2429 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
| 2430 | + continue; |
|
| 2431 | + } |
|
| 2314 | 2432 | |
| 2315 | 2433 | $pos1 = $pos + 1 + $pt_strlen + 1; |
| 2316 | 2434 | |
@@ -2322,8 +2440,9 @@ discard block |
||
| 2322 | 2440 | foreach ($open_tags as $open_quote) |
| 2323 | 2441 | { |
| 2324 | 2442 | // Every parent quote this quote has flips the styling |
| 2325 | - if ($open_quote['tag'] == 'quote') |
|
| 2326 | - $quote_alt = !$quote_alt; |
|
| 2443 | + if ($open_quote['tag'] == 'quote') { |
|
| 2444 | + $quote_alt = !$quote_alt; |
|
| 2445 | + } |
|
| 2327 | 2446 | } |
| 2328 | 2447 | // Add a class to the quote to style alternating blockquotes |
| 2329 | 2448 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2334,8 +2453,9 @@ discard block |
||
| 2334 | 2453 | { |
| 2335 | 2454 | // Build a regular expression for each parameter for the current tag. |
| 2336 | 2455 | $preg = array(); |
| 2337 | - foreach ($possible['parameters'] as $p => $info) |
|
| 2338 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
| 2456 | + foreach ($possible['parameters'] as $p => $info) { |
|
| 2457 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
| 2458 | + } |
|
| 2339 | 2459 | |
| 2340 | 2460 | // Extract the string that potentially holds our parameters. |
| 2341 | 2461 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2354,24 +2474,27 @@ discard block |
||
| 2354 | 2474 | |
| 2355 | 2475 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
| 2356 | 2476 | |
| 2357 | - if ($match) |
|
| 2358 | - $blob_counter = count($blobs) + 1; |
|
| 2477 | + if ($match) { |
|
| 2478 | + $blob_counter = count($blobs) + 1; |
|
| 2479 | + } |
|
| 2359 | 2480 | } |
| 2360 | 2481 | |
| 2361 | 2482 | // Didn't match our parameter list, try the next possible. |
| 2362 | - if (!$match) |
|
| 2363 | - continue; |
|
| 2483 | + if (!$match) { |
|
| 2484 | + continue; |
|
| 2485 | + } |
|
| 2364 | 2486 | |
| 2365 | 2487 | $params = array(); |
| 2366 | 2488 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
| 2367 | 2489 | { |
| 2368 | 2490 | $key = strtok(ltrim($matches[$i]), '='); |
| 2369 | - if (isset($possible['parameters'][$key]['value'])) |
|
| 2370 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
| 2371 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
| 2372 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
| 2373 | - else |
|
| 2374 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
| 2491 | + if (isset($possible['parameters'][$key]['value'])) { |
|
| 2492 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
| 2493 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
| 2494 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
| 2495 | + } else { |
|
| 2496 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
| 2497 | + } |
|
| 2375 | 2498 | |
| 2376 | 2499 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
| 2377 | 2500 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2379,23 +2502,26 @@ discard block |
||
| 2379 | 2502 | |
| 2380 | 2503 | foreach ($possible['parameters'] as $p => $info) |
| 2381 | 2504 | { |
| 2382 | - if (!isset($params['{' . $p . '}'])) |
|
| 2383 | - $params['{' . $p . '}'] = ''; |
|
| 2505 | + if (!isset($params['{' . $p . '}'])) { |
|
| 2506 | + $params['{' . $p . '}'] = ''; |
|
| 2507 | + } |
|
| 2384 | 2508 | } |
| 2385 | 2509 | |
| 2386 | 2510 | $tag = $possible; |
| 2387 | 2511 | |
| 2388 | 2512 | // Put the parameters into the string. |
| 2389 | - if (isset($tag['before'])) |
|
| 2390 | - $tag['before'] = strtr($tag['before'], $params); |
|
| 2391 | - if (isset($tag['after'])) |
|
| 2392 | - $tag['after'] = strtr($tag['after'], $params); |
|
| 2393 | - if (isset($tag['content'])) |
|
| 2394 | - $tag['content'] = strtr($tag['content'], $params); |
|
| 2513 | + if (isset($tag['before'])) { |
|
| 2514 | + $tag['before'] = strtr($tag['before'], $params); |
|
| 2515 | + } |
|
| 2516 | + if (isset($tag['after'])) { |
|
| 2517 | + $tag['after'] = strtr($tag['after'], $params); |
|
| 2518 | + } |
|
| 2519 | + if (isset($tag['content'])) { |
|
| 2520 | + $tag['content'] = strtr($tag['content'], $params); |
|
| 2521 | + } |
|
| 2395 | 2522 | |
| 2396 | 2523 | $pos1 += strlen($given_param_string); |
| 2397 | - } |
|
| 2398 | - else |
|
| 2524 | + } else |
|
| 2399 | 2525 | { |
| 2400 | 2526 | $tag = $possible; |
| 2401 | 2527 | $params = array(); |
@@ -2406,8 +2532,9 @@ discard block |
||
| 2406 | 2532 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
| 2407 | 2533 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
| 2408 | 2534 | { |
| 2409 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
| 2410 | - continue; |
|
| 2535 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
| 2536 | + continue; |
|
| 2537 | + } |
|
| 2411 | 2538 | |
| 2412 | 2539 | $tag = $itemcodes[$message[$pos + 1]]; |
| 2413 | 2540 | |
@@ -2428,9 +2555,9 @@ discard block |
||
| 2428 | 2555 | { |
| 2429 | 2556 | array_pop($open_tags); |
| 2430 | 2557 | $code = '</li>'; |
| 2558 | + } else { |
|
| 2559 | + $code = ''; |
|
| 2431 | 2560 | } |
| 2432 | - else |
|
| 2433 | - $code = ''; |
|
| 2434 | 2561 | |
| 2435 | 2562 | // Now we open a new tag. |
| 2436 | 2563 | $open_tags[] = array( |
@@ -2477,12 +2604,14 @@ discard block |
||
| 2477 | 2604 | } |
| 2478 | 2605 | |
| 2479 | 2606 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
| 2480 | - if ($tag === null) |
|
| 2481 | - continue; |
|
| 2607 | + if ($tag === null) { |
|
| 2608 | + continue; |
|
| 2609 | + } |
|
| 2482 | 2610 | |
| 2483 | 2611 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
| 2484 | - if (isset($inside['disallow_children'])) |
|
| 2485 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
| 2612 | + if (isset($inside['disallow_children'])) { |
|
| 2613 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
| 2614 | + } |
|
| 2486 | 2615 | |
| 2487 | 2616 | // Is this tag disabled? |
| 2488 | 2617 | if (isset($disabled[$tag['tag']])) |
@@ -2492,14 +2621,13 @@ discard block |
||
| 2492 | 2621 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
| 2493 | 2622 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
| 2494 | 2623 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
| 2495 | - } |
|
| 2496 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
| 2624 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
| 2497 | 2625 | { |
| 2498 | 2626 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
| 2499 | 2627 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
| 2628 | + } else { |
|
| 2629 | + $tag['content'] = $tag['disabled_content']; |
|
| 2500 | 2630 | } |
| 2501 | - else |
|
| 2502 | - $tag['content'] = $tag['disabled_content']; |
|
| 2503 | 2631 | } |
| 2504 | 2632 | |
| 2505 | 2633 | // we use this a lot |
@@ -2509,8 +2637,9 @@ discard block |
||
| 2509 | 2637 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
| 2510 | 2638 | { |
| 2511 | 2639 | $n = count($open_tags) - 1; |
| 2512 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
| 2513 | - $n--; |
|
| 2640 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
| 2641 | + $n--; |
|
| 2642 | + } |
|
| 2514 | 2643 | |
| 2515 | 2644 | // Close all the non block level tags so this tag isn't surrounded by them. |
| 2516 | 2645 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2522,12 +2651,15 @@ discard block |
||
| 2522 | 2651 | |
| 2523 | 2652 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
| 2524 | 2653 | $whitespace_regex = ''; |
| 2525 | - if (!empty($tag['block_level'])) |
|
| 2526 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2527 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
| 2528 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2529 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
| 2530 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2654 | + if (!empty($tag['block_level'])) { |
|
| 2655 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2656 | + } |
|
| 2657 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
| 2658 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2659 | + } |
|
| 2660 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
| 2661 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2662 | + } |
|
| 2531 | 2663 | |
| 2532 | 2664 | array_pop($open_tags); |
| 2533 | 2665 | } |
@@ -2548,16 +2680,19 @@ discard block |
||
| 2548 | 2680 | elseif ($tag['type'] == 'unparsed_content') |
| 2549 | 2681 | { |
| 2550 | 2682 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
| 2551 | - if ($pos2 === false) |
|
| 2552 | - continue; |
|
| 2683 | + if ($pos2 === false) { |
|
| 2684 | + continue; |
|
| 2685 | + } |
|
| 2553 | 2686 | |
| 2554 | 2687 | $data = substr($message, $pos1, $pos2 - $pos1); |
| 2555 | 2688 | |
| 2556 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
| 2557 | - $data = substr($data, 4); |
|
| 2689 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
| 2690 | + $data = substr($data, 4); |
|
| 2691 | + } |
|
| 2558 | 2692 | |
| 2559 | - if (isset($tag['validate'])) |
|
| 2560 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2693 | + if (isset($tag['validate'])) { |
|
| 2694 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2695 | + } |
|
| 2561 | 2696 | |
| 2562 | 2697 | $code = strtr($tag['content'], array('$1' => $data)); |
| 2563 | 2698 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2572,34 +2707,40 @@ discard block |
||
| 2572 | 2707 | if (isset($tag['quoted'])) |
| 2573 | 2708 | { |
| 2574 | 2709 | $quoted = substr($message, $pos1, 6) == '"'; |
| 2575 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
| 2576 | - continue; |
|
| 2710 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
| 2711 | + continue; |
|
| 2712 | + } |
|
| 2577 | 2713 | |
| 2578 | - if ($quoted) |
|
| 2579 | - $pos1 += 6; |
|
| 2714 | + if ($quoted) { |
|
| 2715 | + $pos1 += 6; |
|
| 2716 | + } |
|
| 2717 | + } else { |
|
| 2718 | + $quoted = false; |
|
| 2580 | 2719 | } |
| 2581 | - else |
|
| 2582 | - $quoted = false; |
|
| 2583 | 2720 | |
| 2584 | 2721 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
| 2585 | - if ($pos2 === false) |
|
| 2586 | - continue; |
|
| 2722 | + if ($pos2 === false) { |
|
| 2723 | + continue; |
|
| 2724 | + } |
|
| 2587 | 2725 | |
| 2588 | 2726 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
| 2589 | - if ($pos3 === false) |
|
| 2590 | - continue; |
|
| 2727 | + if ($pos3 === false) { |
|
| 2728 | + continue; |
|
| 2729 | + } |
|
| 2591 | 2730 | |
| 2592 | 2731 | $data = array( |
| 2593 | 2732 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
| 2594 | 2733 | substr($message, $pos1, $pos2 - $pos1) |
| 2595 | 2734 | ); |
| 2596 | 2735 | |
| 2597 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
| 2598 | - $data[0] = substr($data[0], 4); |
|
| 2736 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
| 2737 | + $data[0] = substr($data[0], 4); |
|
| 2738 | + } |
|
| 2599 | 2739 | |
| 2600 | 2740 | // Validation for my parking, please! |
| 2601 | - if (isset($tag['validate'])) |
|
| 2602 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2741 | + if (isset($tag['validate'])) { |
|
| 2742 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2743 | + } |
|
| 2603 | 2744 | |
| 2604 | 2745 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
| 2605 | 2746 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2616,23 +2757,27 @@ discard block |
||
| 2616 | 2757 | elseif ($tag['type'] == 'unparsed_commas_content') |
| 2617 | 2758 | { |
| 2618 | 2759 | $pos2 = strpos($message, ']', $pos1); |
| 2619 | - if ($pos2 === false) |
|
| 2620 | - continue; |
|
| 2760 | + if ($pos2 === false) { |
|
| 2761 | + continue; |
|
| 2762 | + } |
|
| 2621 | 2763 | |
| 2622 | 2764 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
| 2623 | - if ($pos3 === false) |
|
| 2624 | - continue; |
|
| 2765 | + if ($pos3 === false) { |
|
| 2766 | + continue; |
|
| 2767 | + } |
|
| 2625 | 2768 | |
| 2626 | 2769 | // We want $1 to be the content, and the rest to be csv. |
| 2627 | 2770 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
| 2628 | 2771 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
| 2629 | 2772 | |
| 2630 | - if (isset($tag['validate'])) |
|
| 2631 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2773 | + if (isset($tag['validate'])) { |
|
| 2774 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2775 | + } |
|
| 2632 | 2776 | |
| 2633 | 2777 | $code = $tag['content']; |
| 2634 | - foreach ($data as $k => $d) |
|
| 2635 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2778 | + foreach ($data as $k => $d) { |
|
| 2779 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2780 | + } |
|
| 2636 | 2781 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
| 2637 | 2782 | $pos += strlen($code) - 1 + 2; |
| 2638 | 2783 | } |
@@ -2640,24 +2785,28 @@ discard block |
||
| 2640 | 2785 | elseif ($tag['type'] == 'unparsed_commas') |
| 2641 | 2786 | { |
| 2642 | 2787 | $pos2 = strpos($message, ']', $pos1); |
| 2643 | - if ($pos2 === false) |
|
| 2644 | - continue; |
|
| 2788 | + if ($pos2 === false) { |
|
| 2789 | + continue; |
|
| 2790 | + } |
|
| 2645 | 2791 | |
| 2646 | 2792 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
| 2647 | 2793 | |
| 2648 | - if (isset($tag['validate'])) |
|
| 2649 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2794 | + if (isset($tag['validate'])) { |
|
| 2795 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2796 | + } |
|
| 2650 | 2797 | |
| 2651 | 2798 | // Fix after, for disabled code mainly. |
| 2652 | - foreach ($data as $k => $d) |
|
| 2653 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
| 2799 | + foreach ($data as $k => $d) { |
|
| 2800 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
| 2801 | + } |
|
| 2654 | 2802 | |
| 2655 | 2803 | $open_tags[] = $tag; |
| 2656 | 2804 | |
| 2657 | 2805 | // Replace them out, $1, $2, $3, $4, etc. |
| 2658 | 2806 | $code = $tag['before']; |
| 2659 | - foreach ($data as $k => $d) |
|
| 2660 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2807 | + foreach ($data as $k => $d) { |
|
| 2808 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2809 | + } |
|
| 2661 | 2810 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
| 2662 | 2811 | $pos += strlen($code) - 1 + 2; |
| 2663 | 2812 | } |
@@ -2668,28 +2817,33 @@ discard block |
||
| 2668 | 2817 | if (isset($tag['quoted'])) |
| 2669 | 2818 | { |
| 2670 | 2819 | $quoted = substr($message, $pos1, 6) == '"'; |
| 2671 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
| 2672 | - continue; |
|
| 2820 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
| 2821 | + continue; |
|
| 2822 | + } |
|
| 2673 | 2823 | |
| 2674 | - if ($quoted) |
|
| 2675 | - $pos1 += 6; |
|
| 2824 | + if ($quoted) { |
|
| 2825 | + $pos1 += 6; |
|
| 2826 | + } |
|
| 2827 | + } else { |
|
| 2828 | + $quoted = false; |
|
| 2676 | 2829 | } |
| 2677 | - else |
|
| 2678 | - $quoted = false; |
|
| 2679 | 2830 | |
| 2680 | 2831 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
| 2681 | - if ($pos2 === false) |
|
| 2682 | - continue; |
|
| 2832 | + if ($pos2 === false) { |
|
| 2833 | + continue; |
|
| 2834 | + } |
|
| 2683 | 2835 | |
| 2684 | 2836 | $data = substr($message, $pos1, $pos2 - $pos1); |
| 2685 | 2837 | |
| 2686 | 2838 | // Validation for my parking, please! |
| 2687 | - if (isset($tag['validate'])) |
|
| 2688 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2839 | + if (isset($tag['validate'])) { |
|
| 2840 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2841 | + } |
|
| 2689 | 2842 | |
| 2690 | 2843 | // For parsed content, we must recurse to avoid security problems. |
| 2691 | - if ($tag['type'] != 'unparsed_equals') |
|
| 2692 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
| 2844 | + if ($tag['type'] != 'unparsed_equals') { |
|
| 2845 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
| 2846 | + } |
|
| 2693 | 2847 | |
| 2694 | 2848 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
| 2695 | 2849 | |
@@ -2701,34 +2855,40 @@ discard block |
||
| 2701 | 2855 | } |
| 2702 | 2856 | |
| 2703 | 2857 | // If this is block level, eat any breaks after it. |
| 2704 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
| 2705 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
| 2858 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
| 2859 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
| 2860 | + } |
|
| 2706 | 2861 | |
| 2707 | 2862 | // Are we trimming outside this tag? |
| 2708 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
| 2709 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
| 2863 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
| 2864 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
| 2865 | + } |
|
| 2710 | 2866 | } |
| 2711 | 2867 | |
| 2712 | 2868 | // Close any remaining tags. |
| 2713 | - while ($tag = array_pop($open_tags)) |
|
| 2714 | - $message .= "\n" . $tag['after'] . "\n"; |
|
| 2869 | + while ($tag = array_pop($open_tags)) { |
|
| 2870 | + $message .= "\n" . $tag['after'] . "\n"; |
|
| 2871 | + } |
|
| 2715 | 2872 | |
| 2716 | 2873 | // Parse the smileys within the parts where it can be done safely. |
| 2717 | 2874 | if ($smileys === true) |
| 2718 | 2875 | { |
| 2719 | 2876 | $message_parts = explode("\n", $message); |
| 2720 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
| 2721 | - parsesmileys($message_parts[$i]); |
|
| 2877 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
| 2878 | + parsesmileys($message_parts[$i]); |
|
| 2879 | + } |
|
| 2722 | 2880 | |
| 2723 | 2881 | $message = implode('', $message_parts); |
| 2724 | 2882 | } |
| 2725 | 2883 | |
| 2726 | 2884 | // No smileys, just get rid of the markers. |
| 2727 | - else |
|
| 2728 | - $message = strtr($message, array("\n" => '')); |
|
| 2885 | + else { |
|
| 2886 | + $message = strtr($message, array("\n" => '')); |
|
| 2887 | + } |
|
| 2729 | 2888 | |
| 2730 | - if ($message !== '' && $message[0] === ' ') |
|
| 2731 | - $message = ' ' . substr($message, 1); |
|
| 2889 | + if ($message !== '' && $message[0] === ' ') { |
|
| 2890 | + $message = ' ' . substr($message, 1); |
|
| 2891 | + } |
|
| 2732 | 2892 | |
| 2733 | 2893 | // Cleanup whitespace. |
| 2734 | 2894 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2737,15 +2897,16 @@ discard block |
||
| 2737 | 2897 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
| 2738 | 2898 | |
| 2739 | 2899 | // Cache the output if it took some time... |
| 2740 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
| 2741 | - cache_put_data($cache_key, $message, 240); |
|
| 2900 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
| 2901 | + cache_put_data($cache_key, $message, 240); |
|
| 2902 | + } |
|
| 2742 | 2903 | |
| 2743 | 2904 | // If this was a force parse revert if needed. |
| 2744 | 2905 | if (!empty($parse_tags)) |
| 2745 | 2906 | { |
| 2746 | - if (empty($temp_bbc)) |
|
| 2747 | - $bbc_codes = array(); |
|
| 2748 | - else |
|
| 2907 | + if (empty($temp_bbc)) { |
|
| 2908 | + $bbc_codes = array(); |
|
| 2909 | + } else |
|
| 2749 | 2910 | { |
| 2750 | 2911 | $bbc_codes = $temp_bbc; |
| 2751 | 2912 | unset($temp_bbc); |
@@ -2772,8 +2933,9 @@ discard block |
||
| 2772 | 2933 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
| 2773 | 2934 | |
| 2774 | 2935 | // No smiley set at all?! |
| 2775 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
| 2776 | - return; |
|
| 2936 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
| 2937 | + return; |
|
| 2938 | + } |
|
| 2777 | 2939 | |
| 2778 | 2940 | // Maybe a mod wants to implement an alternative method (e.g. emojis instead of images) |
| 2779 | 2941 | call_integration_hook('integrate_smileys', array(&$smileyPregSearch, &$smileyPregReplacements)); |
@@ -2787,8 +2949,7 @@ discard block |
||
| 2787 | 2949 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
| 2788 | 2950 | $smileysto = array('evil.png', 'cheesy.png', 'rolleyes.png', 'angry.png', 'laugh.png', 'smiley.png', 'wink.png', 'grin.png', 'sad.png', 'shocked.png', 'cool.png', 'tongue.png', 'huh.png', 'embarrassed.png', 'lipsrsealed.png', 'kiss.png', 'cry.png', 'undecided.png', 'azn.png', 'afro.png', 'police.png', 'angel.png'); |
| 2789 | 2951 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
| 2790 | - } |
|
| 2791 | - else |
|
| 2952 | + } else |
|
| 2792 | 2953 | { |
| 2793 | 2954 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
| 2794 | 2955 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2812,9 +2973,9 @@ discard block |
||
| 2812 | 2973 | $smcFunc['db_free_result']($result); |
| 2813 | 2974 | |
| 2814 | 2975 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
| 2976 | + } else { |
|
| 2977 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
| 2815 | 2978 | } |
| 2816 | - else |
|
| 2817 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
| 2818 | 2979 | } |
| 2819 | 2980 | |
| 2820 | 2981 | // The non-breaking-space is a complex thing... |
@@ -2836,16 +2997,18 @@ discard block |
||
| 2836 | 2997 | $alt_images = glob($smileys_dir . $fname . '.{' . (implode(',', $exts)) . '}', GLOB_BRACE); |
| 2837 | 2998 | if (!empty($alt_images)) |
| 2838 | 2999 | { |
| 2839 | - foreach ($exts as $ext) |
|
| 2840 | - if (in_array($smileys_dir . $fname . '.' . $ext, $alt_images)) |
|
| 3000 | + foreach ($exts as $ext) { |
|
| 3001 | + if (in_array($smileys_dir . $fname . '.' . $ext, $alt_images)) |
|
| 2841 | 3002 | { |
| 2842 | 3003 | $smileysto[$i] = $fname . '.' . $ext; |
| 3004 | + } |
|
| 2843 | 3005 | break; |
| 2844 | 3006 | } |
| 2845 | 3007 | } |
| 2846 | 3008 | // If we have no image, just leave the text version in place |
| 2847 | - else |
|
| 2848 | - continue; |
|
| 3009 | + else { |
|
| 3010 | + continue; |
|
| 3011 | + } |
|
| 2849 | 3012 | } |
| 2850 | 3013 | |
| 2851 | 3014 | $specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES); |
@@ -2913,12 +3076,14 @@ discard block |
||
| 2913 | 3076 | global $boardurl, $image_proxy_enabled, $image_proxy_secret; |
| 2914 | 3077 | |
| 2915 | 3078 | // Only use the proxy if enabled and necessary |
| 2916 | - if (empty($image_proxy_enabled) || parse_url($url, PHP_URL_SCHEME) === 'https') |
|
| 2917 | - return $url; |
|
| 3079 | + if (empty($image_proxy_enabled) || parse_url($url, PHP_URL_SCHEME) === 'https') { |
|
| 3080 | + return $url; |
|
| 3081 | + } |
|
| 2918 | 3082 | |
| 2919 | 3083 | // We don't need to proxy our own resources |
| 2920 | - if (strpos(strtr($url, array('http://' => 'https://')), strtr($boardurl, array('http://' => 'https://'))) === 0) |
|
| 2921 | - return strtr($url, array('http://' => 'https://')); |
|
| 3084 | + if (strpos(strtr($url, array('http://' => 'https://')), strtr($boardurl, array('http://' => 'https://'))) === 0) { |
|
| 3085 | + return strtr($url, array('http://' => 'https://')); |
|
| 3086 | + } |
|
| 2922 | 3087 | |
| 2923 | 3088 | // By default, use SMF's own image proxy script |
| 2924 | 3089 | $proxied_url = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($url) . '&hash=' . md5($url . $image_proxy_secret); |
@@ -2943,35 +3108,41 @@ discard block |
||
| 2943 | 3108 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
| 2944 | 3109 | |
| 2945 | 3110 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
| 2946 | - if (!empty($context['flush_mail'])) |
|
| 2947 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 3111 | + if (!empty($context['flush_mail'])) { |
|
| 3112 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 2948 | 3113 | AddMailQueue(true); |
| 3114 | + } |
|
| 2949 | 3115 | |
| 2950 | 3116 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
| 2951 | 3117 | |
| 2952 | - if ($add) |
|
| 2953 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
| 3118 | + if ($add) { |
|
| 3119 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
| 3120 | + } |
|
| 2954 | 3121 | |
| 2955 | 3122 | // Put the session ID in. |
| 2956 | - if (defined('SID') && SID != '') |
|
| 2957 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
| 3123 | + if (defined('SID') && SID != '') { |
|
| 3124 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
| 3125 | + } |
|
| 2958 | 3126 | // Keep that debug in their for template debugging! |
| 2959 | - elseif (isset($_GET['debug'])) |
|
| 2960 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
| 3127 | + elseif (isset($_GET['debug'])) { |
|
| 3128 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
| 3129 | + } |
|
| 2961 | 3130 | |
| 2962 | 3131 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
| 2963 | 3132 | { |
| 2964 | - if (defined('SID') && SID != '') |
|
| 2965 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
| 3133 | + if (defined('SID') && SID != '') { |
|
| 3134 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
| 2966 | 3135 | function ($m) use ($scripturl) |
| 2967 | 3136 | { |
| 2968 | 3137 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
| 3138 | + } |
|
| 2969 | 3139 | }, $setLocation); |
| 2970 | - else |
|
| 2971 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
| 3140 | + else { |
|
| 3141 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
| 2972 | 3142 | function ($m) use ($scripturl) |
| 2973 | 3143 | { |
| 2974 | 3144 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
| 3145 | + } |
|
| 2975 | 3146 | }, $setLocation); |
| 2976 | 3147 | } |
| 2977 | 3148 | |
@@ -2982,8 +3153,9 @@ discard block |
||
| 2982 | 3153 | header('location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
| 2983 | 3154 | |
| 2984 | 3155 | // Debugging. |
| 2985 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
| 2986 | - $_SESSION['debug_redirect'] = $db_cache; |
|
| 3156 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
| 3157 | + $_SESSION['debug_redirect'] = $db_cache; |
|
| 3158 | + } |
|
| 2987 | 3159 | |
| 2988 | 3160 | obExit(false); |
| 2989 | 3161 | } |
@@ -3002,51 +3174,60 @@ discard block |
||
| 3002 | 3174 | |
| 3003 | 3175 | // Attempt to prevent a recursive loop. |
| 3004 | 3176 | ++$level; |
| 3005 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
| 3006 | - exit; |
|
| 3007 | - if ($from_fatal_error) |
|
| 3008 | - $has_fatal_error = true; |
|
| 3177 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
| 3178 | + exit; |
|
| 3179 | + } |
|
| 3180 | + if ($from_fatal_error) { |
|
| 3181 | + $has_fatal_error = true; |
|
| 3182 | + } |
|
| 3009 | 3183 | |
| 3010 | 3184 | // Clear out the stat cache. |
| 3011 | 3185 | trackStats(); |
| 3012 | 3186 | |
| 3013 | 3187 | // If we have mail to send, send it. |
| 3014 | - if (!empty($context['flush_mail'])) |
|
| 3015 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 3188 | + if (!empty($context['flush_mail'])) { |
|
| 3189 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 3016 | 3190 | AddMailQueue(true); |
| 3191 | + } |
|
| 3017 | 3192 | |
| 3018 | 3193 | $do_header = $header === null ? !$header_done : $header; |
| 3019 | - if ($do_footer === null) |
|
| 3020 | - $do_footer = $do_header; |
|
| 3194 | + if ($do_footer === null) { |
|
| 3195 | + $do_footer = $do_header; |
|
| 3196 | + } |
|
| 3021 | 3197 | |
| 3022 | 3198 | // Has the template/header been done yet? |
| 3023 | 3199 | if ($do_header) |
| 3024 | 3200 | { |
| 3025 | 3201 | // Was the page title set last minute? Also update the HTML safe one. |
| 3026 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
| 3027 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
| 3202 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
| 3203 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
| 3204 | + } |
|
| 3028 | 3205 | |
| 3029 | 3206 | // Start up the session URL fixer. |
| 3030 | 3207 | ob_start('ob_sessrewrite'); |
| 3031 | 3208 | |
| 3032 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
| 3033 | - $buffers = explode(',', $settings['output_buffers']); |
|
| 3034 | - elseif (!empty($settings['output_buffers'])) |
|
| 3035 | - $buffers = $settings['output_buffers']; |
|
| 3036 | - else |
|
| 3037 | - $buffers = array(); |
|
| 3209 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
| 3210 | + $buffers = explode(',', $settings['output_buffers']); |
|
| 3211 | + } elseif (!empty($settings['output_buffers'])) { |
|
| 3212 | + $buffers = $settings['output_buffers']; |
|
| 3213 | + } else { |
|
| 3214 | + $buffers = array(); |
|
| 3215 | + } |
|
| 3038 | 3216 | |
| 3039 | - if (isset($modSettings['integrate_buffer'])) |
|
| 3040 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
| 3217 | + if (isset($modSettings['integrate_buffer'])) { |
|
| 3218 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
| 3219 | + } |
|
| 3041 | 3220 | |
| 3042 | - if (!empty($buffers)) |
|
| 3043 | - foreach ($buffers as $function) |
|
| 3221 | + if (!empty($buffers)) { |
|
| 3222 | + foreach ($buffers as $function) |
|
| 3044 | 3223 | { |
| 3045 | 3224 | $call = call_helper($function, true); |
| 3225 | + } |
|
| 3046 | 3226 | |
| 3047 | 3227 | // Is it valid? |
| 3048 | - if (!empty($call)) |
|
| 3049 | - ob_start($call); |
|
| 3228 | + if (!empty($call)) { |
|
| 3229 | + ob_start($call); |
|
| 3230 | + } |
|
| 3050 | 3231 | } |
| 3051 | 3232 | |
| 3052 | 3233 | // Display the screen in the logical order. |
@@ -3058,8 +3239,9 @@ discard block |
||
| 3058 | 3239 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
| 3059 | 3240 | |
| 3060 | 3241 | // Anything special to put out? |
| 3061 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
| 3062 | - echo $context['insert_after_template']; |
|
| 3242 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
| 3243 | + echo $context['insert_after_template']; |
|
| 3244 | + } |
|
| 3063 | 3245 | |
| 3064 | 3246 | // Just so we don't get caught in an endless loop of errors from the footer... |
| 3065 | 3247 | if (!$footer_done) |
@@ -3068,14 +3250,16 @@ discard block |
||
| 3068 | 3250 | template_footer(); |
| 3069 | 3251 | |
| 3070 | 3252 | // (since this is just debugging... it's okay that it's after </html>.) |
| 3071 | - if (!isset($_REQUEST['xml'])) |
|
| 3072 | - displayDebug(); |
|
| 3253 | + if (!isset($_REQUEST['xml'])) { |
|
| 3254 | + displayDebug(); |
|
| 3255 | + } |
|
| 3073 | 3256 | } |
| 3074 | 3257 | } |
| 3075 | 3258 | |
| 3076 | 3259 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
| 3077 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
| 3078 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
| 3260 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
| 3261 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
| 3262 | + } |
|
| 3079 | 3263 | |
| 3080 | 3264 | // For session check verification.... don't switch browsers... |
| 3081 | 3265 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -3084,9 +3268,10 @@ discard block |
||
| 3084 | 3268 | call_integration_hook('integrate_exit', array($do_footer)); |
| 3085 | 3269 | |
| 3086 | 3270 | // Don't exit if we're coming from index.php; that will pass through normally. |
| 3087 | - if (!$from_index) |
|
| 3088 | - exit; |
|
| 3089 | -} |
|
| 3271 | + if (!$from_index) { |
|
| 3272 | + exit; |
|
| 3273 | + } |
|
| 3274 | + } |
|
| 3090 | 3275 | |
| 3091 | 3276 | /** |
| 3092 | 3277 | * Get the size of a specified image with better error handling. |
@@ -3105,8 +3290,9 @@ discard block |
||
| 3105 | 3290 | $url = str_replace(' ', '%20', $url); |
| 3106 | 3291 | |
| 3107 | 3292 | // Can we pull this from the cache... please please? |
| 3108 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
| 3109 | - return $temp; |
|
| 3293 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
| 3294 | + return $temp; |
|
| 3295 | + } |
|
| 3110 | 3296 | $t = microtime(); |
| 3111 | 3297 | |
| 3112 | 3298 | // Get the host to pester... |
@@ -3116,12 +3302,10 @@ discard block |
||
| 3116 | 3302 | if ($url == '' || $url == 'http://' || $url == 'https://') |
| 3117 | 3303 | { |
| 3118 | 3304 | return false; |
| 3119 | - } |
|
| 3120 | - elseif (!isset($match[1])) |
|
| 3305 | + } elseif (!isset($match[1])) |
|
| 3121 | 3306 | { |
| 3122 | 3307 | $size = @getimagesize($url); |
| 3123 | - } |
|
| 3124 | - else |
|
| 3308 | + } else |
|
| 3125 | 3309 | { |
| 3126 | 3310 | // Try to connect to the server... give it half a second. |
| 3127 | 3311 | $temp = 0; |
@@ -3158,12 +3342,14 @@ discard block |
||
| 3158 | 3342 | } |
| 3159 | 3343 | |
| 3160 | 3344 | // If we didn't get it, we failed. |
| 3161 | - if (!isset($size)) |
|
| 3162 | - $size = false; |
|
| 3345 | + if (!isset($size)) { |
|
| 3346 | + $size = false; |
|
| 3347 | + } |
|
| 3163 | 3348 | |
| 3164 | 3349 | // If this took a long time, we may never have to do it again, but then again we might... |
| 3165 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
| 3166 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
| 3350 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
| 3351 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
| 3352 | + } |
|
| 3167 | 3353 | |
| 3168 | 3354 | // Didn't work. |
| 3169 | 3355 | return $size; |
@@ -3181,8 +3367,9 @@ discard block |
||
| 3181 | 3367 | |
| 3182 | 3368 | // Under SSI this function can be called more then once. That can cause some problems. |
| 3183 | 3369 | // So only run the function once unless we are forced to run it again. |
| 3184 | - if ($loaded && !$forceload) |
|
| 3185 | - return; |
|
| 3370 | + if ($loaded && !$forceload) { |
|
| 3371 | + return; |
|
| 3372 | + } |
|
| 3186 | 3373 | |
| 3187 | 3374 | $loaded = true; |
| 3188 | 3375 | |
@@ -3194,14 +3381,16 @@ discard block |
||
| 3194 | 3381 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
| 3195 | 3382 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
| 3196 | 3383 | { |
| 3197 | - if (trim($context['news_lines'][$i]) == '') |
|
| 3198 | - continue; |
|
| 3384 | + if (trim($context['news_lines'][$i]) == '') { |
|
| 3385 | + continue; |
|
| 3386 | + } |
|
| 3199 | 3387 | |
| 3200 | 3388 | // Clean it up for presentation ;). |
| 3201 | 3389 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
| 3202 | 3390 | } |
| 3203 | - if (!empty($context['news_lines'])) |
|
| 3204 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
| 3391 | + if (!empty($context['news_lines'])) { |
|
| 3392 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
| 3393 | + } |
|
| 3205 | 3394 | |
| 3206 | 3395 | if (!$user_info['is_guest']) |
| 3207 | 3396 | { |
@@ -3210,40 +3399,48 @@ discard block |
||
| 3210 | 3399 | $context['user']['alerts'] = &$user_info['alerts']; |
| 3211 | 3400 | |
| 3212 | 3401 | // Personal message popup... |
| 3213 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
| 3214 | - $context['user']['popup_messages'] = true; |
|
| 3215 | - else |
|
| 3216 | - $context['user']['popup_messages'] = false; |
|
| 3402 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
| 3403 | + $context['user']['popup_messages'] = true; |
|
| 3404 | + } else { |
|
| 3405 | + $context['user']['popup_messages'] = false; |
|
| 3406 | + } |
|
| 3217 | 3407 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
| 3218 | 3408 | |
| 3219 | - if (allowedTo('moderate_forum')) |
|
| 3220 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
| 3409 | + if (allowedTo('moderate_forum')) { |
|
| 3410 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
| 3411 | + } |
|
| 3221 | 3412 | |
| 3222 | 3413 | $context['user']['avatar'] = array(); |
| 3223 | 3414 | |
| 3224 | 3415 | // Check for gravatar first since we might be forcing them... |
| 3225 | 3416 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
| 3226 | 3417 | { |
| 3227 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
| 3228 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
| 3229 | - else |
|
| 3230 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
| 3418 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
| 3419 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
| 3420 | + } else { |
|
| 3421 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
| 3422 | + } |
|
| 3231 | 3423 | } |
| 3232 | 3424 | // Uploaded? |
| 3233 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
| 3234 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
| 3425 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
| 3426 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
| 3427 | + } |
|
| 3235 | 3428 | // Full URL? |
| 3236 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
| 3237 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
| 3429 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
| 3430 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
| 3431 | + } |
|
| 3238 | 3432 | // Otherwise we assume it's server stored. |
| 3239 | - elseif ($user_info['avatar']['url'] != '') |
|
| 3240 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
| 3433 | + elseif ($user_info['avatar']['url'] != '') { |
|
| 3434 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
| 3435 | + } |
|
| 3241 | 3436 | // No avatar at all? Fine, we have a big fat default avatar ;) |
| 3242 | - else |
|
| 3243 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
| 3437 | + else { |
|
| 3438 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
| 3439 | + } |
|
| 3244 | 3440 | |
| 3245 | - if (!empty($context['user']['avatar'])) |
|
| 3246 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
| 3441 | + if (!empty($context['user']['avatar'])) { |
|
| 3442 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
| 3443 | + } |
|
| 3247 | 3444 | |
| 3248 | 3445 | // Figure out how long they've been logged in. |
| 3249 | 3446 | $context['user']['total_time_logged_in'] = array( |
@@ -3251,8 +3448,7 @@ discard block |
||
| 3251 | 3448 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
| 3252 | 3449 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
| 3253 | 3450 | ); |
| 3254 | - } |
|
| 3255 | - else |
|
| 3451 | + } else |
|
| 3256 | 3452 | { |
| 3257 | 3453 | $context['user']['messages'] = 0; |
| 3258 | 3454 | $context['user']['unread_messages'] = 0; |
@@ -3260,12 +3456,14 @@ discard block |
||
| 3260 | 3456 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
| 3261 | 3457 | $context['user']['popup_messages'] = false; |
| 3262 | 3458 | |
| 3263 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
| 3264 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
| 3459 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
| 3460 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
| 3461 | + } |
|
| 3265 | 3462 | |
| 3266 | 3463 | // If we've upgraded recently, go easy on the passwords. |
| 3267 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
| 3268 | - $context['disable_login_hashing'] = true; |
|
| 3464 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
| 3465 | + $context['disable_login_hashing'] = true; |
|
| 3466 | + } |
|
| 3269 | 3467 | } |
| 3270 | 3468 | |
| 3271 | 3469 | // Setup the main menu items. |
@@ -3278,8 +3476,8 @@ discard block |
||
| 3278 | 3476 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
| 3279 | 3477 | |
| 3280 | 3478 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
| 3281 | - if ($context['show_pm_popup']) |
|
| 3282 | - addInlineJavaScript(' |
|
| 3479 | + if ($context['show_pm_popup']) { |
|
| 3480 | + addInlineJavaScript(' |
|
| 3283 | 3481 | jQuery(document).ready(function($) { |
| 3284 | 3482 | new smc_Popup({ |
| 3285 | 3483 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3287,24 +3485,28 @@ discard block |
||
| 3287 | 3485 | icon_class: \'generic_icons mail_new\' |
| 3288 | 3486 | }); |
| 3289 | 3487 | });'); |
| 3488 | + } |
|
| 3290 | 3489 | |
| 3291 | 3490 | // Add a generic "Are you sure?" confirmation message. |
| 3292 | 3491 | addInlineJavaScript(' |
| 3293 | 3492 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
| 3294 | 3493 | |
| 3295 | 3494 | // Now add the capping code for avatars. |
| 3296 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
| 3297 | - addInlineCss(' |
|
| 3495 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
| 3496 | + addInlineCss(' |
|
| 3298 | 3497 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
| 3498 | + } |
|
| 3299 | 3499 | |
| 3300 | 3500 | // Add max image limits |
| 3301 | - if (!empty($modSettings['max_image_width'])) |
|
| 3302 | - addInlineCss(' |
|
| 3501 | + if (!empty($modSettings['max_image_width'])) { |
|
| 3502 | + addInlineCss(' |
|
| 3303 | 3503 | .postarea .bbc_img { max-width: ' . $modSettings['max_image_width'] . 'px; }'); |
| 3504 | + } |
|
| 3304 | 3505 | |
| 3305 | - if (!empty($modSettings['max_image_height'])) |
|
| 3306 | - addInlineCss(' |
|
| 3506 | + if (!empty($modSettings['max_image_height'])) { |
|
| 3507 | + addInlineCss(' |
|
| 3307 | 3508 | .postarea .bbc_img { max-height: ' . $modSettings['max_image_height'] . 'px; }'); |
| 3509 | + } |
|
| 3308 | 3510 | |
| 3309 | 3511 | // This looks weird, but it's because BoardIndex.php references the variable. |
| 3310 | 3512 | $context['common_stats']['latest_member'] = array( |
@@ -3321,11 +3523,13 @@ discard block |
||
| 3321 | 3523 | ); |
| 3322 | 3524 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
| 3323 | 3525 | |
| 3324 | - if (empty($settings['theme_version'])) |
|
| 3325 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
| 3526 | + if (empty($settings['theme_version'])) { |
|
| 3527 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
| 3528 | + } |
|
| 3326 | 3529 | |
| 3327 | - if (!isset($context['page_title'])) |
|
| 3328 | - $context['page_title'] = ''; |
|
| 3530 | + if (!isset($context['page_title'])) { |
|
| 3531 | + $context['page_title'] = ''; |
|
| 3532 | + } |
|
| 3329 | 3533 | |
| 3330 | 3534 | // Set some specific vars. |
| 3331 | 3535 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3335,21 +3539,23 @@ discard block |
||
| 3335 | 3539 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
| 3336 | 3540 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
| 3337 | 3541 | |
| 3338 | - if (!empty($context['meta_keywords'])) |
|
| 3339 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
| 3542 | + if (!empty($context['meta_keywords'])) { |
|
| 3543 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
| 3544 | + } |
|
| 3340 | 3545 | |
| 3341 | - if (!empty($context['canonical_url'])) |
|
| 3342 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
| 3546 | + if (!empty($context['canonical_url'])) { |
|
| 3547 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
| 3548 | + } |
|
| 3343 | 3549 | |
| 3344 | - if (!empty($settings['og_image'])) |
|
| 3345 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
| 3550 | + if (!empty($settings['og_image'])) { |
|
| 3551 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
| 3552 | + } |
|
| 3346 | 3553 | |
| 3347 | 3554 | if (!empty($context['meta_description'])) |
| 3348 | 3555 | { |
| 3349 | 3556 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
| 3350 | 3557 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
| 3351 | - } |
|
| 3352 | - else |
|
| 3558 | + } else |
|
| 3353 | 3559 | { |
| 3354 | 3560 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
| 3355 | 3561 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3374,8 +3580,9 @@ discard block |
||
| 3374 | 3580 | $memory_needed = memoryReturnBytes($needed); |
| 3375 | 3581 | |
| 3376 | 3582 | // should we account for how much is currently being used? |
| 3377 | - if ($in_use) |
|
| 3378 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
| 3583 | + if ($in_use) { |
|
| 3584 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
| 3585 | + } |
|
| 3379 | 3586 | |
| 3380 | 3587 | // if more is needed, request it |
| 3381 | 3588 | if ($memory_current < $memory_needed) |
@@ -3398,8 +3605,9 @@ discard block |
||
| 3398 | 3605 | */ |
| 3399 | 3606 | function memoryReturnBytes($val) |
| 3400 | 3607 | { |
| 3401 | - if (is_integer($val)) |
|
| 3402 | - return $val; |
|
| 3608 | + if (is_integer($val)) { |
|
| 3609 | + return $val; |
|
| 3610 | + } |
|
| 3403 | 3611 | |
| 3404 | 3612 | // Separate the number from the designator |
| 3405 | 3613 | $val = trim($val); |
@@ -3435,10 +3643,11 @@ discard block |
||
| 3435 | 3643 | header('last-modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
| 3436 | 3644 | |
| 3437 | 3645 | // Are we debugging the template/html content? |
| 3438 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
| 3439 | - header('content-type: application/xhtml+xml'); |
|
| 3440 | - elseif (!isset($_REQUEST['xml'])) |
|
| 3441 | - header('content-type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
| 3646 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
| 3647 | + header('content-type: application/xhtml+xml'); |
|
| 3648 | + } elseif (!isset($_REQUEST['xml'])) { |
|
| 3649 | + header('content-type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
| 3650 | + } |
|
| 3442 | 3651 | } |
| 3443 | 3652 | |
| 3444 | 3653 | header('content-type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3447,8 +3656,9 @@ discard block |
||
| 3447 | 3656 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
| 3448 | 3657 | { |
| 3449 | 3658 | $position = array_search('body', $context['template_layers']); |
| 3450 | - if ($position === false) |
|
| 3451 | - $position = array_search('main', $context['template_layers']); |
|
| 3659 | + if ($position === false) { |
|
| 3660 | + $position = array_search('main', $context['template_layers']); |
|
| 3661 | + } |
|
| 3452 | 3662 | |
| 3453 | 3663 | if ($position !== false) |
| 3454 | 3664 | { |
@@ -3476,23 +3686,25 @@ discard block |
||
| 3476 | 3686 | |
| 3477 | 3687 | foreach ($securityFiles as $i => $securityFile) |
| 3478 | 3688 | { |
| 3479 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
| 3480 | - unset($securityFiles[$i]); |
|
| 3689 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
| 3690 | + unset($securityFiles[$i]); |
|
| 3691 | + } |
|
| 3481 | 3692 | } |
| 3482 | 3693 | |
| 3483 | 3694 | // We are already checking so many files...just few more doesn't make any difference! :P |
| 3484 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
| 3485 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
| 3486 | - |
|
| 3487 | - else |
|
| 3488 | - $path = $modSettings['attachmentUploadDir']; |
|
| 3695 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
| 3696 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
| 3697 | + } else { |
|
| 3698 | + $path = $modSettings['attachmentUploadDir']; |
|
| 3699 | + } |
|
| 3489 | 3700 | |
| 3490 | 3701 | secureDirectory($path, true); |
| 3491 | 3702 | secureDirectory($cachedir); |
| 3492 | 3703 | |
| 3493 | 3704 | // If agreement is enabled, at least the english version shall exists |
| 3494 | - if ($modSettings['requireAgreement']) |
|
| 3495 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
| 3705 | + if ($modSettings['requireAgreement']) { |
|
| 3706 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
| 3707 | + } |
|
| 3496 | 3708 | |
| 3497 | 3709 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
| 3498 | 3710 | { |
@@ -3507,18 +3719,21 @@ discard block |
||
| 3507 | 3719 | echo ' |
| 3508 | 3720 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
| 3509 | 3721 | |
| 3510 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
| 3511 | - echo ' |
|
| 3722 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
| 3723 | + echo ' |
|
| 3512 | 3724 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
| 3725 | + } |
|
| 3513 | 3726 | } |
| 3514 | 3727 | |
| 3515 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
| 3516 | - echo ' |
|
| 3728 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
| 3729 | + echo ' |
|
| 3517 | 3730 | <strong>', $txt['cache_writable'], '</strong><br>'; |
| 3731 | + } |
|
| 3518 | 3732 | |
| 3519 | - if (!empty($agreement)) |
|
| 3520 | - echo ' |
|
| 3733 | + if (!empty($agreement)) { |
|
| 3734 | + echo ' |
|
| 3521 | 3735 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
| 3736 | + } |
|
| 3522 | 3737 | |
| 3523 | 3738 | echo ' |
| 3524 | 3739 | </p> |
@@ -3533,16 +3748,18 @@ discard block |
||
| 3533 | 3748 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
| 3534 | 3749 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
| 3535 | 3750 | |
| 3536 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
| 3537 | - echo ' |
|
| 3751 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
| 3752 | + echo ' |
|
| 3538 | 3753 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
| 3754 | + } |
|
| 3539 | 3755 | |
| 3540 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
| 3541 | - echo ' |
|
| 3756 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
| 3757 | + echo ' |
|
| 3542 | 3758 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
| 3543 | - else |
|
| 3544 | - echo ' |
|
| 3759 | + } else { |
|
| 3760 | + echo ' |
|
| 3545 | 3761 | <div>', $txt['your_ban_expires_never'], '</div>'; |
| 3762 | + } |
|
| 3546 | 3763 | |
| 3547 | 3764 | echo ' |
| 3548 | 3765 | </div>'; |
@@ -3558,8 +3775,9 @@ discard block |
||
| 3558 | 3775 | global $forum_copyright, $software_year, $forum_version; |
| 3559 | 3776 | |
| 3560 | 3777 | // Don't display copyright for things like SSI. |
| 3561 | - if (!isset($forum_version) || !isset($software_year)) |
|
| 3562 | - return; |
|
| 3778 | + if (!isset($forum_version) || !isset($software_year)) { |
|
| 3779 | + return; |
|
| 3780 | + } |
|
| 3563 | 3781 | |
| 3564 | 3782 | // Put in the version... |
| 3565 | 3783 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3577,9 +3795,10 @@ discard block |
||
| 3577 | 3795 | $context['load_time'] = round(microtime(true) - $time_start, 3); |
| 3578 | 3796 | $context['load_queries'] = $db_count; |
| 3579 | 3797 | |
| 3580 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
| 3581 | - loadSubTemplate($layer . '_below', true); |
|
| 3582 | -} |
|
| 3798 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
| 3799 | + loadSubTemplate($layer . '_below', true); |
|
| 3800 | + } |
|
| 3801 | + } |
|
| 3583 | 3802 | |
| 3584 | 3803 | /** |
| 3585 | 3804 | * Output the Javascript files |
@@ -3613,8 +3832,7 @@ discard block |
||
| 3613 | 3832 | { |
| 3614 | 3833 | echo ' |
| 3615 | 3834 | var ', $key, ';'; |
| 3616 | - } |
|
| 3617 | - else |
|
| 3835 | + } else |
|
| 3618 | 3836 | { |
| 3619 | 3837 | echo ' |
| 3620 | 3838 | var ', $key, ' = ', $value, ';'; |
@@ -3633,27 +3851,29 @@ discard block |
||
| 3633 | 3851 | foreach ($context['javascript_files'] as $id => $js_file) |
| 3634 | 3852 | { |
| 3635 | 3853 | // Last minute call! allow theme authors to disable single files. |
| 3636 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
| 3637 | - continue; |
|
| 3854 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
| 3855 | + continue; |
|
| 3856 | + } |
|
| 3638 | 3857 | |
| 3639 | 3858 | // By default files don't get minimized unless the file explicitly says so! |
| 3640 | 3859 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
| 3641 | 3860 | { |
| 3642 | - if (!empty($js_file['options']['async'])) |
|
| 3643 | - $toMinify['async'][] = $js_file; |
|
| 3644 | - elseif (!empty($js_file['options']['defer'])) |
|
| 3645 | - $toMinify['defer'][] = $js_file; |
|
| 3646 | - else |
|
| 3647 | - $toMinify['standard'][] = $js_file; |
|
| 3861 | + if (!empty($js_file['options']['async'])) { |
|
| 3862 | + $toMinify['async'][] = $js_file; |
|
| 3863 | + } elseif (!empty($js_file['options']['defer'])) { |
|
| 3864 | + $toMinify['defer'][] = $js_file; |
|
| 3865 | + } else { |
|
| 3866 | + $toMinify['standard'][] = $js_file; |
|
| 3867 | + } |
|
| 3648 | 3868 | |
| 3649 | 3869 | // Grab a random seed. |
| 3650 | - if (!isset($minSeed) && isset($js_file['options']['seed'])) |
|
| 3651 | - $minSeed = $js_file['options']['seed']; |
|
| 3652 | - } |
|
| 3653 | - |
|
| 3654 | - else |
|
| 3655 | - echo ' |
|
| 3870 | + if (!isset($minSeed) && isset($js_file['options']['seed'])) { |
|
| 3871 | + $minSeed = $js_file['options']['seed']; |
|
| 3872 | + } |
|
| 3873 | + } else { |
|
| 3874 | + echo ' |
|
| 3656 | 3875 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async' : '', !empty($js_file['options']['defer']) ? ' defer' : '', '></script>'; |
| 3876 | + } |
|
| 3657 | 3877 | } |
| 3658 | 3878 | |
| 3659 | 3879 | foreach ($toMinify as $js_files) |
@@ -3664,9 +3884,10 @@ discard block |
||
| 3664 | 3884 | |
| 3665 | 3885 | $minSuccessful = array_keys($result) === array('smf_minified'); |
| 3666 | 3886 | |
| 3667 | - foreach ($result as $minFile) |
|
| 3668 | - echo ' |
|
| 3887 | + foreach ($result as $minFile) { |
|
| 3888 | + echo ' |
|
| 3669 | 3889 | <script src="', $minFile['fileUrl'], $minSuccessful && isset($minSeed) ? $minSeed : '', '"', !empty($minFile['options']['async']) ? ' async' : '', !empty($minFile['options']['defer']) ? ' defer' : '', '></script>'; |
| 3890 | + } |
|
| 3670 | 3891 | } |
| 3671 | 3892 | } |
| 3672 | 3893 | } |
@@ -3680,8 +3901,9 @@ discard block |
||
| 3680 | 3901 | <script> |
| 3681 | 3902 | window.addEventListener("DOMContentLoaded", function() {'; |
| 3682 | 3903 | |
| 3683 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
| 3684 | - echo $js_code; |
|
| 3904 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
| 3905 | + echo $js_code; |
|
| 3906 | + } |
|
| 3685 | 3907 | |
| 3686 | 3908 | echo ' |
| 3687 | 3909 | }); |
@@ -3693,8 +3915,9 @@ discard block |
||
| 3693 | 3915 | echo ' |
| 3694 | 3916 | <script>'; |
| 3695 | 3917 | |
| 3696 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
| 3697 | - echo $js_code; |
|
| 3918 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
| 3919 | + echo $js_code; |
|
| 3920 | + } |
|
| 3698 | 3921 | |
| 3699 | 3922 | echo ' |
| 3700 | 3923 | </script>'; |
@@ -3722,23 +3945,26 @@ discard block |
||
| 3722 | 3945 | foreach ($context['css_files'] as $id => $file) |
| 3723 | 3946 | { |
| 3724 | 3947 | // Last minute call! allow theme authors to disable single files. |
| 3725 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
| 3726 | - continue; |
|
| 3948 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
| 3949 | + continue; |
|
| 3950 | + } |
|
| 3727 | 3951 | |
| 3728 | 3952 | // Files are minimized unless they explicitly opt out. |
| 3729 | - if (!isset($file['options']['minimize'])) |
|
| 3730 | - $file['options']['minimize'] = true; |
|
| 3953 | + if (!isset($file['options']['minimize'])) { |
|
| 3954 | + $file['options']['minimize'] = true; |
|
| 3955 | + } |
|
| 3731 | 3956 | |
| 3732 | 3957 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
| 3733 | 3958 | { |
| 3734 | 3959 | $toMinify[] = $file; |
| 3735 | 3960 | |
| 3736 | 3961 | // Grab a random seed. |
| 3737 | - if (!isset($minSeed) && isset($file['options']['seed'])) |
|
| 3738 | - $minSeed = $file['options']['seed']; |
|
| 3962 | + if (!isset($minSeed) && isset($file['options']['seed'])) { |
|
| 3963 | + $minSeed = $file['options']['seed']; |
|
| 3964 | + } |
|
| 3965 | + } else { |
|
| 3966 | + $normal[] = $file['fileUrl']; |
|
| 3739 | 3967 | } |
| 3740 | - else |
|
| 3741 | - $normal[] = $file['fileUrl']; |
|
| 3742 | 3968 | } |
| 3743 | 3969 | |
| 3744 | 3970 | if (!empty($toMinify)) |
@@ -3747,23 +3973,26 @@ discard block |
||
| 3747 | 3973 | |
| 3748 | 3974 | $minSuccessful = array_keys($result) === array('smf_minified'); |
| 3749 | 3975 | |
| 3750 | - foreach ($result as $minFile) |
|
| 3751 | - echo ' |
|
| 3976 | + foreach ($result as $minFile) { |
|
| 3977 | + echo ' |
|
| 3752 | 3978 | <link rel="stylesheet" href="', $minFile['fileUrl'], $minSuccessful && isset($minSeed) ? $minSeed : '', '">'; |
| 3979 | + } |
|
| 3753 | 3980 | } |
| 3754 | 3981 | |
| 3755 | 3982 | // Print the rest after the minified files. |
| 3756 | - if (!empty($normal)) |
|
| 3757 | - foreach ($normal as $nf) |
|
| 3983 | + if (!empty($normal)) { |
|
| 3984 | + foreach ($normal as $nf) |
|
| 3758 | 3985 | echo ' |
| 3759 | 3986 | <link rel="stylesheet" href="', $nf ,'">'; |
| 3987 | + } |
|
| 3760 | 3988 | |
| 3761 | 3989 | if ($db_show_debug === true) |
| 3762 | 3990 | { |
| 3763 | 3991 | // Try to keep only what's useful. |
| 3764 | 3992 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
| 3765 | - foreach ($context['css_files'] as $file) |
|
| 3766 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
| 3993 | + foreach ($context['css_files'] as $file) { |
|
| 3994 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
| 3995 | + } |
|
| 3767 | 3996 | } |
| 3768 | 3997 | |
| 3769 | 3998 | if (!empty($context['css_header'])) |
@@ -3771,9 +4000,10 @@ discard block |
||
| 3771 | 4000 | echo ' |
| 3772 | 4001 | <style>'; |
| 3773 | 4002 | |
| 3774 | - foreach ($context['css_header'] as $css) |
|
| 3775 | - echo $css .' |
|
| 4003 | + foreach ($context['css_header'] as $css) { |
|
| 4004 | + echo $css .' |
|
| 3776 | 4005 | '; |
| 4006 | + } |
|
| 3777 | 4007 | |
| 3778 | 4008 | echo' |
| 3779 | 4009 | </style>'; |
@@ -3796,8 +4026,9 @@ discard block |
||
| 3796 | 4026 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
| 3797 | 4027 | $data = is_array($data) ? $data : array(); |
| 3798 | 4028 | |
| 3799 | - if (empty($type) || empty($data)) |
|
| 3800 | - return $data; |
|
| 4029 | + if (empty($type) || empty($data)) { |
|
| 4030 | + return $data; |
|
| 4031 | + } |
|
| 3801 | 4032 | |
| 3802 | 4033 | // Different pages include different files, so we use a hash to label the different combinations |
| 3803 | 4034 | $hash = md5(implode(' ', array_map(function($file) { return $file['filePath'] . (int) @filesize($file['filePath']) . (int) @filemtime($file['filePath']); }, $data))); |
@@ -3806,13 +4037,14 @@ discard block |
||
| 3806 | 4037 | list($toCache, $async, $defer) = array_pad((array) cache_get_data('minimized_' . $settings['theme_id'] . '_' . $type . '_' . $hash, 86400), 3, null); |
| 3807 | 4038 | |
| 3808 | 4039 | // Already done? |
| 3809 | - if (!empty($toCache)) |
|
| 3810 | - return array('smf_minified' => array( |
|
| 4040 | + if (!empty($toCache)) { |
|
| 4041 | + return array('smf_minified' => array( |
|
| 3811 | 4042 | 'fileUrl' => $settings['theme_url'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/' . basename($toCache), |
| 3812 | 4043 | 'filePath' => $toCache, |
| 3813 | 4044 | 'fileName' => basename($toCache), |
| 3814 | 4045 | 'options' => array('async' => !empty($async), 'defer' => !empty($defer)), |
| 3815 | 4046 | )); |
| 4047 | + } |
|
| 3816 | 4048 | |
| 3817 | 4049 | |
| 3818 | 4050 | // No namespaces, sorry! |
@@ -3842,9 +4074,9 @@ discard block |
||
| 3842 | 4074 | |
| 3843 | 4075 | foreach ($data as $id => $file) |
| 3844 | 4076 | { |
| 3845 | - if (empty($file['filePath'])) |
|
| 3846 | - $toAdd = false; |
|
| 3847 | - else |
|
| 4077 | + if (empty($file['filePath'])) { |
|
| 4078 | + $toAdd = false; |
|
| 4079 | + } else |
|
| 3848 | 4080 | { |
| 3849 | 4081 | $seed = isset($file['options']['seed']) ? $file['options']['seed'] : ''; |
| 3850 | 4082 | $tempFile = str_replace($seed, '', $file['filePath']); |
@@ -3852,12 +4084,14 @@ discard block |
||
| 3852 | 4084 | } |
| 3853 | 4085 | |
| 3854 | 4086 | // A minified script should only be loaded asynchronously if all its components wanted to be. |
| 3855 | - if (empty($file['options']['async'])) |
|
| 3856 | - $async = false; |
|
| 4087 | + if (empty($file['options']['async'])) { |
|
| 4088 | + $async = false; |
|
| 4089 | + } |
|
| 3857 | 4090 | |
| 3858 | 4091 | // A minified script should only be deferred if all its components wanted to be. |
| 3859 | - if (empty($file['options']['defer'])) |
|
| 3860 | - $defer = false; |
|
| 4092 | + if (empty($file['options']['defer'])) { |
|
| 4093 | + $defer = false; |
|
| 4094 | + } |
|
| 3861 | 4095 | |
| 3862 | 4096 | // The file couldn't be located so it won't be added. Log this error. |
| 3863 | 4097 | if (empty($toAdd)) |
@@ -3923,12 +4157,14 @@ discard block |
||
| 3923 | 4157 | foreach (glob(rtrim($theme['dir'], '/') . '/' . ($type == 'css' ? 'css' : 'scripts') . '/minified*.' . $type) as $filename) |
| 3924 | 4158 | { |
| 3925 | 4159 | // Remove the cache entry |
| 3926 | - if (preg_match('~([a-zA-Z0-9]+)\.' . $type . '$~', $filename, $matches)) |
|
| 3927 | - cache_put_data('minimized_' . $theme['id'] . '_' . $type . '_' . $matches[1], null); |
|
| 4160 | + if (preg_match('~([a-zA-Z0-9]+)\.' . $type . '$~', $filename, $matches)) { |
|
| 4161 | + cache_put_data('minimized_' . $theme['id'] . '_' . $type . '_' . $matches[1], null); |
|
| 4162 | + } |
|
| 3928 | 4163 | |
| 3929 | 4164 | // Try to delete the file. Add it to our error list if it fails. |
| 3930 | - if (!@unlink($filename)) |
|
| 3931 | - $not_deleted[] = $filename; |
|
| 4165 | + if (!@unlink($filename)) { |
|
| 4166 | + $not_deleted[] = $filename; |
|
| 4167 | + } |
|
| 3932 | 4168 | } |
| 3933 | 4169 | } |
| 3934 | 4170 | } |
@@ -3960,8 +4196,9 @@ discard block |
||
| 3960 | 4196 | global $modSettings, $smcFunc; |
| 3961 | 4197 | |
| 3962 | 4198 | // Just make up a nice hash... |
| 3963 | - if ($new) |
|
| 3964 | - return sha1(md5($filename . time()) . mt_rand()); |
|
| 4199 | + if ($new) { |
|
| 4200 | + return sha1(md5($filename . time()) . mt_rand()); |
|
| 4201 | + } |
|
| 3965 | 4202 | |
| 3966 | 4203 | // Just make sure that attachment id is only a int |
| 3967 | 4204 | $attachment_id = (int) $attachment_id; |
@@ -3978,23 +4215,25 @@ discard block |
||
| 3978 | 4215 | 'id_attach' => $attachment_id, |
| 3979 | 4216 | )); |
| 3980 | 4217 | |
| 3981 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
| 3982 | - return false; |
|
| 4218 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
| 4219 | + return false; |
|
| 4220 | + } |
|
| 3983 | 4221 | |
| 3984 | 4222 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
| 3985 | 4223 | $smcFunc['db_free_result']($request); |
| 3986 | 4224 | } |
| 3987 | 4225 | |
| 3988 | 4226 | // Still no hash? mmm... |
| 3989 | - if (empty($file_hash)) |
|
| 3990 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
| 4227 | + if (empty($file_hash)) { |
|
| 4228 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
| 4229 | + } |
|
| 3991 | 4230 | |
| 3992 | 4231 | // Are we using multiple directories? |
| 3993 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
| 3994 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
| 3995 | - |
|
| 3996 | - else |
|
| 3997 | - $path = $modSettings['attachmentUploadDir']; |
|
| 4232 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
| 4233 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
| 4234 | + } else { |
|
| 4235 | + $path = $modSettings['attachmentUploadDir']; |
|
| 4236 | + } |
|
| 3998 | 4237 | |
| 3999 | 4238 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
| 4000 | 4239 | } |
@@ -4009,8 +4248,9 @@ discard block |
||
| 4009 | 4248 | function ip2range($fullip) |
| 4010 | 4249 | { |
| 4011 | 4250 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
| 4012 | - if ($fullip == 'unknown') |
|
| 4013 | - $fullip = '255.255.255.255'; |
|
| 4251 | + if ($fullip == 'unknown') { |
|
| 4252 | + $fullip = '255.255.255.255'; |
|
| 4253 | + } |
|
| 4014 | 4254 | |
| 4015 | 4255 | $ip_parts = explode('-', $fullip); |
| 4016 | 4256 | $ip_array = array(); |
@@ -4034,10 +4274,11 @@ discard block |
||
| 4034 | 4274 | $ip_array['low'] = $ip_parts[0]; |
| 4035 | 4275 | $ip_array['high'] = $ip_parts[1]; |
| 4036 | 4276 | return $ip_array; |
| 4037 | - } |
|
| 4038 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
| 4277 | + } elseif (count($ip_parts) == 2) { |
|
| 4278 | + // if ip 22.22.*-22.22.* |
|
| 4039 | 4279 | { |
| 4040 | 4280 | $valid_low = isValidIP($ip_parts[0]); |
| 4281 | + } |
|
| 4041 | 4282 | $valid_high = isValidIP($ip_parts[1]); |
| 4042 | 4283 | $count = 0; |
| 4043 | 4284 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -4052,7 +4293,9 @@ discard block |
||
| 4052 | 4293 | $ip_parts[0] .= $mode . $min; |
| 4053 | 4294 | $valid_low = isValidIP($ip_parts[0]); |
| 4054 | 4295 | $count++; |
| 4055 | - if ($count > 9) break; |
|
| 4296 | + if ($count > 9) { |
|
| 4297 | + break; |
|
| 4298 | + } |
|
| 4056 | 4299 | } |
| 4057 | 4300 | } |
| 4058 | 4301 | |
@@ -4066,7 +4309,9 @@ discard block |
||
| 4066 | 4309 | $ip_parts[1] .= $mode . $max; |
| 4067 | 4310 | $valid_high = isValidIP($ip_parts[1]); |
| 4068 | 4311 | $count++; |
| 4069 | - if ($count > 9) break; |
|
| 4312 | + if ($count > 9) { |
|
| 4313 | + break; |
|
| 4314 | + } |
|
| 4070 | 4315 | } |
| 4071 | 4316 | } |
| 4072 | 4317 | |
@@ -4090,46 +4335,54 @@ discard block |
||
| 4090 | 4335 | { |
| 4091 | 4336 | global $modSettings; |
| 4092 | 4337 | |
| 4093 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
| 4094 | - return $host; |
|
| 4338 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
| 4339 | + return $host; |
|
| 4340 | + } |
|
| 4095 | 4341 | $t = microtime(); |
| 4096 | 4342 | |
| 4097 | 4343 | // Try the Linux host command, perhaps? |
| 4098 | 4344 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
| 4099 | 4345 | { |
| 4100 | - if (!isset($modSettings['host_to_dis'])) |
|
| 4101 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
| 4102 | - else |
|
| 4103 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
| 4346 | + if (!isset($modSettings['host_to_dis'])) { |
|
| 4347 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
| 4348 | + } else { |
|
| 4349 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
| 4350 | + } |
|
| 4104 | 4351 | |
| 4105 | 4352 | // Did host say it didn't find anything? |
| 4106 | - if (strpos($test, 'not found') !== false) |
|
| 4107 | - $host = ''; |
|
| 4353 | + if (strpos($test, 'not found') !== false) { |
|
| 4354 | + $host = ''; |
|
| 4355 | + } |
|
| 4108 | 4356 | // Invalid server option? |
| 4109 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
| 4110 | - updateSettings(array('host_to_dis' => 1)); |
|
| 4357 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
| 4358 | + updateSettings(array('host_to_dis' => 1)); |
|
| 4359 | + } |
|
| 4111 | 4360 | // Maybe it found something, after all? |
| 4112 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
| 4113 | - $host = $match[1]; |
|
| 4361 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
| 4362 | + $host = $match[1]; |
|
| 4363 | + } |
|
| 4114 | 4364 | } |
| 4115 | 4365 | |
| 4116 | 4366 | // This is nslookup; usually only Windows, but possibly some Unix? |
| 4117 | 4367 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
| 4118 | 4368 | { |
| 4119 | 4369 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
| 4120 | - if (strpos($test, 'Non-existent domain') !== false) |
|
| 4121 | - $host = ''; |
|
| 4122 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
| 4123 | - $host = $match[1]; |
|
| 4370 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
| 4371 | + $host = ''; |
|
| 4372 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
| 4373 | + $host = $match[1]; |
|
| 4374 | + } |
|
| 4124 | 4375 | } |
| 4125 | 4376 | |
| 4126 | 4377 | // This is the last try :/. |
| 4127 | - if (!isset($host) || $host === false) |
|
| 4128 | - $host = @gethostbyaddr($ip); |
|
| 4378 | + if (!isset($host) || $host === false) { |
|
| 4379 | + $host = @gethostbyaddr($ip); |
|
| 4380 | + } |
|
| 4129 | 4381 | |
| 4130 | 4382 | // It took a long time, so let's cache it! |
| 4131 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
| 4132 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
| 4383 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
| 4384 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
| 4385 | + } |
|
| 4133 | 4386 | |
| 4134 | 4387 | return $host; |
| 4135 | 4388 | } |
@@ -4165,20 +4418,21 @@ discard block |
||
| 4165 | 4418 | { |
| 4166 | 4419 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
| 4167 | 4420 | $total = 0; |
| 4168 | - for ($i = 0; $i < $max_chars; $i++) |
|
| 4169 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
| 4421 | + for ($i = 0; $i < $max_chars; $i++) { |
|
| 4422 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
| 4423 | + } |
|
| 4170 | 4424 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
| 4171 | 4425 | } |
| 4172 | 4426 | } |
| 4173 | 4427 | return array_unique($returned_ints); |
| 4174 | - } |
|
| 4175 | - else |
|
| 4428 | + } else |
|
| 4176 | 4429 | { |
| 4177 | 4430 | // Trim characters before and after and add slashes for database insertion. |
| 4178 | 4431 | $returned_words = array(); |
| 4179 | - foreach ($words as $word) |
|
| 4180 | - if (($word = trim($word, '-_\'')) !== '') |
|
| 4432 | + foreach ($words as $word) { |
|
| 4433 | + if (($word = trim($word, '-_\'')) !== '') |
|
| 4181 | 4434 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
| 4435 | + } |
|
| 4182 | 4436 | |
| 4183 | 4437 | // Filter out all words that occur more than once. |
| 4184 | 4438 | return array_unique($returned_words); |
@@ -4200,16 +4454,18 @@ discard block |
||
| 4200 | 4454 | global $settings, $txt; |
| 4201 | 4455 | |
| 4202 | 4456 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
| 4203 | - if (function_exists('template_create_button') && !$force_use) |
|
| 4204 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
| 4457 | + if (function_exists('template_create_button') && !$force_use) { |
|
| 4458 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
| 4459 | + } |
|
| 4205 | 4460 | |
| 4206 | - if (!$settings['use_image_buttons']) |
|
| 4207 | - return $txt[$alt]; |
|
| 4208 | - elseif (!empty($settings['use_buttons'])) |
|
| 4209 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
| 4210 | - else |
|
| 4211 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
| 4212 | -} |
|
| 4461 | + if (!$settings['use_image_buttons']) { |
|
| 4462 | + return $txt[$alt]; |
|
| 4463 | + } elseif (!empty($settings['use_buttons'])) { |
|
| 4464 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
| 4465 | + } else { |
|
| 4466 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
| 4467 | + } |
|
| 4468 | + } |
|
| 4213 | 4469 | |
| 4214 | 4470 | /** |
| 4215 | 4471 | * Sets up all of the top menu buttons |
@@ -4252,9 +4508,10 @@ discard block |
||
| 4252 | 4508 | var user_menus = new smc_PopupMenu(); |
| 4253 | 4509 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
| 4254 | 4510 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
| 4255 | - if ($context['allow_pm']) |
|
| 4256 | - addInlineJavaScript(' |
|
| 4511 | + if ($context['allow_pm']) { |
|
| 4512 | + addInlineJavaScript(' |
|
| 4257 | 4513 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
| 4514 | + } |
|
| 4258 | 4515 | |
| 4259 | 4516 | if (!empty($modSettings['enable_ajax_alerts'])) |
| 4260 | 4517 | { |
@@ -4414,88 +4671,96 @@ discard block |
||
| 4414 | 4671 | |
| 4415 | 4672 | // Now we put the buttons in the context so the theme can use them. |
| 4416 | 4673 | $menu_buttons = array(); |
| 4417 | - foreach ($buttons as $act => $button) |
|
| 4418 | - if (!empty($button['show'])) |
|
| 4674 | + foreach ($buttons as $act => $button) { |
|
| 4675 | + if (!empty($button['show'])) |
|
| 4419 | 4676 | { |
| 4420 | 4677 | $button['active_button'] = false; |
| 4678 | + } |
|
| 4421 | 4679 | |
| 4422 | 4680 | // This button needs some action. |
| 4423 | - if (isset($button['action_hook'])) |
|
| 4424 | - $needs_action_hook = true; |
|
| 4681 | + if (isset($button['action_hook'])) { |
|
| 4682 | + $needs_action_hook = true; |
|
| 4683 | + } |
|
| 4425 | 4684 | |
| 4426 | 4685 | // Make sure the last button truly is the last button. |
| 4427 | 4686 | if (!empty($button['is_last'])) |
| 4428 | 4687 | { |
| 4429 | - if (isset($last_button)) |
|
| 4430 | - unset($menu_buttons[$last_button]['is_last']); |
|
| 4688 | + if (isset($last_button)) { |
|
| 4689 | + unset($menu_buttons[$last_button]['is_last']); |
|
| 4690 | + } |
|
| 4431 | 4691 | $last_button = $act; |
| 4432 | 4692 | } |
| 4433 | 4693 | |
| 4434 | 4694 | // Go through the sub buttons if there are any. |
| 4435 | - if (!empty($button['sub_buttons'])) |
|
| 4436 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
| 4695 | + if (!empty($button['sub_buttons'])) { |
|
| 4696 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
| 4437 | 4697 | { |
| 4438 | 4698 | if (empty($subbutton['show'])) |
| 4439 | 4699 | unset($button['sub_buttons'][$key]); |
| 4700 | + } |
|
| 4440 | 4701 | |
| 4441 | 4702 | // 2nd level sub buttons next... |
| 4442 | 4703 | if (!empty($subbutton['sub_buttons'])) |
| 4443 | 4704 | { |
| 4444 | 4705 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
| 4445 | 4706 | { |
| 4446 | - if (empty($sub_button2['show'])) |
|
| 4447 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
| 4707 | + if (empty($sub_button2['show'])) { |
|
| 4708 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
| 4709 | + } |
|
| 4448 | 4710 | } |
| 4449 | 4711 | } |
| 4450 | 4712 | } |
| 4451 | 4713 | |
| 4452 | 4714 | // Does this button have its own icon? |
| 4453 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
| 4454 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4455 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
| 4456 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4457 | - elseif (isset($button['icon'])) |
|
| 4458 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
| 4459 | - else |
|
| 4460 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
| 4715 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
| 4716 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4717 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
| 4718 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4719 | + } elseif (isset($button['icon'])) { |
|
| 4720 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
| 4721 | + } else { |
|
| 4722 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
| 4723 | + } |
|
| 4461 | 4724 | |
| 4462 | 4725 | $menu_buttons[$act] = $button; |
| 4463 | 4726 | } |
| 4464 | 4727 | |
| 4465 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
| 4466 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
| 4728 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
| 4729 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
| 4730 | + } |
|
| 4467 | 4731 | } |
| 4468 | 4732 | |
| 4469 | 4733 | $context['menu_buttons'] = $menu_buttons; |
| 4470 | 4734 | |
| 4471 | 4735 | // Logging out requires the session id in the url. |
| 4472 | - if (isset($context['menu_buttons']['logout'])) |
|
| 4473 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
| 4736 | + if (isset($context['menu_buttons']['logout'])) { |
|
| 4737 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
| 4738 | + } |
|
| 4474 | 4739 | |
| 4475 | 4740 | // Figure out which action we are doing so we can set the active tab. |
| 4476 | 4741 | // Default to home. |
| 4477 | 4742 | $current_action = 'home'; |
| 4478 | 4743 | |
| 4479 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
| 4480 | - $current_action = $context['current_action']; |
|
| 4481 | - elseif ($context['current_action'] == 'search2') |
|
| 4482 | - $current_action = 'search'; |
|
| 4483 | - elseif ($context['current_action'] == 'theme') |
|
| 4484 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
| 4485 | - elseif ($context['current_action'] == 'register2') |
|
| 4486 | - $current_action = 'register'; |
|
| 4487 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
| 4488 | - $current_action = 'login'; |
|
| 4489 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
| 4490 | - $current_action = 'moderate'; |
|
| 4744 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
| 4745 | + $current_action = $context['current_action']; |
|
| 4746 | + } elseif ($context['current_action'] == 'search2') { |
|
| 4747 | + $current_action = 'search'; |
|
| 4748 | + } elseif ($context['current_action'] == 'theme') { |
|
| 4749 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
| 4750 | + } elseif ($context['current_action'] == 'register2') { |
|
| 4751 | + $current_action = 'register'; |
|
| 4752 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
| 4753 | + $current_action = 'login'; |
|
| 4754 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
| 4755 | + $current_action = 'moderate'; |
|
| 4756 | + } |
|
| 4491 | 4757 | |
| 4492 | 4758 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
| 4493 | 4759 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
| 4494 | 4760 | { |
| 4495 | 4761 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
| 4496 | 4762 | $context[$current_action] = true; |
| 4497 | - } |
|
| 4498 | - elseif ($context['current_action'] == 'pm') |
|
| 4763 | + } elseif ($context['current_action'] == 'pm') |
|
| 4499 | 4764 | { |
| 4500 | 4765 | $current_action = 'self_pm'; |
| 4501 | 4766 | $context['self_pm'] = true; |
@@ -4552,12 +4817,14 @@ discard block |
||
| 4552 | 4817 | } |
| 4553 | 4818 | |
| 4554 | 4819 | // Not all actions are simple. |
| 4555 | - if (!empty($needs_action_hook)) |
|
| 4556 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
| 4820 | + if (!empty($needs_action_hook)) { |
|
| 4821 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
| 4822 | + } |
|
| 4557 | 4823 | |
| 4558 | - if (isset($context['menu_buttons'][$current_action])) |
|
| 4559 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
| 4560 | -} |
|
| 4824 | + if (isset($context['menu_buttons'][$current_action])) { |
|
| 4825 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
| 4826 | + } |
|
| 4827 | + } |
|
| 4561 | 4828 | |
| 4562 | 4829 | /** |
| 4563 | 4830 | * Generate a random seed and ensure it's stored in settings. |
@@ -4581,30 +4848,35 @@ discard block |
||
| 4581 | 4848 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
| 4582 | 4849 | global $context, $txt; |
| 4583 | 4850 | |
| 4584 | - if ($db_show_debug === true) |
|
| 4585 | - $context['debug']['hooks'][] = $hook; |
|
| 4851 | + if ($db_show_debug === true) { |
|
| 4852 | + $context['debug']['hooks'][] = $hook; |
|
| 4853 | + } |
|
| 4586 | 4854 | |
| 4587 | 4855 | // Need to have some control. |
| 4588 | - if (!isset($context['instances'])) |
|
| 4589 | - $context['instances'] = array(); |
|
| 4856 | + if (!isset($context['instances'])) { |
|
| 4857 | + $context['instances'] = array(); |
|
| 4858 | + } |
|
| 4590 | 4859 | |
| 4591 | 4860 | $results = array(); |
| 4592 | - if (empty($modSettings[$hook])) |
|
| 4593 | - return $results; |
|
| 4861 | + if (empty($modSettings[$hook])) { |
|
| 4862 | + return $results; |
|
| 4863 | + } |
|
| 4594 | 4864 | |
| 4595 | 4865 | $functions = explode(',', $modSettings[$hook]); |
| 4596 | 4866 | // Loop through each function. |
| 4597 | 4867 | foreach ($functions as $function) |
| 4598 | 4868 | { |
| 4599 | 4869 | // Hook has been marked as "disabled". Skip it! |
| 4600 | - if (strpos($function, '!') !== false) |
|
| 4601 | - continue; |
|
| 4870 | + if (strpos($function, '!') !== false) { |
|
| 4871 | + continue; |
|
| 4872 | + } |
|
| 4602 | 4873 | |
| 4603 | 4874 | $call = call_helper($function, true); |
| 4604 | 4875 | |
| 4605 | 4876 | // Is it valid? |
| 4606 | - if (!empty($call)) |
|
| 4607 | - $results[$function] = call_user_func_array($call, $parameters); |
|
| 4877 | + if (!empty($call)) { |
|
| 4878 | + $results[$function] = call_user_func_array($call, $parameters); |
|
| 4879 | + } |
|
| 4608 | 4880 | |
| 4609 | 4881 | // Whatever it was suppose to call, it failed :( |
| 4610 | 4882 | elseif (!empty($function)) |
@@ -4620,8 +4892,9 @@ discard block |
||
| 4620 | 4892 | } |
| 4621 | 4893 | |
| 4622 | 4894 | // "Assume" the file resides on $boarddir somewhere... |
| 4623 | - else |
|
| 4624 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
| 4895 | + else { |
|
| 4896 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
| 4897 | + } |
|
| 4625 | 4898 | } |
| 4626 | 4899 | } |
| 4627 | 4900 | |
@@ -4643,12 +4916,14 @@ discard block |
||
| 4643 | 4916 | global $smcFunc, $modSettings; |
| 4644 | 4917 | |
| 4645 | 4918 | // Any objects? |
| 4646 | - if ($object) |
|
| 4647 | - $function = $function . '#'; |
|
| 4919 | + if ($object) { |
|
| 4920 | + $function = $function . '#'; |
|
| 4921 | + } |
|
| 4648 | 4922 | |
| 4649 | 4923 | // Any files to load? |
| 4650 | - if (!empty($file) && is_string($file)) |
|
| 4651 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
| 4924 | + if (!empty($file) && is_string($file)) { |
|
| 4925 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
| 4926 | + } |
|
| 4652 | 4927 | |
| 4653 | 4928 | // Get the correct string. |
| 4654 | 4929 | $integration_call = $function; |
@@ -4670,13 +4945,14 @@ discard block |
||
| 4670 | 4945 | if (!empty($current_functions)) |
| 4671 | 4946 | { |
| 4672 | 4947 | $current_functions = explode(',', $current_functions); |
| 4673 | - if (in_array($integration_call, $current_functions)) |
|
| 4674 | - return; |
|
| 4948 | + if (in_array($integration_call, $current_functions)) { |
|
| 4949 | + return; |
|
| 4950 | + } |
|
| 4675 | 4951 | |
| 4676 | 4952 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
| 4953 | + } else { |
|
| 4954 | + $permanent_functions = array($integration_call); |
|
| 4677 | 4955 | } |
| 4678 | - else |
|
| 4679 | - $permanent_functions = array($integration_call); |
|
| 4680 | 4956 | |
| 4681 | 4957 | updateSettings(array($hook => implode(',', $permanent_functions))); |
| 4682 | 4958 | } |
@@ -4685,8 +4961,9 @@ discard block |
||
| 4685 | 4961 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
| 4686 | 4962 | |
| 4687 | 4963 | // Do nothing, if it's already there. |
| 4688 | - if (in_array($integration_call, $functions)) |
|
| 4689 | - return; |
|
| 4964 | + if (in_array($integration_call, $functions)) { |
|
| 4965 | + return; |
|
| 4966 | + } |
|
| 4690 | 4967 | |
| 4691 | 4968 | $functions[] = $integration_call; |
| 4692 | 4969 | $modSettings[$hook] = implode(',', $functions); |
@@ -4709,12 +4986,14 @@ discard block |
||
| 4709 | 4986 | global $smcFunc, $modSettings; |
| 4710 | 4987 | |
| 4711 | 4988 | // Any objects? |
| 4712 | - if ($object) |
|
| 4713 | - $function = $function . '#'; |
|
| 4989 | + if ($object) { |
|
| 4990 | + $function = $function . '#'; |
|
| 4991 | + } |
|
| 4714 | 4992 | |
| 4715 | 4993 | // Any files to load? |
| 4716 | - if (!empty($file) && is_string($file)) |
|
| 4717 | - $function = $file . '|' . $function; |
|
| 4994 | + if (!empty($file) && is_string($file)) { |
|
| 4995 | + $function = $file . '|' . $function; |
|
| 4996 | + } |
|
| 4718 | 4997 | |
| 4719 | 4998 | // Get the correct string. |
| 4720 | 4999 | $integration_call = $function; |
@@ -4735,16 +5014,18 @@ discard block |
||
| 4735 | 5014 | { |
| 4736 | 5015 | $current_functions = explode(',', $current_functions); |
| 4737 | 5016 | |
| 4738 | - if (in_array($integration_call, $current_functions)) |
|
| 4739 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
| 5017 | + if (in_array($integration_call, $current_functions)) { |
|
| 5018 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
| 5019 | + } |
|
| 4740 | 5020 | } |
| 4741 | 5021 | |
| 4742 | 5022 | // Turn the function list into something usable. |
| 4743 | 5023 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
| 4744 | 5024 | |
| 4745 | 5025 | // You can only remove it if it's available. |
| 4746 | - if (!in_array($integration_call, $functions)) |
|
| 4747 | - return; |
|
| 5026 | + if (!in_array($integration_call, $functions)) { |
|
| 5027 | + return; |
|
| 5028 | + } |
|
| 4748 | 5029 | |
| 4749 | 5030 | $functions = array_diff($functions, array($integration_call)); |
| 4750 | 5031 | $modSettings[$hook] = implode(',', $functions); |
@@ -4765,17 +5046,20 @@ discard block |
||
| 4765 | 5046 | global $context, $smcFunc, $txt, $db_show_debug; |
| 4766 | 5047 | |
| 4767 | 5048 | // Really? |
| 4768 | - if (empty($string)) |
|
| 4769 | - return false; |
|
| 5049 | + if (empty($string)) { |
|
| 5050 | + return false; |
|
| 5051 | + } |
|
| 4770 | 5052 | |
| 4771 | 5053 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
| 4772 | 5054 | // A closure? should be a callable one. |
| 4773 | - if (is_array($string) || $string instanceof Closure) |
|
| 4774 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
| 5055 | + if (is_array($string) || $string instanceof Closure) { |
|
| 5056 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
| 5057 | + } |
|
| 4775 | 5058 | |
| 4776 | 5059 | // No full objects, sorry! pass a method or a property instead! |
| 4777 | - if (is_object($string)) |
|
| 4778 | - return false; |
|
| 5060 | + if (is_object($string)) { |
|
| 5061 | + return false; |
|
| 5062 | + } |
|
| 4779 | 5063 | |
| 4780 | 5064 | // Stay vitaminized my friends... |
| 4781 | 5065 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4784,8 +5068,9 @@ discard block |
||
| 4784 | 5068 | $string = load_file($string); |
| 4785 | 5069 | |
| 4786 | 5070 | // Loaded file failed |
| 4787 | - if (empty($string)) |
|
| 4788 | - return false; |
|
| 5071 | + if (empty($string)) { |
|
| 5072 | + return false; |
|
| 5073 | + } |
|
| 4789 | 5074 | |
| 4790 | 5075 | // Found a method. |
| 4791 | 5076 | if (strpos($string, '::') !== false) |
@@ -4806,8 +5091,9 @@ discard block |
||
| 4806 | 5091 | // Add another one to the list. |
| 4807 | 5092 | if ($db_show_debug === true) |
| 4808 | 5093 | { |
| 4809 | - if (!isset($context['debug']['instances'])) |
|
| 4810 | - $context['debug']['instances'] = array(); |
|
| 5094 | + if (!isset($context['debug']['instances'])) { |
|
| 5095 | + $context['debug']['instances'] = array(); |
|
| 5096 | + } |
|
| 4811 | 5097 | |
| 4812 | 5098 | $context['debug']['instances'][$class] = $class; |
| 4813 | 5099 | } |
@@ -4817,13 +5103,15 @@ discard block |
||
| 4817 | 5103 | } |
| 4818 | 5104 | |
| 4819 | 5105 | // Right then. This is a call to a static method. |
| 4820 | - else |
|
| 4821 | - $func = array($class, $method); |
|
| 5106 | + else { |
|
| 5107 | + $func = array($class, $method); |
|
| 5108 | + } |
|
| 4822 | 5109 | } |
| 4823 | 5110 | |
| 4824 | 5111 | // Nope! just a plain regular function. |
| 4825 | - else |
|
| 4826 | - $func = $string; |
|
| 5112 | + else { |
|
| 5113 | + $func = $string; |
|
| 5114 | + } |
|
| 4827 | 5115 | |
| 4828 | 5116 | // Right, we got what we need, time to do some checks. |
| 4829 | 5117 | if (!is_callable($func, false, $callable_name)) |
@@ -4839,17 +5127,18 @@ discard block |
||
| 4839 | 5127 | else |
| 4840 | 5128 | { |
| 4841 | 5129 | // What are we gonna do about it? |
| 4842 | - if ($return) |
|
| 4843 | - return $func; |
|
| 5130 | + if ($return) { |
|
| 5131 | + return $func; |
|
| 5132 | + } |
|
| 4844 | 5133 | |
| 4845 | 5134 | // If this is a plain function, avoid the heat of calling call_user_func(). |
| 4846 | 5135 | else |
| 4847 | 5136 | { |
| 4848 | - if (is_array($func)) |
|
| 4849 | - call_user_func($func); |
|
| 4850 | - |
|
| 4851 | - else |
|
| 4852 | - $func(); |
|
| 5137 | + if (is_array($func)) { |
|
| 5138 | + call_user_func($func); |
|
| 5139 | + } else { |
|
| 5140 | + $func(); |
|
| 5141 | + } |
|
| 4853 | 5142 | } |
| 4854 | 5143 | } |
| 4855 | 5144 | } |
@@ -4866,31 +5155,34 @@ discard block |
||
| 4866 | 5155 | { |
| 4867 | 5156 | global $sourcedir, $txt, $boarddir, $settings; |
| 4868 | 5157 | |
| 4869 | - if (empty($string)) |
|
| 4870 | - return false; |
|
| 5158 | + if (empty($string)) { |
|
| 5159 | + return false; |
|
| 5160 | + } |
|
| 4871 | 5161 | |
| 4872 | 5162 | if (strpos($string, '|') !== false) |
| 4873 | 5163 | { |
| 4874 | 5164 | list ($file, $string) = explode('|', $string); |
| 4875 | 5165 | |
| 4876 | 5166 | // Match the wildcards to their regular vars. |
| 4877 | - if (empty($settings['theme_dir'])) |
|
| 4878 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
| 4879 | - |
|
| 4880 | - else |
|
| 4881 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
| 5167 | + if (empty($settings['theme_dir'])) { |
|
| 5168 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
| 5169 | + } else { |
|
| 5170 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
| 5171 | + } |
|
| 4882 | 5172 | |
| 4883 | 5173 | // Load the file if it can be loaded. |
| 4884 | - if (file_exists($absPath)) |
|
| 4885 | - require_once($absPath); |
|
| 5174 | + if (file_exists($absPath)) { |
|
| 5175 | + require_once($absPath); |
|
| 5176 | + } |
|
| 4886 | 5177 | |
| 4887 | 5178 | // No? try a fallback to $sourcedir |
| 4888 | 5179 | else |
| 4889 | 5180 | { |
| 4890 | 5181 | $absPath = $sourcedir .'/'. $file; |
| 4891 | 5182 | |
| 4892 | - if (file_exists($absPath)) |
|
| 4893 | - require_once($absPath); |
|
| 5183 | + if (file_exists($absPath)) { |
|
| 5184 | + require_once($absPath); |
|
| 5185 | + } |
|
| 4894 | 5186 | |
| 4895 | 5187 | // Sorry, can't do much for you at this point. |
| 4896 | 5188 | else |
@@ -4929,8 +5221,9 @@ discard block |
||
| 4929 | 5221 | preg_match('~^(http|ftp)(s)?://([^/:]+)(:(\d+))?(.+)$~', $url, $match); |
| 4930 | 5222 | |
| 4931 | 5223 | // No scheme? No data for you! |
| 4932 | - if (empty($match[1])) |
|
| 4933 | - return false; |
|
| 5224 | + if (empty($match[1])) { |
|
| 5225 | + return false; |
|
| 5226 | + } |
|
| 4934 | 5227 | |
| 4935 | 5228 | // An FTP url. We should try connecting and RETRieving it... |
| 4936 | 5229 | elseif ($match[1] == 'ftp') |
@@ -4940,23 +5233,26 @@ discard block |
||
| 4940 | 5233 | |
| 4941 | 5234 | // Establish a connection and attempt to enable passive mode. |
| 4942 | 5235 | $ftp = new ftp_connection(($match[2] ? 'ssl://' : '') . $match[3], empty($match[5]) ? 21 : $match[5], 'anonymous', $webmaster_email); |
| 4943 | - if ($ftp->error !== false || !$ftp->passive()) |
|
| 4944 | - return false; |
|
| 5236 | + if ($ftp->error !== false || !$ftp->passive()) { |
|
| 5237 | + return false; |
|
| 5238 | + } |
|
| 4945 | 5239 | |
| 4946 | 5240 | // I want that one *points*! |
| 4947 | 5241 | fwrite($ftp->connection, 'RETR ' . $match[6] . "\r\n"); |
| 4948 | 5242 | |
| 4949 | 5243 | // Since passive mode worked (or we would have returned already!) open the connection. |
| 4950 | 5244 | $fp = @fsockopen($ftp->pasv['ip'], $ftp->pasv['port'], $err, $err, 5); |
| 4951 | - if (!$fp) |
|
| 4952 | - return false; |
|
| 5245 | + if (!$fp) { |
|
| 5246 | + return false; |
|
| 5247 | + } |
|
| 4953 | 5248 | |
| 4954 | 5249 | // The server should now say something in acknowledgement. |
| 4955 | 5250 | $ftp->check_response(150); |
| 4956 | 5251 | |
| 4957 | 5252 | $data = ''; |
| 4958 | - while (!feof($fp)) |
|
| 4959 | - $data .= fread($fp, 4096); |
|
| 5253 | + while (!feof($fp)) { |
|
| 5254 | + $data .= fread($fp, 4096); |
|
| 5255 | + } |
|
| 4960 | 5256 | fclose($fp); |
| 4961 | 5257 | |
| 4962 | 5258 | // All done, right? Good. |
@@ -4968,8 +5264,9 @@ discard block |
||
| 4968 | 5264 | elseif (isset($match[1]) && $match[1] == 'http') |
| 4969 | 5265 | { |
| 4970 | 5266 | // First try to use fsockopen, because it is fastest. |
| 4971 | - if ($keep_alive && $match[3] == $keep_alive_dom) |
|
| 4972 | - $fp = $keep_alive_fp; |
|
| 5267 | + if ($keep_alive && $match[3] == $keep_alive_dom) { |
|
| 5268 | + $fp = $keep_alive_fp; |
|
| 5269 | + } |
|
| 4973 | 5270 | if (empty($fp)) |
| 4974 | 5271 | { |
| 4975 | 5272 | // Open the socket on the port we want... |
@@ -4989,20 +5286,21 @@ discard block |
||
| 4989 | 5286 | fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n"); |
| 4990 | 5287 | fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n"); |
| 4991 | 5288 | fwrite($fp, 'user-agent: PHP/SMF' . "\r\n"); |
| 4992 | - if ($keep_alive) |
|
| 4993 | - fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n"); |
|
| 4994 | - else |
|
| 4995 | - fwrite($fp, 'connection: close' . "\r\n\r\n"); |
|
| 4996 | - } |
|
| 4997 | - else |
|
| 5289 | + if ($keep_alive) { |
|
| 5290 | + fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n"); |
|
| 5291 | + } else { |
|
| 5292 | + fwrite($fp, 'connection: close' . "\r\n\r\n"); |
|
| 5293 | + } |
|
| 5294 | + } else |
|
| 4998 | 5295 | { |
| 4999 | 5296 | fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n"); |
| 5000 | 5297 | fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n"); |
| 5001 | 5298 | fwrite($fp, 'user-agent: PHP/SMF' . "\r\n"); |
| 5002 | - if ($keep_alive) |
|
| 5003 | - fwrite($fp, 'connection: Keep-Alive' . "\r\n"); |
|
| 5004 | - else |
|
| 5005 | - fwrite($fp, 'connection: close' . "\r\n"); |
|
| 5299 | + if ($keep_alive) { |
|
| 5300 | + fwrite($fp, 'connection: Keep-Alive' . "\r\n"); |
|
| 5301 | + } else { |
|
| 5302 | + fwrite($fp, 'connection: close' . "\r\n"); |
|
| 5303 | + } |
|
| 5006 | 5304 | fwrite($fp, 'content-type: application/x-www-form-urlencoded' . "\r\n"); |
| 5007 | 5305 | fwrite($fp, 'content-length: ' . strlen($post_data) . "\r\n\r\n"); |
| 5008 | 5306 | fwrite($fp, $post_data); |
@@ -5015,30 +5313,33 @@ discard block |
||
| 5015 | 5313 | { |
| 5016 | 5314 | $header = ''; |
| 5017 | 5315 | $location = ''; |
| 5018 | - while (!feof($fp) && trim($header = fgets($fp, 4096)) != '') |
|
| 5019 | - if (strpos($header, 'location:') !== false) |
|
| 5316 | + while (!feof($fp) && trim($header = fgets($fp, 4096)) != '') { |
|
| 5317 | + if (strpos($header, 'location:') !== false) |
|
| 5020 | 5318 | $location = trim(substr($header, strpos($header, ':') + 1)); |
| 5319 | + } |
|
| 5021 | 5320 | |
| 5022 | - if (empty($location)) |
|
| 5023 | - return false; |
|
| 5024 | - else |
|
| 5321 | + if (empty($location)) { |
|
| 5322 | + return false; |
|
| 5323 | + } else |
|
| 5025 | 5324 | { |
| 5026 | - if (!$keep_alive) |
|
| 5027 | - fclose($fp); |
|
| 5325 | + if (!$keep_alive) { |
|
| 5326 | + fclose($fp); |
|
| 5327 | + } |
|
| 5028 | 5328 | return fetch_web_data($location, $post_data, $keep_alive, $redirection_level + 1); |
| 5029 | 5329 | } |
| 5030 | 5330 | } |
| 5031 | 5331 | |
| 5032 | 5332 | // Make sure we get a 200 OK. |
| 5033 | - elseif (preg_match('~^HTTP/\S+\s+20[01]~i', $response) === 0) |
|
| 5034 | - return false; |
|
| 5333 | + elseif (preg_match('~^HTTP/\S+\s+20[01]~i', $response) === 0) { |
|
| 5334 | + return false; |
|
| 5335 | + } |
|
| 5035 | 5336 | |
| 5036 | 5337 | // Skip the headers... |
| 5037 | 5338 | while (!feof($fp) && trim($header = fgets($fp, 4096)) != '') |
| 5038 | 5339 | { |
| 5039 | - if (preg_match('~content-length:\s*(\d+)~i', $header, $match) != 0) |
|
| 5040 | - $content_length = $match[1]; |
|
| 5041 | - elseif (preg_match('~connection:\s*close~i', $header) != 0) |
|
| 5340 | + if (preg_match('~content-length:\s*(\d+)~i', $header, $match) != 0) { |
|
| 5341 | + $content_length = $match[1]; |
|
| 5342 | + } elseif (preg_match('~connection:\s*close~i', $header) != 0) |
|
| 5042 | 5343 | { |
| 5043 | 5344 | $keep_alive_dom = null; |
| 5044 | 5345 | $keep_alive = false; |
@@ -5050,17 +5351,19 @@ discard block |
||
| 5050 | 5351 | $data = ''; |
| 5051 | 5352 | if (isset($content_length)) |
| 5052 | 5353 | { |
| 5053 | - while (!feof($fp) && strlen($data) < $content_length) |
|
| 5054 | - $data .= fread($fp, $content_length - strlen($data)); |
|
| 5055 | - } |
|
| 5056 | - else |
|
| 5354 | + while (!feof($fp) && strlen($data) < $content_length) { |
|
| 5355 | + $data .= fread($fp, $content_length - strlen($data)); |
|
| 5356 | + } |
|
| 5357 | + } else |
|
| 5057 | 5358 | { |
| 5058 | - while (!feof($fp)) |
|
| 5059 | - $data .= fread($fp, 4096); |
|
| 5359 | + while (!feof($fp)) { |
|
| 5360 | + $data .= fread($fp, 4096); |
|
| 5361 | + } |
|
| 5060 | 5362 | } |
| 5061 | 5363 | |
| 5062 | - if (!$keep_alive) |
|
| 5063 | - fclose($fp); |
|
| 5364 | + if (!$keep_alive) { |
|
| 5365 | + fclose($fp); |
|
| 5366 | + } |
|
| 5064 | 5367 | } |
| 5065 | 5368 | |
| 5066 | 5369 | // If using fsockopen didn't work, try to use cURL if available. |
@@ -5073,17 +5376,18 @@ discard block |
||
| 5073 | 5376 | $fetch_data->get_url_data($url, $post_data); |
| 5074 | 5377 | |
| 5075 | 5378 | // no errors and a 200 result, then we have a good dataset, well we at least have data. ;) |
| 5076 | - if ($fetch_data->result('code') == 200 && !$fetch_data->result('error')) |
|
| 5077 | - $data = $fetch_data->result('body'); |
|
| 5078 | - else |
|
| 5079 | - return false; |
|
| 5379 | + if ($fetch_data->result('code') == 200 && !$fetch_data->result('error')) { |
|
| 5380 | + $data = $fetch_data->result('body'); |
|
| 5381 | + } else { |
|
| 5382 | + return false; |
|
| 5383 | + } |
|
| 5080 | 5384 | } |
| 5081 | 5385 | |
| 5082 | 5386 | // Neither fsockopen nor curl are available. Well, phooey. |
| 5083 | - else |
|
| 5084 | - return false; |
|
| 5085 | - } |
|
| 5086 | - else |
|
| 5387 | + else { |
|
| 5388 | + return false; |
|
| 5389 | + } |
|
| 5390 | + } else |
|
| 5087 | 5391 | { |
| 5088 | 5392 | // Umm, this shouldn't happen? |
| 5089 | 5393 | trigger_error('fetch_web_data(): Bad URL', E_USER_NOTICE); |
@@ -5103,8 +5407,9 @@ discard block |
||
| 5103 | 5407 | global $user_info, $smcFunc; |
| 5104 | 5408 | |
| 5105 | 5409 | // Make sure we have something to work with. |
| 5106 | - if (empty($topic)) |
|
| 5107 | - return array(); |
|
| 5410 | + if (empty($topic)) { |
|
| 5411 | + return array(); |
|
| 5412 | + } |
|
| 5108 | 5413 | |
| 5109 | 5414 | |
| 5110 | 5415 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -5127,8 +5432,9 @@ discard block |
||
| 5127 | 5432 | 'topic' => $topic, |
| 5128 | 5433 | ) |
| 5129 | 5434 | ); |
| 5130 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 5131 | - $temp[] = (int) $row['content_id']; |
|
| 5435 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 5436 | + $temp[] = (int) $row['content_id']; |
|
| 5437 | + } |
|
| 5132 | 5438 | |
| 5133 | 5439 | cache_put_data($cache_key, $temp, $ttl); |
| 5134 | 5440 | } |
@@ -5149,8 +5455,9 @@ discard block |
||
| 5149 | 5455 | { |
| 5150 | 5456 | global $context; |
| 5151 | 5457 | |
| 5152 | - if (empty($string)) |
|
| 5153 | - return $string; |
|
| 5458 | + if (empty($string)) { |
|
| 5459 | + return $string; |
|
| 5460 | + } |
|
| 5154 | 5461 | |
| 5155 | 5462 | // UTF-8 occurences of MS special characters |
| 5156 | 5463 | $findchars_utf8 = array( |
@@ -5191,10 +5498,11 @@ discard block |
||
| 5191 | 5498 | '--', // — |
| 5192 | 5499 | ); |
| 5193 | 5500 | |
| 5194 | - if ($context['utf8']) |
|
| 5195 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
| 5196 | - else |
|
| 5197 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
| 5501 | + if ($context['utf8']) { |
|
| 5502 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
| 5503 | + } else { |
|
| 5504 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
| 5505 | + } |
|
| 5198 | 5506 | |
| 5199 | 5507 | return $string; |
| 5200 | 5508 | } |
@@ -5213,49 +5521,59 @@ discard block |
||
| 5213 | 5521 | { |
| 5214 | 5522 | global $context; |
| 5215 | 5523 | |
| 5216 | - if (!isset($matches[2])) |
|
| 5217 | - return ''; |
|
| 5524 | + if (!isset($matches[2])) { |
|
| 5525 | + return ''; |
|
| 5526 | + } |
|
| 5218 | 5527 | |
| 5219 | 5528 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
| 5220 | 5529 | |
| 5221 | 5530 | // remove left to right / right to left overrides |
| 5222 | - if ($num === 0x202D || $num === 0x202E) |
|
| 5223 | - return ''; |
|
| 5531 | + if ($num === 0x202D || $num === 0x202E) { |
|
| 5532 | + return ''; |
|
| 5533 | + } |
|
| 5224 | 5534 | |
| 5225 | 5535 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
| 5226 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
| 5227 | - return '&#' . $num . ';'; |
|
| 5536 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
| 5537 | + return '&#' . $num . ';'; |
|
| 5538 | + } |
|
| 5228 | 5539 | |
| 5229 | 5540 | if (empty($context['utf8'])) |
| 5230 | 5541 | { |
| 5231 | 5542 | // no control characters |
| 5232 | - if ($num < 0x20) |
|
| 5233 | - return ''; |
|
| 5543 | + if ($num < 0x20) { |
|
| 5544 | + return ''; |
|
| 5545 | + } |
|
| 5234 | 5546 | // text is text |
| 5235 | - elseif ($num < 0x80) |
|
| 5236 | - return chr($num); |
|
| 5547 | + elseif ($num < 0x80) { |
|
| 5548 | + return chr($num); |
|
| 5549 | + } |
|
| 5237 | 5550 | // all others get html-ised |
| 5238 | - else |
|
| 5239 | - return '&#' . $matches[2] . ';'; |
|
| 5240 | - } |
|
| 5241 | - else |
|
| 5551 | + else { |
|
| 5552 | + return '&#' . $matches[2] . ';'; |
|
| 5553 | + } |
|
| 5554 | + } else |
|
| 5242 | 5555 | { |
| 5243 | 5556 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
| 5244 | 5557 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
| 5245 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
| 5246 | - return ''; |
|
| 5558 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
| 5559 | + return ''; |
|
| 5560 | + } |
|
| 5247 | 5561 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
| 5248 | - elseif ($num < 0x80) |
|
| 5249 | - return chr($num); |
|
| 5562 | + elseif ($num < 0x80) { |
|
| 5563 | + return chr($num); |
|
| 5564 | + } |
|
| 5250 | 5565 | // <0x800 (2048) |
| 5251 | - elseif ($num < 0x800) |
|
| 5252 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5566 | + elseif ($num < 0x800) { |
|
| 5567 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5568 | + } |
|
| 5253 | 5569 | // < 0x10000 (65536) |
| 5254 | - elseif ($num < 0x10000) |
|
| 5255 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5570 | + elseif ($num < 0x10000) { |
|
| 5571 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5572 | + } |
|
| 5256 | 5573 | // <= 0x10FFFF (1114111) |
| 5257 | - else |
|
| 5258 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5574 | + else { |
|
| 5575 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5576 | + } |
|
| 5259 | 5577 | } |
| 5260 | 5578 | } |
| 5261 | 5579 | |
@@ -5271,28 +5589,34 @@ discard block |
||
| 5271 | 5589 | */ |
| 5272 | 5590 | function fixchar__callback($matches) |
| 5273 | 5591 | { |
| 5274 | - if (!isset($matches[1])) |
|
| 5275 | - return ''; |
|
| 5592 | + if (!isset($matches[1])) { |
|
| 5593 | + return ''; |
|
| 5594 | + } |
|
| 5276 | 5595 | |
| 5277 | 5596 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
| 5278 | 5597 | |
| 5279 | 5598 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
| 5280 | 5599 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
| 5281 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
| 5282 | - return ''; |
|
| 5600 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
| 5601 | + return ''; |
|
| 5602 | + } |
|
| 5283 | 5603 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
| 5284 | - elseif ($num < 0x80) |
|
| 5285 | - return chr($num); |
|
| 5604 | + elseif ($num < 0x80) { |
|
| 5605 | + return chr($num); |
|
| 5606 | + } |
|
| 5286 | 5607 | // <0x800 (2048) |
| 5287 | - elseif ($num < 0x800) |
|
| 5288 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5608 | + elseif ($num < 0x800) { |
|
| 5609 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5610 | + } |
|
| 5289 | 5611 | // < 0x10000 (65536) |
| 5290 | - elseif ($num < 0x10000) |
|
| 5291 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5612 | + elseif ($num < 0x10000) { |
|
| 5613 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5614 | + } |
|
| 5292 | 5615 | // <= 0x10FFFF (1114111) |
| 5293 | - else |
|
| 5294 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5295 | -} |
|
| 5616 | + else { |
|
| 5617 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5618 | + } |
|
| 5619 | + } |
|
| 5296 | 5620 | |
| 5297 | 5621 | /** |
| 5298 | 5622 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -5305,17 +5629,19 @@ discard block |
||
| 5305 | 5629 | */ |
| 5306 | 5630 | function entity_fix__callback($matches) |
| 5307 | 5631 | { |
| 5308 | - if (!isset($matches[2])) |
|
| 5309 | - return ''; |
|
| 5632 | + if (!isset($matches[2])) { |
|
| 5633 | + return ''; |
|
| 5634 | + } |
|
| 5310 | 5635 | |
| 5311 | 5636 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
| 5312 | 5637 | |
| 5313 | 5638 | // we don't allow control characters, characters out of range, byte markers, etc |
| 5314 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
| 5315 | - return ''; |
|
| 5316 | - else |
|
| 5317 | - return '&#' . $num . ';'; |
|
| 5318 | -} |
|
| 5639 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
| 5640 | + return ''; |
|
| 5641 | + } else { |
|
| 5642 | + return '&#' . $num . ';'; |
|
| 5643 | + } |
|
| 5644 | + } |
|
| 5319 | 5645 | |
| 5320 | 5646 | /** |
| 5321 | 5647 | * Return a Gravatar URL based on |
@@ -5339,18 +5665,23 @@ discard block |
||
| 5339 | 5665 | $ratings = array('G', 'PG', 'R', 'X'); |
| 5340 | 5666 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
| 5341 | 5667 | $url_params = array(); |
| 5342 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
| 5343 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
| 5344 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
| 5345 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
| 5346 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
| 5347 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
| 5348 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
| 5349 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
| 5668 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
| 5669 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
| 5670 | + } |
|
| 5671 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
| 5672 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
| 5673 | + } |
|
| 5674 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
| 5675 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
| 5676 | + } |
|
| 5677 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
| 5678 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
| 5350 | 5679 | $size_string = $modSettings['avatar_max_height_external']; |
| 5680 | + } |
|
| 5351 | 5681 | |
| 5352 | - if (!empty($size_string)) |
|
| 5353 | - $url_params[] = 's=' . $size_string; |
|
| 5682 | + if (!empty($size_string)) { |
|
| 5683 | + $url_params[] = 's=' . $size_string; |
|
| 5684 | + } |
|
| 5354 | 5685 | } |
| 5355 | 5686 | $http_method = !empty($modSettings['force_ssl']) ? 'https://secure' : 'http://www'; |
| 5356 | 5687 | |
@@ -5369,22 +5700,26 @@ discard block |
||
| 5369 | 5700 | static $timezones = null, $lastwhen = null; |
| 5370 | 5701 | |
| 5371 | 5702 | // No point doing this over if we already did it once |
| 5372 | - if (!empty($timezones) && $when == $lastwhen) |
|
| 5373 | - return $timezones; |
|
| 5374 | - else |
|
| 5375 | - $lastwhen = $when; |
|
| 5703 | + if (!empty($timezones) && $when == $lastwhen) { |
|
| 5704 | + return $timezones; |
|
| 5705 | + } else { |
|
| 5706 | + $lastwhen = $when; |
|
| 5707 | + } |
|
| 5376 | 5708 | |
| 5377 | 5709 | // Parseable datetime string? |
| 5378 | - if (is_int($timestamp = strtotime($when))) |
|
| 5379 | - $when = $timestamp; |
|
| 5710 | + if (is_int($timestamp = strtotime($when))) { |
|
| 5711 | + $when = $timestamp; |
|
| 5712 | + } |
|
| 5380 | 5713 | |
| 5381 | 5714 | // A Unix timestamp? |
| 5382 | - elseif (is_numeric($when)) |
|
| 5383 | - $when = intval($when); |
|
| 5715 | + elseif (is_numeric($when)) { |
|
| 5716 | + $when = intval($when); |
|
| 5717 | + } |
|
| 5384 | 5718 | |
| 5385 | 5719 | // Invalid value? Just get current Unix timestamp. |
| 5386 | - else |
|
| 5387 | - $when = time(); |
|
| 5720 | + else { |
|
| 5721 | + $when = time(); |
|
| 5722 | + } |
|
| 5388 | 5723 | |
| 5389 | 5724 | // We'll need these too |
| 5390 | 5725 | $date_when = date_create('@' . $when); |
@@ -5399,8 +5734,9 @@ discard block |
||
| 5399 | 5734 | foreach ($priority_countries as $country) |
| 5400 | 5735 | { |
| 5401 | 5736 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
| 5402 | - if (!empty($country_tzids)) |
|
| 5403 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
| 5737 | + if (!empty($country_tzids)) { |
|
| 5738 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
| 5739 | + } |
|
| 5404 | 5740 | } |
| 5405 | 5741 | |
| 5406 | 5742 | // Antarctic research stations should be listed last, unless you're running a penguin forum |
@@ -5414,8 +5750,9 @@ discard block |
||
| 5414 | 5750 | foreach ($tzids as $tzid) |
| 5415 | 5751 | { |
| 5416 | 5752 | // We don't want UTC right now |
| 5417 | - if ($tzid == 'UTC') |
|
| 5418 | - continue; |
|
| 5753 | + if ($tzid == 'UTC') { |
|
| 5754 | + continue; |
|
| 5755 | + } |
|
| 5419 | 5756 | |
| 5420 | 5757 | $tz = timezone_open($tzid); |
| 5421 | 5758 | |
@@ -5436,13 +5773,14 @@ discard block |
||
| 5436 | 5773 | } |
| 5437 | 5774 | |
| 5438 | 5775 | // A time zone from a prioritized country? |
| 5439 | - if (in_array($tzid, $priority_tzids)) |
|
| 5440 | - $priority_zones[$tzkey] = true; |
|
| 5776 | + if (in_array($tzid, $priority_tzids)) { |
|
| 5777 | + $priority_zones[$tzkey] = true; |
|
| 5778 | + } |
|
| 5441 | 5779 | |
| 5442 | 5780 | // Keep track of the location and offset for this tzid |
| 5443 | - if (!empty($txt[$tzid])) |
|
| 5444 | - $zones[$tzkey]['locations'][] = $txt[$tzid]; |
|
| 5445 | - else |
|
| 5781 | + if (!empty($txt[$tzid])) { |
|
| 5782 | + $zones[$tzkey]['locations'][] = $txt[$tzid]; |
|
| 5783 | + } else |
|
| 5446 | 5784 | { |
| 5447 | 5785 | $tzid_parts = explode('/', $tzid); |
| 5448 | 5786 | $zones[$tzkey]['locations'][] = str_replace(array('St_', '_'), array('St. ', ' '), array_pop($tzid_parts)); |
@@ -5462,23 +5800,27 @@ discard block |
||
| 5462 | 5800 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
| 5463 | 5801 | |
| 5464 | 5802 | // Use the custom description, if there is one |
| 5465 | - if (!empty($tztxt[$tzvalue['tzid']])) |
|
| 5466 | - $desc = $tztxt[$tzvalue['tzid']]; |
|
| 5803 | + if (!empty($tztxt[$tzvalue['tzid']])) { |
|
| 5804 | + $desc = $tztxt[$tzvalue['tzid']]; |
|
| 5805 | + } |
|
| 5467 | 5806 | // Otherwise, use the list of locations (max 5, so things don't get silly) |
| 5468 | - else |
|
| 5469 | - $desc = implode(', ', array_slice(array_unique($tzvalue['locations']), 0, 5)) . (count($tzvalue['locations']) > 5 ? ', ' . $txt['etc'] : ''); |
|
| 5807 | + else { |
|
| 5808 | + $desc = implode(', ', array_slice(array_unique($tzvalue['locations']), 0, 5)) . (count($tzvalue['locations']) > 5 ? ', ' . $txt['etc'] : ''); |
|
| 5809 | + } |
|
| 5470 | 5810 | |
| 5471 | 5811 | // Show the UTC offset and the abbreviation, if it's something like 'MST' and not '-06' |
| 5472 | 5812 | $desc = '[UTC' . date_format($date_when, 'P') . '] - ' . (!strspn($tzvalue['abbr'], '+-') ? $tzvalue['abbr'] . ' - ' : '') . $desc; |
| 5473 | 5813 | |
| 5474 | - if (isset($priority_zones[$tzkey])) |
|
| 5475 | - $priority_timezones[$tzvalue['tzid']] = $desc; |
|
| 5476 | - else |
|
| 5477 | - $timezones[$tzvalue['tzid']] = $desc; |
|
| 5814 | + if (isset($priority_zones[$tzkey])) { |
|
| 5815 | + $priority_timezones[$tzvalue['tzid']] = $desc; |
|
| 5816 | + } else { |
|
| 5817 | + $timezones[$tzvalue['tzid']] = $desc; |
|
| 5818 | + } |
|
| 5478 | 5819 | } |
| 5479 | 5820 | |
| 5480 | - if (!empty($priority_timezones)) |
|
| 5481 | - $priority_timezones[] = '-----'; |
|
| 5821 | + if (!empty($priority_timezones)) { |
|
| 5822 | + $priority_timezones[] = '-----'; |
|
| 5823 | + } |
|
| 5482 | 5824 | |
| 5483 | 5825 | $timezones = array_merge( |
| 5484 | 5826 | $priority_timezones, |
@@ -5495,8 +5837,9 @@ discard block |
||
| 5495 | 5837 | */ |
| 5496 | 5838 | function inet_ptod($ip_address) |
| 5497 | 5839 | { |
| 5498 | - if (!isValidIP($ip_address)) |
|
| 5499 | - return $ip_address; |
|
| 5840 | + if (!isValidIP($ip_address)) { |
|
| 5841 | + return $ip_address; |
|
| 5842 | + } |
|
| 5500 | 5843 | |
| 5501 | 5844 | $bin = inet_pton($ip_address); |
| 5502 | 5845 | return $bin; |
@@ -5508,13 +5851,15 @@ discard block |
||
| 5508 | 5851 | */ |
| 5509 | 5852 | function inet_dtop($bin) |
| 5510 | 5853 | { |
| 5511 | - if(empty($bin)) |
|
| 5512 | - return ''; |
|
| 5854 | + if(empty($bin)) { |
|
| 5855 | + return ''; |
|
| 5856 | + } |
|
| 5513 | 5857 | |
| 5514 | 5858 | global $db_type; |
| 5515 | 5859 | |
| 5516 | - if ($db_type == 'postgresql') |
|
| 5517 | - return $bin; |
|
| 5860 | + if ($db_type == 'postgresql') { |
|
| 5861 | + return $bin; |
|
| 5862 | + } |
|
| 5518 | 5863 | |
| 5519 | 5864 | $ip_address = inet_ntop($bin); |
| 5520 | 5865 | |
@@ -5539,26 +5884,32 @@ discard block |
||
| 5539 | 5884 | */ |
| 5540 | 5885 | function _safe_serialize($value) |
| 5541 | 5886 | { |
| 5542 | - if(is_null($value)) |
|
| 5543 | - return 'N;'; |
|
| 5887 | + if(is_null($value)) { |
|
| 5888 | + return 'N;'; |
|
| 5889 | + } |
|
| 5544 | 5890 | |
| 5545 | - if(is_bool($value)) |
|
| 5546 | - return 'b:'. (int) $value .';'; |
|
| 5891 | + if(is_bool($value)) { |
|
| 5892 | + return 'b:'. (int) $value .';'; |
|
| 5893 | + } |
|
| 5547 | 5894 | |
| 5548 | - if(is_int($value)) |
|
| 5549 | - return 'i:'. $value .';'; |
|
| 5895 | + if(is_int($value)) { |
|
| 5896 | + return 'i:'. $value .';'; |
|
| 5897 | + } |
|
| 5550 | 5898 | |
| 5551 | - if(is_float($value)) |
|
| 5552 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
| 5899 | + if(is_float($value)) { |
|
| 5900 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
| 5901 | + } |
|
| 5553 | 5902 | |
| 5554 | - if(is_string($value)) |
|
| 5555 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
| 5903 | + if(is_string($value)) { |
|
| 5904 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
| 5905 | + } |
|
| 5556 | 5906 | |
| 5557 | 5907 | if(is_array($value)) |
| 5558 | 5908 | { |
| 5559 | 5909 | $out = ''; |
| 5560 | - foreach($value as $k => $v) |
|
| 5561 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
| 5910 | + foreach($value as $k => $v) { |
|
| 5911 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
| 5912 | + } |
|
| 5562 | 5913 | |
| 5563 | 5914 | return 'a:'. count($value) .':{'. $out .'}'; |
| 5564 | 5915 | } |
@@ -5584,8 +5935,9 @@ discard block |
||
| 5584 | 5935 | |
| 5585 | 5936 | $out = _safe_serialize($value); |
| 5586 | 5937 | |
| 5587 | - if (isset($mbIntEnc)) |
|
| 5588 | - mb_internal_encoding($mbIntEnc); |
|
| 5938 | + if (isset($mbIntEnc)) { |
|
| 5939 | + mb_internal_encoding($mbIntEnc); |
|
| 5940 | + } |
|
| 5589 | 5941 | |
| 5590 | 5942 | return $out; |
| 5591 | 5943 | } |
@@ -5602,8 +5954,9 @@ discard block |
||
| 5602 | 5954 | function _safe_unserialize($str) |
| 5603 | 5955 | { |
| 5604 | 5956 | // Input is not a string. |
| 5605 | - if(empty($str) || !is_string($str)) |
|
| 5606 | - return false; |
|
| 5957 | + if(empty($str) || !is_string($str)) { |
|
| 5958 | + return false; |
|
| 5959 | + } |
|
| 5607 | 5960 | |
| 5608 | 5961 | $stack = array(); |
| 5609 | 5962 | $expected = array(); |
@@ -5619,43 +5972,38 @@ discard block |
||
| 5619 | 5972 | while($state != 1) |
| 5620 | 5973 | { |
| 5621 | 5974 | $type = isset($str[0]) ? $str[0] : ''; |
| 5622 | - if($type == '}') |
|
| 5623 | - $str = substr($str, 1); |
|
| 5624 | - |
|
| 5625 | - else if($type == 'N' && $str[1] == ';') |
|
| 5975 | + if($type == '}') { |
|
| 5976 | + $str = substr($str, 1); |
|
| 5977 | + } else if($type == 'N' && $str[1] == ';') |
|
| 5626 | 5978 | { |
| 5627 | 5979 | $value = null; |
| 5628 | 5980 | $str = substr($str, 2); |
| 5629 | - } |
|
| 5630 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
| 5981 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
| 5631 | 5982 | { |
| 5632 | 5983 | $value = $matches[1] == '1' ? true : false; |
| 5633 | 5984 | $str = substr($str, 4); |
| 5634 | - } |
|
| 5635 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
| 5985 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
| 5636 | 5986 | { |
| 5637 | 5987 | $value = (int)$matches[1]; |
| 5638 | 5988 | $str = $matches[2]; |
| 5639 | - } |
|
| 5640 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
| 5989 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
| 5641 | 5990 | { |
| 5642 | 5991 | $value = (float)$matches[1]; |
| 5643 | 5992 | $str = $matches[3]; |
| 5644 | - } |
|
| 5645 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
| 5993 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
| 5646 | 5994 | { |
| 5647 | 5995 | $value = substr($matches[2], 0, (int)$matches[1]); |
| 5648 | 5996 | $str = substr($matches[2], (int)$matches[1] + 2); |
| 5649 | - } |
|
| 5650 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
| 5997 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
| 5651 | 5998 | { |
| 5652 | 5999 | $expectedLength = (int)$matches[1]; |
| 5653 | 6000 | $str = $matches[2]; |
| 5654 | 6001 | } |
| 5655 | 6002 | |
| 5656 | 6003 | // Object or unknown/malformed type. |
| 5657 | - else |
|
| 5658 | - return false; |
|
| 6004 | + else { |
|
| 6005 | + return false; |
|
| 6006 | + } |
|
| 5659 | 6007 | |
| 5660 | 6008 | switch($state) |
| 5661 | 6009 | { |
@@ -5683,8 +6031,9 @@ discard block |
||
| 5683 | 6031 | if($type == '}') |
| 5684 | 6032 | { |
| 5685 | 6033 | // Array size is less than expected. |
| 5686 | - if(count($list) < end($expected)) |
|
| 5687 | - return false; |
|
| 6034 | + if(count($list) < end($expected)) { |
|
| 6035 | + return false; |
|
| 6036 | + } |
|
| 5688 | 6037 | |
| 5689 | 6038 | unset($list); |
| 5690 | 6039 | $list = &$stack[count($stack)-1]; |
@@ -5693,8 +6042,9 @@ discard block |
||
| 5693 | 6042 | // Go to terminal state if we're at the end of the root array. |
| 5694 | 6043 | array_pop($expected); |
| 5695 | 6044 | |
| 5696 | - if(count($expected) == 0) |
|
| 5697 | - $state = 1; |
|
| 6045 | + if(count($expected) == 0) { |
|
| 6046 | + $state = 1; |
|
| 6047 | + } |
|
| 5698 | 6048 | |
| 5699 | 6049 | break; |
| 5700 | 6050 | } |
@@ -5702,8 +6052,9 @@ discard block |
||
| 5702 | 6052 | if($type == 'i' || $type == 's') |
| 5703 | 6053 | { |
| 5704 | 6054 | // Array size exceeds expected length. |
| 5705 | - if(count($list) >= end($expected)) |
|
| 5706 | - return false; |
|
| 6055 | + if(count($list) >= end($expected)) { |
|
| 6056 | + return false; |
|
| 6057 | + } |
|
| 5707 | 6058 | |
| 5708 | 6059 | $key = $value; |
| 5709 | 6060 | $state = 3; |
@@ -5737,8 +6088,9 @@ discard block |
||
| 5737 | 6088 | } |
| 5738 | 6089 | |
| 5739 | 6090 | // Trailing data in input. |
| 5740 | - if(!empty($str)) |
|
| 5741 | - return false; |
|
| 6091 | + if(!empty($str)) { |
|
| 6092 | + return false; |
|
| 6093 | + } |
|
| 5742 | 6094 | |
| 5743 | 6095 | return $data; |
| 5744 | 6096 | } |
@@ -5761,8 +6113,9 @@ discard block |
||
| 5761 | 6113 | |
| 5762 | 6114 | $out = _safe_unserialize($str); |
| 5763 | 6115 | |
| 5764 | - if (isset($mbIntEnc)) |
|
| 5765 | - mb_internal_encoding($mbIntEnc); |
|
| 6116 | + if (isset($mbIntEnc)) { |
|
| 6117 | + mb_internal_encoding($mbIntEnc); |
|
| 6118 | + } |
|
| 5766 | 6119 | |
| 5767 | 6120 | return $out; |
| 5768 | 6121 | } |
@@ -5777,12 +6130,14 @@ discard block |
||
| 5777 | 6130 | function smf_chmod($file, $value = 0) |
| 5778 | 6131 | { |
| 5779 | 6132 | // No file? no checks! |
| 5780 | - if (empty($file)) |
|
| 5781 | - return false; |
|
| 6133 | + if (empty($file)) { |
|
| 6134 | + return false; |
|
| 6135 | + } |
|
| 5782 | 6136 | |
| 5783 | 6137 | // Already writable? |
| 5784 | - if (is_writable($file)) |
|
| 5785 | - return true; |
|
| 6138 | + if (is_writable($file)) { |
|
| 6139 | + return true; |
|
| 6140 | + } |
|
| 5786 | 6141 | |
| 5787 | 6142 | // Do we have a file or a dir? |
| 5788 | 6143 | $isDir = is_dir($file); |
@@ -5798,10 +6153,9 @@ discard block |
||
| 5798 | 6153 | { |
| 5799 | 6154 | $isWritable = true; |
| 5800 | 6155 | break; |
| 6156 | + } else { |
|
| 6157 | + @chmod($file, $val); |
|
| 5801 | 6158 | } |
| 5802 | - |
|
| 5803 | - else |
|
| 5804 | - @chmod($file, $val); |
|
| 5805 | 6159 | } |
| 5806 | 6160 | |
| 5807 | 6161 | return $isWritable; |
@@ -5820,8 +6174,9 @@ discard block |
||
| 5820 | 6174 | global $txt; |
| 5821 | 6175 | |
| 5822 | 6176 | // Come on... |
| 5823 | - if (empty($json) || !is_string($json)) |
|
| 5824 | - return array(); |
|
| 6177 | + if (empty($json) || !is_string($json)) { |
|
| 6178 | + return array(); |
|
| 6179 | + } |
|
| 5825 | 6180 | |
| 5826 | 6181 | $returnArray = @json_decode($json, $returnAsArray); |
| 5827 | 6182 | |
@@ -5859,11 +6214,11 @@ discard block |
||
| 5859 | 6214 | $jsonDebug = $jsonDebug[0]; |
| 5860 | 6215 | loadLanguage('Errors'); |
| 5861 | 6216 | |
| 5862 | - if (!empty($jsonDebug)) |
|
| 5863 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
| 5864 | - |
|
| 5865 | - else |
|
| 5866 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
| 6217 | + if (!empty($jsonDebug)) { |
|
| 6218 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
| 6219 | + } else { |
|
| 6220 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
| 6221 | + } |
|
| 5867 | 6222 | |
| 5868 | 6223 | // Everyone expects an array. |
| 5869 | 6224 | return array(); |
@@ -5897,8 +6252,9 @@ discard block |
||
| 5897 | 6252 | global $db_show_debug, $modSettings; |
| 5898 | 6253 | |
| 5899 | 6254 | // Defensive programming anyone? |
| 5900 | - if (empty($data)) |
|
| 5901 | - return false; |
|
| 6255 | + if (empty($data)) { |
|
| 6256 | + return false; |
|
| 6257 | + } |
|
| 5902 | 6258 | |
| 5903 | 6259 | // Don't need extra stuff... |
| 5904 | 6260 | $db_show_debug = false; |
@@ -5906,11 +6262,11 @@ discard block |
||
| 5906 | 6262 | // Kill anything else. |
| 5907 | 6263 | ob_end_clean(); |
| 5908 | 6264 | |
| 5909 | - if (!empty($modSettings['CompressedOutput'])) |
|
| 5910 | - @ob_start('ob_gzhandler'); |
|
| 5911 | - |
|
| 5912 | - else |
|
| 5913 | - ob_start(); |
|
| 6265 | + if (!empty($modSettings['CompressedOutput'])) { |
|
| 6266 | + @ob_start('ob_gzhandler'); |
|
| 6267 | + } else { |
|
| 6268 | + ob_start(); |
|
| 6269 | + } |
|
| 5914 | 6270 | |
| 5915 | 6271 | // Set the header. |
| 5916 | 6272 | header($type); |
@@ -5942,8 +6298,9 @@ discard block |
||
| 5942 | 6298 | static $done = false; |
| 5943 | 6299 | |
| 5944 | 6300 | // If we don't need to do anything, don't |
| 5945 | - if (!$update && $done) |
|
| 5946 | - return; |
|
| 6301 | + if (!$update && $done) { |
|
| 6302 | + return; |
|
| 6303 | + } |
|
| 5947 | 6304 | |
| 5948 | 6305 | // Should we get a new copy of the official list of TLDs? |
| 5949 | 6306 | if ($update) |
@@ -5955,8 +6312,9 @@ discard block |
||
| 5955 | 6312 | // marauding bandits roaming on the surface. We don't want to waste precious electricity on |
| 5956 | 6313 | // pointlessly repeating background tasks, so we'll wait until the next regularly scheduled |
| 5957 | 6314 | // update to see if civilization has been restored. |
| 5958 | - if ($tlds === false) |
|
| 5959 | - $postapocalypticNightmare = true; |
|
| 6315 | + if ($tlds === false) { |
|
| 6316 | + $postapocalypticNightmare = true; |
|
| 6317 | + } |
|
| 5960 | 6318 | } |
| 5961 | 6319 | // If we aren't updating and the regex is valid, we're done |
| 5962 | 6320 | elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false) |
@@ -5971,10 +6329,11 @@ discard block |
||
| 5971 | 6329 | // Clean $tlds and convert it to an array |
| 5972 | 6330 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
| 5973 | 6331 | $line = trim($line); |
| 5974 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
| 5975 | - return false; |
|
| 5976 | - else |
|
| 5977 | - return true; |
|
| 6332 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
| 6333 | + return false; |
|
| 6334 | + } else { |
|
| 6335 | + return true; |
|
| 6336 | + } |
|
| 5978 | 6337 | }); |
| 5979 | 6338 | |
| 5980 | 6339 | // Convert Punycode to Unicode |
@@ -6066,8 +6425,7 @@ discard block |
||
| 6066 | 6425 | |
| 6067 | 6426 | $strlen = 'mb_strlen'; |
| 6068 | 6427 | $substr = 'mb_substr'; |
| 6069 | - } |
|
| 6070 | - else |
|
| 6428 | + } else |
|
| 6071 | 6429 | { |
| 6072 | 6430 | $strlen = $smcFunc['strlen']; |
| 6073 | 6431 | $substr = $smcFunc['substr']; |
@@ -6081,20 +6439,21 @@ discard block |
||
| 6081 | 6439 | |
| 6082 | 6440 | $first = $substr($string, 0, 1); |
| 6083 | 6441 | |
| 6084 | - if (empty($index[$first])) |
|
| 6085 | - $index[$first] = array(); |
|
| 6442 | + if (empty($index[$first])) { |
|
| 6443 | + $index[$first] = array(); |
|
| 6444 | + } |
|
| 6086 | 6445 | |
| 6087 | 6446 | if ($strlen($string) > 1) |
| 6088 | 6447 | { |
| 6089 | 6448 | // Sanity check on recursion |
| 6090 | - if ($depth > 99) |
|
| 6091 | - $index[$first][$substr($string, 1)] = ''; |
|
| 6092 | - |
|
| 6093 | - else |
|
| 6094 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
| 6449 | + if ($depth > 99) { |
|
| 6450 | + $index[$first][$substr($string, 1)] = ''; |
|
| 6451 | + } else { |
|
| 6452 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
| 6453 | + } |
|
| 6454 | + } else { |
|
| 6455 | + $index[$first][''] = ''; |
|
| 6095 | 6456 | } |
| 6096 | - else |
|
| 6097 | - $index[$first][''] = ''; |
|
| 6098 | 6457 | |
| 6099 | 6458 | $depth--; |
| 6100 | 6459 | return $index; |
@@ -6117,9 +6476,9 @@ discard block |
||
| 6117 | 6476 | $key_regex = preg_quote($key, $delim); |
| 6118 | 6477 | $new_key = $key; |
| 6119 | 6478 | |
| 6120 | - if (empty($value)) |
|
| 6121 | - $sub_regex = ''; |
|
| 6122 | - else |
|
| 6479 | + if (empty($value)) { |
|
| 6480 | + $sub_regex = ''; |
|
| 6481 | + } else |
|
| 6123 | 6482 | { |
| 6124 | 6483 | $sub_regex = $index_to_regex($value, $delim); |
| 6125 | 6484 | |
@@ -6127,22 +6486,22 @@ discard block |
||
| 6127 | 6486 | { |
| 6128 | 6487 | $new_key_array = explode('(?'.'>', $sub_regex); |
| 6129 | 6488 | $new_key .= $new_key_array[0]; |
| 6489 | + } else { |
|
| 6490 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
| 6130 | 6491 | } |
| 6131 | - else |
|
| 6132 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
| 6133 | 6492 | } |
| 6134 | 6493 | |
| 6135 | - if ($depth > 1) |
|
| 6136 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
| 6137 | - else |
|
| 6494 | + if ($depth > 1) { |
|
| 6495 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
| 6496 | + } else |
|
| 6138 | 6497 | { |
| 6139 | 6498 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
| 6140 | 6499 | { |
| 6141 | 6500 | $regex[$new_key] = $key_regex . $sub_regex; |
| 6142 | 6501 | unset($index[$key]); |
| 6502 | + } else { |
|
| 6503 | + break; |
|
| 6143 | 6504 | } |
| 6144 | - else |
|
| 6145 | - break; |
|
| 6146 | 6505 | } |
| 6147 | 6506 | } |
| 6148 | 6507 | |
@@ -6151,10 +6510,11 @@ discard block |
||
| 6151 | 6510 | $l1 = $strlen($k1); |
| 6152 | 6511 | $l2 = $strlen($k2); |
| 6153 | 6512 | |
| 6154 | - if ($l1 == $l2) |
|
| 6155 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
| 6156 | - else |
|
| 6157 | - return $l1 > $l2 ? -1 : 1; |
|
| 6513 | + if ($l1 == $l2) { |
|
| 6514 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
| 6515 | + } else { |
|
| 6516 | + return $l1 > $l2 ? -1 : 1; |
|
| 6517 | + } |
|
| 6158 | 6518 | }); |
| 6159 | 6519 | |
| 6160 | 6520 | $depth--; |
@@ -6165,21 +6525,24 @@ discard block |
||
| 6165 | 6525 | $index = array(); |
| 6166 | 6526 | $regex = ''; |
| 6167 | 6527 | |
| 6168 | - foreach ($strings as $string) |
|
| 6169 | - $index = $add_string_to_index($string, $index); |
|
| 6528 | + foreach ($strings as $string) { |
|
| 6529 | + $index = $add_string_to_index($string, $index); |
|
| 6530 | + } |
|
| 6170 | 6531 | |
| 6171 | 6532 | if ($returnArray === true) |
| 6172 | 6533 | { |
| 6173 | 6534 | $regex = array(); |
| 6174 | - while (!empty($index)) |
|
| 6175 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6535 | + while (!empty($index)) { |
|
| 6536 | + $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6537 | + } |
|
| 6538 | + } else { |
|
| 6539 | + $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6176 | 6540 | } |
| 6177 | - else |
|
| 6178 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6179 | 6541 | |
| 6180 | 6542 | // Restore PHP's internal character encoding to whatever it was originally |
| 6181 | - if (!empty($current_encoding)) |
|
| 6182 | - mb_internal_encoding($current_encoding); |
|
| 6543 | + if (!empty($current_encoding)) { |
|
| 6544 | + mb_internal_encoding($current_encoding); |
|
| 6545 | + } |
|
| 6183 | 6546 | |
| 6184 | 6547 | return $regex; |
| 6185 | 6548 | } |
@@ -6222,13 +6585,15 @@ discard block |
||
| 6222 | 6585 | // Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't... |
| 6223 | 6586 | $url = str_ireplace('https://', 'http://', $url) . '/'; |
| 6224 | 6587 | $headers = @get_headers($url); |
| 6225 | - if ($headers === false) |
|
| 6226 | - return false; |
|
| 6588 | + if ($headers === false) { |
|
| 6589 | + return false; |
|
| 6590 | + } |
|
| 6227 | 6591 | |
| 6228 | 6592 | // Now to see if it came back https... |
| 6229 | 6593 | // First check for a redirect status code in first row (301, 302, 307) |
| 6230 | - if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) |
|
| 6231 | - return false; |
|
| 6594 | + if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) { |
|
| 6595 | + return false; |
|
| 6596 | + } |
|
| 6232 | 6597 | |
| 6233 | 6598 | // Search for the location entry to confirm https |
| 6234 | 6599 | $result = false; |
@@ -6266,8 +6631,7 @@ discard block |
||
| 6266 | 6631 | $is_admin = $user_info['is_admin']; |
| 6267 | 6632 | $mod_cache = !empty($user_info['mod_cache']) ? $user_info['mod_cache'] : null; |
| 6268 | 6633 | $ignoreboards = !empty($user_info['ignoreboards']) ? $user_info['ignoreboards'] : null; |
| 6269 | - } |
|
| 6270 | - else |
|
| 6634 | + } else |
|
| 6271 | 6635 | { |
| 6272 | 6636 | $request = $smcFunc['db_query']('', ' |
| 6273 | 6637 | SELECT mem.ignore_boards, mem.id_group, mem.additional_groups, mem.id_post_group |
@@ -6281,17 +6645,19 @@ discard block |
||
| 6281 | 6645 | |
| 6282 | 6646 | $row = $smcFunc['db_fetch_assoc']($request); |
| 6283 | 6647 | |
| 6284 | - if (empty($row['additional_groups'])) |
|
| 6285 | - $groups = array($row['id_group'], $row['id_post_group']); |
|
| 6286 | - else |
|
| 6287 | - $groups = array_merge( |
|
| 6648 | + if (empty($row['additional_groups'])) { |
|
| 6649 | + $groups = array($row['id_group'], $row['id_post_group']); |
|
| 6650 | + } else { |
|
| 6651 | + $groups = array_merge( |
|
| 6288 | 6652 | array($row['id_group'], $row['id_post_group']), |
| 6289 | 6653 | explode(',', $row['additional_groups']) |
| 6290 | 6654 | ); |
| 6655 | + } |
|
| 6291 | 6656 | |
| 6292 | 6657 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
| 6293 | - foreach ($groups as $k => $v) |
|
| 6294 | - $groups[$k] = (int) $v; |
|
| 6658 | + foreach ($groups as $k => $v) { |
|
| 6659 | + $groups[$k] = (int) $v; |
|
| 6660 | + } |
|
| 6295 | 6661 | |
| 6296 | 6662 | $is_admin = in_array(1, $groups); |
| 6297 | 6663 | |
@@ -6308,8 +6674,9 @@ discard block |
||
| 6308 | 6674 | 'current_member' => $userid, |
| 6309 | 6675 | ) |
| 6310 | 6676 | ); |
| 6311 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 6312 | - $boards_mod[] = $row['id_board']; |
|
| 6677 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 6678 | + $boards_mod[] = $row['id_board']; |
|
| 6679 | + } |
|
| 6313 | 6680 | $smcFunc['db_free_result']($request); |
| 6314 | 6681 | |
| 6315 | 6682 | // Can any of the groups they're in moderate any of the boards? |
@@ -6321,8 +6688,9 @@ discard block |
||
| 6321 | 6688 | 'groups' => $groups, |
| 6322 | 6689 | ) |
| 6323 | 6690 | ); |
| 6324 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 6325 | - $boards_mod[] = $row['id_board']; |
|
| 6691 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 6692 | + $boards_mod[] = $row['id_board']; |
|
| 6693 | + } |
|
| 6326 | 6694 | $smcFunc['db_free_result']($request); |
| 6327 | 6695 | |
| 6328 | 6696 | // Just in case we've got duplicates here... |
@@ -6350,11 +6718,13 @@ discard block |
||
| 6350 | 6718 | // This will take the place of query_see_boards in certain spots, so it better include the boards they can see also |
| 6351 | 6719 | |
| 6352 | 6720 | // If they aren't ignoring any boards then they want to see all the boards they can see |
| 6353 | - if (empty($ignoreboards)) |
|
| 6354 | - $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
| 6721 | + if (empty($ignoreboards)) { |
|
| 6722 | + $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
| 6723 | + } |
|
| 6355 | 6724 | // Ok I guess they don't want to see all the boards |
| 6356 | - else |
|
| 6357 | - $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
| 6725 | + else { |
|
| 6726 | + $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
| 6727 | + } |
|
| 6358 | 6728 | |
| 6359 | 6729 | return $query_part; |
| 6360 | 6730 | } |
@@ -6368,10 +6738,11 @@ discard block |
||
| 6368 | 6738 | { |
| 6369 | 6739 | $secure = false; |
| 6370 | 6740 | |
| 6371 | - if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') |
|
| 6372 | - $secure = true; |
|
| 6373 | - elseif (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' || !empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') |
|
| 6374 | - $secure = true; |
|
| 6741 | + if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') { |
|
| 6742 | + $secure = true; |
|
| 6743 | + } elseif (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' || !empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') { |
|
| 6744 | + $secure = true; |
|
| 6745 | + } |
|
| 6375 | 6746 | |
| 6376 | 6747 | return $secure; |
| 6377 | 6748 | } |
@@ -6388,11 +6759,12 @@ discard block |
||
| 6388 | 6759 | { |
| 6389 | 6760 | $url = iri_to_url($iri); |
| 6390 | 6761 | |
| 6391 | - if (filter_var($url, FILTER_VALIDATE_URL, $flags) !== false) |
|
| 6392 | - return $iri; |
|
| 6393 | - else |
|
| 6394 | - return false; |
|
| 6395 | -} |
|
| 6762 | + if (filter_var($url, FILTER_VALIDATE_URL, $flags) !== false) { |
|
| 6763 | + return $iri; |
|
| 6764 | + } else { |
|
| 6765 | + return false; |
|
| 6766 | + } |
|
| 6767 | + } |
|
| 6396 | 6768 | |
| 6397 | 6769 | /** |
| 6398 | 6770 | * A wrapper for `filter_var($url, FILTER_SANITIZE_URL)` that can handle URLs |
@@ -6435,8 +6807,9 @@ discard block |
||
| 6435 | 6807 | |
| 6436 | 6808 | $host = parse_url((strpos($iri, '://') === false ? 'http://' : '') . ltrim($iri, ':/'), PHP_URL_HOST); |
| 6437 | 6809 | |
| 6438 | - if (empty($host)) |
|
| 6439 | - return $iri; |
|
| 6810 | + if (empty($host)) { |
|
| 6811 | + return $iri; |
|
| 6812 | + } |
|
| 6440 | 6813 | |
| 6441 | 6814 | // Convert the domain using the Punycode algorithm |
| 6442 | 6815 | require_once($sourcedir . '/Class-Punycode.php'); |
@@ -6472,8 +6845,9 @@ discard block |
||
| 6472 | 6845 | |
| 6473 | 6846 | $host = parse_url((strpos($url, '://') === false ? 'http://' : '') . ltrim($url, ':/'), PHP_URL_HOST); |
| 6474 | 6847 | |
| 6475 | - if (empty($host)) |
|
| 6476 | - return $url; |
|
| 6848 | + if (empty($host)) { |
|
| 6849 | + return $url; |
|
| 6850 | + } |
|
| 6477 | 6851 | |
| 6478 | 6852 | // Decode the domain from Punycode |
| 6479 | 6853 | require_once($sourcedir . '/Class-Punycode.php'); |
@@ -6499,8 +6873,9 @@ discard block |
||
| 6499 | 6873 | { |
| 6500 | 6874 | global $user_info, $modSettings, $smcFunc, $txt; |
| 6501 | 6875 | |
| 6502 | - if (empty($modSettings['cron_last_checked'])) |
|
| 6503 | - $modSettings['cron_last_checked'] = 0; |
|
| 6876 | + if (empty($modSettings['cron_last_checked'])) { |
|
| 6877 | + $modSettings['cron_last_checked'] = 0; |
|
| 6878 | + } |
|
| 6504 | 6879 | |
| 6505 | 6880 | if (!empty($modSettings['cron_is_real_cron']) && time() - $modSettings['cron_last_checked'] > 84600) |
| 6506 | 6881 | { |
@@ -6520,9 +6895,9 @@ discard block |
||
| 6520 | 6895 | loadLanguage('ManageScheduledTasks'); |
| 6521 | 6896 | log_error($txt['cron_not_working']); |
| 6522 | 6897 | updateSettings(array('cron_is_real_cron' => 0)); |
| 6898 | + } else { |
|
| 6899 | + updateSettings(array('cron_last_checked' => time())); |
|
| 6523 | 6900 | } |
| 6524 | - else |
|
| 6525 | - updateSettings(array('cron_last_checked' => time())); |
|
| 6526 | 6901 | } |
| 6527 | 6902 | } |
| 6528 | 6903 | |
@@ -386,7 +386,7 @@ discard block |
||
| 386 | 386 | { |
| 387 | 387 | $val = 'CASE '; |
| 388 | 388 | foreach ($members as $k => $v) |
| 389 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
| 389 | + $val .= 'WHEN id_member = ' . $v . ' THEN ' . count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
| 390 | 390 | $val = $val . ' END'; |
| 391 | 391 | $type = 'raw'; |
| 392 | 392 | } |
@@ -739,7 +739,7 @@ discard block |
||
| 739 | 739 | static $non_twelve_hour, $locale_cache; |
| 740 | 740 | static $unsupportedFormats, $finalizedFormats; |
| 741 | 741 | |
| 742 | - $unsupportedFormatsWindows = array('z','Z'); |
|
| 742 | + $unsupportedFormatsWindows = array('z', 'Z'); |
|
| 743 | 743 | |
| 744 | 744 | // Ensure required values are set |
| 745 | 745 | $user_info['time_offset'] = !empty($user_info['time_offset']) ? $user_info['time_offset'] : 0; |
@@ -824,7 +824,7 @@ discard block |
||
| 824 | 824 | $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
| 825 | 825 | if (empty($unsupportedFormats)) |
| 826 | 826 | { |
| 827 | - foreach($strftimeFormatSubstitutions as $format => $substitution) |
|
| 827 | + foreach ($strftimeFormatSubstitutions as $format => $substitution) |
|
| 828 | 828 | { |
| 829 | 829 | // Avoid a crashing bug with PHP 7 on certain versions of Windows |
| 830 | 830 | if ($context['server']['is_windows'] && in_array($format, $unsupportedFormatsWindows)) |
@@ -1196,7 +1196,7 @@ discard block |
||
| 1196 | 1196 | 'height' => array('optional' => true, 'match' => '(\d+)'), |
| 1197 | 1197 | ), |
| 1198 | 1198 | 'content' => '$1', |
| 1199 | - 'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt) |
|
| 1199 | + 'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt) |
|
| 1200 | 1200 | { |
| 1201 | 1201 | $returnContext = ''; |
| 1202 | 1202 | |
@@ -1231,7 +1231,7 @@ discard block |
||
| 1231 | 1231 | } |
| 1232 | 1232 | |
| 1233 | 1233 | if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
| 1234 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
| 1234 | + $returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '" class="atc_img"></a>'; |
|
| 1235 | 1235 | else |
| 1236 | 1236 | $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
| 1237 | 1237 | } |
@@ -1260,7 +1260,7 @@ discard block |
||
| 1260 | 1260 | 'type' => 'unparsed_content', |
| 1261 | 1261 | 'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>', |
| 1262 | 1262 | // @todo Maybe this can be simplified? |
| 1263 | - 'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context) |
|
| 1263 | + 'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context) |
|
| 1264 | 1264 | { |
| 1265 | 1265 | if (!isset($disabled['code'])) |
| 1266 | 1266 | { |
@@ -1297,7 +1297,7 @@ discard block |
||
| 1297 | 1297 | 'type' => 'unparsed_equals_content', |
| 1298 | 1298 | 'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>', |
| 1299 | 1299 | // @todo Maybe this can be simplified? |
| 1300 | - 'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context) |
|
| 1300 | + 'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context) |
|
| 1301 | 1301 | { |
| 1302 | 1302 | if (!isset($disabled['code'])) |
| 1303 | 1303 | { |
@@ -1341,7 +1341,7 @@ discard block |
||
| 1341 | 1341 | 'type' => 'unparsed_content', |
| 1342 | 1342 | 'content' => '<a href="mailto:$1" class="bbc_email">$1</a>', |
| 1343 | 1343 | // @todo Should this respect guest_hideContacts? |
| 1344 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1344 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1345 | 1345 | { |
| 1346 | 1346 | $data = strtr($data, array('<br>' => '')); |
| 1347 | 1347 | }, |
@@ -1360,7 +1360,7 @@ discard block |
||
| 1360 | 1360 | 'type' => 'unparsed_commas_content', |
| 1361 | 1361 | 'test' => '\d+,\d+\]', |
| 1362 | 1362 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
| 1363 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1363 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1364 | 1364 | { |
| 1365 | 1365 | if (isset($disabled['url'])) |
| 1366 | 1366 | $tag['content'] = '$1'; |
@@ -1376,7 +1376,7 @@ discard block |
||
| 1376 | 1376 | 'test' => '(left|right)(\s+max=\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)?\]', |
| 1377 | 1377 | 'before' => '<div $1>', |
| 1378 | 1378 | 'after' => '</div>', |
| 1379 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1379 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1380 | 1380 | { |
| 1381 | 1381 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
| 1382 | 1382 | |
@@ -1425,7 +1425,7 @@ discard block |
||
| 1425 | 1425 | 'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'), |
| 1426 | 1426 | ), |
| 1427 | 1427 | 'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">', |
| 1428 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1428 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1429 | 1429 | { |
| 1430 | 1430 | global $image_proxy_enabled, $user_info; |
| 1431 | 1431 | |
@@ -1451,7 +1451,7 @@ discard block |
||
| 1451 | 1451 | 'tag' => 'img', |
| 1452 | 1452 | 'type' => 'unparsed_content', |
| 1453 | 1453 | 'content' => '<img src="$1" alt="" class="bbc_img">', |
| 1454 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1454 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1455 | 1455 | { |
| 1456 | 1456 | global $image_proxy_enabled, $user_info; |
| 1457 | 1457 | |
@@ -1477,7 +1477,7 @@ discard block |
||
| 1477 | 1477 | 'tag' => 'iurl', |
| 1478 | 1478 | 'type' => 'unparsed_content', |
| 1479 | 1479 | 'content' => '<a href="$1" class="bbc_link">$1</a>', |
| 1480 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1480 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1481 | 1481 | { |
| 1482 | 1482 | $data = strtr($data, array('<br>' => '')); |
| 1483 | 1483 | $scheme = parse_url($data, PHP_URL_SCHEME); |
@@ -1491,7 +1491,7 @@ discard block |
||
| 1491 | 1491 | 'quoted' => 'optional', |
| 1492 | 1492 | 'before' => '<a href="$1" class="bbc_link">', |
| 1493 | 1493 | 'after' => '</a>', |
| 1494 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1494 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1495 | 1495 | { |
| 1496 | 1496 | if (substr($data, 0, 1) == '#') |
| 1497 | 1497 | $data = '#post_' . substr($data, 1); |
@@ -1577,7 +1577,7 @@ discard block |
||
| 1577 | 1577 | 'tag' => 'php', |
| 1578 | 1578 | 'type' => 'unparsed_content', |
| 1579 | 1579 | 'content' => '<span class="phpcode">$1</span>', |
| 1580 | - 'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled) |
|
| 1580 | + 'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled) |
|
| 1581 | 1581 | { |
| 1582 | 1582 | if (!isset($disabled['php'])) |
| 1583 | 1583 | { |
@@ -1675,7 +1675,7 @@ discard block |
||
| 1675 | 1675 | 'test' => '[1-7]\]', |
| 1676 | 1676 | 'before' => '<span style="font-size: $1;" class="bbc_size">', |
| 1677 | 1677 | 'after' => '</span>', |
| 1678 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1678 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1679 | 1679 | { |
| 1680 | 1680 | $sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95); |
| 1681 | 1681 | $data = $sizes[$data] . 'em'; |
@@ -1713,7 +1713,7 @@ discard block |
||
| 1713 | 1713 | 'tag' => 'time', |
| 1714 | 1714 | 'type' => 'unparsed_content', |
| 1715 | 1715 | 'content' => '$1', |
| 1716 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1716 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1717 | 1717 | { |
| 1718 | 1718 | if (is_numeric($data)) |
| 1719 | 1719 | $data = timeformat($data); |
@@ -1741,7 +1741,7 @@ discard block |
||
| 1741 | 1741 | 'tag' => 'url', |
| 1742 | 1742 | 'type' => 'unparsed_content', |
| 1743 | 1743 | 'content' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">$1</a>', |
| 1744 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1744 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1745 | 1745 | { |
| 1746 | 1746 | $data = strtr($data, array('<br>' => '')); |
| 1747 | 1747 | $scheme = parse_url($data, PHP_URL_SCHEME); |
@@ -1755,7 +1755,7 @@ discard block |
||
| 1755 | 1755 | 'quoted' => 'optional', |
| 1756 | 1756 | 'before' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">', |
| 1757 | 1757 | 'after' => '</a>', |
| 1758 | - 'validate' => function (&$tag, &$data, $disabled) |
|
| 1758 | + 'validate' => function(&$tag, &$data, $disabled) |
|
| 1759 | 1759 | { |
| 1760 | 1760 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1761 | 1761 | if (empty($scheme)) |
@@ -1788,7 +1788,7 @@ discard block |
||
| 1788 | 1788 | { |
| 1789 | 1789 | if (isset($temp_bbc)) |
| 1790 | 1790 | $bbc_codes = $temp_bbc; |
| 1791 | - usort($codes, function ($a, $b) { |
|
| 1791 | + usort($codes, function($a, $b) { |
|
| 1792 | 1792 | return strcmp($a['tag'], $b['tag']); |
| 1793 | 1793 | }); |
| 1794 | 1794 | return $codes; |
@@ -2004,7 +2004,7 @@ discard block |
||
| 2004 | 2004 | # a run of Unicode domain name characters and a dot |
| 2005 | 2005 | [\p{L}\p{M}\p{N}\-.:@]+\. |
| 2006 | 2006 | # and then a TLD valid in the DNS or the reserved "local" TLD |
| 2007 | - (?:'. $modSettings['tld_regex'] .'|local) |
|
| 2007 | + (?:'. $modSettings['tld_regex'] . '|local) |
|
| 2008 | 2008 | ) |
| 2009 | 2009 | # followed by a non-domain character or end of line |
| 2010 | 2010 | (?=[^\p{L}\p{N}\-.]|$) |
@@ -2072,7 +2072,7 @@ discard block |
||
| 2072 | 2072 | )? |
| 2073 | 2073 | '; |
| 2074 | 2074 | |
| 2075 | - $data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) { |
|
| 2075 | + $data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) { |
|
| 2076 | 2076 | $url = array_shift($matches); |
| 2077 | 2077 | |
| 2078 | 2078 | // If this isn't a clean URL, bail out |
@@ -2097,7 +2097,7 @@ discard block |
||
| 2097 | 2097 | $fullUrl = $url; |
| 2098 | 2098 | |
| 2099 | 2099 | // Make sure that $fullUrl really is valid |
| 2100 | - if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '' ) . $fullUrl) === false) |
|
| 2100 | + if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '') . $fullUrl) === false) |
|
| 2101 | 2101 | return $url; |
| 2102 | 2102 | |
| 2103 | 2103 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
@@ -2161,7 +2161,7 @@ discard block |
||
| 2161 | 2161 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
| 2162 | 2162 | |
| 2163 | 2163 | // A closing tag that doesn't match any open tags? Skip it. |
| 2164 | - if (!in_array($look_for, array_map(function($code){return $code['tag'];}, $open_tags))) |
|
| 2164 | + if (!in_array($look_for, array_map(function($code) {return $code['tag']; }, $open_tags))) |
|
| 2165 | 2165 | continue; |
| 2166 | 2166 | |
| 2167 | 2167 | $to_close = array(); |
@@ -2834,7 +2834,7 @@ discard block |
||
| 2834 | 2834 | { |
| 2835 | 2835 | $exts = array('svg', 'png', 'gif', 'jpg'); |
| 2836 | 2836 | $fname = pathinfo($smileysto[$i], PATHINFO_FILENAME); |
| 2837 | - $alt_images = glob($smileys_dir . $fname . '.{' . (implode(',', $exts)) . '}', GLOB_BRACE); |
|
| 2837 | + $alt_images = glob($smileys_dir . $fname . '.{' . (implode(',', $exts)) . '}', GLOB_BRACE); |
|
| 2838 | 2838 | if (!empty($alt_images)) |
| 2839 | 2839 | { |
| 2840 | 2840 | foreach ($exts as $ext) |
@@ -2850,7 +2850,7 @@ discard block |
||
| 2850 | 2850 | } |
| 2851 | 2851 | |
| 2852 | 2852 | $specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES); |
| 2853 | - $smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" class="smiley">'; |
|
| 2853 | + $smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" class="smiley">'; |
|
| 2854 | 2854 | |
| 2855 | 2855 | $smileyPregReplacements[$smileysfrom[$i]] = $smileyCode; |
| 2856 | 2856 | |
@@ -2867,7 +2867,7 @@ discard block |
||
| 2867 | 2867 | |
| 2868 | 2868 | // Replace away! |
| 2869 | 2869 | $message = preg_replace_callback($smileyPregSearch, |
| 2870 | - function ($matches) use ($smileyPregReplacements) |
|
| 2870 | + function($matches) use ($smileyPregReplacements) |
|
| 2871 | 2871 | { |
| 2872 | 2872 | return $smileyPregReplacements[$matches[1]]; |
| 2873 | 2873 | }, $message); |
@@ -2964,13 +2964,13 @@ discard block |
||
| 2964 | 2964 | { |
| 2965 | 2965 | if (defined('SID') && SID != '') |
| 2966 | 2966 | $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
| 2967 | - function ($m) use ($scripturl) |
|
| 2967 | + function($m) use ($scripturl) |
|
| 2968 | 2968 | { |
| 2969 | - return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
|
| 2969 | + return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : ""); |
|
| 2970 | 2970 | }, $setLocation); |
| 2971 | 2971 | else |
| 2972 | 2972 | $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
| 2973 | - function ($m) use ($scripturl) |
|
| 2973 | + function($m) use ($scripturl) |
|
| 2974 | 2974 | { |
| 2975 | 2975 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
| 2976 | 2976 | }, $setLocation); |
@@ -3291,7 +3291,7 @@ discard block |
||
| 3291 | 3291 | |
| 3292 | 3292 | // Add a generic "Are you sure?" confirmation message. |
| 3293 | 3293 | addInlineJavaScript(' |
| 3294 | - var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
|
| 3294 | + var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';'); |
|
| 3295 | 3295 | |
| 3296 | 3296 | // Now add the capping code for avatars. |
| 3297 | 3297 | if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
@@ -3757,7 +3757,7 @@ discard block |
||
| 3757 | 3757 | if (!empty($normal)) |
| 3758 | 3758 | foreach ($normal as $nf) |
| 3759 | 3759 | echo ' |
| 3760 | - <link rel="stylesheet" href="', $nf ,'">'; |
|
| 3760 | + <link rel="stylesheet" href="', $nf, '">'; |
|
| 3761 | 3761 | |
| 3762 | 3762 | if ($db_show_debug === true) |
| 3763 | 3763 | { |
@@ -3773,7 +3773,7 @@ discard block |
||
| 3773 | 3773 | <style>'; |
| 3774 | 3774 | |
| 3775 | 3775 | foreach ($context['css_header'] as $css) |
| 3776 | - echo $css .' |
|
| 3776 | + echo $css . ' |
|
| 3777 | 3777 | '; |
| 3778 | 3778 | |
| 3779 | 3779 | echo' |
@@ -3817,7 +3817,7 @@ discard block |
||
| 3817 | 3817 | |
| 3818 | 3818 | |
| 3819 | 3819 | // No namespaces, sorry! |
| 3820 | - $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
|
| 3820 | + $classType = 'MatthiasMullie\\Minify\\' . strtoupper($type); |
|
| 3821 | 3821 | |
| 3822 | 3822 | // Temp path. |
| 3823 | 3823 | $cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/'; |
@@ -3997,7 +3997,7 @@ discard block |
||
| 3997 | 3997 | else |
| 3998 | 3998 | $path = $modSettings['attachmentUploadDir']; |
| 3999 | 3999 | |
| 4000 | - return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
|
| 4000 | + return $path . '/' . $attachment_id . '_' . $file_hash . '.dat'; |
|
| 4001 | 4001 | } |
| 4002 | 4002 | |
| 4003 | 4003 | /** |
@@ -4041,10 +4041,10 @@ discard block |
||
| 4041 | 4041 | $valid_low = isValidIP($ip_parts[0]); |
| 4042 | 4042 | $valid_high = isValidIP($ip_parts[1]); |
| 4043 | 4043 | $count = 0; |
| 4044 | - $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
|
| 4044 | + $mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.'); |
|
| 4045 | 4045 | $max = ($mode == ':' ? 'ffff' : '255'); |
| 4046 | 4046 | $min = 0; |
| 4047 | - if(!$valid_low) |
|
| 4047 | + if (!$valid_low) |
|
| 4048 | 4048 | { |
| 4049 | 4049 | $ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]); |
| 4050 | 4050 | $valid_low = isValidIP($ip_parts[0]); |
@@ -4058,7 +4058,7 @@ discard block |
||
| 4058 | 4058 | } |
| 4059 | 4059 | |
| 4060 | 4060 | $count = 0; |
| 4061 | - if(!$valid_high) |
|
| 4061 | + if (!$valid_high) |
|
| 4062 | 4062 | { |
| 4063 | 4063 | $ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]); |
| 4064 | 4064 | $valid_high = isValidIP($ip_parts[1]); |
@@ -4071,7 +4071,7 @@ discard block |
||
| 4071 | 4071 | } |
| 4072 | 4072 | } |
| 4073 | 4073 | |
| 4074 | - if($valid_high && $valid_low) |
|
| 4074 | + if ($valid_high && $valid_low) |
|
| 4075 | 4075 | { |
| 4076 | 4076 | $ip_array['low'] = $ip_parts[0]; |
| 4077 | 4077 | $ip_array['high'] = $ip_parts[1]; |
@@ -4252,7 +4252,7 @@ discard block |
||
| 4252 | 4252 | addInlineJavaScript(' |
| 4253 | 4253 | var user_menus = new smc_PopupMenu(); |
| 4254 | 4254 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
| 4255 | - user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
|
| 4255 | + user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true); |
|
| 4256 | 4256 | if ($context['allow_pm']) |
| 4257 | 4257 | addInlineJavaScript(' |
| 4258 | 4258 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
@@ -4888,7 +4888,7 @@ discard block |
||
| 4888 | 4888 | // No? try a fallback to $sourcedir |
| 4889 | 4889 | else |
| 4890 | 4890 | { |
| 4891 | - $absPath = $sourcedir .'/'. $file; |
|
| 4891 | + $absPath = $sourcedir . '/' . $file; |
|
| 4892 | 4892 | |
| 4893 | 4893 | if (file_exists($absPath)) |
| 4894 | 4894 | require_once($absPath); |
@@ -5155,15 +5155,15 @@ discard block |
||
| 5155 | 5155 | |
| 5156 | 5156 | // UTF-8 occurences of MS special characters |
| 5157 | 5157 | $findchars_utf8 = array( |
| 5158 | - "\xe2\x80\x9a", // single low-9 quotation mark |
|
| 5159 | - "\xe2\x80\x9e", // double low-9 quotation mark |
|
| 5160 | - "\xe2\x80\xa6", // horizontal ellipsis |
|
| 5161 | - "\xe2\x80\x98", // left single curly quote |
|
| 5162 | - "\xe2\x80\x99", // right single curly quote |
|
| 5163 | - "\xe2\x80\x9c", // left double curly quote |
|
| 5164 | - "\xe2\x80\x9d", // right double curly quote |
|
| 5165 | - "\xe2\x80\x93", // en dash |
|
| 5166 | - "\xe2\x80\x94", // em dash |
|
| 5158 | + "\xe2\x80\x9a", // single low-9 quotation mark |
|
| 5159 | + "\xe2\x80\x9e", // double low-9 quotation mark |
|
| 5160 | + "\xe2\x80\xa6", // horizontal ellipsis |
|
| 5161 | + "\xe2\x80\x98", // left single curly quote |
|
| 5162 | + "\xe2\x80\x99", // right single curly quote |
|
| 5163 | + "\xe2\x80\x9c", // left double curly quote |
|
| 5164 | + "\xe2\x80\x9d", // right double curly quote |
|
| 5165 | + "\xe2\x80\x93", // en dash |
|
| 5166 | + "\xe2\x80\x94", // em dash |
|
| 5167 | 5167 | ); |
| 5168 | 5168 | |
| 5169 | 5169 | // windows 1252 / iso equivalents |
@@ -5181,15 +5181,15 @@ discard block |
||
| 5181 | 5181 | |
| 5182 | 5182 | // safe replacements |
| 5183 | 5183 | $replacechars = array( |
| 5184 | - ',', // ‚ |
|
| 5185 | - ',,', // „ |
|
| 5186 | - '...', // … |
|
| 5187 | - "'", // ‘ |
|
| 5188 | - "'", // ’ |
|
| 5189 | - '"', // “ |
|
| 5190 | - '"', // ” |
|
| 5191 | - '-', // – |
|
| 5192 | - '--', // — |
|
| 5184 | + ',', // ‚ |
|
| 5185 | + ',,', // „ |
|
| 5186 | + '...', // … |
|
| 5187 | + "'", // ‘ |
|
| 5188 | + "'", // ’ |
|
| 5189 | + '"', // “ |
|
| 5190 | + '"', // ” |
|
| 5191 | + '-', // – |
|
| 5192 | + '--', // — |
|
| 5193 | 5193 | ); |
| 5194 | 5194 | |
| 5195 | 5195 | if ($context['utf8']) |
@@ -5509,7 +5509,7 @@ discard block |
||
| 5509 | 5509 | */ |
| 5510 | 5510 | function inet_dtop($bin) |
| 5511 | 5511 | { |
| 5512 | - if(empty($bin)) |
|
| 5512 | + if (empty($bin)) |
|
| 5513 | 5513 | return ''; |
| 5514 | 5514 | |
| 5515 | 5515 | global $db_type; |
@@ -5540,28 +5540,28 @@ discard block |
||
| 5540 | 5540 | */ |
| 5541 | 5541 | function _safe_serialize($value) |
| 5542 | 5542 | { |
| 5543 | - if(is_null($value)) |
|
| 5543 | + if (is_null($value)) |
|
| 5544 | 5544 | return 'N;'; |
| 5545 | 5545 | |
| 5546 | - if(is_bool($value)) |
|
| 5547 | - return 'b:'. (int) $value .';'; |
|
| 5546 | + if (is_bool($value)) |
|
| 5547 | + return 'b:' . (int) $value . ';'; |
|
| 5548 | 5548 | |
| 5549 | - if(is_int($value)) |
|
| 5550 | - return 'i:'. $value .';'; |
|
| 5549 | + if (is_int($value)) |
|
| 5550 | + return 'i:' . $value . ';'; |
|
| 5551 | 5551 | |
| 5552 | - if(is_float($value)) |
|
| 5553 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
| 5552 | + if (is_float($value)) |
|
| 5553 | + return 'd:' . str_replace(',', '.', $value) . ';'; |
|
| 5554 | 5554 | |
| 5555 | - if(is_string($value)) |
|
| 5556 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
| 5555 | + if (is_string($value)) |
|
| 5556 | + return 's:' . strlen($value) . ':"' . $value . '";'; |
|
| 5557 | 5557 | |
| 5558 | - if(is_array($value)) |
|
| 5558 | + if (is_array($value)) |
|
| 5559 | 5559 | { |
| 5560 | 5560 | $out = ''; |
| 5561 | - foreach($value as $k => $v) |
|
| 5561 | + foreach ($value as $k => $v) |
|
| 5562 | 5562 | $out .= _safe_serialize($k) . _safe_serialize($v); |
| 5563 | 5563 | |
| 5564 | - return 'a:'. count($value) .':{'. $out .'}'; |
|
| 5564 | + return 'a:' . count($value) . ':{' . $out . '}'; |
|
| 5565 | 5565 | } |
| 5566 | 5566 | |
| 5567 | 5567 | // safe_serialize cannot serialize resources or objects. |
@@ -5603,7 +5603,7 @@ discard block |
||
| 5603 | 5603 | function _safe_unserialize($str) |
| 5604 | 5604 | { |
| 5605 | 5605 | // Input is not a string. |
| 5606 | - if(empty($str) || !is_string($str)) |
|
| 5606 | + if (empty($str) || !is_string($str)) |
|
| 5607 | 5607 | return false; |
| 5608 | 5608 | |
| 5609 | 5609 | $stack = array(); |
@@ -5617,40 +5617,40 @@ discard block |
||
| 5617 | 5617 | * 3 - in array, expecting value or another array |
| 5618 | 5618 | */ |
| 5619 | 5619 | $state = 0; |
| 5620 | - while($state != 1) |
|
| 5620 | + while ($state != 1) |
|
| 5621 | 5621 | { |
| 5622 | 5622 | $type = isset($str[0]) ? $str[0] : ''; |
| 5623 | - if($type == '}') |
|
| 5623 | + if ($type == '}') |
|
| 5624 | 5624 | $str = substr($str, 1); |
| 5625 | 5625 | |
| 5626 | - else if($type == 'N' && $str[1] == ';') |
|
| 5626 | + else if ($type == 'N' && $str[1] == ';') |
|
| 5627 | 5627 | { |
| 5628 | 5628 | $value = null; |
| 5629 | 5629 | $str = substr($str, 2); |
| 5630 | 5630 | } |
| 5631 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
| 5631 | + else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
| 5632 | 5632 | { |
| 5633 | 5633 | $value = $matches[1] == '1' ? true : false; |
| 5634 | 5634 | $str = substr($str, 4); |
| 5635 | 5635 | } |
| 5636 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
| 5636 | + else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
| 5637 | 5637 | { |
| 5638 | - $value = (int)$matches[1]; |
|
| 5638 | + $value = (int) $matches[1]; |
|
| 5639 | 5639 | $str = $matches[2]; |
| 5640 | 5640 | } |
| 5641 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
| 5641 | + else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
| 5642 | 5642 | { |
| 5643 | - $value = (float)$matches[1]; |
|
| 5643 | + $value = (float) $matches[1]; |
|
| 5644 | 5644 | $str = $matches[3]; |
| 5645 | 5645 | } |
| 5646 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
| 5646 | + else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";') |
|
| 5647 | 5647 | { |
| 5648 | - $value = substr($matches[2], 0, (int)$matches[1]); |
|
| 5649 | - $str = substr($matches[2], (int)$matches[1] + 2); |
|
| 5648 | + $value = substr($matches[2], 0, (int) $matches[1]); |
|
| 5649 | + $str = substr($matches[2], (int) $matches[1] + 2); |
|
| 5650 | 5650 | } |
| 5651 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
| 5651 | + else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
| 5652 | 5652 | { |
| 5653 | - $expectedLength = (int)$matches[1]; |
|
| 5653 | + $expectedLength = (int) $matches[1]; |
|
| 5654 | 5654 | $str = $matches[2]; |
| 5655 | 5655 | } |
| 5656 | 5656 | |
@@ -5658,10 +5658,10 @@ discard block |
||
| 5658 | 5658 | else |
| 5659 | 5659 | return false; |
| 5660 | 5660 | |
| 5661 | - switch($state) |
|
| 5661 | + switch ($state) |
|
| 5662 | 5662 | { |
| 5663 | 5663 | case 3: // In array, expecting value or another array. |
| 5664 | - if($type == 'a') |
|
| 5664 | + if ($type == 'a') |
|
| 5665 | 5665 | { |
| 5666 | 5666 | $stack[] = &$list; |
| 5667 | 5667 | $list[$key] = array(); |
@@ -5670,7 +5670,7 @@ discard block |
||
| 5670 | 5670 | $state = 2; |
| 5671 | 5671 | break; |
| 5672 | 5672 | } |
| 5673 | - if($type != '}') |
|
| 5673 | + if ($type != '}') |
|
| 5674 | 5674 | { |
| 5675 | 5675 | $list[$key] = $value; |
| 5676 | 5676 | $state = 2; |
@@ -5681,29 +5681,29 @@ discard block |
||
| 5681 | 5681 | return false; |
| 5682 | 5682 | |
| 5683 | 5683 | case 2: // in array, expecting end of array or a key |
| 5684 | - if($type == '}') |
|
| 5684 | + if ($type == '}') |
|
| 5685 | 5685 | { |
| 5686 | 5686 | // Array size is less than expected. |
| 5687 | - if(count($list) < end($expected)) |
|
| 5687 | + if (count($list) < end($expected)) |
|
| 5688 | 5688 | return false; |
| 5689 | 5689 | |
| 5690 | 5690 | unset($list); |
| 5691 | - $list = &$stack[count($stack)-1]; |
|
| 5691 | + $list = &$stack[count($stack) - 1]; |
|
| 5692 | 5692 | array_pop($stack); |
| 5693 | 5693 | |
| 5694 | 5694 | // Go to terminal state if we're at the end of the root array. |
| 5695 | 5695 | array_pop($expected); |
| 5696 | 5696 | |
| 5697 | - if(count($expected) == 0) |
|
| 5697 | + if (count($expected) == 0) |
|
| 5698 | 5698 | $state = 1; |
| 5699 | 5699 | |
| 5700 | 5700 | break; |
| 5701 | 5701 | } |
| 5702 | 5702 | |
| 5703 | - if($type == 'i' || $type == 's') |
|
| 5703 | + if ($type == 'i' || $type == 's') |
|
| 5704 | 5704 | { |
| 5705 | 5705 | // Array size exceeds expected length. |
| 5706 | - if(count($list) >= end($expected)) |
|
| 5706 | + if (count($list) >= end($expected)) |
|
| 5707 | 5707 | return false; |
| 5708 | 5708 | |
| 5709 | 5709 | $key = $value; |
@@ -5716,7 +5716,7 @@ discard block |
||
| 5716 | 5716 | |
| 5717 | 5717 | // Expecting array or value. |
| 5718 | 5718 | case 0: |
| 5719 | - if($type == 'a') |
|
| 5719 | + if ($type == 'a') |
|
| 5720 | 5720 | { |
| 5721 | 5721 | $data = array(); |
| 5722 | 5722 | $list = &$data; |
@@ -5725,7 +5725,7 @@ discard block |
||
| 5725 | 5725 | break; |
| 5726 | 5726 | } |
| 5727 | 5727 | |
| 5728 | - if($type != '}') |
|
| 5728 | + if ($type != '}') |
|
| 5729 | 5729 | { |
| 5730 | 5730 | $data = $value; |
| 5731 | 5731 | $state = 1; |
@@ -5738,7 +5738,7 @@ discard block |
||
| 5738 | 5738 | } |
| 5739 | 5739 | |
| 5740 | 5740 | // Trailing data in input. |
| 5741 | - if(!empty($str)) |
|
| 5741 | + if (!empty($str)) |
|
| 5742 | 5742 | return false; |
| 5743 | 5743 | |
| 5744 | 5744 | return $data; |
@@ -5792,7 +5792,7 @@ discard block |
||
| 5792 | 5792 | // Set different modes. |
| 5793 | 5793 | $chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666); |
| 5794 | 5794 | |
| 5795 | - foreach($chmodValues as $val) |
|
| 5795 | + foreach ($chmodValues as $val) |
|
| 5796 | 5796 | { |
| 5797 | 5797 | // If it's writable, break out of the loop. |
| 5798 | 5798 | if (is_writable($file)) |
@@ -5827,13 +5827,13 @@ discard block |
||
| 5827 | 5827 | $returnArray = @json_decode($json, $returnAsArray); |
| 5828 | 5828 | |
| 5829 | 5829 | // PHP 5.3 so no json_last_error_msg() |
| 5830 | - switch(json_last_error()) |
|
| 5830 | + switch (json_last_error()) |
|
| 5831 | 5831 | { |
| 5832 | 5832 | case JSON_ERROR_NONE: |
| 5833 | 5833 | $jsonError = false; |
| 5834 | 5834 | break; |
| 5835 | 5835 | case JSON_ERROR_DEPTH: |
| 5836 | - $jsonError = 'JSON_ERROR_DEPTH'; |
|
| 5836 | + $jsonError = 'JSON_ERROR_DEPTH'; |
|
| 5837 | 5837 | break; |
| 5838 | 5838 | case JSON_ERROR_STATE_MISMATCH: |
| 5839 | 5839 | $jsonError = 'JSON_ERROR_STATE_MISMATCH'; |
@@ -5861,10 +5861,10 @@ discard block |
||
| 5861 | 5861 | loadLanguage('Errors'); |
| 5862 | 5862 | |
| 5863 | 5863 | if (!empty($jsonDebug)) |
| 5864 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
| 5864 | + log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
| 5865 | 5865 | |
| 5866 | 5866 | else |
| 5867 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
| 5867 | + log_error($txt['json_' . $jsonError], 'critical'); |
|
| 5868 | 5868 | |
| 5869 | 5869 | // Everyone expects an array. |
| 5870 | 5870 | return array(); |
@@ -5981,7 +5981,7 @@ discard block |
||
| 5981 | 5981 | // Convert Punycode to Unicode |
| 5982 | 5982 | require_once($sourcedir . '/Class-Punycode.php'); |
| 5983 | 5983 | $Punycode = new Punycode(); |
| 5984 | - $tlds = array_map(function ($input) use ($Punycode) { return $Punycode->decode($input); }, $tlds); |
|
| 5984 | + $tlds = array_map(function($input) use ($Punycode) { return $Punycode->decode($input); }, $tlds); |
|
| 5985 | 5985 | } |
| 5986 | 5986 | // Otherwise, use the 2012 list of gTLDs and ccTLDs for now and schedule a background update |
| 5987 | 5987 | else |
@@ -6075,7 +6075,7 @@ discard block |
||
| 6075 | 6075 | } |
| 6076 | 6076 | |
| 6077 | 6077 | // This recursive function creates the index array from the strings |
| 6078 | - $add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index) |
|
| 6078 | + $add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index) |
|
| 6079 | 6079 | { |
| 6080 | 6080 | static $depth = 0; |
| 6081 | 6081 | $depth++; |
@@ -6102,7 +6102,7 @@ discard block |
||
| 6102 | 6102 | }; |
| 6103 | 6103 | |
| 6104 | 6104 | // This recursive function turns the index array into a regular expression |
| 6105 | - $index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex) |
|
| 6105 | + $index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex) |
|
| 6106 | 6106 | { |
| 6107 | 6107 | static $depth = 0; |
| 6108 | 6108 | $depth++; |
@@ -6126,11 +6126,11 @@ discard block |
||
| 6126 | 6126 | |
| 6127 | 6127 | if (count(array_keys($value)) == 1) |
| 6128 | 6128 | { |
| 6129 | - $new_key_array = explode('(?'.'>', $sub_regex); |
|
| 6129 | + $new_key_array = explode('(?' . '>', $sub_regex); |
|
| 6130 | 6130 | $new_key .= $new_key_array[0]; |
| 6131 | 6131 | } |
| 6132 | 6132 | else |
| 6133 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
| 6133 | + $sub_regex = '(?' . '>' . $sub_regex . ')'; |
|
| 6134 | 6134 | } |
| 6135 | 6135 | |
| 6136 | 6136 | if ($depth > 1) |
@@ -6173,10 +6173,10 @@ discard block |
||
| 6173 | 6173 | { |
| 6174 | 6174 | $regex = array(); |
| 6175 | 6175 | while (!empty($index)) |
| 6176 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6176 | + $regex[] = '(?' . '>' . $index_to_regex($index, $delim) . ')'; |
|
| 6177 | 6177 | } |
| 6178 | 6178 | else |
| 6179 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6179 | + $regex = '(?' . '>' . $index_to_regex($index, $delim) . ')'; |
|
| 6180 | 6180 | |
| 6181 | 6181 | // Restore PHP's internal character encoding to whatever it was originally |
| 6182 | 6182 | if (!empty($current_encoding)) |
@@ -6341,11 +6341,11 @@ discard block |
||
| 6341 | 6341 | // Otherwise just the groups in $user_info['groups']. |
| 6342 | 6342 | else |
| 6343 | 6343 | { |
| 6344 | - $query_part['query_see_board'] = 'EXISTS (SELECT DISTINCT bpv.id_board FROM ' . $db_prefix . 'board_permissions_view bpv WHERE (bpv.id_group IN ( '. implode(',', $groups) .') AND bpv.deny = 0) ' |
|
| 6345 | - . ( !empty($deny_boards_access) ? ' AND (bpv.id_group NOT IN ( '. implode(',', $groups) .') and bpv.deny = 1)' : '') |
|
| 6344 | + $query_part['query_see_board'] = 'EXISTS (SELECT DISTINCT bpv.id_board FROM ' . $db_prefix . 'board_permissions_view bpv WHERE (bpv.id_group IN ( ' . implode(',', $groups) . ') AND bpv.deny = 0) ' |
|
| 6345 | + . (!empty($deny_boards_access) ? ' AND (bpv.id_group NOT IN ( ' . implode(',', $groups) . ') and bpv.deny = 1)' : '') |
|
| 6346 | 6346 | . ' AND bpv.id_board = b.id_board)'; |
| 6347 | - $query_part['query_see_board_join'] = 'JOIN (SELECT DISTINCT id_board FROM ' . $db_prefix . 'board_permissions_view WHERE (id_group IN ( '. implode(',', $groups) .') AND deny = 0) ' |
|
| 6348 | - . ( !empty($deny_boards_access) ? ' AND (id_group NOT IN ( '. implode(',', $groups) .') and deny = 1)' : '') |
|
| 6347 | + $query_part['query_see_board_join'] = 'JOIN (SELECT DISTINCT id_board FROM ' . $db_prefix . 'board_permissions_view WHERE (id_group IN ( ' . implode(',', $groups) . ') AND deny = 0) ' |
|
| 6348 | + . (!empty($deny_boards_access) ? ' AND (id_group NOT IN ( ' . implode(',', $groups) . ') and deny = 1)' : '') |
|
| 6349 | 6349 | . ') bpv ON (bpv.id_board = b.id_board)'; |
| 6350 | 6350 | } |
| 6351 | 6351 | |
@@ -6410,7 +6410,7 @@ discard block |
||
| 6410 | 6410 | function sanitize_iri($iri) |
| 6411 | 6411 | { |
| 6412 | 6412 | // Encode any non-ASCII characters (but not space or control characters of any sort) |
| 6413 | - $iri = preg_replace_callback('~[^\x00-\x7F\pZ\pC]~u', function ($matches) { |
|
| 6413 | + $iri = preg_replace_callback('~[^\x00-\x7F\pZ\pC]~u', function($matches) { |
|
| 6414 | 6414 | return rawurlencode($matches[0]); |
| 6415 | 6415 | }, $iri); |
| 6416 | 6416 | |
@@ -6452,7 +6452,7 @@ discard block |
||
| 6452 | 6452 | $unescaped = array( |
| 6453 | 6453 | '%21'=>'!', '%23'=>'#', '%24'=>'$', '%26'=>'&', |
| 6454 | 6454 | '%27'=>"'", '%28'=>'(', '%29'=>')', '%2A'=>'*', |
| 6455 | - '%2B'=>'+', '%2C'=>',', '%2F'=>'/', '%3A'=>':', |
|
| 6455 | + '%2B'=>'+', '%2C'=>',', '%2F'=>'/', '%3A'=>':', |
|
| 6456 | 6456 | '%3B'=>';', '%3D'=>'=', '%3F'=>'?', '%40'=>'@', |
| 6457 | 6457 | ); |
| 6458 | 6458 | $iri = strtr(rawurlencode($iri), $unescaped); |