@@ -247,7 +247,7 @@ |
||
247 | 247 | } |
248 | 248 | $smcFunc['db_free_result']($request); |
249 | 249 | |
250 | - if($withSender) |
|
250 | + if ($withSender) |
|
251 | 251 | { |
252 | 252 | $senders = loadMemberData($senders); |
253 | 253 | foreach ($senders as $member) |
@@ -11,8 +11,9 @@ discard block |
||
11 | 11 | * @version 2.1 Beta 4 |
12 | 12 | */ |
13 | 13 | |
14 | -if (!defined('SMF')) |
|
14 | +if (!defined('SMF')) { |
|
15 | 15 | die('No direct access...'); |
16 | +} |
|
16 | 17 | |
17 | 18 | /** |
18 | 19 | * View a summary. |
@@ -23,8 +24,9 @@ discard block |
||
23 | 24 | global $context, $memberContext, $txt, $modSettings, $user_profile, $sourcedir, $scripturl, $smcFunc; |
24 | 25 | |
25 | 26 | // Attempt to load the member's profile data. |
26 | - if (!loadMemberContext($memID) || !isset($memberContext[$memID])) |
|
27 | - fatal_lang_error('not_a_user', false, 404); |
|
27 | + if (!loadMemberContext($memID) || !isset($memberContext[$memID])) { |
|
28 | + fatal_lang_error('not_a_user', false, 404); |
|
29 | + } |
|
28 | 30 | |
29 | 31 | // Set up the stuff and load the user. |
30 | 32 | $context += array( |
@@ -49,19 +51,21 @@ discard block |
||
49 | 51 | |
50 | 52 | // See if they have broken any warning levels... |
51 | 53 | list ($modSettings['warning_enable'], $modSettings['user_limit']) = explode(',', $modSettings['warning_settings']); |
52 | - if (!empty($modSettings['warning_mute']) && $modSettings['warning_mute'] <= $context['member']['warning']) |
|
53 | - $context['warning_status'] = $txt['profile_warning_is_muted']; |
|
54 | - elseif (!empty($modSettings['warning_moderate']) && $modSettings['warning_moderate'] <= $context['member']['warning']) |
|
55 | - $context['warning_status'] = $txt['profile_warning_is_moderation']; |
|
56 | - elseif (!empty($modSettings['warning_watch']) && $modSettings['warning_watch'] <= $context['member']['warning']) |
|
57 | - $context['warning_status'] = $txt['profile_warning_is_watch']; |
|
54 | + if (!empty($modSettings['warning_mute']) && $modSettings['warning_mute'] <= $context['member']['warning']) { |
|
55 | + $context['warning_status'] = $txt['profile_warning_is_muted']; |
|
56 | + } elseif (!empty($modSettings['warning_moderate']) && $modSettings['warning_moderate'] <= $context['member']['warning']) { |
|
57 | + $context['warning_status'] = $txt['profile_warning_is_moderation']; |
|
58 | + } elseif (!empty($modSettings['warning_watch']) && $modSettings['warning_watch'] <= $context['member']['warning']) { |
|
59 | + $context['warning_status'] = $txt['profile_warning_is_watch']; |
|
60 | + } |
|
58 | 61 | |
59 | 62 | // They haven't even been registered for a full day!? |
60 | 63 | $days_registered = (int) ((time() - $user_profile[$memID]['date_registered']) / (3600 * 24)); |
61 | - if (empty($user_profile[$memID]['date_registered']) || $days_registered < 1) |
|
62 | - $context['member']['posts_per_day'] = $txt['not_applicable']; |
|
63 | - else |
|
64 | - $context['member']['posts_per_day'] = comma_format($context['member']['real_posts'] / $days_registered, 3); |
|
64 | + if (empty($user_profile[$memID]['date_registered']) || $days_registered < 1) { |
|
65 | + $context['member']['posts_per_day'] = $txt['not_applicable']; |
|
66 | + } else { |
|
67 | + $context['member']['posts_per_day'] = comma_format($context['member']['real_posts'] / $days_registered, 3); |
|
68 | + } |
|
65 | 69 | |
66 | 70 | // Set the age... |
67 | 71 | if (empty($context['member']['birth_date']) || substr($context['member']['birth_date'], 0, 4) < 1002) |
@@ -70,8 +74,7 @@ discard block |
||
70 | 74 | 'age' => $txt['not_applicable'], |
71 | 75 | 'today_is_birthday' => false |
72 | 76 | ); |
73 | - } |
|
74 | - else |
|
77 | + } else |
|
75 | 78 | { |
76 | 79 | list ($birth_year, $birth_month, $birth_day) = sscanf($context['member']['birth_date'], '%d-%d-%d'); |
77 | 80 | $datearray = getdate(forum_time()); |
@@ -84,15 +87,16 @@ discard block |
||
84 | 87 | if (allowedTo('moderate_forum')) |
85 | 88 | { |
86 | 89 | // Make sure it's a valid ip address; otherwise, don't bother... |
87 | - if (preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/', $memberContext[$memID]['ip']) == 1 && empty($modSettings['disableHostnameLookup'])) |
|
88 | - $context['member']['hostname'] = host_from_ip($memberContext[$memID]['ip']); |
|
89 | - else |
|
90 | - $context['member']['hostname'] = ''; |
|
90 | + if (preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/', $memberContext[$memID]['ip']) == 1 && empty($modSettings['disableHostnameLookup'])) { |
|
91 | + $context['member']['hostname'] = host_from_ip($memberContext[$memID]['ip']); |
|
92 | + } else { |
|
93 | + $context['member']['hostname'] = ''; |
|
94 | + } |
|
91 | 95 | |
92 | 96 | $context['can_see_ip'] = true; |
97 | + } else { |
|
98 | + $context['can_see_ip'] = false; |
|
93 | 99 | } |
94 | - else |
|
95 | - $context['can_see_ip'] = false; |
|
96 | 100 | |
97 | 101 | // Are they hidden? |
98 | 102 | $context['member']['is_hidden'] = empty($user_profile[$memID]['show_online']); |
@@ -103,8 +107,9 @@ discard block |
||
103 | 107 | include_once($sourcedir . '/Who.php'); |
104 | 108 | $action = determineActions($user_profile[$memID]['url']); |
105 | 109 | |
106 | - if ($action !== false) |
|
107 | - $context['member']['action'] = $action; |
|
110 | + if ($action !== false) { |
|
111 | + $context['member']['action'] = $action; |
|
112 | + } |
|
108 | 113 | } |
109 | 114 | |
110 | 115 | // If the user is awaiting activation, and the viewer has permission - setup some activation context messages. |
@@ -167,13 +172,15 @@ discard block |
||
167 | 172 | { |
168 | 173 | // Work out what restrictions we actually have. |
169 | 174 | $ban_restrictions = array(); |
170 | - foreach (array('access', 'login', 'post') as $type) |
|
171 | - if ($row['cannot_' . $type]) |
|
175 | + foreach (array('access', 'login', 'post') as $type) { |
|
176 | + if ($row['cannot_' . $type]) |
|
172 | 177 | $ban_restrictions[] = $txt['ban_type_' . $type]; |
178 | + } |
|
173 | 179 | |
174 | 180 | // No actual ban in place? |
175 | - if (empty($ban_restrictions)) |
|
176 | - continue; |
|
181 | + if (empty($ban_restrictions)) { |
|
182 | + continue; |
|
183 | + } |
|
177 | 184 | |
178 | 185 | // Prepare the link for context. |
179 | 186 | $ban_explanation = sprintf($txt['user_cannot_due_to'], implode(', ', $ban_restrictions), '<a href="' . $scripturl . '?action=admin;area=ban;sa=edit;bg=' . $row['id_ban_group'] . '">' . $row['name'] . '</a>'); |
@@ -195,9 +202,10 @@ discard block |
||
195 | 202 | $context['print_custom_fields'] = array(); |
196 | 203 | |
197 | 204 | // Any custom profile fields? |
198 | - if (!empty($context['custom_fields'])) |
|
199 | - foreach ($context['custom_fields'] as $custom) |
|
205 | + if (!empty($context['custom_fields'])) { |
|
206 | + foreach ($context['custom_fields'] as $custom) |
|
200 | 207 | $context['print_custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom; |
208 | + } |
|
201 | 209 | |
202 | 210 | } |
203 | 211 | |
@@ -242,16 +250,18 @@ discard block |
||
242 | 250 | $row['extra'] = !empty($row['extra']) ? $smcFunc['json_decode']($row['extra'], true) : array(); |
243 | 251 | $alerts[$id_alert] = $row; |
244 | 252 | |
245 | - if (!empty($row['sender_id'])) |
|
246 | - $senders[] = $row['sender_id']; |
|
253 | + if (!empty($row['sender_id'])) { |
|
254 | + $senders[] = $row['sender_id']; |
|
255 | + } |
|
247 | 256 | } |
248 | 257 | $smcFunc['db_free_result']($request); |
249 | 258 | |
250 | 259 | if($withSender) |
251 | 260 | { |
252 | 261 | $senders = loadMemberData($senders); |
253 | - foreach ($senders as $member) |
|
254 | - loadMemberContext($member); |
|
262 | + foreach ($senders as $member) { |
|
263 | + loadMemberContext($member); |
|
264 | + } |
|
255 | 265 | } |
256 | 266 | |
257 | 267 | // Now go through and actually make with the text. |
@@ -266,12 +276,15 @@ discard block |
||
266 | 276 | $msgs = array(); |
267 | 277 | foreach ($alerts as $id_alert => $alert) |
268 | 278 | { |
269 | - if (isset($alert['extra']['board'])) |
|
270 | - $boards[$alert['extra']['board']] = $txt['board_na']; |
|
271 | - if (isset($alert['extra']['topic'])) |
|
272 | - $topics[$alert['extra']['topic']] = $txt['topic_na']; |
|
273 | - if ($alert['content_type'] == 'msg') |
|
274 | - $msgs[$alert['content_id']] = $txt['topic_na']; |
|
279 | + if (isset($alert['extra']['board'])) { |
|
280 | + $boards[$alert['extra']['board']] = $txt['board_na']; |
|
281 | + } |
|
282 | + if (isset($alert['extra']['topic'])) { |
|
283 | + $topics[$alert['extra']['topic']] = $txt['topic_na']; |
|
284 | + } |
|
285 | + if ($alert['content_type'] == 'msg') { |
|
286 | + $msgs[$alert['content_id']] = $txt['topic_na']; |
|
287 | + } |
|
275 | 288 | } |
276 | 289 | |
277 | 290 | // Having figured out what boards etc. there are, let's now get the names of them if we can see them. If not, there's already a fallback set up. |
@@ -286,8 +299,9 @@ discard block |
||
286 | 299 | 'boards' => array_keys($boards), |
287 | 300 | ) |
288 | 301 | ); |
289 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
290 | - $boards[$row['id_board']] = '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>'; |
|
302 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
303 | + $boards[$row['id_board']] = '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>'; |
|
304 | + } |
|
291 | 305 | } |
292 | 306 | if (!empty($topics)) |
293 | 307 | { |
@@ -302,8 +316,9 @@ discard block |
||
302 | 316 | 'topics' => array_keys($topics), |
303 | 317 | ) |
304 | 318 | ); |
305 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
306 | - $topics[$row['id_topic']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['subject'] . '</a>'; |
|
319 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
320 | + $topics[$row['id_topic']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['subject'] . '</a>'; |
|
321 | + } |
|
307 | 322 | } |
308 | 323 | if (!empty($msgs)) |
309 | 324 | { |
@@ -318,44 +333,51 @@ discard block |
||
318 | 333 | 'msgs' => array_keys($msgs), |
319 | 334 | ) |
320 | 335 | ); |
321 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
322 | - $msgs[$row['id_msg']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>'; |
|
336 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
337 | + $msgs[$row['id_msg']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>'; |
|
338 | + } |
|
323 | 339 | } |
324 | 340 | |
325 | 341 | // Now to go back through the alerts, reattach this extra information and then try to build the string out of it (if a hook didn't already) |
326 | 342 | foreach ($alerts as $id_alert => $alert) |
327 | 343 | { |
328 | - if (!empty($alert['text'])) |
|
329 | - continue; |
|
330 | - if (isset($alert['extra']['board'])) |
|
331 | - if ($boards[$alert['extra']['board']] == $txt['board_na']) |
|
344 | + if (!empty($alert['text'])) { |
|
345 | + continue; |
|
346 | + } |
|
347 | + if (isset($alert['extra']['board'])) { |
|
348 | + if ($boards[$alert['extra']['board']] == $txt['board_na']) |
|
332 | 349 | { |
333 | 350 | unset($alerts[$id_alert]); |
351 | + } |
|
334 | 352 | continue; |
353 | + } else { |
|
354 | + $alerts[$id_alert]['extra']['board_msg'] = $boards[$alert['extra']['board']]; |
|
335 | 355 | } |
336 | - else |
|
337 | - $alerts[$id_alert]['extra']['board_msg'] = $boards[$alert['extra']['board']]; |
|
338 | - if (isset($alert['extra']['topic'])) |
|
339 | - if ($alert['extra']['topic'] == $txt['topic_na']) |
|
356 | + if (isset($alert['extra']['topic'])) { |
|
357 | + if ($alert['extra']['topic'] == $txt['topic_na']) |
|
340 | 358 | { |
341 | 359 | unset($alerts[$id_alert]); |
360 | + } |
|
342 | 361 | continue; |
362 | + } else { |
|
363 | + $alerts[$id_alert]['extra']['topic_msg'] = $topics[$alert['extra']['topic']]; |
|
343 | 364 | } |
344 | - else |
|
345 | - $alerts[$id_alert]['extra']['topic_msg'] = $topics[$alert['extra']['topic']]; |
|
346 | - if ($alert['content_type'] == 'msg') |
|
347 | - if ($msgs[$alert['content_id']] == $txt['topic_na']) |
|
365 | + if ($alert['content_type'] == 'msg') { |
|
366 | + if ($msgs[$alert['content_id']] == $txt['topic_na']) |
|
348 | 367 | { |
349 | 368 | unset($alerts[$id_alert]); |
369 | + } |
|
350 | 370 | continue; |
351 | - } |
|
352 | - else |
|
353 | - $alerts[$id_alert]['extra']['msg_msg'] = $msgs[$alert['content_id']]; |
|
354 | - if ($alert['content_type'] == 'profile') |
|
355 | - $alerts[$id_alert]['extra']['profile_msg'] = '<a href="' . $scripturl . '?action=profile;u=' . $alerts[$id_alert]['content_id'] . '">' . $alerts[$id_alert]['extra']['user_name'] . '</a>'; |
|
371 | + } else { |
|
372 | + $alerts[$id_alert]['extra']['msg_msg'] = $msgs[$alert['content_id']]; |
|
373 | + } |
|
374 | + if ($alert['content_type'] == 'profile') { |
|
375 | + $alerts[$id_alert]['extra']['profile_msg'] = '<a href="' . $scripturl . '?action=profile;u=' . $alerts[$id_alert]['content_id'] . '">' . $alerts[$id_alert]['extra']['user_name'] . '</a>'; |
|
376 | + } |
|
356 | 377 | |
357 | - if (!empty($memberContext[$alert['sender_id']])) |
|
358 | - $alerts[$id_alert]['sender'] = &$memberContext[$alert['sender_id']]; |
|
378 | + if (!empty($memberContext[$alert['sender_id']])) { |
|
379 | + $alerts[$id_alert]['sender'] = &$memberContext[$alert['sender_id']]; |
|
380 | + } |
|
359 | 381 | |
360 | 382 | $string = 'alert_' . $alert['content_type'] . '_' . $alert['content_action']; |
361 | 383 | if (isset($txt[$string])) |
@@ -443,11 +465,11 @@ discard block |
||
443 | 465 | checkSession('request'); |
444 | 466 | |
445 | 467 | // Call it! |
446 | - if ($action == 'remove') |
|
447 | - alert_delete($toMark, $memID); |
|
448 | - |
|
449 | - else |
|
450 | - alert_mark($memID, $toMark, $action == 'read' ? 1 : 0); |
|
468 | + if ($action == 'remove') { |
|
469 | + alert_delete($toMark, $memID); |
|
470 | + } else { |
|
471 | + alert_mark($memID, $toMark, $action == 'read' ? 1 : 0); |
|
472 | + } |
|
451 | 473 | |
452 | 474 | // Set a nice update message. |
453 | 475 | $_SESSION['update_message'] = true; |
@@ -497,23 +519,27 @@ discard block |
||
497 | 519 | ); |
498 | 520 | |
499 | 521 | // Set the page title |
500 | - if (isset($_GET['sa']) && array_key_exists($_GET['sa'], $title)) |
|
501 | - $context['page_title'] = $txt['show' . $title[$_GET['sa']]]; |
|
502 | - else |
|
503 | - $context['page_title'] = $txt['showPosts']; |
|
522 | + if (isset($_GET['sa']) && array_key_exists($_GET['sa'], $title)) { |
|
523 | + $context['page_title'] = $txt['show' . $title[$_GET['sa']]]; |
|
524 | + } else { |
|
525 | + $context['page_title'] = $txt['showPosts']; |
|
526 | + } |
|
504 | 527 | |
505 | 528 | $context['page_title'] .= ' - ' . $user_profile[$memID]['real_name']; |
506 | 529 | |
507 | 530 | // Is the load average too high to allow searching just now? |
508 | - if (!empty($context['load_average']) && !empty($modSettings['loadavg_show_posts']) && $context['load_average'] >= $modSettings['loadavg_show_posts']) |
|
509 | - fatal_lang_error('loadavg_show_posts_disabled', false); |
|
531 | + if (!empty($context['load_average']) && !empty($modSettings['loadavg_show_posts']) && $context['load_average'] >= $modSettings['loadavg_show_posts']) { |
|
532 | + fatal_lang_error('loadavg_show_posts_disabled', false); |
|
533 | + } |
|
510 | 534 | |
511 | 535 | // If we're specifically dealing with attachments use that function! |
512 | - if (isset($_GET['sa']) && $_GET['sa'] == 'attach') |
|
513 | - return showAttachments($memID); |
|
536 | + if (isset($_GET['sa']) && $_GET['sa'] == 'attach') { |
|
537 | + return showAttachments($memID); |
|
538 | + } |
|
514 | 539 | // Instead, if we're dealing with unwatched topics (and the feature is enabled) use that other function. |
515 | - elseif (isset($_GET['sa']) && $_GET['sa'] == 'unwatchedtopics') |
|
516 | - return showUnwatched($memID); |
|
540 | + elseif (isset($_GET['sa']) && $_GET['sa'] == 'unwatchedtopics') { |
|
541 | + return showUnwatched($memID); |
|
542 | + } |
|
517 | 543 | |
518 | 544 | // Are we just viewing topics? |
519 | 545 | $context['is_topics'] = isset($_GET['sa']) && $_GET['sa'] == 'topics' ? true : false; |
@@ -536,27 +562,30 @@ discard block |
||
536 | 562 | $smcFunc['db_free_result']($request); |
537 | 563 | |
538 | 564 | // Trying to remove a message that doesn't exist. |
539 | - if (empty($info)) |
|
540 | - redirectexit('action=profile;u=' . $memID . ';area=showposts;start=' . $_GET['start']); |
|
565 | + if (empty($info)) { |
|
566 | + redirectexit('action=profile;u=' . $memID . ';area=showposts;start=' . $_GET['start']); |
|
567 | + } |
|
541 | 568 | |
542 | 569 | // We can be lazy, since removeMessage() will check the permissions for us. |
543 | 570 | require_once($sourcedir . '/RemoveTopic.php'); |
544 | 571 | removeMessage((int) $_GET['delete']); |
545 | 572 | |
546 | 573 | // Add it to the mod log. |
547 | - if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) |
|
548 | - logAction('delete', array('topic' => $info[2], 'subject' => $info[0], 'member' => $info[1], 'board' => $info[3])); |
|
574 | + if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) { |
|
575 | + logAction('delete', array('topic' => $info[2], 'subject' => $info[0], 'member' => $info[1], 'board' => $info[3])); |
|
576 | + } |
|
549 | 577 | |
550 | 578 | // Back to... where we are now ;). |
551 | 579 | redirectexit('action=profile;u=' . $memID . ';area=showposts;start=' . $_GET['start']); |
552 | 580 | } |
553 | 581 | |
554 | 582 | // Default to 10. |
555 | - if (empty($_REQUEST['viewscount']) || !is_numeric($_REQUEST['viewscount'])) |
|
556 | - $_REQUEST['viewscount'] = '10'; |
|
583 | + if (empty($_REQUEST['viewscount']) || !is_numeric($_REQUEST['viewscount'])) { |
|
584 | + $_REQUEST['viewscount'] = '10'; |
|
585 | + } |
|
557 | 586 | |
558 | - if ($context['is_topics']) |
|
559 | - $request = $smcFunc['db_query']('', ' |
|
587 | + if ($context['is_topics']) { |
|
588 | + $request = $smcFunc['db_query']('', ' |
|
560 | 589 | SELECT COUNT(*) |
561 | 590 | FROM {db_prefix}topics AS t' . ($user_info['query_see_board'] == '1=1' ? '' : ' |
562 | 591 | INNER JOIN {db_prefix}boards AS b ON (b.id_board = t.id_board AND {query_see_board})') . ' |
@@ -569,8 +598,8 @@ discard block |
||
569 | 598 | 'board' => $board, |
570 | 599 | ) |
571 | 600 | ); |
572 | - else |
|
573 | - $request = $smcFunc['db_query']('', ' |
|
601 | + } else { |
|
602 | + $request = $smcFunc['db_query']('', ' |
|
574 | 603 | SELECT COUNT(*) |
575 | 604 | FROM {db_prefix}messages AS m' . ($user_info['query_see_board'] == '1=1' ? '' : ' |
576 | 605 | INNER JOIN {db_prefix}boards AS b ON (b.id_board = m.id_board AND {query_see_board})') . ' |
@@ -583,6 +612,7 @@ discard block |
||
583 | 612 | 'board' => $board, |
584 | 613 | ) |
585 | 614 | ); |
615 | + } |
|
586 | 616 | list ($msgCount) = $smcFunc['db_fetch_row']($request); |
587 | 617 | $smcFunc['db_free_result']($request); |
588 | 618 | |
@@ -603,10 +633,11 @@ discard block |
||
603 | 633 | |
604 | 634 | $range_limit = ''; |
605 | 635 | |
606 | - if ($context['is_topics']) |
|
607 | - $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['topics_per_page']) ? $options['topics_per_page'] : $modSettings['defaultMaxTopics']; |
|
608 | - else |
|
609 | - $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
|
636 | + if ($context['is_topics']) { |
|
637 | + $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['topics_per_page']) ? $options['topics_per_page'] : $modSettings['defaultMaxTopics']; |
|
638 | + } else { |
|
639 | + $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
|
640 | + } |
|
610 | 641 | |
611 | 642 | $maxIndex = $maxPerPage; |
612 | 643 | |
@@ -632,9 +663,9 @@ discard block |
||
632 | 663 | { |
633 | 664 | $margin *= 5; |
634 | 665 | $range_limit = $reverse ? 't.id_first_msg < ' . ($min_msg_member + $margin) : 't.id_first_msg > ' . ($max_msg_member - $margin); |
666 | + } else { |
|
667 | + $range_limit = $reverse ? 'm.id_msg < ' . ($min_msg_member + $margin) : 'm.id_msg > ' . ($max_msg_member - $margin); |
|
635 | 668 | } |
636 | - else |
|
637 | - $range_limit = $reverse ? 'm.id_msg < ' . ($min_msg_member + $margin) : 'm.id_msg > ' . ($max_msg_member - $margin); |
|
638 | 669 | } |
639 | 670 | |
640 | 671 | // Find this user's posts. The left join on categories somehow makes this faster, weird as it looks. |
@@ -666,8 +697,7 @@ discard block |
||
666 | 697 | 'max' => $maxIndex, |
667 | 698 | ) |
668 | 699 | ); |
669 | - } |
|
670 | - else |
|
700 | + } else |
|
671 | 701 | { |
672 | 702 | $request = $smcFunc['db_query']('', ' |
673 | 703 | SELECT |
@@ -696,8 +726,9 @@ discard block |
||
696 | 726 | } |
697 | 727 | |
698 | 728 | // Make sure we quit this loop. |
699 | - if ($smcFunc['db_num_rows']($request) === $maxIndex || $looped) |
|
700 | - break; |
|
729 | + if ($smcFunc['db_num_rows']($request) === $maxIndex || $looped) { |
|
730 | + break; |
|
731 | + } |
|
701 | 732 | $looped = true; |
702 | 733 | $range_limit = ''; |
703 | 734 | } |
@@ -741,19 +772,21 @@ discard block |
||
741 | 772 | 'css_class' => $row['approved'] ? 'windowbg' : 'approvebg', |
742 | 773 | ); |
743 | 774 | |
744 | - if ($user_info['id'] == $row['id_member_started']) |
|
745 | - $board_ids['own'][$row['id_board']][] = $counter; |
|
775 | + if ($user_info['id'] == $row['id_member_started']) { |
|
776 | + $board_ids['own'][$row['id_board']][] = $counter; |
|
777 | + } |
|
746 | 778 | $board_ids['any'][$row['id_board']][] = $counter; |
747 | 779 | } |
748 | 780 | $smcFunc['db_free_result']($request); |
749 | 781 | |
750 | 782 | // All posts were retrieved in reverse order, get them right again. |
751 | - if ($reverse) |
|
752 | - $context['posts'] = array_reverse($context['posts'], true); |
|
783 | + if ($reverse) { |
|
784 | + $context['posts'] = array_reverse($context['posts'], true); |
|
785 | + } |
|
753 | 786 | |
754 | 787 | // These are all the permissions that are different from board to board.. |
755 | - if ($context['is_topics']) |
|
756 | - $permissions = array( |
|
788 | + if ($context['is_topics']) { |
|
789 | + $permissions = array( |
|
757 | 790 | 'own' => array( |
758 | 791 | 'post_reply_own' => 'can_reply', |
759 | 792 | ), |
@@ -761,8 +794,8 @@ discard block |
||
761 | 794 | 'post_reply_any' => 'can_reply', |
762 | 795 | ) |
763 | 796 | ); |
764 | - else |
|
765 | - $permissions = array( |
|
797 | + } else { |
|
798 | + $permissions = array( |
|
766 | 799 | 'own' => array( |
767 | 800 | 'post_reply_own' => 'can_reply', |
768 | 801 | 'delete_own' => 'can_delete', |
@@ -772,6 +805,7 @@ discard block |
||
772 | 805 | 'delete_any' => 'can_delete', |
773 | 806 | ) |
774 | 807 | ); |
808 | + } |
|
775 | 809 | |
776 | 810 | // For every permission in the own/any lists... |
777 | 811 | foreach ($permissions as $type => $list) |
@@ -782,19 +816,22 @@ discard block |
||
782 | 816 | $boards = boardsAllowedTo($permission); |
783 | 817 | |
784 | 818 | // Hmm, they can do it on all boards, can they? |
785 | - if (!empty($boards) && $boards[0] == 0) |
|
786 | - $boards = array_keys($board_ids[$type]); |
|
819 | + if (!empty($boards) && $boards[0] == 0) { |
|
820 | + $boards = array_keys($board_ids[$type]); |
|
821 | + } |
|
787 | 822 | |
788 | 823 | // Now go through each board they can do the permission on. |
789 | 824 | foreach ($boards as $board_id) |
790 | 825 | { |
791 | 826 | // There aren't any posts displayed from this board. |
792 | - if (!isset($board_ids[$type][$board_id])) |
|
793 | - continue; |
|
827 | + if (!isset($board_ids[$type][$board_id])) { |
|
828 | + continue; |
|
829 | + } |
|
794 | 830 | |
795 | 831 | // Set the permission to true ;). |
796 | - foreach ($board_ids[$type][$board_id] as $counter) |
|
797 | - $context['posts'][$counter][$allowed] = true; |
|
832 | + foreach ($board_ids[$type][$board_id] as $counter) { |
|
833 | + $context['posts'][$counter][$allowed] = true; |
|
834 | + } |
|
798 | 835 | } |
799 | 836 | } |
800 | 837 | } |
@@ -825,8 +862,9 @@ discard block |
||
825 | 862 | $boardsAllowed = boardsAllowedTo('view_attachments'); |
826 | 863 | |
827 | 864 | // Make sure we can't actually see anything... |
828 | - if (empty($boardsAllowed)) |
|
829 | - $boardsAllowed = array(-1); |
|
865 | + if (empty($boardsAllowed)) { |
|
866 | + $boardsAllowed = array(-1); |
|
867 | + } |
|
830 | 868 | |
831 | 869 | require_once($sourcedir . '/Subs-List.php'); |
832 | 870 | |
@@ -977,8 +1015,8 @@ discard block |
||
977 | 1015 | ) |
978 | 1016 | ); |
979 | 1017 | $attachments = array(); |
980 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
981 | - $attachments[] = array( |
|
1018 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1019 | + $attachments[] = array( |
|
982 | 1020 | 'id' => $row['id_attach'], |
983 | 1021 | 'filename' => $row['filename'], |
984 | 1022 | 'downloads' => $row['downloads'], |
@@ -990,6 +1028,7 @@ discard block |
||
990 | 1028 | 'board_name' => $row['name'], |
991 | 1029 | 'approved' => $row['approved'], |
992 | 1030 | ); |
1031 | + } |
|
993 | 1032 | |
994 | 1033 | $smcFunc['db_free_result']($request); |
995 | 1034 | |
@@ -1044,8 +1083,9 @@ discard block |
||
1044 | 1083 | global $txt, $user_info, $scripturl, $modSettings, $context, $sourcedir; |
1045 | 1084 | |
1046 | 1085 | // Only the owner can see the list (if the function is enabled of course) |
1047 | - if ($user_info['id'] != $memID) |
|
1048 | - return; |
|
1086 | + if ($user_info['id'] != $memID) { |
|
1087 | + return; |
|
1088 | + } |
|
1049 | 1089 | |
1050 | 1090 | require_once($sourcedir . '/Subs-List.php'); |
1051 | 1091 | |
@@ -1191,8 +1231,9 @@ discard block |
||
1191 | 1231 | ); |
1192 | 1232 | |
1193 | 1233 | $topics = array(); |
1194 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1195 | - $topics[] = $row['id_topic']; |
|
1234 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1235 | + $topics[] = $row['id_topic']; |
|
1236 | + } |
|
1196 | 1237 | |
1197 | 1238 | $smcFunc['db_free_result']($request); |
1198 | 1239 | |
@@ -1212,8 +1253,9 @@ discard block |
||
1212 | 1253 | 'topics' => $topics, |
1213 | 1254 | ) |
1214 | 1255 | ); |
1215 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1216 | - $topicsInfo[] = $row; |
|
1256 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1257 | + $topicsInfo[] = $row; |
|
1258 | + } |
|
1217 | 1259 | $smcFunc['db_free_result']($request); |
1218 | 1260 | } |
1219 | 1261 | |
@@ -1261,8 +1303,9 @@ discard block |
||
1261 | 1303 | $context['page_title'] = $txt['statPanel_showStats'] . ' ' . $user_profile[$memID]['real_name']; |
1262 | 1304 | |
1263 | 1305 | // Is the load average too high to allow searching just now? |
1264 | - if (!empty($context['load_average']) && !empty($modSettings['loadavg_userstats']) && $context['load_average'] >= $modSettings['loadavg_userstats']) |
|
1265 | - fatal_lang_error('loadavg_userstats_disabled', false); |
|
1306 | + if (!empty($context['load_average']) && !empty($modSettings['loadavg_userstats']) && $context['load_average'] >= $modSettings['loadavg_userstats']) { |
|
1307 | + fatal_lang_error('loadavg_userstats_disabled', false); |
|
1308 | + } |
|
1266 | 1309 | |
1267 | 1310 | // General user statistics. |
1268 | 1311 | $timeDays = floor($user_profile[$memID]['total_time_logged_in'] / 86400); |
@@ -1405,11 +1448,13 @@ discard block |
||
1405 | 1448 | } |
1406 | 1449 | $smcFunc['db_free_result']($result); |
1407 | 1450 | |
1408 | - if ($maxPosts > 0) |
|
1409 | - for ($hour = 0; $hour < 24; $hour++) |
|
1451 | + if ($maxPosts > 0) { |
|
1452 | + for ($hour = 0; |
|
1453 | + } |
|
1454 | + $hour < 24; $hour++) |
|
1410 | 1455 | { |
1411 | - if (!isset($context['posts_by_time'][$hour])) |
|
1412 | - $context['posts_by_time'][$hour] = array( |
|
1456 | + if (!isset($context['posts_by_time'][$hour])) { |
|
1457 | + $context['posts_by_time'][$hour] = array( |
|
1413 | 1458 | 'hour' => $hour, |
1414 | 1459 | 'hour_format' => stripos($user_info['time_format'], '%p') === false ? $hour : date('g a', mktime($hour)), |
1415 | 1460 | 'posts' => 0, |
@@ -1417,7 +1462,7 @@ discard block |
||
1417 | 1462 | 'relative_percent' => 0, |
1418 | 1463 | 'is_last' => $hour == 23, |
1419 | 1464 | ); |
1420 | - else |
|
1465 | + } else |
|
1421 | 1466 | { |
1422 | 1467 | $context['posts_by_time'][$hour]['posts_percent'] = round(($context['posts_by_time'][$hour]['posts'] * 100) / $realPosts); |
1423 | 1468 | $context['posts_by_time'][$hour]['relative_percent'] = round(($context['posts_by_time'][$hour]['posts'] * 100) / $maxPosts); |
@@ -1450,8 +1495,9 @@ discard block |
||
1450 | 1495 | |
1451 | 1496 | foreach ($subActions as $sa => $action) |
1452 | 1497 | { |
1453 | - if (!allowedTo($action[2])) |
|
1454 | - unset($subActions[$sa]); |
|
1498 | + if (!allowedTo($action[2])) { |
|
1499 | + unset($subActions[$sa]); |
|
1500 | + } |
|
1455 | 1501 | } |
1456 | 1502 | |
1457 | 1503 | // Create the tabs for the template. |
@@ -1469,15 +1515,18 @@ discard block |
||
1469 | 1515 | ); |
1470 | 1516 | |
1471 | 1517 | // Moderation must be on to track edits. |
1472 | - if (empty($modSettings['userlog_enabled'])) |
|
1473 | - unset($context[$context['profile_menu_name']]['tab_data']['edits'], $subActions['edits']); |
|
1518 | + if (empty($modSettings['userlog_enabled'])) { |
|
1519 | + unset($context[$context['profile_menu_name']]['tab_data']['edits'], $subActions['edits']); |
|
1520 | + } |
|
1474 | 1521 | |
1475 | 1522 | // Group requests must be active to show it... |
1476 | - if (empty($modSettings['show_group_membership'])) |
|
1477 | - unset($context[$context['profile_menu_name']]['tab_data']['groupreq'], $subActions['groupreq']); |
|
1523 | + if (empty($modSettings['show_group_membership'])) { |
|
1524 | + unset($context[$context['profile_menu_name']]['tab_data']['groupreq'], $subActions['groupreq']); |
|
1525 | + } |
|
1478 | 1526 | |
1479 | - if (empty($subActions)) |
|
1480 | - fatal_lang_error('no_access', false); |
|
1527 | + if (empty($subActions)) { |
|
1528 | + fatal_lang_error('no_access', false); |
|
1529 | + } |
|
1481 | 1530 | |
1482 | 1531 | $keys = array_keys($subActions); |
1483 | 1532 | $default = array_shift($keys); |
@@ -1490,9 +1539,10 @@ discard block |
||
1490 | 1539 | $context['sub_template'] = $subActions[$context['tracking_area']][0]; |
1491 | 1540 | $call = call_helper($subActions[$context['tracking_area']][0], true); |
1492 | 1541 | |
1493 | - if (!empty($call)) |
|
1494 | - call_user_func($call, $memID); |
|
1495 | -} |
|
1542 | + if (!empty($call)) { |
|
1543 | + call_user_func($call, $memID); |
|
1544 | + } |
|
1545 | + } |
|
1496 | 1546 | |
1497 | 1547 | /** |
1498 | 1548 | * Handles tracking a user's activity |
@@ -1508,8 +1558,9 @@ discard block |
||
1508 | 1558 | isAllowedTo('moderate_forum'); |
1509 | 1559 | |
1510 | 1560 | $context['last_ip'] = $user_profile[$memID]['member_ip']; |
1511 | - if ($context['last_ip'] != $user_profile[$memID]['member_ip2']) |
|
1512 | - $context['last_ip2'] = $user_profile[$memID]['member_ip2']; |
|
1561 | + if ($context['last_ip'] != $user_profile[$memID]['member_ip2']) { |
|
1562 | + $context['last_ip2'] = $user_profile[$memID]['member_ip2']; |
|
1563 | + } |
|
1513 | 1564 | $context['member']['name'] = $user_profile[$memID]['real_name']; |
1514 | 1565 | |
1515 | 1566 | // Set the options for the list component. |
@@ -1675,8 +1726,9 @@ discard block |
||
1675 | 1726 | ) |
1676 | 1727 | ); |
1677 | 1728 | $message_members = array(); |
1678 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1679 | - $message_members[] = $row['id_member']; |
|
1729 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1730 | + $message_members[] = $row['id_member']; |
|
1731 | + } |
|
1680 | 1732 | $smcFunc['db_free_result']($request); |
1681 | 1733 | |
1682 | 1734 | // Fetch their names, cause of the GROUP BY doesn't like giving us that normally. |
@@ -1691,8 +1743,9 @@ discard block |
||
1691 | 1743 | 'ip_list' => $ips, |
1692 | 1744 | ) |
1693 | 1745 | ); |
1694 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1695 | - $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1746 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1747 | + $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1748 | + } |
|
1696 | 1749 | $smcFunc['db_free_result']($request); |
1697 | 1750 | } |
1698 | 1751 | |
@@ -1706,8 +1759,9 @@ discard block |
||
1706 | 1759 | 'ip_list' => $ips, |
1707 | 1760 | ) |
1708 | 1761 | ); |
1709 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1710 | - $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1762 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1763 | + $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1764 | + } |
|
1711 | 1765 | $smcFunc['db_free_result']($request); |
1712 | 1766 | } |
1713 | 1767 | } |
@@ -1767,8 +1821,8 @@ discard block |
||
1767 | 1821 | )) |
1768 | 1822 | ); |
1769 | 1823 | $error_messages = array(); |
1770 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1771 | - $error_messages[] = array( |
|
1824 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1825 | + $error_messages[] = array( |
|
1772 | 1826 | 'ip' => inet_dtop($row['ip']), |
1773 | 1827 | 'member_link' => $row['id_member'] > 0 ? '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>' : $row['display_name'], |
1774 | 1828 | 'message' => strtr($row['message'], array('<span class="remove">' => '', '</span>' => '')), |
@@ -1776,6 +1830,7 @@ discard block |
||
1776 | 1830 | 'time' => timeformat($row['log_time']), |
1777 | 1831 | 'timestamp' => forum_time(true, $row['log_time']), |
1778 | 1832 | ); |
1833 | + } |
|
1779 | 1834 | $smcFunc['db_free_result']($request); |
1780 | 1835 | |
1781 | 1836 | return $error_messages; |
@@ -1838,8 +1893,8 @@ discard block |
||
1838 | 1893 | )) |
1839 | 1894 | ); |
1840 | 1895 | $messages = array(); |
1841 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1842 | - $messages[] = array( |
|
1896 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1897 | + $messages[] = array( |
|
1843 | 1898 | 'ip' => inet_dtop($row['poster_ip']), |
1844 | 1899 | 'member_link' => empty($row['id_member']) ? $row['display_name'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>', |
1845 | 1900 | 'board' => array( |
@@ -1852,6 +1907,7 @@ discard block |
||
1852 | 1907 | 'time' => timeformat($row['poster_time']), |
1853 | 1908 | 'timestamp' => forum_time(true, $row['poster_time']) |
1854 | 1909 | ); |
1910 | + } |
|
1855 | 1911 | $smcFunc['db_free_result']($request); |
1856 | 1912 | |
1857 | 1913 | return $messages; |
@@ -1878,19 +1934,20 @@ discard block |
||
1878 | 1934 | $context['sub_template'] = 'trackIP'; |
1879 | 1935 | $context['page_title'] = $txt['profile']; |
1880 | 1936 | $context['base_url'] = $scripturl . '?action=trackip'; |
1881 | - } |
|
1882 | - else |
|
1937 | + } else |
|
1883 | 1938 | { |
1884 | 1939 | $context['ip'] = $user_profile[$memID]['member_ip']; |
1885 | 1940 | $context['base_url'] = $scripturl . '?action=profile;area=tracking;sa=ip;u=' . $memID; |
1886 | 1941 | } |
1887 | 1942 | |
1888 | 1943 | // Searching? |
1889 | - if (isset($_REQUEST['searchip'])) |
|
1890 | - $context['ip'] = trim($_REQUEST['searchip']); |
|
1944 | + if (isset($_REQUEST['searchip'])) { |
|
1945 | + $context['ip'] = trim($_REQUEST['searchip']); |
|
1946 | + } |
|
1891 | 1947 | |
1892 | - if (isValidIP($context['ip']) === false) |
|
1893 | - fatal_lang_error('invalid_tracking_ip', false); |
|
1948 | + if (isValidIP($context['ip']) === false) { |
|
1949 | + fatal_lang_error('invalid_tracking_ip', false); |
|
1950 | + } |
|
1894 | 1951 | |
1895 | 1952 | //mysql didn't support like search with varbinary |
1896 | 1953 | //$ip_var = str_replace('*', '%', $context['ip']); |
@@ -1898,8 +1955,9 @@ discard block |
||
1898 | 1955 | $ip_var = $context['ip']; |
1899 | 1956 | $ip_string = '= {inet:ip_address}'; |
1900 | 1957 | |
1901 | - if (empty($context['tracking_area'])) |
|
1902 | - $context['page_title'] = $txt['trackIP'] . ' - ' . $context['ip']; |
|
1958 | + if (empty($context['tracking_area'])) { |
|
1959 | + $context['page_title'] = $txt['trackIP'] . ' - ' . $context['ip']; |
|
1960 | + } |
|
1903 | 1961 | |
1904 | 1962 | $request = $smcFunc['db_query']('', ' |
1905 | 1963 | SELECT id_member, real_name AS display_name, member_ip |
@@ -1910,8 +1968,9 @@ discard block |
||
1910 | 1968 | ) |
1911 | 1969 | ); |
1912 | 1970 | $context['ips'] = array(); |
1913 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1914 | - $context['ips'][inet_dtop($row['member_ip'])][] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>'; |
|
1971 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1972 | + $context['ips'][inet_dtop($row['member_ip'])][] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>'; |
|
1973 | + } |
|
1915 | 1974 | $smcFunc['db_free_result']($request); |
1916 | 1975 | |
1917 | 1976 | ksort($context['ips']); |
@@ -2140,8 +2199,9 @@ discard block |
||
2140 | 2199 | foreach ($context['whois_servers'] as $whois) |
2141 | 2200 | { |
2142 | 2201 | // Strip off the "decimal point" and anything following... |
2143 | - if (in_array((int) $context['ip'], $whois['range'])) |
|
2144 | - $context['auto_whois_server'] = $whois; |
|
2202 | + if (in_array((int) $context['ip'], $whois['range'])) { |
|
2203 | + $context['auto_whois_server'] = $whois; |
|
2204 | + } |
|
2145 | 2205 | } |
2146 | 2206 | } |
2147 | 2207 | } |
@@ -2158,10 +2218,11 @@ discard block |
||
2158 | 2218 | // Gonna want this for the list. |
2159 | 2219 | require_once($sourcedir . '/Subs-List.php'); |
2160 | 2220 | |
2161 | - if ($memID == 0) |
|
2162 | - $context['base_url'] = $scripturl . '?action=trackip'; |
|
2163 | - else |
|
2164 | - $context['base_url'] = $scripturl . '?action=profile;area=tracking;sa=ip;u=' . $memID; |
|
2221 | + if ($memID == 0) { |
|
2222 | + $context['base_url'] = $scripturl . '?action=trackip'; |
|
2223 | + } else { |
|
2224 | + $context['base_url'] = $scripturl . '?action=profile;area=tracking;sa=ip;u=' . $memID; |
|
2225 | + } |
|
2165 | 2226 | |
2166 | 2227 | // Start with the user messages. |
2167 | 2228 | $listOptions = array( |
@@ -2271,12 +2332,13 @@ discard block |
||
2271 | 2332 | ) |
2272 | 2333 | ); |
2273 | 2334 | $logins = array(); |
2274 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2275 | - $logins[] = array( |
|
2335 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2336 | + $logins[] = array( |
|
2276 | 2337 | 'time' => timeformat($row['time']), |
2277 | 2338 | 'ip' => inet_dtop($row['ip']), |
2278 | 2339 | 'ip2' => inet_dtop($row['ip2']), |
2279 | 2340 | ); |
2341 | + } |
|
2280 | 2342 | $smcFunc['db_free_result']($request); |
2281 | 2343 | |
2282 | 2344 | return $logins; |
@@ -2301,11 +2363,12 @@ discard block |
||
2301 | 2363 | ) |
2302 | 2364 | ); |
2303 | 2365 | $context['custom_field_titles'] = array(); |
2304 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2305 | - $context['custom_field_titles']['customfield_' . $row['col_name']] = array( |
|
2366 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2367 | + $context['custom_field_titles']['customfield_' . $row['col_name']] = array( |
|
2306 | 2368 | 'title' => $row['field_name'], |
2307 | 2369 | 'parse_bbc' => $row['bbc'], |
2308 | 2370 | ); |
2371 | + } |
|
2309 | 2372 | $smcFunc['db_free_result']($request); |
2310 | 2373 | |
2311 | 2374 | // Set the options for the error lists. |
@@ -2444,19 +2507,22 @@ discard block |
||
2444 | 2507 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2445 | 2508 | { |
2446 | 2509 | $extra = $smcFunc['json_decode']($row['extra'], true); |
2447 | - if (!empty($extra['applicator'])) |
|
2448 | - $members[] = $extra['applicator']; |
|
2510 | + if (!empty($extra['applicator'])) { |
|
2511 | + $members[] = $extra['applicator']; |
|
2512 | + } |
|
2449 | 2513 | |
2450 | 2514 | // Work out what the name of the action is. |
2451 | - if (isset($txt['trackEdit_action_' . $row['action']])) |
|
2452 | - $action_text = $txt['trackEdit_action_' . $row['action']]; |
|
2453 | - elseif (isset($txt[$row['action']])) |
|
2454 | - $action_text = $txt[$row['action']]; |
|
2515 | + if (isset($txt['trackEdit_action_' . $row['action']])) { |
|
2516 | + $action_text = $txt['trackEdit_action_' . $row['action']]; |
|
2517 | + } elseif (isset($txt[$row['action']])) { |
|
2518 | + $action_text = $txt[$row['action']]; |
|
2519 | + } |
|
2455 | 2520 | // Custom field? |
2456 | - elseif (isset($context['custom_field_titles'][$row['action']])) |
|
2457 | - $action_text = $context['custom_field_titles'][$row['action']]['title']; |
|
2458 | - else |
|
2459 | - $action_text = $row['action']; |
|
2521 | + elseif (isset($context['custom_field_titles'][$row['action']])) { |
|
2522 | + $action_text = $context['custom_field_titles'][$row['action']]['title']; |
|
2523 | + } else { |
|
2524 | + $action_text = $row['action']; |
|
2525 | + } |
|
2460 | 2526 | |
2461 | 2527 | // Parse BBC? |
2462 | 2528 | $parse_bbc = isset($context['custom_field_titles'][$row['action']]) && $context['custom_field_titles'][$row['action']]['parse_bbc'] ? true : false; |
@@ -2488,13 +2554,15 @@ discard block |
||
2488 | 2554 | ) |
2489 | 2555 | ); |
2490 | 2556 | $members = array(); |
2491 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2492 | - $members[$row['id_member']] = $row['real_name']; |
|
2557 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2558 | + $members[$row['id_member']] = $row['real_name']; |
|
2559 | + } |
|
2493 | 2560 | $smcFunc['db_free_result']($request); |
2494 | 2561 | |
2495 | - foreach ($edits as $key => $value) |
|
2496 | - if (isset($members[$value['id_member']])) |
|
2562 | + foreach ($edits as $key => $value) { |
|
2563 | + if (isset($members[$value['id_member']])) |
|
2497 | 2564 | $edits[$key]['member_link'] = '<a href="' . $scripturl . '?action=profile;u=' . $value['id_member'] . '">' . $members[$value['id_member']] . '</a>'; |
2565 | + } |
|
2498 | 2566 | } |
2499 | 2567 | |
2500 | 2568 | return $edits; |
@@ -2695,10 +2763,11 @@ discard block |
||
2695 | 2763 | $context['board'] = $board; |
2696 | 2764 | |
2697 | 2765 | // Determine which groups this user is in. |
2698 | - if (empty($user_profile[$memID]['additional_groups'])) |
|
2699 | - $curGroups = array(); |
|
2700 | - else |
|
2701 | - $curGroups = explode(',', $user_profile[$memID]['additional_groups']); |
|
2766 | + if (empty($user_profile[$memID]['additional_groups'])) { |
|
2767 | + $curGroups = array(); |
|
2768 | + } else { |
|
2769 | + $curGroups = explode(',', $user_profile[$memID]['additional_groups']); |
|
2770 | + } |
|
2702 | 2771 | $curGroups[] = $user_profile[$memID]['id_group']; |
2703 | 2772 | $curGroups[] = $user_profile[$memID]['id_post_group']; |
2704 | 2773 | |
@@ -2718,28 +2787,30 @@ discard block |
||
2718 | 2787 | $context['no_access_boards'] = array(); |
2719 | 2788 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2720 | 2789 | { |
2721 | - if (count(array_intersect($curGroups, explode(',', $row['member_groups']))) === 0 && !$row['is_mod']) |
|
2722 | - $context['no_access_boards'][] = array( |
|
2790 | + if (count(array_intersect($curGroups, explode(',', $row['member_groups']))) === 0 && !$row['is_mod']) { |
|
2791 | + $context['no_access_boards'][] = array( |
|
2723 | 2792 | 'id' => $row['id_board'], |
2724 | 2793 | 'name' => $row['name'], |
2725 | 2794 | 'is_last' => false, |
2726 | 2795 | ); |
2727 | - elseif ($row['id_profile'] != 1 || $row['is_mod']) |
|
2728 | - $context['boards'][$row['id_board']] = array( |
|
2796 | + } elseif ($row['id_profile'] != 1 || $row['is_mod']) { |
|
2797 | + $context['boards'][$row['id_board']] = array( |
|
2729 | 2798 | 'id' => $row['id_board'], |
2730 | 2799 | 'name' => $row['name'], |
2731 | 2800 | 'selected' => $board == $row['id_board'], |
2732 | 2801 | 'profile' => $row['id_profile'], |
2733 | 2802 | 'profile_name' => $context['profiles'][$row['id_profile']]['name'], |
2734 | 2803 | ); |
2804 | + } |
|
2735 | 2805 | } |
2736 | 2806 | $smcFunc['db_free_result']($request); |
2737 | 2807 | |
2738 | 2808 | require_once($sourcedir . '/Subs-Boards.php'); |
2739 | 2809 | sortBoards($context['boards']); |
2740 | 2810 | |
2741 | - if (!empty($context['no_access_boards'])) |
|
2742 | - $context['no_access_boards'][count($context['no_access_boards']) - 1]['is_last'] = true; |
|
2811 | + if (!empty($context['no_access_boards'])) { |
|
2812 | + $context['no_access_boards'][count($context['no_access_boards']) - 1]['is_last'] = true; |
|
2813 | + } |
|
2743 | 2814 | |
2744 | 2815 | $context['member']['permissions'] = array( |
2745 | 2816 | 'general' => array(), |
@@ -2748,8 +2819,9 @@ discard block |
||
2748 | 2819 | |
2749 | 2820 | // If you're an admin we know you can do everything, we might as well leave. |
2750 | 2821 | $context['member']['has_all_permissions'] = in_array(1, $curGroups); |
2751 | - if ($context['member']['has_all_permissions']) |
|
2752 | - return; |
|
2822 | + if ($context['member']['has_all_permissions']) { |
|
2823 | + return; |
|
2824 | + } |
|
2753 | 2825 | |
2754 | 2826 | $denied = array(); |
2755 | 2827 | |
@@ -2768,21 +2840,24 @@ discard block |
||
2768 | 2840 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
2769 | 2841 | { |
2770 | 2842 | // We don't know about this permission, it doesn't exist :P. |
2771 | - if (!isset($txt['permissionname_' . $row['permission']])) |
|
2772 | - continue; |
|
2843 | + if (!isset($txt['permissionname_' . $row['permission']])) { |
|
2844 | + continue; |
|
2845 | + } |
|
2773 | 2846 | |
2774 | - if (empty($row['add_deny'])) |
|
2775 | - $denied[] = $row['permission']; |
|
2847 | + if (empty($row['add_deny'])) { |
|
2848 | + $denied[] = $row['permission']; |
|
2849 | + } |
|
2776 | 2850 | |
2777 | 2851 | // Permissions that end with _own or _any consist of two parts. |
2778 | - if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) |
|
2779 | - $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2780 | - else |
|
2781 | - $name = $txt['permissionname_' . $row['permission']]; |
|
2852 | + if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) { |
|
2853 | + $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2854 | + } else { |
|
2855 | + $name = $txt['permissionname_' . $row['permission']]; |
|
2856 | + } |
|
2782 | 2857 | |
2783 | 2858 | // Add this permission if it doesn't exist yet. |
2784 | - if (!isset($context['member']['permissions']['general'][$row['permission']])) |
|
2785 | - $context['member']['permissions']['general'][$row['permission']] = array( |
|
2859 | + if (!isset($context['member']['permissions']['general'][$row['permission']])) { |
|
2860 | + $context['member']['permissions']['general'][$row['permission']] = array( |
|
2786 | 2861 | 'id' => $row['permission'], |
2787 | 2862 | 'groups' => array( |
2788 | 2863 | 'allowed' => array(), |
@@ -2792,6 +2867,7 @@ discard block |
||
2792 | 2867 | 'is_denied' => false, |
2793 | 2868 | 'is_global' => true, |
2794 | 2869 | ); |
2870 | + } |
|
2795 | 2871 | |
2796 | 2872 | // Add the membergroup to either the denied or the allowed groups. |
2797 | 2873 | $context['member']['permissions']['general'][$row['permission']]['groups'][empty($row['add_deny']) ? 'denied' : 'allowed'][] = $row['id_group'] == 0 ? $txt['membergroups_members'] : $row['group_name']; |
@@ -2825,18 +2901,20 @@ discard block |
||
2825 | 2901 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2826 | 2902 | { |
2827 | 2903 | // We don't know about this permission, it doesn't exist :P. |
2828 | - if (!isset($txt['permissionname_' . $row['permission']])) |
|
2829 | - continue; |
|
2904 | + if (!isset($txt['permissionname_' . $row['permission']])) { |
|
2905 | + continue; |
|
2906 | + } |
|
2830 | 2907 | |
2831 | 2908 | // The name of the permission using the format 'permission name' - 'own/any topic/event/etc.'. |
2832 | - if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) |
|
2833 | - $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2834 | - else |
|
2835 | - $name = $txt['permissionname_' . $row['permission']]; |
|
2909 | + if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) { |
|
2910 | + $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2911 | + } else { |
|
2912 | + $name = $txt['permissionname_' . $row['permission']]; |
|
2913 | + } |
|
2836 | 2914 | |
2837 | 2915 | // Create the structure for this permission. |
2838 | - if (!isset($context['member']['permissions']['board'][$row['permission']])) |
|
2839 | - $context['member']['permissions']['board'][$row['permission']] = array( |
|
2916 | + if (!isset($context['member']['permissions']['board'][$row['permission']])) { |
|
2917 | + $context['member']['permissions']['board'][$row['permission']] = array( |
|
2840 | 2918 | 'id' => $row['permission'], |
2841 | 2919 | 'groups' => array( |
2842 | 2920 | 'allowed' => array(), |
@@ -2846,6 +2924,7 @@ discard block |
||
2846 | 2924 | 'is_denied' => false, |
2847 | 2925 | 'is_global' => empty($board), |
2848 | 2926 | ); |
2927 | + } |
|
2849 | 2928 | |
2850 | 2929 | $context['member']['permissions']['board'][$row['permission']]['groups'][empty($row['add_deny']) ? 'denied' : 'allowed'][$row['id_group']] = $row['id_group'] == 0 ? $txt['membergroups_members'] : $row['group_name']; |
2851 | 2930 | |
@@ -2864,8 +2943,9 @@ discard block |
||
2864 | 2943 | global $modSettings, $context, $sourcedir, $txt, $scripturl; |
2865 | 2944 | |
2866 | 2945 | // Firstly, can we actually even be here? |
2867 | - if (!($context['user']['is_owner'] && allowedTo('view_warning_own')) && !allowedTo('view_warning_any') && !allowedTo('issue_warning') && !allowedTo('moderate_forum')) |
|
2868 | - fatal_lang_error('no_access', false); |
|
2946 | + if (!($context['user']['is_owner'] && allowedTo('view_warning_own')) && !allowedTo('view_warning_any') && !allowedTo('issue_warning') && !allowedTo('moderate_forum')) { |
|
2947 | + fatal_lang_error('no_access', false); |
|
2948 | + } |
|
2869 | 2949 | |
2870 | 2950 | // Make sure things which are disabled stay disabled. |
2871 | 2951 | $modSettings['warning_watch'] = !empty($modSettings['warning_watch']) ? $modSettings['warning_watch'] : 110; |
@@ -2952,9 +3032,10 @@ discard block |
||
2952 | 3032 | $modSettings['warning_mute'] => $txt['profile_warning_effect_own_muted'], |
2953 | 3033 | ); |
2954 | 3034 | $context['current_level'] = 0; |
2955 | - foreach ($context['level_effects'] as $limit => $dummy) |
|
2956 | - if ($context['member']['warning'] >= $limit) |
|
3035 | + foreach ($context['level_effects'] as $limit => $dummy) { |
|
3036 | + if ($context['member']['warning'] >= $limit) |
|
2957 | 3037 | $context['current_level'] = $limit; |
2958 | -} |
|
3038 | + } |
|
3039 | + } |
|
2959 | 3040 | |
2960 | 3041 | ?> |
2961 | 3042 | \ No newline at end of file |
@@ -387,7 +387,7 @@ discard block |
||
387 | 387 | { |
388 | 388 | $val = 'CASE '; |
389 | 389 | foreach ($members as $k => $v) |
390 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
390 | + $val .= 'WHEN id_member = ' . $v . ' THEN ' . count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
391 | 391 | $val = $val . ' END'; |
392 | 392 | $type = 'raw'; |
393 | 393 | } |
@@ -820,7 +820,7 @@ discard block |
||
820 | 820 | $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
821 | 821 | if (empty($unsupportedFormats)) |
822 | 822 | { |
823 | - foreach($strftimeFormatSubstitutions as $format => $substitution) |
|
823 | + foreach ($strftimeFormatSubstitutions as $format => $substitution) |
|
824 | 824 | { |
825 | 825 | $value = @strftime('%' . $format); |
826 | 826 | |
@@ -1185,7 +1185,7 @@ discard block |
||
1185 | 1185 | 'height' => array('optional' => true, 'match' => '(\d+)'), |
1186 | 1186 | ), |
1187 | 1187 | 'content' => '$1', |
1188 | - 'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt) |
|
1188 | + 'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt) |
|
1189 | 1189 | { |
1190 | 1190 | $returnContext = ''; |
1191 | 1191 | |
@@ -1220,7 +1220,7 @@ discard block |
||
1220 | 1220 | } |
1221 | 1221 | |
1222 | 1222 | if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
1223 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1223 | + $returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '" class="atc_img"></a>'; |
|
1224 | 1224 | else |
1225 | 1225 | $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
1226 | 1226 | } |
@@ -1249,7 +1249,7 @@ discard block |
||
1249 | 1249 | 'type' => 'unparsed_content', |
1250 | 1250 | 'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>', |
1251 | 1251 | // @todo Maybe this can be simplified? |
1252 | - 'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context) |
|
1252 | + 'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context) |
|
1253 | 1253 | { |
1254 | 1254 | if (!isset($disabled['code'])) |
1255 | 1255 | { |
@@ -1286,7 +1286,7 @@ discard block |
||
1286 | 1286 | 'type' => 'unparsed_equals_content', |
1287 | 1287 | 'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>', |
1288 | 1288 | // @todo Maybe this can be simplified? |
1289 | - 'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context) |
|
1289 | + 'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context) |
|
1290 | 1290 | { |
1291 | 1291 | if (!isset($disabled['code'])) |
1292 | 1292 | { |
@@ -1330,7 +1330,7 @@ discard block |
||
1330 | 1330 | 'type' => 'unparsed_content', |
1331 | 1331 | 'content' => '<a href="mailto:$1" class="bbc_email">$1</a>', |
1332 | 1332 | // @todo Should this respect guest_hideContacts? |
1333 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1333 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1334 | 1334 | { |
1335 | 1335 | $data = strtr($data, array('<br>' => '')); |
1336 | 1336 | }, |
@@ -1349,7 +1349,7 @@ discard block |
||
1349 | 1349 | 'type' => 'unparsed_commas_content', |
1350 | 1350 | 'test' => '\d+,\d+\]', |
1351 | 1351 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1352 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1352 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1353 | 1353 | { |
1354 | 1354 | if (isset($disabled['url'])) |
1355 | 1355 | $tag['content'] = '$1'; |
@@ -1365,7 +1365,7 @@ discard block |
||
1365 | 1365 | 'test' => '(left|right)(\s+max=\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)?\]', |
1366 | 1366 | 'before' => '<div $1>', |
1367 | 1367 | 'after' => '</div>', |
1368 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1368 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1369 | 1369 | { |
1370 | 1370 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1371 | 1371 | |
@@ -1414,7 +1414,7 @@ discard block |
||
1414 | 1414 | 'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'), |
1415 | 1415 | ), |
1416 | 1416 | 'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">', |
1417 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1417 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1418 | 1418 | { |
1419 | 1419 | global $image_proxy_enabled, $image_proxy_secret, $boardurl; |
1420 | 1420 | |
@@ -1437,7 +1437,7 @@ discard block |
||
1437 | 1437 | 'tag' => 'img', |
1438 | 1438 | 'type' => 'unparsed_content', |
1439 | 1439 | 'content' => '<img src="$1" alt="" class="bbc_img">', |
1440 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1440 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1441 | 1441 | { |
1442 | 1442 | global $image_proxy_enabled, $image_proxy_secret, $boardurl; |
1443 | 1443 | |
@@ -1460,7 +1460,7 @@ discard block |
||
1460 | 1460 | 'tag' => 'iurl', |
1461 | 1461 | 'type' => 'unparsed_content', |
1462 | 1462 | 'content' => '<a href="$1" class="bbc_link">$1</a>', |
1463 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1463 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1464 | 1464 | { |
1465 | 1465 | $data = strtr($data, array('<br>' => '')); |
1466 | 1466 | $scheme = parse_url($data, PHP_URL_SCHEME); |
@@ -1474,7 +1474,7 @@ discard block |
||
1474 | 1474 | 'quoted' => 'optional', |
1475 | 1475 | 'before' => '<a href="$1" class="bbc_link">', |
1476 | 1476 | 'after' => '</a>', |
1477 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1477 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1478 | 1478 | { |
1479 | 1479 | if (substr($data, 0, 1) == '#') |
1480 | 1480 | $data = '#post_' . substr($data, 1); |
@@ -1554,7 +1554,7 @@ discard block |
||
1554 | 1554 | 'tag' => 'php', |
1555 | 1555 | 'type' => 'unparsed_content', |
1556 | 1556 | 'content' => '<span class="phpcode">$1</span>', |
1557 | - 'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled) |
|
1557 | + 'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled) |
|
1558 | 1558 | { |
1559 | 1559 | if (!isset($disabled['php'])) |
1560 | 1560 | { |
@@ -1652,7 +1652,7 @@ discard block |
||
1652 | 1652 | 'test' => '[1-7]\]', |
1653 | 1653 | 'before' => '<span style="font-size: $1;" class="bbc_size">', |
1654 | 1654 | 'after' => '</span>', |
1655 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1655 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1656 | 1656 | { |
1657 | 1657 | $sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95); |
1658 | 1658 | $data = $sizes[$data] . 'em'; |
@@ -1690,7 +1690,7 @@ discard block |
||
1690 | 1690 | 'tag' => 'time', |
1691 | 1691 | 'type' => 'unparsed_content', |
1692 | 1692 | 'content' => '$1', |
1693 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1693 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1694 | 1694 | { |
1695 | 1695 | if (is_numeric($data)) |
1696 | 1696 | $data = timeformat($data); |
@@ -1718,7 +1718,7 @@ discard block |
||
1718 | 1718 | 'tag' => 'url', |
1719 | 1719 | 'type' => 'unparsed_content', |
1720 | 1720 | 'content' => '<a href="$1" class="bbc_link" target="_blank">$1</a>', |
1721 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1721 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1722 | 1722 | { |
1723 | 1723 | $data = strtr($data, array('<br>' => '')); |
1724 | 1724 | $scheme = parse_url($data, PHP_URL_SCHEME); |
@@ -1732,7 +1732,7 @@ discard block |
||
1732 | 1732 | 'quoted' => 'optional', |
1733 | 1733 | 'before' => '<a href="$1" class="bbc_link" target="_blank">', |
1734 | 1734 | 'after' => '</a>', |
1735 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1735 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1736 | 1736 | { |
1737 | 1737 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1738 | 1738 | if (empty($scheme)) |
@@ -1758,7 +1758,7 @@ discard block |
||
1758 | 1758 | { |
1759 | 1759 | if (isset($temp_bbc)) |
1760 | 1760 | $bbc_codes = $temp_bbc; |
1761 | - usort($codes, function ($a, $b) { |
|
1761 | + usort($codes, function($a, $b) { |
|
1762 | 1762 | return strcmp($a['tag'], $b['tag']); |
1763 | 1763 | }); |
1764 | 1764 | return $codes; |
@@ -1995,7 +1995,7 @@ discard block |
||
1995 | 1995 | # a run of Unicode domain name characters and a dot |
1996 | 1996 | [\p{L}\p{M}\p{N}\-.:@]+\. |
1997 | 1997 | # and then a TLD valid in the DNS or the reserved "local" TLD |
1998 | - (?:'. $modSettings['tld_regex'] .'|local) |
|
1998 | + (?:'. $modSettings['tld_regex'] . '|local) |
|
1999 | 1999 | ) |
2000 | 2000 | # followed by a non-domain character or end of line |
2001 | 2001 | (?=[^\p{L}\p{N}\-.]|$) |
@@ -2063,7 +2063,7 @@ discard block |
||
2063 | 2063 | )? |
2064 | 2064 | '; |
2065 | 2065 | |
2066 | - $data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) { |
|
2066 | + $data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) { |
|
2067 | 2067 | $url = array_shift($matches); |
2068 | 2068 | |
2069 | 2069 | $scheme = parse_url($url, PHP_URL_SCHEME); |
@@ -2800,7 +2800,7 @@ discard block |
||
2800 | 2800 | for ($i = 0, $n = count($smileysfrom); $i < $n; $i++) |
2801 | 2801 | { |
2802 | 2802 | $specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES); |
2803 | - $smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" class="smiley">'; |
|
2803 | + $smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" class="smiley">'; |
|
2804 | 2804 | |
2805 | 2805 | $smileyPregReplacements[$smileysfrom[$i]] = $smileyCode; |
2806 | 2806 | |
@@ -2817,7 +2817,7 @@ discard block |
||
2817 | 2817 | |
2818 | 2818 | // Replace away! |
2819 | 2819 | $message = preg_replace_callback($smileyPregSearch, |
2820 | - function ($matches) use ($smileyPregReplacements) |
|
2820 | + function($matches) use ($smileyPregReplacements) |
|
2821 | 2821 | { |
2822 | 2822 | return $smileyPregReplacements[$matches[1]]; |
2823 | 2823 | }, $message); |
@@ -2883,13 +2883,13 @@ discard block |
||
2883 | 2883 | { |
2884 | 2884 | if (defined('SID') && SID != '') |
2885 | 2885 | $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
2886 | - function ($m) use ($scripturl) |
|
2886 | + function($m) use ($scripturl) |
|
2887 | 2887 | { |
2888 | - return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
|
2888 | + return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : ""); |
|
2889 | 2889 | }, $setLocation); |
2890 | 2890 | else |
2891 | 2891 | $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
2892 | - function ($m) use ($scripturl) |
|
2892 | + function($m) use ($scripturl) |
|
2893 | 2893 | { |
2894 | 2894 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
2895 | 2895 | }, $setLocation); |
@@ -3212,7 +3212,7 @@ discard block |
||
3212 | 3212 | |
3213 | 3213 | // Add a generic "Are you sure?" confirmation message. |
3214 | 3214 | addInlineJavaScript(' |
3215 | - var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
|
3215 | + var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';'); |
|
3216 | 3216 | |
3217 | 3217 | // Now add the capping code for avatars. |
3218 | 3218 | if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
@@ -3573,7 +3573,7 @@ discard block |
||
3573 | 3573 | |
3574 | 3574 | else |
3575 | 3575 | echo ' |
3576 | - <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
|
3576 | + <script src="', $settings['theme_url'], '/scripts/minified', ($do_deferred ? '_deferred' : ''), '.js', $minSeed, '"></script>'; |
|
3577 | 3577 | } |
3578 | 3578 | |
3579 | 3579 | // Inline JavaScript - Actually useful some times! |
@@ -3651,14 +3651,14 @@ discard block |
||
3651 | 3651 | |
3652 | 3652 | else |
3653 | 3653 | echo ' |
3654 | - <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
|
3654 | + <link rel="stylesheet" href="', $settings['theme_url'], '/css/minified.css', $minSeed, '">'; |
|
3655 | 3655 | } |
3656 | 3656 | |
3657 | 3657 | // Print the rest after the minified files. |
3658 | 3658 | if (!empty($normal)) |
3659 | 3659 | foreach ($normal as $nf) |
3660 | 3660 | echo ' |
3661 | - <link rel="stylesheet" href="', $nf ,'">'; |
|
3661 | + <link rel="stylesheet" href="', $nf, '">'; |
|
3662 | 3662 | |
3663 | 3663 | if ($db_show_debug === true) |
3664 | 3664 | { |
@@ -3674,7 +3674,7 @@ discard block |
||
3674 | 3674 | <style>'; |
3675 | 3675 | |
3676 | 3676 | foreach ($context['css_header'] as $css) |
3677 | - echo $css .' |
|
3677 | + echo $css . ' |
|
3678 | 3678 | '; |
3679 | 3679 | |
3680 | 3680 | echo' |
@@ -3703,27 +3703,27 @@ discard block |
||
3703 | 3703 | return false; |
3704 | 3704 | |
3705 | 3705 | // Did we already did this? |
3706 | - $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
|
3706 | + $toCache = cache_get_data('minimized_' . $settings['theme_id'] . '_' . $type, 86400); |
|
3707 | 3707 | |
3708 | 3708 | // Already done? |
3709 | 3709 | if (!empty($toCache)) |
3710 | 3710 | return true; |
3711 | 3711 | |
3712 | 3712 | // No namespaces, sorry! |
3713 | - $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
|
3713 | + $classType = 'MatthiasMullie\\Minify\\' . strtoupper($type); |
|
3714 | 3714 | |
3715 | 3715 | // Temp path. |
3716 | - $cTempPath = $settings['theme_dir'] .'/'. ($type == 'css' ? 'css' : 'scripts') .'/'; |
|
3716 | + $cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/'; |
|
3717 | 3717 | |
3718 | 3718 | // What kind of file are we going to create? |
3719 | - $toCreate = $cTempPath .'minified'. ($do_deferred ? '_deferred' : '') .'.'. $type; |
|
3719 | + $toCreate = $cTempPath . 'minified' . ($do_deferred ? '_deferred' : '') . '.' . $type; |
|
3720 | 3720 | |
3721 | 3721 | // File has to exists, if it isn't try to create it. |
3722 | 3722 | if ((!file_exists($toCreate) && @fopen($toCreate, 'w') === false) || !smf_chmod($toCreate)) |
3723 | 3723 | { |
3724 | 3724 | loadLanguage('Errors'); |
3725 | 3725 | log_error(sprintf($txt['file_not_created'], $toCreate), 'general'); |
3726 | - cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null); |
|
3726 | + cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null); |
|
3727 | 3727 | |
3728 | 3728 | // The process failed so roll back to print each individual file. |
3729 | 3729 | return $data; |
@@ -3758,14 +3758,14 @@ discard block |
||
3758 | 3758 | { |
3759 | 3759 | loadLanguage('Errors'); |
3760 | 3760 | log_error(sprintf($txt['file_not_created'], $toCreate), 'general'); |
3761 | - cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null); |
|
3761 | + cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null); |
|
3762 | 3762 | |
3763 | 3763 | // The process failed so roll back to print each individual file. |
3764 | 3764 | return $data; |
3765 | 3765 | } |
3766 | 3766 | |
3767 | 3767 | // And create a long lived cache entry. |
3768 | - cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, $toCreate, 86400); |
|
3768 | + cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, $toCreate, 86400); |
|
3769 | 3769 | |
3770 | 3770 | return true; |
3771 | 3771 | } |
@@ -3825,7 +3825,7 @@ discard block |
||
3825 | 3825 | else |
3826 | 3826 | $path = $modSettings['attachmentUploadDir']; |
3827 | 3827 | |
3828 | - return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
|
3828 | + return $path . '/' . $attachment_id . '_' . $file_hash . '.dat'; |
|
3829 | 3829 | } |
3830 | 3830 | |
3831 | 3831 | /** |
@@ -3869,10 +3869,10 @@ discard block |
||
3869 | 3869 | $valid_low = isValidIP($ip_parts[0]); |
3870 | 3870 | $valid_high = isValidIP($ip_parts[1]); |
3871 | 3871 | $count = 0; |
3872 | - $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
|
3872 | + $mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.'); |
|
3873 | 3873 | $max = ($mode == ':' ? 'ffff' : '255'); |
3874 | 3874 | $min = 0; |
3875 | - if(!$valid_low) |
|
3875 | + if (!$valid_low) |
|
3876 | 3876 | { |
3877 | 3877 | $ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]); |
3878 | 3878 | $valid_low = isValidIP($ip_parts[0]); |
@@ -3886,7 +3886,7 @@ discard block |
||
3886 | 3886 | } |
3887 | 3887 | |
3888 | 3888 | $count = 0; |
3889 | - if(!$valid_high) |
|
3889 | + if (!$valid_high) |
|
3890 | 3890 | { |
3891 | 3891 | $ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]); |
3892 | 3892 | $valid_high = isValidIP($ip_parts[1]); |
@@ -3899,7 +3899,7 @@ discard block |
||
3899 | 3899 | } |
3900 | 3900 | } |
3901 | 3901 | |
3902 | - if($valid_high && $valid_low) |
|
3902 | + if ($valid_high && $valid_low) |
|
3903 | 3903 | { |
3904 | 3904 | $ip_array['low'] = $ip_parts[0]; |
3905 | 3905 | $ip_array['high'] = $ip_parts[1]; |
@@ -4081,7 +4081,7 @@ discard block |
||
4081 | 4081 | addInlineJavaScript(' |
4082 | 4082 | var user_menus = new smc_PopupMenu(); |
4083 | 4083 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4084 | - user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
|
4084 | + user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true); |
|
4085 | 4085 | if ($context['allow_pm']) |
4086 | 4086 | addInlineJavaScript(' |
4087 | 4087 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
@@ -4701,7 +4701,7 @@ discard block |
||
4701 | 4701 | // No? try a fallback to $sourcedir |
4702 | 4702 | else |
4703 | 4703 | { |
4704 | - $absPath = $sourcedir .'/'. $file; |
|
4704 | + $absPath = $sourcedir . '/' . $file; |
|
4705 | 4705 | |
4706 | 4706 | if (file_exists($absPath)) |
4707 | 4707 | require_once($absPath); |
@@ -4782,15 +4782,15 @@ discard block |
||
4782 | 4782 | |
4783 | 4783 | // UTF-8 occurences of MS special characters |
4784 | 4784 | $findchars_utf8 = array( |
4785 | - "\xe2\x80\x9a", // single low-9 quotation mark |
|
4786 | - "\xe2\x80\x9e", // double low-9 quotation mark |
|
4787 | - "\xe2\x80\xa6", // horizontal ellipsis |
|
4788 | - "\xe2\x80\x98", // left single curly quote |
|
4789 | - "\xe2\x80\x99", // right single curly quote |
|
4790 | - "\xe2\x80\x9c", // left double curly quote |
|
4791 | - "\xe2\x80\x9d", // right double curly quote |
|
4792 | - "\xe2\x80\x93", // en dash |
|
4793 | - "\xe2\x80\x94", // em dash |
|
4785 | + "\xe2\x80\x9a", // single low-9 quotation mark |
|
4786 | + "\xe2\x80\x9e", // double low-9 quotation mark |
|
4787 | + "\xe2\x80\xa6", // horizontal ellipsis |
|
4788 | + "\xe2\x80\x98", // left single curly quote |
|
4789 | + "\xe2\x80\x99", // right single curly quote |
|
4790 | + "\xe2\x80\x9c", // left double curly quote |
|
4791 | + "\xe2\x80\x9d", // right double curly quote |
|
4792 | + "\xe2\x80\x93", // en dash |
|
4793 | + "\xe2\x80\x94", // em dash |
|
4794 | 4794 | ); |
4795 | 4795 | |
4796 | 4796 | // windows 1252 / iso equivalents |
@@ -4808,15 +4808,15 @@ discard block |
||
4808 | 4808 | |
4809 | 4809 | // safe replacements |
4810 | 4810 | $replacechars = array( |
4811 | - ',', // ‚ |
|
4812 | - ',,', // „ |
|
4813 | - '...', // … |
|
4814 | - "'", // ‘ |
|
4815 | - "'", // ’ |
|
4816 | - '"', // “ |
|
4817 | - '"', // ” |
|
4818 | - '-', // – |
|
4819 | - '--', // — |
|
4811 | + ',', // ‚ |
|
4812 | + ',,', // „ |
|
4813 | + '...', // … |
|
4814 | + "'", // ‘ |
|
4815 | + "'", // ’ |
|
4816 | + '"', // “ |
|
4817 | + '"', // ” |
|
4818 | + '-', // – |
|
4819 | + '--', // — |
|
4820 | 4820 | ); |
4821 | 4821 | |
4822 | 4822 | if ($context['utf8']) |
@@ -5234,7 +5234,7 @@ discard block |
||
5234 | 5234 | */ |
5235 | 5235 | function inet_dtop($bin) |
5236 | 5236 | { |
5237 | - if(empty($bin)) |
|
5237 | + if (empty($bin)) |
|
5238 | 5238 | return ''; |
5239 | 5239 | |
5240 | 5240 | global $db_type; |
@@ -5265,28 +5265,28 @@ discard block |
||
5265 | 5265 | */ |
5266 | 5266 | function _safe_serialize($value) |
5267 | 5267 | { |
5268 | - if(is_null($value)) |
|
5268 | + if (is_null($value)) |
|
5269 | 5269 | return 'N;'; |
5270 | 5270 | |
5271 | - if(is_bool($value)) |
|
5272 | - return 'b:'. (int) $value .';'; |
|
5271 | + if (is_bool($value)) |
|
5272 | + return 'b:' . (int) $value . ';'; |
|
5273 | 5273 | |
5274 | - if(is_int($value)) |
|
5275 | - return 'i:'. $value .';'; |
|
5274 | + if (is_int($value)) |
|
5275 | + return 'i:' . $value . ';'; |
|
5276 | 5276 | |
5277 | - if(is_float($value)) |
|
5278 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5277 | + if (is_float($value)) |
|
5278 | + return 'd:' . str_replace(',', '.', $value) . ';'; |
|
5279 | 5279 | |
5280 | - if(is_string($value)) |
|
5281 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5280 | + if (is_string($value)) |
|
5281 | + return 's:' . strlen($value) . ':"' . $value . '";'; |
|
5282 | 5282 | |
5283 | - if(is_array($value)) |
|
5283 | + if (is_array($value)) |
|
5284 | 5284 | { |
5285 | 5285 | $out = ''; |
5286 | - foreach($value as $k => $v) |
|
5286 | + foreach ($value as $k => $v) |
|
5287 | 5287 | $out .= _safe_serialize($k) . _safe_serialize($v); |
5288 | 5288 | |
5289 | - return 'a:'. count($value) .':{'. $out .'}'; |
|
5289 | + return 'a:' . count($value) . ':{' . $out . '}'; |
|
5290 | 5290 | } |
5291 | 5291 | |
5292 | 5292 | // safe_serialize cannot serialize resources or objects. |
@@ -5328,7 +5328,7 @@ discard block |
||
5328 | 5328 | function _safe_unserialize($str) |
5329 | 5329 | { |
5330 | 5330 | // Input is not a string. |
5331 | - if(empty($str) || !is_string($str)) |
|
5331 | + if (empty($str) || !is_string($str)) |
|
5332 | 5332 | return false; |
5333 | 5333 | |
5334 | 5334 | $stack = array(); |
@@ -5342,40 +5342,40 @@ discard block |
||
5342 | 5342 | * 3 - in array, expecting value or another array |
5343 | 5343 | */ |
5344 | 5344 | $state = 0; |
5345 | - while($state != 1) |
|
5345 | + while ($state != 1) |
|
5346 | 5346 | { |
5347 | 5347 | $type = isset($str[0]) ? $str[0] : ''; |
5348 | - if($type == '}') |
|
5348 | + if ($type == '}') |
|
5349 | 5349 | $str = substr($str, 1); |
5350 | 5350 | |
5351 | - else if($type == 'N' && $str[1] == ';') |
|
5351 | + else if ($type == 'N' && $str[1] == ';') |
|
5352 | 5352 | { |
5353 | 5353 | $value = null; |
5354 | 5354 | $str = substr($str, 2); |
5355 | 5355 | } |
5356 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5356 | + else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5357 | 5357 | { |
5358 | 5358 | $value = $matches[1] == '1' ? true : false; |
5359 | 5359 | $str = substr($str, 4); |
5360 | 5360 | } |
5361 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5361 | + else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5362 | 5362 | { |
5363 | - $value = (int)$matches[1]; |
|
5363 | + $value = (int) $matches[1]; |
|
5364 | 5364 | $str = $matches[2]; |
5365 | 5365 | } |
5366 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5366 | + else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5367 | 5367 | { |
5368 | - $value = (float)$matches[1]; |
|
5368 | + $value = (float) $matches[1]; |
|
5369 | 5369 | $str = $matches[3]; |
5370 | 5370 | } |
5371 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5371 | + else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";') |
|
5372 | 5372 | { |
5373 | - $value = substr($matches[2], 0, (int)$matches[1]); |
|
5374 | - $str = substr($matches[2], (int)$matches[1] + 2); |
|
5373 | + $value = substr($matches[2], 0, (int) $matches[1]); |
|
5374 | + $str = substr($matches[2], (int) $matches[1] + 2); |
|
5375 | 5375 | } |
5376 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5376 | + else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5377 | 5377 | { |
5378 | - $expectedLength = (int)$matches[1]; |
|
5378 | + $expectedLength = (int) $matches[1]; |
|
5379 | 5379 | $str = $matches[2]; |
5380 | 5380 | } |
5381 | 5381 | |
@@ -5383,10 +5383,10 @@ discard block |
||
5383 | 5383 | else |
5384 | 5384 | return false; |
5385 | 5385 | |
5386 | - switch($state) |
|
5386 | + switch ($state) |
|
5387 | 5387 | { |
5388 | 5388 | case 3: // In array, expecting value or another array. |
5389 | - if($type == 'a') |
|
5389 | + if ($type == 'a') |
|
5390 | 5390 | { |
5391 | 5391 | $stack[] = &$list; |
5392 | 5392 | $list[$key] = array(); |
@@ -5395,7 +5395,7 @@ discard block |
||
5395 | 5395 | $state = 2; |
5396 | 5396 | break; |
5397 | 5397 | } |
5398 | - if($type != '}') |
|
5398 | + if ($type != '}') |
|
5399 | 5399 | { |
5400 | 5400 | $list[$key] = $value; |
5401 | 5401 | $state = 2; |
@@ -5406,29 +5406,29 @@ discard block |
||
5406 | 5406 | return false; |
5407 | 5407 | |
5408 | 5408 | case 2: // in array, expecting end of array or a key |
5409 | - if($type == '}') |
|
5409 | + if ($type == '}') |
|
5410 | 5410 | { |
5411 | 5411 | // Array size is less than expected. |
5412 | - if(count($list) < end($expected)) |
|
5412 | + if (count($list) < end($expected)) |
|
5413 | 5413 | return false; |
5414 | 5414 | |
5415 | 5415 | unset($list); |
5416 | - $list = &$stack[count($stack)-1]; |
|
5416 | + $list = &$stack[count($stack) - 1]; |
|
5417 | 5417 | array_pop($stack); |
5418 | 5418 | |
5419 | 5419 | // Go to terminal state if we're at the end of the root array. |
5420 | 5420 | array_pop($expected); |
5421 | 5421 | |
5422 | - if(count($expected) == 0) |
|
5422 | + if (count($expected) == 0) |
|
5423 | 5423 | $state = 1; |
5424 | 5424 | |
5425 | 5425 | break; |
5426 | 5426 | } |
5427 | 5427 | |
5428 | - if($type == 'i' || $type == 's') |
|
5428 | + if ($type == 'i' || $type == 's') |
|
5429 | 5429 | { |
5430 | 5430 | // Array size exceeds expected length. |
5431 | - if(count($list) >= end($expected)) |
|
5431 | + if (count($list) >= end($expected)) |
|
5432 | 5432 | return false; |
5433 | 5433 | |
5434 | 5434 | $key = $value; |
@@ -5441,7 +5441,7 @@ discard block |
||
5441 | 5441 | |
5442 | 5442 | // Expecting array or value. |
5443 | 5443 | case 0: |
5444 | - if($type == 'a') |
|
5444 | + if ($type == 'a') |
|
5445 | 5445 | { |
5446 | 5446 | $data = array(); |
5447 | 5447 | $list = &$data; |
@@ -5450,7 +5450,7 @@ discard block |
||
5450 | 5450 | break; |
5451 | 5451 | } |
5452 | 5452 | |
5453 | - if($type != '}') |
|
5453 | + if ($type != '}') |
|
5454 | 5454 | { |
5455 | 5455 | $data = $value; |
5456 | 5456 | $state = 1; |
@@ -5463,7 +5463,7 @@ discard block |
||
5463 | 5463 | } |
5464 | 5464 | |
5465 | 5465 | // Trailing data in input. |
5466 | - if(!empty($str)) |
|
5466 | + if (!empty($str)) |
|
5467 | 5467 | return false; |
5468 | 5468 | |
5469 | 5469 | return $data; |
@@ -5517,7 +5517,7 @@ discard block |
||
5517 | 5517 | // Set different modes. |
5518 | 5518 | $chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666); |
5519 | 5519 | |
5520 | - foreach($chmodValues as $val) |
|
5520 | + foreach ($chmodValues as $val) |
|
5521 | 5521 | { |
5522 | 5522 | // If it's writable, break out of the loop. |
5523 | 5523 | if (is_writable($file)) |
@@ -5552,13 +5552,13 @@ discard block |
||
5552 | 5552 | $returnArray = @json_decode($json, $returnAsArray); |
5553 | 5553 | |
5554 | 5554 | // PHP 5.3 so no json_last_error_msg() |
5555 | - switch(json_last_error()) |
|
5555 | + switch (json_last_error()) |
|
5556 | 5556 | { |
5557 | 5557 | case JSON_ERROR_NONE: |
5558 | 5558 | $jsonError = false; |
5559 | 5559 | break; |
5560 | 5560 | case JSON_ERROR_DEPTH: |
5561 | - $jsonError = 'JSON_ERROR_DEPTH'; |
|
5561 | + $jsonError = 'JSON_ERROR_DEPTH'; |
|
5562 | 5562 | break; |
5563 | 5563 | case JSON_ERROR_STATE_MISMATCH: |
5564 | 5564 | $jsonError = 'JSON_ERROR_STATE_MISMATCH'; |
@@ -5586,10 +5586,10 @@ discard block |
||
5586 | 5586 | loadLanguage('Errors'); |
5587 | 5587 | |
5588 | 5588 | if (!empty($jsonDebug)) |
5589 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5589 | + log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5590 | 5590 | |
5591 | 5591 | else |
5592 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5592 | + log_error($txt['json_' . $jsonError], 'critical'); |
|
5593 | 5593 | |
5594 | 5594 | // Everyone expects an array. |
5595 | 5595 | return array(); |
@@ -5701,7 +5701,7 @@ discard block |
||
5701 | 5701 | }); |
5702 | 5702 | |
5703 | 5703 | // Convert Punycode to Unicode |
5704 | - $tlds = array_map(function ($input) { |
|
5704 | + $tlds = array_map(function($input) { |
|
5705 | 5705 | $prefix = 'xn--'; |
5706 | 5706 | $safe_char = 0xFFFC; |
5707 | 5707 | $base = 36; |
@@ -5717,7 +5717,7 @@ discard block |
||
5717 | 5717 | |
5718 | 5718 | foreach ($enco_parts as $encoded) |
5719 | 5719 | { |
5720 | - if (strpos($encoded,$prefix) !== 0 || strlen(trim(str_replace($prefix,'',$encoded))) == 0) |
|
5720 | + if (strpos($encoded, $prefix) !== 0 || strlen(trim(str_replace($prefix, '', $encoded))) == 0) |
|
5721 | 5721 | { |
5722 | 5722 | $output_parts[] = $encoded; |
5723 | 5723 | continue; |
@@ -5728,7 +5728,7 @@ discard block |
||
5728 | 5728 | $idx = 0; |
5729 | 5729 | $char = 0x80; |
5730 | 5730 | $decoded = array(); |
5731 | - $output=''; |
|
5731 | + $output = ''; |
|
5732 | 5732 | $delim_pos = strrpos($encoded, '-'); |
5733 | 5733 | |
5734 | 5734 | if ($delim_pos > strlen($prefix)) |
@@ -5744,7 +5744,7 @@ discard block |
||
5744 | 5744 | |
5745 | 5745 | for ($enco_idx = $delim_pos ? ($delim_pos + 1) : 0; $enco_idx < $enco_len; ++$deco_len) |
5746 | 5746 | { |
5747 | - for ($old_idx = $idx, $w = 1, $k = $base; 1 ; $k += $base) |
|
5747 | + for ($old_idx = $idx, $w = 1, $k = $base; 1; $k += $base) |
|
5748 | 5748 | { |
5749 | 5749 | $cp = ord($encoded{$enco_idx++}); |
5750 | 5750 | $digit = ($cp - 48 < 10) ? $cp - 22 : (($cp - 65 < 26) ? $cp - 65 : (($cp - 97 < 26) ? $cp - 97 : $base)); |
@@ -5785,15 +5785,15 @@ discard block |
||
5785 | 5785 | |
5786 | 5786 | // 2 bytes |
5787 | 5787 | elseif ($v < (1 << 11)) |
5788 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
5788 | + $output .= chr(192 + ($v >> 6)) . chr(128 + ($v & 63)); |
|
5789 | 5789 | |
5790 | 5790 | // 3 bytes |
5791 | 5791 | elseif ($v < (1 << 16)) |
5792 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
5792 | + $output .= chr(224 + ($v >> 12)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63)); |
|
5793 | 5793 | |
5794 | 5794 | // 4 bytes |
5795 | 5795 | elseif ($v < (1 << 21)) |
5796 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
5796 | + $output .= chr(240 + ($v >> 18)) . chr(128 + (($v >> 12) & 63)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63)); |
|
5797 | 5797 | |
5798 | 5798 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5799 | 5799 | else |
@@ -5898,7 +5898,7 @@ discard block |
||
5898 | 5898 | } |
5899 | 5899 | |
5900 | 5900 | // This recursive function creates the index array from the strings |
5901 | - $add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index) |
|
5901 | + $add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index) |
|
5902 | 5902 | { |
5903 | 5903 | static $depth = 0; |
5904 | 5904 | $depth++; |
@@ -5925,7 +5925,7 @@ discard block |
||
5925 | 5925 | }; |
5926 | 5926 | |
5927 | 5927 | // This recursive function turns the index array into a regular expression |
5928 | - $index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex) |
|
5928 | + $index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex) |
|
5929 | 5929 | { |
5930 | 5930 | static $depth = 0; |
5931 | 5931 | $depth++; |
@@ -5949,11 +5949,11 @@ discard block |
||
5949 | 5949 | |
5950 | 5950 | if (count(array_keys($value)) == 1) |
5951 | 5951 | { |
5952 | - $new_key_array = explode('(?'.'>', $sub_regex); |
|
5952 | + $new_key_array = explode('(?' . '>', $sub_regex); |
|
5953 | 5953 | $new_key .= $new_key_array[0]; |
5954 | 5954 | } |
5955 | 5955 | else |
5956 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5956 | + $sub_regex = '(?' . '>' . $sub_regex . ')'; |
|
5957 | 5957 | } |
5958 | 5958 | |
5959 | 5959 | if ($depth > 1) |
@@ -5996,10 +5996,10 @@ discard block |
||
5996 | 5996 | { |
5997 | 5997 | $regex = array(); |
5998 | 5998 | while (!empty($index)) |
5999 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
5999 | + $regex[] = '(?' . '>' . $index_to_regex($index, $delim) . ')'; |
|
6000 | 6000 | } |
6001 | 6001 | else |
6002 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6002 | + $regex = '(?' . '>' . $index_to_regex($index, $delim) . ')'; |
|
6003 | 6003 | |
6004 | 6004 | // Restore PHP's internal character encoding to whatever it was originally |
6005 | 6005 | if (!empty($current_encoding)) |
@@ -6020,7 +6020,7 @@ discard block |
||
6020 | 6020 | $url = str_ireplace('http://', 'https://', $url) . '/'; |
6021 | 6021 | |
6022 | 6022 | $result = false; |
6023 | - $stream = stream_context_create (array("ssl" => array("capture_peer_cert" => true))); |
|
6023 | + $stream = stream_context_create(array("ssl" => array("capture_peer_cert" => true))); |
|
6024 | 6024 | $read = @fopen($url, "rb", false, $stream); |
6025 | 6025 | if ($read !== false) { |
6026 | 6026 | $cont = stream_context_get_params($read); |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
122 | 123 | $smcFunc['db_free_result']($result); |
123 | 124 | |
124 | 125 | // Add this to the number of unapproved members |
125 | - if (!empty($changes['unapprovedMembers'])) |
|
126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
127 | - else |
|
128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
126 | + if (!empty($changes['unapprovedMembers'])) { |
|
127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
128 | + } else { |
|
129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
130 | + } |
|
129 | 131 | } |
130 | 132 | } |
131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
133 | 135 | break; |
134 | 136 | |
135 | 137 | case 'message': |
136 | - if ($parameter1 === true && $parameter2 !== null) |
|
137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
138 | - else |
|
138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
140 | + } else |
|
139 | 141 | { |
140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
175 | 177 | $parameter2 = text2words($parameter2); |
176 | 178 | |
177 | 179 | $inserts = array(); |
178 | - foreach ($parameter2 as $word) |
|
179 | - $inserts[] = array($word, $parameter1); |
|
180 | + foreach ($parameter2 as $word) { |
|
181 | + $inserts[] = array($word, $parameter1); |
|
182 | + } |
|
180 | 183 | |
181 | - if (!empty($inserts)) |
|
182 | - $smcFunc['db_insert']('ignore', |
|
184 | + if (!empty($inserts)) { |
|
185 | + $smcFunc['db_insert']('ignore', |
|
183 | 186 | '{db_prefix}log_search_subjects', |
184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
185 | 188 | $inserts, |
186 | 189 | array('word', 'id_topic') |
187 | 190 | ); |
191 | + } |
|
188 | 192 | } |
189 | 193 | break; |
190 | 194 | |
191 | 195 | case 'topic': |
192 | - if ($parameter1 === true) |
|
193 | - updateSettings(array('totalTopics' => true), true); |
|
194 | - else |
|
196 | + if ($parameter1 === true) { |
|
197 | + updateSettings(array('totalTopics' => true), true); |
|
198 | + } else |
|
195 | 199 | { |
196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
212 | 216 | |
213 | 217 | case 'postgroups': |
214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
216 | - return; |
|
219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
220 | + return; |
|
221 | + } |
|
217 | 222 | |
218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
228 | 233 | ) |
229 | 234 | ); |
230 | 235 | $postgroups = array(); |
231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
238 | + } |
|
233 | 239 | $smcFunc['db_free_result']($request); |
234 | 240 | |
235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
239 | 245 | } |
240 | 246 | |
241 | 247 | // Oh great, they've screwed their post groups. |
242 | - if (empty($postgroups)) |
|
243 | - return; |
|
248 | + if (empty($postgroups)) { |
|
249 | + return; |
|
250 | + } |
|
244 | 251 | |
245 | 252 | // Set all membergroups from most posts to least posts. |
246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
298 | 305 | { |
299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
300 | 307 | $parameters['members'] = $members; |
301 | - } |
|
302 | - elseif ($members === null) |
|
303 | - $condition = '1=1'; |
|
304 | - else |
|
308 | + } elseif ($members === null) { |
|
309 | + $condition = '1=1'; |
|
310 | + } else |
|
305 | 311 | { |
306 | 312 | $condition = 'id_member = {int:member}'; |
307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
341 | 347 | if (count($vars_to_integrate) != 0) |
342 | 348 | { |
343 | 349 | // Fetch a list of member_names if necessary |
344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
345 | - $member_names = array($user_info['username']); |
|
346 | - else |
|
350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
351 | + $member_names = array($user_info['username']); |
|
352 | + } else |
|
347 | 353 | { |
348 | 354 | $member_names = array(); |
349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
352 | 358 | WHERE ' . $condition, |
353 | 359 | $parameters |
354 | 360 | ); |
355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
356 | - $member_names[] = $row['member_name']; |
|
361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
362 | + $member_names[] = $row['member_name']; |
|
363 | + } |
|
357 | 364 | $smcFunc['db_free_result']($request); |
358 | 365 | } |
359 | 366 | |
360 | - if (!empty($member_names)) |
|
361 | - foreach ($vars_to_integrate as $var) |
|
367 | + if (!empty($member_names)) { |
|
368 | + foreach ($vars_to_integrate as $var) |
|
362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
370 | + } |
|
363 | 371 | } |
364 | 372 | } |
365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
367 | 375 | foreach ($data as $var => $val) |
368 | 376 | { |
369 | 377 | $type = 'string'; |
370 | - if (in_array($var, $knownInts)) |
|
371 | - $type = 'int'; |
|
372 | - elseif (in_array($var, $knownFloats)) |
|
373 | - $type = 'float'; |
|
374 | - elseif ($var == 'birthdate') |
|
375 | - $type = 'date'; |
|
376 | - elseif ($var == 'member_ip') |
|
377 | - $type = 'inet'; |
|
378 | - elseif ($var == 'member_ip2') |
|
379 | - $type = 'inet'; |
|
378 | + if (in_array($var, $knownInts)) { |
|
379 | + $type = 'int'; |
|
380 | + } elseif (in_array($var, $knownFloats)) { |
|
381 | + $type = 'float'; |
|
382 | + } elseif ($var == 'birthdate') { |
|
383 | + $type = 'date'; |
|
384 | + } elseif ($var == 'member_ip') { |
|
385 | + $type = 'inet'; |
|
386 | + } elseif ($var == 'member_ip2') { |
|
387 | + $type = 'inet'; |
|
388 | + } |
|
380 | 389 | |
381 | 390 | // Doing an increment? |
382 | 391 | if ($var == 'alerts' && ($val === '+' || $val === '-')) |
@@ -385,18 +394,17 @@ discard block |
||
385 | 394 | if (is_array($members)) |
386 | 395 | { |
387 | 396 | $val = 'CASE '; |
388 | - foreach ($members as $k => $v) |
|
389 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
397 | + foreach ($members as $k => $v) { |
|
398 | + $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
399 | + } |
|
390 | 400 | $val = $val . ' END'; |
391 | 401 | $type = 'raw'; |
392 | - } |
|
393 | - else |
|
402 | + } else |
|
394 | 403 | { |
395 | 404 | $blub = fetch_alerts($members, false, 0, array(), false); |
396 | 405 | $val = count($blub); |
397 | 406 | } |
398 | - } |
|
399 | - else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
407 | + } else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
400 | 408 | { |
401 | 409 | $val = $var . ' ' . $val . ' 1'; |
402 | 410 | $type = 'raw'; |
@@ -407,8 +415,9 @@ discard block |
||
407 | 415 | { |
408 | 416 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
409 | 417 | { |
410 | - if ($match[1] != '+ ') |
|
411 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
418 | + if ($match[1] != '+ ') { |
|
419 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
420 | + } |
|
412 | 421 | $type = 'raw'; |
413 | 422 | } |
414 | 423 | } |
@@ -429,8 +438,9 @@ discard block |
||
429 | 438 | // Clear any caching? |
430 | 439 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
431 | 440 | { |
432 | - if (!is_array($members)) |
|
433 | - $members = array($members); |
|
441 | + if (!is_array($members)) { |
|
442 | + $members = array($members); |
|
443 | + } |
|
434 | 444 | |
435 | 445 | foreach ($members as $member) |
436 | 446 | { |
@@ -463,29 +473,32 @@ discard block |
||
463 | 473 | { |
464 | 474 | global $modSettings, $smcFunc; |
465 | 475 | |
466 | - if (empty($changeArray) || !is_array($changeArray)) |
|
467 | - return; |
|
476 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
477 | + return; |
|
478 | + } |
|
468 | 479 | |
469 | 480 | $toRemove = array(); |
470 | 481 | |
471 | 482 | // Go check if there is any setting to be removed. |
472 | - foreach ($changeArray as $k => $v) |
|
473 | - if ($v === null) |
|
483 | + foreach ($changeArray as $k => $v) { |
|
484 | + if ($v === null) |
|
474 | 485 | { |
475 | 486 | // Found some, remove them from the original array and add them to ours. |
476 | 487 | unset($changeArray[$k]); |
488 | + } |
|
477 | 489 | $toRemove[] = $k; |
478 | 490 | } |
479 | 491 | |
480 | 492 | // Proceed with the deletion. |
481 | - if (!empty($toRemove)) |
|
482 | - $smcFunc['db_query']('', ' |
|
493 | + if (!empty($toRemove)) { |
|
494 | + $smcFunc['db_query']('', ' |
|
483 | 495 | DELETE FROM {db_prefix}settings |
484 | 496 | WHERE variable IN ({array_string:remove})', |
485 | 497 | array( |
486 | 498 | 'remove' => $toRemove, |
487 | 499 | ) |
488 | 500 | ); |
501 | + } |
|
489 | 502 | |
490 | 503 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
491 | 504 | if ($update) |
@@ -514,19 +527,22 @@ discard block |
||
514 | 527 | foreach ($changeArray as $variable => $value) |
515 | 528 | { |
516 | 529 | // Don't bother if it's already like that ;). |
517 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
518 | - continue; |
|
530 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
531 | + continue; |
|
532 | + } |
|
519 | 533 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
520 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
521 | - continue; |
|
534 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
535 | + continue; |
|
536 | + } |
|
522 | 537 | |
523 | 538 | $replaceArray[] = array($variable, $value); |
524 | 539 | |
525 | 540 | $modSettings[$variable] = $value; |
526 | 541 | } |
527 | 542 | |
528 | - if (empty($replaceArray)) |
|
529 | - return; |
|
543 | + if (empty($replaceArray)) { |
|
544 | + return; |
|
545 | + } |
|
530 | 546 | |
531 | 547 | $smcFunc['db_insert']('replace', |
532 | 548 | '{db_prefix}settings', |
@@ -572,14 +588,17 @@ discard block |
||
572 | 588 | $start_invalid = $start < 0; |
573 | 589 | |
574 | 590 | // Make sure $start is a proper variable - not less than 0. |
575 | - if ($start_invalid) |
|
576 | - $start = 0; |
|
591 | + if ($start_invalid) { |
|
592 | + $start = 0; |
|
593 | + } |
|
577 | 594 | // Not greater than the upper bound. |
578 | - elseif ($start >= $max_value) |
|
579 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
595 | + elseif ($start >= $max_value) { |
|
596 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
597 | + } |
|
580 | 598 | // And it has to be a multiple of $num_per_page! |
581 | - else |
|
582 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
599 | + else { |
|
600 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
601 | + } |
|
583 | 602 | |
584 | 603 | $context['current_page'] = $start / $num_per_page; |
585 | 604 | |
@@ -609,77 +628,87 @@ discard block |
||
609 | 628 | |
610 | 629 | // Show all the pages. |
611 | 630 | $display_page = 1; |
612 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
613 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
631 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
632 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
633 | + } |
|
614 | 634 | |
615 | 635 | // Show the right arrow. |
616 | 636 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
617 | - if ($start != $counter - $max_value && !$start_invalid) |
|
618 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
619 | - } |
|
620 | - else |
|
637 | + if ($start != $counter - $max_value && !$start_invalid) { |
|
638 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
639 | + } |
|
640 | + } else |
|
621 | 641 | { |
622 | 642 | // If they didn't enter an odd value, pretend they did. |
623 | 643 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
624 | 644 | |
625 | 645 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
626 | - if (!empty($start) && $show_prevnext) |
|
627 | - $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
628 | - else |
|
629 | - $pageindex .= ''; |
|
646 | + if (!empty($start) && $show_prevnext) { |
|
647 | + $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
648 | + } else { |
|
649 | + $pageindex .= ''; |
|
650 | + } |
|
630 | 651 | |
631 | 652 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
632 | - if ($start > $num_per_page * $PageContiguous) |
|
633 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
653 | + if ($start > $num_per_page * $PageContiguous) { |
|
654 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
655 | + } |
|
634 | 656 | |
635 | 657 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
636 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
637 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
658 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
659 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
638 | 660 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
639 | 661 | '{FIRST_PAGE}' => $num_per_page, |
640 | 662 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
641 | 663 | '{PER_PAGE}' => $num_per_page, |
642 | 664 | )); |
665 | + } |
|
643 | 666 | |
644 | 667 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
645 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
646 | - if ($start >= $num_per_page * $nCont) |
|
668 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
669 | + if ($start >= $num_per_page * $nCont) |
|
647 | 670 | { |
648 | 671 | $tmpStart = $start - $num_per_page * $nCont; |
672 | + } |
|
649 | 673 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
650 | 674 | } |
651 | 675 | |
652 | 676 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
653 | - if (!$start_invalid) |
|
654 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
655 | - else |
|
656 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
677 | + if (!$start_invalid) { |
|
678 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
679 | + } else { |
|
680 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
681 | + } |
|
657 | 682 | |
658 | 683 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
659 | 684 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
660 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
661 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
685 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
686 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
662 | 687 | { |
663 | 688 | $tmpStart = $start + $num_per_page * $nCont; |
689 | + } |
|
664 | 690 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
665 | 691 | } |
666 | 692 | |
667 | 693 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
668 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
669 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
694 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
695 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
670 | 696 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
671 | 697 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
672 | 698 | '{LAST_PAGE}' => $tmpMaxPages, |
673 | 699 | '{PER_PAGE}' => $num_per_page, |
674 | 700 | )); |
701 | + } |
|
675 | 702 | |
676 | 703 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
677 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
678 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
704 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
705 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
706 | + } |
|
679 | 707 | |
680 | 708 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
681 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
682 | - $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
709 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
710 | + $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
711 | + } |
|
683 | 712 | } |
684 | 713 | $pageindex .= $settings['page_index']['extra_after']; |
685 | 714 | |
@@ -705,8 +734,9 @@ discard block |
||
705 | 734 | if ($decimal_separator === null) |
706 | 735 | { |
707 | 736 | // Not set for whatever reason? |
708 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
709 | - return $number; |
|
737 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
738 | + return $number; |
|
739 | + } |
|
710 | 740 | |
711 | 741 | // Cache these each load... |
712 | 742 | $thousands_separator = $matches[1]; |
@@ -740,17 +770,20 @@ discard block |
||
740 | 770 | static $unsupportedFormats, $finalizedFormats; |
741 | 771 | |
742 | 772 | // Offset the time. |
743 | - if (!$offset_type) |
|
744 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
773 | + if (!$offset_type) { |
|
774 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
775 | + } |
|
745 | 776 | // Just the forum offset? |
746 | - elseif ($offset_type == 'forum') |
|
747 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
748 | - else |
|
749 | - $time = $log_time; |
|
777 | + elseif ($offset_type == 'forum') { |
|
778 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
779 | + } else { |
|
780 | + $time = $log_time; |
|
781 | + } |
|
750 | 782 | |
751 | 783 | // We can't have a negative date (on Windows, at least.) |
752 | - if ($log_time < 0) |
|
753 | - $log_time = 0; |
|
784 | + if ($log_time < 0) { |
|
785 | + $log_time = 0; |
|
786 | + } |
|
754 | 787 | |
755 | 788 | // Today and Yesterday? |
756 | 789 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -767,24 +800,27 @@ discard block |
||
767 | 800 | { |
768 | 801 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
769 | 802 | $today_fmt = $h . ':%M' . $s . ' %p'; |
803 | + } else { |
|
804 | + $today_fmt = '%H:%M' . $s; |
|
770 | 805 | } |
771 | - else |
|
772 | - $today_fmt = '%H:%M' . $s; |
|
773 | 806 | |
774 | 807 | // Same day of the year, same year.... Today! |
775 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
776 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
808 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
809 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
810 | + } |
|
777 | 811 | |
778 | 812 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
779 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
780 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
813 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
814 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
815 | + } |
|
781 | 816 | } |
782 | 817 | |
783 | 818 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
784 | 819 | |
785 | 820 | // Use the cached formats if available |
786 | - if (is_null($finalizedFormats)) |
|
787 | - $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
821 | + if (is_null($finalizedFormats)) { |
|
822 | + $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
823 | + } |
|
788 | 824 | |
789 | 825 | // Make a supported version for this format if we don't already have one |
790 | 826 | if (empty($finalizedFormats[$str])) |
@@ -813,8 +849,9 @@ discard block |
||
813 | 849 | ); |
814 | 850 | |
815 | 851 | // No need to do this part again if we already did it once |
816 | - if (is_null($unsupportedFormats)) |
|
817 | - $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
852 | + if (is_null($unsupportedFormats)) { |
|
853 | + $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
854 | + } |
|
818 | 855 | if (empty($unsupportedFormats)) |
819 | 856 | { |
820 | 857 | foreach($strftimeFormatSubstitutions as $format => $substitution) |
@@ -823,20 +860,23 @@ discard block |
||
823 | 860 | |
824 | 861 | // Windows will return false for unsupported formats |
825 | 862 | // Other operating systems return the format string as a literal |
826 | - if ($value === false || $value === $format) |
|
827 | - $unsupportedFormats[] = $format; |
|
863 | + if ($value === false || $value === $format) { |
|
864 | + $unsupportedFormats[] = $format; |
|
865 | + } |
|
828 | 866 | } |
829 | 867 | cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400); |
830 | 868 | } |
831 | 869 | |
832 | 870 | // Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q' |
833 | - if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') |
|
834 | - $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
871 | + if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') { |
|
872 | + $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
873 | + } |
|
835 | 874 | |
836 | 875 | // Substitute unsupported formats with supported ones |
837 | - if (!empty($unsupportedFormats)) |
|
838 | - while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
876 | + if (!empty($unsupportedFormats)) { |
|
877 | + while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
839 | 878 | $timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat); |
879 | + } |
|
840 | 880 | |
841 | 881 | // Remember this so we don't need to do it again |
842 | 882 | $finalizedFormats[$str] = $timeformat; |
@@ -845,33 +885,39 @@ discard block |
||
845 | 885 | |
846 | 886 | $str = $finalizedFormats[$str]; |
847 | 887 | |
848 | - if (!isset($locale_cache)) |
|
849 | - $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
888 | + if (!isset($locale_cache)) { |
|
889 | + $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
890 | + } |
|
850 | 891 | |
851 | 892 | if ($locale_cache !== false) |
852 | 893 | { |
853 | 894 | // Check if another process changed the locale |
854 | - if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) |
|
855 | - setlocale(LC_TIME, $txt['lang_locale']); |
|
895 | + if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) { |
|
896 | + setlocale(LC_TIME, $txt['lang_locale']); |
|
897 | + } |
|
856 | 898 | |
857 | - if (!isset($non_twelve_hour)) |
|
858 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
859 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
860 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
899 | + if (!isset($non_twelve_hour)) { |
|
900 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
901 | + } |
|
902 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
903 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
904 | + } |
|
861 | 905 | |
862 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
863 | - if (strpos($str, $token) !== false) |
|
906 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
907 | + if (strpos($str, $token) !== false) |
|
864 | 908 | $str = str_replace($token, strftime($token, $time), $str); |
865 | - } |
|
866 | - else |
|
909 | + } |
|
910 | + } else |
|
867 | 911 | { |
868 | 912 | // Do-it-yourself time localization. Fun. |
869 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
870 | - if (strpos($str, $token) !== false) |
|
913 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
914 | + if (strpos($str, $token) !== false) |
|
871 | 915 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
916 | + } |
|
872 | 917 | |
873 | - if (strpos($str, '%p') !== false) |
|
874 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
918 | + if (strpos($str, '%p') !== false) { |
|
919 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
920 | + } |
|
875 | 921 | } |
876 | 922 | |
877 | 923 | // Format the time and then restore any literal percent characters |
@@ -894,16 +940,19 @@ discard block |
||
894 | 940 | static $translation = array(); |
895 | 941 | |
896 | 942 | // Determine the character set... Default to UTF-8 |
897 | - if (empty($context['character_set'])) |
|
898 | - $charset = 'UTF-8'; |
|
943 | + if (empty($context['character_set'])) { |
|
944 | + $charset = 'UTF-8'; |
|
945 | + } |
|
899 | 946 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
900 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
901 | - $charset = 'ISO-8859-1'; |
|
902 | - else |
|
903 | - $charset = $context['character_set']; |
|
947 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
948 | + $charset = 'ISO-8859-1'; |
|
949 | + } else { |
|
950 | + $charset = $context['character_set']; |
|
951 | + } |
|
904 | 952 | |
905 | - if (empty($translation)) |
|
906 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
953 | + if (empty($translation)) { |
|
954 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
955 | + } |
|
907 | 956 | |
908 | 957 | return strtr($string, $translation); |
909 | 958 | } |
@@ -925,8 +974,9 @@ discard block |
||
925 | 974 | global $smcFunc; |
926 | 975 | |
927 | 976 | // It was already short enough! |
928 | - if ($smcFunc['strlen']($subject) <= $len) |
|
929 | - return $subject; |
|
977 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
978 | + return $subject; |
|
979 | + } |
|
930 | 980 | |
931 | 981 | // Shorten it by the length it was too long, and strip off junk from the end. |
932 | 982 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -945,10 +995,11 @@ discard block |
||
945 | 995 | { |
946 | 996 | global $user_info, $modSettings; |
947 | 997 | |
948 | - if ($timestamp === null) |
|
949 | - $timestamp = time(); |
|
950 | - elseif ($timestamp == 0) |
|
951 | - return 0; |
|
998 | + if ($timestamp === null) { |
|
999 | + $timestamp = time(); |
|
1000 | + } elseif ($timestamp == 0) { |
|
1001 | + return 0; |
|
1002 | + } |
|
952 | 1003 | |
953 | 1004 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
954 | 1005 | } |
@@ -977,8 +1028,9 @@ discard block |
||
977 | 1028 | $array[$i] = $array[$j]; |
978 | 1029 | $array[$j] = $temp; |
979 | 1030 | |
980 | - for ($i = 1; $p[$i] == 0; $i++) |
|
981 | - $p[$i] = 1; |
|
1031 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
1032 | + $p[$i] = 1; |
|
1033 | + } |
|
982 | 1034 | |
983 | 1035 | $orders[] = $array; |
984 | 1036 | } |
@@ -1010,12 +1062,14 @@ discard block |
||
1010 | 1062 | static $disabled; |
1011 | 1063 | |
1012 | 1064 | // Don't waste cycles |
1013 | - if ($message === '') |
|
1014 | - return ''; |
|
1065 | + if ($message === '') { |
|
1066 | + return ''; |
|
1067 | + } |
|
1015 | 1068 | |
1016 | 1069 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
1017 | - if (!isset($context['utf8'])) |
|
1018 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1070 | + if (!isset($context['utf8'])) { |
|
1071 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1072 | + } |
|
1019 | 1073 | |
1020 | 1074 | // Clean up any cut/paste issues we may have |
1021 | 1075 | $message = sanitizeMSCutPaste($message); |
@@ -1027,13 +1081,15 @@ discard block |
||
1027 | 1081 | return $message; |
1028 | 1082 | } |
1029 | 1083 | |
1030 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
1031 | - $smileys = (bool) $smileys; |
|
1084 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
1085 | + $smileys = (bool) $smileys; |
|
1086 | + } |
|
1032 | 1087 | |
1033 | 1088 | if (empty($modSettings['enableBBC']) && $message !== false) |
1034 | 1089 | { |
1035 | - if ($smileys === true) |
|
1036 | - parsesmileys($message); |
|
1090 | + if ($smileys === true) { |
|
1091 | + parsesmileys($message); |
|
1092 | + } |
|
1037 | 1093 | |
1038 | 1094 | return $message; |
1039 | 1095 | } |
@@ -1046,8 +1102,9 @@ discard block |
||
1046 | 1102 | } |
1047 | 1103 | |
1048 | 1104 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
1049 | - if (!empty($modSettings['autoLinkUrls'])) |
|
1050 | - set_tld_regex(); |
|
1105 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
1106 | + set_tld_regex(); |
|
1107 | + } |
|
1051 | 1108 | |
1052 | 1109 | // Allow mods access before entering the main parse_bbc loop |
1053 | 1110 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1061,12 +1118,14 @@ discard block |
||
1061 | 1118 | |
1062 | 1119 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
1063 | 1120 | |
1064 | - foreach ($temp as $tag) |
|
1065 | - $disabled[trim($tag)] = true; |
|
1121 | + foreach ($temp as $tag) { |
|
1122 | + $disabled[trim($tag)] = true; |
|
1123 | + } |
|
1066 | 1124 | } |
1067 | 1125 | |
1068 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1069 | - $disabled['flash'] = true; |
|
1126 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1127 | + $disabled['flash'] = true; |
|
1128 | + } |
|
1070 | 1129 | |
1071 | 1130 | /* The following bbc are formatted as an array, with keys as follows: |
1072 | 1131 | |
@@ -1187,8 +1246,9 @@ discard block |
||
1187 | 1246 | $returnContext = ''; |
1188 | 1247 | |
1189 | 1248 | // BBC or the entire attachments feature is disabled |
1190 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
1191 | - return $data; |
|
1249 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
1250 | + return $data; |
|
1251 | + } |
|
1192 | 1252 | |
1193 | 1253 | // Save the attach ID. |
1194 | 1254 | $attachID = $data; |
@@ -1199,8 +1259,9 @@ discard block |
||
1199 | 1259 | $currentAttachment = parseAttachBBC($attachID); |
1200 | 1260 | |
1201 | 1261 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
1202 | - if (is_string($currentAttachment)) |
|
1203 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1262 | + if (is_string($currentAttachment)) { |
|
1263 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1264 | + } |
|
1204 | 1265 | |
1205 | 1266 | if (!empty($currentAttachment['is_image'])) |
1206 | 1267 | { |
@@ -1216,15 +1277,17 @@ discard block |
||
1216 | 1277 | $height = ' height="' . $currentAttachment['height'] . '"'; |
1217 | 1278 | } |
1218 | 1279 | |
1219 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
1220 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1221 | - else |
|
1222 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1280 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
1281 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1282 | + } else { |
|
1283 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1284 | + } |
|
1223 | 1285 | } |
1224 | 1286 | |
1225 | 1287 | // No image. Show a link. |
1226 | - else |
|
1227 | - $returnContext .= $currentAttachment['link']; |
|
1288 | + else { |
|
1289 | + $returnContext .= $currentAttachment['link']; |
|
1290 | + } |
|
1228 | 1291 | |
1229 | 1292 | // Gotta append what we just did. |
1230 | 1293 | $data = $returnContext; |
@@ -1255,8 +1318,9 @@ discard block |
||
1255 | 1318 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1256 | 1319 | { |
1257 | 1320 | // Do PHP code coloring? |
1258 | - if ($php_parts[$php_i] != '<?php') |
|
1259 | - continue; |
|
1321 | + if ($php_parts[$php_i] != '<?php') { |
|
1322 | + continue; |
|
1323 | + } |
|
1260 | 1324 | |
1261 | 1325 | $php_string = ''; |
1262 | 1326 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1272,8 +1336,9 @@ discard block |
||
1272 | 1336 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
1273 | 1337 | |
1274 | 1338 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1275 | - if ($context['browser']['is_opera']) |
|
1276 | - $data .= ' '; |
|
1339 | + if ($context['browser']['is_opera']) { |
|
1340 | + $data .= ' '; |
|
1341 | + } |
|
1277 | 1342 | } |
1278 | 1343 | }, |
1279 | 1344 | 'block_level' => true, |
@@ -1292,8 +1357,9 @@ discard block |
||
1292 | 1357 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1293 | 1358 | { |
1294 | 1359 | // Do PHP code coloring? |
1295 | - if ($php_parts[$php_i] != '<?php') |
|
1296 | - continue; |
|
1360 | + if ($php_parts[$php_i] != '<?php') { |
|
1361 | + continue; |
|
1362 | + } |
|
1297 | 1363 | |
1298 | 1364 | $php_string = ''; |
1299 | 1365 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1309,8 +1375,9 @@ discard block |
||
1309 | 1375 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
1310 | 1376 | |
1311 | 1377 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1312 | - if ($context['browser']['is_opera']) |
|
1313 | - $data[0] .= ' '; |
|
1378 | + if ($context['browser']['is_opera']) { |
|
1379 | + $data[0] .= ' '; |
|
1380 | + } |
|
1314 | 1381 | } |
1315 | 1382 | }, |
1316 | 1383 | 'block_level' => true, |
@@ -1348,11 +1415,13 @@ discard block |
||
1348 | 1415 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1349 | 1416 | 'validate' => function (&$tag, &$data, $disabled) |
1350 | 1417 | { |
1351 | - if (isset($disabled['url'])) |
|
1352 | - $tag['content'] = '$1'; |
|
1418 | + if (isset($disabled['url'])) { |
|
1419 | + $tag['content'] = '$1'; |
|
1420 | + } |
|
1353 | 1421 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
1354 | - if (empty($scheme)) |
|
1355 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
1422 | + if (empty($scheme)) { |
|
1423 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
1424 | + } |
|
1356 | 1425 | }, |
1357 | 1426 | 'disabled_content' => '<a href="$1" target="_blank">$1</a>', |
1358 | 1427 | ), |
@@ -1366,10 +1435,11 @@ discard block |
||
1366 | 1435 | { |
1367 | 1436 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1368 | 1437 | |
1369 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
1370 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1371 | - else |
|
1372 | - $css = ''; |
|
1438 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
1439 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1440 | + } else { |
|
1441 | + $css = ''; |
|
1442 | + } |
|
1373 | 1443 | |
1374 | 1444 | $data = $class . $css; |
1375 | 1445 | }, |
@@ -1419,14 +1489,16 @@ discard block |
||
1419 | 1489 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1420 | 1490 | if ($image_proxy_enabled) |
1421 | 1491 | { |
1422 | - if (empty($scheme)) |
|
1423 | - $data = 'http://' . ltrim($data, ':/'); |
|
1492 | + if (empty($scheme)) { |
|
1493 | + $data = 'http://' . ltrim($data, ':/'); |
|
1494 | + } |
|
1424 | 1495 | |
1425 | - if ($scheme != 'https') |
|
1426 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1496 | + if ($scheme != 'https') { |
|
1497 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1498 | + } |
|
1499 | + } elseif (empty($scheme)) { |
|
1500 | + $data = '//' . ltrim($data, ':/'); |
|
1427 | 1501 | } |
1428 | - elseif (empty($scheme)) |
|
1429 | - $data = '//' . ltrim($data, ':/'); |
|
1430 | 1502 | }, |
1431 | 1503 | 'disabled_content' => '($1)', |
1432 | 1504 | ), |
@@ -1442,14 +1514,16 @@ discard block |
||
1442 | 1514 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1443 | 1515 | if ($image_proxy_enabled) |
1444 | 1516 | { |
1445 | - if (empty($scheme)) |
|
1446 | - $data = 'http://' . ltrim($data, ':/'); |
|
1517 | + if (empty($scheme)) { |
|
1518 | + $data = 'http://' . ltrim($data, ':/'); |
|
1519 | + } |
|
1447 | 1520 | |
1448 | - if ($scheme != 'https') |
|
1449 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1521 | + if ($scheme != 'https') { |
|
1522 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1523 | + } |
|
1524 | + } elseif (empty($scheme)) { |
|
1525 | + $data = '//' . ltrim($data, ':/'); |
|
1450 | 1526 | } |
1451 | - elseif (empty($scheme)) |
|
1452 | - $data = '//' . ltrim($data, ':/'); |
|
1453 | 1527 | }, |
1454 | 1528 | 'disabled_content' => '($1)', |
1455 | 1529 | ), |
@@ -1461,8 +1535,9 @@ discard block |
||
1461 | 1535 | { |
1462 | 1536 | $data = strtr($data, array('<br>' => '')); |
1463 | 1537 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1464 | - if (empty($scheme)) |
|
1465 | - $data = '//' . ltrim($data, ':/'); |
|
1538 | + if (empty($scheme)) { |
|
1539 | + $data = '//' . ltrim($data, ':/'); |
|
1540 | + } |
|
1466 | 1541 | }, |
1467 | 1542 | ), |
1468 | 1543 | array( |
@@ -1473,13 +1548,14 @@ discard block |
||
1473 | 1548 | 'after' => '</a>', |
1474 | 1549 | 'validate' => function (&$tag, &$data, $disabled) |
1475 | 1550 | { |
1476 | - if (substr($data, 0, 1) == '#') |
|
1477 | - $data = '#post_' . substr($data, 1); |
|
1478 | - else |
|
1551 | + if (substr($data, 0, 1) == '#') { |
|
1552 | + $data = '#post_' . substr($data, 1); |
|
1553 | + } else |
|
1479 | 1554 | { |
1480 | 1555 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1481 | - if (empty($scheme)) |
|
1482 | - $data = '//' . ltrim($data, ':/'); |
|
1556 | + if (empty($scheme)) { |
|
1557 | + $data = '//' . ltrim($data, ':/'); |
|
1558 | + } |
|
1483 | 1559 | } |
1484 | 1560 | }, |
1485 | 1561 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1557,8 +1633,9 @@ discard block |
||
1557 | 1633 | { |
1558 | 1634 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
1559 | 1635 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
1560 | - if ($add_begin) |
|
1561 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1636 | + if ($add_begin) { |
|
1637 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1638 | + } |
|
1562 | 1639 | } |
1563 | 1640 | }, |
1564 | 1641 | 'block_level' => false, |
@@ -1689,10 +1766,11 @@ discard block |
||
1689 | 1766 | 'content' => '$1', |
1690 | 1767 | 'validate' => function (&$tag, &$data, $disabled) |
1691 | 1768 | { |
1692 | - if (is_numeric($data)) |
|
1693 | - $data = timeformat($data); |
|
1694 | - else |
|
1695 | - $tag['content'] = '[time]$1[/time]'; |
|
1769 | + if (is_numeric($data)) { |
|
1770 | + $data = timeformat($data); |
|
1771 | + } else { |
|
1772 | + $tag['content'] = '[time]$1[/time]'; |
|
1773 | + } |
|
1696 | 1774 | }, |
1697 | 1775 | ), |
1698 | 1776 | array( |
@@ -1719,8 +1797,9 @@ discard block |
||
1719 | 1797 | { |
1720 | 1798 | $data = strtr($data, array('<br>' => '')); |
1721 | 1799 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1722 | - if (empty($scheme)) |
|
1723 | - $data = '//' . ltrim($data, ':/'); |
|
1800 | + if (empty($scheme)) { |
|
1801 | + $data = '//' . ltrim($data, ':/'); |
|
1802 | + } |
|
1724 | 1803 | }, |
1725 | 1804 | ), |
1726 | 1805 | array( |
@@ -1732,8 +1811,9 @@ discard block |
||
1732 | 1811 | 'validate' => function (&$tag, &$data, $disabled) |
1733 | 1812 | { |
1734 | 1813 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1735 | - if (empty($scheme)) |
|
1736 | - $data = '//' . ltrim($data, ':/'); |
|
1814 | + if (empty($scheme)) { |
|
1815 | + $data = '//' . ltrim($data, ':/'); |
|
1816 | + } |
|
1737 | 1817 | }, |
1738 | 1818 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
1739 | 1819 | 'disabled_after' => ' ($1)', |
@@ -1753,8 +1833,9 @@ discard block |
||
1753 | 1833 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
1754 | 1834 | if ($message === false) |
1755 | 1835 | { |
1756 | - if (isset($temp_bbc)) |
|
1757 | - $bbc_codes = $temp_bbc; |
|
1836 | + if (isset($temp_bbc)) { |
|
1837 | + $bbc_codes = $temp_bbc; |
|
1838 | + } |
|
1758 | 1839 | usort($codes, function ($a, $b) { |
1759 | 1840 | return strcmp($a['tag'], $b['tag']); |
1760 | 1841 | }); |
@@ -1774,8 +1855,9 @@ discard block |
||
1774 | 1855 | ); |
1775 | 1856 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
1776 | 1857 | { |
1777 | - foreach ($itemcodes as $c => $dummy) |
|
1778 | - $bbc_codes[$c] = array(); |
|
1858 | + foreach ($itemcodes as $c => $dummy) { |
|
1859 | + $bbc_codes[$c] = array(); |
|
1860 | + } |
|
1779 | 1861 | } |
1780 | 1862 | |
1781 | 1863 | // Shhhh! |
@@ -1796,12 +1878,14 @@ discard block |
||
1796 | 1878 | foreach ($codes as $code) |
1797 | 1879 | { |
1798 | 1880 | // Make it easier to process parameters later |
1799 | - if (!empty($code['parameters'])) |
|
1800 | - ksort($code['parameters'], SORT_STRING); |
|
1881 | + if (!empty($code['parameters'])) { |
|
1882 | + ksort($code['parameters'], SORT_STRING); |
|
1883 | + } |
|
1801 | 1884 | |
1802 | 1885 | // If we are not doing every tag only do ones we are interested in. |
1803 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
1804 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1886 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
1887 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1888 | + } |
|
1805 | 1889 | } |
1806 | 1890 | $codes = null; |
1807 | 1891 | } |
@@ -1812,8 +1896,9 @@ discard block |
||
1812 | 1896 | // It's likely this will change if the message is modified. |
1813 | 1897 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
1814 | 1898 | |
1815 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
1816 | - return $temp; |
|
1899 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
1900 | + return $temp; |
|
1901 | + } |
|
1817 | 1902 | |
1818 | 1903 | $cache_t = microtime(); |
1819 | 1904 | } |
@@ -1845,8 +1930,9 @@ discard block |
||
1845 | 1930 | $disabled['flash'] = true; |
1846 | 1931 | |
1847 | 1932 | // @todo Change maybe? |
1848 | - if (!isset($_GET['images'])) |
|
1849 | - $disabled['img'] = true; |
|
1933 | + if (!isset($_GET['images'])) { |
|
1934 | + $disabled['img'] = true; |
|
1935 | + } |
|
1850 | 1936 | |
1851 | 1937 | // @todo Interface/setting to add more? |
1852 | 1938 | } |
@@ -1870,8 +1956,9 @@ discard block |
||
1870 | 1956 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
1871 | 1957 | |
1872 | 1958 | // Failsafe. |
1873 | - if ($pos === false || $last_pos > $pos) |
|
1874 | - $pos = strlen($message) + 1; |
|
1959 | + if ($pos === false || $last_pos > $pos) { |
|
1960 | + $pos = strlen($message) + 1; |
|
1961 | + } |
|
1875 | 1962 | |
1876 | 1963 | // Can't have a one letter smiley, URL, or email! (sorry.) |
1877 | 1964 | if ($last_pos < $pos - 1) |
@@ -1889,8 +1976,9 @@ discard block |
||
1889 | 1976 | |
1890 | 1977 | // <br> should be empty. |
1891 | 1978 | $empty_tags = array('br', 'hr'); |
1892 | - foreach ($empty_tags as $tag) |
|
1893 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1979 | + foreach ($empty_tags as $tag) { |
|
1980 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1981 | + } |
|
1894 | 1982 | |
1895 | 1983 | // b, u, i, s, pre... basic tags. |
1896 | 1984 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong'); |
@@ -1899,8 +1987,9 @@ discard block |
||
1899 | 1987 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
1900 | 1988 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
1901 | 1989 | |
1902 | - if ($diff > 0) |
|
1903 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1990 | + if ($diff > 0) { |
|
1991 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1992 | + } |
|
1904 | 1993 | } |
1905 | 1994 | |
1906 | 1995 | // Do <img ...> - with security... action= -> action-. |
@@ -1913,8 +2002,9 @@ discard block |
||
1913 | 2002 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
1914 | 2003 | |
1915 | 2004 | // Remove action= from the URL - no funny business, now. |
1916 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
1917 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2005 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
2006 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2007 | + } |
|
1918 | 2008 | |
1919 | 2009 | // Check if the image is larger than allowed. |
1920 | 2010 | if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height'])) |
@@ -1935,9 +2025,9 @@ discard block |
||
1935 | 2025 | |
1936 | 2026 | // Set the new image tag. |
1937 | 2027 | $replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]'; |
2028 | + } else { |
|
2029 | + $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1938 | 2030 | } |
1939 | - else |
|
1940 | - $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1941 | 2031 | } |
1942 | 2032 | |
1943 | 2033 | $data = strtr($data, $replaces); |
@@ -1950,16 +2040,18 @@ discard block |
||
1950 | 2040 | $no_autolink_area = false; |
1951 | 2041 | if (!empty($open_tags)) |
1952 | 2042 | { |
1953 | - foreach ($open_tags as $open_tag) |
|
1954 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
2043 | + foreach ($open_tags as $open_tag) { |
|
2044 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
1955 | 2045 | $no_autolink_area = true; |
2046 | + } |
|
1956 | 2047 | } |
1957 | 2048 | |
1958 | 2049 | // Don't go backwards. |
1959 | 2050 | // @todo Don't think is the real solution.... |
1960 | 2051 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
1961 | - if ($pos < $lastAutoPos) |
|
1962 | - $no_autolink_area = true; |
|
2052 | + if ($pos < $lastAutoPos) { |
|
2053 | + $no_autolink_area = true; |
|
2054 | + } |
|
1963 | 2055 | $lastAutoPos = $pos; |
1964 | 2056 | |
1965 | 2057 | if (!$no_autolink_area) |
@@ -2068,17 +2160,19 @@ discard block |
||
2068 | 2160 | if ($scheme == 'mailto') |
2069 | 2161 | { |
2070 | 2162 | $email_address = str_replace('mailto:', '', $url); |
2071 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
2072 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2073 | - else |
|
2074 | - return $url; |
|
2163 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
2164 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2165 | + } else { |
|
2166 | + return $url; |
|
2167 | + } |
|
2075 | 2168 | } |
2076 | 2169 | |
2077 | 2170 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
2078 | - if (empty($scheme)) |
|
2079 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
2080 | - else |
|
2081 | - $fullUrl = $url; |
|
2171 | + if (empty($scheme)) { |
|
2172 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
2173 | + } else { |
|
2174 | + $fullUrl = $url; |
|
2175 | + } |
|
2082 | 2176 | |
2083 | 2177 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
2084 | 2178 | }, $data); |
@@ -2127,16 +2221,18 @@ discard block |
||
2127 | 2221 | } |
2128 | 2222 | |
2129 | 2223 | // Are we there yet? Are we there yet? |
2130 | - if ($pos >= strlen($message) - 1) |
|
2131 | - break; |
|
2224 | + if ($pos >= strlen($message) - 1) { |
|
2225 | + break; |
|
2226 | + } |
|
2132 | 2227 | |
2133 | 2228 | $tags = strtolower($message[$pos + 1]); |
2134 | 2229 | |
2135 | 2230 | if ($tags == '/' && !empty($open_tags)) |
2136 | 2231 | { |
2137 | 2232 | $pos2 = strpos($message, ']', $pos + 1); |
2138 | - if ($pos2 == $pos + 2) |
|
2139 | - continue; |
|
2233 | + if ($pos2 == $pos + 2) { |
|
2234 | + continue; |
|
2235 | + } |
|
2140 | 2236 | |
2141 | 2237 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
2142 | 2238 | |
@@ -2146,8 +2242,9 @@ discard block |
||
2146 | 2242 | do |
2147 | 2243 | { |
2148 | 2244 | $tag = array_pop($open_tags); |
2149 | - if (!$tag) |
|
2150 | - break; |
|
2245 | + if (!$tag) { |
|
2246 | + break; |
|
2247 | + } |
|
2151 | 2248 | |
2152 | 2249 | if (!empty($tag['block_level'])) |
2153 | 2250 | { |
@@ -2161,10 +2258,11 @@ discard block |
||
2161 | 2258 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
2162 | 2259 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
2163 | 2260 | { |
2164 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2165 | - if ($temp['tag'] == $look_for) |
|
2261 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2262 | + if ($temp['tag'] == $look_for) |
|
2166 | 2263 | { |
2167 | 2264 | $block_level = !empty($temp['block_level']); |
2265 | + } |
|
2168 | 2266 | break; |
2169 | 2267 | } |
2170 | 2268 | } |
@@ -2186,15 +2284,15 @@ discard block |
||
2186 | 2284 | { |
2187 | 2285 | $open_tags = $to_close; |
2188 | 2286 | continue; |
2189 | - } |
|
2190 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2287 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2191 | 2288 | { |
2192 | 2289 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
2193 | 2290 | { |
2194 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2195 | - if ($temp['tag'] == $look_for) |
|
2291 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2292 | + if ($temp['tag'] == $look_for) |
|
2196 | 2293 | { |
2197 | 2294 | $block_level = !empty($temp['block_level']); |
2295 | + } |
|
2198 | 2296 | break; |
2199 | 2297 | } |
2200 | 2298 | } |
@@ -2202,8 +2300,9 @@ discard block |
||
2202 | 2300 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
2203 | 2301 | if (!$block_level) |
2204 | 2302 | { |
2205 | - foreach ($to_close as $tag) |
|
2206 | - array_push($open_tags, $tag); |
|
2303 | + foreach ($to_close as $tag) { |
|
2304 | + array_push($open_tags, $tag); |
|
2305 | + } |
|
2207 | 2306 | continue; |
2208 | 2307 | } |
2209 | 2308 | } |
@@ -2216,14 +2315,17 @@ discard block |
||
2216 | 2315 | |
2217 | 2316 | // See the comment at the end of the big loop - just eating whitespace ;). |
2218 | 2317 | $whitespace_regex = ''; |
2219 | - if (!empty($tag['block_level'])) |
|
2220 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2318 | + if (!empty($tag['block_level'])) { |
|
2319 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2320 | + } |
|
2221 | 2321 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
2222 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2223 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2322 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2323 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2324 | + } |
|
2224 | 2325 | |
2225 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2226 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2326 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2327 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2328 | + } |
|
2227 | 2329 | } |
2228 | 2330 | |
2229 | 2331 | if (!empty($to_close)) |
@@ -2236,8 +2338,9 @@ discard block |
||
2236 | 2338 | } |
2237 | 2339 | |
2238 | 2340 | // No tags for this character, so just keep going (fastest possible course.) |
2239 | - if (!isset($bbc_codes[$tags])) |
|
2240 | - continue; |
|
2341 | + if (!isset($bbc_codes[$tags])) { |
|
2342 | + continue; |
|
2343 | + } |
|
2241 | 2344 | |
2242 | 2345 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
2243 | 2346 | $tag = null; |
@@ -2246,44 +2349,52 @@ discard block |
||
2246 | 2349 | $pt_strlen = strlen($possible['tag']); |
2247 | 2350 | |
2248 | 2351 | // Not a match? |
2249 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
2250 | - continue; |
|
2352 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
2353 | + continue; |
|
2354 | + } |
|
2251 | 2355 | |
2252 | 2356 | $next_c = $message[$pos + 1 + $pt_strlen]; |
2253 | 2357 | |
2254 | 2358 | // A test validation? |
2255 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
2256 | - continue; |
|
2359 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
2360 | + continue; |
|
2361 | + } |
|
2257 | 2362 | // Do we want parameters? |
2258 | 2363 | elseif (!empty($possible['parameters'])) |
2259 | 2364 | { |
2260 | - if ($next_c != ' ') |
|
2261 | - continue; |
|
2262 | - } |
|
2263 | - elseif (isset($possible['type'])) |
|
2365 | + if ($next_c != ' ') { |
|
2366 | + continue; |
|
2367 | + } |
|
2368 | + } elseif (isset($possible['type'])) |
|
2264 | 2369 | { |
2265 | 2370 | // Do we need an equal sign? |
2266 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
2267 | - continue; |
|
2371 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
2372 | + continue; |
|
2373 | + } |
|
2268 | 2374 | // Maybe we just want a /... |
2269 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
2270 | - continue; |
|
2375 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
2376 | + continue; |
|
2377 | + } |
|
2271 | 2378 | // An immediate ]? |
2272 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
2273 | - continue; |
|
2379 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
2380 | + continue; |
|
2381 | + } |
|
2274 | 2382 | } |
2275 | 2383 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
2276 | - elseif ($next_c != ']') |
|
2277 | - continue; |
|
2384 | + elseif ($next_c != ']') { |
|
2385 | + continue; |
|
2386 | + } |
|
2278 | 2387 | |
2279 | 2388 | // Check allowed tree? |
2280 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
2281 | - continue; |
|
2282 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
2283 | - continue; |
|
2389 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
2390 | + continue; |
|
2391 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
2392 | + continue; |
|
2393 | + } |
|
2284 | 2394 | // If this is in the list of disallowed child tags, don't parse it. |
2285 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
2286 | - continue; |
|
2395 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
2396 | + continue; |
|
2397 | + } |
|
2287 | 2398 | |
2288 | 2399 | $pos1 = $pos + 1 + $pt_strlen + 1; |
2289 | 2400 | |
@@ -2295,8 +2406,9 @@ discard block |
||
2295 | 2406 | foreach ($open_tags as $open_quote) |
2296 | 2407 | { |
2297 | 2408 | // Every parent quote this quote has flips the styling |
2298 | - if ($open_quote['tag'] == 'quote') |
|
2299 | - $quote_alt = !$quote_alt; |
|
2409 | + if ($open_quote['tag'] == 'quote') { |
|
2410 | + $quote_alt = !$quote_alt; |
|
2411 | + } |
|
2300 | 2412 | } |
2301 | 2413 | // Add a class to the quote to style alternating blockquotes |
2302 | 2414 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2307,8 +2419,9 @@ discard block |
||
2307 | 2419 | { |
2308 | 2420 | // Build a regular expression for each parameter for the current tag. |
2309 | 2421 | $preg = array(); |
2310 | - foreach ($possible['parameters'] as $p => $info) |
|
2311 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2422 | + foreach ($possible['parameters'] as $p => $info) { |
|
2423 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2424 | + } |
|
2312 | 2425 | |
2313 | 2426 | // Extract the string that potentially holds our parameters. |
2314 | 2427 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2328,24 +2441,27 @@ discard block |
||
2328 | 2441 | |
2329 | 2442 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
2330 | 2443 | |
2331 | - if ($match) |
|
2332 | - $blob_counter = count($blobs) + 1; |
|
2444 | + if ($match) { |
|
2445 | + $blob_counter = count($blobs) + 1; |
|
2446 | + } |
|
2333 | 2447 | } |
2334 | 2448 | |
2335 | 2449 | // Didn't match our parameter list, try the next possible. |
2336 | - if (!$match) |
|
2337 | - continue; |
|
2450 | + if (!$match) { |
|
2451 | + continue; |
|
2452 | + } |
|
2338 | 2453 | |
2339 | 2454 | $params = array(); |
2340 | 2455 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
2341 | 2456 | { |
2342 | 2457 | $key = strtok(ltrim($matches[$i]), '='); |
2343 | - if (isset($possible['parameters'][$key]['value'])) |
|
2344 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2345 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
2346 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2347 | - else |
|
2348 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2458 | + if (isset($possible['parameters'][$key]['value'])) { |
|
2459 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2460 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
2461 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2462 | + } else { |
|
2463 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2464 | + } |
|
2349 | 2465 | |
2350 | 2466 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
2351 | 2467 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2353,23 +2469,26 @@ discard block |
||
2353 | 2469 | |
2354 | 2470 | foreach ($possible['parameters'] as $p => $info) |
2355 | 2471 | { |
2356 | - if (!isset($params['{' . $p . '}'])) |
|
2357 | - $params['{' . $p . '}'] = ''; |
|
2472 | + if (!isset($params['{' . $p . '}'])) { |
|
2473 | + $params['{' . $p . '}'] = ''; |
|
2474 | + } |
|
2358 | 2475 | } |
2359 | 2476 | |
2360 | 2477 | $tag = $possible; |
2361 | 2478 | |
2362 | 2479 | // Put the parameters into the string. |
2363 | - if (isset($tag['before'])) |
|
2364 | - $tag['before'] = strtr($tag['before'], $params); |
|
2365 | - if (isset($tag['after'])) |
|
2366 | - $tag['after'] = strtr($tag['after'], $params); |
|
2367 | - if (isset($tag['content'])) |
|
2368 | - $tag['content'] = strtr($tag['content'], $params); |
|
2480 | + if (isset($tag['before'])) { |
|
2481 | + $tag['before'] = strtr($tag['before'], $params); |
|
2482 | + } |
|
2483 | + if (isset($tag['after'])) { |
|
2484 | + $tag['after'] = strtr($tag['after'], $params); |
|
2485 | + } |
|
2486 | + if (isset($tag['content'])) { |
|
2487 | + $tag['content'] = strtr($tag['content'], $params); |
|
2488 | + } |
|
2369 | 2489 | |
2370 | 2490 | $pos1 += strlen($given_param_string); |
2371 | - } |
|
2372 | - else |
|
2491 | + } else |
|
2373 | 2492 | { |
2374 | 2493 | $tag = $possible; |
2375 | 2494 | $params = array(); |
@@ -2380,8 +2499,9 @@ discard block |
||
2380 | 2499 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
2381 | 2500 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
2382 | 2501 | { |
2383 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
2384 | - continue; |
|
2502 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
2503 | + continue; |
|
2504 | + } |
|
2385 | 2505 | |
2386 | 2506 | $tag = $itemcodes[$message[$pos + 1]]; |
2387 | 2507 | |
@@ -2402,9 +2522,9 @@ discard block |
||
2402 | 2522 | { |
2403 | 2523 | array_pop($open_tags); |
2404 | 2524 | $code = '</li>'; |
2525 | + } else { |
|
2526 | + $code = ''; |
|
2405 | 2527 | } |
2406 | - else |
|
2407 | - $code = ''; |
|
2408 | 2528 | |
2409 | 2529 | // Now we open a new tag. |
2410 | 2530 | $open_tags[] = array( |
@@ -2451,12 +2571,14 @@ discard block |
||
2451 | 2571 | } |
2452 | 2572 | |
2453 | 2573 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
2454 | - if ($tag === null) |
|
2455 | - continue; |
|
2574 | + if ($tag === null) { |
|
2575 | + continue; |
|
2576 | + } |
|
2456 | 2577 | |
2457 | 2578 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
2458 | - if (isset($inside['disallow_children'])) |
|
2459 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2579 | + if (isset($inside['disallow_children'])) { |
|
2580 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2581 | + } |
|
2460 | 2582 | |
2461 | 2583 | // Is this tag disabled? |
2462 | 2584 | if (isset($disabled[$tag['tag']])) |
@@ -2466,14 +2588,13 @@ discard block |
||
2466 | 2588 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
2467 | 2589 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
2468 | 2590 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
2469 | - } |
|
2470 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2591 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2471 | 2592 | { |
2472 | 2593 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
2473 | 2594 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
2595 | + } else { |
|
2596 | + $tag['content'] = $tag['disabled_content']; |
|
2474 | 2597 | } |
2475 | - else |
|
2476 | - $tag['content'] = $tag['disabled_content']; |
|
2477 | 2598 | } |
2478 | 2599 | |
2479 | 2600 | // we use this a lot |
@@ -2483,8 +2604,9 @@ discard block |
||
2483 | 2604 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
2484 | 2605 | { |
2485 | 2606 | $n = count($open_tags) - 1; |
2486 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
2487 | - $n--; |
|
2607 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
2608 | + $n--; |
|
2609 | + } |
|
2488 | 2610 | |
2489 | 2611 | // Close all the non block level tags so this tag isn't surrounded by them. |
2490 | 2612 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2496,12 +2618,15 @@ discard block |
||
2496 | 2618 | |
2497 | 2619 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
2498 | 2620 | $whitespace_regex = ''; |
2499 | - if (!empty($tag['block_level'])) |
|
2500 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2501 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2502 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2503 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2504 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2621 | + if (!empty($tag['block_level'])) { |
|
2622 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2623 | + } |
|
2624 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2625 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2626 | + } |
|
2627 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2628 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2629 | + } |
|
2505 | 2630 | |
2506 | 2631 | array_pop($open_tags); |
2507 | 2632 | } |
@@ -2522,16 +2647,19 @@ discard block |
||
2522 | 2647 | elseif ($tag['type'] == 'unparsed_content') |
2523 | 2648 | { |
2524 | 2649 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
2525 | - if ($pos2 === false) |
|
2526 | - continue; |
|
2650 | + if ($pos2 === false) { |
|
2651 | + continue; |
|
2652 | + } |
|
2527 | 2653 | |
2528 | 2654 | $data = substr($message, $pos1, $pos2 - $pos1); |
2529 | 2655 | |
2530 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
2531 | - $data = substr($data, 4); |
|
2656 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
2657 | + $data = substr($data, 4); |
|
2658 | + } |
|
2532 | 2659 | |
2533 | - if (isset($tag['validate'])) |
|
2534 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2660 | + if (isset($tag['validate'])) { |
|
2661 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2662 | + } |
|
2535 | 2663 | |
2536 | 2664 | $code = strtr($tag['content'], array('$1' => $data)); |
2537 | 2665 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2547,34 +2675,40 @@ discard block |
||
2547 | 2675 | if (isset($tag['quoted'])) |
2548 | 2676 | { |
2549 | 2677 | $quoted = substr($message, $pos1, 6) == '"'; |
2550 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2551 | - continue; |
|
2678 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2679 | + continue; |
|
2680 | + } |
|
2552 | 2681 | |
2553 | - if ($quoted) |
|
2554 | - $pos1 += 6; |
|
2682 | + if ($quoted) { |
|
2683 | + $pos1 += 6; |
|
2684 | + } |
|
2685 | + } else { |
|
2686 | + $quoted = false; |
|
2555 | 2687 | } |
2556 | - else |
|
2557 | - $quoted = false; |
|
2558 | 2688 | |
2559 | 2689 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2560 | - if ($pos2 === false) |
|
2561 | - continue; |
|
2690 | + if ($pos2 === false) { |
|
2691 | + continue; |
|
2692 | + } |
|
2562 | 2693 | |
2563 | 2694 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2564 | - if ($pos3 === false) |
|
2565 | - continue; |
|
2695 | + if ($pos3 === false) { |
|
2696 | + continue; |
|
2697 | + } |
|
2566 | 2698 | |
2567 | 2699 | $data = array( |
2568 | 2700 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
2569 | 2701 | substr($message, $pos1, $pos2 - $pos1) |
2570 | 2702 | ); |
2571 | 2703 | |
2572 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
2573 | - $data[0] = substr($data[0], 4); |
|
2704 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
2705 | + $data[0] = substr($data[0], 4); |
|
2706 | + } |
|
2574 | 2707 | |
2575 | 2708 | // Validation for my parking, please! |
2576 | - if (isset($tag['validate'])) |
|
2577 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2709 | + if (isset($tag['validate'])) { |
|
2710 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2711 | + } |
|
2578 | 2712 | |
2579 | 2713 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
2580 | 2714 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2591,23 +2725,27 @@ discard block |
||
2591 | 2725 | elseif ($tag['type'] == 'unparsed_commas_content') |
2592 | 2726 | { |
2593 | 2727 | $pos2 = strpos($message, ']', $pos1); |
2594 | - if ($pos2 === false) |
|
2595 | - continue; |
|
2728 | + if ($pos2 === false) { |
|
2729 | + continue; |
|
2730 | + } |
|
2596 | 2731 | |
2597 | 2732 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2598 | - if ($pos3 === false) |
|
2599 | - continue; |
|
2733 | + if ($pos3 === false) { |
|
2734 | + continue; |
|
2735 | + } |
|
2600 | 2736 | |
2601 | 2737 | // We want $1 to be the content, and the rest to be csv. |
2602 | 2738 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
2603 | 2739 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
2604 | 2740 | |
2605 | - if (isset($tag['validate'])) |
|
2606 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2741 | + if (isset($tag['validate'])) { |
|
2742 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2743 | + } |
|
2607 | 2744 | |
2608 | 2745 | $code = $tag['content']; |
2609 | - foreach ($data as $k => $d) |
|
2610 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2746 | + foreach ($data as $k => $d) { |
|
2747 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2748 | + } |
|
2611 | 2749 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
2612 | 2750 | $pos += strlen($code) - 1 + 2; |
2613 | 2751 | } |
@@ -2615,24 +2753,28 @@ discard block |
||
2615 | 2753 | elseif ($tag['type'] == 'unparsed_commas') |
2616 | 2754 | { |
2617 | 2755 | $pos2 = strpos($message, ']', $pos1); |
2618 | - if ($pos2 === false) |
|
2619 | - continue; |
|
2756 | + if ($pos2 === false) { |
|
2757 | + continue; |
|
2758 | + } |
|
2620 | 2759 | |
2621 | 2760 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
2622 | 2761 | |
2623 | - if (isset($tag['validate'])) |
|
2624 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2762 | + if (isset($tag['validate'])) { |
|
2763 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2764 | + } |
|
2625 | 2765 | |
2626 | 2766 | // Fix after, for disabled code mainly. |
2627 | - foreach ($data as $k => $d) |
|
2628 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2767 | + foreach ($data as $k => $d) { |
|
2768 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2769 | + } |
|
2629 | 2770 | |
2630 | 2771 | $open_tags[] = $tag; |
2631 | 2772 | |
2632 | 2773 | // Replace them out, $1, $2, $3, $4, etc. |
2633 | 2774 | $code = $tag['before']; |
2634 | - foreach ($data as $k => $d) |
|
2635 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2775 | + foreach ($data as $k => $d) { |
|
2776 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2777 | + } |
|
2636 | 2778 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
2637 | 2779 | $pos += strlen($code) - 1 + 2; |
2638 | 2780 | } |
@@ -2643,28 +2785,33 @@ discard block |
||
2643 | 2785 | if (isset($tag['quoted'])) |
2644 | 2786 | { |
2645 | 2787 | $quoted = substr($message, $pos1, 6) == '"'; |
2646 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2647 | - continue; |
|
2788 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2789 | + continue; |
|
2790 | + } |
|
2648 | 2791 | |
2649 | - if ($quoted) |
|
2650 | - $pos1 += 6; |
|
2792 | + if ($quoted) { |
|
2793 | + $pos1 += 6; |
|
2794 | + } |
|
2795 | + } else { |
|
2796 | + $quoted = false; |
|
2651 | 2797 | } |
2652 | - else |
|
2653 | - $quoted = false; |
|
2654 | 2798 | |
2655 | 2799 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2656 | - if ($pos2 === false) |
|
2657 | - continue; |
|
2800 | + if ($pos2 === false) { |
|
2801 | + continue; |
|
2802 | + } |
|
2658 | 2803 | |
2659 | 2804 | $data = substr($message, $pos1, $pos2 - $pos1); |
2660 | 2805 | |
2661 | 2806 | // Validation for my parking, please! |
2662 | - if (isset($tag['validate'])) |
|
2663 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2807 | + if (isset($tag['validate'])) { |
|
2808 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2809 | + } |
|
2664 | 2810 | |
2665 | 2811 | // For parsed content, we must recurse to avoid security problems. |
2666 | - if ($tag['type'] != 'unparsed_equals') |
|
2667 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2812 | + if ($tag['type'] != 'unparsed_equals') { |
|
2813 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2814 | + } |
|
2668 | 2815 | |
2669 | 2816 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
2670 | 2817 | |
@@ -2676,34 +2823,40 @@ discard block |
||
2676 | 2823 | } |
2677 | 2824 | |
2678 | 2825 | // If this is block level, eat any breaks after it. |
2679 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
2680 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2826 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
2827 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2828 | + } |
|
2681 | 2829 | |
2682 | 2830 | // Are we trimming outside this tag? |
2683 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
2684 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2831 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
2832 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2833 | + } |
|
2685 | 2834 | } |
2686 | 2835 | |
2687 | 2836 | // Close any remaining tags. |
2688 | - while ($tag = array_pop($open_tags)) |
|
2689 | - $message .= "\n" . $tag['after'] . "\n"; |
|
2837 | + while ($tag = array_pop($open_tags)) { |
|
2838 | + $message .= "\n" . $tag['after'] . "\n"; |
|
2839 | + } |
|
2690 | 2840 | |
2691 | 2841 | // Parse the smileys within the parts where it can be done safely. |
2692 | 2842 | if ($smileys === true) |
2693 | 2843 | { |
2694 | 2844 | $message_parts = explode("\n", $message); |
2695 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
2696 | - parsesmileys($message_parts[$i]); |
|
2845 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
2846 | + parsesmileys($message_parts[$i]); |
|
2847 | + } |
|
2697 | 2848 | |
2698 | 2849 | $message = implode('', $message_parts); |
2699 | 2850 | } |
2700 | 2851 | |
2701 | 2852 | // No smileys, just get rid of the markers. |
2702 | - else |
|
2703 | - $message = strtr($message, array("\n" => '')); |
|
2853 | + else { |
|
2854 | + $message = strtr($message, array("\n" => '')); |
|
2855 | + } |
|
2704 | 2856 | |
2705 | - if ($message !== '' && $message[0] === ' ') |
|
2706 | - $message = ' ' . substr($message, 1); |
|
2857 | + if ($message !== '' && $message[0] === ' ') { |
|
2858 | + $message = ' ' . substr($message, 1); |
|
2859 | + } |
|
2707 | 2860 | |
2708 | 2861 | // Cleanup whitespace. |
2709 | 2862 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2712,15 +2865,16 @@ discard block |
||
2712 | 2865 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
2713 | 2866 | |
2714 | 2867 | // Cache the output if it took some time... |
2715 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
2716 | - cache_put_data($cache_key, $message, 240); |
|
2868 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
2869 | + cache_put_data($cache_key, $message, 240); |
|
2870 | + } |
|
2717 | 2871 | |
2718 | 2872 | // If this was a force parse revert if needed. |
2719 | 2873 | if (!empty($parse_tags)) |
2720 | 2874 | { |
2721 | - if (empty($temp_bbc)) |
|
2722 | - $bbc_codes = array(); |
|
2723 | - else |
|
2875 | + if (empty($temp_bbc)) { |
|
2876 | + $bbc_codes = array(); |
|
2877 | + } else |
|
2724 | 2878 | { |
2725 | 2879 | $bbc_codes = $temp_bbc; |
2726 | 2880 | unset($temp_bbc); |
@@ -2747,8 +2901,9 @@ discard block |
||
2747 | 2901 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
2748 | 2902 | |
2749 | 2903 | // No smiley set at all?! |
2750 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
2751 | - return; |
|
2904 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
2905 | + return; |
|
2906 | + } |
|
2752 | 2907 | |
2753 | 2908 | // If smileyPregSearch hasn't been set, do it now. |
2754 | 2909 | if (empty($smileyPregSearch)) |
@@ -2759,8 +2914,7 @@ discard block |
||
2759 | 2914 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
2760 | 2915 | $smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif'); |
2761 | 2916 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
2762 | - } |
|
2763 | - else |
|
2917 | + } else |
|
2764 | 2918 | { |
2765 | 2919 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
2766 | 2920 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2784,9 +2938,9 @@ discard block |
||
2784 | 2938 | $smcFunc['db_free_result']($result); |
2785 | 2939 | |
2786 | 2940 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
2941 | + } else { |
|
2942 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2787 | 2943 | } |
2788 | - else |
|
2789 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2790 | 2944 | } |
2791 | 2945 | |
2792 | 2946 | // The non-breaking-space is a complex thing... |
@@ -2863,35 +3017,41 @@ discard block |
||
2863 | 3017 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
2864 | 3018 | |
2865 | 3019 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
2866 | - if (!empty($context['flush_mail'])) |
|
2867 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3020 | + if (!empty($context['flush_mail'])) { |
|
3021 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2868 | 3022 | AddMailQueue(true); |
3023 | + } |
|
2869 | 3024 | |
2870 | 3025 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
2871 | 3026 | |
2872 | - if ($add) |
|
2873 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3027 | + if ($add) { |
|
3028 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3029 | + } |
|
2874 | 3030 | |
2875 | 3031 | // Put the session ID in. |
2876 | - if (defined('SID') && SID != '') |
|
2877 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3032 | + if (defined('SID') && SID != '') { |
|
3033 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3034 | + } |
|
2878 | 3035 | // Keep that debug in their for template debugging! |
2879 | - elseif (isset($_GET['debug'])) |
|
2880 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3036 | + elseif (isset($_GET['debug'])) { |
|
3037 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3038 | + } |
|
2881 | 3039 | |
2882 | 3040 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
2883 | 3041 | { |
2884 | - if (defined('SID') && SID != '') |
|
2885 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
3042 | + if (defined('SID') && SID != '') { |
|
3043 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
2886 | 3044 | function ($m) use ($scripturl) |
2887 | 3045 | { |
2888 | 3046 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
3047 | + } |
|
2889 | 3048 | }, $setLocation); |
2890 | - else |
|
2891 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
3049 | + else { |
|
3050 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
2892 | 3051 | function ($m) use ($scripturl) |
2893 | 3052 | { |
2894 | 3053 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
3054 | + } |
|
2895 | 3055 | }, $setLocation); |
2896 | 3056 | } |
2897 | 3057 | |
@@ -2902,8 +3062,9 @@ discard block |
||
2902 | 3062 | header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
2903 | 3063 | |
2904 | 3064 | // Debugging. |
2905 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
2906 | - $_SESSION['debug_redirect'] = $db_cache; |
|
3065 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3066 | + $_SESSION['debug_redirect'] = $db_cache; |
|
3067 | + } |
|
2907 | 3068 | |
2908 | 3069 | obExit(false); |
2909 | 3070 | } |
@@ -2922,51 +3083,60 @@ discard block |
||
2922 | 3083 | |
2923 | 3084 | // Attempt to prevent a recursive loop. |
2924 | 3085 | ++$level; |
2925 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
2926 | - exit; |
|
2927 | - if ($from_fatal_error) |
|
2928 | - $has_fatal_error = true; |
|
3086 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
3087 | + exit; |
|
3088 | + } |
|
3089 | + if ($from_fatal_error) { |
|
3090 | + $has_fatal_error = true; |
|
3091 | + } |
|
2929 | 3092 | |
2930 | 3093 | // Clear out the stat cache. |
2931 | 3094 | trackStats(); |
2932 | 3095 | |
2933 | 3096 | // If we have mail to send, send it. |
2934 | - if (!empty($context['flush_mail'])) |
|
2935 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3097 | + if (!empty($context['flush_mail'])) { |
|
3098 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2936 | 3099 | AddMailQueue(true); |
3100 | + } |
|
2937 | 3101 | |
2938 | 3102 | $do_header = $header === null ? !$header_done : $header; |
2939 | - if ($do_footer === null) |
|
2940 | - $do_footer = $do_header; |
|
3103 | + if ($do_footer === null) { |
|
3104 | + $do_footer = $do_header; |
|
3105 | + } |
|
2941 | 3106 | |
2942 | 3107 | // Has the template/header been done yet? |
2943 | 3108 | if ($do_header) |
2944 | 3109 | { |
2945 | 3110 | // Was the page title set last minute? Also update the HTML safe one. |
2946 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
2947 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3111 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
3112 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3113 | + } |
|
2948 | 3114 | |
2949 | 3115 | // Start up the session URL fixer. |
2950 | 3116 | ob_start('ob_sessrewrite'); |
2951 | 3117 | |
2952 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
2953 | - $buffers = explode(',', $settings['output_buffers']); |
|
2954 | - elseif (!empty($settings['output_buffers'])) |
|
2955 | - $buffers = $settings['output_buffers']; |
|
2956 | - else |
|
2957 | - $buffers = array(); |
|
3118 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
3119 | + $buffers = explode(',', $settings['output_buffers']); |
|
3120 | + } elseif (!empty($settings['output_buffers'])) { |
|
3121 | + $buffers = $settings['output_buffers']; |
|
3122 | + } else { |
|
3123 | + $buffers = array(); |
|
3124 | + } |
|
2958 | 3125 | |
2959 | - if (isset($modSettings['integrate_buffer'])) |
|
2960 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3126 | + if (isset($modSettings['integrate_buffer'])) { |
|
3127 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3128 | + } |
|
2961 | 3129 | |
2962 | - if (!empty($buffers)) |
|
2963 | - foreach ($buffers as $function) |
|
3130 | + if (!empty($buffers)) { |
|
3131 | + foreach ($buffers as $function) |
|
2964 | 3132 | { |
2965 | 3133 | $call = call_helper($function, true); |
3134 | + } |
|
2966 | 3135 | |
2967 | 3136 | // Is it valid? |
2968 | - if (!empty($call)) |
|
2969 | - ob_start($call); |
|
3137 | + if (!empty($call)) { |
|
3138 | + ob_start($call); |
|
3139 | + } |
|
2970 | 3140 | } |
2971 | 3141 | |
2972 | 3142 | // Display the screen in the logical order. |
@@ -2978,8 +3148,9 @@ discard block |
||
2978 | 3148 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
2979 | 3149 | |
2980 | 3150 | // Anything special to put out? |
2981 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
2982 | - echo $context['insert_after_template']; |
|
3151 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
3152 | + echo $context['insert_after_template']; |
|
3153 | + } |
|
2983 | 3154 | |
2984 | 3155 | // Just so we don't get caught in an endless loop of errors from the footer... |
2985 | 3156 | if (!$footer_done) |
@@ -2988,14 +3159,16 @@ discard block |
||
2988 | 3159 | template_footer(); |
2989 | 3160 | |
2990 | 3161 | // (since this is just debugging... it's okay that it's after </html>.) |
2991 | - if (!isset($_REQUEST['xml'])) |
|
2992 | - displayDebug(); |
|
3162 | + if (!isset($_REQUEST['xml'])) { |
|
3163 | + displayDebug(); |
|
3164 | + } |
|
2993 | 3165 | } |
2994 | 3166 | } |
2995 | 3167 | |
2996 | 3168 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
2997 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
2998 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3169 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
3170 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3171 | + } |
|
2999 | 3172 | |
3000 | 3173 | // For session check verification.... don't switch browsers... |
3001 | 3174 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -3004,9 +3177,10 @@ discard block |
||
3004 | 3177 | call_integration_hook('integrate_exit', array($do_footer)); |
3005 | 3178 | |
3006 | 3179 | // Don't exit if we're coming from index.php; that will pass through normally. |
3007 | - if (!$from_index) |
|
3008 | - exit; |
|
3009 | -} |
|
3180 | + if (!$from_index) { |
|
3181 | + exit; |
|
3182 | + } |
|
3183 | + } |
|
3010 | 3184 | |
3011 | 3185 | /** |
3012 | 3186 | * Get the size of a specified image with better error handling. |
@@ -3025,8 +3199,9 @@ discard block |
||
3025 | 3199 | $url = str_replace(' ', '%20', $url); |
3026 | 3200 | |
3027 | 3201 | // Can we pull this from the cache... please please? |
3028 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
3029 | - return $temp; |
|
3202 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
3203 | + return $temp; |
|
3204 | + } |
|
3030 | 3205 | $t = microtime(); |
3031 | 3206 | |
3032 | 3207 | // Get the host to pester... |
@@ -3036,12 +3211,10 @@ discard block |
||
3036 | 3211 | if ($url == '' || $url == 'http://' || $url == 'https://') |
3037 | 3212 | { |
3038 | 3213 | return false; |
3039 | - } |
|
3040 | - elseif (!isset($match[1])) |
|
3214 | + } elseif (!isset($match[1])) |
|
3041 | 3215 | { |
3042 | 3216 | $size = @getimagesize($url); |
3043 | - } |
|
3044 | - else |
|
3217 | + } else |
|
3045 | 3218 | { |
3046 | 3219 | // Try to connect to the server... give it half a second. |
3047 | 3220 | $temp = 0; |
@@ -3080,12 +3253,14 @@ discard block |
||
3080 | 3253 | } |
3081 | 3254 | |
3082 | 3255 | // If we didn't get it, we failed. |
3083 | - if (!isset($size)) |
|
3084 | - $size = false; |
|
3256 | + if (!isset($size)) { |
|
3257 | + $size = false; |
|
3258 | + } |
|
3085 | 3259 | |
3086 | 3260 | // If this took a long time, we may never have to do it again, but then again we might... |
3087 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
3088 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3261 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
3262 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3263 | + } |
|
3089 | 3264 | |
3090 | 3265 | // Didn't work. |
3091 | 3266 | return $size; |
@@ -3103,8 +3278,9 @@ discard block |
||
3103 | 3278 | |
3104 | 3279 | // Under SSI this function can be called more then once. That can cause some problems. |
3105 | 3280 | // So only run the function once unless we are forced to run it again. |
3106 | - if ($loaded && !$forceload) |
|
3107 | - return; |
|
3281 | + if ($loaded && !$forceload) { |
|
3282 | + return; |
|
3283 | + } |
|
3108 | 3284 | |
3109 | 3285 | $loaded = true; |
3110 | 3286 | |
@@ -3116,14 +3292,16 @@ discard block |
||
3116 | 3292 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
3117 | 3293 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
3118 | 3294 | { |
3119 | - if (trim($context['news_lines'][$i]) == '') |
|
3120 | - continue; |
|
3295 | + if (trim($context['news_lines'][$i]) == '') { |
|
3296 | + continue; |
|
3297 | + } |
|
3121 | 3298 | |
3122 | 3299 | // Clean it up for presentation ;). |
3123 | 3300 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
3124 | 3301 | } |
3125 | - if (!empty($context['news_lines'])) |
|
3126 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3302 | + if (!empty($context['news_lines'])) { |
|
3303 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3304 | + } |
|
3127 | 3305 | |
3128 | 3306 | if (!$user_info['is_guest']) |
3129 | 3307 | { |
@@ -3132,40 +3310,48 @@ discard block |
||
3132 | 3310 | $context['user']['alerts'] = &$user_info['alerts']; |
3133 | 3311 | |
3134 | 3312 | // Personal message popup... |
3135 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
3136 | - $context['user']['popup_messages'] = true; |
|
3137 | - else |
|
3138 | - $context['user']['popup_messages'] = false; |
|
3313 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
3314 | + $context['user']['popup_messages'] = true; |
|
3315 | + } else { |
|
3316 | + $context['user']['popup_messages'] = false; |
|
3317 | + } |
|
3139 | 3318 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
3140 | 3319 | |
3141 | - if (allowedTo('moderate_forum')) |
|
3142 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3320 | + if (allowedTo('moderate_forum')) { |
|
3321 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3322 | + } |
|
3143 | 3323 | |
3144 | 3324 | $context['user']['avatar'] = array(); |
3145 | 3325 | |
3146 | 3326 | // Check for gravatar first since we might be forcing them... |
3147 | 3327 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
3148 | 3328 | { |
3149 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
3150 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3151 | - else |
|
3152 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3329 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
3330 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3331 | + } else { |
|
3332 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3333 | + } |
|
3153 | 3334 | } |
3154 | 3335 | // Uploaded? |
3155 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
3156 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3336 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
3337 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3338 | + } |
|
3157 | 3339 | // Full URL? |
3158 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
3159 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3340 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
3341 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3342 | + } |
|
3160 | 3343 | // Otherwise we assume it's server stored. |
3161 | - elseif ($user_info['avatar']['url'] != '') |
|
3162 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3344 | + elseif ($user_info['avatar']['url'] != '') { |
|
3345 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3346 | + } |
|
3163 | 3347 | // No avatar at all? Fine, we have a big fat default avatar ;) |
3164 | - else |
|
3165 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3348 | + else { |
|
3349 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3350 | + } |
|
3166 | 3351 | |
3167 | - if (!empty($context['user']['avatar'])) |
|
3168 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3352 | + if (!empty($context['user']['avatar'])) { |
|
3353 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3354 | + } |
|
3169 | 3355 | |
3170 | 3356 | // Figure out how long they've been logged in. |
3171 | 3357 | $context['user']['total_time_logged_in'] = array( |
@@ -3173,8 +3359,7 @@ discard block |
||
3173 | 3359 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
3174 | 3360 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
3175 | 3361 | ); |
3176 | - } |
|
3177 | - else |
|
3362 | + } else |
|
3178 | 3363 | { |
3179 | 3364 | $context['user']['messages'] = 0; |
3180 | 3365 | $context['user']['unread_messages'] = 0; |
@@ -3182,12 +3367,14 @@ discard block |
||
3182 | 3367 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
3183 | 3368 | $context['user']['popup_messages'] = false; |
3184 | 3369 | |
3185 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
3186 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3370 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
3371 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3372 | + } |
|
3187 | 3373 | |
3188 | 3374 | // If we've upgraded recently, go easy on the passwords. |
3189 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
3190 | - $context['disable_login_hashing'] = true; |
|
3375 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
3376 | + $context['disable_login_hashing'] = true; |
|
3377 | + } |
|
3191 | 3378 | } |
3192 | 3379 | |
3193 | 3380 | // Setup the main menu items. |
@@ -3200,8 +3387,8 @@ discard block |
||
3200 | 3387 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
3201 | 3388 | |
3202 | 3389 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
3203 | - if ($context['show_pm_popup']) |
|
3204 | - addInlineJavaScript(' |
|
3390 | + if ($context['show_pm_popup']) { |
|
3391 | + addInlineJavaScript(' |
|
3205 | 3392 | jQuery(document).ready(function($) { |
3206 | 3393 | new smc_Popup({ |
3207 | 3394 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3209,15 +3396,17 @@ discard block |
||
3209 | 3396 | icon_class: \'generic_icons mail_new\' |
3210 | 3397 | }); |
3211 | 3398 | });'); |
3399 | + } |
|
3212 | 3400 | |
3213 | 3401 | // Add a generic "Are you sure?" confirmation message. |
3214 | 3402 | addInlineJavaScript(' |
3215 | 3403 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
3216 | 3404 | |
3217 | 3405 | // Now add the capping code for avatars. |
3218 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
3219 | - addInlineCss(' |
|
3406 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
3407 | + addInlineCss(' |
|
3220 | 3408 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
3409 | + } |
|
3221 | 3410 | |
3222 | 3411 | // This looks weird, but it's because BoardIndex.php references the variable. |
3223 | 3412 | $context['common_stats']['latest_member'] = array( |
@@ -3234,11 +3423,13 @@ discard block |
||
3234 | 3423 | ); |
3235 | 3424 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
3236 | 3425 | |
3237 | - if (empty($settings['theme_version'])) |
|
3238 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
3426 | + if (empty($settings['theme_version'])) { |
|
3427 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
3428 | + } |
|
3239 | 3429 | |
3240 | - if (!isset($context['page_title'])) |
|
3241 | - $context['page_title'] = ''; |
|
3430 | + if (!isset($context['page_title'])) { |
|
3431 | + $context['page_title'] = ''; |
|
3432 | + } |
|
3242 | 3433 | |
3243 | 3434 | // Set some specific vars. |
3244 | 3435 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3248,21 +3439,23 @@ discard block |
||
3248 | 3439 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
3249 | 3440 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
3250 | 3441 | |
3251 | - if (!empty($context['meta_keywords'])) |
|
3252 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3442 | + if (!empty($context['meta_keywords'])) { |
|
3443 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3444 | + } |
|
3253 | 3445 | |
3254 | - if (!empty($context['canonical_url'])) |
|
3255 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3446 | + if (!empty($context['canonical_url'])) { |
|
3447 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3448 | + } |
|
3256 | 3449 | |
3257 | - if (!empty($settings['og_image'])) |
|
3258 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3450 | + if (!empty($settings['og_image'])) { |
|
3451 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3452 | + } |
|
3259 | 3453 | |
3260 | 3454 | if (!empty($context['meta_description'])) |
3261 | 3455 | { |
3262 | 3456 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
3263 | 3457 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
3264 | - } |
|
3265 | - else |
|
3458 | + } else |
|
3266 | 3459 | { |
3267 | 3460 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
3268 | 3461 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3287,8 +3480,9 @@ discard block |
||
3287 | 3480 | $memory_needed = memoryReturnBytes($needed); |
3288 | 3481 | |
3289 | 3482 | // should we account for how much is currently being used? |
3290 | - if ($in_use) |
|
3291 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3483 | + if ($in_use) { |
|
3484 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3485 | + } |
|
3292 | 3486 | |
3293 | 3487 | // if more is needed, request it |
3294 | 3488 | if ($memory_current < $memory_needed) |
@@ -3311,8 +3505,9 @@ discard block |
||
3311 | 3505 | */ |
3312 | 3506 | function memoryReturnBytes($val) |
3313 | 3507 | { |
3314 | - if (is_integer($val)) |
|
3315 | - return $val; |
|
3508 | + if (is_integer($val)) { |
|
3509 | + return $val; |
|
3510 | + } |
|
3316 | 3511 | |
3317 | 3512 | // Separate the number from the designator |
3318 | 3513 | $val = trim($val); |
@@ -3348,10 +3543,11 @@ discard block |
||
3348 | 3543 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
3349 | 3544 | |
3350 | 3545 | // Are we debugging the template/html content? |
3351 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
3352 | - header('Content-Type: application/xhtml+xml'); |
|
3353 | - elseif (!isset($_REQUEST['xml'])) |
|
3354 | - header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3546 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
3547 | + header('Content-Type: application/xhtml+xml'); |
|
3548 | + } elseif (!isset($_REQUEST['xml'])) { |
|
3549 | + header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3550 | + } |
|
3355 | 3551 | } |
3356 | 3552 | |
3357 | 3553 | header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3360,8 +3556,9 @@ discard block |
||
3360 | 3556 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
3361 | 3557 | { |
3362 | 3558 | $position = array_search('body', $context['template_layers']); |
3363 | - if ($position === false) |
|
3364 | - $position = array_search('main', $context['template_layers']); |
|
3559 | + if ($position === false) { |
|
3560 | + $position = array_search('main', $context['template_layers']); |
|
3561 | + } |
|
3365 | 3562 | |
3366 | 3563 | if ($position !== false) |
3367 | 3564 | { |
@@ -3389,23 +3586,25 @@ discard block |
||
3389 | 3586 | |
3390 | 3587 | foreach ($securityFiles as $i => $securityFile) |
3391 | 3588 | { |
3392 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
3393 | - unset($securityFiles[$i]); |
|
3589 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
3590 | + unset($securityFiles[$i]); |
|
3591 | + } |
|
3394 | 3592 | } |
3395 | 3593 | |
3396 | 3594 | // We are already checking so many files...just few more doesn't make any difference! :P |
3397 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
3398 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3399 | - |
|
3400 | - else |
|
3401 | - $path = $modSettings['attachmentUploadDir']; |
|
3595 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
3596 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3597 | + } else { |
|
3598 | + $path = $modSettings['attachmentUploadDir']; |
|
3599 | + } |
|
3402 | 3600 | |
3403 | 3601 | secureDirectory($path, true); |
3404 | 3602 | secureDirectory($cachedir); |
3405 | 3603 | |
3406 | 3604 | // If agreement is enabled, at least the english version shall exists |
3407 | - if ($modSettings['requireAgreement']) |
|
3408 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3605 | + if ($modSettings['requireAgreement']) { |
|
3606 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3607 | + } |
|
3409 | 3608 | |
3410 | 3609 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
3411 | 3610 | { |
@@ -3420,18 +3619,21 @@ discard block |
||
3420 | 3619 | echo ' |
3421 | 3620 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
3422 | 3621 | |
3423 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
3424 | - echo ' |
|
3622 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
3623 | + echo ' |
|
3425 | 3624 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
3625 | + } |
|
3426 | 3626 | } |
3427 | 3627 | |
3428 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
3429 | - echo ' |
|
3628 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
3629 | + echo ' |
|
3430 | 3630 | <strong>', $txt['cache_writable'], '</strong><br>'; |
3631 | + } |
|
3431 | 3632 | |
3432 | - if (!empty($agreement)) |
|
3433 | - echo ' |
|
3633 | + if (!empty($agreement)) { |
|
3634 | + echo ' |
|
3434 | 3635 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
3636 | + } |
|
3435 | 3637 | |
3436 | 3638 | echo ' |
3437 | 3639 | </p> |
@@ -3446,16 +3648,18 @@ discard block |
||
3446 | 3648 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
3447 | 3649 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
3448 | 3650 | |
3449 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
3450 | - echo ' |
|
3651 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
3652 | + echo ' |
|
3451 | 3653 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
3654 | + } |
|
3452 | 3655 | |
3453 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
3454 | - echo ' |
|
3656 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
3657 | + echo ' |
|
3455 | 3658 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
3456 | - else |
|
3457 | - echo ' |
|
3659 | + } else { |
|
3660 | + echo ' |
|
3458 | 3661 | <div>', $txt['your_ban_expires_never'], '</div>'; |
3662 | + } |
|
3459 | 3663 | |
3460 | 3664 | echo ' |
3461 | 3665 | </div>'; |
@@ -3471,8 +3675,9 @@ discard block |
||
3471 | 3675 | global $forum_copyright, $software_year, $forum_version; |
3472 | 3676 | |
3473 | 3677 | // Don't display copyright for things like SSI. |
3474 | - if (!isset($forum_version) || !isset($software_year)) |
|
3475 | - return; |
|
3678 | + if (!isset($forum_version) || !isset($software_year)) { |
|
3679 | + return; |
|
3680 | + } |
|
3476 | 3681 | |
3477 | 3682 | // Put in the version... |
3478 | 3683 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3490,9 +3695,10 @@ discard block |
||
3490 | 3695 | $context['load_time'] = round(microtime(true) - $time_start, 3); |
3491 | 3696 | $context['load_queries'] = $db_count; |
3492 | 3697 | |
3493 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
3494 | - loadSubTemplate($layer . '_below', true); |
|
3495 | -} |
|
3698 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
3699 | + loadSubTemplate($layer . '_below', true); |
|
3700 | + } |
|
3701 | + } |
|
3496 | 3702 | |
3497 | 3703 | /** |
3498 | 3704 | * Output the Javascript files |
@@ -3523,8 +3729,7 @@ discard block |
||
3523 | 3729 | { |
3524 | 3730 | echo ' |
3525 | 3731 | var ', $key, ';'; |
3526 | - } |
|
3527 | - else |
|
3732 | + } else |
|
3528 | 3733 | { |
3529 | 3734 | echo ' |
3530 | 3735 | var ', $key, ' = ', $value, ';'; |
@@ -3539,26 +3744,27 @@ discard block |
||
3539 | 3744 | foreach ($context['javascript_files'] as $id => $js_file) |
3540 | 3745 | { |
3541 | 3746 | // Last minute call! allow theme authors to disable single files. |
3542 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3543 | - continue; |
|
3747 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3748 | + continue; |
|
3749 | + } |
|
3544 | 3750 | |
3545 | 3751 | // By default all files don't get minimized unless the file explicitly says so! |
3546 | 3752 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
3547 | 3753 | { |
3548 | - if ($do_deferred && !empty($js_file['options']['defer'])) |
|
3549 | - $toMinifyDefer[] = $js_file; |
|
3550 | - |
|
3551 | - elseif (!$do_deferred && empty($js_file['options']['defer'])) |
|
3552 | - $toMinify[] = $js_file; |
|
3754 | + if ($do_deferred && !empty($js_file['options']['defer'])) { |
|
3755 | + $toMinifyDefer[] = $js_file; |
|
3756 | + } elseif (!$do_deferred && empty($js_file['options']['defer'])) { |
|
3757 | + $toMinify[] = $js_file; |
|
3758 | + } |
|
3553 | 3759 | |
3554 | 3760 | // Grab a random seed. |
3555 | - if (!isset($minSeed)) |
|
3556 | - $minSeed = $js_file['options']['seed']; |
|
3557 | - } |
|
3558 | - |
|
3559 | - elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) |
|
3560 | - echo ' |
|
3761 | + if (!isset($minSeed)) { |
|
3762 | + $minSeed = $js_file['options']['seed']; |
|
3763 | + } |
|
3764 | + } elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) { |
|
3765 | + echo ' |
|
3561 | 3766 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>'; |
3767 | + } |
|
3562 | 3768 | } |
3563 | 3769 | |
3564 | 3770 | if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer))) |
@@ -3566,14 +3772,14 @@ discard block |
||
3566 | 3772 | $result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred); |
3567 | 3773 | |
3568 | 3774 | // Minify process couldn't work, print each individual files. |
3569 | - if (!empty($result) && is_array($result)) |
|
3570 | - foreach ($result as $minFailedFile) |
|
3775 | + if (!empty($result) && is_array($result)) { |
|
3776 | + foreach ($result as $minFailedFile) |
|
3571 | 3777 | echo ' |
3572 | 3778 | <script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>'; |
3573 | - |
|
3574 | - else |
|
3575 | - echo ' |
|
3779 | + } else { |
|
3780 | + echo ' |
|
3576 | 3781 | <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
3782 | + } |
|
3577 | 3783 | } |
3578 | 3784 | |
3579 | 3785 | // Inline JavaScript - Actually useful some times! |
@@ -3584,8 +3790,9 @@ discard block |
||
3584 | 3790 | echo ' |
3585 | 3791 | <script>'; |
3586 | 3792 | |
3587 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
3588 | - echo $js_code; |
|
3793 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
3794 | + echo $js_code; |
|
3795 | + } |
|
3589 | 3796 | |
3590 | 3797 | echo ' |
3591 | 3798 | </script>'; |
@@ -3596,8 +3803,9 @@ discard block |
||
3596 | 3803 | echo ' |
3597 | 3804 | <script>'; |
3598 | 3805 | |
3599 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
3600 | - echo $js_code; |
|
3806 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
3807 | + echo $js_code; |
|
3808 | + } |
|
3601 | 3809 | |
3602 | 3810 | echo ' |
3603 | 3811 | </script>'; |
@@ -3622,8 +3830,9 @@ discard block |
||
3622 | 3830 | foreach ($context['css_files'] as $id => $file) |
3623 | 3831 | { |
3624 | 3832 | // Last minute call! allow theme authors to disable single files. |
3625 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3626 | - continue; |
|
3833 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3834 | + continue; |
|
3835 | + } |
|
3627 | 3836 | |
3628 | 3837 | // By default all files don't get minimized unless the file explicitly says so! |
3629 | 3838 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
@@ -3631,12 +3840,12 @@ discard block |
||
3631 | 3840 | $toMinify[] = $file; |
3632 | 3841 | |
3633 | 3842 | // Grab a random seed. |
3634 | - if (!isset($minSeed)) |
|
3635 | - $minSeed = $file['options']['seed']; |
|
3843 | + if (!isset($minSeed)) { |
|
3844 | + $minSeed = $file['options']['seed']; |
|
3845 | + } |
|
3846 | + } else { |
|
3847 | + $normal[] = $file['fileUrl']; |
|
3636 | 3848 | } |
3637 | - |
|
3638 | - else |
|
3639 | - $normal[] = $file['fileUrl']; |
|
3640 | 3849 | } |
3641 | 3850 | |
3642 | 3851 | if (!empty($toMinify)) |
@@ -3644,28 +3853,30 @@ discard block |
||
3644 | 3853 | $result = custMinify($toMinify, 'css'); |
3645 | 3854 | |
3646 | 3855 | // Minify process couldn't work, print each individual files. |
3647 | - if (!empty($result) && is_array($result)) |
|
3648 | - foreach ($result as $minFailedFile) |
|
3856 | + if (!empty($result) && is_array($result)) { |
|
3857 | + foreach ($result as $minFailedFile) |
|
3649 | 3858 | echo ' |
3650 | 3859 | <link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">'; |
3651 | - |
|
3652 | - else |
|
3653 | - echo ' |
|
3860 | + } else { |
|
3861 | + echo ' |
|
3654 | 3862 | <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
3863 | + } |
|
3655 | 3864 | } |
3656 | 3865 | |
3657 | 3866 | // Print the rest after the minified files. |
3658 | - if (!empty($normal)) |
|
3659 | - foreach ($normal as $nf) |
|
3867 | + if (!empty($normal)) { |
|
3868 | + foreach ($normal as $nf) |
|
3660 | 3869 | echo ' |
3661 | 3870 | <link rel="stylesheet" href="', $nf ,'">'; |
3871 | + } |
|
3662 | 3872 | |
3663 | 3873 | if ($db_show_debug === true) |
3664 | 3874 | { |
3665 | 3875 | // Try to keep only what's useful. |
3666 | 3876 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
3667 | - foreach ($context['css_files'] as $file) |
|
3668 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3877 | + foreach ($context['css_files'] as $file) { |
|
3878 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3879 | + } |
|
3669 | 3880 | } |
3670 | 3881 | |
3671 | 3882 | if (!empty($context['css_header'])) |
@@ -3673,9 +3884,10 @@ discard block |
||
3673 | 3884 | echo ' |
3674 | 3885 | <style>'; |
3675 | 3886 | |
3676 | - foreach ($context['css_header'] as $css) |
|
3677 | - echo $css .' |
|
3887 | + foreach ($context['css_header'] as $css) { |
|
3888 | + echo $css .' |
|
3678 | 3889 | '; |
3890 | + } |
|
3679 | 3891 | |
3680 | 3892 | echo' |
3681 | 3893 | </style>'; |
@@ -3699,15 +3911,17 @@ discard block |
||
3699 | 3911 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
3700 | 3912 | $data = !empty($data) ? $data : false; |
3701 | 3913 | |
3702 | - if (empty($type) || empty($data)) |
|
3703 | - return false; |
|
3914 | + if (empty($type) || empty($data)) { |
|
3915 | + return false; |
|
3916 | + } |
|
3704 | 3917 | |
3705 | 3918 | // Did we already did this? |
3706 | 3919 | $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
3707 | 3920 | |
3708 | 3921 | // Already done? |
3709 | - if (!empty($toCache)) |
|
3710 | - return true; |
|
3922 | + if (!empty($toCache)) { |
|
3923 | + return true; |
|
3924 | + } |
|
3711 | 3925 | |
3712 | 3926 | // No namespaces, sorry! |
3713 | 3927 | $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
@@ -3789,8 +4003,9 @@ discard block |
||
3789 | 4003 | global $modSettings, $smcFunc; |
3790 | 4004 | |
3791 | 4005 | // Just make up a nice hash... |
3792 | - if ($new) |
|
3793 | - return sha1(md5($filename . time()) . mt_rand()); |
|
4006 | + if ($new) { |
|
4007 | + return sha1(md5($filename . time()) . mt_rand()); |
|
4008 | + } |
|
3794 | 4009 | |
3795 | 4010 | // Just make sure that attachment id is only a int |
3796 | 4011 | $attachment_id = (int) $attachment_id; |
@@ -3807,23 +4022,25 @@ discard block |
||
3807 | 4022 | 'id_attach' => $attachment_id, |
3808 | 4023 | )); |
3809 | 4024 | |
3810 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
3811 | - return false; |
|
4025 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
4026 | + return false; |
|
4027 | + } |
|
3812 | 4028 | |
3813 | 4029 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
3814 | 4030 | $smcFunc['db_free_result']($request); |
3815 | 4031 | } |
3816 | 4032 | |
3817 | 4033 | // Still no hash? mmm... |
3818 | - if (empty($file_hash)) |
|
3819 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4034 | + if (empty($file_hash)) { |
|
4035 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4036 | + } |
|
3820 | 4037 | |
3821 | 4038 | // Are we using multiple directories? |
3822 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
3823 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
3824 | - |
|
3825 | - else |
|
3826 | - $path = $modSettings['attachmentUploadDir']; |
|
4039 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
4040 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
4041 | + } else { |
|
4042 | + $path = $modSettings['attachmentUploadDir']; |
|
4043 | + } |
|
3827 | 4044 | |
3828 | 4045 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
3829 | 4046 | } |
@@ -3838,8 +4055,9 @@ discard block |
||
3838 | 4055 | function ip2range($fullip) |
3839 | 4056 | { |
3840 | 4057 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
3841 | - if ($fullip == 'unknown') |
|
3842 | - $fullip = '255.255.255.255'; |
|
4058 | + if ($fullip == 'unknown') { |
|
4059 | + $fullip = '255.255.255.255'; |
|
4060 | + } |
|
3843 | 4061 | |
3844 | 4062 | $ip_parts = explode('-', $fullip); |
3845 | 4063 | $ip_array = array(); |
@@ -3863,10 +4081,11 @@ discard block |
||
3863 | 4081 | $ip_array['low'] = $ip_parts[0]; |
3864 | 4082 | $ip_array['high'] = $ip_parts[1]; |
3865 | 4083 | return $ip_array; |
3866 | - } |
|
3867 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
4084 | + } elseif (count($ip_parts) == 2) { |
|
4085 | + // if ip 22.22.*-22.22.* |
|
3868 | 4086 | { |
3869 | 4087 | $valid_low = isValidIP($ip_parts[0]); |
4088 | + } |
|
3870 | 4089 | $valid_high = isValidIP($ip_parts[1]); |
3871 | 4090 | $count = 0; |
3872 | 4091 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -3881,7 +4100,9 @@ discard block |
||
3881 | 4100 | $ip_parts[0] .= $mode . $min; |
3882 | 4101 | $valid_low = isValidIP($ip_parts[0]); |
3883 | 4102 | $count++; |
3884 | - if ($count > 9) break; |
|
4103 | + if ($count > 9) { |
|
4104 | + break; |
|
4105 | + } |
|
3885 | 4106 | } |
3886 | 4107 | } |
3887 | 4108 | |
@@ -3895,7 +4116,9 @@ discard block |
||
3895 | 4116 | $ip_parts[1] .= $mode . $max; |
3896 | 4117 | $valid_high = isValidIP($ip_parts[1]); |
3897 | 4118 | $count++; |
3898 | - if ($count > 9) break; |
|
4119 | + if ($count > 9) { |
|
4120 | + break; |
|
4121 | + } |
|
3899 | 4122 | } |
3900 | 4123 | } |
3901 | 4124 | |
@@ -3920,46 +4143,54 @@ discard block |
||
3920 | 4143 | { |
3921 | 4144 | global $modSettings; |
3922 | 4145 | |
3923 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
3924 | - return $host; |
|
4146 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
4147 | + return $host; |
|
4148 | + } |
|
3925 | 4149 | $t = microtime(); |
3926 | 4150 | |
3927 | 4151 | // Try the Linux host command, perhaps? |
3928 | 4152 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
3929 | 4153 | { |
3930 | - if (!isset($modSettings['host_to_dis'])) |
|
3931 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
3932 | - else |
|
3933 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4154 | + if (!isset($modSettings['host_to_dis'])) { |
|
4155 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
4156 | + } else { |
|
4157 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4158 | + } |
|
3934 | 4159 | |
3935 | 4160 | // Did host say it didn't find anything? |
3936 | - if (strpos($test, 'not found') !== false) |
|
3937 | - $host = ''; |
|
4161 | + if (strpos($test, 'not found') !== false) { |
|
4162 | + $host = ''; |
|
4163 | + } |
|
3938 | 4164 | // Invalid server option? |
3939 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
3940 | - updateSettings(array('host_to_dis' => 1)); |
|
4165 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
4166 | + updateSettings(array('host_to_dis' => 1)); |
|
4167 | + } |
|
3941 | 4168 | // Maybe it found something, after all? |
3942 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
3943 | - $host = $match[1]; |
|
4169 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
4170 | + $host = $match[1]; |
|
4171 | + } |
|
3944 | 4172 | } |
3945 | 4173 | |
3946 | 4174 | // This is nslookup; usually only Windows, but possibly some Unix? |
3947 | 4175 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
3948 | 4176 | { |
3949 | 4177 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
3950 | - if (strpos($test, 'Non-existent domain') !== false) |
|
3951 | - $host = ''; |
|
3952 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
3953 | - $host = $match[1]; |
|
4178 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
4179 | + $host = ''; |
|
4180 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
4181 | + $host = $match[1]; |
|
4182 | + } |
|
3954 | 4183 | } |
3955 | 4184 | |
3956 | 4185 | // This is the last try :/. |
3957 | - if (!isset($host) || $host === false) |
|
3958 | - $host = @gethostbyaddr($ip); |
|
4186 | + if (!isset($host) || $host === false) { |
|
4187 | + $host = @gethostbyaddr($ip); |
|
4188 | + } |
|
3959 | 4189 | |
3960 | 4190 | // It took a long time, so let's cache it! |
3961 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
3962 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4191 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
4192 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4193 | + } |
|
3963 | 4194 | |
3964 | 4195 | return $host; |
3965 | 4196 | } |
@@ -3995,20 +4226,21 @@ discard block |
||
3995 | 4226 | { |
3996 | 4227 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
3997 | 4228 | $total = 0; |
3998 | - for ($i = 0; $i < $max_chars; $i++) |
|
3999 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4229 | + for ($i = 0; $i < $max_chars; $i++) { |
|
4230 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4231 | + } |
|
4000 | 4232 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
4001 | 4233 | } |
4002 | 4234 | } |
4003 | 4235 | return array_unique($returned_ints); |
4004 | - } |
|
4005 | - else |
|
4236 | + } else |
|
4006 | 4237 | { |
4007 | 4238 | // Trim characters before and after and add slashes for database insertion. |
4008 | 4239 | $returned_words = array(); |
4009 | - foreach ($words as $word) |
|
4010 | - if (($word = trim($word, '-_\'')) !== '') |
|
4240 | + foreach ($words as $word) { |
|
4241 | + if (($word = trim($word, '-_\'')) !== '') |
|
4011 | 4242 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
4243 | + } |
|
4012 | 4244 | |
4013 | 4245 | // Filter out all words that occur more than once. |
4014 | 4246 | return array_unique($returned_words); |
@@ -4030,16 +4262,18 @@ discard block |
||
4030 | 4262 | global $settings, $txt; |
4031 | 4263 | |
4032 | 4264 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
4033 | - if (function_exists('template_create_button') && !$force_use) |
|
4034 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4265 | + if (function_exists('template_create_button') && !$force_use) { |
|
4266 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4267 | + } |
|
4035 | 4268 | |
4036 | - if (!$settings['use_image_buttons']) |
|
4037 | - return $txt[$alt]; |
|
4038 | - elseif (!empty($settings['use_buttons'])) |
|
4039 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4040 | - else |
|
4041 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4042 | -} |
|
4269 | + if (!$settings['use_image_buttons']) { |
|
4270 | + return $txt[$alt]; |
|
4271 | + } elseif (!empty($settings['use_buttons'])) { |
|
4272 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4273 | + } else { |
|
4274 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4275 | + } |
|
4276 | + } |
|
4043 | 4277 | |
4044 | 4278 | /** |
4045 | 4279 | * Sets up all of the top menu buttons |
@@ -4082,9 +4316,10 @@ discard block |
||
4082 | 4316 | var user_menus = new smc_PopupMenu(); |
4083 | 4317 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4084 | 4318 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
4085 | - if ($context['allow_pm']) |
|
4086 | - addInlineJavaScript(' |
|
4319 | + if ($context['allow_pm']) { |
|
4320 | + addInlineJavaScript(' |
|
4087 | 4321 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
4322 | + } |
|
4088 | 4323 | |
4089 | 4324 | if (!empty($modSettings['enable_ajax_alerts'])) |
4090 | 4325 | { |
@@ -4244,88 +4479,96 @@ discard block |
||
4244 | 4479 | |
4245 | 4480 | // Now we put the buttons in the context so the theme can use them. |
4246 | 4481 | $menu_buttons = array(); |
4247 | - foreach ($buttons as $act => $button) |
|
4248 | - if (!empty($button['show'])) |
|
4482 | + foreach ($buttons as $act => $button) { |
|
4483 | + if (!empty($button['show'])) |
|
4249 | 4484 | { |
4250 | 4485 | $button['active_button'] = false; |
4486 | + } |
|
4251 | 4487 | |
4252 | 4488 | // This button needs some action. |
4253 | - if (isset($button['action_hook'])) |
|
4254 | - $needs_action_hook = true; |
|
4489 | + if (isset($button['action_hook'])) { |
|
4490 | + $needs_action_hook = true; |
|
4491 | + } |
|
4255 | 4492 | |
4256 | 4493 | // Make sure the last button truly is the last button. |
4257 | 4494 | if (!empty($button['is_last'])) |
4258 | 4495 | { |
4259 | - if (isset($last_button)) |
|
4260 | - unset($menu_buttons[$last_button]['is_last']); |
|
4496 | + if (isset($last_button)) { |
|
4497 | + unset($menu_buttons[$last_button]['is_last']); |
|
4498 | + } |
|
4261 | 4499 | $last_button = $act; |
4262 | 4500 | } |
4263 | 4501 | |
4264 | 4502 | // Go through the sub buttons if there are any. |
4265 | - if (!empty($button['sub_buttons'])) |
|
4266 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4503 | + if (!empty($button['sub_buttons'])) { |
|
4504 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4267 | 4505 | { |
4268 | 4506 | if (empty($subbutton['show'])) |
4269 | 4507 | unset($button['sub_buttons'][$key]); |
4508 | + } |
|
4270 | 4509 | |
4271 | 4510 | // 2nd level sub buttons next... |
4272 | 4511 | if (!empty($subbutton['sub_buttons'])) |
4273 | 4512 | { |
4274 | 4513 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
4275 | 4514 | { |
4276 | - if (empty($sub_button2['show'])) |
|
4277 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4515 | + if (empty($sub_button2['show'])) { |
|
4516 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4517 | + } |
|
4278 | 4518 | } |
4279 | 4519 | } |
4280 | 4520 | } |
4281 | 4521 | |
4282 | 4522 | // Does this button have its own icon? |
4283 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
4284 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4285 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
4286 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4287 | - elseif (isset($button['icon'])) |
|
4288 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4289 | - else |
|
4290 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4523 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
4524 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4525 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
4526 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4527 | + } elseif (isset($button['icon'])) { |
|
4528 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4529 | + } else { |
|
4530 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4531 | + } |
|
4291 | 4532 | |
4292 | 4533 | $menu_buttons[$act] = $button; |
4293 | 4534 | } |
4294 | 4535 | |
4295 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
4296 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4536 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
4537 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4538 | + } |
|
4297 | 4539 | } |
4298 | 4540 | |
4299 | 4541 | $context['menu_buttons'] = $menu_buttons; |
4300 | 4542 | |
4301 | 4543 | // Logging out requires the session id in the url. |
4302 | - if (isset($context['menu_buttons']['logout'])) |
|
4303 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4544 | + if (isset($context['menu_buttons']['logout'])) { |
|
4545 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4546 | + } |
|
4304 | 4547 | |
4305 | 4548 | // Figure out which action we are doing so we can set the active tab. |
4306 | 4549 | // Default to home. |
4307 | 4550 | $current_action = 'home'; |
4308 | 4551 | |
4309 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
4310 | - $current_action = $context['current_action']; |
|
4311 | - elseif ($context['current_action'] == 'search2') |
|
4312 | - $current_action = 'search'; |
|
4313 | - elseif ($context['current_action'] == 'theme') |
|
4314 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4315 | - elseif ($context['current_action'] == 'register2') |
|
4316 | - $current_action = 'register'; |
|
4317 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
4318 | - $current_action = 'login'; |
|
4319 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
4320 | - $current_action = 'moderate'; |
|
4552 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
4553 | + $current_action = $context['current_action']; |
|
4554 | + } elseif ($context['current_action'] == 'search2') { |
|
4555 | + $current_action = 'search'; |
|
4556 | + } elseif ($context['current_action'] == 'theme') { |
|
4557 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4558 | + } elseif ($context['current_action'] == 'register2') { |
|
4559 | + $current_action = 'register'; |
|
4560 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
4561 | + $current_action = 'login'; |
|
4562 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
4563 | + $current_action = 'moderate'; |
|
4564 | + } |
|
4321 | 4565 | |
4322 | 4566 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
4323 | 4567 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
4324 | 4568 | { |
4325 | 4569 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
4326 | 4570 | $context[$current_action] = true; |
4327 | - } |
|
4328 | - elseif ($context['current_action'] == 'pm') |
|
4571 | + } elseif ($context['current_action'] == 'pm') |
|
4329 | 4572 | { |
4330 | 4573 | $current_action = 'self_pm'; |
4331 | 4574 | $context['self_pm'] = true; |
@@ -4366,12 +4609,14 @@ discard block |
||
4366 | 4609 | } |
4367 | 4610 | |
4368 | 4611 | // Not all actions are simple. |
4369 | - if (!empty($needs_action_hook)) |
|
4370 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4612 | + if (!empty($needs_action_hook)) { |
|
4613 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4614 | + } |
|
4371 | 4615 | |
4372 | - if (isset($context['menu_buttons'][$current_action])) |
|
4373 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4374 | -} |
|
4616 | + if (isset($context['menu_buttons'][$current_action])) { |
|
4617 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4618 | + } |
|
4619 | + } |
|
4375 | 4620 | |
4376 | 4621 | /** |
4377 | 4622 | * Generate a random seed and ensure it's stored in settings. |
@@ -4395,30 +4640,35 @@ discard block |
||
4395 | 4640 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
4396 | 4641 | global $context, $txt; |
4397 | 4642 | |
4398 | - if ($db_show_debug === true) |
|
4399 | - $context['debug']['hooks'][] = $hook; |
|
4643 | + if ($db_show_debug === true) { |
|
4644 | + $context['debug']['hooks'][] = $hook; |
|
4645 | + } |
|
4400 | 4646 | |
4401 | 4647 | // Need to have some control. |
4402 | - if (!isset($context['instances'])) |
|
4403 | - $context['instances'] = array(); |
|
4648 | + if (!isset($context['instances'])) { |
|
4649 | + $context['instances'] = array(); |
|
4650 | + } |
|
4404 | 4651 | |
4405 | 4652 | $results = array(); |
4406 | - if (empty($modSettings[$hook])) |
|
4407 | - return $results; |
|
4653 | + if (empty($modSettings[$hook])) { |
|
4654 | + return $results; |
|
4655 | + } |
|
4408 | 4656 | |
4409 | 4657 | $functions = explode(',', $modSettings[$hook]); |
4410 | 4658 | // Loop through each function. |
4411 | 4659 | foreach ($functions as $function) |
4412 | 4660 | { |
4413 | 4661 | // Hook has been marked as "disabled". Skip it! |
4414 | - if (strpos($function, '!') !== false) |
|
4415 | - continue; |
|
4662 | + if (strpos($function, '!') !== false) { |
|
4663 | + continue; |
|
4664 | + } |
|
4416 | 4665 | |
4417 | 4666 | $call = call_helper($function, true); |
4418 | 4667 | |
4419 | 4668 | // Is it valid? |
4420 | - if (!empty($call)) |
|
4421 | - $results[$function] = call_user_func_array($call, $parameters); |
|
4669 | + if (!empty($call)) { |
|
4670 | + $results[$function] = call_user_func_array($call, $parameters); |
|
4671 | + } |
|
4422 | 4672 | |
4423 | 4673 | // Whatever it was suppose to call, it failed :( |
4424 | 4674 | elseif (!empty($function)) |
@@ -4434,8 +4684,9 @@ discard block |
||
4434 | 4684 | } |
4435 | 4685 | |
4436 | 4686 | // "Assume" the file resides on $boarddir somewhere... |
4437 | - else |
|
4438 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4687 | + else { |
|
4688 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4689 | + } |
|
4439 | 4690 | } |
4440 | 4691 | } |
4441 | 4692 | |
@@ -4457,12 +4708,14 @@ discard block |
||
4457 | 4708 | global $smcFunc, $modSettings; |
4458 | 4709 | |
4459 | 4710 | // Any objects? |
4460 | - if ($object) |
|
4461 | - $function = $function . '#'; |
|
4711 | + if ($object) { |
|
4712 | + $function = $function . '#'; |
|
4713 | + } |
|
4462 | 4714 | |
4463 | 4715 | // Any files to load? |
4464 | - if (!empty($file) && is_string($file)) |
|
4465 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4716 | + if (!empty($file) && is_string($file)) { |
|
4717 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4718 | + } |
|
4466 | 4719 | |
4467 | 4720 | // Get the correct string. |
4468 | 4721 | $integration_call = $function; |
@@ -4484,13 +4737,14 @@ discard block |
||
4484 | 4737 | if (!empty($current_functions)) |
4485 | 4738 | { |
4486 | 4739 | $current_functions = explode(',', $current_functions); |
4487 | - if (in_array($integration_call, $current_functions)) |
|
4488 | - return; |
|
4740 | + if (in_array($integration_call, $current_functions)) { |
|
4741 | + return; |
|
4742 | + } |
|
4489 | 4743 | |
4490 | 4744 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
4745 | + } else { |
|
4746 | + $permanent_functions = array($integration_call); |
|
4491 | 4747 | } |
4492 | - else |
|
4493 | - $permanent_functions = array($integration_call); |
|
4494 | 4748 | |
4495 | 4749 | updateSettings(array($hook => implode(',', $permanent_functions))); |
4496 | 4750 | } |
@@ -4499,8 +4753,9 @@ discard block |
||
4499 | 4753 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4500 | 4754 | |
4501 | 4755 | // Do nothing, if it's already there. |
4502 | - if (in_array($integration_call, $functions)) |
|
4503 | - return; |
|
4756 | + if (in_array($integration_call, $functions)) { |
|
4757 | + return; |
|
4758 | + } |
|
4504 | 4759 | |
4505 | 4760 | $functions[] = $integration_call; |
4506 | 4761 | $modSettings[$hook] = implode(',', $functions); |
@@ -4523,12 +4778,14 @@ discard block |
||
4523 | 4778 | global $smcFunc, $modSettings; |
4524 | 4779 | |
4525 | 4780 | // Any objects? |
4526 | - if ($object) |
|
4527 | - $function = $function . '#'; |
|
4781 | + if ($object) { |
|
4782 | + $function = $function . '#'; |
|
4783 | + } |
|
4528 | 4784 | |
4529 | 4785 | // Any files to load? |
4530 | - if (!empty($file) && is_string($file)) |
|
4531 | - $function = $file . '|' . $function; |
|
4786 | + if (!empty($file) && is_string($file)) { |
|
4787 | + $function = $file . '|' . $function; |
|
4788 | + } |
|
4532 | 4789 | |
4533 | 4790 | // Get the correct string. |
4534 | 4791 | $integration_call = $function; |
@@ -4549,16 +4806,18 @@ discard block |
||
4549 | 4806 | { |
4550 | 4807 | $current_functions = explode(',', $current_functions); |
4551 | 4808 | |
4552 | - if (in_array($integration_call, $current_functions)) |
|
4553 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4809 | + if (in_array($integration_call, $current_functions)) { |
|
4810 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4811 | + } |
|
4554 | 4812 | } |
4555 | 4813 | |
4556 | 4814 | // Turn the function list into something usable. |
4557 | 4815 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4558 | 4816 | |
4559 | 4817 | // You can only remove it if it's available. |
4560 | - if (!in_array($integration_call, $functions)) |
|
4561 | - return; |
|
4818 | + if (!in_array($integration_call, $functions)) { |
|
4819 | + return; |
|
4820 | + } |
|
4562 | 4821 | |
4563 | 4822 | $functions = array_diff($functions, array($integration_call)); |
4564 | 4823 | $modSettings[$hook] = implode(',', $functions); |
@@ -4579,17 +4838,20 @@ discard block |
||
4579 | 4838 | global $context, $smcFunc, $txt, $db_show_debug; |
4580 | 4839 | |
4581 | 4840 | // Really? |
4582 | - if (empty($string)) |
|
4583 | - return false; |
|
4841 | + if (empty($string)) { |
|
4842 | + return false; |
|
4843 | + } |
|
4584 | 4844 | |
4585 | 4845 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
4586 | 4846 | // A closure? should be a callable one. |
4587 | - if (is_array($string) || $string instanceof Closure) |
|
4588 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4847 | + if (is_array($string) || $string instanceof Closure) { |
|
4848 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4849 | + } |
|
4589 | 4850 | |
4590 | 4851 | // No full objects, sorry! pass a method or a property instead! |
4591 | - if (is_object($string)) |
|
4592 | - return false; |
|
4852 | + if (is_object($string)) { |
|
4853 | + return false; |
|
4854 | + } |
|
4593 | 4855 | |
4594 | 4856 | // Stay vitaminized my friends... |
4595 | 4857 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4598,8 +4860,9 @@ discard block |
||
4598 | 4860 | $string = load_file($string); |
4599 | 4861 | |
4600 | 4862 | // Loaded file failed |
4601 | - if (empty($string)) |
|
4602 | - return false; |
|
4863 | + if (empty($string)) { |
|
4864 | + return false; |
|
4865 | + } |
|
4603 | 4866 | |
4604 | 4867 | // Found a method. |
4605 | 4868 | if (strpos($string, '::') !== false) |
@@ -4620,8 +4883,9 @@ discard block |
||
4620 | 4883 | // Add another one to the list. |
4621 | 4884 | if ($db_show_debug === true) |
4622 | 4885 | { |
4623 | - if (!isset($context['debug']['instances'])) |
|
4624 | - $context['debug']['instances'] = array(); |
|
4886 | + if (!isset($context['debug']['instances'])) { |
|
4887 | + $context['debug']['instances'] = array(); |
|
4888 | + } |
|
4625 | 4889 | |
4626 | 4890 | $context['debug']['instances'][$class] = $class; |
4627 | 4891 | } |
@@ -4631,13 +4895,15 @@ discard block |
||
4631 | 4895 | } |
4632 | 4896 | |
4633 | 4897 | // Right then. This is a call to a static method. |
4634 | - else |
|
4635 | - $func = array($class, $method); |
|
4898 | + else { |
|
4899 | + $func = array($class, $method); |
|
4900 | + } |
|
4636 | 4901 | } |
4637 | 4902 | |
4638 | 4903 | // Nope! just a plain regular function. |
4639 | - else |
|
4640 | - $func = $string; |
|
4904 | + else { |
|
4905 | + $func = $string; |
|
4906 | + } |
|
4641 | 4907 | |
4642 | 4908 | // Right, we got what we need, time to do some checks. |
4643 | 4909 | if (!is_callable($func, false, $callable_name)) |
@@ -4653,17 +4919,18 @@ discard block |
||
4653 | 4919 | else |
4654 | 4920 | { |
4655 | 4921 | // What are we gonna do about it? |
4656 | - if ($return) |
|
4657 | - return $func; |
|
4922 | + if ($return) { |
|
4923 | + return $func; |
|
4924 | + } |
|
4658 | 4925 | |
4659 | 4926 | // If this is a plain function, avoid the heat of calling call_user_func(). |
4660 | 4927 | else |
4661 | 4928 | { |
4662 | - if (is_array($func)) |
|
4663 | - call_user_func($func); |
|
4664 | - |
|
4665 | - else |
|
4666 | - $func(); |
|
4929 | + if (is_array($func)) { |
|
4930 | + call_user_func($func); |
|
4931 | + } else { |
|
4932 | + $func(); |
|
4933 | + } |
|
4667 | 4934 | } |
4668 | 4935 | } |
4669 | 4936 | } |
@@ -4680,31 +4947,34 @@ discard block |
||
4680 | 4947 | { |
4681 | 4948 | global $sourcedir, $txt, $boarddir, $settings; |
4682 | 4949 | |
4683 | - if (empty($string)) |
|
4684 | - return false; |
|
4950 | + if (empty($string)) { |
|
4951 | + return false; |
|
4952 | + } |
|
4685 | 4953 | |
4686 | 4954 | if (strpos($string, '|') !== false) |
4687 | 4955 | { |
4688 | 4956 | list ($file, $string) = explode('|', $string); |
4689 | 4957 | |
4690 | 4958 | // Match the wildcards to their regular vars. |
4691 | - if (empty($settings['theme_dir'])) |
|
4692 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4693 | - |
|
4694 | - else |
|
4695 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4959 | + if (empty($settings['theme_dir'])) { |
|
4960 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4961 | + } else { |
|
4962 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4963 | + } |
|
4696 | 4964 | |
4697 | 4965 | // Load the file if it can be loaded. |
4698 | - if (file_exists($absPath)) |
|
4699 | - require_once($absPath); |
|
4966 | + if (file_exists($absPath)) { |
|
4967 | + require_once($absPath); |
|
4968 | + } |
|
4700 | 4969 | |
4701 | 4970 | // No? try a fallback to $sourcedir |
4702 | 4971 | else |
4703 | 4972 | { |
4704 | 4973 | $absPath = $sourcedir .'/'. $file; |
4705 | 4974 | |
4706 | - if (file_exists($absPath)) |
|
4707 | - require_once($absPath); |
|
4975 | + if (file_exists($absPath)) { |
|
4976 | + require_once($absPath); |
|
4977 | + } |
|
4708 | 4978 | |
4709 | 4979 | // Sorry, can't do much for you at this point. |
4710 | 4980 | else |
@@ -4731,8 +5001,9 @@ discard block |
||
4731 | 5001 | global $user_info, $smcFunc; |
4732 | 5002 | |
4733 | 5003 | // Make sure we have something to work with. |
4734 | - if (empty($topic)) |
|
4735 | - return array(); |
|
5004 | + if (empty($topic)) { |
|
5005 | + return array(); |
|
5006 | + } |
|
4736 | 5007 | |
4737 | 5008 | |
4738 | 5009 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -4755,8 +5026,9 @@ discard block |
||
4755 | 5026 | 'topic' => $topic, |
4756 | 5027 | ) |
4757 | 5028 | ); |
4758 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
4759 | - $temp[] = (int) $row['content_id']; |
|
5029 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
5030 | + $temp[] = (int) $row['content_id']; |
|
5031 | + } |
|
4760 | 5032 | |
4761 | 5033 | cache_put_data($cache_key, $temp, $ttl); |
4762 | 5034 | } |
@@ -4777,8 +5049,9 @@ discard block |
||
4777 | 5049 | { |
4778 | 5050 | global $context; |
4779 | 5051 | |
4780 | - if (empty($string)) |
|
4781 | - return $string; |
|
5052 | + if (empty($string)) { |
|
5053 | + return $string; |
|
5054 | + } |
|
4782 | 5055 | |
4783 | 5056 | // UTF-8 occurences of MS special characters |
4784 | 5057 | $findchars_utf8 = array( |
@@ -4819,10 +5092,11 @@ discard block |
||
4819 | 5092 | '--', // — |
4820 | 5093 | ); |
4821 | 5094 | |
4822 | - if ($context['utf8']) |
|
4823 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
4824 | - else |
|
4825 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
5095 | + if ($context['utf8']) { |
|
5096 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
5097 | + } else { |
|
5098 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
5099 | + } |
|
4826 | 5100 | |
4827 | 5101 | return $string; |
4828 | 5102 | } |
@@ -4841,49 +5115,59 @@ discard block |
||
4841 | 5115 | { |
4842 | 5116 | global $context; |
4843 | 5117 | |
4844 | - if (!isset($matches[2])) |
|
4845 | - return ''; |
|
5118 | + if (!isset($matches[2])) { |
|
5119 | + return ''; |
|
5120 | + } |
|
4846 | 5121 | |
4847 | 5122 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4848 | 5123 | |
4849 | 5124 | // remove left to right / right to left overrides |
4850 | - if ($num === 0x202D || $num === 0x202E) |
|
4851 | - return ''; |
|
5125 | + if ($num === 0x202D || $num === 0x202E) { |
|
5126 | + return ''; |
|
5127 | + } |
|
4852 | 5128 | |
4853 | 5129 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
4854 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
4855 | - return '&#' . $num . ';'; |
|
5130 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
5131 | + return '&#' . $num . ';'; |
|
5132 | + } |
|
4856 | 5133 | |
4857 | 5134 | if (empty($context['utf8'])) |
4858 | 5135 | { |
4859 | 5136 | // no control characters |
4860 | - if ($num < 0x20) |
|
4861 | - return ''; |
|
5137 | + if ($num < 0x20) { |
|
5138 | + return ''; |
|
5139 | + } |
|
4862 | 5140 | // text is text |
4863 | - elseif ($num < 0x80) |
|
4864 | - return chr($num); |
|
5141 | + elseif ($num < 0x80) { |
|
5142 | + return chr($num); |
|
5143 | + } |
|
4865 | 5144 | // all others get html-ised |
4866 | - else |
|
4867 | - return '&#' . $matches[2] . ';'; |
|
4868 | - } |
|
4869 | - else |
|
5145 | + else { |
|
5146 | + return '&#' . $matches[2] . ';'; |
|
5147 | + } |
|
5148 | + } else |
|
4870 | 5149 | { |
4871 | 5150 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
4872 | 5151 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
4873 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
4874 | - return ''; |
|
5152 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
5153 | + return ''; |
|
5154 | + } |
|
4875 | 5155 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4876 | - elseif ($num < 0x80) |
|
4877 | - return chr($num); |
|
5156 | + elseif ($num < 0x80) { |
|
5157 | + return chr($num); |
|
5158 | + } |
|
4878 | 5159 | // <0x800 (2048) |
4879 | - elseif ($num < 0x800) |
|
4880 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5160 | + elseif ($num < 0x800) { |
|
5161 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5162 | + } |
|
4881 | 5163 | // < 0x10000 (65536) |
4882 | - elseif ($num < 0x10000) |
|
4883 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5164 | + elseif ($num < 0x10000) { |
|
5165 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5166 | + } |
|
4884 | 5167 | // <= 0x10FFFF (1114111) |
4885 | - else |
|
4886 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5168 | + else { |
|
5169 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5170 | + } |
|
4887 | 5171 | } |
4888 | 5172 | } |
4889 | 5173 | |
@@ -4899,28 +5183,34 @@ discard block |
||
4899 | 5183 | */ |
4900 | 5184 | function fixchar__callback($matches) |
4901 | 5185 | { |
4902 | - if (!isset($matches[1])) |
|
4903 | - return ''; |
|
5186 | + if (!isset($matches[1])) { |
|
5187 | + return ''; |
|
5188 | + } |
|
4904 | 5189 | |
4905 | 5190 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
4906 | 5191 | |
4907 | 5192 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
4908 | 5193 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
4909 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
4910 | - return ''; |
|
5194 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
5195 | + return ''; |
|
5196 | + } |
|
4911 | 5197 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4912 | - elseif ($num < 0x80) |
|
4913 | - return chr($num); |
|
5198 | + elseif ($num < 0x80) { |
|
5199 | + return chr($num); |
|
5200 | + } |
|
4914 | 5201 | // <0x800 (2048) |
4915 | - elseif ($num < 0x800) |
|
4916 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5202 | + elseif ($num < 0x800) { |
|
5203 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5204 | + } |
|
4917 | 5205 | // < 0x10000 (65536) |
4918 | - elseif ($num < 0x10000) |
|
4919 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5206 | + elseif ($num < 0x10000) { |
|
5207 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5208 | + } |
|
4920 | 5209 | // <= 0x10FFFF (1114111) |
4921 | - else |
|
4922 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
4923 | -} |
|
5210 | + else { |
|
5211 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5212 | + } |
|
5213 | + } |
|
4924 | 5214 | |
4925 | 5215 | /** |
4926 | 5216 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -4933,17 +5223,19 @@ discard block |
||
4933 | 5223 | */ |
4934 | 5224 | function entity_fix__callback($matches) |
4935 | 5225 | { |
4936 | - if (!isset($matches[2])) |
|
4937 | - return ''; |
|
5226 | + if (!isset($matches[2])) { |
|
5227 | + return ''; |
|
5228 | + } |
|
4938 | 5229 | |
4939 | 5230 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4940 | 5231 | |
4941 | 5232 | // we don't allow control characters, characters out of range, byte markers, etc |
4942 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
4943 | - return ''; |
|
4944 | - else |
|
4945 | - return '&#' . $num . ';'; |
|
4946 | -} |
|
5233 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
5234 | + return ''; |
|
5235 | + } else { |
|
5236 | + return '&#' . $num . ';'; |
|
5237 | + } |
|
5238 | + } |
|
4947 | 5239 | |
4948 | 5240 | /** |
4949 | 5241 | * Return a Gravatar URL based on |
@@ -4967,18 +5259,23 @@ discard block |
||
4967 | 5259 | $ratings = array('G', 'PG', 'R', 'X'); |
4968 | 5260 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
4969 | 5261 | $url_params = array(); |
4970 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
4971 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
4972 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
4973 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
4974 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
4975 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
4976 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
4977 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
5262 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
5263 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
5264 | + } |
|
5265 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
5266 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
5267 | + } |
|
5268 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
5269 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
5270 | + } |
|
5271 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
5272 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
4978 | 5273 | $size_string = $modSettings['avatar_max_height_external']; |
5274 | + } |
|
4979 | 5275 | |
4980 | - if (!empty($size_string)) |
|
4981 | - $url_params[] = 's=' . $size_string; |
|
5276 | + if (!empty($size_string)) { |
|
5277 | + $url_params[] = 's=' . $size_string; |
|
5278 | + } |
|
4982 | 5279 | } |
4983 | 5280 | $http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www'; |
4984 | 5281 | |
@@ -4997,22 +5294,26 @@ discard block |
||
4997 | 5294 | static $timezones = null, $lastwhen = null; |
4998 | 5295 | |
4999 | 5296 | // No point doing this over if we already did it once |
5000 | - if (!empty($timezones) && $when == $lastwhen) |
|
5001 | - return $timezones; |
|
5002 | - else |
|
5003 | - $lastwhen = $when; |
|
5297 | + if (!empty($timezones) && $when == $lastwhen) { |
|
5298 | + return $timezones; |
|
5299 | + } else { |
|
5300 | + $lastwhen = $when; |
|
5301 | + } |
|
5004 | 5302 | |
5005 | 5303 | // Parseable datetime string? |
5006 | - if (is_int($timestamp = strtotime($when))) |
|
5007 | - $when = $timestamp; |
|
5304 | + if (is_int($timestamp = strtotime($when))) { |
|
5305 | + $when = $timestamp; |
|
5306 | + } |
|
5008 | 5307 | |
5009 | 5308 | // A Unix timestamp? |
5010 | - elseif (is_numeric($when)) |
|
5011 | - $when = intval($when); |
|
5309 | + elseif (is_numeric($when)) { |
|
5310 | + $when = intval($when); |
|
5311 | + } |
|
5012 | 5312 | |
5013 | 5313 | // Invalid value? Just get current Unix timestamp. |
5014 | - else |
|
5015 | - $when = time(); |
|
5314 | + else { |
|
5315 | + $when = time(); |
|
5316 | + } |
|
5016 | 5317 | |
5017 | 5318 | // We'll need these too |
5018 | 5319 | $date_when = date_create('@' . $when); |
@@ -5076,8 +5377,9 @@ discard block |
||
5076 | 5377 | foreach ($priority_countries as $country) |
5077 | 5378 | { |
5078 | 5379 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
5079 | - if (!empty($country_tzids)) |
|
5080 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5380 | + if (!empty($country_tzids)) { |
|
5381 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5382 | + } |
|
5081 | 5383 | } |
5082 | 5384 | |
5083 | 5385 | // Process the preferred timezones first, then the rest. |
@@ -5087,8 +5389,9 @@ discard block |
||
5087 | 5389 | foreach ($tzids as $tzid) |
5088 | 5390 | { |
5089 | 5391 | // We don't want UTC right now |
5090 | - if ($tzid == 'UTC') |
|
5091 | - continue; |
|
5392 | + if ($tzid == 'UTC') { |
|
5393 | + continue; |
|
5394 | + } |
|
5092 | 5395 | |
5093 | 5396 | $tz = timezone_open($tzid); |
5094 | 5397 | |
@@ -5109,8 +5412,9 @@ discard block |
||
5109 | 5412 | } |
5110 | 5413 | |
5111 | 5414 | // A time zone from a prioritized country? |
5112 | - if (in_array($tzid, $priority_tzids)) |
|
5113 | - $priority_zones[$tzkey] = true; |
|
5415 | + if (in_array($tzid, $priority_tzids)) { |
|
5416 | + $priority_zones[$tzkey] = true; |
|
5417 | + } |
|
5114 | 5418 | |
5115 | 5419 | // Keep track of the location and offset for this tzid |
5116 | 5420 | $tzid_parts = explode('/', $tzid); |
@@ -5129,15 +5433,17 @@ discard block |
||
5129 | 5433 | { |
5130 | 5434 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
5131 | 5435 | |
5132 | - if (!empty($timezone_descriptions[$tzvalue['tzid']])) |
|
5133 | - $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5134 | - else |
|
5135 | - $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5436 | + if (!empty($timezone_descriptions[$tzvalue['tzid']])) { |
|
5437 | + $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5438 | + } else { |
|
5439 | + $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5440 | + } |
|
5136 | 5441 | |
5137 | - if (isset($priority_zones[$tzkey])) |
|
5138 | - $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5139 | - else |
|
5140 | - $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5442 | + if (isset($priority_zones[$tzkey])) { |
|
5443 | + $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5444 | + } else { |
|
5445 | + $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5446 | + } |
|
5141 | 5447 | } |
5142 | 5448 | |
5143 | 5449 | $timezones = array_merge( |
@@ -5191,9 +5497,9 @@ discard block |
||
5191 | 5497 | 'Indian/Kerguelen' => 'TFT', |
5192 | 5498 | ); |
5193 | 5499 | |
5194 | - if (!empty($missing_tz_abbrs[$tzid])) |
|
5195 | - $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5196 | - else |
|
5500 | + if (!empty($missing_tz_abbrs[$tzid])) { |
|
5501 | + $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5502 | + } else |
|
5197 | 5503 | { |
5198 | 5504 | // Russia likes to experiment with time zones often, and names them as offsets from Moscow |
5199 | 5505 | $tz_location = timezone_location_get(timezone_open($tzid)); |
@@ -5221,8 +5527,9 @@ discard block |
||
5221 | 5527 | */ |
5222 | 5528 | function inet_ptod($ip_address) |
5223 | 5529 | { |
5224 | - if (!isValidIP($ip_address)) |
|
5225 | - return $ip_address; |
|
5530 | + if (!isValidIP($ip_address)) { |
|
5531 | + return $ip_address; |
|
5532 | + } |
|
5226 | 5533 | |
5227 | 5534 | $bin = inet_pton($ip_address); |
5228 | 5535 | return $bin; |
@@ -5234,13 +5541,15 @@ discard block |
||
5234 | 5541 | */ |
5235 | 5542 | function inet_dtop($bin) |
5236 | 5543 | { |
5237 | - if(empty($bin)) |
|
5238 | - return ''; |
|
5544 | + if(empty($bin)) { |
|
5545 | + return ''; |
|
5546 | + } |
|
5239 | 5547 | |
5240 | 5548 | global $db_type; |
5241 | 5549 | |
5242 | - if ($db_type == 'postgresql') |
|
5243 | - return $bin; |
|
5550 | + if ($db_type == 'postgresql') { |
|
5551 | + return $bin; |
|
5552 | + } |
|
5244 | 5553 | |
5245 | 5554 | $ip_address = inet_ntop($bin); |
5246 | 5555 | |
@@ -5265,26 +5574,32 @@ discard block |
||
5265 | 5574 | */ |
5266 | 5575 | function _safe_serialize($value) |
5267 | 5576 | { |
5268 | - if(is_null($value)) |
|
5269 | - return 'N;'; |
|
5577 | + if(is_null($value)) { |
|
5578 | + return 'N;'; |
|
5579 | + } |
|
5270 | 5580 | |
5271 | - if(is_bool($value)) |
|
5272 | - return 'b:'. (int) $value .';'; |
|
5581 | + if(is_bool($value)) { |
|
5582 | + return 'b:'. (int) $value .';'; |
|
5583 | + } |
|
5273 | 5584 | |
5274 | - if(is_int($value)) |
|
5275 | - return 'i:'. $value .';'; |
|
5585 | + if(is_int($value)) { |
|
5586 | + return 'i:'. $value .';'; |
|
5587 | + } |
|
5276 | 5588 | |
5277 | - if(is_float($value)) |
|
5278 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5589 | + if(is_float($value)) { |
|
5590 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
5591 | + } |
|
5279 | 5592 | |
5280 | - if(is_string($value)) |
|
5281 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5593 | + if(is_string($value)) { |
|
5594 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
5595 | + } |
|
5282 | 5596 | |
5283 | 5597 | if(is_array($value)) |
5284 | 5598 | { |
5285 | 5599 | $out = ''; |
5286 | - foreach($value as $k => $v) |
|
5287 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5600 | + foreach($value as $k => $v) { |
|
5601 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5602 | + } |
|
5288 | 5603 | |
5289 | 5604 | return 'a:'. count($value) .':{'. $out .'}'; |
5290 | 5605 | } |
@@ -5310,8 +5625,9 @@ discard block |
||
5310 | 5625 | |
5311 | 5626 | $out = _safe_serialize($value); |
5312 | 5627 | |
5313 | - if (isset($mbIntEnc)) |
|
5314 | - mb_internal_encoding($mbIntEnc); |
|
5628 | + if (isset($mbIntEnc)) { |
|
5629 | + mb_internal_encoding($mbIntEnc); |
|
5630 | + } |
|
5315 | 5631 | |
5316 | 5632 | return $out; |
5317 | 5633 | } |
@@ -5328,8 +5644,9 @@ discard block |
||
5328 | 5644 | function _safe_unserialize($str) |
5329 | 5645 | { |
5330 | 5646 | // Input is not a string. |
5331 | - if(empty($str) || !is_string($str)) |
|
5332 | - return false; |
|
5647 | + if(empty($str) || !is_string($str)) { |
|
5648 | + return false; |
|
5649 | + } |
|
5333 | 5650 | |
5334 | 5651 | $stack = array(); |
5335 | 5652 | $expected = array(); |
@@ -5345,43 +5662,38 @@ discard block |
||
5345 | 5662 | while($state != 1) |
5346 | 5663 | { |
5347 | 5664 | $type = isset($str[0]) ? $str[0] : ''; |
5348 | - if($type == '}') |
|
5349 | - $str = substr($str, 1); |
|
5350 | - |
|
5351 | - else if($type == 'N' && $str[1] == ';') |
|
5665 | + if($type == '}') { |
|
5666 | + $str = substr($str, 1); |
|
5667 | + } else if($type == 'N' && $str[1] == ';') |
|
5352 | 5668 | { |
5353 | 5669 | $value = null; |
5354 | 5670 | $str = substr($str, 2); |
5355 | - } |
|
5356 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5671 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5357 | 5672 | { |
5358 | 5673 | $value = $matches[1] == '1' ? true : false; |
5359 | 5674 | $str = substr($str, 4); |
5360 | - } |
|
5361 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5675 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5362 | 5676 | { |
5363 | 5677 | $value = (int)$matches[1]; |
5364 | 5678 | $str = $matches[2]; |
5365 | - } |
|
5366 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5679 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5367 | 5680 | { |
5368 | 5681 | $value = (float)$matches[1]; |
5369 | 5682 | $str = $matches[3]; |
5370 | - } |
|
5371 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5683 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5372 | 5684 | { |
5373 | 5685 | $value = substr($matches[2], 0, (int)$matches[1]); |
5374 | 5686 | $str = substr($matches[2], (int)$matches[1] + 2); |
5375 | - } |
|
5376 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5687 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5377 | 5688 | { |
5378 | 5689 | $expectedLength = (int)$matches[1]; |
5379 | 5690 | $str = $matches[2]; |
5380 | 5691 | } |
5381 | 5692 | |
5382 | 5693 | // Object or unknown/malformed type. |
5383 | - else |
|
5384 | - return false; |
|
5694 | + else { |
|
5695 | + return false; |
|
5696 | + } |
|
5385 | 5697 | |
5386 | 5698 | switch($state) |
5387 | 5699 | { |
@@ -5409,8 +5721,9 @@ discard block |
||
5409 | 5721 | if($type == '}') |
5410 | 5722 | { |
5411 | 5723 | // Array size is less than expected. |
5412 | - if(count($list) < end($expected)) |
|
5413 | - return false; |
|
5724 | + if(count($list) < end($expected)) { |
|
5725 | + return false; |
|
5726 | + } |
|
5414 | 5727 | |
5415 | 5728 | unset($list); |
5416 | 5729 | $list = &$stack[count($stack)-1]; |
@@ -5419,8 +5732,9 @@ discard block |
||
5419 | 5732 | // Go to terminal state if we're at the end of the root array. |
5420 | 5733 | array_pop($expected); |
5421 | 5734 | |
5422 | - if(count($expected) == 0) |
|
5423 | - $state = 1; |
|
5735 | + if(count($expected) == 0) { |
|
5736 | + $state = 1; |
|
5737 | + } |
|
5424 | 5738 | |
5425 | 5739 | break; |
5426 | 5740 | } |
@@ -5428,8 +5742,9 @@ discard block |
||
5428 | 5742 | if($type == 'i' || $type == 's') |
5429 | 5743 | { |
5430 | 5744 | // Array size exceeds expected length. |
5431 | - if(count($list) >= end($expected)) |
|
5432 | - return false; |
|
5745 | + if(count($list) >= end($expected)) { |
|
5746 | + return false; |
|
5747 | + } |
|
5433 | 5748 | |
5434 | 5749 | $key = $value; |
5435 | 5750 | $state = 3; |
@@ -5463,8 +5778,9 @@ discard block |
||
5463 | 5778 | } |
5464 | 5779 | |
5465 | 5780 | // Trailing data in input. |
5466 | - if(!empty($str)) |
|
5467 | - return false; |
|
5781 | + if(!empty($str)) { |
|
5782 | + return false; |
|
5783 | + } |
|
5468 | 5784 | |
5469 | 5785 | return $data; |
5470 | 5786 | } |
@@ -5487,8 +5803,9 @@ discard block |
||
5487 | 5803 | |
5488 | 5804 | $out = _safe_unserialize($str); |
5489 | 5805 | |
5490 | - if (isset($mbIntEnc)) |
|
5491 | - mb_internal_encoding($mbIntEnc); |
|
5806 | + if (isset($mbIntEnc)) { |
|
5807 | + mb_internal_encoding($mbIntEnc); |
|
5808 | + } |
|
5492 | 5809 | |
5493 | 5810 | return $out; |
5494 | 5811 | } |
@@ -5503,12 +5820,14 @@ discard block |
||
5503 | 5820 | function smf_chmod($file, $value = 0) |
5504 | 5821 | { |
5505 | 5822 | // No file? no checks! |
5506 | - if (empty($file)) |
|
5507 | - return false; |
|
5823 | + if (empty($file)) { |
|
5824 | + return false; |
|
5825 | + } |
|
5508 | 5826 | |
5509 | 5827 | // Already writable? |
5510 | - if (is_writable($file)) |
|
5511 | - return true; |
|
5828 | + if (is_writable($file)) { |
|
5829 | + return true; |
|
5830 | + } |
|
5512 | 5831 | |
5513 | 5832 | // Do we have a file or a dir? |
5514 | 5833 | $isDir = is_dir($file); |
@@ -5524,10 +5843,9 @@ discard block |
||
5524 | 5843 | { |
5525 | 5844 | $isWritable = true; |
5526 | 5845 | break; |
5846 | + } else { |
|
5847 | + @chmod($file, $val); |
|
5527 | 5848 | } |
5528 | - |
|
5529 | - else |
|
5530 | - @chmod($file, $val); |
|
5531 | 5849 | } |
5532 | 5850 | |
5533 | 5851 | return $isWritable; |
@@ -5546,8 +5864,9 @@ discard block |
||
5546 | 5864 | global $txt; |
5547 | 5865 | |
5548 | 5866 | // Come on... |
5549 | - if (empty($json) || !is_string($json)) |
|
5550 | - return array(); |
|
5867 | + if (empty($json) || !is_string($json)) { |
|
5868 | + return array(); |
|
5869 | + } |
|
5551 | 5870 | |
5552 | 5871 | $returnArray = @json_decode($json, $returnAsArray); |
5553 | 5872 | |
@@ -5585,11 +5904,11 @@ discard block |
||
5585 | 5904 | $jsonDebug = $jsonDebug[0]; |
5586 | 5905 | loadLanguage('Errors'); |
5587 | 5906 | |
5588 | - if (!empty($jsonDebug)) |
|
5589 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5590 | - |
|
5591 | - else |
|
5592 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5907 | + if (!empty($jsonDebug)) { |
|
5908 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5909 | + } else { |
|
5910 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
5911 | + } |
|
5593 | 5912 | |
5594 | 5913 | // Everyone expects an array. |
5595 | 5914 | return array(); |
@@ -5623,8 +5942,9 @@ discard block |
||
5623 | 5942 | global $db_show_debug, $modSettings; |
5624 | 5943 | |
5625 | 5944 | // Defensive programming anyone? |
5626 | - if (empty($data)) |
|
5627 | - return false; |
|
5945 | + if (empty($data)) { |
|
5946 | + return false; |
|
5947 | + } |
|
5628 | 5948 | |
5629 | 5949 | // Don't need extra stuff... |
5630 | 5950 | $db_show_debug = false; |
@@ -5632,11 +5952,11 @@ discard block |
||
5632 | 5952 | // Kill anything else. |
5633 | 5953 | ob_end_clean(); |
5634 | 5954 | |
5635 | - if (!empty($modSettings['CompressedOutput'])) |
|
5636 | - @ob_start('ob_gzhandler'); |
|
5637 | - |
|
5638 | - else |
|
5639 | - ob_start(); |
|
5955 | + if (!empty($modSettings['CompressedOutput'])) { |
|
5956 | + @ob_start('ob_gzhandler'); |
|
5957 | + } else { |
|
5958 | + ob_start(); |
|
5959 | + } |
|
5640 | 5960 | |
5641 | 5961 | // Set the header. |
5642 | 5962 | header($type); |
@@ -5668,8 +5988,9 @@ discard block |
||
5668 | 5988 | static $done = false; |
5669 | 5989 | |
5670 | 5990 | // If we don't need to do anything, don't |
5671 | - if (!$update && $done) |
|
5672 | - return; |
|
5991 | + if (!$update && $done) { |
|
5992 | + return; |
|
5993 | + } |
|
5673 | 5994 | |
5674 | 5995 | // Should we get a new copy of the official list of TLDs? |
5675 | 5996 | if ($update) |
@@ -5678,8 +5999,9 @@ discard block |
||
5678 | 5999 | $tlds = fetch_web_data('https://data.iana.org/TLD/tlds-alpha-by-domain.txt'); |
5679 | 6000 | |
5680 | 6001 | // If the Internet Assigned Numbers Authority can't be reached, the Internet is gone. We're probably running on a server hidden in a bunker deep underground to protect it from marauding bandits roaming on the surface. We don't want to waste precious electricity on pointlessly repeating background tasks, so we'll wait until the next regularly scheduled update to see if civilization has been restored. |
5681 | - if ($tlds === false) |
|
5682 | - $postapocalypticNightmare = true; |
|
6002 | + if ($tlds === false) { |
|
6003 | + $postapocalypticNightmare = true; |
|
6004 | + } |
|
5683 | 6005 | } |
5684 | 6006 | // If we aren't updating and the regex is valid, we're done |
5685 | 6007 | elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false) |
@@ -5694,10 +6016,11 @@ discard block |
||
5694 | 6016 | // Clean $tlds and convert it to an array |
5695 | 6017 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
5696 | 6018 | $line = trim($line); |
5697 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
5698 | - return false; |
|
5699 | - else |
|
5700 | - return true; |
|
6019 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
6020 | + return false; |
|
6021 | + } else { |
|
6022 | + return true; |
|
6023 | + } |
|
5701 | 6024 | }); |
5702 | 6025 | |
5703 | 6026 | // Convert Punycode to Unicode |
@@ -5751,8 +6074,9 @@ discard block |
||
5751 | 6074 | $idx += $digit * $w; |
5752 | 6075 | $t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias)); |
5753 | 6076 | |
5754 | - if ($digit < $t) |
|
5755 | - break; |
|
6077 | + if ($digit < $t) { |
|
6078 | + break; |
|
6079 | + } |
|
5756 | 6080 | |
5757 | 6081 | $w = (int) ($w * ($base - $t)); |
5758 | 6082 | } |
@@ -5761,8 +6085,9 @@ discard block |
||
5761 | 6085 | $delta = intval($is_first ? ($delta / $damp) : ($delta / 2)); |
5762 | 6086 | $delta += intval($delta / ($deco_len + 1)); |
5763 | 6087 | |
5764 | - for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) |
|
5765 | - $delta = intval($delta / ($base - $tmin)); |
|
6088 | + for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) { |
|
6089 | + $delta = intval($delta / ($base - $tmin)); |
|
6090 | + } |
|
5766 | 6091 | |
5767 | 6092 | $bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew)); |
5768 | 6093 | $is_first = false; |
@@ -5771,8 +6096,9 @@ discard block |
||
5771 | 6096 | |
5772 | 6097 | if ($deco_len > 0) |
5773 | 6098 | { |
5774 | - for ($i = $deco_len; $i > $idx; $i--) |
|
5775 | - $decoded[$i] = $decoded[($i - 1)]; |
|
6099 | + for ($i = $deco_len; $i > $idx; $i--) { |
|
6100 | + $decoded[$i] = $decoded[($i - 1)]; |
|
6101 | + } |
|
5776 | 6102 | } |
5777 | 6103 | $decoded[$idx++] = $char; |
5778 | 6104 | } |
@@ -5780,24 +6106,29 @@ discard block |
||
5780 | 6106 | foreach ($decoded as $k => $v) |
5781 | 6107 | { |
5782 | 6108 | // 7bit are transferred literally |
5783 | - if ($v < 128) |
|
5784 | - $output .= chr($v); |
|
6109 | + if ($v < 128) { |
|
6110 | + $output .= chr($v); |
|
6111 | + } |
|
5785 | 6112 | |
5786 | 6113 | // 2 bytes |
5787 | - elseif ($v < (1 << 11)) |
|
5788 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6114 | + elseif ($v < (1 << 11)) { |
|
6115 | + $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6116 | + } |
|
5789 | 6117 | |
5790 | 6118 | // 3 bytes |
5791 | - elseif ($v < (1 << 16)) |
|
5792 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6119 | + elseif ($v < (1 << 16)) { |
|
6120 | + $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6121 | + } |
|
5793 | 6122 | |
5794 | 6123 | // 4 bytes |
5795 | - elseif ($v < (1 << 21)) |
|
5796 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6124 | + elseif ($v < (1 << 21)) { |
|
6125 | + $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6126 | + } |
|
5797 | 6127 | |
5798 | 6128 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5799 | - else |
|
5800 | - $output .= $safe_char; |
|
6129 | + else { |
|
6130 | + $output .= $safe_char; |
|
6131 | + } |
|
5801 | 6132 | } |
5802 | 6133 | |
5803 | 6134 | $output_parts[] = $output; |
@@ -5890,8 +6221,7 @@ discard block |
||
5890 | 6221 | |
5891 | 6222 | $strlen = 'mb_strlen'; |
5892 | 6223 | $substr = 'mb_substr'; |
5893 | - } |
|
5894 | - else |
|
6224 | + } else |
|
5895 | 6225 | { |
5896 | 6226 | $strlen = $smcFunc['strlen']; |
5897 | 6227 | $substr = $smcFunc['substr']; |
@@ -5905,20 +6235,21 @@ discard block |
||
5905 | 6235 | |
5906 | 6236 | $first = $substr($string, 0, 1); |
5907 | 6237 | |
5908 | - if (empty($index[$first])) |
|
5909 | - $index[$first] = array(); |
|
6238 | + if (empty($index[$first])) { |
|
6239 | + $index[$first] = array(); |
|
6240 | + } |
|
5910 | 6241 | |
5911 | 6242 | if ($strlen($string) > 1) |
5912 | 6243 | { |
5913 | 6244 | // Sanity check on recursion |
5914 | - if ($depth > 99) |
|
5915 | - $index[$first][$substr($string, 1)] = ''; |
|
5916 | - |
|
5917 | - else |
|
5918 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6245 | + if ($depth > 99) { |
|
6246 | + $index[$first][$substr($string, 1)] = ''; |
|
6247 | + } else { |
|
6248 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6249 | + } |
|
6250 | + } else { |
|
6251 | + $index[$first][''] = ''; |
|
5919 | 6252 | } |
5920 | - else |
|
5921 | - $index[$first][''] = ''; |
|
5922 | 6253 | |
5923 | 6254 | $depth--; |
5924 | 6255 | return $index; |
@@ -5941,9 +6272,9 @@ discard block |
||
5941 | 6272 | $key_regex = preg_quote($key, $delim); |
5942 | 6273 | $new_key = $key; |
5943 | 6274 | |
5944 | - if (empty($value)) |
|
5945 | - $sub_regex = ''; |
|
5946 | - else |
|
6275 | + if (empty($value)) { |
|
6276 | + $sub_regex = ''; |
|
6277 | + } else |
|
5947 | 6278 | { |
5948 | 6279 | $sub_regex = $index_to_regex($value, $delim); |
5949 | 6280 | |
@@ -5951,22 +6282,22 @@ discard block |
||
5951 | 6282 | { |
5952 | 6283 | $new_key_array = explode('(?'.'>', $sub_regex); |
5953 | 6284 | $new_key .= $new_key_array[0]; |
6285 | + } else { |
|
6286 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5954 | 6287 | } |
5955 | - else |
|
5956 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5957 | 6288 | } |
5958 | 6289 | |
5959 | - if ($depth > 1) |
|
5960 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
5961 | - else |
|
6290 | + if ($depth > 1) { |
|
6291 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
6292 | + } else |
|
5962 | 6293 | { |
5963 | 6294 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
5964 | 6295 | { |
5965 | 6296 | $regex[$new_key] = $key_regex . $sub_regex; |
5966 | 6297 | unset($index[$key]); |
6298 | + } else { |
|
6299 | + break; |
|
5967 | 6300 | } |
5968 | - else |
|
5969 | - break; |
|
5970 | 6301 | } |
5971 | 6302 | } |
5972 | 6303 | |
@@ -5975,10 +6306,11 @@ discard block |
||
5975 | 6306 | $l1 = $strlen($k1); |
5976 | 6307 | $l2 = $strlen($k2); |
5977 | 6308 | |
5978 | - if ($l1 == $l2) |
|
5979 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
5980 | - else |
|
5981 | - return $l1 > $l2 ? -1 : 1; |
|
6309 | + if ($l1 == $l2) { |
|
6310 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
6311 | + } else { |
|
6312 | + return $l1 > $l2 ? -1 : 1; |
|
6313 | + } |
|
5982 | 6314 | }); |
5983 | 6315 | |
5984 | 6316 | $depth--; |
@@ -5989,21 +6321,24 @@ discard block |
||
5989 | 6321 | $index = array(); |
5990 | 6322 | $regex = ''; |
5991 | 6323 | |
5992 | - foreach ($strings as $string) |
|
5993 | - $index = $add_string_to_index($string, $index); |
|
6324 | + foreach ($strings as $string) { |
|
6325 | + $index = $add_string_to_index($string, $index); |
|
6326 | + } |
|
5994 | 6327 | |
5995 | 6328 | if ($returnArray === true) |
5996 | 6329 | { |
5997 | 6330 | $regex = array(); |
5998 | - while (!empty($index)) |
|
5999 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6331 | + while (!empty($index)) { |
|
6332 | + $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6333 | + } |
|
6334 | + } else { |
|
6335 | + $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6000 | 6336 | } |
6001 | - else |
|
6002 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6003 | 6337 | |
6004 | 6338 | // Restore PHP's internal character encoding to whatever it was originally |
6005 | - if (!empty($current_encoding)) |
|
6006 | - mb_internal_encoding($current_encoding); |
|
6339 | + if (!empty($current_encoding)) { |
|
6340 | + mb_internal_encoding($current_encoding); |
|
6341 | + } |
|
6007 | 6342 | |
6008 | 6343 | return $regex; |
6009 | 6344 | } |
@@ -6043,13 +6378,15 @@ discard block |
||
6043 | 6378 | // Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't... |
6044 | 6379 | $url = str_ireplace('https://', 'http://', $url) . '/'; |
6045 | 6380 | $headers = @get_headers($url); |
6046 | - if ($headers === false) |
|
6047 | - return false; |
|
6381 | + if ($headers === false) { |
|
6382 | + return false; |
|
6383 | + } |
|
6048 | 6384 | |
6049 | 6385 | // Now to see if it came back https... |
6050 | 6386 | // First check for a redirect status code in first row (301, 302, 307) |
6051 | - if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) |
|
6052 | - return false; |
|
6387 | + if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) { |
|
6388 | + return false; |
|
6389 | + } |
|
6053 | 6390 | |
6054 | 6391 | // Search for the location entry to confirm https |
6055 | 6392 | $result = false; |
@@ -6085,8 +6422,7 @@ discard block |
||
6085 | 6422 | $is_admin = $user_info['is_admin']; |
6086 | 6423 | $mod_cache = !empty($user_info['mod_cache']) ? $user_info['mod_cache'] : null; |
6087 | 6424 | $ignoreboards = !empty($user_info['ignoreboards']) ? $user_info['ignoreboards'] : null; |
6088 | - } |
|
6089 | - else |
|
6425 | + } else |
|
6090 | 6426 | { |
6091 | 6427 | $request = $smcFunc['db_query']('', ' |
6092 | 6428 | SELECT mem.ignore_boards, mem.id_group, mem.additional_groups, mem.id_post_group |
@@ -6100,17 +6436,19 @@ discard block |
||
6100 | 6436 | |
6101 | 6437 | $row = $smcFunc['db_fetch_assoc']($request); |
6102 | 6438 | |
6103 | - if (empty($row['additional_groups'])) |
|
6104 | - $groups = array($row['id_group'], $user_settings['id_post_group']); |
|
6105 | - else |
|
6106 | - $groups = array_merge( |
|
6439 | + if (empty($row['additional_groups'])) { |
|
6440 | + $groups = array($row['id_group'], $user_settings['id_post_group']); |
|
6441 | + } else { |
|
6442 | + $groups = array_merge( |
|
6107 | 6443 | array($row['id_group'], $user_settings['id_post_group']), |
6108 | 6444 | explode(',', $row['additional_groups']) |
6109 | 6445 | ); |
6446 | + } |
|
6110 | 6447 | |
6111 | 6448 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
6112 | - foreach ($groups as $k => $v) |
|
6113 | - $groups[$k] = (int) $v; |
|
6449 | + foreach ($groups as $k => $v) { |
|
6450 | + $groups[$k] = (int) $v; |
|
6451 | + } |
|
6114 | 6452 | |
6115 | 6453 | $is_admin = in_array(1, $groups); |
6116 | 6454 | |
@@ -6127,8 +6465,9 @@ discard block |
||
6127 | 6465 | 'current_member' => $userid, |
6128 | 6466 | ) |
6129 | 6467 | ); |
6130 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6131 | - $boards_mod[] = $row['id_board']; |
|
6468 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6469 | + $boards_mod[] = $row['id_board']; |
|
6470 | + } |
|
6132 | 6471 | $smcFunc['db_free_result']($request); |
6133 | 6472 | |
6134 | 6473 | // Can any of the groups they're in moderate any of the boards? |
@@ -6140,8 +6479,9 @@ discard block |
||
6140 | 6479 | 'groups' => $groups, |
6141 | 6480 | ) |
6142 | 6481 | ); |
6143 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6144 | - $boards_mod[] = $row['id_board']; |
|
6482 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6483 | + $boards_mod[] = $row['id_board']; |
|
6484 | + } |
|
6145 | 6485 | $smcFunc['db_free_result']($request); |
6146 | 6486 | |
6147 | 6487 | // Just in case we've got duplicates here... |
@@ -6151,21 +6491,25 @@ discard block |
||
6151 | 6491 | } |
6152 | 6492 | |
6153 | 6493 | // Just build this here, it makes it easier to change/use - administrators can see all boards. |
6154 | - if ($is_admin) |
|
6155 | - $query_part['query_see_board'] = '1=1'; |
|
6494 | + if ($is_admin) { |
|
6495 | + $query_part['query_see_board'] = '1=1'; |
|
6496 | + } |
|
6156 | 6497 | // Otherwise just the groups in $user_info['groups']. |
6157 | - else |
|
6158 | - $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6498 | + else { |
|
6499 | + $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6500 | + } |
|
6159 | 6501 | |
6160 | 6502 | // Build the list of boards they WANT to see. |
6161 | 6503 | // This will take the place of query_see_boards in certain spots, so it better include the boards they can see also |
6162 | 6504 | |
6163 | 6505 | // If they aren't ignoring any boards then they want to see all the boards they can see |
6164 | - if (empty($ignoreboards)) |
|
6165 | - $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6506 | + if (empty($ignoreboards)) { |
|
6507 | + $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6508 | + } |
|
6166 | 6509 | // Ok I guess they don't want to see all the boards |
6167 | - else |
|
6168 | - $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6510 | + else { |
|
6511 | + $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6512 | + } |
|
6169 | 6513 | |
6170 | 6514 | return $query_part; |
6171 | 6515 | } |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Load the $modSettings array. |
@@ -25,13 +26,14 @@ discard block |
||
25 | 26 | global $cache_enable, $sourcedir, $context; |
26 | 27 | |
27 | 28 | // Most database systems have not set UTF-8 as their default input charset. |
28 | - if (!empty($db_character_set)) |
|
29 | - $smcFunc['db_query']('', ' |
|
29 | + if (!empty($db_character_set)) { |
|
30 | + $smcFunc['db_query']('', ' |
|
30 | 31 | SET NAMES {string:db_character_set}', |
31 | 32 | array( |
32 | 33 | 'db_character_set' => $db_character_set, |
33 | 34 | ) |
34 | 35 | ); |
36 | + } |
|
35 | 37 | |
36 | 38 | // We need some caching support, maybe. |
37 | 39 | loadCacheAccelerator(); |
@@ -46,28 +48,36 @@ discard block |
||
46 | 48 | ) |
47 | 49 | ); |
48 | 50 | $modSettings = array(); |
49 | - if (!$request) |
|
50 | - display_db_error(); |
|
51 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
52 | - $modSettings[$row[0]] = $row[1]; |
|
51 | + if (!$request) { |
|
52 | + display_db_error(); |
|
53 | + } |
|
54 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
55 | + $modSettings[$row[0]] = $row[1]; |
|
56 | + } |
|
53 | 57 | $smcFunc['db_free_result']($request); |
54 | 58 | |
55 | 59 | // Do a few things to protect against missing settings or settings with invalid values... |
56 | - if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) |
|
57 | - $modSettings['defaultMaxTopics'] = 20; |
|
58 | - if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) |
|
59 | - $modSettings['defaultMaxMessages'] = 15; |
|
60 | - if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) |
|
61 | - $modSettings['defaultMaxMembers'] = 30; |
|
62 | - if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) |
|
63 | - $modSettings['defaultMaxListItems'] = 15; |
|
60 | + if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) { |
|
61 | + $modSettings['defaultMaxTopics'] = 20; |
|
62 | + } |
|
63 | + if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) { |
|
64 | + $modSettings['defaultMaxMessages'] = 15; |
|
65 | + } |
|
66 | + if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) { |
|
67 | + $modSettings['defaultMaxMembers'] = 30; |
|
68 | + } |
|
69 | + if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) { |
|
70 | + $modSettings['defaultMaxListItems'] = 15; |
|
71 | + } |
|
64 | 72 | |
65 | 73 | // We excpiclity do not use $smcFunc['json_decode'] here yet, as $smcFunc is not fully loaded. |
66 | - if (!is_array($modSettings['attachmentUploadDir'])) |
|
67 | - $modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true); |
|
74 | + if (!is_array($modSettings['attachmentUploadDir'])) { |
|
75 | + $modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true); |
|
76 | + } |
|
68 | 77 | |
69 | - if (!empty($cache_enable)) |
|
70 | - cache_put_data('modSettings', $modSettings, 90); |
|
78 | + if (!empty($cache_enable)) { |
|
79 | + cache_put_data('modSettings', $modSettings, 90); |
|
80 | + } |
|
71 | 81 | } |
72 | 82 | |
73 | 83 | $modSettings['cache_enable'] = $cache_enable; |
@@ -87,8 +97,9 @@ discard block |
||
87 | 97 | }; |
88 | 98 | $fix_utf8mb4 = function($string) use ($utf8, $smcFunc) |
89 | 99 | { |
90 | - if (!$utf8 || $smcFunc['db_mb4']) |
|
91 | - return $string; |
|
100 | + if (!$utf8 || $smcFunc['db_mb4']) { |
|
101 | + return $string; |
|
102 | + } |
|
92 | 103 | |
93 | 104 | $i = 0; |
94 | 105 | $len = strlen($string); |
@@ -100,18 +111,15 @@ discard block |
||
100 | 111 | { |
101 | 112 | $new_string .= $string[$i]; |
102 | 113 | $i++; |
103 | - } |
|
104 | - elseif ($ord < 224) |
|
114 | + } elseif ($ord < 224) |
|
105 | 115 | { |
106 | 116 | $new_string .= $string[$i] . $string[$i + 1]; |
107 | 117 | $i += 2; |
108 | - } |
|
109 | - elseif ($ord < 240) |
|
118 | + } elseif ($ord < 240) |
|
110 | 119 | { |
111 | 120 | $new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2]; |
112 | 121 | $i += 3; |
113 | - } |
|
114 | - elseif ($ord < 248) |
|
122 | + } elseif ($ord < 248) |
|
115 | 123 | { |
116 | 124 | // Magic happens. |
117 | 125 | $val = (ord($string[$i]) & 0x07) << 18; |
@@ -155,8 +163,7 @@ discard block |
||
155 | 163 | { |
156 | 164 | $result = array_search($needle, array_slice($haystack_arr, $offset)); |
157 | 165 | return is_int($result) ? $result + $offset : false; |
158 | - } |
|
159 | - else |
|
166 | + } else |
|
160 | 167 | { |
161 | 168 | $needle_arr = preg_split('~(&#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . ';|"|&|<|>| |.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY); |
162 | 169 | $needle_size = count($needle_arr); |
@@ -165,8 +172,9 @@ discard block |
||
165 | 172 | while ((int) $result === $result) |
166 | 173 | { |
167 | 174 | $offset += $result; |
168 | - if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) |
|
169 | - return $offset; |
|
175 | + if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) { |
|
176 | + return $offset; |
|
177 | + } |
|
170 | 178 | $result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset)); |
171 | 179 | } |
172 | 180 | return false; |
@@ -204,8 +212,9 @@ discard block |
||
204 | 212 | $string = $ent_check($string); |
205 | 213 | preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches); |
206 | 214 | $string = $matches[0]; |
207 | - while (strlen($string) > $length) |
|
208 | - $string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string); |
|
215 | + while (strlen($string) > $length) { |
|
216 | + $string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string); |
|
217 | + } |
|
209 | 218 | return $string; |
210 | 219 | }, |
211 | 220 | 'ucfirst' => $utf8 ? function($string) use (&$smcFunc) |
@@ -215,8 +224,9 @@ discard block |
||
215 | 224 | 'ucwords' => $utf8 ? function($string) use (&$smcFunc) |
216 | 225 | { |
217 | 226 | $words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE); |
218 | - for ($i = 0, $n = count($words); $i < $n; $i += 2) |
|
219 | - $words[$i] = $smcFunc['ucfirst']($words[$i]); |
|
227 | + for ($i = 0, $n = count($words); $i < $n; $i += 2) { |
|
228 | + $words[$i] = $smcFunc['ucfirst']($words[$i]); |
|
229 | + } |
|
220 | 230 | return implode('', $words); |
221 | 231 | } : 'ucwords', |
222 | 232 | 'json_decode' => 'smf_json_decode', |
@@ -224,16 +234,17 @@ discard block |
||
224 | 234 | ); |
225 | 235 | |
226 | 236 | // Setting the timezone is a requirement for some functions. |
227 | - if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) |
|
228 | - date_default_timezone_set($modSettings['default_timezone']); |
|
229 | - else |
|
237 | + if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) { |
|
238 | + date_default_timezone_set($modSettings['default_timezone']); |
|
239 | + } else |
|
230 | 240 | { |
231 | 241 | // Get PHP's default timezone, if set |
232 | 242 | $ini_tz = ini_get('date.timezone'); |
233 | - if (!empty($ini_tz)) |
|
234 | - $modSettings['default_timezone'] = $ini_tz; |
|
235 | - else |
|
236 | - $modSettings['default_timezone'] = ''; |
|
243 | + if (!empty($ini_tz)) { |
|
244 | + $modSettings['default_timezone'] = $ini_tz; |
|
245 | + } else { |
|
246 | + $modSettings['default_timezone'] = ''; |
|
247 | + } |
|
237 | 248 | |
238 | 249 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
239 | 250 | if (!in_array($modSettings['default_timezone'], timezone_identifiers_list())) |
@@ -251,22 +262,26 @@ discard block |
||
251 | 262 | if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null) |
252 | 263 | { |
253 | 264 | $modSettings['load_average'] = @file_get_contents('/proc/loadavg'); |
254 | - if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) |
|
255 | - $modSettings['load_average'] = (float) $matches[1]; |
|
256 | - elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) |
|
257 | - $modSettings['load_average'] = (float) $matches[1]; |
|
258 | - else |
|
259 | - unset($modSettings['load_average']); |
|
265 | + if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) { |
|
266 | + $modSettings['load_average'] = (float) $matches[1]; |
|
267 | + } elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) { |
|
268 | + $modSettings['load_average'] = (float) $matches[1]; |
|
269 | + } else { |
|
270 | + unset($modSettings['load_average']); |
|
271 | + } |
|
260 | 272 | |
261 | - if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) |
|
262 | - cache_put_data('loadavg', $modSettings['load_average'], 90); |
|
273 | + if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) { |
|
274 | + cache_put_data('loadavg', $modSettings['load_average'], 90); |
|
275 | + } |
|
263 | 276 | } |
264 | 277 | |
265 | - if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) |
|
266 | - call_integration_hook('integrate_load_average', array($modSettings['load_average'])); |
|
278 | + if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) { |
|
279 | + call_integration_hook('integrate_load_average', array($modSettings['load_average'])); |
|
280 | + } |
|
267 | 281 | |
268 | - if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) |
|
269 | - display_loadavg_error(); |
|
282 | + if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) { |
|
283 | + display_loadavg_error(); |
|
284 | + } |
|
270 | 285 | } |
271 | 286 | |
272 | 287 | // Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is. |
@@ -287,8 +302,9 @@ discard block |
||
287 | 302 | if (defined('SMF_INTEGRATION_SETTINGS')) |
288 | 303 | { |
289 | 304 | $integration_settings = $smcFunc['json_decode'](SMF_INTEGRATION_SETTINGS, true); |
290 | - foreach ($integration_settings as $hook => $function) |
|
291 | - add_integration_function($hook, $function, '', false); |
|
305 | + foreach ($integration_settings as $hook => $function) { |
|
306 | + add_integration_function($hook, $function, '', false); |
|
307 | + } |
|
292 | 308 | } |
293 | 309 | |
294 | 310 | // Any files to pre include? |
@@ -298,8 +314,9 @@ discard block |
||
298 | 314 | foreach ($pre_includes as $include) |
299 | 315 | { |
300 | 316 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
301 | - if (file_exists($include)) |
|
302 | - require_once($include); |
|
317 | + if (file_exists($include)) { |
|
318 | + require_once($include); |
|
319 | + } |
|
303 | 320 | } |
304 | 321 | } |
305 | 322 | |
@@ -403,27 +420,28 @@ discard block |
||
403 | 420 | break; |
404 | 421 | } |
405 | 422 | } |
423 | + } else { |
|
424 | + $id_member = 0; |
|
406 | 425 | } |
407 | - else |
|
408 | - $id_member = 0; |
|
409 | 426 | |
410 | 427 | if (empty($id_member) && isset($_COOKIE[$cookiename])) |
411 | 428 | { |
412 | 429 | $cookie_data = $smcFunc['json_decode']($_COOKIE[$cookiename], true, false); |
413 | 430 | |
414 | - if (empty($cookie_data)) |
|
415 | - $cookie_data = safe_unserialize($_COOKIE[$cookiename]); |
|
431 | + if (empty($cookie_data)) { |
|
432 | + $cookie_data = safe_unserialize($_COOKIE[$cookiename]); |
|
433 | + } |
|
416 | 434 | |
417 | 435 | list ($id_member, $password) = $cookie_data; |
418 | 436 | $id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0; |
419 | - } |
|
420 | - elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA']))) |
|
437 | + } elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA']))) |
|
421 | 438 | { |
422 | 439 | // @todo Perhaps we can do some more checking on this, such as on the first octet of the IP? |
423 | 440 | $cookie_data = $smcFunc['json_decode']($_SESSION['login_' . $cookiename]); |
424 | 441 | |
425 | - if (empty($cookie_data)) |
|
426 | - $cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
442 | + if (empty($cookie_data)) { |
|
443 | + $cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
444 | + } |
|
427 | 445 | |
428 | 446 | list ($id_member, $password, $login_span) = $cookie_data; |
429 | 447 | $id_member = !empty($id_member) && strlen($password) == 128 && $login_span > time() ? (int) $id_member : 0; |
@@ -448,30 +466,34 @@ discard block |
||
448 | 466 | $user_settings = $smcFunc['db_fetch_assoc']($request); |
449 | 467 | $smcFunc['db_free_result']($request); |
450 | 468 | |
451 | - if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) |
|
452 | - $user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret); |
|
469 | + if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) { |
|
470 | + $user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret); |
|
471 | + } |
|
453 | 472 | |
454 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
455 | - cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
473 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
474 | + cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
475 | + } |
|
456 | 476 | } |
457 | 477 | |
458 | 478 | // Did we find 'im? If not, junk it. |
459 | 479 | if (!empty($user_settings)) |
460 | 480 | { |
461 | 481 | // As much as the password should be right, we can assume the integration set things up. |
462 | - if (!empty($already_verified) && $already_verified === true) |
|
463 | - $check = true; |
|
482 | + if (!empty($already_verified) && $already_verified === true) { |
|
483 | + $check = true; |
|
484 | + } |
|
464 | 485 | // SHA-512 hash should be 128 characters long. |
465 | - elseif (strlen($password) == 128) |
|
466 | - $check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password; |
|
467 | - else |
|
468 | - $check = false; |
|
486 | + elseif (strlen($password) == 128) { |
|
487 | + $check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password; |
|
488 | + } else { |
|
489 | + $check = false; |
|
490 | + } |
|
469 | 491 | |
470 | 492 | // Wrong password or not activated - either way, you're going nowhere. |
471 | 493 | $id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0; |
494 | + } else { |
|
495 | + $id_member = 0; |
|
472 | 496 | } |
473 | - else |
|
474 | - $id_member = 0; |
|
475 | 497 | |
476 | 498 | // If we no longer have the member maybe they're being all hackey, stop brute force! |
477 | 499 | if (!$id_member) |
@@ -500,8 +522,9 @@ discard block |
||
500 | 522 | |
501 | 523 | list ($tfamember, $tfasecret) = $tfa_data; |
502 | 524 | |
503 | - if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member) |
|
504 | - $tfasecret = null; |
|
525 | + if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member) { |
|
526 | + $tfasecret = null; |
|
527 | + } |
|
505 | 528 | } |
506 | 529 | |
507 | 530 | if (empty($tfasecret) || hash_salt($user_settings['tfa_backup'], $user_settings['password_salt']) != $tfasecret) |
@@ -521,10 +544,12 @@ discard block |
||
521 | 544 | // Are we forcing 2FA? Need to check if the user groups actually require 2FA |
522 | 545 | elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret'])) |
523 | 546 | { |
524 | - if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups |
|
547 | + if ($modSettings['tfa_mode'] == 2) { |
|
548 | + //only do this if we are just forcing SOME membergroups |
|
525 | 549 | { |
526 | 550 | //Build an array of ALL user membergroups. |
527 | 551 | $full_groups = array($user_settings['id_group']); |
552 | + } |
|
528 | 553 | if (!empty($user_settings['additional_groups'])) |
529 | 554 | { |
530 | 555 | $full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups'])); |
@@ -544,15 +569,17 @@ discard block |
||
544 | 569 | ); |
545 | 570 | $row = $smcFunc['db_fetch_assoc']($request); |
546 | 571 | $smcFunc['db_free_result']($request); |
572 | + } else { |
|
573 | + $row['total'] = 1; |
|
547 | 574 | } |
548 | - else |
|
549 | - $row['total'] = 1; //simplifies logics in the next "if" |
|
575 | + //simplifies logics in the next "if" |
|
550 | 576 | |
551 | 577 | $area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : ''; |
552 | 578 | $action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : ''; |
553 | 579 | |
554 | - if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) |
|
555 | - redirectexit('action=profile;area=tfasetup;forced'); |
|
580 | + if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) { |
|
581 | + redirectexit('action=profile;area=tfasetup;forced'); |
|
582 | + } |
|
556 | 583 | } |
557 | 584 | } |
558 | 585 | |
@@ -589,33 +616,37 @@ discard block |
||
589 | 616 | updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP'])); |
590 | 617 | $user_settings['last_login'] = time(); |
591 | 618 | |
592 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
593 | - cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
619 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
620 | + cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
621 | + } |
|
594 | 622 | |
595 | - if (!empty($modSettings['cache_enable'])) |
|
596 | - cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600); |
|
623 | + if (!empty($modSettings['cache_enable'])) { |
|
624 | + cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600); |
|
625 | + } |
|
597 | 626 | } |
627 | + } elseif (empty($_SESSION['id_msg_last_visit'])) { |
|
628 | + $_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit']; |
|
598 | 629 | } |
599 | - elseif (empty($_SESSION['id_msg_last_visit'])) |
|
600 | - $_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit']; |
|
601 | 630 | |
602 | 631 | $username = $user_settings['member_name']; |
603 | 632 | |
604 | - if (empty($user_settings['additional_groups'])) |
|
605 | - $user_info = array( |
|
633 | + if (empty($user_settings['additional_groups'])) { |
|
634 | + $user_info = array( |
|
606 | 635 | 'groups' => array($user_settings['id_group'], $user_settings['id_post_group']) |
607 | 636 | ); |
608 | - else |
|
609 | - $user_info = array( |
|
637 | + } else { |
|
638 | + $user_info = array( |
|
610 | 639 | 'groups' => array_merge( |
611 | 640 | array($user_settings['id_group'], $user_settings['id_post_group']), |
612 | 641 | explode(',', $user_settings['additional_groups']) |
613 | 642 | ) |
614 | 643 | ); |
644 | + } |
|
615 | 645 | |
616 | 646 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
617 | - foreach ($user_info['groups'] as $k => $v) |
|
618 | - $user_info['groups'][$k] = (int) $v; |
|
647 | + foreach ($user_info['groups'] as $k => $v) { |
|
648 | + $user_info['groups'][$k] = (int) $v; |
|
649 | + } |
|
619 | 650 | |
620 | 651 | // This is a logged in user, so definitely not a spider. |
621 | 652 | $user_info['possibly_robot'] = false; |
@@ -629,8 +660,7 @@ discard block |
||
629 | 660 | $time_system = new DateTime('now', $tz_system); |
630 | 661 | $time_user = new DateTime('now', $tz_user); |
631 | 662 | $user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600; |
632 | - } |
|
633 | - else |
|
663 | + } else |
|
634 | 664 | { |
635 | 665 | // !!! Compatibility. |
636 | 666 | $user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset']; |
@@ -644,8 +674,9 @@ discard block |
||
644 | 674 | $user_info = array('groups' => array(-1)); |
645 | 675 | $user_settings = array(); |
646 | 676 | |
647 | - if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) |
|
648 | - $_COOKIE[$cookiename] = ''; |
|
677 | + if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) { |
|
678 | + $_COOKIE[$cookiename] = ''; |
|
679 | + } |
|
649 | 680 | |
650 | 681 | // Expire the 2FA cookie |
651 | 682 | if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member'])) |
@@ -662,19 +693,20 @@ discard block |
||
662 | 693 | } |
663 | 694 | |
664 | 695 | // Create a login token if it doesn't exist yet. |
665 | - if (!isset($_SESSION['token']['post-login'])) |
|
666 | - createToken('login'); |
|
667 | - else |
|
668 | - list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login']; |
|
696 | + if (!isset($_SESSION['token']['post-login'])) { |
|
697 | + createToken('login'); |
|
698 | + } else { |
|
699 | + list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login']; |
|
700 | + } |
|
669 | 701 | |
670 | 702 | // Do we perhaps think this is a search robot? Check every five minutes just in case... |
671 | 703 | if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300)) |
672 | 704 | { |
673 | 705 | require_once($sourcedir . '/ManageSearchEngines.php'); |
674 | 706 | $user_info['possibly_robot'] = SpiderCheck(); |
707 | + } elseif (!empty($modSettings['spider_mode'])) { |
|
708 | + $user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0; |
|
675 | 709 | } |
676 | - elseif (!empty($modSettings['spider_mode'])) |
|
677 | - $user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0; |
|
678 | 710 | // If we haven't turned on proper spider hunts then have a guess! |
679 | 711 | else |
680 | 712 | { |
@@ -722,8 +754,9 @@ discard block |
||
722 | 754 | $user_info['groups'] = array_unique($user_info['groups']); |
723 | 755 | |
724 | 756 | // Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems. |
725 | - if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) |
|
726 | - unset($user_info['ignoreboards'][$tmp]); |
|
757 | + if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) { |
|
758 | + unset($user_info['ignoreboards'][$tmp]); |
|
759 | + } |
|
727 | 760 | |
728 | 761 | // Allow the user to change their language. |
729 | 762 | if (!empty($modSettings['userLanguage'])) |
@@ -736,13 +769,14 @@ discard block |
||
736 | 769 | $user_info['language'] = strtr($_GET['language'], './\\:', '____'); |
737 | 770 | |
738 | 771 | // Make it permanent for members. |
739 | - if (!empty($user_info['id'])) |
|
740 | - updateMemberData($user_info['id'], array('lngfile' => $user_info['language'])); |
|
741 | - else |
|
742 | - $_SESSION['language'] = $user_info['language']; |
|
772 | + if (!empty($user_info['id'])) { |
|
773 | + updateMemberData($user_info['id'], array('lngfile' => $user_info['language'])); |
|
774 | + } else { |
|
775 | + $_SESSION['language'] = $user_info['language']; |
|
776 | + } |
|
777 | + } elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) { |
|
778 | + $user_info['language'] = strtr($_SESSION['language'], './\\:', '____'); |
|
743 | 779 | } |
744 | - elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) |
|
745 | - $user_info['language'] = strtr($_SESSION['language'], './\\:', '____'); |
|
746 | 780 | } |
747 | 781 | |
748 | 782 | $temp = build_query_board($user_info['id']); |
@@ -805,9 +839,9 @@ discard block |
||
805 | 839 | } |
806 | 840 | |
807 | 841 | // Remember redirection is the key to avoiding fallout from your bosses. |
808 | - if (!empty($topic)) |
|
809 | - redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']); |
|
810 | - else |
|
842 | + if (!empty($topic)) { |
|
843 | + redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']); |
|
844 | + } else |
|
811 | 845 | { |
812 | 846 | loadPermissions(); |
813 | 847 | loadTheme(); |
@@ -825,10 +859,11 @@ discard block |
||
825 | 859 | if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3)) |
826 | 860 | { |
827 | 861 | // @todo SLOW? |
828 | - if (!empty($topic)) |
|
829 | - $temp = cache_get_data('topic_board-' . $topic, 120); |
|
830 | - else |
|
831 | - $temp = cache_get_data('board-' . $board, 120); |
|
862 | + if (!empty($topic)) { |
|
863 | + $temp = cache_get_data('topic_board-' . $topic, 120); |
|
864 | + } else { |
|
865 | + $temp = cache_get_data('board-' . $board, 120); |
|
866 | + } |
|
832 | 867 | |
833 | 868 | if (!empty($temp)) |
834 | 869 | { |
@@ -866,8 +901,9 @@ discard block |
||
866 | 901 | $row = $smcFunc['db_fetch_assoc']($request); |
867 | 902 | |
868 | 903 | // Set the current board. |
869 | - if (!empty($row['id_board'])) |
|
870 | - $board = $row['id_board']; |
|
904 | + if (!empty($row['id_board'])) { |
|
905 | + $board = $row['id_board']; |
|
906 | + } |
|
871 | 907 | |
872 | 908 | // Basic operating information. (globals... :/) |
873 | 909 | $board_info = array( |
@@ -903,21 +939,23 @@ discard block |
||
903 | 939 | |
904 | 940 | do |
905 | 941 | { |
906 | - if (!empty($row['id_moderator'])) |
|
907 | - $board_info['moderators'][$row['id_moderator']] = array( |
|
942 | + if (!empty($row['id_moderator'])) { |
|
943 | + $board_info['moderators'][$row['id_moderator']] = array( |
|
908 | 944 | 'id' => $row['id_moderator'], |
909 | 945 | 'name' => $row['real_name'], |
910 | 946 | 'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'], |
911 | 947 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>' |
912 | 948 | ); |
949 | + } |
|
913 | 950 | |
914 | - if (!empty($row['id_moderator_group'])) |
|
915 | - $board_info['moderator_groups'][$row['id_moderator_group']] = array( |
|
951 | + if (!empty($row['id_moderator_group'])) { |
|
952 | + $board_info['moderator_groups'][$row['id_moderator_group']] = array( |
|
916 | 953 | 'id' => $row['id_moderator_group'], |
917 | 954 | 'name' => $row['group_name'], |
918 | 955 | 'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'], |
919 | 956 | 'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>' |
920 | 957 | ); |
958 | + } |
|
921 | 959 | } |
922 | 960 | while ($row = $smcFunc['db_fetch_assoc']($request)); |
923 | 961 | |
@@ -949,12 +987,12 @@ discard block |
||
949 | 987 | if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3)) |
950 | 988 | { |
951 | 989 | // @todo SLOW? |
952 | - if (!empty($topic)) |
|
953 | - cache_put_data('topic_board-' . $topic, $board_info, 120); |
|
990 | + if (!empty($topic)) { |
|
991 | + cache_put_data('topic_board-' . $topic, $board_info, 120); |
|
992 | + } |
|
954 | 993 | cache_put_data('board-' . $board, $board_info, 120); |
955 | 994 | } |
956 | - } |
|
957 | - else |
|
995 | + } else |
|
958 | 996 | { |
959 | 997 | // Otherwise the topic is invalid, there are no moderators, etc. |
960 | 998 | $board_info = array( |
@@ -968,8 +1006,9 @@ discard block |
||
968 | 1006 | $smcFunc['db_free_result']($request); |
969 | 1007 | } |
970 | 1008 | |
971 | - if (!empty($topic)) |
|
972 | - $_GET['board'] = (int) $board; |
|
1009 | + if (!empty($topic)) { |
|
1010 | + $_GET['board'] = (int) $board; |
|
1011 | + } |
|
973 | 1012 | |
974 | 1013 | if (!empty($board)) |
975 | 1014 | { |
@@ -979,10 +1018,12 @@ discard block |
||
979 | 1018 | // Now check if the user is a moderator. |
980 | 1019 | $user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0; |
981 | 1020 | |
982 | - if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) |
|
983 | - $board_info['error'] = 'access'; |
|
984 | - if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) |
|
985 | - $board_info['error'] = 'access'; |
|
1021 | + if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) { |
|
1022 | + $board_info['error'] = 'access'; |
|
1023 | + } |
|
1024 | + if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) { |
|
1025 | + $board_info['error'] = 'access'; |
|
1026 | + } |
|
986 | 1027 | |
987 | 1028 | // Build up the linktree. |
988 | 1029 | $context['linktree'] = array_merge( |
@@ -1005,8 +1046,9 @@ discard block |
||
1005 | 1046 | $context['current_board'] = $board; |
1006 | 1047 | |
1007 | 1048 | // No posting in redirection boards! |
1008 | - if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) |
|
1009 | - $board_info['error'] == 'post_in_redirect'; |
|
1049 | + if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) { |
|
1050 | + $board_info['error'] == 'post_in_redirect'; |
|
1051 | + } |
|
1010 | 1052 | |
1011 | 1053 | // Hacker... you can't see this topic, I'll tell you that. (but moderators can!) |
1012 | 1054 | if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod'])) |
@@ -1032,24 +1074,23 @@ discard block |
||
1032 | 1074 | ob_end_clean(); |
1033 | 1075 | header('HTTP/1.1 403 Forbidden'); |
1034 | 1076 | die; |
1035 | - } |
|
1036 | - elseif ($board_info['error'] == 'post_in_redirect') |
|
1077 | + } elseif ($board_info['error'] == 'post_in_redirect') |
|
1037 | 1078 | { |
1038 | 1079 | // Slightly different error message here... |
1039 | 1080 | fatal_lang_error('cannot_post_redirect', false); |
1040 | - } |
|
1041 | - elseif ($user_info['is_guest']) |
|
1081 | + } elseif ($user_info['is_guest']) |
|
1042 | 1082 | { |
1043 | 1083 | loadLanguage('Errors'); |
1044 | 1084 | is_not_guest($txt['topic_gone']); |
1085 | + } else { |
|
1086 | + fatal_lang_error('topic_gone', false); |
|
1045 | 1087 | } |
1046 | - else |
|
1047 | - fatal_lang_error('topic_gone', false); |
|
1048 | 1088 | } |
1049 | 1089 | |
1050 | - if ($user_info['is_mod']) |
|
1051 | - $user_info['groups'][] = 3; |
|
1052 | -} |
|
1090 | + if ($user_info['is_mod']) { |
|
1091 | + $user_info['groups'][] = 3; |
|
1092 | + } |
|
1093 | + } |
|
1053 | 1094 | |
1054 | 1095 | /** |
1055 | 1096 | * Load this user's permissions. |
@@ -1070,8 +1111,9 @@ discard block |
||
1070 | 1111 | asort($cache_groups); |
1071 | 1112 | $cache_groups = implode(',', $cache_groups); |
1072 | 1113 | // If it's a spider then cache it different. |
1073 | - if ($user_info['possibly_robot']) |
|
1074 | - $cache_groups .= '-spider'; |
|
1114 | + if ($user_info['possibly_robot']) { |
|
1115 | + $cache_groups .= '-spider'; |
|
1116 | + } |
|
1075 | 1117 | |
1076 | 1118 | if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated']) |
1077 | 1119 | { |
@@ -1079,9 +1121,9 @@ discard block |
||
1079 | 1121 | banPermissions(); |
1080 | 1122 | |
1081 | 1123 | return; |
1124 | + } elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) { |
|
1125 | + list ($user_info['permissions'], $removals) = $temp; |
|
1082 | 1126 | } |
1083 | - elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) |
|
1084 | - list ($user_info['permissions'], $removals) = $temp; |
|
1085 | 1127 | } |
1086 | 1128 | |
1087 | 1129 | // If it is detected as a robot, and we are restricting permissions as a special group - then implement this. |
@@ -1103,23 +1145,26 @@ discard block |
||
1103 | 1145 | $removals = array(); |
1104 | 1146 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1105 | 1147 | { |
1106 | - if (empty($row['add_deny'])) |
|
1107 | - $removals[] = $row['permission']; |
|
1108 | - else |
|
1109 | - $user_info['permissions'][] = $row['permission']; |
|
1148 | + if (empty($row['add_deny'])) { |
|
1149 | + $removals[] = $row['permission']; |
|
1150 | + } else { |
|
1151 | + $user_info['permissions'][] = $row['permission']; |
|
1152 | + } |
|
1110 | 1153 | } |
1111 | 1154 | $smcFunc['db_free_result']($request); |
1112 | 1155 | |
1113 | - if (isset($cache_groups)) |
|
1114 | - cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240); |
|
1156 | + if (isset($cache_groups)) { |
|
1157 | + cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240); |
|
1158 | + } |
|
1115 | 1159 | } |
1116 | 1160 | |
1117 | 1161 | // Get the board permissions. |
1118 | 1162 | if (!empty($board)) |
1119 | 1163 | { |
1120 | 1164 | // Make sure the board (if any) has been loaded by loadBoard(). |
1121 | - if (!isset($board_info['profile'])) |
|
1122 | - fatal_lang_error('no_board'); |
|
1165 | + if (!isset($board_info['profile'])) { |
|
1166 | + fatal_lang_error('no_board'); |
|
1167 | + } |
|
1123 | 1168 | |
1124 | 1169 | $request = $smcFunc['db_query']('', ' |
1125 | 1170 | SELECT permission, add_deny |
@@ -1135,20 +1180,23 @@ discard block |
||
1135 | 1180 | ); |
1136 | 1181 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1137 | 1182 | { |
1138 | - if (empty($row['add_deny'])) |
|
1139 | - $removals[] = $row['permission']; |
|
1140 | - else |
|
1141 | - $user_info['permissions'][] = $row['permission']; |
|
1183 | + if (empty($row['add_deny'])) { |
|
1184 | + $removals[] = $row['permission']; |
|
1185 | + } else { |
|
1186 | + $user_info['permissions'][] = $row['permission']; |
|
1187 | + } |
|
1142 | 1188 | } |
1143 | 1189 | $smcFunc['db_free_result']($request); |
1144 | 1190 | } |
1145 | 1191 | |
1146 | 1192 | // Remove all the permissions they shouldn't have ;). |
1147 | - if (!empty($modSettings['permission_enable_deny'])) |
|
1148 | - $user_info['permissions'] = array_diff($user_info['permissions'], $removals); |
|
1193 | + if (!empty($modSettings['permission_enable_deny'])) { |
|
1194 | + $user_info['permissions'] = array_diff($user_info['permissions'], $removals); |
|
1195 | + } |
|
1149 | 1196 | |
1150 | - if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) |
|
1151 | - cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240); |
|
1197 | + if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) { |
|
1198 | + cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240); |
|
1199 | + } |
|
1152 | 1200 | |
1153 | 1201 | // Banned? Watch, don't touch.. |
1154 | 1202 | banPermissions(); |
@@ -1160,17 +1208,18 @@ discard block |
||
1160 | 1208 | { |
1161 | 1209 | require_once($sourcedir . '/Subs-Auth.php'); |
1162 | 1210 | rebuildModCache(); |
1211 | + } else { |
|
1212 | + $user_info['mod_cache'] = $_SESSION['mc']; |
|
1163 | 1213 | } |
1164 | - else |
|
1165 | - $user_info['mod_cache'] = $_SESSION['mc']; |
|
1166 | 1214 | |
1167 | 1215 | // This is a useful phantom permission added to the current user, and only the current user while they are logged in. |
1168 | 1216 | // For example this drastically simplifies certain changes to the profile area. |
1169 | 1217 | $user_info['permissions'][] = 'is_not_guest'; |
1170 | 1218 | // And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions. |
1171 | 1219 | $user_info['permissions'][] = 'profile_view_own'; |
1172 | - if (in_array('profile_view', $user_info['permissions'])) |
|
1173 | - $user_info['permissions'][] = 'profile_view_any'; |
|
1220 | + if (in_array('profile_view', $user_info['permissions'])) { |
|
1221 | + $user_info['permissions'][] = 'profile_view_any'; |
|
1222 | + } |
|
1174 | 1223 | } |
1175 | 1224 | } |
1176 | 1225 | |
@@ -1188,8 +1237,9 @@ discard block |
||
1188 | 1237 | global $image_proxy_enabled, $image_proxy_secret, $boardurl; |
1189 | 1238 | |
1190 | 1239 | // Can't just look for no users :P. |
1191 | - if (empty($users)) |
|
1192 | - return array(); |
|
1240 | + if (empty($users)) { |
|
1241 | + return array(); |
|
1242 | + } |
|
1193 | 1243 | |
1194 | 1244 | // Pass the set value |
1195 | 1245 | $context['loadMemberContext_set'] = $set; |
@@ -1204,8 +1254,9 @@ discard block |
||
1204 | 1254 | for ($i = 0, $n = count($users); $i < $n; $i++) |
1205 | 1255 | { |
1206 | 1256 | $data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240); |
1207 | - if ($data == null) |
|
1208 | - continue; |
|
1257 | + if ($data == null) { |
|
1258 | + continue; |
|
1259 | + } |
|
1209 | 1260 | |
1210 | 1261 | $loaded_ids[] = $data['id_member']; |
1211 | 1262 | $user_profile[$data['id_member']] = $data; |
@@ -1272,16 +1323,19 @@ discard block |
||
1272 | 1323 | $row['avatar_original'] = !empty($row['avatar']) ? $row['avatar'] : ''; |
1273 | 1324 | |
1274 | 1325 | // Take care of proxying avatar if required, do this here for maximum reach |
1275 | - if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false) |
|
1276 | - $row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret); |
|
1326 | + if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false) { |
|
1327 | + $row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret); |
|
1328 | + } |
|
1277 | 1329 | |
1278 | 1330 | // Keep track of the member's normal member group |
1279 | 1331 | $row['primary_group'] = $row['member_group']; |
1280 | 1332 | |
1281 | - if (isset($row['member_ip'])) |
|
1282 | - $row['member_ip'] = inet_dtop($row['member_ip']); |
|
1283 | - if (isset($row['member_ip2'])) |
|
1284 | - $row['member_ip2'] = inet_dtop($row['member_ip2']); |
|
1333 | + if (isset($row['member_ip'])) { |
|
1334 | + $row['member_ip'] = inet_dtop($row['member_ip']); |
|
1335 | + } |
|
1336 | + if (isset($row['member_ip2'])) { |
|
1337 | + $row['member_ip2'] = inet_dtop($row['member_ip2']); |
|
1338 | + } |
|
1285 | 1339 | $new_loaded_ids[] = $row['id_member']; |
1286 | 1340 | $loaded_ids[] = $row['id_member']; |
1287 | 1341 | $row['options'] = array(); |
@@ -1300,8 +1354,9 @@ discard block |
||
1300 | 1354 | 'loaded_ids' => $new_loaded_ids, |
1301 | 1355 | ) |
1302 | 1356 | ); |
1303 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1304 | - $user_profile[$row['id_member']]['options'][$row['variable']] = $row['value']; |
|
1357 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1358 | + $user_profile[$row['id_member']]['options'][$row['variable']] = $row['value']; |
|
1359 | + } |
|
1305 | 1360 | $smcFunc['db_free_result']($request); |
1306 | 1361 | } |
1307 | 1362 | |
@@ -1312,10 +1367,11 @@ discard block |
||
1312 | 1367 | { |
1313 | 1368 | foreach ($loaded_ids as $a_member) |
1314 | 1369 | { |
1315 | - if (!empty($user_profile[$a_member]['additional_groups'])) |
|
1316 | - $groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups'])); |
|
1317 | - else |
|
1318 | - $groups = array($user_profile[$a_member]['id_group']); |
|
1370 | + if (!empty($user_profile[$a_member]['additional_groups'])) { |
|
1371 | + $groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups'])); |
|
1372 | + } else { |
|
1373 | + $groups = array($user_profile[$a_member]['id_group']); |
|
1374 | + } |
|
1319 | 1375 | |
1320 | 1376 | $temp = array_intersect($groups, array_keys($board_info['moderator_groups'])); |
1321 | 1377 | |
@@ -1328,8 +1384,9 @@ discard block |
||
1328 | 1384 | |
1329 | 1385 | if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3) |
1330 | 1386 | { |
1331 | - for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) |
|
1332 | - cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240); |
|
1387 | + for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) { |
|
1388 | + cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240); |
|
1389 | + } |
|
1333 | 1390 | } |
1334 | 1391 | |
1335 | 1392 | // Are we loading any moderators? If so, fix their group data... |
@@ -1355,14 +1412,17 @@ discard block |
||
1355 | 1412 | foreach ($temp_mods as $id) |
1356 | 1413 | { |
1357 | 1414 | // By popular demand, don't show admins or global moderators as moderators. |
1358 | - if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) |
|
1359 | - $user_profile[$id]['member_group'] = $row['member_group']; |
|
1415 | + if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) { |
|
1416 | + $user_profile[$id]['member_group'] = $row['member_group']; |
|
1417 | + } |
|
1360 | 1418 | |
1361 | 1419 | // If the Moderator group has no color or icons, but their group does... don't overwrite. |
1362 | - if (!empty($row['icons'])) |
|
1363 | - $user_profile[$id]['icons'] = $row['icons']; |
|
1364 | - if (!empty($row['member_group_color'])) |
|
1365 | - $user_profile[$id]['member_group_color'] = $row['member_group_color']; |
|
1420 | + if (!empty($row['icons'])) { |
|
1421 | + $user_profile[$id]['icons'] = $row['icons']; |
|
1422 | + } |
|
1423 | + if (!empty($row['member_group_color'])) { |
|
1424 | + $user_profile[$id]['member_group_color'] = $row['member_group_color']; |
|
1425 | + } |
|
1366 | 1426 | } |
1367 | 1427 | } |
1368 | 1428 | |
@@ -1384,12 +1444,14 @@ discard block |
||
1384 | 1444 | static $loadedLanguages = array(); |
1385 | 1445 | |
1386 | 1446 | // If this person's data is already loaded, skip it. |
1387 | - if (isset($dataLoaded[$user])) |
|
1388 | - return true; |
|
1447 | + if (isset($dataLoaded[$user])) { |
|
1448 | + return true; |
|
1449 | + } |
|
1389 | 1450 | |
1390 | 1451 | // We can't load guests or members not loaded by loadMemberData()! |
1391 | - if ($user == 0) |
|
1392 | - return false; |
|
1452 | + if ($user == 0) { |
|
1453 | + return false; |
|
1454 | + } |
|
1393 | 1455 | if (!isset($user_profile[$user])) |
1394 | 1456 | { |
1395 | 1457 | trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING); |
@@ -1415,12 +1477,16 @@ discard block |
||
1415 | 1477 | $buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array(); |
1416 | 1478 | |
1417 | 1479 | //We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme |
1418 | - if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists |
|
1480 | + if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) { |
|
1481 | + //icon is set and exists |
|
1419 | 1482 | $group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1]; |
1420 | - elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default |
|
1483 | + } elseif (isset($profile['icons'][1])) { |
|
1484 | + //icon is set and doesn't exist, fallback to default |
|
1421 | 1485 | $group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1]; |
1422 | - else //not set, bye bye |
|
1486 | + } else { |
|
1487 | + //not set, bye bye |
|
1423 | 1488 | $group_icon_url = ''; |
1489 | + } |
|
1424 | 1490 | |
1425 | 1491 | // These minimal values are always loaded |
1426 | 1492 | $memberContext[$user] = array( |
@@ -1439,8 +1505,9 @@ discard block |
||
1439 | 1505 | if ($context['loadMemberContext_set'] != 'minimal') |
1440 | 1506 | { |
1441 | 1507 | // Go the extra mile and load the user's native language name. |
1442 | - if (empty($loadedLanguages)) |
|
1443 | - $loadedLanguages = getLanguages(); |
|
1508 | + if (empty($loadedLanguages)) { |
|
1509 | + $loadedLanguages = getLanguages(); |
|
1510 | + } |
|
1444 | 1511 | |
1445 | 1512 | $memberContext[$user] += array( |
1446 | 1513 | 'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>', |
@@ -1495,31 +1562,33 @@ discard block |
||
1495 | 1562 | { |
1496 | 1563 | if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://'))) |
1497 | 1564 | { |
1498 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) |
|
1499 | - $image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11)); |
|
1500 | - else |
|
1501 | - $image = get_gravatar_url($profile['email_address']); |
|
1502 | - } |
|
1503 | - else |
|
1565 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) { |
|
1566 | + $image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11)); |
|
1567 | + } else { |
|
1568 | + $image = get_gravatar_url($profile['email_address']); |
|
1569 | + } |
|
1570 | + } else |
|
1504 | 1571 | { |
1505 | 1572 | // So it's stored in the member table? |
1506 | 1573 | if (!empty($profile['avatar'])) |
1507 | 1574 | { |
1508 | 1575 | $image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar']; |
1576 | + } elseif (!empty($profile['filename'])) { |
|
1577 | + $image = $modSettings['custom_avatar_url'] . '/' . $profile['filename']; |
|
1509 | 1578 | } |
1510 | - elseif (!empty($profile['filename'])) |
|
1511 | - $image = $modSettings['custom_avatar_url'] . '/' . $profile['filename']; |
|
1512 | 1579 | // Right... no avatar...use the default one |
1513 | - else |
|
1514 | - $image = $modSettings['avatar_url'] . '/default.png'; |
|
1580 | + else { |
|
1581 | + $image = $modSettings['avatar_url'] . '/default.png'; |
|
1582 | + } |
|
1515 | 1583 | } |
1516 | - if (!empty($image)) |
|
1517 | - $memberContext[$user]['avatar'] = array( |
|
1584 | + if (!empty($image)) { |
|
1585 | + $memberContext[$user]['avatar'] = array( |
|
1518 | 1586 | 'name' => $profile['avatar'], |
1519 | 1587 | 'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">', |
1520 | 1588 | 'href' => $image, |
1521 | 1589 | 'url' => $image, |
1522 | 1590 | ); |
1591 | + } |
|
1523 | 1592 | } |
1524 | 1593 | |
1525 | 1594 | // Are we also loading the members custom fields into context? |
@@ -1527,35 +1596,41 @@ discard block |
||
1527 | 1596 | { |
1528 | 1597 | $memberContext[$user]['custom_fields'] = array(); |
1529 | 1598 | |
1530 | - if (!isset($context['display_fields'])) |
|
1531 | - $context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true); |
|
1599 | + if (!isset($context['display_fields'])) { |
|
1600 | + $context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true); |
|
1601 | + } |
|
1532 | 1602 | |
1533 | 1603 | foreach ($context['display_fields'] as $custom) |
1534 | 1604 | { |
1535 | - if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) |
|
1536 | - continue; |
|
1605 | + if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) { |
|
1606 | + continue; |
|
1607 | + } |
|
1537 | 1608 | |
1538 | 1609 | $value = $profile['options'][$custom['col_name']]; |
1539 | 1610 | |
1540 | 1611 | // Don't show the "disabled" option for the "gender" field. |
1541 | - if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') |
|
1542 | - continue; |
|
1612 | + if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') { |
|
1613 | + continue; |
|
1614 | + } |
|
1543 | 1615 | |
1544 | 1616 | // BBC? |
1545 | - if ($custom['bbc']) |
|
1546 | - $value = parse_bbc($value); |
|
1617 | + if ($custom['bbc']) { |
|
1618 | + $value = parse_bbc($value); |
|
1619 | + } |
|
1547 | 1620 | // ... or checkbox? |
1548 | - elseif (isset($custom['type']) && $custom['type'] == 'check') |
|
1549 | - $value = $value ? $txt['yes'] : $txt['no']; |
|
1621 | + elseif (isset($custom['type']) && $custom['type'] == 'check') { |
|
1622 | + $value = $value ? $txt['yes'] : $txt['no']; |
|
1623 | + } |
|
1550 | 1624 | |
1551 | 1625 | // Enclosing the user input within some other text? |
1552 | - if (!empty($custom['enclose'])) |
|
1553 | - $value = strtr($custom['enclose'], array( |
|
1626 | + if (!empty($custom['enclose'])) { |
|
1627 | + $value = strtr($custom['enclose'], array( |
|
1554 | 1628 | '{SCRIPTURL}' => $scripturl, |
1555 | 1629 | '{IMAGES_URL}' => $settings['images_url'], |
1556 | 1630 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
1557 | 1631 | '{INPUT}' => $value, |
1558 | 1632 | )); |
1633 | + } |
|
1559 | 1634 | |
1560 | 1635 | $memberContext[$user]['custom_fields'][] = array( |
1561 | 1636 | 'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'], |
@@ -1582,8 +1657,9 @@ discard block |
||
1582 | 1657 | global $smcFunc, $txt, $scripturl, $settings; |
1583 | 1658 | |
1584 | 1659 | // Do not waste my time... |
1585 | - if (empty($users) || empty($params)) |
|
1586 | - return false; |
|
1660 | + if (empty($users) || empty($params)) { |
|
1661 | + return false; |
|
1662 | + } |
|
1587 | 1663 | |
1588 | 1664 | // Make sure it's an array. |
1589 | 1665 | $users = !is_array($users) ? array($users) : array_unique($users); |
@@ -1607,31 +1683,36 @@ discard block |
||
1607 | 1683 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1608 | 1684 | { |
1609 | 1685 | // BBC? |
1610 | - if (!empty($row['bbc'])) |
|
1611 | - $row['value'] = parse_bbc($row['value']); |
|
1686 | + if (!empty($row['bbc'])) { |
|
1687 | + $row['value'] = parse_bbc($row['value']); |
|
1688 | + } |
|
1612 | 1689 | |
1613 | 1690 | // ... or checkbox? |
1614 | - elseif (isset($row['type']) && $row['type'] == 'check') |
|
1615 | - $row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no']; |
|
1691 | + elseif (isset($row['type']) && $row['type'] == 'check') { |
|
1692 | + $row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no']; |
|
1693 | + } |
|
1616 | 1694 | |
1617 | 1695 | // Enclosing the user input within some other text? |
1618 | - if (!empty($row['enclose'])) |
|
1619 | - $row['value'] = strtr($row['enclose'], array( |
|
1696 | + if (!empty($row['enclose'])) { |
|
1697 | + $row['value'] = strtr($row['enclose'], array( |
|
1620 | 1698 | '{SCRIPTURL}' => $scripturl, |
1621 | 1699 | '{IMAGES_URL}' => $settings['images_url'], |
1622 | 1700 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
1623 | 1701 | '{INPUT}' => un_htmlspecialchars($row['value']), |
1624 | 1702 | )); |
1703 | + } |
|
1625 | 1704 | |
1626 | 1705 | // Send a simple array if there is just 1 param |
1627 | - if (count($params) == 1) |
|
1628 | - $return[$row['id_member']] = $row; |
|
1706 | + if (count($params) == 1) { |
|
1707 | + $return[$row['id_member']] = $row; |
|
1708 | + } |
|
1629 | 1709 | |
1630 | 1710 | // More than 1? knock yourself out... |
1631 | 1711 | else |
1632 | 1712 | { |
1633 | - if (!isset($return[$row['id_member']])) |
|
1634 | - $return[$row['id_member']] = array(); |
|
1713 | + if (!isset($return[$row['id_member']])) { |
|
1714 | + $return[$row['id_member']] = array(); |
|
1715 | + } |
|
1635 | 1716 | |
1636 | 1717 | $return[$row['id_member']][$row['variable']] = $row; |
1637 | 1718 | } |
@@ -1665,8 +1746,9 @@ discard block |
||
1665 | 1746 | global $context; |
1666 | 1747 | |
1667 | 1748 | // Don't know any browser! |
1668 | - if (empty($context['browser'])) |
|
1669 | - detectBrowser(); |
|
1749 | + if (empty($context['browser'])) { |
|
1750 | + detectBrowser(); |
|
1751 | + } |
|
1670 | 1752 | |
1671 | 1753 | return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false; |
1672 | 1754 | } |
@@ -1684,8 +1766,9 @@ discard block |
||
1684 | 1766 | global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled; |
1685 | 1767 | |
1686 | 1768 | // The theme was specified by parameter. |
1687 | - if (!empty($id_theme)) |
|
1688 | - $id_theme = (int) $id_theme; |
|
1769 | + if (!empty($id_theme)) { |
|
1770 | + $id_theme = (int) $id_theme; |
|
1771 | + } |
|
1689 | 1772 | // The theme was specified by REQUEST. |
1690 | 1773 | elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) |
1691 | 1774 | { |
@@ -1693,54 +1776,61 @@ discard block |
||
1693 | 1776 | $_SESSION['id_theme'] = $id_theme; |
1694 | 1777 | } |
1695 | 1778 | // The theme was specified by REQUEST... previously. |
1696 | - elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) |
|
1697 | - $id_theme = (int) $_SESSION['id_theme']; |
|
1779 | + elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) { |
|
1780 | + $id_theme = (int) $_SESSION['id_theme']; |
|
1781 | + } |
|
1698 | 1782 | // The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.) |
1699 | - elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) |
|
1700 | - $id_theme = $user_info['theme']; |
|
1783 | + elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) { |
|
1784 | + $id_theme = $user_info['theme']; |
|
1785 | + } |
|
1701 | 1786 | // The theme was specified by the board. |
1702 | - elseif (!empty($board_info['theme'])) |
|
1703 | - $id_theme = $board_info['theme']; |
|
1787 | + elseif (!empty($board_info['theme'])) { |
|
1788 | + $id_theme = $board_info['theme']; |
|
1789 | + } |
|
1704 | 1790 | // The theme is the forum's default. |
1705 | - else |
|
1706 | - $id_theme = $modSettings['theme_guests']; |
|
1791 | + else { |
|
1792 | + $id_theme = $modSettings['theme_guests']; |
|
1793 | + } |
|
1707 | 1794 | |
1708 | 1795 | // We already load the basic stuff? |
1709 | 1796 | if (empty($settings['theme_id']) || $settings['theme_id'] != $id_theme ) |
1710 | 1797 | { |
1711 | 1798 | // Verify the id_theme... no foul play. |
1712 | 1799 | // Always allow the board specific theme, if they are overriding. |
1713 | - if (!empty($board_info['theme']) && $board_info['override_theme']) |
|
1714 | - $id_theme = $board_info['theme']; |
|
1800 | + if (!empty($board_info['theme']) && $board_info['override_theme']) { |
|
1801 | + $id_theme = $board_info['theme']; |
|
1802 | + } |
|
1715 | 1803 | // If they have specified a particular theme to use with SSI allow it to be used. |
1716 | - elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) |
|
1717 | - $id_theme = (int) $id_theme; |
|
1718 | - elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum')) |
|
1804 | + elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) { |
|
1805 | + $id_theme = (int) $id_theme; |
|
1806 | + } elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum')) |
|
1719 | 1807 | { |
1720 | 1808 | $themes = explode(',', $modSettings['enableThemes']); |
1721 | - if (!in_array($id_theme, $themes)) |
|
1722 | - $id_theme = $modSettings['theme_guests']; |
|
1723 | - else |
|
1724 | - $id_theme = (int) $id_theme; |
|
1809 | + if (!in_array($id_theme, $themes)) { |
|
1810 | + $id_theme = $modSettings['theme_guests']; |
|
1811 | + } else { |
|
1812 | + $id_theme = (int) $id_theme; |
|
1813 | + } |
|
1814 | + } else { |
|
1815 | + $id_theme = (int) $id_theme; |
|
1725 | 1816 | } |
1726 | - else |
|
1727 | - $id_theme = (int) $id_theme; |
|
1728 | 1817 | |
1729 | 1818 | $member = empty($user_info['id']) ? -1 : $user_info['id']; |
1730 | 1819 | |
1731 | 1820 | // Disable image proxy if we don't have SSL enabled |
1732 | - if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) |
|
1733 | - $image_proxy_enabled = false; |
|
1821 | + if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) { |
|
1822 | + $image_proxy_enabled = false; |
|
1823 | + } |
|
1734 | 1824 | |
1735 | 1825 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated']) |
1736 | 1826 | { |
1737 | 1827 | $themeData = $temp; |
1738 | 1828 | $flag = true; |
1829 | + } elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) { |
|
1830 | + $themeData = $temp + array($member => array()); |
|
1831 | + } else { |
|
1832 | + $themeData = array(-1 => array(), 0 => array(), $member => array()); |
|
1739 | 1833 | } |
1740 | - elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) |
|
1741 | - $themeData = $temp + array($member => array()); |
|
1742 | - else |
|
1743 | - $themeData = array(-1 => array(), 0 => array(), $member => array()); |
|
1744 | 1834 | |
1745 | 1835 | if (empty($flag)) |
1746 | 1836 | { |
@@ -1759,31 +1849,37 @@ discard block |
||
1759 | 1849 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
1760 | 1850 | { |
1761 | 1851 | // There are just things we shouldn't be able to change as members. |
1762 | - if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) |
|
1763 | - continue; |
|
1852 | + if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) { |
|
1853 | + continue; |
|
1854 | + } |
|
1764 | 1855 | |
1765 | 1856 | // If this is the theme_dir of the default theme, store it. |
1766 | - if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) |
|
1767 | - $themeData[0]['default_' . $row['variable']] = $row['value']; |
|
1857 | + if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) { |
|
1858 | + $themeData[0]['default_' . $row['variable']] = $row['value']; |
|
1859 | + } |
|
1768 | 1860 | |
1769 | 1861 | // If this isn't set yet, is a theme option, or is not the default theme.. |
1770 | - if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') |
|
1771 | - $themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value']; |
|
1862 | + if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') { |
|
1863 | + $themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value']; |
|
1864 | + } |
|
1772 | 1865 | } |
1773 | 1866 | $smcFunc['db_free_result']($result); |
1774 | 1867 | |
1775 | - if (!empty($themeData[-1])) |
|
1776 | - foreach ($themeData[-1] as $k => $v) |
|
1868 | + if (!empty($themeData[-1])) { |
|
1869 | + foreach ($themeData[-1] as $k => $v) |
|
1777 | 1870 | { |
1778 | 1871 | if (!isset($themeData[$member][$k])) |
1779 | 1872 | $themeData[$member][$k] = $v; |
1873 | + } |
|
1780 | 1874 | } |
1781 | 1875 | |
1782 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
1783 | - cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60); |
|
1876 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
1877 | + cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60); |
|
1878 | + } |
|
1784 | 1879 | // Only if we didn't already load that part of the cache... |
1785 | - elseif (!isset($temp)) |
|
1786 | - cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90); |
|
1880 | + elseif (!isset($temp)) { |
|
1881 | + cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90); |
|
1882 | + } |
|
1787 | 1883 | } |
1788 | 1884 | |
1789 | 1885 | $settings = $themeData[0]; |
@@ -1800,22 +1896,26 @@ discard block |
||
1800 | 1896 | $settings['template_dirs'][] = $settings['theme_dir']; |
1801 | 1897 | |
1802 | 1898 | // Based on theme (if there is one). |
1803 | - if (!empty($settings['base_theme_dir'])) |
|
1804 | - $settings['template_dirs'][] = $settings['base_theme_dir']; |
|
1899 | + if (!empty($settings['base_theme_dir'])) { |
|
1900 | + $settings['template_dirs'][] = $settings['base_theme_dir']; |
|
1901 | + } |
|
1805 | 1902 | |
1806 | 1903 | // Lastly the default theme. |
1807 | - if ($settings['theme_dir'] != $settings['default_theme_dir']) |
|
1808 | - $settings['template_dirs'][] = $settings['default_theme_dir']; |
|
1904 | + if ($settings['theme_dir'] != $settings['default_theme_dir']) { |
|
1905 | + $settings['template_dirs'][] = $settings['default_theme_dir']; |
|
1906 | + } |
|
1809 | 1907 | } |
1810 | 1908 | |
1811 | 1909 | |
1812 | - if (!$initialize) |
|
1813 | - return; |
|
1910 | + if (!$initialize) { |
|
1911 | + return; |
|
1912 | + } |
|
1814 | 1913 | |
1815 | 1914 | // Check to see if we're forcing SSL |
1816 | 1915 | if (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 && empty($maintenance) && |
1817 | - (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') |
|
1818 | - redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://'))); |
|
1916 | + (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') { |
|
1917 | + redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://'))); |
|
1918 | + } |
|
1819 | 1919 | |
1820 | 1920 | // Check to see if they're accessing it from the wrong place. |
1821 | 1921 | if (isset($_SERVER['HTTP_HOST']) || isset($_SERVER['SERVER_NAME'])) |
@@ -1823,8 +1923,9 @@ discard block |
||
1823 | 1923 | $detected_url = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on' ? 'https://' : 'http://'; |
1824 | 1924 | $detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST']; |
1825 | 1925 | $temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/')); |
1826 | - if ($temp != '/') |
|
1827 | - $detected_url .= $temp; |
|
1926 | + if ($temp != '/') { |
|
1927 | + $detected_url .= $temp; |
|
1928 | + } |
|
1828 | 1929 | } |
1829 | 1930 | if (isset($detected_url) && $detected_url != $boardurl) |
1830 | 1931 | { |
@@ -1836,8 +1937,9 @@ discard block |
||
1836 | 1937 | foreach ($aliases as $alias) |
1837 | 1938 | { |
1838 | 1939 | // Rip off all the boring parts, spaces, etc. |
1839 | - if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) |
|
1840 | - $do_fix = true; |
|
1940 | + if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) { |
|
1941 | + $do_fix = true; |
|
1942 | + } |
|
1841 | 1943 | } |
1842 | 1944 | } |
1843 | 1945 | |
@@ -1845,20 +1947,22 @@ discard block |
||
1845 | 1947 | if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI') |
1846 | 1948 | { |
1847 | 1949 | // Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;). |
1848 | - if (empty($_GET)) |
|
1849 | - redirectexit('wwwRedirect'); |
|
1850 | - else |
|
1950 | + if (empty($_GET)) { |
|
1951 | + redirectexit('wwwRedirect'); |
|
1952 | + } else |
|
1851 | 1953 | { |
1852 | 1954 | list ($k, $v) = each($_GET); |
1853 | 1955 | |
1854 | - if ($k != 'wwwRedirect') |
|
1855 | - redirectexit('wwwRedirect;' . $k . '=' . $v); |
|
1956 | + if ($k != 'wwwRedirect') { |
|
1957 | + redirectexit('wwwRedirect;' . $k . '=' . $v); |
|
1958 | + } |
|
1856 | 1959 | } |
1857 | 1960 | } |
1858 | 1961 | |
1859 | 1962 | // #3 is just a check for SSL... |
1860 | - if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) |
|
1861 | - $do_fix = true; |
|
1963 | + if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) { |
|
1964 | + $do_fix = true; |
|
1965 | + } |
|
1862 | 1966 | |
1863 | 1967 | // Okay, #4 - perhaps it's an IP address? We're gonna want to use that one, then. (assuming it's the IP or something...) |
1864 | 1968 | if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1) |
@@ -1892,8 +1996,9 @@ discard block |
||
1892 | 1996 | $board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl)); |
1893 | 1997 | } |
1894 | 1998 | } |
1895 | - foreach ($context['linktree'] as $k => $dummy) |
|
1896 | - $context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl)); |
|
1999 | + foreach ($context['linktree'] as $k => $dummy) { |
|
2000 | + $context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl)); |
|
2001 | + } |
|
1897 | 2002 | } |
1898 | 2003 | } |
1899 | 2004 | // Set up the contextual user array. |
@@ -1912,16 +2017,16 @@ discard block |
||
1912 | 2017 | 'email' => $user_info['email'], |
1913 | 2018 | 'ignoreusers' => $user_info['ignoreusers'], |
1914 | 2019 | ); |
1915 | - if (!$context['user']['is_guest']) |
|
1916 | - $context['user']['name'] = $user_info['name']; |
|
1917 | - elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) |
|
1918 | - $context['user']['name'] = $txt['guest_title']; |
|
2020 | + if (!$context['user']['is_guest']) { |
|
2021 | + $context['user']['name'] = $user_info['name']; |
|
2022 | + } elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) { |
|
2023 | + $context['user']['name'] = $txt['guest_title']; |
|
2024 | + } |
|
1919 | 2025 | |
1920 | 2026 | // Determine the current smiley set. |
1921 | 2027 | $user_info['smiley_set'] = (!in_array($user_info['smiley_set'], explode(',', $modSettings['smiley_sets_known'])) && $user_info['smiley_set'] != 'none') || empty($modSettings['smiley_sets_enable']) ? (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default']) : $user_info['smiley_set']; |
1922 | 2028 | $context['user']['smiley_set'] = $user_info['smiley_set']; |
1923 | - } |
|
1924 | - else |
|
2029 | + } else |
|
1925 | 2030 | { |
1926 | 2031 | // What to do when there is no $user_info (e.g., an error very early in the login process) |
1927 | 2032 | $context['user'] = array( |
@@ -1955,18 +2060,24 @@ discard block |
||
1955 | 2060 | } |
1956 | 2061 | |
1957 | 2062 | // Some basic information... |
1958 | - if (!isset($context['html_headers'])) |
|
1959 | - $context['html_headers'] = ''; |
|
1960 | - if (!isset($context['javascript_files'])) |
|
1961 | - $context['javascript_files'] = array(); |
|
1962 | - if (!isset($context['css_files'])) |
|
1963 | - $context['css_files'] = array(); |
|
1964 | - if (!isset($context['css_header'])) |
|
1965 | - $context['css_header'] = array(); |
|
1966 | - if (!isset($context['javascript_inline'])) |
|
1967 | - $context['javascript_inline'] = array('standard' => array(), 'defer' => array()); |
|
1968 | - if (!isset($context['javascript_vars'])) |
|
1969 | - $context['javascript_vars'] = array(); |
|
2063 | + if (!isset($context['html_headers'])) { |
|
2064 | + $context['html_headers'] = ''; |
|
2065 | + } |
|
2066 | + if (!isset($context['javascript_files'])) { |
|
2067 | + $context['javascript_files'] = array(); |
|
2068 | + } |
|
2069 | + if (!isset($context['css_files'])) { |
|
2070 | + $context['css_files'] = array(); |
|
2071 | + } |
|
2072 | + if (!isset($context['css_header'])) { |
|
2073 | + $context['css_header'] = array(); |
|
2074 | + } |
|
2075 | + if (!isset($context['javascript_inline'])) { |
|
2076 | + $context['javascript_inline'] = array('standard' => array(), 'defer' => array()); |
|
2077 | + } |
|
2078 | + if (!isset($context['javascript_vars'])) { |
|
2079 | + $context['javascript_vars'] = array(); |
|
2080 | + } |
|
1970 | 2081 | |
1971 | 2082 | $context['login_url'] = (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl) . '?action=login2'; |
1972 | 2083 | $context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | '; |
@@ -1978,16 +2089,18 @@ discard block |
||
1978 | 2089 | $context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null; |
1979 | 2090 | $context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null; |
1980 | 2091 | $context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3; |
1981 | - if (isset($modSettings['load_average'])) |
|
1982 | - $context['load_average'] = $modSettings['load_average']; |
|
2092 | + if (isset($modSettings['load_average'])) { |
|
2093 | + $context['load_average'] = $modSettings['load_average']; |
|
2094 | + } |
|
1983 | 2095 | |
1984 | 2096 | // Detect the browser. This is separated out because it's also used in attachment downloads |
1985 | 2097 | detectBrowser(); |
1986 | 2098 | |
1987 | 2099 | // Set the top level linktree up. |
1988 | 2100 | // Note that if we're dealing with certain very early errors (e.g., login) the linktree might not be set yet... |
1989 | - if (empty($context['linktree'])) |
|
1990 | - $context['linktree'] = array(); |
|
2101 | + if (empty($context['linktree'])) { |
|
2102 | + $context['linktree'] = array(); |
|
2103 | + } |
|
1991 | 2104 | array_unshift($context['linktree'], array( |
1992 | 2105 | 'url' => $scripturl, |
1993 | 2106 | 'name' => $context['forum_name_html_safe'] |
@@ -1996,8 +2109,9 @@ discard block |
||
1996 | 2109 | // This allows sticking some HTML on the page output - useful for controls. |
1997 | 2110 | $context['insert_after_template'] = ''; |
1998 | 2111 | |
1999 | - if (!isset($txt)) |
|
2000 | - $txt = array(); |
|
2112 | + if (!isset($txt)) { |
|
2113 | + $txt = array(); |
|
2114 | + } |
|
2001 | 2115 | |
2002 | 2116 | $simpleActions = array( |
2003 | 2117 | 'findmember', |
@@ -2043,9 +2157,10 @@ discard block |
||
2043 | 2157 | |
2044 | 2158 | // See if theres any extra param to check. |
2045 | 2159 | $requiresXML = false; |
2046 | - foreach ($extraParams as $key => $extra) |
|
2047 | - if (isset($_REQUEST[$extra])) |
|
2160 | + foreach ($extraParams as $key => $extra) { |
|
2161 | + if (isset($_REQUEST[$extra])) |
|
2048 | 2162 | $requiresXML = true; |
2163 | + } |
|
2049 | 2164 | |
2050 | 2165 | // Output is fully XML, so no need for the index template. |
2051 | 2166 | if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML)) |
@@ -2060,37 +2175,39 @@ discard block |
||
2060 | 2175 | { |
2061 | 2176 | loadLanguage('index+Modifications'); |
2062 | 2177 | $context['template_layers'] = array(); |
2063 | - } |
|
2064 | - |
|
2065 | - else |
|
2178 | + } else |
|
2066 | 2179 | { |
2067 | 2180 | // Custom templates to load, or just default? |
2068 | - if (isset($settings['theme_templates'])) |
|
2069 | - $templates = explode(',', $settings['theme_templates']); |
|
2070 | - else |
|
2071 | - $templates = array('index'); |
|
2181 | + if (isset($settings['theme_templates'])) { |
|
2182 | + $templates = explode(',', $settings['theme_templates']); |
|
2183 | + } else { |
|
2184 | + $templates = array('index'); |
|
2185 | + } |
|
2072 | 2186 | |
2073 | 2187 | // Load each template... |
2074 | - foreach ($templates as $template) |
|
2075 | - loadTemplate($template); |
|
2188 | + foreach ($templates as $template) { |
|
2189 | + loadTemplate($template); |
|
2190 | + } |
|
2076 | 2191 | |
2077 | 2192 | // ...and attempt to load their associated language files. |
2078 | 2193 | $required_files = implode('+', array_merge($templates, array('Modifications'))); |
2079 | 2194 | loadLanguage($required_files, '', false); |
2080 | 2195 | |
2081 | 2196 | // Custom template layers? |
2082 | - if (isset($settings['theme_layers'])) |
|
2083 | - $context['template_layers'] = explode(',', $settings['theme_layers']); |
|
2084 | - else |
|
2085 | - $context['template_layers'] = array('html', 'body'); |
|
2197 | + if (isset($settings['theme_layers'])) { |
|
2198 | + $context['template_layers'] = explode(',', $settings['theme_layers']); |
|
2199 | + } else { |
|
2200 | + $context['template_layers'] = array('html', 'body'); |
|
2201 | + } |
|
2086 | 2202 | } |
2087 | 2203 | |
2088 | 2204 | // Initialize the theme. |
2089 | 2205 | loadSubTemplate('init', 'ignore'); |
2090 | 2206 | |
2091 | 2207 | // Allow overriding the board wide time/number formats. |
2092 | - if (empty($user_settings['time_format']) && !empty($txt['time_format'])) |
|
2093 | - $user_info['time_format'] = $txt['time_format']; |
|
2208 | + if (empty($user_settings['time_format']) && !empty($txt['time_format'])) { |
|
2209 | + $user_info['time_format'] = $txt['time_format']; |
|
2210 | + } |
|
2094 | 2211 | |
2095 | 2212 | // Set the character set from the template. |
2096 | 2213 | $context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']; |
@@ -2098,12 +2215,14 @@ discard block |
||
2098 | 2215 | $context['right_to_left'] = !empty($txt['lang_rtl']); |
2099 | 2216 | |
2100 | 2217 | // Guests may still need a name. |
2101 | - if ($context['user']['is_guest'] && empty($context['user']['name'])) |
|
2102 | - $context['user']['name'] = $txt['guest_title']; |
|
2218 | + if ($context['user']['is_guest'] && empty($context['user']['name'])) { |
|
2219 | + $context['user']['name'] = $txt['guest_title']; |
|
2220 | + } |
|
2103 | 2221 | |
2104 | 2222 | // Any theme-related strings that need to be loaded? |
2105 | - if (!empty($settings['require_theme_strings'])) |
|
2106 | - loadLanguage('ThemeStrings', '', false); |
|
2223 | + if (!empty($settings['require_theme_strings'])) { |
|
2224 | + loadLanguage('ThemeStrings', '', false); |
|
2225 | + } |
|
2107 | 2226 | |
2108 | 2227 | // Make a special URL for the language. |
2109 | 2228 | $settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']); |
@@ -2114,8 +2233,9 @@ discard block |
||
2114 | 2233 | // Here is my luvly Responsive CSS |
2115 | 2234 | loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true), 'smf_responsive'); |
2116 | 2235 | |
2117 | - if ($context['right_to_left']) |
|
2118 | - loadCSSFile('rtl.css', array(), 'smf_rtl'); |
|
2236 | + if ($context['right_to_left']) { |
|
2237 | + loadCSSFile('rtl.css', array(), 'smf_rtl'); |
|
2238 | + } |
|
2119 | 2239 | |
2120 | 2240 | // We allow theme variants, because we're cool. |
2121 | 2241 | $context['theme_variant'] = ''; |
@@ -2123,14 +2243,17 @@ discard block |
||
2123 | 2243 | if (!empty($settings['theme_variants'])) |
2124 | 2244 | { |
2125 | 2245 | // Overriding - for previews and that ilk. |
2126 | - if (!empty($_REQUEST['variant'])) |
|
2127 | - $_SESSION['id_variant'] = $_REQUEST['variant']; |
|
2246 | + if (!empty($_REQUEST['variant'])) { |
|
2247 | + $_SESSION['id_variant'] = $_REQUEST['variant']; |
|
2248 | + } |
|
2128 | 2249 | // User selection? |
2129 | - if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) |
|
2130 | - $context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : ''); |
|
2250 | + if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) { |
|
2251 | + $context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : ''); |
|
2252 | + } |
|
2131 | 2253 | // If not a user variant, select the default. |
2132 | - if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) |
|
2133 | - $context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0]; |
|
2254 | + if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) { |
|
2255 | + $context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0]; |
|
2256 | + } |
|
2134 | 2257 | |
2135 | 2258 | // Do this to keep things easier in the templates. |
2136 | 2259 | $context['theme_variant'] = '_' . $context['theme_variant']; |
@@ -2139,20 +2262,23 @@ discard block |
||
2139 | 2262 | if (!empty($context['theme_variant'])) |
2140 | 2263 | { |
2141 | 2264 | loadCSSFile('index' . $context['theme_variant'] . '.css', array(), 'smf_index' . $context['theme_variant']); |
2142 | - if ($context['right_to_left']) |
|
2143 | - loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']); |
|
2265 | + if ($context['right_to_left']) { |
|
2266 | + loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']); |
|
2267 | + } |
|
2144 | 2268 | } |
2145 | 2269 | } |
2146 | 2270 | |
2147 | 2271 | // Let's be compatible with old themes! |
2148 | - if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) |
|
2149 | - $context['template_layers'] = array('main'); |
|
2272 | + if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) { |
|
2273 | + $context['template_layers'] = array('main'); |
|
2274 | + } |
|
2150 | 2275 | |
2151 | 2276 | $context['tabindex'] = 1; |
2152 | 2277 | |
2153 | 2278 | // Compatibility. |
2154 | - if (!isset($settings['theme_version'])) |
|
2155 | - $modSettings['memberCount'] = $modSettings['totalMembers']; |
|
2279 | + if (!isset($settings['theme_version'])) { |
|
2280 | + $modSettings['memberCount'] = $modSettings['totalMembers']; |
|
2281 | + } |
|
2156 | 2282 | |
2157 | 2283 | // Default JS variables for use in every theme |
2158 | 2284 | $context['javascript_vars'] = array( |
@@ -2171,18 +2297,18 @@ discard block |
||
2171 | 2297 | ); |
2172 | 2298 | |
2173 | 2299 | // Add the JQuery library to the list of files to load. |
2174 | - if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') |
|
2175 | - loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2176 | - |
|
2177 | - elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') |
|
2178 | - loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery'); |
|
2179 | - |
|
2180 | - elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') |
|
2181 | - loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery'); |
|
2300 | + if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') { |
|
2301 | + loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2302 | + } elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') { |
|
2303 | + loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery'); |
|
2304 | + } elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') { |
|
2305 | + loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery'); |
|
2306 | + } |
|
2182 | 2307 | |
2183 | 2308 | // Auto loading? template_javascript() will take care of the local half of this. |
2184 | - else |
|
2185 | - loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2309 | + else { |
|
2310 | + loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
2311 | + } |
|
2186 | 2312 | |
2187 | 2313 | // Queue our JQuery plugins! |
2188 | 2314 | loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins'); |
@@ -2205,12 +2331,12 @@ discard block |
||
2205 | 2331 | require_once($sourcedir . '/ScheduledTasks.php'); |
2206 | 2332 | |
2207 | 2333 | // What to do, what to do?! |
2208 | - if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) |
|
2209 | - AutoTask(); |
|
2210 | - else |
|
2211 | - ReduceMailQueue(); |
|
2212 | - } |
|
2213 | - else |
|
2334 | + if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) { |
|
2335 | + AutoTask(); |
|
2336 | + } else { |
|
2337 | + ReduceMailQueue(); |
|
2338 | + } |
|
2339 | + } else |
|
2214 | 2340 | { |
2215 | 2341 | $type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq'; |
2216 | 2342 | $ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time']; |
@@ -2261,8 +2387,9 @@ discard block |
||
2261 | 2387 | foreach ($theme_includes as $include) |
2262 | 2388 | { |
2263 | 2389 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
2264 | - if (file_exists($include)) |
|
2265 | - require_once($include); |
|
2390 | + if (file_exists($include)) { |
|
2391 | + require_once($include); |
|
2392 | + } |
|
2266 | 2393 | } |
2267 | 2394 | } |
2268 | 2395 | |
@@ -2292,16 +2419,19 @@ discard block |
||
2292 | 2419 | // Do any style sheets first, cause we're easy with those. |
2293 | 2420 | if (!empty($style_sheets)) |
2294 | 2421 | { |
2295 | - if (!is_array($style_sheets)) |
|
2296 | - $style_sheets = array($style_sheets); |
|
2422 | + if (!is_array($style_sheets)) { |
|
2423 | + $style_sheets = array($style_sheets); |
|
2424 | + } |
|
2297 | 2425 | |
2298 | - foreach ($style_sheets as $sheet) |
|
2299 | - loadCSSFile($sheet . '.css', array(), $sheet); |
|
2426 | + foreach ($style_sheets as $sheet) { |
|
2427 | + loadCSSFile($sheet . '.css', array(), $sheet); |
|
2428 | + } |
|
2300 | 2429 | } |
2301 | 2430 | |
2302 | 2431 | // No template to load? |
2303 | - if ($template_name === false) |
|
2304 | - return true; |
|
2432 | + if ($template_name === false) { |
|
2433 | + return true; |
|
2434 | + } |
|
2305 | 2435 | |
2306 | 2436 | $loaded = false; |
2307 | 2437 | foreach ($settings['template_dirs'] as $template_dir) |
@@ -2316,12 +2446,14 @@ discard block |
||
2316 | 2446 | |
2317 | 2447 | if ($loaded) |
2318 | 2448 | { |
2319 | - if ($db_show_debug === true) |
|
2320 | - $context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')'; |
|
2449 | + if ($db_show_debug === true) { |
|
2450 | + $context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')'; |
|
2451 | + } |
|
2321 | 2452 | |
2322 | 2453 | // If they have specified an initialization function for this template, go ahead and call it now. |
2323 | - if (function_exists('template_' . $template_name . '_init')) |
|
2324 | - call_user_func('template_' . $template_name . '_init'); |
|
2454 | + if (function_exists('template_' . $template_name . '_init')) { |
|
2455 | + call_user_func('template_' . $template_name . '_init'); |
|
2456 | + } |
|
2325 | 2457 | } |
2326 | 2458 | // Hmmm... doesn't exist?! I don't suppose the directory is wrong, is it? |
2327 | 2459 | elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default')) |
@@ -2341,13 +2473,14 @@ discard block |
||
2341 | 2473 | loadTemplate($template_name); |
2342 | 2474 | } |
2343 | 2475 | // Cause an error otherwise. |
2344 | - elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) |
|
2345 | - fatal_lang_error('theme_template_error', 'template', array((string) $template_name)); |
|
2346 | - elseif ($fatal) |
|
2347 | - die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template')); |
|
2348 | - else |
|
2349 | - return false; |
|
2350 | -} |
|
2476 | + elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) { |
|
2477 | + fatal_lang_error('theme_template_error', 'template', array((string) $template_name)); |
|
2478 | + } elseif ($fatal) { |
|
2479 | + die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template')); |
|
2480 | + } else { |
|
2481 | + return false; |
|
2482 | + } |
|
2483 | + } |
|
2351 | 2484 | |
2352 | 2485 | /** |
2353 | 2486 | * Load a sub-template. |
@@ -2365,17 +2498,19 @@ discard block |
||
2365 | 2498 | { |
2366 | 2499 | global $context, $txt, $db_show_debug; |
2367 | 2500 | |
2368 | - if ($db_show_debug === true) |
|
2369 | - $context['debug']['sub_templates'][] = $sub_template_name; |
|
2501 | + if ($db_show_debug === true) { |
|
2502 | + $context['debug']['sub_templates'][] = $sub_template_name; |
|
2503 | + } |
|
2370 | 2504 | |
2371 | 2505 | // Figure out what the template function is named. |
2372 | 2506 | $theme_function = 'template_' . $sub_template_name; |
2373 | - if (function_exists($theme_function)) |
|
2374 | - $theme_function(); |
|
2375 | - elseif ($fatal === false) |
|
2376 | - fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name)); |
|
2377 | - elseif ($fatal !== 'ignore') |
|
2378 | - die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template')); |
|
2507 | + if (function_exists($theme_function)) { |
|
2508 | + $theme_function(); |
|
2509 | + } elseif ($fatal === false) { |
|
2510 | + fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name)); |
|
2511 | + } elseif ($fatal !== 'ignore') { |
|
2512 | + die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template')); |
|
2513 | + } |
|
2379 | 2514 | |
2380 | 2515 | // Are we showing debugging for templates? Just make sure not to do it before the doctype... |
2381 | 2516 | if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml'])) |
@@ -2412,8 +2547,9 @@ discard block |
||
2412 | 2547 | $params['validate'] = isset($params['validate']) ? $params['validate'] : true; |
2413 | 2548 | |
2414 | 2549 | // If this is an external file, automatically set this to false. |
2415 | - if (!empty($params['external'])) |
|
2416 | - $params['minimize'] = false; |
|
2550 | + if (!empty($params['external'])) { |
|
2551 | + $params['minimize'] = false; |
|
2552 | + } |
|
2417 | 2553 | |
2418 | 2554 | // Account for shorthand like admin.css?alp21 filenames |
2419 | 2555 | $has_seed = strpos($fileName, '.css?'); |
@@ -2430,13 +2566,10 @@ discard block |
||
2430 | 2566 | { |
2431 | 2567 | $fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
2432 | 2568 | $filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
2569 | + } else { |
|
2570 | + $fileUrl = false; |
|
2433 | 2571 | } |
2434 | - |
|
2435 | - else |
|
2436 | - $fileUrl = false; |
|
2437 | - } |
|
2438 | - |
|
2439 | - else |
|
2572 | + } else |
|
2440 | 2573 | { |
2441 | 2574 | $fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
2442 | 2575 | $filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
@@ -2451,12 +2584,14 @@ discard block |
||
2451 | 2584 | } |
2452 | 2585 | |
2453 | 2586 | // Add it to the array for use in the template |
2454 | - if (!empty($fileName)) |
|
2455 | - $context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2587 | + if (!empty($fileName)) { |
|
2588 | + $context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2589 | + } |
|
2456 | 2590 | |
2457 | - if (!empty($context['right_to_left']) && !empty($params['rtl'])) |
|
2458 | - loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0))); |
|
2459 | -} |
|
2591 | + if (!empty($context['right_to_left']) && !empty($params['rtl'])) { |
|
2592 | + loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0))); |
|
2593 | + } |
|
2594 | + } |
|
2460 | 2595 | |
2461 | 2596 | /** |
2462 | 2597 | * Add a block of inline css code to be executed later |
@@ -2473,8 +2608,9 @@ discard block |
||
2473 | 2608 | global $context; |
2474 | 2609 | |
2475 | 2610 | // Gotta add something... |
2476 | - if (empty($css)) |
|
2477 | - return false; |
|
2611 | + if (empty($css)) { |
|
2612 | + return false; |
|
2613 | + } |
|
2478 | 2614 | |
2479 | 2615 | $context['css_header'][] = $css; |
2480 | 2616 | } |
@@ -2509,8 +2645,9 @@ discard block |
||
2509 | 2645 | $params['validate'] = isset($params['validate']) ? $params['validate'] : true; |
2510 | 2646 | |
2511 | 2647 | // If this is an external file, automatically set this to false. |
2512 | - if (!empty($params['external'])) |
|
2513 | - $params['minimize'] = false; |
|
2648 | + if (!empty($params['external'])) { |
|
2649 | + $params['minimize'] = false; |
|
2650 | + } |
|
2514 | 2651 | |
2515 | 2652 | // Account for shorthand like admin.js?alp21 filenames |
2516 | 2653 | $has_seed = strpos($fileName, '.js?'); |
@@ -2527,16 +2664,12 @@ discard block |
||
2527 | 2664 | { |
2528 | 2665 | $fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
2529 | 2666 | $filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
2530 | - } |
|
2531 | - |
|
2532 | - else |
|
2667 | + } else |
|
2533 | 2668 | { |
2534 | 2669 | $fileUrl = false; |
2535 | 2670 | $filePath = false; |
2536 | 2671 | } |
2537 | - } |
|
2538 | - |
|
2539 | - else |
|
2672 | + } else |
|
2540 | 2673 | { |
2541 | 2674 | $fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
2542 | 2675 | $filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
@@ -2551,9 +2684,10 @@ discard block |
||
2551 | 2684 | } |
2552 | 2685 | |
2553 | 2686 | // Add it to the array for use in the template |
2554 | - if (!empty($fileName)) |
|
2555 | - $context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2556 | -} |
|
2687 | + if (!empty($fileName)) { |
|
2688 | + $context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
2689 | + } |
|
2690 | + } |
|
2557 | 2691 | |
2558 | 2692 | /** |
2559 | 2693 | * Add a Javascript variable for output later (for feeding text strings and similar to JS) |
@@ -2567,9 +2701,10 @@ discard block |
||
2567 | 2701 | { |
2568 | 2702 | global $context; |
2569 | 2703 | |
2570 | - if (!empty($key) && (!empty($value) || $value === '0')) |
|
2571 | - $context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value; |
|
2572 | -} |
|
2704 | + if (!empty($key) && (!empty($value) || $value === '0')) { |
|
2705 | + $context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value; |
|
2706 | + } |
|
2707 | + } |
|
2573 | 2708 | |
2574 | 2709 | /** |
2575 | 2710 | * Add a block of inline Javascript code to be executed later |
@@ -2586,8 +2721,9 @@ discard block |
||
2586 | 2721 | { |
2587 | 2722 | global $context; |
2588 | 2723 | |
2589 | - if (empty($javascript)) |
|
2590 | - return false; |
|
2724 | + if (empty($javascript)) { |
|
2725 | + return false; |
|
2726 | + } |
|
2591 | 2727 | |
2592 | 2728 | $context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript; |
2593 | 2729 | } |
@@ -2608,15 +2744,18 @@ discard block |
||
2608 | 2744 | static $already_loaded = array(); |
2609 | 2745 | |
2610 | 2746 | // Default to the user's language. |
2611 | - if ($lang == '') |
|
2612 | - $lang = isset($user_info['language']) ? $user_info['language'] : $language; |
|
2747 | + if ($lang == '') { |
|
2748 | + $lang = isset($user_info['language']) ? $user_info['language'] : $language; |
|
2749 | + } |
|
2613 | 2750 | |
2614 | 2751 | // Do we want the English version of language file as fallback? |
2615 | - if (empty($modSettings['disable_language_fallback']) && $lang != 'english') |
|
2616 | - loadLanguage($template_name, 'english', false); |
|
2752 | + if (empty($modSettings['disable_language_fallback']) && $lang != 'english') { |
|
2753 | + loadLanguage($template_name, 'english', false); |
|
2754 | + } |
|
2617 | 2755 | |
2618 | - if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) |
|
2619 | - return $lang; |
|
2756 | + if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) { |
|
2757 | + return $lang; |
|
2758 | + } |
|
2620 | 2759 | |
2621 | 2760 | // Make sure we have $settings - if not we're in trouble and need to find it! |
2622 | 2761 | if (empty($settings['default_theme_dir'])) |
@@ -2627,8 +2766,9 @@ discard block |
||
2627 | 2766 | |
2628 | 2767 | // What theme are we in? |
2629 | 2768 | $theme_name = basename($settings['theme_url']); |
2630 | - if (empty($theme_name)) |
|
2631 | - $theme_name = 'unknown'; |
|
2769 | + if (empty($theme_name)) { |
|
2770 | + $theme_name = 'unknown'; |
|
2771 | + } |
|
2632 | 2772 | |
2633 | 2773 | // For each file open it up and write it out! |
2634 | 2774 | foreach (explode('+', $template_name) as $template) |
@@ -2670,8 +2810,9 @@ discard block |
||
2670 | 2810 | $found = true; |
2671 | 2811 | |
2672 | 2812 | // setlocale is required for basename() & pathinfo() to work properly on the selected language |
2673 | - if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) |
|
2674 | - setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']); |
|
2813 | + if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) { |
|
2814 | + setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']); |
|
2815 | + } |
|
2675 | 2816 | |
2676 | 2817 | break; |
2677 | 2818 | } |
@@ -2711,8 +2852,9 @@ discard block |
||
2711 | 2852 | } |
2712 | 2853 | |
2713 | 2854 | // Keep track of what we're up to soldier. |
2714 | - if ($db_show_debug === true) |
|
2715 | - $context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')'; |
|
2855 | + if ($db_show_debug === true) { |
|
2856 | + $context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')'; |
|
2857 | + } |
|
2716 | 2858 | |
2717 | 2859 | // Remember what we have loaded, and in which language. |
2718 | 2860 | $already_loaded[$template_name] = $lang; |
@@ -2758,8 +2900,9 @@ discard block |
||
2758 | 2900 | ) |
2759 | 2901 | ); |
2760 | 2902 | // In the EXTREMELY unlikely event this happens, give an error message. |
2761 | - if ($smcFunc['db_num_rows']($result) == 0) |
|
2762 | - fatal_lang_error('parent_not_found', 'critical'); |
|
2903 | + if ($smcFunc['db_num_rows']($result) == 0) { |
|
2904 | + fatal_lang_error('parent_not_found', 'critical'); |
|
2905 | + } |
|
2763 | 2906 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
2764 | 2907 | { |
2765 | 2908 | if (!isset($boards[$row['id_board']])) |
@@ -2776,8 +2919,8 @@ discard block |
||
2776 | 2919 | ); |
2777 | 2920 | } |
2778 | 2921 | // If a moderator exists for this board, add that moderator for all children too. |
2779 | - if (!empty($row['id_moderator'])) |
|
2780 | - foreach ($boards as $id => $dummy) |
|
2922 | + if (!empty($row['id_moderator'])) { |
|
2923 | + foreach ($boards as $id => $dummy) |
|
2781 | 2924 | { |
2782 | 2925 | $boards[$id]['moderators'][$row['id_moderator']] = array( |
2783 | 2926 | 'id' => $row['id_moderator'], |
@@ -2785,11 +2928,12 @@ discard block |
||
2785 | 2928 | 'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'], |
2786 | 2929 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>' |
2787 | 2930 | ); |
2931 | + } |
|
2788 | 2932 | } |
2789 | 2933 | |
2790 | 2934 | // If a moderator group exists for this board, add that moderator group for all children too |
2791 | - if (!empty($row['id_moderator_group'])) |
|
2792 | - foreach ($boards as $id => $dummy) |
|
2935 | + if (!empty($row['id_moderator_group'])) { |
|
2936 | + foreach ($boards as $id => $dummy) |
|
2793 | 2937 | { |
2794 | 2938 | $boards[$id]['moderator_groups'][$row['id_moderator_group']] = array( |
2795 | 2939 | 'id' => $row['id_moderator_group'], |
@@ -2797,6 +2941,7 @@ discard block |
||
2797 | 2941 | 'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'], |
2798 | 2942 | 'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>' |
2799 | 2943 | ); |
2944 | + } |
|
2800 | 2945 | } |
2801 | 2946 | } |
2802 | 2947 | $smcFunc['db_free_result']($result); |
@@ -2823,23 +2968,27 @@ discard block |
||
2823 | 2968 | if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null) |
2824 | 2969 | { |
2825 | 2970 | // If we don't have our ucwords function defined yet, let's load the settings data. |
2826 | - if (empty($smcFunc['ucwords'])) |
|
2827 | - reloadSettings(); |
|
2971 | + if (empty($smcFunc['ucwords'])) { |
|
2972 | + reloadSettings(); |
|
2973 | + } |
|
2828 | 2974 | |
2829 | 2975 | // If we don't have our theme information yet, let's get it. |
2830 | - if (empty($settings['default_theme_dir'])) |
|
2831 | - loadTheme(0, false); |
|
2976 | + if (empty($settings['default_theme_dir'])) { |
|
2977 | + loadTheme(0, false); |
|
2978 | + } |
|
2832 | 2979 | |
2833 | 2980 | // Default language directories to try. |
2834 | 2981 | $language_directories = array( |
2835 | 2982 | $settings['default_theme_dir'] . '/languages', |
2836 | 2983 | ); |
2837 | - if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) |
|
2838 | - $language_directories[] = $settings['actual_theme_dir'] . '/languages'; |
|
2984 | + if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) { |
|
2985 | + $language_directories[] = $settings['actual_theme_dir'] . '/languages'; |
|
2986 | + } |
|
2839 | 2987 | |
2840 | 2988 | // We possibly have a base theme directory. |
2841 | - if (!empty($settings['base_theme_dir'])) |
|
2842 | - $language_directories[] = $settings['base_theme_dir'] . '/languages'; |
|
2989 | + if (!empty($settings['base_theme_dir'])) { |
|
2990 | + $language_directories[] = $settings['base_theme_dir'] . '/languages'; |
|
2991 | + } |
|
2843 | 2992 | |
2844 | 2993 | // Remove any duplicates. |
2845 | 2994 | $language_directories = array_unique($language_directories); |
@@ -2853,20 +3002,21 @@ discard block |
||
2853 | 3002 | foreach ($language_directories as $language_dir) |
2854 | 3003 | { |
2855 | 3004 | // Can't look in here... doesn't exist! |
2856 | - if (!file_exists($language_dir)) |
|
2857 | - continue; |
|
3005 | + if (!file_exists($language_dir)) { |
|
3006 | + continue; |
|
3007 | + } |
|
2858 | 3008 | |
2859 | 3009 | $dir = dir($language_dir); |
2860 | 3010 | while ($entry = $dir->read()) |
2861 | 3011 | { |
2862 | 3012 | // Look for the index language file... For good measure skip any "index.language-utf8.php" files |
2863 | - if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) |
|
2864 | - continue; |
|
2865 | - |
|
2866 | - if (!empty($langList) && !empty($langList[$matches[1]])) |
|
2867 | - $langName = $langList[$matches[1]]; |
|
3013 | + if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) { |
|
3014 | + continue; |
|
3015 | + } |
|
2868 | 3016 | |
2869 | - else |
|
3017 | + if (!empty($langList) && !empty($langList[$matches[1]])) { |
|
3018 | + $langName = $langList[$matches[1]]; |
|
3019 | + } else |
|
2870 | 3020 | { |
2871 | 3021 | $langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' '))); |
2872 | 3022 | |
@@ -2907,12 +3057,14 @@ discard block |
||
2907 | 3057 | } |
2908 | 3058 | |
2909 | 3059 | // Do we need to store the lang list? |
2910 | - if (empty($langList)) |
|
2911 | - updateSettings(array('langList' => $smcFunc['json_encode']($catchLang))); |
|
3060 | + if (empty($langList)) { |
|
3061 | + updateSettings(array('langList' => $smcFunc['json_encode']($catchLang))); |
|
3062 | + } |
|
2912 | 3063 | |
2913 | 3064 | // Let's cash in on this deal. |
2914 | - if (!empty($modSettings['cache_enable'])) |
|
2915 | - cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600); |
|
3065 | + if (!empty($modSettings['cache_enable'])) { |
|
3066 | + cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600); |
|
3067 | + } |
|
2916 | 3068 | } |
2917 | 3069 | |
2918 | 3070 | return $context['languages']; |
@@ -2935,8 +3087,9 @@ discard block |
||
2935 | 3087 | global $modSettings, $options, $txt; |
2936 | 3088 | static $censor_vulgar = null, $censor_proper; |
2937 | 3089 | |
2938 | - if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') |
|
2939 | - return $text; |
|
3090 | + if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') { |
|
3091 | + return $text; |
|
3092 | + } |
|
2940 | 3093 | |
2941 | 3094 | // If they haven't yet been loaded, load them. |
2942 | 3095 | if ($censor_vulgar == null) |
@@ -2964,9 +3117,9 @@ discard block |
||
2964 | 3117 | { |
2965 | 3118 | $func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace'; |
2966 | 3119 | $text = $func($censor_vulgar, $censor_proper, $text); |
3120 | + } else { |
|
3121 | + $text = preg_replace($censor_vulgar, $censor_proper, $text); |
|
2967 | 3122 | } |
2968 | - else |
|
2969 | - $text = preg_replace($censor_vulgar, $censor_proper, $text); |
|
2970 | 3123 | |
2971 | 3124 | return $text; |
2972 | 3125 | } |
@@ -2992,38 +3145,42 @@ discard block |
||
2992 | 3145 | @ini_set('track_errors', '1'); |
2993 | 3146 | |
2994 | 3147 | // Don't include the file more than once, if $once is true. |
2995 | - if ($once && in_array($filename, $templates)) |
|
2996 | - return; |
|
3148 | + if ($once && in_array($filename, $templates)) { |
|
3149 | + return; |
|
3150 | + } |
|
2997 | 3151 | // Add this file to the include list, whether $once is true or not. |
2998 | - else |
|
2999 | - $templates[] = $filename; |
|
3152 | + else { |
|
3153 | + $templates[] = $filename; |
|
3154 | + } |
|
3000 | 3155 | |
3001 | 3156 | // Are we going to use eval? |
3002 | 3157 | if (empty($modSettings['disableTemplateEval'])) |
3003 | 3158 | { |
3004 | 3159 | $file_found = file_exists($filename) && eval('?' . '>' . rtrim(file_get_contents($filename))) !== false; |
3005 | 3160 | $settings['current_include_filename'] = $filename; |
3006 | - } |
|
3007 | - else |
|
3161 | + } else |
|
3008 | 3162 | { |
3009 | 3163 | $file_found = file_exists($filename); |
3010 | 3164 | |
3011 | - if ($once && $file_found) |
|
3012 | - require_once($filename); |
|
3013 | - elseif ($file_found) |
|
3014 | - require($filename); |
|
3165 | + if ($once && $file_found) { |
|
3166 | + require_once($filename); |
|
3167 | + } elseif ($file_found) { |
|
3168 | + require($filename); |
|
3169 | + } |
|
3015 | 3170 | } |
3016 | 3171 | |
3017 | 3172 | if ($file_found !== true) |
3018 | 3173 | { |
3019 | 3174 | ob_end_clean(); |
3020 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
3021 | - @ob_start('ob_gzhandler'); |
|
3022 | - else |
|
3023 | - ob_start(); |
|
3175 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
3176 | + @ob_start('ob_gzhandler'); |
|
3177 | + } else { |
|
3178 | + ob_start(); |
|
3179 | + } |
|
3024 | 3180 | |
3025 | - if (isset($_GET['debug'])) |
|
3026 | - header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3181 | + if (isset($_GET['debug'])) { |
|
3182 | + header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3183 | + } |
|
3027 | 3184 | |
3028 | 3185 | // Don't cache error pages!! |
3029 | 3186 | header('Expires: Mon, 26 Jul 1997 05:00:00 GMT'); |
@@ -3042,12 +3199,13 @@ discard block |
||
3042 | 3199 | echo '<!DOCTYPE html> |
3043 | 3200 | <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '> |
3044 | 3201 | <head>'; |
3045 | - if (isset($context['character_set'])) |
|
3046 | - echo ' |
|
3202 | + if (isset($context['character_set'])) { |
|
3203 | + echo ' |
|
3047 | 3204 | <meta charset="', $context['character_set'], '">'; |
3205 | + } |
|
3048 | 3206 | |
3049 | - if (!empty($maintenance) && !allowedTo('admin_forum')) |
|
3050 | - echo ' |
|
3207 | + if (!empty($maintenance) && !allowedTo('admin_forum')) { |
|
3208 | + echo ' |
|
3051 | 3209 | <title>', $mtitle, '</title> |
3052 | 3210 | </head> |
3053 | 3211 | <body> |
@@ -3055,8 +3213,8 @@ discard block |
||
3055 | 3213 | ', $mmessage, ' |
3056 | 3214 | </body> |
3057 | 3215 | </html>'; |
3058 | - elseif (!allowedTo('admin_forum')) |
|
3059 | - echo ' |
|
3216 | + } elseif (!allowedTo('admin_forum')) { |
|
3217 | + echo ' |
|
3060 | 3218 | <title>', $txt['template_parse_error'], '</title> |
3061 | 3219 | </head> |
3062 | 3220 | <body> |
@@ -3064,16 +3222,18 @@ discard block |
||
3064 | 3222 | ', $txt['template_parse_error_message'], ' |
3065 | 3223 | </body> |
3066 | 3224 | </html>'; |
3067 | - else |
|
3225 | + } else |
|
3068 | 3226 | { |
3069 | 3227 | require_once($sourcedir . '/Subs-Package.php'); |
3070 | 3228 | |
3071 | 3229 | $error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => ''))); |
3072 | 3230 | $error_array = error_get_last(); |
3073 | - if (empty($error) && ini_get('track_errors') && !empty($error_array)) |
|
3074 | - $error = $error_array['message']; |
|
3075 | - if (empty($error)) |
|
3076 | - $error = $txt['template_parse_errmsg']; |
|
3231 | + if (empty($error) && ini_get('track_errors') && !empty($error_array)) { |
|
3232 | + $error = $error_array['message']; |
|
3233 | + } |
|
3234 | + if (empty($error)) { |
|
3235 | + $error = $txt['template_parse_errmsg']; |
|
3236 | + } |
|
3077 | 3237 | |
3078 | 3238 | $error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>')); |
3079 | 3239 | |
@@ -3084,11 +3244,12 @@ discard block |
||
3084 | 3244 | <h3>', $txt['template_parse_error'], '</h3> |
3085 | 3245 | ', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => ''))); |
3086 | 3246 | |
3087 | - if (!empty($error)) |
|
3088 | - echo ' |
|
3247 | + if (!empty($error)) { |
|
3248 | + echo ' |
|
3089 | 3249 | <hr> |
3090 | 3250 | |
3091 | 3251 | <div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>'; |
3252 | + } |
|
3092 | 3253 | |
3093 | 3254 | // I know, I know... this is VERY COMPLICATED. Still, it's good. |
3094 | 3255 | if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0) |
@@ -3098,10 +3259,11 @@ discard block |
||
3098 | 3259 | $data2 = preg_split('~\<br( /)?\>~', $data2); |
3099 | 3260 | |
3100 | 3261 | // Fix the PHP code stuff... |
3101 | - if (!isBrowser('gecko')) |
|
3102 | - $data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2); |
|
3103 | - else |
|
3104 | - $data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2); |
|
3262 | + if (!isBrowser('gecko')) { |
|
3263 | + $data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2); |
|
3264 | + } else { |
|
3265 | + $data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2); |
|
3266 | + } |
|
3105 | 3267 | |
3106 | 3268 | // Now we get to work around a bug in PHP where it doesn't escape <br>s! |
3107 | 3269 | $j = -1; |
@@ -3109,8 +3271,9 @@ discard block |
||
3109 | 3271 | { |
3110 | 3272 | $j++; |
3111 | 3273 | |
3112 | - if (substr_count($line, '<br>') == 0) |
|
3113 | - continue; |
|
3274 | + if (substr_count($line, '<br>') == 0) { |
|
3275 | + continue; |
|
3276 | + } |
|
3114 | 3277 | |
3115 | 3278 | $n = substr_count($line, '<br>'); |
3116 | 3279 | for ($i = 0; $i < $n; $i++) |
@@ -3129,38 +3292,42 @@ discard block |
||
3129 | 3292 | // Figure out what the color coding was before... |
3130 | 3293 | $line = max($match[1] - 9, 1); |
3131 | 3294 | $last_line = ''; |
3132 | - for ($line2 = $line - 1; $line2 > 1; $line2--) |
|
3133 | - if (strpos($data2[$line2], '<') !== false) |
|
3295 | + for ($line2 = $line - 1; $line2 > 1; $line2--) { |
|
3296 | + if (strpos($data2[$line2], '<') !== false) |
|
3134 | 3297 | { |
3135 | 3298 | if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0) |
3136 | 3299 | $last_line = $color_match[1]; |
3300 | + } |
|
3137 | 3301 | break; |
3138 | 3302 | } |
3139 | 3303 | |
3140 | 3304 | // Show the relevant lines... |
3141 | 3305 | for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++) |
3142 | 3306 | { |
3143 | - if ($line == $match[1]) |
|
3144 | - echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">'; |
|
3307 | + if ($line == $match[1]) { |
|
3308 | + echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">'; |
|
3309 | + } |
|
3145 | 3310 | |
3146 | 3311 | echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> '; |
3147 | - if (isset($data2[$line]) && $data2[$line] != '') |
|
3148 | - echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line]; |
|
3312 | + if (isset($data2[$line]) && $data2[$line] != '') { |
|
3313 | + echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line]; |
|
3314 | + } |
|
3149 | 3315 | |
3150 | 3316 | if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0) |
3151 | 3317 | { |
3152 | 3318 | $last_line = $color_match[1]; |
3153 | 3319 | echo '</', substr($last_line, 1, 4), '>'; |
3320 | + } elseif ($last_line != '' && strpos($data2[$line], '<') !== false) { |
|
3321 | + $last_line = ''; |
|
3322 | + } elseif ($last_line != '' && $data2[$line] != '') { |
|
3323 | + echo '</', substr($last_line, 1, 4), '>'; |
|
3154 | 3324 | } |
3155 | - elseif ($last_line != '' && strpos($data2[$line], '<') !== false) |
|
3156 | - $last_line = ''; |
|
3157 | - elseif ($last_line != '' && $data2[$line] != '') |
|
3158 | - echo '</', substr($last_line, 1, 4), '>'; |
|
3159 | 3325 | |
3160 | - if ($line == $match[1]) |
|
3161 | - echo '</pre></div><pre style="margin: 0;">'; |
|
3162 | - else |
|
3163 | - echo "\n"; |
|
3326 | + if ($line == $match[1]) { |
|
3327 | + echo '</pre></div><pre style="margin: 0;">'; |
|
3328 | + } else { |
|
3329 | + echo "\n"; |
|
3330 | + } |
|
3164 | 3331 | } |
3165 | 3332 | |
3166 | 3333 | echo '</pre></div>'; |
@@ -3184,8 +3351,9 @@ discard block |
||
3184 | 3351 | global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port; |
3185 | 3352 | |
3186 | 3353 | // Figure out what type of database we are using. |
3187 | - if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) |
|
3188 | - $db_type = 'mysql'; |
|
3354 | + if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) { |
|
3355 | + $db_type = 'mysql'; |
|
3356 | + } |
|
3189 | 3357 | |
3190 | 3358 | // Load the file for the database. |
3191 | 3359 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
@@ -3193,8 +3361,9 @@ discard block |
||
3193 | 3361 | $db_options = array(); |
3194 | 3362 | |
3195 | 3363 | // Add in the port if needed |
3196 | - if (!empty($db_port)) |
|
3197 | - $db_options['port'] = $db_port; |
|
3364 | + if (!empty($db_port)) { |
|
3365 | + $db_options['port'] = $db_port; |
|
3366 | + } |
|
3198 | 3367 | |
3199 | 3368 | // If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use. |
3200 | 3369 | if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd)) |
@@ -3213,13 +3382,15 @@ discard block |
||
3213 | 3382 | } |
3214 | 3383 | |
3215 | 3384 | // Safe guard here, if there isn't a valid connection lets put a stop to it. |
3216 | - if (!$db_connection) |
|
3217 | - display_db_error(); |
|
3385 | + if (!$db_connection) { |
|
3386 | + display_db_error(); |
|
3387 | + } |
|
3218 | 3388 | |
3219 | 3389 | // If in SSI mode fix up the prefix. |
3220 | - if (SMF == 'SSI') |
|
3221 | - db_fix_prefix($db_prefix, $db_name); |
|
3222 | -} |
|
3390 | + if (SMF == 'SSI') { |
|
3391 | + db_fix_prefix($db_prefix, $db_name); |
|
3392 | + } |
|
3393 | + } |
|
3223 | 3394 | |
3224 | 3395 | /** |
3225 | 3396 | * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it. |
@@ -3233,10 +3404,11 @@ discard block |
||
3233 | 3404 | global $sourcedir, $cacheAPI, $cache_accelerator; |
3234 | 3405 | |
3235 | 3406 | // Not overriding this and we have a cacheAPI, send it back. |
3236 | - if (empty($overrideCache) && is_object($cacheAPI)) |
|
3237 | - return $cacheAPI; |
|
3238 | - elseif (is_null($cacheAPI)) |
|
3239 | - $cacheAPI = false; |
|
3407 | + if (empty($overrideCache) && is_object($cacheAPI)) { |
|
3408 | + return $cacheAPI; |
|
3409 | + } elseif (is_null($cacheAPI)) { |
|
3410 | + $cacheAPI = false; |
|
3411 | + } |
|
3240 | 3412 | |
3241 | 3413 | // Make sure our class is in session. |
3242 | 3414 | require_once($sourcedir . '/Class-CacheAPI.php'); |
@@ -3257,8 +3429,9 @@ discard block |
||
3257 | 3429 | if (!$testAPI->isSupported()) |
3258 | 3430 | { |
3259 | 3431 | // Can we save ourselves? |
3260 | - if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') |
|
3261 | - return loadCacheAccelerator(null, false); |
|
3432 | + if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') { |
|
3433 | + return loadCacheAccelerator(null, false); |
|
3434 | + } |
|
3262 | 3435 | return false; |
3263 | 3436 | } |
3264 | 3437 | |
@@ -3270,9 +3443,9 @@ discard block |
||
3270 | 3443 | { |
3271 | 3444 | $cacheAPI = $testAPI; |
3272 | 3445 | return $cacheAPI; |
3446 | + } else { |
|
3447 | + return $testAPI; |
|
3273 | 3448 | } |
3274 | - else |
|
3275 | - return $testAPI; |
|
3276 | 3449 | } |
3277 | 3450 | } |
3278 | 3451 | |
@@ -3292,8 +3465,9 @@ discard block |
||
3292 | 3465 | |
3293 | 3466 | // @todo Why are we doing this if caching is disabled? |
3294 | 3467 | |
3295 | - if (function_exists('call_integration_hook')) |
|
3296 | - call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level)); |
|
3468 | + if (function_exists('call_integration_hook')) { |
|
3469 | + call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level)); |
|
3470 | + } |
|
3297 | 3471 | |
3298 | 3472 | /* Refresh the cache if either: |
3299 | 3473 | 1. Caching is disabled. |
@@ -3307,16 +3481,19 @@ discard block |
||
3307 | 3481 | require_once($sourcedir . '/' . $file); |
3308 | 3482 | $cache_block = call_user_func_array($function, $params); |
3309 | 3483 | |
3310 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) |
|
3311 | - cache_put_data($key, $cache_block, $cache_block['expires'] - time()); |
|
3484 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) { |
|
3485 | + cache_put_data($key, $cache_block, $cache_block['expires'] - time()); |
|
3486 | + } |
|
3312 | 3487 | } |
3313 | 3488 | |
3314 | 3489 | // Some cached data may need a freshening up after retrieval. |
3315 | - if (!empty($cache_block['post_retri_eval'])) |
|
3316 | - eval($cache_block['post_retri_eval']); |
|
3490 | + if (!empty($cache_block['post_retri_eval'])) { |
|
3491 | + eval($cache_block['post_retri_eval']); |
|
3492 | + } |
|
3317 | 3493 | |
3318 | - if (function_exists('call_integration_hook')) |
|
3319 | - call_integration_hook('post_cache_quick_get', array(&$cache_block)); |
|
3494 | + if (function_exists('call_integration_hook')) { |
|
3495 | + call_integration_hook('post_cache_quick_get', array(&$cache_block)); |
|
3496 | + } |
|
3320 | 3497 | |
3321 | 3498 | return $cache_block['data']; |
3322 | 3499 | } |
@@ -3343,8 +3520,9 @@ discard block |
||
3343 | 3520 | global $smcFunc, $cache_enable, $cacheAPI; |
3344 | 3521 | global $cache_hits, $cache_count, $db_show_debug; |
3345 | 3522 | |
3346 | - if (empty($cache_enable) || empty($cacheAPI)) |
|
3347 | - return; |
|
3523 | + if (empty($cache_enable) || empty($cacheAPI)) { |
|
3524 | + return; |
|
3525 | + } |
|
3348 | 3526 | |
3349 | 3527 | $cache_count = isset($cache_count) ? $cache_count + 1 : 1; |
3350 | 3528 | if (isset($db_show_debug) && $db_show_debug === true) |
@@ -3357,12 +3535,14 @@ discard block |
||
3357 | 3535 | $value = $value === null ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_encode']($value) : json_encode($value)); |
3358 | 3536 | $cacheAPI->putData($key, $value, $ttl); |
3359 | 3537 | |
3360 | - if (function_exists('call_integration_hook')) |
|
3361 | - call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl)); |
|
3538 | + if (function_exists('call_integration_hook')) { |
|
3539 | + call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl)); |
|
3540 | + } |
|
3362 | 3541 | |
3363 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
3364 | - $cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st)); |
|
3365 | -} |
|
3542 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3543 | + $cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st)); |
|
3544 | + } |
|
3545 | + } |
|
3366 | 3546 | |
3367 | 3547 | /** |
3368 | 3548 | * Gets the value from the cache specified by key, so long as it is not older than ttl seconds. |
@@ -3378,8 +3558,9 @@ discard block |
||
3378 | 3558 | global $smcFunc, $cache_enable, $cacheAPI; |
3379 | 3559 | global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug; |
3380 | 3560 | |
3381 | - if (empty($cache_enable) || empty($cacheAPI)) |
|
3382 | - return; |
|
3561 | + if (empty($cache_enable) || empty($cacheAPI)) { |
|
3562 | + return; |
|
3563 | + } |
|
3383 | 3564 | |
3384 | 3565 | $cache_count = isset($cache_count) ? $cache_count + 1 : 1; |
3385 | 3566 | if (isset($db_show_debug) && $db_show_debug === true) |
@@ -3399,16 +3580,18 @@ discard block |
||
3399 | 3580 | |
3400 | 3581 | if (empty($value)) |
3401 | 3582 | { |
3402 | - if (!is_array($cache_misses)) |
|
3403 | - $cache_misses = array(); |
|
3583 | + if (!is_array($cache_misses)) { |
|
3584 | + $cache_misses = array(); |
|
3585 | + } |
|
3404 | 3586 | |
3405 | 3587 | $cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1; |
3406 | 3588 | $cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get'); |
3407 | 3589 | } |
3408 | 3590 | } |
3409 | 3591 | |
3410 | - if (function_exists('call_integration_hook') && isset($value)) |
|
3411 | - call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value)); |
|
3592 | + if (function_exists('call_integration_hook') && isset($value)) { |
|
3593 | + call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value)); |
|
3594 | + } |
|
3412 | 3595 | |
3413 | 3596 | return empty($value) ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_decode']($value, true) : smf_json_decode($value, true)); |
3414 | 3597 | } |
@@ -3430,8 +3613,9 @@ discard block |
||
3430 | 3613 | global $cacheAPI; |
3431 | 3614 | |
3432 | 3615 | // If we can't get to the API, can't do this. |
3433 | - if (empty($cacheAPI)) |
|
3434 | - return; |
|
3616 | + if (empty($cacheAPI)) { |
|
3617 | + return; |
|
3618 | + } |
|
3435 | 3619 | |
3436 | 3620 | // Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure. |
3437 | 3621 | $cacheAPI->cleanCache($type); |
@@ -3456,8 +3640,9 @@ discard block |
||
3456 | 3640 | global $modSettings, $boardurl, $smcFunc, $image_proxy_enabled, $image_proxy_secret; |
3457 | 3641 | |
3458 | 3642 | // Come on! |
3459 | - if (empty($data)) |
|
3460 | - return array(); |
|
3643 | + if (empty($data)) { |
|
3644 | + return array(); |
|
3645 | + } |
|
3461 | 3646 | |
3462 | 3647 | // Set a nice default var. |
3463 | 3648 | $image = ''; |
@@ -3465,11 +3650,11 @@ discard block |
||
3465 | 3650 | // Gravatar has been set as mandatory! |
3466 | 3651 | if (!empty($modSettings['gravatarOverride'])) |
3467 | 3652 | { |
3468 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) |
|
3469 | - $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3470 | - |
|
3471 | - else if (!empty($data['email'])) |
|
3472 | - $image = get_gravatar_url($data['email']); |
|
3653 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) { |
|
3654 | + $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3655 | + } else if (!empty($data['email'])) { |
|
3656 | + $image = get_gravatar_url($data['email']); |
|
3657 | + } |
|
3473 | 3658 | } |
3474 | 3659 | |
3475 | 3660 | // Look if the user has a gravatar field or has set an external url as avatar. |
@@ -3481,54 +3666,60 @@ discard block |
||
3481 | 3666 | // Gravatar. |
3482 | 3667 | if (stristr($data['avatar'], 'gravatar://')) |
3483 | 3668 | { |
3484 | - if ($data['avatar'] == 'gravatar://') |
|
3485 | - $image = get_gravatar_url($data['email']); |
|
3486 | - |
|
3487 | - elseif (!empty($modSettings['gravatarAllowExtraEmail'])) |
|
3488 | - $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3669 | + if ($data['avatar'] == 'gravatar://') { |
|
3670 | + $image = get_gravatar_url($data['email']); |
|
3671 | + } elseif (!empty($modSettings['gravatarAllowExtraEmail'])) { |
|
3672 | + $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
3673 | + } |
|
3489 | 3674 | } |
3490 | 3675 | |
3491 | 3676 | // External url. |
3492 | 3677 | else |
3493 | 3678 | { |
3494 | 3679 | // Using ssl? |
3495 | - if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) |
|
3496 | - $image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret); |
|
3680 | + if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) { |
|
3681 | + $image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret); |
|
3682 | + } |
|
3497 | 3683 | |
3498 | 3684 | // Just a plain external url. |
3499 | - else |
|
3500 | - $image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar']; |
|
3685 | + else { |
|
3686 | + $image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar']; |
|
3687 | + } |
|
3501 | 3688 | } |
3502 | 3689 | } |
3503 | 3690 | |
3504 | 3691 | // Perhaps this user has an attachment as avatar... |
3505 | - else if (!empty($data['filename'])) |
|
3506 | - $image = $modSettings['custom_avatar_url'] . '/' . $data['filename']; |
|
3692 | + else if (!empty($data['filename'])) { |
|
3693 | + $image = $modSettings['custom_avatar_url'] . '/' . $data['filename']; |
|
3694 | + } |
|
3507 | 3695 | |
3508 | 3696 | // Right... no avatar... use our default image. |
3509 | - else |
|
3510 | - $image = $modSettings['avatar_url'] . '/default.png'; |
|
3697 | + else { |
|
3698 | + $image = $modSettings['avatar_url'] . '/default.png'; |
|
3699 | + } |
|
3511 | 3700 | } |
3512 | 3701 | |
3513 | 3702 | call_integration_hook('integrate_set_avatar_data', array(&$image, &$data)); |
3514 | 3703 | |
3515 | 3704 | // At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed. |
3516 | - if (!empty($image)) |
|
3517 | - return array( |
|
3705 | + if (!empty($image)) { |
|
3706 | + return array( |
|
3518 | 3707 | 'name' => !empty($data['avatar']) ? $data['avatar'] : '', |
3519 | 3708 | 'image' => '<img class="avatar" src="' . $image . '" />', |
3520 | 3709 | 'href' => $image, |
3521 | 3710 | 'url' => $image, |
3522 | 3711 | ); |
3712 | + } |
|
3523 | 3713 | |
3524 | 3714 | // Fallback to make life easier for everyone... |
3525 | - else |
|
3526 | - return array( |
|
3715 | + else { |
|
3716 | + return array( |
|
3527 | 3717 | 'name' => '', |
3528 | 3718 | 'image' => '', |
3529 | 3719 | 'href' => '', |
3530 | 3720 | 'url' => '', |
3531 | 3721 | ); |
3532 | -} |
|
3722 | + } |
|
3723 | + } |
|
3533 | 3724 | |
3534 | 3725 | ?> |
3535 | 3726 | \ No newline at end of file |