Sources/Subs.php ➔ build_query_board()

Complexity

Conditions	16
Paths	400

Size

Total Lines	101
Code Lines	52

Duplication

Lines	7
Ratio	6.93 %

Importance

Changes

0

<?php
function build_query_board($userid)
{
	global $user_info, $modSettings, $smcFunc;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

	$query_part = array();
	$groups = array();

$groups is not used, you could remove the assignment.

	$is_admin = false;

$is_admin is not used, you could remove the assignment.

	$deny_boards_access = !empty($modSettings['deny_boards_access']) ? $modSettings['deny_boards_access'] : null;
	$mod_cache;

The variable $mod_cache seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

	$ignoreboards;

The variable $ignoreboards seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

	if ($user_info['id'] == $userid)
	{
		$groups = $user_info['groups'];
		$is_admin = $user_info['is_admin'];
		$mod_cache = !empty($user_info['mod_cache']) ? $user_info['mod_cache'] : null;
		$ignoreboards = !empty($user_info['ignoreboards']) ? $user_info['ignoreboards'] : null;
	}
	else
	{
		$request = $smcFunc['db_query']('', '
				SELECT mem.ignore_boards, mem.id_group, mem.additional_groups, mem.id_post_group
				FROM {db_prefix}members AS mem
				WHERE mem.id_member = {int:id_member}
				LIMIT 1',
				array(
					'id_member' => $userid,
				)
			);

		$row = $smcFunc['db_fetch_assoc']($request);

		if (empty($row['additional_groups']))
			$groups = array($row['id_group'], $user_settings['id_post_group']);

The variable $user_settings does not exist. Did you forget to declare it?

		else
			$groups = array_merge(
					array($row['id_group'], $user_settings['id_post_group']),
					explode(',', $row['additional_groups'])
			);

		// Because history has proven that it is possible for groups to go bad - clean up in case.
		foreach ($groups as $k => $v)
			$groups[$k] = (int) $v;

		$is_admin = in_array(1, $groups);

		$ignoreboards = !empty($row['ignore_boards']) && !empty($modSettings['allow_ignore_boards']) ? explode(',', $row['ignore_boards']) : array();

		// What boards are they the moderator of?
		$boards_mod = array();

		$request = $smcFunc['db_query']('', '
			SELECT id_board
			FROM {db_prefix}moderators
			WHERE id_member = {int:current_member}',
			array(
				'current_member' => $userid,
			)
		);
		while ($row = $smcFunc['db_fetch_assoc']($request))
			$boards_mod[] = $row['id_board'];
		$smcFunc['db_free_result']($request);

		// Can any of the groups they're in moderate any of the boards?
		$request = $smcFunc['db_query']('', '
			SELECT id_board
			FROM {db_prefix}moderator_groups
			WHERE id_group IN({array_int:groups})',
			array(
				'groups' => $groups,
			)
		);
		while ($row = $smcFunc['db_fetch_assoc']($request))
			$boards_mod[] = $row['id_board'];
		$smcFunc['db_free_result']($request);

		// Just in case we've got duplicates here...
		$boards_mod = array_unique($boards_mod);

		$mod_cache['mq'] = empty($boards_mod) ? '0=1' : 'b.id_board IN (' . implode(',', $boards_mod) . ')';

$mod_cache was never initialized. Although not strictly required by PHP, it is generally a good practice to add $mod_cache = array(); before regardless.

	}
	
	// Just build this here, it makes it easier to change/use - administrators can see all boards.
	if ($is_admin)
		$query_part['query_see_board'] = '1=1';
	// Otherwise just the groups in $user_info['groups'].
	else
		$query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')';

	// Build the list of boards they WANT to see.
	// This will take the place of query_see_boards in certain spots, so it better include the boards they can see also

	// If they aren't ignoring any boards then they want to see all the boards they can see
	if (empty($ignoreboards))
		$query_part['query_wanna_see_board'] = $query_part['query_see_board'];
	// Ok I guess they don't want to see all the boards
	else
		$query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))';

	return $query_part;
}

?>