Completed
Push — release-2.1 ( 12381f...8d796c )
by Michael
07:22
created
Themes/default/Post.template.php 1 patch
Braces   +89 added lines, -61 removed lines patch added patch discarded remove patch
@@ -22,22 +22,24 @@  discard block
 block discarded – undo
22 22
 		<script>';
23 23
 
24 24
 	// When using Go Back due to fatal_error, allow the form to be re-submitted with changes.
25
-	if (isBrowser('is_firefox'))
26
-		echo '
25
+	if (isBrowser('is_firefox')) {
26
+			echo '
27 27
 			window.addEventListener("pageshow", reActivate, false);';
28
+	}
28 29
 
29 30
 	// Start with message icons - and any missing from this theme.
30 31
 	echo '
31 32
 			var icon_urls = {';
32
-	foreach ($context['icons'] as $icon)
33
-		echo '
33
+	foreach ($context['icons'] as $icon) {
34
+			echo '
34 35
 				\'', $icon['value'], '\': \'', $icon['url'], '\'', $icon['is_last'] ? '' : ',';
36
+	}
35 37
 	echo '
36 38
 			};';
37 39
 
38 40
 	// If this is a poll - use some javascript to ensure the user doesn't create a poll with illegal option combinations.
39
-	if ($context['make_poll'])
40
-		echo '
41
+	if ($context['make_poll']) {
42
+			echo '
41 43
 			var pollOptionNum = 0, pollTabIndex;
42 44
 			var pollOptionId = ', $context['last_choice_id'], ';
43 45
 			function addPollOption()
@@ -56,11 +58,13 @@  discard block
 block discarded – undo
56 58
 
57 59
 				setOuterHTML(document.getElementById(\'pollMoreOptions\'), ', JavaScriptEscape('<dt><label for="options-'), ' + pollOptionId + ', JavaScriptEscape('">' . $txt['option'] . ' '), ' + pollOptionNum + ', JavaScriptEscape('</label>:</dt><dd><input type="text" name="options['), ' + pollOptionId + ', JavaScriptEscape(']" id="options-'), ' + pollOptionId + ', JavaScriptEscape('" value="" size="80" maxlength="255" tabindex="'), ' + pollTabIndex + ', JavaScriptEscape('"></dd><p id="pollMoreOptions"></p>'), ');
58 60
 			}';
61
+	}
59 62
 
60 63
 	// If we are making a calendar event we want to ensure we show the current days in a month etc... this is done here.
61
-	if ($context['make_event'])
62
-		echo '
64
+	if ($context['make_event']) {
65
+			echo '
63 66
 			var monthLength = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];';
67
+	}
64 68
 
65 69
 	// End of the javascript, start the form and display the link tree.
66 70
 	echo '
@@ -80,9 +84,10 @@  discard block
 block discarded – undo
80 84
 				</div>
81 85
 			</div><br>';
82 86
 
83
-	if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board'])))
84
-		echo '
87
+	if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board']))) {
88
+			echo '
85 89
 			<input type="hidden" name="eventid" value="', $context['event']['id'], '">';
90
+	}
86 91
 
87 92
 	// Start the main table.
88 93
 	echo '
@@ -117,18 +122,20 @@  discard block
 block discarded – undo
117 122
 	}
118 123
 
119 124
 	// If it's locked, show a message to warn the replier.
120
-	if (!empty($context['locked']))
121
-	echo '
125
+	if (!empty($context['locked'])) {
126
+		echo '
122 127
 					<div class="errorbox">
123 128
 						', $txt['topic_locked_no_reply'], '
124 129
 					</div>';
130
+	}
125 131
 
126
-	if (!empty($modSettings['drafts_post_enabled']))
127
-		echo '
132
+	if (!empty($modSettings['drafts_post_enabled'])) {
133
+			echo '
128 134
 					<div id="draft_section" class="infobox"', isset($context['draft_saved']) ? '' : ' style="display: none;"', '>',
129 135
 						sprintf($txt['draft_saved'], $scripturl . '?action=profile;u=' . $context['user']['id'] . ';area=showdrafts'), '
130 136
 						', (!empty($modSettings['drafts_keep_days']) ? ' <strong>' . sprintf($txt['draft_save_warning'], $modSettings['drafts_keep_days']) . '</strong>' : ''), '
131 137
 					</div>';
138
+	}
132 139
 
133 140
 	// The post header... important stuff
134 141
 	echo '
@@ -180,9 +187,10 @@  discard block
 block discarded – undo
180 187
 				{
181 188
 					echo '
182 189
 										<optgroup label="', $category['name'], '">';
183
-					foreach ($category['boards'] as $board)
184
-						echo '
190
+					foreach ($category['boards'] as $board) {
191
+											echo '
185 192
 											<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=&gt;' : '', ' ', $board['name'], '&nbsp;</option>';
193
+					}
186 194
 					echo '
187 195
 										</optgroup>';
188 196
 				}
@@ -218,9 +226,10 @@  discard block
 block discarded – undo
218 226
 									<span class="label">', $txt['calendar_timezone'], '</span>
219 227
 									<select name="tz" id="tz"', !empty($context['event']['allday']) ? ' disabled' : '', '>';
220 228
 
221
-			foreach ($context['all_timezones'] as $tz => $tzname)
222
-				echo '
229
+			foreach ($context['all_timezones'] as $tz => $tzname) {
230
+							echo '
223 231
 										<option value="', $tz, '"', $tz == $context['event']['tz'] ? ' selected' : '', '>', $tzname, '</option>';
232
+			}
224 233
 
225 234
 			echo '
226 235
 									</select>
@@ -286,14 +295,15 @@  discard block
 block discarded – undo
286 295
 									<input type="checkbox" id="poll_change_vote" name="poll_change_vote"', !empty($context['poll']['change_vote']) ? ' checked' : '', '>
287 296
 								</dd>';
288 297
 
289
-		if ($context['poll_options']['guest_vote_enabled'])
290
-			echo '
298
+		if ($context['poll_options']['guest_vote_enabled']) {
299
+					echo '
291 300
 								<dt>
292 301
 									<label for="poll_guest_vote">', $txt['poll_guest_vote'], ':</label>
293 302
 								</dt>
294 303
 								<dd>
295 304
 									<input type="checkbox" id="poll_guest_vote" name="poll_guest_vote"', !empty($context['poll_options']['guest_vote']) ? ' checked' : '', '>
296 305
 								</dd>';
306
+		}
297 307
 
298 308
 		echo '
299 309
 								<dt>
@@ -314,8 +324,8 @@  discard block
 block discarded – undo
314 324
 					', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message');
315 325
 
316 326
 	// If we're editing and displaying edit details, show a box where they can say why
317
-	if (isset($context['editing']) && $modSettings['show_modify'])
318
-		echo '
327
+	if (isset($context['editing']) && $modSettings['show_modify']) {
328
+			echo '
319 329
 					<dl>
320 330
 						<dt class="clear">
321 331
 							<span id="caption_edit_reason">', $txt['reason_for_edit'], ':</span>
@@ -324,20 +334,23 @@  discard block
 block discarded – undo
324 334
 							<input type="text" name="modify_reason"', isset($context['last_modified_reason']) ? ' value="' . $context['last_modified_reason'] . '"' : '', ' tabindex="', $context['tabindex']++, '" size="80" maxlength="80">
325 335
 						</dd>
326 336
 					</dl>';
337
+	}
327 338
 
328 339
 	// If this message has been edited in the past - display when it was.
329
-	if (isset($context['last_modified']))
330
-		echo '
340
+	if (isset($context['last_modified'])) {
341
+			echo '
331 342
 					<div class="padding smalltext">
332 343
 						', $context['last_modified_text'], '
333 344
 					</div>';
345
+	}
334 346
 
335 347
 	// If the admin has enabled the hiding of the additional options - show a link and image for it.
336
-	if (!empty($modSettings['additional_options_collapsable']))
337
-		echo '
348
+	if (!empty($modSettings['additional_options_collapsable'])) {
349
+			echo '
338 350
 					<div id="postAdditionalOptionsHeader">
339 351
 						<strong><a href="#" id="postMoreExpandLink"> ', $context['can_post_attachment'] ? $txt['post_additionalopt_attach'] : $txt['post_additionalopt'], '</a></strong>
340 352
 					</div>';
353
+	}
341 354
 
342 355
 	echo '
343 356
 					<div id="postAdditionalOptions">';
@@ -369,19 +382,21 @@  discard block
 block discarded – undo
369 382
 								<input type="hidden" name="attach_del[]" value="0">
370 383
 								', $txt['uncheck_unwatchd_attach'], ':
371 384
 							</dd>';
372
-		foreach ($context['current_attachments'] as $attachment)
373
-			echo '
385
+		foreach ($context['current_attachments'] as $attachment) {
386
+					echo '
374 387
 							<dd class="smalltext">
375 388
 								<label for="attachment_', $attachment['attachID'], '"><input type="checkbox" id="attachment_', $attachment['attachID'], '" name="attach_del[]" value="', $attachment['attachID'], '"', empty($attachment['unchecked']) ? ' checked' : '', '> ', $attachment['name'], (empty($attachment['approved']) ? ' (' . $txt['awaiting_approval'] . ')' : ''),
376 389
 								!empty($modSettings['attachmentPostLimit']) || !empty($modSettings['attachmentSizeLimit']) ? sprintf($txt['attach_kb'], comma_format(round(max($attachment['size'], 1024) / 1024), 0)) : '', '</label>
377 390
 							</dd>';
391
+		}
378 392
 
379 393
 		echo '
380 394
 						</dl>';
381 395
 
382
-		if (!empty($context['files_in_session_warning']))
383
-			echo '
396
+		if (!empty($context['files_in_session_warning'])) {
397
+					echo '
384 398
 						<div class="smalltext">', $context['files_in_session_warning'], '</div>';
399
+		}
385 400
 	}
386 401
 
387 402
 	// Is the user allowed to post any additional ones? If so give them the boxes to do it!
@@ -445,8 +460,8 @@  discard block
 block discarded – undo
445 460
 								', empty($modSettings['attachmentSizeLimit']) ? '' : ('<input type="hidden" name="MAX_FILE_SIZE" value="' . $modSettings['attachmentSizeLimit'] * 1024 . '">');
446 461
 
447 462
 		// Show more boxes if they aren't approaching that limit.
448
-		if ($context['num_allowed_attachments'] > 1)
449
-			echo '
463
+		if ($context['num_allowed_attachments'] > 1) {
464
+					echo '
450 465
 										<script>
451 466
 											var allowed_attachments = ', $context['num_allowed_attachments'], ';
452 467
 											var current_attachment = 1;
@@ -467,9 +482,10 @@  discard block
 block discarded – undo
467 482
 									</div>
468 483
 								</div>
469 484
 							</dd>';
470
-		else
471
-			echo '
485
+		} else {
486
+					echo '
472 487
 							</dd>';
488
+		}
473 489
 
474 490
 		// Add any template changes for an alternative upload system here.
475 491
 		call_integration_hook('integrate_upload_template');
@@ -478,21 +494,25 @@  discard block
 block discarded – undo
478 494
 							<dd class="smalltext">';
479 495
 
480 496
 		// Show some useful information such as allowed extensions, maximum size and amount of attachments allowed.
481
-		if (!empty($modSettings['attachmentCheckExtensions']))
482
-			echo '
497
+		if (!empty($modSettings['attachmentCheckExtensions'])) {
498
+					echo '
483 499
 								', $txt['allowed_types'], ': ', $context['allowed_extensions'], '<br>';
500
+		}
484 501
 
485
-		if (!empty($context['attachment_restrictions']))
486
-			echo '
502
+		if (!empty($context['attachment_restrictions'])) {
503
+					echo '
487 504
 								', $txt['attach_restrictions'], ' ', implode(', ', $context['attachment_restrictions']), '<br>';
505
+		}
488 506
 
489
-		if ($context['num_allowed_attachments'] == 0)
490
-			echo '
507
+		if ($context['num_allowed_attachments'] == 0) {
508
+					echo '
491 509
 								', $txt['attach_limit_nag'], '<br>';
510
+		}
492 511
 
493
-		if (!$context['can_post_attachment_unapproved'])
494
-			echo '
512
+		if (!$context['can_post_attachment_unapproved']) {
513
+					echo '
495 514
 								<span class="alert">', $txt['attachment_requires_approval'], '</span>', '<br>';
515
+		}
496 516
 
497 517
 		echo '
498 518
 							</dd>
@@ -515,10 +535,11 @@  discard block
 block discarded – undo
515 535
 							<dt><strong>', $txt['subject'], '</strong></dt>
516 536
 							<dd><strong>', $txt['draft_saved_on'], '</strong></dd>';
517 537
 
518
-		foreach ($context['drafts'] as $draft)
519
-			echo '
538
+		foreach ($context['drafts'] as $draft) {
539
+					echo '
520 540
 							<dt>', $draft['link'], '</dt>
521 541
 							<dd>', $draft['poster_time'], '</dd>';
542
+		}
522 543
 		echo '
523 544
 						</dl>
524 545
 					</div>';
@@ -543,9 +564,10 @@  discard block
 block discarded – undo
543 564
 						', template_control_richedit_buttons($context['post_box_name']);
544 565
 
545 566
 	// Option to delete an event if user is editing one.
546
-	if ($context['make_event'] && !$context['event']['new'])
547
-		echo '
567
+	if ($context['make_event'] && !$context['event']['new']) {
568
+			echo '
548 569
 						<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button you_sure">';
570
+	}
549 571
 
550 572
 	echo '
551 573
 					</span>
@@ -554,9 +576,10 @@  discard block
 block discarded – undo
554 576
 			<br class="clear">';
555 577
 
556 578
 	// Assuming this isn't a new topic pass across the last message id.
557
-	if (isset($context['topic_last_message']))
558
-		echo '
579
+	if (isset($context['topic_last_message'])) {
580
+			echo '
559 581
 			<input type="hidden" name="last_msg" value="', $context['topic_last_message'], '">';
582
+	}
560 583
 
561 584
 	echo '
562 585
 			<input type="hidden" name="additional_options" id="additional_options" value="', $context['show_additional_options'] ? '1' : '0', '">
@@ -698,9 +721,10 @@  discard block
 block discarded – undo
698 721
 
699 722
 						newPostsHTML += \'<div class="windowbg\' + (++reply_counter % 2 == 0 ? \'2\' : \'\') + \'"><div id="msg\' + newPosts[i].getAttribute("id") + \'"><div class="floatleft"><h5>', $txt['posted_by'], ': \' + newPosts[i].getElementsByTagName("poster")[0].firstChild.nodeValue + \'</h5><span class="smalltext">&#171;&nbsp;<strong>', $txt['on'], ':</strong> \' + newPosts[i].getElementsByTagName("time")[0].firstChild.nodeValue + \'&nbsp;&#187;</span> <span class="new_posts" id="image_new_\' + newPosts[i].getAttribute("id") + \'">', $txt['new'], '</span></div>\';';
700 723
 
701
-	if ($context['can_quote'])
702
-		echo '
724
+	if ($context['can_quote']) {
725
+			echo '
703 726
 						newPostsHTML += \'<ul class="quickbuttons" id="msg_\' + newPosts[i].getAttribute("id") + \'_quote"><li><a href="#postmodify" onclick="return insertQuoteFast(\\\'\' + newPosts[i].getAttribute("id") + \'\\\');" class="quote_button"><span>', $txt['quote'], '</span><\' + \'/a></li></ul>\';';
727
+	}
704 728
 
705 729
 	echo '
706 730
 						newPostsHTML += \'<br class="clear">\';
@@ -743,8 +767,8 @@  discard block
 block discarded – undo
743 767
 			}';
744 768
 
745 769
 	// Code for showing and hiding additional options.
746
-	if (!empty($modSettings['additional_options_collapsable']))
747
-		echo '
770
+	if (!empty($modSettings['additional_options_collapsable'])) {
771
+			echo '
748 772
 			var oSwapAdditionalOptions = new smc_Toggle({
749 773
 				bToggleEnabled: true,
750 774
 				bCurrentlyCollapsed: ', $context['show_additional_options'] ? 'false' : 'true', ',
@@ -772,10 +796,11 @@  discard block
 block discarded – undo
772 796
 					}
773 797
 				]
774 798
 			});';
799
+	}
775 800
 
776 801
 	// Code for showing and hiding drafts
777
-	if (!empty($context['drafts']))
778
-		echo '
802
+	if (!empty($context['drafts'])) {
803
+			echo '
779 804
 			var oSwapDraftOptions = new smc_Toggle({
780 805
 				bToggleEnabled: true,
781 806
 				bCurrentlyCollapsed: true,
@@ -797,6 +822,7 @@  discard block
 block discarded – undo
797 822
 					}
798 823
 				]
799 824
 			});';
825
+	}
800 826
 
801 827
 	echo '
802 828
 			var oEditorID = "', $context['post_box_name'] ,'";
@@ -817,8 +843,9 @@  discard block
 block discarded – undo
817 843
 		foreach ($context['previous_posts'] as $post)
818 844
 		{
819 845
 			$ignoring = false;
820
-			if (!empty($post['is_ignored']))
821
-				$ignored_posts[] = $ignoring = $post['id'];
846
+			if (!empty($post['is_ignored'])) {
847
+							$ignored_posts[] = $ignoring = $post['id'];
848
+			}
822 849
 
823 850
 			echo '
824 851
 			<div class="windowbg">
@@ -1001,10 +1028,10 @@  discard block
 block discarded – undo
1001 1028
 		<div id="temporary_posting_area" style="display: none;"></div>
1002 1029
 		<script>';
1003 1030
 
1004
-	if ($context['close_window'])
1005
-		echo '
1031
+	if ($context['close_window']) {
1032
+			echo '
1006 1033
 			window.close();';
1007
-	else
1034
+	} else
1008 1035
 	{
1009 1036
 		// Lucky for us, Internet Explorer has an "innerText" feature which basically converts entities <--> text. Use it if possible ;).
1010 1037
 		echo '
@@ -1058,11 +1085,12 @@  discard block
 block discarded – undo
1058 1085
 				</p>
1059 1086
 				<ul>';
1060 1087
 
1061
-	foreach ($context['groups'] as $group)
1062
-		echo '
1088
+	foreach ($context['groups'] as $group) {
1089
+			echo '
1063 1090
 					<li>
1064 1091
 						<label for="who_', $group['id'], '"><input type="checkbox" name="who[', $group['id'], ']" id="who_', $group['id'], '" value="', $group['id'], '" checked> ', $group['name'], '</label> <em>(', $group['member_count'], ')</em>
1065 1092
 					</li>';
1093
+	}
1066 1094
 
1067 1095
 	echo '
1068 1096
 					<li>
Please login to merge, or discard this patch.