Completed
Push — release-2.1 ( abcd56...53231f )
by Colin
07:51
created
Sources/Subs.php 2 patches
Indentation   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -5495,7 +5495,6 @@  discard block
 block discarded – undo
5495 5495
 
5496 5496
 /**
5497 5497
  * Tries different modes to make file/dirs writable. Wrapper function for chmod()
5498
-
5499 5498
  * @param string $file The file/dir full path.
5500 5499
  * @param int $value Not needed, added for legacy reasons.
5501 5500
  * @return boolean  true if the file/dir is already writable or the function was able to make it writable, false if the function couldn't make the file/dir writable.
@@ -5535,7 +5534,6 @@  discard block
 block discarded – undo
5535 5534
 
5536 5535
 /**
5537 5536
  * Wrapper function for json_decode() with error handling.
5538
-
5539 5537
  * @param string $json The string to decode.
5540 5538
  * @param bool $returnAsArray To return the decoded string as an array or an object, SMF only uses Arrays but to keep on compatibility with json_decode its set to false as default.
5541 5539
  * @param bool $logIt To specify if the error will be logged if theres any.
@@ -6029,7 +6027,7 @@  discard block
 block discarded – undo
6029 6027
 		$params = stream_context_get_params($stream);
6030 6028
 		$result = isset($params["options"]["ssl"]["peer_certificate"]) ? true : false;
6031 6029
 	}
6032
-    return $result;
6030
+	return $result;
6033 6031
 }
6034 6032
 
6035 6033
 /**
Please login to merge, or discard this patch.
Spacing   +120 added lines, -120 removed lines patch added patch discarded remove patch
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
 			{
387 387
 				$val = 'CASE ';
388 388
 				foreach ($members as $k => $v)
389
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' ';
389
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . count(fetch_alerts($v, false, 0, array(), false)) . ' ';
390 390
 				$val = $val . ' END';
391 391
 				$type = 'raw';
392 392
 			}
@@ -817,7 +817,7 @@  discard block
 block discarded – undo
817 817
 			$unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400);
818 818
 		if (empty($unsupportedFormats))
819 819
 		{
820
-			foreach($strftimeFormatSubstitutions as $format => $substitution)
820
+			foreach ($strftimeFormatSubstitutions as $format => $substitution)
821 821
 			{
822 822
 				$value = @strftime('%' . $format);
823 823
 
@@ -1182,7 +1182,7 @@  discard block
 block discarded – undo
1182 1182
 					'height' => array('optional' => true, 'match' => '(\d+)'),
1183 1183
 				),
1184 1184
 				'content' => '$1',
1185
-				'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1185
+				'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1186 1186
 				{
1187 1187
 					$returnContext = '';
1188 1188
 
@@ -1217,7 +1217,7 @@  discard block
 block discarded – undo
1217 1217
 						}
1218 1218
 
1219 1219
 						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1220
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1220
+							$returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '" class="atc_img"></a>';
1221 1221
 						else
1222 1222
 							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1223 1223
 					}
@@ -1246,7 +1246,7 @@  discard block
 block discarded – undo
1246 1246
 				'type' => 'unparsed_content',
1247 1247
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1248 1248
 				// @todo Maybe this can be simplified?
1249
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1249
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1250 1250
 				{
1251 1251
 					if (!isset($disabled['code']))
1252 1252
 					{
@@ -1283,7 +1283,7 @@  discard block
 block discarded – undo
1283 1283
 				'type' => 'unparsed_equals_content',
1284 1284
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1285 1285
 				// @todo Maybe this can be simplified?
1286
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1286
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1287 1287
 				{
1288 1288
 					if (!isset($disabled['code']))
1289 1289
 					{
@@ -1327,7 +1327,7 @@  discard block
 block discarded – undo
1327 1327
 				'type' => 'unparsed_content',
1328 1328
 				'content' => '<a href="mailto:$1" class="bbc_email">$1</a>',
1329 1329
 				// @todo Should this respect guest_hideContacts?
1330
-				'validate' => function (&$tag, &$data, $disabled)
1330
+				'validate' => function(&$tag, &$data, $disabled)
1331 1331
 				{
1332 1332
 					$data = strtr($data, array('<br>' => ''));
1333 1333
 				},
@@ -1346,7 +1346,7 @@  discard block
 block discarded – undo
1346 1346
 				'type' => 'unparsed_commas_content',
1347 1347
 				'test' => '\d+,\d+\]',
1348 1348
 				'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">',
1349
-				'validate' => function (&$tag, &$data, $disabled)
1349
+				'validate' => function(&$tag, &$data, $disabled)
1350 1350
 				{
1351 1351
 					if (isset($disabled['url']))
1352 1352
 						$tag['content'] = '$1';
@@ -1362,7 +1362,7 @@  discard block
 block discarded – undo
1362 1362
 				'test' => '(left|right)(\s+max=\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)?\]',
1363 1363
 				'before' => '<div $1>',
1364 1364
 				'after' => '</div>',
1365
-				'validate' => function (&$tag, &$data, $disabled)
1365
+				'validate' => function(&$tag, &$data, $disabled)
1366 1366
 				{
1367 1367
 					$class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"';
1368 1368
 
@@ -1411,7 +1411,7 @@  discard block
 block discarded – undo
1411 1411
 					'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'),
1412 1412
 				),
1413 1413
 				'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">',
1414
-				'validate' => function (&$tag, &$data, $disabled)
1414
+				'validate' => function(&$tag, &$data, $disabled)
1415 1415
 				{
1416 1416
 					global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1417 1417
 
@@ -1434,7 +1434,7 @@  discard block
 block discarded – undo
1434 1434
 				'tag' => 'img',
1435 1435
 				'type' => 'unparsed_content',
1436 1436
 				'content' => '<img src="$1" alt="" class="bbc_img">',
1437
-				'validate' => function (&$tag, &$data, $disabled)
1437
+				'validate' => function(&$tag, &$data, $disabled)
1438 1438
 				{
1439 1439
 					global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1440 1440
 
@@ -1457,7 +1457,7 @@  discard block
 block discarded – undo
1457 1457
 				'tag' => 'iurl',
1458 1458
 				'type' => 'unparsed_content',
1459 1459
 				'content' => '<a href="$1" class="bbc_link">$1</a>',
1460
-				'validate' => function (&$tag, &$data, $disabled)
1460
+				'validate' => function(&$tag, &$data, $disabled)
1461 1461
 				{
1462 1462
 					$data = strtr($data, array('<br>' => ''));
1463 1463
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1471,7 +1471,7 @@  discard block
 block discarded – undo
1471 1471
 				'quoted' => 'optional',
1472 1472
 				'before' => '<a href="$1" class="bbc_link">',
1473 1473
 				'after' => '</a>',
1474
-				'validate' => function (&$tag, &$data, $disabled)
1474
+				'validate' => function(&$tag, &$data, $disabled)
1475 1475
 				{
1476 1476
 					if (substr($data, 0, 1) == '#')
1477 1477
 						$data = '#post_' . substr($data, 1);
@@ -1551,7 +1551,7 @@  discard block
 block discarded – undo
1551 1551
 				'tag' => 'php',
1552 1552
 				'type' => 'unparsed_content',
1553 1553
 				'content' => '<span class="phpcode">$1</span>',
1554
-				'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled)
1554
+				'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled)
1555 1555
 				{
1556 1556
 					if (!isset($disabled['php']))
1557 1557
 					{
@@ -1649,7 +1649,7 @@  discard block
 block discarded – undo
1649 1649
 				'test' => '[1-7]\]',
1650 1650
 				'before' => '<span style="font-size: $1;" class="bbc_size">',
1651 1651
 				'after' => '</span>',
1652
-				'validate' => function (&$tag, &$data, $disabled)
1652
+				'validate' => function(&$tag, &$data, $disabled)
1653 1653
 				{
1654 1654
 					$sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95);
1655 1655
 					$data = $sizes[$data] . 'em';
@@ -1687,7 +1687,7 @@  discard block
 block discarded – undo
1687 1687
 				'tag' => 'time',
1688 1688
 				'type' => 'unparsed_content',
1689 1689
 				'content' => '$1',
1690
-				'validate' => function (&$tag, &$data, $disabled)
1690
+				'validate' => function(&$tag, &$data, $disabled)
1691 1691
 				{
1692 1692
 					if (is_numeric($data))
1693 1693
 						$data = timeformat($data);
@@ -1715,7 +1715,7 @@  discard block
 block discarded – undo
1715 1715
 				'tag' => 'url',
1716 1716
 				'type' => 'unparsed_content',
1717 1717
 				'content' => '<a href="$1" class="bbc_link" target="_blank">$1</a>',
1718
-				'validate' => function (&$tag, &$data, $disabled)
1718
+				'validate' => function(&$tag, &$data, $disabled)
1719 1719
 				{
1720 1720
 					$data = strtr($data, array('<br>' => ''));
1721 1721
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1729,7 +1729,7 @@  discard block
 block discarded – undo
1729 1729
 				'quoted' => 'optional',
1730 1730
 				'before' => '<a href="$1" class="bbc_link" target="_blank">',
1731 1731
 				'after' => '</a>',
1732
-				'validate' => function (&$tag, &$data, $disabled)
1732
+				'validate' => function(&$tag, &$data, $disabled)
1733 1733
 				{
1734 1734
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1735 1735
 					if (empty($scheme))
@@ -1755,7 +1755,7 @@  discard block
 block discarded – undo
1755 1755
 		{
1756 1756
 			if (isset($temp_bbc))
1757 1757
 				$bbc_codes = $temp_bbc;
1758
-			usort($codes, function ($a, $b) {
1758
+			usort($codes, function($a, $b) {
1759 1759
 				return strcmp($a['tag'], $b['tag']);
1760 1760
 			});
1761 1761
 			return $codes;
@@ -1992,7 +1992,7 @@  discard block
 block discarded – undo
1992 1992
 										# a run of Unicode domain name characters and a dot
1993 1993
 										[\p{L}\p{M}\p{N}\-.:@]+\.
1994 1994
 										# and then a TLD valid in the DNS or the reserved "local" TLD
1995
-										(?:'. $modSettings['tld_regex'] .'|local)
1995
+										(?:'. $modSettings['tld_regex'] . '|local)
1996 1996
 									)
1997 1997
 									# followed by a non-domain character or end of line
1998 1998
 									(?=[^\p{L}\p{N}\-.]|$)
@@ -2060,7 +2060,7 @@  discard block
 block discarded – undo
2060 2060
 						)?
2061 2061
 						';
2062 2062
 
2063
-						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) {
2063
+						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) {
2064 2064
 							$url = array_shift($matches);
2065 2065
 
2066 2066
 							$scheme = parse_url($url, PHP_URL_SCHEME);
@@ -2800,7 +2800,7 @@  discard block
 block discarded – undo
2800 2800
 		for ($i = 0, $n = count($smileysfrom); $i < $n; $i++)
2801 2801
 		{
2802 2802
 			$specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES);
2803
-			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2803
+			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2804 2804
 
2805 2805
 			$smileyPregReplacements[$smileysfrom[$i]] = $smileyCode;
2806 2806
 
@@ -2817,7 +2817,7 @@  discard block
 block discarded – undo
2817 2817
 
2818 2818
 	// Replace away!
2819 2819
 	$message = preg_replace_callback($smileyPregSearch,
2820
-		function ($matches) use ($smileyPregReplacements)
2820
+		function($matches) use ($smileyPregReplacements)
2821 2821
 		{
2822 2822
 			return $smileyPregReplacements[$matches[1]];
2823 2823
 		}, $message);
@@ -2883,13 +2883,13 @@  discard block
 block discarded – undo
2883 2883
 	{
2884 2884
 		if (defined('SID') && SID != '')
2885 2885
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2886
-				function ($m) use ($scripturl)
2886
+				function($m) use ($scripturl)
2887 2887
 				{
2888
-					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
2888
+					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : "");
2889 2889
 				}, $setLocation);
2890 2890
 		else
2891 2891
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2892
-				function ($m) use ($scripturl)
2892
+				function($m) use ($scripturl)
2893 2893
 				{
2894 2894
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
2895 2895
 				}, $setLocation);
@@ -3212,7 +3212,7 @@  discard block
 block discarded – undo
3212 3212
 
3213 3213
 	// Add a generic "Are you sure?" confirmation message.
3214 3214
 	addInlineJavaScript('
3215
-	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3215
+	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';');
3216 3216
 
3217 3217
 	// Now add the capping code for avatars.
3218 3218
 	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
@@ -3573,7 +3573,7 @@  discard block
 block discarded – undo
3573 3573
 
3574 3574
 		else
3575 3575
 			echo '
3576
-	<script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>';
3576
+	<script src="', $settings['theme_url'], '/scripts/minified', ($do_deferred ? '_deferred' : ''), '.js', $minSeed, '"></script>';
3577 3577
 	}
3578 3578
 
3579 3579
 	// Inline JavaScript - Actually useful some times!
@@ -3651,14 +3651,14 @@  discard block
 block discarded – undo
3651 3651
 
3652 3652
 		else
3653 3653
 			echo '
3654
-	<link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">';
3654
+	<link rel="stylesheet" href="', $settings['theme_url'], '/css/minified.css', $minSeed, '">';
3655 3655
 	}
3656 3656
 
3657 3657
 	// Print the rest after the minified files.
3658 3658
 	if (!empty($normal))
3659 3659
 		foreach ($normal as $nf)
3660 3660
 			echo '
3661
-	<link rel="stylesheet" href="', $nf ,'">';
3661
+	<link rel="stylesheet" href="', $nf, '">';
3662 3662
 
3663 3663
 	if ($db_show_debug === true)
3664 3664
 	{
@@ -3674,7 +3674,7 @@  discard block
 block discarded – undo
3674 3674
 	<style>';
3675 3675
 
3676 3676
 		foreach ($context['css_header'] as $css)
3677
-			echo $css .'
3677
+			echo $css . '
3678 3678
 	';
3679 3679
 
3680 3680
 		echo'
@@ -3703,27 +3703,27 @@  discard block
 block discarded – undo
3703 3703
 		return false;
3704 3704
 
3705 3705
 	// Did we already did this?
3706
-	$toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400);
3706
+	$toCache = cache_get_data('minimized_' . $settings['theme_id'] . '_' . $type, 86400);
3707 3707
 
3708 3708
 	// Already done?
3709 3709
 	if (!empty($toCache))
3710 3710
 		return true;
3711 3711
 
3712 3712
 	// No namespaces, sorry!
3713
-	$classType = 'MatthiasMullie\\Minify\\'. strtoupper($type);
3713
+	$classType = 'MatthiasMullie\\Minify\\' . strtoupper($type);
3714 3714
 
3715 3715
 	// Temp path.
3716
-	$cTempPath = $settings['theme_dir'] .'/'. ($type == 'css' ? 'css' : 'scripts') .'/';
3716
+	$cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/';
3717 3717
 
3718 3718
 	// What kind of file are we going to create?
3719
-	$toCreate = $cTempPath .'minified'. ($do_deferred ? '_deferred' : '') .'.'. $type;
3719
+	$toCreate = $cTempPath . 'minified' . ($do_deferred ? '_deferred' : '') . '.' . $type;
3720 3720
 
3721 3721
 	// File has to exists, if it isn't try to create it.
3722 3722
 	if ((!file_exists($toCreate) && @fopen($toCreate, 'w') === false) || !smf_chmod($toCreate))
3723 3723
 	{
3724 3724
 		loadLanguage('Errors');
3725 3725
 		log_error(sprintf($txt['file_not_created'], $toCreate), 'general');
3726
-		cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null);
3726
+		cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null);
3727 3727
 
3728 3728
 		// The process failed so roll back to print each individual file.
3729 3729
 		return $data;
@@ -3758,14 +3758,14 @@  discard block
 block discarded – undo
3758 3758
 	{
3759 3759
 		loadLanguage('Errors');
3760 3760
 		log_error(sprintf($txt['file_not_created'], $toCreate), 'general');
3761
-		cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null);
3761
+		cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null);
3762 3762
 
3763 3763
 		// The process failed so roll back to print each individual file.
3764 3764
 		return $data;
3765 3765
 	}
3766 3766
 
3767 3767
 	// And create a long lived cache entry.
3768
-	cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, $toCreate, 86400);
3768
+	cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, $toCreate, 86400);
3769 3769
 
3770 3770
 	return true;
3771 3771
 }
@@ -3825,7 +3825,7 @@  discard block
 block discarded – undo
3825 3825
 	else
3826 3826
 		$path = $modSettings['attachmentUploadDir'];
3827 3827
 
3828
-	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
3828
+	return $path . '/' . $attachment_id . '_' . $file_hash . '.dat';
3829 3829
 }
3830 3830
 
3831 3831
 /**
@@ -3869,10 +3869,10 @@  discard block
 block discarded – undo
3869 3869
 		$valid_low = isValidIP($ip_parts[0]);
3870 3870
 		$valid_high = isValidIP($ip_parts[1]);
3871 3871
 		$count = 0;
3872
-		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
3872
+		$mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.');
3873 3873
 		$max = ($mode == ':' ? 'ffff' : '255');
3874 3874
 		$min = 0;
3875
-		if(!$valid_low)
3875
+		if (!$valid_low)
3876 3876
 		{
3877 3877
 			$ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]);
3878 3878
 			$valid_low = isValidIP($ip_parts[0]);
@@ -3886,7 +3886,7 @@  discard block
 block discarded – undo
3886 3886
 		}
3887 3887
 
3888 3888
 		$count = 0;
3889
-		if(!$valid_high)
3889
+		if (!$valid_high)
3890 3890
 		{
3891 3891
 			$ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]);
3892 3892
 			$valid_high = isValidIP($ip_parts[1]);
@@ -3899,7 +3899,7 @@  discard block
 block discarded – undo
3899 3899
 			}
3900 3900
 		}
3901 3901
 
3902
-		if($valid_high && $valid_low)
3902
+		if ($valid_high && $valid_low)
3903 3903
 		{
3904 3904
 			$ip_array['low'] = $ip_parts[0];
3905 3905
 			$ip_array['high'] = $ip_parts[1];
@@ -4081,7 +4081,7 @@  discard block
 block discarded – undo
4081 4081
 		addInlineJavaScript('
4082 4082
 	var user_menus = new smc_PopupMenu();
4083 4083
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
4084
-	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
4084
+	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true);
4085 4085
 		if ($context['allow_pm'])
4086 4086
 			addInlineJavaScript('
4087 4087
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
@@ -4701,7 +4701,7 @@  discard block
 block discarded – undo
4701 4701
 		// No? try a fallback to $sourcedir
4702 4702
 		else
4703 4703
 		{
4704
-			$absPath = $sourcedir .'/'. $file;
4704
+			$absPath = $sourcedir . '/' . $file;
4705 4705
 
4706 4706
 			if (file_exists($absPath))
4707 4707
 				require_once($absPath);
@@ -4782,15 +4782,15 @@  discard block
 block discarded – undo
4782 4782
 
4783 4783
 	// UTF-8 occurences of MS special characters
4784 4784
 	$findchars_utf8 = array(
4785
-		"\xe2\x80\x9a",	// single low-9 quotation mark
4786
-		"\xe2\x80\x9e",	// double low-9 quotation mark
4787
-		"\xe2\x80\xa6",	// horizontal ellipsis
4788
-		"\xe2\x80\x98",	// left single curly quote
4789
-		"\xe2\x80\x99",	// right single curly quote
4790
-		"\xe2\x80\x9c",	// left double curly quote
4791
-		"\xe2\x80\x9d",	// right double curly quote
4792
-		"\xe2\x80\x93",	// en dash
4793
-		"\xe2\x80\x94",	// em dash
4785
+		"\xe2\x80\x9a", // single low-9 quotation mark
4786
+		"\xe2\x80\x9e", // double low-9 quotation mark
4787
+		"\xe2\x80\xa6", // horizontal ellipsis
4788
+		"\xe2\x80\x98", // left single curly quote
4789
+		"\xe2\x80\x99", // right single curly quote
4790
+		"\xe2\x80\x9c", // left double curly quote
4791
+		"\xe2\x80\x9d", // right double curly quote
4792
+		"\xe2\x80\x93", // en dash
4793
+		"\xe2\x80\x94", // em dash
4794 4794
 	);
4795 4795
 
4796 4796
 	// windows 1252 / iso equivalents
@@ -4808,15 +4808,15 @@  discard block
 block discarded – undo
4808 4808
 
4809 4809
 	// safe replacements
4810 4810
 	$replacechars = array(
4811
-		',',	// &sbquo;
4812
-		',,',	// &bdquo;
4813
-		'...',	// &hellip;
4814
-		"'",	// &lsquo;
4815
-		"'",	// &rsquo;
4816
-		'"',	// &ldquo;
4817
-		'"',	// &rdquo;
4818
-		'-',	// &ndash;
4819
-		'--',	// &mdash;
4811
+		',', // &sbquo;
4812
+		',,', // &bdquo;
4813
+		'...', // &hellip;
4814
+		"'", // &lsquo;
4815
+		"'", // &rsquo;
4816
+		'"', // &ldquo;
4817
+		'"', // &rdquo;
4818
+		'-', // &ndash;
4819
+		'--', // &mdash;
4820 4820
 	);
4821 4821
 
4822 4822
 	if ($context['utf8'])
@@ -5234,7 +5234,7 @@  discard block
 block discarded – undo
5234 5234
  */
5235 5235
 function inet_dtop($bin)
5236 5236
 {
5237
-	if(empty($bin))
5237
+	if (empty($bin))
5238 5238
 		return '';
5239 5239
 
5240 5240
 	global $db_type;
@@ -5265,28 +5265,28 @@  discard block
 block discarded – undo
5265 5265
  */
5266 5266
 function _safe_serialize($value)
5267 5267
 {
5268
-	if(is_null($value))
5268
+	if (is_null($value))
5269 5269
 		return 'N;';
5270 5270
 
5271
-	if(is_bool($value))
5272
-		return 'b:'. (int) $value .';';
5271
+	if (is_bool($value))
5272
+		return 'b:' . (int) $value . ';';
5273 5273
 
5274
-	if(is_int($value))
5275
-		return 'i:'. $value .';';
5274
+	if (is_int($value))
5275
+		return 'i:' . $value . ';';
5276 5276
 
5277
-	if(is_float($value))
5278
-		return 'd:'. str_replace(',', '.', $value) .';';
5277
+	if (is_float($value))
5278
+		return 'd:' . str_replace(',', '.', $value) . ';';
5279 5279
 
5280
-	if(is_string($value))
5281
-		return 's:'. strlen($value) .':"'. $value .'";';
5280
+	if (is_string($value))
5281
+		return 's:' . strlen($value) . ':"' . $value . '";';
5282 5282
 
5283
-	if(is_array($value))
5283
+	if (is_array($value))
5284 5284
 	{
5285 5285
 		$out = '';
5286
-		foreach($value as $k => $v)
5286
+		foreach ($value as $k => $v)
5287 5287
 			$out .= _safe_serialize($k) . _safe_serialize($v);
5288 5288
 
5289
-		return 'a:'. count($value) .':{'. $out .'}';
5289
+		return 'a:' . count($value) . ':{' . $out . '}';
5290 5290
 	}
5291 5291
 
5292 5292
 	// safe_serialize cannot serialize resources or objects.
@@ -5328,7 +5328,7 @@  discard block
 block discarded – undo
5328 5328
 function _safe_unserialize($str)
5329 5329
 {
5330 5330
 	// Input  is not a string.
5331
-	if(empty($str) || !is_string($str))
5331
+	if (empty($str) || !is_string($str))
5332 5332
 		return false;
5333 5333
 
5334 5334
 	$stack = array();
@@ -5342,40 +5342,40 @@  discard block
 block discarded – undo
5342 5342
 	 *   3 - in array, expecting value or another array
5343 5343
 	 */
5344 5344
 	$state = 0;
5345
-	while($state != 1)
5345
+	while ($state != 1)
5346 5346
 	{
5347 5347
 		$type = isset($str[0]) ? $str[0] : '';
5348
-		if($type == '}')
5348
+		if ($type == '}')
5349 5349
 			$str = substr($str, 1);
5350 5350
 
5351
-		else if($type == 'N' && $str[1] == ';')
5351
+		else if ($type == 'N' && $str[1] == ';')
5352 5352
 		{
5353 5353
 			$value = null;
5354 5354
 			$str = substr($str, 2);
5355 5355
 		}
5356
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5356
+		else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5357 5357
 		{
5358 5358
 			$value = $matches[1] == '1' ? true : false;
5359 5359
 			$str = substr($str, 4);
5360 5360
 		}
5361
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5361
+		else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5362 5362
 		{
5363
-			$value = (int)$matches[1];
5363
+			$value = (int) $matches[1];
5364 5364
 			$str = $matches[2];
5365 5365
 		}
5366
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5366
+		else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5367 5367
 		{
5368
-			$value = (float)$matches[1];
5368
+			$value = (float) $matches[1];
5369 5369
 			$str = $matches[3];
5370 5370
 		}
5371
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5371
+		else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";')
5372 5372
 		{
5373
-			$value = substr($matches[2], 0, (int)$matches[1]);
5374
-			$str = substr($matches[2], (int)$matches[1] + 2);
5373
+			$value = substr($matches[2], 0, (int) $matches[1]);
5374
+			$str = substr($matches[2], (int) $matches[1] + 2);
5375 5375
 		}
5376
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5376
+		else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5377 5377
 		{
5378
-			$expectedLength = (int)$matches[1];
5378
+			$expectedLength = (int) $matches[1];
5379 5379
 			$str = $matches[2];
5380 5380
 		}
5381 5381
 
@@ -5383,10 +5383,10 @@  discard block
 block discarded – undo
5383 5383
 		else
5384 5384
 			return false;
5385 5385
 
5386
-		switch($state)
5386
+		switch ($state)
5387 5387
 		{
5388 5388
 			case 3: // In array, expecting value or another array.
5389
-				if($type == 'a')
5389
+				if ($type == 'a')
5390 5390
 				{
5391 5391
 					$stack[] = &$list;
5392 5392
 					$list[$key] = array();
@@ -5395,7 +5395,7 @@  discard block
 block discarded – undo
5395 5395
 					$state = 2;
5396 5396
 					break;
5397 5397
 				}
5398
-				if($type != '}')
5398
+				if ($type != '}')
5399 5399
 				{
5400 5400
 					$list[$key] = $value;
5401 5401
 					$state = 2;
@@ -5406,29 +5406,29 @@  discard block
 block discarded – undo
5406 5406
 				return false;
5407 5407
 
5408 5408
 			case 2: // in array, expecting end of array or a key
5409
-				if($type == '}')
5409
+				if ($type == '}')
5410 5410
 				{
5411 5411
 					// Array size is less than expected.
5412
-					if(count($list) < end($expected))
5412
+					if (count($list) < end($expected))
5413 5413
 						return false;
5414 5414
 
5415 5415
 					unset($list);
5416
-					$list = &$stack[count($stack)-1];
5416
+					$list = &$stack[count($stack) - 1];
5417 5417
 					array_pop($stack);
5418 5418
 
5419 5419
 					// Go to terminal state if we're at the end of the root array.
5420 5420
 					array_pop($expected);
5421 5421
 
5422
-					if(count($expected) == 0)
5422
+					if (count($expected) == 0)
5423 5423
 						$state = 1;
5424 5424
 
5425 5425
 					break;
5426 5426
 				}
5427 5427
 
5428
-				if($type == 'i' || $type == 's')
5428
+				if ($type == 'i' || $type == 's')
5429 5429
 				{
5430 5430
 					// Array size exceeds expected length.
5431
-					if(count($list) >= end($expected))
5431
+					if (count($list) >= end($expected))
5432 5432
 						return false;
5433 5433
 
5434 5434
 					$key = $value;
@@ -5441,7 +5441,7 @@  discard block
 block discarded – undo
5441 5441
 
5442 5442
 			// Expecting array or value.
5443 5443
 			case 0:
5444
-				if($type == 'a')
5444
+				if ($type == 'a')
5445 5445
 				{
5446 5446
 					$data = array();
5447 5447
 					$list = &$data;
@@ -5450,7 +5450,7 @@  discard block
 block discarded – undo
5450 5450
 					break;
5451 5451
 				}
5452 5452
 
5453
-				if($type != '}')
5453
+				if ($type != '}')
5454 5454
 				{
5455 5455
 					$data = $value;
5456 5456
 					$state = 1;
@@ -5463,7 +5463,7 @@  discard block
 block discarded – undo
5463 5463
 	}
5464 5464
 
5465 5465
 	// Trailing data in input.
5466
-	if(!empty($str))
5466
+	if (!empty($str))
5467 5467
 		return false;
5468 5468
 
5469 5469
 	return $data;
@@ -5517,7 +5517,7 @@  discard block
 block discarded – undo
5517 5517
 	// Set different modes.
5518 5518
 	$chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666);
5519 5519
 
5520
-	foreach($chmodValues as $val)
5520
+	foreach ($chmodValues as $val)
5521 5521
 	{
5522 5522
 		// If it's writable, break out of the loop.
5523 5523
 		if (is_writable($file))
@@ -5552,13 +5552,13 @@  discard block
 block discarded – undo
5552 5552
 	$returnArray = @json_decode($json, $returnAsArray);
5553 5553
 
5554 5554
 	// PHP 5.3 so no json_last_error_msg()
5555
-	switch(json_last_error())
5555
+	switch (json_last_error())
5556 5556
 	{
5557 5557
 		case JSON_ERROR_NONE:
5558 5558
 			$jsonError = false;
5559 5559
 			break;
5560 5560
 		case JSON_ERROR_DEPTH:
5561
-			$jsonError =  'JSON_ERROR_DEPTH';
5561
+			$jsonError = 'JSON_ERROR_DEPTH';
5562 5562
 			break;
5563 5563
 		case JSON_ERROR_STATE_MISMATCH:
5564 5564
 			$jsonError = 'JSON_ERROR_STATE_MISMATCH';
@@ -5586,10 +5586,10 @@  discard block
 block discarded – undo
5586 5586
 		loadLanguage('Errors');
5587 5587
 
5588 5588
 		if (!empty($jsonDebug))
5589
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5589
+			log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5590 5590
 
5591 5591
 		else
5592
-			log_error($txt['json_'. $jsonError], 'critical');
5592
+			log_error($txt['json_' . $jsonError], 'critical');
5593 5593
 
5594 5594
 		// Everyone expects an array.
5595 5595
 		return array();
@@ -5701,7 +5701,7 @@  discard block
 block discarded – undo
5701 5701
 		});
5702 5702
 
5703 5703
 		// Convert Punycode to Unicode
5704
-		$tlds = array_map(function ($input) {
5704
+		$tlds = array_map(function($input) {
5705 5705
 			$prefix = 'xn--';
5706 5706
 			$safe_char = 0xFFFC;
5707 5707
 			$base = 36;
@@ -5717,7 +5717,7 @@  discard block
 block discarded – undo
5717 5717
 
5718 5718
 			foreach ($enco_parts as $encoded)
5719 5719
 			{
5720
-				if (strpos($encoded,$prefix) !== 0 || strlen(trim(str_replace($prefix,'',$encoded))) == 0)
5720
+				if (strpos($encoded, $prefix) !== 0 || strlen(trim(str_replace($prefix, '', $encoded))) == 0)
5721 5721
 				{
5722 5722
 					$output_parts[] = $encoded;
5723 5723
 					continue;
@@ -5728,7 +5728,7 @@  discard block
 block discarded – undo
5728 5728
 				$idx = 0;
5729 5729
 				$char = 0x80;
5730 5730
 				$decoded = array();
5731
-				$output='';
5731
+				$output = '';
5732 5732
 				$delim_pos = strrpos($encoded, '-');
5733 5733
 
5734 5734
 				if ($delim_pos > strlen($prefix))
@@ -5744,7 +5744,7 @@  discard block
 block discarded – undo
5744 5744
 
5745 5745
 				for ($enco_idx = $delim_pos ? ($delim_pos + 1) : 0; $enco_idx < $enco_len; ++$deco_len)
5746 5746
 				{
5747
-					for ($old_idx = $idx, $w = 1, $k = $base; 1 ; $k += $base)
5747
+					for ($old_idx = $idx, $w = 1, $k = $base; 1; $k += $base)
5748 5748
 					{
5749 5749
 						$cp = ord($encoded{$enco_idx++});
5750 5750
 						$digit = ($cp - 48 < 10) ? $cp - 22 : (($cp - 65 < 26) ? $cp - 65 : (($cp - 97 < 26) ? $cp - 97 : $base));
@@ -5785,15 +5785,15 @@  discard block
 block discarded – undo
5785 5785
 
5786 5786
 					// 2 bytes
5787 5787
 					elseif ($v < (1 << 11))
5788
-						$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
5788
+						$output .= chr(192 + ($v >> 6)) . chr(128 + ($v & 63));
5789 5789
 
5790 5790
 					// 3 bytes
5791 5791
 					elseif ($v < (1 << 16))
5792
-						$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5792
+						$output .= chr(224 + ($v >> 12)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63));
5793 5793
 
5794 5794
 					// 4 bytes
5795 5795
 					elseif ($v < (1 << 21))
5796
-						$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5796
+						$output .= chr(240 + ($v >> 18)) . chr(128 + (($v >> 12) & 63)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63));
5797 5797
 
5798 5798
 					//  'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k
5799 5799
 					else
@@ -5898,7 +5898,7 @@  discard block
 block discarded – undo
5898 5898
 	}
5899 5899
 
5900 5900
 	// This recursive function creates the index array from the strings
5901
-	$add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
5901
+	$add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
5902 5902
 	{
5903 5903
 		static $depth = 0;
5904 5904
 		$depth++;
@@ -5925,7 +5925,7 @@  discard block
 block discarded – undo
5925 5925
 	};
5926 5926
 
5927 5927
 	// This recursive function turns the index array into a regular expression
5928
-	$index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex)
5928
+	$index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex)
5929 5929
 	{
5930 5930
 		static $depth = 0;
5931 5931
 		$depth++;
@@ -5949,11 +5949,11 @@  discard block
 block discarded – undo
5949 5949
 
5950 5950
 				if (count(array_keys($value)) == 1)
5951 5951
 				{
5952
-					$new_key_array = explode('(?'.'>', $sub_regex);
5952
+					$new_key_array = explode('(?' . '>', $sub_regex);
5953 5953
 					$new_key .= $new_key_array[0];
5954 5954
 				}
5955 5955
 				else
5956
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
5956
+					$sub_regex = '(?' . '>' . $sub_regex . ')';
5957 5957
 			}
5958 5958
 
5959 5959
 			if ($depth > 1)
@@ -5996,10 +5996,10 @@  discard block
 block discarded – undo
5996 5996
 	{
5997 5997
 		$regex = array();
5998 5998
 		while (!empty($index))
5999
-			$regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
5999
+			$regex[] = '(?' . '>' . $index_to_regex($index, $delim) . ')';
6000 6000
 	}
6001 6001
 	else
6002
-		$regex = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6002
+		$regex = '(?' . '>' . $index_to_regex($index, $delim) . ')';
6003 6003
 
6004 6004
 	// Restore PHP's internal character encoding to whatever it was originally
6005 6005
 	if (!empty($current_encoding))
Please login to merge, or discard this patch.