Completed
Pull Request — release-2.1 (#4892)
by Mathias
09:39
created
Sources/ManageSettings.php 1 patch
Braces   +279 added lines, -203 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * This function makes sure the requested subaction does exists, if it doesn't, it sets a default action or.
@@ -210,16 +211,18 @@  discard block
 block discarded – undo
210 211
 	{
211 212
 		$all_zones = timezone_identifiers_list();
212 213
 		// Make sure we set the value to the same as the printed value.
213
-		foreach ($all_zones as $zone)
214
-			$config_vars['default_timezone'][2][$zone] = $zone;
214
+		foreach ($all_zones as $zone) {
215
+					$config_vars['default_timezone'][2][$zone] = $zone;
216
+		}
217
+	} else {
218
+			unset($config_vars['default_timezone']);
215 219
 	}
216
-	else
217
-		unset($config_vars['default_timezone']);
218 220
 
219 221
 	call_integration_hook('integrate_modify_basic_settings', array(&$config_vars));
220 222
 
221
-	if ($return_config)
222
-		return $config_vars;
223
+	if ($return_config) {
224
+			return $config_vars;
225
+	}
223 226
 
224 227
 	// Saving?
225 228
 	if (isset($_GET['save']))
@@ -227,8 +230,9 @@  discard block
 block discarded – undo
227 230
 		checkSession();
228 231
 
229 232
 		// Prevent absurd boundaries here - make it a day tops.
230
-		if (isset($_POST['lastActive']))
231
-			$_POST['lastActive'] = min((int) $_POST['lastActive'], 1440);
233
+		if (isset($_POST['lastActive'])) {
234
+					$_POST['lastActive'] = min((int) $_POST['lastActive'], 1440);
235
+		}
232 236
 
233 237
 		call_integration_hook('integrate_save_basic_settings');
234 238
 
@@ -236,8 +240,9 @@  discard block
 block discarded – undo
236 240
 		$_SESSION['adm-save'] = true;
237 241
 
238 242
 		// Do a bit of housekeeping
239
-		if (empty($_POST['minimize_files']))
240
-			deleteAllMinified();
243
+		if (empty($_POST['minimize_files'])) {
244
+					deleteAllMinified();
245
+		}
241 246
 
242 247
 		writeLog();
243 248
 		redirectexit('action=admin;area=featuresettings;sa=basic');
@@ -277,8 +282,9 @@  discard block
 block discarded – undo
277 282
 
278 283
 	call_integration_hook('integrate_modify_bbc_settings', array(&$config_vars));
279 284
 
280
-	if ($return_config)
281
-		return $config_vars;
285
+	if ($return_config) {
286
+			return $config_vars;
287
+	}
282 288
 
283 289
 	// Setup the template.
284 290
 	require_once($sourcedir . '/ManageServer.php');
@@ -295,13 +301,15 @@  discard block
 block discarded – undo
295 301
 
296 302
 		// Clean up the tags.
297 303
 		$bbcTags = array();
298
-		foreach (parse_bbc(false) as $tag)
299
-			$bbcTags[] = $tag['tag'];
304
+		foreach (parse_bbc(false) as $tag) {
305
+					$bbcTags[] = $tag['tag'];
306
+		}
300 307
 
301
-		if (!isset($_POST['disabledBBC_enabledTags']))
302
-			$_POST['disabledBBC_enabledTags'] = array();
303
-		elseif (!is_array($_POST['disabledBBC_enabledTags']))
304
-			$_POST['disabledBBC_enabledTags'] = array($_POST['disabledBBC_enabledTags']);
308
+		if (!isset($_POST['disabledBBC_enabledTags'])) {
309
+					$_POST['disabledBBC_enabledTags'] = array();
310
+		} elseif (!is_array($_POST['disabledBBC_enabledTags'])) {
311
+					$_POST['disabledBBC_enabledTags'] = array($_POST['disabledBBC_enabledTags']);
312
+		}
305 313
 		// Work out what is actually disabled!
306 314
 		$_POST['disabledBBC'] = implode(',', array_diff($bbcTags, $_POST['disabledBBC_enabledTags']));
307 315
 
@@ -345,8 +353,9 @@  discard block
 block discarded – undo
345 353
 
346 354
 	call_integration_hook('integrate_layout_settings', array(&$config_vars));
347 355
 
348
-	if ($return_config)
349
-		return $config_vars;
356
+	if ($return_config) {
357
+			return $config_vars;
358
+	}
350 359
 
351 360
 	// Saving?
352 361
 	if (isset($_GET['save']))
@@ -386,8 +395,9 @@  discard block
 block discarded – undo
386 395
 
387 396
 	call_integration_hook('integrate_likes_settings', array(&$config_vars));
388 397
 
389
-	if ($return_config)
390
-		return $config_vars;
398
+	if ($return_config) {
399
+			return $config_vars;
400
+	}
391 401
 
392 402
 	// Saving?
393 403
 	if (isset($_GET['save']))
@@ -425,8 +435,9 @@  discard block
 block discarded – undo
425 435
 
426 436
 	call_integration_hook('integrate_mentions_settings', array(&$config_vars));
427 437
 
428
-	if ($return_config)
429
-		return $config_vars;
438
+	if ($return_config) {
439
+			return $config_vars;
440
+	}
430 441
 
431 442
 	// Saving?
432 443
 	if (isset($_GET['save']))
@@ -470,8 +481,8 @@  discard block
 block discarded – undo
470 481
 			'enable' => array('check', 'warning_enable'),
471 482
 	);
472 483
 
473
-	if (!empty($modSettings['warning_settings']) && $currently_enabled)
474
-		$config_vars += array(
484
+	if (!empty($modSettings['warning_settings']) && $currently_enabled) {
485
+			$config_vars += array(
475 486
 			'',
476 487
 				array('int', 'warning_watch', 'subtext' => $txt['setting_warning_watch_note'] . ' ' . $txt['zero_to_disable']),
477 488
 				'moderate' => array('int', 'warning_moderate', 'subtext' => $txt['setting_warning_moderate_note'] . ' ' . $txt['zero_to_disable']),
@@ -480,15 +491,18 @@  discard block
 block discarded – undo
480 491
 				'rem2' => array('int', 'warning_decrement', 'subtext' => $txt['setting_warning_decrement_note'] . ' ' . $txt['zero_to_disable']),
481 492
 				array('permissions', 'view_warning'),
482 493
 		);
494
+	}
483 495
 
484 496
 	call_integration_hook('integrate_warning_settings', array(&$config_vars));
485 497
 
486
-	if ($return_config)
487
-		return $config_vars;
498
+	if ($return_config) {
499
+			return $config_vars;
500
+	}
488 501
 
489 502
 	// Cannot use moderation if post moderation is not enabled.
490
-	if (!$modSettings['postmod_active'])
491
-		unset($config_vars['moderate']);
503
+	if (!$modSettings['postmod_active']) {
504
+			unset($config_vars['moderate']);
505
+	}
492 506
 
493 507
 	// Will need the utility functions from here.
494 508
 	require_once($sourcedir . '/ManageServer.php');
@@ -513,16 +527,16 @@  discard block
 block discarded – undo
513 527
 				'warning_watch' => 10,
514 528
 				'warning_mute' => 60,
515 529
 			);
516
-			if ($modSettings['postmod_active'])
517
-				$vars['warning_moderate'] = 35;
530
+			if ($modSettings['postmod_active']) {
531
+							$vars['warning_moderate'] = 35;
532
+			}
518 533
 
519 534
 			foreach ($vars as $var => $value)
520 535
 			{
521 536
 				$config_vars[] = array('int', $var);
522 537
 				$_POST[$var] = $value;
523 538
 			}
524
-		}
525
-		else
539
+		} else
526 540
 		{
527 541
 			$_POST['warning_watch'] = min($_POST['warning_watch'], 100);
528 542
 			$_POST['warning_moderate'] = $modSettings['postmod_active'] ? min($_POST['warning_moderate'], 100) : 0;
@@ -610,8 +624,9 @@  discard block
 block discarded – undo
610 624
 
611 625
 	call_integration_hook('integrate_spam_settings', array(&$config_vars));
612 626
 
613
-	if ($return_config)
614
-		return $config_vars;
627
+	if ($return_config) {
628
+			return $config_vars;
629
+	}
615 630
 
616 631
 	// You need to be an admin to edit settings!
617 632
 	isAllowedTo('admin_forum');
@@ -645,8 +660,9 @@  discard block
 block discarded – undo
645 660
 
646 661
 	if (empty($context['qa_by_lang'][strtr($language, array('-utf8' => ''))]) && !empty($context['question_answers']))
647 662
 	{
648
-		if (empty($context['settings_insert_above']))
649
-			$context['settings_insert_above'] = '';
663
+		if (empty($context['settings_insert_above'])) {
664
+					$context['settings_insert_above'] = '';
665
+		}
650 666
 
651 667
 		$context['settings_insert_above'] .= '<div class="noticebox">' . sprintf($txt['question_not_defined'], $context['languages'][$language]['name']) . '</div>';
652 668
 	}
@@ -688,8 +704,9 @@  discard block
 block discarded – undo
688 704
 		$_POST['pm_spam_settings'] = (int) $_POST['max_pm_recipients'] . ',' . (int) $_POST['pm_posts_verification'] . ',' . (int) $_POST['pm_posts_per_hour'];
689 705
 
690 706
 		// Hack in guest requiring verification!
691
-		if (empty($_POST['posts_require_captcha']) && !empty($_POST['guests_require_captcha']))
692
-			$_POST['posts_require_captcha'] = -1;
707
+		if (empty($_POST['posts_require_captcha']) && !empty($_POST['guests_require_captcha'])) {
708
+					$_POST['posts_require_captcha'] = -1;
709
+		}
693 710
 
694 711
 		$save_vars = $config_vars;
695 712
 		unset($save_vars['pm1'], $save_vars['pm2'], $save_vars['pm3'], $save_vars['guest_verify']);
@@ -706,14 +723,16 @@  discard block
 block discarded – undo
706 723
 		foreach ($context['qa_languages'] as $lang_id => $dummy)
707 724
 		{
708 725
 			// If we had some questions for this language before, but don't now, delete everything from that language.
709
-			if ((!isset($_POST['question'][$lang_id]) || !is_array($_POST['question'][$lang_id])) && !empty($context['qa_by_lang'][$lang_id]))
710
-				$changes['delete'] = array_merge($questions['delete'], $context['qa_by_lang'][$lang_id]);
726
+			if ((!isset($_POST['question'][$lang_id]) || !is_array($_POST['question'][$lang_id])) && !empty($context['qa_by_lang'][$lang_id])) {
727
+							$changes['delete'] = array_merge($questions['delete'], $context['qa_by_lang'][$lang_id]);
728
+			}
711 729
 
712 730
 			// Now step through and see if any existing questions no longer exist.
713
-			if (!empty($context['qa_by_lang'][$lang_id]))
714
-				foreach ($context['qa_by_lang'][$lang_id] as $q_id)
731
+			if (!empty($context['qa_by_lang'][$lang_id])) {
732
+							foreach ($context['qa_by_lang'][$lang_id] as $q_id)
715 733
 					if (empty($_POST['question'][$lang_id][$q_id]))
716 734
 						$changes['delete'][] = $q_id;
735
+			}
717 736
 
718 737
 			// Now let's see if there are new questions or ones that need updating.
719 738
 			if (isset($_POST['question'][$lang_id]))
@@ -722,14 +741,16 @@  discard block
 block discarded – undo
722 741
 				{
723 742
 					// Ignore junky ids.
724 743
 					$q_id = (int) $q_id;
725
-					if ($q_id <= 0)
726
-						continue;
744
+					if ($q_id <= 0) {
745
+											continue;
746
+					}
727 747
 
728 748
 					// Check the question isn't empty (because they want to delete it?)
729 749
 					if (empty($question) || trim($question) == '')
730 750
 					{
731
-						if (isset($context['question_answers'][$q_id]))
732
-							$changes['delete'][] = $q_id;
751
+						if (isset($context['question_answers'][$q_id])) {
752
+													$changes['delete'][] = $q_id;
753
+						}
733 754
 						continue;
734 755
 					}
735 756
 					$question = $smcFunc['htmlspecialchars'](trim($question));
@@ -737,19 +758,22 @@  discard block
 block discarded – undo
737 758
 					// Get the answers. Firstly check there actually might be some.
738 759
 					if (!isset($_POST['answer'][$lang_id][$q_id]) || !is_array($_POST['answer'][$lang_id][$q_id]))
739 760
 					{
740
-						if (isset($context['question_answers'][$q_id]))
741
-							$changes['delete'][] = $q_id;
761
+						if (isset($context['question_answers'][$q_id])) {
762
+													$changes['delete'][] = $q_id;
763
+						}
742 764
 						continue;
743 765
 					}
744 766
 					// Now get them and check that they might be viable.
745 767
 					$answers = array();
746
-					foreach ($_POST['answer'][$lang_id][$q_id] as $answer)
747
-						if (!empty($answer) && trim($answer) !== '')
768
+					foreach ($_POST['answer'][$lang_id][$q_id] as $answer) {
769
+											if (!empty($answer) && trim($answer) !== '')
748 770
 							$answers[] = $smcFunc['htmlspecialchars'](trim($answer));
771
+					}
749 772
 					if (empty($answers))
750 773
 					{
751
-						if (isset($context['question_answers'][$q_id]))
752
-							$changes['delete'][] = $q_id;
774
+						if (isset($context['question_answers'][$q_id])) {
775
+													$changes['delete'][] = $q_id;
776
+						}
753 777
 						continue;
754 778
 					}
755 779
 					$answers = $smcFunc['json_encode']($answers);
@@ -759,16 +783,17 @@  discard block
 block discarded – undo
759 783
 					{
760 784
 						// New question. Now, we don't want to randomly consume ids, so we'll set those, rather than trusting the browser's supplied ids.
761 785
 						$changes['insert'][] = array($lang_id, $question, $answers);
762
-					}
763
-					else
786
+					} else
764 787
 					{
765 788
 						// It's an existing question. Let's see what's changed, if anything.
766
-						if ($lang_id != $context['question_answers'][$q_id]['lngfile'] || $question != $context['question_answers'][$q_id]['question'] || $answers != $context['question_answers'][$q_id]['answers'])
767
-							$changes['replace'][$q_id] = array('lngfile' => $lang_id, 'question' => $question, 'answers' => $answers);
789
+						if ($lang_id != $context['question_answers'][$q_id]['lngfile'] || $question != $context['question_answers'][$q_id]['question'] || $answers != $context['question_answers'][$q_id]['answers']) {
790
+													$changes['replace'][$q_id] = array('lngfile' => $lang_id, 'question' => $question, 'answers' => $answers);
791
+						}
768 792
 					}
769 793
 
770
-					if (!isset($qs_per_lang[$lang_id]))
771
-						$qs_per_lang[$lang_id] = 0;
794
+					if (!isset($qs_per_lang[$lang_id])) {
795
+											$qs_per_lang[$lang_id] = 0;
796
+					}
772 797
 					$qs_per_lang[$lang_id]++;
773 798
 				}
774 799
 			}
@@ -818,8 +843,9 @@  discard block
 block discarded – undo
818 843
 
819 844
 		// Lastly, the count of messages needs to be no more than the lowest number of questions for any one language.
820 845
 		$count_questions = empty($qs_per_lang) ? 0 : min($qs_per_lang);
821
-		if (empty($count_questions) || $_POST['qa_verification_number'] > $count_questions)
822
-			$_POST['qa_verification_number'] = $count_questions;
846
+		if (empty($count_questions) || $_POST['qa_verification_number'] > $count_questions) {
847
+					$_POST['qa_verification_number'] = $count_questions;
848
+		}
823 849
 
824 850
 		call_integration_hook('integrate_save_spam_settings', array(&$save_vars));
825 851
 
@@ -834,24 +860,27 @@  discard block
 block discarded – undo
834 860
 
835 861
 	$character_range = array_merge(range('A', 'H'), array('K', 'M', 'N', 'P', 'R'), range('T', 'Y'));
836 862
 	$_SESSION['visual_verification_code'] = '';
837
-	for ($i = 0; $i < 6; $i++)
838
-		$_SESSION['visual_verification_code'] .= $character_range[array_rand($character_range)];
863
+	for ($i = 0; $i < 6; $i++) {
864
+			$_SESSION['visual_verification_code'] .= $character_range[array_rand($character_range)];
865
+	}
839 866
 
840 867
 	// Some javascript for CAPTCHA.
841 868
 	$context['settings_post_javascript'] = '';
842
-	if ($context['use_graphic_library'])
843
-		$context['settings_post_javascript'] .= '
869
+	if ($context['use_graphic_library']) {
870
+			$context['settings_post_javascript'] .= '
844 871
 		function refreshImages()
845 872
 		{
846 873
 			var imageType = document.getElementById(\'visual_verification_type\').value;
847 874
 			document.getElementById(\'verification_image\').src = \'' . $context['verification_image_href'] . ';type=\' + imageType;
848 875
 		}';
876
+	}
849 877
 
850 878
 	// Show the image itself, or text saying we can't.
851
-	if ($context['use_graphic_library'])
852
-		$config_vars['vv']['postinput'] = '<br><img src="' . $context['verification_image_href'] . ';type=' . (empty($modSettings['visual_verification_type']) ? 0 : $modSettings['visual_verification_type']) . '" alt="' . $txt['setting_image_verification_sample'] . '" id="verification_image"><br>';
853
-	else
854
-		$config_vars['vv']['postinput'] = '<br><span class="smalltext">' . $txt['setting_image_verification_nogd'] . '</span>';
879
+	if ($context['use_graphic_library']) {
880
+			$config_vars['vv']['postinput'] = '<br><img src="' . $context['verification_image_href'] . ';type=' . (empty($modSettings['visual_verification_type']) ? 0 : $modSettings['visual_verification_type']) . '" alt="' . $txt['setting_image_verification_sample'] . '" id="verification_image"><br>';
881
+	} else {
882
+			$config_vars['vv']['postinput'] = '<br><span class="smalltext">' . $txt['setting_image_verification_nogd'] . '</span>';
883
+	}
855 884
 
856 885
 	// Hack for PM spam settings.
857 886
 	list ($modSettings['max_pm_recipients'], $modSettings['pm_posts_verification'], $modSettings['pm_posts_per_hour']) = explode(',', $modSettings['pm_spam_settings']);
@@ -861,9 +890,10 @@  discard block
 block discarded – undo
861 890
 	$modSettings['posts_require_captcha'] = !isset($modSettings['posts_require_captcha']) || $modSettings['posts_require_captcha'] == -1 ? 0 : $modSettings['posts_require_captcha'];
862 891
 
863 892
 	// Some minor javascript for the guest post setting.
864
-	if ($modSettings['posts_require_captcha'])
865
-		$context['settings_post_javascript'] .= '
893
+	if ($modSettings['posts_require_captcha']) {
894
+			$context['settings_post_javascript'] .= '
866 895
 		document.getElementById(\'guests_require_captcha\').disabled = true;';
896
+	}
867 897
 
868 898
 	// And everything else.
869 899
 	$context['post_url'] = $scripturl . '?action=admin;area=antispam;save';
@@ -910,8 +940,9 @@  discard block
 block discarded – undo
910 940
 
911 941
 	call_integration_hook('integrate_signature_settings', array(&$config_vars));
912 942
 
913
-	if ($return_config)
914
-		return $config_vars;
943
+	if ($return_config) {
944
+			return $config_vars;
945
+	}
915 946
 
916 947
 	// Setup the template.
917 948
 	$context['page_title'] = $txt['signature_settings'];
@@ -966,8 +997,9 @@  discard block
 block discarded – undo
966 997
 				$sig = strtr($row['signature'], array('<br>' => "\n"));
967 998
 
968 999
 				// Max characters...
969
-				if (!empty($sig_limits[1]))
970
-					$sig = $smcFunc['substr']($sig, 0, $sig_limits[1]);
1000
+				if (!empty($sig_limits[1])) {
1001
+									$sig = $smcFunc['substr']($sig, 0, $sig_limits[1]);
1002
+				}
971 1003
 				// Max lines...
972 1004
 				if (!empty($sig_limits[2]))
973 1005
 				{
@@ -977,8 +1009,9 @@  discard block
 block discarded – undo
977 1009
 						if ($sig[$i] == "\n")
978 1010
 						{
979 1011
 							$count++;
980
-							if ($count >= $sig_limits[2])
981
-								$sig = substr($sig, 0, $i) . strtr(substr($sig, $i), array("\n" => ' '));
1012
+							if ($count >= $sig_limits[2]) {
1013
+															$sig = substr($sig, 0, $i) . strtr(substr($sig, $i), array("\n" => ' '));
1014
+							}
982 1015
 						}
983 1016
 					}
984 1017
 				}
@@ -989,17 +1022,19 @@  discard block
 block discarded – undo
989 1022
 					{
990 1023
 						$limit_broke = 0;
991 1024
 						// Attempt to allow all sizes of abuse, so to speak.
992
-						if ($matches[2][$ind] == 'px' && $size > $sig_limits[7])
993
-							$limit_broke = $sig_limits[7] . 'px';
994
-						elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75))
995
-							$limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt';
996
-						elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16))
997
-							$limit_broke = ((float) $sig_limits[7] / 16) . 'em';
998
-						elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18)
999
-							$limit_broke = 'large';
1000
-
1001
-						if ($limit_broke)
1002
-							$sig = str_replace($matches[0][$ind], '[size=' . $sig_limits[7] . 'px', $sig);
1025
+						if ($matches[2][$ind] == 'px' && $size > $sig_limits[7]) {
1026
+													$limit_broke = $sig_limits[7] . 'px';
1027
+						} elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75)) {
1028
+													$limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt';
1029
+						} elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16)) {
1030
+													$limit_broke = ((float) $sig_limits[7] / 16) . 'em';
1031
+						} elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18) {
1032
+													$limit_broke = 'large';
1033
+						}
1034
+
1035
+						if ($limit_broke) {
1036
+													$sig = str_replace($matches[0][$ind], '[size=' . $sig_limits[7] . 'px', $sig);
1037
+						}
1003 1038
 					}
1004 1039
 				}
1005 1040
 
@@ -1055,32 +1090,34 @@  discard block
 block discarded – undo
1055 1090
 											$img_offset = false;
1056 1091
 										}
1057 1092
 									}
1093
+								} else {
1094
+																	$replaces[$image] = '';
1058 1095
 								}
1059
-								else
1060
-									$replaces[$image] = '';
1061 1096
 
1062 1097
 								continue;
1063 1098
 							}
1064 1099
 
1065 1100
 							// Does it have predefined restraints? Width first.
1066
-							if ($matches[6][$key])
1067
-								$matches[2][$key] = $matches[6][$key];
1101
+							if ($matches[6][$key]) {
1102
+															$matches[2][$key] = $matches[6][$key];
1103
+							}
1068 1104
 							if ($matches[2][$key] && $sig_limits[5] && $matches[2][$key] > $sig_limits[5])
1069 1105
 							{
1070 1106
 								$width = $sig_limits[5];
1071 1107
 								$matches[4][$key] = $matches[4][$key] * ($width / $matches[2][$key]);
1108
+							} elseif ($matches[2][$key]) {
1109
+															$width = $matches[2][$key];
1072 1110
 							}
1073
-							elseif ($matches[2][$key])
1074
-								$width = $matches[2][$key];
1075 1111
 							// ... and height.
1076 1112
 							if ($matches[4][$key] && $sig_limits[6] && $matches[4][$key] > $sig_limits[6])
1077 1113
 							{
1078 1114
 								$height = $sig_limits[6];
1079
-								if ($width != -1)
1080
-									$width = $width * ($height / $matches[4][$key]);
1115
+								if ($width != -1) {
1116
+																	$width = $width * ($height / $matches[4][$key]);
1117
+								}
1118
+							} elseif ($matches[4][$key]) {
1119
+															$height = $matches[4][$key];
1081 1120
 							}
1082
-							elseif ($matches[4][$key])
1083
-								$height = $matches[4][$key];
1084 1121
 
1085 1122
 							// If the dimensions are still not fixed - we need to check the actual image.
1086 1123
 							if (($width == -1 && $sig_limits[5]) || ($height == -1 && $sig_limits[6]))
@@ -1098,12 +1135,13 @@  discard block
 block discarded – undo
1098 1135
 									if ($sizes[1] > $sig_limits[6] && $sig_limits[6])
1099 1136
 									{
1100 1137
 										$height = $sig_limits[6];
1101
-										if ($width == -1)
1102
-											$width = $sizes[0];
1138
+										if ($width == -1) {
1139
+																					$width = $sizes[0];
1140
+										}
1103 1141
 										$width = $width * ($height / $sizes[1]);
1142
+									} elseif ($width != -1) {
1143
+																			$height = $sizes[1];
1104 1144
 									}
1105
-									elseif ($width != -1)
1106
-										$height = $sizes[1];
1107 1145
 								}
1108 1146
 							}
1109 1147
 
@@ -1116,8 +1154,9 @@  discard block
 block discarded – undo
1116 1154
 							// Record that we got one.
1117 1155
 							$image_count_holder[$image] = isset($image_count_holder[$image]) ? $image_count_holder[$image] + 1 : 1;
1118 1156
 						}
1119
-						if (!empty($replaces))
1120
-							$sig = str_replace(array_keys($replaces), array_values($replaces), $sig);
1157
+						if (!empty($replaces)) {
1158
+													$sig = str_replace(array_keys($replaces), array_values($replaces), $sig);
1159
+						}
1121 1160
 					}
1122 1161
 				}
1123 1162
 				// Try to fix disabled tags.
@@ -1129,18 +1168,20 @@  discard block
 block discarded – undo
1129 1168
 
1130 1169
 				$sig = strtr($sig, array("\n" => '<br>'));
1131 1170
 				call_integration_hook('integrate_apply_signature_settings', array(&$sig, $sig_limits, $disabledTags));
1132
-				if ($sig != $row['signature'])
1133
-					$changes[$row['id_member']] = $sig;
1171
+				if ($sig != $row['signature']) {
1172
+									$changes[$row['id_member']] = $sig;
1173
+				}
1174
+			}
1175
+			if ($smcFunc['db_num_rows']($request) == 0) {
1176
+							$done = true;
1134 1177
 			}
1135
-			if ($smcFunc['db_num_rows']($request) == 0)
1136
-				$done = true;
1137 1178
 			$smcFunc['db_free_result']($request);
1138 1179
 
1139 1180
 			// Do we need to delete what we have?
1140 1181
 			if (!empty($changes))
1141 1182
 			{
1142
-				foreach ($changes as $id => $sig)
1143
-					$smcFunc['db_query']('', '
1183
+				foreach ($changes as $id => $sig) {
1184
+									$smcFunc['db_query']('', '
1144 1185
 						UPDATE {db_prefix}members
1145 1186
 						SET signature = {string:signature}
1146 1187
 						WHERE id_member = {int:id_member}',
@@ -1149,11 +1190,13 @@  discard block
 block discarded – undo
1149 1190
 							'signature' => $sig,
1150 1191
 						)
1151 1192
 					);
1193
+				}
1152 1194
 			}
1153 1195
 
1154 1196
 			$_GET['step'] += 50;
1155
-			if (!$done)
1156
-				pauseSignatureApplySettings();
1197
+			if (!$done) {
1198
+							pauseSignatureApplySettings();
1199
+			}
1157 1200
 		}
1158 1201
 		$settings_applied = true;
1159 1202
 	}
@@ -1171,8 +1214,9 @@  discard block
 block discarded – undo
1171 1214
 	);
1172 1215
 
1173 1216
 	// Temporarily make each setting a modSetting!
1174
-	foreach ($context['signature_settings'] as $key => $value)
1175
-		$modSettings['signature_' . $key] = $value;
1217
+	foreach ($context['signature_settings'] as $key => $value) {
1218
+			$modSettings['signature_' . $key] = $value;
1219
+	}
1176 1220
 
1177 1221
 	// Make sure we check the right tags!
1178 1222
 	$modSettings['bbc_disabled_signature_bbc'] = $disabledTags;
@@ -1184,23 +1228,26 @@  discard block
 block discarded – undo
1184 1228
 
1185 1229
 		// Clean up the tag stuff!
1186 1230
 		$bbcTags = array();
1187
-		foreach (parse_bbc(false) as $tag)
1188
-			$bbcTags[] = $tag['tag'];
1231
+		foreach (parse_bbc(false) as $tag) {
1232
+					$bbcTags[] = $tag['tag'];
1233
+		}
1189 1234
 
1190
-		if (!isset($_POST['signature_bbc_enabledTags']))
1191
-			$_POST['signature_bbc_enabledTags'] = array();
1192
-		elseif (!is_array($_POST['signature_bbc_enabledTags']))
1193
-			$_POST['signature_bbc_enabledTags'] = array($_POST['signature_bbc_enabledTags']);
1235
+		if (!isset($_POST['signature_bbc_enabledTags'])) {
1236
+					$_POST['signature_bbc_enabledTags'] = array();
1237
+		} elseif (!is_array($_POST['signature_bbc_enabledTags'])) {
1238
+					$_POST['signature_bbc_enabledTags'] = array($_POST['signature_bbc_enabledTags']);
1239
+		}
1194 1240
 
1195 1241
 		$sig_limits = array();
1196 1242
 		foreach ($context['signature_settings'] as $key => $value)
1197 1243
 		{
1198
-			if ($key == 'allow_smileys')
1199
-				continue;
1200
-			elseif ($key == 'max_smileys' && empty($_POST['signature_allow_smileys']))
1201
-				$sig_limits[] = -1;
1202
-			else
1203
-				$sig_limits[] = !empty($_POST['signature_' . $key]) ? max(1, (int) $_POST['signature_' . $key]) : 0;
1244
+			if ($key == 'allow_smileys') {
1245
+							continue;
1246
+			} elseif ($key == 'max_smileys' && empty($_POST['signature_allow_smileys'])) {
1247
+							$sig_limits[] = -1;
1248
+			} else {
1249
+							$sig_limits[] = !empty($_POST['signature_' . $key]) ? max(1, (int) $_POST['signature_' . $key]) : 0;
1250
+			}
1204 1251
 		}
1205 1252
 
1206 1253
 		call_integration_hook('integrate_save_signature_settings', array(&$sig_limits, &$bbcTags));
@@ -1233,12 +1280,14 @@  discard block
 block discarded – undo
1233 1280
 
1234 1281
 	// Try get more time...
1235 1282
 	@set_time_limit(600);
1236
-	if (function_exists('apache_reset_timeout'))
1237
-		@apache_reset_timeout();
1283
+	if (function_exists('apache_reset_timeout')) {
1284
+			@apache_reset_timeout();
1285
+	}
1238 1286
 
1239 1287
 	// Have we exhausted all the time we allowed?
1240
-	if (time() - array_sum(explode(' ', $sig_start)) < 3)
1241
-		return;
1288
+	if (time() - array_sum(explode(' ', $sig_start)) < 3) {
1289
+			return;
1290
+	}
1242 1291
 
1243 1292
 	$context['continue_get_data'] = '?action=admin;area=featuresettings;sa=sig;apply;step=' . $_GET['step'] . ';' . $context['session_var'] . '=' . $context['session_id'];
1244 1293
 	$context['page_title'] = $txt['not_done_title'];
@@ -1284,9 +1333,10 @@  discard block
 block discarded – undo
1284 1333
 		$disable_fields = array_flip($standard_fields);
1285 1334
 		if (!empty($_POST['active']))
1286 1335
 		{
1287
-			foreach ($_POST['active'] as $value)
1288
-				if (isset($disable_fields[$value]))
1336
+			foreach ($_POST['active'] as $value) {
1337
+							if (isset($disable_fields[$value]))
1289 1338
 					unset($disable_fields[$value]);
1339
+			}
1290 1340
 		}
1291 1341
 		// What we have left!
1292 1342
 		$changes['disabled_profile_fields'] = empty($disable_fields) ? '' : implode(',', array_keys($disable_fields));
@@ -1295,16 +1345,18 @@  discard block
 block discarded – undo
1295 1345
 		$reg_fields = array();
1296 1346
 		if (!empty($_POST['reg']))
1297 1347
 		{
1298
-			foreach ($_POST['reg'] as $value)
1299
-				if (in_array($value, $standard_fields) && !isset($disable_fields[$value]))
1348
+			foreach ($_POST['reg'] as $value) {
1349
+							if (in_array($value, $standard_fields) && !isset($disable_fields[$value]))
1300 1350
 					$reg_fields[] = $value;
1351
+			}
1301 1352
 		}
1302 1353
 		// What we have left!
1303 1354
 		$changes['registration_fields'] = empty($reg_fields) ? '' : implode(',', $reg_fields);
1304 1355
 
1305 1356
 		$_SESSION['adm-save'] = true;
1306
-		if (!empty($changes))
1307
-			updateSettings($changes);
1357
+		if (!empty($changes)) {
1358
+					updateSettings($changes);
1359
+		}
1308 1360
 	}
1309 1361
 
1310 1362
 	createToken('admin-scp');
@@ -1407,11 +1459,13 @@  discard block
 block discarded – undo
1407 1459
 					{
1408 1460
 						$return = '<p class="centertext bold_text">'. $rowData['field_order'] .'<br>';
1409 1461
 
1410
-						if ($rowData['field_order'] > 1)
1411
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1462
+						if ($rowData['field_order'] > 1) {
1463
+													$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1464
+						}
1412 1465
 
1413
-						if ($rowData['field_order'] < $context['custFieldsMaxOrder'])
1414
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1466
+						if ($rowData['field_order'] < $context['custFieldsMaxOrder']) {
1467
+													$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1468
+						}
1415 1469
 
1416 1470
 						$return .= '</p>';
1417 1471
 
@@ -1549,16 +1603,16 @@  discard block
 block discarded – undo
1549 1603
 		$disabled_fields = isset($modSettings['disabled_profile_fields']) ? explode(',', $modSettings['disabled_profile_fields']) : array();
1550 1604
 		$registration_fields = isset($modSettings['registration_fields']) ? explode(',', $modSettings['registration_fields']) : array();
1551 1605
 
1552
-		foreach ($standard_fields as $field)
1553
-			$list[] = array(
1606
+		foreach ($standard_fields as $field) {
1607
+					$list[] = array(
1554 1608
 				'id' => $field,
1555 1609
 				'label' => isset($txt['standard_profile_field_' . $field]) ? $txt['standard_profile_field_' . $field] : (isset($txt[$field]) ? $txt[$field] : $field),
1556 1610
 				'disabled' => in_array($field, $disabled_fields),
1557 1611
 				'on_register' => in_array($field, $registration_fields) && !in_array($field, $fields_no_registration),
1558 1612
 				'can_show_register' => !in_array($field, $fields_no_registration),
1559 1613
 			);
1560
-	}
1561
-	else
1614
+		}
1615
+	} else
1562 1616
 	{
1563 1617
 		// Load all the fields.
1564 1618
 		$request = $smcFunc['db_query']('', '
@@ -1572,8 +1626,9 @@  discard block
 block discarded – undo
1572 1626
 				'items_per_page' => $items_per_page,
1573 1627
 			)
1574 1628
 		);
1575
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1576
-			$list[] = $row;
1629
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1630
+					$list[] = $row;
1631
+		}
1577 1632
 		$smcFunc['db_free_result']($request);
1578 1633
 	}
1579 1634
 
@@ -1639,9 +1694,9 @@  discard block
 block discarded – undo
1639 1694
 		$context['field'] = array();
1640 1695
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1641 1696
 		{
1642
-			if ($row['field_type'] == 'textarea')
1643
-				@list ($rows, $cols) = @explode(',', $row['default_value']);
1644
-			else
1697
+			if ($row['field_type'] == 'textarea') {
1698
+							@list ($rows, $cols) = @explode(',', $row['default_value']);
1699
+			} else
1645 1700
 			{
1646 1701
 				$rows = 3;
1647 1702
 				$cols = 30;
@@ -1677,8 +1732,8 @@  discard block
 block discarded – undo
1677 1732
 	}
1678 1733
 
1679 1734
 	// Setup the default values as needed.
1680
-	if (empty($context['field']))
1681
-		$context['field'] = array(
1735
+	if (empty($context['field'])) {
1736
+			$context['field'] = array(
1682 1737
 			'name' => '',
1683 1738
 			'col_name' => '???',
1684 1739
 			'desc' => '',
@@ -1703,6 +1758,7 @@  discard block
 block discarded – undo
1703 1758
 			'enclose' => '',
1704 1759
 			'placement' => 0,
1705 1760
 		);
1761
+	}
1706 1762
 
1707 1763
 	// Are we moving it?
1708 1764
 	if (isset($_GET['move']) && in_array($smcFunc['htmlspecialchars']($_GET['move']), $move_to))
@@ -1711,8 +1767,10 @@  discard block
 block discarded – undo
1711 1767
 		$new_order = ($_GET['move'] == 'up' ? ($context['field']['order'] - 1) : ($context['field']['order'] + 1));
1712 1768
 
1713 1769
 		// Is this a valid position?
1714
-		if ($new_order <= 0 || $new_order > $order_count)
1715
-			redirectexit('action=admin;area=featuresettings;sa=profile'); // @todo implement an error handler
1770
+		if ($new_order <= 0 || $new_order > $order_count) {
1771
+					redirectexit('action=admin;area=featuresettings;sa=profile');
1772
+		}
1773
+		// @todo implement an error handler
1716 1774
 
1717 1775
 		// All good, proceed.
1718 1776
 		$smcFunc['db_query']('','
@@ -1743,12 +1801,14 @@  discard block
 block discarded – undo
1743 1801
 		validateToken('admin-ecp');
1744 1802
 
1745 1803
 		// Everyone needs a name - even the (bracket) unknown...
1746
-		if (trim($_POST['field_name']) == '')
1747
-			redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=need_name');
1804
+		if (trim($_POST['field_name']) == '') {
1805
+					redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=need_name');
1806
+		}
1748 1807
 
1749 1808
 		// Regex you say?  Do a very basic test to see if the pattern is valid
1750
-		if (!empty($_POST['regex']) && @preg_match($_POST['regex'], 'dummy') === false)
1751
-			redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=regex_error');
1809
+		if (!empty($_POST['regex']) && @preg_match($_POST['regex'], 'dummy') === false) {
1810
+					redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=regex_error');
1811
+		}
1752 1812
 
1753 1813
 		$_POST['field_name'] = $smcFunc['htmlspecialchars']($_POST['field_name']);
1754 1814
 		$_POST['field_desc'] = $smcFunc['htmlspecialchars']($_POST['field_desc']);
@@ -1765,8 +1825,9 @@  discard block
 block discarded – undo
1765 1825
 
1766 1826
 		// Some masking stuff...
1767 1827
 		$mask = isset($_POST['mask']) ? $_POST['mask'] : '';
1768
-		if ($mask == 'regex' && isset($_POST['regex']))
1769
-			$mask .= $_POST['regex'];
1828
+		if ($mask == 'regex' && isset($_POST['regex'])) {
1829
+					$mask .= $_POST['regex'];
1830
+		}
1770 1831
 
1771 1832
 		$field_length = isset($_POST['max_length']) ? (int) $_POST['max_length'] : 255;
1772 1833
 		$enclose = isset($_POST['enclose']) ? $_POST['enclose'] : '';
@@ -1785,8 +1846,9 @@  discard block
 block discarded – undo
1785 1846
 				$v = strtr($v, array(',' => ''));
1786 1847
 
1787 1848
 				// Nada, zip, etc...
1788
-				if (trim($v) == '')
1789
-					continue;
1849
+				if (trim($v) == '') {
1850
+									continue;
1851
+				}
1790 1852
 
1791 1853
 				// Otherwise, save it boy.
1792 1854
 				$field_options .= $v . ',';
@@ -1794,15 +1856,17 @@  discard block
 block discarded – undo
1794 1856
 				$newOptions[$k] = $v;
1795 1857
 
1796 1858
 				// Is it default?
1797
-				if (isset($_POST['default_select']) && $_POST['default_select'] == $k)
1798
-					$default = $v;
1859
+				if (isset($_POST['default_select']) && $_POST['default_select'] == $k) {
1860
+									$default = $v;
1861
+				}
1799 1862
 			}
1800 1863
 			$field_options = substr($field_options, 0, -1);
1801 1864
 		}
1802 1865
 
1803 1866
 		// Text area has default has dimensions
1804
-		if ($_POST['field_type'] == 'textarea')
1805
-			$default = (int) $_POST['rows'] . ',' . (int) $_POST['cols'];
1867
+		if ($_POST['field_type'] == 'textarea') {
1868
+					$default = (int) $_POST['rows'] . ',' . (int) $_POST['cols'];
1869
+		}
1806 1870
 
1807 1871
 		// Come up with the unique name?
1808 1872
 		if (empty($context['fid']))
@@ -1811,32 +1875,36 @@  discard block
 block discarded – undo
1811 1875
 			preg_match('~([\w\d_-]+)~', $col_name, $matches);
1812 1876
 
1813 1877
 			// If there is nothing to the name, then let's start out own - for foreign languages etc.
1814
-			if (isset($matches[1]))
1815
-				$col_name = $initial_col_name = 'cust_' . strtolower($matches[1]);
1816
-			else
1817
-				$col_name = $initial_col_name = 'cust_' . mt_rand(1, 9999);
1878
+			if (isset($matches[1])) {
1879
+							$col_name = $initial_col_name = 'cust_' . strtolower($matches[1]);
1880
+			} else {
1881
+							$col_name = $initial_col_name = 'cust_' . mt_rand(1, 9999);
1882
+			}
1818 1883
 
1819 1884
 			// Make sure this is unique.
1820 1885
 			$current_fields = array();
1821 1886
 			$request = $smcFunc['db_query']('', '
1822 1887
 				SELECT id_field, col_name
1823 1888
 				FROM {db_prefix}custom_fields');
1824
-			while ($row = $smcFunc['db_fetch_assoc']($request))
1825
-				$current_fields[$row['id_field']] = $row['col_name'];
1889
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
1890
+							$current_fields[$row['id_field']] = $row['col_name'];
1891
+			}
1826 1892
 			$smcFunc['db_free_result']($request);
1827 1893
 
1828 1894
 			$unique = false;
1829 1895
 			for ($i = 0; !$unique && $i < 9; $i ++)
1830 1896
 			{
1831
-				if (!in_array($col_name, $current_fields))
1832
-					$unique = true;
1833
-				else
1834
-					$col_name = $initial_col_name . $i;
1897
+				if (!in_array($col_name, $current_fields)) {
1898
+									$unique = true;
1899
+				} else {
1900
+									$col_name = $initial_col_name . $i;
1901
+				}
1835 1902
 			}
1836 1903
 
1837 1904
 			// Still not a unique column name? Leave it up to the user, then.
1838
-			if (!$unique)
1839
-				fatal_lang_error('custom_option_not_unique');
1905
+			if (!$unique) {
1906
+							fatal_lang_error('custom_option_not_unique');
1907
+			}
1840 1908
 		}
1841 1909
 		// Work out what to do with the user data otherwise...
1842 1910
 		else
@@ -1864,8 +1932,9 @@  discard block
 block discarded – undo
1864 1932
 				// Work out what's changed!
1865 1933
 				foreach ($context['field']['options'] as $k => $option)
1866 1934
 				{
1867
-					if (trim($option) == '')
1868
-						continue;
1935
+					if (trim($option) == '') {
1936
+											continue;
1937
+					}
1869 1938
 
1870 1939
 					// Still exists?
1871 1940
 					if (in_array($option, $newOptions))
@@ -1879,8 +1948,8 @@  discard block
 block discarded – undo
1879 1948
 				foreach ($optionChanges as $k => $option)
1880 1949
 				{
1881 1950
 					// Just been renamed?
1882
-					if (!in_array($k, $takenKeys) && !empty($newOptions[$k]))
1883
-						$smcFunc['db_query']('', '
1951
+					if (!in_array($k, $takenKeys) && !empty($newOptions[$k])) {
1952
+											$smcFunc['db_query']('', '
1884 1953
 							UPDATE {db_prefix}themes
1885 1954
 							SET value = {string:new_value}
1886 1955
 							WHERE variable = {string:current_column}
@@ -1893,6 +1962,7 @@  discard block
 block discarded – undo
1893 1962
 								'old_value' => $option,
1894 1963
 							)
1895 1964
 						);
1965
+					}
1896 1966
 				}
1897 1967
 			}
1898 1968
 			// @todo Maybe we should adjust based on new text length limits?
@@ -1935,8 +2005,8 @@  discard block
 block discarded – undo
1935 2005
 			);
1936 2006
 
1937 2007
 			// Just clean up any old selects - these are a pain!
1938
-			if (($_POST['field_type'] == 'select' || $_POST['field_type'] == 'radio') && !empty($newOptions))
1939
-				$smcFunc['db_query']('', '
2008
+			if (($_POST['field_type'] == 'select' || $_POST['field_type'] == 'radio') && !empty($newOptions)) {
2009
+							$smcFunc['db_query']('', '
1940 2010
 					DELETE FROM {db_prefix}themes
1941 2011
 					WHERE variable = {string:current_column}
1942 2012
 						AND value NOT IN ({array_string:new_option_values})
@@ -1947,8 +2017,8 @@  discard block
 block discarded – undo
1947 2017
 						'current_column' => $context['field']['col_name'],
1948 2018
 					)
1949 2019
 				);
1950
-		}
1951
-		else
2020
+			}
2021
+		} else
1952 2022
 		{
1953 2023
 			// Gotta figure it out the order.
1954 2024
 			$new_order = $order_count > 1 ? ($order_count + 1) : 1;
@@ -2123,11 +2193,13 @@  discard block
 block discarded – undo
2123 2193
 	call_integration_hook('integrate_prune_settings', array(&$config_vars, &$prune_toggle, false));
2124 2194
 
2125 2195
 	$prune_toggle_dt = array();
2126
-	foreach ($prune_toggle as $item)
2127
-		$prune_toggle_dt[] = 'setting_' . $item;
2196
+	foreach ($prune_toggle as $item) {
2197
+			$prune_toggle_dt[] = 'setting_' . $item;
2198
+	}
2128 2199
 
2129
-	if ($return_config)
2130
-		return $config_vars;
2200
+	if ($return_config) {
2201
+			return $config_vars;
2202
+	}
2131 2203
 
2132 2204
 	addInlineJavaScript('
2133 2205
 	function togglePruned()
@@ -2165,15 +2237,16 @@  discard block
 block discarded – undo
2165 2237
 			$vals = array();
2166 2238
 			foreach ($config_vars as $index => $dummy)
2167 2239
 			{
2168
-				if (!is_array($dummy) || $index == 'pruningOptions' || !in_array($dummy[1], $prune_toggle))
2169
-					continue;
2240
+				if (!is_array($dummy) || $index == 'pruningOptions' || !in_array($dummy[1], $prune_toggle)) {
2241
+									continue;
2242
+				}
2170 2243
 
2171 2244
 				$vals[] = empty($_POST[$dummy[1]]) || $_POST[$dummy[1]] < 0 ? 0 : (int) $_POST[$dummy[1]];
2172 2245
 			}
2173 2246
 			$_POST['pruningOptions'] = implode(',', $vals);
2247
+		} else {
2248
+					$_POST['pruningOptions'] = '';
2174 2249
 		}
2175
-		else
2176
-			$_POST['pruningOptions'] = '';
2177 2250
 
2178 2251
 		saveDBSettings($savevar);
2179 2252
 		$_SESSION['adm-save'] = true;
@@ -2185,10 +2258,11 @@  discard block
 block discarded – undo
2185 2258
 	$context['sub_template'] = 'show_settings';
2186 2259
 
2187 2260
 	// Get the actual values
2188
-	if (!empty($modSettings['pruningOptions']))
2189
-		@list ($modSettings['pruneErrorLog'], $modSettings['pruneModLog'], $modSettings['pruneBanLog'], $modSettings['pruneReportLog'], $modSettings['pruneScheduledTaskLog'], $modSettings['pruneSpiderHitLog']) = explode(',', $modSettings['pruningOptions']);
2190
-	else
2191
-		$modSettings['pruneErrorLog'] = $modSettings['pruneModLog'] = $modSettings['pruneBanLog'] = $modSettings['pruneReportLog'] = $modSettings['pruneScheduledTaskLog'] = $modSettings['pruneSpiderHitLog'] = 0;
2261
+	if (!empty($modSettings['pruningOptions'])) {
2262
+			@list ($modSettings['pruneErrorLog'], $modSettings['pruneModLog'], $modSettings['pruneBanLog'], $modSettings['pruneReportLog'], $modSettings['pruneScheduledTaskLog'], $modSettings['pruneSpiderHitLog']) = explode(',', $modSettings['pruningOptions']);
2263
+	} else {
2264
+			$modSettings['pruneErrorLog'] = $modSettings['pruneModLog'] = $modSettings['pruneBanLog'] = $modSettings['pruneReportLog'] = $modSettings['pruneScheduledTaskLog'] = $modSettings['pruneSpiderHitLog'] = 0;
2265
+	}
2192 2266
 
2193 2267
 	prepareDBSettingContext($config_vars);
2194 2268
 }
@@ -2210,8 +2284,9 @@  discard block
 block discarded – undo
2210 2284
 	// Make it even easier to add new settings.
2211 2285
 	call_integration_hook('integrate_general_mod_settings', array(&$config_vars));
2212 2286
 
2213
-	if ($return_config)
2214
-		return $config_vars;
2287
+	if ($return_config) {
2288
+			return $config_vars;
2289
+	}
2215 2290
 
2216 2291
 	$context['post_url'] = $scripturl . '?action=admin;area=modsettings;save;sa=general';
2217 2292
 	$context['settings_title'] = $txt['mods_cat_modifications_misc'];
@@ -2298,8 +2373,9 @@  discard block
 block discarded – undo
2298 2373
 
2299 2374
 	call_integration_hook('integrate_privacy_settings', array(&$config_vars));
2300 2375
 
2301
-	if ($return_config)
2302
-		return $config_vars;
2376
+	if ($return_config) {
2377
+			return $config_vars;
2378
+	}
2303 2379
 
2304 2380
 	// Saving?
2305 2381
 	if (isset($_GET['save']))
Please login to merge, or discard this patch.
Themes/default/Profile.template.php 1 patch
Braces   +576 added lines, -439 removed lines patch added patch discarded remove patch
@@ -18,23 +18,25 @@  discard block
 block discarded – undo
18 18
 	global $context;
19 19
 
20 20
 	// Prevent Chrome from auto completing fields when viewing/editing other members profiles
21
-	if (isBrowser('is_chrome') && !$context['user']['is_owner'])
22
-		echo '
21
+	if (isBrowser('is_chrome') && !$context['user']['is_owner']) {
22
+			echo '
23 23
 			<script>
24 24
 				disableAutoComplete();
25 25
 			</script>';
26
+	}
26 27
 
27 28
 	// If an error occurred while trying to save previously, give the user a clue!
28 29
 	echo '
29 30
 			', template_error_message();
30 31
 
31 32
 	// If the profile was update successfully, let the user know this.
32
-	if (!empty($context['profile_updated']))
33
-		echo '
33
+	if (!empty($context['profile_updated'])) {
34
+			echo '
34 35
 			<div class="infobox">
35 36
 				', $context['profile_updated'], '
36 37
 			</div>';
37
-}
38
+	}
39
+	}
38 40
 
39 41
 /**
40 42
  * Template for any HTML needed below the profile (closing off divs/tables, etc.)
@@ -99,19 +101,19 @@  discard block
 block discarded – undo
99 101
 		</div>
100 102
 		<div class="alerts_unread">';
101 103
 
102
-	if (empty($context['unread_alerts']))
103
-		template_alerts_all_read();
104
-
105
-	else
104
+	if (empty($context['unread_alerts'])) {
105
+			template_alerts_all_read();
106
+	} else
106 107
 	{
107
-		foreach ($context['unread_alerts'] as $id_alert => $details)
108
-			echo '
108
+		foreach ($context['unread_alerts'] as $id_alert => $details) {
109
+					echo '
109 110
 			<div class="unread">
110 111
 				', !empty($details['sender']) ? $details['sender']['avatar']['image'] : '', '
111 112
 				<div class="details">
112 113
 					', !empty($details['icon']) ? $details['icon'] : '', '<span>', $details['text'], '</span> - ', $details['time'], '
113 114
 				</div>
114 115
 			</div>';
116
+		}
115 117
 	}
116 118
 
117 119
 	echo '
@@ -158,37 +160,41 @@  discard block
 block discarded – undo
158 160
 	if (!empty($context['print_custom_fields']['above_member']))
159 161
 	{
160 162
 		$fields = '';
161
-		foreach ($context['print_custom_fields']['above_member'] as $field)
162
-			if (!empty($field['output_html']))
163
+		foreach ($context['print_custom_fields']['above_member'] as $field) {
164
+					if (!empty($field['output_html']))
163 165
 				$fields .= '
164 166
 					<li>' . $field['output_html'] . '</li>';
167
+		}
165 168
 
166
-		if (!empty($fields))
167
-			echo '
169
+		if (!empty($fields)) {
170
+					echo '
168 171
 			<div class="custom_fields_above_name">
169 172
 				<ul>', $fields, '
170 173
 				</ul>
171 174
 			</div>';
175
+		}
172 176
 	}
173 177
 
174 178
 	echo '
175 179
 			<div class="username clear">
176 180
 				<h4>';
177 181
 
178
-	if (!empty($context['print_custom_fields']['before_member']))
179
-		foreach ($context['print_custom_fields']['before_member'] as $field)
182
+	if (!empty($context['print_custom_fields']['before_member'])) {
183
+			foreach ($context['print_custom_fields']['before_member'] as $field)
180 184
 			if (!empty($field['output_html']))
181 185
 				echo '
182 186
 					<span>', $field['output_html'], '</span>';
187
+	}
183 188
 
184 189
 	echo '
185 190
 					', $context['member']['name'];
186 191
 
187
-	if (!empty($context['print_custom_fields']['after_member']))
188
-		foreach ($context['print_custom_fields']['after_member'] as $field)
192
+	if (!empty($context['print_custom_fields']['after_member'])) {
193
+			foreach ($context['print_custom_fields']['after_member'] as $field)
189 194
 			if (!empty($field['output_html']))
190 195
 				echo '
191 196
 					<span>', $field['output_html'], '</span>';
197
+	}
192 198
 
193 199
 
194 200
 	echo '
@@ -201,39 +207,44 @@  discard block
 block discarded – undo
201 207
 	if (!empty($context['print_custom_fields']['below_avatar']))
202 208
 	{
203 209
 		$fields = '';
204
-		foreach ($context['print_custom_fields']['below_avatar'] as $field)
205
-			if (!empty($field['output_html']))
210
+		foreach ($context['print_custom_fields']['below_avatar'] as $field) {
211
+					if (!empty($field['output_html']))
206 212
 				$fields .= '
207 213
 					<li>' . $field['output_html'] . '</li>';
214
+		}
208 215
 
209
-		if (!empty($fields))
210
-			echo '
216
+		if (!empty($fields)) {
217
+					echo '
211 218
 			<div class="custom_fields_below_avatar">
212 219
 				<ul>', $fields, '
213 220
 				</ul>
214 221
 			</div>';
222
+		}
215 223
 	}
216 224
 
217 225
 	echo '
218 226
 			<ul class="icon_fields clear">';
219 227
 
220 228
 	// Email is only visible if it's your profile or you have the moderate_forum permission
221
-	if ($context['member']['show_email'])
222
-		echo '
229
+	if ($context['member']['show_email']) {
230
+			echo '
223 231
 				<li><a href="mailto:', $context['member']['email'], '" title="', $context['member']['email'], '" rel="nofollow"><span class="generic_icons mail" title="' . $txt['email'] . '"></span></a></li>';
232
+	}
224 233
 
225 234
 	// Don't show an icon if they haven't specified a website.
226
-	if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website']))
227
-		echo '
235
+	if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) {
236
+			echo '
228 237
 				<li><a href="', $context['member']['website']['url'], '" title="' . $context['member']['website']['title'] . '" target="_blank" rel="noopener">', ($settings['use_image_buttons'] ? '<span class="generic_icons www" title="' . $context['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>';
238
+	}
229 239
 
230 240
 	// Are there any custom profile fields as icons?
231 241
 	if (!empty($context['print_custom_fields']['icons']))
232 242
 	{
233
-		foreach ($context['print_custom_fields']['icons'] as $field)
234
-			if (!empty($field['output_html']))
243
+		foreach ($context['print_custom_fields']['icons'] as $field) {
244
+					if (!empty($field['output_html']))
235 245
 				echo '
236 246
 				<li class="custom_field">', $field['output_html'], '</li>';
247
+		}
237 248
 	}
238 249
 
239 250
 	echo '
@@ -242,24 +253,27 @@  discard block
 block discarded – undo
242 253
 				', $context['can_send_pm'] ? '<a href="' . $context['member']['online']['href'] . '" title="' . $context['member']['online']['text'] . '" rel="nofollow">' : '', $settings['use_image_buttons'] ? '<span class="' . ($context['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $context['member']['online']['text'] . '"></span>' : $context['member']['online']['label'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['member']['online']['label'] . '</span>' : '';
243 254
 
244 255
 	// Can they add this member as a buddy?
245
-	if (!empty($context['can_have_buddy']) && !$context['user']['is_owner'])
246
-		echo '
256
+	if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) {
257
+			echo '
247 258
 				<br>
248 259
 				<a href="', $scripturl, '?action=buddy;u=', $context['id_member'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['buddy_' . ($context['member']['is_buddy'] ? 'remove' : 'add')], '</a>';
260
+	}
249 261
 
250 262
 	echo '
251 263
 			</span>';
252 264
 
253
-	if (!$context['user']['is_owner'] && $context['can_send_pm'])
254
-		echo '
265
+	if (!$context['user']['is_owner'] && $context['can_send_pm']) {
266
+			echo '
255 267
 			<a href="', $scripturl, '?action=pm;sa=send;u=', $context['id_member'], '" class="infolinks">', $txt['profile_sendpm_short'], '</a>';
268
+	}
256 269
 
257 270
 	echo '
258 271
 			<a href="', $scripturl, '?action=profile;area=showposts;u=', $context['id_member'], '" class="infolinks">', $txt['showPosts'], '</a>';
259 272
 
260
-	if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled']))
261
-		echo '
273
+	if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) {
274
+			echo '
262 275
 			<a href="', $scripturl, '?action=profile;area=showdrafts;u=', $context['id_member'], '" class="infolinks">', $txt['drafts_show'], '</a>';
276
+	}
263 277
 
264 278
 	echo '
265 279
 			<a href="', $scripturl, '?action=profile;area=statistics;u=', $context['id_member'], '" class="infolinks">', $txt['statPanel'], '</a>';
@@ -268,17 +282,19 @@  discard block
 block discarded – undo
268 282
 	if (!empty($context['print_custom_fields']['bottom_poster']))
269 283
 	{
270 284
 		$fields = '';
271
-		foreach ($context['print_custom_fields']['bottom_poster'] as $field)
272
-			if (!empty($field['output_html']))
285
+		foreach ($context['print_custom_fields']['bottom_poster'] as $field) {
286
+					if (!empty($field['output_html']))
273 287
 				$fields .= '
274 288
 					<li>' . $field['output_html'] . '</li>';
289
+		}
275 290
 
276
-		if (!empty($fields))
277
-			echo '
291
+		if (!empty($fields)) {
292
+					echo '
278 293
 			<div class="custom_fields_bottom">
279 294
 				<ul class="nolist">', $fields, '
280 295
 				</ul>
281 296
 			</div>';
297
+		}
282 298
 	}
283 299
 
284 300
 	echo '
@@ -287,30 +303,35 @@  discard block
 block discarded – undo
287 303
 		<div id="detailedinfo">
288 304
 			<dl class="settings">';
289 305
 
290
-	if ($context['user']['is_owner'] || $context['user']['is_admin'])
291
-		echo '
306
+	if ($context['user']['is_owner'] || $context['user']['is_admin']) {
307
+			echo '
292 308
 				<dt>', $txt['username'], ': </dt>
293 309
 				<dd>', $context['member']['username'], '</dd>';
310
+	}
294 311
 
295
-	if (!isset($context['disabled_fields']['posts']))
296
-		echo '
312
+	if (!isset($context['disabled_fields']['posts'])) {
313
+			echo '
297 314
 				<dt>', $txt['profile_posts'], ': </dt>
298 315
 				<dd>', $context['member']['posts'], ' (', $context['member']['posts_per_day'], ' ', $txt['posts_per_day'], ')</dd>';
316
+	}
299 317
 
300
-	if ($context['member']['show_email'])
301
-		echo '
318
+	if ($context['member']['show_email']) {
319
+			echo '
302 320
 				<dt>', $txt['email'], ': </dt>
303 321
 				<dd><a href="mailto:', $context['member']['email'], '">', $context['member']['email'], '</a></dd>';
322
+	}
304 323
 
305
-	if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title']))
306
-		echo '
324
+	if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) {
325
+			echo '
307 326
 				<dt>', $txt['custom_title'], ': </dt>
308 327
 				<dd>', $context['member']['title'], '</dd>';
328
+	}
309 329
 
310
-	if (!empty($context['member']['blurb']))
311
-		echo '
330
+	if (!empty($context['member']['blurb'])) {
331
+			echo '
312 332
 				<dt>', $txt['personal_text'], ': </dt>
313 333
 				<dd>', $context['member']['blurb'], '</dd>';
334
+	}
314 335
 
315 336
 	echo '
316 337
 				<dt>', $txt['age'], ':</dt>
@@ -324,19 +345,21 @@  discard block
 block discarded – undo
324 345
 	{
325 346
 		$fields = array();
326 347
 
327
-		foreach ($context['print_custom_fields']['standard'] as $field)
328
-			if (!empty($field['output_html']))
348
+		foreach ($context['print_custom_fields']['standard'] as $field) {
349
+					if (!empty($field['output_html']))
329 350
 				$fields[] = $field;
351
+		}
330 352
 
331 353
 		if (count($fields) > 0)
332 354
 		{
333 355
 			echo '
334 356
 			<dl class="settings">';
335 357
 
336
-			foreach ($fields as $field)
337
-				echo '
358
+			foreach ($fields as $field) {
359
+							echo '
338 360
 				<dt>', $field['name'], ':</dt>
339 361
 				<dd>', $field['output_html'], '</dd>';
362
+			}
340 363
 
341 364
 			echo '
342 365
 			</dl>';
@@ -355,9 +378,10 @@  discard block
 block discarded – undo
355 378
 					<a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=', ($context['can_issue_warning'] && !$context['user']['is_owner'] ? 'issuewarning' : 'viewwarning'), '">', $context['member']['warning'], '%</a>';
356 379
 
357 380
 		// Can we provide information on what this means?
358
-		if (!empty($context['warning_status']))
359
-			echo '
381
+		if (!empty($context['warning_status'])) {
382
+					echo '
360 383
 					<span class="smalltext">(', $context['warning_status'], ')</span>';
384
+		}
361 385
 
362 386
 		echo '
363 387
 				</dd>';
@@ -367,11 +391,12 @@  discard block
 block discarded – undo
367 391
 	if (!empty($context['activate_message']) || !empty($context['member']['bans']))
368 392
 	{
369 393
 		// If the person looking at the summary has permission, and the account isn't activated, give the viewer the ability to do it themselves.
370
-		if (!empty($context['activate_message']))
371
-			echo '
394
+		if (!empty($context['activate_message'])) {
395
+					echo '
372 396
 				<dt class="clear">
373 397
 					<span class="alert">', $context['activate_message'], '</span> (<a href="', $context['activate_link'], '"', ($context['activate_type'] == 4 ? ' class="you_sure" data-confirm="' . $txt['profileConfirm'] . '"' : ''), '>', $context['activate_link_text'], '</a>)
374 398
 				</dt>';
399
+		}
375 400
 
376 401
 		// If the current member is banned, show a message and possibly a link to the ban.
377 402
 		if (!empty($context['member']['bans']))
@@ -383,10 +408,11 @@  discard block
 block discarded – undo
383 408
 				<dt class="clear" id="ban_info" style="display: none;">
384 409
 					<strong>', $txt['user_banned_by_following'], ':</strong>';
385 410
 
386
-			foreach ($context['member']['bans'] as $ban)
387
-				echo '
411
+			foreach ($context['member']['bans'] as $ban) {
412
+							echo '
388 413
 					<br>
389 414
 					<span class="smalltext">', $ban['explanation'], '</span>';
415
+			}
390 416
 
391 417
 			echo '
392 418
 				</dt>';
@@ -400,30 +426,34 @@  discard block
 block discarded – undo
400 426
 	// If the person looking is allowed, they can check the members IP address and hostname.
401 427
 	if ($context['can_see_ip'])
402 428
 	{
403
-		if (!empty($context['member']['ip']))
404
-		echo '
429
+		if (!empty($context['member']['ip'])) {
430
+				echo '
405 431
 				<dt>', $txt['ip'], ': </dt>
406 432
 				<dd><a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['member']['ip'], ';u=', $context['member']['id'], '">', $context['member']['ip'], '</a></dd>';
433
+		}
407 434
 
408
-		if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip']))
409
-			echo '
435
+		if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) {
436
+					echo '
410 437
 				<dt>', $txt['hostname'], ': </dt>
411 438
 				<dd>', $context['member']['hostname'], '</dd>';
439
+		}
412 440
 	}
413 441
 
414 442
 	echo '
415 443
 				<dt>', $txt['local_time'], ':</dt>
416 444
 				<dd>', $context['member']['local_time'], '</dd>';
417 445
 
418
-	if (!empty($modSettings['userLanguage']) && !empty($context['member']['language']))
419
-		echo '
446
+	if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) {
447
+			echo '
420 448
 				<dt>', $txt['language'], ':</dt>
421 449
 				<dd>', $context['member']['language'], '</dd>';
450
+	}
422 451
 
423
-	if ($context['member']['show_last_login'])
424
-		echo '
452
+	if ($context['member']['show_last_login']) {
453
+			echo '
425 454
 				<dt>', $txt['lastLoggedIn'], ': </dt>
426 455
 				<dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>';
456
+	}
427 457
 
428 458
 	echo '
429 459
 			</dl>';
@@ -432,42 +462,47 @@  discard block
 block discarded – undo
432 462
 	if (!empty($context['print_custom_fields']['above_signature']))
433 463
 	{
434 464
 		$fields = '';
435
-		foreach ($context['print_custom_fields']['above_signature'] as $field)
436
-			if (!empty($field['output_html']))
465
+		foreach ($context['print_custom_fields']['above_signature'] as $field) {
466
+					if (!empty($field['output_html']))
437 467
 				$fields .= '
438 468
 					<li>' . $field['output_html'] . '</li>';
469
+		}
439 470
 
440
-		if (!empty($fields))
441
-			echo '
471
+		if (!empty($fields)) {
472
+					echo '
442 473
 			<div class="custom_fields_above_signature">
443 474
 				<ul class="nolist">', $fields, '
444 475
 				</ul>
445 476
 			</div>';
477
+		}
446 478
 	}
447 479
 
448 480
 	// Show the users signature.
449
-	if ($context['signature_enabled'] && !empty($context['member']['signature']))
450
-		echo '
481
+	if ($context['signature_enabled'] && !empty($context['member']['signature'])) {
482
+			echo '
451 483
 			<div class="signature">
452 484
 				<h5>', $txt['signature'], ':</h5>
453 485
 				', $context['member']['signature'], '
454 486
 			</div>';
487
+	}
455 488
 
456 489
 	// Are there any custom profile fields for below the signature?
457 490
 	if (!empty($context['print_custom_fields']['below_signature']))
458 491
 	{
459 492
 		$fields = '';
460
-		foreach ($context['print_custom_fields']['below_signature'] as $field)
461
-			if (!empty($field['output_html']))
493
+		foreach ($context['print_custom_fields']['below_signature'] as $field) {
494
+					if (!empty($field['output_html']))
462 495
 				$fields .=  '
463 496
 					<li>' . $field['output_html'] . '</li>';
497
+		}
464 498
 
465
-		if (!empty($fields))
466
-			echo '
499
+		if (!empty($fields)) {
500
+					echo '
467 501
 			<div class="custom_fields_below_signature">
468 502
 				<ul class="nolist">', $fields, '
469 503
 				</ul>
470 504
 			</div>';
505
+		}
471 506
 	}
472 507
 
473 508
 	echo '
@@ -509,62 +544,70 @@  discard block
 block discarded – undo
509 544
 			</div>
510 545
 			<div class="list_posts">';
511 546
 
512
-			if (!$post['approved'])
513
-				echo '
547
+			if (!$post['approved']) {
548
+							echo '
514 549
 				<div class="approve_post">
515 550
 					<em>', $txt['post_awaiting_approval'], '</em>
516 551
 				</div>';
552
+			}
517 553
 
518 554
 			echo '
519 555
 				', $post['body'], '
520 556
 			</div>';
521 557
 
522
-			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete'])
523
-				echo '
558
+			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) {
559
+							echo '
524 560
 			<div class="floatright">
525 561
 				<ul class="quickbuttons">';
562
+			}
526 563
 
527 564
 			// If they *can* reply?
528
-			if ($post['can_reply'])
529
-				echo '
565
+			if ($post['can_reply']) {
566
+							echo '
530 567
 					<li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>';
568
+			}
531 569
 
532 570
 			// If they *can* quote?
533
-			if ($post['can_quote'])
534
-				echo '
571
+			if ($post['can_quote']) {
572
+							echo '
535 573
 					<li><a href="', $scripturl . '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>';
574
+			}
536 575
 
537 576
 			// How about... even... remove it entirely?!
538
-			if ($post['can_delete'])
539
-				echo '
577
+			if ($post['can_delete']) {
578
+							echo '
540 579
 					<li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';profile;u=', $context['member']['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>';
580
+			}
541 581
 
542
-			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete'])
543
-				echo '
582
+			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) {
583
+							echo '
544 584
 				</ul>
545 585
 			</div><!-- .floatright -->';
586
+			}
546 587
 
547 588
 			echo '
548 589
 		</div><!-- $post[css_class] -->';
549 590
 		}
591
+	} else {
592
+			template_show_list('attachments');
550 593
 	}
551
-	else
552
-		template_show_list('attachments');
553 594
 
554 595
 	// No posts? Just end with a informative message.
555
-	if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts'])))
556
-		echo '
596
+	if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) {
597
+			echo '
557 598
 		<div class="windowbg">
558 599
 			', isset($context['attachments']) ? $txt['show_attachments_none'] : ($context['is_topics'] ? $txt['show_topics_none'] : $txt['show_posts_none']), '
559 600
 		</div>';
601
+	}
560 602
 
561 603
 	// Show more page numbers.
562
-	if (!empty($context['page_index']))
563
-		echo '
604
+	if (!empty($context['page_index'])) {
605
+			echo '
564 606
 		<div class="pagesection">
565 607
 			<div class="pagelinks">', $context['page_index'], '</div>
566 608
 		</div>';
567
-}
609
+	}
610
+	}
568 611
 
569 612
 /**
570 613
  * Template for showing alerts within the alerts popup
@@ -574,11 +617,12 @@  discard block
 block discarded – undo
574 617
 	global $context, $txt, $scripturl;
575 618
 
576 619
 	// Do we have an update message?
577
-	if (!empty($context['update_message']))
578
-		echo '
620
+	if (!empty($context['update_message'])) {
621
+			echo '
579 622
 		<div class="infobox">
580 623
 			', $context['update_message'], '
581 624
 		</div>';
625
+	}
582 626
 
583 627
 	echo '
584 628
 		<div class="cat_bar">
@@ -587,18 +631,18 @@  discard block
 block discarded – undo
587 631
 			</h3>
588 632
 		</div>';
589 633
 
590
-	if (empty($context['alerts']))
591
-		echo '
634
+	if (empty($context['alerts'])) {
635
+			echo '
592 636
 		<div class="information">
593 637
 			', $txt['alerts_none'], '
594 638
 		</div>';
595
-
596
-	else
639
+	} else
597 640
 	{
598 641
 		// Start the form if checkboxes are in use
599
-		if ($context['showCheckboxes'])
600
-			echo '
642
+		if ($context['showCheckboxes']) {
643
+					echo '
601 644
 		<form action="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;save" method="post" accept-charset="', $context['character_set'], '" id="mark_all">';
645
+		}
602 646
 
603 647
 		echo '
604 648
 			<table id="alerts" class="table_grid">';
@@ -614,9 +658,10 @@  discard block
 block discarded – undo
614 658
 							<li><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;do=remove;aid=', $id, ';', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['delete'], '</a></li>
615 659
 							<li><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;do=', ($alert['is_read'] != 0 ? 'unread' : 'read'), ';aid=', $id, ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons ', $alert['is_read'] != 0 ? 'unread_button' : 'read_button', '"></span>', ($alert['is_read'] != 0 ? $txt['mark_unread'] : $txt['mark_read_short']), '</a></li>';
616 660
 
617
-					if ($context['showCheckboxes'])
618
-						echo '
661
+					if ($context['showCheckboxes']) {
662
+											echo '
619 663
 							<li><input type="checkbox" name="mark[', $id, ']" value="', $id, '"></li>';
664
+					}
620 665
 
621 666
 			echo '
622 667
 						</ul>
@@ -631,8 +676,8 @@  discard block
 block discarded – undo
631 676
 					', $context['pagination'], '
632 677
 				</div>';
633 678
 
634
-		if ($context['showCheckboxes'])
635
-			echo '
679
+		if ($context['showCheckboxes']) {
680
+					echo '
636 681
 				<div class="floatright">
637 682
 					', $txt['check_all'], ': <input type="checkbox" name="select_all" id="select_all">
638 683
 					<select name="mark_as">
@@ -643,14 +688,16 @@  discard block
 block discarded – undo
643 688
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
644 689
 					<input type="submit" name="req" value="', $txt['quick_mod_go'], '" class="button you_sure">
645 690
 				</div>';
691
+		}
646 692
 
647 693
 	echo '
648 694
 			</div>';
649 695
 
650
-	if ($context['showCheckboxes'])
651
-		echo '
696
+	if ($context['showCheckboxes']) {
697
+			echo '
652 698
 		</form>';
653 699
 	}
700
+	}
654 701
 }
655 702
 
656 703
 /**
@@ -671,12 +718,12 @@  discard block
 block discarded – undo
671 718
 		</div>' : '';
672 719
 
673 720
 	// No drafts? Just show an informative message.
674
-	if (empty($context['drafts']))
675
-		echo '
721
+	if (empty($context['drafts'])) {
722
+			echo '
676 723
 		<div class="windowbg centertext">
677 724
 			', $txt['draft_none'], '
678 725
 		</div>';
679
-	else
726
+	} else
680 727
 	{
681 728
 		// For every draft to be displayed, give it its own div, and show the important details of the draft.
682 729
 		foreach ($context['drafts'] as $draft)
@@ -688,13 +735,15 @@  discard block
 block discarded – undo
688 735
 				<h5>
689 736
 					<strong><a href="', $scripturl, '?board=', $draft['board']['id'], '.0">', $draft['board']['name'], '</a> / ', $draft['topic']['link'], '</strong> &nbsp; &nbsp;';
690 737
 
691
-			if (!empty($draft['sticky']))
692
-				echo '
738
+			if (!empty($draft['sticky'])) {
739
+							echo '
693 740
 					<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>';
741
+			}
694 742
 
695
-			if (!empty($draft['locked']))
696
-				echo '
743
+			if (!empty($draft['locked'])) {
744
+							echo '
697 745
 					<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>';
746
+			}
698 747
 
699 748
 			echo '
700 749
 				</h5>
@@ -727,13 +776,13 @@  discard block
 block discarded – undo
727 776
 {
728 777
 	global $context, $scripturl, $txt;
729 778
 
730
-	if (!empty($context['saved_successful']))
731
-		echo '
779
+	if (!empty($context['saved_successful'])) {
780
+			echo '
732 781
 	<div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>';
733
-
734
-	elseif (!empty($context['saved_failed']))
735
-		echo '
782
+	} elseif (!empty($context['saved_failed'])) {
783
+			echo '
736 784
 	<div class="errorbox">', $context['saved_failed'], '</div>';
785
+	}
737 786
 
738 787
 	echo '
739 788
 	<div id="edit_buddies">
@@ -748,14 +797,16 @@  discard block
 block discarded – undo
748 797
 					<th scope="col" class="quarter_table">', $txt['name'], '</th>
749 798
 					<th scope="col">', $txt['status'], '</th>';
750 799
 
751
-	if (allowedTo('moderate_forum'))
752
-		echo '
800
+	if (allowedTo('moderate_forum')) {
801
+			echo '
753 802
 					<th scope="col">', $txt['email'], '</th>';
803
+	}
754 804
 
755
-	if (!empty($context['custom_pf']))
756
-		foreach ($context['custom_pf'] as $column)
805
+	if (!empty($context['custom_pf'])) {
806
+			foreach ($context['custom_pf'] as $column)
757 807
 				echo '
758 808
 					<th scope="col">', $column['label'], '</th>';
809
+	}
759 810
 
760 811
 	echo '
761 812
 					<th scope="col">', $txt['remove'], '</th>
@@ -764,13 +815,14 @@  discard block
 block discarded – undo
764 815
 			<tbody>';
765 816
 
766 817
 	// If they don't have any buddies don't list them!
767
-	if (empty($context['buddies']))
768
-		echo '
818
+	if (empty($context['buddies'])) {
819
+			echo '
769 820
 				<tr class="windowbg">
770 821
 					<td colspan="', allowedTo('moderate_forum') ? '10' : '9', '">
771 822
 						<strong>', $txt['no_buddies'], '</strong>
772 823
 					</td>
773 824
 				</tr>';
825
+	}
774 826
 
775 827
 		// Now loop through each buddy showing info on each.
776 828
 	else
@@ -784,17 +836,19 @@  discard block
 block discarded – undo
784 836
 						<a href="', $buddy['online']['href'], '"><span class="' . ($buddy['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $buddy['online']['text'] . '"></span></a>
785 837
 					</td>';
786 838
 
787
-			if ($buddy['show_email'])
788
-				echo '
839
+			if ($buddy['show_email']) {
840
+							echo '
789 841
 					<td>
790 842
 						<a href="mailto:' . $buddy['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $buddy['name'] . '"></span></a>
791 843
 					</td>';
844
+			}
792 845
 
793 846
 			// Show the custom profile fields for this user.
794
-			if (!empty($context['custom_pf']))
795
-				foreach ($context['custom_pf'] as $key => $column)
847
+			if (!empty($context['custom_pf'])) {
848
+							foreach ($context['custom_pf'] as $key => $column)
796 849
 					echo '
797 850
 					<td class="lefttext">', $buddy['options'][$key], '</td>';
851
+			}
798 852
 
799 853
 			echo '
800 854
 					<td>
@@ -827,9 +881,10 @@  discard block
 block discarded – undo
827 881
 			</dl>
828 882
 		</div>';
829 883
 
830
-	if (!empty($context['token_check']))
831
-		echo '
884
+	if (!empty($context['token_check'])) {
885
+			echo '
832 886
 		<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
887
+	}
833 888
 
834 889
 	echo '
835 890
 		<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -855,13 +910,13 @@  discard block
 block discarded – undo
855 910
 {
856 911
 	global $context, $scripturl, $txt;
857 912
 
858
-	if (!empty($context['saved_successful']))
859
-		echo '
913
+	if (!empty($context['saved_successful'])) {
914
+			echo '
860 915
 	<div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>';
861
-
862
-	elseif (!empty($context['saved_failed']))
863
-		echo '
916
+	} elseif (!empty($context['saved_failed'])) {
917
+			echo '
864 918
 	<div class="errorbox">', $context['saved_failed'], '</div>';
919
+	}
865 920
 
866 921
 	echo '
867 922
 	<div id="edit_buddies">
@@ -876,9 +931,10 @@  discard block
 block discarded – undo
876 931
 					<th scope="col" class="quarter_table">', $txt['name'], '</th>
877 932
 					<th scope="col">', $txt['status'], '</th>';
878 933
 
879
-	if (allowedTo('moderate_forum'))
880
-		echo '
934
+	if (allowedTo('moderate_forum')) {
935
+			echo '
881 936
 					<th scope="col">', $txt['email'], '</th>';
937
+	}
882 938
 
883 939
 	echo '
884 940
 					<th scope="col">', $txt['ignore_remove'], '</th>
@@ -887,13 +943,14 @@  discard block
 block discarded – undo
887 943
 			<tbody>';
888 944
 
889 945
 	// If they don't have anyone on their ignore list, don't list it!
890
-	if (empty($context['ignore_list']))
891
-		echo '
946
+	if (empty($context['ignore_list'])) {
947
+			echo '
892 948
 				<tr class="windowbg">
893 949
 					<td colspan="', allowedTo('moderate_forum') ? '4' : '3', '">
894 950
 						<strong>', $txt['no_ignore'], '</strong>
895 951
 					</td>
896 952
 				</tr>';
953
+	}
897 954
 
898 955
 	// Now loop through each buddy showing info on each.
899 956
 	foreach ($context['ignore_list'] as $member)
@@ -905,11 +962,12 @@  discard block
 block discarded – undo
905 962
 						<a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a>
906 963
 					</td>';
907 964
 
908
-		if ($member['show_email'])
909
-			echo '
965
+		if ($member['show_email']) {
966
+					echo '
910 967
 					<td>
911 968
 						<a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a>
912 969
 					</td>';
970
+		}
913 971
 		echo '
914 972
 					<td>
915 973
 						<a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=lists;sa=ignore;remove=', $member['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['ignore_remove'], '"></span></a>
@@ -939,9 +997,10 @@  discard block
 block discarded – undo
939 997
 			</dl>
940 998
 		</div>';
941 999
 
942
-	if (!empty($context['token_check']))
943
-		echo '
1000
+	if (!empty($context['token_check'])) {
1001
+			echo '
944 1002
 		<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
1003
+	}
945 1004
 
946 1005
 	echo '
947 1006
 		<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -987,9 +1046,10 @@  discard block
 block discarded – undo
987 1046
 					<a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip'], ';u=', $context['member']['id'], '">', $context['last_ip'], '</a>';
988 1047
 
989 1048
 	// Second address detected?
990
-	if (!empty($context['last_ip2']))
991
-		echo '
1049
+	if (!empty($context['last_ip2'])) {
1050
+			echo '
992 1051
 					, <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip2'], ';u=', $context['member']['id'], '">', $context['last_ip2'], '</a>';
1052
+	}
993 1053
 
994 1054
 	echo '
995 1055
 				</dd>';
@@ -1055,9 +1115,10 @@  discard block
 block discarded – undo
1055 1115
 		</div>
1056 1116
 		<div class="windowbg">';
1057 1117
 
1058
-		foreach ($context['whois_servers'] as $server)
1059
-			echo '
1118
+		foreach ($context['whois_servers'] as $server) {
1119
+					echo '
1060 1120
 			<a href="', $server['url'], '" target="_blank" rel="noopener"', '>', $server['name'], '</a><br>';
1121
+		}
1061 1122
 		echo '
1062 1123
 		</div>
1063 1124
 		<br>';
@@ -1069,13 +1130,12 @@  discard block
 block discarded – undo
1069 1130
 			<h3 class="catbg">', $txt['members_from_ip'], ' ', $context['ip'], '</h3>
1070 1131
 		</div>';
1071 1132
 
1072
-	if (empty($context['ips']))
1073
-		echo '
1133
+	if (empty($context['ips'])) {
1134
+			echo '
1074 1135
 		<p class="windowbg description">
1075 1136
 			<em>', $txt['no_members_from_ip'], '</em>
1076 1137
 		</p>';
1077
-
1078
-	else
1138
+	} else
1079 1139
 	{
1080 1140
 		echo '
1081 1141
 		<table class="table_grid">
@@ -1088,12 +1148,13 @@  discard block
 block discarded – undo
1088 1148
 			<tbody>';
1089 1149
 
1090 1150
 		// Loop through each of the members and display them.
1091
-		foreach ($context['ips'] as $ip => $memberlist)
1092
-			echo '
1151
+		foreach ($context['ips'] as $ip => $memberlist) {
1152
+					echo '
1093 1153
 				<tr class="windowbg">
1094 1154
 					<td><a href="', $context['base_url'], ';searchip=', $ip, '">', $ip, '</a></td>
1095 1155
 					<td>', implode(', ', $memberlist), '</td>
1096 1156
 				</tr>';
1157
+		}
1097 1158
 
1098 1159
 		echo '
1099 1160
 			</tbody>
@@ -1135,11 +1196,10 @@  discard block
 block discarded – undo
1135 1196
 			</h3>
1136 1197
 		</div>';
1137 1198
 
1138
-	if ($context['member']['has_all_permissions'])
1139
-		echo '
1199
+	if ($context['member']['has_all_permissions']) {
1200
+			echo '
1140 1201
 		<div class="information">', $txt['showPermissions_all'], '</div>';
1141
-
1142
-	else
1202
+	} else
1143 1203
 	{
1144 1204
 		echo '
1145 1205
 		<div class="information">',$txt['showPermissions_help'], '</div>
@@ -1154,9 +1214,10 @@  discard block
 block discarded – undo
1154 1214
 			<div class="windowbg smalltext">
1155 1215
 				', $txt['showPermissions_restricted_boards_desc'], ':<br>';
1156 1216
 
1157
-			foreach ($context['no_access_boards'] as $no_access_board)
1158
-				echo '
1217
+			foreach ($context['no_access_boards'] as $no_access_board) {
1218
+							echo '
1159 1219
 				<a href="', $scripturl, '?board=', $no_access_board['id'], '.0">', $no_access_board['name'], '</a>', $no_access_board['is_last'] ? '' : ', ';
1220
+			}
1160 1221
 			echo '
1161 1222
 			</div>';
1162 1223
 		}
@@ -1188,12 +1249,13 @@  discard block
 block discarded – undo
1188 1249
 							</td>
1189 1250
 							<td class="smalltext">';
1190 1251
 
1191
-				if ($permission['is_denied'])
1192
-					echo '
1252
+				if ($permission['is_denied']) {
1253
+									echo '
1193 1254
 								<span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>';
1194
-				else
1195
-					echo '
1255
+				} else {
1256
+									echo '
1196 1257
 								', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']);
1258
+				}
1197 1259
 
1198 1260
 				echo '
1199 1261
 							</td>
@@ -1204,10 +1266,10 @@  discard block
 block discarded – undo
1204 1266
 				</table>
1205 1267
 			</div><!-- .tborder -->
1206 1268
 			<br>';
1207
-		}
1208
-		else
1209
-			echo '
1269
+		} else {
1270
+					echo '
1210 1271
 			<p class="windowbg">', $txt['showPermissions_none_general'], '</p>';
1272
+		}
1211 1273
 
1212 1274
 		// Board permission section.
1213 1275
 		echo '
@@ -1218,14 +1280,16 @@  discard block
 block discarded – undo
1218 1280
 						<select name="board" onchange="if (this.options[this.selectedIndex].value) this.form.submit();">
1219 1281
 							<option value="0"', $context['board'] == 0 ? ' selected' : '', '>', $txt['showPermissions_global'], '</option>';
1220 1282
 
1221
-		if (!empty($context['boards']))
1222
-			echo '
1283
+		if (!empty($context['boards'])) {
1284
+					echo '
1223 1285
 							<option value="" disabled>---------------------------</option>';
1286
+		}
1224 1287
 
1225 1288
 		// Fill the box with any local permission boards.
1226
-		foreach ($context['boards'] as $board)
1227
-			echo '
1289
+		foreach ($context['boards'] as $board) {
1290
+					echo '
1228 1291
 							<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['name'], ' (', $board['profile_name'], ')</option>';
1292
+		}
1229 1293
 
1230 1294
 		echo '
1231 1295
 						</select>
@@ -1254,13 +1318,13 @@  discard block
 block discarded – undo
1254 1318
 						</td>
1255 1319
 						<td class="smalltext">';
1256 1320
 
1257
-				if ($permission['is_denied'])
1258
-					echo '
1321
+				if ($permission['is_denied']) {
1322
+									echo '
1259 1323
 							<span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>';
1260
-
1261
-				else
1262
-					echo '
1324
+				} else {
1325
+									echo '
1263 1326
 							', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']);
1327
+				}
1264 1328
 
1265 1329
 				echo '
1266 1330
 						</td>
@@ -1269,10 +1333,10 @@  discard block
 block discarded – undo
1269 1333
 			echo '
1270 1334
 				</tbody>
1271 1335
 			</table>';
1272
-		}
1273
-		else
1274
-			echo '
1336
+		} else {
1337
+					echo '
1275 1338
 			<p class="windowbg">', $txt['showPermissions_none_board'], '</p>';
1339
+		}
1276 1340
 	echo '
1277 1341
 		</div><!-- #permissions -->';
1278 1342
 	}
@@ -1313,9 +1377,10 @@  discard block
 block discarded – undo
1313 1377
 			</div>';
1314 1378
 
1315 1379
 	// If they haven't post at all, don't draw the graph.
1316
-	if (empty($context['posts_by_time']))
1317
-		echo '
1380
+	if (empty($context['posts_by_time'])) {
1381
+			echo '
1318 1382
 			<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1383
+	}
1319 1384
 
1320 1385
 	// Otherwise do!
1321 1386
 	else
@@ -1324,8 +1389,8 @@  discard block
 block discarded – undo
1324 1389
 			<ul class="activity_stats flow_hidden">';
1325 1390
 
1326 1391
 		// The labels.
1327
-		foreach ($context['posts_by_time'] as $time_of_day)
1328
-			echo '
1392
+		foreach ($context['posts_by_time'] as $time_of_day) {
1393
+					echo '
1329 1394
 				<li>
1330 1395
 					<div class="generic_bar vertical">
1331 1396
 						<div class="bar" style="height: ', (int) $time_of_day['relative_percent'], '%;">
@@ -1334,6 +1399,7 @@  discard block
 block discarded – undo
1334 1399
 					</div>
1335 1400
 					<span class="stats_hour">', $time_of_day['hour_format'], '</span>
1336 1401
 				</li>';
1402
+		}
1337 1403
 
1338 1404
 		echo '
1339 1405
 			</ul>';
@@ -1352,11 +1418,10 @@  discard block
 block discarded – undo
1352 1418
 					</h3>
1353 1419
 				</div>';
1354 1420
 
1355
-	if (empty($context['popular_boards']))
1356
-		echo '
1421
+	if (empty($context['popular_boards'])) {
1422
+			echo '
1357 1423
 				<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1358
-
1359
-	else
1424
+	} else
1360 1425
 	{
1361 1426
 		echo '
1362 1427
 				<dl class="stats">';
@@ -1386,10 +1451,10 @@  discard block
 block discarded – undo
1386 1451
 					</h3>
1387 1452
 				</div>';
1388 1453
 
1389
-	if (empty($context['board_activity']))
1390
-		echo '
1454
+	if (empty($context['board_activity'])) {
1455
+			echo '
1391 1456
 				<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1392
-	else
1457
+	} else
1393 1458
 	{
1394 1459
 		echo '
1395 1460
 				<dl class="stats">';
@@ -1440,90 +1505,97 @@  discard block
 block discarded – undo
1440 1505
 				<h3 class="catbg profile_hd">';
1441 1506
 
1442 1507
 		// Don't say "Profile" if this isn't the profile...
1443
-		if (!empty($context['profile_header_text']))
1444
-			echo '
1508
+		if (!empty($context['profile_header_text'])) {
1509
+					echo '
1445 1510
 					', $context['profile_header_text'];
1446
-		else
1447
-			echo '
1511
+		} else {
1512
+					echo '
1448 1513
 					', $txt['profile'];
1514
+		}
1449 1515
 
1450 1516
 		echo '
1451 1517
 				</h3>
1452 1518
 			</div>';
1453 1519
 
1454 1520
 	// Have we some description?
1455
-	if ($context['page_desc'])
1456
-		echo '
1521
+	if ($context['page_desc']) {
1522
+			echo '
1457 1523
 			<p class="information">', $context['page_desc'], '</p>';
1524
+	}
1458 1525
 
1459 1526
 	echo '
1460 1527
 			<div class="roundframe">';
1461 1528
 
1462 1529
 	// Any bits at the start?
1463
-	if (!empty($context['profile_prehtml']))
1464
-		echo '
1530
+	if (!empty($context['profile_prehtml'])) {
1531
+			echo '
1465 1532
 				<div>', $context['profile_prehtml'], '</div>';
1533
+	}
1466 1534
 
1467
-	if (!empty($context['profile_fields']))
1468
-		echo '
1535
+	if (!empty($context['profile_fields'])) {
1536
+			echo '
1469 1537
 				<dl class="settings">';
1538
+	}
1470 1539
 
1471 1540
 	// Start the big old loop 'of love.
1472 1541
 	$lastItem = 'hr';
1473 1542
 	foreach ($context['profile_fields'] as $key => $field)
1474 1543
 	{
1475 1544
 		// We add a little hack to be sure we never get more than one hr in a row!
1476
-		if ($lastItem == 'hr' && $field['type'] == 'hr')
1477
-			continue;
1545
+		if ($lastItem == 'hr' && $field['type'] == 'hr') {
1546
+					continue;
1547
+		}
1478 1548
 
1479 1549
 		$lastItem = $field['type'];
1480
-		if ($field['type'] == 'hr')
1481
-			echo '
1550
+		if ($field['type'] == 'hr') {
1551
+					echo '
1482 1552
 				</dl>
1483 1553
 				<hr>
1484 1554
 				<dl class="settings">';
1485
-
1486
-		elseif ($field['type'] == 'callback')
1555
+		} elseif ($field['type'] == 'callback')
1487 1556
 		{
1488 1557
 			if (isset($field['callback_func']) && function_exists('template_profile_' . $field['callback_func']))
1489 1558
 			{
1490 1559
 				$callback_func = 'template_profile_' . $field['callback_func'];
1491 1560
 				$callback_func();
1492 1561
 			}
1493
-		}
1494
-		else
1562
+		} else
1495 1563
 		{
1496 1564
 			echo '
1497 1565
 					<dt>
1498 1566
 						<strong', !empty($field['is_error']) ? ' class="error"' : '', '>', $field['type'] !== 'label' ? '<label for="' . $key . '">' : '', $field['label'], $field['type'] !== 'label' ? '</label>' : '', '</strong>';
1499 1567
 
1500 1568
 			// Does it have any subtext to show?
1501
-			if (!empty($field['subtext']))
1502
-				echo '
1569
+			if (!empty($field['subtext'])) {
1570
+							echo '
1503 1571
 						<br>
1504 1572
 						<span class="smalltext">', $field['subtext'], '</span>';
1573
+			}
1505 1574
 
1506 1575
 			echo '
1507 1576
 					</dt>
1508 1577
 					<dd>';
1509 1578
 
1510 1579
 			// Want to put something infront of the box?
1511
-			if (!empty($field['preinput']))
1512
-				echo '
1580
+			if (!empty($field['preinput'])) {
1581
+							echo '
1513 1582
 						', $field['preinput'];
1583
+			}
1514 1584
 
1515 1585
 			// What type of data are we showing?
1516
-			if ($field['type'] == 'label')
1517
-				echo '
1586
+			if ($field['type'] == 'label') {
1587
+							echo '
1518 1588
 						', $field['value'];
1589
+			}
1519 1590
 
1520 1591
 			// Maybe it's a text box - very likely!
1521 1592
 			elseif (in_array($field['type'], array('int', 'float', 'text', 'password', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number', 'time', 'url')))
1522 1593
 			{
1523
-				if ($field['type'] == 'int' || $field['type'] == 'float')
1524
-					$type = 'number';
1525
-				else
1526
-					$type = $field['type'];
1594
+				if ($field['type'] == 'int' || $field['type'] == 'float') {
1595
+									$type = 'number';
1596
+				} else {
1597
+									$type = $field['type'];
1598
+				}
1527 1599
 				$step = $field['type'] == 'float' ? ' step="0.1"' : '';
1528 1600
 
1529 1601
 
@@ -1531,10 +1603,11 @@  discard block
 block discarded – undo
1531 1603
 						<input type="', $type, '" name="', $key, '" id="', $key, '" size="', empty($field['size']) ? 30 : $field['size'], '" value="', $field['value'], '" ', $field['input_attr'], ' ', $step, '>';
1532 1604
 			}
1533 1605
 			// You "checking" me out? ;)
1534
-			elseif ($field['type'] == 'check')
1535
-				echo '
1606
+			elseif ($field['type'] == 'check') {
1607
+							echo '
1536 1608
 						<input type="hidden" name="', $key, '" value="0">
1537 1609
 						<input type="checkbox" name="', $key, '" id="', $key, '"', !empty($field['value']) ? ' checked' : '', ' value="1" ', $field['input_attr'], '>';
1610
+			}
1538 1611
 
1539 1612
 			// Always fun - select boxes!
1540 1613
 			elseif ($field['type'] == 'select')
@@ -1545,14 +1618,16 @@  discard block
 block discarded – undo
1545 1618
 				if (isset($field['options']))
1546 1619
 				{
1547 1620
 					// Is this some code to generate the options?
1548
-					if (!is_array($field['options']))
1549
-						$field['options'] = $field['options']();
1621
+					if (!is_array($field['options'])) {
1622
+											$field['options'] = $field['options']();
1623
+					}
1550 1624
 
1551 1625
 					// Assuming we now have some!
1552
-					if (is_array($field['options']))
1553
-						foreach ($field['options'] as $value => $name)
1626
+					if (is_array($field['options'])) {
1627
+											foreach ($field['options'] as $value => $name)
1554 1628
 							echo '
1555 1629
 							<option', is_numeric($value) ? ' value="" disabled' : ' value="' . $value . '"', $value === $field['value'] ? ' selected' : '', '>', $name, '</option>';
1630
+					}
1556 1631
 				}
1557 1632
 
1558 1633
 				echo '
@@ -1560,31 +1635,34 @@  discard block
 block discarded – undo
1560 1635
 			}
1561 1636
 
1562 1637
 			// Something to end with?
1563
-			if (!empty($field['postinput']))
1564
-				echo '
1638
+			if (!empty($field['postinput'])) {
1639
+							echo '
1565 1640
 						', $field['postinput'];
1641
+			}
1566 1642
 
1567 1643
 			echo '
1568 1644
 					</dd>';
1569 1645
 		}
1570 1646
 	}
1571 1647
 
1572
-	if (!empty($context['profile_fields']))
1573
-		echo '
1648
+	if (!empty($context['profile_fields'])) {
1649
+			echo '
1574 1650
 				</dl>';
1651
+	}
1575 1652
 
1576 1653
 	// Are there any custom profile fields - if so print them!
1577 1654
 	if (!empty($context['custom_fields']))
1578 1655
 	{
1579
-		if ($lastItem != 'hr')
1580
-			echo '
1656
+		if ($lastItem != 'hr') {
1657
+					echo '
1581 1658
 				<hr>';
1659
+		}
1582 1660
 
1583 1661
 		echo '
1584 1662
 				<dl class="settings">';
1585 1663
 
1586
-		foreach ($context['custom_fields'] as $field)
1587
-			echo '
1664
+		foreach ($context['custom_fields'] as $field) {
1665
+					echo '
1588 1666
 					<dt>
1589 1667
 						<strong>', $field['name'], ': </strong><br>
1590 1668
 						<span class="smalltext">', $field['desc'], '</span>
@@ -1592,19 +1670,21 @@  discard block
 block discarded – undo
1592 1670
 					<dd>
1593 1671
 						', $field['input_html'], '
1594 1672
 					</dd>';
1673
+		}
1595 1674
 
1596 1675
 		echo '
1597 1676
 				</dl>';
1598 1677
 	}
1599 1678
 
1600 1679
 	// Any closing HTML?
1601
-	if (!empty($context['profile_posthtml']))
1602
-		echo '
1680
+	if (!empty($context['profile_posthtml'])) {
1681
+			echo '
1603 1682
 				<div>', $context['profile_posthtml'], '</div>';
1683
+	}
1604 1684
 
1605 1685
 	// Only show the password box if it's actually needed.
1606
-	if ($context['require_password'])
1607
-		echo '
1686
+	if ($context['require_password']) {
1687
+			echo '
1608 1688
 				<dl class="settings">
1609 1689
 					<dt>
1610 1690
 						<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br>
@@ -1614,18 +1694,21 @@  discard block
 block discarded – undo
1614 1694
 						<input type="password" name="oldpasswrd" id="oldpasswrd" size="20">
1615 1695
 					</dd>
1616 1696
 				</dl>';
1697
+	}
1617 1698
 
1618 1699
 	// The button shouldn't say "Change profile" unless we're changing the profile...
1619
-	if (!empty($context['submit_button_text']))
1620
-		echo '
1700
+	if (!empty($context['submit_button_text'])) {
1701
+			echo '
1621 1702
 				<input type="submit" name="save" value="', $context['submit_button_text'], '" class="button floatright">';
1622
-	else
1623
-		echo '
1703
+	} else {
1704
+			echo '
1624 1705
 				<input type="submit" name="save" value="', $txt['change_profile'], '" class="button floatright">';
1706
+	}
1625 1707
 
1626
-	if (!empty($context['token_check']))
1627
-		echo '
1708
+	if (!empty($context['token_check'])) {
1709
+			echo '
1628 1710
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
1711
+	}
1629 1712
 
1630 1713
 	echo '
1631 1714
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -1635,10 +1718,11 @@  discard block
 block discarded – undo
1635 1718
 		</form>';
1636 1719
 
1637 1720
 	// Any final spellchecking stuff?
1638
-	if (!empty($context['show_spellchecking']))
1639
-		echo '
1721
+	if (!empty($context['show_spellchecking'])) {
1722
+			echo '
1640 1723
 		<form name="spell_form" id="spell_form" method="post" accept-charset="', $context['character_set'], '" target="spellWindow" action="', $scripturl, '?action=spellcheck"><input type="hidden" name="spellstring" value=""></form>';
1641
-}
1724
+	}
1725
+	}
1642 1726
 
1643 1727
 /**
1644 1728
  * Personal Message settings.
@@ -1675,10 +1759,11 @@  discard block
 block discarded – undo
1675 1759
 						<select name="pm_receive_from" id="pm_receive_from">
1676 1760
 							<option value="0"', empty($context['receive_from']) || (empty($modSettings['enable_buddylist']) && $context['receive_from'] < 3) ? ' selected' : '', '>', $txt['pm_receive_from_everyone'], '</option>';
1677 1761
 
1678
-	if (!empty($modSettings['enable_buddylist']))
1679
-		echo '
1762
+	if (!empty($modSettings['enable_buddylist'])) {
1763
+			echo '
1680 1764
 							<option value="1"', !empty($context['receive_from']) && $context['receive_from'] == 1 ? ' selected' : '', '>', $txt['pm_receive_from_ignore'], '</option>
1681 1765
 							<option value="2"', !empty($context['receive_from']) && $context['receive_from'] == 2 ? ' selected' : '', '>', $txt['pm_receive_from_buddies'], '</option>';
1766
+	}
1682 1767
 
1683 1768
 	echo '
1684 1769
 							<option value="3"', !empty($context['receive_from']) && $context['receive_from'] > 2 ? ' selected' : '', '>', $txt['pm_receive_from_admins'], '</option>
@@ -1721,11 +1806,12 @@  discard block
 block discarded – undo
1721 1806
 		if (empty($setting) || !is_array($setting))
1722 1807
 		{
1723 1808
 			// Insert a separator (unless this is the first item in the list)
1724
-			if ($i !== $first_option_key)
1725
-				echo '
1809
+			if ($i !== $first_option_key) {
1810
+							echo '
1726 1811
 				</dl>
1727 1812
 				<hr>
1728 1813
 				<dl class="settings">';
1814
+			}
1729 1815
 
1730 1816
 			// Should we give a name to this section?
1731 1817
 			if (is_string($setting) && !empty($setting))
@@ -1734,69 +1820,67 @@  discard block
 block discarded – undo
1734 1820
 				echo '
1735 1821
 					<dt><strong>' . $setting . '</strong></dt>
1736 1822
 					<dd></dd>';
1823
+			} else {
1824
+							$titled_section = false;
1737 1825
 			}
1738
-			else
1739
-				$titled_section = false;
1740 1826
 
1741 1827
 			continue;
1742 1828
 		}
1743 1829
 
1744 1830
 		// Is this disabled?
1745
-		if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled']))
1746
-			continue;
1747
-
1748
-		elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage']))
1749
-			continue;
1750
-
1751
-		elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored']))
1752
-			continue;
1753
-
1754
-		elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist']))
1755
-			continue;
1756
-
1757
-		elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg']))
1758
-			continue;
1759
-
1760
-		elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled']))))
1761
-			continue;
1762
-
1763
-		elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled']))))
1764
-			continue;
1831
+		if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) {
1832
+					continue;
1833
+		} elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) {
1834
+					continue;
1835
+		} elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) {
1836
+					continue;
1837
+		} elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) {
1838
+					continue;
1839
+		} elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) {
1840
+					continue;
1841
+		} elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) {
1842
+					continue;
1843
+		} elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) {
1844
+					continue;
1845
+		}
1765 1846
 
1766 1847
 		// Some of these may not be set...  Set to defaults here
1767 1848
 		$opts = array('topics_per_page', 'messages_per_page', 'display_quick_mod');
1768
-		if (in_array($setting['id'], $opts) && !isset($context['member']['options'][$setting['id']]))
1769
-			$context['member']['options'][$setting['id']] = 0;
1770
-
1771
-		if (!isset($setting['type']) || $setting['type'] == 'bool')
1772
-			$setting['type'] = 'checkbox';
1773
-
1774
-		elseif ($setting['type'] == 'int' || $setting['type'] == 'integer')
1775
-			$setting['type'] = 'number';
1849
+		if (in_array($setting['id'], $opts) && !isset($context['member']['options'][$setting['id']])) {
1850
+					$context['member']['options'][$setting['id']] = 0;
1851
+		}
1776 1852
 
1777
-		elseif ($setting['type'] == 'string')
1778
-			$setting['type'] = 'text';
1853
+		if (!isset($setting['type']) || $setting['type'] == 'bool') {
1854
+					$setting['type'] = 'checkbox';
1855
+		} elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') {
1856
+					$setting['type'] = 'number';
1857
+		} elseif ($setting['type'] == 'string') {
1858
+					$setting['type'] = 'text';
1859
+		}
1779 1860
 
1780
-		if (isset($setting['options']))
1781
-			$setting['type'] = 'list';
1861
+		if (isset($setting['options'])) {
1862
+					$setting['type'] = 'list';
1863
+		}
1782 1864
 
1783 1865
 		echo '
1784 1866
 					<dt>
1785 1867
 						<label for="', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>';
1786 1868
 
1787
-		if (isset($setting['description']))
1788
-			echo '
1869
+		if (isset($setting['description'])) {
1870
+					echo '
1789 1871
 						<br>
1790 1872
 						<span class="smalltext">', $setting['description'], '</span>';
1873
+		}
1791 1874
 		echo '
1792 1875
 					</dt>
1793 1876
 					<dd>';
1794 1877
 
1795 1878
 		// Display checkbox options
1796
-		if ($setting['type'] == 'checkbox')
1797
-			echo '
1879
+		if ($setting['type'] == 'checkbox') {
1880
+					echo '
1798 1881
 						<input type="hidden" name="default_options[' . $setting['id'] . ']" value="0">
1799 1882
 						<input type="checkbox" name="default_options[', $setting['id'], ']" id="', $setting['id'], '"', !empty($context['member']['options'][$setting['id']]) ? ' checked' : '', ' value="1">';
1883
+		}
1800 1884
 
1801 1885
 		// How about selection lists, we all love them
1802 1886
 		elseif ($setting['type'] == 'list')
@@ -1804,9 +1888,10 @@  discard block
 block discarded – undo
1804 1888
 			echo '
1805 1889
 						<select name="default_options[', $setting['id'], ']" id="', $setting['id'], '"', '>';
1806 1890
 
1807
-			foreach ($setting['options'] as $value => $label)
1808
-				echo '
1891
+			foreach ($setting['options'] as $value => $label) {
1892
+							echo '
1809 1893
 							<option value="', $value, '"', $value == $context['member']['options'][$setting['id']] ? ' selected' : '', '>', $label, '</option>';
1894
+			}
1810 1895
 
1811 1896
 			echo '
1812 1897
 						</select>';
@@ -1822,14 +1907,13 @@  discard block
 block discarded – undo
1822 1907
 
1823 1908
 				echo '
1824 1909
 						<input type="number"', $min . $max . $step;
1825
-			}
1826
-			elseif (isset($setting['type']) && $setting['type'] == 'url')
1827
-				echo'
1910
+			} elseif (isset($setting['type']) && $setting['type'] == 'url') {
1911
+							echo'
1828 1912
 						<input type="url"';
1829
-
1830
-			else
1831
-				echo '
1913
+			} else {
1914
+							echo '
1832 1915
 						<input type="text"';
1916
+			}
1833 1917
 
1834 1918
 			echo ' name="default_options[', $setting['id'], ']" id="', $setting['id'], '" value="', isset($context['member']['options'][$setting['id']]) ? $context['member']['options'][$setting['id']] : $setting['value'], '"', $setting['type'] == 'number' ? ' size="5"' : '', '>';
1835 1919
 		}
@@ -1866,8 +1950,8 @@  discard block
 block discarded – undo
1866 1950
 				<dl class="settings">';
1867 1951
 
1868 1952
 	// Allow notification on announcements to be disabled?
1869
-	if (!empty($modSettings['allow_disableAnnounce']))
1870
-		echo '
1953
+	if (!empty($modSettings['allow_disableAnnounce'])) {
1954
+			echo '
1871 1955
 					<dt>
1872 1956
 						<label for="notify_announcements">', $txt['notify_important_email'], '</label>
1873 1957
 					</dt>
@@ -1875,15 +1959,17 @@  discard block
 block discarded – undo
1875 1959
 						<input type="hidden" name="notify_announcements" value="0">
1876 1960
 						<input type="checkbox" id="notify_announcements" name="notify_announcements" value="1"', !empty($context['member']['notify_announcements']) ? ' checked' : '', '>
1877 1961
 					</dd>';
1962
+	}
1878 1963
 
1879
-	if (!empty($modSettings['enable_ajax_alerts']))
1880
-		echo '
1964
+	if (!empty($modSettings['enable_ajax_alerts'])) {
1965
+			echo '
1881 1966
 					<dt>
1882 1967
 						<label for="notify_send_body">', $txt['notify_alert_timeout'], '</label>
1883 1968
 					</dt>
1884 1969
 					<dd>
1885 1970
 						<input type="number" size="4" id="notify_alert_timeout" name="opt_alert_timeout" min="0" value="', $context['member']['alert_timeout'], '">
1886 1971
 					</dd>';
1972
+	}
1887 1973
 
1888 1974
 	echo '
1889 1975
 				</dl>
@@ -1915,9 +2001,10 @@  discard block
 block discarded – undo
1915 2001
 
1916 2002
 				$label = $txt['alert_opt_' . $opts[1]];
1917 2003
 				$label_pos = isset($opts['label']) ? $opts['label'] : '';
1918
-				if ($label_pos == 'before')
1919
-					echo '
2004
+				if ($label_pos == 'before') {
2005
+									echo '
1920 2006
 						<label for="opt_', $opts[1], '">', $label, '</label>';
2007
+				}
1921 2008
 
1922 2009
 				$this_value = isset($context['alert_prefs'][$opts[1]]) ? $context['alert_prefs'][$opts[1]] : 0;
1923 2010
 				switch ($opts[0])
@@ -1931,17 +2018,19 @@  discard block
 block discarded – undo
1931 2018
 						echo '
1932 2019
 						<select name="opt_', $opts[1], '" id="opt_', $opts[1], '">';
1933 2020
 
1934
-						foreach ($opts['opts'] as $k => $v)
1935
-							echo '
2021
+						foreach ($opts['opts'] as $k => $v) {
2022
+													echo '
1936 2023
 							<option value="', $k, '"', $this_value == $k ? ' selected' : '', '>', $v, '</option>';
2024
+						}
1937 2025
 						echo '
1938 2026
 						</select>';
1939 2027
 						break;
1940 2028
 				}
1941 2029
 
1942
-				if ($label_pos == 'after')
1943
-					echo '
2030
+				if ($label_pos == 'after') {
2031
+									echo '
1944 2032
 						<label for="opt_', $opts[1], '">', $label, '</label>';
2033
+				}
1945 2034
 
1946 2035
 				echo '
1947 2036
 					</td>
@@ -2058,11 +2147,12 @@  discard block
 block discarded – undo
2058 2147
 			<p class="information">', $txt['groupMembership_info'], '</p>';
2059 2148
 
2060 2149
 	// Do we have an update message?
2061
-	if (!empty($context['update_message']))
2062
-		echo '
2150
+	if (!empty($context['update_message'])) {
2151
+			echo '
2063 2152
 			<div class="infobox">
2064 2153
 				', $context['update_message'], '.
2065 2154
 			</div>';
2155
+	}
2066 2156
 
2067 2157
 	echo '
2068 2158
 			<div id="groups">';
@@ -2084,8 +2174,7 @@  discard block
 block discarded – undo
2084 2174
 						</div>
2085 2175
 					</div>
2086 2176
 				</div><!-- .groupmembership -->';
2087
-	}
2088
-	else
2177
+	} else
2089 2178
 	{
2090 2179
 		echo '
2091 2180
 				<div class="title_bar">
@@ -2097,27 +2186,30 @@  discard block
 block discarded – undo
2097 2186
 			echo '
2098 2187
 				<div class="windowbg" id="primdiv_', $group['id'], '">';
2099 2188
 
2100
-				if ($context['can_edit_primary'])
2101
-					echo '
2189
+				if ($context['can_edit_primary']) {
2190
+									echo '
2102 2191
 					<input type="radio" name="primary" id="primary_', $group['id'], '" value="', $group['id'], '"', $group['is_primary'] ? ' checked' : '', ' onclick="highlightSelected(\'primdiv_' . $group['id'] . '\');"', $group['can_be_primary'] ? '' : ' disabled', '>';
2192
+				}
2103 2193
 
2104 2194
 				echo '
2105 2195
 					<label for="primary_', $group['id'], '"><strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '</label>';
2106 2196
 
2107 2197
 				// Can they leave their group?
2108
-				if ($group['can_leave'])
2109
-					echo '
2198
+				if ($group['can_leave']) {
2199
+									echo '
2110 2200
 					<a href="' . $scripturl . '?action=profile;save;u=' . $context['id_member'] . ';area=groupmembership;' . $context['session_var'] . '=' . $context['session_id'] . ';gid=' . $group['id'] . ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '">' . $txt['leave_group'] . '</a>';
2201
+				}
2111 2202
 
2112 2203
 				echo '
2113 2204
 				</div><!-- .windowbg -->';
2114 2205
 		}
2115 2206
 
2116
-		if ($context['can_edit_primary'])
2117
-			echo '
2207
+		if ($context['can_edit_primary']) {
2208
+					echo '
2118 2209
 				<div class="padding righttext">
2119 2210
 					<input type="submit" value="', $txt['make_primary'], '" class="button">
2120 2211
 				</div>';
2212
+		}
2121 2213
 
2122 2214
 		// Any groups they can join?
2123 2215
 		if (!empty($context['groups']['available']))
@@ -2133,17 +2225,16 @@  discard block
 block discarded – undo
2133 2225
 				<div class="windowbg">
2134 2226
 					<strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '';
2135 2227
 
2136
-				if ($group['type'] == 3)
2137
-					echo '
2228
+				if ($group['type'] == 3) {
2229
+									echo '
2138 2230
 					<a href="', $scripturl, '?action=profile;save;u=', $context['id_member'], ';area=groupmembership;', $context['session_var'], '=', $context['session_id'], ';gid=', $group['id'], ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '" class="button floatright">', $txt['join_group'], '</a>';
2139
-
2140
-				elseif ($group['type'] == 2 && $group['pending'])
2141
-					echo '
2231
+				} elseif ($group['type'] == 2 && $group['pending']) {
2232
+									echo '
2142 2233
 					<span class="floatright">', $txt['approval_pending'], '</span>';
2143
-
2144
-				elseif ($group['type'] == 2)
2145
-					echo '
2234
+				} elseif ($group['type'] == 2) {
2235
+									echo '
2146 2236
 					<a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=groupmembership;request=', $group['id'], '" class="button floatright">', $txt['request_group'], '</a>';
2237
+				}
2147 2238
 
2148 2239
 				echo '
2149 2240
 				</div><!-- .windowbg -->';
@@ -2166,9 +2257,10 @@  discard block
 block discarded – undo
2166 2257
 
2167 2258
 						prevDiv.className = "windowbg";
2168 2259
 					}';
2169
-		if (isset($context['groups']['member'][$context['primary_group']]))
2170
-			echo '
2260
+		if (isset($context['groups']['member'][$context['primary_group']])) {
2261
+					echo '
2171 2262
 					highlightSelected("primdiv_' . $context['primary_group'] . '");';
2263
+		}
2172 2264
 
2173 2265
 		echo '
2174 2266
 				</script>';
@@ -2177,9 +2269,10 @@  discard block
 block discarded – undo
2177 2269
 	echo '
2178 2270
 			</div><!-- #groups -->';
2179 2271
 
2180
-	if (!empty($context['token_check']))
2181
-		echo '
2272
+	if (!empty($context['token_check'])) {
2273
+			echo '
2182 2274
 			<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2275
+	}
2183 2276
 
2184 2277
 	echo '
2185 2278
 			<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2227,14 +2320,15 @@  discard block
 block discarded – undo
2227 2320
 
2228 2321
 		foreach ($category['boards'] as $board)
2229 2322
 		{
2230
-			if ($i == $limit)
2231
-				echo '
2323
+			if ($i == $limit) {
2324
+							echo '
2232 2325
 						</ul>
2233 2326
 					</li>
2234 2327
 				</ul>
2235 2328
 				<ul class="ignoreboards floatright">
2236 2329
 					<li class="category">
2237 2330
 						<ul>';
2331
+			}
2238 2332
 
2239 2333
 			echo '
2240 2334
 							<li class="board" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;">
@@ -2279,10 +2373,11 @@  discard block
 block discarded – undo
2279 2373
 
2280 2374
 	// Work out the starting warning.
2281 2375
 	$context['current_warning_mode'] = $context['warning_mode'][0];
2282
-	foreach ($context['warning_mode'] as $limit => $warning)
2283
-		if ($context['member']['warning'] >= $limit)
2376
+	foreach ($context['warning_mode'] as $limit => $warning) {
2377
+			if ($context['member']['warning'] >= $limit)
2284 2378
 			$context['current_warning_mode'] = $warning;
2285
-}
2379
+	}
2380
+	}
2286 2381
 
2287 2382
 // Show all warnings of a user?
2288 2383
 function template_viewWarning()
@@ -2317,14 +2412,15 @@  discard block
 block discarded – undo
2317 2412
 				</dd>';
2318 2413
 
2319 2414
 	// There's some impact of this?
2320
-	if (!empty($context['level_effects'][$context['current_level']]))
2321
-		echo '
2415
+	if (!empty($context['level_effects'][$context['current_level']])) {
2416
+			echo '
2322 2417
 				<dt>
2323 2418
 					<strong>', $txt['profile_viewwarning_impact'], ':</strong>
2324 2419
 				</dt>
2325 2420
 				<dd>
2326 2421
 					', $context['level_effects'][$context['current_level']], '
2327 2422
 				</dd>';
2423
+	}
2328 2424
 
2329 2425
 	echo '
2330 2426
 			</dl>
@@ -2362,10 +2458,11 @@  discard block
 block discarded – undo
2362 2458
 
2363 2459
 			// Otherwise see what we can do...';
2364 2460
 
2365
-	foreach ($context['notification_templates'] as $k => $type)
2366
-		echo '
2461
+	foreach ($context['notification_templates'] as $k => $type) {
2462
+			echo '
2367 2463
 			if (index == ', $k, ')
2368 2464
 				document.getElementById(\'warn_body\').value = "', strtr($type['body'], array('"' => "'", "\n" => '\\n', "\r" => '')), '";';
2465
+	}
2369 2466
 
2370 2467
 	echo '
2371 2468
 		}
@@ -2375,10 +2472,11 @@  discard block
 block discarded – undo
2375 2472
 			// Also set the right effect.
2376 2473
 			effectText = "";';
2377 2474
 
2378
-	foreach ($context['level_effects'] as $limit => $text)
2379
-		echo '
2475
+	foreach ($context['level_effects'] as $limit => $text) {
2476
+			echo '
2380 2477
 			if (slideAmount >= ', $limit, ')
2381 2478
 				effectText = "', $text, '";';
2479
+	}
2382 2480
 
2383 2481
 	echo '
2384 2482
 			setInnerHTML(document.getElementById(\'cur_level_div\'), slideAmount + \'% (\' + effectText + \')\');
@@ -2393,32 +2491,35 @@  discard block
 block discarded – undo
2393 2491
 			</h3>
2394 2492
 		</div>';
2395 2493
 
2396
-	if (!$context['user']['is_owner'])
2397
-		echo '
2494
+	if (!$context['user']['is_owner']) {
2495
+			echo '
2398 2496
 		<p class="information">', $txt['profile_warning_desc'], '</p>';
2497
+	}
2399 2498
 
2400 2499
 	echo '
2401 2500
 		<div class="windowbg">
2402 2501
 			<dl class="settings">';
2403 2502
 
2404
-	if (!$context['user']['is_owner'])
2405
-		echo '
2503
+	if (!$context['user']['is_owner']) {
2504
+			echo '
2406 2505
 				<dt>
2407 2506
 					<strong>', $txt['profile_warning_name'], ':</strong>
2408 2507
 				</dt>
2409 2508
 				<dd>
2410 2509
 					<strong>', $context['member']['name'], '</strong>
2411 2510
 				</dd>';
2511
+	}
2412 2512
 
2413 2513
 	echo '
2414 2514
 				<dt>
2415 2515
 					<strong>', $txt['profile_warning_level'], ':</strong>';
2416 2516
 
2417 2517
 	// Is there only so much they can apply?
2418
-	if ($context['warning_limit'])
2419
-		echo '
2518
+	if ($context['warning_limit']) {
2519
+			echo '
2420 2520
 					<br>
2421 2521
 					<span class="smalltext">', sprintf($txt['profile_warning_limit_attribute'], $context['warning_limit']), '</span>';
2522
+	}
2422 2523
 
2423 2524
 	echo '
2424 2525
 				</dt>
@@ -2473,9 +2574,10 @@  discard block
 block discarded – undo
2473 2574
 						<option value="-1">', $txt['profile_warning_notify_template'], '</option>
2474 2575
 						<option value="-1" disabled>------------------------------</option>';
2475 2576
 
2476
-		foreach ($context['notification_templates'] as $id_template => $template)
2477
-			echo '
2577
+		foreach ($context['notification_templates'] as $id_template => $template) {
2578
+					echo '
2478 2579
 						<option value="', $id_template, '">', $template['title'], '</option>';
2580
+		}
2479 2581
 
2480 2582
 		echo '
2481 2583
 					</select>
@@ -2488,9 +2590,10 @@  discard block
 block discarded – undo
2488 2590
 			</dl>
2489 2591
 			<div class="righttext">';
2490 2592
 
2491
-	if (!empty($context['token_check']))
2492
-		echo '
2593
+	if (!empty($context['token_check'])) {
2594
+			echo '
2493 2595
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2596
+	}
2494 2597
 
2495 2598
 	echo '
2496 2599
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2506,8 +2609,8 @@  discard block
 block discarded – undo
2506 2609
 	echo '
2507 2610
 	<script>';
2508 2611
 
2509
-	if (!$context['user']['is_owner'])
2510
-		echo '
2612
+	if (!$context['user']['is_owner']) {
2613
+			echo '
2511 2614
 		modifyWarnNotify();
2512 2615
 		$(document).ready(function() {
2513 2616
 			$("#preview_button").click(function() {
@@ -2546,6 +2649,7 @@  discard block
 block discarded – undo
2546 2649
 			});
2547 2650
 			return false;
2548 2651
 		}';
2652
+	}
2549 2653
 
2550 2654
 	echo '
2551 2655
 	</script>';
@@ -2568,17 +2672,19 @@  discard block
 block discarded – undo
2568 2672
 			</div>';
2569 2673
 
2570 2674
 	// If deleting another account give them a lovely info box.
2571
-	if (!$context['user']['is_owner'])
2572
-		echo '
2675
+	if (!$context['user']['is_owner']) {
2676
+			echo '
2573 2677
 			<p class="information">', $txt['deleteAccount_desc'], '</p>';
2678
+	}
2574 2679
 
2575 2680
 	echo '
2576 2681
 			<div class="windowbg">';
2577 2682
 
2578 2683
 	// If they are deleting their account AND the admin needs to approve it - give them another piece of info ;)
2579
-	if ($context['needs_approval'])
2580
-		echo '
2684
+	if ($context['needs_approval']) {
2685
+			echo '
2581 2686
 				<div class="errorbox">', $txt['deleteAccount_approval'], '</div>';
2687
+	}
2582 2688
 
2583 2689
 	// If the user is deleting their own account warn them first - and require a password!
2584 2690
 	if ($context['user']['is_owner'])
@@ -2590,9 +2696,10 @@  discard block
 block discarded – undo
2590 2696
 					<input type="password" name="oldpasswrd" size="20">
2591 2697
 					<input type="submit" value="', $txt['yes'], '" class="button">';
2592 2698
 
2593
-		if (!empty($context['token_check']))
2594
-			echo '
2699
+		if (!empty($context['token_check'])) {
2700
+					echo '
2595 2701
 					<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2702
+		}
2596 2703
 
2597 2704
 		echo '
2598 2705
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2622,10 +2729,11 @@  discard block
 block discarded – undo
2622 2729
 						<option value="topics">', $txt['deleteAccount_topics'], '</option>
2623 2730
 					</select>';
2624 2731
 
2625
-			if ($context['show_perma_delete'])
2626
-				echo '
2732
+			if ($context['show_perma_delete']) {
2733
+							echo '
2627 2734
 					<br>
2628 2735
 					<label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1">', $txt['deleteAccount_permanent'], ':</label>';
2736
+			}
2629 2737
 
2630 2738
 			echo '
2631 2739
 				</div>';
@@ -2638,9 +2746,10 @@  discard block
 block discarded – undo
2638 2746
 				<div>
2639 2747
 					<input type="submit" value="', $txt['delete'], '" class="button">';
2640 2748
 
2641
-		if (!empty($context['token_check']))
2642
-			echo '
2749
+		if (!empty($context['token_check'])) {
2750
+					echo '
2643 2751
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2752
+		}
2644 2753
 
2645 2754
 		echo '
2646 2755
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2666,8 +2775,8 @@  discard block
 block discarded – undo
2666 2775
 					<hr>';
2667 2776
 
2668 2777
 	// Only show the password box if it's actually needed.
2669
-	if ($context['require_password'])
2670
-		echo '
2778
+	if ($context['require_password']) {
2779
+			echo '
2671 2780
 					<dl class="settings">
2672 2781
 						<dt>
2673 2782
 							<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '>', $txt['current_password'], ': </strong><br>
@@ -2677,13 +2786,15 @@  discard block
 block discarded – undo
2677 2786
 							<input type="password" name="oldpasswrd" size="20">
2678 2787
 						</dd>
2679 2788
 					</dl>';
2789
+	}
2680 2790
 
2681 2791
 	echo '
2682 2792
 					<div class="righttext">';
2683 2793
 
2684
-	if (!empty($context['token_check']))
2685
-		echo '
2794
+	if (!empty($context['token_check'])) {
2795
+			echo '
2686 2796
 						<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2797
+	}
2687 2798
 
2688 2799
 	echo '
2689 2800
 						<input type="submit" value="', $txt['change_profile'], '" class="button">
@@ -2710,9 +2821,10 @@  discard block
 block discarded – undo
2710 2821
 			<ul id="list_errors">';
2711 2822
 
2712 2823
 		// Cycle through each error and display an error message.
2713
-		foreach ($context['post_errors'] as $error)
2714
-			echo '
2824
+		foreach ($context['post_errors'] as $error) {
2825
+					echo '
2715 2826
 				<li>', isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : $error, '</li>';
2827
+		}
2716 2828
 
2717 2829
 		echo '
2718 2830
 			</ul>';
@@ -2738,12 +2850,13 @@  discard block
 block discarded – undo
2738 2850
 								<select name="id_group" ', ($context['user']['is_owner'] && $context['member']['group_id'] == 1 ? 'onchange="if (this.value != 1 &amp;&amp; !confirm(\'' . $txt['deadmin_confirm'] . '\')) this.value = 1;"' : ''), '>';
2739 2851
 
2740 2852
 	// Fill the select box with all primary member groups that can be assigned to a member.
2741
-	foreach ($context['member_groups'] as $member_group)
2742
-		if (!empty($member_group['can_be_primary']))
2853
+	foreach ($context['member_groups'] as $member_group) {
2854
+			if (!empty($member_group['can_be_primary']))
2743 2855
 			echo '
2744 2856
 									<option value="', $member_group['id'], '"', $member_group['is_primary'] ? ' selected' : '', '>
2745 2857
 										', $member_group['name'], '
2746 2858
 									</option>';
2859
+	}
2747 2860
 
2748 2861
 	echo '
2749 2862
 								</select>
@@ -2756,10 +2869,11 @@  discard block
 block discarded – undo
2756 2869
 									<input type="hidden" name="additional_groups[]" value="0">';
2757 2870
 
2758 2871
 	// For each membergroup show a checkbox so members can be assigned to more than one group.
2759
-	foreach ($context['member_groups'] as $member_group)
2760
-		if ($member_group['can_be_additional'])
2872
+	foreach ($context['member_groups'] as $member_group) {
2873
+			if ($member_group['can_be_additional'])
2761 2874
 			echo '
2762 2875
 									<label for="additional_groups-', $member_group['id'], '"><input type="checkbox" name="additional_groups[]" value="', $member_group['id'], '" id="additional_groups-', $member_group['id'], '"', $member_group['is_additional'] ? ' checked' : '', '> ', $member_group['name'], '</label><br>';
2876
+	}
2763 2877
 
2764 2878
 	echo '
2765 2879
 								</span>
@@ -2819,9 +2933,10 @@  discard block
 block discarded – undo
2819 2933
 								<span class="smalltext">', $txt['sig_info'], '</span><br>
2820 2934
 								<br>';
2821 2935
 
2822
-	if ($context['show_spellchecking'])
2823
-		echo '
2936
+	if ($context['show_spellchecking']) {
2937
+			echo '
2824 2938
 								<input type="button" value="', $txt['spell_check'], '" onclick="spellCheck(\'creator\', \'signature\');" class="button">';
2939
+	}
2825 2940
 
2826 2941
 	echo '
2827 2942
 							</dt>
@@ -2829,17 +2944,20 @@  discard block
 block discarded – undo
2829 2944
 								<textarea class="editor" onkeyup="calcCharLeft();" id="signature" name="signature" rows="5" cols="50">', $context['member']['signature'], '</textarea><br>';
2830 2945
 
2831 2946
 	// If there is a limit at all!
2832
-	if (!empty($context['signature_limits']['max_length']))
2833
-		echo '
2947
+	if (!empty($context['signature_limits']['max_length'])) {
2948
+			echo '
2834 2949
 								<span class="smalltext">', sprintf($txt['max_sig_characters'], $context['signature_limits']['max_length']), ' <span id="signatureLeft">', $context['signature_limits']['max_length'], '</span></span><br>';
2950
+	}
2835 2951
 
2836
-	if (!empty($context['show_preview_button']))
2837
-		echo '
2952
+	if (!empty($context['show_preview_button'])) {
2953
+			echo '
2838 2954
 								<input type="button" name="preview_signature" id="preview_button" value="', $txt['preview_signature'], '" class="button floatright">';
2955
+	}
2839 2956
 
2840
-	if ($context['signature_warning'])
2841
-		echo '
2957
+	if ($context['signature_warning']) {
2958
+			echo '
2842 2959
 								<span class="smalltext">', $context['signature_warning'], '</span>';
2960
+	}
2843 2961
 
2844 2962
 	// Some javascript used to count how many characters have been used so far in the signature.
2845 2963
 	echo '
@@ -2870,38 +2988,43 @@  discard block
 block discarded – undo
2870 2988
 									<label for="avatar_upload_box">', $txt['personal_picture'], '</label>
2871 2989
 								</strong>';
2872 2990
 
2873
-	if (empty($modSettings['gravatarOverride']))
2874
-		echo '
2991
+	if (empty($modSettings['gravatarOverride'])) {
2992
+			echo '
2875 2993
 								<input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_none" value="none"' . ($context['member']['avatar']['choice'] == 'none' ? ' checked="checked"' : '') . '>
2876 2994
 								<label for="avatar_choice_none"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '>
2877 2995
 									' . $txt['no_avatar'] . '
2878 2996
 								</label><br>';
2997
+	}
2879 2998
 
2880
-	if (!empty($context['member']['avatar']['allow_server_stored']))
2881
-		echo '
2999
+	if (!empty($context['member']['avatar']['allow_server_stored'])) {
3000
+			echo '
2882 3001
 								<input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_server_stored" value="server_stored"' . ($context['member']['avatar']['choice'] == 'server_stored' ? ' checked="checked"' : '') . '>
2883 3002
 								<label for="avatar_choice_server_stored"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '>
2884 3003
 									', $txt['choose_avatar_gallery'], '
2885 3004
 								</label><br>';
3005
+	}
2886 3006
 
2887
-	if (!empty($context['member']['avatar']['allow_external']))
2888
-		echo '
3007
+	if (!empty($context['member']['avatar']['allow_external'])) {
3008
+			echo '
2889 3009
 								<input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_external" value="external"' . ($context['member']['avatar']['choice'] == 'external' ? ' checked="checked"' : '') . '>
2890 3010
 								<label for="avatar_choice_external"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '>
2891 3011
 									', $txt['my_own_pic'], '
2892 3012
 								</label><br>';
3013
+	}
2893 3014
 
2894
-	if (!empty($context['member']['avatar']['allow_upload']))
2895
-		echo '
3015
+	if (!empty($context['member']['avatar']['allow_upload'])) {
3016
+			echo '
2896 3017
 								<input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_upload" value="upload"' . ($context['member']['avatar']['choice'] == 'upload' ? ' checked="checked"' : '') . '>
2897 3018
 								<label for="avatar_choice_upload"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '>
2898 3019
 									', $txt['avatar_will_upload'], '
2899 3020
 								</label><br>';
3021
+	}
2900 3022
 
2901
-	if (!empty($context['member']['avatar']['allow_gravatar']))
2902
-		echo '
3023
+	if (!empty($context['member']['avatar']['allow_gravatar'])) {
3024
+			echo '
2903 3025
 								<input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_gravatar" value="gravatar"' . ($context['member']['avatar']['choice'] == 'gravatar' ? ' checked="checked"' : '') . '>
2904 3026
 								<label for="avatar_choice_gravatar"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '>' . $txt['use_gravatar'] . '</label>';
3027
+	}
2905 3028
 
2906 3029
 	echo '
2907 3030
 							</dt>
@@ -2916,9 +3039,10 @@  discard block
 block discarded – undo
2916 3039
 										<select name="cat" id="cat" size="10" onchange="changeSel(\'\');" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'server_stored\');">';
2917 3040
 
2918 3041
 		// This lists all the file categories.
2919
-		foreach ($context['avatars'] as $avatar)
2920
-			echo '
3042
+		foreach ($context['avatars'] as $avatar) {
3043
+					echo '
2921 3044
 											<option value="', $avatar['filename'] . ($avatar['is_dir'] ? '/' : ''), '"', ($avatar['checked'] ? ' selected' : ''), '>', $avatar['name'], '</option>';
3045
+		}
2922 3046
 
2923 3047
 		echo '
2924 3048
 										</select>
@@ -2950,20 +3074,22 @@  discard block
 block discarded – undo
2950 3074
 	}
2951 3075
 
2952 3076
 	// If the user can link to an off server avatar, show them a box to input the address.
2953
-	if (!empty($context['member']['avatar']['allow_external']))
2954
-		echo '
3077
+	if (!empty($context['member']['avatar']['allow_external'])) {
3078
+			echo '
2955 3079
 								<div id="avatar_external">
2956 3080
 									<div class="smalltext">', $txt['avatar_by_url'], '</div>', !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_download_and_resize' ? template_max_size('external') : '', '
2957 3081
 									<input type="text" name="userpicpersonal" size="45" value="', ((stristr($context['member']['avatar']['external'], 'http://') || stristr($context['member']['avatar']['external'], 'https://')) ? $context['member']['avatar']['external'] : 'http://'), '" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'external\');" onchange="if (typeof(previewExternalAvatar) != \'undefined\') previewExternalAvatar(this.value);">
2958 3082
 								</div>';
3083
+	}
2959 3084
 
2960 3085
 	// If the user is able to upload avatars to the server show them an upload box.
2961
-	if (!empty($context['member']['avatar']['allow_upload']))
2962
-		echo '
3086
+	if (!empty($context['member']['avatar']['allow_upload'])) {
3087
+			echo '
2963 3088
 								<div id="avatar_upload">
2964 3089
 									<input type="file" size="44" name="attachment" id="avatar_upload_box" value="" onchange="readfromUpload(this)"  onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'upload\');" accept="image/gif, image/jpeg, image/jpg, image/png">', template_max_size('upload'), '
2965 3090
 									', (!empty($context['member']['avatar']['id_attach']) ? '<br><img src="' . $context['member']['avatar']['href'] . (strpos($context['member']['avatar']['href'], '?') === false ? '?' : '&amp;') . 'time=' . time() . '" alt="" id="attached_image"><input type="hidden" name="id_attach" value="' . $context['member']['avatar']['id_attach'] . '">' : ''), '
2966 3091
 								</div>';
3092
+	}
2967 3093
 
2968 3094
 	// if the user is able to use Gravatar avatars show then the image preview
2969 3095
 	if (!empty($context['member']['avatar']['allow_gravatar']))
@@ -2972,16 +3098,17 @@  discard block
 block discarded – undo
2972 3098
 								<div id="avatar_gravatar">
2973 3099
 									<img src="' . $context['member']['avatar']['href'] . '" alt="">';
2974 3100
 
2975
-		if (empty($modSettings['gravatarAllowExtraEmail']))
2976
-			echo '
3101
+		if (empty($modSettings['gravatarAllowExtraEmail'])) {
3102
+					echo '
2977 3103
 									<div class="smalltext">', $txt['gravatar_noAlternateEmail'], '</div>';
2978
-		else
3104
+		} else
2979 3105
 		{
2980 3106
 			// Depending on other stuff, the stored value here might have some odd things in it from other areas.
2981
-			if ($context['member']['avatar']['external'] == $context['member']['email'])
2982
-				$textbox_value = '';
2983
-			else
2984
-				$textbox_value = $context['member']['avatar']['external'];
3107
+			if ($context['member']['avatar']['external'] == $context['member']['email']) {
3108
+							$textbox_value = '';
3109
+			} else {
3110
+							$textbox_value = $context['member']['avatar']['external'];
3111
+			}
2985 3112
 
2986 3113
 			echo '
2987 3114
 									<div class="smalltext">', $txt['gravatar_alternateEmail'], '</div>
@@ -3053,8 +3180,9 @@  discard block
 block discarded – undo
3053 3180
 	$h = !empty($modSettings['avatar_max_height_' . $type]) ? comma_format($modSettings['avatar_max_height_' . $type]) : 0;
3054 3181
 
3055 3182
 	$suffix = (!empty($w) ? 'w' : '') . (!empty($h) ? 'h' : '');
3056
-	if (empty($suffix))
3057
-		return;
3183
+	if (empty($suffix)) {
3184
+			return;
3185
+	}
3058 3186
 
3059 3187
 	echo '
3060 3188
 								<div class="smalltext">', sprintf($txt['avatar_max_size_' . $suffix], $w, $h), '</div>';
@@ -3079,9 +3207,10 @@  discard block
 block discarded – undo
3079 3207
 								<select name="easyformat" id="easyformat" onchange="document.forms.creator.time_format.value = this.options[this.selectedIndex].value;">';
3080 3208
 
3081 3209
 	// Help the user by showing a list of common time formats.
3082
-	foreach ($context['easy_timeformats'] as $time_format)
3083
-		echo '
3210
+	foreach ($context['easy_timeformats'] as $time_format) {
3211
+			echo '
3084 3212
 									<option value="', $time_format['format'], '"', $time_format['format'] == $context['member']['time_format'] ? ' selected' : '', '>', $time_format['title'], '</option>';
3213
+	}
3085 3214
 
3086 3215
 	echo '
3087 3216
 								</select>
@@ -3119,9 +3248,10 @@  discard block
 block discarded – undo
3119 3248
 							<dd>
3120 3249
 								<select name="smiley_set" id="smiley_set" onchange="document.getElementById(\'smileypr\').src = this.selectedIndex == 0 ? \'', $settings['images_url'], '/blank.png\' : \'', $modSettings['smileys_url'], '/\' + (this.selectedIndex != 1 ? this.options[this.selectedIndex].value : \'', !empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'], '\') + \'/smiley.png\';">';
3121 3250
 
3122
-	foreach ($context['smiley_sets'] as $set)
3123
-		echo '
3251
+	foreach ($context['smiley_sets'] as $set) {
3252
+			echo '
3124 3253
 									<option value="', $set['id'], '"', $set['selected'] ? ' selected' : '', '>', $set['name'], '</option>';
3254
+	}
3125 3255
 
3126 3256
 	echo '
3127 3257
 								</select>
@@ -3143,17 +3273,17 @@  discard block
 block discarded – undo
3143 3273
 			<div class="roundframe">
3144 3274
 				<div>';
3145 3275
 
3146
-	if (!empty($context['tfa_backup']))
3147
-		echo '
3276
+	if (!empty($context['tfa_backup'])) {
3277
+			echo '
3148 3278
 					<div class="smalltext error">
3149 3279
 						', $txt['tfa_backup_used_desc'], '
3150 3280
 					</div>';
3151
-
3152
-	elseif ($modSettings['tfa_mode'] == 2)
3153
-		echo '
3281
+	} elseif ($modSettings['tfa_mode'] == 2) {
3282
+			echo '
3154 3283
 					<div class="smalltext">
3155 3284
 						<strong>', $txt['tfa_forced_desc'], '</strong>
3156 3285
 					</div>';
3286
+	}
3157 3287
 
3158 3288
 	echo '
3159 3289
 					<div class="smalltext">
@@ -3164,11 +3294,12 @@  discard block
 block discarded – undo
3164 3294
 							<div class="block">
3165 3295
 								<strong>', $txt['tfa_step1'], '</strong><br>';
3166 3296
 
3167
-	if (!empty($context['tfa_pass_error']))
3168
-		echo '
3297
+	if (!empty($context['tfa_pass_error'])) {
3298
+			echo '
3169 3299
 								<div class="error smalltext">
3170 3300
 									', $txt['tfa_pass_invalid'], '
3171 3301
 								</div>';
3302
+	}
3172 3303
 
3173 3304
 	echo '
3174 3305
 								<input type="password" name="passwd" size="25"', !empty($context['tfa_pass_error']) ? ' class="error"' : '', !empty($context['tfa_pass_value']) ? ' value="' . $context['tfa_pass_value'] . '"' : '', '>
@@ -3181,11 +3312,12 @@  discard block
 block discarded – undo
3181 3312
 							<div class="block">
3182 3313
 								<strong>', $txt['tfa_step3'], '</strong><br>';
3183 3314
 
3184
-	if (!empty($context['tfa_error']))
3185
-		echo '
3315
+	if (!empty($context['tfa_error'])) {
3316
+			echo '
3186 3317
 								<div class="error smalltext">
3187 3318
 									', $txt['tfa_code_invalid'], '
3188 3319
 								</div>';
3320
+	}
3189 3321
 
3190 3322
 	echo '
3191 3323
 								<input type="text" name="tfa_code" size="25"', !empty($context['tfa_error']) ? ' class="error"' : '', !empty($context['tfa_value']) ? ' value="' . $context['tfa_value'] . '"' : '', '>
@@ -3199,10 +3331,11 @@  discard block
 block discarded – undo
3199 3331
 						<img src="', $context['tfa_qr_url'], '" alt="">
3200 3332
 					</div>';
3201 3333
 
3202
-	if (!empty($context['from_ajax']))
3203
-		echo '
3334
+	if (!empty($context['from_ajax'])) {
3335
+			echo '
3204 3336
 					<br>
3205 3337
 					<a href="javascript:self.close();"></a>';
3338
+	}
3206 3339
 
3207 3340
 	echo '
3208 3341
 				</div>
@@ -3242,17 +3375,16 @@  discard block
 block discarded – undo
3242 3375
 							</dt>
3243 3376
 							<dd>';
3244 3377
 
3245
-	if (!$context['tfa_enabled'] && $context['user']['is_owner'])
3246
-		echo '
3378
+	if (!$context['tfa_enabled'] && $context['user']['is_owner']) {
3379
+			echo '
3247 3380
 								<a href="', !empty($modSettings['force_ssl']) ? strtr($scripturl, array('http://' => 'https://')) : $scripturl, '?action=profile;area=tfasetup" id="enable_tfa">', $txt['tfa_profile_enable'], '</a>';
3248
-
3249
-	elseif (!$context['tfa_enabled'])
3250
-		echo '
3381
+	} elseif (!$context['tfa_enabled']) {
3382
+			echo '
3251 3383
 								', $txt['tfa_profile_disabled'];
3252
-
3253
-	else
3254
-		echo '
3384
+	} else {
3385
+			echo '
3255 3386
 								', sprintf($txt['tfa_profile_enabled'], $scripturl . '?action=profile;u=' . $context['id_member'] . ';area=tfasetup;disable');
3387
+	}
3256 3388
 
3257 3389
 	echo '
3258 3390
 							</dd>';
@@ -3275,17 +3407,19 @@  discard block
 block discarded – undo
3275 3407
 			</div>';
3276 3408
 
3277 3409
 	// If deleting another account give them a lovely info box.
3278
-	if (!$context['user']['is_owner'])
3279
-		echo '
3410
+	if (!$context['user']['is_owner']) {
3411
+			echo '
3280 3412
 			<p class="information">', $txt['deleteAccount_desc'], '</p>';
3413
+	}
3281 3414
 
3282 3415
 	echo '
3283 3416
 			<div class="windowbg">';
3284 3417
 
3285 3418
 	// If they are deleting their account AND the admin needs to approve it - give them another piece of info ;)
3286
-	if ($context['needs_approval'])
3287
-		echo '
3419
+	if ($context['needs_approval']) {
3420
+			echo '
3288 3421
 				<div class="errorbox">', $txt['deleteAccount_approval'], '</div>';
3422
+	}
3289 3423
 
3290 3424
 	// If the user is deleting their own account warn them first - and require a password!
3291 3425
 	if ($context['user']['is_owner'])
@@ -3297,9 +3431,10 @@  discard block
 block discarded – undo
3297 3431
 					<input type="password" name="oldpasswrd" size="20">
3298 3432
 					<input type="submit" value="', $txt['yes'], '" class="button">';
3299 3433
 
3300
-		if (!empty($context['token_check']))
3301
-			echo '
3434
+		if (!empty($context['token_check'])) {
3435
+					echo '
3302 3436
 					<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
3437
+		}
3303 3438
 
3304 3439
 		echo '
3305 3440
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -3329,10 +3464,11 @@  discard block
 block discarded – undo
3329 3464
 						<option value="topics">', $txt['deleteAccount_topics'], '</option>
3330 3465
 					</select>';
3331 3466
 
3332
-			if ($context['show_perma_delete'])
3333
-				echo '
3467
+			if ($context['show_perma_delete']) {
3468
+							echo '
3334 3469
 					<br>
3335 3470
 					<label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1">', $txt['deleteAccount_permanent'], ':</label>';
3471
+			}
3336 3472
 
3337 3473
 			echo '
3338 3474
 				</div>';
@@ -3345,9 +3481,10 @@  discard block
 block discarded – undo
3345 3481
 				<div>
3346 3482
 					<input type="submit" value="', $txt['delete'], '" class="button">';
3347 3483
 
3348
-		if (!empty($context['token_check']))
3349
-			echo '
3484
+		if (!empty($context['token_check'])) {
3485
+					echo '
3350 3486
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
3487
+		}
3351 3488
 
3352 3489
 		echo '
3353 3490
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
Please login to merge, or discard this patch.
Sources/Profile-Actions.php 3 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1050,15 +1050,15 @@
 block discarded – undo
1050 1050
 }
1051 1051
 
1052 1052
 /**
1053
-  * Formats a line (passed as a fields  array) as CSV and returns the CSV as a string.
1054
-  * from https://stackoverflow.com/questions/3933668/convert-array-into-csv
1053
+ * Formats a line (passed as a fields  array) as CSV and returns the CSV as a string.
1054
+ * from https://stackoverflow.com/questions/3933668/convert-array-into-csv
1055 1055
  * 
1056 1056
  * @param array $fields a line of the array
1057 1057
  * @param string @delimiter the delimiter char
1058 1058
  * @param string @enclosure the enclosure char
1059 1059
  * @param boolean $encloseAll enclose all
1060 1060
  * @param boolean $nullToMysqlNull
1061
-  */
1061
+ */
1062 1062
 function arrayToCsv( array $fields, $delimiter = ';', $enclosure = '"', $encloseAll = false, $nullToMysqlNull = false ) {
1063 1063
 	$delimiter_esc = preg_quote($delimiter, '/');
1064 1064
 	$enclosure_esc = preg_quote($enclosure, '/');
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -984,12 +984,12 @@  discard block
 block discarded – undo
984 984
 	{
985 985
 		loadMemberData($memID, false, 'profile');
986 986
 		$profile = $user_profile[$memID];
987
-		$removeFields = array('secret_question','tfa_secret','password_salt');
987
+		$removeFields = array('secret_question', 'tfa_secret', 'password_salt');
988 988
 		foreach ($removeFields as $value)
989 989
 		{
990 990
 			unset($profile[$value]);
991 991
 		}
992
-		foreach($profile as $key => &$value)
992
+		foreach ($profile as $key => &$value)
993 993
 		{
994 994
 			if (is_array($value))
995 995
 				$value = $smcFunc['json_encode']($value);
@@ -1001,7 +1001,7 @@  discard block
 block discarded – undo
1001 1001
 	elseif ($mode == 'messages') // messages
1002 1002
 	{
1003 1003
 		
1004
-		$request = $smcFunc['db_query']('','
1004
+		$request = $smcFunc['db_query']('', '
1005 1005
 			SELECT id_msg, id_topic, poster_time, subject, modified_time, modified_name, modified_reason, body, likes, poster_ip
1006 1006
 			FROM {db_prefix}messages 
1007 1007
 			WHERE id_member = {int:memID}',
@@ -1017,7 +1017,7 @@  discard block
 block discarded – undo
1017 1017
 	}
1018 1018
 	else
1019 1019
 	{
1020
-		$request = $smcFunc['db_query']('','
1020
+		$request = $smcFunc['db_query']('', '
1021 1021
 			SELECT pm.msgtime, pm.subject, pm.body
1022 1022
 			FROM {db_prefix}personal_messages pm
1023 1023
 			LEFT JOIN {db_prefix}pm_recipients pmr on (pm.id_pm = pmr.id_pm and pmr.id_member = {int:memID})
@@ -1033,14 +1033,14 @@  discard block
 block discarded – undo
1033 1033
 	}
1034 1034
 	$count = count($profileData);
1035 1035
 	$csv_data = '';
1036
-	for($i = 0; $i < $count; $i++)
1036
+	for ($i = 0; $i < $count; $i++)
1037 1037
 	{
1038 1038
 		$csv_data .= arrayToCsv($profileData[$i]) . "\r\n";
1039 1039
 	}
1040 1040
 
1041 1041
 
1042 1042
 	header("Pragma: no-cache");
1043
-	header('Content-Disposition: attachment; filename="privacySMF'.$mode.'.csv";');
1043
+	header('Content-Disposition: attachment; filename="privacySMF' . $mode . '.csv";');
1044 1044
 	header("Content-Length: " . strlen($csv_data));
1045 1045
 	header("Content-Transfer-Encoding: binary");
1046 1046
 	header("Content-Type: application/force-download");
@@ -1059,12 +1059,12 @@  discard block
 block discarded – undo
1059 1059
  * @param boolean $encloseAll enclose all
1060 1060
  * @param boolean $nullToMysqlNull
1061 1061
   */
1062
-function arrayToCsv( array $fields, $delimiter = ';', $enclosure = '"', $encloseAll = false, $nullToMysqlNull = false ) {
1062
+function arrayToCsv(array $fields, $delimiter = ';', $enclosure = '"', $encloseAll = false, $nullToMysqlNull = false) {
1063 1063
 	$delimiter_esc = preg_quote($delimiter, '/');
1064 1064
 	$enclosure_esc = preg_quote($enclosure, '/');
1065 1065
 
1066 1066
 	$output = array();
1067
-	foreach ( $fields as $field )
1067
+	foreach ($fields as $field)
1068 1068
 	{
1069 1069
 		if ($field === null && $nullToMysqlNull)
1070 1070
 		{
@@ -1073,7 +1073,7 @@  discard block
 block discarded – undo
1073 1073
 		}
1074 1074
 
1075 1075
 		// Enclose fields containing $delimiter, $enclosure or whitespace
1076
-		if ( $encloseAll || preg_match( "/(?:${delimiter_esc}|${enclosure_esc}|\s)/", $field ) )
1076
+		if ($encloseAll || preg_match("/(?:${delimiter_esc}|${enclosure_esc}|\s)/", $field))
1077 1077
 		{
1078 1078
 			$output[] = $enclosure . str_replace($enclosure, $enclosure . $enclosure, $field) . $enclosure;
1079 1079
 		}
@@ -1083,7 +1083,7 @@  discard block
 block discarded – undo
1083 1083
 		}
1084 1084
 	}
1085 1085
 
1086
-	return implode( $delimiter, $output );
1086
+	return implode($delimiter, $output);
1087 1087
 }
1088 1088
 
1089 1089
 ?>
1090 1090
\ No newline at end of file
Please login to merge, or discard this patch.
Braces   +128 added lines, -95 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Activate an account.
@@ -48,8 +49,9 @@  discard block
 block discarded – undo
48 49
 		logAction('approve_member', array('member' => $memID), 'admin');
49 50
 
50 51
 		// If we are doing approval, update the stats for the member just in case.
51
-		if (in_array($user_profile[$memID]['is_activated'], array(3, 4, 5, 13, 14, 15)))
52
-			updateSettings(array('unapprovedMembers' => ($modSettings['unapprovedMembers'] > 1 ? $modSettings['unapprovedMembers'] - 1 : 0)));
52
+		if (in_array($user_profile[$memID]['is_activated'], array(3, 4, 5, 13, 14, 15))) {
53
+					updateSettings(array('unapprovedMembers' => ($modSettings['unapprovedMembers'] > 1 ? $modSettings['unapprovedMembers'] - 1 : 0)));
54
+		}
53 55
 
54 56
 		// Make sure we update the stats too.
55 57
 		updateStats('member', false);
@@ -76,8 +78,9 @@  discard block
 block discarded – undo
76 78
 	$issueErrors = array();
77 79
 
78 80
 	// Doesn't hurt to be overly cautious.
79
-	if (empty($modSettings['warning_enable']) || ($context['user']['is_owner'] && !$cur_profile['warning']) || !allowedTo('issue_warning'))
80
-		fatal_lang_error('no_access', false);
81
+	if (empty($modSettings['warning_enable']) || ($context['user']['is_owner'] && !$cur_profile['warning']) || !allowedTo('issue_warning')) {
82
+			fatal_lang_error('no_access', false);
83
+	}
81 84
 
82 85
 	// Get the base (errors related) stuff done.
83 86
 	loadLanguage('Errors');
@@ -135,16 +138,18 @@  discard block
 block discarded – undo
135 138
 
136 139
 		// This cannot be empty!
137 140
 		$_POST['warn_reason'] = isset($_POST['warn_reason']) ? trim($_POST['warn_reason']) : '';
138
-		if ($_POST['warn_reason'] == '' && !$context['user']['is_owner'])
139
-			$issueErrors[] = 'warning_no_reason';
141
+		if ($_POST['warn_reason'] == '' && !$context['user']['is_owner']) {
142
+					$issueErrors[] = 'warning_no_reason';
143
+		}
140 144
 		$_POST['warn_reason'] = $smcFunc['htmlspecialchars']($_POST['warn_reason']);
141 145
 
142 146
 		$_POST['warning_level'] = (int) $_POST['warning_level'];
143 147
 		$_POST['warning_level'] = max(0, min(100, $_POST['warning_level']));
144
-		if ($_POST['warning_level'] < $context['min_allowed'])
145
-			$_POST['warning_level'] = $context['min_allowed'];
146
-		elseif ($_POST['warning_level'] > $context['max_allowed'])
147
-			$_POST['warning_level'] = $context['max_allowed'];
148
+		if ($_POST['warning_level'] < $context['min_allowed']) {
149
+					$_POST['warning_level'] = $context['min_allowed'];
150
+		} elseif ($_POST['warning_level'] > $context['max_allowed']) {
151
+					$_POST['warning_level'] = $context['max_allowed'];
152
+		}
148 153
 
149 154
 		// Do we actually have to issue them with a PM?
150 155
 		$id_notice = 0;
@@ -152,8 +157,9 @@  discard block
 block discarded – undo
152 157
 		{
153 158
 			$_POST['warn_sub'] = trim($_POST['warn_sub']);
154 159
 			$_POST['warn_body'] = trim($_POST['warn_body']);
155
-			if (empty($_POST['warn_sub']) || empty($_POST['warn_body']))
156
-				$issueErrors[] = 'warning_notify_blank';
160
+			if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) {
161
+							$issueErrors[] = 'warning_notify_blank';
162
+			}
157 163
 			// Send the PM?
158 164
 			else
159 165
 			{
@@ -190,8 +196,8 @@  discard block
 block discarded – undo
190 196
 		if (empty($issueErrors))
191 197
 		{
192 198
 			// Log what we've done!
193
-			if (!$context['user']['is_owner'])
194
-				$smcFunc['db_insert']('',
199
+			if (!$context['user']['is_owner']) {
200
+							$smcFunc['db_insert']('',
195 201
 					'{db_prefix}log_comments',
196 202
 					array(
197 203
 						'id_member' => 'int', 'member_name' => 'string', 'comment_type' => 'string', 'id_recipient' => 'int', 'recipient_name' => 'string-255',
@@ -203,14 +209,14 @@  discard block
 block discarded – undo
203 209
 					),
204 210
 					array('id_comment')
205 211
 				);
212
+			}
206 213
 
207 214
 			// Make the change.
208 215
 			updateMemberData($memID, array('warning' => $_POST['warning_level']));
209 216
 
210 217
 			// Leave a lovely message.
211 218
 			$context['profile_updated'] = $context['user']['is_owner'] ? $txt['profile_updated_own'] : $txt['profile_warning_success'];
212
-		}
213
-		else
219
+		} else
214 220
 		{
215 221
 			// Try to remember some bits.
216 222
 			$context['warning_data'] = array(
@@ -229,8 +235,9 @@  discard block
 block discarded – undo
229 235
 	{
230 236
 		$warning_body = !empty($_POST['warn_body']) ? trim(censorText($_POST['warn_body'])) : '';
231 237
 		$context['preview_subject'] = !empty($_POST['warn_sub']) ? trim($smcFunc['htmlspecialchars']($_POST['warn_sub'])) : '';
232
-		if (empty($_POST['warn_sub']) || empty($_POST['warn_body']))
233
-			$issueErrors[] = 'warning_notify_blank';
238
+		if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) {
239
+					$issueErrors[] = 'warning_notify_blank';
240
+		}
234 241
 
235 242
 		if (!empty($_POST['warn_body']))
236 243
 		{
@@ -254,8 +261,9 @@  discard block
 block discarded – undo
254 261
 	{
255 262
 		// Fill in the suite of errors.
256 263
 		$context['post_errors'] = array();
257
-		foreach ($issueErrors as $error)
258
-			$context['post_errors'][] = $txt[$error];
264
+		foreach ($issueErrors as $error) {
265
+					$context['post_errors'][] = $txt[$error];
266
+		}
259 267
 	}
260 268
 
261 269
 
@@ -272,9 +280,10 @@  discard block
 block discarded – undo
272 280
 		$modSettings['warning_mute'] => $txt['profile_warning_effect_mute'],
273 281
 	);
274 282
 	$context['current_level'] = 0;
275
-	foreach ($context['level_effects'] as $limit => $dummy)
276
-		if ($context['member']['warning'] >= $limit)
283
+	foreach ($context['level_effects'] as $limit => $dummy) {
284
+			if ($context['member']['warning'] >= $limit)
277 285
 			$context['current_level'] = $limit;
286
+	}
278 287
 
279 288
 	$listOptions = array(
280 289
 		'id' => 'view_warnings',
@@ -337,11 +346,12 @@  discard block
 block discarded – undo
337 346
 							' . $warning['reason'] . '
338 347
 						</div>';
339 348
 
340
-						if (!empty($warning['id_notice']))
341
-							$ret .= '
349
+						if (!empty($warning['id_notice'])) {
350
+													$ret .= '
342 351
 						<div class="floatright">
343 352
 							<a href="' . $scripturl . '?action=moderate;area=notice;nid=' . $warning['id_notice'] . '" onclick="window.open(this.href, \'\', \'scrollbars=yes,resizable=yes,width=400,height=250\');return false;" target="_blank" rel="noopener" title="' . $txt['profile_warning_previous_notice'] . '"><span class="generic_icons filter centericon"></span></a>
344 353
 						</div>';
354
+						}
345 355
 
346 356
 						return $ret;
347 357
 					},
@@ -412,8 +422,9 @@  discard block
 block discarded – undo
412 422
 	while ($row = $smcFunc['db_fetch_assoc']($request))
413 423
 	{
414 424
 		// If we're not warning for a message skip any that are.
415
-		if (!$context['warning_for_message'] && strpos($row['body'], '{MESSAGE}') !== false)
416
-			continue;
425
+		if (!$context['warning_for_message'] && strpos($row['body'], '{MESSAGE}') !== false) {
426
+					continue;
427
+		}
417 428
 
418 429
 		$context['notification_templates'][] = array(
419 430
 			'title' => $row['template_title'],
@@ -423,16 +434,18 @@  discard block
 block discarded – undo
423 434
 	$smcFunc['db_free_result']($request);
424 435
 
425 436
 	// Setup the "default" templates.
426
-	foreach (array('spamming', 'offence', 'insulting') as $type)
427
-		$context['notification_templates'][] = array(
437
+	foreach (array('spamming', 'offence', 'insulting') as $type) {
438
+			$context['notification_templates'][] = array(
428 439
 			'title' => $txt['profile_warning_notify_title_' . $type],
429 440
 			'body' => sprintf($txt['profile_warning_notify_template_outline' . (!empty($context['warning_for_message']) ? '_post' : '')], $txt['profile_warning_notify_for_' . $type]),
430 441
 		);
442
+	}
431 443
 
432 444
 	// Replace all the common variables in the templates.
433
-	foreach ($context['notification_templates'] as $k => $name)
434
-		$context['notification_templates'][$k]['body'] = strtr($name['body'], array('{MEMBER}' => un_htmlspecialchars($context['member']['name']), '{MESSAGE}' => '[url=' . $scripturl . '?msg=' . $context['warning_for_message'] . ']' . un_htmlspecialchars($context['warned_message_subject']) . '[/url]', '{SCRIPTURL}' => $scripturl, '{FORUMNAME}' => $mbname, '{REGARDS}' => $txt['regards_team']));
435
-}
445
+	foreach ($context['notification_templates'] as $k => $name) {
446
+			$context['notification_templates'][$k]['body'] = strtr($name['body'], array('{MEMBER}' => un_htmlspecialchars($context['member']['name']), '{MESSAGE}' => '[url=' . $scripturl . '?msg=' . $context['warning_for_message'] . ']' . un_htmlspecialchars($context['warned_message_subject']) . '[/url]', '{SCRIPTURL}' => $scripturl, '{FORUMNAME}' => $mbname, '{REGARDS}' => $txt['regards_team']));
447
+	}
448
+	}
436 449
 
437 450
 /**
438 451
  * Get the number of warnings a user has. Callback for $listOptions['get_count'] in issueWarning()
@@ -516,10 +529,11 @@  discard block
 block discarded – undo
516 529
 {
517 530
 	global $txt, $context, $modSettings, $cur_profile;
518 531
 
519
-	if (!$context['user']['is_owner'])
520
-		isAllowedTo('profile_remove_any');
521
-	elseif (!allowedTo('profile_remove_any'))
522
-		isAllowedTo('profile_remove_own');
532
+	if (!$context['user']['is_owner']) {
533
+			isAllowedTo('profile_remove_any');
534
+	} elseif (!allowedTo('profile_remove_any')) {
535
+			isAllowedTo('profile_remove_own');
536
+	}
523 537
 
524 538
 	// Permissions for removing stuff...
525 539
 	$context['can_delete_posts'] = !$context['user']['is_owner'] && allowedTo('moderate_forum');
@@ -546,10 +560,11 @@  discard block
 block discarded – undo
546 560
 
547 561
 	// @todo Add a way to delete pms as well?
548 562
 
549
-	if (!$context['user']['is_owner'])
550
-		isAllowedTo('profile_remove_any');
551
-	elseif (!allowedTo('profile_remove_any'))
552
-		isAllowedTo('profile_remove_own');
563
+	if (!$context['user']['is_owner']) {
564
+			isAllowedTo('profile_remove_any');
565
+	} elseif (!allowedTo('profile_remove_any')) {
566
+			isAllowedTo('profile_remove_own');
567
+	}
553 568
 
554 569
 	checkSession();
555 570
 
@@ -575,8 +590,9 @@  discard block
 block discarded – undo
575 590
 		list ($another) = $smcFunc['db_fetch_row']($request);
576 591
 		$smcFunc['db_free_result']($request);
577 592
 
578
-		if (empty($another))
579
-			fatal_lang_error('at_least_one_admin', 'critical');
593
+		if (empty($another)) {
594
+					fatal_lang_error('at_least_one_admin', 'critical');
595
+		}
580 596
 	}
581 597
 
582 598
 	// This file is needed for the deleteMembers function.
@@ -655,8 +671,9 @@  discard block
 block discarded – undo
655 671
 					)
656 672
 				);
657 673
 				$topicIDs = array();
658
-				while ($row = $smcFunc['db_fetch_assoc']($request))
659
-					$topicIDs[] = $row['id_topic'];
674
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
675
+									$topicIDs[] = $row['id_topic'];
676
+				}
660 677
 				$smcFunc['db_free_result']($request);
661 678
 
662 679
 				// Actually remove the topics. Ignore recycling if we want to perma-delete things...
@@ -679,8 +696,9 @@  discard block
 block discarded – undo
679 696
 			// This could take a while... but ya know it's gonna be worth it in the end.
680 697
 			while ($row = $smcFunc['db_fetch_assoc']($request))
681 698
 			{
682
-				if (function_exists('apache_reset_timeout'))
683
-					@apache_reset_timeout();
699
+				if (function_exists('apache_reset_timeout')) {
700
+									@apache_reset_timeout();
701
+				}
684 702
 
685 703
 				removeMessage($row['id_msg']);
686 704
 			}
@@ -688,8 +706,9 @@  discard block
 block discarded – undo
688 706
 		}
689 707
 
690 708
 		// Only delete this poor members account if they are actually being booted out of camp.
691
-		if (isset($_POST['deleteAccount']))
692
-			deleteMembers($memID);
709
+		if (isset($_POST['deleteAccount'])) {
710
+					deleteMembers($memID);
711
+		}
693 712
 	}
694 713
 	// Do they need approval to delete?
695 714
 	elseif (!empty($modSettings['approveAccountDeletion']) && !allowedTo('moderate_forum'))
@@ -740,18 +759,18 @@  discard block
 block discarded – undo
740 759
 		{
741 760
 			foreach ($costs as $duration => $cost)
742 761
 			{
743
-				if ($cost != 0)
744
-					$cost_array[$duration] = $cost;
762
+				if ($cost != 0) {
763
+									$cost_array[$duration] = $cost;
764
+				}
745 765
 			}
746
-		}
747
-		else
766
+		} else
748 767
 		{
749 768
 			$cost_array['fixed'] = $costs['fixed'];
750 769
 		}
751 770
 
752
-		if (empty($cost_array))
753
-			unset($context['subscriptions'][$id]);
754
-		else
771
+		if (empty($cost_array)) {
772
+					unset($context['subscriptions'][$id]);
773
+		} else
755 774
 		{
756 775
 			$context['subscriptions'][$id]['member'] = 0;
757 776
 			$context['subscriptions'][$id]['subscribed'] = false;
@@ -764,13 +783,15 @@  discard block
 block discarded – undo
764 783
 	foreach ($gateways as $id => $gateway)
765 784
 	{
766 785
 		$gateways[$id] = new $gateway['display_class']();
767
-		if (!$gateways[$id]->gatewayEnabled())
768
-			unset($gateways[$id]);
786
+		if (!$gateways[$id]->gatewayEnabled()) {
787
+					unset($gateways[$id]);
788
+		}
769 789
 	}
770 790
 
771 791
 	// No gateways yet?
772
-	if (empty($gateways))
773
-		fatal_error($txt['paid_admin_not_setup_gateway']);
792
+	if (empty($gateways)) {
793
+			fatal_error($txt['paid_admin_not_setup_gateway']);
794
+	}
774 795
 
775 796
 	// Get the current subscriptions.
776 797
 	$request = $smcFunc['db_query']('', '
@@ -785,8 +806,9 @@  discard block
 block discarded – undo
785 806
 	while ($row = $smcFunc['db_fetch_assoc']($request))
786 807
 	{
787 808
 		// The subscription must exist!
788
-		if (!isset($context['subscriptions'][$row['id_subscribe']]))
789
-			continue;
809
+		if (!isset($context['subscriptions'][$row['id_subscribe']])) {
810
+					continue;
811
+		}
790 812
 
791 813
 		$context['current'][$row['id_subscribe']] = array(
792 814
 			'id' => $row['id_sublog'],
@@ -800,8 +822,9 @@  discard block
 block discarded – undo
800 822
 			'status_text' => $row['status'] == 0 ? ($row['payments_pending'] ? $txt['paid_pending'] : $txt['paid_finished']) : $txt['paid_active'],
801 823
 		);
802 824
 
803
-		if ($row['status'] == 1)
804
-			$context['subscriptions'][$row['id_subscribe']]['subscribed'] = true;
825
+		if ($row['status'] == 1) {
826
+					$context['subscriptions'][$row['id_subscribe']]['subscribed'] = true;
827
+		}
805 828
 	}
806 829
 	$smcFunc['db_free_result']($request);
807 830
 
@@ -852,21 +875,25 @@  discard block
 block discarded – undo
852 875
 	if (isset($_GET['confirm']) && isset($_POST['sub_id']) && is_array($_POST['sub_id']))
853 876
 	{
854 877
 		// Hopefully just one.
855
-		foreach ($_POST['sub_id'] as $k => $v)
856
-			$ID_SUB = (int) $k;
878
+		foreach ($_POST['sub_id'] as $k => $v) {
879
+					$ID_SUB = (int) $k;
880
+		}
857 881
 
858
-		if (!isset($context['subscriptions'][$ID_SUB]) || $context['subscriptions'][$ID_SUB]['active'] == 0)
859
-			fatal_lang_error('paid_sub_not_active');
882
+		if (!isset($context['subscriptions'][$ID_SUB]) || $context['subscriptions'][$ID_SUB]['active'] == 0) {
883
+					fatal_lang_error('paid_sub_not_active');
884
+		}
860 885
 
861 886
 		// Simplify...
862 887
 		$context['sub'] = $context['subscriptions'][$ID_SUB];
863 888
 		$period = 'xx';
864
-		if ($context['sub']['flexible'])
865
-			$period = isset($_POST['cur'][$ID_SUB]) && isset($context['sub']['costs'][$_POST['cur'][$ID_SUB]]) ? $_POST['cur'][$ID_SUB] : 'xx';
889
+		if ($context['sub']['flexible']) {
890
+					$period = isset($_POST['cur'][$ID_SUB]) && isset($context['sub']['costs'][$_POST['cur'][$ID_SUB]]) ? $_POST['cur'][$ID_SUB] : 'xx';
891
+		}
866 892
 
867 893
 		// Check we have a valid cost.
868
-		if ($context['sub']['flexible'] && $period == 'xx')
869
-			fatal_lang_error('paid_sub_not_active');
894
+		if ($context['sub']['flexible'] && $period == 'xx') {
895
+					fatal_lang_error('paid_sub_not_active');
896
+		}
870 897
 
871 898
 		// Sort out the cost/currency.
872 899
 		$context['currency'] = $modSettings['paid_currency_code'];
@@ -879,8 +906,7 @@  discard block
 block discarded – undo
879 906
 			$context['cost'] = sprintf($modSettings['paid_currency_symbol'], $context['value']) . '/' . $txt[$_POST['cur'][$ID_SUB]];
880 907
 			// The period value for paypal.
881 908
 			$context['paypal_period'] = strtoupper(substr($_POST['cur'][$ID_SUB], 0, 1));
882
-		}
883
-		else
909
+		} else
884 910
 		{
885 911
 			// Real cost...
886 912
 			$context['value'] = $context['sub']['costs']['fixed'];
@@ -897,13 +923,15 @@  discard block
 block discarded – undo
897 923
 		foreach ($gateways as $id => $gateway)
898 924
 		{
899 925
 			$fields = $gateways[$id]->fetchGatewayFields($context['sub']['id'] . '+' . $memID, $context['sub'], $context['value'], $period, $scripturl . '?action=profile;u=' . $memID . ';area=subscriptions;sub_id=' . $context['sub']['id'] . ';done');
900
-			if (!empty($fields['form']))
901
-				$context['gateways'][] = $fields;
926
+			if (!empty($fields['form'])) {
927
+							$context['gateways'][] = $fields;
928
+			}
902 929
 		}
903 930
 
904 931
 		// Bugger?!
905
-		if (empty($context['gateways']))
906
-			fatal_error($txt['paid_admin_not_setup_gateway']);
932
+		if (empty($context['gateways'])) {
933
+					fatal_error($txt['paid_admin_not_setup_gateway']);
934
+		}
907 935
 
908 936
 		// Now we are going to assume they want to take this out ;)
909 937
 		$new_data = array($context['sub']['id'], $context['value'], $period, 'prepay');
@@ -911,16 +939,19 @@  discard block
 block discarded – undo
911 939
 		{
912 940
 			// What are the details like?
913 941
 			$current_pending = array();
914
-			if ($context['current'][$context['sub']['id']]['pending_details'] != '')
915
-				$current_pending = $smcFunc['json_decode']($context['current'][$context['sub']['id']]['pending_details'], true);
942
+			if ($context['current'][$context['sub']['id']]['pending_details'] != '') {
943
+							$current_pending = $smcFunc['json_decode']($context['current'][$context['sub']['id']]['pending_details'], true);
944
+			}
916 945
 			// Don't get silly.
917
-			if (count($current_pending) > 9)
918
-				$current_pending = array();
946
+			if (count($current_pending) > 9) {
947
+							$current_pending = array();
948
+			}
919 949
 			$pending_count = 0;
920 950
 			// Only record real pending payments as will otherwise confuse the admin!
921
-			foreach ($current_pending as $pending)
922
-				if ($pending[3] == 'payback')
951
+			foreach ($current_pending as $pending) {
952
+							if ($pending[3] == 'payback')
923 953
 					$pending_count++;
954
+			}
924 955
 
925 956
 			if (!in_array($new_data, $current_pending))
926 957
 			{
@@ -964,10 +995,10 @@  discard block
 block discarded – undo
964 995
 
965 996
 		// Quit.
966 997
 		return;
998
+	} else {
999
+			$context['sub_template'] = 'user_subscription';
1000
+	}
967 1001
 	}
968
-	else
969
-		$context['sub_template'] = 'user_subscription';
970
-}
971 1002
 
972 1003
 /**
973 1004
  * Function to allow the user to todo Privacy stuff
@@ -980,9 +1011,11 @@  discard block
 block discarded – undo
980 1011
 
981 1012
 	$profileData = array();
982 1013
 	$mode = 'pmessages';
983
-	if ($mode == 'profile') // profile
1014
+	if ($mode == 'profile') {
1015
+		// profile
984 1016
 	{
985 1017
 		loadMemberData($memID, false, 'profile');
1018
+	}
986 1019
 		$profile = $user_profile[$memID];
987 1020
 		$removeFields = array('secret_question','tfa_secret','password_salt');
988 1021
 		foreach ($removeFields as $value)
@@ -991,14 +1024,15 @@  discard block
 block discarded – undo
991 1024
 		}
992 1025
 		foreach($profile as $key => &$value)
993 1026
 		{
994
-			if (is_array($value))
995
-				$value = $smcFunc['json_encode']($value);
1027
+			if (is_array($value)) {
1028
+							$value = $smcFunc['json_encode']($value);
1029
+			}
996 1030
 		}
997 1031
 		$profileData[0] = array_keys($profile);
998 1032
 		$profileData[1] = $profile;
999 1033
 		call_integration_hook('integrate_getProfile_profile', array(&$profileData));
1000
-	}
1001
-	elseif ($mode == 'messages') // messages
1034
+	} elseif ($mode == 'messages') {
1035
+		// messages
1002 1036
 	{
1003 1037
 		
1004 1038
 		$request = $smcFunc['db_query']('','
@@ -1009,13 +1043,13 @@  discard block
 block discarded – undo
1009 1043
 				'memID' => $memID,
1010 1044
 			)
1011 1045
 		);
1046
+	}
1012 1047
 		$profileData = $smcFunc['db_fetch_all']($request);
1013 1048
 		array_unshift($profileData, array_keys($profileData[0]));
1014 1049
 		$smcFunc['db_free_result']($request);
1015 1050
 
1016 1051
 		call_integration_hook('integrate_getProfile_messages', array(&$profileData));
1017
-	}
1018
-	else
1052
+	} else
1019 1053
 	{
1020 1054
 		$request = $smcFunc['db_query']('','
1021 1055
 			SELECT pm.msgtime, pm.subject, pm.body
@@ -1076,8 +1110,7 @@  discard block
 block discarded – undo
1076 1110
 		if ( $encloseAll || preg_match( "/(?:${delimiter_esc}|${enclosure_esc}|\s)/", $field ) )
1077 1111
 		{
1078 1112
 			$output[] = $enclosure . str_replace($enclosure, $enclosure . $enclosure, $field) . $enclosure;
1079
-		}
1080
-		else
1113
+		} else
1081 1114
 		{
1082 1115
 			$output[] = $field;
1083 1116
 		}
Please login to merge, or discard this patch.