Completed
Pull Request — release-2.1 (#4846)
by Jeremy
09:05
created
Sources/Topic.php 1 patch
Braces   +41 added lines, -29 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Locks a topic... either by way of a moderator or the topic starter.
@@ -32,8 +33,9 @@  discard block
 block discarded – undo
32 33
 	global $topic, $user_info, $sourcedir, $board, $smcFunc;
33 34
 
34 35
 	// Just quit if there's no topic to lock.
35
-	if (empty($topic))
36
-		fatal_lang_error('not_a_topic', false);
36
+	if (empty($topic)) {
37
+			fatal_lang_error('not_a_topic', false);
38
+	}
37 39
 
38 40
 	checkSession('get');
39 41
 
@@ -55,29 +57,35 @@  discard block
 block discarded – undo
55 57
 
56 58
 	// Can you lock topics here, mister?
57 59
 	$user_lock = !allowedTo('lock_any');
58
-	if ($user_lock && $starter == $user_info['id'])
59
-		isAllowedTo('lock_own');
60
-	else
61
-		isAllowedTo('lock_any');
60
+	if ($user_lock && $starter == $user_info['id']) {
61
+			isAllowedTo('lock_own');
62
+	} else {
63
+			isAllowedTo('lock_any');
64
+	}
62 65
 
63 66
 	// Another moderator got the job done first?
64
-	if (isset($_GET['sa']) && $_GET['sa'] == 'unlock' && $locked == '0')
65
-		fatal_lang_error('error_topic_locked_already', false);
66
-	elseif (isset($_GET['sa']) && $_GET['sa'] == 'lock' && ($locked == '1' || $locked == '2'))
67
-		fatal_lang_error('error_topic_locked_already', false);
67
+	if (isset($_GET['sa']) && $_GET['sa'] == 'unlock' && $locked == '0') {
68
+			fatal_lang_error('error_topic_locked_already', false);
69
+	} elseif (isset($_GET['sa']) && $_GET['sa'] == 'lock' && ($locked == '1' || $locked == '2')) {
70
+			fatal_lang_error('error_topic_locked_already', false);
71
+	}
68 72
 
69 73
 	// Locking with high privileges.
70
-	if ($locked == '0' && !$user_lock)
71
-		$locked = '1';
74
+	if ($locked == '0' && !$user_lock) {
75
+			$locked = '1';
76
+	}
72 77
 	// Locking with low privileges.
73
-	elseif ($locked == '0')
74
-		$locked = '2';
78
+	elseif ($locked == '0') {
79
+			$locked = '2';
80
+	}
75 81
 	// Unlocking - make sure you don't unlock what you can't.
76
-	elseif ($locked == '2' || ($locked == '1' && !$user_lock))
77
-		$locked = '0';
82
+	elseif ($locked == '2' || ($locked == '1' && !$user_lock)) {
83
+			$locked = '0';
84
+	}
78 85
 	// You cannot unlock this!
79
-	else
80
-		fatal_lang_error('locked_by_admin', 'user');
86
+	else {
87
+			fatal_lang_error('locked_by_admin', 'user');
88
+	}
81 89
 
82 90
 	// Actually lock the topic in the database with the new value.
83 91
 	$smcFunc['db_query']('', '
@@ -91,8 +99,9 @@  discard block
 block discarded – undo
91 99
 	);
92 100
 
93 101
 	// If they are allowed a "moderator" permission, log it in the moderator log.
94
-	if (!$user_lock)
95
-		logAction($locked ? 'lock' : 'unlock', array('topic' => $topic, 'board' => $board));
102
+	if (!$user_lock) {
103
+			logAction($locked ? 'lock' : 'unlock', array('topic' => $topic, 'board' => $board));
104
+	}
96 105
 	// Notify people that this topic has been locked?
97 106
 	sendNotifications($topic, empty($locked) ? 'unlock' : 'lock');
98 107
 
@@ -118,8 +127,9 @@  discard block
 block discarded – undo
118 127
 	isAllowedTo('make_sticky');
119 128
 
120 129
 	// You can't sticky a board or something!
121
-	if (empty($topic))
122
-		fatal_lang_error('not_a_topic', false);
130
+	if (empty($topic)) {
131
+			fatal_lang_error('not_a_topic', false);
132
+	}
123 133
 
124 134
 	checkSession('get');
125 135
 
@@ -140,10 +150,11 @@  discard block
 block discarded – undo
140 150
 	$smcFunc['db_free_result']($request);
141 151
 
142 152
 	// Another moderator got the job done first?
143
-	if (isset($_GET['sa']) && $_GET['sa'] == 'nonsticky' && $is_sticky == '0')
144
-		fatal_lang_error('error_topic_nonsticky_already', false);
145
-	elseif (isset($_GET['sa']) && $_GET['sa'] == 'sticky' && $is_sticky == '1')
146
-		fatal_lang_error('error_topic_sticky_already', false);
153
+	if (isset($_GET['sa']) && $_GET['sa'] == 'nonsticky' && $is_sticky == '0') {
154
+			fatal_lang_error('error_topic_nonsticky_already', false);
155
+	} elseif (isset($_GET['sa']) && $_GET['sa'] == 'sticky' && $is_sticky == '1') {
156
+			fatal_lang_error('error_topic_sticky_already', false);
157
+	}
147 158
 
148 159
 	// Toggle the sticky value.... pretty simple ;).
149 160
 	$smcFunc['db_query']('', '
@@ -159,8 +170,9 @@  discard block
 block discarded – undo
159 170
 	// Log this sticky action - always a moderator thing.
160 171
 	logAction(empty($is_sticky) ? 'sticky' : 'unsticky', array('topic' => $topic, 'board' => $board));
161 172
 	// Notify people that this topic has been stickied?
162
-	if (empty($is_sticky))
163
-		sendNotifications($topic, 'sticky');
173
+	if (empty($is_sticky)) {
174
+			sendNotifications($topic, 'sticky');
175
+	}
164 176
 
165 177
 	// Take them back to the now stickied topic.
166 178
 	redirectexit('topic=' . $topic . '.' . $_REQUEST['start'] . ';moderate');
Please login to merge, or discard this patch.
Sources/Display.php 1 patch
Braces   +292 added lines, -214 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * The central part of the board - topic display.
@@ -34,8 +35,9 @@  discard block
 block discarded – undo
34 35
 	global $messages_request, $language, $smcFunc;
35 36
 
36 37
 	// What are you gonna display if these are empty?!
37
-	if (empty($topic))
38
-		fatal_lang_error('no_board', false);
38
+	if (empty($topic)) {
39
+			fatal_lang_error('no_board', false);
40
+	}
39 41
 
40 42
 	// Load the proper template.
41 43
 	loadTemplate('Display');
@@ -52,15 +54,17 @@  discard block
 block discarded – undo
52 54
 	$context['messages_per_page'] = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages'];
53 55
 
54 56
 	// Let's do some work on what to search index.
55
-	if (count($_GET) > 2)
56
-		foreach ($_GET as $k => $v)
57
+	if (count($_GET) > 2) {
58
+			foreach ($_GET as $k => $v)
57 59
 		{
58 60
 			if (!in_array($k, array('topic', 'board', 'start', session_name())))
59 61
 				$context['robot_no_index'] = true;
62
+	}
60 63
 		}
61 64
 
62
-	if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0))
63
-		$context['robot_no_index'] = true;
65
+	if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) {
66
+			$context['robot_no_index'] = true;
67
+	}
64 68
 
65 69
 	// Find the previous or next topic.  Make a fuss if there are no more.
66 70
 	if (isset($_REQUEST['prev_next']) && ($_REQUEST['prev_next'] == 'prev' || $_REQUEST['prev_next'] == 'next'))
@@ -172,8 +176,9 @@  discard block
 block discarded – undo
172 176
 			$topic_parameters
173 177
 	);
174 178
 
175
-	if ($smcFunc['db_num_rows']($request) == 0)
176
-		fatal_lang_error('not_a_topic', false, 404);
179
+	if ($smcFunc['db_num_rows']($request) == 0) {
180
+			fatal_lang_error('not_a_topic', false, 404);
181
+	}
177 182
 	$context['topicinfo'] = $smcFunc['db_fetch_assoc']($request);
178 183
 	$smcFunc['db_free_result']($request);
179 184
 
@@ -210,8 +215,9 @@  discard block
 block discarded – undo
210 215
 	$context['topic_unwatched'] = isset($context['topicinfo']['unwatched']) ? $context['topicinfo']['unwatched'] : 0;
211 216
 
212 217
 	// Add up unapproved replies to get real number of replies...
213
-	if ($modSettings['postmod_active'] && $approve_posts)
214
-		$context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1);
218
+	if ($modSettings['postmod_active'] && $approve_posts) {
219
+			$context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1);
220
+	}
215 221
 
216 222
 	// If this topic has unapproved posts, we need to work out how many posts the user can see, for page indexing.
217 223
 	if ($modSettings['postmod_active'] && $context['topicinfo']['unapproved_posts'] && !$user_info['is_guest'] && !$approve_posts)
@@ -231,11 +237,11 @@  discard block
 block discarded – undo
231 237
 		$smcFunc['db_free_result']($request);
232 238
 
233 239
 		$context['total_visible_posts'] = $context['num_replies'] + $myUnapprovedPosts + ($context['topicinfo']['approved'] ? 1 : 0);
240
+	} elseif ($user_info['is_guest']) {
241
+			$context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0);
242
+	} else {
243
+			$context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0);
234 244
 	}
235
-	elseif ($user_info['is_guest'])
236
-		$context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0);
237
-	else
238
-		$context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0);
239 245
 
240 246
 	// The start isn't a number; it's information about what to do, where to go.
241 247
 	if (!is_numeric($_REQUEST['start']))
@@ -248,8 +254,7 @@  discard block
 block discarded – undo
248 254
 			{
249 255
 				$context['start_from'] = $context['total_visible_posts'] - 1;
250 256
 				$_REQUEST['start'] = empty($options['view_newest_first']) ? $context['start_from'] : 0;
251
-			}
252
-			else
257
+			} else
253 258
 			{
254 259
 				// Find the earliest unread message in the topic. (the use of topics here is just for both tables.)
255 260
 				$request = $smcFunc['db_query']('', '
@@ -277,9 +282,9 @@  discard block
 block discarded – undo
277 282
 		if (substr($_REQUEST['start'], 0, 4) == 'from')
278 283
 		{
279 284
 			$timestamp = (int) substr($_REQUEST['start'], 4);
280
-			if ($timestamp === 0)
281
-				$_REQUEST['start'] = 0;
282
-			else
285
+			if ($timestamp === 0) {
286
+							$_REQUEST['start'] = 0;
287
+			} else
283 288
 			{
284 289
 				// Find the number of messages posted before said time...
285 290
 				$request = $smcFunc['db_query']('', '
@@ -307,11 +312,11 @@  discard block
 block discarded – undo
307 312
 		elseif (substr($_REQUEST['start'], 0, 3) == 'msg')
308 313
 		{
309 314
 			$virtual_msg = (int) substr($_REQUEST['start'], 3);
310
-			if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg'])
311
-				$context['start_from'] = $context['total_visible_posts'] - 1;
312
-			elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg'])
313
-				$context['start_from'] = 0;
314
-			else
315
+			if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg']) {
316
+							$context['start_from'] = $context['total_visible_posts'] - 1;
317
+			} elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg']) {
318
+							$context['start_from'] = 0;
319
+			} else
315 320
 			{
316 321
 				// Find the start value for that message......
317 322
 				$request = $smcFunc['db_query']('', '
@@ -394,21 +399,25 @@  discard block
 block discarded – undo
394 399
 		);
395 400
 		while ($row = $smcFunc['db_fetch_assoc']($request))
396 401
 		{
397
-			if (empty($row['id_member']))
398
-				continue;
402
+			if (empty($row['id_member'])) {
403
+							continue;
404
+			}
399 405
 
400
-			if (!empty($row['online_color']))
401
-				$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>';
402
-			else
403
-				$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>';
406
+			if (!empty($row['online_color'])) {
407
+							$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>';
408
+			} else {
409
+							$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>';
410
+			}
404 411
 
405 412
 			$is_buddy = in_array($row['id_member'], $user_info['buddies']);
406
-			if ($is_buddy)
407
-				$link = '<strong>' . $link . '</strong>';
413
+			if ($is_buddy) {
414
+							$link = '<strong>' . $link . '</strong>';
415
+			}
408 416
 
409 417
 			// Add them both to the list and to the more detailed list.
410
-			if (!empty($row['show_online']) || allowedTo('moderate_forum'))
411
-				$context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link;
418
+			if (!empty($row['show_online']) || allowedTo('moderate_forum')) {
419
+							$context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link;
420
+			}
412 421
 			$context['view_members'][$row['log_time'] . $row['member_name']] = array(
413 422
 				'id' => $row['id_member'],
414 423
 				'username' => $row['member_name'],
@@ -420,8 +429,9 @@  discard block
 block discarded – undo
420 429
 				'hidden' => empty($row['show_online']),
421 430
 			);
422 431
 
423
-			if (empty($row['show_online']))
424
-				$context['view_num_hidden']++;
432
+			if (empty($row['show_online'])) {
433
+							$context['view_num_hidden']++;
434
+			}
425 435
 		}
426 436
 
427 437
 		// The number of guests is equal to the rows minus the ones we actually used ;).
@@ -435,11 +445,13 @@  discard block
 block discarded – undo
435 445
 
436 446
 	// If all is set, but not allowed... just unset it.
437 447
 	$can_show_all = !empty($modSettings['enableAllMessages']) && $context['total_visible_posts'] > $context['messages_per_page'] && $context['total_visible_posts'] < $modSettings['enableAllMessages'];
438
-	if (isset($_REQUEST['all']) && !$can_show_all)
439
-		unset($_REQUEST['all']);
448
+	if (isset($_REQUEST['all']) && !$can_show_all) {
449
+			unset($_REQUEST['all']);
450
+	}
440 451
 	// Otherwise, it must be allowed... so pretend start was -1.
441
-	elseif (isset($_REQUEST['all']))
442
-		$_REQUEST['start'] = -1;
452
+	elseif (isset($_REQUEST['all'])) {
453
+			$_REQUEST['start'] = -1;
454
+	}
443 455
 
444 456
 	// Construct the page index, allowing for the .START method...
445 457
 	$context['page_index'] = constructPageIndex($scripturl . '?topic=' . $topic . '.%1$d', $_REQUEST['start'], $context['total_visible_posts'], $context['messages_per_page'], true);
@@ -476,8 +488,9 @@  discard block
 block discarded – undo
476 488
 			$_REQUEST['start'] = 0;
477 489
 		}
478 490
 		// They aren't using it, but the *option* is there, at least.
479
-		else
480
-			$context['page_index'] .= '&nbsp;<a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> ';
491
+		else {
492
+					$context['page_index'] .= '&nbsp;<a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> ';
493
+		}
481 494
 	}
482 495
 
483 496
 	// Build the link tree.
@@ -493,14 +506,16 @@  discard block
 block discarded – undo
493 506
 	if (!empty($board_info['moderators']))
494 507
 	{
495 508
 		// Add a link for each moderator...
496
-		foreach ($board_info['moderators'] as $mod)
497
-			$context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>';
509
+		foreach ($board_info['moderators'] as $mod) {
510
+					$context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>';
511
+		}
498 512
 	}
499 513
 	if (!empty($board_info['moderator_groups']))
500 514
 	{
501 515
 		// Add a link for each moderator group as well...
502
-		foreach ($board_info['moderator_groups'] as $mod_group)
503
-			$context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>';
516
+		foreach ($board_info['moderator_groups'] as $mod_group) {
517
+					$context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>';
518
+		}
504 519
 	}
505 520
 
506 521
 	if (!empty($context['link_moderators']))
@@ -531,9 +546,9 @@  discard block
 block discarded – undo
531 546
 	// For quick reply we need a response prefix in the default forum language.
532 547
 	if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix', 600)))
533 548
 	{
534
-		if ($language === $user_info['language'])
535
-			$context['response_prefix'] = $txt['response_prefix'];
536
-		else
549
+		if ($language === $user_info['language']) {
550
+					$context['response_prefix'] = $txt['response_prefix'];
551
+		} else
537 552
 		{
538 553
 			loadLanguage('index', $language, false);
539 554
 			$context['response_prefix'] = $txt['response_prefix'];
@@ -565,8 +580,9 @@  discard block
 block discarded – undo
565 580
 			list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row);
566 581
 
567 582
 			// Sanity check
568
-			if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count']))
569
-				continue;
583
+			if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) {
584
+							continue;
585
+			}
570 586
 
571 587
 			$linked_calendar_event = array(
572 588
 				'id' => $row['id_event'],
@@ -615,8 +631,9 @@  discard block
 block discarded – undo
615 631
 		}
616 632
 		$smcFunc['db_free_result']($request);
617 633
 
618
-		if (!empty($context['linked_calendar_events']))
619
-			$context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true;
634
+		if (!empty($context['linked_calendar_events'])) {
635
+					$context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true;
636
+		}
620 637
 	}
621 638
 
622 639
 	// Create the poll info if it exists.
@@ -679,8 +696,9 @@  discard block
 block discarded – undo
679 696
 		$smcFunc['db_free_result']($request);
680 697
 
681 698
 		// Got we multi choice?
682
-		if ($pollinfo['max_votes'] > 1)
683
-			$realtotal = $pollinfo['total'];
699
+		if ($pollinfo['max_votes'] > 1) {
700
+					$realtotal = $pollinfo['total'];
701
+		}
684 702
 
685 703
 		// If this is a guest we need to do our best to work out if they have voted, and what they voted for.
686 704
 		if ($user_info['is_guest'] && $pollinfo['guest_vote'] && allowedTo('poll_vote'))
@@ -693,20 +711,21 @@  discard block
 block discarded – undo
693 711
 				foreach ($guestinfo as $i => $guestvoted)
694 712
 				{
695 713
 					$guestvoted = explode(',', $guestvoted);
696
-					if ($guestvoted[0] == $context['topicinfo']['id_poll'])
697
-						break;
714
+					if ($guestvoted[0] == $context['topicinfo']['id_poll']) {
715
+											break;
716
+					}
698 717
 				}
699 718
 				// Has the poll been reset since guest voted?
700 719
 				if ($pollinfo['reset_poll'] > $guestvoted[1])
701 720
 				{
702 721
 					// Remove the poll info from the cookie to allow guest to vote again
703 722
 					unset($guestinfo[$i]);
704
-					if (!empty($guestinfo))
705
-						$_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo);
706
-					else
707
-						unset($_COOKIE['guest_poll_vote']);
708
-				}
709
-				else
723
+					if (!empty($guestinfo)) {
724
+											$_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo);
725
+					} else {
726
+											unset($_COOKIE['guest_poll_vote']);
727
+					}
728
+				} else
710 729
 				{
711 730
 					// What did they vote for?
712 731
 					unset($guestvoted[0], $guestvoted[1]);
@@ -820,23 +839,29 @@  discard block
 block discarded – undo
820 839
 		// Build the poll moderation button array.
821 840
 		$context['poll_buttons'] = array();
822 841
 
823
-		if ($context['allow_return_vote'])
824
-			$context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']);
842
+		if ($context['allow_return_vote']) {
843
+					$context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']);
844
+		}
825 845
 
826
-		if ($context['show_view_results_button'])
827
-			$context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults');
846
+		if ($context['show_view_results_button']) {
847
+					$context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults');
848
+		}
828 849
 
829
-		if ($context['allow_change_vote'])
830
-			$context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']);
850
+		if ($context['allow_change_vote']) {
851
+					$context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']);
852
+		}
831 853
 
832
-		if ($context['allow_lock_poll'])
833
-			$context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
854
+		if ($context['allow_lock_poll']) {
855
+					$context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
856
+		}
834 857
 
835
-		if ($context['allow_edit_poll'])
836
-			$context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']);
858
+		if ($context['allow_edit_poll']) {
859
+					$context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']);
860
+		}
837 861
 
838
-		if ($context['can_remove_poll'])
839
-			$context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
862
+		if ($context['can_remove_poll']) {
863
+					$context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
864
+		}
840 865
 
841 866
 		// Allow mods to add additional buttons here
842 867
 		call_integration_hook('integrate_poll_buttons');
@@ -872,9 +897,9 @@  discard block
 block discarded – undo
872 897
 	{
873 898
 		$start_char = 'C';
874 899
 		$page_id = $ascending ? $context['topicinfo']['id_first_msg'] : $context['topicinfo']['id_last_msg'];
900
+	} else {
901
+			$start_char = null;
875 902
 	}
876
-	else
877
-		$start_char = null;
878 903
 
879 904
 	$limit = $context['messages_per_page'];
880 905
 
@@ -888,17 +913,17 @@  discard block
 block discarded – undo
888 913
 		{
889 914
 			$ascending_seek = true;
890 915
 			$page_operator = $ascending ? '>=' : '<=';
891
-		}
892
-		else
916
+		} else
893 917
 		{
894 918
 			$ascending_seek = false;
895 919
 			$page_operator = $ascending ? '<=' : '>=';
896 920
 		}
897 921
 
898
-		if ($start_char === 'C')
899
-			$limit_seek = $limit;
900
-		else
901
-			$limit_seek  = $limit + 1;
922
+		if ($start_char === 'C') {
923
+					$limit_seek = $limit;
924
+		} else {
925
+					$limit_seek  = $limit + 1;
926
+		}
902 927
 
903 928
 		$request = $smcFunc['db_query']('', '
904 929
 			SELECT id_msg, id_member, approved
@@ -921,21 +946,23 @@  discard block
 block discarded – undo
921 946
 		$found_msg = false;
922 947
 
923 948
 		// Fallback
924
-		if ($smcFunc['db_num_rows']($request) < 1)
925
-			unset($start_char);
926
-		else
949
+		if ($smcFunc['db_num_rows']($request) < 1) {
950
+					unset($start_char);
951
+		} else
927 952
 		{
928 953
 			while ($row = $smcFunc['db_fetch_assoc']($request))
929 954
 			{
930 955
 				// Check if the start msg is in our result
931
-				if ($row['id_msg'] == $page_id)
932
-					$found_msg = true;
956
+				if ($row['id_msg'] == $page_id) {
957
+									$found_msg = true;
958
+				}
933 959
 
934 960
 				// Skip the the start msg if we not in mode C
935 961
 				if ($start_char === 'C' || $row['id_msg'] != $page_id)
936 962
 				{
937
-					if (!empty($row['id_member']))
938
-						$all_posters[$row['id_msg']] = $row['id_member'];
963
+					if (!empty($row['id_member'])) {
964
+											$all_posters[$row['id_msg']] = $row['id_member'];
965
+					}
939 966
 
940 967
 					$messages[] = $row['id_msg'];
941 968
 				}
@@ -951,8 +978,9 @@  discard block
 block discarded – undo
951 978
 		}
952 979
 
953 980
 		// Before Page bring in the right order
954
-		if (!empty($start_char) && $start_char === 'L')
955
-			krsort($messages);
981
+		if (!empty($start_char) && $start_char === 'L') {
982
+					krsort($messages);
983
+		}
956 984
 	}
957 985
 
958 986
 	// Jump to page
@@ -987,14 +1015,16 @@  discard block
 block discarded – undo
987 1015
 
988 1016
 		while ($row = $smcFunc['db_fetch_assoc']($request))
989 1017
 		{
990
-			if (!empty($row['id_member']))
991
-				$all_posters[$row['id_msg']] = $row['id_member'];
1018
+			if (!empty($row['id_member'])) {
1019
+							$all_posters[$row['id_msg']] = $row['id_member'];
1020
+			}
992 1021
 			$messages[] = $row['id_msg'];
993 1022
 		}
994 1023
 
995 1024
 		// Sort the messages into the correct display order
996
-		if (!$ascending)
997
-			sort($messages);
1025
+		if (!$ascending) {
1026
+					sort($messages);
1027
+		}
998 1028
 	}
999 1029
 
1000 1030
 	// Remember the paging data for next time
@@ -1014,8 +1044,9 @@  discard block
 block discarded – undo
1014 1044
 	if (!$user_info['is_guest'] && !empty($messages))
1015 1045
 	{
1016 1046
 		$mark_at_msg = max($messages);
1017
-		if ($mark_at_msg >= $context['topicinfo']['id_last_msg'])
1018
-			$mark_at_msg = $modSettings['maxMsgID'];
1047
+		if ($mark_at_msg >= $context['topicinfo']['id_last_msg']) {
1048
+					$mark_at_msg = $modSettings['maxMsgID'];
1049
+		}
1019 1050
 		if ($mark_at_msg >= $context['topicinfo']['new_from'])
1020 1051
 		{
1021 1052
 			$smcFunc['db_insert']($context['topicinfo']['new_from'] == 0 ? 'ignore' : 'replace',
@@ -1047,8 +1078,9 @@  discard block
 block discarded – undo
1047 1078
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1048 1079
 		{
1049 1080
 			// Find if this topic is marked for notification...
1050
-			if (!empty($row['id_topic']))
1051
-				$context['is_marked_notify'] = true;
1081
+			if (!empty($row['id_topic'])) {
1082
+							$context['is_marked_notify'] = true;
1083
+			}
1052 1084
 
1053 1085
 			// Only do this once, but mark the notifications as "not sent yet" for next time.
1054 1086
 			if (!empty($row['sent']) && $do_once)
@@ -1070,8 +1102,9 @@  discard block
 block discarded – undo
1070 1102
 		}
1071 1103
 
1072 1104
 		// Have we recently cached the number of new topics in this board, and it's still a lot?
1073
-		if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5)
1074
-			$_SESSION['topicseen_cache'][$board]--;
1105
+		if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5) {
1106
+					$_SESSION['topicseen_cache'][$board]--;
1107
+		}
1075 1108
 		// Mark board as seen if this is the only new topic.
1076 1109
 		elseif (isset($_REQUEST['topicseen']))
1077 1110
 		{
@@ -1095,14 +1128,16 @@  discard block
 block discarded – undo
1095 1128
 			$smcFunc['db_free_result']($request);
1096 1129
 
1097 1130
 			// If there're no real new topics in this board, mark the board as seen.
1098
-			if (empty($numNewTopics))
1099
-				$_REQUEST['boardseen'] = true;
1100
-			else
1101
-				$_SESSION['topicseen_cache'][$board] = $numNewTopics;
1131
+			if (empty($numNewTopics)) {
1132
+							$_REQUEST['boardseen'] = true;
1133
+			} else {
1134
+							$_SESSION['topicseen_cache'][$board] = $numNewTopics;
1135
+			}
1102 1136
 		}
1103 1137
 		// Probably one less topic - maybe not, but even if we decrease this too fast it will only make us look more often.
1104
-		elseif (isset($_SESSION['topicseen_cache'][$board]))
1105
-			$_SESSION['topicseen_cache'][$board]--;
1138
+		elseif (isset($_SESSION['topicseen_cache'][$board])) {
1139
+					$_SESSION['topicseen_cache'][$board]--;
1140
+		}
1106 1141
 
1107 1142
 		// Mark board as seen if we came using last post link from BoardIndex. (or other places...)
1108 1143
 		if (isset($_REQUEST['boardseen']))
@@ -1159,23 +1194,26 @@  discard block
 block discarded – undo
1159 1194
 			$temp = array();
1160 1195
 			while ($row = $smcFunc['db_fetch_assoc']($request))
1161 1196
 			{
1162
-				if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id']))
1163
-					continue;
1197
+				if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id'])) {
1198
+									continue;
1199
+				}
1164 1200
 
1165 1201
 				$temp[$row['id_attach']] = $row;
1166 1202
 				$temp[$row['id_attach']]['topic'] = $topic;
1167 1203
 				$temp[$row['id_attach']]['board'] = $board;
1168 1204
 
1169
-				if (!isset($context['loaded_attachments'][$row['id_msg']]))
1170
-					$context['loaded_attachments'][$row['id_msg']] = array();
1205
+				if (!isset($context['loaded_attachments'][$row['id_msg']])) {
1206
+									$context['loaded_attachments'][$row['id_msg']] = array();
1207
+				}
1171 1208
 			}
1172 1209
 			$smcFunc['db_free_result']($request);
1173 1210
 
1174 1211
 			// This is better than sorting it with the query...
1175 1212
 			ksort($temp);
1176 1213
 
1177
-			foreach ($temp as $row)
1178
-				$context['loaded_attachments'][$row['id_msg']][] = $row;
1214
+			foreach ($temp as $row) {
1215
+							$context['loaded_attachments'][$row['id_msg']][] = $row;
1216
+			}
1179 1217
 		}
1180 1218
 
1181 1219
 		$msg_parameters = array(
@@ -1202,21 +1240,23 @@  discard block
 block discarded – undo
1202 1240
 		);
1203 1241
 
1204 1242
 		// And the likes
1205
-		if (!empty($modSettings['enable_likes']))
1206
-			$context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic);
1243
+		if (!empty($modSettings['enable_likes'])) {
1244
+					$context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic);
1245
+		}
1207 1246
 
1208 1247
 		// Go to the last message if the given time is beyond the time of the last message.
1209
-		if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies'])
1210
-			$context['start_from'] = $context['topicinfo']['num_replies'];
1248
+		if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies']) {
1249
+					$context['start_from'] = $context['topicinfo']['num_replies'];
1250
+		}
1211 1251
 
1212 1252
 		// Since the anchor information is needed on the top of the page we load these variables beforehand.
1213 1253
 		$context['first_message'] = isset($messages[$firstIndex]) ? $messages[$firstIndex] : $messages[0];
1214
-		if (empty($options['view_newest_first']))
1215
-			$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from'];
1216
-		else
1217
-			$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from'];
1218
-	}
1219
-	else
1254
+		if (empty($options['view_newest_first'])) {
1255
+					$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from'];
1256
+		} else {
1257
+					$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from'];
1258
+		}
1259
+	} else
1220 1260
 	{
1221 1261
 		$messages_request = false;
1222 1262
 		$context['first_message'] = 0;
@@ -1251,8 +1291,9 @@  discard block
 block discarded – undo
1251 1291
 		'can_restore_msg' => 'move_any',
1252 1292
 		'can_like' => 'likes_like',
1253 1293
 	);
1254
-	foreach ($common_permissions as $contextual => $perm)
1255
-		$context[$contextual] = allowedTo($perm);
1294
+	foreach ($common_permissions as $contextual => $perm) {
1295
+			$context[$contextual] = allowedTo($perm);
1296
+	}
1256 1297
 
1257 1298
 	// Permissions with _any/_own versions.  $context[YYY] => ZZZ_any/_own.
1258 1299
 	$anyown_permissions = array(
@@ -1265,8 +1306,9 @@  discard block
 block discarded – undo
1265 1306
 		'can_reply_unapproved' => 'post_unapproved_replies',
1266 1307
 		'can_view_warning' => 'profile_warning',
1267 1308
 	);
1268
-	foreach ($anyown_permissions as $contextual => $perm)
1269
-		$context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own'));
1309
+	foreach ($anyown_permissions as $contextual => $perm) {
1310
+			$context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own'));
1311
+	}
1270 1312
 
1271 1313
 	if (!$user_info['is_admin'] && $context['can_move'] && !$modSettings['topic_move_any'])
1272 1314
 	{
@@ -1312,8 +1354,9 @@  discard block
 block discarded – undo
1312 1354
 	// Check if the draft functions are enabled and that they have permission to use them (for quick reply.)
1313 1355
 	$context['drafts_save'] = !empty($modSettings['drafts_post_enabled']) && allowedTo('post_draft') && $context['can_reply'];
1314 1356
 	$context['drafts_autosave'] = !empty($context['drafts_save']) && !empty($modSettings['drafts_autosave_enabled']);
1315
-	if (!empty($context['drafts_save']))
1316
-		loadLanguage('Drafts');
1357
+	if (!empty($context['drafts_save'])) {
1358
+			loadLanguage('Drafts');
1359
+	}
1317 1360
 
1318 1361
 	// When was the last time this topic was replied to?  Should we warn them about it?
1319 1362
 	if (!empty($modSettings['oldTopicDays']) && ($context['can_reply'] || $context['can_reply_unapproved']) && empty($context['topicinfo']['is_sticky']))
@@ -1374,26 +1417,31 @@  discard block
 block discarded – undo
1374 1417
 	// Message icons - customized icons are off?
1375 1418
 	$context['icons'] = getMessageIcons($board);
1376 1419
 
1377
-	if (!empty($context['icons']))
1378
-		$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1420
+	if (!empty($context['icons'])) {
1421
+			$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1422
+	}
1379 1423
 
1380 1424
 	// Build the normal button array.
1381 1425
 	$context['normal_buttons'] = array();
1382 1426
 
1383
-	if ($context['can_reply'])
1384
-		$context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true);
1427
+	if ($context['can_reply']) {
1428
+			$context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true);
1429
+	}
1385 1430
 
1386
-	if ($context['can_add_poll'])
1387
-		$context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']);
1431
+	if ($context['can_add_poll']) {
1432
+			$context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']);
1433
+	}
1388 1434
 
1389
-	if ($context['can_mark_unread'])
1390
-		$context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1435
+	if ($context['can_mark_unread']) {
1436
+			$context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1437
+	}
1391 1438
 
1392
-	if ($context['can_print'])
1393
-		$context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0');
1439
+	if ($context['can_print']) {
1440
+			$context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0');
1441
+	}
1394 1442
 
1395
-	if ($context['can_set_notify'])
1396
-		$context['normal_buttons']['notify'] = array(
1443
+	if ($context['can_set_notify']) {
1444
+			$context['normal_buttons']['notify'] = array(
1397 1445
 			'text' => 'notify_topic_' . $context['topic_notification_mode'],
1398 1446
 			'sub_buttons' => array(
1399 1447
 				array(
@@ -1415,38 +1463,47 @@  discard block
 block discarded – undo
1415 1463
 				),
1416 1464
 			),
1417 1465
 		);
1466
+	}
1418 1467
 
1419 1468
 	// Build the mod button array
1420 1469
 	$context['mod_buttons'] = array();
1421 1470
 
1422
-	if ($context['can_move'])
1423
-		$context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0');
1471
+	if ($context['can_move']) {
1472
+			$context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0');
1473
+	}
1424 1474
 
1425
-	if ($context['can_delete'])
1426
-		$context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']);
1475
+	if ($context['can_delete']) {
1476
+			$context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']);
1477
+	}
1427 1478
 
1428
-	if ($context['can_lock'])
1429
-		$context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';sa=' . ($context['is_locked'] ? 'unlock' : 'lock') . ';' . $context['session_var'] . '=' . $context['session_id']);
1479
+	if ($context['can_lock']) {
1480
+			$context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';sa=' . ($context['is_locked'] ? 'unlock' : 'lock') . ';' . $context['session_var'] . '=' . $context['session_id']);
1481
+	}
1430 1482
 
1431
-	if ($context['can_sticky'])
1432
-		$context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';sa=' . ($context['is_sticky'] ? 'nonsticky' : 'sticky') . ';' . $context['session_var'] . '=' . $context['session_id']);
1483
+	if ($context['can_sticky']) {
1484
+			$context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';sa=' . ($context['is_sticky'] ? 'nonsticky' : 'sticky') . ';' . $context['session_var'] . '=' . $context['session_id']);
1485
+	}
1433 1486
 
1434
-	if ($context['can_merge'])
1435
-		$context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']);
1487
+	if ($context['can_merge']) {
1488
+			$context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']);
1489
+	}
1436 1490
 
1437
-	if ($context['calendar_post'])
1438
-		$context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0');
1491
+	if ($context['calendar_post']) {
1492
+			$context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0');
1493
+	}
1439 1494
 
1440 1495
 	// Restore topic. eh?  No monkey business.
1441
-	if ($context['can_restore_topic'])
1442
-		$context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1496
+	if ($context['can_restore_topic']) {
1497
+			$context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1498
+	}
1443 1499
 
1444 1500
 	// Show a message in case a recently posted message became unapproved.
1445 1501
 	$context['becomesUnapproved'] = !empty($_SESSION['becomesUnapproved']) ? true : false;
1446 1502
 
1447 1503
 	// Don't want to show this forever...
1448
-	if ($context['becomesUnapproved'])
1449
-		unset($_SESSION['becomesUnapproved']);
1504
+	if ($context['becomesUnapproved']) {
1505
+			unset($_SESSION['becomesUnapproved']);
1506
+	}
1450 1507
 
1451 1508
 	// Allow adding new mod buttons easily.
1452 1509
 	// Note: $context['normal_buttons'] and $context['mod_buttons'] are added for backward compatibility with 2.0, but are deprecated and should not be used
@@ -1455,12 +1512,14 @@  discard block
 block discarded – undo
1455 1512
 	call_integration_hook('integrate_mod_buttons', array(&$context['mod_buttons']));
1456 1513
 
1457 1514
 	// Load the drafts js file
1458
-	if ($context['drafts_autosave'])
1459
-		loadJavaScriptFile('drafts.js', array('defer' => false, 'minimize' => true), 'smf_drafts');
1515
+	if ($context['drafts_autosave']) {
1516
+			loadJavaScriptFile('drafts.js', array('defer' => false, 'minimize' => true), 'smf_drafts');
1517
+	}
1460 1518
 
1461 1519
 	// Spellcheck
1462
-	if ($context['show_spellchecking'])
1463
-		loadJavaScriptFile('spellcheck.js', array('defer' => false, 'minimize' => true), 'smf_spellcheck');
1520
+	if ($context['show_spellchecking']) {
1521
+			loadJavaScriptFile('spellcheck.js', array('defer' => false, 'minimize' => true), 'smf_spellcheck');
1522
+	}
1464 1523
 
1465 1524
 	// topic.js
1466 1525
 	loadJavaScriptFile('topic.js', array('defer' => false, 'minimize' => true), 'smf_topic');
@@ -1494,16 +1553,19 @@  discard block
 block discarded – undo
1494 1553
 	static $counter = null;
1495 1554
 
1496 1555
 	// If the query returned false, bail.
1497
-	if ($messages_request == false)
1498
-		return false;
1556
+	if ($messages_request == false) {
1557
+			return false;
1558
+	}
1499 1559
 
1500 1560
 	// Remember which message this is.  (ie. reply #83)
1501
-	if ($counter === null || $reset)
1502
-		$counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start'];
1561
+	if ($counter === null || $reset) {
1562
+			$counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start'];
1563
+	}
1503 1564
 
1504 1565
 	// Start from the beginning...
1505
-	if ($reset)
1506
-		return @$smcFunc['db_data_seek']($messages_request, 0);
1566
+	if ($reset) {
1567
+			return @$smcFunc['db_data_seek']($messages_request, 0);
1568
+	}
1507 1569
 
1508 1570
 	// Attempt to get the next message.
1509 1571
 	$message = $smcFunc['db_fetch_assoc']($messages_request);
@@ -1517,19 +1579,21 @@  discard block
 block discarded – undo
1517 1579
 	if (empty($context['icon_sources']))
1518 1580
 	{
1519 1581
 		$context['icon_sources'] = array();
1520
-		foreach ($context['stable_icons'] as $icon)
1521
-			$context['icon_sources'][$icon] = 'images_url';
1582
+		foreach ($context['stable_icons'] as $icon) {
1583
+					$context['icon_sources'][$icon] = 'images_url';
1584
+		}
1522 1585
 	}
1523 1586
 
1524 1587
 	// Message Icon Management... check the images exist.
1525 1588
 	if (empty($modSettings['messageIconChecks_disable']))
1526 1589
 	{
1527 1590
 		// If the current icon isn't known, then we need to do something...
1528
-		if (!isset($context['icon_sources'][$message['icon']]))
1529
-			$context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url';
1591
+		if (!isset($context['icon_sources'][$message['icon']])) {
1592
+					$context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url';
1593
+		}
1594
+	} elseif (!isset($context['icon_sources'][$message['icon']])) {
1595
+			$context['icon_sources'][$message['icon']] = 'images_url';
1530 1596
 	}
1531
-	elseif (!isset($context['icon_sources'][$message['icon']]))
1532
-		$context['icon_sources'][$message['icon']] = 'images_url';
1533 1597
 
1534 1598
 	// If you're a lazy bum, you probably didn't give a subject...
1535 1599
 	$message['subject'] = $message['subject'] != '' ? $message['subject'] : $txt['no_subject'];
@@ -1554,8 +1618,7 @@  discard block
 block discarded – undo
1554 1618
 		$memberContext[$message['id_member']]['email'] = $message['poster_email'];
1555 1619
 		$memberContext[$message['id_member']]['show_email'] = allowedTo('moderate_forum');
1556 1620
 		$memberContext[$message['id_member']]['is_guest'] = true;
1557
-	}
1558
-	else
1621
+	} else
1559 1622
 	{
1560 1623
 		// Define this here to make things a bit more readable
1561 1624
 		$can_view_warning = $context['user']['can_mod'] || allowedTo('view_warning_any') || ($message['id_member'] == $user_info['id'] && allowedTo('view_warning_own'));
@@ -1578,8 +1641,9 @@  discard block
 block discarded – undo
1578 1641
 	$message['body'] = parse_bbc($message['body'], $message['smileys_enabled'], $message['id_msg']);
1579 1642
 
1580 1643
 	// If it's in the recycle bin we need to override whatever icon we did have.
1581
-	if (!empty($board_info['recycle']))
1582
-		$message['icon'] = 'recycled';
1644
+	if (!empty($board_info['recycle'])) {
1645
+			$message['icon'] = 'recycled';
1646
+	}
1583 1647
 
1584 1648
 	require_once($sourcedir . '/Subs-Attachments.php');
1585 1649
 
@@ -1623,32 +1687,36 @@  discard block
 block discarded – undo
1623 1687
 	}
1624 1688
 
1625 1689
 	// Are likes enable?
1626
-	if (!empty($modSettings['enable_likes']))
1627
-		$output['likes'] = array(
1690
+	if (!empty($modSettings['enable_likes'])) {
1691
+			$output['likes'] = array(
1628 1692
 			'count' => $message['likes'],
1629 1693
 			'you' => in_array($message['id_msg'], $context['my_likes']),
1630 1694
 			'can_like' => !$context['user']['is_guest'] && $message['id_member'] != $context['user']['id'] && !empty($context['can_like']),
1631 1695
 		);
1696
+	}
1632 1697
 
1633 1698
 	// Is this user the message author?
1634 1699
 	$output['is_message_author'] = $message['id_member'] == $user_info['id'];
1635
-	if (!empty($output['modified']['name']))
1636
-		$output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']);
1700
+	if (!empty($output['modified']['name'])) {
1701
+			$output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']);
1702
+	}
1637 1703
 
1638 1704
 	// Did they give a reason for editing?
1639
-	if (!empty($output['modified']['name']) && !empty($output['modified']['reason']))
1640
-		$output['modified']['last_edit_text'] .= '&nbsp;' . sprintf($txt['last_edit_reason'], $output['modified']['reason']);
1705
+	if (!empty($output['modified']['name']) && !empty($output['modified']['reason'])) {
1706
+			$output['modified']['last_edit_text'] .= '&nbsp;' . sprintf($txt['last_edit_reason'], $output['modified']['reason']);
1707
+	}
1641 1708
 
1642 1709
 	// Any custom profile fields?
1643
-	if (!empty($memberContext[$message['id_member']]['custom_fields']))
1644
-		foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom)
1710
+	if (!empty($memberContext[$message['id_member']]['custom_fields'])) {
1711
+			foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom)
1645 1712
 			$output['custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom;
1713
+	}
1646 1714
 
1647
-	if (empty($options['view_newest_first']))
1648
-		$counter++;
1649
-
1650
-	else
1651
-		$counter--;
1715
+	if (empty($options['view_newest_first'])) {
1716
+			$counter++;
1717
+	} else {
1718
+			$counter--;
1719
+	}
1652 1720
 
1653 1721
 	call_integration_hook('integrate_prepare_display_context', array(&$output, &$message, $counter));
1654 1722
 
@@ -1674,8 +1742,9 @@  discard block
 block discarded – undo
1674 1742
  */
1675 1743
 function approved_attach_sort($a, $b)
1676 1744
 {
1677
-	if ($a['is_approved'] == $b['is_approved'])
1678
-		return 0;
1745
+	if ($a['is_approved'] == $b['is_approved']) {
1746
+			return 0;
1747
+	}
1679 1748
 
1680 1749
 	return $a['is_approved'] > $b['is_approved'] ? -1 : 1;
1681 1750
 }
@@ -1692,16 +1761,19 @@  discard block
 block discarded – undo
1692 1761
 
1693 1762
 	require_once($sourcedir . '/RemoveTopic.php');
1694 1763
 
1695
-	if (empty($_REQUEST['msgs']))
1696
-		redirectexit('topic=' . $topic . '.' . $_REQUEST['start']);
1764
+	if (empty($_REQUEST['msgs'])) {
1765
+			redirectexit('topic=' . $topic . '.' . $_REQUEST['start']);
1766
+	}
1697 1767
 
1698 1768
 	$messages = array();
1699
-	foreach ($_REQUEST['msgs'] as $dummy)
1700
-		$messages[] = (int) $dummy;
1769
+	foreach ($_REQUEST['msgs'] as $dummy) {
1770
+			$messages[] = (int) $dummy;
1771
+	}
1701 1772
 
1702 1773
 	// We are restoring messages. We handle this in another place.
1703
-	if (isset($_REQUEST['restore_selected']))
1704
-		redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']);
1774
+	if (isset($_REQUEST['restore_selected'])) {
1775
+			redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']);
1776
+	}
1705 1777
 	if (isset($_REQUEST['split_selection']))
1706 1778
 	{
1707 1779
 		$request = $smcFunc['db_query']('', '
@@ -1720,8 +1792,9 @@  discard block
 block discarded – undo
1720 1792
 	}
1721 1793
 
1722 1794
 	// Allowed to delete any message?
1723
-	if (allowedTo('delete_any'))
1724
-		$allowed_all = true;
1795
+	if (allowedTo('delete_any')) {
1796
+			$allowed_all = true;
1797
+	}
1725 1798
 	// Allowed to delete replies to their messages?
1726 1799
 	elseif (allowedTo('delete_replies'))
1727 1800
 	{
@@ -1738,13 +1811,14 @@  discard block
 block discarded – undo
1738 1811
 		$smcFunc['db_free_result']($request);
1739 1812
 
1740 1813
 		$allowed_all = $starter == $user_info['id'];
1814
+	} else {
1815
+			$allowed_all = false;
1741 1816
 	}
1742
-	else
1743
-		$allowed_all = false;
1744 1817
 
1745 1818
 	// Make sure they're allowed to delete their own messages, if not any.
1746
-	if (!$allowed_all)
1747
-		isAllowedTo('delete_own');
1819
+	if (!$allowed_all) {
1820
+			isAllowedTo('delete_own');
1821
+	}
1748 1822
 
1749 1823
 	// Allowed to remove which messages?
1750 1824
 	$request = $smcFunc['db_query']('', '
@@ -1764,8 +1838,9 @@  discard block
 block discarded – undo
1764 1838
 	$messages = array();
1765 1839
 	while ($row = $smcFunc['db_fetch_assoc']($request))
1766 1840
 	{
1767
-		if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time())
1768
-			continue;
1841
+		if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time()) {
1842
+					continue;
1843
+		}
1769 1844
 
1770 1845
 		$messages[$row['id_msg']] = array($row['subject'], $row['id_member']);
1771 1846
 	}
@@ -1788,17 +1863,20 @@  discard block
 block discarded – undo
1788 1863
 	foreach ($messages as $message => $info)
1789 1864
 	{
1790 1865
 		// Just skip the first message - if it's not the last.
1791
-		if ($message == $first_message && $message != $last_message)
1792
-			continue;
1866
+		if ($message == $first_message && $message != $last_message) {
1867
+					continue;
1868
+		}
1793 1869
 		// If the first message is going then don't bother going back to the topic as we're effectively deleting it.
1794
-		elseif ($message == $first_message)
1795
-			$topicGone = true;
1870
+		elseif ($message == $first_message) {
1871
+					$topicGone = true;
1872
+		}
1796 1873
 
1797 1874
 		removeMessage($message);
1798 1875
 
1799 1876
 		// Log this moderation action ;).
1800
-		if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id']))
1801
-			logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board));
1877
+		if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) {
1878
+					logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board));
1879
+		}
1802 1880
 	}
1803 1881
 
1804 1882
 	redirectexit(!empty($topicGone) ? 'board=' . $board : 'topic=' . $topic . '.' . $_REQUEST['start']);
Please login to merge, or discard this patch.