Completed
Pull Request — release-2.1 (#5047)
by Mathias
06:29
created
Sources/Load.php 1 patch
Braces   +795 added lines, -599 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Load the $modSettings array.
@@ -25,13 +26,14 @@  discard block
 block discarded – undo
25 26
 	global $cache_enable, $sourcedir, $context;
26 27
 
27 28
 	// Most database systems have not set UTF-8 as their default input charset.
28
-	if (!empty($db_character_set))
29
-		$smcFunc['db_query']('', '
29
+	if (!empty($db_character_set)) {
30
+			$smcFunc['db_query']('', '
30 31
 			SET NAMES {string:db_character_set}',
31 32
 			array(
32 33
 				'db_character_set' => $db_character_set,
33 34
 			)
34 35
 		);
36
+	}
35 37
 
36 38
 	// We need some caching support, maybe.
37 39
 	loadCacheAccelerator();
@@ -46,28 +48,36 @@  discard block
 block discarded – undo
46 48
 			)
47 49
 		);
48 50
 		$modSettings = array();
49
-		if (!$request)
50
-			display_db_error();
51
-		while ($row = $smcFunc['db_fetch_row']($request))
52
-			$modSettings[$row[0]] = $row[1];
51
+		if (!$request) {
52
+					display_db_error();
53
+		}
54
+		while ($row = $smcFunc['db_fetch_row']($request)) {
55
+					$modSettings[$row[0]] = $row[1];
56
+		}
53 57
 		$smcFunc['db_free_result']($request);
54 58
 
55 59
 		// Do a few things to protect against missing settings or settings with invalid values...
56
-		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999)
57
-			$modSettings['defaultMaxTopics'] = 20;
58
-		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999)
59
-			$modSettings['defaultMaxMessages'] = 15;
60
-		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999)
61
-			$modSettings['defaultMaxMembers'] = 30;
62
-		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999)
63
-			$modSettings['defaultMaxListItems'] = 15;
60
+		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) {
61
+					$modSettings['defaultMaxTopics'] = 20;
62
+		}
63
+		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) {
64
+					$modSettings['defaultMaxMessages'] = 15;
65
+		}
66
+		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) {
67
+					$modSettings['defaultMaxMembers'] = 30;
68
+		}
69
+		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) {
70
+					$modSettings['defaultMaxListItems'] = 15;
71
+		}
64 72
 
65 73
 		// We explicitly do not use $smcFunc['json_decode'] here yet, as $smcFunc is not fully loaded.
66
-		if (!is_array($modSettings['attachmentUploadDir']))
67
-			$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
74
+		if (!is_array($modSettings['attachmentUploadDir'])) {
75
+					$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
76
+		}
68 77
 
69
-		if (!empty($cache_enable))
70
-			cache_put_data('modSettings', $modSettings, 90);
78
+		if (!empty($cache_enable)) {
79
+					cache_put_data('modSettings', $modSettings, 90);
80
+		}
71 81
 	}
72 82
 
73 83
 	$modSettings['cache_enable'] = $cache_enable;
@@ -87,8 +97,9 @@  discard block
 block discarded – undo
87 97
 		};
88 98
 	$fix_utf8mb4 = function($string) use ($utf8, $smcFunc)
89 99
 	{
90
-		if (!$utf8 || $smcFunc['db_mb4'])
91
-			return $string;
100
+		if (!$utf8 || $smcFunc['db_mb4']) {
101
+					return $string;
102
+		}
92 103
 
93 104
 		$i = 0;
94 105
 		$len = strlen($string);
@@ -100,18 +111,15 @@  discard block
 block discarded – undo
100 111
 			{
101 112
 				$new_string .= $string[$i];
102 113
 				$i++;
103
-			}
104
-			elseif ($ord < 224)
114
+			} elseif ($ord < 224)
105 115
 			{
106 116
 				$new_string .= $string[$i] . $string[$i + 1];
107 117
 				$i += 2;
108
-			}
109
-			elseif ($ord < 240)
118
+			} elseif ($ord < 240)
110 119
 			{
111 120
 				$new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2];
112 121
 				$i += 3;
113
-			}
114
-			elseif ($ord < 248)
122
+			} elseif ($ord < 248)
115 123
 			{
116 124
 				// Magic happens.
117 125
 				$val = (ord($string[$i]) & 0x07) << 18;
@@ -155,8 +163,7 @@  discard block
 block discarded – undo
155 163
 			{
156 164
 				$result = array_search($needle, array_slice($haystack_arr, $offset));
157 165
 				return is_int($result) ? $result + $offset : false;
158
-			}
159
-			else
166
+			} else
160 167
 			{
161 168
 				$needle_arr = preg_split('~(' . $ent_list . '|.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
162 169
 				$needle_size = count($needle_arr);
@@ -165,8 +172,9 @@  discard block
 block discarded – undo
165 172
 				while ((int) $result === $result)
166 173
 				{
167 174
 					$offset += $result;
168
-					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr)
169
-						return $offset;
175
+					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) {
176
+											return $offset;
177
+					}
170 178
 					$result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset));
171 179
 				}
172 180
 				return false;
@@ -204,8 +212,9 @@  discard block
 block discarded – undo
204 212
 			$string = $ent_check($string);
205 213
 			preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches);
206 214
 			$string = $matches[0];
207
-			while (strlen($string) > $length)
208
-				$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
215
+			while (strlen($string) > $length) {
216
+							$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
217
+			}
209 218
 			return $string;
210 219
 		},
211 220
 		'ucfirst' => $utf8 ? function($string) use (&$smcFunc)
@@ -215,8 +224,9 @@  discard block
 block discarded – undo
215 224
 		'ucwords' => $utf8 ? function($string) use (&$smcFunc)
216 225
 		{
217 226
 			$words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE);
218
-			for ($i = 0, $n = count($words); $i < $n; $i += 2)
219
-				$words[$i] = $smcFunc['ucfirst']($words[$i]);
227
+			for ($i = 0, $n = count($words); $i < $n; $i += 2) {
228
+							$words[$i] = $smcFunc['ucfirst']($words[$i]);
229
+			}
220 230
 			return implode('', $words);
221 231
 		} : 'ucwords',
222 232
 		'json_decode' => 'smf_json_decode',
@@ -224,16 +234,17 @@  discard block
 block discarded – undo
224 234
 	);
225 235
 
226 236
 	// Setting the timezone is a requirement for some functions.
227
-	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list()))
228
-		date_default_timezone_set($modSettings['default_timezone']);
229
-	else
237
+	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) {
238
+			date_default_timezone_set($modSettings['default_timezone']);
239
+	} else
230 240
 	{
231 241
 		// Get PHP's default timezone, if set
232 242
 		$ini_tz = ini_get('date.timezone');
233
-		if (!empty($ini_tz))
234
-			$modSettings['default_timezone'] = $ini_tz;
235
-		else
236
-			$modSettings['default_timezone'] = '';
243
+		if (!empty($ini_tz)) {
244
+					$modSettings['default_timezone'] = $ini_tz;
245
+		} else {
246
+					$modSettings['default_timezone'] = '';
247
+		}
237 248
 
238 249
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
239 250
 		if (!in_array($modSettings['default_timezone'], timezone_identifiers_list()))
@@ -251,22 +262,26 @@  discard block
 block discarded – undo
251 262
 		if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null)
252 263
 		{
253 264
 			$modSettings['load_average'] = @file_get_contents('/proc/loadavg');
254
-			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0)
255
-				$modSettings['load_average'] = (float) $matches[1];
256
-			elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0)
257
-				$modSettings['load_average'] = (float) $matches[1];
258
-			else
259
-				unset($modSettings['load_average']);
265
+			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) {
266
+							$modSettings['load_average'] = (float) $matches[1];
267
+			} elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) {
268
+							$modSettings['load_average'] = (float) $matches[1];
269
+			} else {
270
+							unset($modSettings['load_average']);
271
+			}
260 272
 
261
-			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
262
-				cache_put_data('loadavg', $modSettings['load_average'], 90);
273
+			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
274
+							cache_put_data('loadavg', $modSettings['load_average'], 90);
275
+			}
263 276
 		}
264 277
 
265
-		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
266
-			call_integration_hook('integrate_load_average', array($modSettings['load_average']));
278
+		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
279
+					call_integration_hook('integrate_load_average', array($modSettings['load_average']));
280
+		}
267 281
 
268
-		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum'])
269
-			display_loadavg_error();
282
+		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) {
283
+					display_loadavg_error();
284
+		}
270 285
 	}
271 286
 
272 287
 	// Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is.
@@ -287,8 +302,9 @@  discard block
 block discarded – undo
287 302
 	if (defined('SMF_INTEGRATION_SETTINGS'))
288 303
 	{
289 304
 		$integration_settings = $smcFunc['json_decode'](SMF_INTEGRATION_SETTINGS, true);
290
-		foreach ($integration_settings as $hook => $function)
291
-			add_integration_function($hook, $function, '', false);
305
+		foreach ($integration_settings as $hook => $function) {
306
+					add_integration_function($hook, $function, '', false);
307
+		}
292 308
 	}
293 309
 
294 310
 	// Any files to pre include?
@@ -298,8 +314,9 @@  discard block
 block discarded – undo
298 314
 		foreach ($pre_includes as $include)
299 315
 		{
300 316
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
301
-			if (file_exists($include))
302
-				require_once($include);
317
+			if (file_exists($include)) {
318
+							require_once($include);
319
+			}
303 320
 		}
304 321
 	}
305 322
 
@@ -410,9 +427,9 @@  discard block
 block discarded – undo
410 427
 				break;
411 428
 			}
412 429
 		}
430
+	} else {
431
+			$id_member = 0;
413 432
 	}
414
-	else
415
-		$id_member = 0;
416 433
 
417 434
 	if (empty($id_member) && isset($_COOKIE[$cookiename]))
418 435
 	{
@@ -420,8 +437,9 @@  discard block
 block discarded – undo
420 437
 		$cookie_data = $smcFunc['json_decode']($_COOKIE[$cookiename], true, false);
421 438
 
422 439
 		// Legacy format (for recent 2.0 --> 2.1 upgrades)
423
-		if (empty($cookie_data))
424
-			$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
440
+		if (empty($cookie_data)) {
441
+					$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
442
+		}
425 443
 
426 444
 		list($id_member, $password, $login_span, $cookie_domain, $cookie_path) = array_pad((array) $cookie_data, 5, '');
427 445
 
@@ -429,16 +447,17 @@  discard block
 block discarded – undo
429 447
 
430 448
 		// Make sure the cookie is set to the correct domain and path
431 449
 		require_once($sourcedir . '/Subs-Auth.php');
432
-		if (array($cookie_domain, $cookie_path) !== url_parts(!empty($modSettings['localCookies']), !empty($modSettings['globalCookies'])))
433
-			setLoginCookie((int) $login_span - time(), $id_member);
434
-	}
435
-	elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
450
+		if (array($cookie_domain, $cookie_path) !== url_parts(!empty($modSettings['localCookies']), !empty($modSettings['globalCookies']))) {
451
+					setLoginCookie((int) $login_span - time(), $id_member);
452
+		}
453
+	} elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
436 454
 	{
437 455
 		// @todo Perhaps we can do some more checking on this, such as on the first octet of the IP?
438 456
 		$cookie_data = $smcFunc['json_decode']($_SESSION['login_' . $cookiename], true);
439 457
 
440
-		if (empty($cookie_data))
441
-			$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
458
+		if (empty($cookie_data)) {
459
+					$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
460
+		}
442 461
 
443 462
 		list($id_member, $password, $login_span) = array_pad((array) $cookie_data, 3, '');
444 463
 		$id_member = !empty($id_member) && strlen($password) == 128 && (int) $login_span > time() ? (int) $id_member : 0;
@@ -463,30 +482,34 @@  discard block
 block discarded – undo
463 482
 			$user_settings = $smcFunc['db_fetch_assoc']($request);
464 483
 			$smcFunc['db_free_result']($request);
465 484
 
466
-			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false && empty($user_info['possibly_robot']))
467
-				$user_settings['avatar'] = get_proxied_url($user_settings['avatar']);
485
+			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false && empty($user_info['possibly_robot'])) {
486
+							$user_settings['avatar'] = get_proxied_url($user_settings['avatar']);
487
+			}
468 488
 
469
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
470
-				cache_put_data('user_settings-' . $id_member, $user_settings, 60);
489
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
490
+							cache_put_data('user_settings-' . $id_member, $user_settings, 60);
491
+			}
471 492
 		}
472 493
 
473 494
 		// Did we find 'im?  If not, junk it.
474 495
 		if (!empty($user_settings))
475 496
 		{
476 497
 			// As much as the password should be right, we can assume the integration set things up.
477
-			if (!empty($already_verified) && $already_verified === true)
478
-				$check = true;
498
+			if (!empty($already_verified) && $already_verified === true) {
499
+							$check = true;
500
+			}
479 501
 			// SHA-512 hash should be 128 characters long.
480
-			elseif (strlen($password) == 128)
481
-				$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
482
-			else
483
-				$check = false;
502
+			elseif (strlen($password) == 128) {
503
+							$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
504
+			} else {
505
+							$check = false;
506
+			}
484 507
 
485 508
 			// Wrong password or not activated - either way, you're going nowhere.
486 509
 			$id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0;
510
+		} else {
511
+					$id_member = 0;
487 512
 		}
488
-		else
489
-			$id_member = 0;
490 513
 
491 514
 		// If we no longer have the member maybe they're being all hackey, stop brute force!
492 515
 		if (!$id_member)
@@ -515,8 +538,9 @@  discard block
 block discarded – undo
515 538
 
516 539
 					list ($tfamember, $tfasecret) = array_pad((array) $tfa_data, 2, '');
517 540
 
518
-					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member)
519
-						$tfasecret = null;
541
+					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member) {
542
+											$tfasecret = null;
543
+					}
520 544
 				}
521 545
 
522 546
 				// They didn't finish logging in before coming here? Then they're no one to us.
@@ -538,10 +562,12 @@  discard block
 block discarded – undo
538 562
 		// Are we forcing 2FA? Need to check if the user groups actually require 2FA
539 563
 		elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret']))
540 564
 		{
541
-			if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups
565
+			if ($modSettings['tfa_mode'] == 2) {
566
+				//only do this if we are just forcing SOME membergroups
542 567
 			{
543 568
 				//Build an array of ALL user membergroups.
544 569
 				$full_groups = array($user_settings['id_group']);
570
+			}
545 571
 				if (!empty($user_settings['additional_groups']))
546 572
 				{
547 573
 					$full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups']));
@@ -561,15 +587,17 @@  discard block
 block discarded – undo
561 587
 				);
562 588
 				$row = $smcFunc['db_fetch_assoc']($request);
563 589
 				$smcFunc['db_free_result']($request);
590
+			} else {
591
+							$row['total'] = 1;
564 592
 			}
565
-			else
566
-				$row['total'] = 1; //simplifies logics in the next "if"
593
+			//simplifies logics in the next "if"
567 594
 
568 595
 			$area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : '';
569 596
 			$action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : '';
570 597
 
571
-			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup'))
572
-				redirectexit('action=profile;area=tfasetup;forced');
598
+			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) {
599
+							redirectexit('action=profile;area=tfasetup;forced');
600
+			}
573 601
 		}
574 602
 	}
575 603
 
@@ -606,29 +634,32 @@  discard block
 block discarded – undo
606 634
 				updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP']));
607 635
 				$user_settings['last_login'] = time();
608 636
 
609
-				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
610
-					cache_put_data('user_settings-' . $id_member, $user_settings, 60);
637
+				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
638
+									cache_put_data('user_settings-' . $id_member, $user_settings, 60);
639
+				}
611 640
 
612
-				if (!empty($modSettings['cache_enable']))
613
-					cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
641
+				if (!empty($modSettings['cache_enable'])) {
642
+									cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
643
+				}
614 644
 			}
645
+		} elseif (empty($_SESSION['id_msg_last_visit'])) {
646
+					$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
615 647
 		}
616
-		elseif (empty($_SESSION['id_msg_last_visit']))
617
-			$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
618 648
 
619 649
 		$username = $user_settings['member_name'];
620 650
 
621
-		if (empty($user_settings['additional_groups']))
622
-			$user_info = array(
651
+		if (empty($user_settings['additional_groups'])) {
652
+					$user_info = array(
623 653
 				'groups' => array($user_settings['id_group'], $user_settings['id_post_group'])
624 654
 			);
625
-		else
626
-			$user_info = array(
655
+		} else {
656
+					$user_info = array(
627 657
 				'groups' => array_merge(
628 658
 					array($user_settings['id_group'], $user_settings['id_post_group']),
629 659
 					explode(',', $user_settings['additional_groups'])
630 660
 				)
631 661
 			);
662
+		}
632 663
 
633 664
 		// Because history has proven that it is possible for groups to go bad - clean up in case.
634 665
 		$user_info['groups'] = array_map('intval', $user_info['groups']);
@@ -645,8 +676,7 @@  discard block
 block discarded – undo
645 676
 			$time_system = new DateTime('now', $tz_system);
646 677
 			$time_user = new DateTime('now', $tz_user);
647 678
 			$user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600;
648
-		}
649
-		else
679
+		} else
650 680
 		{
651 681
 			// !!! Compatibility.
652 682
 			$user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset'];
@@ -660,8 +690,9 @@  discard block
 block discarded – undo
660 690
 		$user_info = array('groups' => array(-1));
661 691
 		$user_settings = array();
662 692
 
663
-		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member']))
664
-			$_COOKIE[$cookiename] = '';
693
+		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) {
694
+					$_COOKIE[$cookiename] = '';
695
+		}
665 696
 
666 697
 		// Expire the 2FA cookie
667 698
 		if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member']))
@@ -678,19 +709,20 @@  discard block
 block discarded – undo
678 709
 		}
679 710
 
680 711
 		// Create a login token if it doesn't exist yet.
681
-		if (!isset($_SESSION['token']['post-login']))
682
-			createToken('login');
683
-		else
684
-			list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
712
+		if (!isset($_SESSION['token']['post-login'])) {
713
+					createToken('login');
714
+		} else {
715
+					list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
716
+		}
685 717
 
686 718
 		// Do we perhaps think this is a search robot? Check every five minutes just in case...
687 719
 		if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300))
688 720
 		{
689 721
 			require_once($sourcedir . '/ManageSearchEngines.php');
690 722
 			$user_info['possibly_robot'] = SpiderCheck();
723
+		} elseif (!empty($modSettings['spider_mode'])) {
724
+					$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
691 725
 		}
692
-		elseif (!empty($modSettings['spider_mode']))
693
-			$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
694 726
 		// If we haven't turned on proper spider hunts then have a guess!
695 727
 		else
696 728
 		{
@@ -747,8 +779,9 @@  discard block
 block discarded – undo
747 779
 	$user_info['groups'] = array_unique($user_info['groups']);
748 780
 
749 781
 	// Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems.
750
-	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1]))
751
-		unset($user_info['ignoreboards'][$tmp]);
782
+	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) {
783
+			unset($user_info['ignoreboards'][$tmp]);
784
+	}
752 785
 
753 786
 	// Allow the user to change their language.
754 787
 	if (!empty($modSettings['userLanguage']))
@@ -761,13 +794,14 @@  discard block
 block discarded – undo
761 794
 			$user_info['language'] = strtr($_GET['language'], './\\:', '____');
762 795
 
763 796
 			// Make it permanent for members.
764
-			if (!empty($user_info['id']))
765
-				updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
766
-			else
767
-				$_SESSION['language'] = $user_info['language'];
797
+			if (!empty($user_info['id'])) {
798
+							updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
799
+			} else {
800
+							$_SESSION['language'] = $user_info['language'];
801
+			}
802
+		} elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) {
803
+					$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
768 804
 		}
769
-		elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')]))
770
-			$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
771 805
 	}
772 806
 
773 807
 	$temp = build_query_board($user_info['id']);
@@ -830,9 +864,9 @@  discard block
 block discarded – undo
830 864
 		}
831 865
 
832 866
 		// Remember redirection is the key to avoiding fallout from your bosses.
833
-		if (!empty($topic))
834
-			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
835
-		else
867
+		if (!empty($topic)) {
868
+					redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
869
+		} else
836 870
 		{
837 871
 			loadPermissions();
838 872
 			loadTheme();
@@ -850,10 +884,11 @@  discard block
 block discarded – undo
850 884
 	if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
851 885
 	{
852 886
 		// @todo SLOW?
853
-		if (!empty($topic))
854
-			$temp = cache_get_data('topic_board-' . $topic, 120);
855
-		else
856
-			$temp = cache_get_data('board-' . $board, 120);
887
+		if (!empty($topic)) {
888
+					$temp = cache_get_data('topic_board-' . $topic, 120);
889
+		} else {
890
+					$temp = cache_get_data('board-' . $board, 120);
891
+		}
857 892
 
858 893
 		if (!empty($temp))
859 894
 		{
@@ -891,8 +926,9 @@  discard block
 block discarded – undo
891 926
 			$row = $smcFunc['db_fetch_assoc']($request);
892 927
 
893 928
 			// Set the current board.
894
-			if (!empty($row['id_board']))
895
-				$board = $row['id_board'];
929
+			if (!empty($row['id_board'])) {
930
+							$board = $row['id_board'];
931
+			}
896 932
 
897 933
 			// Basic operating information. (globals... :/)
898 934
 			$board_info = array(
@@ -928,21 +964,23 @@  discard block
 block discarded – undo
928 964
 
929 965
 			do
930 966
 			{
931
-				if (!empty($row['id_moderator']))
932
-					$board_info['moderators'][$row['id_moderator']] = array(
967
+				if (!empty($row['id_moderator'])) {
968
+									$board_info['moderators'][$row['id_moderator']] = array(
933 969
 						'id' => $row['id_moderator'],
934 970
 						'name' => $row['real_name'],
935 971
 						'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
936 972
 						'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
937 973
 					);
974
+				}
938 975
 
939
-				if (!empty($row['id_moderator_group']))
940
-					$board_info['moderator_groups'][$row['id_moderator_group']] = array(
976
+				if (!empty($row['id_moderator_group'])) {
977
+									$board_info['moderator_groups'][$row['id_moderator_group']] = array(
941 978
 						'id' => $row['id_moderator_group'],
942 979
 						'name' => $row['group_name'],
943 980
 						'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
944 981
 						'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
945 982
 					);
983
+				}
946 984
 			}
947 985
 			while ($row = $smcFunc['db_fetch_assoc']($request));
948 986
 
@@ -974,12 +1012,12 @@  discard block
 block discarded – undo
974 1012
 			if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
975 1013
 			{
976 1014
 				// @todo SLOW?
977
-				if (!empty($topic))
978
-					cache_put_data('topic_board-' . $topic, $board_info, 120);
1015
+				if (!empty($topic)) {
1016
+									cache_put_data('topic_board-' . $topic, $board_info, 120);
1017
+				}
979 1018
 				cache_put_data('board-' . $board, $board_info, 120);
980 1019
 			}
981
-		}
982
-		else
1020
+		} else
983 1021
 		{
984 1022
 			// Otherwise the topic is invalid, there are no moderators, etc.
985 1023
 			$board_info = array(
@@ -993,8 +1031,9 @@  discard block
 block discarded – undo
993 1031
 		$smcFunc['db_free_result']($request);
994 1032
 	}
995 1033
 
996
-	if (!empty($topic))
997
-		$_GET['board'] = (int) $board;
1034
+	if (!empty($topic)) {
1035
+			$_GET['board'] = (int) $board;
1036
+	}
998 1037
 
999 1038
 	if (!empty($board))
1000 1039
 	{
@@ -1004,10 +1043,12 @@  discard block
 block discarded – undo
1004 1043
 		// Now check if the user is a moderator.
1005 1044
 		$user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0;
1006 1045
 
1007
-		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin'])
1008
-			$board_info['error'] = 'access';
1009
-		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin'])
1010
-			$board_info['error'] = 'access';
1046
+		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) {
1047
+					$board_info['error'] = 'access';
1048
+		}
1049
+		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) {
1050
+					$board_info['error'] = 'access';
1051
+		}
1011 1052
 
1012 1053
 		// Build up the linktree.
1013 1054
 		$context['linktree'] = array_merge(
@@ -1030,8 +1071,9 @@  discard block
 block discarded – undo
1030 1071
 	$context['current_board'] = $board;
1031 1072
 
1032 1073
 	// No posting in redirection boards!
1033
-	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect']))
1034
-		$board_info['error'] == 'post_in_redirect';
1074
+	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) {
1075
+			$board_info['error'] == 'post_in_redirect';
1076
+	}
1035 1077
 
1036 1078
 	// Hacker... you can't see this topic, I'll tell you that. (but moderators can!)
1037 1079
 	if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod']))
@@ -1057,24 +1099,23 @@  discard block
 block discarded – undo
1057 1099
 			ob_end_clean();
1058 1100
 			send_http_status(403);
1059 1101
 			die;
1060
-		}
1061
-		elseif ($board_info['error'] == 'post_in_redirect')
1102
+		} elseif ($board_info['error'] == 'post_in_redirect')
1062 1103
 		{
1063 1104
 			// Slightly different error message here...
1064 1105
 			fatal_lang_error('cannot_post_redirect', false);
1065
-		}
1066
-		elseif ($user_info['is_guest'])
1106
+		} elseif ($user_info['is_guest'])
1067 1107
 		{
1068 1108
 			loadLanguage('Errors');
1069 1109
 			is_not_guest($txt['topic_gone']);
1110
+		} else {
1111
+					fatal_lang_error('topic_gone', false);
1070 1112
 		}
1071
-		else
1072
-			fatal_lang_error('topic_gone', false);
1073 1113
 	}
1074 1114
 
1075
-	if ($user_info['is_mod'])
1076
-		$user_info['groups'][] = 3;
1077
-}
1115
+	if ($user_info['is_mod']) {
1116
+			$user_info['groups'][] = 3;
1117
+	}
1118
+	}
1078 1119
 
1079 1120
 /**
1080 1121
  * Load this user's permissions.
@@ -1095,8 +1136,9 @@  discard block
 block discarded – undo
1095 1136
 		asort($cache_groups);
1096 1137
 		$cache_groups = implode(',', $cache_groups);
1097 1138
 		// If it's a spider then cache it different.
1098
-		if ($user_info['possibly_robot'])
1099
-			$cache_groups .= '-spider';
1139
+		if ($user_info['possibly_robot']) {
1140
+					$cache_groups .= '-spider';
1141
+		}
1100 1142
 
1101 1143
 		if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1102 1144
 		{
@@ -1104,9 +1146,9 @@  discard block
 block discarded – undo
1104 1146
 			banPermissions();
1105 1147
 
1106 1148
 			return;
1149
+		} elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) {
1150
+					list ($user_info['permissions'], $removals) = $temp;
1107 1151
 		}
1108
-		elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1109
-			list ($user_info['permissions'], $removals) = $temp;
1110 1152
 	}
1111 1153
 
1112 1154
 	// If it is detected as a robot, and we are restricting permissions as a special group - then implement this.
@@ -1128,23 +1170,26 @@  discard block
 block discarded – undo
1128 1170
 		$removals = array();
1129 1171
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1130 1172
 		{
1131
-			if (empty($row['add_deny']))
1132
-				$removals[] = $row['permission'];
1133
-			else
1134
-				$user_info['permissions'][] = $row['permission'];
1173
+			if (empty($row['add_deny'])) {
1174
+							$removals[] = $row['permission'];
1175
+			} else {
1176
+							$user_info['permissions'][] = $row['permission'];
1177
+			}
1135 1178
 		}
1136 1179
 		$smcFunc['db_free_result']($request);
1137 1180
 
1138
-		if (isset($cache_groups))
1139
-			cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1181
+		if (isset($cache_groups)) {
1182
+					cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1183
+		}
1140 1184
 	}
1141 1185
 
1142 1186
 	// Get the board permissions.
1143 1187
 	if (!empty($board))
1144 1188
 	{
1145 1189
 		// Make sure the board (if any) has been loaded by loadBoard().
1146
-		if (!isset($board_info['profile']))
1147
-			fatal_lang_error('no_board');
1190
+		if (!isset($board_info['profile'])) {
1191
+					fatal_lang_error('no_board');
1192
+		}
1148 1193
 
1149 1194
 		$request = $smcFunc['db_query']('', '
1150 1195
 			SELECT permission, add_deny
@@ -1160,20 +1205,23 @@  discard block
 block discarded – undo
1160 1205
 		);
1161 1206
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1162 1207
 		{
1163
-			if (empty($row['add_deny']))
1164
-				$removals[] = $row['permission'];
1165
-			else
1166
-				$user_info['permissions'][] = $row['permission'];
1208
+			if (empty($row['add_deny'])) {
1209
+							$removals[] = $row['permission'];
1210
+			} else {
1211
+							$user_info['permissions'][] = $row['permission'];
1212
+			}
1167 1213
 		}
1168 1214
 		$smcFunc['db_free_result']($request);
1169 1215
 	}
1170 1216
 
1171 1217
 	// Remove all the permissions they shouldn't have ;).
1172
-	if (!empty($modSettings['permission_enable_deny']))
1173
-		$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1218
+	if (!empty($modSettings['permission_enable_deny'])) {
1219
+			$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1220
+	}
1174 1221
 
1175
-	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2)
1176
-		cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1222
+	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) {
1223
+			cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1224
+	}
1177 1225
 
1178 1226
 	// Banned?  Watch, don't touch..
1179 1227
 	banPermissions();
@@ -1185,17 +1233,18 @@  discard block
 block discarded – undo
1185 1233
 		{
1186 1234
 			require_once($sourcedir . '/Subs-Auth.php');
1187 1235
 			rebuildModCache();
1236
+		} else {
1237
+					$user_info['mod_cache'] = $_SESSION['mc'];
1188 1238
 		}
1189
-		else
1190
-			$user_info['mod_cache'] = $_SESSION['mc'];
1191 1239
 
1192 1240
 		// This is a useful phantom permission added to the current user, and only the current user while they are logged in.
1193 1241
 		// For example this drastically simplifies certain changes to the profile area.
1194 1242
 		$user_info['permissions'][] = 'is_not_guest';
1195 1243
 		// And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions.
1196 1244
 		$user_info['permissions'][] = 'profile_view_own';
1197
-		if (in_array('profile_view', $user_info['permissions']))
1198
-			$user_info['permissions'][] = 'profile_view_any';
1245
+		if (in_array('profile_view', $user_info['permissions'])) {
1246
+					$user_info['permissions'][] = 'profile_view_any';
1247
+		}
1199 1248
 	}
1200 1249
 }
1201 1250
 
@@ -1213,8 +1262,9 @@  discard block
 block discarded – undo
1213 1262
 	global $image_proxy_enabled, $user_info;
1214 1263
 
1215 1264
 	// Can't just look for no users :P.
1216
-	if (empty($users))
1217
-		return array();
1265
+	if (empty($users)) {
1266
+			return array();
1267
+	}
1218 1268
 
1219 1269
 	// Pass the set value
1220 1270
 	$context['loadMemberContext_set'] = $set;
@@ -1229,8 +1279,9 @@  discard block
 block discarded – undo
1229 1279
 		for ($i = 0, $n = count($users); $i < $n; $i++)
1230 1280
 		{
1231 1281
 			$data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240);
1232
-			if ($data == null)
1233
-				continue;
1282
+			if ($data == null) {
1283
+							continue;
1284
+			}
1234 1285
 
1235 1286
 			$loaded_ids[] = $data['id_member'];
1236 1287
 			$user_profile[$data['id_member']] = $data;
@@ -1297,16 +1348,19 @@  discard block
 block discarded – undo
1297 1348
 			$row['avatar_original'] = !empty($row['avatar']) ? $row['avatar'] : '';
1298 1349
 
1299 1350
 			// Take care of proxying avatar if required, do this here for maximum reach
1300
-			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false && empty($user_info['possibly_robot']))
1301
-				$row['avatar'] = get_proxied_url($row['avatar']);
1351
+			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false && empty($user_info['possibly_robot'])) {
1352
+							$row['avatar'] = get_proxied_url($row['avatar']);
1353
+			}
1302 1354
 
1303 1355
 			// Keep track of the member's normal member group
1304 1356
 			$row['primary_group'] = !empty($row['member_group']) ? $row['member_group'] : '';
1305 1357
 
1306
-			if (isset($row['member_ip']))
1307
-				$row['member_ip'] = inet_dtop($row['member_ip']);
1308
-			if (isset($row['member_ip2']))
1309
-				$row['member_ip2'] = inet_dtop($row['member_ip2']);
1358
+			if (isset($row['member_ip'])) {
1359
+							$row['member_ip'] = inet_dtop($row['member_ip']);
1360
+			}
1361
+			if (isset($row['member_ip2'])) {
1362
+							$row['member_ip2'] = inet_dtop($row['member_ip2']);
1363
+			}
1310 1364
 			$row['id_member'] = (int) $row['id_member'];
1311 1365
 			$new_loaded_ids[] = $row['id_member'];
1312 1366
 			$loaded_ids[] = $row['id_member'];
@@ -1326,8 +1380,9 @@  discard block
 block discarded – undo
1326 1380
 				'loaded_ids' => $new_loaded_ids,
1327 1381
 			)
1328 1382
 		);
1329
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1330
-			$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1383
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1384
+					$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1385
+		}
1331 1386
 		$smcFunc['db_free_result']($request);
1332 1387
 	}
1333 1388
 
@@ -1338,10 +1393,11 @@  discard block
 block discarded – undo
1338 1393
 	{
1339 1394
 		foreach ($loaded_ids as $a_member)
1340 1395
 		{
1341
-			if (!empty($user_profile[$a_member]['additional_groups']))
1342
-				$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1343
-			else
1344
-				$groups = array($user_profile[$a_member]['id_group']);
1396
+			if (!empty($user_profile[$a_member]['additional_groups'])) {
1397
+							$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1398
+			} else {
1399
+							$groups = array($user_profile[$a_member]['id_group']);
1400
+			}
1345 1401
 
1346 1402
 			$temp = array_intersect($groups, array_keys($board_info['moderator_groups']));
1347 1403
 
@@ -1354,8 +1410,9 @@  discard block
 block discarded – undo
1354 1410
 
1355 1411
 	if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3)
1356 1412
 	{
1357
-		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++)
1358
-			cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1413
+		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) {
1414
+					cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1415
+		}
1359 1416
 	}
1360 1417
 
1361 1418
 	// Are we loading any moderators?  If so, fix their group data...
@@ -1381,14 +1438,17 @@  discard block
 block discarded – undo
1381 1438
 		foreach ($temp_mods as $id)
1382 1439
 		{
1383 1440
 			// By popular demand, don't show admins or global moderators as moderators.
1384
-			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2)
1385
-				$user_profile[$id]['member_group'] = $row['member_group'];
1441
+			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) {
1442
+							$user_profile[$id]['member_group'] = $row['member_group'];
1443
+			}
1386 1444
 
1387 1445
 			// If the Moderator group has no color or icons, but their group does... don't overwrite.
1388
-			if (!empty($row['icons']))
1389
-				$user_profile[$id]['icons'] = $row['icons'];
1390
-			if (!empty($row['member_group_color']))
1391
-				$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1446
+			if (!empty($row['icons'])) {
1447
+							$user_profile[$id]['icons'] = $row['icons'];
1448
+			}
1449
+			if (!empty($row['member_group_color'])) {
1450
+							$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1451
+			}
1392 1452
 		}
1393 1453
 	}
1394 1454
 
@@ -1410,12 +1470,14 @@  discard block
 block discarded – undo
1410 1470
 	static $loadedLanguages = array();
1411 1471
 
1412 1472
 	// If this person's data is already loaded, skip it.
1413
-	if (isset($dataLoaded[$user]))
1414
-		return true;
1473
+	if (isset($dataLoaded[$user])) {
1474
+			return true;
1475
+	}
1415 1476
 
1416 1477
 	// We can't load guests or members not loaded by loadMemberData()!
1417
-	if ($user == 0)
1418
-		return false;
1478
+	if ($user == 0) {
1479
+			return false;
1480
+	}
1419 1481
 	if (!isset($user_profile[$user]))
1420 1482
 	{
1421 1483
 		trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING);
@@ -1441,12 +1503,16 @@  discard block
 block discarded – undo
1441 1503
 	$buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array();
1442 1504
 
1443 1505
 	//We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme
1444
-	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists
1506
+	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) {
1507
+		//icon is set and exists
1445 1508
 		$group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1];
1446
-	elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default
1509
+	} elseif (isset($profile['icons'][1])) {
1510
+		//icon is set and doesn't exist, fallback to default
1447 1511
 		$group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1];
1448
-	else //not set, bye bye
1512
+	} else {
1513
+		//not set, bye bye
1449 1514
 		$group_icon_url = '';
1515
+	}
1450 1516
 
1451 1517
 	// These minimal values are always loaded
1452 1518
 	$memberContext[$user] = array(
@@ -1465,8 +1531,9 @@  discard block
 block discarded – undo
1465 1531
 	if ($context['loadMemberContext_set'] != 'minimal')
1466 1532
 	{
1467 1533
 		// Go the extra mile and load the user's native language name.
1468
-		if (empty($loadedLanguages))
1469
-			$loadedLanguages = getLanguages();
1534
+		if (empty($loadedLanguages)) {
1535
+					$loadedLanguages = getLanguages();
1536
+		}
1470 1537
 
1471 1538
 		$memberContext[$user] += array(
1472 1539
 			'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>',
@@ -1521,31 +1588,33 @@  discard block
 block discarded – undo
1521 1588
 	{
1522 1589
 		if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://')))
1523 1590
 		{
1524
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11)
1525
-				$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1526
-			else
1527
-				$image = get_gravatar_url($profile['email_address']);
1528
-		}
1529
-		else
1591
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) {
1592
+							$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1593
+			} else {
1594
+							$image = get_gravatar_url($profile['email_address']);
1595
+			}
1596
+		} else
1530 1597
 		{
1531 1598
 			// So it's stored in the member table?
1532 1599
 			if (!empty($profile['avatar']))
1533 1600
 			{
1534 1601
 				$image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar'];
1602
+			} elseif (!empty($profile['filename'])) {
1603
+							$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1535 1604
 			}
1536
-			elseif (!empty($profile['filename']))
1537
-				$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1538 1605
 			// Right... no avatar...use the default one
1539
-			else
1540
-				$image = $modSettings['avatar_url'] . '/default.png';
1606
+			else {
1607
+							$image = $modSettings['avatar_url'] . '/default.png';
1608
+			}
1541 1609
 		}
1542
-		if (!empty($image))
1543
-			$memberContext[$user]['avatar'] = array(
1610
+		if (!empty($image)) {
1611
+					$memberContext[$user]['avatar'] = array(
1544 1612
 				'name' => $profile['avatar'],
1545 1613
 				'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">',
1546 1614
 				'href' => $image,
1547 1615
 				'url' => $image,
1548 1616
 			);
1617
+		}
1549 1618
 	}
1550 1619
 
1551 1620
 	// Are we also loading the members custom fields into context?
@@ -1553,13 +1622,15 @@  discard block
 block discarded – undo
1553 1622
 	{
1554 1623
 		$memberContext[$user]['custom_fields'] = array();
1555 1624
 
1556
-		if (!isset($context['display_fields']))
1557
-			$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1625
+		if (!isset($context['display_fields'])) {
1626
+					$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1627
+		}
1558 1628
 
1559 1629
 		foreach ($context['display_fields'] as $custom)
1560 1630
 		{
1561
-			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']]))
1562
-				continue;
1631
+			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) {
1632
+							continue;
1633
+			}
1563 1634
 
1564 1635
 			$value = $profile['options'][$custom['col_name']];
1565 1636
 
@@ -1567,31 +1638,36 @@  discard block
 block discarded – undo
1567 1638
 			$currentKey = 0;
1568 1639
 
1569 1640
 			// Create a key => value array for multiple options fields
1570
-			if (!empty($custom['options']))
1571
-				foreach ($custom['options'] as $k => $v)
1641
+			if (!empty($custom['options'])) {
1642
+							foreach ($custom['options'] as $k => $v)
1572 1643
 				{
1573 1644
 					$fieldOptions[] = $v;
1574
-					if (empty($currentKey))
1575
-						$currentKey = $v == $value ? $k : 0;
1645
+			}
1646
+					if (empty($currentKey)) {
1647
+											$currentKey = $v == $value ? $k : 0;
1648
+					}
1576 1649
 				}
1577 1650
 
1578 1651
 			// BBC?
1579
-			if ($custom['bbc'])
1580
-				$value = parse_bbc($value);
1652
+			if ($custom['bbc']) {
1653
+							$value = parse_bbc($value);
1654
+			}
1581 1655
 
1582 1656
 			// ... or checkbox?
1583
-			elseif (isset($custom['type']) && $custom['type'] == 'check')
1584
-				$value = $value ? $txt['yes'] : $txt['no'];
1657
+			elseif (isset($custom['type']) && $custom['type'] == 'check') {
1658
+							$value = $value ? $txt['yes'] : $txt['no'];
1659
+			}
1585 1660
 
1586 1661
 			// Enclosing the user input within some other text?
1587
-			if (!empty($custom['enclose']))
1588
-				$value = strtr($custom['enclose'], array(
1662
+			if (!empty($custom['enclose'])) {
1663
+							$value = strtr($custom['enclose'], array(
1589 1664
 					'{SCRIPTURL}' => $scripturl,
1590 1665
 					'{IMAGES_URL}' => $settings['images_url'],
1591 1666
 					'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1592 1667
 					'{INPUT}' => $value,
1593 1668
 					'{KEY}' => $currentKey,
1594 1669
 				));
1670
+			}
1595 1671
 
1596 1672
 			$memberContext[$user]['custom_fields'][] = array(
1597 1673
 				'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'],
@@ -1618,8 +1694,9 @@  discard block
 block discarded – undo
1618 1694
 	global $smcFunc, $txt, $scripturl, $settings;
1619 1695
 
1620 1696
 	// Do not waste my time...
1621
-	if (empty($users) || empty($params))
1622
-		return false;
1697
+	if (empty($users) || empty($params)) {
1698
+			return false;
1699
+	}
1623 1700
 
1624 1701
 	// Make sure it's an array.
1625 1702
 	$users = !is_array($users) ? array($users) : array_unique($users);
@@ -1646,41 +1723,48 @@  discard block
 block discarded – undo
1646 1723
 		$currentKey = 0;
1647 1724
 
1648 1725
 		// Create a key => value array for multiple options fields
1649
-		if (!empty($row['field_options']))
1650
-			foreach (explode(',', $row['field_options']) as $k => $v)
1726
+		if (!empty($row['field_options'])) {
1727
+					foreach (explode(',', $row['field_options']) as $k => $v)
1651 1728
 			{
1652 1729
 				$fieldOptions[] = $v;
1653
-				if (empty($currentKey))
1654
-					$currentKey = $v == $row['value'] ? $k : 0;
1730
+		}
1731
+				if (empty($currentKey)) {
1732
+									$currentKey = $v == $row['value'] ? $k : 0;
1733
+				}
1655 1734
 			}
1656 1735
 
1657 1736
 		// BBC?
1658
-		if (!empty($row['bbc']))
1659
-			$row['value'] = parse_bbc($row['value']);
1737
+		if (!empty($row['bbc'])) {
1738
+					$row['value'] = parse_bbc($row['value']);
1739
+		}
1660 1740
 
1661 1741
 		// ... or checkbox?
1662
-		elseif (isset($row['type']) && $row['type'] == 'check')
1663
-			$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1742
+		elseif (isset($row['type']) && $row['type'] == 'check') {
1743
+					$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1744
+		}
1664 1745
 
1665 1746
 		// Enclosing the user input within some other text?
1666
-		if (!empty($row['enclose']))
1667
-			$row['value'] = strtr($row['enclose'], array(
1747
+		if (!empty($row['enclose'])) {
1748
+					$row['value'] = strtr($row['enclose'], array(
1668 1749
 				'{SCRIPTURL}' => $scripturl,
1669 1750
 				'{IMAGES_URL}' => $settings['images_url'],
1670 1751
 				'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1671 1752
 				'{INPUT}' => un_htmlspecialchars($row['value']),
1672 1753
 				'{KEY}' => $currentKey,
1673 1754
 			));
1755
+		}
1674 1756
 
1675 1757
 		// Send a simple array if there is just 1 param
1676
-		if (count($params) == 1)
1677
-			$return[$row['id_member']] = $row;
1758
+		if (count($params) == 1) {
1759
+					$return[$row['id_member']] = $row;
1760
+		}
1678 1761
 
1679 1762
 		// More than 1? knock yourself out...
1680 1763
 		else
1681 1764
 		{
1682
-			if (!isset($return[$row['id_member']]))
1683
-				$return[$row['id_member']] = array();
1765
+			if (!isset($return[$row['id_member']])) {
1766
+							$return[$row['id_member']] = array();
1767
+			}
1684 1768
 
1685 1769
 			$return[$row['id_member']][$row['variable']] = $row;
1686 1770
 		}
@@ -1714,8 +1798,9 @@  discard block
 block discarded – undo
1714 1798
 	global $context;
1715 1799
 
1716 1800
 	// Don't know any browser!
1717
-	if (empty($context['browser']))
1718
-		detectBrowser();
1801
+	if (empty($context['browser'])) {
1802
+			detectBrowser();
1803
+	}
1719 1804
 
1720 1805
 	return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false;
1721 1806
 }
@@ -1733,8 +1818,9 @@  discard block
 block discarded – undo
1733 1818
 	global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled;
1734 1819
 
1735 1820
 	// The theme was specified by parameter.
1736
-	if (!empty($id_theme))
1737
-		$id_theme = (int) $id_theme;
1821
+	if (!empty($id_theme)) {
1822
+			$id_theme = (int) $id_theme;
1823
+	}
1738 1824
 	// The theme was specified by REQUEST.
1739 1825
 	elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1740 1826
 	{
@@ -1742,32 +1828,38 @@  discard block
 block discarded – undo
1742 1828
 		$_SESSION['id_theme'] = $id_theme;
1743 1829
 	}
1744 1830
 	// The theme was specified by REQUEST... previously.
1745
-	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1746
-		$id_theme = (int) $_SESSION['id_theme'];
1831
+	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) {
1832
+			$id_theme = (int) $_SESSION['id_theme'];
1833
+	}
1747 1834
 	// The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.)
1748
-	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme']))
1749
-		$id_theme = $user_info['theme'];
1835
+	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) {
1836
+			$id_theme = $user_info['theme'];
1837
+	}
1750 1838
 	// The theme was specified by the board.
1751
-	elseif (!empty($board_info['theme']))
1752
-		$id_theme = $board_info['theme'];
1839
+	elseif (!empty($board_info['theme'])) {
1840
+			$id_theme = $board_info['theme'];
1841
+	}
1753 1842
 	// The theme is the forum's default.
1754
-	else
1755
-		$id_theme = $modSettings['theme_guests'];
1843
+	else {
1844
+			$id_theme = $modSettings['theme_guests'];
1845
+	}
1756 1846
 
1757 1847
 	// Verify the id_theme... no foul play.
1758 1848
 	// Always allow the board specific theme, if they are overriding.
1759
-	if (!empty($board_info['theme']) && $board_info['override_theme'])
1760
-		$id_theme = $board_info['theme'];
1849
+	if (!empty($board_info['theme']) && $board_info['override_theme']) {
1850
+			$id_theme = $board_info['theme'];
1851
+	}
1761 1852
 	// If they have specified a particular theme to use with SSI allow it to be used.
1762
-	elseif (!empty($ssi_theme) && $id_theme == $ssi_theme)
1763
-		$id_theme = (int) $id_theme;
1764
-	elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1853
+	elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) {
1854
+			$id_theme = (int) $id_theme;
1855
+	} elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1765 1856
 	{
1766 1857
 		$themes = explode(',', $modSettings['enableThemes']);
1767
-		if (!in_array($id_theme, $themes))
1768
-			$id_theme = $modSettings['theme_guests'];
1769
-		else
1770
-			$id_theme = (int) $id_theme;
1858
+		if (!in_array($id_theme, $themes)) {
1859
+					$id_theme = $modSettings['theme_guests'];
1860
+		} else {
1861
+					$id_theme = (int) $id_theme;
1862
+		}
1771 1863
 	}
1772 1864
 		
1773 1865
 	// Allow mod authors the option to override the theme id for custom page themes
@@ -1779,18 +1871,19 @@  discard block
 block discarded – undo
1779 1871
 		$member = empty($user_info['id']) ? -1 : $user_info['id'];
1780 1872
 
1781 1873
 		// Disable image proxy if we don't have SSL enabled
1782
-		if (empty($modSettings['force_ssl']))
1783
-			$image_proxy_enabled = false;
1874
+		if (empty($modSettings['force_ssl'])) {
1875
+					$image_proxy_enabled = false;
1876
+		}
1784 1877
 
1785 1878
 		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated'])
1786 1879
 		{
1787 1880
 			$themeData = $temp;
1788 1881
 			$flag = true;
1882
+		} elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) {
1883
+					$themeData = $temp + array($member => array());
1884
+		} else {
1885
+					$themeData = array(-1 => array(), 0 => array(), $member => array());
1789 1886
 		}
1790
-		elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated'])
1791
-			$themeData = $temp + array($member => array());
1792
-		else
1793
-			$themeData = array(-1 => array(), 0 => array(), $member => array());
1794 1887
 
1795 1888
 		if (empty($flag))
1796 1889
 		{
@@ -1810,31 +1903,37 @@  discard block
 block discarded – undo
1810 1903
 			while ($row = $smcFunc['db_fetch_assoc']($result))
1811 1904
 			{
1812 1905
 				// There are just things we shouldn't be able to change as members.
1813
-				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url')))
1814
-					continue;
1906
+				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) {
1907
+									continue;
1908
+				}
1815 1909
 
1816 1910
 				// If this is the theme_dir of the default theme, store it.
1817
-				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member']))
1818
-					$themeData[0]['default_' . $row['variable']] = $row['value'];
1911
+				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) {
1912
+									$themeData[0]['default_' . $row['variable']] = $row['value'];
1913
+				}
1819 1914
 
1820 1915
 				// If this isn't set yet, is a theme option, or is not the default theme..
1821
-				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1')
1822
-					$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1916
+				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') {
1917
+									$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1918
+				}
1823 1919
 			}
1824 1920
 			$smcFunc['db_free_result']($result);
1825 1921
 
1826
-			if (!empty($themeData[-1]))
1827
-				foreach ($themeData[-1] as $k => $v)
1922
+			if (!empty($themeData[-1])) {
1923
+							foreach ($themeData[-1] as $k => $v)
1828 1924
 				{
1829 1925
 					if (!isset($themeData[$member][$k]))
1830 1926
 						$themeData[$member][$k] = $v;
1927
+			}
1831 1928
 				}
1832 1929
 
1833
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
1834
-				cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1930
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
1931
+							cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1932
+			}
1835 1933
 			// Only if we didn't already load that part of the cache...
1836
-			elseif (!isset($temp))
1837
-				cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1934
+			elseif (!isset($temp)) {
1935
+							cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1936
+			}
1838 1937
 		}
1839 1938
 
1840 1939
 		$settings = $themeData[0];
@@ -1851,17 +1950,20 @@  discard block
 block discarded – undo
1851 1950
 		$settings['template_dirs'][] = $settings['theme_dir'];
1852 1951
 
1853 1952
 		// Based on theme (if there is one).
1854
-		if (!empty($settings['base_theme_dir']))
1855
-			$settings['template_dirs'][] = $settings['base_theme_dir'];
1953
+		if (!empty($settings['base_theme_dir'])) {
1954
+					$settings['template_dirs'][] = $settings['base_theme_dir'];
1955
+		}
1856 1956
 
1857 1957
 		// Lastly the default theme.
1858
-		if ($settings['theme_dir'] != $settings['default_theme_dir'])
1859
-			$settings['template_dirs'][] = $settings['default_theme_dir'];
1958
+		if ($settings['theme_dir'] != $settings['default_theme_dir']) {
1959
+					$settings['template_dirs'][] = $settings['default_theme_dir'];
1960
+		}
1860 1961
 	}
1861 1962
 
1862 1963
 
1863
-	if (!$initialize)
1864
-		return;
1964
+	if (!$initialize) {
1965
+			return;
1966
+	}
1865 1967
 
1866 1968
 	// Check to see if we're forcing SSL
1867 1969
 	if (!empty($modSettings['force_ssl']) && empty($maintenance) &&
@@ -1882,8 +1984,9 @@  discard block
 block discarded – undo
1882 1984
 		$detected_url = httpsOn() ? 'https://' : 'http://';
1883 1985
 		$detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST'];
1884 1986
 		$temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/'));
1885
-		if ($temp != '/')
1886
-			$detected_url .= $temp;
1987
+		if ($temp != '/') {
1988
+					$detected_url .= $temp;
1989
+		}
1887 1990
 	}
1888 1991
 	if (isset($detected_url) && $detected_url != $boardurl)
1889 1992
 	{
@@ -1895,8 +1998,9 @@  discard block
 block discarded – undo
1895 1998
 			foreach ($aliases as $alias)
1896 1999
 			{
1897 2000
 				// Rip off all the boring parts, spaces, etc.
1898
-				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias))
1899
-					$do_fix = true;
2001
+				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) {
2002
+									$do_fix = true;
2003
+				}
1900 2004
 			}
1901 2005
 		}
1902 2006
 
@@ -1904,21 +2008,23 @@  discard block
 block discarded – undo
1904 2008
 		if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI')
1905 2009
 		{
1906 2010
 			// Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;).
1907
-			if (empty($_GET))
1908
-				redirectexit('wwwRedirect');
1909
-			else
2011
+			if (empty($_GET)) {
2012
+							redirectexit('wwwRedirect');
2013
+			} else
1910 2014
 			{
1911 2015
 				$k = key($_GET);
1912 2016
 				$v = current($_GET);
1913 2017
 
1914
-				if ($k != 'wwwRedirect')
1915
-					redirectexit('wwwRedirect;' . $k . '=' . $v);
2018
+				if ($k != 'wwwRedirect') {
2019
+									redirectexit('wwwRedirect;' . $k . '=' . $v);
2020
+				}
1916 2021
 			}
1917 2022
 		}
1918 2023
 
1919 2024
 		// #3 is just a check for SSL...
1920
-		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl)
1921
-			$do_fix = true;
2025
+		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) {
2026
+					$do_fix = true;
2027
+		}
1922 2028
 
1923 2029
 		// Okay, #4 - perhaps it's an IP address?  We're gonna want to use that one, then. (assuming it's the IP or something...)
1924 2030
 		if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1)
@@ -1953,8 +2059,9 @@  discard block
 block discarded – undo
1953 2059
 					$board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl));
1954 2060
 				}
1955 2061
 			}
1956
-			foreach ($context['linktree'] as $k => $dummy)
1957
-				$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2062
+			foreach ($context['linktree'] as $k => $dummy) {
2063
+							$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2064
+			}
1958 2065
 		}
1959 2066
 	}
1960 2067
 	// Set up the contextual user array.
@@ -1973,10 +2080,11 @@  discard block
 block discarded – undo
1973 2080
 			'email' => $user_info['email'],
1974 2081
 			'ignoreusers' => $user_info['ignoreusers'],
1975 2082
 		);
1976
-		if (!$context['user']['is_guest'])
1977
-			$context['user']['name'] = $user_info['name'];
1978
-		elseif ($context['user']['is_guest'] && !empty($txt['guest_title']))
1979
-			$context['user']['name'] = $txt['guest_title'];
2083
+		if (!$context['user']['is_guest']) {
2084
+					$context['user']['name'] = $user_info['name'];
2085
+		} elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) {
2086
+					$context['user']['name'] = $txt['guest_title'];
2087
+		}
1980 2088
 
1981 2089
 		// Determine the current smiley set.
1982 2090
 		$smiley_sets_known = explode(',', $modSettings['smiley_sets_known']);
@@ -1990,8 +2098,7 @@  discard block
 block discarded – undo
1990 2098
 
1991 2099
 		// Determine global default smiley set extension
1992 2100
 		$context['user']['smiley_set_default_ext'] = $smiley_sets_exts[array_search($modSettings['smiley_sets_default'], $smiley_sets_known)];
1993
-	}
1994
-	else
2101
+	} else
1995 2102
 	{
1996 2103
 		// What to do when there is no $user_info (e.g., an error very early in the login process)
1997 2104
 		$context['user'] = array(
@@ -2025,18 +2132,24 @@  discard block
 block discarded – undo
2025 2132
 	}
2026 2133
 
2027 2134
 	// Some basic information...
2028
-	if (!isset($context['html_headers']))
2029
-		$context['html_headers'] = '';
2030
-	if (!isset($context['javascript_files']))
2031
-		$context['javascript_files'] = array();
2032
-	if (!isset($context['css_files']))
2033
-		$context['css_files'] = array();
2034
-	if (!isset($context['css_header']))
2035
-		$context['css_header'] = array();
2036
-	if (!isset($context['javascript_inline']))
2037
-		$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
2038
-	if (!isset($context['javascript_vars']))
2039
-		$context['javascript_vars'] = array();
2135
+	if (!isset($context['html_headers'])) {
2136
+			$context['html_headers'] = '';
2137
+	}
2138
+	if (!isset($context['javascript_files'])) {
2139
+			$context['javascript_files'] = array();
2140
+	}
2141
+	if (!isset($context['css_files'])) {
2142
+			$context['css_files'] = array();
2143
+	}
2144
+	if (!isset($context['css_header'])) {
2145
+			$context['css_header'] = array();
2146
+	}
2147
+	if (!isset($context['javascript_inline'])) {
2148
+			$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
2149
+	}
2150
+	if (!isset($context['javascript_vars'])) {
2151
+			$context['javascript_vars'] = array();
2152
+	}
2040 2153
 
2041 2154
 	$context['login_url'] =  $scripturl . '?action=login2';
2042 2155
 	$context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | ';
@@ -2048,16 +2161,18 @@  discard block
 block discarded – undo
2048 2161
 	$context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null;
2049 2162
 	$context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null;
2050 2163
 	$context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3;
2051
-	if (isset($modSettings['load_average']))
2052
-		$context['load_average'] = $modSettings['load_average'];
2164
+	if (isset($modSettings['load_average'])) {
2165
+			$context['load_average'] = $modSettings['load_average'];
2166
+	}
2053 2167
 
2054 2168
 	// Detect the browser. This is separated out because it's also used in attachment downloads
2055 2169
 	detectBrowser();
2056 2170
 
2057 2171
 	// Set the top level linktree up.
2058 2172
 	// Note that if we're dealing with certain very early errors (e.g., login) the linktree might not be set yet...
2059
-	if (empty($context['linktree']))
2060
-		$context['linktree'] = array();
2173
+	if (empty($context['linktree'])) {
2174
+			$context['linktree'] = array();
2175
+	}
2061 2176
 	array_unshift($context['linktree'], array(
2062 2177
 		'url' => $scripturl,
2063 2178
 		'name' => $context['forum_name_html_safe']
@@ -2066,8 +2181,9 @@  discard block
 block discarded – undo
2066 2181
 	// This allows sticking some HTML on the page output - useful for controls.
2067 2182
 	$context['insert_after_template'] = '';
2068 2183
 
2069
-	if (!isset($txt))
2070
-		$txt = array();
2184
+	if (!isset($txt)) {
2185
+			$txt = array();
2186
+	}
2071 2187
 
2072 2188
 	$simpleActions = array(
2073 2189
 		'findmember',
@@ -2113,9 +2229,10 @@  discard block
 block discarded – undo
2113 2229
 
2114 2230
 	// See if theres any extra param to check.
2115 2231
 	$requiresXML = false;
2116
-	foreach ($extraParams as $key => $extra)
2117
-		if (isset($_REQUEST[$extra]))
2232
+	foreach ($extraParams as $key => $extra) {
2233
+			if (isset($_REQUEST[$extra]))
2118 2234
 			$requiresXML = true;
2235
+	}
2119 2236
 
2120 2237
 	// Output is fully XML, so no need for the index template.
2121 2238
 	if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML))
@@ -2130,37 +2247,39 @@  discard block
 block discarded – undo
2130 2247
 	{
2131 2248
 		loadLanguage('index+Modifications');
2132 2249
 		$context['template_layers'] = array();
2133
-	}
2134
-
2135
-	else
2250
+	} else
2136 2251
 	{
2137 2252
 		// Custom templates to load, or just default?
2138
-		if (isset($settings['theme_templates']))
2139
-			$templates = explode(',', $settings['theme_templates']);
2140
-		else
2141
-			$templates = array('index');
2253
+		if (isset($settings['theme_templates'])) {
2254
+					$templates = explode(',', $settings['theme_templates']);
2255
+		} else {
2256
+					$templates = array('index');
2257
+		}
2142 2258
 
2143 2259
 		// Load each template...
2144
-		foreach ($templates as $template)
2145
-			loadTemplate($template);
2260
+		foreach ($templates as $template) {
2261
+					loadTemplate($template);
2262
+		}
2146 2263
 
2147 2264
 		// ...and attempt to load their associated language files.
2148 2265
 		$required_files = implode('+', array_merge($templates, array('Modifications')));
2149 2266
 		loadLanguage($required_files, '', false);
2150 2267
 
2151 2268
 		// Custom template layers?
2152
-		if (isset($settings['theme_layers']))
2153
-			$context['template_layers'] = explode(',', $settings['theme_layers']);
2154
-		else
2155
-			$context['template_layers'] = array('html', 'body');
2269
+		if (isset($settings['theme_layers'])) {
2270
+					$context['template_layers'] = explode(',', $settings['theme_layers']);
2271
+		} else {
2272
+					$context['template_layers'] = array('html', 'body');
2273
+		}
2156 2274
 	}
2157 2275
 
2158 2276
 	// Initialize the theme.
2159 2277
 	loadSubTemplate('init', 'ignore');
2160 2278
 
2161 2279
 	// Allow overriding the board wide time/number formats.
2162
-	if (empty($user_settings['time_format']) && !empty($txt['time_format']))
2163
-		$user_info['time_format'] = $txt['time_format'];
2280
+	if (empty($user_settings['time_format']) && !empty($txt['time_format'])) {
2281
+			$user_info['time_format'] = $txt['time_format'];
2282
+	}
2164 2283
 
2165 2284
 	// Set the character set from the template.
2166 2285
 	$context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set'];
@@ -2168,12 +2287,14 @@  discard block
 block discarded – undo
2168 2287
 	$context['right_to_left'] = !empty($txt['lang_rtl']);
2169 2288
 
2170 2289
 	// Guests may still need a name.
2171
-	if ($context['user']['is_guest'] && empty($context['user']['name']))
2172
-		$context['user']['name'] = $txt['guest_title'];
2290
+	if ($context['user']['is_guest'] && empty($context['user']['name'])) {
2291
+			$context['user']['name'] = $txt['guest_title'];
2292
+	}
2173 2293
 
2174 2294
 	// Any theme-related strings that need to be loaded?
2175
-	if (!empty($settings['require_theme_strings']))
2176
-		loadLanguage('ThemeStrings', '', false);
2295
+	if (!empty($settings['require_theme_strings'])) {
2296
+			loadLanguage('ThemeStrings', '', false);
2297
+	}
2177 2298
 
2178 2299
 	// Make a special URL for the language.
2179 2300
 	$settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']);
@@ -2184,8 +2305,9 @@  discard block
 block discarded – undo
2184 2305
 	// Here is my luvly Responsive CSS
2185 2306
 	loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true, 'order_pos' => 9000), 'smf_responsive');
2186 2307
 
2187
-	if ($context['right_to_left'])
2188
-		loadCSSFile('rtl.css', array('order_pos' => 200), 'smf_rtl');
2308
+	if ($context['right_to_left']) {
2309
+			loadCSSFile('rtl.css', array('order_pos' => 200), 'smf_rtl');
2310
+	}
2189 2311
 
2190 2312
 	// We allow theme variants, because we're cool.
2191 2313
 	$context['theme_variant'] = '';
@@ -2193,14 +2315,17 @@  discard block
 block discarded – undo
2193 2315
 	if (!empty($settings['theme_variants']))
2194 2316
 	{
2195 2317
 		// Overriding - for previews and that ilk.
2196
-		if (!empty($_REQUEST['variant']))
2197
-			$_SESSION['id_variant'] = $_REQUEST['variant'];
2318
+		if (!empty($_REQUEST['variant'])) {
2319
+					$_SESSION['id_variant'] = $_REQUEST['variant'];
2320
+		}
2198 2321
 		// User selection?
2199
-		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum'))
2200
-			$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2322
+		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) {
2323
+					$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2324
+		}
2201 2325
 		// If not a user variant, select the default.
2202
-		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants']))
2203
-			$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2326
+		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) {
2327
+					$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2328
+		}
2204 2329
 
2205 2330
 		// Do this to keep things easier in the templates.
2206 2331
 		$context['theme_variant'] = '_' . $context['theme_variant'];
@@ -2209,20 +2334,23 @@  discard block
 block discarded – undo
2209 2334
 		if (!empty($context['theme_variant']))
2210 2335
 		{
2211 2336
 			loadCSSFile('index' . $context['theme_variant'] . '.css', array('order_pos' => 300), 'smf_index' . $context['theme_variant']);
2212
-			if ($context['right_to_left'])
2213
-				loadCSSFile('rtl' . $context['theme_variant'] . '.css', array('order_pos' => 400), 'smf_rtl' . $context['theme_variant']);
2337
+			if ($context['right_to_left']) {
2338
+							loadCSSFile('rtl' . $context['theme_variant'] . '.css', array('order_pos' => 400), 'smf_rtl' . $context['theme_variant']);
2339
+			}
2214 2340
 		}
2215 2341
 	}
2216 2342
 
2217 2343
 	// Let's be compatible with old themes!
2218
-	if (!function_exists('template_html_above') && in_array('html', $context['template_layers']))
2219
-		$context['template_layers'] = array('main');
2344
+	if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) {
2345
+			$context['template_layers'] = array('main');
2346
+	}
2220 2347
 
2221 2348
 	$context['tabindex'] = 1;
2222 2349
 
2223 2350
 	// Compatibility.
2224
-	if (!isset($settings['theme_version']))
2225
-		$modSettings['memberCount'] = $modSettings['totalMembers'];
2351
+	if (!isset($settings['theme_version'])) {
2352
+			$modSettings['memberCount'] = $modSettings['totalMembers'];
2353
+	}
2226 2354
 
2227 2355
 	// Default JS variables for use in every theme
2228 2356
 	$context['javascript_vars'] = array(
@@ -2245,18 +2373,18 @@  discard block
 block discarded – undo
2245 2373
 	);
2246 2374
 
2247 2375
 	// Add the JQuery library to the list of files to load.
2248
-	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn')
2249
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2250
-
2251
-	elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local')
2252
-		loadJavaScriptFile('jquery-3.2.1.min.js', array('seed' => false), 'smf_jquery');
2253
-
2254
-	elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom')
2255
-		loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2376
+	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') {
2377
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2378
+	} elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') {
2379
+			loadJavaScriptFile('jquery-3.2.1.min.js', array('seed' => false), 'smf_jquery');
2380
+	} elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') {
2381
+			loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2382
+	}
2256 2383
 
2257 2384
 	// Auto loading? template_javascript() will take care of the local half of this.
2258
-	else
2259
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2385
+	else {
2386
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2387
+	}
2260 2388
 
2261 2389
 	// Queue our JQuery plugins!
2262 2390
 	loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins');
@@ -2279,12 +2407,12 @@  discard block
 block discarded – undo
2279 2407
 			require_once($sourcedir . '/ScheduledTasks.php');
2280 2408
 
2281 2409
 			// What to do, what to do?!
2282
-			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time())
2283
-				AutoTask();
2284
-			else
2285
-				ReduceMailQueue();
2286
-		}
2287
-		else
2410
+			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) {
2411
+							AutoTask();
2412
+			} else {
2413
+							ReduceMailQueue();
2414
+			}
2415
+		} else
2288 2416
 		{
2289 2417
 			$type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq';
2290 2418
 			$ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time'];
@@ -2335,8 +2463,9 @@  discard block
 block discarded – undo
2335 2463
 		foreach ($theme_includes as $include)
2336 2464
 		{
2337 2465
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
2338
-			if (file_exists($include))
2339
-				require_once($include);
2466
+			if (file_exists($include)) {
2467
+							require_once($include);
2468
+			}
2340 2469
 		}
2341 2470
 	}
2342 2471
 
@@ -2366,16 +2495,19 @@  discard block
 block discarded – undo
2366 2495
 	// Do any style sheets first, cause we're easy with those.
2367 2496
 	if (!empty($style_sheets))
2368 2497
 	{
2369
-		if (!is_array($style_sheets))
2370
-			$style_sheets = array($style_sheets);
2498
+		if (!is_array($style_sheets)) {
2499
+					$style_sheets = array($style_sheets);
2500
+		}
2371 2501
 
2372
-		foreach ($style_sheets as $sheet)
2373
-			loadCSSFile($sheet . '.css', array(), $sheet);
2502
+		foreach ($style_sheets as $sheet) {
2503
+					loadCSSFile($sheet . '.css', array(), $sheet);
2504
+		}
2374 2505
 	}
2375 2506
 
2376 2507
 	// No template to load?
2377
-	if ($template_name === false)
2378
-		return true;
2508
+	if ($template_name === false) {
2509
+			return true;
2510
+	}
2379 2511
 
2380 2512
 	$loaded = false;
2381 2513
 	foreach ($settings['template_dirs'] as $template_dir)
@@ -2390,12 +2522,14 @@  discard block
 block discarded – undo
2390 2522
 
2391 2523
 	if ($loaded)
2392 2524
 	{
2393
-		if ($db_show_debug === true)
2394
-			$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2525
+		if ($db_show_debug === true) {
2526
+					$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2527
+		}
2395 2528
 
2396 2529
 		// If they have specified an initialization function for this template, go ahead and call it now.
2397
-		if (function_exists('template_' . $template_name . '_init'))
2398
-			call_user_func('template_' . $template_name . '_init');
2530
+		if (function_exists('template_' . $template_name . '_init')) {
2531
+					call_user_func('template_' . $template_name . '_init');
2532
+		}
2399 2533
 	}
2400 2534
 	// Hmmm... doesn't exist?!  I don't suppose the directory is wrong, is it?
2401 2535
 	elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default'))
@@ -2415,13 +2549,14 @@  discard block
 block discarded – undo
2415 2549
 		loadTemplate($template_name);
2416 2550
 	}
2417 2551
 	// Cause an error otherwise.
2418
-	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal)
2419
-		fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2420
-	elseif ($fatal)
2421
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2422
-	else
2423
-		return false;
2424
-}
2552
+	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) {
2553
+			fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2554
+	} elseif ($fatal) {
2555
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2556
+	} else {
2557
+			return false;
2558
+	}
2559
+	}
2425 2560
 
2426 2561
 /**
2427 2562
  * Load a sub-template.
@@ -2439,17 +2574,19 @@  discard block
 block discarded – undo
2439 2574
 {
2440 2575
 	global $context, $txt, $db_show_debug;
2441 2576
 
2442
-	if ($db_show_debug === true)
2443
-		$context['debug']['sub_templates'][] = $sub_template_name;
2577
+	if ($db_show_debug === true) {
2578
+			$context['debug']['sub_templates'][] = $sub_template_name;
2579
+	}
2444 2580
 
2445 2581
 	// Figure out what the template function is named.
2446 2582
 	$theme_function = 'template_' . $sub_template_name;
2447
-	if (function_exists($theme_function))
2448
-		$theme_function();
2449
-	elseif ($fatal === false)
2450
-		fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2451
-	elseif ($fatal !== 'ignore')
2452
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2583
+	if (function_exists($theme_function)) {
2584
+			$theme_function();
2585
+	} elseif ($fatal === false) {
2586
+			fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2587
+	} elseif ($fatal !== 'ignore') {
2588
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2589
+	}
2453 2590
 
2454 2591
 	// Are we showing debugging for templates?  Just make sure not to do it before the doctype...
2455 2592
 	if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml']))
@@ -2479,8 +2616,9 @@  discard block
 block discarded – undo
2479 2616
 {
2480 2617
 	global $settings, $context, $modSettings;
2481 2618
 
2482
-	if (empty($context['css_files_order']))
2483
-		$context['css_files_order'] = array();
2619
+	if (empty($context['css_files_order'])) {
2620
+			$context['css_files_order'] = array();
2621
+	}
2484 2622
 
2485 2623
 	$params['seed'] = (!array_key_exists('seed', $params) || (array_key_exists('seed', $params) && $params['seed'] === true)) ? (array_key_exists('browser_cache', $modSettings) ? $modSettings['browser_cache'] : '') : (is_string($params['seed']) ? ($params['seed'] = $params['seed'][0] === '?' ? $params['seed'] : '?' . $params['seed']) : '');
2486 2624
 	$params['force_current'] = isset($params['force_current']) ? $params['force_current'] : false;
@@ -2491,8 +2629,9 @@  discard block
 block discarded – undo
2491 2629
 	$params['order_pos'] = isset($params['order_pos']) ? (int) $params['order_pos'] : 3000;
2492 2630
 
2493 2631
 	// If this is an external file, automatically set this to false.
2494
-	if (!empty($params['external']))
2495
-		$params['minimize'] = false;
2632
+	if (!empty($params['external'])) {
2633
+			$params['minimize'] = false;
2634
+	}
2496 2635
 
2497 2636
 	// Account for shorthand like admin.css?alp21 filenames
2498 2637
 	$has_seed = strpos($fileName, '.css?');
@@ -2509,16 +2648,12 @@  discard block
 block discarded – undo
2509 2648
 			{
2510 2649
 				$fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2511 2650
 				$filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2512
-			}
2513
-
2514
-			else
2651
+			} else
2515 2652
 			{
2516 2653
 				$fileUrl = false;
2517 2654
 				$filePath = false;
2518 2655
 			}
2519
-		}
2520
-
2521
-		else
2656
+		} else
2522 2657
 		{
2523 2658
 			$fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2524 2659
 			$filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2536,16 +2671,18 @@  discard block
 block discarded – undo
2536 2671
 	if (!empty($fileName))
2537 2672
 	{
2538 2673
 		// find a free number/position
2539
-		while (isset($context['css_files_order'][$params['order_pos']]))
2540
-			$params['order_pos']++;
2674
+		while (isset($context['css_files_order'][$params['order_pos']])) {
2675
+					$params['order_pos']++;
2676
+		}
2541 2677
 		$context['css_files_order'][$params['order_pos']] = $id;
2542 2678
 
2543 2679
 		$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2544 2680
 	}
2545 2681
 
2546
-	if (!empty($context['right_to_left']) && !empty($params['rtl']))
2547
-		loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2548
-}
2682
+	if (!empty($context['right_to_left']) && !empty($params['rtl'])) {
2683
+			loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2684
+	}
2685
+	}
2549 2686
 
2550 2687
 /**
2551 2688
  * Add a block of inline css code to be executed later
@@ -2562,8 +2699,9 @@  discard block
 block discarded – undo
2562 2699
 	global $context;
2563 2700
 
2564 2701
 	// Gotta add something...
2565
-	if (empty($css))
2566
-		return false;
2702
+	if (empty($css)) {
2703
+			return false;
2704
+	}
2567 2705
 
2568 2706
 	$context['css_header'][] = $css;
2569 2707
 }
@@ -2599,8 +2737,9 @@  discard block
 block discarded – undo
2599 2737
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2600 2738
 
2601 2739
 	// If this is an external file, automatically set this to false.
2602
-	if (!empty($params['external']))
2603
-		$params['minimize'] = false;
2740
+	if (!empty($params['external'])) {
2741
+			$params['minimize'] = false;
2742
+	}
2604 2743
 
2605 2744
 	// Account for shorthand like admin.js?alp21 filenames
2606 2745
 	$has_seed = strpos($fileName, '.js?');
@@ -2617,16 +2756,12 @@  discard block
 block discarded – undo
2617 2756
 			{
2618 2757
 				$fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2619 2758
 				$filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2620
-			}
2621
-
2622
-			else
2759
+			} else
2623 2760
 			{
2624 2761
 				$fileUrl = false;
2625 2762
 				$filePath = false;
2626 2763
 			}
2627
-		}
2628
-
2629
-		else
2764
+		} else
2630 2765
 		{
2631 2766
 			$fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2632 2767
 			$filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2641,9 +2776,10 @@  discard block
 block discarded – undo
2641 2776
 	}
2642 2777
 
2643 2778
 	// Add it to the array for use in the template
2644
-	if (!empty($fileName))
2645
-		$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2646
-}
2779
+	if (!empty($fileName)) {
2780
+			$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2781
+	}
2782
+	}
2647 2783
 
2648 2784
 /**
2649 2785
  * Add a Javascript variable for output later (for feeding text strings and similar to JS)
@@ -2657,9 +2793,10 @@  discard block
 block discarded – undo
2657 2793
 {
2658 2794
 	global $context;
2659 2795
 
2660
-	if (!empty($key) && (!empty($value) || $value === '0'))
2661
-		$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2662
-}
2796
+	if (!empty($key) && (!empty($value) || $value === '0')) {
2797
+			$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2798
+	}
2799
+	}
2663 2800
 
2664 2801
 /**
2665 2802
  * Add a block of inline Javascript code to be executed later
@@ -2676,8 +2813,9 @@  discard block
 block discarded – undo
2676 2813
 {
2677 2814
 	global $context;
2678 2815
 
2679
-	if (empty($javascript))
2680
-		return false;
2816
+	if (empty($javascript)) {
2817
+			return false;
2818
+	}
2681 2819
 
2682 2820
 	$context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript;
2683 2821
 }
@@ -2698,15 +2836,18 @@  discard block
 block discarded – undo
2698 2836
 	static $already_loaded = array();
2699 2837
 
2700 2838
 	// Default to the user's language.
2701
-	if ($lang == '')
2702
-		$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2839
+	if ($lang == '') {
2840
+			$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2841
+	}
2703 2842
 
2704 2843
 	// Do we want the English version of language file as fallback?
2705
-	if (empty($modSettings['disable_language_fallback']) && $lang != 'english')
2706
-		loadLanguage($template_name, 'english', false);
2844
+	if (empty($modSettings['disable_language_fallback']) && $lang != 'english') {
2845
+			loadLanguage($template_name, 'english', false);
2846
+	}
2707 2847
 
2708
-	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang)
2709
-		return $lang;
2848
+	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) {
2849
+			return $lang;
2850
+	}
2710 2851
 
2711 2852
 	// Make sure we have $settings - if not we're in trouble and need to find it!
2712 2853
 	if (empty($settings['default_theme_dir']))
@@ -2717,8 +2858,9 @@  discard block
 block discarded – undo
2717 2858
 
2718 2859
 	// What theme are we in?
2719 2860
 	$theme_name = basename($settings['theme_url']);
2720
-	if (empty($theme_name))
2721
-		$theme_name = 'unknown';
2861
+	if (empty($theme_name)) {
2862
+			$theme_name = 'unknown';
2863
+	}
2722 2864
 
2723 2865
 	// For each file open it up and write it out!
2724 2866
 	foreach (explode('+', $template_name) as $template)
@@ -2760,8 +2902,9 @@  discard block
 block discarded – undo
2760 2902
 				$found = true;
2761 2903
 
2762 2904
 				// setlocale is required for basename() & pathinfo() to work properly on the selected language
2763
-				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set']))
2764
-					setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2905
+				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) {
2906
+									setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2907
+				}
2765 2908
 
2766 2909
 				break;
2767 2910
 			}
@@ -2801,8 +2944,9 @@  discard block
 block discarded – undo
2801 2944
 	}
2802 2945
 
2803 2946
 	// Keep track of what we're up to soldier.
2804
-	if ($db_show_debug === true)
2805
-		$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2947
+	if ($db_show_debug === true) {
2948
+			$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2949
+	}
2806 2950
 
2807 2951
 	// Remember what we have loaded, and in which language.
2808 2952
 	$already_loaded[$template_name] = $lang;
@@ -2848,8 +2992,9 @@  discard block
 block discarded – undo
2848 2992
 				)
2849 2993
 			);
2850 2994
 			// In the EXTREMELY unlikely event this happens, give an error message.
2851
-			if ($smcFunc['db_num_rows']($result) == 0)
2852
-				fatal_lang_error('parent_not_found', 'critical');
2995
+			if ($smcFunc['db_num_rows']($result) == 0) {
2996
+							fatal_lang_error('parent_not_found', 'critical');
2997
+			}
2853 2998
 			while ($row = $smcFunc['db_fetch_assoc']($result))
2854 2999
 			{
2855 3000
 				if (!isset($boards[$row['id_board']]))
@@ -2866,8 +3011,8 @@  discard block
 block discarded – undo
2866 3011
 					);
2867 3012
 				}
2868 3013
 				// If a moderator exists for this board, add that moderator for all children too.
2869
-				if (!empty($row['id_moderator']))
2870
-					foreach ($boards as $id => $dummy)
3014
+				if (!empty($row['id_moderator'])) {
3015
+									foreach ($boards as $id => $dummy)
2871 3016
 					{
2872 3017
 						$boards[$id]['moderators'][$row['id_moderator']] = array(
2873 3018
 							'id' => $row['id_moderator'],
@@ -2875,11 +3020,12 @@  discard block
 block discarded – undo
2875 3020
 							'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
2876 3021
 							'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
2877 3022
 						);
3023
+				}
2878 3024
 					}
2879 3025
 
2880 3026
 				// If a moderator group exists for this board, add that moderator group for all children too
2881
-				if (!empty($row['id_moderator_group']))
2882
-					foreach ($boards as $id => $dummy)
3027
+				if (!empty($row['id_moderator_group'])) {
3028
+									foreach ($boards as $id => $dummy)
2883 3029
 					{
2884 3030
 						$boards[$id]['moderator_groups'][$row['id_moderator_group']] = array(
2885 3031
 							'id' => $row['id_moderator_group'],
@@ -2887,6 +3033,7 @@  discard block
 block discarded – undo
2887 3033
 							'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
2888 3034
 							'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
2889 3035
 						);
3036
+				}
2890 3037
 					}
2891 3038
 			}
2892 3039
 			$smcFunc['db_free_result']($result);
@@ -2913,23 +3060,27 @@  discard block
 block discarded – undo
2913 3060
 	if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null)
2914 3061
 	{
2915 3062
 		// If we don't have our ucwords function defined yet, let's load the settings data.
2916
-		if (empty($smcFunc['ucwords']))
2917
-			reloadSettings();
3063
+		if (empty($smcFunc['ucwords'])) {
3064
+					reloadSettings();
3065
+		}
2918 3066
 
2919 3067
 		// If we don't have our theme information yet, let's get it.
2920
-		if (empty($settings['default_theme_dir']))
2921
-			loadTheme(0, false);
3068
+		if (empty($settings['default_theme_dir'])) {
3069
+					loadTheme(0, false);
3070
+		}
2922 3071
 
2923 3072
 		// Default language directories to try.
2924 3073
 		$language_directories = array(
2925 3074
 			$settings['default_theme_dir'] . '/languages',
2926 3075
 		);
2927
-		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir'])
2928
-			$language_directories[] = $settings['actual_theme_dir'] . '/languages';
3076
+		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) {
3077
+					$language_directories[] = $settings['actual_theme_dir'] . '/languages';
3078
+		}
2929 3079
 
2930 3080
 		// We possibly have a base theme directory.
2931
-		if (!empty($settings['base_theme_dir']))
2932
-			$language_directories[] = $settings['base_theme_dir'] . '/languages';
3081
+		if (!empty($settings['base_theme_dir'])) {
3082
+					$language_directories[] = $settings['base_theme_dir'] . '/languages';
3083
+		}
2933 3084
 
2934 3085
 		// Remove any duplicates.
2935 3086
 		$language_directories = array_unique($language_directories);
@@ -2943,20 +3094,21 @@  discard block
 block discarded – undo
2943 3094
 		foreach ($language_directories as $language_dir)
2944 3095
 		{
2945 3096
 			// Can't look in here... doesn't exist!
2946
-			if (!file_exists($language_dir))
2947
-				continue;
3097
+			if (!file_exists($language_dir)) {
3098
+							continue;
3099
+			}
2948 3100
 
2949 3101
 			$dir = dir($language_dir);
2950 3102
 			while ($entry = $dir->read())
2951 3103
 			{
2952 3104
 				// Look for the index language file... For good measure skip any "index.language-utf8.php" files
2953
-				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches))
2954
-					continue;
2955
-
2956
-				if (!empty($langList) && !empty($langList[$matches[1]]))
2957
-					$langName = $langList[$matches[1]];
3105
+				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) {
3106
+									continue;
3107
+				}
2958 3108
 
2959
-				else
3109
+				if (!empty($langList) && !empty($langList[$matches[1]])) {
3110
+									$langName = $langList[$matches[1]];
3111
+				} else
2960 3112
 				{
2961 3113
 					$langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' ')));
2962 3114
 
@@ -2997,12 +3149,14 @@  discard block
 block discarded – undo
2997 3149
 		}
2998 3150
 
2999 3151
 		// Do we need to store the lang list?
3000
-		if (empty($langList))
3001
-			updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3152
+		if (empty($langList)) {
3153
+					updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3154
+		}
3002 3155
 
3003 3156
 		// Let's cash in on this deal.
3004
-		if (!empty($modSettings['cache_enable']))
3005
-			cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3157
+		if (!empty($modSettings['cache_enable'])) {
3158
+					cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3159
+		}
3006 3160
 	}
3007 3161
 
3008 3162
 	return $context['languages'];
@@ -3025,8 +3179,9 @@  discard block
 block discarded – undo
3025 3179
 	global $modSettings, $options, $txt;
3026 3180
 	static $censor_vulgar = null, $censor_proper;
3027 3181
 
3028
-	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '')
3029
-		return $text;
3182
+	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') {
3183
+			return $text;
3184
+	}
3030 3185
 
3031 3186
 	// If they haven't yet been loaded, load them.
3032 3187
 	if ($censor_vulgar == null)
@@ -3057,9 +3212,9 @@  discard block
 block discarded – undo
3057 3212
 	{
3058 3213
 		$func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace';
3059 3214
 		$text = $func($censor_vulgar, $censor_proper, $text);
3215
+	} else {
3216
+			$text = preg_replace($censor_vulgar, $censor_proper, $text);
3060 3217
 	}
3061
-	else
3062
-		$text = preg_replace($censor_vulgar, $censor_proper, $text);
3063 3218
 
3064 3219
 	return $text;
3065 3220
 }
@@ -3085,30 +3240,35 @@  discard block
 block discarded – undo
3085 3240
 	@ini_set('track_errors', '1');
3086 3241
 
3087 3242
 	// Don't include the file more than once, if $once is true.
3088
-	if ($once && in_array($filename, $templates))
3089
-		return;
3243
+	if ($once && in_array($filename, $templates)) {
3244
+			return;
3245
+	}
3090 3246
 	// Add this file to the include list, whether $once is true or not.
3091
-	else
3092
-		$templates[] = $filename;
3247
+	else {
3248
+			$templates[] = $filename;
3249
+	}
3093 3250
 
3094 3251
 
3095 3252
 	$file_found = file_exists($filename);
3096 3253
 
3097
-	if ($once && $file_found)
3098
-		require_once($filename);
3099
-	elseif ($file_found)
3100
-		require($filename);
3254
+	if ($once && $file_found) {
3255
+			require_once($filename);
3256
+	} elseif ($file_found) {
3257
+			require($filename);
3258
+	}
3101 3259
 
3102 3260
 	if ($file_found !== true)
3103 3261
 	{
3104 3262
 		ob_end_clean();
3105
-		if (!empty($modSettings['enableCompressedOutput']))
3106
-			@ob_start('ob_gzhandler');
3107
-		else
3108
-			ob_start();
3263
+		if (!empty($modSettings['enableCompressedOutput'])) {
3264
+					@ob_start('ob_gzhandler');
3265
+		} else {
3266
+					ob_start();
3267
+		}
3109 3268
 
3110
-		if (isset($_GET['debug']))
3111
-			header('content-type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3269
+		if (isset($_GET['debug'])) {
3270
+					header('content-type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3271
+		}
3112 3272
 
3113 3273
 		// Don't cache error pages!!
3114 3274
 		header('expires: Mon, 26 Jul 1997 05:00:00 GMT');
@@ -3127,12 +3287,13 @@  discard block
 block discarded – undo
3127 3287
 		echo '<!DOCTYPE html>
3128 3288
 <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '>
3129 3289
 	<head>';
3130
-		if (isset($context['character_set']))
3131
-			echo '
3290
+		if (isset($context['character_set'])) {
3291
+					echo '
3132 3292
 		<meta charset="', $context['character_set'], '">';
3293
+		}
3133 3294
 
3134
-		if (!empty($maintenance) && !allowedTo('admin_forum'))
3135
-			echo '
3295
+		if (!empty($maintenance) && !allowedTo('admin_forum')) {
3296
+					echo '
3136 3297
 		<title>', $mtitle, '</title>
3137 3298
 	</head>
3138 3299
 	<body>
@@ -3140,8 +3301,8 @@  discard block
 block discarded – undo
3140 3301
 		', $mmessage, '
3141 3302
 	</body>
3142 3303
 </html>';
3143
-		elseif (!allowedTo('admin_forum'))
3144
-			echo '
3304
+		} elseif (!allowedTo('admin_forum')) {
3305
+					echo '
3145 3306
 		<title>', $txt['template_parse_error'], '</title>
3146 3307
 	</head>
3147 3308
 	<body>
@@ -3149,14 +3310,16 @@  discard block
 block discarded – undo
3149 3310
 		', $txt['template_parse_error_message'], '
3150 3311
 	</body>
3151 3312
 </html>';
3152
-		else
3313
+		} else
3153 3314
 		{
3154 3315
 			$error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3155 3316
 			$error_array = error_get_last();
3156
-			if (empty($error) && ini_get('track_errors') && !empty($error_array))
3157
-				$error = $error_array['message'];
3158
-			if (empty($error))
3159
-				$error = $txt['template_parse_errmsg'];
3317
+			if (empty($error) && ini_get('track_errors') && !empty($error_array)) {
3318
+							$error = $error_array['message'];
3319
+			}
3320
+			if (empty($error)) {
3321
+							$error = $txt['template_parse_errmsg'];
3322
+			}
3160 3323
 
3161 3324
 			$error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>'));
3162 3325
 
@@ -3167,11 +3330,12 @@  discard block
 block discarded – undo
3167 3330
 		<h3>', $txt['template_parse_error'], '</h3>
3168 3331
 		', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3169 3332
 
3170
-			if (!empty($error))
3171
-				echo '
3333
+			if (!empty($error)) {
3334
+							echo '
3172 3335
 		<hr>
3173 3336
 
3174 3337
 		<div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>';
3338
+			}
3175 3339
 
3176 3340
 			// I know, I know... this is VERY COMPLICATED.  Still, it's good.
3177 3341
 			if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0)
@@ -3181,10 +3345,11 @@  discard block
 block discarded – undo
3181 3345
 				$data2 = preg_split('~\<br( /)?\>~', $data2);
3182 3346
 
3183 3347
 				// Fix the PHP code stuff...
3184
-				if (!isBrowser('gecko'))
3185
-					$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3186
-				else
3187
-					$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3348
+				if (!isBrowser('gecko')) {
3349
+									$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3350
+				} else {
3351
+									$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3352
+				}
3188 3353
 
3189 3354
 				// Now we get to work around a bug in PHP where it doesn't escape <br>s!
3190 3355
 				$j = -1;
@@ -3192,8 +3357,9 @@  discard block
 block discarded – undo
3192 3357
 				{
3193 3358
 					$j++;
3194 3359
 
3195
-					if (substr_count($line, '<br>') == 0)
3196
-						continue;
3360
+					if (substr_count($line, '<br>') == 0) {
3361
+											continue;
3362
+					}
3197 3363
 
3198 3364
 					$n = substr_count($line, '<br>');
3199 3365
 					for ($i = 0; $i < $n; $i++)
@@ -3212,38 +3378,42 @@  discard block
 block discarded – undo
3212 3378
 				// Figure out what the color coding was before...
3213 3379
 				$line = max($match[1] - 9, 1);
3214 3380
 				$last_line = '';
3215
-				for ($line2 = $line - 1; $line2 > 1; $line2--)
3216
-					if (strpos($data2[$line2], '<') !== false)
3381
+				for ($line2 = $line - 1; $line2 > 1; $line2--) {
3382
+									if (strpos($data2[$line2], '<') !== false)
3217 3383
 					{
3218 3384
 						if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0)
3219 3385
 							$last_line = $color_match[1];
3386
+				}
3220 3387
 						break;
3221 3388
 					}
3222 3389
 
3223 3390
 				// Show the relevant lines...
3224 3391
 				for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++)
3225 3392
 				{
3226
-					if ($line == $match[1])
3227
-						echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3393
+					if ($line == $match[1]) {
3394
+											echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3395
+					}
3228 3396
 
3229 3397
 					echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> ';
3230
-					if (isset($data2[$line]) && $data2[$line] != '')
3231
-						echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3398
+					if (isset($data2[$line]) && $data2[$line] != '') {
3399
+											echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3400
+					}
3232 3401
 
3233 3402
 					if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0)
3234 3403
 					{
3235 3404
 						$last_line = $color_match[1];
3236 3405
 						echo '</', substr($last_line, 1, 4), '>';
3406
+					} elseif ($last_line != '' && strpos($data2[$line], '<') !== false) {
3407
+											$last_line = '';
3408
+					} elseif ($last_line != '' && $data2[$line] != '') {
3409
+											echo '</', substr($last_line, 1, 4), '>';
3237 3410
 					}
3238
-					elseif ($last_line != '' && strpos($data2[$line], '<') !== false)
3239
-						$last_line = '';
3240
-					elseif ($last_line != '' && $data2[$line] != '')
3241
-						echo '</', substr($last_line, 1, 4), '>';
3242 3411
 
3243
-					if ($line == $match[1])
3244
-						echo '</pre></div><pre style="margin: 0;">';
3245
-					else
3246
-						echo "\n";
3412
+					if ($line == $match[1]) {
3413
+											echo '</pre></div><pre style="margin: 0;">';
3414
+					} else {
3415
+											echo "\n";
3416
+					}
3247 3417
 				}
3248 3418
 
3249 3419
 				echo '</pre></div>';
@@ -3267,8 +3437,9 @@  discard block
 block discarded – undo
3267 3437
 	global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port, $db_mb4;
3268 3438
 
3269 3439
 	// Figure out what type of database we are using.
3270
-	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
3271
-		$db_type = 'mysql';
3440
+	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) {
3441
+			$db_type = 'mysql';
3442
+	}
3272 3443
 
3273 3444
 	// Load the file for the database.
3274 3445
 	require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
@@ -3276,11 +3447,13 @@  discard block
 block discarded – undo
3276 3447
 	$db_options = array();
3277 3448
 
3278 3449
 	// Add in the port if needed
3279
-	if (!empty($db_port))
3280
-		$db_options['port'] = $db_port;
3450
+	if (!empty($db_port)) {
3451
+			$db_options['port'] = $db_port;
3452
+	}
3281 3453
 
3282
-	if (!empty($db_mb4))
3283
-		$db_options['db_mb4'] = $db_mb4;
3454
+	if (!empty($db_mb4)) {
3455
+			$db_options['db_mb4'] = $db_mb4;
3456
+	}
3284 3457
 
3285 3458
 	// If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use.
3286 3459
 	if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd))
@@ -3299,13 +3472,15 @@  discard block
 block discarded – undo
3299 3472
 	}
3300 3473
 
3301 3474
 	// Safe guard here, if there isn't a valid connection lets put a stop to it.
3302
-	if (!$db_connection)
3303
-		display_db_error();
3475
+	if (!$db_connection) {
3476
+			display_db_error();
3477
+	}
3304 3478
 
3305 3479
 	// If in SSI mode fix up the prefix.
3306
-	if (SMF == 'SSI')
3307
-		db_fix_prefix($db_prefix, $db_name);
3308
-}
3480
+	if (SMF == 'SSI') {
3481
+			db_fix_prefix($db_prefix, $db_name);
3482
+	}
3483
+	}
3309 3484
 
3310 3485
 /**
3311 3486
  * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it.
@@ -3319,14 +3494,16 @@  discard block
 block discarded – undo
3319 3494
 	global $sourcedir, $cacheAPI, $cache_accelerator, $cache_enable;
3320 3495
 
3321 3496
 	// is caching enabled?
3322
-	if (empty($cache_enable))
3323
-		return false;
3497
+	if (empty($cache_enable)) {
3498
+			return false;
3499
+	}
3324 3500
 
3325 3501
 	// Not overriding this and we have a cacheAPI, send it back.
3326
-	if (empty($overrideCache) && is_object($cacheAPI))
3327
-		return $cacheAPI;
3328
-	elseif (is_null($cacheAPI))
3329
-		$cacheAPI = false;
3502
+	if (empty($overrideCache) && is_object($cacheAPI)) {
3503
+			return $cacheAPI;
3504
+	} elseif (is_null($cacheAPI)) {
3505
+			$cacheAPI = false;
3506
+	}
3330 3507
 
3331 3508
 	// Make sure our class is in session.
3332 3509
 	require_once($sourcedir . '/Class-CacheAPI.php');
@@ -3347,8 +3524,9 @@  discard block
 block discarded – undo
3347 3524
 		if (!$testAPI->isSupported())
3348 3525
 		{
3349 3526
 			// Can we save ourselves?
3350
-			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf')
3351
-				return loadCacheAccelerator(null, false);
3527
+			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') {
3528
+							return loadCacheAccelerator(null, false);
3529
+			}
3352 3530
 			return false;
3353 3531
 		}
3354 3532
 
@@ -3360,9 +3538,9 @@  discard block
 block discarded – undo
3360 3538
 		{
3361 3539
 			$cacheAPI = $testAPI;
3362 3540
 			return $cacheAPI;
3541
+		} else {
3542
+					return $testAPI;
3363 3543
 		}
3364
-		else
3365
-			return $testAPI;
3366 3544
 	}
3367 3545
 }
3368 3546
 
@@ -3382,8 +3560,9 @@  discard block
 block discarded – undo
3382 3560
 
3383 3561
 	// @todo Why are we doing this if caching is disabled?
3384 3562
 
3385
-	if (function_exists('call_integration_hook'))
3386
-		call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3563
+	if (function_exists('call_integration_hook')) {
3564
+			call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3565
+	}
3387 3566
 
3388 3567
 	/* Refresh the cache if either:
3389 3568
 		1. Caching is disabled.
@@ -3397,16 +3576,19 @@  discard block
 block discarded – undo
3397 3576
 		require_once($sourcedir . '/' . $file);
3398 3577
 		$cache_block = call_user_func_array($function, $params);
3399 3578
 
3400
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level)
3401
-			cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3579
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) {
3580
+					cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3581
+		}
3402 3582
 	}
3403 3583
 
3404 3584
 	// Some cached data may need a freshening up after retrieval.
3405
-	if (!empty($cache_block['post_retri_eval']))
3406
-		eval($cache_block['post_retri_eval']);
3585
+	if (!empty($cache_block['post_retri_eval'])) {
3586
+			eval($cache_block['post_retri_eval']);
3587
+	}
3407 3588
 
3408
-	if (function_exists('call_integration_hook'))
3409
-		call_integration_hook('post_cache_quick_get', array(&$cache_block));
3589
+	if (function_exists('call_integration_hook')) {
3590
+			call_integration_hook('post_cache_quick_get', array(&$cache_block));
3591
+	}
3410 3592
 
3411 3593
 	return $cache_block['data'];
3412 3594
 }
@@ -3433,8 +3615,9 @@  discard block
 block discarded – undo
3433 3615
 	global $smcFunc, $cache_enable, $cacheAPI;
3434 3616
 	global $cache_hits, $cache_count, $db_show_debug;
3435 3617
 
3436
-	if (empty($cache_enable) || empty($cacheAPI))
3437
-		return;
3618
+	if (empty($cache_enable) || empty($cacheAPI)) {
3619
+			return;
3620
+	}
3438 3621
 
3439 3622
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3440 3623
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3447,12 +3630,14 @@  discard block
 block discarded – undo
3447 3630
 	$value = $value === null ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_encode']($value) : json_encode($value));
3448 3631
 	$cacheAPI->putData($key, $value, $ttl);
3449 3632
 
3450
-	if (function_exists('call_integration_hook'))
3451
-		call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3633
+	if (function_exists('call_integration_hook')) {
3634
+			call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3635
+	}
3452 3636
 
3453
-	if (isset($db_show_debug) && $db_show_debug === true)
3454
-		$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3455
-}
3637
+	if (isset($db_show_debug) && $db_show_debug === true) {
3638
+			$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3639
+	}
3640
+	}
3456 3641
 
3457 3642
 /**
3458 3643
  * Gets the value from the cache specified by key, so long as it is not older than ttl seconds.
@@ -3468,8 +3653,9 @@  discard block
 block discarded – undo
3468 3653
 	global $smcFunc, $cache_enable, $cacheAPI;
3469 3654
 	global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug;
3470 3655
 
3471
-	if (empty($cache_enable) || empty($cacheAPI))
3472
-		return;
3656
+	if (empty($cache_enable) || empty($cacheAPI)) {
3657
+			return;
3658
+	}
3473 3659
 
3474 3660
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3475 3661
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3489,16 +3675,18 @@  discard block
 block discarded – undo
3489 3675
 
3490 3676
 		if (empty($value))
3491 3677
 		{
3492
-			if (!is_array($cache_misses))
3493
-				$cache_misses = array();
3678
+			if (!is_array($cache_misses)) {
3679
+							$cache_misses = array();
3680
+			}
3494 3681
 
3495 3682
 			$cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1;
3496 3683
 			$cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get');
3497 3684
 		}
3498 3685
 	}
3499 3686
 
3500
-	if (function_exists('call_integration_hook') && isset($value))
3501
-		call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3687
+	if (function_exists('call_integration_hook') && isset($value)) {
3688
+			call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3689
+	}
3502 3690
 
3503 3691
 	return empty($value) ? null : (isset($smcFunc['json_decode']) ? $smcFunc['json_decode']($value, true) : smf_json_decode($value, true));
3504 3692
 }
@@ -3520,8 +3708,9 @@  discard block
 block discarded – undo
3520 3708
 	global $cacheAPI;
3521 3709
 
3522 3710
 	// If we can't get to the API, can't do this.
3523
-	if (empty($cacheAPI))
3524
-		return;
3711
+	if (empty($cacheAPI)) {
3712
+			return;
3713
+	}
3525 3714
 
3526 3715
 	// Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure.
3527 3716
 	$cacheAPI->cleanCache($type);
@@ -3546,8 +3735,9 @@  discard block
 block discarded – undo
3546 3735
 	global $modSettings, $smcFunc, $image_proxy_enabled, $user_info;
3547 3736
 
3548 3737
 	// Come on!
3549
-	if (empty($data))
3550
-		return array();
3738
+	if (empty($data)) {
3739
+			return array();
3740
+	}
3551 3741
 
3552 3742
 	// Set a nice default var.
3553 3743
 	$image = '';
@@ -3555,11 +3745,11 @@  discard block
 block discarded – undo
3555 3745
 	// Gravatar has been set as mandatory!
3556 3746
 	if (!empty($modSettings['gravatarOverride']))
3557 3747
 	{
3558
-		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://'))
3559
-			$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3560
-
3561
-		else if (!empty($data['email']))
3562
-			$image = get_gravatar_url($data['email']);
3748
+		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) {
3749
+					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3750
+		} else if (!empty($data['email'])) {
3751
+					$image = get_gravatar_url($data['email']);
3752
+		}
3563 3753
 	}
3564 3754
 
3565 3755
 	// Look if the user has a gravatar field or has set an external url as avatar.
@@ -3571,54 +3761,60 @@  discard block
 block discarded – undo
3571 3761
 			// Gravatar.
3572 3762
 			if (stristr($data['avatar'], 'gravatar://'))
3573 3763
 			{
3574
-				if ($data['avatar'] == 'gravatar://')
3575
-					$image = get_gravatar_url($data['email']);
3576
-
3577
-				elseif (!empty($modSettings['gravatarAllowExtraEmail']))
3578
-					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3764
+				if ($data['avatar'] == 'gravatar://') {
3765
+									$image = get_gravatar_url($data['email']);
3766
+				} elseif (!empty($modSettings['gravatarAllowExtraEmail'])) {
3767
+									$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3768
+				}
3579 3769
 			}
3580 3770
 
3581 3771
 			// External url.
3582 3772
 			else
3583 3773
 			{
3584 3774
 				// Using ssl?
3585
-				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false && empty($user_info['possibly_robot']))
3586
-					$image = get_proxied_url($data['avatar']);
3775
+				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false && empty($user_info['possibly_robot'])) {
3776
+									$image = get_proxied_url($data['avatar']);
3777
+				}
3587 3778
 
3588 3779
 				// Just a plain external url.
3589
-				else
3590
-					$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3780
+				else {
3781
+									$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3782
+				}
3591 3783
 			}
3592 3784
 		}
3593 3785
 
3594 3786
 		// Perhaps this user has an attachment as avatar...
3595
-		else if (!empty($data['filename']))
3596
-			$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3787
+		else if (!empty($data['filename'])) {
3788
+					$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3789
+		}
3597 3790
 
3598 3791
 		// Right... no avatar... use our default image.
3599
-		else
3600
-			$image = $modSettings['avatar_url'] . '/default.png';
3792
+		else {
3793
+					$image = $modSettings['avatar_url'] . '/default.png';
3794
+		}
3601 3795
 	}
3602 3796
 
3603 3797
 	call_integration_hook('integrate_set_avatar_data', array(&$image, &$data));
3604 3798
 
3605 3799
 	// At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed.
3606
-	if (!empty($image))
3607
-		return array(
3800
+	if (!empty($image)) {
3801
+			return array(
3608 3802
 			'name' => !empty($data['avatar']) ? $data['avatar'] : '',
3609 3803
 			'image' => '<img class="avatar" src="' . $image . '" />',
3610 3804
 			'href' => $image,
3611 3805
 			'url' => $image,
3612 3806
 		);
3807
+	}
3613 3808
 
3614 3809
 	// Fallback to make life easier for everyone...
3615
-	else
3616
-		return array(
3810
+	else {
3811
+			return array(
3617 3812
 			'name' => '',
3618 3813
 			'image' => '',
3619 3814
 			'href' => '',
3620 3815
 			'url' => '',
3621 3816
 		);
3622
-}
3817
+	}
3818
+	}
3623 3819
 
3624 3820
 ?>
3625 3821
\ No newline at end of file
Please login to merge, or discard this patch.