Passed
Pull Request — release-2.1 (#6814)
by Jon
03:56
created
Sources/Subs-Admin.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -859,7 +859,7 @@  discard block
 block discarded – undo
859 859
 				'if (!is_dir(realpath($cachedir)) && is_dir($boarddir . \'/cache\'))',
860 860
 				'	$cachedir = $boarddir . \'/cache\';',
861 861
 			)),
862
-			'search_pattern' => '~\n?(#[^\n]+)?(?:\n\h*if\s*\((?:\!file_exists\(\$(?'.'>boarddir|sourcedir|tasksdir|packagesdir|cachedir)\)|\!is_dir\(realpath\(\$(?'.'>boarddir|sourcedir|tasksdir|packagesdir|cachedir)\)\))[^;]+\n\h*\$(?'.'>boarddir|sourcedir|tasksdir|packagesdir|cachedir)[^\n]+;)+~sm',
862
+			'search_pattern' => '~\n?(#[^\n]+)?(?:\n\h*if\s*\((?:\!file_exists\(\$(?' . '>boarddir|sourcedir|tasksdir|packagesdir|cachedir)\)|\!is_dir\(realpath\(\$(?' . '>boarddir|sourcedir|tasksdir|packagesdir|cachedir)\)\))[^;]+\n\h*\$(?' . '>boarddir|sourcedir|tasksdir|packagesdir|cachedir)[^\n]+;)+~sm',
863 863
 		),
864 864
 		'db_character_set' => array(
865 865
 			'text' => implode("\n", array(
@@ -958,8 +958,8 @@  discard block
 block discarded – undo
958 958
 		'boolean' =>  '(?i:TRUE|FALSE|(["\']?)[01]\b\\1)',
959 959
 		'NULL' =>  '(?i:NULL)',
960 960
 		// These use a PCRE subroutine to match nested arrays.
961
-		'array' =>  'array\s*(\((?'.'>[^()]|(?1))*\))',
962
-		'object' =>  '\w+::__set_state\(array\s*(\((?'.'>[^()]|(?1))*\))\)',
961
+		'array' =>  'array\s*(\((?' . '>[^()]|(?1))*\))',
962
+		'object' =>  '\w+::__set_state\(array\s*(\((?' . '>[^()]|(?1))*\))\)',
963 963
 	);
964 964
 
965 965
 	/*
@@ -992,7 +992,7 @@  discard block
 block discarded – undo
992 992
 		),
993 993
 		// Remove the code that redirects to the installer.
994 994
 		$neg_index-- => array(
995
-			'search_pattern' => '~^if\s*\(file_exists\(dirname\(__FILE__\)\s*\.\s*\'/install\.php\'\)\)\s*(?:({(?'.'>[^{}]|(?1))*})\h*|header(\((?' . '>[^()]|(?2))*\));\n)~m',
995
+			'search_pattern' => '~^if\s*\(file_exists\(dirname\(__FILE__\)\s*\.\s*\'/install\.php\'\)\)\s*(?:({(?' . '>[^{}]|(?1))*})\h*|header(\((?' . '>[^()]|(?2))*\));\n)~m',
996 996
 			'placeholder' => '',
997 997
 		),
998 998
 	);
@@ -1755,7 +1755,7 @@  discard block
 block discarded – undo
1755 1755
 	// Prevents warnings about constants that are already defined.
1756 1756
 	$settingsText = preg_replace_callback(
1757 1757
 		'~\bdefine\s*\(\s*(["\'])(\w+)\1~',
1758
-		function ($matches)
1758
+		function($matches)
1759 1759
 		{
1760 1760
 			return 'define(\'' . md5(mt_rand()) . '\'';
1761 1761
 		},
@@ -1765,7 +1765,7 @@  discard block
 block discarded – undo
1765 1765
 	// Handle eval errors gracefully in both PHP 5 and PHP 7
1766 1766
 	try
1767 1767
 	{
1768
-		if($settingsText !== '' && @eval($settingsText) === false)
1768
+		if ($settingsText !== '' && @eval($settingsText) === false)
1769 1769
 			throw new ErrorException('eval error');
1770 1770
 
1771 1771
 		unset($mtime, $settingsFile, $settingsText);
Please login to merge, or discard this patch.
Braces   +12 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1232,7 +1232,8 @@  discard block
 block discarded – undo
1232 1232
 	}
1233 1233
 
1234 1234
 	// It's important to do the numbered ones before the named ones, or messes happen.
1235
-	uksort($substitutions, function($a, $b) {
1235
+	uksort($substitutions, function($a, $b)
1236
+	{
1236 1237
 		if (is_int($a) && is_int($b))
1237 1238
 			return $a > $b ? 1 : ($a < $b ? -1 : 0);
1238 1239
 		elseif (is_int($a))
@@ -1771,8 +1772,12 @@  discard block
 block discarded – undo
1771 1772
 		unset($mtime, $settingsFile, $settingsText);
1772 1773
 		$defined_vars = get_defined_vars();
1773 1774
 	}
1774
-	catch (Throwable $e) {}
1775
-	catch (ErrorException $e) {}
1775
+	catch (Throwable $e)
1776
+	{
1777
+}
1778
+	catch (ErrorException $e)
1779
+	{
1780
+}
1776 1781
 	if (isset($e))
1777 1782
 		return false;
1778 1783
 
@@ -1928,7 +1933,8 @@  discard block
 block discarded – undo
1928 1933
 	// For the same reason, replace literal returns and newlines with "\r" and "\n"
1929 1934
 	elseif (is_string($var) && (strpos($var, "\n") !== false || strpos($var, "\r") !== false))
1930 1935
 	{
1931
-		return strtr(preg_replace_callback('/[\r\n]+/', function($m) {
1936
+		return strtr(preg_replace_callback('/[\r\n]+/', function($m)
1937
+		{
1932 1938
 			return '\' . "' . strtr($m[0], array("\r" => '\r', "\n" => '\n')) . '" . \'';
1933 1939
 		}, var_export($var, true)), array("'' . " => '', " . ''" => ''));
1934 1940
 	}
@@ -1966,7 +1972,8 @@  discard block
 block discarded – undo
1966 1972
 
1967 1973
 				$prev_part = count($parts) - 1;
1968 1974
 
1969
-				switch ($id) {
1975
+				switch ($id)
1976
+				{
1970 1977
 					case T_COMMENT:
1971 1978
 					case T_DOC_COMMENT:
1972 1979
 						// For the sake of tider output, trim any horizontal
Please login to merge, or discard this patch.