NotificationController::update() - Code Metrics - SierraTecnologia/Transmissor - Measure and Improve Code Quality continuously with Scrutinizer

NotificationController::update() A
last analyzed 2020-10-20 08:55 UTC

↳ Parent: NotificationController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php

namespace Transmissor\Http\Controllers\Admin;

use Illuminate\Http\Request;
use Transmissor\Http\Controllers\Controller;
use Transmissor\Services\NotificationService;
use Transmissor\Http\Requests\NotificationCreateRequest;
use Transmissor\Http\Requests\NotificationUpdateRequest;

class NotificationController extends Controller
{
    public function __construct(NotificationService $notificationService)
    {
        $this->service = $notificationService;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

    {
        $notifications = $this->service->paginated();
        return view('transmissor::admin.notifications.index')->with('notifications', $notifications);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Display a listing of the resource searched.
     *
     * @return \Illuminate\Http\Response
     */
    public function search(Request $request)
    {
        $notifications = $this->service->search($request->search, null);
        return view('transmissor::admin.notifications.index')->with('notifications', $notifications);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('transmissor::admin.notifications.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\NotificationCreateRequest $request
     * @return \Illuminate\Http\Response
     */
    public function store(NotificationCreateRequest $request)
    {
        $result = $this->service->create($request->except('_token'));

        if ($result && is_object($result)) {
            return redirect('admin/notifications/'.$result->id.'/edit')->with('message', 'Successfully created');
        } elseif ($result) {
            return redirect('admin/notifications')->with('message', 'Successfully created');
        }

        return redirect('admin/notifications')->with('errors', ['Failed to create']);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, $id)

    {
        $notification = $this->service->find($id);
        return view('transmissor::admin.notifications.edit')->with('notification', $notification);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\NotificationUpdateRequest $request
     * @param  int                                        $id
     * @return \Illuminate\Http\Response
     */
    public function update(NotificationUpdateRequest $request, $id)
    {
        $result = $this->service->update($id, $request->except('_token'));

        if ($result) {
            return back()->with('message', 'Successfully updated');
        }

        return back()->with('errors', ['Failed to update']);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, $id)

    {
        $result = $this->service->destroy($id);

        if ($result) {
            return redirect('admin/notifications')->with('message', 'Successfully deleted');
        }

        return redirect('admin/notifications')->with('errors', ['Failed to delete']);
    }
}


1		<?php
2
3		namespace Transmissor\Http\Controllers\Admin;
4
5		use Illuminate\Http\Request;
6		use Transmissor\Http\Controllers\Controller;
7		use Transmissor\Services\NotificationService;
8		use Transmissor\Http\Requests\NotificationCreateRequest;
9		use Transmissor\Http\Requests\NotificationUpdateRequest;
10
11		class NotificationController extends Controller
12		{
13		public function __construct(NotificationService $notificationService)
14		{
15		$this->service = $notificationService;
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The property `service` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16		}
17
18		/**
19		* Display a listing of the resource.
20		*
21		* @return \Illuminate\Http\Response
22		*/
23		public function index(Request $request)
		0 ignored issues – show Unused Code introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
24		{
25		$notifications = $this->service->paginated();
26		return view('transmissor::admin.notifications.index')->with('notifications', $notifications);
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27		}
28
29		/**
30		* Display a listing of the resource searched.
31		*
32		* @return \Illuminate\Http\Response
33		*/
34		public function search(Request $request)
35		{
36		$notifications = $this->service->search($request->search, null);
37		return view('transmissor::admin.notifications.index')->with('notifications', $notifications);
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38		}
39
40		/**
41		* Show the form for creating a new resource.
42		*
43		* @return \Illuminate\Http\Response
44		*/
45		public function create()
46		{
47		return view('transmissor::admin.notifications.create');
48		}
49
50		/**
51		* Store a newly created resource in storage.
52		*
53		* @param \Illuminate\Http\NotificationCreateRequest $request
54		* @return \Illuminate\Http\Response
55		*/
56		public function store(NotificationCreateRequest $request)
57		{
58		$result = $this->service->create($request->except('_token'));
59
60		if ($result && is_object($result)) {
61		return redirect('admin/notifications/'.$result->id.'/edit')->with('message', 'Successfully created');
62		} elseif ($result) {
63		return redirect('admin/notifications')->with('message', 'Successfully created');
64		}
65
66		return redirect('admin/notifications')->with('errors', ['Failed to create']);
67		}
68
69		/**
70		* Show the form for editing the specified resource.
71		*
72		* @param int $id
73		* @return \Illuminate\Http\Response
74		*/
75		public function edit(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2020-09-25 18:13 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
76		{
77		$notification = $this->service->find($id);
78		return view('transmissor::admin.notifications.edit')->with('notification', $notification);
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
79		}
80
81		/**
82		* Update the specified resource in storage.
83		*
84		* @param \Illuminate\Http\NotificationUpdateRequest $request
85		* @param int $id
86		* @return \Illuminate\Http\Response
87		*/
88		public function update(NotificationUpdateRequest $request, $id)
89		{
90		$result = $this->service->update($id, $request->except('_token'));
91
92		if ($result) {
93		return back()->with('message', 'Successfully updated');
94		}
95
96		return back()->with('errors', ['Failed to update']);
97		}
98
99		/**
100		* Remove the specified resource from storage.
101		*
102		* @param int $id
103		* @return \Illuminate\Http\Response
104		*/
105	View Code Duplication	public function destroy(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2020-09-25 18:13 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2020-09-25 18:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		{
107		$result = $this->service->destroy($id);
108
109		if ($result) {
110		return redirect('admin/notifications')->with('message', 'Successfully deleted');
111		}
112
113		return redirect('admin/notifications')->with('errors', ['Failed to delete']);
114		}
115		}
116

SierraTecnologia / Transmissor

NotificationController::update() A last analyzed 2020-10-20 08:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

NotificationController::update() A
last analyzed 2020-10-20 08:55 UTC