Transmissor\Http\Controllers\Admin\NotificationController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	105
Duplicated Lines	9.52 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	5	1
A	search()	0	5	1
A	create()	0	4	1
A	store()	0	12	4
A	update()	0	10	2
A	edit()	0	5	1
A	destroy()	10	10	2

<?php

namespace Transmissor\Http\Controllers\Admin;

use Illuminate\Http\Request;
use Transmissor\Http\Controllers\Controller;
use Transmissor\Services\NotificationService;
use Transmissor\Http\Requests\NotificationCreateRequest;
use Transmissor\Http\Requests\NotificationUpdateRequest;

class NotificationController extends Controller
{
    public function __construct(NotificationService $notificationService)
    {
        $this->service = $notificationService;

The property service does not exist. Did you maybe forget to declare it?

    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        $notifications = $this->service->paginated();
        return view('transmissor::admin.notifications.index')->with('notifications', $notifications);

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

    }

    /**
     * Display a listing of the resource searched.
     *
     * @return \Illuminate\Http\Response
     */
    public function search(Request $request)
    {
        $notifications = $this->service->search($request->search, null);
        return view('transmissor::admin.notifications.index')->with('notifications', $notifications);

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('transmissor::admin.notifications.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\NotificationCreateRequest $request
     * @return \Illuminate\Http\Response
     */
    public function store(NotificationCreateRequest $request)
    {
        $result = $this->service->create($request->except('_token'));

        if ($result && is_object($result)) {
            return redirect('admin/notifications/'.$result->id.'/edit')->with('message', 'Successfully created');
        } elseif ($result) {
            return redirect('admin/notifications')->with('message', 'Successfully created');
        }

        return redirect('admin/notifications')->with('errors', ['Failed to create']);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $notification = $this->service->find($id);
        return view('transmissor::admin.notifications.edit')->with('notification', $notification);

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\NotificationUpdateRequest $request
     * @param  int                                        $id
     * @return \Illuminate\Http\Response
     */
    public function update(NotificationUpdateRequest $request, $id)
    {
        $result = $this->service->update($id, $request->except('_token'));

        if ($result) {
            return back()->with('message', 'Successfully updated');
        }

        return back()->with('errors', ['Failed to update']);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, $id)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $result = $this->service->destroy($id);

        if ($result) {
            return redirect('admin/notifications')->with('message', 'Successfully deleted');
        }

        return redirect('admin/notifications')->with('errors', ['Failed to delete']);
    }
}