NotificationController::update() - Code Metrics - SierraTecnologia/Tracking - Measure and Improve Code Quality continuously with Scrutinizer

NotificationController::update() A
last analyzed 2020-09-22 16:25 UTC

↳ Parent: NotificationController

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace Tracking\Http\Controllers\Metrics;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Tracking\Models\Metrics\LarametricsNotification;

class NotificationController extends Controller
{
    
    public function index()
    {
        $notifications = LarametricsNotification::all();
        
        return view(
            'rica.larametrics::notifications.index', [
            'notifications' => $notifications,
            'pageTitle' => 'Notifications'
            ]
        );
    }

    public function update(Request $request)
    {
        $notifications = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        LarametricsNotification::truncate();
        foreach(json_decode($request->input('notifications')) as $notification) {
            $notificationData = array(
                'action' => $notification->action,
                'filter' => $notification->filter,
                'notify_by' => $notification->notify_by
            );
            try {
                LarametricsNotification::create($notificationData);
            } catch(\Exception $e) {

            }
        }

        return redirect()->route('rica.larametrics::notifications.index');
    }

}


1			<?php
2
3			namespace Tracking\Http\Controllers\Metrics;
4
5			use Illuminate\Http\Request;
6			use Illuminate\Routing\Controller;
7			use Tracking\Models\Metrics\LarametricsNotification;
8
9			class NotificationController extends Controller
10			{
11
12			public function index()
13			{
14			$notifications = LarametricsNotification::all();
15
16			return view(
17			'rica.larametrics::notifications.index', [
18			'notifications' => $notifications,
19			'pageTitle' => 'Notifications'
20			]
21			);
22			}
23
24			public function update(Request $request)
25			{
26			$notifications = '';
			0 ignored issues – show Unused Code introduced 2020-09-08 01:24 UTC by Report Bug Copy Issue Report `$notifications` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
27			LarametricsNotification::truncate();
28			foreach(json_decode($request->input('notifications')) as $notification) {
29			$notificationData = array(
30			'action' => $notification->action,
31			'filter' => $notification->filter,
32			'notify_by' => $notification->notify_by
33			);
34			try {
35			LarametricsNotification::create($notificationData);
36			} catch(\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-09-08 01:24 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
37			}
38			}
39
40			return redirect()->route('rica.larametrics::notifications.index');
41			}
42
43			}
44

SierraTecnologia / Tracking

NotificationController::update() A last analyzed 2020-09-22 16:25 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

NotificationController::update() A
last analyzed 2020-09-22 16:25 UTC