Tracking\Http\Controllers\Metrics\NotificationController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	11	1
A	update()	0	18	3

<?php

namespace Tracking\Http\Controllers\Metrics;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Tracking\Models\Metrics\LarametricsNotification;

class NotificationController extends Controller
{
    
    public function index()
    {
        $notifications = LarametricsNotification::all();
        
        return view(
            'rica.larametrics::notifications.index', [
            'notifications' => $notifications,
            'pageTitle' => 'Notifications'
            ]
        );
    }

    public function update(Request $request)
    {
        $notifications = '';

$notifications is not used, you could remove the assignment.

        LarametricsNotification::truncate();
        foreach(json_decode($request->input('notifications')) as $notification) {
            $notificationData = array(
                'action' => $notification->action,
                'filter' => $notification->filter,
                'notify_by' => $notification->notify_by
            );
            try {
                LarametricsNotification::create($notificationData);
            } catch(\Exception $e) {

Consider adding a comment why this CATCH block is empty.

            }
        }

        return redirect()->route('rica.larametrics::notifications.index');
    }

}