Completed
Push — master ( 3184dc...186529 )
by mw
36:28
created
src/SQLStore/QueryEngine/OrderConditionsComplementor.php 2 patches
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	/**
78 78
 	 * @since 2.5
79 79
 	 *
80
-	 * @return array
80
+	 * @return string[]
81 81
 	 */
82 82
 	public function getErrors() {
83 83
 		return $this->querySegmentListBuilder->getErrors();
@@ -120,6 +120,9 @@  discard block
 block discarded – undo
120 120
 		return $this->querySegmentListBuilder->getQuerySegmentList();
121 121
 	}
122 122
 
123
+	/**
124
+	 * @param QuerySegment $querySegment
125
+	 */
123 126
 	private function collectExtraDescriptionsFromSortKeys( $querySegment ) {
124 127
 
125 128
 		$extraDescriptions = array();
@@ -138,6 +141,10 @@  discard block
 block discarded – undo
138 141
 		return $extraDescriptions;
139 142
 	}
140 143
 
144
+	/**
145
+	 * @param string $label
146
+	 * @param string $order
147
+	 */
141 148
 	private function findExtraDescriptionBy( $querySegment, $label, $order ) {
142 149
 
143 150
 		$description = null;
@@ -171,6 +178,9 @@  discard block
 block discarded – undo
171 178
 		return $description;
172 179
 	}
173 180
 
181
+	/**
182
+	 * @param QuerySegment $querySegment
183
+	 */
174 184
 	private function addConjunctionFromExtraDescriptions( $querySegment, array $extraDescriptions ) {
175 185
 
176 186
 		$this->querySegmentListBuilder->setSortKeys(
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use SMW\DataValueFactory;
6 6
 use SMW\Query\DescriptionFactory;
7 7
 use SMW\Query\Language\Description;
8
-use SMW\DataValues\PropertyChainValue;
9 8
 use RuntimeException;
10 9
 
11 10
 /**
Please login to merge, or discard this patch.
src/SQLStore/QueryEngine/QueryEngine.php 2 patches
Doc Comments   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 	/**
234 234
 	 * Compute abstract representation of the query (compilation)
235 235
 	 *
236
-	 * @param Database $connection
236
+	 * @param \SMW\MediaWiki\Database $connection
237 237
 	 * @param Query $query
238 238
 	 *
239 239
 	 * @return integer
@@ -344,6 +344,9 @@  discard block
 block discarded – undo
344 344
 		return QueryDebugOutputFormatter::getStringFrom( 'SQLStore', $entries, $query );
345 345
 	}
346 346
 
347
+	/**
348
+	 * @param QuerySegment $qobj
349
+	 */
347 350
 	private function doExecuteDebugQueryResult( $qobj, $sqlOptions, &$entries ) {
348 351
 
349 352
 		if ( !isset( $qobj->joinfield ) || $qobj->joinfield === '' ) {
@@ -384,7 +387,7 @@  discard block
 block discarded – undo
384 387
 	 * @param Query $query
385 388
 	 * @param integer $rootid
386 389
 	 *
387
-	 * @return integer
390
+	 * @return QueryResult
388 391
 	 */
389 392
 	private function getCountQueryResult( Query $query, $rootid ) {
390 393
 
@@ -553,6 +556,10 @@  discard block
 block discarded – undo
553 556
 		return $queryResult;
554 557
 	}
555 558
 
559
+	/**
560
+	 * @param \SMW\MediaWiki\Database $connection
561
+	 * @param integer $qid
562
+	 */
556 563
 	private function applyExtraWhereCondition( $connection, $qid ) {
557 564
 
558 565
 		if ( !isset( $this->querySegmentList[$qid] ) ) {
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -6,14 +6,10 @@
 block discarded – undo
6 6
 use SMW\DIWikiPage;
7 7
 use SMW\InvalidPredefinedPropertyException;
8 8
 use SMW\Query\DebugOutputFormatter as QueryDebugOutputFormatter;
9
-use SMW\Query\Language\Conjunction;
10
-use SMW\Query\Language\SomeProperty;
11 9
 use SMW\Query\Language\ThingDescription;
12 10
 use SMWDataItem as DataItem;
13
-use SMWPropertyValue as PropertyValue;
14 11
 use SMWQuery as Query;
15 12
 use SMWQueryResult as QueryResult;
16
-use SMWSql3SmwIds;
17 13
 use SMWSQLStore3 as SQLStore;
18 14
 use SMW\QueryEngine as QueryEngineInterface;
19 15
 use SMW\QueryFactory;
Please login to merge, or discard this patch.