Completed
Push — master ( b59220...419e79 )
by mw
90:31 queued 54:46
created
includes/datavalues/SMW_DV_Time.php 1 patch
Doc Comments   +11 added lines, -7 removed lines patch added patch discarded remove patch
@@ -186,14 +186,15 @@  discard block
 block discarded – undo
186 186
 	 * The function sets the provided call-by-ref values to the respective
187 187
 	 * values. If errors are encountered, they are added to the objects
188 188
 	 * error list and false is returned. Otherwise, true is returned.
189
-	 * @param $string string input time representation, e.g. "12 May 2007 13:45:23-3:30"
189
+	 * @param string $string string input time representation, e.g. "12 May 2007 13:45:23-3:30"
190 190
 	 * @param $datecomponents array of strings that might belong to the specification of a date
191 191
 	 * @param $calendarmodesl string if model was set in input, otherwise false
192
-	 * @param $era string '+' or '-' if provided, otherwise false
193
-	 * @param $hours integer set to a value between 0 and 24
194
-	 * @param $minutes integer set to a value between 0 and 59
195
-	 * @param $seconds integer set to a value between 0 and 59, or false if not given
196
-	 * @param $timeoffset double set to a value for time offset (e.g. 3.5), or false if not given
192
+	 * @param boolean $era string '+' or '-' if provided, otherwise false
193
+	 * @param boolean $hours integer set to a value between 0 and 24
194
+	 * @param boolean $minutes integer set to a value between 0 and 59
195
+	 * @param boolean $seconds integer set to a value between 0 and 59, or false if not given
196
+	 * @param boolean $timeoffset double set to a value for time offset (e.g. 3.5), or false if not given
197
+	 * @param boolean $calendarmodel
197 198
 	 * @return boolean stating if the parsing succeeded
198 199
 	 * @todo This method in principle allows date parsing to be internationalized further. Should be done.
199 200
 	 */
@@ -403,7 +404,7 @@  discard block
 block discarded – undo
403 404
 	 * messages are added to the objects list of errors, and false is
404 405
 	 * returned. Otherwise, true is returned.
405 406
 	 * @param $datecomponents array of strings that might belong to the specification of a date
406
-	 * @param $date array set to result
407
+	 * @param boolean $date array set to result
407 408
 	 * @return boolean stating if successful
408 409
 	 */
409 410
 	protected function interpretDateComponents( $datecomponents, &$date ) {
@@ -780,6 +781,9 @@  discard block
 block discarded – undo
780 781
 		}
781 782
 	}
782 783
 
784
+	/**
785
+	 * @param string $value
786
+	 */
783 787
 	private function isInterpretableAsYearOnly( $value ) {
784 788
 		return strpos( $value, ' ' ) === false && is_numeric( strval( $value ) ) && ( strval( $value ) < 0 || strlen( $value ) < 6 );
785 789
 	}
Please login to merge, or discard this patch.