SemanticMediaWiki / SemanticFormsSelect

tests/phpunit/Unit/ApiSemanticFormsSelectRequestProcessorTest.php

Spacing +20 added lines, -20 removed lines

@@ -24,13 +24,13 @@ 
 
 	protected function setUp(): void {
 		parent::setUp();
-		$parser = $this->getMockBuilder( '\Parser' )
+		$parser = $this->getMockBuilder('\Parser')
 			->disableOriginalConstructor()->getMock();
-		$this->ApiSFSRP = new ApiSemanticFormsSelectRequestProcessor( $parser );
+		$this->ApiSFSRP = new ApiSemanticFormsSelectRequestProcessor($parser);
 	}
 
 	protected function tearDown(): void {
-		unset( $this->ApiSFSRP );
+		unset($this->ApiSFSRP);
 		parent::tearDown();
 	}
 
@@ -44,7 +44,7 @@ 
 
 		$parameters = [];
 
-		$this->setExpectedException( 'InvalidArgumentException' );
+		$this->setExpectedException('InvalidArgumentException');
 		$this->ApiSFSRP->getJsonDecodedResultValuesForRequestParameters(
 			$parameters
 		);
@@ -52,7 +52,7 @@ 
 
 	public function testJsonResultValuesFromRequestParameters() {
 
-		$parameters = [ 'query' => 'foo', 'sep' => ',' ];
+		$parameters = ['query' => 'foo', 'sep' => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -65,8 +65,8 @@ 
 	public function testJsonResultValuesFromRequestParameters_doProcessQueryFor(
 	) {
 
-		$parameters = [ 'approach' => 'smw', 'query' => 'foo, baa, gaah',
-		                     'sep'      => ',' ];
+		$parameters = ['approach' => 'smw', 'query' => 'foo, baa, gaah',
+		                     'sep'      => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -77,8 +77,8 @@ 
 	}
 
 	public function testSetDebugFlag() {
-		$this->ApiSFSRP->setDebugFlag( true );
-		$parameters = [ 'query' => 'foo , function', 'sep' => ',' ];
+		$this->ApiSFSRP->setDebugFlag(true);
+		$parameters = ['query' => 'foo , function', 'sep' => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -89,9 +89,9 @@ 
 	}
 
 	public function testSetDebugFlag_doProcessQueryFor() {
-		$this->ApiSFSRP->setDebugFlag( true );
-		$parameters = [ 'approach' => 'smw', 'query' => 'my Query,query2',
-		                     'sep'      => ',' ];
+		$this->ApiSFSRP->setDebugFlag(true);
+		$parameters = ['approach' => 'smw', 'query' => 'my Query,query2',
+		                     'sep'      => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -104,11 +104,11 @@ 
 	public function testGetFormattedValuesFrom() {
 		$sep = ",";
 		$values = "my Query,query2";
-		$result = [ "", "my Query", "query2" ];
+		$result = ["", "my Query", "query2"];
 		$formattedValues = $this->invokeMethod(
-			$this->ApiSFSRP, 'getFormattedValuesFrom', [ $sep, $values ]
+			$this->ApiSFSRP, 'getFormattedValuesFrom', [$sep, $values]
 		);
-		$this->assertEquals( $result, $formattedValues );
+		$this->assertEquals($result, $formattedValues);
 	}
 
 	/**
@@ -120,14 +120,14 @@ 
 	 *
 	 * @return mixed Method return.
 	 */
-	public function invokeMethod( &$object, $methodName,
+	public function invokeMethod(&$object, $methodName,
 		array $parameters = []
 	) {
-		$reflection = new \ReflectionClass( get_class( $object ) );
-		$method = $reflection->getMethod( $methodName );
-		$method->setAccessible( true );
+		$reflection = new \ReflectionClass(get_class($object));
+		$method = $reflection->getMethod($methodName);
+		$method->setAccessible(true);
 
-		return $method->invokeArgs( $object, $parameters );
+		return $method->invokeArgs($object, $parameters);
 	}
 
 

tests/phpunit/Unit/SelectFieldTest.php

Spacing +50 added lines, -50 removed lines

@@ -24,17 +24,17 @@ 
 	private $SelectField;
 	private $parser;
 	// Defined variables
-	private $other_args_query_parametrized = [ 'query' => '((Category:Building Complex))((Part Of Site::@@@@));?Display Title;format~list;sort~Display Title;sep~,;link~none;headers~hide;limit~500' ];
+	private $other_args_query_parametrized = ['query' => '((Category:Building Complex))((Part Of Site::@@@@));?Display Title;format~list;sort~Display Title;sep~,;link~none;headers~hide;limit~500'];
 	private $expected_result_parametrized_setQuery = "[[Category:Building Complex]][[Part Of Site::@@@@]];?Display Title;format=list;sort=Display Title;sep=,;link=none;headers=hide;limit=500";
-	private $other_args_query_unparametrized = [ 'query' => '((Category:Building Complex));?Display Title;format~list;sort~Display Title;sep~,;link~none;headers~hide;limit~500' ];
-	private $other_args_function_parametrized = [ 'function' => '((Category:Building Complex))((Part Of Site::@@@@));?Display Title;format~list;sort~Display Title;sep~,;link~none;headers~hide;limit~500' ];
+	private $other_args_query_unparametrized = ['query' => '((Category:Building Complex));?Display Title;format~list;sort~Display Title;sep~,;link~none;headers~hide;limit~500'];
+	private $other_args_function_parametrized = ['function' => '((Category:Building Complex))((Part Of Site::@@@@));?Display Title;format~list;sort~Display Title;sep~,;link~none;headers~hide;limit~500'];
 	private $expected_result_parametrized_seFunction = '{{#[[Category:Building Complex]][[Part Of Site::@@@@]];?Display Title;format=list;sort=Display Title;sep=,;link=none;headers=hide;limit=500}}';
-	private $other_args_function_unparametrized = [ 'function' => 'ask:((Category:Building Complex));?Display Title;format~list;sort~Display Title;sep~@@;link~none;headers~hide;limit~500' ];
+	private $other_args_function_unparametrized = ['function' => 'ask:((Category:Building Complex));?Display Title;format~list;sort~Display Title;sep~@@;link~none;headers~hide;limit~500'];
 	private $expected_result_unparametrized_seFunction = "Building Complex:86543eab-4112-4616-be50-17dcdc24c346 (OFD.AEXH)@@Building Complex:5b9e26f8-6c57-48ff-a6b8-42a4e50fe472 (OFD.AEXH)@@Building Complex:93b076aa-cbe9-4371-8b61-c17c26f1872f (OFD.AMEXH)@@Building Complex:59577450-1582-4d6e-9621-3ac0531a728e (OFD.EEXH)@@Building Complex:1a9bed0b-67de-4e71-8528-f2b6a8907814 (RContiAve.Sport Complex)@@Building Complex:6a2242ea-7536-4a6d-85d2-f2ba4398ef44 (TB.BC)@@Building Complex:2db51fb1-10b6-4d4c-a152-f512914781ff (TB.BD)";
 
 	public function testCanConstruct() {
 
-		$this->assertInstanceOf( '\SFS\SelectField', $this->SelectField );
+		$this->assertInstanceOf('\SFS\SelectField', $this->SelectField);
 	}
 
 	public function testProcessParameters_Query() {
@@ -43,7 +43,7 @@ 
 			"", $this->other_args_query_parametrized
 		);
 		$this->assertTrue(
-			array_key_exists( "query", $this->other_args_query_parametrized )
+			array_key_exists("query", $this->other_args_query_parametrized)
 		);
 	}
 
@@ -59,7 +59,7 @@ 
 
 	public function testParametrized_setQuery() {
 
-		$this->SelectField->setQuery( $this->other_args_query_parametrized );
+		$this->SelectField->setQuery($this->other_args_query_parametrized);
 
 		$this->assertEquals(
 			$this->expected_result_parametrized_setQuery,
@@ -78,16 +78,16 @@ 
 			$was_replaced
 		);
 
-		$this->assertTrue( count( $was_remove[0] ) == 0 );
-		$this->assertTrue( count( $was_replaced[0] ) > 0 );
+		$this->assertTrue(count($was_remove[0]) == 0);
+		$this->assertTrue(count($was_replaced[0]) > 0);
 	}
 
 	public function testUnparametrized_setQuery() {
 
-		$this->SelectField->setQuery( $this->other_args_query_unparametrized );
+		$this->SelectField->setQuery($this->other_args_query_unparametrized);
 
-		$this->assertTrue( $this->SelectField->getValues() !== null );
-		$this->assertTrue( $this->SelectField->hasStaticValues() );
+		$this->assertTrue($this->SelectField->getValues() !== null);
+		$this->assertTrue($this->SelectField->hasStaticValues());
 	}
 
 	public function testParametrized_setFunction() {
@@ -109,26 +109,26 @@ 
 			$this->other_args_function_unparametrized
 		);
 
-		$this->assertTrue( $this->SelectField->hasStaticValues() );
+		$this->assertTrue($this->SelectField->hasStaticValues());
 	}
 
 	public function testSetSelectIsMultiple_keyExistTrue() {
-		$other_args = [ "part_of_multiple" => "bla bla bla" ];
-		$this->SelectField->setSelectIsMultiple( $other_args );
-		$this->assertTrue( $this->SelectField->getData()["selectismultiple"] );
+		$other_args = ["part_of_multiple" => "bla bla bla"];
+		$this->SelectField->setSelectIsMultiple($other_args);
+		$this->assertTrue($this->SelectField->getData()["selectismultiple"]);
 	}
 
 	public function testSetSelectIsMultiple_keyExistFalse() {
 
-		$other_args = [ "Not_part_of_multiple" => "blas blas blas" ];
-		$this->SelectField->setSelectIsMultiple( $other_args );
-		$this->assertFalse( $this->SelectField->getData()["selectismultiple"] );
+		$other_args = ["Not_part_of_multiple" => "blas blas blas"];
+		$this->SelectField->setSelectIsMultiple($other_args);
+		$this->assertFalse($this->SelectField->getData()["selectismultiple"]);
 	}
 
 	public function testSetSelectTemplate_correctData() {
 		$input_name = "{{#[[Category:Building Complex]][[Part Of Site::@@@@]]";
 		$result = "{{#";
-		$this->SelectField->setSelectTemplate( $input_name );
+		$this->SelectField->setSelectTemplate($input_name);
 
 		$this->assertEquals(
 			$this->SelectField->getData()['selecttemplate'], $result
@@ -138,7 +138,7 @@ 
 	public function testSetSelectTemplate_wrongData() {
 		$input_name = "Category:Building Complex";
 		$result = "";
-		$this->SelectField->setSelectTemplate( $input_name );
+		$this->SelectField->setSelectTemplate($input_name);
 
 		$this->assertEquals(
 			$this->SelectField->getData()['selecttemplate'], $result
@@ -149,7 +149,7 @@ 
 		$input_name = "{{#[[Category:Building Complex]][[Part Of Site::@@@@]]";
 		$result = "Part Of Site::@@@@]";
 
-		$this->SelectField->setSelectField( $input_name );
+		$this->SelectField->setSelectField($input_name);
 
 		$this->assertEquals(
 			$this->SelectField->getData()['selectfield'], $result
@@ -159,7 +159,7 @@ 
 	public function testSetSelectField_wrongData() {
 		$input_name = "Category:Building Complex";
 		$result = "";
-		$this->SelectField->setSelectField( $input_name );
+		$this->SelectField->setSelectField($input_name);
 
 		$this->assertNotEquals(
 			$this->SelectField->getData()['selectfield'], $result
@@ -168,10 +168,10 @@ 
 
 	public function testSetValueTemplate_containsMselectTemplate() {
 		$input_name = "{{#[[Category:Building Complex]][[Part Of Site::@@@@]]";
-		$other_args = [ "sametemplate" => "test values" ];
+		$other_args = ["sametemplate" => "test values"];
 		$result = "{{#";
-		$this->SelectField->setSelectTemplate( $input_name );
-		$this->SelectField->setValueTemplate( $other_args );
+		$this->SelectField->setSelectTemplate($input_name);
+		$this->SelectField->setValueTemplate($other_args);
 
 		$this->assertEquals(
 			$this->SelectField->getData()["valuetemplate"], $result
@@ -180,9 +180,9 @@ 
 
 	public function testSetValueTemplate_containsOtherArgsTemplate() {
 
-		$other_args = [ "template" => "test values" ];
+		$other_args = ["template" => "test values"];
 
-		$this->SelectField->setValueTemplate( $other_args );
+		$this->SelectField->setValueTemplate($other_args);
 
 		$this->assertEquals(
 			$this->SelectField->getData()["valuetemplate"],
@@ -191,9 +191,9 @@ 
 	}
 
 	public function testSetValueField() {
-		$other_args = [ "field" => "test values Field" ];
+		$other_args = ["field" => "test values Field"];
 
-		$this->SelectField->setValueField( $other_args );
+		$this->SelectField->setValueField($other_args);
 
 		$this->assertEquals(
 			$this->SelectField->getData()["valuefield"], $other_args["field"]
@@ -201,35 +201,35 @@ 
 	}
 
 	public function testSetSelectRemove_keyExistTrue() {
-		$other_args = [ 'rmdiv' => "Test data" ];
-		$this->SelectField->setSelectRemove( $other_args );
-		$this->assertTrue( $this->SelectField->getData()["selectrm"] );
+		$other_args = ['rmdiv' => "Test data"];
+		$this->SelectField->setSelectRemove($other_args);
+		$this->assertTrue($this->SelectField->getData()["selectrm"]);
 	}
 
 	public function testSetSelectRemove_keyExistFalse() {
 
-		$other_args = [ "no_rmdiv" => "test data" ];
-		$this->SelectField->setSelectRemove( $other_args );
-		$this->assertFalse( $this->SelectField->getData()["selectrm"] );
+		$other_args = ["no_rmdiv" => "test data"];
+		$this->SelectField->setSelectRemove($other_args);
+		$this->assertFalse($this->SelectField->getData()["selectrm"]);
 	}
 
 	public function testSetLabel_keyExistTrue() {
-		$other_args = [ 'label' => "Test data" ];
-		$this->SelectField->setLabel( $other_args );
-		$this->assertTrue( $this->SelectField->getData()["label"] );
+		$other_args = ['label' => "Test data"];
+		$this->SelectField->setLabel($other_args);
+		$this->assertTrue($this->SelectField->getData()["label"]);
 	}
 
 	public function testSetLabel_keyExistFalse() {
 
-		$other_args = [ "no_label" => "test data" ];
-		$this->SelectField->setLabel( $other_args );
-		$this->assertArrayHasKey( "label", $this->SelectField->getData() );
-		$this->assertFalse( $this->SelectField->getData()["label"] );
+		$other_args = ["no_label" => "test data"];
+		$this->SelectField->setLabel($other_args);
+		$this->assertArrayHasKey("label", $this->SelectField->getData());
+		$this->assertFalse($this->SelectField->getData()["label"]);
 	}
 
 	public function testSetDelimiter_keyExistTrue() {
-		$other_args = [ "delimiter" => ":" ];
-		$this->SelectField->setDelimiter( $other_args );
+		$other_args = ["delimiter" => ":"];
+		$this->SelectField->setDelimiter($other_args);
 		$this->assertEquals(
 			$this->SelectField->getDelimiter(), $other_args["delimiter"]
 		);
@@ -240,8 +240,8 @@ 
 
 	public function testSetWgPageFormsListSeparator_keyExistTrue() {
 
-		$g_args = [ "Global_delimiter" => ";" ];
-		$this->SelectField->setDelimiter( $g_args );
+		$g_args = ["Global_delimiter" => ";"];
+		$this->SelectField->setDelimiter($g_args);
 		$this->assertEquals(
 			$this->SelectField->getDelimiter(), $g_args["Global_delimiter"]
 		);
@@ -253,15 +253,15 @@ 
 	protected function setUp(): void {
 		parent::setUp();
 		$this->parser = $GLOBALS['wgParser'];
-		$this->parser->setTitle( Title::newFromText( 'NO TITLE' ) );
+		$this->parser->setTitle(Title::newFromText('NO TITLE'));
 		$this->parser->mOptions = new ParserOptions();
 		$this->parser->resetOutput();
 		$this->parser->clearState();
-		$this->SelectField = new SelectField( $this->parser );
+		$this->SelectField = new SelectField($this->parser);
 	}
 
 	protected function tearDown(): void {
-		unset( $this->SelectField );
+		unset($this->SelectField);
 		parent::tearDown();
 	}
 

tests/phpunit/Unit/SemanticFormsSelectInputTest.php

Spacing +10 added lines, -10 removed lines

@@ -25,17 +25,17 @@ 
 		$isMandatory = false;
 		$isDisabled = false;
 
-		$otherArgs = [ 'template' => 'Foo', 'field' => '',
-		                    'function' => 'Bar', 'is_list' => true ];
+		$otherArgs = ['template' => 'Foo', 'field' => '',
+		                    'function' => 'Bar', 'is_list' => true];
 
-		$parserOutput = $this->getMockBuilder( '\ParserOutput' )
+		$parserOutput = $this->getMockBuilder('\ParserOutput')
 			->disableOriginalConstructor()->getMock();
 
-		$parser = $this->getMockBuilder( '\Parser' )
+		$parser = $this->getMockBuilder('\Parser')
 			->disableOriginalConstructor()->getMock();
 
-		$parser->expects( $this->any() )->method( 'getOutput' )->will(
-				$this->returnValue( $parserOutput )
+		$parser->expects($this->any())->method('getOutput')->will(
+				$this->returnValue($parserOutput)
 			);
 		$this->SFSInput = new SemanticFormsSelectInput(
 			$value, $inputName, $isMandatory, $isDisabled, $otherArgs
@@ -43,7 +43,7 @@ 
 	}
 
 	protected function tearDown(): void {
-		unset( $this->SelectField );
+		unset($this->SelectField);
 		parent::tearDown();
 	}
 
@@ -70,14 +70,14 @@ 
 
 	public function testGetParameters() {
 
-		$this->assertInternalType( 'array', $this->SFSInput->getParameters() );
+		$this->assertInternalType('array', $this->SFSInput->getParameters());
 	}
 
 
 	public function testGetResourceModuleNames() {
-		$rsmn = [ 'ext.sf_select.scriptselect' ];
+		$rsmn = ['ext.sf_select.scriptselect'];
 
-		$this->assertEquals( $rsmn, $this->SFSInput->getResourceModuleNames() );
+		$this->assertEquals($rsmn, $this->SFSInput->getResourceModuleNames());
 	}
 
 }

tests/phpunit/Unit/OutputTest.php

Spacing +6 added lines, -6 removed lines

@@ -24,24 +24,24 @@
 	}
 
 	protected function tearDown(): void {
-		unset( $this->data );
+		unset($this->data);
 		parent::tearDown();
 	}
 
 	public function testCanConstruct() {
-		$this->assertInstanceOf( '\SFS\Output', new Output() );
+		$this->assertInstanceOf('\SFS\Output', new Output());
 	}
 
 	public function testAddToHeadItem() {
-		$ret = Output::addToHeadItem( $this->data );
+		$ret = Output::addToHeadItem($this->data);
 
-		$this->assertArrayHasKey( 'Foo', $ret );
-		$this->assertArrayHasKey( 'Spam', $ret );
+		$this->assertArrayHasKey('Foo', $ret);
+		$this->assertArrayHasKey('Spam', $ret);
 	}
 
 	public function testCommitToParserOutput() {
 		global $wgOut;
-		$expected_result = '[' . json_encode( $this->data ) . ']';
+		$expected_result = '['.json_encode($this->data).']';
 		Output::commitToParserOutput();
 		$this->assertEquals(
 			$expected_result, $wgOut->getJsConfigVars()['sf_select']

tests/phpunit/Unit/ApiSemanticFormsSelectTest.php

Indentation +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
 	protected function setUp(): void {
 		parent::setUp();
 		$parameters = [ 'action' => 'sformsselect', 'approach' => 'smw',
-		                     'query'  => 'abc', 'sep' => ',' ];
+							 'query'  => 'abc', 'sep' => ',' ];
 
 		$this->ApiMain = new ApiMain(
 			$this->newRequestContext( $parameters ), true
@@ -69,7 +69,7 @@ 
 
 	public function testGetParamDescription() {
 		$tdata = [ 'approach' => 'The actual approach: function or smw',
-		                'query'    => 'The query of the former' ];
+						'query'    => 'The query of the former' ];
 		$this->assertEquals( $this->ApiSFS->getParamDescription(), $tdata );
 	}
 

Spacing +16 added lines, -16 removed lines

@@ -24,11 +24,11 @@ 
 
 	protected function setUp(): void {
 		parent::setUp();
-		$parameters = [ 'action' => 'sformsselect', 'approach' => 'smw',
-		                     'query'  => 'abc', 'sep' => ',' ];
+		$parameters = ['action' => 'sformsselect', 'approach' => 'smw',
+		                     'query'  => 'abc', 'sep' => ','];
 
 		$this->ApiMain = new ApiMain(
-			$this->newRequestContext( $parameters ), true
+			$this->newRequestContext($parameters), true
 		);
 		$this->ApiSFS = new ApiSemanticFormsSelect(
 			$this->ApiMain, 'sformsselect'
@@ -36,15 +36,15 @@ 
 	}
 
 	protected function tearDown(): void {
-		unset( $this->ApiSFS );
-		unset( $this->ApiMain );
+		unset($this->ApiSFS);
+		unset($this->ApiMain);
 		parent::tearDown();
 	}
 
 
 	public function testCanConstruct() {
 
-		$apiMain = new ApiMain( $this->newRequestContext( [] ), true );
+		$apiMain = new ApiMain($this->newRequestContext([]), true);
 
 		$instance = new ApiSemanticFormsSelect(
 			$apiMain, 'sformsselect'
@@ -63,30 +63,30 @@ 
 	}
 
 	public function testGetDescription() {
-		$tdata = [ 'API for providing SemanticFormsSelect values' ];
-		$this->assertEquals( $this->ApiSFS->getDescription(), $tdata );
+		$tdata = ['API for providing SemanticFormsSelect values'];
+		$this->assertEquals($this->ApiSFS->getDescription(), $tdata);
 	}
 
 	public function testGetParamDescription() {
-		$tdata = [ 'approach' => 'The actual approach: function or smw',
-		                'query'    => 'The query of the former' ];
-		$this->assertEquals( $this->ApiSFS->getParamDescription(), $tdata );
+		$tdata = ['approach' => 'The actual approach: function or smw',
+		                'query'    => 'The query of the former'];
+		$this->assertEquals($this->ApiSFS->getParamDescription(), $tdata);
 	}
 
 	public function testGetVersion() {
 		$tdata = 'SFS\ApiSemanticFormsSelect: 1.1';
-		$this->assertEquals( $this->ApiSFS->getVersion(), $tdata );
+		$this->assertEquals($this->ApiSFS->getVersion(), $tdata);
 	}
 
 
-	private function newRequestContext( $request = [] ) {
+	private function newRequestContext($request = []) {
 
 		$context = new RequestContext();
 
-		if ( $request instanceof WebRequest ) {
-			$context->setRequest( $request );
+		if ($request instanceof WebRequest) {
+			$context->setRequest($request);
 		} else {
-			$context->setRequest( new FauxRequest( $request, true ) );
+			$context->setRequest(new FauxRequest($request, true));
 		}
 
 		return $context;