SemanticMediaWiki / SemanticFormsSelect

SemanticFormsSelect.hooks.php

Doc Comments +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 	 * This is attached to the MediaWiki 'ParserFirstCallInit' hook.

 	 *

 	 * @param $parser Parser

-	 * @return bool

+	 * @return null|boolean

 	 */

 	public static function onSemanticFormsSelectSetup ( & $parser ) {

 

Spacing +6 added lines, -6 removed lines

@@ -16,14 +16,14 @@ 
 	 * @param $parser Parser

 	 * @return bool

 	 */

-	public static function onSemanticFormsSelectSetup ( & $parser ) {

+	public static function onSemanticFormsSelectSetup(& $parser) {

 

-		if ( !defined( 'PF_VERSION' ) ) {

-			die( '<b>Error:</b><a href="https://github.com/SemanticMediaWiki/SemanticFormsSelect/">Semantic Forms Select</a> requires the <a href="https://www.mediawiki.org/wiki/Extension:PageForms">Page Forms</a> extension. Please install and activate this extension first.' );

+		if (!defined('PF_VERSION')) {

+			die('<b>Error:</b><a href="https://github.com/SemanticMediaWiki/SemanticFormsSelect/">Semantic Forms Select</a> requires the <a href="https://www.mediawiki.org/wiki/Extension:PageForms">Page Forms</a> extension. Please install and activate this extension first.');

 		}

 

-		if ( isset( $GLOBALS['wgPageFormsFormPrinter'] ) ) {

-			$GLOBALS['wgPageFormsFormPrinter']->registerInputType( \SFS\SemanticFormsSelectInput::class );

+		if (isset($GLOBALS['wgPageFormsFormPrinter'])) {

+			$GLOBALS['wgPageFormsFormPrinter']->registerInputType(\SFS\SemanticFormsSelectInput::class);

 		}

 

 		return true;

@@ -31,7 +31,7 @@ 
 	

 	public static function onRegistration() {

 

-		if ( isset( $GLOBALS['wgAPIModules'] ) ) {

+		if (isset($GLOBALS['wgAPIModules'])) {

 			$GLOBALS['wgAPIModules']['sformsselect'] = \SFS\ApiSemanticFormsSelect::class;

 		}

 	}

tests/bootstrap.php

Spacing +10 added lines, -10 removed lines

@@ -1,23 +1,23 @@ 
 <?php
 
-if ( PHP_SAPI !== 'cli' ) {
-	die( 'Not an entry point' );
+if (PHP_SAPI !== 'cli') {
+	die('Not an entry point');
 }
 
-error_reporting( E_ALL | E_STRICT );
-date_default_timezone_set( 'UTC' );
-ini_set( 'display_errors', 1 );
+error_reporting(E_ALL | E_STRICT);
+date_default_timezone_set('UTC');
+ini_set('display_errors', 1);
 
 global $IP;
 
 //if ( !is_readable( $autoloaderClassPath = __DIR__ . '/../../SemanticMediaWiki/tests/autoloader.php' ) ) {
-if ( !is_readable( $autoloaderClassPath = $IP . '/extensions/SemanticMediaWiki/tests/autoloader.php' ) ) {
-	die( "\nThe Semantic MediaWiki test autoloader is not available\n" );
+if (!is_readable($autoloaderClassPath = $IP.'/extensions/SemanticMediaWiki/tests/autoloader.php')) {
+	die("\nThe Semantic MediaWiki test autoloader is not available\n");
 }
 
 // if ( !class_exists( 'SemanticFormsSelect' ) || ( $version = SemanticFormsSelect::getVersion() ) === null ) {
-if ( ExtensionRegistry::getInstance()->isLoaded( 'SemanticFormsSelect' ) ) {
-	die( "\nSemantic Forms Select is not available, please check your Composer or LocalSettings.\n" );
+if (ExtensionRegistry::getInstance()->isLoaded('SemanticFormsSelect')) {
+	die("\nSemantic Forms Select is not available, please check your Composer or LocalSettings.\n");
 }
 
 //print sprintf( "\n%-20s%s\n", "Semantic Forms Select: ", ExtensionRegistry::getInstance()->isLoaded( 'SemanticFormsSelect' ) );
@@ -26,4 +26,4 @@ 
 $autoloader = require $autoloaderClassPath;
 //$autoloader->addPsr4( 'SFS\\Tests\\', __DIR__ . '/phpunit/Unit' );
 //$autoloader->addPsr4( 'SFS\\Tests\\Integration\\', __DIR__ . '/phpunit/Integration' );
-unset( $autoloader );
+unset($autoloader);

src/ApiSemanticFormsSelectRequestProcessor.php

Doc Comments +3 added lines

@@ -126,6 +126,9 @@
 		] );
 	}
 
+	/**
+	 * @param string $sep
+	 */
 	private function getFormattedValuesFrom( $sep, $values ) {
 
 		if ( strpos( $values, $sep ) === false ) {

Spacing +40 added lines, -40 removed lines

@@ -33,7 +33,7 @@ 
 	 *
 	 * @param Parser $parser
 	 */
-	public function __construct( Parser $parser ) {
+	public function __construct(Parser $parser) {
 		$this->parser = $parser;
 	}
 
@@ -42,7 +42,7 @@ 
 	 *
 	 * @param boolean $debugFlag
 	 */
-	public function setDebugFlag( $debugFlag ) {
+	public function setDebugFlag($debugFlag) {
 		$this->debugFlag = $debugFlag;
 	}
 
@@ -53,95 +53,95 @@ 
 	 *
 	 * @return string
 	 */
-	public function getJsonDecodedResultValuesForRequestParameters( array $parameters ) {
+	public function getJsonDecodedResultValuesForRequestParameters(array $parameters) {
 
-		if ( !isset( $parameters['query'] ) || !isset( $parameters['sep'] ) ) {
-			throw new InvalidArgumentException( 'Missing an query parameter' );
+		if (!isset($parameters['query']) || !isset($parameters['sep'])) {
+			throw new InvalidArgumentException('Missing an query parameter');
 		}
 
 		$this->parser->firstCallInit();
 		$json = [];
 
-		if ( isset( $parameters['approach'] ) && $parameters['approach'] == 'smw' ) {
-			$json = $this->doProcessQueryFor( $parameters['query'], $parameters['sep'] );
+		if (isset($parameters['approach']) && $parameters['approach'] == 'smw') {
+			$json = $this->doProcessQueryFor($parameters['query'], $parameters['sep']);
 		} else {
-			$json = $this->doProcessFunctionFor( $parameters['query'], $parameters['sep'] );
+			$json = $this->doProcessFunctionFor($parameters['query'], $parameters['sep']);
 		}
 
 		// I have no idea why we first encode and and then decode here??
 
-		return json_decode( $json );
+		return json_decode($json);
 	}
 
-	private function doProcessQueryFor( $querystr, $sep = "," ) {
+	private function doProcessQueryFor($querystr, $sep = ",") {
 
 		$querystr = str_replace(
-			[ "<", ">", "sep=;" ],
-			[ "<", ">", "sep={$sep};" ],
+			["&lt;", "&gt;", "sep=;"],
+			["<", ">", "sep={$sep};"],
 			$querystr
 		);
 
-		$rawparams = explode( ";", $querystr );
-		$f = str_replace( ";", "|", $rawparams[0] );
+		$rawparams = explode(";", $querystr);
+		$f = str_replace(";", "|", $rawparams[0]);
 
-		$rawparams[0] = $this->parser->replaceVariables( $f );
+		$rawparams[0] = $this->parser->replaceVariables($f);
 
-		if ( $this->debugFlag ) {
-			error_log( implode( "|", $rawparams ) );
+		if ($this->debugFlag) {
+			error_log(implode("|", $rawparams));
 		}
 
 		
-		list( $query, $params ) = QueryProcessor::getQueryAndParamsFromFunctionParams( $rawparams, SMW_OUTPUT_WIKI, QueryProcessor::INLINE_QUERY, false );
+		list($query, $params) = QueryProcessor::getQueryAndParamsFromFunctionParams($rawparams, SMW_OUTPUT_WIKI, QueryProcessor::INLINE_QUERY, false);
 			
-		$result = QueryProcessor::getResultFromQuery( $query, $params, SMW_OUTPUT_WIKI, QueryProcessor::INLINE_QUERY );
+		$result = QueryProcessor::getResultFromQuery($query, $params, SMW_OUTPUT_WIKI, QueryProcessor::INLINE_QUERY);
 		
 		
-		$values = $this->getFormattedValuesFrom( $sep, $result );
+		$values = $this->getFormattedValuesFrom($sep, $result);
 
-		return json_encode( [
+		return json_encode([
 			"values" => $values,
-			"count"  => count( $values )
-		] );
+			"count"  => count($values)
+		]);
 	}
 
-	private function doProcessFunctionFor( $query, $sep = "," ) {
+	private function doProcessFunctionFor($query, $sep = ",") {
 
 		$query = str_replace(
-			[ "&lt;", "&gt;", "sep=;" ],
-			[ "<", ">", "sep={$sep};" ],
+			["&lt;", "&gt;", "sep=;"],
+			["<", ">", "sep={$sep};"],
 			$query
 		);
 
-		$f = str_replace( ";", "|", $query );
+		$f = str_replace(";", "|", $query);
 
-		if ( $this->debugFlag ) {
-			error_log( $f );
+		if ($this->debugFlag) {
+			error_log($f);
 		}
 
 		$values = $this->getFormattedValuesFrom(
 			$sep,
-			$this->parser->replaceVariables( $f )
+			$this->parser->replaceVariables($f)
 		);
 
-		return json_encode( [
+		return json_encode([
 			"values" => $values,
-			"count"  => count( $values )
-		] );
+			"count"  => count($values)
+		]);
 	}
 
-	private function getFormattedValuesFrom( $sep, $values ) {
+	private function getFormattedValuesFrom($sep, $values) {
 
-		if ( strpos( $values, $sep ) === false ) {
-			return [ $values ];
+		if (strpos($values, $sep) === false) {
+			return [$values];
 		}
 
-		$values = explode( $sep, $values );
-		$values = array_map( "trim", $values );
-		$values = array_unique( $values );
+		$values = explode($sep, $values);
+		$values = array_map("trim", $values);
+		$values = array_unique($values);
 
 		// TODO: sorting here will destroy any sort defined in the query, e.g. in case sorting for labels (instead of mainlable)
 		//sort( $values );
-		array_unshift( $values, "" );
+		array_unshift($values, "");
 
 		return $values;
 	}

src/SemanticFormsSelectInput.php

Doc Comments +8 added lines, -2 removed lines

@@ -27,6 +27,12 @@ 
 
 	private $mSelectField;
 
+	/**
+	 * @param string $inputNumber
+	 * @param string $curValue
+	 * @param boolean $inputName
+	 * @param boolean $disabled
+	 */
 	public function __construct( $inputNumber, $curValue, $inputName, $disabled, $otherArgs ) {
 		parent::__construct( $inputNumber, $curValue, $inputName, $disabled, $otherArgs );
 
@@ -69,8 +75,8 @@ 
 	 *
 	 * @param    string $cur_value A single value or a list of values with separator
 	 * @param    string $input_name Name of the input including the template, e.g. Building[Part Of Site]
-	 * @param            $is_mandatory
-	 * @param            $is_disabled
+	 * @param            boolean $is_mandatory
+	 * @param            boolean $is_disabled
 	 * @param    string[] $other_args Array of other field parameters
 	 * @return string
 	 */

Spacing +69 added lines, -69 removed lines

@@ -27,11 +27,11 @@ 
 
 	private $mSelectField;
 
-	public function __construct( $inputNumber, $curValue, $inputName, $disabled, $otherArgs ) {
-		parent::__construct( $inputNumber, $curValue, $inputName, $disabled, $otherArgs );
+	public function __construct($inputNumber, $curValue, $inputName, $disabled, $otherArgs) {
+		parent::__construct($inputNumber, $curValue, $inputName, $disabled, $otherArgs);
 
 		// SelectField is a simple value object - we accept creating it in the constructor
-		$this->mSelectField = new SelectField( $GLOBALS['wgParser'] );
+		$this->mSelectField = new SelectField($GLOBALS['wgParser']);
 	}
 
 	public static function getName() {
@@ -59,8 +59,8 @@ 
 	 * This is currently just a wrapper for getHTML().
 	 */
 	public function getHtmlText() {
-		return self::getHTML( $this->mCurrentValue, $this->mInputName, $this->mIsMandatory, $this->mIsDisabled,
-			$this->mOtherArgs );
+		return self::getHTML($this->mCurrentValue, $this->mInputName, $this->mIsMandatory, $this->mIsDisabled,
+			$this->mOtherArgs);
 	}
 
 	/**
@@ -74,35 +74,35 @@ 
 	 * @param    string[] $other_args Array of other field parameters
 	 * @return string
 	 */
-	public function getHTML( $cur_value = "", $input_name = "", $is_mandatory, $is_disabled, Array $other_args ) {
+	public function getHTML($cur_value = "", $input_name = "", $is_mandatory, $is_disabled, Array $other_args) {
 		global $sfgFieldNum, $wgUser;
 
 		// shortcut to the SelectField object
 		$selectField = $this->mSelectField;
 
 		// get 'delimiter' before 'query' or 'function'
-		$selectField->setDelimiter( $other_args );
+		$selectField->setDelimiter($other_args);
 
-		if ( array_key_exists( "query", $other_args ) ) {
-			$selectField->setQuery( $other_args );
-		} elseif ( array_key_exists( "function", $other_args ) ) {
-			$selectField->setFunction( $other_args );
+		if (array_key_exists("query", $other_args)) {
+			$selectField->setQuery($other_args);
+		} elseif (array_key_exists("function", $other_args)) {
+			$selectField->setFunction($other_args);
 		}
 		
-		if ( array_key_exists( "label", $other_args ) ) {
-			$selectField->setLabel( $other_args );
+		if (array_key_exists("label", $other_args)) {
+			$selectField->setLabel($other_args);
 		}
 
 		// parameters are only required if values needs to be retrieved dynamically
-		if ( !$selectField->hasStaticValues() ) {
-			$selectField->setSelectIsMultiple( $other_args );
-			$selectField->setSelectTemplate( $input_name );
-			$selectField->setSelectField( $input_name );
-			$selectField->setValueTemplate( $other_args );
-			$selectField->setValueField( $other_args );
-			$selectField->setSelectRemove( $other_args );
-
-			$item = Output::addToHeadItem( $selectField->getData() );
+		if (!$selectField->hasStaticValues()) {
+			$selectField->setSelectIsMultiple($other_args);
+			$selectField->setSelectTemplate($input_name);
+			$selectField->setSelectField($input_name);
+			$selectField->setValueTemplate($other_args);
+			$selectField->setValueField($other_args);
+			$selectField->setSelectRemove($other_args);
+
+			$item = Output::addToHeadItem($selectField->getData());
 		}
 
 		Output::commitToParserOutput();
@@ -112,51 +112,51 @@ 
 		$extraatt = "";
 		$is_list = false;
 
-		if ( array_key_exists( 'is_list', $other_args ) && $other_args['is_list'] == true ) {
+		if (array_key_exists('is_list', $other_args) && $other_args['is_list'] == true) {
 			$is_list = true;
 		}
 
-		if ( $is_list ) {
+		if ($is_list) {
 			$extraatt = ' multiple="multiple" ';
 		}
 
-		if ( array_key_exists( "size", $other_args ) ) {
+		if (array_key_exists("size", $other_args)) {
 			$extraatt .= " size=\"{$other_args['size']}\"";
 		}
 
 		$classes = [];
-		if ( $is_mandatory ) {
+		if ($is_mandatory) {
 			$classes[] = "mandatoryField";
 		}
-		if ( array_key_exists( "class", $other_args ) ) {
+		if (array_key_exists("class", $other_args)) {
 			$classes[] = $other_args['class'];
 		}
-		if ( $classes ) {
-			$cstr = implode( " ", $classes );
+		if ($classes) {
+			$cstr = implode(" ", $classes);
 			$extraatt .= " class=\"$cstr\"";
 		}
 
 		$inname = $input_name;
-		if ( $is_list ) {
+		if ($is_list) {
 			$inname .= '[]';
 		}
 
 		// TODO Use Html::
 
 		$spanextra = $is_mandatory ? 'mandatoryFieldSpan' : '';
-		$is_single_select = (!$is_list) ? 'select-sfs-single' : '' ;
+		$is_single_select = (!$is_list) ? 'select-sfs-single' : '';
 		$ret = "<span class=\"inputSpan select-sfs $is_single_select $spanextra\"><select name='$inname' id='input_$sfgFieldNum' $extraatt>";
 
 		$curvalues = null;
-		if ( $cur_value ) {
-			if ( $cur_value === 'current user' ) {
+		if ($cur_value) {
+			if ($cur_value === 'current user') {
 				$cur_value = $wgUser->getName();
 			}
-			if ( is_array( $cur_value ) ) {
+			if (is_array($cur_value)) {
 				$curvalues = $cur_value;
 			} else {
 				// delimiter for $cur_value is always ',' - PF seems to ignore $wgPageFormsListSeparator
-				$curvalues = array_map( "trim", explode( $selectField->getDelimiter(), $cur_value ) );
+				$curvalues = array_map("trim", explode($selectField->getDelimiter(), $cur_value));
 			}
 
 		} else {
@@ -165,38 +165,38 @@ 
 
 		
 		$labelArray = [];
-		if ( array_key_exists( "label", $other_args ) && $curvalues ) {
+		if (array_key_exists("label", $other_args) && $curvalues) {
 			// $labelArray = $this->getLabels( $curvalues );
 		}
 
 		// TODO handle empty value case.
 		$ret .= "<option></option>";
 
-		if ( $selectField->hasStaticValues() ) {
+		if ($selectField->hasStaticValues()) {
 			
 			$values = $selectField->getValues();
 			
-			if ( array_key_exists( "label", $other_args ) && $values ) {
-				$labelArray = $this->getLabels( $values );
+			if (array_key_exists("label", $other_args) && $values) {
+				$labelArray = $this->getLabels($values);
 			}
 			
-			if ( is_array( $values ) ) {
+			if (is_array($values)) {
 				
-				foreach ( $values as $val ) {
+				foreach ($values as $val) {
 					
 					$selected = "";
 											
-					if ( array_key_exists( $val, $labelArray ) ) {
+					if (array_key_exists($val, $labelArray)) {
 					
-						if ( in_array( $labelArray[ $val ][0], $curvalues ) ) {
+						if (in_array($labelArray[$val][0], $curvalues)) {
 							$selected = " selected='selected'";
 						}
 						
-						$ret.="<option".$selected." value='".$labelArray[ $val ][0]."'>".$labelArray[ $val ][1]."</option>";
+						$ret .= "<option".$selected." value='".$labelArray[$val][0]."'>".$labelArray[$val][1]."</option>";
 					
 					} else {
 						
-						if ( in_array( $val, $curvalues ) ) {
+						if (in_array($val, $curvalues)) {
 							$selected = " selected='selected'";
 						}
 
@@ -206,22 +206,22 @@ 
 			}
 		} else {
 			
-			foreach ( $curvalues as $cur ) {
+			foreach ($curvalues as $cur) {
 				$selected = "";
 				
-				if ( array_key_exists( $cur, $labelArray ) ) {
+				if (array_key_exists($cur, $labelArray)) {
 					
-					if ( in_array( $labelArray[ $cur ][0], $curvalues ) ) {
+					if (in_array($labelArray[$cur][0], $curvalues)) {
 						$selected = " selected='selected'";
 					}
 					
-					$ret.="<option".$selected." value='".$labelArray[ $cur ][0]."'>".$labelArray[ $cur ][1]."</option>";
+					$ret .= "<option".$selected." value='".$labelArray[$cur][0]."'>".$labelArray[$cur][1]."</option>";
 					
 				} else {
-					if ( in_array( $cur, $curvalues ) ) {
+					if (in_array($cur, $curvalues)) {
 						$selected = " selected='selected'";
 					}
-					$ret.="<option".$selected.">$cur</option>";
+					$ret .= "<option".$selected.">$cur</option>";
 				}
 			}
 
@@ -230,8 +230,8 @@ 
 		$ret .= "</select></span>";
 		$ret .= "<span id=\"info_$sfgFieldNum\" class=\"errorMessage\"></span>";
 
-		if ( $other_args["is_list"] ) {
-			$hiddenname = $input_name . '[is_list]';
+		if ($other_args["is_list"]) {
+			$hiddenname = $input_name.'[is_list]';
 			$ret .= "<input type='hidden' name='$hiddenname' value='1' />";
 		}
 
@@ -239,49 +239,49 @@ 
 	}
 	
 		
-	private function getLabels( $labels ) {
+	private function getLabels($labels) {
 		
-		$labelArray = [ ];
+		$labelArray = [];
 
-		if ( is_array( $labels ) ) {
-			foreach ( $labels as $label ) {
+		if (is_array($labels)) {
+			foreach ($labels as $label) {
 				
 				$labelKey = $label;
 				$labelValue = $label;
 				
 				// Tricky thing if ( ) already in name
-				if ( strpos( $label, ")" ) && strpos( $label, "(" ) ) {
+				if (strpos($label, ")") && strpos($label, "(")) {
 				
 					// Check Break
 					$openBr = 0;
 					$doneBr = 0;
 					$num = 0;
 					
-					$labelArr = str_split ( $label );
+					$labelArr = str_split($label);
 					
-					$end = count( $labelArr ) - 1;
+					$end = count($labelArr) - 1;
 					$iter = $end;
 					
 					$endBr = $end;
 					$startBr = 0;
 					
-					while ( $doneBr == 0 && $iter >= 0 ) {
+					while ($doneBr == 0 && $iter >= 0) {
 					
-						$char = $labelArr[ $iter ];
+						$char = $labelArr[$iter];
 						
-						if ( $char == ")" ) {
+						if ($char == ")") {
 							$openBr = $openBr - 1;
 							
-							if ( $num == 0 ) {
+							if ($num == 0) {
 								$endBr = $iter;
 								$num = $num + 1;
 							}
 						}
 						
-						if ( $char == "(" ) {
+						if ($char == "(") {
 							$openBr = $openBr + 1;
 							
-							if ( $num > 0 && $openBr == 0 ) {
+							if ($num > 0 && $openBr == 0) {
 								$startBr = $iter;
 								$doneBr = 1;
 							}
@@ -291,12 +291,12 @@ 
 						
 					}
 					
-					$labelValue = implode( "", array_slice( $labelArr, $startBr+1, $endBr-$startBr-1 ) );			
-					$labelKey = implode( "", array_slice( $labelArr, 0, $startBr-1 ) );
+					$labelValue = implode("", array_slice($labelArr, $startBr + 1, $endBr - $startBr - 1));			
+					$labelKey = implode("", array_slice($labelArr, 0, $startBr - 1));
 				
 				}
 				
-				$labelArray[ $label ] = [ $labelKey, $labelValue ] ;
+				$labelArray[$label] = [$labelKey, $labelValue];
 			}
 		
 		}

tests/phpunit/Unit/ApiSemanticFormsSelectRequestProcessorTest.php

Indentation +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 	) {
 
 		$parameters = [ 'approach' => 'smw', 'query' => 'foo, baa, gaah',
-		                     'sep'      => ',' ];
+							 'sep'      => ',' ];
 
 		$this->assertInternalType(
 			'object',
@@ -91,7 +91,7 @@ 
 	public function testSetDebugFlag_doProcessQueryFor() {
 		$this->ApiSFSRP->setDebugFlag( true );
 		$parameters = [ 'approach' => 'smw', 'query' => 'my Query,query2',
-		                     'sep'      => ',' ];
+							 'sep'      => ',' ];
 
 		$this->assertInternalType(
 			'object',

Spacing +20 added lines, -20 removed lines

@@ -24,13 +24,13 @@ 
 
 	protected function setUp() {
 		parent::setUp();
-		$parser = $this->getMockBuilder( '\Parser' )
+		$parser = $this->getMockBuilder('\Parser')
 			->disableOriginalConstructor()->getMock();
-		$this->ApiSFSRP = new ApiSemanticFormsSelectRequestProcessor( $parser );
+		$this->ApiSFSRP = new ApiSemanticFormsSelectRequestProcessor($parser);
 	}
 
 	protected function tearDown() {
-		unset( $this->ApiSFSRP );
+		unset($this->ApiSFSRP);
 		parent::tearDown();
 	}
 
@@ -44,7 +44,7 @@ 
 
 		$parameters = [];
 
-		$this->setExpectedException( 'InvalidArgumentException' );
+		$this->setExpectedException('InvalidArgumentException');
 		$this->ApiSFSRP->getJsonDecodedResultValuesForRequestParameters(
 			$parameters
 		);
@@ -52,7 +52,7 @@ 
 
 	public function testJsonResultValuesFromRequestParameters() {
 
-		$parameters = [ 'query' => 'foo', 'sep' => ',' ];
+		$parameters = ['query' => 'foo', 'sep' => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -65,8 +65,8 @@ 
 	public function testJsonResultValuesFromRequestParameters_doProcessQueryFor(
 	) {
 
-		$parameters = [ 'approach' => 'smw', 'query' => 'foo, baa, gaah',
-		                     'sep'      => ',' ];
+		$parameters = ['approach' => 'smw', 'query' => 'foo, baa, gaah',
+		                     'sep'      => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -77,8 +77,8 @@ 
 	}
 
 	public function testSetDebugFlag() {
-		$this->ApiSFSRP->setDebugFlag( true );
-		$parameters = [ 'query' => 'foo , function', 'sep' => ',' ];
+		$this->ApiSFSRP->setDebugFlag(true);
+		$parameters = ['query' => 'foo , function', 'sep' => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -89,9 +89,9 @@ 
 	}
 
 	public function testSetDebugFlag_doProcessQueryFor() {
-		$this->ApiSFSRP->setDebugFlag( true );
-		$parameters = [ 'approach' => 'smw', 'query' => 'my Query,query2',
-		                     'sep'      => ',' ];
+		$this->ApiSFSRP->setDebugFlag(true);
+		$parameters = ['approach' => 'smw', 'query' => 'my Query,query2',
+		                     'sep'      => ','];
 
 		$this->assertInternalType(
 			'object',
@@ -104,11 +104,11 @@ 
 	public function testGetFormattedValuesFrom() {
 		$sep = ",";
 		$values = "my Query,query2";
-		$result = [ "", "my Query", "query2" ];
+		$result = ["", "my Query", "query2"];
 		$formattedValues = $this->invokeMethod(
-			$this->ApiSFSRP, 'getFormattedValuesFrom', [ $sep, $values ]
+			$this->ApiSFSRP, 'getFormattedValuesFrom', [$sep, $values]
 		);
-		$this->assertEquals( $result, $formattedValues );
+		$this->assertEquals($result, $formattedValues);
 	}
 
 	/**
@@ -120,14 +120,14 @@ 
 	 *
 	 * @return mixed Method return.
 	 */
-	public function invokeMethod( &$object, $methodName,
+	public function invokeMethod(&$object, $methodName,
 		array $parameters = []
 	) {
-		$reflection = new \ReflectionClass( get_class( $object ) );
-		$method = $reflection->getMethod( $methodName );
-		$method->setAccessible( true );
+		$reflection = new \ReflectionClass(get_class($object));
+		$method = $reflection->getMethod($methodName);
+		$method->setAccessible(true);
 
-		return $method->invokeArgs( $object, $parameters );
+		return $method->invokeArgs($object, $parameters);
 	}
 
 

tests/phpunit/Unit/SemanticFormsSelectInputTest.php

Indentation +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 		$isDisabled = false;
 
 		$otherArgs = [ 'template' => 'Foo', 'field' => '',
-		                    'function' => 'Bar', 'is_list' => true ];
+							'function' => 'Bar', 'is_list' => true ];
 
 		$parserOutput = $this->getMockBuilder( '\ParserOutput' )
 			->disableOriginalConstructor()->getMock();

Spacing +10 added lines, -10 removed lines

@@ -25,17 +25,17 @@ 
 		$isMandatory = false;
 		$isDisabled = false;
 
-		$otherArgs = [ 'template' => 'Foo', 'field' => '',
-		                    'function' => 'Bar', 'is_list' => true ];
+		$otherArgs = ['template' => 'Foo', 'field' => '',
+		                    'function' => 'Bar', 'is_list' => true];
 
-		$parserOutput = $this->getMockBuilder( '\ParserOutput' )
+		$parserOutput = $this->getMockBuilder('\ParserOutput')
 			->disableOriginalConstructor()->getMock();
 
-		$parser = $this->getMockBuilder( '\Parser' )
+		$parser = $this->getMockBuilder('\Parser')
 			->disableOriginalConstructor()->getMock();
 
-		$parser->expects( $this->any() )->method( 'getOutput' )->will(
-				$this->returnValue( $parserOutput )
+		$parser->expects($this->any())->method('getOutput')->will(
+				$this->returnValue($parserOutput)
 			);
 		$this->SFSInput = new SemanticFormsSelectInput(
 			$value, $inputName, $isMandatory, $isDisabled, $otherArgs
@@ -43,7 +43,7 @@ 
 	}
 
 	protected function tearDown() {
-		unset( $this->SelectField );
+		unset($this->SelectField);
 		parent::tearDown();
 	}
 
@@ -70,14 +70,14 @@ 
 
 	public function testGetParameters() {
 
-		$this->assertInternalType( 'array', $this->SFSInput->getParameters() );
+		$this->assertInternalType('array', $this->SFSInput->getParameters());
 	}
 
 
 	public function testGetResourceModuleNames() {
-		$rsmn = [ 'ext.sf_select.scriptselect' ];
+		$rsmn = ['ext.sf_select.scriptselect'];
 
-		$this->assertEquals( $rsmn, $this->SFSInput->getResourceModuleNames() );
+		$this->assertEquals($rsmn, $this->SFSInput->getResourceModuleNames());
 	}
 
 }

tests/phpunit/Unit/ApiSemanticFormsSelectTest.php

Indentation +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
 	protected function setUp() {
 		parent::setUp();
 		$parameters = [ 'action' => 'sformsselect', 'approach' => 'smw',
-		                     'query'  => 'abc', 'sep' => ',' ];
+							 'query'  => 'abc', 'sep' => ',' ];
 
 		$this->ApiMain = new ApiMain(
 			$this->newRequestContext( $parameters ), true
@@ -69,7 +69,7 @@ 
 
 	public function testGetParamDescription() {
 		$tdata = [ 'approach' => 'The actual approach: function or smw',
-		                'query'    => 'The query of the former' ];
+						'query'    => 'The query of the former' ];
 		$this->assertEquals( $this->ApiSFS->getParamDescription(), $tdata );
 	}
 

Spacing +16 added lines, -16 removed lines

@@ -24,11 +24,11 @@ 
 
 	protected function setUp() {
 		parent::setUp();
-		$parameters = [ 'action' => 'sformsselect', 'approach' => 'smw',
-		                     'query'  => 'abc', 'sep' => ',' ];
+		$parameters = ['action' => 'sformsselect', 'approach' => 'smw',
+		                     'query'  => 'abc', 'sep' => ','];
 
 		$this->ApiMain = new ApiMain(
-			$this->newRequestContext( $parameters ), true
+			$this->newRequestContext($parameters), true
 		);
 		$this->ApiSFS = new ApiSemanticFormsSelect(
 			$this->ApiMain, 'sformsselect'
@@ -36,15 +36,15 @@ 
 	}
 
 	protected function tearDown() {
-		unset( $this->ApiSFS );
-		unset( $this->ApiMain );
+		unset($this->ApiSFS);
+		unset($this->ApiMain);
 		parent::tearDown();
 	}
 
 
 	public function testCanConstruct() {
 
-		$apiMain = new ApiMain( $this->newRequestContext( [] ), true );
+		$apiMain = new ApiMain($this->newRequestContext([]), true);
 
 		$instance = new ApiSemanticFormsSelect(
 			$apiMain, 'sformsselect'
@@ -63,30 +63,30 @@ 
 	}
 
 	public function testGetDescription() {
-		$tdata = [ 'API for providing SemanticFormsSelect values' ];
-		$this->assertEquals( $this->ApiSFS->getDescription(), $tdata );
+		$tdata = ['API for providing SemanticFormsSelect values'];
+		$this->assertEquals($this->ApiSFS->getDescription(), $tdata);
 	}
 
 	public function testGetParamDescription() {
-		$tdata = [ 'approach' => 'The actual approach: function or smw',
-		                'query'    => 'The query of the former' ];
-		$this->assertEquals( $this->ApiSFS->getParamDescription(), $tdata );
+		$tdata = ['approach' => 'The actual approach: function or smw',
+		                'query'    => 'The query of the former'];
+		$this->assertEquals($this->ApiSFS->getParamDescription(), $tdata);
 	}
 
 	public function testGetVersion() {
 		$tdata = 'SFS\ApiSemanticFormsSelect: 1.1';
-		$this->assertEquals( $this->ApiSFS->getVersion(), $tdata );
+		$this->assertEquals($this->ApiSFS->getVersion(), $tdata);
 	}
 
 
-	private function newRequestContext( $request = [] ) {
+	private function newRequestContext($request = []) {
 
 		$context = new RequestContext();
 
-		if ( $request instanceof WebRequest ) {
-			$context->setRequest( $request );
+		if ($request instanceof WebRequest) {
+			$context->setRequest($request);
 		} else {
-			$context->setRequest( new FauxRequest( $request, true ) );
+			$context->setRequest(new FauxRequest($request, true));
 		}
 
 		return $context;

tests/phpunit/Unit/OutputTest.php

Spacing +6 added lines, -6 removed lines

@@ -24,24 +24,24 @@
 	}
 
 	protected function tearDown() {
-		unset( $this->data );
+		unset($this->data);
 		parent::tearDown();
 	}
 
 	public function testCanConstruct() {
-		$this->assertInstanceOf( '\SFS\Output', new Output() );
+		$this->assertInstanceOf('\SFS\Output', new Output());
 	}
 
 	public function testAddToHeadItem() {
-		$ret = Output::addToHeadItem( $this->data );
+		$ret = Output::addToHeadItem($this->data);
 
-		$this->assertArrayHasKey( 'Foo', $ret );
-		$this->assertArrayHasKey( 'Spam', $ret );
+		$this->assertArrayHasKey('Foo', $ret);
+		$this->assertArrayHasKey('Spam', $ret);
 	}
 
 	public function testCommitToParserOutput() {
 		global $wgOut;
-		$expected_result = '[' . json_encode( $this->data ) . ']';
+		$expected_result = '['.json_encode($this->data).']';
 		Output::commitToParserOutput();
 		$this->assertEquals(
 			$expected_result, $wgOut->getJsConfigVars()['sf_select']

src/Output.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
 	 *
 	 * @param array $data
 	 */
-	public static function addToHeadItem( Array $data = [] ) {
+	public static function addToHeadItem(Array $data = []) {
 		return self::$headItems[] = $data;
 	}
 
@@ -35,11 +35,11 @@ 
 	 *
 	 */
 	public static function commitToParserOutput() {
-		global $wgOut;	# is there a better way to get $output/$parser without using a global? (testability!)
+		global $wgOut; # is there a better way to get $output/$parser without using a global? (testability!)
 
 		// to be used in JS like:
 		// var SFSelect_fobjs = $.parseJSON( mw.config.get( 'sf_select' ) );
-		$wgOut->addJsConfigVars('sf_select', json_encode( self::$headItems ));
+		$wgOut->addJsConfigVars('sf_select', json_encode(self::$headItems));
 
 		//self::$resourceModules = array();
 		//self::$headItems = array();