Completed
Pull Request — master (#36)
by
unknown
20:47
created
src/ByHttpRequest/JsonResponseParser.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	/**
112 112
 	 * @since 1.0
113 113
 	 *
114
-	 * @return array
114
+	 * @return string
115 115
 	 */
116 116
 	public function getRawResponseResult() {
117 117
 		return $this->rawResponseResult;
@@ -192,6 +192,9 @@  discard block
 block discarded – undo
192 192
 		}
193 193
 	}
194 194
 
195
+	/**
196
+	 * @param string $hash
197
+	 */
195 198
 	private function addPropertyValues( $hash, $pk, $pvalues ) {
196 199
 
197 200
 		$property = DIProperty::newFromUserLabel( $pk );
Please login to merge, or discard this patch.
tests/phpunit/Unit/ByHttpRequest/CannedResultArrayTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -284,6 +284,9 @@
 block discarded – undo
284 284
 		);
285 285
 	}
286 286
 
287
+	/**
288
+	 * @param CannedResultArray $instance
289
+	 */
287 290
 	private function assertDataItem( $dataItem, $instance ) {
288 291
 
289 292
 		$this->assertEquals(
Please login to merge, or discard this patch.
src/DataValueDeserializer.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 *
86 86
 	 * @param array $value
87 87
 	 *
88
-	 * @return DIWikiPage|false
88
+	 * @return boolean
89 89
 	 */
90 90
 	public function newDiWikiPage( array $value ) {
91 91
 
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
 		return new DIBlob( $this->embeddedLinksReplacer->replace( $value ) );
128 128
 	}
129 129
 
130
+	/**
131
+	 * @param DIProperty $property
132
+	 */
130 133
 	private function newDataValueFromPropertyObject( $property, $value ) {
131 134
 
132 135
 		try{
@@ -138,6 +141,9 @@  discard block
 block discarded – undo
138 141
 		return $dv;
139 142
 	}
140 143
 
144
+	/**
145
+	 * @param DIProperty $property
146
+	 */
141 147
 	private function newDataValueFromDataItem( $property, $dataItem = false ) {
142 148
 
143 149
 		if ( $dataItem === false ) {
Please login to merge, or discard this patch.
src/ByHttpRequest/QueryResultFetcher.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -66,6 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * @param HttpRequestFactory $httpRequestFactory
67 67
 	 * @param QueryResultFactory $queryResultFactory
68 68
 	 * @param JsonResponseParser $jsonResponseParser
69
+	 * @param boolean $credentials
69 70
 	 */
70 71
 	public function __construct( HttpRequestFactory $httpRequestFactory, QueryResultFactory $queryResultFactory, JsonResponseParser $jsonResponseParser, $credentials ) {
71 72
 		$this->httpRequestFactory = $httpRequestFactory;
@@ -219,6 +220,9 @@  discard block
 block discarded – undo
219 220
 		return $queryResult;
220 221
 	}
221 222
 
223
+	/**
224
+	 * @param Query $query
225
+	 */
222 226
 	private function doResetPrintRequestsToQuerySource( $query ) {
223 227
 
224 228
 		$querySource = $query->getQuerySource();
@@ -239,6 +243,9 @@  discard block
 block discarded – undo
239 243
 		}
240 244
 	}
241 245
 
246
+	/**
247
+	 * @param Query $query
248
+	 */
242 249
 	private function doMakeHttpRequestFor( $query ) {
243 250
 
244 251
 		$httpRequest = $this->httpRequestFactory->newCachedCurlRequest();
Please login to merge, or discard this patch.