Completed
Pull Request — master (#4)
by mw
01:12
created
src/DatabaseLogReader.php 1 patch
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 *
67 67
 	 * @since 1.0
68 68
 	 *
69
-	 * @return array of parameters for SELECT call
69
+	 * @return string of parameters for SELECT call
70 70
 	 */
71 71
 	public function getQuery() {
72 72
 		return $this->query;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	 * @param Title|null $title
97 97
 	 * @param string $type
98 98
 	 *
99
-	 * @return Timestamp
99
+	 * @return MWTimestamp|null
100 100
 	 */
101 101
 	public function getDateOfLogEntry( Title $title = null, $type = 'approval' ) {
102 102
 
@@ -128,6 +128,8 @@  discard block
 block discarded – undo
128 128
 
129 129
 	/**
130 130
 	 * Take care of loading from the cache or filling the query.
131
+	 * @param null|Title $title
132
+	 * @param string $type
131 133
 	 */
132 134
 	private function init( $title, $type ) {
133 135
 
Please login to merge, or discard this patch.
src/Hooks.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 	 *
154 154
 	 * @since 1.0
155 155
 	 *
156
-	 * @param ProertyRegistry $$registry
156
+	 * @param ProertyRegistry $registry
157 157
 	 * @param integer &$latestRevID
158 158
 	 */
159 159
 	public function onInitProperties( $registry ) {
@@ -169,7 +169,6 @@  discard block
 block discarded – undo
169 169
 	 *
170 170
 	 * @since 1.0
171 171
 	 *
172
-	 * @param ProertyRegistry $$registry
173 172
 	 * @param integer &$latestRevID
174 173
 	 */
175 174
 	public function onUpdateDataBefore( $store, $semanticData ) {
Please login to merge, or discard this patch.
src/PropertyAnnotator.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -68,6 +68,9 @@
 block discarded – undo
68 68
 		);
69 69
 	}
70 70
 
71
+	/**
72
+	 * @param \SMW\DIWikiPage $subject
73
+	 */
71 74
 	private function canAnnotate( $subject ) {
72 75
 
73 76
 		if ( $subject === null || $subject->getTitle() === null || $subject->getTitle()->isSpecialPage() ) {
Please login to merge, or discard this patch.
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -3,12 +3,7 @@
 block discarded – undo
3 3
 namespace SMW\ApprovedRevs;
4 4
 
5 5
 use Psr\Log\LoggerAwareTrait;
6
-use SMW\DIProperty;
7 6
 use SMW\SemanticData;
8
-use SMW\ApprovedRevs\PropertyAnnotators\ApprovedStatusPropertyAnnotator;
9
-use SMW\ApprovedRevs\PropertyAnnotators\ApprovedByPropertyAnnotator;
10
-use SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator;
11
-use SMW\ApprovedRevs\PropertyAnnotators\ApprovedRevPropertyAnnotator;
12 7
 
13 8
 /**
14 9
  * @private
Please login to merge, or discard this patch.
src/PropertyAnnotators/ApprovedDatePropertyAnnotator.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use SMWDITime as DITime;;
8 8
 use SMW\ApprovedRevs\DatabaseLogReader;
9 9
 use SMW\ApprovedRevs\PropertyRegistry;
10
-use User;
11 10
 
12 11
 /**
13 12
  * @private
Please login to merge, or discard this patch.
tests/phpunit/Unit/PropertyAnnotators/ApprovedByPropertyAnnotatorTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SMW\ApprovedRevs\Tests\PropertyAnnotators;
4 4
 
5 5
 use SMW\ApprovedRevs\PropertyAnnotators\ApprovedByPropertyAnnotator;
6
-use SMW\DIProperty;
7 6
 use SMW\DIWikiPage;
8 7
 use User;
9 8
 
Please login to merge, or discard this patch.
tests/phpunit/Unit/PropertyAnnotators/ApprovedDatePropertyAnnotatorTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SMW\ApprovedRevs\Tests\PropertyAnnotators;
4 4
 
5 5
 use SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator;
6
-use SMW\DIProperty;
7 6
 use MWTimestamp;
8 7
 use SMWDITime as DITime;
9 8
 
Please login to merge, or discard this patch.
tests/phpunit/Unit/PropertyAnnotators/ApprovedRevPropertyAnnotatorTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace SMW\ApprovedRevs\Tests\PropertyAnnotators;
4 4
 
5 5
 use SMW\ApprovedRevs\PropertyAnnotators\ApprovedRevPropertyAnnotator;
6
-use SMW\DIProperty;
7
-use SMW\DIWikiPage;
8 6
 use SMWDINumber as DINumber;
9 7
 
10 8
 /**
Please login to merge, or discard this patch.
phpunit/Unit/PropertyAnnotators/ApprovedStatusPropertyAnnotatorTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SMW\ApprovedRevs\Tests\PropertyAnnotators;
4 4
 
5 5
 use SMW\ApprovedRevs\PropertyAnnotators\ApprovedStatusPropertyAnnotator;
6
-use SMW\DIProperty;
7 6
 use SMWDIString as DIString;
8 7
 
9 8
 /**
Please login to merge, or discard this patch.
tests/phpunit/Unit/HooksTest.php 1 patch
Doc Comments   +18 added lines patch added patch discarded remove patch
@@ -39,6 +39,9 @@  discard block
 block discarded – undo
39 39
 		$this->callOnSMWStoreUpdateDataBefore( $instance );
40 40
 	}
41 41
 
42
+	/**
43
+	 * @param Hooks $instance
44
+	 */
42 45
 	public function callOnSMWLinksUpdateApprovedUpdate( $instance ) {
43 46
 
44 47
 		$handler = 'SMW::LinksUpdate::ApprovedUpdate';
@@ -59,6 +62,9 @@  discard block
 block discarded – undo
59 62
 		);
60 63
 	}
61 64
 
65
+	/**
66
+	 * @param Hooks $instance
67
+	 */
62 68
 	public function callOnSMWDataUpdaterSkipUpdate( $instance ) {
63 69
 
64 70
 		$handler = 'SMW::DataUpdater::SkipUpdate';
@@ -79,6 +85,9 @@  discard block
 block discarded – undo
79 85
 		);
80 86
 	}
81 87
 
88
+	/**
89
+	 * @param Hooks $instance
90
+	 */
82 91
 	public function callOnSMWParserChangeRevision( $instance ) {
83 92
 
84 93
 		$handler = 'SMW::Parser::ChangeRevision';
@@ -99,6 +108,9 @@  discard block
 block discarded – undo
99 108
 		);
100 109
 	}
101 110
 
111
+	/**
112
+	 * @param Hooks $instance
113
+	 */
102 114
 	public function callOnSMWFactboxOverrideRevisionID( $instance ) {
103 115
 
104 116
 		$handler = 'SMW::Factbox::OverrideRevisionID';
@@ -119,6 +131,9 @@  discard block
 block discarded – undo
119 131
 		);
120 132
 	}
121 133
 
134
+	/**
135
+	 * @param Hooks $instance
136
+	 */
122 137
 	public function callOnSMWInitProperties( $instance ) {
123 138
 
124 139
 		$handler = 'SMW::Property::initProperties';
@@ -137,6 +152,9 @@  discard block
 block discarded – undo
137 152
 		);
138 153
 	}
139 154
 
155
+	/**
156
+	 * @param Hooks $instance
157
+	 */
140 158
 	public function callOnSMWStoreUpdateDataBefore( $instance ) {
141 159
 
142 160
 		$handler = 'SMWStore::updateDataBefore';
Please login to merge, or discard this patch.