View GitHub Repository MailHookBundle

Schedule Inspection
Subscribe
Completed
Pull Request — master (#2)
by Evan
04:45
created
Status
Category
Toggle Patches
ApiService/MailgunApiService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@  discard block
 
 block discarded – undo
8 8 
 {
9 9 
     /**
10 10 
      * @param  array  $hook
11 
-     * @return HookInterface
11 
+     * @return DefaultHook
12 12 
      */
13 13 
     private function bindHook(array $hook)
14 14 
     {
 
@@ -16,7 +16,7 @@  discard block
 
 block discarded – undo
16 16 
     }
17 17
18 18 
     /**
19 
-     * @return array<HookInterface>
19 
+     * @return DefaultHook[]
20 20 
      */
21 21 
     public function bind()
22 22 
     {
Please login to merge, or discard this patch.
ApiService/SendgridApiService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@
 
 block discarded – undo
8 8 
 {
9 9 
     /**
10 10 
      * @param  array  $hook
11 
-     * @return HookInterface
11 
+     * @return DefaultHook
12 12 
      */
13 13 
     private function bindHook(array $hook)
14 14 
     {
Please login to merge, or discard this patch.
Event/UserMailHookEvent.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -49,7 +49,7 @@
 
 block discarded – undo
49 49 
      *
50 50 
      * @param UserInterface $user the user
51 51 
      *
52 
-     * @return this
52 
+     * @return UserMailHookEvent
53 53 
      */
54 54 
     public function setUser(UserInterface $user)
55 55 
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,7 @@
 
 block discarded – undo
27 27 
      * @param UserInterface $user
28 28 
      * @param array         $metaData
29 29 
      */
30 
-    public function __construct(UserInterface $user  = null, $name  = null, array $metaData = array())
30 
+    public function __construct(UserInterface $user = null, $name = null, array $metaData = array())
31 31 
     {
32 32 
         $this->name     = $name;
33 33 
         $this->user     = $user;
Please login to merge, or discard this patch.
Provider/ApiServiceProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -28,7 +28,7 @@
 
 block discarded – undo
28 28 
     /**
29 29 
      * @param string              $apiServiceName
30 30 
      * @param ApiServiceInterface $apiService
31 
-     * @return this
31 
+     * @return ApiServiceProvider
32 32 
      */
33 33 
     public function setApiService($apiServiceName, ApiServiceInterface $apiService)
34 34 
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -4,7 +4,6 @@
 
 block discarded – undo
4 4
5 5 
 use Swm\Bundle\MailHookBundle\ApiService\ApiServiceInterface;
6 6 
 use Symfony\Component\DependencyInjection\Exception\LogicException;
7 
-use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
8 7
9 8 
 class ApiServiceProvider implements ProviderInterface
10 9 
 {
Please login to merge, or discard this patch.
Service/MailHookService.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch 
@@ -30,7 +30,6 @@
 
 block discarded – undo
30 30 
     }
31 31
32 32 
     /**
33 
-     * @param  string $apiService
34 33 
      * @return array<HookInterface>
35 34 
      */
36 35 
     public function getHooksForService($serviceName)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch 
@@ -2,8 +2,6 @@
 
 block discarded – undo
2 2
3 3 
 namespace Swm\Bundle\MailHookBundle\Service;
4 4
5 
-use Swm\Bundle\MailHookBundle\ApiService\ApiServiceInterface;
6 
-use Swm\Bundle\MailHookBundle\Model as ApiServiceModel;
7 5 
 use Swm\Bundle\MailHookBundle\Provider\ProviderInterface;
8 6 
 use Symfony\Component\HttpFoundation\Request;
9 7
Please login to merge, or discard this patch.
tests/atoum.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -3,4 +3,4 @@
 
 block discarded – undo
3 3 
 $runner->addTestsFromDirectory(__DIR__.'/tests/units');
4 4
5 5 
 $script->noCodeCoverageForNamespaces('mageekguy', 'Symfony');
6 
-$script->bootstrapFile(__DIR__.DIRECTORY_SEPARATOR . 'tests' . DIRECTORY_SEPARATOR . 'bootstrap.php');
7 6 
\ No newline at end of file
7 
+$script->bootstrapFile(__DIR__.DIRECTORY_SEPARATOR.'tests'.DIRECTORY_SEPARATOR.'bootstrap.php');
8 8 
\ No newline at end of file
Please login to merge, or discard this patch.