Completed
Push — master ( 7d4021...e7c5b3 )
by wen
11:02
created
src/Http/Controllers/Auth/LoginController.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,10 +3,10 @@
 block discarded – undo
3 3
 namespace Sco\Admin\Http\Controllers\Auth;
4 4
 
5 5
 use Auth;
6
+use Illuminate\Foundation\Auth\AuthenticatesUsers;
6 7
 use Illuminate\Foundation\Validation\ValidatesRequests;
7 8
 use Illuminate\Http\Request;
8 9
 use Illuminate\Routing\Controller;
9
-use Illuminate\Foundation\Auth\AuthenticatesUsers;
10 10
 
11 11
 class LoginController extends Controller
12 12
 {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
      *
101 101
      * @param  Request $request
102 102
      *
103
-     * @return \Illuminate\Http\Response
103
+     * @return \Illuminate\Http\RedirectResponse
104 104
      */
105 105
     public function logout(Request $request)
106 106
     {
Please login to merge, or discard this patch.
src/Console/InstallCommand.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,6 @@
 block discarded – undo
3 3
 namespace Sco\Admin\Console;
4 4
 
5 5
 use Illuminate\Console\Command;
6
-use Symfony\Component\Process\Exception\ProcessFailedException;
7
-use Symfony\Component\Process\ExecutableFinder;
8
-use Symfony\Component\Process\Process;
9 6
 
10 7
 class InstallCommand extends Command
11 8
 {
Please login to merge, or discard this patch.
src/Http/Middleware/RouteAuthorize.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@
 block discarded – undo
4 4
 
5 5
 use Closure;
6 6
 use Illuminate\Auth\Access\AuthorizationException;
7
-use Route;
8 7
 use Illuminate\Contracts\Auth\Factory as Auth;
8
+use Route;
9 9
 
10 10
 class RouteAuthorize
11 11
 {
Please login to merge, or discard this patch.
src/View/Columns/Column.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -115,6 +115,9 @@
 block discarded – undo
115 115
         return $this->getValueFromObject($this->getModel(), $this->getName());
116 116
     }
117 117
 
118
+    /**
119
+     * @param Model $instance
120
+     */
118 121
     protected function getValueFromObject($instance, $name)
119 122
     {
120 123
         $parts = explode('.', $name);
Please login to merge, or discard this patch.
src/Form/Elements/File.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
      *
281 281
      * @param \Illuminate\Http\UploadedFile $file
282 282
      *
283
-     * @return mixed|string
283
+     * @return string
284 284
      */
285 285
     public function getUploadFileName(UploadedFile $file)
286 286
     {
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
         ];
356 356
     }
357 357
 
358
+    /**
359
+     * @param string $rule
360
+     */
358 361
     public function addValidationRule($rule, $message = null)
359 362
     {
360 363
         $uploadRules = [
Please login to merge, or discard this patch.
src/Providers/NavigationServiceProvider.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,10 @@
 block discarded – undo
3 3
 namespace Sco\Admin\Providers;
4 4
 
5 5
 use Illuminate\Support\ServiceProvider;
6
-use KodiComponents\Navigation\Contracts\NavigationInterface;
7
-use KodiComponents\Navigation\Navigation;
8 6
 use KodiComponents\Navigation\Contracts\BadgeInterface;
7
+use KodiComponents\Navigation\Contracts\NavigationInterface;
9 8
 use KodiComponents\Navigation\Contracts\PageInterface;
9
+use KodiComponents\Navigation\Navigation;
10 10
 use Sco\Admin\Navigation\Badge;
11 11
 use Sco\Admin\Navigation\Page;
12 12
 
Please login to merge, or discard this patch.
src/Form/Elements/Input.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@
 block discarded – undo
20 20
         return $this->size;
21 21
     }
22 22
 
23
+    /**
24
+     * @param string $value
25
+     */
23 26
     public function setSize($value)
24 27
     {
25 28
         $this->size = $value;
Please login to merge, or discard this patch.
src/Component/Concerns/HasAccess.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     /**
91 91
      * Get the observable ability names.
92 92
      *
93
-     * @return array
93
+     * @return string[]
94 94
      */
95 95
     public function getObservableAbilities()
96 96
     {
@@ -103,6 +103,10 @@  discard block
 block discarded – undo
103 103
         );
104 104
     }
105 105
 
106
+    /**
107
+     * @param string $ability
108
+     * @param string $callback
109
+     */
106 110
     public function registerAbility($ability, $callback)
107 111
     {
108 112
         $this->abilities->put($ability, $this->makeAbilityCallback($callback));
@@ -124,7 +128,7 @@  discard block
 block discarded – undo
124 128
     /**
125 129
      * @param string $ability
126 130
      *
127
-     * @return mixed
131
+     * @return boolean
128 132
      */
129 133
     final public function can($ability)
130 134
     {
Please login to merge, or discard this patch.
src/Component/Concerns/HasNavigation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     protected $priority = 100;
39 39
 
40 40
     /**
41
-     * @return mixed
41
+     * @return string
42 42
      */
43 43
     public function getPageId()
44 44
     {
Please login to merge, or discard this patch.