EntrustPermissionTrait::roles() - Code Metrics - Inspection of "merge entrust into admin" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 27aaeb...0eb7b3 )

by wen

created 2017-05-24 08:52 UTC

EntrustPermissionTrait::roles() A

↳ Parent: EntrustPermissionTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Sco\Admin\Traits;

/**
 * This file is part of Entrust,
 * a role & permission management solution for Laravel.
 *
 * @license MIT
 * @package Zizaco\Entrust
 */

use Illuminate\Support\Facades\Config;

trait EntrustPermissionTrait
{
    /**
     * Many-to-Many relations with role model.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function roles()
    {
        return $this->belongsToMany(Config::get('admin.role'),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Config::get('admin.permission_role_table'),
            Config::get('admin.permission_foreign_key'),
            Config::get('admin.role_foreign_key'));
    }

    /**
     * Boot the permission model
     * Attach event listener to remove the many-to-many records when trying to
     * delete Will NOT delete any records if the permission model uses soft
     * deletes.
     *
     * @return void|bool
     */
    public static function boot()

    {
        parent::boot();

        static::deleting(function ($permission) {
            if (!method_exists(Config::get('admin.permission'),
                'bootSoftDeletes')
            ) {
                $permission->roles()->sync([]);
            }

            return true;
        });
    }
}


1		<?php
2
3		namespace Sco\Admin\Traits;
4
5		/**
6		* This file is part of Entrust,
7		* a role & permission management solution for Laravel.
8		*
9		* @license MIT
10		* @package Zizaco\Entrust
11		*/
12
13		use Illuminate\Support\Facades\Config;
14
15		trait EntrustPermissionTrait
16		{
17		/**
18		* Many-to-Many relations with role model.
19		*
20		* @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
21		*/
22		public function roles()
23		{
24		return $this->belongsToMany(Config::get('admin.role'),
		0 ignored issues – show Bug introduced 2017-05-24 08:55 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25		Config::get('admin.permission_role_table'),
26		Config::get('admin.permission_foreign_key'),
27		Config::get('admin.role_foreign_key'));
28		}
29
30		/**
31		* Boot the permission model
32		* Attach event listener to remove the many-to-many records when trying to
33		* delete Will NOT delete any records if the permission model uses soft
34		* deletes.
35		*
36		* @return void\|bool
37		*/
38	View Code Duplication	public static function boot()
		0 ignored issues – show Duplication introduced 2017-05-24 08:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		parent::boot();
41
42		static::deleting(function ($permission) {
43		if (!method_exists(Config::get('admin.permission'),
44		'bootSoftDeletes')
45		) {
46		$permission->roles()->sync([]);
47		}
48
49		return true;
50		});
51		}
52		}
53

ScoLib / admin

Push — master ( 27aaeb...0eb7b3 )

EntrustPermissionTrait::roles() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like