Completed
Push — master ( 27aaeb...0eb7b3 )
by wen
03:21
created

EntrustPermissionTrait   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 38
Duplicated Lines 36.84 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 0
Metric Value
wmc 3
lcom 0
cbo 0
dl 14
loc 38
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A roles() 0 7 1
A boot() 14 14 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Sco\Admin\Traits;
4
5
/**
6
 * This file is part of Entrust,
7
 * a role & permission management solution for Laravel.
8
 *
9
 * @license MIT
10
 * @package Zizaco\Entrust
11
 */
12
13
use Illuminate\Support\Facades\Config;
14
15
trait EntrustPermissionTrait
16
{
17
    /**
18
     * Many-to-Many relations with role model.
19
     *
20
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
21
     */
22
    public function roles()
23
    {
24
        return $this->belongsToMany(Config::get('admin.role'),
0 ignored issues
show
Bug introduced by
It seems like belongsToMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
25
            Config::get('admin.permission_role_table'),
26
            Config::get('admin.permission_foreign_key'),
27
            Config::get('admin.role_foreign_key'));
28
    }
29
30
    /**
31
     * Boot the permission model
32
     * Attach event listener to remove the many-to-many records when trying to
33
     * delete Will NOT delete any records if the permission model uses soft
34
     * deletes.
35
     *
36
     * @return void|bool
37
     */
38 View Code Duplication
    public static function boot()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
39
    {
40
        parent::boot();
41
42
        static::deleting(function ($permission) {
43
            if (!method_exists(Config::get('admin.permission'),
44
                'bootSoftDeletes')
45
            ) {
46
                $permission->roles()->sync([]);
47
            }
48
49
            return true;
50
        });
51
    }
52
}
53