Handler::isAdmin() - Code Metrics - Inspection of "fix Exception Handler bug" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7968b0...17a3ac )

by wen

created 2017-06-02 07:51 UTC

Handler::isAdmin() A

↳ Parent: Handler

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
cc	2
eloc	2
nc	2
nop	1
crap	6

<?php

namespace Sco\Admin\Exceptions;

use Exception;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Contracts\Debug\ExceptionHandler as ExceptionHandlerContract;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class Handler implements ExceptionHandlerContract
{
    protected $parentHandler;

    public function __construct(ExceptionHandlerContract $parentHandler)
    {
        $this->parentHandler = $parentHandler;
    }

    /**
     * Report or log an exception.
     *
     * @param  \Exception $exception
     *
     * @return void
     * @throws \Exception
     */
    public function report(Exception $exception)
    {
        $this->parentHandler->report($exception);
    }

    /**
     * Render an exception into a response.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Exception               $exception
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function render($request, Exception $exception)
    {
        $exception = $this->prepareException($exception);

        if ($exception instanceof AuthenticationException) {
            $response = $this->unauthenticated($request, $exception);
        } elseif ($exception instanceof HttpException) {
            $response = $this->renderHttpException($request, $exception);
        }

        if ($response) {
            return $response;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        return $this->parentHandler->render($request, $exception);
    }

    /**
     * Render an exception to the console.
     *
     * @param  \Symfony\Component\Console\Output\OutputInterface $output
     * @param  \Exception                                        $exception
     *
     * @return void
     */
    public function renderForConsole($output, Exception $exception)
    {
        $this->parentHandler->renderForConsole($output, $exception);
    }

    /**
     * Prepare exception for rendering.
     *
     * @param  \Exception  $exception
     * @return \Exception
     */
    protected function prepareException(Exception $exception)
    {
        if ($exception instanceof ModelNotFoundException) {
            $exception = new NotFoundHttpException($exception->getMessage(), $exception);
        } elseif ($exception instanceof AuthorizationException) {
            $exception = new HttpException(403, $exception->getMessage() ?: 'Forbidden');
        }

        return $exception;
    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Illuminate\Auth\AuthenticationException  $exception
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $exception)

    {
        if ($request->expectsJson()) {
            return response('Unauthenticated.', 401);
        }

        if ($this->isAdmin($request)) {
            return redirect()->guest(route('admin.login'));
        }
    }

    /**
     * Render the given HttpException.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Symfony\Component\HttpKernel\Exception\HttpException  $exception
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function renderHttpException($request, HttpException $exception)
    {
        $status = $exception->getStatusCode();
        if ($request->expectsJson()) {
            return response($exception->getMessage() ?: 'Not Found', $status);
        }
        if ($this->isAdmin($request)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //return response()->view('admin::app', ['exception' => $exception], $status, $exception->getHeaders());

        }
    }

    protected function isAdmin($request)
    {
        return $request->route() && $request->route()->getPrefix() == 'admin';
    }
}


1			<?php
2
3			namespace Sco\Admin\Exceptions;
4
5			use Exception;
6			use Illuminate\Auth\Access\AuthorizationException;
7			use Illuminate\Auth\AuthenticationException;
8			use Illuminate\Contracts\Debug\ExceptionHandler as ExceptionHandlerContract;
9			use Illuminate\Database\Eloquent\ModelNotFoundException;
10			use Symfony\Component\HttpKernel\Exception\HttpException;
11			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
12
13			class Handler implements ExceptionHandlerContract
14			{
15			protected $parentHandler;
16
17			public function __construct(ExceptionHandlerContract $parentHandler)
18			{
19			$this->parentHandler = $parentHandler;
20			}
21
22			/**
23			* Report or log an exception.
24			*
25			* @param \Exception $exception
26			*
27			* @return void
28			* @throws \Exception
29			*/
30			public function report(Exception $exception)
31			{
32			$this->parentHandler->report($exception);
33			}
34
35			/**
36			* Render an exception into a response.
37			*
38			* @param \Illuminate\Http\Request $request
39			* @param \Exception $exception
40			*
41			* @return \Symfony\Component\HttpFoundation\Response
42			*/
43			public function render($request, Exception $exception)
44			{
45			$exception = $this->prepareException($exception);
46
47			if ($exception instanceof AuthenticationException) {
48			$response = $this->unauthenticated($request, $exception);
49			} elseif ($exception instanceof HttpException) {
50			$response = $this->renderHttpException($request, $exception);
51			}
52
53			if ($response) {
54			return $response;
			0 ignored issues – show Bug introduced 2017-06-02 07:54 UTC by Report Bug Copy Issue Report The variable `$response` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
55			}
56
57			return $this->parentHandler->render($request, $exception);
58			}
59
60			/**
61			* Render an exception to the console.
62			*
63			* @param \Symfony\Component\Console\Output\OutputInterface $output
64			* @param \Exception $exception
65			*
66			* @return void
67			*/
68			public function renderForConsole($output, Exception $exception)
69			{
70			$this->parentHandler->renderForConsole($output, $exception);
71			}
72
73			/**
74			* Prepare exception for rendering.
75			*
76			* @param \Exception $exception
77			* @return \Exception
78			*/
79			protected function prepareException(Exception $exception)
80			{
81			if ($exception instanceof ModelNotFoundException) {
82			$exception = new NotFoundHttpException($exception->getMessage(), $exception);
83			} elseif ($exception instanceof AuthorizationException) {
84			$exception = new HttpException(403, $exception->getMessage() ?: 'Forbidden');
85			}
86
87			return $exception;
88			}
89
90			/**
91			* Convert an authentication exception into an unauthenticated response.
92			*
93			* @param \Illuminate\Http\Request $request
94			* @param \Illuminate\Auth\AuthenticationException $exception
95			* @return \Illuminate\Http\Response
96			*/
97			protected function unauthenticated($request, AuthenticationException $exception)
			0 ignored issues – show Unused Code introduced 2017-05-31 08:01 UTC by Report Bug Copy Issue Report The parameter `$exception` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
98			{
99			if ($request->expectsJson()) {
100			return response('Unauthenticated.', 401);
101			}
102
103			if ($this->isAdmin($request)) {
104			return redirect()->guest(route('admin.login'));
105			}
106			}
107
108			/**
109			* Render the given HttpException.
110			*
111			* @param \Illuminate\Http\Request $request
112			* @param \Symfony\Component\HttpKernel\Exception\HttpException $exception
113			* @return \Symfony\Component\HttpFoundation\Response
114			*/
115			protected function renderHttpException($request, HttpException $exception)
116			{
117			$status = $exception->getStatusCode();
118			if ($request->expectsJson()) {
119			return response($exception->getMessage() ?: 'Not Found', $status);
120			}
121			if ($this->isAdmin($request)) {
			0 ignored issues – show Unused Code introduced 2017-06-02 07:54 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
122			//return response()->view('admin::app', ['exception' => $exception], $status, $exception->getHeaders());
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-06-02 07:54 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
123			}
124			}
125
126			protected function isAdmin($request)
127			{
128			return $request->route() && $request->route()->getPrefix() == 'admin';
129			}
130			}
131

ScoLib / admin

Push — master ( 7968b0...17a3ac )

Handler::isAdmin() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like