Sco\Admin\Exceptions\Handler

Complexity

Total Complexity

20

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	report()	0	4	1
A	render()	0	16	4
A	renderForConsole()	0	4	1
A	prepareException()	0	10	4
A	unauthenticated()	0	10	3
A	renderHttpException()	0	10	4
A	isAdmin()	0	4	2

<?php

namespace Sco\Admin\Exceptions;

use Exception;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Contracts\Debug\ExceptionHandler as ExceptionHandlerContract;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class Handler implements ExceptionHandlerContract
{
    protected $parentHandler;

    public function __construct(ExceptionHandlerContract $parentHandler)
    {
        $this->parentHandler = $parentHandler;
    }

    /**
     * Report or log an exception.
     *
     * @param  \Exception $exception
     *
     * @return void
     * @throws \Exception
     */
    public function report(Exception $exception)
    {
        $this->parentHandler->report($exception);
    }

    /**
     * Render an exception into a response.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Exception               $exception
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function render($request, Exception $exception)
    {
        $exception = $this->prepareException($exception);

        if ($exception instanceof AuthenticationException) {
            $response = $this->unauthenticated($request, $exception);
        } elseif ($exception instanceof HttpException) {
            $response = $this->renderHttpException($request, $exception);
        }

        if ($response) {
            return $response;

The variable $response does not seem to be defined for all execution paths leading up to this point.

        }

        return $this->parentHandler->render($request, $exception);
    }

    /**
     * Render an exception to the console.
     *
     * @param  \Symfony\Component\Console\Output\OutputInterface $output
     * @param  \Exception                                        $exception
     *
     * @return void
     */
    public function renderForConsole($output, Exception $exception)
    {
        $this->parentHandler->renderForConsole($output, $exception);
    }

    /**
     * Prepare exception for rendering.
     *
     * @param  \Exception  $exception
     * @return \Exception
     */
    protected function prepareException(Exception $exception)
    {
        if ($exception instanceof ModelNotFoundException) {
            $exception = new NotFoundHttpException($exception->getMessage(), $exception);
        } elseif ($exception instanceof AuthorizationException) {
            $exception = new HttpException(403, $exception->getMessage() ?: 'Forbidden');
        }

        return $exception;
    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Illuminate\Auth\AuthenticationException  $exception
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $exception)

The parameter $exception is not used and could be removed.

    {
        if ($request->expectsJson()) {
            return response('Unauthenticated.', 401);
        }

        if ($this->isAdmin($request)) {
            return redirect()->guest(route('admin.login'));
        }
    }

    /**
     * Render the given HttpException.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Symfony\Component\HttpKernel\Exception\HttpException  $exception
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function renderHttpException($request, HttpException $exception)
    {
        $status = $exception->getStatusCode();
        if ($request->expectsJson()) {
            return response($exception->getMessage() ?: 'Not Found', $status);
        }
        if ($this->isAdmin($request)) {

This if statement is empty and can be removed.

            //return response()->view('admin::app', ['exception' => $exception], $status, $exception->getHeaders());

70% of this comment could be valid code. Did you maybe forget this after debugging?

        }
    }

    protected function isAdmin($request)
    {
        return $request->route() && $request->route()->getPrefix() == 'admin';
    }
}