MultiSelect::__construct() - Code Metrics - Inspection of "form element date cast" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 10405b...259f27 )

by wen

created 2018-01-30 09:13 UTC

MultiSelect::__construct() A

↳ Parent: MultiSelect

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	4
nop	3

<?php

namespace Sco\Admin\Form\Elements;

use Illuminate\Database\Eloquent\Relations\BelongsToMany;
use Sco\Admin\Traits\HasSelectOptions;

class MultiSelect extends NamedElement
{
    use HasSelectOptions;

    protected $type = 'select';

    protected $defaultValue = [];

    /**
     *
     * @param string $name
     * @param string $title
     * @param array|Model $options
     */
    public function __construct(string $name, string $title, $options = null)
    {
        parent::__construct($name, $title);

        if (! is_null($options)) {
            $this->setOptions($options);
        }

        if (! ($this->isOptionsModel() && $this->isRelation())) {
            $this->setCast('json');
        }
    }

    public function getValue()
    {
        $value = parent::getValue();

        if ($this->isOptionsModel() && $this->isRelation()) {
            $model = $this->getOptionsModel();
            $key = $this->getOptionsValueAttribute() ?: $model->getKeyName();

            return collect($value)->pluck($key)->map(function ($item) {
                return (string) $item;
            });
        }

        return (array) $value;
    }

    public function save()
    {
        if (! ($this->isOptionsModel() && $this->isRelation())) {
            parent::save();
        }
    }

    public function finishSave()

    {
        if (! ($this->isOptionsModel() && $this->isRelation())) {
            return;
        }
        $attribute = $this->getName();
        $values = $this->getValueFromRequest();

        $relation = $this->getModel()->{$attribute}();
        if ($relation instanceof BelongsToMany) {
            $relation->sync($values);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }
    }

    protected function isRelation()
    {
        return method_exists($this->getModel(), $this->getName());
    }

    public function toArray()
    {
        return parent::toArray() + [
                'options'  => $this->getOptions(),
                'multiple' => true,
            ];
    }
}


1		<?php
2
3		namespace Sco\Admin\Form\Elements;
4
5		use Illuminate\Database\Eloquent\Relations\BelongsToMany;
6		use Sco\Admin\Traits\HasSelectOptions;
7
8		class MultiSelect extends NamedElement
9		{
10		use HasSelectOptions;
11
12		protected $type = 'select';
13
14		protected $defaultValue = [];
15
16		/**
17		*
18		* @param string $name
19		* @param string $title
20		* @param array\|Model $options
21		*/
22		public function __construct(string $name, string $title, $options = null)
23		{
24		parent::__construct($name, $title);
25
26		if (! is_null($options)) {
27		$this->setOptions($options);
28		}
29
30		if (! ($this->isOptionsModel() && $this->isRelation())) {
31		$this->setCast('json');
32		}
33		}
34
35		public function getValue()
36		{
37		$value = parent::getValue();
38
39		if ($this->isOptionsModel() && $this->isRelation()) {
40		$model = $this->getOptionsModel();
41		$key = $this->getOptionsValueAttribute() ?: $model->getKeyName();
42
43		return collect($value)->pluck($key)->map(function ($item) {
44		return (string) $item;
45		});
46		}
47
48		return (array) $value;
49		}
50
51		public function save()
52		{
53		if (! ($this->isOptionsModel() && $this->isRelation())) {
54		parent::save();
55		}
56		}
57
58	View Code Duplication	public function finishSave()
		0 ignored issues – show Duplication introduced 2017-09-20 09:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		if (! ($this->isOptionsModel() && $this->isRelation())) {
61		return;
62		}
63		$attribute = $this->getName();
64		$values = $this->getValueFromRequest();
65
66		$relation = $this->getModel()->{$attribute}();
67		if ($relation instanceof BelongsToMany) {
68		$relation->sync($values);
		0 ignored issues – show Bug introduced 2018-01-23 09:19 UTC by Report Bug Copy Issue Report It seems like `$values` defined by `$this->getValueFromRequest()` on line `64` can also be of type `string`; however, `Illuminate\Database\Eloq...sWithPivotTable::sync()` does only seem to accept `object<Illuminate\Databa...pport\Collection>\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
69		}
70		}
71
72		protected function isRelation()
73		{
74		return method_exists($this->getModel(), $this->getName());
75		}
76
77		public function toArray()
78		{
79		return parent::toArray() + [
80		'options' => $this->getOptions(),
81		'multiple' => true,
82		];
83		}
84		}
85

ScoLib / admin

Push — master ( 10405b...259f27 )

MultiSelect::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like