Sco\Admin\Form\Elements\MultiSelect

Complexity

Total Complexity

17

Size/Duplication

Total Lines	77
Duplicated Lines	16.88 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	4
A	getValue()	0	15	4
A	save()	0	6	3
A	finishSave()	13	13	4
A	isRelation()	0	4	1
A	toArray()	0	7	1

<?php

namespace Sco\Admin\Form\Elements;

use Illuminate\Database\Eloquent\Relations\BelongsToMany;
use Sco\Admin\Traits\HasSelectOptions;

class MultiSelect extends NamedElement
{
    use HasSelectOptions;

    protected $type = 'select';

    protected $defaultValue = [];

    /**
     *
     * @param string $name
     * @param string $title
     * @param array|Model $options
     */
    public function __construct(string $name, string $title, $options = null)
    {
        parent::__construct($name, $title);

        if (! is_null($options)) {
            $this->setOptions($options);
        }

        if (! ($this->isOptionsModel() && $this->isRelation())) {
            $this->setCast('json');
        }
    }

    public function getValue()
    {
        $value = parent::getValue();

        if ($this->isOptionsModel() && $this->isRelation()) {
            $model = $this->getOptionsModel();
            $key = $this->getOptionsValueAttribute() ?: $model->getKeyName();

            return collect($value)->pluck($key)->map(function ($item) {
                return (string) $item;
            });
        }

        return (array) $value;
    }

    public function save()
    {
        if (! ($this->isOptionsModel() && $this->isRelation())) {
            parent::save();
        }
    }

    public function finishSave()

This method seems to be duplicated in your project.

    {
        if (! ($this->isOptionsModel() && $this->isRelation())) {
            return;
        }
        $attribute = $this->getName();
        $values = $this->getValueFromRequest();

        $relation = $this->getModel()->{$attribute}();
        if ($relation instanceof BelongsToMany) {
            $relation->sync($values);

It seems like $values defined by $this->getValueFromRequest() on line 64 can also be of type string; however, Illuminate\Database\Eloquent\Relations\Concerns\InteractsWithPivotTable::sync() does only seem to accept object<Illuminate\Database\Eloquent\Collection>|object<Illuminate\Support\Collection>|array, maybe add an additional type check?

        }
    }

    protected function isRelation()
    {
        return method_exists($this->getModel(), $this->getName());
    }

    public function toArray()
    {
        return parent::toArray() + [
                'options'  => $this->getOptions(),
                'multiple' => true,
            ];
    }
}