Completed
Push — master ( 248726...ad47fd )
by wen
27:35 queued 12:36
created
src/Http/Controllers/Auth/LoginController.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,10 +3,10 @@
 block discarded – undo
3 3
 namespace Sco\Admin\Http\Controllers\Auth;
4 4
 
5 5
 use Auth;
6
+use Illuminate\Foundation\Auth\AuthenticatesUsers;
6 7
 use Illuminate\Foundation\Validation\ValidatesRequests;
7 8
 use Illuminate\Http\Request;
8 9
 use Illuminate\Routing\Controller;
9
-use Illuminate\Foundation\Auth\AuthenticatesUsers;
10 10
 
11 11
 class LoginController extends Controller
12 12
 {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
      *
101 101
      * @param  Request $request
102 102
      *
103
-     * @return \Illuminate\Http\Response
103
+     * @return \Illuminate\Http\RedirectResponse
104 104
      */
105 105
     public function logout(Request $request)
106 106
     {
Please login to merge, or discard this patch.
src/Console/InstallCommand.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,6 @@
 block discarded – undo
3 3
 namespace Sco\Admin\Console;
4 4
 
5 5
 use Illuminate\Console\Command;
6
-use Symfony\Component\Process\Exception\ProcessFailedException;
7
-use Symfony\Component\Process\ExecutableFinder;
8
-use Symfony\Component\Process\Process;
9 6
 
10 7
 class InstallCommand extends Command
11 8
 {
Please login to merge, or discard this patch.
src/Http/Middleware/RouteAuthorize.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@
 block discarded – undo
4 4
 
5 5
 use Closure;
6 6
 use Illuminate\Auth\Access\AuthorizationException;
7
-use Route;
8 7
 use Illuminate\Contracts\Auth\Factory as Auth;
8
+use Route;
9 9
 
10 10
 class RouteAuthorize
11 11
 {
Please login to merge, or discard this patch.
src/View/Columns/Column.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -115,6 +115,9 @@
 block discarded – undo
115 115
         return $this->getValueFromObject($this->getModel(), $this->getName());
116 116
     }
117 117
 
118
+    /**
119
+     * @param Model $instance
120
+     */
118 121
     protected function getValueFromObject($instance, $name)
119 122
     {
120 123
         $parts = explode('.', $name);
Please login to merge, or discard this patch.
src/Component/Component.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -52,6 +52,9 @@  discard block
 block discarded – undo
52 52
         return $this->getRepository()->isRestorable();
53 53
     }
54 54
 
55
+    /**
56
+     * @param string $class
57
+     */
55 58
     public function registerObserver($class = null)
56 59
     {
57 60
         if (!$class) {
@@ -72,6 +75,9 @@  discard block
 block discarded – undo
72 75
         $this->permissions[$permission] = $callback;
73 76
     }
74 77
 
78
+    /**
79
+     * @param string $permission
80
+     */
75 81
     public function can($permission)
76 82
     {
77 83
         if (is_callable($this->permissions[$permission])) {
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,8 +3,8 @@
 block discarded – undo
3 3
 namespace Sco\Admin\Component;
4 4
 
5 5
 use BadMethodCallException;
6
-use InvalidArgumentException;
7 6
 use Illuminate\Foundation\Application;
7
+use InvalidArgumentException;
8 8
 use Sco\Admin\Component\Concerns\HasEvents;
9 9
 use Sco\Admin\Component\Concerns\HasNavigation;
10 10
 use Sco\Admin\Contracts\ComponentInterface;
Please login to merge, or discard this patch.
src/Form/Elements/File.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
      *
281 281
      * @param \Illuminate\Http\UploadedFile $file
282 282
      *
283
-     * @return mixed|string
283
+     * @return string
284 284
      */
285 285
     public function getUploadFileName(UploadedFile $file)
286 286
     {
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
         ];
356 356
     }
357 357
 
358
+    /**
359
+     * @param string $rule
360
+     */
358 361
     public function addValidationRule($rule, $message = null)
359 362
     {
360 363
         $uploadRules = [
Please login to merge, or discard this patch.
src/Providers/NavigationServiceProvider.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,10 @@
 block discarded – undo
3 3
 namespace Sco\Admin\Providers;
4 4
 
5 5
 use Illuminate\Support\ServiceProvider;
6
-use KodiComponents\Navigation\Contracts\NavigationInterface;
7
-use KodiComponents\Navigation\Navigation;
8 6
 use KodiComponents\Navigation\Contracts\BadgeInterface;
7
+use KodiComponents\Navigation\Contracts\NavigationInterface;
9 8
 use KodiComponents\Navigation\Contracts\PageInterface;
9
+use KodiComponents\Navigation\Navigation;
10 10
 use Sco\Admin\Navigation\Badge;
11 11
 use Sco\Admin\Navigation\Page;
12 12
 
Please login to merge, or discard this patch.