Completed
Push — master ( 80411a...1281a7 )
by wen
03:35
created

MenuController::destroy()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 5
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 5
rs 9.4285
c 0
b 0
f 0
ccs 0
cts 2
cp 0
cc 1
eloc 3
nc 1
nop 1
crap 2
1
<?php
2
3
namespace Sco\Admin\Http\Controllers\System;
4
5
use Illuminate\Http\Request;
6
use Illuminate\Routing\Controller;
7
use Sco\Admin\Http\Requests\StorePermissionRequest;
8
use Sco\Admin\Http\Requests\PermissionRequest;
9
use Sco\Admin\Http\Requests\UpdatePermissionRequest;
10
use Sco\Admin\Models\Permission;
11
12
/**
13
 * 菜单管理
14
 */
15
class MenuController extends Controller
16
{
17
    /**
18
     * 菜单列表
19
     *
20
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
21
     */
22
    public function getList()
23
    {
24
        $menus = (new Permission())->getMenuTreeList();
25
        return response()->json($menus->values());
26
    }
27
28
    /**
29
     * 保存菜单信息
30
     *
31
     * @param \Sco\Admin\Http\Requests\StorePermissionRequest $request 提交数据
32
     *
33
     * @return \Illuminate\Http\JsonResponse
34
     */
35
    public function store(StorePermissionRequest $request)
36
    {
37
        $model = new Permission();
38
        $model->fill($request->input())->save();
0 ignored issues
show
Bug introduced by
It seems like $request->input() targeting Illuminate\Http\Concerns...ractsWithInput::input() can also be of type string; however, Illuminate\Database\Eloquent\Model::fill() does only seem to accept array, maybe add an additional type check?

This check looks at variables that are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
39
        return response()->json(['message' => 'ok']);
40
    }
41
42
    /**
43
     *  更新菜单
44
     *
45
     * @param \Sco\Admin\Http\Requests\UpdatePermissionRequest $request 提交数据
46
     *
47
     * @return \Illuminate\Http\JsonResponse
48
     */
49
    public function update(UpdatePermissionRequest $request)
50
    {
51
        $perm = Permission::findOrFail($request->input('id'));
52
        $perm->update($request->input());
53
        return response()->json(['message' => 'ok']);
54
    }
55
56
    /**
57
     * 删除菜单
58
     *
59
     * @param int $id
60
     *
61
     * @return \Illuminate\Http\JsonResponse
62
     */
63
    public function destroy($id)
64
    {
65
        (new Permission())->destroyMenu($id);
66
        return response()->json(['message' => 'ok']);
67
    }
68
69
    /**
70
     * 批量删除菜单
71
     *
72
     * @param \Illuminate\Http\Request $request
73
     *
74
     * @return \Illuminate\Http\JsonResponse
75
     */
76
    public function batchDestroy(Request $request)
77
    {
78
        if (!is_array($request->input('ids'))) {
79
            throw new AdminHttpException('参数错误');
80
        }
81
82
        (new Permission())->destroyMenu($request->input('ids'));
83
        return response()->json(['message' => 'ok']);
84
    }
85
}
86