Sco\Admin\Http\Controllers\System\MenuController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getList()	0	5	1
A	store()	0	6	1
A	update()	0	6	1
A	destroy()	0	5	1
A	batchDestroy()	0	9	2

<?php

namespace Sco\Admin\Http\Controllers\System;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Sco\Admin\Http\Requests\StorePermissionRequest;
use Sco\Admin\Http\Requests\PermissionRequest;
use Sco\Admin\Http\Requests\UpdatePermissionRequest;
use Sco\Admin\Models\Permission;

/**
 * 菜单管理
 */
class MenuController extends Controller
{
    /**
     * 菜单列表
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function getList()
    {
        $menus = (new Permission())->getMenuTreeList();
        return response()->json($menus->values());
    }

    /**
     * 保存菜单信息
     *
     * @param \Sco\Admin\Http\Requests\StorePermissionRequest $request 提交数据
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(StorePermissionRequest $request)
    {
        $model = new Permission();
        $model->fill($request->input())->save();

It seems like $request->input() targeting Illuminate\Http\Concerns\InteractsWithInput::input() can also be of type string; however, Illuminate\Database\Eloquent\Model::fill() does only seem to accept array, maybe add an additional type check?

        return response()->json(['message' => 'ok']);
    }

    /**
     *  更新菜单
     *
     * @param \Sco\Admin\Http\Requests\UpdatePermissionRequest $request 提交数据
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function update(UpdatePermissionRequest $request)
    {
        $perm = Permission::findOrFail($request->input('id'));
        $perm->update($request->input());
        return response()->json(['message' => 'ok']);
    }

    /**
     * 删除菜单
     *
     * @param int $id
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        (new Permission())->destroyMenu($id);
        return response()->json(['message' => 'ok']);
    }

    /**
     * 批量删除菜单
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function batchDestroy(Request $request)
    {
        if (!is_array($request->input('ids'))) {
            throw new AdminHttpException('参数错误');
        }

        (new Permission())->destroyMenu($request->input('ids'));
        return response()->json(['message' => 'ok']);
    }
}