SchulIT / idp

src/Menu/Builder.php

Spacing +6 added lines, -6 removed lines

@@ -53,7 +53,7 @@ 
         ])
             ->setAttribute('icon', 'fas fa-shield-alt');
 
-        if($this->authorizationChecker->isGranted('ROLE_ADMIN')) {
+        if ($this->authorizationChecker->isGranted('ROLE_ADMIN')) {
             $menu->addChild('users.label', [
                 'route' => 'users'
             ])
@@ -93,7 +93,7 @@ 
             ->setExtra('menu-container', '#submenu')
             ->setExtra('pull-right', true);
 
-        if($this->authorizationChecker->isGranted('ROLE_SUPER_ADMIN')) {
+        if ($this->authorizationChecker->isGranted('ROLE_SUPER_ADMIN')) {
             $menu->addChild('user_types.label', [
                 'route' => 'user_types'
             ])
@@ -104,7 +104,7 @@ 
             ])
                 ->setAttribute('icon', 'fas fa-user-tag');
 
-            if($this->adAuthEnabled === true) {
+            if ($this->adAuthEnabled === true) {
                 $menu->addChild('ad_sync_options.label', [
                     'route' => 'ad_sync_options'
                 ])
@@ -162,14 +162,14 @@ 
 
         $user = $this->tokenStorage->getToken()->getUser();
 
-        if(!$user instanceof User) {
+        if (!$user instanceof User) {
             return $menu;
         }
 
         $label = 'dark_mode.enable';
         $icon = 'far fa-moon';
 
-        if($this->darkModeManager->isDarkModeEnabled()) {
+        if ($this->darkModeManager->isDarkModeEnabled()) {
             $label = 'dark_mode.disable';
             $icon = 'far fa-sun';
         }
@@ -207,7 +207,7 @@ 
         $token = $this->tokenStorage->getToken();
         $user = $token->getUser();
 
-        if($user instanceof User) {
+        if ($user instanceof User) {
             $menu = $root->addChild('services', [
                 'label' => ''
             ])

src/Security/UserAuthenticator.php

Spacing +13 added lines, -13 removed lines

@@ -102,7 +102,7 @@ 
     public function getUser($credentials, UserProviderInterface $userProvider) {
         $token = new CsrfToken('authenticate', $credentials['csrf_token']);
 
-        if(!$this->csrfTokenManager->isTokenValid($token)) {
+        if (!$this->csrfTokenManager->isTokenValid($token)) {
             throw new InvalidCsrfTokenException();
         }
 
@@ -110,18 +110,18 @@ 
             /** @var User $user */
             $user = $userProvider->loadUserByUsername($credentials['username']);
 
-            if($user->isProvisioned() === false) {
+            if ($user->isProvisioned() === false) {
                 throw new CustomUserMessageAuthenticationException('not_provisioned');
             }
 
-            if($user instanceof ActiveDirectoryUser) {
+            if ($user instanceof ActiveDirectoryUser) {
                 $user = $this->authenticateUsingActiveDirectory(new Credentials($credentials['username'], $credentials['password']), $user);
             }
-        } catch(UsernameNotFoundException $e) {
+        } catch (UsernameNotFoundException $e) {
             $user = $this->authenticateUsingActiveDirectory(new Credentials($credentials['username'], $credentials['password']));
         }
 
-        if($user === null) {
+        if ($user === null) {
             throw new CustomUserMessageAuthenticationException('invalid_credentials');
         }
 
@@ -133,14 +133,14 @@ 
      */
     public function checkCredentials($credentials, UserInterface $user) {
         return $this->encoder->isPasswordValid($user, $credentials['password'])
-            && ((!$user instanceof User) || $user->isDeleted() === false);          // Important: check if user was deleted
+            && ((!$user instanceof User) || $user->isDeleted() === false); // Important: check if user was deleted
     }
 
     /**
      * @inheritDoc
      */
     public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey) {
-        if($targetPath = $this->getTargetPath($request->getSession(), $providerKey)) {
+        if ($targetPath = $this->getTargetPath($request->getSession(), $providerKey)) {
             return new RedirectResponse($targetPath);
         }
 
@@ -148,14 +148,14 @@ 
     }
 
     protected function authenticateUsingActiveDirectory(Credentials $credentials, ActiveDirectoryUser $adUser = null) {
-        if($this->isActiveDirectoryEnabled !== true) {
+        if ($this->isActiveDirectoryEnabled !== true) {
             return $adUser;
         }
 
         $upnSuffix = substr($credentials->getUsername(), strpos($credentials->getUsername(), '@') + 1);
         $upnSuffixes = array_map(function(ActiveDirectoryUpnSuffix $suffix) { return $suffix->getSuffix(); }, $this->upnSuffixRepository->findAll());
 
-        if(count($upnSuffixes) > 0 && !in_array($upnSuffix, $upnSuffixes)) {
+        if (count($upnSuffixes) > 0 && !in_array($upnSuffix, $upnSuffixes)) {
             $this->logger->debug(sprintf('UPN-Suffix "%s" is not enabled for AD sync.', $upnSuffix));
             return $adUser;
         }
@@ -164,7 +164,7 @@ 
             /** @var AuthenticationResponse $response */
             $response = $this->adAuth->authenticate($credentials);
 
-            if($response->isSuccess() !== true) {
+            if ($response->isSuccess() !== true) {
                 $this->logger
                     ->notice(sprintf('Failed to authenticate "%s" using Active Directory', $credentials->getUsername()));
 
@@ -174,7 +174,7 @@ 
 
             $info = $this->transformResponse($response);
 
-            if($this->userCreator->canCreateUser($info)) {
+            if ($this->userCreator->canCreateUser($info)) {
                 $user = $this->userCreator->createUser($info, $adUser);
 
                 $user->setPassword($this->encoder->encodePassword($user, $credentials->getPassword()));
@@ -188,12 +188,12 @@ 
 
                 throw new CustomUserMessageAuthenticationException('not_allowed');
             }
-        } catch(SocketException $e) {
+        } catch (SocketException $e) {
             $this->logger
                 ->critical('Authentication server is not available');
 
             throw new CustomUserMessageAuthenticationException('server_unavailable');
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
             $this->logger->critical(
                 'Authentication failed', [
                     'exception' => $e

src/EventSubscriber/ApiExceptionSubscriber.php

Spacing +7 added lines, -7 removed lines

@@ -29,7 +29,7 @@ 
     public function onKernelException(ExceptionEvent $event) {
         $request = $event->getRequest();
 
-        if(!in_array(static::JsonContentType, $request->getAcceptableContentTypes())) {
+        if (!in_array(static::JsonContentType, $request->getAcceptableContentTypes())) {
             return;
         }
 
@@ -37,15 +37,15 @@ 
         $code = Response::HTTP_INTERNAL_SERVER_ERROR;
 
         // Case 1: general HttpException (Authorization/Authentication) or BadRequest
-        if($throwable instanceof HttpException) {
+        if ($throwable instanceof HttpException) {
             $code = $throwable->getStatusCode();
             $message = new ErrorResponse($throwable->getMessage(), get_class($throwable));
-        } else if($throwable instanceof ValidationFailedException) { // Case 2: validation failed
+        } else if ($throwable instanceof ValidationFailedException) { // Case 2: validation failed
             $code = Response::HTTP_BAD_REQUEST;
 
-            $violations = [ ];
-            foreach($throwable->getConstraintViolations() as $violation) {
-                $violations[] = new Violation($violation->getPropertyPath(), (string)$violation->getMessage());
+            $violations = [];
+            foreach ($throwable->getConstraintViolations() as $violation) {
+                $violations[] = new Violation($violation->getPropertyPath(), (string) $violation->getMessage());
             }
 
             $message = new ViolationListResponse($violations);
@@ -61,7 +61,7 @@ 
         }
 
         $validStatusCodes = array_keys(Response::$statusTexts);
-        if(!in_array($code, $validStatusCodes)) {
+        if (!in_array($code, $validStatusCodes)) {
             $code = Response::HTTP_INTERNAL_SERVER_ERROR;
         }
 

Braces +4 added lines, -2 removed lines

@@ -40,7 +40,8 @@ 
         if($throwable instanceof HttpException) {
             $code = $throwable->getStatusCode();
             $message = new ErrorResponse($throwable->getMessage(), get_class($throwable));
-        } else if($throwable instanceof ValidationFailedException) { // Case 2: validation failed
+        } else if($throwable instanceof ValidationFailedException) {
+// Case 2: validation failed
             $code = Response::HTTP_BAD_REQUEST;
 
             $violations = [ ];
@@ -49,7 +50,8 @@ 
             }
 
             $message = new ViolationListResponse($violations);
-        } else { // Case 3: General error
+        } else {
+// Case 3: General error
             $message = new ErrorResponse(
                 'An unknown error occured.',
                 get_class($throwable)

src/Command/ProvisionUserCommand.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
         $users = $this->userRepository->findNextNonProvisionedUsers($this->numberOfUsers);
 
-        foreach($users as $user) {
+        foreach ($users as $user) {
             $user->setPassword(
                 $this->passwordEncoder->encodePassword($user, $user->getPassword())
             );

src/Migrations/Version20200709105141.php

Braces +1 added lines, -2 removed lines

@@ -10,8 +10,7 @@
 /**
  * Auto-generated Migration: Please modify to your needs!
  */
-final class Version20200709105141 extends AbstractMigration
-{
+final class Version20200709105141 extends AbstractMigration {
     public function getDescription() : string
     {
         return '';

src/Validator/UniqueUsernameValidator.php

Spacing +3 added lines, -3 removed lines

@@ -21,17 +21,17 @@
      * @inheritDoc
      */
     public function validate($value, Constraint $constraint) {
-        if(!$constraint instanceof UniqueUsername) {
+        if (!$constraint instanceof UniqueUsername) {
             throw new UnexpectedTypeException($constraint, UniqueUsername::class);
         }
 
-        if(!is_string($value)) {
+        if (!is_string($value)) {
             throw new UnexpectedTypeException($constraint, 'string');
         }
 
         $user = $this->userRepository->findOneByUsername($value);
 
-        if($user !== null && $this->matchesType($user, $constraint->type) === false) {
+        if ($user !== null && $this->matchesType($user, $constraint->type) === false) {
             $this->context
                 ->buildViolation($constraint->message)
                 ->addViolation();