SchulIT / icc

src/Controller/ListController.php

Spacing +41 added lines, -41 removed lines

@@ -75,29 +75,29 @@ 
         $studentFilterView = $studentFilter->handle($request->query->get('student', null), $sectionFilterView->getCurrentSection(), $user);
         $teacherFilterView = $teacherFilter->handle($request->query->get('teacher', null), $sectionFilterView->getCurrentSection(), $user, $gradeFilterView->getCurrentGrade() === null && $studentFilterView->getCurrentStudent() === null);
 
-        $tuitions = [ ];
-        $memberships = [ ];
-        $teacherMailAddresses = [ ];
+        $tuitions = [];
+        $memberships = [];
+        $teacherMailAddresses = [];
 
-        if($studentFilterView->getCurrentStudent() !== null && $sectionFilterView->getCurrentSection() !== null) {
+        if ($studentFilterView->getCurrentStudent() !== null && $sectionFilterView->getCurrentSection() !== null) {
             $tuitions = $tuitionRepository->findAllByStudents([$studentFilterView->getCurrentStudent()], $sectionFilterView->getCurrentSection());
 
-            foreach($tuitions as $tuition) {
+            foreach ($tuitions as $tuition) {
                 /** @var StudyGroupMembership|null $membership */
                 $membership = $tuition->getStudyGroup()->getMemberships()->filter(fn(StudyGroupMembership $membership) => $membership->getStudent()->getId() === $studentFilterView->getCurrentStudent()->getId())->first();
 
                 $memberships[$tuition->getExternalId()] = $membership->getType();
             }
-        } else if($gradeFilterView->getCurrentGrade() !== null) {
+        } else if ($gradeFilterView->getCurrentGrade() !== null) {
             $tuitions = $tuitionRepository->findAllByGrades([$gradeFilterView->getCurrentGrade()], $sectionFilterView->getCurrentSection());
-        } else if($teacherFilterView->getCurrentTeacher() !== null && $sectionFilterView->getCurrentSection() !== null) {
+        } else if ($teacherFilterView->getCurrentTeacher() !== null && $sectionFilterView->getCurrentSection() !== null) {
             $tuitions = $tuitionRepository->findAllByTeacher($teacherFilterView->getCurrentTeacher(), $sectionFilterView->getCurrentSection());
         }
 
-        if($studentFilterView->getCurrentStudent() !== null || $gradeFilterView->getCurrentGrade() !== null) {
-            foreach($tuitions as $tuition) {
-                foreach($tuition->getTeachers() as $teacher) {
-                    if($teacher->getEmail() !== null) {
+        if ($studentFilterView->getCurrentStudent() !== null || $gradeFilterView->getCurrentGrade() !== null) {
+            foreach ($tuitions as $tuition) {
+                foreach ($tuition->getTeachers() as $teacher) {
+                    if ($teacher->getEmail() !== null) {
                         $teacherMailAddresses[] = $teacher->getEmail();
                     }
                 }
@@ -135,10 +135,10 @@ 
 
         $exams = array_filter($exams, fn(Exam $exam) => $this->isGranted(ExamVoter::Show, $exam));
 
-        $types = [ ];
+        $types = [];
 
-        foreach($memberships as $membership) {
-            if(!array_key_exists($membership->getType(), $types)) {
+        foreach ($memberships as $membership) {
+            if (!array_key_exists($membership->getType(), $types)) {
                 $types[$membership->getType()] = 0;
             }
 
@@ -174,24 +174,24 @@ 
         $studyGroupFilterView = $studyGroupFilter->handle($request->query->get('study_group', null), $sectionFilterView->getCurrentSection(), $user);
         $studentFilterView = $studentFilter->handle($request->query->get('student', null), $sectionFilterView->getCurrentSection(), $user);
 
-        $students = [ ];
-        $studyGroups = [ ];
-        $memberships = [ ];
+        $students = [];
+        $studyGroups = [];
+        $memberships = [];
 
-        if($studyGroupFilterView->getCurrentStudyGroup() !== null) {
+        if ($studyGroupFilterView->getCurrentStudyGroup() !== null) {
             /** @var StudyGroupMembership $membership */
-            foreach($studyGroupFilterView->getCurrentStudyGroup()->getMemberships() as $membership) {
+            foreach ($studyGroupFilterView->getCurrentStudyGroup()->getMemberships() as $membership) {
                 $students[] = $membership->getStudent();
                 $memberships[$membership->getStudent()->getId()] = $membership->getType();
             }
 
             $this->sorter->sort($students, StudentStrategy::class);
-        } else if($studentFilterView->getCurrentStudent() !== null) {
-            $studyGroups = [ ];
-            $memberships = [ ];
+        } else if ($studentFilterView->getCurrentStudent() !== null) {
+            $studyGroups = [];
+            $memberships = [];
 
             /** @var StudyGroupMembership $membership */
-            foreach($studentFilterView->getCurrentStudent()->getStudyGroupMemberships() as $membership) {
+            foreach ($studentFilterView->getCurrentStudent()->getStudyGroupMemberships() as $membership) {
                 $studyGroups[] = $membership->getStudyGroup();
                 $memberships[$membership->getStudyGroup()->getId()] = $membership->getType();
             }
@@ -202,26 +202,26 @@ 
         $studyGroups = array_filter($studyGroups, fn(StudyGroup $studyGroup) => $studyGroup->getSection() === $sectionFilterView->getCurrentSection());
 
         $grade = null;
-        $gradeTeachers = [ ];
-        $substitutionalGradeTeachers = [ ];
+        $gradeTeachers = [];
+        $substitutionalGradeTeachers = [];
 
-        if($studyGroupFilterView->getCurrentStudyGroup() !== null && $studyGroupFilterView->getCurrentStudyGroup()->getType() === StudyGroupType::Grade) {
+        if ($studyGroupFilterView->getCurrentStudyGroup() !== null && $studyGroupFilterView->getCurrentStudyGroup()->getType() === StudyGroupType::Grade) {
             /** @var Grade $grade */
             $grade = $studyGroupFilterView->getCurrentStudyGroup()->getGrades()->first();
-        } else if($studentFilterView->getCurrentStudent() !== null && $sectionFilterView->getCurrentSection() !== null) {
+        } else if ($studentFilterView->getCurrentStudent() !== null && $sectionFilterView->getCurrentSection() !== null) {
             $grade = $studentFilterView->getCurrentStudent()->getGrade($sectionFilterView->getCurrentSection());
         }
 
-        if($grade !== null) {
+        if ($grade !== null) {
             $gradeTeachers = array_map(fn(GradeTeacher $gradeTeacher) => $gradeTeacher->getTeacher(), array_filter($grade->getTeachers()->toArray(), fn(GradeTeacher $gradeTeacher) => $gradeTeacher->getType() === GradeTeacherType::Primary));
 
             $substitutionalGradeTeachers = array_map(fn(GradeTeacher $gradeTeacher) => $gradeTeacher->getTeacher(), array_filter($grade->getTeachers()->toArray(), fn(GradeTeacher $gradeTeacher) => $gradeTeacher->getType() === GradeTeacherType::Substitute));
         }
 
-        $tuitions = [ ];
+        $tuitions = [];
 
-        if($studyGroupFilterView->getCurrentStudyGroup() !== null) {
-            if($studyGroupFilterView->getCurrentStudyGroup()->getType() === StudyGroupType::Grade) {
+        if ($studyGroupFilterView->getCurrentStudyGroup() !== null) {
+            if ($studyGroupFilterView->getCurrentStudyGroup()->getType() === StudyGroupType::Grade) {
                 $tuitions = $tuitionRepository->findAllByGrades($studyGroupFilterView->getCurrentStudyGroup()->getGrades()->toArray(), $sectionFilterView->getCurrentSection());
             } else {
                 $tuitions = $studyGroupFilterView->getCurrentStudyGroup()->getTuitions()->toArray();
@@ -265,7 +265,7 @@ 
 
         $teachers = $teacherRepository->findAllBySubjectAndTag($subjectFilterView->getCurrentSubject(), $tagFilterView->getCurrentTag());
 
-        if($tagFilterView->getCurrentTag() !== null && $tagFilterView->getCurrentTag()->getId() === null) {
+        if ($tagFilterView->getCurrentTag() !== null && $tagFilterView->getCurrentTag()->getId() === null) {
             $teachers = $this->filterImplicitTeacherTag($teachers, $tagFilterView->getCurrentTag());
         }
 
@@ -289,12 +289,12 @@ 
     private function filterImplicitTeacherTag(array $teachers, TeacherTag $tag): array {
         return array_filter($teachers, function(Teacher $teacher) use ($tag) {
             /** @var GradeTeacher $gradeTeacher */
-            foreach($teacher->getGrades() as $gradeTeacher) {
-                if($gradeTeacher->getType() === GradeTeacherType::Primary && $tag->getUuid()->toString() === TeacherTag::GradeTeacherTagUuid) {
+            foreach ($teacher->getGrades() as $gradeTeacher) {
+                if ($gradeTeacher->getType() === GradeTeacherType::Primary && $tag->getUuid()->toString() === TeacherTag::GradeTeacherTagUuid) {
                     return true;
                 }
 
-                if($gradeTeacher->getType() === GradeTeacherType::Substitute && $tag->getUuid()->toString() === TeacherTag::SubstituteGradeTeacherTagUuid) {
+                if ($gradeTeacher->getType() === GradeTeacherType::Substitute && $tag->getUuid()->toString() === TeacherTag::SubstituteGradeTeacherTagUuid) {
                     return true;
                 }
             }
@@ -315,19 +315,19 @@ 
 
         // Filter categories
         $categories = $privacyCategoryRepository->findAll();
-        $filteredCategories = [ ];
+        $filteredCategories = [];
 
-        foreach($categories as $category) {
-            if($request->query->get($category->getUuid()->toString()) === '✓') {
+        foreach ($categories as $category) {
+            if ($request->query->get($category->getUuid()->toString()) === '✓') {
                 $filteredCategories[] = $category->getUuid()->toString();
             }
         }
 
-        $students = [ ];
+        $students = [];
 
-        if($q !== null) {
+        if ($q !== null) {
             $students = $studentRepository->findAllByQuery($q);
-        } else if($studygroupView->getCurrentStudyGroup() !== null) {
+        } else if ($studygroupView->getCurrentStudyGroup() !== null) {
             $students = $studentRepository->findAllByStudyGroups([$studygroupView->getCurrentStudyGroup()]);
         }
 

src/Controller/AuthenticationController.php

Spacing +3 added lines, -3 removed lines

@@ -14,17 +14,17 @@
     public function error(AuthenticationUtils $authenticationUtils, TranslatorInterface $translator): Response {
         $exception = $authenticationUtils->getLastAuthenticationError();
 
-        if($exception === null) {
+        if ($exception === null) {
             return $this->redirectToRoute('lightsaml_sp.login');
         }
 
-        if($exception->getPrevious() !== null) {
+        if ($exception->getPrevious() !== null) {
             $exception = $exception->getPrevious();
         }
 
         $exceptionType = $exception::class;
 
-        if(method_exists($exception, 'getMessageKey')) {
+        if (method_exists($exception, 'getMessageKey')) {
             $messageKey = $exception->getMessageKey();
             $message = $translator->trans($messageKey, [], 'security');
         } else {