CheckjsonController3::indexAction() - Code Metrics - SandraJinnevall/ramverk1-module - Measure and Improve Code Quality continuously with Scrutinizer

CheckjsonController3::indexAction() A
last analyzed 2020-12-04 11:10 UTC

↳ Parent: CheckjsonController3

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
nc	1
nop	0
dl	0
loc	14
c	1
b	0
f	0
cc	1
ccs	9
cts	9
cp	1
crap	1
rs	9.9666

<?php

namespace Anax\Ip3;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

class CheckjsonController3 implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    public function initialize()
    {
        $this->IpController = new Validera3();

    }

    public function indexAction() : array
    {
        $ipController = new Validera3();

        $ipadress = $this->di->request->getGet("ipjson");

        $weather = $this->di->get("validera3");

        $json = [
            "Stad" => $ipadress,
            "validerbar" => $weather->check($ipadress),
            "weatherForecast" => $weather->getWeather($ipadress)["weatherForecast"],
            "weatherHistory" => $weather->getWeather($ipadress)["weatherHistory"],
        ];

        return [$json];
    }
}


1		<?php
2
3		namespace Anax\Ip3;
4
5		use Anax\Commons\ContainerInjectableInterface;
6		use Anax\Commons\ContainerInjectableTrait;
7
8		class CheckjsonController3 implements ContainerInjectableInterface
9		{
10		use ContainerInjectableTrait;
11
12	1	public function initialize()
13		{
14	1	$this->IpController = new Validera3();
		0 ignored issues – show Bug Best Practice introduced 2020-12-04 10:54 UTC by Report Bug Copy Issue Report The property `IpController` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
15	1	}
16
17	1	public function indexAction() : array
18		{
19	1	$ipController = new Validera3();
		0 ignored issues – show Unused Code introduced 2020-12-04 10:54 UTC by Report Bug Copy Issue Report The assignment to `$ipController` is dead and can be removed. Loading history...
20	1	$ipadress = $this->di->request->getGet("ipjson");
		0 ignored issues – show Bug introduced 2020-12-04 10:54 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Psr\Container\ContainerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
21	1	$weather = $this->di->get("validera3");
22
23		$json = [
24	1	"Stad" => $ipadress,
25	1	"validerbar" => $weather->check($ipadress),
26	1	"weatherForecast" => $weather->getWeather($ipadress)["weatherForecast"],
27	1	"weatherHistory" => $weather->getWeather($ipadress)["weatherHistory"],
28		];
29
30	1	return [$json];
31		}
32		}
33

SandraJinnevall / ramverk1-module

CheckjsonController3::indexAction() A last analyzed 2020-12-04 11:10 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CheckjsonController3::indexAction() A
last analyzed 2020-12-04 11:10 UTC