Anax\Ip3\CheckjsonController3

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	3	1
A	indexAction()	0	14	1

<?php

namespace Anax\Ip3;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

class CheckjsonController3 implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    public function initialize()
    {
        $this->IpController = new Validera3();

The property IpController does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function indexAction() : array
    {
        $ipController = new Validera3();

The assignment to $ipController is dead and can be removed.

        $ipadress = $this->di->request->getGet("ipjson");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $weather = $this->di->get("validera3");

        $json = [
            "Stad" => $ipadress,
            "validerbar" => $weather->check($ipadress),
            "weatherForecast" => $weather->getWeather($ipadress)["weatherForecast"],
            "weatherHistory" => $weather->getWeather($ipadress)["weatherHistory"],
        ];

        return [$json];
    }
}