Sam-Burns / Slim

Slim/App.php

Unused Use Statements -2 removed lines

@@ -14,7 +14,6 @@ 
 use Throwable;
 use Closure;
 use InvalidArgumentException;
-use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;
 use Interop\Container\ContainerInterface;
@@ -26,7 +25,6 @@ 
 use Slim\Http\Headers;
 use Slim\Http\Body;
 use Slim\Http\Request;
-use Slim\Interfaces\Http\EnvironmentInterface;
 use Slim\Interfaces\RouteGroupInterface;
 use Slim\Interfaces\RouteInterface;
 use Slim\Interfaces\RouterInterface;

Spacing +3 added lines, -3 removed lines

@@ -466,7 +466,7 @@ 
         $router = $this->container->get('router');
 
         // If router hasn't been dispatched or the URI changed then dispatch
-        if (null === $routeInfo || ($routeInfo['request'] !== [$request->getMethod(), (string) $request->getUri()])) {
+        if (null === $routeInfo || ($routeInfo['request'] !== [$request->getMethod(), (string)$request->getUri()])) {
             $request = $this->dispatchRouterAndPrepareRoute($request, $router);
             $routeInfo = $request->getAttribute('routeInfo');
         }
@@ -558,7 +558,7 @@ 
             $request = $request->withAttribute('route', $route);
         }
 
-        $routeInfo['request'] = [$request->getMethod(), (string) $request->getUri()];
+        $routeInfo['request'] = [$request->getMethod(), (string)$request->getUri()];
 
         return $request->withAttribute('routeInfo', $routeInfo);
     }
@@ -587,7 +587,7 @@ 
             }
             $size = $response->getBody()->getSize();
             if ($size !== null && !$response->hasHeader('Content-Length')) {
-                $response = $response->withHeader('Content-Length', (string) $size);
+                $response = $response->withHeader('Content-Length', (string)$size);
             }
         }
 

Slim/Handlers/NotFound.php

Doc Comments +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
     /**
      * Return a response for application/json content not found
      *
-     * @return ResponseInterface
+     * @return string
      */
     protected function renderJsonNotFoundOutput()
     {
@@ -72,7 +72,7 @@ 
     /**
      * Return a response for xml content not found
      *
-     * @return ResponseInterface
+     * @return string
      */
     protected function renderXmlNotFoundOutput()
     {

Slim/Http/Request.php

Doc Comments +2 added lines, -2 removed lines

@@ -811,7 +811,7 @@ 
      * These values MAY be prepared from $_FILES or the message body during
      * instantiation, or MAY be injected via withUploadedFiles().
      *
-     * @return array An array tree of UploadedFileInterface instances; an empty
+     * @return UploadedFileInterface[] An array tree of UploadedFileInterface instances; an empty
      *     array MUST be returned if no data is present.
      */
     public function getUploadedFiles()
@@ -1144,7 +1144,7 @@ 
      * @param string $key
      * @param mixed $default
      *
-     * @return mixed
+     * @return null|string
      */
     public function getParsedBodyParam($key, $default = null)
     {

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use Psr\Http\Message\StreamInterface;
 use Slim\Collection;
 use Slim\Exception\InvalidMethodException;
-use Slim\Exception\MethodNotAllowedException;
 use Slim\Interfaces\Http\HeadersInterface;
 
 /**

Spacing +5 added lines, -5 removed lines

@@ -201,25 +201,25 @@ 
             $this->headers->set('Host', $this->uri->getHost());
         }
 
-        $this->registerMediaTypeParser('application/json', function ($input) {
+        $this->registerMediaTypeParser('application/json', function($input) {
             return json_decode($input, true);
         });
 
-        $this->registerMediaTypeParser('application/xml', function ($input) {
+        $this->registerMediaTypeParser('application/xml', function($input) {
             $backup = libxml_disable_entity_loader(true);
             $result = simplexml_load_string($input);
             libxml_disable_entity_loader($backup);
             return $result;
         });
 
-        $this->registerMediaTypeParser('text/xml', function ($input) {
+        $this->registerMediaTypeParser('text/xml', function($input) {
             $backup = libxml_disable_entity_loader(true);
             $result = simplexml_load_string($input);
             libxml_disable_entity_loader($backup);
             return $result;
         });
 
-        $this->registerMediaTypeParser('application/x-www-form-urlencoded', function ($input) {
+        $this->registerMediaTypeParser('application/x-www-form-urlencoded', function($input) {
             parse_str($input, $data);
             return $data;
         });
@@ -1015,7 +1015,7 @@ 
         // look for a media type with a structured syntax suffix (RFC 6839)
         $parts = explode('+', $mediaType);
         if (count($parts) >= 2) {
-            $mediaType = 'application/' . $parts[count($parts)-1];
+            $mediaType = 'application/' . $parts[count($parts) - 1];
         }
 
         if (isset($this->bodyParsers[$mediaType]) === true) {

Slim/Route.php

Doc Comments +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
     /**
      * Create new route
      *
-     * @param string|string[]   $methods The route HTTP methods
+     * @param string[]   $methods The route HTTP methods
      * @param string            $pattern The route pattern
      * @param callable          $callable The route callable
      * @param RouteGroup[]      $groups The parent route groups

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use InvalidArgumentException;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;
-use Slim\Exception\SlimException;
 use Slim\Handlers\Strategies\RequestResponse;
 use Slim\Interfaces\InvocationStrategyInterface;
 use Slim\Interfaces\RouteInterface;

Slim/Router.php

Doc Comments +1 added lines, -1 removed lines

@@ -199,7 +199,7 @@
      *
      * @param  string[] $methods Array of HTTP methods
      * @param  string   $pattern The route pattern
-     * @param  callable $handler The route callable
+     * @param callable $callable
      *
      * @return \Slim\Interfaces\RouteInterface
      */

Spacing +1 added lines, -1 removed lines

@@ -222,7 +222,7 @@
             return $this->dispatcher;
         }
 
-        $routeDefinitionCallback = function (RouteCollector $r) {
+        $routeDefinitionCallback = function(RouteCollector $r) {
             foreach ($this->getRoutes() as $route) {
                 $r->addRoute($route->getMethods(), $route->getPattern(), $route->getIdentifier());
             }

example/index.php

Spacing +2 added lines, -2 removed lines

@@ -26,12 +26,12 @@
  * argument for `Slim::get`, `Slim::post`, `Slim::put`, `Slim::patch`, and `Slim::delete`
  * is an anonymous function.
  */
-$app->get('/', function ($request, $response, $args) {
+$app->get('/', function($request, $response, $args) {
     $response->write("Welcome to Slim!");
     return $response;
 });
 
-$app->get('/hello[/{name}]', function ($request, $response, $args) {
+$app->get('/hello[/{name}]', function($request, $response, $args) {
     $response->write("Hello, " . $args['name']);
     return $response;
 })->setArgument('name', 'World!');

Slim/Container.php

Spacing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
          *
          * @return array|\ArrayAccess
          */
-        $this['settings'] = function () use ($userSettings, $defaultSettings) {
+        $this['settings'] = function() use ($userSettings, $defaultSettings) {
             return new Collection(array_merge($defaultSettings, $userSettings));
         };
 

Slim/MiddlewareAwareTrait.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
             $this->seedMiddlewareStack();
         }
         $next = $this->stack->top();
-        $this->stack[] = function (
+        $this->stack[] = function(
             ServerRequestInterface $request,
             ResponseInterface $response
         ) use (

Slim/Http/Response.php

Spacing +1 added lines, -1 removed lines

@@ -211,7 +211,7 @@
      */
     protected function filterStatus($status)
     {
-        if (!is_integer($status) || $status<100 || $status>599) {
+        if (!is_integer($status) || $status < 100 || $status > 599) {
             throw new InvalidArgumentException('Invalid HTTP status code');
         }