Saluki / Barmate

app/Http/Controllers/CategoryController.php

Doc Comments +8 added lines, -5 removed lines

@@ -12,7 +12,7 @@ 
 	/**
 	 * Display a listing of the resource.
 	 *
-	 * @return Response
+	 * @return \Illuminate\Http\JsonResponse
 	 */
 	public function index()
 	{
@@ -24,7 +24,7 @@ 
 	/**
 	 * Store a newly created resource in storage.
 	 *
-	 * @return Response
+	 * @return \Illuminate\Http\JsonResponse
 	 */
 	public function store()
 	{		
@@ -56,7 +56,7 @@ 
 	 * Display the specified resource.
 	 *
 	 * @param  int  $id
-	 * @return Response
+	 * @return \Illuminate\Http\JsonResponse
 	 */
 	public function show($id)
 	{
@@ -76,7 +76,7 @@ 
 	 * Update the specified resource in storage.
 	 *
 	 * @param  int  $id
-	 * @return Response
+	 * @return \Illuminate\Http\JsonResponse
 	 */
 	public function update($id)
 	{
@@ -113,7 +113,7 @@ 
 	 * Remove the specified resource from storage.
 	 *
 	 * @param  int  $id
-	 * @return Response
+	 * @return \Illuminate\Http\JsonResponse
 	 */
 	public function destroy($id)
 	{
@@ -140,6 +140,9 @@ 
     	return Response::json( [], 200);
 	}
 
+	/**
+	 * @param integer $id
+	 */
 	private function isID($id) {
 
 		return (bool) preg_match('/^[0-9]{1,10}$/', $id);

Indentation +128 added lines, -128 removed lines

@@ -9,139 +9,139 @@
 
 class CategoryController extends Controller {
 
-	/**
-	 * Display a listing of the resource.
-	 *
-	 * @return Response
-	 */
-	public function index()
-	{
-		$categoriesFromGroup = Categories::allAPI();
-
-		return Response::json( $categoriesFromGroup, 200);
-	}
-
-	/**
-	 * Store a newly created resource in storage.
-	 *
-	 * @return Response
-	 */
-	public function store()
-	{		
-    	$validator = Validator::make(Input::all(), [
-    		'title'        => 'required|alpha|between:1,50',
-    		'description'  => ''
-    	]);
-
-    	if( $validator->fails() ) {
-    		return Response::json( ['code'=>1, 'error'=>'Validation failed'], 400);
-    	}
-
-		$category = new Categories();
-		$category->group_id  = Session::get('groupID');
-		$category->category_title = Input::get('title');
-		$category->description = Input::get('description');
-		$category->is_active = true;
-
-		if( !$category->save() ) {
-
-			return Response::json( ['code'=>2, 'error'=>'Database error'], 400);
-		}
-
-    	return Response::json( ['id' => DB::getPdo()->lastInsertId() ], 200);
-	}
-
-
-	/**
-	 * Display the specified resource.
-	 *
-	 * @param  int  $id
-	 * @return Response
-	 */
-	public function show($id)
-	{
-		if( !$this->isID($id) )
-			return Response::json( ['code'=>1, 'error'=>'Parameter must be an integer'], 400);
-
-		$category = Categories::fromGroup()->find($id);
-
-		if( $category == null )
-			return Response::json();
-
-		return Response::json($category, 200);
-	}
-
-
-	/**
-	 * Update the specified resource in storage.
-	 *
-	 * @param  int  $id
-	 * @return Response
-	 */
-	public function update($id)
-	{
-		$validator = Validator::make(Input::all(), [
-    		'title'        => 'required|alpha|between:1,50',
-    		'description'  => ''
-    	]);
-
-    	if( $validator->fails() ) {
-    		return Response::json( ['code'=>3, 'error'=>'Validation failed'], 400);
-    	}
-
-		if( !$this->isID($id) )
-			return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
-
-		$category = Categories::fromGroup()->find($id);
-
-		if( $category == null )
-			return Response::json( ['code'=>2, 'error'=>'Category not found'] , 400);
-
-		$category->category_title = Input::get('title');
-		$category->description = Input::get('description');
-
-		if( !$category->save() ) {
-
-			return Response::json( ['code'=>2, 'error'=>'Database error'], 400);
-		}
-
-    	return Response::json( [], 200);
-	}
-
-
-	/**
-	 * Remove the specified resource from storage.
-	 *
-	 * @param  int  $id
-	 * @return Response
-	 */
-	public function destroy($id)
-	{
-		if( !$this->isID($id) )
-			return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
-
-		$category = Categories::fromGroup()->find($id);
+    /**
+     * Display a listing of the resource.
+     *
+     * @return Response
+     */
+    public function index()
+    {
+        $categoriesFromGroup = Categories::allAPI();
+
+        return Response::json( $categoriesFromGroup, 200);
+    }
+
+    /**
+     * Store a newly created resource in storage.
+     *
+     * @return Response
+     */
+    public function store()
+    {		
+        $validator = Validator::make(Input::all(), [
+            'title'        => 'required|alpha|between:1,50',
+            'description'  => ''
+        ]);
+
+        if( $validator->fails() ) {
+            return Response::json( ['code'=>1, 'error'=>'Validation failed'], 400);
+        }
+
+        $category = new Categories();
+        $category->group_id  = Session::get('groupID');
+        $category->category_title = Input::get('title');
+        $category->description = Input::get('description');
+        $category->is_active = true;
+
+        if( !$category->save() ) {
+
+            return Response::json( ['code'=>2, 'error'=>'Database error'], 400);
+        }
+
+        return Response::json( ['id' => DB::getPdo()->lastInsertId() ], 200);
+    }
+
+
+    /**
+     * Display the specified resource.
+     *
+     * @param  int  $id
+     * @return Response
+     */
+    public function show($id)
+    {
+        if( !$this->isID($id) )
+            return Response::json( ['code'=>1, 'error'=>'Parameter must be an integer'], 400);
+
+        $category = Categories::fromGroup()->find($id);
+
+        if( $category == null )
+            return Response::json();
+
+        return Response::json($category, 200);
+    }
+
+
+    /**
+     * Update the specified resource in storage.
+     *
+     * @param  int  $id
+     * @return Response
+     */
+    public function update($id)
+    {
+        $validator = Validator::make(Input::all(), [
+            'title'        => 'required|alpha|between:1,50',
+            'description'  => ''
+        ]);
+
+        if( $validator->fails() ) {
+            return Response::json( ['code'=>3, 'error'=>'Validation failed'], 400);
+        }
+
+        if( !$this->isID($id) )
+            return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
+
+        $category = Categories::fromGroup()->find($id);
+
+        if( $category == null )
+            return Response::json( ['code'=>2, 'error'=>'Category not found'] , 400);
+
+        $category->category_title = Input::get('title');
+        $category->description = Input::get('description');
+
+        if( !$category->save() ) {
+
+            return Response::json( ['code'=>2, 'error'=>'Database error'], 400);
+        }
+
+        return Response::json( [], 200);
+    }
+
+
+    /**
+     * Remove the specified resource from storage.
+     *
+     * @param  int  $id
+     * @return Response
+     */
+    public function destroy($id)
+    {
+        if( !$this->isID($id) )
+            return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
+
+        $category = Categories::fromGroup()->find($id);
 		
-		if( $category == null )
-			return Response::json( ['code'=>2, 'error'=>'Category not found'], 400);
+        if( $category == null )
+            return Response::json( ['code'=>2, 'error'=>'Category not found'], 400);
 
-		$products = Categories::find($id)->products()->get();
+        $products = Categories::find($id)->products()->get();
 
-		if( count($products) != 0 )
-			return Response::json( ['code'=>3, 'error'=>'Category not empty'], 400);
+        if( count($products) != 0 )
+            return Response::json( ['code'=>3, 'error'=>'Category not empty'], 400);
 
-		try {
-			$category->delete();
-		}
-		catch(\Exception $e) {
-			return Response::json( ['code'=>4, 'error'=>'Database error'], 400);
-		}
+        try {
+            $category->delete();
+        }
+        catch(\Exception $e) {
+            return Response::json( ['code'=>4, 'error'=>'Database error'], 400);
+        }
 
-    	return Response::json( [], 200);
-	}
+        return Response::json( [], 200);
+    }
 
-	private function isID($id) {
+    private function isID($id) {
 
-		return (bool) preg_match('/^[0-9]{1,10}$/', $id);
-	}
+        return (bool) preg_match('/^[0-9]{1,10}$/', $id);
+    }
 }

Spacing +25 added lines, -25 removed lines

@@ -18,7 +18,7 @@ 
 	{
 		$categoriesFromGroup = Categories::allAPI();
 
-		return Response::json( $categoriesFromGroup, 200);
+		return Response::json($categoriesFromGroup, 200);
 	}
 
 	/**
@@ -33,8 +33,8 @@ 
     		'description'  => ''
     	]);
 
-    	if( $validator->fails() ) {
-    		return Response::json( ['code'=>1, 'error'=>'Validation failed'], 400);
+    	if ($validator->fails()) {
+    		return Response::json(['code'=>1, 'error'=>'Validation failed'], 400);
     	}
 
 		$category = new Categories();
@@ -43,12 +43,12 @@ 
 		$category->description = Input::get('description');
 		$category->is_active = true;
 
-		if( !$category->save() ) {
+		if (!$category->save()) {
 
-			return Response::json( ['code'=>2, 'error'=>'Database error'], 400);
+			return Response::json(['code'=>2, 'error'=>'Database error'], 400);
 		}
 
-    	return Response::json( ['id' => DB::getPdo()->lastInsertId() ], 200);
+    	return Response::json(['id' => DB::getPdo()->lastInsertId()], 200);
 	}
 
 
@@ -60,12 +60,12 @@ 
 	 */
 	public function show($id)
 	{
-		if( !$this->isID($id) )
-			return Response::json( ['code'=>1, 'error'=>'Parameter must be an integer'], 400);
+		if (!$this->isID($id))
+			return Response::json(['code'=>1, 'error'=>'Parameter must be an integer'], 400);
 
 		$category = Categories::fromGroup()->find($id);
 
-		if( $category == null )
+		if ($category == null)
 			return Response::json();
 
 		return Response::json($category, 200);
@@ -85,27 +85,27 @@ 
     		'description'  => ''
     	]);
 
-    	if( $validator->fails() ) {
-    		return Response::json( ['code'=>3, 'error'=>'Validation failed'], 400);
+    	if ($validator->fails()) {
+    		return Response::json(['code'=>3, 'error'=>'Validation failed'], 400);
     	}
 
-		if( !$this->isID($id) )
+		if (!$this->isID($id))
 			return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
 
 		$category = Categories::fromGroup()->find($id);
 
-		if( $category == null )
-			return Response::json( ['code'=>2, 'error'=>'Category not found'] , 400);
+		if ($category == null)
+			return Response::json(['code'=>2, 'error'=>'Category not found'], 400);
 
 		$category->category_title = Input::get('title');
 		$category->description = Input::get('description');
 
-		if( !$category->save() ) {
+		if (!$category->save()) {
 
-			return Response::json( ['code'=>2, 'error'=>'Database error'], 400);
+			return Response::json(['code'=>2, 'error'=>'Database error'], 400);
 		}
 
-    	return Response::json( [], 200);
+    	return Response::json([], 200);
 	}
 
 
@@ -117,27 +117,27 @@ 
 	 */
 	public function destroy($id)
 	{
-		if( !$this->isID($id) )
+		if (!$this->isID($id))
 			return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
 
 		$category = Categories::fromGroup()->find($id);
 		
-		if( $category == null )
-			return Response::json( ['code'=>2, 'error'=>'Category not found'], 400);
+		if ($category == null)
+			return Response::json(['code'=>2, 'error'=>'Category not found'], 400);
 
 		$products = Categories::find($id)->products()->get();
 
-		if( count($products) != 0 )
-			return Response::json( ['code'=>3, 'error'=>'Category not empty'], 400);
+		if (count($products) != 0)
+			return Response::json(['code'=>3, 'error'=>'Category not empty'], 400);
 
 		try {
 			$category->delete();
 		}
-		catch(\Exception $e) {
-			return Response::json( ['code'=>4, 'error'=>'Database error'], 400);
+		catch (\Exception $e) {
+			return Response::json(['code'=>4, 'error'=>'Database error'], 400);
 		}
 
-    	return Response::json( [], 200);
+    	return Response::json([], 200);
 	}
 
 	private function isID($id) {

Braces +22 added lines, -16 removed lines

@@ -60,13 +60,15 @@ 
 	 */
 	public function show($id)
 	{
-		if( !$this->isID($id) )
-			return Response::json( ['code'=>1, 'error'=>'Parameter must be an integer'], 400);
+		if( !$this->isID($id) ) {
+					return Response::json( ['code'=>1, 'error'=>'Parameter must be an integer'], 400);
+		}
 
 		$category = Categories::fromGroup()->find($id);
 
-		if( $category == null )
-			return Response::json();
+		if( $category == null ) {
+					return Response::json();
+		}
 
 		return Response::json($category, 200);
 	}
@@ -89,13 +91,15 @@ 
     		return Response::json( ['code'=>3, 'error'=>'Validation failed'], 400);
     	}
 
-		if( !$this->isID($id) )
-			return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
+		if( !$this->isID($id) ) {
+					return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
+		}
 
 		$category = Categories::fromGroup()->find($id);
 
-		if( $category == null )
-			return Response::json( ['code'=>2, 'error'=>'Category not found'] , 400);
+		if( $category == null ) {
+					return Response::json( ['code'=>2, 'error'=>'Category not found'] , 400);
+		}
 
 		$category->category_title = Input::get('title');
 		$category->description = Input::get('description');
@@ -117,23 +121,25 @@ 
 	 */
 	public function destroy($id)
 	{
-		if( !$this->isID($id) )
-			return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
+		if( !$this->isID($id) ) {
+					return Response::json(['code'=>1, 'error'=>'Parameter must be numeric'], 400);
+		}
 
 		$category = Categories::fromGroup()->find($id);
 		
-		if( $category == null )
-			return Response::json( ['code'=>2, 'error'=>'Category not found'], 400);
+		if( $category == null ) {
+					return Response::json( ['code'=>2, 'error'=>'Category not found'], 400);
+		}
 
 		$products = Categories::find($id)->products()->get();
 
-		if( count($products) != 0 )
-			return Response::json( ['code'=>3, 'error'=>'Category not empty'], 400);
+		if( count($products) != 0 ) {
+					return Response::json( ['code'=>3, 'error'=>'Category not empty'], 400);
+		}
 
 		try {
 			$category->delete();
-		}
-		catch(\Exception $e) {
+		} catch(\Exception $e) {
 			return Response::json( ['code'=>4, 'error'=>'Database error'], 400);
 		}
 

app/Http/Controllers/InstallController.php

Unused Use Statements -4 removed lines

@@ -2,9 +2,7 @@ 
 
 namespace App\Http\Controllers;
 
-use App\Http\Requests;
 use App\User;
-use Config;
 use DateTimeZone;
 use Exception;
 use Hash;
@@ -12,8 +10,6 @@ 
 use Illuminate\Support\Facades\Artisan;
 use PDO;
 use PDOException;
-use Session;
-use URL;
 
 class InstallController extends Controller
 {

Spacing +23 added lines, -23 removed lines

@@ -37,7 +37,7 @@ 
             'TOKENIZER_EXTENSION' => false,
             'WRITE_ACCESS' => false];
 
-        if ($this->getPhpVersionId() >= self::REQUIRED_PHP_VERSION_ID) {
+        if ($this->getPhpVersionId()>=self::REQUIRED_PHP_VERSION_ID) {
             $requirements['PHP_VERSION'] = true;
         }
 
@@ -142,7 +142,7 @@ 
 
     public function checkEnvironmentFile(Request $request)
     {
-        if (file_exists(base_path() . '/.env')) {
+        if (file_exists(base_path().'/.env')) {
             return redirect('install/account');
         }
 
@@ -174,34 +174,34 @@ 
     {
         $configArray = session(self::CONFIG_KEY);
 
-        $configContent = 'APP_ENV=production' . PHP_EOL;
-        $configContent .= 'APP_DEBUG=false' . PHP_EOL;
-        $configContent .= 'APP_URL=' . $configArray['app_url'] . '' . PHP_EOL;
-        $configContent .= 'APP_KEY=' . $configArray['app_key'] . '' . PHP_EOL;
-        $configContent .= 'APP_TIMEZONE=' . $configArray['app_timezone'] . '' . PHP_EOL;
+        $configContent = 'APP_ENV=production'.PHP_EOL;
+        $configContent .= 'APP_DEBUG=false'.PHP_EOL;
+        $configContent .= 'APP_URL='.$configArray['app_url'].''.PHP_EOL;
+        $configContent .= 'APP_KEY='.$configArray['app_key'].''.PHP_EOL;
+        $configContent .= 'APP_TIMEZONE='.$configArray['app_timezone'].''.PHP_EOL;
 
-        $configContent .= 'DB_DRIVER=mysql' . PHP_EOL;
-        $configContent .= 'DB_HOST=' . $configArray['db_hostname'] . '' . PHP_EOL;
-        $configContent .= 'DB_DATABASE=' . $configArray['db_name'] . '' . PHP_EOL;
-        $configContent .= 'DB_USERNAME=' . $configArray['db_username'] . '' . PHP_EOL;
-        $configContent .= 'DB_PASSWORD=' . $configArray['db_password'] . '' . PHP_EOL;
+        $configContent .= 'DB_DRIVER=mysql'.PHP_EOL;
+        $configContent .= 'DB_HOST='.$configArray['db_hostname'].''.PHP_EOL;
+        $configContent .= 'DB_DATABASE='.$configArray['db_name'].''.PHP_EOL;
+        $configContent .= 'DB_USERNAME='.$configArray['db_username'].''.PHP_EOL;
+        $configContent .= 'DB_PASSWORD='.$configArray['db_password'].''.PHP_EOL;
 
-        $configContent .= 'MAIL_DRIVER=smtp' . PHP_EOL;
-        $configContent .= 'MAIL_HOST=mailtrap.io' . PHP_EOL;
-        $configContent .= 'MAIL_PORT=2525' . PHP_EOL;
-        $configContent .= 'MAIL_USERNAME=null' . PHP_EOL;
-        $configContent .= 'MAIL_PASSWORD=null' . PHP_EOL;
+        $configContent .= 'MAIL_DRIVER=smtp'.PHP_EOL;
+        $configContent .= 'MAIL_HOST=mailtrap.io'.PHP_EOL;
+        $configContent .= 'MAIL_PORT=2525'.PHP_EOL;
+        $configContent .= 'MAIL_USERNAME=null'.PHP_EOL;
+        $configContent .= 'MAIL_PASSWORD=null'.PHP_EOL;
 
-        $configContent .= 'CACHE_DRIVER=file' . PHP_EOL;
-        $configContent .= 'SESSION_DRIVER=file' . PHP_EOL;
-        $configContent .= 'QUEUE_DRIVER=sync' . PHP_EOL;
+        $configContent .= 'CACHE_DRIVER=file'.PHP_EOL;
+        $configContent .= 'SESSION_DRIVER=file'.PHP_EOL;
+        $configContent .= 'QUEUE_DRIVER=sync'.PHP_EOL;
 
 
         if (!is_writable(base_path())) {
             throw new Exception('Could not create the configuration file');
         }
 
-        $fileHandle = fopen(base_path() . '/.env', "w");
+        $fileHandle = fopen(base_path().'/.env', "w");
         fwrite($fileHandle, $configContent);
         fclose($fileHandle);
     }
@@ -211,7 +211,7 @@ 
         $request->session()->forget(self::CONFIG_KEY);
 
         try {
-            unlink(base_path() . '/' . self::INSTALLATION_FILE);
+            unlink(base_path().'/'.self::INSTALLATION_FILE);
             return view('install.finished');
         } catch (\ErrorException $e) {
             return view('install.finished')->with('lockError', true);
@@ -231,7 +231,7 @@ 
     private function hasDatabaseAccess($hostname, $username, $password, $database)
     {
         try {
-            (new PDO("mysql:host=$hostname;dbname=$database", $username, $password))->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);;
+            (new PDO("mysql:host=$hostname;dbname=$database", $username, $password))->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); ;
         } catch (PDOException $e) {
             return false;
         }

app/Http/Controllers/SnapshotController.php

Unused Use Statements -2 removed lines

@@ -1,7 +1,5 @@
 <?php
 
-use App\Exceptions\RepositoryException;
-use App\Repositories\SnapshotDetailsRepository;
 use App\Repositories\SnapshotRepository;
 use Input;
 use Response;

Indentation +30 added lines, -30 removed lines

@@ -8,35 +8,35 @@
 
 class SnapshotController extends \Controller {
 	
-	protected $repository;
-
-	public function __construct(SnapshotRepository $repository)
-	{
-		$this->repository = $repository;
-	}
-
-	public function index()
-	{
-		$snapshots = $this->repository->all();
-		return Response::json( $this->repository->APIFormat($snapshots), 200);
-	}
-
-	public function store()
-	{		
-		$snapshot = $this->repository->store( Input::all() );
-		return Response::json( ['id' => $snapshot->id], 200);
-	}
-
-	public function show($id)
-	{
-		$snapshot = $this->repository->get($id);
-		return Response::json($this->repository->APIFormat($snapshot), 200);
-	}
-
-	public function getCurrent()
-	{
-		$snapshot = $this->repository->current();
-		return Response::json($this->repository->APIFormat($snapshot), 200);
-	}
+    protected $repository;
+
+    public function __construct(SnapshotRepository $repository)
+    {
+        $this->repository = $repository;
+    }
+
+    public function index()
+    {
+        $snapshots = $this->repository->all();
+        return Response::json( $this->repository->APIFormat($snapshots), 200);
+    }
+
+    public function store()
+    {		
+        $snapshot = $this->repository->store( Input::all() );
+        return Response::json( ['id' => $snapshot->id], 200);
+    }
+
+    public function show($id)
+    {
+        $snapshot = $this->repository->get($id);
+        return Response::json($this->repository->APIFormat($snapshot), 200);
+    }
+
+    public function getCurrent()
+    {
+        $snapshot = $this->repository->current();
+        return Response::json($this->repository->APIFormat($snapshot), 200);
+    }
 
 }

Spacing +3 added lines, -3 removed lines

@@ -18,13 +18,13 @@
 	public function index()
 	{
 		$snapshots = $this->repository->all();
-		return Response::json( $this->repository->APIFormat($snapshots), 200);
+		return Response::json($this->repository->APIFormat($snapshots), 200);
 	}
 
 	public function store()
 	{		
-		$snapshot = $this->repository->store( Input::all() );
-		return Response::json( ['id' => $snapshot->id], 200);
+		$snapshot = $this->repository->store(Input::all());
+		return Response::json(['id' => $snapshot->id], 200);
 	}
 
 	public function show($id)

app/Repositories/UserRepository.php

Doc Comments +6 added lines

@@ -28,6 +28,9 @@ 
         }
     }
 
+    /**
+     * @param boolean $isActive
+     */
     public function allByStatus($isActive)
     {
         if (!is_bool($isActive)) {
@@ -98,6 +101,9 @@ 
         return $user;
     }
 
+    /**
+     * @return string|null
+     */
     public function changeRole($userId)
     {
         $user = $this->get($userId);

Spacing +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
             $user->delete();
         } catch (Exception $e) {
 
-            throw new RepositoryException('Database error #' . $e->getCode(), RepositoryException::DATABASE_ERROR);
+            throw new RepositoryException('Database error #'.$e->getCode(), RepositoryException::DATABASE_ERROR);
         }
 
         return $user;

Braces +3 added lines, -2 removed lines

@@ -206,8 +206,9 @@
     {
         $user = $this->get($userId);
 
-        if ($user->role == 'ADMN')
-            throw new RepositoryException('Cannot delete administrator', RepositoryException::RESOURCE_DENIED);
+        if ($user->role == 'ADMN') {
+                    throw new RepositoryException('Cannot delete administrator', RepositoryException::RESOURCE_DENIED);
+        }
 
         try {
             $user->delete();

app/Console/Commands/DatabaseFaker.php

Indentation +17 added lines, -17 removed lines

@@ -15,20 +15,20 @@ 
     const NB_USERS = 20;
     const MAX_NB_PRODUCTS = 9;
 
-	protected $name = 'db:faker';
-	protected $description = 'Seed the database with fake data for testing purposes';
+    protected $name = 'db:faker';
+    protected $description = 'Seed the database with fake data for testing purposes';
 
     private $faker;
 
-	public function __construct()
-	{
-		parent::__construct();
+    public function __construct()
+    {
+        parent::__construct();
 
         $this->faker = Factory::create();
-	}
+    }
 
-	public function fire()
-	{
+    public function fire()
+    {
         $this->error("\nWatch out!");
         $this->info('This command will truncate all your Barmate data.');
         $this->info("Use this command only for testing purposes.\n");
@@ -48,17 +48,17 @@ 
         $this->seedCategories($groupId);
 
         $this->info("\nFake data successfully created. Happy testing!");
-	}
+    }
 
-	protected function getArguments()
-	{
-		return [];
-	}
+    protected function getArguments()
+    {
+        return [];
+    }
 
-	protected function getOptions()
-	{
-		return [];
-	}
+    protected function getOptions()
+    {
+        return [];
+    }
 
     private function seedUsers($groupId)
     {

Spacing +8 added lines, -8 removed lines

@@ -33,7 +33,7 @@ 
         $this->info('This command will truncate all your Barmate data.');
         $this->info("Use this command only for testing purposes.\n");
 
-        if( $this->confirm('Are you sure you want to continue? ', false)==false )
+        if ($this->confirm('Are you sure you want to continue? ', false) == false)
         {
             $this->info('Command aborted');
             return 1;
@@ -62,20 +62,20 @@ 
 
     private function seedUsers($groupId)
     {
-        for($i=0; $i<self::NB_USERS; $i++)
+        for ($i = 0; $i<self::NB_USERS; $i++)
         {
             $firstName = $this->faker->firstName;
             $lastName = $this->faker->lastName;
             $email = strtolower($firstName.'.'.$lastName.'@'.$this->faker->domainName);
 
-            User::create([  'firstname'         => $firstName,
+            User::create(['firstname'         => $firstName,
                             'lastname'          => $lastName,
                             'group_id'          => $groupId,
                             'email'             => $email,
                             'password_hash'     => Hash::make('password'),
-                            'role'              => ( $i%2 == 0 ) ? 'USER' : 'MNGR',
+                            'role'              => ($i % 2 == 0) ? 'USER' : 'MNGR',
                             'inscription_date'  => $this->faker->dateTime,
-                            'is_active'         => ( $i%5 == 0 ) ? false : true ]);
+                            'is_active'         => ($i % 5 == 0) ? false : true]);
         }
 
         $this->info('Added '.self::NB_USERS.' users to the application with password \'password\'.');
@@ -88,20 +88,20 @@ 
         $categories = ['Saison', 'Gueuze', 'Tripel', 'Witbier', 'Dubbel'];
         shuffle($categories);
 
-        foreach($categories as $categoryName)
+        foreach ($categories as $categoryName)
         {
             $category = Categories::create(['group_id'          => $groupId,
                                             'category_title'    => $categoryName]);
 
             $nbProducts = rand(1, self::MAX_NB_PRODUCTS);
 
-            for($i=1; $i<=$nbProducts; $i++)
+            for ($i = 1; $i<=$nbProducts; $i++)
             {
                 Products::create(['category_id' => $category->category_id,
                                     'product_name' => $categoryName.''.$i,
                                     'description' => '',
                                     'price' => rand(1, 4),
-                                    'quantity' => rand(24,48)]);
+                                    'quantity' => rand(24, 48)]);
             }
         }
 

app/Console/Commands/Inspire.php

Indentation +21 added lines, -21 removed lines

@@ -5,28 +5,28 @@
 
 class Inspire extends Command {
 
-	/**
-	 * The console command name.
-	 *
-	 * @var string
-	 */
-	protected $name = 'inspire';
+    /**
+     * The console command name.
+     *
+     * @var string
+     */
+    protected $name = 'inspire';
 
-	/**
-	 * The console command description.
-	 *
-	 * @var string
-	 */
-	protected $description = 'Display an inspiring quote';
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Display an inspiring quote';
 
-	/**
-	 * Execute the console command.
-	 *
-	 * @return mixed
-	 */
-	public function handle()
-	{
-		$this->comment(PHP_EOL.Inspiring::quote().PHP_EOL);
-	}
+    /**
+     * Execute the console command.
+     *
+     * @return mixed
+     */
+    public function handle()
+    {
+        $this->comment(PHP_EOL.Inspiring::quote().PHP_EOL);
+    }
 
 }

app/Console/Kernel.php

Indentation +19 added lines, -19 removed lines

@@ -5,26 +5,26 @@
 
 class Kernel extends ConsoleKernel {
 
-	/**
-	 * The Artisan commands provided by your application.
-	 *
-	 * @var array
-	 */
-	protected $commands = [
-		'App\Console\Commands\Inspire',
+    /**
+     * The Artisan commands provided by your application.
+     *
+     * @var array
+     */
+    protected $commands = [
+        'App\Console\Commands\Inspire',
         'App\Console\Commands\DatabaseFaker'
-	];
+    ];
 
-	/**
-	 * Define the application's command schedule.
-	 *
-	 * @param  \Illuminate\Console\Scheduling\Schedule  $schedule
-	 * @return void
-	 */
-	protected function schedule(Schedule $schedule)
-	{
-		$schedule->command('inspire')
-				 ->hourly();
-	}
+    /**
+     * Define the application's command schedule.
+     *
+     * @param  \Illuminate\Console\Scheduling\Schedule  $schedule
+     * @return void
+     */
+    protected function schedule(Schedule $schedule)
+    {
+        $schedule->command('inspire')
+                    ->hourly();
+    }
 
 }

app/Http/Controllers/AccountController.php

Spacing +2 added lines, -2 removed lines

@@ -34,10 +34,10 @@
         try {
             $this->userRepository->updateAccount(auth()->id(), $request->all());
         }
-        catch(ValidationException $e) {
+        catch (ValidationException $e) {
             return redirect('app/account')->with('error', $e->getMessageBag()->first());
         }
-        catch(RepositoryException $e) {
+        catch (RepositoryException $e) {
             return redirect('app/account')->with('error', 'Could not update settings: '.strtolower($e->getMessage()));
         }
 

Braces +2 added lines, -4 removed lines

@@ -33,11 +33,9 @@
     {
         try {
             $this->userRepository->updateAccount(auth()->id(), $request->all());
-        }
-        catch(ValidationException $e) {
+        } catch(ValidationException $e) {
             return redirect('app/account')->with('error', $e->getMessageBag()->first());
-        }
-        catch(RepositoryException $e) {
+        } catch(RepositoryException $e) {
             return redirect('app/account')->with('error', 'Could not update settings: '.strtolower($e->getMessage()));
         }
 

app/Http/Controllers/CashController.php

Spacing +10 added lines, -10 removed lines

@@ -117,27 +117,27 @@ 
     private function approximateDuration(Carbon $oldSnapshotTime, Carbon $nextSnapshotTime)
     {
         $years = $oldSnapshotTime->diffInYears($nextSnapshotTime);
-        if( $years > 0 ) {
+        if ($years>0) {
             return ($years == 1) ? "1 year" : "$years years";
         }
 
         $months = $oldSnapshotTime->diffInMonths($nextSnapshotTime);
-        if($months > 0 ) {
+        if ($months>0) {
             return ($months == 1) ? "1 month" : "$months months";
         }
 
         $days = $oldSnapshotTime->diffInDays($nextSnapshotTime);
-        if ($days > 0) {
+        if ($days>0) {
             return ($days == 1) ? "1 day" : "$days days";
         }
 
         $hours = $oldSnapshotTime->diffInHours($nextSnapshotTime);
-        if ($hours > 0) {
+        if ($hours>0) {
             return ($hours == 1) ? "1 hour" : "$hours hours";
         }
 
         $minutes = $oldSnapshotTime->diffInMinutes($nextSnapshotTime);
-        if($minutes > 0) {
+        if ($minutes>0) {
             return ($minutes == 1) ? "1 minute" : "$minutes minutes";
         }
 
@@ -164,12 +164,12 @@ 
         try {
             $this->detailsRepository->store($operationData);
         } catch (RepositoryException $e) {
-            return Redirect::to('app/cash/register-operation')->with('error', 'Could not save operation: ' . $e->getMessage())
+            return Redirect::to('app/cash/register-operation')->with('error', 'Could not save operation: '.$e->getMessage())
                 ->withInput();
         }
 
-        $message = ($amount < 0) ? 'removed ' . abs($amount) . '&euro; from drawer' : 'added ' . $amount . '&euro; in drawer';
-        return Redirect::to('app/cash')->with('success', 'Cash operation saved: ' . $message);
+        $message = ($amount<0) ? 'removed '.abs($amount).'&euro; from drawer' : 'added '.$amount.'&euro; in drawer';
+        return Redirect::to('app/cash')->with('success', 'Cash operation saved: '.$message);
     }
 
     public function snapshotForm()
@@ -184,7 +184,7 @@ 
         try {
             $this->snapshotRepository->store(Input::all());
         } catch (RepositoryException $e) {
-            return Redirect::to('app/cash/new-snapshot')->with('error', 'Error while creating snapshot: ' . $e->getMessage())
+            return Redirect::to('app/cash/new-snapshot')->with('error', 'Error while creating snapshot: '.$e->getMessage())
                 ->withInput();
         }
 
@@ -215,7 +215,7 @@ 
             DB::commit();
 
         } catch (RepositoryException $e) {
-            return redirect('app/cash')->with('error', 'An error occurred: ' . strtolower($e->getMessage()));
+            return redirect('app/cash')->with('error', 'An error occurred: '.strtolower($e->getMessage()));
         }
 
         return redirect('app/cash')->with('success', "Snapshot item removed");

Braces +3 added lines, -1 removed lines

@@ -25,9 +25,11 @@
 
     public function dashboard($requestedSnapshot = null)
     {
-        if (isset($requestedSnapshot))     // Search snapshot in history
+        if (isset($requestedSnapshot)) {
+            // Search snapshot in history
         {
             $snapshot = $this->snapshotRepository->get($requestedSnapshot);
+        }
         } else    // Grab the current snapshot, or redirect if no one exists
         {
             try {