SAM-IT / react-smtp

src/Connection.php

Doc Comments +3 added lines

@@ -172,6 +172,9 @@
 
     }
 
+    /**
+     * @param integer $code
+     */
     protected function sendReply($code, $message, $close = false)
     {
         $out = '';

Unused Use Statements -2 removed lines

@@ -2,11 +2,9 @@
 namespace SamIT\React\Smtp;
 
 
-use React\Dns\Query\TimeoutException;
 use React\EventLoop\LoopInterface;
 use React\EventLoop\Timer\TimerInterface;
 use React\Socket\ConnectionInterface;
-use React\Stream\WritableStream;
 
 class Connection extends \React\Socket\Connection{
     const STATUS_NEW = 0;

Spacing +6 added lines, -6 removed lines

@@ -8,7 +8,7 @@ 
 use React\Socket\ConnectionInterface;
 use React\Stream\WritableStream;
 
-class Connection extends \React\Socket\Connection{
+class Connection extends \React\Socket\Connection {
     const STATUS_NEW = 0;
     const STATUS_INIT = 1;
     const STATUS_FROM = 2;
@@ -99,7 +99,7 @@ 
         $this->reset(self::STATUS_NEW);
         $this->on('line', [$this, 'handleCommand']);
         if ($this->bannerDelay > 0) {
-            $loop->addTimer($this->bannerDelay, function () use ($disconnect) {
+            $loop->addTimer($this->bannerDelay, function() use ($disconnect) {
                 $this->sendReply(220, $this->banner);
                 $this->removeListener('data', $disconnect);
             });
@@ -117,7 +117,7 @@ 
     {
         // Socket is raw, not using fread as it's interceptable by filters
         // See issues #192, #209, and #240
-        $data = stream_socket_recvfrom($stream, $this->bufferSize);;
+        $data = stream_socket_recvfrom($stream, $this->bufferSize); ;
 
         $limit = $this->state == self::STATUS_DATA ? 1000 : 512;
         if ('' !== $data && false !== $data) {
@@ -128,7 +128,7 @@ 
             }
 
             $delimiter = "\r\n";
-            while(false !== $pos = strpos($this->lineBuffer, $delimiter)) {
+            while (false !== $pos = strpos($this->lineBuffer, $delimiter)) {
                 $line = substr($this->lineBuffer, 0, $pos);
                 $this->lineBuffer = substr($this->lineBuffer, $pos + strlen($delimiter));
                 $this->emit('line', [$line, $this]);
@@ -158,7 +158,7 @@ 
 
     protected function handleCommand($line)
     {
-        if ($line !=='') {
+        if ($line !== '') {
             $command = $this->parseCommand($line);
             if ($command == null) {
                 $this->sendReply(500, "Unexpected or unknown command.");
@@ -177,7 +177,7 @@ 
         $out = '';
         if (is_array($message)) {
             $last = array_pop($message);
-            foreach($message as $line) {
+            foreach ($message as $line) {
                 $out .= "$code-$line\r\n";
             }
             $this->write($out);

src/MessageInterface.php

Doc Comments +3 added lines, -1 removed lines

@@ -25,18 +25,21 @@ 
     /**
      * This function will throw an exception since replacing headers is will mangle SMTP messages.
      * @throws \Exception
+     * @return \GuzzleHttp\Psr7\MessageTrait
      */
     public function withHeader($name, $value);
 
     /**
      * This function will throw an exception since removing headers is will mangle SMTP messages.
      * @throws \Exception
+     * @return \GuzzleHttp\Psr7\MessageTrait
      */
     public function withoutHeader($name);
 
     /**
      * This function will throw an exception since removing headers is will mangle SMTP messages.
      * @throws \Exception
+     * @return string
      */
     public function getHeaderLine($name);
 
@@ -96,7 +99,6 @@ 
      * new and/or updated header and value.
      *
      * @return self
-     * @param array $recipients Array of email => name pairs.
      * @throws \InvalidArgumentException for invalid email.
      */
     public function withAddedRecipient($email, $name = null);

src/MessageTrait.php

Doc Comments +4 added lines

@@ -11,6 +11,10 @@
         throw new \Exception('SMTP Message does not support replacing headers.');
     }
 
+    /**
+     * @param string $name
+     * @param string $value
+     */
     public function withAddedHeader($name, $value)
     {
         $new = clone $this;

Indentation +6 added lines, -6 removed lines

@@ -57,12 +57,12 @@
         return $this->withRecipients([$email => $name]);
     }
 
-   public function withRecipients(array $recipients)
-   {
-       $new = clone $this;
-       $new->recipients = $recipients;
-       return $new;
-   }
+    public function withRecipients(array $recipients)
+    {
+        $new = clone $this;
+        $new->recipients = $recipients;
+        return $new;
+    }
 
     public function withAddedRecipient($email, $name = null)
     {

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     {
         $result = [];
         $header = strtolower($header);
-        foreach($this->headers as list($name, $value)) {
+        foreach ($this->headers as list($name, $value)) {
             if ($header == strtolower($name)) {
                 $result[] = [$name, $value];
             }

src/RequestInterface.php

Doc Comments -1 removed lines

@@ -38,7 +38,6 @@
      * new and/or updated header and value.
      *
      * @return self
-     * @param array $recipients Array of email => name pairs.
      * @throws \InvalidArgumentException for invalid email.
      */
     public function withAddedRecipient($email, $name = null);

src/Server.php

Unused Use Statements -4 removed lines

@@ -2,11 +2,7 @@
 
 namespace SamIT\React\Smtp;
 
-use Evenement\EventEmitter;
 use React\EventLoop\LoopInterface;
-use React\Http\ServerInterface;
-use React\Socket\ServerInterface as SocketServerInterface;
-use React\Socket\ConnectionInterface;
 
 /** @event request */
 class Server extends \React\Socket\Server

src/Message.php

Indentation +1 added lines, -1 removed lines

@@ -3,5 +3,5 @@
 
 class Message implements MessageInterface
 {
-   use MessageTrait;
+    use MessageTrait;
 }
\ No newline at end of file

src/Request.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
     public function withAddedRecipients(array $recipients) 
     {
         $new = clone $this;
-        foreach($recipients as $email => $name) {
+        foreach ($recipients as $email => $name) {
             $this->validateEmail($email);
             $new->recipients[$email] = $name;
         }
@@ -46,7 +46,7 @@ 
     public function withRecipients(array $recipients) {
         $new = clone $this;
         $new->recipients = [];
-        foreach($recipients as $email => $name) {
+        foreach ($recipients as $email => $name) {
             $this->validateEmail($email);
             $new->recipients[$email] = $name;
         }