@@ -130,8 +130,7 @@ discard block |
||
| 130 | 130 | // Compare the current states with the set of valid states |
| 131 | 131 | if ($intersect) { |
| 132 | 132 | $remaining_states = array_intersect($current_states, $valid_states); |
| 133 | - } |
|
| 134 | - else { |
|
| 133 | + } else { |
|
| 135 | 134 | $remaining_states = array_diff($current_states, $valid_states); |
| 136 | 135 | } |
| 137 | 136 | |
@@ -139,8 +138,7 @@ discard block |
||
| 139 | 138 | // Unit is in a state that is within the set of valid states so add to result set |
| 140 | 139 | $units[$unit] = $unit; |
| 141 | 140 | $response->addMatch($keyed_units[$unit], CalendarResponse::VALID_STATE); |
| 142 | - } |
|
| 143 | - else { |
|
| 141 | + } else { |
|
| 144 | 142 | $response->addMiss($keyed_units[$unit], CalendarResponse::INVALID_STATE); |
| 145 | 143 | } |
| 146 | 144 | |
@@ -234,8 +232,7 @@ discard block |
||
| 234 | 232 | foreach ($days as $day => $value) { |
| 235 | 233 | $result[$year][$month][$day] = ((int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day]); |
| 236 | 234 | } |
| 237 | - } |
|
| 238 | - else { |
|
| 235 | + } else { |
|
| 239 | 236 | foreach ($days as $day => $value) { |
| 240 | 237 | $result[$year][$month][$day] = $keyed_units[$unit]->getDefaultValue(); |
| 241 | 238 | } |
@@ -266,8 +263,7 @@ discard block |
||
| 266 | 263 | foreach ($hours as $hour => $value) { |
| 267 | 264 | if (isset($db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour])) { |
| 268 | 265 | $result[$year][$month][$day][$hour] = ((int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]); |
| 269 | - } |
|
| 270 | - else { |
|
| 266 | + } else { |
|
| 271 | 267 | // If nothing from db - then revert to the defaults |
| 272 | 268 | $result[$year][$month][$day][$hour] = (int) $keyed_units[$unit]->getDefaultValue(); |
| 273 | 269 | } |
@@ -315,8 +311,7 @@ discard block |
||
| 315 | 311 | foreach ($minutes as $minute => $value) { |
| 316 | 312 | if (isset($db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute])) { |
| 317 | 313 | $result[$year][$month][$day][$hour][$minute] = ((int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]); |
| 318 | - } |
|
| 319 | - else { |
|
| 314 | + } else { |
|
| 320 | 315 | // If nothing from db - then revert to the defaults |
| 321 | 316 | $result[$year][$month][$day][$hour][$minute] = (int) $keyed_units[$unit]->getDefaultValue(); |
| 322 | 317 | } |
@@ -365,8 +360,12 @@ discard block |
||
| 365 | 360 | |
| 366 | 361 | // Make sure years are sorted |
| 367 | 362 | ksort($data[Event::BAT_DAY]); |
| 368 | - if (isset($data[Event::BAT_HOUR])) ksort($data[Event::BAT_HOUR]); |
|
| 369 | - if (isset($data[Event::BAT_MINUTE])) ksort($data[Event::BAT_MINUTE]); |
|
| 363 | + if (isset($data[Event::BAT_HOUR])) { |
|
| 364 | + ksort($data[Event::BAT_HOUR]); |
|
| 365 | + } |
|
| 366 | + if (isset($data[Event::BAT_MINUTE])) { |
|
| 367 | + ksort($data[Event::BAT_MINUTE]); |
|
| 368 | + } |
|
| 370 | 369 | |
| 371 | 370 | // Set up variables to keep track of stuff |
| 372 | 371 | $current_value = NULL; |
@@ -391,8 +390,7 @@ discard block |
||
| 391 | 390 | if ($current_value === $minute_value) { |
| 392 | 391 | // We are still in minutes and going through so add a minute |
| 393 | 392 | $end_event->add(new \DateInterval('PT1M')); |
| 394 | - } |
|
| 395 | - elseif (($current_value != $minute_value) && ($current_value !== NULL)) { |
|
| 393 | + } elseif (($current_value != $minute_value) && ($current_value !== NULL)) { |
|
| 396 | 394 | // Value just switched - let us wrap up with current event and start a new one |
| 397 | 395 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
| 398 | 396 | $start_event = clone($end_event->add(new \DateInterval('PT1M'))); |
@@ -406,12 +404,10 @@ discard block |
||
| 406 | 404 | } |
| 407 | 405 | $current_value = $minute_value; |
| 408 | 406 | } |
| 409 | - } |
|
| 410 | - elseif ($current_value === $hour_value) { |
|
| 407 | + } elseif ($current_value === $hour_value) { |
|
| 411 | 408 | // We are in hours and can add something |
| 412 | 409 | $end_event->add(new \DateInterval('PT1H')); |
| 413 | - } |
|
| 414 | - elseif (($current_value != $hour_value) && ($current_value !== NULL)) { |
|
| 410 | + } elseif (($current_value != $hour_value) && ($current_value !== NULL)) { |
|
| 415 | 411 | // Value just switched - let us wrap up with current event and start a new one |
| 416 | 412 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
| 417 | 413 | // Start event becomes the end event with a minute added |
@@ -428,12 +424,10 @@ discard block |
||
| 428 | 424 | $current_value = $hour_value; |
| 429 | 425 | } |
| 430 | 426 | } |
| 431 | - } |
|
| 432 | - elseif ($current_value === $value) { |
|
| 427 | + } elseif ($current_value === $value) { |
|
| 433 | 428 | // We are adding a whole day so the end event gets moved to the end of the day we are adding |
| 434 | 429 | $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . '23:59'); |
| 435 | - } |
|
| 436 | - elseif (($current_value !== $value) && ($current_value !== NULL)) { |
|
| 430 | + } elseif (($current_value !== $value) && ($current_value !== NULL)) { |
|
| 437 | 431 | // Value just switched - let us wrap up with current event and start a new one |
| 438 | 432 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
| 439 | 433 | // Start event becomes the end event with a minute added |
@@ -468,8 +462,7 @@ discard block |
||
| 468 | 462 | if ($event->endsLater($end_date)) { |
| 469 | 463 | $event->setEndDate($end_date); |
| 470 | 464 | } |
| 471 | - } |
|
| 472 | - else { |
|
| 465 | + } else { |
|
| 473 | 466 | // Event completely not in range so unset it |
| 474 | 467 | unset($normalized_events[$unit_id][$key]); |
| 475 | 468 | } |
@@ -500,8 +493,7 @@ discard block |
||
| 500 | 493 | $e++; |
| 501 | 494 | $flipped[$e][$value][$datum] = $datum; |
| 502 | 495 | $old_value = $value; |
| 503 | - } |
|
| 504 | - else { |
|
| 496 | + } else { |
|
| 505 | 497 | $flipped[$e][$value][$datum] = $datum; |
| 506 | 498 | } |
| 507 | 499 | } |