@@ -174,7 +174,7 @@ discard block  | 
                                                    ||
| 174 | 174 | // Create a mock itemized event for the period in question - since event data is either  | 
                                                        
| 175 | 175 | // in the database or the default value we first create a mock event and then fill it in  | 
                                                        
| 176 | 176 | // accordingly  | 
                                                        
| 177 | - $mock_event = new Event($start_date, $end_date, new Unit(0,0), $this->default_value);  | 
                                                        |
| 177 | + $mock_event = new Event($start_date, $end_date, new Unit(0, 0), $this->default_value);  | 
                                                        |
| 178 | 178 | $itemized = $mock_event->itemize(new EventItemizer($mock_event, $granularity));  | 
                                                        
| 179 | 179 | |
| 180 | 180 | // Cycle through each unit retrieved and provide it with a fully configured itemized mock event  | 
                                                        
@@ -265,11 +265,11 @@ discard block  | 
                                                    ||
| 265 | 265 |            foreach ($days as $day => $hours) { | 
                                                        
| 266 | 266 |              foreach ($hours as $hour => $value) { | 
                                                        
| 267 | 267 |                if (isset($db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour])) { | 
                                                        
| 268 | - $result[$year][$month][$day][$hour] = ((int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]);  | 
                                                        |
| 268 | + $result[$year][$month][$day][$hour] = ((int)$db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]);  | 
                                                        |
| 269 | 269 | }  | 
                                                        
| 270 | 270 |                else { | 
                                                        
| 271 | 271 | // If nothing from db - then revert to the defaults  | 
                                                        
| 272 | - $result[$year][$month][$day][$hour] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 272 | + $result[$year][$month][$day][$hour] = (int)$keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 273 | 273 | }  | 
                                                        
| 274 | 274 | }  | 
                                                        
| 275 | 275 | }  | 
                                                        
@@ -283,7 +283,7 @@ discard block  | 
                                                    ||
| 283 | 283 |          foreach ($months as $month => $days) { | 
                                                        
| 284 | 284 |            foreach ($days as $day => $hours) { | 
                                                        
| 285 | 285 |              foreach ($hours as $hour => $value) { | 
                                                        
| 286 | - $result[$year][$month][$day][$hour] = ((int) $value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $value);  | 
                                                        |
| 286 | + $result[$year][$month][$day][$hour] = ((int)$value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$value);  | 
                                                        |
| 287 | 287 | }  | 
                                                        
| 288 | 288 | ksort($result[$year][$month][$day], SORT_NATURAL);  | 
                                                        
| 289 | 289 | }  | 
                                                        
@@ -314,11 +314,11 @@ discard block  | 
                                                    ||
| 314 | 314 |              foreach ($hours as $hour => $minutes) { | 
                                                        
| 315 | 315 |                foreach ($minutes as $minute => $value) { | 
                                                        
| 316 | 316 |                  if (isset($db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute])) { | 
                                                        
| 317 | - $result[$year][$month][$day][$hour][$minute] = ((int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]);  | 
                                                        |
| 317 | + $result[$year][$month][$day][$hour][$minute] = ((int)$db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]);  | 
                                                        |
| 318 | 318 | }  | 
                                                        
| 319 | 319 |                  else { | 
                                                        
| 320 | 320 | // If nothing from db - then revert to the defaults  | 
                                                        
| 321 | - $result[$year][$month][$day][$hour][$minute] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 321 | + $result[$year][$month][$day][$hour][$minute] = (int)$keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 322 | 322 | }  | 
                                                        
| 323 | 323 | }  | 
                                                        
| 324 | 324 | }  | 
                                                        
@@ -334,7 +334,7 @@ discard block  | 
                                                    ||
| 334 | 334 |            foreach ($days as $day => $hours) { | 
                                                        
| 335 | 335 |              foreach ($hours as $hour => $minutes) { | 
                                                        
| 336 | 336 |                foreach ($minutes as $minute => $value) { | 
                                                        
| 337 | - $result[$year][$month][$day][$hour][$minute] = ((int) $value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $value);  | 
                                                        |
| 337 | + $result[$year][$month][$day][$hour][$minute] = ((int)$value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$value);  | 
                                                        |
| 338 | 338 | }  | 
                                                        
| 339 | 339 | ksort($result[$year][$month][$day][$hour], SORT_NATURAL);  | 
                                                        
| 340 | 340 | }  | 
                                                        
@@ -396,12 +396,12 @@ discard block  | 
                                                    ||
| 396 | 396 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 397 | 397 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 398 | 398 |                        $start_event = clone($end_event->add(new \DateInterval('PT1M'))); | 
                                                        
| 399 | - $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute,1));  | 
                                                        |
| 399 | + $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute, 1));  | 
                                                        |
| 400 | 400 | $current_value = $minute_value;  | 
                                                        
| 401 | 401 | }  | 
                                                        
| 402 | 402 |                      if ($current_value === NULL) { | 
                                                        
| 403 | 403 | // We are down to minutes and haven't created and event yet - do one now  | 
                                                        
| 404 | - $start_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute,1));  | 
                                                        |
| 404 | + $start_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute, 1));  | 
                                                        |
| 405 | 405 | $end_event = clone($start_event);  | 
                                                        
| 406 | 406 | }  | 
                                                        
| 407 | 407 | $current_value = $minute_value;  | 
                                                        
@@ -544,7 +544,7 @@ discard block  | 
                                                    ||
| 544 | 544 | * @return Unit  | 
                                                        
| 545 | 545 | */  | 
                                                        
| 546 | 546 |    protected function getUnit($unit_id) { | 
                                                        
| 547 | - $keyed = $this->keyUnitsById();  | 
                                                        |
| 547 | + $keyed = $this->keyUnitsById();  | 
                                                        |
| 548 | 548 | return $keyed[$unit_id];  | 
                                                        
| 549 | 549 | }  | 
                                                        
| 550 | 550 | |
@@ -130,8 +130,7 @@ discard block  | 
                                                    ||
| 130 | 130 | // Compare the current states with the set of valid states  | 
                                                        
| 131 | 131 |        if ($intersect) { | 
                                                        
| 132 | 132 | $remaining_states = array_intersect($current_states, $valid_states);  | 
                                                        
| 133 | - }  | 
                                                        |
| 134 | -      else { | 
                                                        |
| 133 | +      } else { | 
                                                        |
| 135 | 134 | $remaining_states = array_diff($current_states, $valid_states);  | 
                                                        
| 136 | 135 | }  | 
                                                        
| 137 | 136 | |
@@ -139,8 +138,7 @@ discard block  | 
                                                    ||
| 139 | 138 | // Unit is in a state that is within the set of valid states so add to result set  | 
                                                        
| 140 | 139 | $units[$unit] = $unit;  | 
                                                        
| 141 | 140 | $response->addMatch($keyed_units[$unit], CalendarResponse::VALID_STATE);  | 
                                                        
| 142 | - }  | 
                                                        |
| 143 | -      else { | 
                                                        |
| 141 | +      } else { | 
                                                        |
| 144 | 142 | $response->addMiss($keyed_units[$unit], CalendarResponse::INVALID_STATE);  | 
                                                        
| 145 | 143 | }  | 
                                                        
| 146 | 144 | |
@@ -234,8 +232,7 @@ discard block  | 
                                                    ||
| 234 | 232 |            foreach ($days as $day => $value) { | 
                                                        
| 235 | 233 | $result[$year][$month][$day] = ((int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day]);  | 
                                                        
| 236 | 234 | }  | 
                                                        
| 237 | - }  | 
                                                        |
| 238 | -        else { | 
                                                        |
| 235 | +        } else { | 
                                                        |
| 239 | 236 |            foreach ($days as $day => $value) { | 
                                                        
| 240 | 237 | $result[$year][$month][$day] = $keyed_units[$unit]->getDefaultValue();  | 
                                                        
| 241 | 238 | }  | 
                                                        
@@ -266,8 +263,7 @@ discard block  | 
                                                    ||
| 266 | 263 |              foreach ($hours as $hour => $value) { | 
                                                        
| 267 | 264 |                if (isset($db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour])) { | 
                                                        
| 268 | 265 | $result[$year][$month][$day][$hour] = ((int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]);  | 
                                                        
| 269 | - }  | 
                                                        |
| 270 | -              else { | 
                                                        |
| 266 | +              } else { | 
                                                        |
| 271 | 267 | // If nothing from db - then revert to the defaults  | 
                                                        
| 272 | 268 | $result[$year][$month][$day][$hour] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        
| 273 | 269 | }  | 
                                                        
@@ -315,8 +311,7 @@ discard block  | 
                                                    ||
| 315 | 311 |                foreach ($minutes as $minute => $value) { | 
                                                        
| 316 | 312 |                  if (isset($db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute])) { | 
                                                        
| 317 | 313 | $result[$year][$month][$day][$hour][$minute] = ((int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]);  | 
                                                        
| 318 | - }  | 
                                                        |
| 319 | -                else { | 
                                                        |
| 314 | +                } else { | 
                                                        |
| 320 | 315 | // If nothing from db - then revert to the defaults  | 
                                                        
| 321 | 316 | $result[$year][$month][$day][$hour][$minute] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        
| 322 | 317 | }  | 
                                                        
@@ -391,8 +386,7 @@ discard block  | 
                                                    ||
| 391 | 386 |                      if ($current_value === $minute_value) { | 
                                                        
| 392 | 387 | // We are still in minutes and going through so add a minute  | 
                                                        
| 393 | 388 |                        $end_event->add(new \DateInterval('PT1M')); | 
                                                        
| 394 | - }  | 
                                                        |
| 395 | -                    elseif (($current_value != $minute_value) && ($current_value !== NULL)) { | 
                                                        |
| 389 | +                    } elseif (($current_value != $minute_value) && ($current_value !== NULL)) { | 
                                                        |
| 396 | 390 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 397 | 391 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 398 | 392 |                        $start_event = clone($end_event->add(new \DateInterval('PT1M'))); | 
                                                        
@@ -406,12 +400,10 @@ discard block  | 
                                                    ||
| 406 | 400 | }  | 
                                                        
| 407 | 401 | $current_value = $minute_value;  | 
                                                        
| 408 | 402 | }  | 
                                                        
| 409 | - }  | 
                                                        |
| 410 | -                elseif ($current_value === $hour_value) { | 
                                                        |
| 403 | +                } elseif ($current_value === $hour_value) { | 
                                                        |
| 411 | 404 | // We are in hours and can add something  | 
                                                        
| 412 | 405 |                    $end_event->add(new \DateInterval('PT1H')); | 
                                                        
| 413 | - }  | 
                                                        |
| 414 | -                elseif (($current_value != $hour_value) && ($current_value !== NULL)) { | 
                                                        |
| 406 | +                } elseif (($current_value != $hour_value) && ($current_value !== NULL)) { | 
                                                        |
| 415 | 407 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 416 | 408 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 417 | 409 | // Start event becomes the end event with a minute added  | 
                                                        
@@ -428,12 +420,10 @@ discard block  | 
                                                    ||
| 428 | 420 | $current_value = $hour_value;  | 
                                                        
| 429 | 421 | }  | 
                                                        
| 430 | 422 | }  | 
                                                        
| 431 | - }  | 
                                                        |
| 432 | -            elseif ($current_value === $value) { | 
                                                        |
| 423 | +            } elseif ($current_value === $value) { | 
                                                        |
| 433 | 424 | // We are adding a whole day so the end event gets moved to the end of the day we are adding  | 
                                                        
| 434 | 425 | $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . '23:59');  | 
                                                        
| 435 | - }  | 
                                                        |
| 436 | -            elseif (($current_value !== $value) && ($current_value !== NULL)) { | 
                                                        |
| 426 | +            } elseif (($current_value !== $value) && ($current_value !== NULL)) { | 
                                                        |
| 437 | 427 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 438 | 428 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 439 | 429 | // Start event becomes the end event with a minute added  | 
                                                        
@@ -468,8 +458,7 @@ discard block  | 
                                                    ||
| 468 | 458 |            if ($event->endsLater($end_date)) { | 
                                                        
| 469 | 459 | $event->setEndDate($end_date);  | 
                                                        
| 470 | 460 | }  | 
                                                        
| 471 | - }  | 
                                                        |
| 472 | -        else { | 
                                                        |
| 461 | +        } else { | 
                                                        |
| 473 | 462 | // Event completely not in range so unset it  | 
                                                        
| 474 | 463 | unset($normalized_events[$unit_id][$key]);  | 
                                                        
| 475 | 464 | }  | 
                                                        
@@ -500,8 +489,7 @@ discard block  | 
                                                    ||
| 500 | 489 | $e++;  | 
                                                        
| 501 | 490 | $flipped[$e][$value][$datum] = $datum;  | 
                                                        
| 502 | 491 | $old_value = $value;  | 
                                                        
| 503 | - }  | 
                                                        |
| 504 | -        else { | 
                                                        |
| 492 | +        } else { | 
                                                        |
| 505 | 493 | $flipped[$e][$value][$datum] = $datum;  | 
                                                        
| 506 | 494 | }  | 
                                                        
| 507 | 495 | }  |